[jira] [Updated] (JSPWIKI-1146) Add AWS Kendra as a Search Provider
[ https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Masnada updated JSPWIKI-1146: Attachment: KendraSearchProvider.zip > Add AWS Kendra as a Search Provider > --- > > Key: JSPWIKI-1146 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1146 > Project: JSPWiki > Issue Type: New Feature > Components: Search >Affects Versions: 2.11.0-M8 >Reporter: Julien Masnada >Priority: Minor > Labels: features, pull-request-available > Attachments: KendraSearchProvider.zip > > > We use AWS Kendra a central search tool in our organization to provide a > search result that can span different Data Source (DB, Sharepoint, etc). > Since we have a lot of documents in our Wiki, it is interesting for us to be > able to index (in Kendra) and search pages and attachments from our wiki. > Furthermore it is important to be able to search in attachments that are in > PDF / Word / PPT or HTML format also. > We have implemented a SearchProvider that does the job of indexing and > returning search result. The code is available in > [https://github.com/rostskadat/jspwiki] > Some further documentation is available in the README. > I would appreciate if you could direct me toward a document explaining the > process for requesting the inclusion of this feature > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] dependabot[bot] closed pull request #41: Bump jetty-all from 9.4.35.v20201120 to 9.4.37.v20210219
dependabot[bot] closed pull request #41: URL: https://github.com/apache/jspwiki/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] dependabot[bot] opened a new pull request #45: Bump jetty-all from 9.4.35.v20201120 to 9.4.38.v20210224
dependabot[bot] opened a new pull request #45: URL: https://github.com/apache/jspwiki/pull/45 Bumps jetty-all from 9.4.35.v20201120 to 9.4.38.v20210224. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] dependabot[bot] commented on pull request #41: Bump jetty-all from 9.4.35.v20201120 to 9.4.37.v20210219
dependabot[bot] commented on pull request #41: URL: https://github.com/apache/jspwiki/pull/41#issuecomment-787754826 Superseded by #45. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JSPWIKI-1146) Add AWS Kendra as a Search Provider
[ https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292721#comment-17292721 ] Julien Masnada commented on JSPWIKI-1146: - Hello [~juanpablo] No worries. # I did create an account at jspwiki-wiki.a.o and tried to create a page with *just* the text "KendraSearchProvider" (literally). The spam filter does not even accept that. It is a little bit ridiculous :). I attached to this issue a stub page with its attached documents in case the spam filter let *you* pass... I will complete the page with the Docker part once I can edit the Page on jspwiki-wiki.a.o # The json file has been added to the maven-rat-plugin configuration # I removed the use of Awaitility. It is true that most of the code is boilerplate... However most line do need to be used to mock the Kendra API client, there are no real solution around that. I tried to make the test code as readable as possible using annotations, but it is still heavy to read. If you don't mind, once you checked that the wiki page provides the necessary information and that I am able to edit it and complete it, I will remove the following files (not before): * jspwiki-kendra-searchprovider/cloudformation* * jspwiki-kendra-searchprovider/docker-files/jspwiki-custom.properties * jspwiki-kendra-searchprovider/docs/images/* * jspwiki-kendra-searchprovider/Dockerfile * jspwiki-kendra-searchprovider/README.md => Allow them to stay in the source repository until the spam filter issue has been resolved. Thanks for your feedback > Add AWS Kendra as a Search Provider > --- > > Key: JSPWIKI-1146 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1146 > Project: JSPWiki > Issue Type: New Feature > Components: Search >Affects Versions: 2.11.0-M8 >Reporter: Julien Masnada >Priority: Minor > Labels: features, pull-request-available > Attachments: KendraSearchProvider.zip > > > We use AWS Kendra a central search tool in our organization to provide a > search result that can span different Data Source (DB, Sharepoint, etc). > Since we have a lot of documents in our Wiki, it is interesting for us to be > able to index (in Kendra) and search pages and attachments from our wiki. > Furthermore it is important to be able to search in attachments that are in > PDF / Word / PPT or HTML format also. > We have implemented a SearchProvider that does the job of indexing and > returning search result. The code is available in > [https://github.com/rostskadat/jspwiki] > Some further documentation is available in the README. > I would appreciate if you could direct me toward a document explaining the > process for requesting the inclusion of this feature > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JSPWIKI-1146) Add AWS Kendra as a Search Provider
[ https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293180#comment-17293180 ] Juan Pablo Santos Rodríguez commented on JSPWIKI-1146: -- Hi [~rostskadat], thanks for following this through! The documentation is available at https://jspwiki-wiki.apache.org/Wiki.jsp?page=KendraSearchProvider :-) you should be able to edit the page, don't know without looking at the logs, but perhaps before you tried to make too many changes on a given interval of time, or the hostname / ip was marked as making too may changes... I agree that right now is too restrictive, hopefully we'll have it fixed for next release best regards, juan pablo > Add AWS Kendra as a Search Provider > --- > > Key: JSPWIKI-1146 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1146 > Project: JSPWiki > Issue Type: New Feature > Components: Search >Affects Versions: 2.11.0-M8 >Reporter: Julien Masnada >Priority: Minor > Labels: features, pull-request-available > Attachments: KendraSearchProvider.zip > > > We use AWS Kendra a central search tool in our organization to provide a > search result that can span different Data Source (DB, Sharepoint, etc). > Since we have a lot of documents in our Wiki, it is interesting for us to be > able to index (in Kendra) and search pages and attachments from our wiki. > Furthermore it is important to be able to search in attachments that are in > PDF / Word / PPT or HTML format also. > We have implemented a SearchProvider that does the job of indexing and > returning search result. The code is available in > [https://github.com/rostskadat/jspwiki] > Some further documentation is available in the README. > I would appreciate if you could direct me toward a document explaining the > process for requesting the inclusion of this feature > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #44: JSPWIKI-1117
juanpablo-santos commented on a change in pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#discussion_r585068939
##
File path:
jspwiki-main/src/main/java/org/apache/wiki/preferences/Preferences.java
##
@@ -125,19 +133,21 @@ public static void reloadPreferences( final PageContext
pageContext ) {
* @param request
* @param prefs The default hashmap of preferences
*/
- private static void parseJSONPreferences( final HttpServletRequest
request, final Preferences prefs ) {
-final String prefVal = TextUtil.urlDecodeUTF8(
HttpUtil.retrieveCookieValue( request, "JSPWikiUserPrefs" ) );
-if( prefVal != null ) {
+ private static void parseJSONPreferences( final Preferences prefs,
final String prefVal ) {
Review comment:
it would be nice if this method is made package-private, so some unit
tests defining its behaviour can be made. The alternative would be unit testing
the `reloadPreferences` method, but the first approach seems easier.
##
File path: jspwiki-war/src/main/webapp/templates/default/commonheader.jsp
##
@@ -156,4 +177,76 @@ String.I18N.PREFIX = "javascript.";
src="" >
+
+
+<%-- Support for cookie acceptance --%>
+
+
