[GitHub] [jspwiki] juanpablo-santos merged pull request #32: [JSPWIKI-1142] - Minor performances improvement:
juanpablo-santos merged pull request #32: URL: https://github.com/apache/jspwiki/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JSPWIKI-1142) Minor performances improvement
[ https://issues.apache.org/jira/browse/JSPWIKI-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262811#comment-17262811 ] ASF subversion and git services commented on JSPWIKI-1142: -- Commit abb5666f180efd0a7f14267a2f7bd1673ced2dc4 in jspwiki's branch refs/heads/master from Arturo Bernal [ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=abb5666 ] JSPWIKI-1142 - Minor performances improvement: * Remove redundant initializer * Redundant interface modifier --> Not really performance * Remove Unused import * Bulk operation can be used instead of iteration * Manual array copy * Manual array to collection copy * Avoid String concatenation in loop * Redundant 'Collection.addAll()' call. Use Parametrized constructor. > Minor performances improvement > -- > > Key: JSPWIKI-1142 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1142 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > Labels: pull-request-available > > > * Remove redundant initializer > * Redundant interface modifier --> Not really performance ;) > * Remove Unused import > * Bulk operation can be used instead of iteration > * Manual array copy > * Manual array to collection copy > * Avoid String concatenation in loop > * Redundant 'Collection.addAll()' call. Use Parametrized constructor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (JSPWIKI-1143) Allow SpamFilter to exclude certain users/groups from checks
Juan Pablo Santos Rodríguez created JSPWIKI-1143: Summary: Allow SpamFilter to exclude certain users/groups from checks Key: JSPWIKI-1143 URL: https://issues.apache.org/jira/browse/JSPWIKI-1143 Project: JSPWiki Issue Type: Improvement Components: Filters Reporter: Juan Pablo Santos Rodríguez SpamFilter currently does not perform any check on an incoming Edit if it has been made by an Administrator. It would be nice if it could also exclude certain groups/users from the checks, configurable through the jspwiki.properties file (f.ex., from a comma separated list of user/group ids). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JSPWIKI-1142) Minor performance improvements
[ https://issues.apache.org/jira/browse/JSPWIKI-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Pablo Santos Rodríguez updated JSPWIKI-1142: - Summary: Minor performance improvements (was: Minor performances improvement) > Minor performance improvements > -- > > Key: JSPWIKI-1142 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1142 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > Labels: pull-request-available > > > * Remove redundant initializer > * Redundant interface modifier --> Not really performance ;) > * Remove Unused import > * Bulk operation can be used instead of iteration > * Manual array copy > * Manual array to collection copy > * Avoid String concatenation in loop > * Redundant 'Collection.addAll()' call. Use Parametrized constructor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (JSPWIKI-1142) Minor performance improvements
[ https://issues.apache.org/jira/browse/JSPWIKI-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Pablo Santos Rodríguez resolved JSPWIKI-1142. -- Resolution: Fixed merged in 2.11.0-git-03 - thanks! (btw you may want to take a look at JSPWIKI-1143, it's perfect for newcomers :-)) > Minor performance improvements > -- > > Key: JSPWIKI-1142 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1142 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > Labels: pull-request-available > > > * Remove redundant initializer > * Redundant interface modifier --> Not really performance ;) > * Remove Unused import > * Bulk operation can be used instead of iteration > * Manual array copy > * Manual array to collection copy > * Avoid String concatenation in loop > * Redundant 'Collection.addAll()' call. Use Parametrized constructor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[DRAFT] 2021-01 Board report
Hi, as usual, below is a draft for this quarter's Board report. Reviews, comments, edits, etc. are most welcome! best regards, juan pablo -- Forwarded message - From: Date: Mon, Jan 11, 2021 at 9:18 PM Subject: [jspwiki-asf-docs] branch master updated: DRAFT for 2021-01 Board report To: comm...@jspwiki.apache.org This is an automated email from the ASF dual-hosted git repository. juanpablo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jspwiki-asf-docs.git The following commit(s) were added to refs/heads/master by this push: new 6e16989 DRAFT for 2021-01 Board report 6e16989 is described below commit 6e1698914b2c8ba4cdf2d3eb3b9779f0cb1a3bad Author: Juan Pablo Santos Rodríguez AuthorDate: Mon Jan 11 21:17:24 2021 +0100 DRAFT for 2021-01 Board report --- board-reports/2021-01.txt | 41 + 1 file changed, 41 insertions(+) diff --git a/board-reports/2021-01.txt b/board-reports/2021-01.txt new file mode 100755 index 000..68b3bb9 --- /dev/null +++ b/board-reports/2021-01.txt @@ -0,0 +1,41 @@ +## Description: +The mission of JSPWiki is the creation and maintenance of software related to +Leading open source WikiWiki engine, feature-rich and built around standard +JEE components (Java, servlets, JSP). + +## Issues: +There are no issues requiring board attention. + +## Membership Data: +Apache JSPWiki was founded 2013-07-17 (7 years ago) +There are currently 14 committers and 10 PMC members in this project. +The Committer-to-PMC ratio is 7:5. + +Community changes, past quarter: +- No new PMC members. Last addition was Dave Koelmeyer on 2016-04-06. + Murray Altheim requested (Jan 5, 2021) to step down as PMC member due to + being inactive for a long time. +- No new committers. Last addition was Dave Koelmeyer on 2016-04-06. + Murray Altheim requested (Jan 5, 2021) to step down as committer due to + being inactive for a long time. + +## Project Activity: +2.11.0.M8 was released on 2020-12-13, which featured fixes for problems +on Searches and Workflows' persistence on disk, introduced on 2.11.0.M7. + +This release also contained features provided by community members: +completed translations for french and german, and another patch reworking +a previous fix in one of the plugins bundled with JSPWiki. + +After 2.11.0.M8, activity has been focused on attending several PRs +created by the dependabot (dependabot configuration was provided by another +contributor). We also got a contribution regarding the official documentation, +where the Docker page got a big rework. + +2.11.0 should be the next planned release. + +## Community Health: +There's enough project oversight, although project activity is low. + +We are looking for some continuity on previously noted contributors, as they +may end up becoming potential PMC members / committers. \ No newline at end of file
Re: Proposed Docker page rework
Hi,
apologies for the late reply, but yes, of course is ok, whatever page you
see needs some extra-care please go and edit it :-)
Re. the Docker page, I've seen you've already made some edits, I've made a
sweep and fixed a big bunch, should be (mostly) ok now.. If there's
something left to fix, also feel free to edit it
thx for looking into this!
br,
juan pablo
On Sun, Jan 3, 2021 at 4:29 PM Carl Marcum wrote:
> It looks like there are quite a few non-printable characters causing
> unwanted line-wrapping.
>
> If I try to fix more than a few at a time I'm getting caught by the spam
> filter.
> If I keep fixing them there are going to be a lot of page versions.
> Is that okay?
>
> Thanks,
> Carl
>
> On 1/1/21 2:42 PM, Juan Pablo Santos Rodríguez wrote:
>
> Hi Carl,
>
> the suggested rework looked good to me, so I've just went and posted it at
> jspwiki-wiki.a.o; if needed, we can continue the rework later on.. I've
> only added the
> PageViewPlugin at the end, so that the page shows up at the SystemInfo
> one. The changes can be seen at
> https://jspwiki-wiki.apache.org/Diff.jsp?page=Docker&r1=22&r2=21
>
>
> best regards & happy new year!!
> juan pablo
>
> On Mon, Dec 28, 2020 at 2:08 PM Carl Marcum wrote:
>
>> Hi All,
>>
>> To avoid the spam filter for such a large change see below for the
>> proposed page contents.
>> The references to the previous image on Docker Hub will need replaced
>> when you have the new one ready.
>> I'd be happy to make the edit.
>>
>> The major changes are the that the image has changed a lot since the
>> metskem/docker-jspwikiused on the current page so I described the new
>> one somewhat.
>>
>> In addition to using the pre-built image I added how to build your own
>> and added a example of how you can customize it based on CentOS or
>> Amazon Linux and the Corretto JDK which I did for mine.
>>
>> In the persisting data section I added how to seed the volume directory
>> with the default pages.
>>
>> If you would like to use it or have any changes please let me know.
>>
>> Best regards,
>> Carl
>>
>> Begin
>>
>> !!! JSPWiki for Docker
>>
>> JSPWiki can be used with [Docker|https://docs.docker.com]. Docker images
>> can be built from source or you can use a pre-built official image.
>>
>> [{TableOfContents }]
>>
>>
>> !! Default Image
>>
>> The default JSPWiki Docker image uses the official Docker Community
>> supported [Apache Tomcat 9
>> image|
>> https://github.com/docker-library/tomcat/blob/b9416beec5364c00694595d6f3c61b09e764113c/9.0/jdk11/openjdk-buster/Dockerfile]
>>
>> which is based on the [OpenJDK
>> 11|
>> https://github.com/docker-library/openjdk/blob/20450f7a60b8db7aafd491a5ea55c6a3548138c6/11/jdk/buster/Dockerfile]
>>
>> built on Debian Buster.
>>
>> JSPWiki is built from source using [Apache
>> Maven|http://maven.apache.org/] during the image build process.
>>
>> !! Prerequisites
>>
>> To use the pre-built image or build one from source you only need a
>> [Docker Engine|https://docs.docker.com/engine/]. See the [installation
>> instructions|http://docs.docker.com/installation/] on the docker site
>> for details.
>>
>> !! Using the Pre-Built Image
>> To download it locally from the [docker
>> hub|https://registry.hub.docker.com/u/metskem/docker-jspwiki/].
>> ! Get the Image
>> {{{
>> $ docker pull metskem/docker-jspwiki
>> }}}
>> ! Running the Container
>> {{{
>> $ docker run -d -p 8080:8080 --name jspwiki metskem/docker-jspwiki
>> }}}
>>
>> This means :
>> * __-d__ - detached mode, run the container in the background
>> * __-p 8080:8080__ - bind the host port (8080) to the container port
>> (8080). JSPWiki always runs on port 8080 inside the container.
>> * __--name jspwiki__ - the new docker container will get the name
>> ''jspwiki'' (instead of a generated container name)
>> * __metskem/docker-jspwiki__ - the name of the image to run
>>
>> !! Building from Source
>> ! Building the Image
>> From the source root directory that contains the Dockerfile. The
>> example uses a {{$version}} variable because the version is referred to
>> multiple times. It is optional and can be replaced by any version number
>> you would like to use. If you do not specify a version with the tag name
>> it will default to 'latest'.
>>
>> Watch out for the space and period at the end which means the current
>> directory.
>> {{{
>> $ version='2.11.0'
>> $ docker build --tag="jspwiki:$version" .
>> }}}
>>
>> ! Running the Container
>> This is exactly like running the pre-built image except for the image
>> {{name:version}} at the end.
>> {{{
>> $ docker run -d -p 8080:8080 --name jspwiki jspwiki:$version
>> }}}
>>
>> !! Check the Results
>>
>> Just point your browser at [http://localhost:8080/], that should give
>> you a working wiki right away !
>>
>> To see the list of running containers use {{docker ps}} or {{docker
>> container ls}} and {{docker ps -a}} or {{docker container ls -a}} will
>> show all containers running and stopped.
>> {{{
>> $ docker ps
>> CONTAINER ID
[jira] [Commented] (JSPWIKI-1142) Minor performance improvements
[ https://issues.apache.org/jira/browse/JSPWIKI-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263090#comment-17263090 ] Arturo Bernal commented on JSPWIKI-1142: Hi [~juanpablo] i'm gonna check the Jira JSPWIKI-1143 and see what i can do. I will notify you when I have something. hopefully will soon. > Minor performance improvements > -- > > Key: JSPWIKI-1142 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1142 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Minor > Labels: pull-request-available > > > * Remove redundant initializer > * Redundant interface modifier --> Not really performance ;) > * Remove Unused import > * Bulk operation can be used instead of iteration > * Manual array copy > * Manual array to collection copy > * Avoid String concatenation in loop > * Redundant 'Collection.addAll()' call. Use Parametrized constructor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
