[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file

2020-12-22 Thread GitBox 


arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969



##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:

Review comment:
   Hi @juanpablo-santos 
   
   At the moment thinks are fallows:
   
   `version: 2
   updates:
 - package-ecosystem: "maven"
   directory: "/"
   schedule:
 interval: "daily"
 - package-ecosystem: "github-actions"
   directory: "/"
   schedule:
 interval: "daily"
   ignore:
 - dependency-name: javax.servlet:javax.servlet-api
versions: [3.2.0,)
 - dependency-name: javax.servlet.jsp:javax.servlet.jsp-api
versions: [2.4.0,)
 - dependency-name: org.apache.tomcat:*
versions: [10.0.0,)
 - dependency-name: org.slf4j:*
versions: [1.8.0-beta1,2.0.0)`
   
   
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file

2020-12-22 Thread GitBox 


arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969



##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:

Review comment:
   Hi @juanpablo-santos 
   
   At the moment thinks are fallows:
   
   version: 2
   updates:
 - package-ecosystem: "maven"
   directory: "/"
   schedule:
 interval: "daily"
 - package-ecosystem: "github-actions"
   directory: "/"
   schedule:
 interval: "daily"
   ignore:
 - dependency-name: javax.servlet:javax.servlet-api
versions: [3.2.0,)
 - dependency-name: javax.servlet.jsp:javax.servlet.jsp-api
versions: [2.4.0,)
 - dependency-name: org.apache.tomcat:*
versions: [10.0.0,)
 - dependency-name: org.slf4j:*
versions: [1.8.0-beta1,2.0.0)
   
   
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Docker questions

2020-12-22 Thread Carl Marcum 

Hi All,

I'm working on a PR for the Docker page I should have ready sometime today.

Thanks,
Carl

On 12/21/20 1:15 PM, Harry Metske wrote:

thanks for following up, I will delete that (my personal) repo to prevent
future misunderstandings.

cheers,
Harry

On Mon, 21 Dec 2020 at 17:36, Carl Marcum  wrote:


Hi Juan Pablo,

Thanks for redirect.  That's quite a bit different.
I will fork that repo instead and work on it.

If I see something I think will help I'll be back :)

Best regards,
Carl

On 12/21/20 11:17 AM, Juan Pablo Santos Rodríguez wrote:

Hi Carl,

the Dockerfile was moved on to the main repo on 2.11.0.M6, you cand
find it at [#1]. Related documentation at jspwiki-wiki.a.o [#2] is
still outdated, tough, and needs some work to reflect current status.

In any case, we'd love if you could take a look at [#1] and send any
PRs you see fit to make it better! :-)


Thanks + best regards,
juan pablo


[#1]: https://github.com/apache/jspwiki/blob/master/Dockerfile

[#2]: https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker


On Mon, Dec 21, 2020 at 2:23 PM Carl Marcum mailto:cmar...@apache.org>> wrote:

 Hi All,

 I've forked the docker-jspwiki [1] from github and was wondering
 if you
 might want anything I'm working on PR'd back.

 Some of the things I'm looking at are:

 1. Using the Dockerfile to download binaries and remove them.

 I noticed the Docker file comments mention CentOS 7 but the image is
 Alpine so I didn't know if that was a planned change.
 2. a. Using a CentOS based image and adding a JRE
 b. Amazon Corretto based on Amazon Linux 2 optimized for AWS.
 c. Just start with an official Tomcat image (many OS options with
 this one).

 3. Reducing the number of image layers through command consolidation.

 Also is branch 2.11.0-M5 the latest branch?

 Thanks,
 Carl

 [1] https://github.com/metskem/docker-jspwiki
 

 Best regards,
 Carl

Re: Docker questions

2020-12-22 Thread Carl Marcum 

Hi all,

I have reworked the Docker.txt page from the Wiki but I can't seem to 
find it in the source trees.


Have I overlooked it or are not all the Wiki pages in Git?

If not I can also just post the page text here and you can review.

Best regards,
Carl


On 12/22/20 9:54 AM, Carl Marcum wrote:

Hi All,

I'm working on a PR for the Docker page I should have ready sometime 
today.


Thanks,
Carl

On 12/21/20 1:15 PM, Harry Metske wrote:
thanks for following up, I will delete that (my personal) repo to 
prevent

future misunderstandings.

cheers,
Harry

On Mon, 21 Dec 2020 at 17:36, Carl Marcum  wrote:


Hi Juan Pablo,

Thanks for redirect.  That's quite a bit different.
I will fork that repo instead and work on it.

If I see something I think will help I'll be back :)

Best regards,
Carl

On 12/21/20 11:17 AM, Juan Pablo Santos Rodríguez wrote:

Hi Carl,

the Dockerfile was moved on to the main repo on 2.11.0.M6, you cand
find it at [#1]. Related documentation at jspwiki-wiki.a.o [#2] is
still outdated, tough, and needs some work to reflect current status.

In any case, we'd love if you could take a look at [#1] and send any
PRs you see fit to make it better! :-)


Thanks + best regards,
juan pablo


[#1]: https://github.com/apache/jspwiki/blob/master/Dockerfile

[#2]: https://jspwiki-wiki.apache.org/Wiki.jsp?page=Docker


On Mon, Dec 21, 2020 at 2:23 PM Carl Marcum mailto:cmar...@apache.org>> wrote:

 Hi All,

 I've forked the docker-jspwiki [1] from github and was wondering
 if you
 might want anything I'm working on PR'd back.

 Some of the things I'm looking at are:

 1. Using the Dockerfile to download binaries and remove them.

 I noticed the Docker file comments mention CentOS 7 but the 
image is

 Alpine so I didn't know if that was a planned change.
 2. a. Using a CentOS based image and adding a JRE
 b. Amazon Corretto based on Amazon Linux 2 optimized for AWS.
 c. Just start with an official Tomcat image (many OS 
options with

 this one).

 3. Reducing the number of image layers through command 
consolidation.


 Also is branch 2.11.0-M5 the latest branch?

 Thanks,
 Carl

 [1] https://github.com/metskem/docker-jspwiki
 

 Best regards,
 Carl