[GitHub] [jspwiki] arturobernalg commented on pull request #17: [JSPWIKI-1137] - Minor Improvement
arturobernalg commented on pull request #17: URL: https://github.com/apache/jspwiki/pull/17#issuecomment-748199608 Hi @juanpablo-santos I'm really sorry the number of line. but i thing the change proposed it will improve the code Pls let me know if you want me to change something merry christmas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JSPWIKI-1137) Minor Improvement
[ https://issues.apache.org/jira/browse/JSPWIKI-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated JSPWIKI-1137: Labels: pull-request-available pull-requests-available (was: pull-requests-available) > Minor Improvement > - > > Key: JSPWIKI-1137 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1137 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available, pull-requests-available > > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 > * Unnecessary semicolon '' > * add final > * Unnecessary 'null' check before 'equals()' call > * Replace "UTF-8" for StandardCharsets.UTF_8.name() > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1.name() > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] arturobernalg edited a comment on pull request #17: [JSPWIKI-1137] - Minor Improvement
arturobernalg edited a comment on pull request #17: URL: https://github.com/apache/jspwiki/pull/17#issuecomment-748199608 Hi @juanpablo-santos I'm very sorry for the line number and files changed. but i thing the change proposed it will improve the code Pls let me know if you want me to change something merry christmas This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
