[GitHub] [jspwiki] juanpablo-santos commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
juanpablo-santos commented on a change in pull request #15: URL: https://github.com/apache/jspwiki/pull/15#discussion_r545343859 ## File path: .github/dependabot.yml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: 2 +updates: Review comment: Hi @arturobernalg , thanks for the PR! A couple of questions / comments: * would you mind including some exclusions for servlet-api, jsp-api and tomcat required dependencies? More precisely, it would be great if we could get notified about patch releases on those dependencies, but not on minor or major * how does dependabot behave with versions not following semantic versioning? For instance, slf4j should stay on 1.7.30 and not be upgraded to latest 2.0.0-alpha1. thanks + br, juan pablo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos merged pull request #16: [JSPWIKI-1136] - Refine Class member fields
juanpablo-santos merged pull request #16: URL: https://github.com/apache/jspwiki/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] juanpablo-santos commented on pull request #16: [JSPWIKI-1136] - Refine Class member fields
juanpablo-santos commented on pull request #16: URL: https://github.com/apache/jspwiki/pull/16#issuecomment-747648792 PR merged, thanks for the contribution, @arturobernalg! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JSPWIKI-1136) Refine Class member fields
[ https://issues.apache.org/jira/browse/JSPWIKI-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251303#comment-17251303 ] ASF subversion and git services commented on JSPWIKI-1136: -- Commit 31c34210315b013ccf873b09a729e310a21a989c in jspwiki's branch refs/heads/master from Arturo Bernal [ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=31c3421 ] JSPWIKI-1136 - Refine Class member fields > Refine Class member fields > -- > > Key: JSPWIKI-1136 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1136 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (JSPWIKI-1136) Refine Class member fields
[ https://issues.apache.org/jira/browse/JSPWIKI-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Pablo Santos Rodríguez resolved JSPWIKI-1136. -- Resolution: Fixed Merged in 2.11.0-git-01. > Refine Class member fields > -- > > Key: JSPWIKI-1136 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1136 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available > Fix For: 2.11.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JSPWIKI-1136) Refine Class member fields
[ https://issues.apache.org/jira/browse/JSPWIKI-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juan Pablo Santos Rodríguez updated JSPWIKI-1136: - Fix Version/s: 2.11.0 > Refine Class member fields > -- > > Key: JSPWIKI-1136 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1136 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available > Fix For: 2.11.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] arturobernalg commented on a change in pull request #15: [JSPWIKI-1135] - Add dependabot config file
arturobernalg commented on a change in pull request #15: URL: https://github.com/apache/jspwiki/pull/15#discussion_r545582681 ## File path: .github/dependabot.yml ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: 2 +updates: Review comment: no clue. I'm gonna check if we can configure the bot to achieve what you asking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (JSPWIKI-1137) Minor Improvement
Arturo Bernal created JSPWIKI-1137: -- Summary: Minor Improvement Key: JSPWIKI-1137 URL: https://issues.apache.org/jira/browse/JSPWIKI-1137 Project: JSPWiki Issue Type: Improvement Reporter: Arturo Bernal * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 * Unnecessary semicolon '' * add final * Unnecessary 'null' check before 'equals()' call -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] arturobernalg opened a new pull request #17: [JSPWIKI-1137] - Minor Improvement
arturobernalg opened a new pull request #17: URL: https://github.com/apache/jspwiki/pull/17 * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 * Unnecessary semicolon '' * add final * Unnecessary 'null' check before 'equals()' call This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (JSPWIKI-1137) Minor Improvement
[ https://issues.apache.org/jira/browse/JSPWIKI-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated JSPWIKI-1137: Labels: pull-request-available (was: ) > Minor Improvement > - > > Key: JSPWIKI-1137 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1137 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-request-available > > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 > * Unnecessary semicolon '' > * add final > * Unnecessary 'null' check before 'equals()' call > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JSPWIKI-1137) Minor Improvement
[ https://issues.apache.org/jira/browse/JSPWIKI-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated JSPWIKI-1137: --- Labels: pull-requests-available (was: pull-request-available) > Minor Improvement > - > > Key: JSPWIKI-1137 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1137 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-requests-available > > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 > * Unnecessary semicolon '' > * add final > * Unnecessary 'null' check before 'equals()' call > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JSPWIKI-1137) Minor Improvement
[ https://issues.apache.org/jira/browse/JSPWIKI-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arturo Bernal updated JSPWIKI-1137: --- Description: * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 * Unnecessary semicolon '' * add final * Unnecessary 'null' check before 'equals()' call * Replace "UTF-8" for StandardCharsets.UTF_8.name() * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1.name() was: * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 * Unnecessary semicolon '' * add final * Unnecessary 'null' check before 'equals()' call > Minor Improvement > - > > Key: JSPWIKI-1137 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1137 > Project: JSPWiki > Issue Type: Improvement >Reporter: Arturo Bernal >Priority: Major > Labels: pull-requests-available > > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1 > * Unnecessary semicolon '' > * add final > * Unnecessary 'null' check before 'equals()' call > * Replace "UTF-8" for StandardCharsets.UTF_8.name() > * Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1.name() > -- This message was sent by Atlassian Jira (v8.3.4#803005)
