[jira] [Commented] (JSPWIKI-1042) Impossible to change user profile loginName, fullname, password
[ https://issues.apache.org/jira/browse/JSPWIKI-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822552#comment-15822552 ] Eric Kraußer commented on JSPWIKI-1042: --- Skip email check if found userprofile is the profile to be changed > Impossible to change user profile loginName, fullname, password > --- > > Key: JSPWIKI-1042 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1042 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage >Affects Versions: 2.10.2, 2.10.3 >Reporter: Eric Kraußer > Attachments: vcs-diff1033007971762742953.patch > > > Just try to change the logged in users profile, e. g. the password. > The method > UserManager#validateProfile(WikiContext, UserProfile) > checks for duplicate entries but this check fails on the user profile that > should be changed itself. If you change your password the manager finds an > user profile with the same email adress and fails. > The DefaultUserProfile#equals(Object) method should only test the uuid > attribute and not the other attributes. This would be the best solution i > think, but this could break other code that looks in maps an sets, for > example. > Or just check for equality of the uuid in > UserManager#validateProfile(WikiContext, UserProfile). > I would like to help here and with other open issues and can send patches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JSPWIKI-1042) Impossible to change user profile loginName, fullname, password
[ https://issues.apache.org/jira/browse/JSPWIKI-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Kraußer updated JSPWIKI-1042: -- Attachment: vcs-diff1033007971762742953.patch > Impossible to change user profile loginName, fullname, password > --- > > Key: JSPWIKI-1042 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1042 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage >Affects Versions: 2.10.2, 2.10.3 >Reporter: Eric Kraußer > Attachments: vcs-diff1033007971762742953.patch > > > Just try to change the logged in users profile, e. g. the password. > The method > UserManager#validateProfile(WikiContext, UserProfile) > checks for duplicate entries but this check fails on the user profile that > should be changed itself. If you change your password the manager finds an > user profile with the same email adress and fails. > The DefaultUserProfile#equals(Object) method should only test the uuid > attribute and not the other attributes. This would be the best solution i > think, but this could break other code that looks in maps an sets, for > example. > Or just check for equality of the uuid in > UserManager#validateProfile(WikiContext, UserProfile). > I would like to help here and with other open issues and can send patches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1042) Impossible to change user profile loginName, fullname, password
[ https://issues.apache.org/jira/browse/JSPWIKI-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822570#comment-15822570 ] Eric Kraußer commented on JSPWIKI-1042: --- Sorry for the long patch, it should only be the 3 lines near && !profile.getUid().equals(otherProfile.getUid()) // Issue JSPWIKI-1042 > Impossible to change user profile loginName, fullname, password > --- > > Key: JSPWIKI-1042 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1042 > Project: JSPWiki > Issue Type: Bug > Components: Core & storage >Affects Versions: 2.10.2, 2.10.3 >Reporter: Eric Kraußer > Attachments: vcs-diff1033007971762742953.patch > > > Just try to change the logged in users profile, e. g. the password. > The method > UserManager#validateProfile(WikiContext, UserProfile) > checks for duplicate entries but this check fails on the user profile that > should be changed itself. If you change your password the manager finds an > user profile with the same email adress and fails. > The DefaultUserProfile#equals(Object) method should only test the uuid > attribute and not the other attributes. This would be the best solution i > think, but this could break other code that looks in maps an sets, for > example. > Or just check for equality of the uuid in > UserManager#validateProfile(WikiContext, UserProfile). > I would like to help here and with other open issues and can send patches. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (JSPWIKI-1043) Encode email subjects as UTF-8
Eric Kraußer created JSPWIKI-1043: - Summary: Encode email subjects as UTF-8 Key: JSPWIKI-1043 URL: https://issues.apache.org/jira/browse/JSPWIKI-1043 Project: JSPWiki Issue Type: Bug Components: Localization Affects Versions: 2.10.2, 2.10.3 Reporter: Eric Kraußer Priority: Minor The email subject is broken for e. g. German umlauts. For example the email for the new password has the subject: "Neues Passwort f?r wikiname" but should be "Neues Passwort für wikiname" Patch follows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JSPWIKI-1043) Encode email subjects as UTF-8
[ https://issues.apache.org/jira/browse/JSPWIKI-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Kraußer updated JSPWIKI-1043: -- Attachment: mailutf8.patch > Encode email subjects as UTF-8 > -- > > Key: JSPWIKI-1043 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1043 > Project: JSPWiki > Issue Type: Bug > Components: Localization >Affects Versions: 2.10.2, 2.10.3 >Reporter: Eric Kraußer >Priority: Minor > Attachments: mailutf8.patch > > > The email subject is broken for e. g. German umlauts. > For example the email for the new password has the subject: > "Neues Passwort f?r wikiname" but should be > "Neues Passwort für wikiname" > Patch follows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
