Re: IEP-78 .NET Thin Client for Ignite 3.0
Hi Val, This is a very good point. I've looked around blogs, docs, and system APIs, and updated the IEP accordingly: For Ignite.NET I propose NOT to add sync methods when the actual implementation is async: - It is easy to consume async APIs in C# with async/await keywords (added in 2012 and widely adopted) - Most codebases are fully async anyway - System APIs and popular libraries follow this direction - Sync-over-async is misleading and can affect performance However, I'm not so sure about Java, where async/await are not present, overall async usage seems to be rarer, and removing sync methods may become an obstacle for the users in some cases. Let's create a separate discussion and see what others think. Pavel On Thu, Sep 2, 2021 at 10:32 PM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Hi Pavel, > > I've looked at the IEP and the public API - looks good to me. > > Quick question - do you plan to add sync methods to the interfaces, or > you're thinking to only leave async? If the latter, what are the arguments > for this? The reason I'm asking is that I'm actually thinking about > suggesting the same for Java as well (or at least having a discussion about > this). > > -Val > > On Thu, Sep 2, 2021 at 10:08 AM Pavel Tupitsyn > wrote: > > > Igniters, > > > > Please review the IEP [1] and the PoC [2] for .NET Thin Client in Ignite > > 3.0. > > > > [1] > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-78+.NET+Thin+Client > > [2] https://github.com/apache/ignite-3/pull/306 > > >
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Folks, The patch [1] for the azure module seems to be ready for review, however, there are still some questions that exist: - Do we have a technical account in azure to test the moude on TC? Manual testing for such changes is really annoying. - Is there any reason to add these changes to the main Apache Ignite project? Why not extensions? - It seems there is a lack of tests for this module. According to the mentions above, what do you think about moving this functionality to the next 2.12 release to solve all the questions without a rush? I propose to revert the changes related to the azure functionality from the 2.11 branch. [1] https://issues.apache.org/jira/browse/IGNITE-15388 On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov wrote: > > We had a separate discussion with Max and Alex, so I tend to agree that > both issues are blockers. > > Sincerely, > Dmitriy Pavlov > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > Hi, Maxim! > > > > These issues really block release. So we should wait fixes. > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > Folks, > > > > > > > > > I've been faced these issues, which seems to be a blocker for the > > > release. Please, take a look and share your thoughts. > > > > > > The server node fails when the client node with the higher java > > > version connects to it [1]. > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov wrote: > > > > > > > > +1 > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky > > wrote: > > > > > > > > > > I suppose, that https://issues.apache.org/jira/browse/IGNITE-15274 > > is a > > > > > blocker. > > > > > Fix is quite easy and straightforward > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego : > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > Best Regards, > > > > > > Igor > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > olive.c...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can you > > cherry-pick it to > > > > > > > release branch? > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > > > On 2021/07/30 02:25:25, Igor Sapego wrote: > > > > > > > > I'm fine with any of these two solutions. > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > > > > ilya.kasnach...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hello! > > > > > > > > > > > > > > > > > > I think it does make sense to include changes which will let > > us avoid > > > > > > > > > migration issues in the future. > > > > > > > > > > > > > > > > > > Alternatively, maybe we can revert the incomplete change > > from 2.11 in > > > > > > > order > > > > > > > > > to reintroduce it in 2.12 in full form if Igor agrees and RE > > thinks > > > > > > > this is > > > > > > > > > the best course of action. > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > -- > > > > > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > > > > > > > > > > > > > чт, 29 июл. 2021 г. в 18:07, Igor Sapego > >: > > > > > > > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > > > > > > It contains changes we could not introduce if we release > > ignite in > > > > > > > its > > > > > > > > > > current state as they are going to be breaking changes. > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 4:13 PM Alexey Gidaspov < > > > > > > > olive.c...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi, Igor! > > > > > > > > > > > > > > > > > > > > > > Now we are in stabilization phase and accepting only > > blockers. I > > > > > > > may be > > > > > > > > > > > wrong, but this ticket doesn't seem to be of that kind. > > > > > > > > > > > > > > > > > > > > > > On 2021/07/28 21:00:15, Igor Sapego > > wrote: > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > > > > > > > > > > > I suggest adding [1] to the scope of release, because > > it > > > > > > contains > > > > > > > > > > > > changes to code introduced by [2], which is already > > included in > > > > > > > > > > release. > > > > > > > > > > > > > > > > > > > > > > > > [1] - > > https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > [2] - > > https://issues.apache.org/jira/browse/IGNITE-14658 > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Jul 26, 2021 at 11:30 PM Maxim Muzafarov < > > > > > > > mmu...@apache.org>
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
I would argue that the module Co exists with the other IP discovery modules (such as GCP and AWS), which are part of core. In terms of tests, the azure module has exactly the same type of tests as the other two modules mentioned above. On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote: > Folks, > > The patch [1] for the azure module seems to be ready for review, > however, there are still some questions that exist: > - Do we have a technical account in azure to test the moude on TC? > Manual testing for such changes is really annoying. > - Is there any reason to add these changes to the main Apache Ignite > project? Why not extensions? > - It seems there is a lack of tests for this module. > > According to the mentions above, what do you think about moving this > functionality to the next 2.12 release to solve all the questions > without a rush? I propose to revert the changes related to the azure > functionality from the 2.11 branch. > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov wrote: > > > > We had a separate discussion with Max and Alex, so I tend to agree that > > both issues are blockers. > > > > Sincerely, > > Dmitriy Pavlov > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > > > Hi, Maxim! > > > > > > These issues really block release. So we should wait fixes. > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > > Folks, > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker for the > > > > release. Please, take a look and share your thoughts. > > > > > > > > The server node fails when the client node with the higher java > > > > version connects to it [1]. > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov > wrote: > > > > > > > > > > +1 > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky > > > wrote: > > > > > > > > > > > > I suppose, that > https://issues.apache.org/jira/browse/IGNITE-15274 > > > is a > > > > > > blocker. > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego : > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > Best Regards, > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > olive.c...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can you > > > cherry-pick it to > > > > > > > > release branch? > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > > > > > On 2021/07/30 02:25:25, Igor Sapego > wrote: > > > > > > > > > I'm fine with any of these two solutions. > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > > > > > ilya.kasnach...@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hello! > > > > > > > > > > > > > > > > > > > > I think it does make sense to include changes which will > let > > > us avoid > > > > > > > > > > migration issues in the future. > > > > > > > > > > > > > > > > > > > > Alternatively, maybe we can revert the incomplete change > > > from 2.11 in > > > > > > > > order > > > > > > > > > > to reintroduce it in 2.12 in full form if Igor agrees > and RE > > > thinks > > > > > > > > this is > > > > > > > > > > the best course of action. > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > > -- > > > > > > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > чт, 29 июл. 2021 г. в 18:07, Igor Sapego < > isap...@apache.org > > > >: > > > > > > > > > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > > > > > > > > It contains changes we could not introduce if we > release > > > ignite in > > > > > > > > its > > > > > > > > > > > current state as they are going to be breaking changes. > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 4:13 PM Alexey Gidaspov < > > > > > > > > olive.c...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hi, Igor! > > > > > > > > > > > > > > > > > > > > > > > > Now we are in stabilization phase and accepting only > > > blockers. I > > > > > > > > may be > > > > > > > > > > > > wrong, but this ticket doesn't seem to be of that > kind. > > > > > > > > > > > > > > > > > > > > > > > > On 2021/07/28 21:00:15, Igor Sapego < > isap...@apache.org> > > > wrote: > > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > > > > > > > > > > > > > I suggest adding [1] to th
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Disagree to exclude this contribution from the 2.11 release. As Atri explained, its implementation and testing approach is identical to the AWS, GCP and Kubernetes IP finders. If we want to move the modules to extensions and improve the testing approach, then it needs to be done for all similar components. Atri, have you tested the module in the cloud? If it works, then I don't see any reason why we need to have someone else double-checking this once again. This is the community, we need to trust each other. - Denis On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > I would argue that the module Co exists with the other IP discovery modules > (such as GCP and AWS), which are part of core. > > In terms of tests, the azure module has exactly the same type of tests as > the other two modules mentioned above. > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote: > > > Folks, > > > > The patch [1] for the azure module seems to be ready for review, > > however, there are still some questions that exist: > > - Do we have a technical account in azure to test the moude on TC? > > Manual testing for such changes is really annoying. > > - Is there any reason to add these changes to the main Apache Ignite > > project? Why not extensions? > > - It seems there is a lack of tests for this module. > > > > According to the mentions above, what do you think about moving this > > functionality to the next 2.12 release to solve all the questions > > without a rush? I propose to revert the changes related to the azure > > functionality from the 2.11 branch. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov wrote: > > > > > > We had a separate discussion with Max and Alex, so I tend to agree that > > > both issues are blockers. > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > > > > > Hi, Maxim! > > > > > > > > These issues really block release. So we should wait fixes. > > > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > > > Folks, > > > > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker for the > > > > > release. Please, take a look and share your thoughts. > > > > > > > > > > The server node fails when the client node with the higher java > > > > > version connects to it [1]. > > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov > > wrote: > > > > > > > > > > > > +1 > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > ivanda...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > I suppose, that > > https://issues.apache.org/jira/browse/IGNITE-15274 > > > > is a > > > > > > > blocker. > > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego : > > > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > olive.c...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can you > > > > cherry-pick it to > > > > > > > > > release branch? > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > > > > > > > On 2021/07/30 02:25:25, Igor Sapego > > wrote: > > > > > > > > > > I'm fine with any of these two solutions. > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > > > > > > ilya.kasnach...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hello! > > > > > > > > > > > > > > > > > > > > > > I think it does make sense to include changes which > will > > let > > > > us avoid > > > > > > > > > > > migration issues in the future. > > > > > > > > > > > > > > > > > > > > > > Alternatively, maybe we can revert the incomplete > change > > > > from 2.11 in > > > > > > > > > order > > > > > > > > > > > to reintroduce it in 2.12 in full form if Igor agrees > > and RE > > > > thinks > > > > > > > > > this is > > > > > > > > > > > the best course of action. > > > > > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > > > -- > > > > > > > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > чт, 29 июл. 2021 г. в 18:07, Igor Sapego < > > isap...@apache.org > > > > >: > > > > > > > > > > > > > > > > > > > > > > > Alexey, > > > > > > > > > > > > > > > > > > > > > > > > It contains changes we could not introduce if we > > release > > > > ignite in > > > > > > > > > its >
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
It was extensively tested by myself (running the tests on an actual Azure account and running an Ignite cluster using an Azure account) and Ilya (thanks Ilya!) prior to merging it in the core On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: > Disagree to exclude this contribution from the 2.11 release. As Atri > explained, its implementation and testing approach is identical to the AWS, > GCP and Kubernetes IP finders. > If we want to move the modules to extensions and improve the testing > approach, then it needs to be done for all similar components. > > Atri, have you tested the module in the cloud? If it works, then I don't > see any reason why we need to have someone else double-checking this once > again. This is the community, we need to trust each other. > > - > Denis > > On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > > > I would argue that the module Co exists with the other IP discovery > modules > > (such as GCP and AWS), which are part of core. > > > > In terms of tests, the azure module has exactly the same type of tests as > > the other two modules mentioned above. > > > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote: > > > > > Folks, > > > > > > The patch [1] for the azure module seems to be ready for review, > > > however, there are still some questions that exist: > > > - Do we have a technical account in azure to test the moude on TC? > > > Manual testing for such changes is really annoying. > > > - Is there any reason to add these changes to the main Apache Ignite > > > project? Why not extensions? > > > - It seems there is a lack of tests for this module. > > > > > > According to the mentions above, what do you think about moving this > > > functionality to the next 2.12 release to solve all the questions > > > without a rush? I propose to revert the changes related to the azure > > > functionality from the 2.11 branch. > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov > wrote: > > > > > > > > We had a separate discussion with Max and Alex, so I tend to agree > that > > > > both issues are blockers. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > > > > > > > Hi, Maxim! > > > > > > > > > > These issues really block release. So we should wait fixes. > > > > > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > > > > Folks, > > > > > > > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker for the > > > > > > release. Please, take a look and share your thoughts. > > > > > > > > > > > > The server node fails when the client node with the higher java > > > > > > version connects to it [1]. > > > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov > > > wrote: > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > ivanda...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > I suppose, that > > > https://issues.apache.org/jira/browse/IGNITE-15274 > > > > > is a > > > > > > > > blocker. > > > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego >: > > > > > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > > olive.c...@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can you > > > > > cherry-pick it to > > > > > > > > > > release branch? > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > > > > > > > > > On 2021/07/30 02:25:25, Igor Sapego > > > wrote: > > > > > > > > > > > I'm fine with any of these two solutions. > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > > > > > > > ilya.kasnach...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hello! > > > > > > > > > > > > > > > > > > > > > > > > I think it does make sense to include changes which > > will > > > let > > > > > us avoid > > > > > > > > > > > > migration issues in the future. > > > > > > > > > > > > > > > > > > > > > > > > Alternatively, maybe we can revert the incomplete > > change > > > > > from 2.11 in > > > > > > > > > > order > > > > > > > > > > > > to reintroduce it in 2.12 in full form if Igor agrees > > > and RE > > > > > thinks > > > > > > > > > > this is > > > >
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Folks, The GCP and AWS should also be moved to extensions, but this is a discussion for another topic. I trust you all :-) But who can validate the patch [1]? This is a bad practice that only a few members be able to test the code. [1] https://issues.apache.org/jira/browse/IGNITE-15388 On Fri, 3 Sept 2021 at 16:43, Atri Sharma wrote: > > It was extensively tested by myself (running the tests on an actual Azure > account and running an Ignite cluster using an Azure account) and Ilya > (thanks Ilya!) prior to merging it in the core > > On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: > > > Disagree to exclude this contribution from the 2.11 release. As Atri > > explained, its implementation and testing approach is identical to the AWS, > > GCP and Kubernetes IP finders. > > If we want to move the modules to extensions and improve the testing > > approach, then it needs to be done for all similar components. > > > > Atri, have you tested the module in the cloud? If it works, then I don't > > see any reason why we need to have someone else double-checking this once > > again. This is the community, we need to trust each other. > > > > - > > Denis > > > > On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > > > > > I would argue that the module Co exists with the other IP discovery > > modules > > > (such as GCP and AWS), which are part of core. > > > > > > In terms of tests, the azure module has exactly the same type of tests as > > > the other two modules mentioned above. > > > > > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote: > > > > > > > Folks, > > > > > > > > The patch [1] for the azure module seems to be ready for review, > > > > however, there are still some questions that exist: > > > > - Do we have a technical account in azure to test the moude on TC? > > > > Manual testing for such changes is really annoying. > > > > - Is there any reason to add these changes to the main Apache Ignite > > > > project? Why not extensions? > > > > - It seems there is a lack of tests for this module. > > > > > > > > According to the mentions above, what do you think about moving this > > > > functionality to the next 2.12 release to solve all the questions > > > > without a rush? I propose to revert the changes related to the azure > > > > functionality from the 2.11 branch. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov > > wrote: > > > > > > > > > > We had a separate discussion with Max and Alex, so I tend to agree > > that > > > > > both issues are blockers. > > > > > > > > > > Sincerely, > > > > > Dmitriy Pavlov > > > > > > > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > > > > > > > > > Hi, Maxim! > > > > > > > > > > > > These issues really block release. So we should wait fixes. > > > > > > > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > > > > > Folks, > > > > > > > > > > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker for the > > > > > > > release. Please, take a look and share your thoughts. > > > > > > > > > > > > > > The server node fails when the client node with the higher java > > > > > > > version connects to it [1]. > > > > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov > > > > wrote: > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > > ivanda...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > > > > I suppose, that > > > > https://issues.apache.org/jira/browse/IGNITE-15274 > > > > > > is a > > > > > > > > > blocker. > > > > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego > >: > > > > > > > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > > > olive.c...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can you > > > > > > cherry-pick it to > > > > > > > > > > > release branch? > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14815 > > > > > > > > > > > > > > > > > > > > > > On 2021/07/30 02:25:25, Igor Sapego > > > > wrote: > > > > > > > > > > > > I'm fine with any of these two solutions. > > > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev < > > > > > > > > > > > ilya.kasnach...@gm
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Folks, I'd like to mention that currently THE BUILD is broken not only for the release branch but for the master also. It's true that the TC has cached the artefacts, so we don't see broken builds but how to build the Apache Ignite locally? I'm not able to do so. On Fri, 3 Sept 2021 at 16:59, Maxim Muzafarov wrote: > > Folks, > > The GCP and AWS should also be moved to extensions, but this is a > discussion for another topic. > > I trust you all :-) > But who can validate the patch [1]? This is a bad practice that only a > few members be able to test the code. > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > On Fri, 3 Sept 2021 at 16:43, Atri Sharma wrote: > > > > It was extensively tested by myself (running the tests on an actual Azure > > account and running an Ignite cluster using an Azure account) and Ilya > > (thanks Ilya!) prior to merging it in the core > > > > On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: > > > > > Disagree to exclude this contribution from the 2.11 release. As Atri > > > explained, its implementation and testing approach is identical to the > > > AWS, > > > GCP and Kubernetes IP finders. > > > If we want to move the modules to extensions and improve the testing > > > approach, then it needs to be done for all similar components. > > > > > > Atri, have you tested the module in the cloud? If it works, then I don't > > > see any reason why we need to have someone else double-checking this once > > > again. This is the community, we need to trust each other. > > > > > > - > > > Denis > > > > > > On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > > > > > > > I would argue that the module Co exists with the other IP discovery > > > modules > > > > (such as GCP and AWS), which are part of core. > > > > > > > > In terms of tests, the azure module has exactly the same type of tests > > > > as > > > > the other two modules mentioned above. > > > > > > > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, wrote: > > > > > > > > > Folks, > > > > > > > > > > The patch [1] for the azure module seems to be ready for review, > > > > > however, there are still some questions that exist: > > > > > - Do we have a technical account in azure to test the moude on TC? > > > > > Manual testing for such changes is really annoying. > > > > > - Is there any reason to add these changes to the main Apache Ignite > > > > > project? Why not extensions? > > > > > - It seems there is a lack of tests for this module. > > > > > > > > > > According to the mentions above, what do you think about moving this > > > > > functionality to the next 2.12 release to solve all the questions > > > > > without a rush? I propose to revert the changes related to the azure > > > > > functionality from the 2.11 branch. > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov > > > wrote: > > > > > > > > > > > > We had a separate discussion with Max and Alex, so I tend to agree > > > that > > > > > > both issues are blockers. > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov : > > > > > > > > > > > > > Hi, Maxim! > > > > > > > > > > > > > > These issues really block release. So we should wait fixes. > > > > > > > > > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov wrote: > > > > > > > > Folks, > > > > > > > > > > > > > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker for > > > > > > > > the > > > > > > > > release. Please, take a look and share your thoughts. > > > > > > > > > > > > > > > > The server node fails when the client node with the higher java > > > > > > > > version connects to it [1]. > > > > > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov > > > > > wrote: > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > > > ivanda...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > I suppose, that > > > > > https://issues.apache.org/jira/browse/IGNITE-15274 > > > > > > > is a > > > > > > > > > > blocker. > > > > > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego > > >: > > > > > > > > > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > > > > olive.c...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Ok, I think we should
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
I am not sure why is it can be tested by few members? Anyone with azure account should be able to test it On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, wrote: > Folks, > > The GCP and AWS should also be moved to extensions, but this is a > discussion for another topic. > > I trust you all :-) > But who can validate the patch [1]? This is a bad practice that only a > few members be able to test the code. > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > On Fri, 3 Sept 2021 at 16:43, Atri Sharma wrote: > > > > It was extensively tested by myself (running the tests on an actual Azure > > account and running an Ignite cluster using an Azure account) and Ilya > > (thanks Ilya!) prior to merging it in the core > > > > On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: > > > > > Disagree to exclude this contribution from the 2.11 release. As Atri > > > explained, its implementation and testing approach is identical to the > AWS, > > > GCP and Kubernetes IP finders. > > > If we want to move the modules to extensions and improve the testing > > > approach, then it needs to be done for all similar components. > > > > > > Atri, have you tested the module in the cloud? If it works, then I > don't > > > see any reason why we need to have someone else double-checking this > once > > > again. This is the community, we need to trust each other. > > > > > > - > > > Denis > > > > > > On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > > > > > > > I would argue that the module Co exists with the other IP discovery > > > modules > > > > (such as GCP and AWS), which are part of core. > > > > > > > > In terms of tests, the azure module has exactly the same type of > tests as > > > > the other two modules mentioned above. > > > > > > > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, > wrote: > > > > > > > > > Folks, > > > > > > > > > > The patch [1] for the azure module seems to be ready for review, > > > > > however, there are still some questions that exist: > > > > > - Do we have a technical account in azure to test the moude on TC? > > > > > Manual testing for such changes is really annoying. > > > > > - Is there any reason to add these changes to the main Apache > Ignite > > > > > project? Why not extensions? > > > > > - It seems there is a lack of tests for this module. > > > > > > > > > > According to the mentions above, what do you think about moving > this > > > > > functionality to the next 2.12 release to solve all the questions > > > > > without a rush? I propose to revert the changes related to the > azure > > > > > functionality from the 2.11 branch. > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov > > > wrote: > > > > > > > > > > > > We had a separate discussion with Max and Alex, so I tend to > agree > > > that > > > > > > both issues are blockers. > > > > > > > > > > > > Sincerely, > > > > > > Dmitriy Pavlov > > > > > > > > > > > > пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov < > olive.c...@gmail.com>: > > > > > > > > > > > > > Hi, Maxim! > > > > > > > > > > > > > > These issues really block release. So we should wait fixes. > > > > > > > > > > > > > > On 2021/08/27 12:46:24, Maxim Muzafarov > wrote: > > > > > > > > Folks, > > > > > > > > > > > > > > > > > > > > > > > > I've been faced these issues, which seems to be a blocker > for the > > > > > > > > release. Please, take a look and share your thoughts. > > > > > > > > > > > > > > > > The server node fails when the client node with the higher > java > > > > > > > > version connects to it [1]. > > > > > > > > The Apache Ignite build fails with missing dependency [2]. > > > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov < > mmu...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > > > ivanda...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > I suppose, that > > > > > https://issues.apache.org/jira/browse/IGNITE-15274 > > > > > > > is a > > > > > > > > > > blocker. > > > > > > > > > > Fix is quite easy and straightforward > > > > > > > > > > > > > > > > > > > > пн, 2 авг. 2021 г. в 03:11, Igor Sapego < > isap...@apache.org > > > >: > > > > > > > > > > > > > > > > > > > > > Cherry-picked to release branch. > > > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < > > > > > > > olive.c...@gmail.com> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Ok, I think we should add [1] to 2.11 release. Can > you > > > > > > > cherry-pick it to > > > > > > > > > > > > release
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Atri. Right now code can’t be tested because it doesn’t compile. > 3 сент. 2021 г., в 17:42, Atri Sharma написал(а): > > I am not sure why is it can be tested by few members? > > Anyone with azure account should be able to test it > > On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, wrote: > >> Folks, >> >> The GCP and AWS should also be moved to extensions, but this is a >> discussion for another topic. >> >> I trust you all :-) >> But who can validate the patch [1]? This is a bad practice that only a >> few members be able to test the code. >> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-15388 >> >> On Fri, 3 Sept 2021 at 16:43, Atri Sharma wrote: >>> >>> It was extensively tested by myself (running the tests on an actual Azure >>> account and running an Ignite cluster using an Azure account) and Ilya >>> (thanks Ilya!) prior to merging it in the core >>> >>> On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: >>> Disagree to exclude this contribution from the 2.11 release. As Atri explained, its implementation and testing approach is identical to the >> AWS, GCP and Kubernetes IP finders. If we want to move the modules to extensions and improve the testing approach, then it needs to be done for all similar components. Atri, have you tested the module in the cloud? If it works, then I >> don't see any reason why we need to have someone else double-checking this >> once again. This is the community, we need to trust each other. - Denis On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > I would argue that the module Co exists with the other IP discovery modules > (such as GCP and AWS), which are part of core. > > In terms of tests, the azure module has exactly the same type of >> tests as > the other two modules mentioned above. > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, >> wrote: > >> Folks, >> >> The patch [1] for the azure module seems to be ready for review, >> however, there are still some questions that exist: >> - Do we have a technical account in azure to test the moude on TC? >> Manual testing for such changes is really annoying. >> - Is there any reason to add these changes to the main Apache >> Ignite >> project? Why not extensions? >> - It seems there is a lack of tests for this module. >> >> According to the mentions above, what do you think about moving >> this >> functionality to the next 2.12 release to solve all the questions >> without a rush? I propose to revert the changes related to the >> azure >> functionality from the 2.11 branch. >> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-15388 >> >> On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov wrote: >>> >>> We had a separate discussion with Max and Alex, so I tend to >> agree that >>> both issues are blockers. >>> >>> Sincerely, >>> Dmitriy Pavlov >>> >>> пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov < >> olive.c...@gmail.com>: >>> Hi, Maxim! These issues really block release. So we should wait fixes. On 2021/08/27 12:46:24, Maxim Muzafarov >> wrote: > Folks, > > > I've been faced these issues, which seems to be a blocker >> for the > release. Please, take a look and share your thoughts. > > The server node fails when the client node with the higher >> java > version connects to it [1]. > The Apache Ignite build fails with missing dependency [2]. > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov < >> mmu...@apache.org> >> wrote: >> >> +1 >> >> On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > ivanda...@gmail.com> wrote: >>> >>> I suppose, that >> https://issues.apache.org/jira/browse/IGNITE-15274 is a >>> blocker. >>> Fix is quite easy and straightforward >>> >>> пн, 2 авг. 2021 г. в 03:11, Igor Sapego < >> isap...@apache.org > : >>> Cherry-picked to release branch. Best Regards, Igor On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov < olive.c...@gmail.com> wrote: > Ok, I think we should add [1] to 2.11 release. Can >> you cherry-pick it to > release branch? > [1] >> https://issues.apache.org/jira/browse/IGNITE-14815 > > On 2021/07/30 02:25:25, Igor Sapego < >> isap...@apache.org> >> wrote: >> I'm fine with any of these two solutions. >>
Re: [Announcement] Apache Ignite 2.11 Code Freeze started
Atri, > Anyone with azure account should be able to test it I checked the test included in the module with an Azure account (as I mentioned in Jira), it passes successfully. But I'm not sure if this is enough. пт, 3 сент. 2021 г. в 17:48, Nikolay Izhikov : > > Atri. > > Right now code can’t be tested because it doesn’t compile. > > > 3 сент. 2021 г., в 17:42, Atri Sharma написал(а): > > > > I am not sure why is it can be tested by few members? > > > > Anyone with azure account should be able to test it > > > > On Fri, 3 Sep 2021, 19:29 Maxim Muzafarov, wrote: > > > >> Folks, > >> > >> The GCP and AWS should also be moved to extensions, but this is a > >> discussion for another topic. > >> > >> I trust you all :-) > >> But who can validate the patch [1]? This is a bad practice that only a > >> few members be able to test the code. > >> > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-15388 > >> > >> On Fri, 3 Sept 2021 at 16:43, Atri Sharma wrote: > >>> > >>> It was extensively tested by myself (running the tests on an actual Azure > >>> account and running an Ignite cluster using an Azure account) and Ilya > >>> (thanks Ilya!) prior to merging it in the core > >>> > >>> On Fri, 3 Sep 2021, 18:50 Denis Magda, wrote: > >>> > Disagree to exclude this contribution from the 2.11 release. As Atri > explained, its implementation and testing approach is identical to the > >> AWS, > GCP and Kubernetes IP finders. > If we want to move the modules to extensions and improve the testing > approach, then it needs to be done for all similar components. > > Atri, have you tested the module in the cloud? If it works, then I > >> don't > see any reason why we need to have someone else double-checking this > >> once > again. This is the community, we need to trust each other. > > - > Denis > > On Fri, Sep 3, 2021 at 9:15 AM Atri Sharma wrote: > > > I would argue that the module Co exists with the other IP discovery > modules > > (such as GCP and AWS), which are part of core. > > > > In terms of tests, the azure module has exactly the same type of > >> tests as > > the other two modules mentioned above. > > > > On Fri, 3 Sep 2021, 17:54 Maxim Muzafarov, > >> wrote: > > > >> Folks, > >> > >> The patch [1] for the azure module seems to be ready for review, > >> however, there are still some questions that exist: > >> - Do we have a technical account in azure to test the moude on TC? > >> Manual testing for such changes is really annoying. > >> - Is there any reason to add these changes to the main Apache > >> Ignite > >> project? Why not extensions? > >> - It seems there is a lack of tests for this module. > >> > >> According to the mentions above, what do you think about moving > >> this > >> functionality to the next 2.12 release to solve all the questions > >> without a rush? I propose to revert the changes related to the > >> azure > >> functionality from the 2.11 branch. > >> > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-15388 > >> > >> On Fri, 27 Aug 2021 at 20:53, Dmitriy Pavlov > wrote: > >>> > >>> We had a separate discussion with Max and Alex, so I tend to > >> agree > that > >>> both issues are blockers. > >>> > >>> Sincerely, > >>> Dmitriy Pavlov > >>> > >>> пт, 27 авг. 2021 г. в 16:41, Alexey Gidaspov < > >> olive.c...@gmail.com>: > >>> > Hi, Maxim! > > These issues really block release. So we should wait fixes. > > On 2021/08/27 12:46:24, Maxim Muzafarov > >> wrote: > > Folks, > > > > > > I've been faced these issues, which seems to be a blocker > >> for the > > release. Please, take a look and share your thoughts. > > > > The server node fails when the client node with the higher > >> java > > version connects to it [1]. > > The Apache Ignite build fails with missing dependency [2]. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14725 > > [2] https://issues.apache.org/jira/browse/IGNITE-15388 > > > > On Mon, 9 Aug 2021 at 16:56, Maxim Muzafarov < > >> mmu...@apache.org> > >> wrote: > >> > >> +1 > >> > >> On Mon, 9 Aug 2021 at 16:27, Ivan Daschinsky < > > ivanda...@gmail.com> > wrote: > >>> > >>> I suppose, that > >> https://issues.apache.org/jira/browse/IGNITE-15274 > is a > >>> blocker. > >>> Fix is quite easy and straightforward > >>> > >>> пн, 2 авг. 2021 г. в 03:11, Igor Sapego < > >> isap...@apache.org > > : > >>> > Cherry-picked to release branch. > > Best Regards, > Igor > > >
Re: IEP-78 .NET Thin Client for Ignite 3.0
Makes sense, thanks! -Val On Fri, Sep 3, 2021 at 2:00 AM Pavel Tupitsyn wrote: > Hi Val, > > This is a very good point. > > I've looked around blogs, docs, and system APIs, and updated the IEP > accordingly: > For Ignite.NET I propose NOT to add sync methods when the actual > implementation is async: > - It is easy to consume async APIs in C# with async/await keywords (added > in 2012 and widely adopted) > - Most codebases are fully async anyway > - System APIs and popular libraries follow this direction > - Sync-over-async is misleading and can affect performance > > > However, I'm not so sure about Java, where async/await are not present, > overall async usage seems to be rarer, and removing sync methods may become > an obstacle for the users in some cases. > Let's create a separate discussion and see what others think. > > Pavel > > On Thu, Sep 2, 2021 at 10:32 PM Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > Hi Pavel, > > > > I've looked at the IEP and the public API - looks good to me. > > > > Quick question - do you plan to add sync methods to the interfaces, or > > you're thinking to only leave async? If the latter, what are the > arguments > > for this? The reason I'm asking is that I'm actually thinking about > > suggesting the same for Java as well (or at least having a discussion > about > > this). > > > > -Val > > > > On Thu, Sep 2, 2021 at 10:08 AM Pavel Tupitsyn > > wrote: > > > > > Igniters, > > > > > > Please review the IEP [1] and the PoC [2] for .NET Thin Client in > Ignite > > > 3.0. > > > > > > [1] > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-78+.NET+Thin+Client > > > [2] https://github.com/apache/ignite-3/pull/306 > > > > > >
