date:20181003

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4889


---

[jira] [Created] (IGNITE-9778) Gathering local node statistics on query level

2018-10-03 Thread Yury Gerzhedovich (JIRA)

Yury Gerzhedovich created IGNITE-9778:
-

 Summary: Gathering local node statistics on query level
 Key: IGNITE-9778
 URL: https://issues.apache.org/jira/browse/IGNITE-9778
 Project: Ignite
  Issue Type: Task
  Components: sql
Reporter: Yury Gerzhedovich
 Fix For: 2.8


Should be gathered and exposed IO statistics on query level. It should contains 
number of  physical read/write and logical read operations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Apache Ignite 2.7 release

Nikolay,

this has nothing about scaring someone. Let me explain about Apache Way.

Voting -1 to release does not mean blocking it, release can't be vetoed.
Approving release is done by policy: majority approval. 3+1 binding and
more +1 than -1. Consensus approval is better but not mandatory.

Instead, if PMC says -1 to code modification it means veto and can't be
bypassed to anyone. This is a very strong statement, which should be
applied reasonably and with technical justification. Lack of
understanding is not a justification.

So my point instead of vetoing bugfix let's veto commits where the bugs
were introduced. I feel a number of bugs reported recently are all
connected to WalManager, and these bugs may come from just a couple of
fixes. PDS tests were quite stable last time, so I think it is possible to
find out why WAL crashes and hangs.

Sincerely,
Dmitriy Pavlov

ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :

> Vladimir, Nikolay,
>
> For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> intervening. I've just run the reproducer from [1] against ignite-2.6
> branch and it has passed. So, it's not an legacy bug, we've brought it with
> some change of 2.7 scope. Is it still ok to ignore the bug?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-9776
>
> ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
>
> > Hello, Dmitriy.
> >
> > I'm sorry, but I don't understand your concern.
> >
> > Vladimir just asks experienced Ignite contributor to *explain impact* of
> a
> > bug.
> >
> > Why are you scaring us with your "-1"?
> > Is it Apache Way to do so?
> > What should be done for you to return to a constructive discussion?
> >
> > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > Hi Igniters, Vladimir,
> > >
> > > NPEs or hangs in WAL is a completely non-functional grid (if
> persistence
> > > enabled).
> > >
> > > I see no reasons to release 2.7 with such symptoms until we're sure it
> is
> > > too rare/impossible to reproduce. But it seems it is not the case. I
> will
> > > definitely vote -1 for the release if I'm aware of such problems exist
> > and
> > > were not researched. Community guarantees the quality and usability of
> > the
> > > product.
> > >
> > > We should ask and answer other questions:
> > > 1) why there are a lot of NPEs and hangs reported recently in the same
> > area
> > > 2) and why we signed-off commit(s).
> > >
> > > Probably we can identify and revert these commit(s) from 2.7 and
> research
> > > these failures in master (with no rush).
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov :
> > >
> > > > Andrey, Anton,
> > > >
> > > > How do you conclude that these tickets are blockers? What is the
> > impact to
> > > > users and in what circumstances users can met them?
> > > >
> > > > Note that we have many hundreds opened bugs, and yet we do not strive
> > to
> > > > include them all, because bug != blocker.
> > > >
> > > > So -1 from my side to including these tickets to release scope,
> unless
> > > > impact is explained.
> > > >
> > > > Vladimir.
> > > >
> > > > вт, 2 окт. 2018 г. в 22:45, Andrey Kuznetsov :
> > > >
> > > > > I've caught a bug [1] in FsyncModeFileWriteAheadLogManager. It
> looks
> > > >
> > > > like a
> > > > > release blocker to me.
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > > >
> > > > > вт, 2 окт. 2018 г. в 13:14, Dmitriy Pavlov  >:
> > > > >
> > > > > > Hi Anton,
> > > > > >
> > > > > >  I definitely agree it is a blocker.
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > вт, 2 окт. 2018 г. в 13:09, Anton Kalashnikov  >:
> > > > > >
> > > > > > > Hi Igniters.
> > > > > > >
> > > > > > > I have one more possible blockers - deadlock in archiver -
> > > > > > > https://issues.apache.org/jira/browse/IGNITE-9761. I almost
> > fixed
> > > >
> > > > it.
> > > > > > > It seems it should be include to scope.
> > > > > > >
> > > > > > > --
> > > > > > > Best regards,
> > > > > > > Anton Kalashnikov
> > > > > > >
> > > > > > >
> > > > > > > 02.10.2018, 00:08, "Dmitriy Setrakyan"  >:
> > > > > > > > Thanks, got it.
> > > > > > > >
> > > > > > > > On Mon, Oct 1, 2018 at 1:14 PM Dmitriy Pavlov <
> > > >
> > > > dpavlov@gmail.com
> > > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > >  Here I agree with Vladimir. Furthermore, I do my absolute
> > best to
> > > > > > >
> > > > > > > finalize
> > > > > > > > >  all reviews in all 2.7 tickets I'm related to. I think
> most
> > of
> > > >
> > > > the
> > > > > > > > >  contributors doing the same.
> > > > > > > > >
> > > > > > > > >  пн, 1 окт. 2018 г. в 23:03, Vladimir Ozerov <
> > > >
> > > > voze...@gridgain.com
> > > > > > :
> > > > > > > > >
> > > > > > > > >  > This is precisely the scope we have at the moment. All
> > these
> > > > > >
> > > > > > tickets
> > > > > > > were
> > > > > > > > >  > considered carefully on whether to include them into AI
> > 2.

Unknown Pair issue with OptimizedMarshaller

2018-10-03 Thread Sunny Chan

The fix for MarshallerContext in IGNITE-7794 has resolved part of the
problem with unknown pair, however, we can still trigger a further unknown
pair issue with the following sequence:

1) Connect a client node to a server node
2) send a couple of service call so that there are some objects is being
marshalled
3a) Stop the server node, removed the work directory (for example, docker
remove container that runs the server which would clear the work directory)
3b) leave the client node running so that it tries  to reconnect
4) Restart the server, let the client node reconnect and send service call

This will still trigger the Unknown Pair issue.

Upon further investigation, it seems that in the OptimizedMarshaller, it
caches the look up for the existing class descriptor
(OptimizedClassDescriptor) in the "clsmap". This is not cleared when the
client reconnects it will assume that the server still have the same
mapping and therefore attempt to send the invalid class id down the wire.

I have a hack to force the OptimizedMarshaller to check with the
MarshallerContext before using the cached OptimizedClassDescriptor. This
does fix the issue however there is a performance penalty as we need to
check the MarhsallerContext

I believe the proper fix for this problem should be by adding a hook to
clear the clsmap when the client reconnect, but I cannot identify the right
place to insert this hook. Can the community suggest a good place where
this hook can be inserted? Or is there any alternative fixes that you can
suggest?

Thanks
Sunny

Re: Danger (?) change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

2018-10-03 Thread Alexey Goncharuk

Vyacheslav,

Thanks for investigating this. User code should never listen to system
custom events because this is an internal API and it's a subject to change.
If there is anything a user interested in, the corresponding public event
should be added.

Nullifying the event in this case looks ok for me.

вс, 30 сент. 2018 г. в 11:45, Vyacheslav Daradur :

> I think that I understand a reason for doing this:
> The most custom events which handle in
> 'GridDhtPartitionsExchangeFuture' are using only in PME flow and
> reason is release them for GC as soon as possible.
>
> But there are some other systems which can listen to the same events,
> for example, to perform activation/deactivation actions them should
> handle [ChangeGlobalStateMessage, ChangeGlobalStateFinishMessage]
> which can be reset to 'null' by PME earlier then they will be handled
> by other systems.
>
> I'd suggest do not reset to 'null' custom messages in
> 'DiscoveryCustomEvent ' (at least without properly logic from the
> discovery-spi side).
>
> Thoughts?
>
>
>
> On Sat, Sep 29, 2018 at 11:43 PM Vyacheslav Daradur 
> wrote:
> >
> > Hi Igniters!
> >
> > I think I found an illegal behavior in
> > GridDhtPartitionsExchangeFuture#onDone, the following code is called
> > here:
> > ((DiscoveryCustomEvent)firstDiscoEvt).customMessage(null);
> >
> > That means a global instance of 'DiscoveryCustomEvent' is being
> > mutated outside discovery-spi infrastructure. It also means that
> > discovery listeners receive 'DiscoveryCustomEvent' with 'null' field
> > instead of 'CustomMessage' which they may rely on.
> >
> > Could someone confirm if it is wrong behavior and should be fixed?
> >
> > --
> > Best Regards, Vyacheslav D.
>
>
>
> --
> Best Regards, Vyacheslav D.
>

Re: [ML] New features and improvement of ML module for 2.7 release

Denis, Alexey,

thank you for work you do to make Ignite more recognizable.

Don't forget to encourage contributors to come not only to ML but to core
and to other modules as well :)

Sincerely,
Dmitriy Pavlov

ср, 3 окт. 2018 г. в 6:29, Denis Magda :

> Alexey,
>
> Thanks for spreading the word about the ML capabilities! *Prachi*, please
> help us to add the talks Alexey is going to give to Ignite events page:
> https://ignite.apache.org/events.html
>
> Btw, I gave a presentation about Ignite ML + TensorFlow integration today
> at IMC Summit in the US. It was perceived really well, was bombarded with
> many questions after the talk and think we've got some potential users ;)
>
> --
> Denis
>
> On Tue, Oct 2, 2018 at 8:54 AM Alexey Zinoviev 
> wrote:
>
> > Currently, in release 2.7, the ignite ML has a parity with a Spark ML by
> ML
> > algorithms, feature preprocessing and other capabilities.
> >
> > I'm going to talk about that in October on two conferences
> >
> > 1) [Ru] Yaroslavl, Open Source Distributed Machine Learning Library for
> > Apache Ignite https://yappidays.ru/talks.html#zinovev
> >
> > 2) [En] Minsk, Nuances of Machine Learning with Ignite ML,
> > https://jfuture.by/#talkbyAlexeyZinoviev
> >
> > After my previous event, JUG MSK, the new contributor @Ravil Galeyev
> joined
> > to our community, hope for new members from Yaroslavl and Minsk soon
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

[GitHub] ololo3000 opened a new pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

ololo3000 opened a new pull request #25: IGNITE-9645 [TC Bot] Add comparison of 
failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ignite pull request #4901: IGNITE-9728: fix setup IGNITE_HOME for tests

2018-10-03 Thread tledkov-gridgain

GitHub user tledkov-gridgain opened a pull request:

https://github.com/apache/ignite/pull/4901

IGNITE-9728: fix setup IGNITE_HOME for tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9728

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4901


commit e2ad60dacf4730897c7df22b5d68dd0fe8292d60
Author: tledkov-gridgain 
Date:   2018-10-03T09:28:42Z

IGNITE-9728: fix setup IGNITE_HOME for tests




---

Re: [ML] New features and improvement of ML module for 2.7 release

2018-10-03 Thread Alexey Zinoviev

It will be great if you can share your presentation/video after this summit
in dev-list.
Did you use a TensorFlow integration stand in your presentation?

Good news about potential users, it will be great to contact with somebody
who are going to use ML in production to discuss possible cases

ср, 3 окт. 2018 г. в 6:29, Denis Magda :

> Alexey,
>
> Thanks for spreading the word about the ML capabilities! *Prachi*, please
> help us to add the talks Alexey is going to give to Ignite events page:
> https://ignite.apache.org/events.html
>
> Btw, I gave a presentation about Ignite ML + TensorFlow integration today
> at IMC Summit in the US. It was perceived really well, was bombarded with
> many questions after the talk and think we've got some potential users ;)
>
> --
> Denis
>
> On Tue, Oct 2, 2018 at 8:54 AM Alexey Zinoviev 
> wrote:
>
> > Currently, in release 2.7, the ignite ML has a parity with a Spark ML by
> ML
> > algorithms, feature preprocessing and other capabilities.
> >
> > I'm going to talk about that in October on two conferences
> >
> > 1) [Ru] Yaroslavl, Open Source Distributed Machine Learning Library for
> > Apache Ignite https://yappidays.ru/talks.html#zinovev
> >
> > 2) [En] Minsk, Nuances of Machine Learning with Ignite ML,
> > https://jfuture.by/#talkbyAlexeyZinoviev
> >
> > After my previous event, JUG MSK, the new contributor @Ravil Galeyev
> joined
> > to our community, hope for new members from Yaroslavl and Minsk soon
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >
>

Re: [ML] New features and improvement of ML module for 2.7 release

2018-10-03 Thread Alexey Zinoviev

I will try, Dmitriy, of course, to encourage contributors to other modules.
But from my side the main problem is not enough
screencasts/tutorials/examples to run something interesting about other
modules.
Great to see something tasty in examples folder in 2.7 release.

If you need my help with examples, I could try to help to other modules.

ср, 3 окт. 2018 г. в 11:30, Dmitriy Pavlov :

> Denis, Alexey,
>
> thank you for work you do to make Ignite more recognizable.
>
> Don't forget to encourage contributors to come not only to ML but to core
> and to other modules as well :)
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 3 окт. 2018 г. в 6:29, Denis Magda :
>
> > Alexey,
> >
> > Thanks for spreading the word about the ML capabilities! *Prachi*, please
> > help us to add the talks Alexey is going to give to Ignite events page:
> > https://ignite.apache.org/events.html
> >
> > Btw, I gave a presentation about Ignite ML + TensorFlow integration today
> > at IMC Summit in the US. It was perceived really well, was bombarded with
> > many questions after the talk and think we've got some potential users ;)
> >
> > --
> > Denis
> >
> > On Tue, Oct 2, 2018 at 8:54 AM Alexey Zinoviev 
> > wrote:
> >
> > > Currently, in release 2.7, the ignite ML has a parity with a Spark ML
> by
> > ML
> > > algorithms, feature preprocessing and other capabilities.
> > >
> > > I'm going to talk about that in October on two conferences
> > >
> > > 1) [Ru] Yaroslavl, Open Source Distributed Machine Learning Library for
> > > Apache Ignite https://yappidays.ru/talks.html#zinovev
> > >
> > > 2) [En] Minsk, Nuances of Machine Learning with Ignite ML,
> > > https://jfuture.by/#talkbyAlexeyZinoviev
> > >
> > > After my previous event, JUG MSK, the new contributor @Ravil Galeyev
> > joined
> > > to our community, hope for new members from Yaroslavl and Minsk soon
> > >
> > >
> > >
> > > --
> > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > >
> >
>

[GitHub] ignite pull request #4871: IGNITE-9727: fix ignite.sh & ignite.bat start scr...

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4871


---

Re: Apache Ignite 2.7 release

2018-10-03 Thread Vladimir Ozerov

Nobody vetos anything, let's stop use this term unless some really
important problem is discussed.

At this point we are in situation when new tickets are still included into
the scope. All want to ask is to stop including new tickets without
explaining on why they should be in AI 2.7. Regression between is AI 2.6
and AI 2.7 is enough. But "I found new NPE" is not.

On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
wrote:

> Nikolay,
>
> this has nothing about scaring someone. Let me explain about Apache Way.
>
> Voting -1 to release does not mean blocking it, release can't be vetoed.
> Approving release is done by policy: majority approval. 3+1 binding and
> more +1 than -1. Consensus approval is better but not mandatory.
>
> Instead, if PMC says -1 to code modification it means veto and can't be
> bypassed to anyone. This is a very strong statement, which should be
> applied reasonably and with technical justification. Lack of
> understanding is not a justification.
>
> So my point instead of vetoing bugfix let's veto commits where the bugs
> were introduced. I feel a number of bugs reported recently are all
> connected to WalManager, and these bugs may come from just a couple of
> fixes. PDS tests were quite stable last time, so I think it is possible to
> find out why WAL crashes and hangs.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
>
> > Vladimir, Nikolay,
> >
> > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> > intervening. I've just run the reproducer from [1] against ignite-2.6
> > branch and it has passed. So, it's not an legacy bug, we've brought it
> with
> > some change of 2.7 scope. Is it still ok to ignore the bug?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> >
> > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
> >
> > > Hello, Dmitriy.
> > >
> > > I'm sorry, but I don't understand your concern.
> > >
> > > Vladimir just asks experienced Ignite contributor to *explain impact*
> of
> > a
> > > bug.
> > >
> > > Why are you scaring us with your "-1"?
> > > Is it Apache Way to do so?
> > > What should be done for you to return to a constructive discussion?
> > >
> > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > Hi Igniters, Vladimir,
> > > >
> > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > persistence
> > > > enabled).
> > > >
> > > > I see no reasons to release 2.7 with such symptoms until we're sure
> it
> > is
> > > > too rare/impossible to reproduce. But it seems it is not the case. I
> > will
> > > > definitely vote -1 for the release if I'm aware of such problems
> exist
> > > and
> > > > were not researched. Community guarantees the quality and usability
> of
> > > the
> > > > product.
> > > >
> > > > We should ask and answer other questions:
> > > > 1) why there are a lot of NPEs and hangs reported recently in the
> same
> > > area
> > > > 2) and why we signed-off commit(s).
> > > >
> > > > Probably we can identify and revert these commit(s) from 2.7 and
> > research
> > > > these failures in master (with no rush).
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov :
> > > >
> > > > > Andrey, Anton,
> > > > >
> > > > > How do you conclude that these tickets are blockers? What is the
> > > impact to
> > > > > users and in what circumstances users can met them?
> > > > >
> > > > > Note that we have many hundreds opened bugs, and yet we do not
> strive
> > > to
> > > > > include them all, because bug != blocker.
> > > > >
> > > > > So -1 from my side to including these tickets to release scope,
> > unless
> > > > > impact is explained.
> > > > >
> > > > > Vladimir.
> > > > >
> > > > > вт, 2 окт. 2018 г. в 22:45, Andrey Kuznetsov :
> > > > >
> > > > > > I've caught a bug [1] in FsyncModeFileWriteAheadLogManager. It
> > looks
> > > > >
> > > > > like a
> > > > > > release blocker to me.
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > > > >
> > > > > > вт, 2 окт. 2018 г. в 13:14, Dmitriy Pavlov <
> dpavlov@gmail.com
> > >:
> > > > > >
> > > > > > > Hi Anton,
> > > > > > >
> > > > > > >  I definitely agree it is a blocker.
> > > > > > >
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > >
> > > > > > > вт, 2 окт. 2018 г. в 13:09, Anton Kalashnikov <
> kaa@yandex.ru
> > >:
> > > > > > >
> > > > > > > > Hi Igniters.
> > > > > > > >
> > > > > > > > I have one more possible blockers - deadlock in archiver -
> > > > > > > > https://issues.apache.org/jira/browse/IGNITE-9761. I almost
> > > fixed
> > > > >
> > > > > it.
> > > > > > > > It seems it should be include to scope.
> > > > > > > >
> > > > > > > > --
> > > > > > > > Best regards,
> > > > > > > > Anton Kalashnikov
> > > > > > > >
> > > > > > > >
> > > > > > > > 02.10.2018, 00:08, "Dmitriy Setrakyan" <
> dsetrak...@apache.org
> > >:
> > > > > > > > > Thanks, got it.
> > > > > > > > >
> > > > > > > > > On Mon,

Re: Apache Ignite 2.7 release

2018-10-03 Thread Vladimir Ozerov

Nobody vetos anything, let's stop use this term unless some really
important problem is discussed.

At this point we are in situation when new tickets are still included into
the scope. All I want to ask is to stop including new tickets without
explaining why they should be in AI 2.7. Regression between AI 2.6 and AI
2.7 is enough. But "I found new NPE" is not.

On Wed, Oct 3, 2018 at 1:24 PM Vladimir Ozerov  wrote:

> Nobody vetos anything, let's stop use this term unless some really
> important problem is discussed.
>
> At this point we are in situation when new tickets are still included into
> the scope. All want to ask is to stop including new tickets without
> explaining on why they should be in AI 2.7. Regression between is AI 2.6
> and AI 2.7 is enough. But "I found new NPE" is not.
>
> On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
> wrote:
>
>> Nikolay,
>>
>> this has nothing about scaring someone. Let me explain about Apache Way.
>>
>> Voting -1 to release does not mean blocking it, release can't be vetoed.
>> Approving release is done by policy: majority approval. 3+1 binding and
>> more +1 than -1. Consensus approval is better but not mandatory.
>>
>> Instead, if PMC says -1 to code modification it means veto and can't be
>> bypassed to anyone. This is a very strong statement, which should be
>> applied reasonably and with technical justification. Lack of
>> understanding is not a justification.
>>
>> So my point instead of vetoing bugfix let's veto commits where the bugs
>> were introduced. I feel a number of bugs reported recently are all
>> connected to WalManager, and these bugs may come from just a couple of
>> fixes. PDS tests were quite stable last time, so I think it is possible to
>> find out why WAL crashes and hangs.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
>>
>> > Vladimir, Nikolay,
>> >
>> > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
>> > intervening. I've just run the reproducer from [1] against ignite-2.6
>> > branch and it has passed. So, it's not an legacy bug, we've brought it
>> with
>> > some change of 2.7 scope. Is it still ok to ignore the bug?
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-9776
>> >
>> > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
>> >
>> > > Hello, Dmitriy.
>> > >
>> > > I'm sorry, but I don't understand your concern.
>> > >
>> > > Vladimir just asks experienced Ignite contributor to *explain impact*
>> of
>> > a
>> > > bug.
>> > >
>> > > Why are you scaring us with your "-1"?
>> > > Is it Apache Way to do so?
>> > > What should be done for you to return to a constructive discussion?
>> > >
>> > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
>> > > > Hi Igniters, Vladimir,
>> > > >
>> > > > NPEs or hangs in WAL is a completely non-functional grid (if
>> > persistence
>> > > > enabled).
>> > > >
>> > > > I see no reasons to release 2.7 with such symptoms until we're sure
>> it
>> > is
>> > > > too rare/impossible to reproduce. But it seems it is not the case. I
>> > will
>> > > > definitely vote -1 for the release if I'm aware of such problems
>> exist
>> > > and
>> > > > were not researched. Community guarantees the quality and usability
>> of
>> > > the
>> > > > product.
>> > > >
>> > > > We should ask and answer other questions:
>> > > > 1) why there are a lot of NPEs and hangs reported recently in the
>> same
>> > > area
>> > > > 2) and why we signed-off commit(s).
>> > > >
>> > > > Probably we can identify and revert these commit(s) from 2.7 and
>> > research
>> > > > these failures in master (with no rush).
>> > > >
>> > > > Sincerely,
>> > > > Dmitriy Pavlov
>> > > >
>> > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov :
>> > > >
>> > > > > Andrey, Anton,
>> > > > >
>> > > > > How do you conclude that these tickets are blockers? What is the
>> > > impact to
>> > > > > users and in what circumstances users can met them?
>> > > > >
>> > > > > Note that we have many hundreds opened bugs, and yet we do not
>> strive
>> > > to
>> > > > > include them all, because bug != blocker.
>> > > > >
>> > > > > So -1 from my side to including these tickets to release scope,
>> > unless
>> > > > > impact is explained.
>> > > > >
>> > > > > Vladimir.
>> > > > >
>> > > > > вт, 2 окт. 2018 г. в 22:45, Andrey Kuznetsov :
>> > > > >
>> > > > > > I've caught a bug [1] in FsyncModeFileWriteAheadLogManager. It
>> > looks
>> > > > >
>> > > > > like a
>> > > > > > release blocker to me.
>> > > > > >
>> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
>> > > > > >
>> > > > > > вт, 2 окт. 2018 г. в 13:14, Dmitriy Pavlov <
>> dpavlov@gmail.com
>> > >:
>> > > > > >
>> > > > > > > Hi Anton,
>> > > > > > >
>> > > > > > >  I definitely agree it is a blocker.
>> > > > > > >
>> > > > > > > Sincerely,
>> > > > > > > Dmitriy Pavlov
>> > > > > > >
>> > > > > > > вт, 2 окт. 2018 г. в 13:09, Anton Kalashnikov <
>> kaa@yandex.ru
>> > >:
>> > > > > > >
>> > > > > > > > Hi

[jira] [Created] (IGNITE-9779) Support Java 9/10/11 in C++ tests

2018-10-03 Thread Ilya Kasnacheev (JIRA)

Ilya Kasnacheev created IGNITE-9779:
---

 Summary: Support Java 9/10/11 in C++ tests
 Key: IGNITE-9779
 URL: https://issues.apache.org/jira/browse/IGNITE-9779
 Project: Ignite
  Issue Type: Sub-task
  Components: platforms
Affects Versions: 2.5
Reporter: Ilya Kasnacheev


Right now, it does not work.

Linux builds fail with return code -1
Windows builds complain:
{code}
aborted
std::exception: JVM library is not found (did you set JAVA_HOME environment 
variable?)
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #4828: IGNITE-9691 testConcurrentAuthorize uses outdated...

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4828


---

Re: Apache Ignite 2.7 release

2018-10-03 Thread Nikolay Izhikov

Hello, Igniters.

Release scope is frozen.
Please, if you include some new issues in release - discuss it in this thread.

Alexey, can you, please, comment on including fix for IGNITE-9760, IGNITE-9761 
in 2.7 branch.

https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69

В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> Nobody vetos anything, let's stop use this term unless some really
> important problem is discussed.
> 
> At this point we are in situation when new tickets are still included into
> the scope. All want to ask is to stop including new tickets without
> explaining on why they should be in AI 2.7. Regression between is AI 2.6
> and AI 2.7 is enough. But "I found new NPE" is not.
> 
> On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
> wrote:
> 
> > Nikolay,
> > 
> > this has nothing about scaring someone. Let me explain about Apache Way.
> > 
> > Voting -1 to release does not mean blocking it, release can't be vetoed.
> > Approving release is done by policy: majority approval. 3+1 binding and
> > more +1 than -1. Consensus approval is better but not mandatory.
> > 
> > Instead, if PMC says -1 to code modification it means veto and can't be
> > bypassed to anyone. This is a very strong statement, which should be
> > applied reasonably and with technical justification. Lack of
> > understanding is not a justification.
> > 
> > So my point instead of vetoing bugfix let's veto commits where the bugs
> > were introduced. I feel a number of bugs reported recently are all
> > connected to WalManager, and these bugs may come from just a couple of
> > fixes. PDS tests were quite stable last time, so I think it is possible to
> > find out why WAL crashes and hangs.
> > 
> > Sincerely,
> > Dmitriy Pavlov
> > 
> > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
> > 
> > > Vladimir, Nikolay,
> > > 
> > > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> > > intervening. I've just run the reproducer from [1] against ignite-2.6
> > > branch and it has passed. So, it's not an legacy bug, we've brought it
> > 
> > with
> > > some change of 2.7 scope. Is it still ok to ignore the bug?
> > > 
> > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > 
> > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
> > > 
> > > > Hello, Dmitriy.
> > > > 
> > > > I'm sorry, but I don't understand your concern.
> > > > 
> > > > Vladimir just asks experienced Ignite contributor to *explain impact*
> > 
> > of
> > > a
> > > > bug.
> > > > 
> > > > Why are you scaring us with your "-1"?
> > > > Is it Apache Way to do so?
> > > > What should be done for you to return to a constructive discussion?
> > > > 
> > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > > Hi Igniters, Vladimir,
> > > > > 
> > > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > > 
> > > persistence
> > > > > enabled).
> > > > > 
> > > > > I see no reasons to release 2.7 with such symptoms until we're sure
> > 
> > it
> > > is
> > > > > too rare/impossible to reproduce. But it seems it is not the case. I
> > > 
> > > will
> > > > > definitely vote -1 for the release if I'm aware of such problems
> > 
> > exist
> > > > and
> > > > > were not researched. Community guarantees the quality and usability
> > 
> > of
> > > > the
> > > > > product.
> > > > > 
> > > > > We should ask and answer other questions:
> > > > > 1) why there are a lot of NPEs and hangs reported recently in the
> > 
> > same
> > > > area
> > > > > 2) and why we signed-off commit(s).
> > > > > 
> > > > > Probably we can identify and revert these commit(s) from 2.7 and
> > > 
> > > research
> > > > > these failures in master (with no rush).
> > > > > 
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > > 
> > > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov :
> > > > > 
> > > > > > Andrey, Anton,
> > > > > > 
> > > > > > How do you conclude that these tickets are blockers? What is the
> > > > 
> > > > impact to
> > > > > > users and in what circumstances users can met them?
> > > > > > 
> > > > > > Note that we have many hundreds opened bugs, and yet we do not
> > 
> > strive
> > > > to
> > > > > > include them all, because bug != blocker.
> > > > > > 
> > > > > > So -1 from my side to including these tickets to release scope,
> > > 
> > > unless
> > > > > > impact is explained.
> > > > > > 
> > > > > > Vladimir.
> > > > > > 
> > > > > > вт, 2 окт. 2018 г. в 22:45, Andrey Kuznetsov :
> > > > > > 
> > > > > > > I've caught a bug [1] in FsyncModeFileWriteAheadLogManager. It
> > > 
> > > looks
> > > > > > 
> > > > > > like a
> > > > > > > release blocker to me.
> > > > > > > 
> > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > > > > > 
> > > > > > > вт, 2 окт. 2018 г. в 13:14, Dmitriy Pavlov <
> > 
> > dpavlov@gmail.com
> > > > :
> > > > > > > 
> > >

Re: Apache Ignite 2.7 release

Hi Igniters,

After a short chat with Vladimir I understood the concern, it should be a
regression, but not just a bug, which existed for years. It is the case of
all fixes related to WAL nowadays.

I can research a bit which ticket caused regression, but I see no reason to
do if we already have fixes instead.

Nikolay,

we've passed only scope freeze, but not code freeze. I've mentioned we
should discuss ticket including in our process, and features are
prohibited, but please note it is a draft for now.

Sincerely,
Dmitriy Pavlov

ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :

> Hello, Igniters.
>
> Release scope is frozen.
> Please, if you include some new issues in release - discuss it in this
> thread.
>
> Alexey, can you, please, comment on including fix for IGNITE-9760,
> IGNITE-9761 in 2.7 branch.
>
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
>
> В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> > Nobody vetos anything, let's stop use this term unless some really
> > important problem is discussed.
> >
> > At this point we are in situation when new tickets are still included
> into
> > the scope. All want to ask is to stop including new tickets without
> > explaining on why they should be in AI 2.7. Regression between is AI 2.6
> > and AI 2.7 is enough. But "I found new NPE" is not.
> >
> > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
> > wrote:
> >
> > > Nikolay,
> > >
> > > this has nothing about scaring someone. Let me explain about Apache
> Way.
> > >
> > > Voting -1 to release does not mean blocking it, release can't be
> vetoed.
> > > Approving release is done by policy: majority approval. 3+1 binding and
> > > more +1 than -1. Consensus approval is better but not mandatory.
> > >
> > > Instead, if PMC says -1 to code modification it means veto and can't be
> > > bypassed to anyone. This is a very strong statement, which should be
> > > applied reasonably and with technical justification. Lack of
> > > understanding is not a justification.
> > >
> > > So my point instead of vetoing bugfix let's veto commits where the bugs
> > > were introduced. I feel a number of bugs reported recently are all
> > > connected to WalManager, and these bugs may come from just a couple of
> > > fixes. PDS tests were quite stable last time, so I think it is
> possible to
> > > find out why WAL crashes and hangs.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
> > >
> > > > Vladimir, Nikolay,
> > > >
> > > > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> > > > intervening. I've just run the reproducer from [1] against ignite-2.6
> > > > branch and it has passed. So, it's not an legacy bug, we've brought
> it
> > >
> > > with
> > > > some change of 2.7 scope. Is it still ok to ignore the bug?
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > >
> > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
> > > >
> > > > > Hello, Dmitriy.
> > > > >
> > > > > I'm sorry, but I don't understand your concern.
> > > > >
> > > > > Vladimir just asks experienced Ignite contributor to *explain
> impact*
> > >
> > > of
> > > > a
> > > > > bug.
> > > > >
> > > > > Why are you scaring us with your "-1"?
> > > > > Is it Apache Way to do so?
> > > > > What should be done for you to return to a constructive discussion?
> > > > >
> > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > > > Hi Igniters, Vladimir,
> > > > > >
> > > > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > > >
> > > > persistence
> > > > > > enabled).
> > > > > >
> > > > > > I see no reasons to release 2.7 with such symptoms until we're
> sure
> > >
> > > it
> > > > is
> > > > > > too rare/impossible to reproduce. But it seems it is not the
> case. I
> > > >
> > > > will
> > > > > > definitely vote -1 for the release if I'm aware of such problems
> > >
> > > exist
> > > > > and
> > > > > > were not researched. Community guarantees the quality and
> usability
> > >
> > > of
> > > > > the
> > > > > > product.
> > > > > >
> > > > > > We should ask and answer other questions:
> > > > > > 1) why there are a lot of NPEs and hangs reported recently in the
> > >
> > > same
> > > > > area
> > > > > > 2) and why we signed-off commit(s).
> > > > > >
> > > > > > Probably we can identify and revert these commit(s) from 2.7 and
> > > >
> > > > research
> > > > > > these failures in master (with no rush).
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov <
> voze...@gridgain.com>:
> > > > > >
> > > > > > > Andrey, Anton,
> > > > > > >
> > > > > > > How do you conclude that these tickets are blockers? What is
> the
> > > > >
> > > > > impact to
> > > > > > > users and in what circumsta

Re: Apache Ignite 2.7 release

2018-10-03 Thread Alexey Goncharuk

Nikolay, both commits fixed a regression compared to ignite-2.6. First one
was mentioned by Anton Kalashnikov before (java-level deadlock during WAL
flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL flush).

--AG

ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :

> Hello, Igniters.
>
> Release scope is frozen.
> Please, if you include some new issues in release - discuss it in this
> thread.
>
> Alexey, can you, please, comment on including fix for IGNITE-9760,
> IGNITE-9761 in 2.7 branch.
>
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
>
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
>
> В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> > Nobody vetos anything, let's stop use this term unless some really
> > important problem is discussed.
> >
> > At this point we are in situation when new tickets are still included
> into
> > the scope. All want to ask is to stop including new tickets without
> > explaining on why they should be in AI 2.7. Regression between is AI 2.6
> > and AI 2.7 is enough. But "I found new NPE" is not.
> >
> > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
> > wrote:
> >
> > > Nikolay,
> > >
> > > this has nothing about scaring someone. Let me explain about Apache
> Way.
> > >
> > > Voting -1 to release does not mean blocking it, release can't be
> vetoed.
> > > Approving release is done by policy: majority approval. 3+1 binding and
> > > more +1 than -1. Consensus approval is better but not mandatory.
> > >
> > > Instead, if PMC says -1 to code modification it means veto and can't be
> > > bypassed to anyone. This is a very strong statement, which should be
> > > applied reasonably and with technical justification. Lack of
> > > understanding is not a justification.
> > >
> > > So my point instead of vetoing bugfix let's veto commits where the bugs
> > > were introduced. I feel a number of bugs reported recently are all
> > > connected to WalManager, and these bugs may come from just a couple of
> > > fixes. PDS tests were quite stable last time, so I think it is
> possible to
> > > find out why WAL crashes and hangs.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
> > >
> > > > Vladimir, Nikolay,
> > > >
> > > > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> > > > intervening. I've just run the reproducer from [1] against ignite-2.6
> > > > branch and it has passed. So, it's not an legacy bug, we've brought
> it
> > >
> > > with
> > > > some change of 2.7 scope. Is it still ok to ignore the bug?
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > >
> > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
> > > >
> > > > > Hello, Dmitriy.
> > > > >
> > > > > I'm sorry, but I don't understand your concern.
> > > > >
> > > > > Vladimir just asks experienced Ignite contributor to *explain
> impact*
> > >
> > > of
> > > > a
> > > > > bug.
> > > > >
> > > > > Why are you scaring us with your "-1"?
> > > > > Is it Apache Way to do so?
> > > > > What should be done for you to return to a constructive discussion?
> > > > >
> > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > > > Hi Igniters, Vladimir,
> > > > > >
> > > > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > > >
> > > > persistence
> > > > > > enabled).
> > > > > >
> > > > > > I see no reasons to release 2.7 with such symptoms until we're
> sure
> > >
> > > it
> > > > is
> > > > > > too rare/impossible to reproduce. But it seems it is not the
> case. I
> > > >
> > > > will
> > > > > > definitely vote -1 for the release if I'm aware of such problems
> > >
> > > exist
> > > > > and
> > > > > > were not researched. Community guarantees the quality and
> usability
> > >
> > > of
> > > > > the
> > > > > > product.
> > > > > >
> > > > > > We should ask and answer other questions:
> > > > > > 1) why there are a lot of NPEs and hangs reported recently in the
> > >
> > > same
> > > > > area
> > > > > > 2) and why we signed-off commit(s).
> > > > > >
> > > > > > Probably we can identify and revert these commit(s) from 2.7 and
> > > >
> > > > research
> > > > > > these failures in master (with no rush).
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov <
> voze...@gridgain.com>:
> > > > > >
> > > > > > > Andrey, Anton,
> > > > > > >
> > > > > > > How do you conclude that these tickets are blockers? What is
> the
> > > > >
> > > > > impact to
> > > > > > > users and in what circumstances users can met them?
> > > > > > >
> > > > > > > Note that we have many hundreds opened bugs, and yet we do not
> > >
> > > strive
> > > > > to
> > > > > > > include them all, because bug != blocker.
> > > > > > >
> > > > > > > So -1 from my side to including these tickets to release scope,
> > > >
> >

Re: Apache Ignite 2.7 release

2018-10-03 Thread Nikolay Izhikov

Alexey.

Sorry, I lost link to IGNITE-9760 in this thread :)

Thanks, for a clarification.


В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет:
> Nikolay, both commits fixed a regression compared to ignite-2.6. First one 
> was mentioned by Anton Kalashnikov before (java-level deadlock during WAL 
> flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL flush).
> 
> --AG
> 
> ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :
> > Hello, Igniters.
> > 
> > Release scope is frozen.
> > Please, if you include some new issues in release - discuss it in this 
> > thread.
> > 
> > Alexey, can you, please, comment on including fix for IGNITE-9760, 
> > IGNITE-9761 in 2.7 branch.
> > 
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
> > https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
> > 
> > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> > > Nobody vetos anything, let's stop use this term unless some really
> > > important problem is discussed.
> > > 
> > > At this point we are in situation when new tickets are still included into
> > > the scope. All want to ask is to stop including new tickets without
> > > explaining on why they should be in AI 2.7. Regression between is AI 2.6
> > > and AI 2.7 is enough. But "I found new NPE" is not.
> > > 
> > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov 
> > > wrote:
> > > 
> > > > Nikolay,
> > > > 
> > > > this has nothing about scaring someone. Let me explain about Apache Way.
> > > > 
> > > > Voting -1 to release does not mean blocking it, release can't be vetoed.
> > > > Approving release is done by policy: majority approval. 3+1 binding and
> > > > more +1 than -1. Consensus approval is better but not mandatory.
> > > > 
> > > > Instead, if PMC says -1 to code modification it means veto and can't be
> > > > bypassed to anyone. This is a very strong statement, which should be
> > > > applied reasonably and with technical justification. Lack of
> > > > understanding is not a justification.
> > > > 
> > > > So my point instead of vetoing bugfix let's veto commits where the bugs
> > > > were introduced. I feel a number of bugs reported recently are all
> > > > connected to WalManager, and these bugs may come from just a couple of
> > > > fixes. PDS tests were quite stable last time, so I think it is possible 
> > > > to
> > > > find out why WAL crashes and hangs.
> > > > 
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > > 
> > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
> > > > 
> > > > > Vladimir, Nikolay,
> > > > > 
> > > > > For sure, I'm not an experienced Ignite contributor, so I'm sorry for
> > > > > intervening. I've just run the reproducer from [1] against ignite-2.6
> > > > > branch and it has passed. So, it's not an legacy bug, we've brought it
> > > > 
> > > > with
> > > > > some change of 2.7 scope. Is it still ok to ignore the bug?
> > > > > 
> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > > > 
> > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov :
> > > > > 
> > > > > > Hello, Dmitriy.
> > > > > > 
> > > > > > I'm sorry, but I don't understand your concern.
> > > > > > 
> > > > > > Vladimir just asks experienced Ignite contributor to *explain 
> > > > > > impact*
> > > > 
> > > > of
> > > > > a
> > > > > > bug.
> > > > > > 
> > > > > > Why are you scaring us with your "-1"?
> > > > > > Is it Apache Way to do so?
> > > > > > What should be done for you to return to a constructive discussion?
> > > > > > 
> > > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > > > > Hi Igniters, Vladimir,
> > > > > > > 
> > > > > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > > > > 
> > > > > persistence
> > > > > > > enabled).
> > > > > > > 
> > > > > > > I see no reasons to release 2.7 with such symptoms until we're 
> > > > > > > sure
> > > > 
> > > > it
> > > > > is
> > > > > > > too rare/impossible to reproduce. But it seems it is not the 
> > > > > > > case. I
> > > > > 
> > > > > will
> > > > > > > definitely vote -1 for the release if I'm aware of such problems
> > > > 
> > > > exist
> > > > > > and
> > > > > > > were not researched. Community guarantees the quality and 
> > > > > > > usability
> > > > 
> > > > of
> > > > > > the
> > > > > > > product.
> > > > > > > 
> > > > > > > We should ask and answer other questions:
> > > > > > > 1) why there are a lot of NPEs and hangs reported recently in the
> > > > 
> > > > same
> > > > > > area
> > > > > > > 2) and why we signed-off commit(s).
> > > > > > > 
> > > > > > > Probably we can identify and revert these commit(s) from 2.7 and
> > > > > 
> > > > > research
> > > > > > > these failures in master (with no rush).
> > > > > > > 
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > > 
> > > > > > > вт, 2 окт. 2018 г. в 23:54, Vladimir Ozerov 
> > > > > > > :
> > > > > > > 
> > > > > > > > Andrey, Anton

[GitHub] ignite pull request #4902: IGNTIE-9722

GitHub user devozerov opened a pull request:

https://github.com/apache/ignite/pull/4902

IGNTIE-9722



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9722-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4902.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4902


commit 405342d649c9723297eec431ff3f7b3e4d95e1aa
Author: devozerov 
Date:   2018-10-02T13:33:30Z

Adopted test for better output.

commit 4fdcd160d4c349665d763696fca639c0d4b3fd8f
Author: devozerov 
Date:   2018-10-02T14:19:00Z

Debug.

commit 14d482200066aa4bdb8923369810a14263917b1b
Author: devozerov 
Date:   2018-10-02T14:44:13Z

Debug.

commit 1840b8a7b2ff3b137f751d7b3d8568edc418de7d
Author: devozerov 
Date:   2018-10-02T15:19:26Z

WIP.

commit e1392cbf742459dd7f05be1f2b3955110038b9c7
Author: devozerov 
Date:   2018-10-03T11:09:27Z

WIP.

commit f71ec2924eb6266c5ba04916d4be84a6b6a1c067
Author: devozerov 
Date:   2018-10-03T11:10:06Z

Merge branch 'master' into ignite-9722-1

commit 724ab42d61a1cbd6712949b2363210cd5d9d0af1
Author: devozerov 
Date:   2018-10-03T11:11:39Z

WIP.

commit 4eaf80a7391fe8995d5244dbd008486e39d9f8cf
Author: devozerov 
Date:   2018-10-03T11:12:04Z

WIP.

commit 57427d2f1a3b40c23e6e37f1ffac372fecb020a2
Author: devozerov 
Date:   2018-10-03T11:14:45Z

WIP.

commit ee9cc59d2e8f2c2e15fee97660d920bbbd13d751
Author: devozerov 
Date:   2018-10-03T11:16:03Z

WIP.

commit 03a6980f2c76597330833fa4faaa6d1f04eb2e03
Author: devozerov 
Date:   2018-10-03T11:19:08Z

WIP.




---

[GitHub] ignite pull request #4902: IGNTIE-9722

Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/4902


---

[GitHub] ignite pull request #4903: IGNITE-9722

GitHub user devozerov opened a pull request:

https://github.com/apache/ignite/pull/4903

IGNITE-9722



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9722-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4903


commit 405342d649c9723297eec431ff3f7b3e4d95e1aa
Author: devozerov 
Date:   2018-10-02T13:33:30Z

Adopted test for better output.

commit 4fdcd160d4c349665d763696fca639c0d4b3fd8f
Author: devozerov 
Date:   2018-10-02T14:19:00Z

Debug.

commit 14d482200066aa4bdb8923369810a14263917b1b
Author: devozerov 
Date:   2018-10-02T14:44:13Z

Debug.

commit 1840b8a7b2ff3b137f751d7b3d8568edc418de7d
Author: devozerov 
Date:   2018-10-02T15:19:26Z

WIP.

commit e1392cbf742459dd7f05be1f2b3955110038b9c7
Author: devozerov 
Date:   2018-10-03T11:09:27Z

WIP.

commit f71ec2924eb6266c5ba04916d4be84a6b6a1c067
Author: devozerov 
Date:   2018-10-03T11:10:06Z

Merge branch 'master' into ignite-9722-1

commit 724ab42d61a1cbd6712949b2363210cd5d9d0af1
Author: devozerov 
Date:   2018-10-03T11:11:39Z

WIP.

commit 4eaf80a7391fe8995d5244dbd008486e39d9f8cf
Author: devozerov 
Date:   2018-10-03T11:12:04Z

WIP.

commit 57427d2f1a3b40c23e6e37f1ffac372fecb020a2
Author: devozerov 
Date:   2018-10-03T11:14:45Z

WIP.

commit ee9cc59d2e8f2c2e15fee97660d920bbbd13d751
Author: devozerov 
Date:   2018-10-03T11:16:03Z

WIP.

commit 03a6980f2c76597330833fa4faaa6d1f04eb2e03
Author: devozerov 
Date:   2018-10-03T11:19:08Z

WIP.




---

[jira] [Created] (IGNITE-9780) SQL system view for cache groups

2018-10-03 Thread Aleksey Plekhanov (JIRA)

Aleksey Plekhanov created IGNITE-9780:
-

 Summary: SQL system view for cache groups
 Key: IGNITE-9780
 URL: https://issues.apache.org/jira/browse/IGNITE-9780
 Project: Ignite
  Issue Type: Task
  Components: sql
Reporter: Aleksey Plekhanov
Assignee: Aleksey Plekhanov


Implement SQL system view to show list of cache groups. 
View must contain information: cache group id, cache group name, caches count, 
and attributes related to cache group from CacheConfiguration (at least 
attributes checked in {{ClusterCachesInfo#validateCacheGroupConfiguration()}} 
method)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-9781) JDK11: SSL handshake is failed

2018-10-03 Thread Taras Ledkov (JIRA)

Taras Ledkov created IGNITE-9781:


 Summary: JDK11: SSL handshake is failed
 Key: IGNITE-9781
 URL: https://issues.apache.org/jira/browse/IGNITE-9781
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.6
 Environment: JDK11
Reporter: Taras Ledkov
 Fix For: 2.7


The problem is reproduced on JDK11 by the test 
{{GridNioSslSelfTest.testSimpleMessages}}
Error on the Ignite node
{code}
java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:148)
at 
java.base/sun.security.ssl.ServerHello$T13ServerHelloProducer.produce(ServerHello.java:551)
at 
java.base/sun.security.ssl.SSLHandshake.produce(SSLHandshake.java:436)
at 
java.base/sun.security.ssl.ClientHello$T13ClientHelloConsumer.goServerHello(ClientHello.java:1189)
at 
java.base/sun.security.ssl.ClientHello$T13ClientHelloConsumer.consume(ClientHello.java:1125)
at 
java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.onClientHello(ClientHello.java:831)
at 
java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.consume(ClientHello.java:792)
at 
java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
at 
java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:444)
at 
java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1065)
at 
java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:1052)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at 
java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask.run(SSLEngineImpl.java:999)
at 
org.apache.ignite.internal.util.nio.ssl.GridNioSslHandler.runTasks(GridNioSslHandler.java:624)
at 
org.apache.ignite.internal.util.nio.ssl.GridNioSslHandler.handshake(GridNioSslHandler.java:243)
at 
org.apache.ignite.internal.util.nio.ssl.GridNioSslHandler.messageReceived(GridNioSslHandler.java:321)
at 
org.apache.ignite.internal.util.nio.ssl.GridNioSslFilter.onMessageReceived(GridNioSslFilter.java:330)
at 
org.apache.ignite.internal.util.nio.GridNioFilterAdapter.proceedMessageReceived(GridNioFilterAdapter.java:109)
at 
org.apache.ignite.internal.util.nio.GridNioServer$HeadFilter.onMessageReceived(GridNioServer.java:3547)
at 
org.apache.ignite.internal.util.nio.GridNioFilterChain.onMessageReceived(GridNioFilterChain.java:175)
at 
org.apache.ignite.internal.util.nio.GridNioServer$ByteBufferNioClientWorker.processRead(GridNioServer.java:1132)
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNioServer.java:2386)
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:2153)
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1797)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
at java.base/java.lang.Thread.run(Thread.java:834)
[2018-10-03 14:35:08,033][ERROR][grid-nio-worker-0-#42%nio-test-grid%][root] 
Closing NIO session because of unhandled exception.
class org.apache.ignite.internal.util.nio.GridNioException: No value present
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNioServer.java:2412)
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:2153)
at 
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1797)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:148)
at 
java.base/sun.security.ssl.ServerHello$T13ServerHelloProducer.produce(ServerHello.java:551)
at 
java.base/sun.security.ssl.SSLHandshake.produce(SSLHandshake.java:436)
at 
java.base/sun.security.ssl.ClientHello$T13ClientHelloConsumer.goServerHello(ClientHello.java:1189)
at 
java.base/sun.security.ssl.ClientHello$T13ClientHelloConsumer.consume(ClientHello.java:1125)
at 
java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.onClientHello(ClientHello.java:831)
at 
java.base/sun.security.ssl.ClientHello$ClientHelloConsumer.consume(ClientHello.java:792)
at 
java.base/sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:392)
at 
java.base/sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:444)
at 
java.base/sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.r

Re: Danger (?) change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

2018-10-03 Thread Vyacheslav Daradur

Alexey, thank you for the answer. I'd ask your advice about the
following question:

New Service Grid implementation listens to messages:
* ChangeGlobalStateMessage - to perform activation/deactivation actions;
* DynamicCacheChangeBatch - to handle caches stopping to undeploy
related affinity services;
* CacheAffinityChangeMessage - to recalculate assignments for affinity
services in case of late affinity.

It's important to handle these messages in order from disco-spi that
means SG is storing them in own exchange queue to process.
In some cases, PME may nullify this message earlier than they will be
processed by SG.

Could I exclude these messages from PME nullifying?

On Wed, Oct 3, 2018 at 11:26 AM Alexey Goncharuk
 wrote:
>
> Vyacheslav,
>
> Thanks for investigating this. User code should never listen to system
> custom events because this is an internal API and it's a subject to change.
> If there is anything a user interested in, the corresponding public event
> should be added.
>
> Nullifying the event in this case looks ok for me.
>
> вс, 30 сент. 2018 г. в 11:45, Vyacheslav Daradur :
>
> > I think that I understand a reason for doing this:
> > The most custom events which handle in
> > 'GridDhtPartitionsExchangeFuture' are using only in PME flow and
> > reason is release them for GC as soon as possible.
> >
> > But there are some other systems which can listen to the same events,
> > for example, to perform activation/deactivation actions them should
> > handle [ChangeGlobalStateMessage, ChangeGlobalStateFinishMessage]
> > which can be reset to 'null' by PME earlier then they will be handled
> > by other systems.
> >
> > I'd suggest do not reset to 'null' custom messages in
> > 'DiscoveryCustomEvent ' (at least without properly logic from the
> > discovery-spi side).
> >
> > Thoughts?
> >
> >
> >
> > On Sat, Sep 29, 2018 at 11:43 PM Vyacheslav Daradur 
> > wrote:
> > >
> > > Hi Igniters!
> > >
> > > I think I found an illegal behavior in
> > > GridDhtPartitionsExchangeFuture#onDone, the following code is called
> > > here:
> > > ((DiscoveryCustomEvent)firstDiscoEvt).customMessage(null);
> > >
> > > That means a global instance of 'DiscoveryCustomEvent' is being
> > > mutated outside discovery-spi infrastructure. It also means that
> > > discovery listeners receive 'DiscoveryCustomEvent' with 'null' field
> > > instead of 'CustomMessage' which they may rely on.
> > >
> > > Could someone confirm if it is wrong behavior and should be fixed?
> > >
> > > --
> > > Best Regards, Vyacheslav D.
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >



-- 
Best Regards, Vyacheslav D.

[jira] [Created] (IGNITE-9782) Webconsole: Form too large

2018-10-03 Thread Andrew Medvedev (JIRA)

Andrew Medvedev created IGNITE-9782:
---

 Summary: Webconsole: Form too large
 Key: IGNITE-9782
 URL: https://issues.apache.org/jira/browse/IGNITE-9782
 Project: Ignite
  Issue Type: Bug
Reporter: Andrew Medvedev
 Attachments: image.png

On large topologies form size increases jetty defaults

Consider increasing "{{org.mortbay.jetty.Request.maxFormContentSize}}"

 

!image.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #4873: IGNITE-5935: MVCC transaction recovery

2018-10-03 Thread pavlukhin

Github user pavlukhin closed the pull request at:

https://github.com/apache/ignite/pull/4873


---

[jira] [Created] (IGNITE-9783) MVCC: Track all nodes participating in transaction

2018-10-03 Thread Ivan Pavlukhin (JIRA)

Ivan Pavlukhin created IGNITE-9783:
--

 Summary: MVCC: Track all nodes participating in transaction
 Key: IGNITE-9783
 URL: https://issues.apache.org/jira/browse/IGNITE-9783
 Project: Ignite
  Issue Type: Bug
  Components: mvcc
Reporter: Ivan Pavlukhin
 Fix For: 2.7


All nodes should be tracked by near tx in order to make recovery possible. 
Backup nodes should be tracked as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #4881: IGNITE-9540

Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/4881


---

[GitHub] ignite pull request #4832: IGNITE-9540: MVCC TX: make cache invoke\invokeAll...

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4832


---

[GitHub] ignite pull request #4904: IGNITE-9783: MVCC: Track all nodes participating ...

2018-10-03 Thread pavlukhin

GitHub user pavlukhin opened a pull request:

https://github.com/apache/ignite/pull/4904

IGNITE-9783: MVCC: Track all nodes participating in transaction



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9783

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4904


commit 77dc283027793bee8831fe75c8947a825f81a539
Author: ipavlukhin 
Date:   2018-09-28T14:50:59Z

accumulate backups participating in transaction in 
GridDistributedTxMapping, retrieve them from received enlist response

commit 781dab6e0a2068acaaf859f4848f35c52327cc4f
Author: ipavlukhin 
Date:   2018-09-28T15:14:11Z

GridDistributedTxMapping normalize null backups to empty list

commit 090d17e40e56f45258a5a3f27c4da6e065343ed9
Author: ipavlukhin 
Date:   2018-09-28T15:32:01Z

pass backups to transaction mappings upon receiving response in 
GridNearTxEnlistFuture

commit 0d2446b27da80944d203cfd3c8a218a6904daa1c
Author: ipavlukhin 
Date:   2018-09-28T15:36:28Z

putIfAbsent -> put

commit 8d3eb13b40ba1bcd3fa70fa6af4c7af5ed521454
Author: ipavlukhin 
Date:   2018-09-28T15:48:16Z

remove outdated todo

commit 36a22a8b0ffc487dd47ab430057d185afdb81da9
Author: ipavlukhin 
Date:   2018-09-28T16:05:52Z

make backups in GridDistributedTxMapping thread-safe

commit 3ff50a1d2553d249f30858b478fc89986f344f8e
Author: ipavlukhin 
Date:   2018-09-28T16:07:41Z

add draft of a test

commit 9087ab222ad5b5ef41cb3ed5183d88ba5a141a77
Author: ipavlukhin 
Date:   2018-10-01T13:26:10Z

fix NPE occurring when enlist operation is finished by exception and 
response is null

commit caafe2fbad8c09fd07e5e8d1a5ed39c55aac0d7d
Author: ipavlukhin 
Date:   2018-10-02T05:30:54Z

Merge branch 'master' into ignite-5935

commit 8329bf39dcf83e65f44c69766b75a8d018da4191
Author: ipavlukhin 
Date:   2018-10-02T08:10:45Z

factor CacheMvccTxNodeMappingTest and add it to suite

commit 5866adc686ff6521bbed443e48d54a8e18fddd19
Author: ipavlukhin 
Date:   2018-10-02T08:21:13Z

test scenarios when near tx node is server

commit 3d080c08d17c34369d4cccb7b01e5767a32d03c0
Author: ipavlukhin 
Date:   2018-10-02T12:34:50Z

fail troublesome test

commit 37c4bfb62af9685e9179e1de1fa27913bb4e326c
Author: ipavlukhin 
Date:   2018-10-03T07:50:36Z

fail hanging issue with a ticket




---

[GitHub] ignite pull request #4905: IGNITE-9719 Extra rebalanceThreadPoolSize check o...

2018-10-03 Thread luchnikovbsk

GitHub user luchnikovbsk opened a pull request:

https://github.com/apache/ignite/pull/4905

IGNITE-9719 Extra rebalanceThreadPoolSize check on client node



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/luchnikovbsk/ignite ignite-9719

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4905


commit 6f5a78d5d0c7ed3489f6acdcaf9db5304cad78f2
Author: luchnikovnsk 
Date:   2018-10-03T12:45:22Z

IGNITE-9719 Extra rebalanceThreadPoolSize check on client node




---

[GitHub] ignite pull request #4891: IGNITE-9750

Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/4891


---

[GitHub] ignite pull request #4906: IGNITE-9606: JDBC getPrimaryKeys() returns wrong ...

2018-10-03 Thread pavel-kuznetsov

GitHub user pavel-kuznetsov opened a pull request:

https://github.com/apache/ignite/pull/4906

IGNITE-9606: JDBC getPrimaryKeys() returns wrong value for COLUMN_NAME



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9606

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4906.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4906


commit 5d144b2f57933b96dc4ccb68be119f7c205bb6f7
Author: Pavel Kuznetsov 
Date:   2018-10-02T14:43:31Z

ignite-9606: Added test that reproduces the bug.

commit 0bf7d1c8265e681cdc5ea8b7d27c013844724be6
Author: Pavel Kuznetsov 
Date:   2018-10-03T13:02:42Z

ignite-9606: fixed COLUMN_NAME metadata result.

Earlier, if key was of SQL type (so not wrapped), corresponding property 
thought that it is not a key. This behaviour affected what COLUMN_NAME JDBC 
metadata would contain.




---

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r222308185
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##
 @@ -46,16 +50,9 @@
 import javax.ws.rs.QueryParam;
 import javax.ws.rs.core.Context;
 import javax.ws.rs.core.MediaType;
-import java.util.ArrayList;
 import java.util.Collections;
-import java.util.List;
-import java.util.Date;
+import java.util.Optional;
 
 Review comment:
   Unused import.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r68058
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
 ##
 @@ -42,12 +42,15 @@
 import org.apache.ignite.ci.tcmodel.result.issues.IssuesUsagesList;
 import org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrences;
 import org.apache.ignite.ci.tcmodel.result.stat.Statistics;
+import org.apache.ignite.ci.tcmodel.result.tests.TestOccurrence;
 
 Review comment:
   Unused import.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r85591
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/comparison.html
 ##
 @@ -173,6 +178,176 @@
 return parseFloat(string.substring(string.indexOf("-") + 2, 
string.lastIndexOf("-") - 1));
 }
 
+var ch_disp = function(id) {
+let el = document.getElementById(id);
+
+el.style.display = el.style.display == 'block' ? 'none' : 'block';
+}
+
+function printTests(num, result) {
+let obj = {};
+
+try {
+obj = JSON.parse(result);
+} catch (e) {
+showErrInLoadStatus
 
 Review comment:
   String do nothing. This is not a method call.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r89864
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/comparison.html
 ##
 @@ -173,6 +178,176 @@
 return parseFloat(string.substring(string.indexOf("-") + 2, 
string.lastIndexOf("-") - 1));
 }
 
+var ch_disp = function(id) {
+let el = document.getElementById(id);
+
+el.style.display = el.style.display == 'block' ? 'none' : 'block';
+}
+
+function printTests(num, result) {
+let obj = {};
+
+try {
+obj = JSON.parse(result);
+} catch (e) {
+showErrInLoadStatus
+
+return;
+}
+
+if (obj == null)
+return;
+
+let tests = getTests(obj, num);
+
+window.sessionStorage.setItem('tests' + num, tests);
+
+$('#MT' + num).html(tests);
+}
+
+function compareHandler() {
+var compareMode = window.sessionStorage.compareMode;
+
+var needTestsUpdate = window.sessionStorage.needTestsUpdate;
+
+if (needTestsUpdate == 'true') {
+let result1 = window.sessionStorage.result1;
+
+let result2 = window.sessionStorage.result2;
+
+if (result1 == null || result2 == null) {
+alert("Two columns should be loaded for compareMode!");
+
+return;
+}
+
+let obj1 = {};
+
+let obj2 = {};
+
+try {
+obj1 = JSON.parse(result1);
+
+obj2 = JSON.parse(result2);
+} catch (e) {
+showErrInLoadStatus
+}
+
+window.sessionStorage.uniqTests1 = getUniqueTests(obj1, obj2, 1);
+
+window.sessionStorage.uniqTests2 = getUniqueTests(obj2, obj1, 2);
+
+window.sessionStorage.needTestsUpdate = 'false';
+}
+
+if (compareMode == 'true') {
+$('#btt').html("CompareMode");
+
+$('#MT1').html(window.sessionStorage.tests1);
+
+$('#MT2').html(window.sessionStorage.tests2);
+
+window.sessionStorage.compareMode = 'false';
+} else {
+$('#btt').html("FullMode");
+
+$('#MT1').html(window.sessionStorage.uniqTests1);
+
+$('#MT2').html(window.sessionStorage.uniqTests2);
+
+window.sessionStorage.compareMode = 'true';
+}
+
+}
+
+function getUniqueTests(obj1, obj2, num) {
+let uniqObj = {};
+
+let suites = Object.keys(obj1);
+
+for (let suite of suites) {
+if (!obj2.hasOwnProperty(suite)) {
+uniqObj[suite] = obj1[suite];
+
+continue;
+}
+
+let tests = obj2[suite];
+
+let uniqTests = [];
+
+for (let v of obj1[suite])
+if (!tests.includes(v, 0))
+uniqTests.push(v);
+
+if (uniqTests.length != 0)
+uniqObj[suite] = uniqTests;
+}
+
+return getTests(uniqObj, num);
+}
+
+function getTests(obj, num) {
+let res = '';
+
+let suites = Object.keys(obj).sort();
+
+for (let suite of suites) {
+let suiteName = suite.split('_').filter((value, index) => index != 
0).join('_');
+
+res += '' + suiteName + '' + ' (' + obj[suite].length + 
')' +
+'\n' +
+'';
+
+for (let v of obj[suite].sort()) {
+let list = v.toString().split(".");
+
+if (list.length < 2)
+list = v.toString().split(":");
+
+let testName = list.pop();
+
+let testClass = list.pop();
+
+res += ''
++ testClass + '.' + testName + ' ' +
+'' +
+'>>' +
+''
+}
+
+res += '';
+}
+
+res += '';
+
+return res;
+}
+
+function getTestRef(testName) {
+let res = '';
+
+$.ajax(
+{
 
 Review comment:
   Move to previous line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r78498
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
 ##
 @@ -125,6 +128,11 @@
  */
 private ConcurrentMap> 
testOccFullFutures = new ConcurrentHashMap<>();
 
+/**
+ * cached loads of test refs.
 
 Review comment:
   Start sentence with a capital letter.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r222307517
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##
 @@ -159,75 +156,59 @@ public TestFailuresSummary getBuildTestFails(
 }
 
 @GET
-@Path("history")
-public List getBuildsHistory(
-@Nullable @QueryParam("server") String srv,
-@Nullable @QueryParam("buildType") String buildType,
-@Nullable @QueryParam("branch") String branch,
-@Nullable @QueryParam("sinceDate") String sinceDate,
-@Nullable @QueryParam("untilDate") String untilDate)
-throws ServiceUnauthorizedException {
-String srvId = isNullOrEmpty(srv) ? "apache" : srv;
-String buildTypeId = isNullOrEmpty(buildType) ? 
"IgniteTests24Java8_RunAll" : buildType;
-String branchName = isNullOrEmpty(branch) ? "refs/heads/master" : 
branch;
-Date sinceDateFilter = isNullOrEmpty(sinceDate) ? null : 
dateParse(sinceDate);
-Date untilDateFilter = isNullOrEmpty(untilDate) ? null : 
dateParse(untilDate);
-
-final BackgroundUpdater updater = 
CtxListener.getBackgroundUpdater(ctx);
-
-final ITcHelper tcHelper = CtxListener.getTcHelper(ctx);
+@Produces(MediaType.TEXT_PLAIN)
+@Path("testRef")
+public String getTestRef(
+@NotNull @QueryParam("testName") String name,
+@Nullable @QueryParam("server") String server,
+@Nullable @QueryParam("projectId") String projectId)
+throws InterruptedException, ExecutionException {
+final ITcHelper helper = CtxListener.getTcHelper(ctx);
 
 final ICredentialsProv prov = ICredentialsProv.get(req);
 
-IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
-
-int[] finishedBuilds = 
teamcity.getBuildNumbersFromHistory(buildTypeId, branchName, sinceDateFilter, 
untilDateFilter);
+String project = projectId == null ? "IgniteTests24Java8" : projectId;
 
 Review comment:
   Missed authorization check.
   ```
   if (!prov.hasAccess(serverId))
   throw ServiceUnauthorizedException.noCreds(serverId);
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r63950
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
 ##
 @@ -0,0 +1,209 @@
+package org.apache.ignite.ci.web.model.hist;
 
 Review comment:
   Missed license and javadocs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r72279
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/BuildsHistory.java
 ##
 @@ -0,0 +1,209 @@
+package org.apache.ignite.ci.web.model.hist;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.text.DateFormat;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.ArrayList;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import javax.servlet.ServletContext;
+import org.apache.ignite.ci.IAnalyticsEnabledTeamcity;
+import org.apache.ignite.ci.ITcHelper;
+import org.apache.ignite.ci.IgnitePersistentTeamcity;
+import org.apache.ignite.ci.chain.BuildChainProcessor;
+import org.apache.ignite.ci.tcmodel.result.Build;
+import org.apache.ignite.ci.tcmodel.result.tests.TestOccurrence;
+import org.apache.ignite.ci.tcmodel.result.tests.TestOccurrences;
+import org.apache.ignite.ci.user.ICredentialsProv;
+import org.apache.ignite.ci.web.CtxListener;
+import org.apache.ignite.ci.web.model.current.BuildStatisticsSummary;
+import org.apache.ignite.ci.web.rest.parms.FullQueryParams;
+
+import static com.google.common.base.Strings.isNullOrEmpty;
+import static 
org.apache.ignite.ci.web.rest.build.GetBuildTestFailures.BUILDS_STATISTICS_SUMMARY_CACHE_NAME;
+
+public class BuildsHistory {
+private String srvId;
+
+private String projectId;
+
+private String buildTypeId;
+
+private String branchName;
+
+private Date sinceDateFilter;
+
+private Date untilDateFilter;
+
+private ObjectMapper objectMapper = new ObjectMapper();
+
+private Map> mergedTestsBySuites = new HashMap<>();
+
+private Set mergedTests = new HashSet<>();
+
+public List buildsStatistics = new ArrayList<>();
+
+public String mergedTestsResult;
+
+public void initialize(ICredentialsProv prov, ServletContext context) {
+ITcHelper tcHelper = CtxListener.getTcHelper(context);
+
+IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
+
+
 
 Review comment:
   Remove double empty line.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r71593
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
 ##
 @@ -542,6 +545,19 @@ public ProblemOccurrences getProblems(Build build) {
 return supplyAsync(() -> getJaxbUsingHref(href, 
TestOccurrenceFull.class), executor);
 }
 
+@AutoProfiling
+@Override public TestOccurrences getFailedUnmutedTests(String href, int 
count, String normalizedBranch) {
+return getTests(href + ",muted:false,status:FAILURE,count:" + count, 
normalizedBranch);
+}
+
+@Override
 
 Review comment:
   `Override` annotation should be on the same line with method signature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r89732
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/comparison.html
 ##
 @@ -173,6 +178,176 @@
 return parseFloat(string.substring(string.indexOf("-") + 2, 
string.lastIndexOf("-") - 1));
 }
 
+var ch_disp = function(id) {
+let el = document.getElementById(id);
+
+el.style.display = el.style.display == 'block' ? 'none' : 'block';
+}
+
+function printTests(num, result) {
+let obj = {};
+
+try {
+obj = JSON.parse(result);
+} catch (e) {
+showErrInLoadStatus
+
+return;
+}
+
+if (obj == null)
+return;
+
+let tests = getTests(obj, num);
+
+window.sessionStorage.setItem('tests' + num, tests);
+
+$('#MT' + num).html(tests);
+}
+
+function compareHandler() {
+var compareMode = window.sessionStorage.compareMode;
+
+var needTestsUpdate = window.sessionStorage.needTestsUpdate;
+
+if (needTestsUpdate == 'true') {
+let result1 = window.sessionStorage.result1;
+
+let result2 = window.sessionStorage.result2;
+
+if (result1 == null || result2 == null) {
+alert("Two columns should be loaded for compareMode!");
+
+return;
+}
+
+let obj1 = {};
+
+let obj2 = {};
+
+try {
+obj1 = JSON.parse(result1);
+
+obj2 = JSON.parse(result2);
+} catch (e) {
+showErrInLoadStatus
+}
+
+window.sessionStorage.uniqTests1 = getUniqueTests(obj1, obj2, 1);
+
+window.sessionStorage.uniqTests2 = getUniqueTests(obj2, obj1, 2);
+
+window.sessionStorage.needTestsUpdate = 'false';
+}
+
+if (compareMode == 'true') {
+$('#btt').html("CompareMode");
+
+$('#MT1').html(window.sessionStorage.tests1);
+
+$('#MT2').html(window.sessionStorage.tests2);
+
+window.sessionStorage.compareMode = 'false';
+} else {
+$('#btt').html("FullMode");
+
+$('#MT1').html(window.sessionStorage.uniqTests1);
+
+$('#MT2').html(window.sessionStorage.uniqTests2);
+
+window.sessionStorage.compareMode = 'true';
+}
+
+}
+
+function getUniqueTests(obj1, obj2, num) {
+let uniqObj = {};
+
+let suites = Object.keys(obj1);
+
+for (let suite of suites) {
+if (!obj2.hasOwnProperty(suite)) {
+uniqObj[suite] = obj1[suite];
+
+continue;
+}
+
+let tests = obj2[suite];
+
+let uniqTests = [];
+
+for (let v of obj1[suite])
 
 Review comment:
   Need bracers for multiline `for`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r63852
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcmodel/result/tests/TestOccurrence.java
 ##
 @@ -98,4 +98,15 @@ public TestOccurrence setStatus(String status) {
 
 return this;
 }
+
+public Integer getBuildId() {
 
 Review comment:
   Missed javadoc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r222307974
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##
 @@ -159,75 +156,59 @@ public TestFailuresSummary getBuildTestFails(
 }
 
 @GET
-@Path("history")
-public List getBuildsHistory(
-@Nullable @QueryParam("server") String srv,
-@Nullable @QueryParam("buildType") String buildType,
-@Nullable @QueryParam("branch") String branch,
-@Nullable @QueryParam("sinceDate") String sinceDate,
-@Nullable @QueryParam("untilDate") String untilDate)
-throws ServiceUnauthorizedException {
-String srvId = isNullOrEmpty(srv) ? "apache" : srv;
-String buildTypeId = isNullOrEmpty(buildType) ? 
"IgniteTests24Java8_RunAll" : buildType;
-String branchName = isNullOrEmpty(branch) ? "refs/heads/master" : 
branch;
-Date sinceDateFilter = isNullOrEmpty(sinceDate) ? null : 
dateParse(sinceDate);
-Date untilDateFilter = isNullOrEmpty(untilDate) ? null : 
dateParse(untilDate);
-
-final BackgroundUpdater updater = 
CtxListener.getBackgroundUpdater(ctx);
-
-final ITcHelper tcHelper = CtxListener.getTcHelper(ctx);
+@Produces(MediaType.TEXT_PLAIN)
+@Path("testRef")
+public String getTestRef(
+@NotNull @QueryParam("testName") String name,
+@Nullable @QueryParam("server") String server,
 
 Review comment:
   Rename variable to `srv`. See [abbreviation 
rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r79867
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/build/GetBuildTestFailures.java
 ##
 @@ -159,75 +156,59 @@ public TestFailuresSummary getBuildTestFails(
 }
 
 @GET
-@Path("history")
-public List getBuildsHistory(
-@Nullable @QueryParam("server") String srv,
-@Nullable @QueryParam("buildType") String buildType,
-@Nullable @QueryParam("branch") String branch,
-@Nullable @QueryParam("sinceDate") String sinceDate,
-@Nullable @QueryParam("untilDate") String untilDate)
-throws ServiceUnauthorizedException {
-String srvId = isNullOrEmpty(srv) ? "apache" : srv;
-String buildTypeId = isNullOrEmpty(buildType) ? 
"IgniteTests24Java8_RunAll" : buildType;
-String branchName = isNullOrEmpty(branch) ? "refs/heads/master" : 
branch;
-Date sinceDateFilter = isNullOrEmpty(sinceDate) ? null : 
dateParse(sinceDate);
-Date untilDateFilter = isNullOrEmpty(untilDate) ? null : 
dateParse(untilDate);
-
-final BackgroundUpdater updater = 
CtxListener.getBackgroundUpdater(ctx);
-
-final ITcHelper tcHelper = CtxListener.getTcHelper(ctx);
+@Produces(MediaType.TEXT_PLAIN)
+@Path("testRef")
+public String getTestRef(
+@NotNull @QueryParam("testName") String name,
+@Nullable @QueryParam("server") String server,
+@Nullable @QueryParam("projectId") String projectId)
+throws InterruptedException, ExecutionException {
+final ITcHelper helper = CtxListener.getTcHelper(ctx);
 
 final ICredentialsProv prov = ICredentialsProv.get(req);
 
-IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
-
-int[] finishedBuilds = 
teamcity.getBuildNumbersFromHistory(buildTypeId, branchName, sinceDateFilter, 
untilDateFilter);
+String project = projectId == null ? "IgniteTests24Java8" : projectId;
 
-List buildsStatistics = new ArrayList<>();
+String serverId = server == null ? "apache" : server;
 
-for (int i = 0; i < finishedBuilds.length; i++) {
-int buildId = finishedBuilds[i];
+IAnalyticsEnabledTeamcity teamcity = helper.server(serverId, prov);
 
-FullQueryParams param = new FullQueryParams();
-param.setBuildId(buildId);
-param.setBranch(branchName);
-param.setServerId(srvId);
+FullQueryParams key = new FullQueryParams();
 
-BuildStatisticsSummary buildsStatistic = updater.get(
-BUILDS_STATISTICS_SUMMARY_CACHE_NAME, prov, param,
-(k) -> getBuildStatisticsSummaryNoCache(srvId, buildId), 
false);
+key.setTestName(name);
 
-if (!buildsStatistic.isFakeStub)
-buildsStatistics.add(buildsStatistic);
-}
+key.setProjectId(project);
 
-return buildsStatistics;
-}
+key.setServerId(serverId);
 
-private Date dateParse(String date){
-DateFormat dateFormat = new SimpleDateFormat("ddMMHHmmss");
+CompletableFuture ref = teamcity.getTestRef(key);
 
-try {
-return dateFormat.parse(date);
-}
-catch (ParseException e) {
-return null;
-}
+return ref.isDone() ? teamcity.host() + "project.html?"
++ "projectId=" + project
++ "&testNameId=" + ref.get().id
++ "&tab=testDetails" : null;
 }
 
-private BuildStatisticsSummary getBuildStatisticsSummaryNoCache(String 
server, int buildId) {
-String srvId = isNullOrEmpty(server) ? "apache" : server;
-
-final ITcHelper tcHelper = CtxListener.getTcHelper(ctx);
-
-final ICredentialsProv creds = ICredentialsProv.get(req);
-
-IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, creds);
+@GET
+@Path("history")
+public BuildsHistory getBuildsHistory(
+@Nullable @QueryParam("server") String server,
+@Nullable @QueryParam("buildType") String buildType,
+@Nullable @QueryParam("branch") String branch,
+@Nullable @QueryParam("sinceDate") String sinceDate,
+@Nullable @QueryParam("untilDate") String untilDate)  throws 
ParseException {
+BuildsHistory buildsHistory = new BuildsHistory.Builder()
+.branch(branch)
+.server(server)
+.buildType(buildType)
+.sinceDate(sinceDate)
+.untilDate(untilDate)
+.build();
 
-BuildStatisticsSummary stat = new BuildStatisticsSummary(buildId);
+System.out.println("History request handled");
 
 Review comment:
   Use logger instead of `sout`. Do we really need this in the log?

--

[GitHub] SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add comparison of failed tests lists in two date intervals

SomeFire commented on a change in pull request #25: IGNITE-9645 [TC Bot] Add 
comparison of failed tests lists in two date intervals
URL: https://github.com/apache/ignite-teamcity-bot/pull/25#discussion_r90983
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/comparison.html
 ##
 @@ -247,6 +422,7 @@
 
 $(document).ready(function() {
 loadData(1, moment(oneWeekAgo), moment());
+
 
 Review comment:
   Don't separate same semantic units. 
   See [Coding 
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-SemanticUnits).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (IGNITE-9784) Performance drop on sql yardstick benchmarks

2018-10-03 Thread Ilya Suntsov (JIRA)

Ilya Suntsov created IGNITE-9784:


 Summary: Performance drop on sql yardstick benchmarks
 Key: IGNITE-9784
 URL: https://issues.apache.org/jira/browse/IGNITE-9784
 Project: Ignite
  Issue Type: Bug
  Components: sql
Affects Versions: 2.7
Reporter: Ilya Suntsov
 Attachments: Screen Shot 2018-10-03 at 4.52.22 PM.png

Please take a look at the attachment.

Grid configuration:
 * 4 servers / 8 clients
 * java 8
 * 64 threads, 60s warmup, 180s duration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Discussion] Create new mailing list notifications@ and forward GitBox comments to it

Hi Ignite Enthusiasts,

I would like to decrease pressure to dev list by removing GitBox comments
from being forwarded to dev@

I suggest we will create new list notificati...@ignite.apache.org and setup
GitBox comments to be sent to it instead of dev list.

Dmitrii Ryabov contacted Infra about disabling comments
https://issues.apache.org/jira/browse/INFRA-17032 (BTW, thank you, Dmitrii!
), but it is not possible to just disable, it can be forwarded to a
separate list.

Please share your vision about this change. I believe Ignite developers
don't need to read each PR comment in TC bot, so separate list for these
notifications may be a solution.

Sincerely,
Dmitriy Pavlov

[jira] [Created] (IGNITE-9785) Introduce read-only state in local node context

2018-10-03 Thread Ivan Rakov (JIRA)

Ivan Rakov created IGNITE-9785:
--

 Summary: Introduce read-only state in local node context
 Key: IGNITE-9785
 URL: https://issues.apache.org/jira/browse/IGNITE-9785
 Project: Ignite
  Issue Type: New Feature
Reporter: Ivan Rakov
Assignee: Aleksey Plekhanov
 Fix For: 2.8


It would be useful to have option to switch "read-only" state on Ignite node. 
Under read-only state:
1) Any attempt to update data via Cache API should throw exception
2) Any attempt to update data via DataStreamer should throw exception
Local read-only state may be helpful in further implementing global read-only 
cluster state, which can be switched via user API. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [MTCGA]: new failures in builds [1871897] needs to be handled

Hi Alexey,

Could you please assist with fixing test?

Sincerely,
Dmitriy Pavlov

сб, 29 сент. 2018 г. в 12:23, Dmitriy Pavlov :

> Folks,
>
> both tests are failed in ignite-2.7 IgniteStandByClusterTest.testSimple
> 
>  &
> IgniteChangeGlobalStateFailOverTest.testActivateDeActivateOnFixTopologyWithPutValues
> 
>
>
> Can I hope these failures will be fixed in master and 2.7 before release?
>
> https://issues.apache.org/jira/browse/IGNITE-7618
> 
>
>
>
> пт, 21 сент. 2018 г. в 11:33, Dmitrii Ryabov :
>
>> Hi, Dmitriy,
>> I checked 7618 and previous commits: test fails locally starting from
>> 7618.
>> It fails because `cache.get()` remembers deactivated state and doesn't
>> check current state.
>>
>> 2018-09-20 18:41 GMT+03:00 Dmitriy Pavlov :
>>
>> > Hi,
>> >
>> > IgniteStandByClusterTest seems to fail, Dmitriy G., Ivan, would it be
>> > reasonable to revert commit?
>> >
>> > Dmitriy Ryabov, is it related to recent fix or is it a standalone
>> problem?
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> > пн, 17 сент. 2018 г. в 18:45, Dmitrii Ryabov :
>> >
>> > > Looks like problem I had described in the ticket.
>> > >
>> > >
>> > > https://issues.apache.org/jira/browse/IGNITE-7618?
>> > focusedCommentId=16506923&page=com.atlassian.jira.
>> > plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16506923
>> > >
>> > > 2018-09-15 12:01 GMT+03:00 Dmitriy Pavlov :
>> > >
>> > > > Dmitriy G, Ivan B,
>> > > >
>> > > > could you please double-check if failure is not coming from
>> > > > https://issues.apache.org/jira/browse/IGNITE-7618
>> > > >
>> > > > Sincerely,
>> > > > Dmitriy Pavlov
>> > > >
>> > > > сб, 15 сент. 2018 г. в 5:42, :
>> > > >
>> > > > > Hi Ignite Developer,
>> > > > >
>> > > > > I am MTCGA.Bot, and I've detected some issue on TeamCity to be
>> > > addressed.
>> > > > > I hope you can help.
>> > > > >
>> > > > >  *New test failure in master
>> IgniteStandByClusterTest.testSimple
>> > > > > https://ci.ignite.apache.org/project.html?projectId=
>> > > > IgniteTests24Java8&testNameId=1332314705000986815&branch=%
>> > > > 3Cdefault%3E&tab=testDetails
>> > > > >  Changes may led to failure were done by
>> > > > >  - bessonov.ip
>> > > > > http://ci.ignite.apache.org/viewModification.html?modId=
>> > > > 831651&personal=false
>> > > > >
>> > > > > - If your changes can led to this failure(s), please
>> create
>> > > issue
>> > > > > with label MakeTeamCityGreenAgain and assign it to you.
>> > > > > -- If you have fix, please set ticket to PA state and
>> write
>> > to
>> > > > dev
>> > > > > list fix is ready
>> > > > > -- For case fix will require some time please mute test
>> and
>> > set
>> > > > > label Muted_Test to issue
>> > > > > - If you know which change caused failure please contact
>> > change
>> > > > > author directly
>> > > > > - If you don't know which change caused failure please
>> send
>> > > > > message to dev list to find out
>> > > > > Should you have any questions please contact
>> dev@ignite.apache.org
>> > > > > Best Regards,
>> > > > > MTCGA.Bot
>> > > > > Notification generated at Sat Sep 15 05:42:21 MSK 2018
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: [Discussion] revert of commit MVCC, ignite-9320

Hi Igniters,

I see that https://issues.apache.org/jira/browse/IGNITE-9390 was resolved, but
.Net metrics tests are failing.
 *New test failure in master DataRegionMetricsTest.TestMemoryMetrics
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6742613397597284603&branch=%3Cdefault%3E&tab=testDetails

 *New test failure in master MemoryMetricsTest.TestMemoryMetrics
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-7558087625238261420&branch=%3Cdefault%3E&tab=testDetails


Pavel,

I did all I could by the moment to encourage these tests to be fixed, but
it seems we need your help to fix these test.

Assert fails 3 instead of 4 in test validation, could you please step in
and help with fixing this?

Sincerely,
Dmitriy Pavlov

сб, 29 сент. 2018 г. в 12:29, Dmitriy Pavlov :

> Vladimir, I agree more with Andrey's fix in the parity test, because it
> disables only specific property failure.
>
> If we keep .NET parity test failed for a long time, some other
> contributor will introduce new property- it will begin to fail always - it
> is like a snowball.
>
> I hope the metrics test will also be fixed before 2.7
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 28 сент. 2018 г. в 14:43, Павлухин Иван :
>
>> Hi guys!
>>
>> By the way, is it practically feasible to revert a single commit without
>> making harm? If I am getting it right in current case reverting commit
>> will
>> lead to compilation errors for commits depending on commit in question.
>>
>> 2018-09-28 14:22 GMT+03:00 Dmitriy Pavlov :
>>
>> > Hi Dmitriy S.,
>> >
>> > I really prefer avoiding reverts, which why I've started this topic. If
>> I
>> > were reverting-fan, I could just write: "Vetoing commit  because of
>> > test failures , commit reverted, ticket IGNITE- reopened."
>> >
>> > But some time ago I several times asked newbie contributors to fix
>> missed
>> > test failures and they managed to do it in 1-2 days, I'm waiting these
>> test
>> > to be fixed by Ignite veteran(s) for 11 days.
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>> >
>> >
>> > пт, 28 сент. 2018 г. в 13:16, Vladimir Ozerov :
>> >
>> > > Andrey,
>> > >
>> > > This is not a fix, but a hack, which covers real state of affairs.
>> > >
>> > > пт, 28 сент. 2018 г. в 13:00, Andrey Mashenkov <
>> > andrey.mashen...@gmail.com
>> > > >:
>> > >
>> > > > Hi,
>> > > >
>> > > > Fix is trivial and ready.
>> > > > Hope, it will be merged within IGNITE-7764 today.
>> > > >
>> > > > https://issues.apache.org/jira/browse/IGNITE-7764
>> > > >
>> > > > On Fri, Sep 28, 2018 at 12:26 PM Dmitriy Setrakyan <
>> > > dsetrak...@apache.org>
>> > > > wrote:
>> > > >
>> > > > > Guys, let's just fix the tests without reverting commits.
>> Reverting a
>> > > > > commit may trigger a time machine, where all following commits
>> may be
>> > > > > broken because of it. Fixing that scenario will be much harder.
>> > > > >
>> > > > > Going forward, I would agree that we should not merge anything
>> that
>> > > > breaks
>> > > > > tests. This is about following a basic engineering discipline. We
>> > > should
>> > > > > all do it.
>> > > > >
>> > > > > D.
>> > > > >
>> > > > >
>> > > > > On Fri, Sep 28, 2018 at 12:47 AM Dmitriy Pavlov <
>> > dpavlov@gmail.com
>> > > >
>> > > > > wrote:
>> > > > >
>> > > > > > Yep, we're humans and we constantly make mistakes. It is a very
>> > human
>> > > > > thing
>> > > > > > to do mistakes.
>> > > > > >
>> > > > > > So I suggest we will be under the control and protection of
>> robot
>> > to
>> > > > > avoid
>> > > > > > mistakes, I suggest robot will revert such commits in 72h
>> without
>> > its
>> > > > own
>> > > > > > personal attitudes, emotions, etc.
>> > > > > >
>> > > > > > Someone who is interested in contribution usually can find time
>> to
>> > > make
>> > > > > > contribution perfect.
>> > > > > >
>> > > > > > I'm not aware of project priorities, please share it. I believe
>> > > > different
>> > > > > > priorities can co-exist. A number of contributors are fixing
>> tests,
>> > > so
>> > > > it
>> > > > > > is a priority for them, isn't it? So why to add work to that
>> guys
>> > > > because
>> > > > > > of you have other priorities?
>> > > > > >
>> > > > > > пт, 28 сент. 2018 г. в 10:39, Vladimir Ozerov <
>> > voze...@gridgain.com
>> > > >:
>> > > > > >
>> > > > > > > Because a lot of other activities depended on configuration in
>> > > Java,
>> > > > > and
>> > > > > > we
>> > > > > > > didn't have expertise to fix .NET immediately.
>> > > > > > >
>> > > > > > > If you want to revert it - please go ahead. But I'd better
>> > suggest
>> > > > you
>> > > > > to
>> > > > > > > think about the impact and project priorities first, instead
>> of
>> > > > trying
>> > > > > to
>> > > > > > > apply the some sort rules blindly. We are not robots.
>> > > > > > >
>> > > > > > > On Fri, Sep 28, 2018 at 10:19 AM Dmitriy Pavlov <
>> > > > dpavlov@gmail.com
>> > > > > >
>> > > > > > > wrote:
>> > >

[GitHub] ignite pull request #4907: IGNITE-9785 Introduce read-only state in local no...

2018-10-03 Thread glukos

GitHub user glukos opened a pull request:

https://github.com/apache/ignite/pull/4907

IGNITE-9785 Introduce read-only state in local node context



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9785

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4907


commit 9a40d52662a115755d3e89931ff24c55ca4b377c
Author: Aleksey Plekhanov 
Date:   2018-10-03T15:11:08Z

TDR-18 Read-only mode

Signed-off-by: Ivan Rakov 




---

Re: [Discussion] Create new mailing list notifications@ and forward GitBox comments to it

2018-10-03 Thread Petr Ivanov

Will that list be read at all?



> On 3 Oct 2018, at 17:24, Dmitriy Pavlov  wrote:
> 
> Hi Ignite Enthusiasts,
> 
> I would like to decrease pressure to dev list by removing GitBox comments
> from being forwarded to dev@
> 
> I suggest we will create new list notificati...@ignite.apache.org and setup
> GitBox comments to be sent to it instead of dev list.
> 
> Dmitrii Ryabov contacted Infra about disabling comments
> https://issues.apache.org/jira/browse/INFRA-17032 (BTW, thank you, Dmitrii!
> ), but it is not possible to just disable, it can be forwarded to a
> separate list.
> 
> Please share your vision about this change. I believe Ignite developers
> don't need to read each PR comment in TC bot, so separate list for these
> notifications may be a solution.
> 
> Sincerely,
> Dmitriy Pavlov

[jira] [Created] (IGNITE-9786) MVCC: simplify TX wait list management

2018-10-03 Thread Vladimir Ozerov (JIRA)

Vladimir Ozerov created IGNITE-9786:
---

 Summary: MVCC: simplify TX wait list management
 Key: IGNITE-9786
 URL: https://issues.apache.org/jira/browse/IGNITE-9786
 Project: Ignite
  Issue Type: Task
  Components: mvcc
Reporter: Vladimir Ozerov
Assignee: Vladimir Ozerov
 Fix For: 2.8


It seems that instead of having a lot of classes and complex synchronization 
mechanics for MvccProcessorImpl.waitMap, we can use single wrapper with a list 
of waiters. 
Resulting code will be much more simpler and less prone to concurrency issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [Discussion] Create new mailing list notifications@ and forward GitBox comments to it

Yes, by Igniters, who will subscribe to it using
notifications-subscr...@ignite.apache.org   . I'm going to subscribe.

I've heard complains about the volume of emails here, so it could be useful
to remove this one chunk from the dev.

For the record:
I suggest forwarding only emails from g...@apache.org (GitBox, TC Bot
repository).
g...@git.apache.org (GitHub), so regular PRs to Ignite will be forwarded as
is.

ср, 3 окт. 2018 г. в 18:36, Petr Ivanov :

> Will that list be read at all?
>
>
>
> > On 3 Oct 2018, at 17:24, Dmitriy Pavlov  wrote:
> >
> > Hi Ignite Enthusiasts,
> >
> > I would like to decrease pressure to dev list by removing GitBox comments
> > from being forwarded to dev@
> >
> > I suggest we will create new list notificati...@ignite.apache.org and
> setup
> > GitBox comments to be sent to it instead of dev list.
> >
> > Dmitrii Ryabov contacted Infra about disabling comments
> > https://issues.apache.org/jira/browse/INFRA-17032 (BTW, thank you,
> Dmitrii!
> > ), but it is not possible to just disable, it can be forwarded to a
> > separate list.
> >
> > Please share your vision about this change. I believe Ignite developers
> > don't need to read each PR comment in TC bot, so separate list for these
> > notifications may be a solution.
> >
> > Sincerely,
> > Dmitriy Pavlov
>
>

[GitHub] ignite pull request #4908: IGNITE-9786

GitHub user devozerov opened a pull request:

https://github.com/apache/ignite/pull/4908

IGNITE-9786



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9786

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4908


commit 9200568fb830c93c7d98c74c14d4006bbdac8797
Author: devozerov 
Date:   2018-10-03T14:37:59Z

WIP.

commit 88ef985156c42ffeef564b7a1a2a54e5efaa7989
Author: devozerov 
Date:   2018-10-03T15:41:59Z

Done.




---

[GitHub] ignite pull request #4880: IGNITE-9126 Update Apache Kafka dependency

2018-10-03 Thread Max-Pudov

Github user Max-Pudov closed the pull request at:

https://github.com/apache/ignite/pull/4880


---

Re: [Discussion] Create new mailing list notifications@ and forward GitBox comments to it

Sorry, the previous email was not clear and not finished: Main repository
related emails from g...@git.apache.org (GitHub) will remain as is, so
regular PRs create and close will be forwarded as is.

If someone wants to redirect main repo-related PR notifications (as it was
suggested in Remove Bots from dev list), please start a separate
discussion. As part of this discussion, I would like we come to an
agreement about the creation of the list and forwarding TC Bot review
comments there.

ср, 3 окт. 2018 г. в 18:42, Dmitriy Pavlov :

> Yes, by Igniters, who will subscribe to it using
> notifications-subscr...@ignite.apache.org   . I'm going to subscribe.
>
> I've heard complains about the volume of emails here, so it could be
> useful to remove this one chunk from the dev.
>
> For the record:
> I suggest forwarding only emails from g...@apache.org (GitBox, TC Bot
> repository).
> g...@git.apache.org (GitHub), so regular PRs to Ignite will be forwarded
> as is.
>
> ср, 3 окт. 2018 г. в 18:36, Petr Ivanov :
>
>> Will that list be read at all?
>>
>>
>>
>> > On 3 Oct 2018, at 17:24, Dmitriy Pavlov  wrote:
>> >
>> > Hi Ignite Enthusiasts,
>> >
>> > I would like to decrease pressure to dev list by removing GitBox
>> comments
>> > from being forwarded to dev@
>> >
>> > I suggest we will create new list notificati...@ignite.apache.org and
>> setup
>> > GitBox comments to be sent to it instead of dev list.
>> >
>> > Dmitrii Ryabov contacted Infra about disabling comments
>> > https://issues.apache.org/jira/browse/INFRA-17032 (BTW, thank you,
>> Dmitrii!
>> > ), but it is not possible to just disable, it can be forwarded to a
>> > separate list.
>> >
>> > Please share your vision about this change. I believe Ignite developers
>> > don't need to read each PR comment in TC bot, so separate list for these
>> > notifications may be a solution.
>> >
>> > Sincerely,
>> > Dmitriy Pavlov
>>
>>

[jira] [Created] (IGNITE-9787) Local Continuous Query skips rows during initial rebalance of REPLICATED cache

2018-10-03 Thread Ilya Kasnacheev (JIRA)

Ilya Kasnacheev created IGNITE-9787:
---

 Summary: Local Continuous Query skips rows during initial 
rebalance of REPLICATED cache
 Key: IGNITE-9787
 URL: https://issues.apache.org/jira/browse/IGNITE-9787
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.4
Reporter: Ilya Kasnacheev
 Attachments: IgniteRepro2.zip

This is observer under .Net but I assume will affect Java too:

If you have a partitioned cache with non-local continuous query, continuous 
query will iterate every entry in REPLICATED cache.
If you have a replicated cache with non-local continuous query, it works.
If you have a replicated cache with local continuous query and synchronous 
rebalancing, it also works.
But if you have replicated cache with local continuous query and 
non-synchronous rebalancing , you will see the gap in data - newly written 
entries while rebalance is underway may not be passed to callback or scan query.

Please see the ML thread and reproducer.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Release process documentation in wiki

Hi Nikolay, Igniters,

I've added the link to notes, and (as follow up related to the blockers/
non-blockers discussion)  added several attributes of blockers. Please
review if you have a minute.

Sincerely,
Dmitriy Pavlov

вт, 2 окт. 2018 г. в 14:49, Nikolay Izhikov :

> Dmitriy, thank you.
>
> I also making some notes about release.
> Feedback are welcome.
>
> https://cwiki.apache.org/confluence/display/IGNITE/Release+manager+Notes
>
> В Вт, 02/10/2018 в 14:42 +0300, Dmitriy Pavlov пишет:
> > Hi Igniters,
> >
> > We had several hot discussions related to release, and one from reasons
> we
> > need time to come to consensus was my poor understanding of the process.
> >
> > I decided to contribute currently found facts as a scheme of release
> > process here
> > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process
> >
> > Please find a minute and take a look. Feedback, as always, is more than
> > welcome.
> >
> > Sincerely,
> > Dmitriy Pavlov
>

[GitHub] asfgit closed pull request #23: IGNITE-9541 Add row highlight for 'failed', add title for columns, re…

asfgit closed pull request #23: IGNITE-9541 Add row highlight for 'failed', add 
title for columns, re…
URL: https://github.com/apache/ignite-teamcity-bot/pull/23
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ignite-tc-helper-web/src/main/webapp/comparison.html 
b/ignite-tc-helper-web/src/main/webapp/comparison.html
index 5efe4e3..7868f64 100644
--- a/ignite-tc-helper-web/src/main/webapp/comparison.html
+++ b/ignite-tc-helper-web/src/main/webapp/comparison.html
@@ -29,11 +29,11 @@
 
 
 
-TESTS
+TESTS
 COUNT
 
-
-
+
+
 
 
 
@@ -42,8 +42,8 @@
 
 PASSED
 
-
-
+
+
 
 
 
@@ -52,8 +52,8 @@
 
 FAILED
 
-
-
+
+
 
 
 
@@ -62,8 +62,8 @@
 
 IGNORED
 
-
-
+
+
 
 
 
@@ -72,19 +72,19 @@
 
 MUTED
 
-
-
+
+
 
 
 
 
 
-PROBLEMS
+PROBLEMS
 
 TOTAL
 
-
-
+
+
 
 
 
@@ -92,8 +92,8 @@
 
 EXECUTION TIMEOUT
 
-
-
+
+
 
 
 
@@ -102,8 +102,8 @@
 
 JVM CRASH
 
-
-
+
+
 
 
 
@@ -112,8 +112,8 @@
 
 OOME
 
-
-
+
+
 
 
 
@@ -122,8 +122,8 @@
 
 EXIT CODE
 
-
-
+
+
 
 
 
@@ -200,6 +200,7 @@
 if (dates.length === 0) {
 printImportantMessage(num, "#ff", "No data for the selected 
period");
 fillAllDataCells(num, "");
+$('.title' + num).html("");
 
 return;
 } else {
@@ -211,37 +212,47 @@
 (firstDate === lastDate ? firstDate : ("the period from " 
+ firstDate + " to " + lastDate)) + "");
 } else {
 $("#info" + num).html("");
-if (document.getElementById("info" + anotherNum).innerHTML === 
"") {
-document.getElementById("showInfo").style.display = "none";
+if ($('#info' + anotherNum).text() === ''){
+$('#showInfo').css('display', 'none')
 }
 }
 }
 
-let anotherMedian;
-let result = {};
+$('.title' + num).html('min - median - max');
 
 for (let i = 0; i < prOcc.length; i++) {
-result = getMinMaxMedian(statistics[prOcc[i]]);
-anotherMedian = parseMedian(document.getElementById(prOcc[i] + 
anotherNum).innerHTML);
-
-$('#' + prOcc[i] + num).html(result.min + " - " + result.median +  
" - " + result.max);
-
-if (!isNaN(anotherMedian)){
-if (result.median > anotherMedian){
-document.getElementById(prOcc[i] + 
num).style.backgroundColor = "#ffeee9";
-document.getElementById(prOcc[i] + 
anotherNum).style.backgroundColor = "#e5ffe8";
-} else if (result.median < anotherMedian){
-document.getElementById(prOcc[i] + 
anotherNum).style.backgroundColor = "#ffeee9";
-document.getElementById(prOcc[i] + 
num).style.backgroundColor = "#e5ffe8";
-}
-}
+fillCellWithStatistics(prOcc[i], num, statistics, dates);
+fillCellWithStatistics(tOcc[i], num, statistics, dates);
+}
+}
+
+function fillCellWithStatistics(prefix, num, statistics, dates) {
+let result = getMinMaxMedian(statistics[prefix]);
 
-result = getMinMaxMedian(statistics[tOcc[i]]);
+$('#' + prefix + num).html(result.min + " - " + result.median +  " - " 
+ result.max);
 
-$('#' + tOcc[i] + num).html(result.min + " - " + result.median + " 
- " + result.max);
+compareAndHighlight(prefix, num, result.median);
+
+drawGraph(prefix, num, dates, statistics[prefix], prefix);
+}
 
-drawGraph(prOcc[i], num, dates, statistics[prOcc[i]], prOcc[i]);
-drawGraph(tOcc[i], num, dates, statistics[tOcc[i]], tOcc[i]);
+function compareAndHighlight(prefix, thisNum, thisMedian){
+let anotherNum = (thisNum === 1) ? 2 : 1;
+
+let thisElement = $('#' + prefix + thisNum);
+let anotherElement =  $('#' + prefix + anotherNum);
+
+if (thisElement.data('allowHighlight').toString() === "true") {
+let anotherMedian = parseMedian(anotherElement.text());
+if (!isNaN(anotherMedian)) {
+if (th

[GitHub] ignite pull request #4909: IGNITE-9126 Update Apache Kafka dependency

2018-10-03 Thread Max-Pudov

GitHub user Max-Pudov opened a pull request:

https://github.com/apache/ignite/pull/4909

IGNITE-9126 Update Apache Kafka dependency



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9126

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4909


commit e81883de88965435e878fe60ddd5f933c05fe312
Author: Max-Pudov 
Date:   2018-10-03T16:39:21Z

IGNITE-9126 Update Apache Kafka dependency




---

[GitHub] asfgit closed pull request #24: IGNITE-9697 Autocomplete branch for TC field

asfgit closed pull request #24: IGNITE-9697 Autocomplete branch for TC field
URL: https://github.com/apache/ignite-teamcity-bot/pull/24
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/HelperConfig.java 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/HelperConfig.java
index 67be102..c39fd1e 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/HelperConfig.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/HelperConfig.java
@@ -54,6 +54,12 @@
 /** JIRA authorization token property name. */
 public static final String JIRA_AUTH_TOKEN = "jira.auth_token";
 
+/** JIRA authorization token property name. */
+public static final String GIT_API_URL = "git.api_url";
+
+/** JIRA authorization token property name. */
+public static final String JIRA_API_URL = "jira.api_url";
+
 /** Slack authorization token property name. */
 public static final String SLACK_AUTH_TOKEN = "slack.auth_token";
 public static final String SLACK_CHANNEL = "slack.channel";
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
index 3193ea8..8f58657 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
@@ -319,6 +319,25 @@ default SingleBuildRunCtx loadTestsAndProblems(@Nonnull 
Build build, @Deprecated
  */
 boolean sendJiraComment(String ticket, String comment);
 
+/**
+ * @param url URL for git integration.
+ */
+void setGitApiUrl(String url);
+
+/**
+ * @return URL for git integration.
+ */
+String getGitApiUrl();
+
+/**
+ * @param url URL for JIRA integration.
+ */
+void setJiraApiUrl(String url);
+
+/**
+ * @return URL for JIRA integration.
+ */
+String getJiraApiUrl();
 
 default void setAuthData(String user, String password) {
 setAuthToken(
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
index ec53d9b..2e9f873 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
@@ -1168,6 +1168,26 @@ public void setExecutor(ExecutorService executor) {
 return teamcity.sendJiraComment(ticket, comment);
 }
 
+/** {@inheritDoc} */
+@Override public void setGitApiUrl(String url) {
+teamcity.setGitApiUrl(url);
+}
+
+/** {@inheritDoc} */
+@Override public String getGitApiUrl() {
+return teamcity.getGitApiUrl();
+}
+
+/** {@inheritDoc} */
+@Override public void setJiraApiUrl(String url) {
+teamcity.setJiraApiUrl(url);
+}
+
+/** {@inheritDoc} */
+@Override public String getJiraApiUrl() {
+return teamcity.getJiraApiUrl();
+}
+
 /** {@inheritDoc} */
 @Override public PullRequest getPullRequest(String branchForTc) {
 return teamcity.getPullRequest(branchForTc);
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
index 6b63f1b..3d68ccb 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
@@ -104,6 +104,12 @@
 /**  JIRA authorization token. */
 private String jiraBasicAuthTok;
 
+/** URL for git integration. */
+private String gitApiUrl;
+
+/** URL for JIRA integration. */
+private String jiraApiUrl;
+
 private String configName; //main properties file name
 private String tcName;
 
@@ -130,8 +136,10 @@ public void init(@Nullable String tcName) {
 }
 
 setGitToken(HelperConfig.prepareGithubHttpAuthToken(props));
+setGitApiUrl(props.getProperty(HelperConfig.GIT_API_URL));
 
 setJiraToken(HelperConfig.prepareJiraHttpAuthToken(props));
+setJiraApiUrl(props.getProperty(HelperConfig.JIRA_API_URL));
 
 final File logsDirFile = HelperConfig.resolveLogs(workDir, props);
 
@@ -173,8 +181,14 @@ public void init(@Nullable String tcName) {
 /** {@inheritDoc} */
 @AutoProfiling
 @Override public boolean sendJiraComment(String ticket, String comment) {
+if (isNullOrEmpty(jiraApiUrl)) {
+logger.error("Failed to notify JIRA [errMsg=JIRA API URL is not

[GitHub] ignite pull request #4910: IGNITE-9390: Fixed memory metrics tests.

2018-10-03 Thread rkondakov

GitHub user rkondakov opened a pull request:

https://github.com/apache/ignite/pull/4910

IGNITE-9390: Fixed memory metrics tests.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9390

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4910


commit dce38c4a2bd1a075ae78ebe59e8b43bfb50f3306
Author: rkondakov 
Date:   2018-10-03T18:17:57Z

IGNITE-9390: Fixed memory metrics tests.




---

[GitHub] ignite pull request #4903: IGNITE-9722

Github user devozerov closed the pull request at:

https://github.com/apache/ignite/pull/4903


---

Re: Apache Ignite 2.7 release

2018-10-03 Thread Vladimir Ozerov

Igniters,

We observe serious drop in SQL performance. Corresponding ticket with
"blocker" priority has been added to AI 2.7 scope [1].

[1] https://issues.apache.org/jira/browse/IGNITE-9784

On Wed, Oct 3, 2018 at 2:02 PM Nikolay Izhikov  wrote:

> Alexey.
>
> Sorry, I lost link to IGNITE-9760 in this thread :)
>
> Thanks, for a clarification.
>
>
> В Ср, 03/10/2018 в 13:58 +0300, Alexey Goncharuk пишет:
> > Nikolay, both commits fixed a regression compared to ignite-2.6. First
> one was mentioned by Anton Kalashnikov before (java-level deadlock during
> WAL flush), another - by Andrey Kuznetsov (NPE during a concurrent WAL
> flush).
> >
> > --AG
> >
> > ср, 3 окт. 2018 г. в 13:38, Nikolay Izhikov :
> > > Hello, Igniters.
> > >
> > > Release scope is frozen.
> > > Please, if you include some new issues in release - discuss it in this
> thread.
> > >
> > > Alexey, can you, please, comment on including fix for IGNITE-9760,
> IGNITE-9761 in 2.7 branch.
> > >
> > >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=3355201f3e8cafd23b2250aaf3b91b8b8ed1
> > >
> https://git-wip-us.apache.org/repos/asf?p=ignite.git;a=commit;h=9d6e6ff394c05ddf7ef31a9d9ed1b492d9eeba69
> > >
> > > В Ср, 03/10/2018 в 13:24 +0300, Vladimir Ozerov пишет:
> > > > Nobody vetos anything, let's stop use this term unless some really
> > > > important problem is discussed.
> > > >
> > > > At this point we are in situation when new tickets are still
> included into
> > > > the scope. All want to ask is to stop including new tickets without
> > > > explaining on why they should be in AI 2.7. Regression between is AI
> 2.6
> > > > and AI 2.7 is enough. But "I found new NPE" is not.
> > > >
> > > > On Wed, Oct 3, 2018 at 11:10 AM Dmitriy Pavlov <
> dpavlov@gmail.com>
> > > > wrote:
> > > >
> > > > > Nikolay,
> > > > >
> > > > > this has nothing about scaring someone. Let me explain about
> Apache Way.
> > > > >
> > > > > Voting -1 to release does not mean blocking it, release can't be
> vetoed.
> > > > > Approving release is done by policy: majority approval. 3+1
> binding and
> > > > > more +1 than -1. Consensus approval is better but not mandatory.
> > > > >
> > > > > Instead, if PMC says -1 to code modification it means veto and
> can't be
> > > > > bypassed to anyone. This is a very strong statement, which should
> be
> > > > > applied reasonably and with technical justification. Lack of
> > > > > understanding is not a justification.
> > > > >
> > > > > So my point instead of vetoing bugfix let's veto commits where the
> bugs
> > > > > were introduced. I feel a number of bugs reported recently are all
> > > > > connected to WalManager, and these bugs may come from just a
> couple of
> > > > > fixes. PDS tests were quite stable last time, so I think it is
> possible to
> > > > > find out why WAL crashes and hangs.
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > ср, 3 окт. 2018 г. в 10:05, Andrey Kuznetsov :
> > > > >
> > > > > > Vladimir, Nikolay,
> > > > > >
> > > > > > For sure, I'm not an experienced Ignite contributor, so I'm
> sorry for
> > > > > > intervening. I've just run the reproducer from [1] against
> ignite-2.6
> > > > > > branch and it has passed. So, it's not an legacy bug, we've
> brought it
> > > > >
> > > > > with
> > > > > > some change of 2.7 scope. Is it still ok to ignore the bug?
> > > > > >
> > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-9776
> > > > > >
> > > > > > ср, 3 окт. 2018 г. в 2:07, Nikolay Izhikov  >:
> > > > > >
> > > > > > > Hello, Dmitriy.
> > > > > > >
> > > > > > > I'm sorry, but I don't understand your concern.
> > > > > > >
> > > > > > > Vladimir just asks experienced Ignite contributor to *explain
> impact*
> > > > >
> > > > > of
> > > > > > a
> > > > > > > bug.
> > > > > > >
> > > > > > > Why are you scaring us with your "-1"?
> > > > > > > Is it Apache Way to do so?
> > > > > > > What should be done for you to return to a constructive
> discussion?
> > > > > > >
> > > > > > > В Ср, 03/10/2018 в 00:23 +0300, Dmitriy Pavlov пишет:
> > > > > > > > Hi Igniters, Vladimir,
> > > > > > > >
> > > > > > > > NPEs or hangs in WAL is a completely non-functional grid (if
> > > > > >
> > > > > > persistence
> > > > > > > > enabled).
> > > > > > > >
> > > > > > > > I see no reasons to release 2.7 with such symptoms until
> we're sure
> > > > >
> > > > > it
> > > > > > is
> > > > > > > > too rare/impossible to reproduce. But it seems it is not the
> case. I
> > > > > >
> > > > > > will
> > > > > > > > definitely vote -1 for the release if I'm aware of such
> problems
> > > > >
> > > > > exist
> > > > > > > and
> > > > > > > > were not researched. Community guarantees the quality and
> usability
> > > > >
> > > > > of
> > > > > > > the
> > > > > > > > product.
> > > > > > > >
> > > > > > > > We should ask and answer other questions:
> > > > > > > > 1) why there are a lot of NPEs and hangs reported recently
> in the
> > > > >
> > > > > same
> > > > > >

Re: [Discussion] revert of commit MVCC, ignite-9320

2018-10-03 Thread Roman Kondakov

Dmitriy, Vladimir,

We added an extra memory region for TxLog and this change wasn't
reflected in .Net tests.

I've made a trivial fix for these issues:
https://github.com/apache/ignite/pull/4910

Tests are OK:
https://ci.ignite.apache.org/viewLog.html?buildId=1999429&tab=queuedBuildOverviewTab

Patch is ready for review and merge.

--
Kind Regards
Roman Kondakov

On 03.10.2018 18:06, Dmitriy Pavlov wrote:

Hi Igniters,

I see that https://issues.apache.org/jira/browse/IGNITE-9390 was resolved, but
.Net metrics tests are failing.
*New test failure in master DataRegionMetricsTest.TestMemoryMetrics
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6742613397597284603&branch=%3Cdefault%3E&tab=testDetails

*New test failure in master MemoryMetricsTest.TestMemoryMetrics
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-7558087625238261420&branch=%3Cdefault%3E&tab=testDetails

Pavel,

I did all I could by the moment to encourage these tests to be fixed, but
it seems we need your help to fix these test.

Assert fails 3 instead of 4 in test validation, could you please step in
and help with fixing this?

Sincerely,
Dmitriy Pavlov

сб, 29 сент. 2018 г. в 12:29, Dmitriy Pavlov :

Vladimir, I agree more with Andrey's fix in the parity test, because it
disables only specific property failure.

If we keep .NET parity test failed for a long time, some other
contributor will introduce new property- it will begin to fail always - it
is like a snowball.

I hope the metrics test will also be fixed before 2.7

Sincerely,
Dmitriy Pavlov

пт, 28 сент. 2018 г. в 14:43, Павлухин Иван :

Hi guys!

By the way, is it practically feasible to revert a single commit without
making harm? If I am getting it right in current case reverting commit
will
lead to compilation errors for commits depending on commit in question.

2018-09-28 14:22 GMT+03:00 Dmitriy Pavlov :

Hi Dmitriy S.,

I really prefer avoiding reverts, which why I've started this topic. If

were reverting-fan, I could just write: "Vetoing commit because of
test failures , commit reverted, ticket IGNITE- reopened."

But some time ago I several times asked newbie contributors to fix

missed

test failures and they managed to do it in 1-2 days, I'm waiting these

test

to be fixed by Ignite veteran(s) for 11 days.

Sincerely,
Dmitriy Pavlov

пт, 28 сент. 2018 г. в 13:16, Vladimir Ozerov :

Andrey,

This is not a fix, but a hack, which covers real state of affairs.

пт, 28 сент. 2018 г. в 13:00, Andrey Mashenkov <

andrey.mashen...@gmail.com

:
Hi,

Fix is trivial and ready.
Hope, it will be merged within IGNITE-7764 today.

https://issues.apache.org/jira/browse/IGNITE-7764

On Fri, Sep 28, 2018 at 12:26 PM Dmitriy Setrakyan <

dsetrak...@apache.org>

wrote:

Guys, let's just fix the tests without reverting commits.

Reverting a

commit may trigger a time machine, where all following commits

may be

broken because of it. Fixing that scenario will be much harder.

Going forward, I would agree that we should not merge anything

that

breaks

tests. This is about following a basic engineering discipline. We

should

all do it.

On Fri, Sep 28, 2018 at 12:47 AM Dmitriy Pavlov <

dpavlov@gmail.com

wrote:

Yep, we're humans and we constantly make mistakes. It is a very

human

thing

to do mistakes.

So I suggest we will be under the control and protection of

robot

avoid

mistakes, I suggest robot will revert such commits in 72h

without

its

own

personal attitudes, emotions, etc.

Someone who is interested in contribution usually can find time

make

contribution perfect.

I'm not aware of project priorities, please share it. I believe

different

priorities can co-exist. A number of contributors are fixing

tests,

is a priority for them, isn't it? So why to add work to that

guys

because

of you have other priorities?

пт, 28 сент. 2018 г. в 10:39, Vladimir Ozerov <

voze...@gridgain.com

Because a lot of other activities depended on configuration in

Java,

and

didn't have expertise to fix .NET immediately.

If you want to revert it - please go ahead. But I'd better

suggest

you

think about the impact and project priorities first, instead

trying

apply the some sort rules blindly. We are not robots.

On Fri, Sep 28, 2018 at 10:19 AM Dmitriy Pavlov <

dpavlov@gmail.com

wrote:

Hi Vladimir,

https://issues.apache.org/jira/browse/IGNITE-9320 is named

configuration

finalization.

Why finalization was considered as done without tests

passing?

Why can't ve revert finalization change, re-do finalization

with

passing

tests and merge changes?

Sincerely,
Dmitriy Pavlov

пт, 28 сент. 2018 г. в 8:16, Vladimir Ozerov <

voze...@gridgain.com

Test is going to be fixed in the scope of AI 2.7 [1].

This is

not

one-minute fix as there are multiple places where

configuration

should

passed, and changes should be

[GitHub] ignite pull request #4910: IGNITE-9390: Fixed memory metrics tests.

Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4910


---

Re: [Discussion] revert of commit MVCC, ignite-9320