[jira] [Created] (HIVE-26461) Add CI build check for macOS

[Stamatis Zampetakis (Jira)]

Stamatis Zampetakis created HIVE-26461:
--

 Summary: Add CI build check for macOS
 Key: HIVE-26461
 URL: https://issues.apache.org/jira/browse/HIVE-26461
 Project: Hive
  Issue Type: Test
  Components: Build Infrastructure
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis


Add CI builds for Hive over macOS distribution to test that the project can be 
compiled successfully in this platform and ensure that future changes will not 
break it accidentally.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [DISCUSS] SonarCloud integration for Apache Hive

[Stamatis Zampetakis]

That's great news! From the initial message, I got the impression that the
Sonar label in the PR will report all problems currently in master (and not
only the new ones).

I agree, it is better not to enforce quality gates directly but leave some
time for the rest of us to get familiar with the tool.

Best,
Stamatis

On Tue, Aug 9, 2022 at 6:04 PM Alessandro Solimando <
alessandro.solima...@gmail.com> wrote:

> Hi Stamatis,
> glad to hear you find Sonar helpful, thanks for providing your feedback.
>
> The master branch analysis already provides what I think you are looking
> for, you have:
>
>- all code analysis (to see the full status of the code):
>https://sonarcloud.io/summary/overall?id=apache_hive
>- new code analysis (basically what changed in the last commit):
>https://sonarcloud.io/summary/new_code?id=apache_hive
>
> For PRs, similarly, the analysis covers the changes w.r.t. the target
> branch, it's a good and quick way to ascertain the code quality of the PR.
>
> Regarding "Is it possible to somehow save the current analysis on master
> and make the
> PR quality gates fail when things become worse?", it is definitely
> possible, we can define a success/failure threshold for each of the
> metrics, and make it fail if the quality gate criteria are not met.
>
> I was suggesting to postpone this to allow people to get first familiar
> with it, I would not want to disrupt existing work, Sonar is a rich tool
> and people might need a bit of time to adjust to it.
>
> Good news is that quality gates can be changed directly from SonarCloud and
> won't require code changes, we might kick in a feedback discussion after a
> month or so from when we introduce Sonar analysis and see what people
> think.
>
> Best regards,
> Alessandro
>
> On Tue, 9 Aug 2022 at 16:38, Stamatis Zampetakis 
> wrote:
>
> > Hi Alessandro,
> >
> > Sonar integration will definitely help in improving cope quality and
> > preventing bugs so many thanks for pushing this forward.
> >
> > I went over the PR and it is in good shape. I plan to merge it in the
> > following days unless someone objects.
> > We can tackle further improvements in follow up JIRAs.
> >
> > Is it possible to somehow save the current analysis on master and make
> the
> > PR quality gates fail when things become worse?
> > If not then what may help in reviewing PRs is to have a diff view
> (between
> > a PR and current master) so we can quickly tell if the PR we are about to
> > merge makes things better or worse; as far as I understand the idea is to
> > do this manually at the moment by checking the results on master and on
> the
> > PR under review.
> >
> > Enabling code coverage would be very helpful as well. Looking forward to
> > this.
> >
> > Best,
> > Stamatis
> >
> > On Mon, Aug 8, 2022 at 1:22 PM Alessandro Solimando <
> > alessandro.solima...@gmail.com> wrote:
> >
> > > Errata corrige: the right PR link is the following
> > > https://github.com/apache/hive/pull/3254
> > >
> > > Best regards,
> > > Alessandro
> > >
> > > On Mon, 8 Aug 2022 at 10:04, Alessandro Solimando <
> > > alessandro.solima...@gmail.com> wrote:
> > >
> > > > Hi community,
> > > > in the context of HIVE-26196
> > > >  we started
> > > considering
> > > > the adoption of SonarCloud  analysis
> > for
> > > > Apache Hive to promote data-driven code quality improvements and to
> > allow
> > > > reviewers to focus on the conceptual part of the changes by helping
> > them
> > > > spot trivial code smells, security issues and bugs.
> > > >
> > > > SonarCloud has already been adopted and integrated into a few top
> > Apache
> > > > projects like DolphinScheduler  >
> > > and Apache
> > > > Jackrabbit FileVault .
> > > >
> > > > For those who don't know, Sonar is a code analysis tool, the initial
> > > > adoption would aim at tracking code quality for the master branch,
> and
> > > > making the PRs' review process easier, by allowing to compare which
> > > > code/security issues a PR solved/introduced with respect to the main
> > > branch.
> > > >
> > > > We already have a Hive-dedicated project under the Apache
> foundation's
> > > > SonarCloud account:
> > > https://sonarcloud.io/project/overview?id=apache_hive.
> > > >
> > > > In what follows I will highlight the main points of interest:
> > > >
> > > > 1) sonar adoption scope:
> > > > For the time being a descriptive approach (just show the analysis and
> > > > associated metrics) could be adopted, delaying a prescriptive one
> > (i.e.,
> > > > quality gates based on the metrics for PRs' mergeability) to a later
> > time
> > > > where we have tested SonarCloud for long enough to judge that it
> could
> > > be a
> > > > sensible move.
> > > >
> > > > 2) false positives:
> > > > Sonar suffers from false positives, but they can be marked as such
> from
> > > > the web 

[jira] [Created] (HIVE-26462) SMTP mail alerts for critical DML's

[Naresh P R (Jira)]

Naresh P R created HIVE-26462:
-

 Summary: SMTP mail alerts for critical DML's
 Key: HIVE-26462
 URL: https://issues.apache.org/jira/browse/HIVE-26462
 Project: Hive
  Issue Type: New Feature
Reporter: Naresh P R


Any alerting mechanism via smtp to single configured email for mission critical 
DMLs like

Drop db/table/partition/materialized view/view on specific db/table pattern 
will be very useful on production systems.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)