Re: MavenGrapeEngine?

2017-01-10 Thread Romain Manni-Bucau
Ok, imported the project and...discovered changing() :). Think it can solve
the issue for now. Then the remaining question is the duplication of the
repo but guess I can live with it for now. In GrapeIvy do we want to move

boolean changing   = deps.containsKey('changing')   ? deps.changing   : false

to

boolean changing   = deps.containsKey('changing')   ? deps.changing ||
version.endsWith('-SNAPSHOT')   : false


?

Not an issue if not, would just makes maven standard better integrated with
the pitfall of having changing value forced (so less obvious).

wdyt?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-01-10 1:36 GMT+01:00 Jochen Theodorou :

> well... contributions are welcome ;)
>
> On 06.01.2017 15:36, Romain Manni-Bucau wrote:
>
>>
>>
>> 2017-01-06 15:33 GMT+01:00 Jochen Theodorou > >:
>>
>>
>> On 06.01.2017 15:00, Romain Manni-Bucau wrote:
>> [...]
>>
>> Means SNAPSHOT patterns needs to be identified (likely a flag in
>> the
>> @Grab(snapshot=true)?) and groovy should clean up the artifacts
>> before
>> resolving to avoid to let ivy mess up its repo.
>>
>>
>> which means it is more than just a change in the configuration file.
>>
>>
>> Both options are valid but I think you had a good point and it can be
>> API intrusive
>>
>> For maven based artifact
>> it also means you run copies instead of maven repository ones
>> which is
>> leading to unexpected runtime sometimes.
>>
>>
>> can you explain a bit more? you mean the local ivy repo with copy?
>>
>>
>> Yes, if you don't remove the snapshot copy from ~/.groovy/grapes/ then
>> you use the last resolved one which is likely outdated with maven repo.
>>
>>  - what kind of SPI groovy would use (ATM GrapeEngine
>> lookup is quite
>>  hardcoded): do we want a config in groovy installation
>> + system
>>  property?
>>
>>  would someone want to define the engine as part of the
>> annotation or
>>  should this be automatic in the background? We could also
>> think of
>>  using the Java service provider interface logic - of course
>> then we
>>  have to think about what to do if multiple engines are there
>>
>> sounds good in @Grab with probably a default globally settable
>> in the
>> script.
>>
>>
>> yes I think we can do that
>>
>>  - if we want another engine: how do we manage
>> dependencies? do we
>>  isolate them from groovy libs?
>>
>>
>>  they should be optional for the delivery and in the
>> light of
>>  that I think depending on spring-boot-cli is an option
>>
>> Alternative is to implement it in groovy without maven in a light
>> fashion, with
>> https://github.com/apache/tomee/blob/master/container/openej
>> b-loader/src/main/java/org/apache/openejb/loader/provisin
>> ing/MavenResolver.java
>> > jb-loader/src/main/java/org/apache/openejb/loader/provisin
>> ing/MavenResolver.java>
>> and
>> https://github.com/apache/tomee/blob/master/container/openej
>> b-loader/src/main/java/org/apache/openejb/loader/provisin
>> ing/HttpResolver.java
>> > jb-loader/src/main/java/org/apache/openejb/loader/provisin
>> ing/HttpResolver.java>
>> you can resolve most of maven artifacts. This code needs to be
>> reworked
>> on its config side cause it is specific to tomee but my point is
>> in <
>> 400 LOC you can get a maven resolver you own and therefore
>> supporting
>> snapshots is very doable there.
>>
>>
>> I would prefer depending on something existing, but 400 LOC is not
>> much and if that goes without further dependencies... well then we
>> should consider doing that
>>
>>
>> Agree, I only know aether (or its forks) which are far from 400 LOC but
>> alternatives welcomed as well if they exist
>>
>> bye Jochen
>>
>>
>>
>


Re: MavenGrapeEngine?

2017-01-10 Thread Paul King
Perhaps something can be done but some people use snapshots without
any timestamps. As long as that didn't break. I think years ago it
became a lot slower in that scenario if we auto set 'changing'. Not
sure if that is the case any longer.

Cheers, Paul.

On Tue, Jan 10, 2017 at 6:48 PM, Romain Manni-Bucau
 wrote:
> Ok, imported the project and...discovered changing() :). Think it can solve
> the issue for now. Then the remaining question is the duplication of the
> repo but guess I can live with it for now. In GrapeIvy do we want to move
>
> boolean changing   = deps.containsKey('changing')   ? deps.changing   :
> false
>
> to
>
> boolean changing   = deps.containsKey('changing')   ? deps.changing ||
> version.endsWith('-SNAPSHOT')   : false
>
>
> ?
>
> Not an issue if not, would just makes maven standard better integrated with
> the pitfall of having changing value forced (so less obvious).
>
> wdyt?
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | JavaEE Factory
>
> 2017-01-10 1:36 GMT+01:00 Jochen Theodorou :
>>
>> well... contributions are welcome ;)
>>
>> On 06.01.2017 15:36, Romain Manni-Bucau wrote:
>>>
>>>
>>>
>>> 2017-01-06 15:33 GMT+01:00 Jochen Theodorou >> >:
>>>
>>>
>>> On 06.01.2017 15:00, Romain Manni-Bucau wrote:
>>> [...]
>>>
>>> Means SNAPSHOT patterns needs to be identified (likely a flag in
>>> the
>>> @Grab(snapshot=true)?) and groovy should clean up the artifacts
>>> before
>>> resolving to avoid to let ivy mess up its repo.
>>>
>>>
>>> which means it is more than just a change in the configuration file.
>>>
>>>
>>> Both options are valid but I think you had a good point and it can be
>>> API intrusive
>>>
>>> For maven based artifact
>>> it also means you run copies instead of maven repository ones
>>> which is
>>> leading to unexpected runtime sometimes.
>>>
>>>
>>> can you explain a bit more? you mean the local ivy repo with copy?
>>>
>>>
>>> Yes, if you don't remove the snapshot copy from ~/.groovy/grapes/ then
>>> you use the last resolved one which is likely outdated with maven repo.
>>>
>>>  - what kind of SPI groovy would use (ATM GrapeEngine
>>> lookup is quite
>>>  hardcoded): do we want a config in groovy installation
>>> + system
>>>  property?
>>>
>>>  would someone want to define the engine as part of the
>>> annotation or
>>>  should this be automatic in the background? We could also
>>> think of
>>>  using the Java service provider interface logic - of course
>>> then we
>>>  have to think about what to do if multiple engines are there
>>>
>>> sounds good in @Grab with probably a default globally settable
>>> in the
>>> script.
>>>
>>>
>>> yes I think we can do that
>>>
>>>  - if we want another engine: how do we manage
>>> dependencies? do we
>>>  isolate them from groovy libs?
>>>
>>>
>>>  they should be optional for the delivery and in the
>>> light of
>>>  that I think depending on spring-boot-cli is an option
>>>
>>> Alternative is to implement it in groovy without maven in a light
>>> fashion, with
>>>
>>> https://github.com/apache/tomee/blob/master/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/MavenResolver.java
>>>
>>> 
>>> and
>>>
>>> https://github.com/apache/tomee/blob/master/container/openejb-loader/src/main/java/org/apache/openejb/loader/provisining/HttpResolver.java
>>>
>>> 
>>> you can resolve most of maven artifacts. This code needs to be
>>> reworked
>>> on its config side cause it is specific to tomee but my point is
>>> in <
>>> 400 LOC you can get a maven resolver you own and therefore
>>> supporting
>>> snapshots is very doable there.
>>>
>>>
>>> I would prefer depending on something existing, but 400 LOC is not
>>> much and if that goes without further dependencies... well then we
>>> should consider doing that
>>>
>>>
>>> Agree, I only know aether (or its forks) which are far from 400 LOC but
>>> alternatives welcomed as well if they exist
>>>
>>> bye Jochen
>>>
>>>
>>
>


Re: MavenGrapeEngine?

2017-01-10 Thread Romain Manni-Bucau
Hmm, ibiblio (localm2 in grapesConfig.xml) has setChangingPattern(
".*-SNAPSHOT"); so should have worked OOTBbut

org.apache.ivy.plugins.resolver.ChainResolver#getDependency checks the ivy
(default) cache before using resolvers so resolvers are basically skipped
and even the localm2 good behavior is ignored cause
in org.apache.ivy.plugins.resolver.BasicResolver#getDependency
shouldReturnResolvedModule() makes  it bypassed

Looks like a bug in ivy, wdyt? Adding in this test a changing pattern test (
String.valueOf(dd.getAttribute("revision")).matches(getChangingPattern()))
would make it working.

Of course this is doable in groovy but should probably be reported to ivy.

Wdyt?



Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-01-10 10:10 GMT+01:00 Paul King :

> Perhaps something can be done but some people use snapshots without
> any timestamps. As long as that didn't break. I think years ago it
> became a lot slower in that scenario if we auto set 'changing'. Not
> sure if that is the case any longer.
>
> Cheers, Paul.
>
> On Tue, Jan 10, 2017 at 6:48 PM, Romain Manni-Bucau
>  wrote:
> > Ok, imported the project and...discovered changing() :). Think it can
> solve
> > the issue for now. Then the remaining question is the duplication of the
> > repo but guess I can live with it for now. In GrapeIvy do we want to move
> >
> > boolean changing   = deps.containsKey('changing')   ? deps.changing   :
> > false
> >
> > to
> >
> > boolean changing   = deps.containsKey('changing')   ? deps.changing ||
> > version.endsWith('-SNAPSHOT')   : false
> >
> >
> > ?
> >
> > Not an issue if not, would just makes maven standard better integrated
> with
> > the pitfall of having changing value forced (so less obvious).
> >
> > wdyt?
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | JavaEE Factory
> >
> > 2017-01-10 1:36 GMT+01:00 Jochen Theodorou :
> >>
> >> well... contributions are welcome ;)
> >>
> >> On 06.01.2017 15:36, Romain Manni-Bucau wrote:
> >>>
> >>>
> >>>
> >>> 2017-01-06 15:33 GMT+01:00 Jochen Theodorou  >>> >:
> >>>
> >>>
> >>> On 06.01.2017 15:00, Romain Manni-Bucau wrote:
> >>> [...]
> >>>
> >>> Means SNAPSHOT patterns needs to be identified (likely a flag
> in
> >>> the
> >>> @Grab(snapshot=true)?) and groovy should clean up the artifacts
> >>> before
> >>> resolving to avoid to let ivy mess up its repo.
> >>>
> >>>
> >>> which means it is more than just a change in the configuration
> file.
> >>>
> >>>
> >>> Both options are valid but I think you had a good point and it can be
> >>> API intrusive
> >>>
> >>> For maven based artifact
> >>> it also means you run copies instead of maven repository ones
> >>> which is
> >>> leading to unexpected runtime sometimes.
> >>>
> >>>
> >>> can you explain a bit more? you mean the local ivy repo with copy?
> >>>
> >>>
> >>> Yes, if you don't remove the snapshot copy from ~/.groovy/grapes/ then
> >>> you use the last resolved one which is likely outdated with maven repo.
> >>>
> >>>  - what kind of SPI groovy would use (ATM GrapeEngine
> >>> lookup is quite
> >>>  hardcoded): do we want a config in groovy installation
> >>> + system
> >>>  property?
> >>>
> >>>  would someone want to define the engine as part of the
> >>> annotation or
> >>>  should this be automatic in the background? We could also
> >>> think of
> >>>  using the Java service provider interface logic - of
> course
> >>> then we
> >>>  have to think about what to do if multiple engines are
> there
> >>>
> >>> sounds good in @Grab with probably a default globally settable
> >>> in the
> >>> script.
> >>>
> >>>
> >>> yes I think we can do that
> >>>
> >>>  - if we want another engine: how do we manage
> >>> dependencies? do we
> >>>  isolate them from groovy libs?
> >>>
> >>>
> >>>  they should be optional for the delivery and in the
> >>> light of
> >>>  that I think depending on spring-boot-cli is an option
> >>>
> >>> Alternative is to implement it in groovy without maven in a
> light
> >>> fashion, with
> >>>
> >>> https://github.com/apache/tomee/blob/master/container/
> openejb-loader/src/main/java/org/apache/openejb/loader/
> provisining/MavenResolver.java
> >>>
> >>>  openejb-loader/src/main/java/org/apache/openejb/loader/
> provisining/MavenResolver.java>
> >>> and
> 

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Paul King
John found an issue with "install" if you don't have signing properties in
place. As painful as it is, I'll cancel the vote and try again.

I have re-run the tweaked build script and the new artifacts are
re-uploaded to the same place on the DEV server. Anyone want to give
it a quick try before I do a formal re-start of the vote tomorrow?
Install now works for me with and without signing in place.

Cheers, Paul.

On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner
 wrote:
> With the downloaded source I was using gradle 2.14.  I also fetched the
> GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the error
> with both.  Not sure if I need to set up a property to point to gpg keys,
> but haven't had to do that in the past.
>
> On Mon, Jan 9, 2017 at 7:42 PM, Paul King  wrote:
>>
>> Can you check the version of gradle that is running? The artifacts are
>> built using install and install works fine for me from the src zip.
>>
>> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
>>  wrote:
>> > When I run `gradlew install` from source (both from the downloaded zip
>> > and
>> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior to
>> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
>> > build
>> > and wont install the artifacts in the local maven repo.
>> >
>> > [1]
>> >
>> > https://github.com/apache/groovy/commit/9fa4b015e4a80ef036ef32aa48158f8360663000
>> >
>> > ---
>> > :groovy-groovydoc:javadoc
>> > :groovy-ant:javadoc
>> >
>> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/codehaus/groovy/ant/Groovyc.java:42:
>> > error: cannot find symbol
>> > import org.apache.commons.cli.GroovyInternalPosixParser;
>> >  ^
>> >   symbol:   class GroovyInternalPosixParser
>> >   location: package org.apache.commons.cli
>> > 1 warning
>> > :groovy-ant:javadocJar
>> > :groovy-ant:install FAILED
>> >
>> > FAILURE: Build failed with an exception.
>> >
>> > * What went wrong:
>> > Execution failed for task ':groovy-ant:install'.
>> >> Could not publish configuration 'archives'
>> >> Cannot publish artifact 'groovy-ant.jar.asc
>> > (org.codehaus.groovy:groovy-ant:2.4.8)'
>> >
>> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc) 
>> > as
>> > it does not exist.
>> >
>> > * Try:
>> > Run with --stacktrace option to get the stack trace. Run with --info or
>> > --debug option to get more log output.
>> >
>> > BUILD FAILED
>> > ---
>> >
>> >
>> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King  wrote:
>> >>
>> >> Dear community,
>> >>
>> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>> >>
>> >> This release includes 84 bug fixes/improvements as outlined in the
>> >> changelog:
>> >>
>> >>
>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950
>> >>
>> >> Tag:
>> >>
>> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
>> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
>> >>
>> >> The artifacts to be voted on are located as follows (r17713).
>> >> Source release:
>> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> >> Convenience binaries:
>> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>> >>
>> >> Release artifacts are signed with a key from the following file:
>> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >>
>> >> Please vote on releasing this package as Apache Groovy 2.4.8.
>> >>
>> >> The vote is open for the next 72 hours and passes if a majority of at
>> >> least three +1 PMC votes are cast.
>> >>
>> >> [ ] +1 Release Apache Groovy 2.4.8
>> >> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> >> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>> >>
>> >> Here is my vote:
>> >>
>> >> +1 (binding)
>> >
>> >
>
>


Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Cédric Champeau
Was it such a big deal we needed to cancel the vote? I find it a bit
unfortunate, since "building" just works, or that setting the signing
properties do. Anyway I leave it to you.

2017-01-10 12:37 GMT+01:00 Paul King :

> John found an issue with "install" if you don't have signing properties in
> place. As painful as it is, I'll cancel the vote and try again.
>
> I have re-run the tweaked build script and the new artifacts are
> re-uploaded to the same place on the DEV server. Anyone want to give
> it a quick try before I do a formal re-start of the vote tomorrow?
> Install now works for me with and without signing in place.
>
> Cheers, Paul.
>
> On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner
>  wrote:
> > With the downloaded source I was using gradle 2.14.  I also fetched the
> > GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the
> error
> > with both.  Not sure if I need to set up a property to point to gpg keys,
> > but haven't had to do that in the past.
> >
> > On Mon, Jan 9, 2017 at 7:42 PM, Paul King  wrote:
> >>
> >> Can you check the version of gradle that is running? The artifacts are
> >> built using install and install works fine for me from the src zip.
> >>
> >> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
> >>  wrote:
> >> > When I run `gradlew install` from source (both from the downloaded zip
> >> > and
> >> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior to
> >> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
> >> > build
> >> > and wont install the artifacts in the local maven repo.
> >> >
> >> > [1]
> >> >
> >> > https://github.com/apache/groovy/commit/
> 9fa4b015e4a80ef036ef32aa48158f8360663000
> >> >
> >> > ---
> >> > :groovy-groovydoc:javadoc
> >> > :groovy-ant:javadoc
> >> >
> >> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/
> codehaus/groovy/ant/Groovyc.java:42:
> >> > error: cannot find symbol
> >> > import org.apache.commons.cli.GroovyInternalPosixParser;
> >> >  ^
> >> >   symbol:   class GroovyInternalPosixParser
> >> >   location: package org.apache.commons.cli
> >> > 1 warning
> >> > :groovy-ant:javadocJar
> >> > :groovy-ant:install FAILED
> >> >
> >> > FAILURE: Build failed with an exception.
> >> >
> >> > * What went wrong:
> >> > Execution failed for task ':groovy-ant:install'.
> >> >> Could not publish configuration 'archives'
> >> >> Cannot publish artifact 'groovy-ant.jar.asc
> >> > (org.codehaus.groovy:groovy-ant:2.4.8)'
> >> >
> >> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc)
> as
> >> > it does not exist.
> >> >
> >> > * Try:
> >> > Run with --stacktrace option to get the stack trace. Run with --info
> or
> >> > --debug option to get more log output.
> >> >
> >> > BUILD FAILED
> >> > ---
> >> >
> >> >
> >> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King 
> wrote:
> >> >>
> >> >> Dear community,
> >> >>
> >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
> >> >>
> >> >> This release includes 84 bug fixes/improvements as outlined in the
> >> >> changelog:
> >> >>
> >> >>
> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12335950
> >> >>
> >> >> Tag:
> >> >>
> >> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_4_8
> >> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
> >> >>
> >> >> The artifacts to be voted on are located as follows (r17713).
> >> >> Source release:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
> >> >> Convenience binaries:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
> >> >>
> >> >> Release artifacts are signed with a key from the following file:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
> >> >>
> >> >> Please vote on releasing this package as Apache Groovy 2.4.8.
> >> >>
> >> >> The vote is open for the next 72 hours and passes if a majority of at
> >> >> least three +1 PMC votes are cast.
> >> >>
> >> >> [ ] +1 Release Apache Groovy 2.4.8
> >> >> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> >> >> [ ] -1 Do not release Apache Groovy 2.4.8 because...
> >> >>
> >> >> Here is my vote:
> >> >>
> >> >> +1 (binding)
> >> >
> >> >
> >
> >
>


RE: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Uwe Schindler
Hi,

 

This also delays fixing Lucene‘s build system for our release Lucene 6.4, so we 
can test Java 9 build 148+. So it’s a pity!

 

Uwe

 

-

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de  

eMail: u...@thetaphi.de

 

From: Cédric Champeau [mailto:cedric.champ...@gmail.com] 
Sent: Tuesday, January 10, 2017 12:42 PM
To: dev@groovy.apache.org; Paul King 
Cc: John Wagenleitner 
Subject: Re: [VOTE] Release Groovy 2.4.8

 

Was it such a big deal we needed to cancel the vote? I find it a bit 
unfortunate, since "building" just works, or that setting the signing 
properties do. Anyway I leave it to you.

 

2017-01-10 12:37 GMT+01:00 Paul King mailto:pa...@asert.com.au> >:

John found an issue with "install" if you don't have signing properties in
place. As painful as it is, I'll cancel the vote and try again.

I have re-run the tweaked build script and the new artifacts are
re-uploaded to the same place on the DEV server. Anyone want to give
it a quick try before I do a formal re-start of the vote tomorrow?
Install now works for me with and without signing in place.

Cheers, Paul.

On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner

mailto:john.wagenleit...@gmail.com> > wrote:
> With the downloaded source I was using gradle 2.14.  I also fetched the
> GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the error
> with both.  Not sure if I need to set up a property to point to gpg keys,
> but haven't had to do that in the past.
>
> On Mon, Jan 9, 2017 at 7:42 PM, Paul King   > wrote:
>>
>> Can you check the version of gradle that is running? The artifacts are
>> built using install and install works fine for me from the src zip.
>>
>> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
>> mailto:john.wagenleit...@gmail.com> > wrote:
>> > When I run `gradlew install` from source (both from the downloaded zip
>> > and
>> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior to
>> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
>> > build
>> > and wont install the artifacts in the local maven repo.
>> >
>> > [1]
>> >
>> > https://github.com/apache/groovy/commit/9fa4b015e4a80ef036ef32aa48158f8360663000
>> >
>> > ---
>> > :groovy-groovydoc:javadoc
>> > :groovy-ant:javadoc
>> >
>> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/codehaus/groovy/ant/Groovyc.java:42:
>> > error: cannot find symbol
>> > import org.apache.commons.cli.GroovyInternalPosixParser;
>> >  ^
>> >   symbol:   class GroovyInternalPosixParser
>> >   location: package org.apache.commons.cli
>> > 1 warning
>> > :groovy-ant:javadocJar
>> > :groovy-ant:install FAILED
>> >
>> > FAILURE: Build failed with an exception.
>> >
>> > * What went wrong:
>> > Execution failed for task ':groovy-ant:install'.
>> >> Could not publish configuration 'archives'
>> >> Cannot publish artifact 'groovy-ant.jar.asc
>> > (org.codehaus.groovy:groovy-ant:2.4.8)'
>> >
>> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc) 
>> > as
>> > it does not exist.
>> >
>> > * Try:
>> > Run with --stacktrace option to get the stack trace. Run with --info or
>> > --debug option to get more log output.
>> >
>> > BUILD FAILED
>> > ---
>> >
>> >
>> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King > >  > wrote:
>> >>
>> >> Dear community,
>> >>
>> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>> >>
>> >> This release includes 84 bug fixes/improvements as outlined in the
>> >> changelog:
>> >>
>> >>
>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123 
>> >> 
>> >>  &version=12335950
>> >>
>> >> Tag:
>> >>
>> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
>> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
>> >>
>> >> The artifacts to be voted on are located as follows (r17713).
>> >> Source release:
>> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> >> Convenience binaries:
>> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>> >>
>> >> Release artifacts are signed with a key from the following file:
>> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >>
>> >> Please vote on releasing this package as Apache Groovy 2.4.8.
>> >>
>> >> The vote is open for the next 72 hours and passes if a majority of at
>> >> least three +1 PMC votes are cast.
>> >>
>> >> [ ] +1 Release Apache Groovy 2.4.8
>> >> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> >> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>> >>
>> >> Here is my vote:
>> >>
>> >> +1 (binding)
>> >
>> >
>
>

 



Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Guillaume Laforge
I also believe it's okay, and not critical, leading us to cancel the vote.
We can just list that point as a known (minor) issue.

On Tue, Jan 10, 2017 at 12:41 PM, Cédric Champeau  wrote:

> Was it such a big deal we needed to cancel the vote? I find it a bit
> unfortunate, since "building" just works, or that setting the signing
> properties do. Anyway I leave it to you.
>
> 2017-01-10 12:37 GMT+01:00 Paul King :
>
>> John found an issue with "install" if you don't have signing properties in
>> place. As painful as it is, I'll cancel the vote and try again.
>>
>> I have re-run the tweaked build script and the new artifacts are
>> re-uploaded to the same place on the DEV server. Anyone want to give
>> it a quick try before I do a formal re-start of the vote tomorrow?
>> Install now works for me with and without signing in place.
>>
>> Cheers, Paul.
>>
>> On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner
>>  wrote:
>> > With the downloaded source I was using gradle 2.14.  I also fetched the
>> > GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the
>> error
>> > with both.  Not sure if I need to set up a property to point to gpg
>> keys,
>> > but haven't had to do that in the past.
>> >
>> > On Mon, Jan 9, 2017 at 7:42 PM, Paul King  wrote:
>> >>
>> >> Can you check the version of gradle that is running? The artifacts are
>> >> built using install and install works fine for me from the src zip.
>> >>
>> >> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
>> >>  wrote:
>> >> > When I run `gradlew install` from source (both from the downloaded
>> zip
>> >> > and
>> >> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior
>> to
>> >> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
>> >> > build
>> >> > and wont install the artifacts in the local maven repo.
>> >> >
>> >> > [1]
>> >> >
>> >> > https://github.com/apache/groovy/commit/9fa4b015e4a80ef036ef
>> 32aa48158f8360663000
>> >> >
>> >> > ---
>> >> > :groovy-groovydoc:javadoc
>> >> > :groovy-ant:javadoc
>> >> >
>> >> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/codehau
>> s/groovy/ant/Groovyc.java:42:
>> >> > error: cannot find symbol
>> >> > import org.apache.commons.cli.GroovyInternalPosixParser;
>> >> >  ^
>> >> >   symbol:   class GroovyInternalPosixParser
>> >> >   location: package org.apache.commons.cli
>> >> > 1 warning
>> >> > :groovy-ant:javadocJar
>> >> > :groovy-ant:install FAILED
>> >> >
>> >> > FAILURE: Build failed with an exception.
>> >> >
>> >> > * What went wrong:
>> >> > Execution failed for task ':groovy-ant:install'.
>> >> >> Could not publish configuration 'archives'
>> >> >> Cannot publish artifact 'groovy-ant.jar.asc
>> >> > (org.codehaus.groovy:groovy-ant:2.4.8)'
>> >> >
>> >> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc)
>> as
>> >> > it does not exist.
>> >> >
>> >> > * Try:
>> >> > Run with --stacktrace option to get the stack trace. Run with --info
>> or
>> >> > --debug option to get more log output.
>> >> >
>> >> > BUILD FAILED
>> >> > ---
>> >> >
>> >> >
>> >> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King 
>> wrote:
>> >> >>
>> >> >> Dear community,
>> >> >>
>> >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>> >> >>
>> >> >> This release includes 84 bug fixes/improvements as outlined in the
>> >> >> changelog:
>> >> >>
>> >> >>
>> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318123&version=12335950
>> >> >>
>> >> >> Tag:
>> >> >>
>> >> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>> ;h=refs/tags/GROOVY_2_4_8
>> >> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
>> >> >>
>> >> >> The artifacts to be voted on are located as follows (r17713).
>> >> >> Source release:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> >> >> Convenience binaries:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>> >> >>
>> >> >> Release artifacts are signed with a key from the following file:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >> >>
>> >> >> Please vote on releasing this package as Apache Groovy 2.4.8.
>> >> >>
>> >> >> The vote is open for the next 72 hours and passes if a majority of
>> at
>> >> >> least three +1 PMC votes are cast.
>> >> >>
>> >> >> [ ] +1 Release Apache Groovy 2.4.8
>> >> >> [ ]  0 I don't have a strong opinion about this, but I assume it's
>> ok
>> >> >> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>> >> >>
>> >> >> Here is my vote:
>> >> >>
>> >> >> +1 (binding)
>> >> >
>> >> >
>> >
>> >
>>
>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge  / Google+



Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Cédric Champeau
If the difference is just in fixing the build, maybe a shorter vote is
acceptable?

2017-01-10 13:37 GMT+01:00 Uwe Schindler :

> Hi,
>
>
>
> This also delays fixing Lucene‘s build system for our release Lucene 6.4,
> so we can test Java 9 build 148+. So it’s a pity!
>
>
>
> Uwe
>
>
>
> -
>
> Uwe Schindler
>
> Achterdiek 19, D-28357 Bremen
>
> http://www.thetaphi.de
>
> eMail: u...@thetaphi.de
>
>
>
> *From:* Cédric Champeau [mailto:cedric.champ...@gmail.com]
> *Sent:* Tuesday, January 10, 2017 12:42 PM
> *To:* dev@groovy.apache.org; Paul King 
> *Cc:* John Wagenleitner 
> *Subject:* Re: [VOTE] Release Groovy 2.4.8
>
>
>
> Was it such a big deal we needed to cancel the vote? I find it a bit
> unfortunate, since "building" just works, or that setting the signing
> properties do. Anyway I leave it to you.
>
>
>
> 2017-01-10 12:37 GMT+01:00 Paul King :
>
> John found an issue with "install" if you don't have signing properties in
> place. As painful as it is, I'll cancel the vote and try again.
>
> I have re-run the tweaked build script and the new artifacts are
> re-uploaded to the same place on the DEV server. Anyone want to give
> it a quick try before I do a formal re-start of the vote tomorrow?
> Install now works for me with and without signing in place.
>
> Cheers, Paul.
>
> On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner
>
>  wrote:
> > With the downloaded source I was using gradle 2.14.  I also fetched the
> > GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the
> error
> > with both.  Not sure if I need to set up a property to point to gpg keys,
> > but haven't had to do that in the past.
> >
> > On Mon, Jan 9, 2017 at 7:42 PM, Paul King  wrote:
> >>
> >> Can you check the version of gradle that is running? The artifacts are
> >> built using install and install works fine for me from the src zip.
> >>
> >> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
> >>  wrote:
> >> > When I run `gradlew install` from source (both from the downloaded zip
> >> > and
> >> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior to
> >> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
> >> > build
> >> > and wont install the artifacts in the local maven repo.
> >> >
> >> > [1]
> >> >
> >> > https://github.com/apache/groovy/commit/
> 9fa4b015e4a80ef036ef32aa48158f8360663000
> >> >
> >> > ---
> >> > :groovy-groovydoc:javadoc
> >> > :groovy-ant:javadoc
> >> >
> >> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/
> codehaus/groovy/ant/Groovyc.java:42:
> >> > error: cannot find symbol
> >> > import org.apache.commons.cli.GroovyInternalPosixParser;
> >> >  ^
> >> >   symbol:   class GroovyInternalPosixParser
> >> >   location: package org.apache.commons.cli
> >> > 1 warning
> >> > :groovy-ant:javadocJar
> >> > :groovy-ant:install FAILED
> >> >
> >> > FAILURE: Build failed with an exception.
> >> >
> >> > * What went wrong:
> >> > Execution failed for task ':groovy-ant:install'.
> >> >> Could not publish configuration 'archives'
> >> >> Cannot publish artifact 'groovy-ant.jar.asc
> >> > (org.codehaus.groovy:groovy-ant:2.4.8)'
> >> >
> >> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc)
> as
> >> > it does not exist.
> >> >
> >> > * Try:
> >> > Run with --stacktrace option to get the stack trace. Run with --info
> or
> >> > --debug option to get more log output.
> >> >
> >> > BUILD FAILED
> >> > ---
> >> >
> >> >
> >> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King 
> wrote:
> >> >>
> >> >> Dear community,
> >> >>
> >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
> >> >>
> >> >> This release includes 84 bug fixes/improvements as outlined in the
> >> >> changelog:
> >> >>
> >> >>
> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12335950
> >> >>
> >> >> Tag:
> >> >>
> >> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_4_8
> >> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
> >> >>
> >> >> The artifacts to be voted on are located as follows (r17713).
> >> >> Source release:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
> >> >> Convenience binaries:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
> >> >>
> >> >> Release artifacts are signed with a key from the following file:
> >> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
> >> >>
> >> >> Please vote on releasing this package as Apache Groovy 2.4.8.
> >> >>
> >> >> The vote is open for the next 72 hours and passes if a majority of at
> >> >> least three +1 PMC votes are cast.
> >> >>
> >> >> [ ] +1 Release Apache Groovy 2.4.8
> >> >> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> >> >> [ ] -1 Do not release Apache Groovy 2.4.8 because...
> >> >>
> >> >> Here is my vote:
> >> >>

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Paul King
Looks like everyone is keen to get the release out soon. Given it was
just a minor tweak to the build file, I'll re-issue the vote but with
a 48 hr window.

On Tue, Jan 10, 2017 at 10:39 PM, Cédric Champeau
 wrote:
> If the difference is just in fixing the build, maybe a shorter vote is
> acceptable?
>
> 2017-01-10 13:37 GMT+01:00 Uwe Schindler :
>>
>> Hi,
>>
>>
>>
>> This also delays fixing Lucene‘s build system for our release Lucene 6.4,
>> so we can test Java 9 build 148+. So it’s a pity!
>>
>>
>>
>> Uwe
>>
>>
>>
>> -
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> http://www.thetaphi.de
>>
>> eMail: u...@thetaphi.de
>>
>>
>>
>> From: Cédric Champeau [mailto:cedric.champ...@gmail.com]
>> Sent: Tuesday, January 10, 2017 12:42 PM
>> To: dev@groovy.apache.org; Paul King 
>> Cc: John Wagenleitner 
>> Subject: Re: [VOTE] Release Groovy 2.4.8
>>
>>
>>
>> Was it such a big deal we needed to cancel the vote? I find it a bit
>> unfortunate, since "building" just works, or that setting the signing
>> properties do. Anyway I leave it to you.
>>
>>
>>
>> 2017-01-10 12:37 GMT+01:00 Paul King :
>>
>> John found an issue with "install" if you don't have signing properties in
>> place. As painful as it is, I'll cancel the vote and try again.
>>
>> I have re-run the tweaked build script and the new artifacts are
>> re-uploaded to the same place on the DEV server. Anyone want to give
>> it a quick try before I do a formal re-start of the vote tomorrow?
>> Install now works for me with and without signing in place.
>>
>> Cheers, Paul.
>>
>> On Tue, Jan 10, 2017 at 2:22 PM, John Wagenleitner
>>
>>  wrote:
>> > With the downloaded source I was using gradle 2.14.  I also fetched the
>> > GROOVY_2_4_8 tag and ran gradlew from there which is 2.3.  I get the
>> > error
>> > with both.  Not sure if I need to set up a property to point to gpg
>> > keys,
>> > but haven't had to do that in the past.
>> >
>> > On Mon, Jan 9, 2017 at 7:42 PM, Paul King  wrote:
>> >>
>> >> Can you check the version of gradle that is running? The artifacts are
>> >> built using install and install works fine for me from the src zip.
>> >>
>> >> On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner
>> >>  wrote:
>> >> > When I run `gradlew install` from source (both from the downloaded
>> >> > zip
>> >> > and
>> >> > from the GROOVY_2_4_8 tag) I get the error below.  Looks like prior
>> >> > to
>> >> > commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the
>> >> > build
>> >> > and wont install the artifacts in the local maven repo.
>> >> >
>> >> > [1]
>> >> >
>> >> >
>> >> > https://github.com/apache/groovy/commit/9fa4b015e4a80ef036ef32aa48158f8360663000
>> >> >
>> >> > ---
>> >> > :groovy-groovydoc:javadoc
>> >> > :groovy-ant:javadoc
>> >> >
>> >> >
>> >> > /ASF/groovy/subprojects/groovy-ant/src/main/java/org/codehaus/groovy/ant/Groovyc.java:42:
>> >> > error: cannot find symbol
>> >> > import org.apache.commons.cli.GroovyInternalPosixParser;
>> >> >  ^
>> >> >   symbol:   class GroovyInternalPosixParser
>> >> >   location: package org.apache.commons.cli
>> >> > 1 warning
>> >> > :groovy-ant:javadocJar
>> >> > :groovy-ant:install FAILED
>> >> >
>> >> > FAILURE: Build failed with an exception.
>> >> >
>> >> > * What went wrong:
>> >> > Execution failed for task ':groovy-ant:install'.
>> >> >> Could not publish configuration 'archives'
>> >> >> Cannot publish artifact 'groovy-ant.jar.asc
>> >> > (org.codehaus.groovy:groovy-ant:2.4.8)'
>> >> >
>> >> >
>> >> > (/ASF/groovy/subprojects/groovy-ant/target/libs/groovy-ant-2.4.8.jar.asc)
>> >> >  as
>> >> > it does not exist.
>> >> >
>> >> > * Try:
>> >> > Run with --stacktrace option to get the stack trace. Run with --info
>> >> > or
>> >> > --debug option to get more log output.
>> >> >
>> >> > BUILD FAILED
>> >> > ---
>> >> >
>> >> >
>> >> > On Sun, Jan 8, 2017 at 10:33 PM, Paul King 
>> >> > wrote:
>> >> >>
>> >> >> Dear community,
>> >> >>
>> >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>> >> >>
>> >> >> This release includes 84 bug fixes/improvements as outlined in the
>> >> >> changelog:
>> >> >>
>> >> >>
>> >> >>
>> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950
>> >> >>
>> >> >> Tag:
>> >> >>
>> >> >>
>> >> >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
>> >> >> Tag commit id: a1dc0fabb39feb2410d00c7919965557c7841ed6
>> >> >>
>> >> >> The artifacts to be voted on are located as follows (r17713).
>> >> >> Source release:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> >> >> Convenience binaries:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>> >> >>
>> >> >> Release artifacts are signed with a key from the following file:
>> >> >> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >> >>
>> >> 

[VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Paul King
[Hopefully for real this time]

Dear community,

I am happy to start the VOTE thread for a Groovy 2.4.8 release!

This release includes 85 bug fixes/improvements as outlined in the changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950

Tag: 
https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3

The artifacts to be voted on are located as follows (r17747).
Source release: https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
Convenience binaries:
https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution

Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy/KEYS

Please vote on releasing this package as Apache Groovy 2.4.8.

Given that the source code used to build binary artifacts hasn't been
touched and those artifacts have gone through quite a bit of scrutiny
in the previous attempt, I'll keep the vote open for the next 48
hours. It passes if a majority of at least three +1 PMC votes are
cast.

[ ] +1 Release Apache Groovy 2.4.8
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.4.8 because...

Here is my vote:

+1 (binding)


Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Guillaume Laforge
+1 (binding)

On Tue, Jan 10, 2017 at 2:06 PM, Paul King  wrote:

> [Hopefully for real this time]
>
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>
> This release includes 85 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12335950
>
> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_4_8
> Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3
>
> The artifacts to be voted on are located as follows (r17747).
> Source release: https://dist.apache.org/repos/
> dist/dev/groovy/2.4.8/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.4.8.
>
> Given that the source code used to build binary artifacts hasn't been
> touched and those artifacts have gone through quite a bit of scrutiny
> in the previous attempt, I'll keep the vote open for the next 48
> hours. It passes if a majority of at least three +1 PMC votes are
> cast.
>
> [ ] +1 Release Apache Groovy 2.4.8
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>
> Here is my vote:
>
> +1 (binding)
>



-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge  / Google+



Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Jochen Theodorou

+1

On 10.01.2017 14:10, Guillaume Laforge wrote:

+1 (binding)

On Tue, Jan 10, 2017 at 2:06 PM, Paul King mailto:pa...@asert.com.au>> wrote:

[Hopefully for real this time]

Dear community,

I am happy to start the VOTE thread for a Groovy 2.4.8 release!

This release includes 85 bug fixes/improvements as outlined in the
changelog:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950



Tag:

https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8


Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3

The artifacts to be voted on are located as follows (r17747).
Source release:
https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources

Convenience binaries:
https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution


Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy/KEYS


Please vote on releasing this package as Apache Groovy 2.4.8.

Given that the source code used to build binary artifacts hasn't been
touched and those artifacts have gone through quite a bit of scrutiny
in the previous attempt, I'll keep the vote open for the next 48
hours. It passes if a majority of at least three +1 PMC votes are
cast.

[ ] +1 Release Apache Groovy 2.4.8
[ ]  0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.4.8 because...

Here is my vote:

+1 (binding)




--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge  / Google+



Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Cédric Champeau
+1 (binding)

Checking apache-groovy-src-2.4.8.zip : signature [ok] checksum [ok]
Checking apache-groovy-binary-2.4.8.zip : signature [ok] checksum [ok]
Checking apache-groovy-sdk-2.4.8.zip : signature [ok] checksum [ok]
Checking apache-groovy-docs-2.4.8.zip : signature [ok] checksum [ok]


2017-01-10 14:45 GMT+01:00 Jochen Theodorou :

> +1
>
> On 10.01.2017 14:10, Guillaume Laforge wrote:
>
>> +1 (binding)
>>
>> On Tue, Jan 10, 2017 at 2:06 PM, Paul King > > wrote:
>>
>> [Hopefully for real this time]
>>
>> Dear community,
>>
>> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>>
>> This release includes 85 bug fixes/improvements as outlined in the
>> changelog:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318123&version=12335950
>> > ectId=12318123&version=12335950>
>>
>> Tag:
>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>> ;h=refs/tags/GROOVY_2_4_8
>> > g;h=refs/tags/GROOVY_2_4_8>
>> Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3
>>
>> The artifacts to be voted on are located as follows (r17747).
>> Source release:
>> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> 
>> Convenience binaries:
>> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>> 
>>
>> Release artifacts are signed with a key from the following file:
>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> 
>>
>> Please vote on releasing this package as Apache Groovy 2.4.8.
>>
>> Given that the source code used to build binary artifacts hasn't been
>> touched and those artifacts have gone through quite a bit of scrutiny
>> in the previous attempt, I'll keep the vote open for the next 48
>> hours. It passes if a majority of at least three +1 PMC votes are
>> cast.
>>
>> [ ] +1 Release Apache Groovy 2.4.8
>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>>
>> Here is my vote:
>>
>> +1 (binding)
>>
>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge  / Google+
>> 
>>
>


Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Jim Northrop
Do we have an ETA date when we can chg our gradle configs to pull 2.4.8 please?

Sent from my iPad

> On 10 Jan 2017, at 14:06, Paul King  wrote:
> 
> [Hopefully for real this time]
> 
> Dear community,
> 
> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
> 
> This release includes 85 bug fixes/improvements as outlined in the changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950
> 
> Tag: 
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
> Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3
> 
> The artifacts to be voted on are located as follows (r17747).
> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
> 
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
> 
> Please vote on releasing this package as Apache Groovy 2.4.8.
> 
> Given that the source code used to build binary artifacts hasn't been
> touched and those artifacts have gone through quite a bit of scrutiny
> in the previous attempt, I'll keep the vote open for the next 48
> hours. It passes if a majority of at least three +1 PMC votes are
> cast.
> 
> [ ] +1 Release Apache Groovy 2.4.8
> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.4.8 because...
> 
> Here is my vote:
> 
> +1 (binding)


Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Paul King
A little early to give an exact ETA Jim. I'll update here when I know more.

On Wed, Jan 11, 2017 at 2:05 AM, Jim Northrop
 wrote:
> Do we have an ETA date when we can chg our gradle configs to pull 2.4.8 
> please?
>
> Sent from my iPad
>
>> On 10 Jan 2017, at 14:06, Paul King  wrote:
>>
>> [Hopefully for real this time]
>>
>> Dear community,
>>
>> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>>
>> This release includes 85 bug fixes/improvements as outlined in the changelog:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950
>>
>> Tag: 
>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
>> Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3
>>
>> The artifacts to be voted on are located as follows (r17747).
>> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>> Convenience binaries:
>> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>>
>> Release artifacts are signed with a key from the following file:
>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>
>> Please vote on releasing this package as Apache Groovy 2.4.8.
>>
>> Given that the source code used to build binary artifacts hasn't been
>> touched and those artifacts have gone through quite a bit of scrutiny
>> in the previous attempt, I'll keep the vote open for the next 48
>> hours. It passes if a majority of at least three +1 PMC votes are
>> cast.
>>
>> [ ] +1 Release Apache Groovy 2.4.8
>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>>
>> Here is my vote:
>>
>> +1 (binding)


Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Roman Shaposhnik
On Tue, Jan 10, 2017 at 5:02 AM, Paul King  wrote:
> Looks like everyone is keen to get the release out soon. Given it was
> just a minor tweak to the build file, I'll re-issue the vote but with
> a 48 hr window.

+1

Thanks,
Roman.


Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread jim northrop
Thank you Paul. We're working to get GPars V2.0 doc.s ready so will include 
2.4.8 plus asciidoctor 1.5.5 just out this morning. ☺️

Sent from my iPad

> On 11 Jan 2017, at 01:42, Paul King  wrote:
> 
> A little early to give an exact ETA Jim. I'll update here when I know more.
> 
> On Wed, Jan 11, 2017 at 2:05 AM, Jim Northrop
>  wrote:
>> Do we have an ETA date when we can chg our gradle configs to pull 2.4.8 
>> please?
>> 
>> Sent from my iPad
>> 
>>> On 10 Jan 2017, at 14:06, Paul King  wrote:
>>> 
>>> [Hopefully for real this time]
>>> 
>>> Dear community,
>>> 
>>> I am happy to start the VOTE thread for a Groovy 2.4.8 release!
>>> 
>>> This release includes 85 bug fixes/improvements as outlined in the 
>>> changelog:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950
>>> 
>>> Tag: 
>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_4_8
>>> Tag commit id: c94d839d7bf6e15377b0c355acf8087295273ff3
>>> 
>>> The artifacts to be voted on are located as follows (r17747).
>>> Source release: https://dist.apache.org/repos/dist/dev/groovy/2.4.8/sources
>>> Convenience binaries:
>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.8/distribution
>>> 
>>> Release artifacts are signed with a key from the following file:
>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>> 
>>> Please vote on releasing this package as Apache Groovy 2.4.8.
>>> 
>>> Given that the source code used to build binary artifacts hasn't been
>>> touched and those artifacts have gone through quite a bit of scrutiny
>>> in the previous attempt, I'll keep the vote open for the next 48
>>> hours. It passes if a majority of at least three +1 PMC votes are
>>> cast.
>>> 
>>> [ ] +1 Release Apache Groovy 2.4.8
>>> [ ]  0 I don't have a strong opinion about this, but I assume it's ok
>>> [ ] -1 Do not release Apache Groovy 2.4.8 because...
>>> 
>>> Here is my vote:
>>> 
>>> +1 (binding)