Re: [VOTE] Release Groovy 2.4.8
On 31.12.2016 03:25, Paul King wrote: The README gives bootstrap instructions for building from source. In particular, you should not copy gradlew from another groovy install. Instead you can just run any gradle and that will effectively do a "gradle wrapper" which will get the correct gradle version. Let me know if that works. that is what I did in my second try. The wrapper task cannot be executed because of Could not set unknown property 'overview' for task ':groovydoc' of type org.gradle.api.tasks.javadoc.Groovydoc. bye Jochen
Re: [VOTE] Release Groovy 2.4.8
Is it maybe because Groovy 2.4.8 is supposed to use Gradle 2.3 and that this build then does not work with Gradle 3.2.1, the version master is using? Just tested, and yes, this seems to be the cause. This means you cannot create the wrapper using Gradle 3.2.1 because the build file is not compatible. Besides that... where do we define the gradle version to be used for the build? If not any gradle version will work we need to specify that in the build instructions for the source distribution at least. bye Jochen On 31.12.2016 03:25, Paul King wrote: The README gives bootstrap instructions for building from source. In particular, you should not copy gradlew from another groovy install. Instead you can just run any gradle and that will effectively do a "gradle wrapper" which will get the correct gradle version. Let me know if that works. Cheers, Paul. On Sat, Dec 31, 2016 at 11:16 AM, Jochen Theodorou wrote: On 30.12.2016 22:13, Paul King wrote: Can you give some more info? I can't replicate. I copied the 3.2.1 wrapper over and then tried to start... this is what I got. Just tried again using another 3.2.1 wrapper and this time I got FAILURE: Build failed with an exception. * Where: Script '/tmp/r/groovy-2.4.8/gradle/docs.gradle' line: 63 * What went wrong: A problem occurred evaluating script. Could not set unknown property 'overview' for task ':groovydoc' of type org.gradle.api.tasks.javadoc.Groovydoc. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED bye Jochen
Re: [VOTE] Release Groovy 2.4.8
Yes, I guess Gradle 3 had breaking changes in their groovydoc tasks. I guess we should be mentioning that in the README somewhere. Any gradle version before 3 should work and there be some hack for 3 too no doubt - I'll see what I can do. There is a 'gradleVersion' property (set in the build.gradle file) which is used when bootstrapping the wrapper, so no need for further instructions in that regard. Cheers, Paul. On Sat, Dec 31, 2016 at 7:45 PM, Jochen Theodorou wrote: > Is it maybe because Groovy 2.4.8 is supposed to use Gradle 2.3 and that this > build then does not work with Gradle 3.2.1, the version master is using? > > Just tested, and yes, this seems to be the cause. This means you cannot > create the wrapper using Gradle 3.2.1 because the build file is not > compatible. > > Besides that... where do we define the gradle version to be used for the > build? If not any gradle version will work we need to specify that in the > build instructions for the source distribution at least. > > bye Jochen > > On 31.12.2016 03:25, Paul King wrote: >> >> The README gives bootstrap instructions for building from source. In >> particular, you should not copy gradlew from another groovy install. >> Instead you can just run any gradle and that will effectively do a >> "gradle wrapper" which will get the correct gradle version. Let me >> know if that works. >> >> Cheers, Paul. >> >> On Sat, Dec 31, 2016 at 11:16 AM, Jochen Theodorou >> wrote: >>> >>> On 30.12.2016 22:13, Paul King wrote: Can you give some more info? I can't replicate. >>> >>> >>> >>> I copied the 3.2.1 wrapper over and then tried to start... this is what I >>> got. >>> Just tried again using another 3.2.1 wrapper and this time I got >>> FAILURE: Build failed with an exception. * Where: Script '/tmp/r/groovy-2.4.8/gradle/docs.gradle' line: 63 * What went wrong: A problem occurred evaluating script. > > > Could not set unknown property 'overview' for task ':groovydoc' of type > org.gradle.api.tasks.javadoc.Groovydoc. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. BUILD FAILED >>> >>> >>> >>> bye Jochen >>> >
Re: [VOTE] Release Groovy 2.4.8
On 31.12.2016 12:38, Paul King wrote: [...] There is a 'gradleVersion' property (set in the build.gradle file) which is used when bootstrapping the wrapper, so no need for further instructions in that regard. ah, ok. I am used to find those things in gradle.properties now... Is there any reason we cannot transfer all those properties in that ext block there? bye Jochen
Re: [VOTE] Release Groovy 2.4.8
I imagine some of them could be moved but I think what we have is the more common place to have those versions. I am unsure whether an IDE assistance would be affected with such a move - I haven't actually tried. Cheers, Paul. On Sat, Dec 31, 2016 at 9:57 PM, Jochen Theodorou wrote: > On 31.12.2016 12:38, Paul King wrote: > [...] >> >> There is a 'gradleVersion' property (set in the build.gradle file) >> which is used when bootstrapping the wrapper, so no need for further >> instructions in that regard. > > > ah, ok. I am used to find those things in gradle.properties now... Is there > any reason we cannot transfer all those properties in that ext block there? > > bye Jochen >
