[CANCELLED][VOTE] Release Apache Flink 1.0.0 (RC1)

[Robert Metzger]

I cancel this vote in favor of a new RC.

On Fri, Feb 26, 2016 at 1:47 PM, Robert Metzger  wrote:

> @Greg: I've merged the two PRs you've mentioned.
>
> Since nobody objected, I'll create now a branch for "release-1.0" and I'll
> update the version in master to 1.1-SNAPSHOT.
>
> Please remember that I'm aiming for creating the next RC later today. I
> keep an eye on blocking issues / open pull requests. If there's nothing
> I'll start creating the RC.
>
> On Thu, Feb 25, 2016 at 8:10 PM, Stephan Ewen  wrote:
>
>> Just looked at Greg's object juggle PR - looks good for inclusion in the
>> next release candidate.
>>
>> Have not tested the web UI Router fix, but the code looks good.
>> Hi,
>>
>> I have two bugfix pull requests in the stack.
>>
>> [FLINK-3340] [runtime] Fix object juggling in drivers
>>   https://github.com/apache/flink/pull/1626
>>
>> [FLINK-3437] [web-dashboard] Fix UI router state for job plan
>>   https://github.com/apache/flink/pull/1661
>>
>> Greg
>>
>> On Thu, Feb 25, 2016 at 8:32 AM, Robert Metzger 
>> wrote:
>>
>> > Damn. I agree that this is a blocker.
>> > I use the maven-enforcer-plugin to check for the right maven, but the
>> build
>> > profile that runs the profile is only active during "deploy", not when
>> > packaging the binaries.
>> > That's why I didn't realize that I build the binaries with the wrong
>> maven
>> > version.
>> >
>> > I suggest that we keep collecting problems until Friday afternoon (CET).
>> > Then I'll create the next release candidate.
>> >
>> > I'd also like to address this one:
>> > https://issues.apache.org/jira/browse/FLINK-3509
>> >
>> >
>> > On Thu, Feb 25, 2016 at 2:23 PM, Fabian Hueske 
>> wrote:
>> >
>> > > Hi folks,
>> > >
>> > > I think I found a release blocker.
>> > > The flink-dist JAR file contains non-relocated classes of Google Guava
>> > and
>> > > Apache HttpComponents.
>> > >
>> > > Fabian
>> > >
>> > > 2016-02-25 13:21 GMT+01:00 Chesnay Schepler :
>> > >
>> > > > tested the RC on Windows:
>> > > >
>> > > > - source compiles
>> > > > - some tests categorically fail: see FLINK-3491 / FLINK-3496
>> > > > - start/stop scripts work in both cygwin and windows CMD
>> > > > - ran several examples from batch/streaming/python
>> > > > - scripts also work on paths containing spaces
>> > > >
>> > > >
>> > > > On 25.02.2016 12:41, Robert Metzger wrote:
>> > > >
>> > > >> (I'm removing user@ from the discussion)
>> > > >>
>> > > >> Thank you for bringing the pull request to my attention Marton. I
>> have
>> > > to
>> > > >> admit that I didn't announce this RC properly in advance. In the
>> RC0
>> > > >> thread
>> > > >> I said "early next week" and now its Thursday. I should have said
>> > > >> something
>> > > >> in that thread.
>> > > >> The "trigger" for creating the release was that the number of
>> blocking
>> > > >> issues is 0 now.
>> > > >>
>> > > >> I did a quick check of the open pull requests yesterday evening and
>> > > found
>> > > >> one [1] to be included into the RC as well. Since the PR you
>> mentioned
>> > > is
>> > > >> marked with [WIP] I thought its not yet ready to be merged.
>> > > >>
>> > > >> I would like to find a solution that works for everyone here: I
>> would
>> > > like
>> > > >> to avoid delaying the release until tomorrow evening, and also the
>> > work
>> > > it
>> > > >> incurs for me create a release candidate.
>> > > >> How about the following: We keep this vote open, test and check the
>> > > >> release
>> > > >> and you merge the change to master in the meantime.
>> > > >> Most likely, the release gets cancelled anyways because we find
>> > > something
>> > > >> and then the next RC will contain your change.
>> > > >>
>> > > >> [1] https://github.com/apache/flink/pull/1706
>> > > >>
>> > > >> On Thu, Feb 25, 2016 at 12:11 PM, Márton Balassi <
>> > > >> balassi.mar...@gmail.com>
>> > > >> wrote:
>> > > >>
>> > > >> Thanks for creating the candidate Robert and for the heads-up,
>> Slim.
>> > > >>>
>> > > >>> I would like to get a PR [1] in before 1.0.0 as it breaks hashing
>> > > >>> behavior
>> > > >>> of DataStream.keyBy. The PR has the feature implemented and the
>> java
>> > > >>> tests
>> > > >>> adopted, there is still a bit of outstanding fix for the scala
>> tests.
>> > > >>> Gábor
>> > > >>> Horváth or myself will finish it by tomorrow evening.
>> > > >>>
>> > > >>> [1] https://github.com/apache/flink/pull/1685
>> > > >>>
>> > > >>> Best,
>> > > >>>
>> > > >>> Marton
>> > > >>>
>> > > >>> On Thu, Feb 25, 2016 at 12:04 PM, Slim Baltagi <
>> sbalt...@gmail.com>
>> > > >>> wrote:
>> > > >>>
>> > > >>> Dear Flink community
>> > > 
>> > >  It is great news that the vote for the first release candidate
>> (RC1)
>> > > of
>> > >  Apache Flink 1.0.0 is starting today February 25th, 2016!
>> > >  As a community, we need to double our efforts and make sure that
>> > Flink
>> > >  1.0.0 is GA before these 2 upcoming major events:
>> > > 
>> > >  -  Strata + Hadoop World in San Jos

[VOTE] Release Apache Flink 1.0.0 (RC2)

[Robert Metzger]

Dear Flink community,

Please vote on releasing the following candidate as Apache Flink version 1.0
.0.

This is the second RC.


The commit to be voted on
(*http://git-wip-us.apache.org/repos/asf/flink/commit/6895fd92
*)
6895fd92386ec1b6181af7dba553116b028259f2

Branch:
release-1.0.0-rc2 (see
https://git1-us-west.apache.org/repos/asf/flink/repo?p=flink.git;a=shortlog;h=refs/heads/release-1.0.0-rc2
)

The release artifacts to be voted on can be found at:
*http://people.apache.org/~rmetzger/flink-1.0.0-rc2/
*

The release artifacts are signed with the key with fingerprint D9839159:
http://www.apache.org/dist/flink/KEYS

The staging repository for this release can be found at:
*https://repository.apache.org/content/repositories/orgapacheflink-1064
*

-

The vote is open until Tuesday and passes if a majority of at least
three +1 PMC
votes are cast.

The vote ends on Friday, March 4, 11:00 CET.

[ ] +1 Release this package as Apache Flink 1.0.0
[ ] -1 Do not release this package because ...

Re: [VOTE] Release Apache Flink 1.0.0 (RC2)

[Robert Metzger]

Small correction: The vote ends on Friday (or if a -1 occurs), not on
Tuesday, as stated in the email.

On Sat, Feb 27, 2016 at 10:25 AM, Robert Metzger 
wrote:

> Dear Flink community,
>
> Please vote on releasing the following candidate as Apache Flink version 1
> .0.0.
>
> This is the second RC.
>
>
> The commit to be voted on 
> (*http://git-wip-us.apache.org/repos/asf/flink/commit/6895fd92
> *)
> 6895fd92386ec1b6181af7dba553116b028259f2
>
> Branch:
> release-1.0.0-rc2 (see
> https://git1-us-west.apache.org/repos/asf/flink/repo?p=flink.git;a=shortlog;h=refs/heads/release-1.0.0-rc2
> )
>
> The release artifacts to be voted on can be found at:
> *http://people.apache.org/~rmetzger/flink-1.0.0-rc2/
> *
>
> The release artifacts are signed with the key with fingerprint D9839159:
> http://www.apache.org/dist/flink/KEYS
>
> The staging repository for this release can be found at:
> *https://repository.apache.org/content/repositories/orgapacheflink-1064
> *
>
> -
>
> The vote is open until Tuesday and passes if a majority of at least three
> +1 PMC votes are cast.
>
> The vote ends on Friday, March 4, 11:00 CET.
>
> [ ] +1 Release this package as Apache Flink 1.0.0
> [ ] -1 Do not release this package because ...
>

Re: Inconvenient (unforeseen?) consequences of PR #1683

[Vasiliki Kalavri]

Hi squirrels,

sorry I've been slow to respond to this, but I'm now testing RC1 and I'm a
bit confused with this change.

So far, the easier way to run a Gelly example on a cluster was to package
and submit the Gelly jar.
Now, since the flink-gelly project doesn't contain the examples anymore, I
tried running a Gelly example by the packaging flink-gelly-examples jar
(mvn package). However, this gives me a ClassNotFoundException.
e.g. for SingleSourceShortestPaths, the following:

java.lang.RuntimeException: Could not look up the main(String[]) method
from the class org.apache.flink.graph.examples.SingleSourceShortestPaths:
org/apache/flink/graph/spargel/MessagingFunction
at
org.apache.flink.client.program.PackagedProgram.hasMainMethod(PackagedProgram.java:478)
at
org.apache.flink.client.program.PackagedProgram.(PackagedProgram.java:216)
at org.apache.flink.client.CliFrontend.buildProgram(CliFrontend.java:922)
at org.apache.flink.client.CliFrontend.run(CliFrontend.java:301)
at
org.apache.flink.client.CliFrontend.parseParameters(CliFrontend.java:1189)
at org.apache.flink.client.CliFrontend.main(CliFrontend.java:1239)
Caused by: java.lang.NoClassDefFoundError:
org/apache/flink/graph/spargel/MessagingFunction
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2531)
at java.lang.Class.getMethod0(Class.java:2774)
at java.lang.Class.getMethod(Class.java:1663)
at
org.apache.flink.client.program.PackagedProgram.hasMainMethod(PackagedProgram.java:473)
... 5 more
Caused by: java.lang.ClassNotFoundException:
org.apache.flink.graph.spargel.MessagingFunction
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
... 10 more


What am I missing here?

Thanks!
-Vasia.

On 26 February 2016 at 14:10, Márton Balassi 
wrote:

> Thanks, +1.
>
> On Fri, Feb 26, 2016 at 12:35 PM, Stephan Ewen  wrote:
>
> > Hi!
> >
> > I think it is a release blocker.
> >
> > That was a change to make it possible to use Flink with SBT (and make it
> > easier to use it with Maven).
> > Just had an offline chat with Till, and we suggest the following
> solution:
> >
> > All libraries should be split into two projects:
> >   - library
> >   - library-examples
> >
> > The "library" project has the core flink dependencies as "provided"
> > The "library-examples" project has both the "library" and the core flink
> > dependencies with scope "compile"
> >
> > That way the example should run in the IDE out of the cox, and users that
> > reference the libraries will still get the correct packaging (include the
> > library in the user jar, but not additionally the core flink jars).
> >
> > Greetings,
> > Stephan
> >
> >
> > On Thu, Feb 25, 2016 at 3:45 PM, Márton Balassi <
> balassi.mar...@gmail.com>
> > wrote:
> >
> > > Issued JIRA ticket 3511 to make it referable in other discussions. [1]
> > >
> > > [1] https://issues.apache.org/jira/browse/FLINK-3511
> > >
> > > On Thu, Feb 25, 2016 at 3:36 PM, Márton Balassi <
> > balassi.mar...@gmail.com>
> > > wrote:
> > >
> > > > Recent changes to the build [1] where many libraries got their core
> > > > dependencies (the ones included in the flink-dist fat jar) moved to
> the
> > > > provided scope.
> > > >
> > > > The reasoning was that when submitting to the Flink cluster the
> > > > application already has these dependencies, while when a user writes
> a
> > > > program against these libraries she will include the core
> dependencies
> > > > explicitly anyway.
> > > >
> > > > There is one other case of usage however, namely when someone is
> trying
> > > to
> > > > run an application defined in these libraries depending on the core
> > jars.
> > > > To give an example if you were to run the Gelly ConnectedComponents
> > > example
> > > > [2] from an IDE after importing Flink (or running with java -jar
> > without
> > > > including the flink fat jar in the classpath) you would receive the
> > > > following class not found exception as per the current master:
> > > >
> > > > Exception in thread "main" java.lang.NoClassDefFoundError:
> > > > org/apache/flink/api/common/ProgramDescription
> > > > at java.lang.ClassLoader.defineClass1(Native Method)
> > > > at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
> > > > at
> > > java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> > > > at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> > > > at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> > > > at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> > > > at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
> > > > at java.security.AccessController.doPrivileged(Native Method)
> > > > at java.net.URLCla

[jira] [Created] (FLINK-3529) Add pull request template

[Martin Liesenberg (JIRA)]

Martin Liesenberg created FLINK-3529:


 Summary: Add pull request template
 Key: FLINK-3529
 URL: https://issues.apache.org/jira/browse/FLINK-3529
 Project: Flink
  Issue Type: Task
  Components: other
Reporter: Martin Liesenberg
Assignee: Martin Liesenberg
Priority: Minor


Add a template for pull requests, checking if prerequisites of opening a PR 
have been fulfilled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Introducing a PR template

[Martin Liesenberg]

I guess with the upcoming 1.0 release there's heaps of more urgent things
on your plate, nevertheless just a quick update: I added a JIRA ticket [1]
and opened a PR [2] with the changes.

best regards
martin


[1] https://issues.apache.org/jira/browse/FLINK-3529
[2] https://github.com/apache/flink/pull/1729

Martin Liesenberg  schrieb am Di., 23. Feb.
2016 um 00:12 Uhr:

> sure. will take that into account. Thanks for the input.
>
> best regards
> martin
>
> Maximilian Michels  schrieb am So., 21. Feb. 2016 um
> 13:49 Uhr:
>
>> Hi Martin,
>>
>> Thanks for the proposal. This is a great idea and will help new
>> contributors.
>>
>> How about having three sections and less check boxes? I think checking
>> all those boxes will get announcing for regular contributors.
>>
>> [ ] Pull Request
>>   - JIRA issue associated
>>   - Pull request only addresses one issue
>>   - Meaningful commit message
>>
>> [ ] Documentation
>>   - New documentation added
>>   - Old documentation updated
>>   - JavaDoc for public methods
>>
>> [ ] Tests
>>- Tests added for new functionality
>>- Executed "mvn clean verify" or built on Travis
>>
>>
>> Cheers,
>> Max
>>
>> On Sat, Feb 20, 2016 at 3:21 AM, Jamie Grier 
>> wrote:
>> > +1
>> >
>> > On Fri, Feb 19, 2016 at 9:30 AM, Fabian Hueske 
>> wrote:
>> >
>> >> Hi Martin,
>> >>
>> >> "mvn install" does include the goals "test" and "verify".
>> >> In fact, "verify" is enough, because "install" does only copy the
>> results
>> >> into the local Maven repository (~/.m2/repository).
>> >>
>> >> So I think
>> >>  - [ ] Tests pass (`mvn test`)
>> >>  - [ ] Build passes (`mvn install`)
>> >>  - [ ] Check style passes (`mvn verfiy`)
>> >>
>> >> can be condensed to
>> >>   - [ ] Build passes (`mvn clean verify`)
>> >>
>> >> Otherwise, this looks good, IMO :-)
>> >>
>> >> Thanks, Fabian
>> >>
>> >> 2016-02-19 18:19 GMT+01:00 Martin Liesenberg <
>> martin.liesenb...@gmail.com
>> >> >:
>> >>
>> >> > Based on the recent discussion in the email thread 'Extending and
>> >> improving
>> >> > our "How to contribute" page', I propose to introduce the following
>> >> > template for PRs
>> >> >
>> >> > 
>> >> > Thanks for contributing to Apache Flink, before you open your PR
>> please
>> >> > kindly take into consideration the following check list.
>> >> > Once you are sure, all items on the list can be checked, feel free to
>> >> open
>> >> > your PR. For more information please refer to the How To Contribute
>> guide
>> >> > linked above.
>> >> >
>> >> > ### General
>> >> >   - [ ] Is there an associated JIRA issue
>> >> >   - [ ] This PR addresses includes a single change
>> >> >   - [ ] New functionality is covered by tests
>> >> >   - [ ] Documentation is up to date
>> >> >
>> >> > ### Code health
>> >> >  - [ ] Tests pass (`mvn test`)
>> >> >  - [ ] Build passes (`mvn install`)
>> >> >  - [ ] Check style passes (`mvn verfiy`)
>> >> >  - [ ] JavaDoc for new `public` methods has been added
>> >> > ---
>> >> >
>> >> >
>> >> > The intended effects would be:
>> >> > - reduce friction in the PR process created by basic oversights such
>> as
>> >> > checkstyle violations or missing tests
>> >> > - provide a helping hand for new contributors
>> >> >
>> >> > I tried to condense the suggestion on the mailing list to make it
>> not too
>> >> > long and intimidating but at the same time cover the most important
>> >> points.
>> >> >
>> >> > Looking forward to your input.
>> >> > Best regards
>> >> > martin
>> >> >
>> >>
>> >
>> >
>> >
>> > --
>> >
>> > Jamie Grier
>> > data Artisans, Director of Applications Engineering
>> > @jamiegrier 
>> > ja...@data-artisans.com
>>
>