Re: [dpdk-dev] [Bug 814] Intel PMD both i40 and iavf send OP_DISABLE_VLAN_STRIPPING and it not mandatory

[spyroot]

The second issue is in CONFIG_RSS_LUT.

That *VIRTCHNL_OP_CONFIG_RSS_LUT*
; is
optional so if it returns ret it must be handled correctly.


int

*iavf_configure_rss_lut*
(struct
*iavf_adapter* 
*adapter)

{

struct *iavf_info*
 *vf =
*IAVF_DEV_PRIVATE_TO_VF*
(adapter);

struct *virtchnl_rss_lut*
 *rss_lut;

struct *iavf_cmd_info*
 args;

int len, err = 0;



len = sizeof(*rss_lut) + vf->vf_res->rss_lut_size - 1;

rss_lut = *rte_zmalloc*
("rss_lut", len,
0);

if (!rss_lut)

return -ENOMEM;



rss_lut->vsi_id = vf->vsi_res->vsi_id;

rss_lut->lut_entries = vf->vf_res->rss_lut_size;

*rte_memcpy*
(rss_lut->lut,
vf->rss_lut, vf->vf_res->rss_lut_size);



args.ops = *VIRTCHNL_OP_CONFIG_RSS_LUT*
;

args.in_args = (*u8*
 *)rss_lut;

args.in_args_size = len;

args.out_buffer = vf->aq_resp;

args.out_size = *IAVF_AQ_BUF_SZ*
;



err = *iavf_execute_vf_cmd*
(adapter,
&args);

if (err)

*PMD_DRV_LOG*
(ERR,

   "Failed to execute command of OP_CONFIG_RSS_LUT");



*rte_free* (rss_lut);

return err;

}


On Fri, Sep 24, 2021 at 12:29 AM  wrote:

> https://bugs.dpdk.org/show_bug.cgi?id=814
>
> Bug ID: 814
>Summary: Intel PMD both i40 and iavf send
> OP_DISABLE_VLAN_STRIPPING and it not mandatory
>Product: DPDK
>Version: 20.11
>   Hardware: All
> OS: All
> Status: UNCONFIRMED
>   Severity: normal
>   Priority: Normal
>  Component: core
>   Assignee: dev@dpdk.org
>   Reporter: spyr...@gmail.com
>   Target Milestone: ---
>
> Hi Folks,
>
> There is an issue in i40 and ivfx PMD's both drivers send optional commands
> that require trusted mode enabled and if OP_DISABLE_VLAN_STRIPPING discard
> by
> PF, PMD return error and not gracefully handles.
>
>
> Example iavf_disable_vlan_strip() same function present in i40 that disable
> vlan strip.  That is optional and not required and must be gracefully be
> handled.
>
>
> EAL: Detected 4 lcore(s)
> EAL: Detected 1 NUMA nodes
> EAL: Detected static linkage of DPDK
> EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> EAL: Selected IOVA mode 'PA'
> EAL: No available hugepages reported in hugepages-1048576kB
> EAL: Probing VFIO support...
> EAL: Probe PCI driver: net_iavf (8086:1889) device: :13:00.0 (socket 0)
> EAL: Error reading from file descriptor 26: Input/output error
> EAL: No legacy callbacks, legacy socket not created
> testpmd: create a new mbuf pool : n=171456, size=2176, socket=0
> testpmd: preferred mempool ops selected: ring_mp_mc
>
> Warning! port-topology=paired and odd forward ports number, the last port
> will
> pair with itself.
>
> Configuring Port 0 (socket 0)
> iavf_execute_vf_cmd(): No response for cmd 28
> iavf_disable_vlan_strip(): Failed to execute command of
> OP_DISABLE_VLAN_STRIPPING
> iavf_init_rss(): RSS is enabled by PF by default
> iavf_execute_vf_cmd(): No response for cmd 24
> iavf_configure_rss_lut(): Failed to execute command of OP_CONFIG_RSS_LUT
> iavf_dev_configure(): configure rss failed
> Port0 dev_configure = -1
> Fail to configure port 0
> EAL: Error - exiting with code: 1
>   Cause: Start ports failed
>
> Thank you,
> Mus>
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

[dpdk-dev] KNI compilation

[spyroot]

Hi Folks,

I troubleshooting already for a couple of hours but still not clear why
exactly the build process
failing on the KNI module.  I've tried to disable KNI but it same issue.
Any ideas what might be a root cause.  It x86_64


[1/2] Generating rte_kni with a custom command
FAILED: kernel/linux/kni/rte_kni.ko
make -j4 -C /lib/modules/5.10.52-3.ph4-esx/build
M=/root/dpdk-stable-20.11.2/build/kernel/linux/kni
src=/root/dpdk-stable-20.11.2/kernel/linux/kni 'MODULE_CFLAGS=-include
/root/dpdk-stable-20.11.2/config/rte_config.h
-I/root/dpdk-stable-20.11.2/lib/librte_eal/include
-I/root/dpdk-stable-20.11.2/lib/librte_kni
-I/root/dpdk-stable-20.11.2/build
-I/root/dpdk-stable-20.11.2/kernel/linux/kni' modules
make: Entering directory '/usr/src/linux-headers-5.10.52-3.ph4-esx'
make[1]: *** No rule to make target
'/root/dpdk-stable-20.11.2/build/kernel/linux/kni/kni_misc.o', needed by
'/root/dpdk-stable-20.11.2/build/kernel/linux/kni/rte_kni.o'.  Stop.
make: *** [Makefile:1821: /root/dpdk-stable-20.11.2/build/kernel/linux/kni]
Error 2
make: Leaving directory '/usr/src/linux-headers-5.10.52-3.ph4-esx'
ninja: build stopped: subcommand failed.

Kind Regards,
Mus>

Re: [dpdk-dev] KNI compilation

[spyroot]

Hi Ferruh,

Sorry, I forgot to mention,  Yes, I was compiling with -Denable_kmods=true.

I just partially found a root cause.   The target system Photon OS (It
VMware distro)
It has 4 kernels variation regular, RT, ESX, security.  ( I was using ESX
variation that optimized for
ESXi but it looks like something is disabled in the kernel that prevents
KNI to compile) when
I use a regular kernel source tree, it does compile.

I was trying to figure out what KNI actually requires from the kernel
source tree or what instrumentation
I can use it to see the more verbose errors.  ninja -v doesn't really
provide details.

Thank you very much

On Mon, Aug 30, 2021 at 9:44 PM Ferruh Yigit  wrote:

> On 8/30/2021 5:47 PM, spyroot wrote:
> > Hi Folks,
> >
> > I troubleshooting already for a couple of hours but still not clear why
> > exactly the build process
> > failing on the KNI module.  I've tried to disable KNI but it same issue.
> > Any ideas what might be a root cause.  It x86_64
> >
> >
> > [1/2] Generating rte_kni with a custom command
> > FAILED: kernel/linux/kni/rte_kni.ko
> > make -j4 -C /lib/modules/5.10.52-3.ph4-esx/build
> > M=/root/dpdk-stable-20.11.2/build/kernel/linux/kni
> > src=/root/dpdk-stable-20.11.2/kernel/linux/kni 'MODULE_CFLAGS=-include
> > /root/dpdk-stable-20.11.2/config/rte_config.h
> > -I/root/dpdk-stable-20.11.2/lib/librte_eal/include
> > -I/root/dpdk-stable-20.11.2/lib/librte_kni
> > -I/root/dpdk-stable-20.11.2/build
> > -I/root/dpdk-stable-20.11.2/kernel/linux/kni' modules
> > make: Entering directory '/usr/src/linux-headers-5.10.52-3.ph4-esx'
> > make[1]: *** No rule to make target
> > '/root/dpdk-stable-20.11.2/build/kernel/linux/kni/kni_misc.o', needed by
> > '/root/dpdk-stable-20.11.2/build/kernel/linux/kni/rte_kni.o'.  Stop.
> > make: *** [Makefile:1821:
> /root/dpdk-stable-20.11.2/build/kernel/linux/kni]
> > Error 2
> > make: Leaving directory '/usr/src/linux-headers-5.10.52-3.ph4-esx'
> > ninja: build stopped: subcommand failed.
> >
> > Kind Regards,
> > Mus>
> >
>
> Hi spyroot (Mus> ?),
>
> modules already disabled by default, you should be enabling it via
> '-Denable_kmods=true' meson option, if you want to disable kni just not
> enabling
> kmods should be enough.
>
> btw, I have tried and not able to reproduce the issue in 20.11.2 in my
> platforml, kni compiles fine.
> Can you confirm you have kernel source installed in your system?
> Or to be more specific, does '/usr/src/linux-headers-5.10.52-3.ph4-esx'
> patch
> has kernel source code?
>
> And can you please share your full commands for build?
>
> Cheers,
> ferruh
>

Re: [PATCH v3 2/2] net/vmxnet3: support larger MTU with version 6

[spyroot]

Hi Folks, how can you bump them VMXNET3 version, and do we have a VMXNET3
unit test for RSS / Max mtu and 32 queue?

On Wed, Nov 6, 2024 at 8:00 AM Ferruh Yigit  wrote:

> On 11/4/2024 9:44 PM, Jochen Behrens wrote:
>
> > On 11/4/24 02:52, Morten Brørup wrote:
> >> Virtual hardware version 6 supports larger max MTU, but the device
> >> information (dev_info) did not reflect this, so it could not be used.
> >>
> >> Fixes: b1584dd0affe ("net/vmxnet3: support version 6")
> >>
> >> Signed-off-by: Morten Brørup 
> >
> > Acked-by: Jochen Behrens jochen.behr...@broadcom.com
> >
>
> Applied to dpdk-next-net/main, thanks.
>