Re: [dpdk-dev] [PATCH v6 4/8] ethdev: make driver-only headers private

[Webster, Steven]

> -Original Message-
> From: Bruce Richardson 
> Sent: Wednesday, January 27, 2021 12:33 PM
> Subject: [PATCH v6 4/8] ethdev: make driver-only headers private
> 
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> The rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pci.h files are
> for drivers only and should be a private to DPDK and not installed.
> 
> Signed-off-by: Bruce Richardson 
> ---
>  drivers/net/avp/avp_ethdev.c   | 4 ++--
> diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> index f531e03c02..566a3606a2 100644
> --- a/drivers/net/avp/avp_ethdev.c
> +++ b/drivers/net/avp/avp_ethdev.c
> @@ -8,8 +8,8 @@
>  #include 
>  #include 
> 
> -#include 
> -#include 
> +#include 
> +#include 
>  #include 
>  #include 
>  #include 

Acked-By: Steven Webster 

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

[Webster, Steven]

> gcc 10.0.1 reports:
> 
> ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’:
> ../drivers/net/avp/avp_ethdev.c:1791:24:
> warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-
> Wmaybe-uninitialized]
>  1791 |   tx_bufs[i] = avp_bufs[count];
>   |^~~
> ../drivers/net/avp/avp_ethdev.c:1791:24:
> warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-
> Wmaybe-uninitialized]
> 
> Fix by intializing the array.
> 
> Fixes: 295abce2d25b ("net/avp: add packet transmit functions")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Kevin Traynor 
> ---
Acked-by: Steven Webster