Re: [dpdk-dev] [PATCH v2 43/52] net/ice/base: adjust scheduler default BW weight

2020-06-12 Thread Singh, Tarun K
Yes, BW is for bandwidth.

-Tarun

-Original Message-
From: Yigit, Ferruh  
Sent: Thursday, June 11, 2020 11:37 AM
To: Zhang, Qi Z ; Yang, Qiming 
Cc: Ye, Xiaolong ; dev@dpdk.org; Singh, Tarun K 
; Stillwell Jr, Paul M 
Subject: Re: [dpdk-dev] [PATCH v2 43/52] net/ice/base: adjust scheduler default 
BW weight

On 6/9/2020 12:59 PM, Qi Zhang wrote:
> By default the queues are configured in legacy mode. The default BW 
> settings for legacy/advanced modes are different.

BW == Bandwidth?

> The existing
> code was using the advanced mode default value of 1 which was 
> incorrect. This caused the unbalanced BW sharing among siblings.
> The recommneded default value is applied.

's/recommneded/recommended/'

> 
> Signed-off-by: Tarun Singh 
> Signed-off-by: Paul M. Stillwell Jr 
> Signed-off-by: Qi Zhang 

<...>


Re: [dpdk-dev] [PATCH v2 33/52] net/ice/base: add RL profile bit mask check

2020-06-12 Thread Singh, Tarun K
Yes, RL profile is for Rate limiter profile.
-Tarun

-Original Message-
From: Yigit, Ferruh  
Sent: Thursday, June 11, 2020 11:40 AM
To: Zhang, Qi Z ; Yang, Qiming 
Cc: Ye, Xiaolong ; dev@dpdk.org; Singh, Tarun K 
; Stillwell Jr, Paul M 
Subject: Re: [dpdk-dev] [PATCH v2 33/52] net/ice/base: add RL profile bit mask 
check

On 6/9/2020 12:59 PM, Qi Zhang wrote:
> Mask bits before accessing the profile type field.

RL profile == Rate Limiter profile?

> 
> Signed-off-by: Tarun Singh 
> Signed-off-by: Paul M. Stillwell Jr 
> Signed-off-by: Qi Zhang 

<...>