RE: [PATCH v3 1/1] dma/cnxk: fix installing internal cnxk DMA headers
> -Original Message-
> From: Srikanth Yalavarthi
> Sent: Tuesday, January 25, 2022 9:50 PM
> To: Radha Chintakuntla ; Veerasenareddy Burru
>
> Cc: dev@dpdk.org; sta...@dpdk.org; Jerin Jacob Kollanukkaran
> ; Shivah Shankar Shankar Narayan Rao
> ; Srikanth Yalavarthi
>
> Subject: [PATCH v3 1/1] dma/cnxk: fix installing internal cnxk DMA headers
>
> DMA module internal header files are currently being installed to the prefix
> directory. This patch updates DMA meson config file to exclude internal
> headers during install stage.
>
> Fixes: 53f6d7328b (dma/cnxk: create and initialize device on PCI probing)
> Cc: sta...@dpdk.org
>
> Signed-off-by: Srikanth Yalavarthi
Acked-by: Radha Mohan Chintakuntla
> ---
> drivers/dma/cnxk/meson.build | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/cnxk/meson.build b/drivers/dma/cnxk/meson.build
> index 633e92a20d..d4be4ee860 100644
> --- a/drivers/dma/cnxk/meson.build
> +++ b/drivers/dma/cnxk/meson.build
> @@ -3,4 +3,3 @@
>
> deps += ['bus_pci', 'common_cnxk', 'dmadev'] sources =
> files('cnxk_dmadev.c') -headers = files('cnxk_dmadev.h')
> --
> 2.17.1
RE: [EXT] Re: OVS DPDK DMA-Dev library/Design Discussion
> -Original Message- > From: Bruce Richardson > Sent: Friday, May 13, 2022 3:34 AM > To: fengchengwen > Cc: Pai G, Sunil ; Ilya Maximets > ; Radha Chintakuntla ; > Veerasenareddy Burru ; Gagandeep Singh > ; Nipun Gupta ; Stokes, Ian > ; Hu, Jiayu ; Ferriter, Cian > ; Van Haaren, Harry > ; Maxime Coquelin > (maxime.coque...@redhat.com) ; ovs- > d...@openvswitch.org; dev@dpdk.org; Mcnamara, John > ; O'Driscoll, Tim ; > Finn, Emma > Subject: [EXT] Re: OVS DPDK DMA-Dev library/Design Discussion > > External Email > > -- > On Fri, May 13, 2022 at 05:48:35PM +0800, fengchengwen wrote: > > On 2022/5/13 17:10, Bruce Richardson wrote: > > > On Fri, May 13, 2022 at 04:52:10PM +0800, fengchengwen wrote: > > >> On 2022/4/8 14:29, Pai G, Sunil wrote: > > >>>> -Original Message- > > >>>> From: Richardson, Bruce > > >>>> Sent: Tuesday, April 5, 2022 5:38 PM > > >>>> To: Ilya Maximets ; Chengwen Feng > > >>>> ; Radha Mohan Chintakuntla > > >>>> ; Veerasenareddy Burru > ; > > >>>> Gagandeep Singh ; Nipun Gupta > > >>>> > > >>>> Cc: Pai G, Sunil ; Stokes, Ian > > >>>> ; Hu, Jiayu ; Ferriter, > > >>>> Cian ; Van Haaren, Harry > > >>>> ; Maxime Coquelin > > >>>> (maxime.coque...@redhat.com) ; > > >>>> ovs-...@openvswitch.org; dev@dpdk.org; Mcnamara, John > > >>>> ; O'Driscoll, Tim > > >>>> ; Finn, Emma > > >>>> Subject: Re: OVS DPDK DMA-Dev library/Design Discussion > > >>>> > > >>>> On Tue, Apr 05, 2022 at 01:29:25PM +0200, Ilya Maximets wrote: > > >>>>> On 3/30/22 16:09, Bruce Richardson wrote: > > >>>>>> On Wed, Mar 30, 2022 at 01:41:34PM +0200, Ilya Maximets wrote: > > >>>>>>> On 3/30/22 13:12, Bruce Richardson wrote: > > >>>>>>>> On Wed, Mar 30, 2022 at 12:52:15PM +0200, Ilya Maximets > wrote: > > >>>>>>>>> On 3/30/22 12:41, Ilya Maximets wrote: > > >>>>>>>>>> Forking the thread to discuss a memory consistency/ordering > model. > > >>>>>>>>>> > > >>>>>>>>>> AFAICT, dmadev can be anything from part of a CPU to a > > >>>>>>>>>> completely separate PCI device. However, I don't see any > > >>>>>>>>>> memory ordering being enforced or even described in the > > >>>>>>>>>> dmadev API or > > >>>> documentation. > > >>>>>>>>>> Please, point me to the correct documentation, if I somehow > > >>>>>>>>>> missed > > >>>> it. > > >>>>>>>>>> > > >>>>>>>>>> We have a DMA device (A) and a CPU core (B) writing > > >>>>>>>>>> respectively the data and the descriptor info. CPU core > > >>>>>>>>>> (C) is reading the descriptor and the data it points too. > > >>>>>>>>>> > > >>>>>>>>>> A few things about that process: > > >>>>>>>>>> > > >>>>>>>>>> 1. There is no memory barrier between writes A and B (Did I > miss > > >>>>>>>>>>them?). Meaning that those operations can be seen by C in > a > > >>>>>>>>>>different order regardless of barriers issued by C and > > >>>> regardless > > >>>>>>>>>>of the nature of devices A and B. > > >>>>>>>>>> > > >>>>>>>>>> 2. Even if there is a write barrier between A and B, there is > > >>>>>>>>>>no guarantee that C will see these writes in the same order > > >>>>>>>>>>as C doesn't use real memory barriers because vhost > > >>>>>>>>>> advertises > > >>>>>>>>> > > >>>>>>>>> s/advertises/does not advertise/ > > >>>>>>>>> > > >>>>>>>>>>VIRTIO_F_ORDER_PLATFORM. > > >&
RE: [PATCH] maintainers: update for OCTEON EP and CNXK DMA
> -Original Message- > From: Vamsi Attunuru > Sent: Tuesday, June 13, 2023 9:28 PM > To: dev@dpdk.org; tho...@monjalon.net > Cc: Radha Chintakuntla ; Veerasenareddy Burru > ; Sathesh B Edara ; Jerin Jacob > Kollanukkaran ; Vamsi Krishna Attunuru > > Subject: [PATCH] maintainers: update for OCTEON EP and CNXK DMA > > Replace the maintainers for OcteonTX EP and cnxk DPI DMA drivers. > > Signed-off-by: Vamsi Attunuru > --- > MAINTAINERS | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 906b31f97c..827733a1aa 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -845,9 +845,7 @@ F: doc/guides/nics/mvneta.rst > F: doc/guides/nics/features/mvneta.ini > > Marvell OCTEON TX EP - endpoint > -M: Radha Mohan Chintakuntla > -M: Veerasenareddy Burru > -M: Sathesh Edara > +M: Vamsi Attunuru > T: git://dpdk.org/next/dpdk-next-net-mrvl > F: drivers/net/octeon_ep/ > F: doc/guides/nics/features/octeon_ep.ini > @@ -1250,8 +1248,7 @@ F: drivers/dma/hisilicon/ > F: doc/guides/dmadevs/hisilicon.rst > > Marvell CNXK DPI DMA > -M: Radha Mohan Chintakuntla > -M: Veerasenareddy Burru > +M: Vamsi Attunuru > F: drivers/dma/cnxk/ > F: doc/guides/dmadevs/cnxk.rst > Acked-by: Radha Mohan Chintakuntla > -- > 2.25.1
RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine
> -Original Message-
> From: Radha Mohan Chintakuntla
> Sent: Friday, August 5, 2022 12:30 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Radha Chintakuntla ; Nithin
> Kumar Dabilpuram ; Kiran Kumar Kokkilagadda
> ; Sunil Kumar Kori ; Satha
> Koteswara Rao Kottidi ; Veerasenareddy Burru
>
> Subject: [PATCH v3] dma/cnxk: add support for CN10K DMA engine
>
> Added support for CN10K SoC DMA engine to dmadev.
>
> Signed-off-by: Radha Mohan Chintakuntla
> Reviewed-by: Jerin Jacob Kollanukkaran
> ---
> Changes from v2:
> - Added missing files required in the patch
>
> Changes from v1:
> - Removed gerrit changeID
>
> drivers/common/cnxk/hw/dpi.h | 16 +-
> drivers/common/cnxk/roc_dpi_priv.h | 2 +-
> drivers/dma/cnxk/cnxk_dmadev.c | 248 +
> drivers/dma/cnxk/cnxk_dmadev.h | 2 +-
> 4 files changed, 225 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/common/cnxk/hw/dpi.h b/drivers/common/cnxk/hw/dpi.h
> index 2da123228f..a34713dde6 100644
> --- a/drivers/common/cnxk/hw/dpi.h
> +++ b/drivers/common/cnxk/hw/dpi.h
> @@ -61,7 +61,7 @@
> */
> union dpi_instr_hdr_s {
> uint64_t u[4];
> - struct dpi_dma_instr_hdr_s_s {
> + struct dpi_cn9k_instr_hdr_s_s {
> uint64_t tag : 32;
> uint64_t tt : 2;
> uint64_t grp : 10;
> @@ -93,17 +93,9 @@ union dpi_instr_hdr_s {
> /* Word 2 - End */
> uint64_t reserved_192_255 : 64;
> /* Word 3 - End */
> - } s;
> -};
> + } cn9k;
>
> -/**
> - * Structure dpi_cn10k_instr_hdr_s for CN10K
> - *
> - * DPI DMA Instruction Header Format
> - */
> -union dpi_cn10k_instr_hdr_s {
> - uint64_t u[4];
> - struct dpi_cn10k_dma_instr_hdr_s_s {
> + struct dpi_cn10k_instr_hdr_s_s {
> uint64_t nfst : 4;
> uint64_t reserved_4_5 : 2;
> uint64_t nlst : 4;
> @@ -135,7 +127,7 @@ union dpi_cn10k_instr_hdr_s {
> /* Word 2 - End */
> uint64_t reserved_192_255 : 64;
> /* Word 3 - End */
> - } s;
> + } cn10k;
> };
>
> #endif /*__DEV_DPI_HW_H__*/
> diff --git a/drivers/common/cnxk/roc_dpi_priv.h
> b/drivers/common/cnxk/roc_dpi_priv.h
> index 92953fbcfc..1fa1a715d3 100644
> --- a/drivers/common/cnxk/roc_dpi_priv.h
> +++ b/drivers/common/cnxk/roc_dpi_priv.h
> @@ -23,7 +23,7 @@ typedef union dpi_mbox_msg_t {
> uint64_t u[2];
> struct dpi_mbox_message_s {
> /* VF ID to configure */
> - uint64_t vfid : 4;
> + uint64_t vfid : 8;
> /* Command code */
> uint64_t cmd : 4;
> /* Command buffer size in 8-byte words */ diff --git
> a/drivers/dma/cnxk/cnxk_dmadev.c b/drivers/dma/cnxk/cnxk_dmadev.c index
> 2824c1b44f..a67bcba9d4 100644
> --- a/drivers/dma/cnxk/cnxk_dmadev.c
> +++ b/drivers/dma/cnxk/cnxk_dmadev.c
> @@ -70,31 +70,31 @@ cnxk_dmadev_vchan_setup(struct rte_dma_dev *dev,
> uint16_t vchan,
> RTE_SET_USED(vchan);
> RTE_SET_USED(conf_sz);
>
> - header->s.pt = DPI_HDR_PT_ZBW_CA;
> + header->cn9k.pt = DPI_HDR_PT_ZBW_CA;
>
> switch (conf->direction) {
> case RTE_DMA_DIR_DEV_TO_MEM:
> - header->s.xtype = DPI_XTYPE_INBOUND;
> - header->s.lport = conf->src_port.pcie.coreid;
> - header->s.fport = 0;
> - header->s.pvfe = 1;
> + header->cn9k.xtype = DPI_XTYPE_INBOUND;
> + header->cn9k.lport = conf->src_port.pcie.coreid;
> + header->cn9k.fport = 0;
> + header->cn9k.pvfe = 1;
> break;
> case RTE_DMA_DIR_MEM_TO_DEV:
> - header->s.xtype = DPI_XTYPE_OUTBOUND;
> - header->s.lport = 0;
> - header->s.fport = conf->dst_port.pcie.coreid;
> - header->s.pvfe = 1;
> + header->cn9k.xtype = DPI_XTYPE_OUTBOUND;
> + header->cn9k.lport = 0;
> + header->cn9k.fport = conf->dst_port.pcie.coreid;
> + header->cn9k.pvfe = 1;
> break;
> case RTE_DMA_DIR_MEM_TO_MEM:
> - header->s.xtype = DPI_XTYPE_INTERNAL_ONLY;
> - header->s.lport = 0;
> - header->s.fport = 0;
> - header->s.pvfe = 0;
> + header->cn9k.xtype = DPI_XTYPE_INTERNAL_ONLY;
> + header->cn9k.lport = 0;
> + header->cn9k.fport = 0;
> + header->cn9k.pvfe = 0;
> break;
> case R
RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine
> -Original Message- > From: Radha Chintakuntla > Sent: Thursday, September 1, 2022 12:08 PM > To: Radha Chintakuntla ; dev@dpdk.org > Cc: tho...@monjalon.net; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Veerasenareddy Burru > > Subject: RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine > > > > -Original Message- > > From: Radha Mohan Chintakuntla > > Sent: Friday, August 5, 2022 12:30 PM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; Radha Chintakuntla ; > > Nithin Kumar Dabilpuram ; Kiran Kumar > > Kokkilagadda ; Sunil Kumar Kori > > ; Satha Koteswara Rao Kottidi > > ; Veerasenareddy Burru > > > Subject: [PATCH v3] dma/cnxk: add support for CN10K DMA engine > > > > Added support for CN10K SoC DMA engine to dmadev. > > > > Signed-off-by: Radha Mohan Chintakuntla > > Reviewed-by: Jerin Jacob Kollanukkaran > > --- > > Changes from v2: > > - Added missing files required in the patch > > > > Changes from v1: > > - Removed gerrit changeID > > > > drivers/common/cnxk/hw/dpi.h | 16 +- > > drivers/common/cnxk/roc_dpi_priv.h | 2 +- > > drivers/dma/cnxk/cnxk_dmadev.c | 248 > + > > drivers/dma/cnxk/cnxk_dmadev.h | 2 +- > > 4 files changed, 225 insertions(+), 43 deletions(-) > > snip > > 2.17.1 > > Hi Thomas, > Could you please pick this patch for main ? > > Regards, > Radha Hi Thomas, Could you please consider this for 22.11-rc1 ? Regards, Radha
RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine
> -Original Message- > From: Radha Chintakuntla > Sent: Monday, September 19, 2022 2:44 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: tho...@monjalon.net; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Veerasenareddy Burru > > Subject: RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine > > > > -Original Message- > > From: Radha Chintakuntla > > Sent: Thursday, September 1, 2022 12:08 PM > > To: Radha Chintakuntla ; dev@dpdk.org > > Cc: tho...@monjalon.net; Nithin Kumar Dabilpuram > > ; Kiran Kumar Kokkilagadda > > ; Sunil Kumar Kori ; Satha > > Koteswara Rao Kottidi ; Veerasenareddy Burru > > > > Subject: RE: [PATCH v3] dma/cnxk: add support for CN10K DMA engine > > > > > > > -Original Message- > > > From: Radha Mohan Chintakuntla > > > Sent: Friday, August 5, 2022 12:30 PM > > > To: dev@dpdk.org > > > Cc: tho...@monjalon.net; Radha Chintakuntla ; > > > Nithin Kumar Dabilpuram ; Kiran Kumar > > > Kokkilagadda ; Sunil Kumar Kori > > > ; Satha Koteswara Rao Kottidi > > > ; Veerasenareddy Burru > > > > > Subject: [PATCH v3] dma/cnxk: add support for CN10K DMA engine > > > > > > Added support for CN10K SoC DMA engine to dmadev. > > > > > > Signed-off-by: Radha Mohan Chintakuntla > > > Reviewed-by: Jerin Jacob Kollanukkaran > > > --- > > > Changes from v2: > > > - Added missing files required in the patch > > > > > > Changes from v1: > > > - Removed gerrit changeID > > > > > > drivers/common/cnxk/hw/dpi.h | 16 +- > > > drivers/common/cnxk/roc_dpi_priv.h | 2 +- > > > drivers/dma/cnxk/cnxk_dmadev.c | 248 > > + > > > drivers/dma/cnxk/cnxk_dmadev.h | 2 +- > > > 4 files changed, 225 insertions(+), 43 deletions(-) > > > > snip > > > 2.17.1 > > > > Hi Thomas, > > Could you please pick this patch for main ? > > > > Regards, > > Radha > > > Hi Thomas, > Could you please consider this for 22.11-rc1 ? Hi David, There has been no response from Thomas for quite long. Could you please pick this for main? Regards, Radha
