Re: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library
Hi Thomas, Would you merge this patch as the series is acked by Cristian as below? https://patchwork.dpdk.org/project/dpdk/cover/20211019081902.3514841-1-wojciechx.liguzin...@intel.com/ Thanks & Regards, Yu Liu -Original Message- From: dev On Behalf Of Liguzinski, WojciechX Sent: Monday, October 25, 2021 7:32 PM To: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, Cristian Cc: Ajmera, Megha Subject: [dpdk-dev] [PATCH v18 0/5] Add PIE support for HQoS library DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced queue management is required to address this problem and provide desirable quality of service to users. This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional Integral controller Enhanced) that can effectively and directly control queuing latency to address the bufferbloat problem. The implementation of mentioned functionality includes modification of existing and adding a new set of data structures to the library, adding PIE related APIs. This affects structures in public API/ABI. That is why deprecation notice is going to be prepared and sent. Liguzinski, WojciechX (5): sched: add PIE based congestion management example/qos_sched: add PIE support example/ip_pipeline: add PIE support doc/guides/prog_guide: added PIE app/test: add tests for PIE app/test/meson.build |4 + app/test/test_pie.c | 1065 ++ config/rte_config.h |1 - doc/guides/prog_guide/glossary.rst |3 + doc/guides/prog_guide/qos_framework.rst | 64 +- doc/guides/prog_guide/traffic_management.rst | 13 +- drivers/net/softnic/rte_eth_softnic_tm.c |6 +- examples/ip_pipeline/tmgr.c | 142 +-- examples/qos_sched/cfg_file.c| 127 ++- examples/qos_sched/cfg_file.h|5 + examples/qos_sched/init.c| 27 +- examples/qos_sched/main.h|3 + examples/qos_sched/profile.cfg | 196 ++-- lib/sched/meson.build|3 +- lib/sched/rte_pie.c | 86 ++ lib/sched/rte_pie.h | 398 +++ lib/sched/rte_sched.c| 241 ++-- lib/sched/rte_sched.h| 63 +- lib/sched/version.map|4 + 19 files changed, 2172 insertions(+), 279 deletions(-) create mode 100644 app/test/test_pie.c create mode 100644 lib/sched/rte_pie.c create mode 100644 lib/sched/rte_pie.h -- 2.25.1 Series-acked-by: Cristian Dumitrescu
[dpdk-dev] test
Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed
This is needed for RC2 as lots of test cases are affected.
Thanks & Regards,
Yu Liu
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann
Sent: Monday, July 10, 2017 5:48 PM
To: Yang, Zhiyong
Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com; Yao, Lei A
Subject: Re: [dpdk-dev] [PATCH] vhost: fix vhost-user init failed
On Mon, Jul 10, 2017 at 04:06:48PM +0800, Zhiyong Yang wrote:
>Exception handling is executed in the normal path and it will cause
>vhost-user init failure.
>Fixes: d6983a70e259("vhost: check return of pthread calls")
>
>Reported-by: Lei Yao
>Signed-off-by: Zhiyong Yang
>---
> lib/librte_vhost/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>index 57b86c0..9d2049c 100644
>--- a/lib/librte_vhost/socket.c
>+++ b/lib/librte_vhost/socket.c
>@@ -668,7 +668,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
> }
>
> vhost_user.vsockets[vhost_user.vsocket_cnt++] = vsocket;
>-
>+ goto out;
> out_mutex:
> if (pthread_mutex_destroy(&vsocket->conn_mutex)) {
> RTE_LOG(ERR, VHOST_CONFIG,
Thanks for fixing this!
Sorry for introducing this bug, I was about to send this before I saw your fix:
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index
57b86c0..b2158a7 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -668,6 +668,9 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
}
vhost_user.vsockets[vhost_user.vsocket_cnt++] = vsocket;
+out:
+ pthread_mutex_unlock(&vhost_user.mutex);
+ return ret;
out_mutex:
if (pthread_mutex_destroy(&vsocket->conn_mutex)) { @@ -677,9 +680,7 @@
rte_vhost_driver_register(const char *path, uint64_t flags)
out_free:
free(vsocket->path);
free(vsocket);
-out:
pthread_mutex_unlock(&vhost_user.mutex);
-
return ret;
}
Both works fine, so I leave it up to the maintainers how to fix.
Reviewed-by: Jens Freimann
[dpdk-dev] Patches verified by Intel engineers for DPDK 17.05 RC4.
Hi Thomas, Below patches have been verified. It would be great if they can get included into DPDK17.05. http://www.dpdk.org/dev/patchwork/patch/23957/ http://dpdk.org/dev/patchwork/patch/24044/ http://dpdk.org/dev/patchwork/patch/24021/ http://dpdk.org/dev/patchwork/patch/24022/ http://dpdk.org/dev/patchwork/patch/24023/ http://dpdk.org/dev/patchwork/patch/24051/ http://dpdk.org/dev/patchwork/patch/24052/ http://dpdk.org/dev/patchwork/patch/24053/ http://www.dpdk.org/dev/patchwork/patch/24060/ http://www.dpdk.org/dev/patchwork/patch/24061/ Thanks & Best Regards, Yu Liu
Re: [dpdk-dev] [PATCH] net/ixgbe: fix LSC interrupt issue
Hi Thomas,
This is fix for critical issues exposed by Gaetan Rivet's
commit(8ea656f8c300175ac84f3cbe1117f5ef11ffc4eb) to enable LSC.
This fix two issues. One is "VF testpmd can't set up successfully on Niantic
nic.", another is " kernel VF sometimes can't link up successfully when test
DPDK PF+kernel VF".
The fix is verified and code review show it is low risk.
It would be great if it can be released with DPDK 17.05.
Thanks & Regards,
Yu Liu
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
Sent: Monday, May 8, 2017 11:58 AM
To: Zhang, Helin ; Lu, Wenzhuo
Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix LSC interrupt issue
There is a bug in previous fix for lsc interrupt.
lsc interrupt is not disabled before delayed handler, that cause the delayed
handler be re-entered.
Fixes: 9b667210700e ("net/ixgbe: fix blocked interrupts")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ec667d8..c680aab 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4107,14 +4107,15 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev *dev,
timeout = IXGBE_LINK_DOWN_CHECK_TIMEOUT;
ixgbe_dev_link_status_print(dev);
- intr->mask_original = intr->mask;
- /* only disable lsc interrupt */
- intr->mask &= ~IXGBE_EIMS_LSC;
if (rte_eal_alarm_set(timeout * 1000,
ixgbe_dev_interrupt_delayed_handler,
(void *)dev) < 0)
PMD_DRV_LOG(ERR, "Error setting alarm");
- else
- intr->mask = intr->mask_original;
+ else {
+ /* remember orignal mask */
+ intr->mask_original = intr->mask;
+ /* only disable lsc interrupt */
+ intr->mask &= ~IXGBE_EIMS_LSC;
+ }
}
PMD_DRV_LOG(DEBUG, "enable intr immediately");
--
2.7.4
[dpdk-dev] dpdk daily build error on dpdk16.07-rc2
Hi Thomas, Would you check who can work on "dpdk16.07-rc2 compile error on FC18 & UB1204"? For "dpdk16.07-rc2 compile error on suse11", I saw document shows we support suse12+. Seems it is not issue for this release. Agree? Thanks & Regards, Yu Liu From: Gu, YongjieX Sent: Thursday, July 14, 2016 5:23 PM To: thomas.monjalon at 6wind.com; Richardson, Bruce ; Yigit, Ferruh ; Gonzalez Monroy, Sergio ; Jan Medala ; dev at dpdk.org Cc: Cao, Waterman ; Liu, Yu Y ; Chen, WeichunX ; Xu, HuilongX ; Gu, YongjieX Subject: dpdk daily build error on dpdk16.07-rc2 Hi,All, There are 4 build errors reported by our dpdk daily report,and can you take a look on these issues. Jan is working on ena issues,and I will help to test it. OS, Kernel , GCC , ICC Affected Targets Build errors comments FC18_64,3.6.10-4,4.7.2,14.0.0 x86_64-ivshmem-linuxapp-gcc CC test_kvargs.o UBT124_64,3.8.0-29,4.6.3,14.0.0 LD test SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `eal_alarm_callback': eal_alarm.c:(.text+0xd7): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `rte_eal_alarm_set': eal_alarm.c:(.text+0x20f): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_timer.o): In function `get_tsc_freq': eal_timer.c:(.text+0x108): undefined reference to `clock_gettime' eal_timer.c:(.text+0x146): undefined reference to `clock_gettime' collect2: error: ld returned 1 exit status make[5]: *** [test] Error 1 make[4]: *** [test] Error 2 make[3]: *** [app] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 x86_64-native-linuxapp-gcc-examples == ipsec-secgw CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c:56:2: error: unknown field 'ip4' specified in initializer compilation terminated due to -Wfatal-errors. make[4]: *** [sa.o] Error 1 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-gcc_examples] Error 2 make: *** [examples] Error 2 x86_64-native-linuxapp-icc-examples == ipsec-secgw x86_64-ivshmem-linuxapp-icc-examples CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o icc: command line warning #10158: ignoring option '-diag-disable'; argument must be separate /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c(56): error: a designator for an anonymous union member can only appear within braces corresponding to that anonymous union .src.ip4 = IPv4(172, 16, 1, 5), ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c (code 4) make[4]: *** [sa.o] Error 4 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-icc_examples] Error 2 make: *** [examples] Error 2 UBT144_32,3.13.0-30,4.8.2,14.0.0 i686-native-linuxapp-icc == Build drivers/net/ena CC ena_ethdev.o PMDINFO ena_ethdev.o.pmd.c CC ena_ethdev.o.pmd.o LD ena_ethdev.o CC ena_com.o /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c(346): error #3656: variable "dev_node" may be used before its value is set ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev, ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c (code 4) make[6]: *** [ena_com.o] Error 4 make[5]: *** [ena] Error 2 make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 freebsd10.3,10.3-RELEASE,4.8.5 x86_64-native-linuxapp-gcc sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...&
[dpdk-dev] dpdk daily build error on dpdk16.07-rc2
Hi Jan, Any update on ena related error? Thanks, Yu Liu From: Gu, YongjieX Sent: Thursday, July 14, 2016 5:23 PM To: thomas.monjalon at 6wind.com; Richardson, Bruce ; Yigit, Ferruh ; Gonzalez Monroy, Sergio ; Jan Medala ; dev at dpdk.org Cc: Cao, Waterman ; Liu, Yu Y ; Chen, WeichunX ; Xu, HuilongX ; Gu, YongjieX Subject: dpdk daily build error on dpdk16.07-rc2 Hi,All, There are 4 build errors reported by our dpdk daily report,and can you take a look on these issues. Jan is working on ena issues,and I will help to test it. OS, Kernel , GCC , ICC Affected Targets Build errors comments FC18_64,3.6.10-4,4.7.2,14.0.0 x86_64-ivshmem-linuxapp-gcc CC test_kvargs.o UBT124_64,3.8.0-29,4.6.3,14.0.0 LD test SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `eal_alarm_callback': eal_alarm.c:(.text+0xd7): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `rte_eal_alarm_set': eal_alarm.c:(.text+0x20f): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_timer.o): In function `get_tsc_freq': eal_timer.c:(.text+0x108): undefined reference to `clock_gettime' eal_timer.c:(.text+0x146): undefined reference to `clock_gettime' collect2: error: ld returned 1 exit status make[5]: *** [test] Error 1 make[4]: *** [test] Error 2 make[3]: *** [app] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 x86_64-native-linuxapp-gcc-examples == ipsec-secgw CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c:56:2: error: unknown field 'ip4' specified in initializer compilation terminated due to -Wfatal-errors. make[4]: *** [sa.o] Error 1 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-gcc_examples] Error 2 make: *** [examples] Error 2 x86_64-native-linuxapp-icc-examples == ipsec-secgw x86_64-ivshmem-linuxapp-icc-examples CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o icc: command line warning #10158: ignoring option '-diag-disable'; argument must be separate /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c(56): error: a designator for an anonymous union member can only appear within braces corresponding to that anonymous union .src.ip4 = IPv4(172, 16, 1, 5), ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c (code 4) make[4]: *** [sa.o] Error 4 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-icc_examples] Error 2 make: *** [examples] Error 2 UBT144_32,3.13.0-30,4.8.2,14.0.0 i686-native-linuxapp-icc == Build drivers/net/ena CC ena_ethdev.o PMDINFO ena_ethdev.o.pmd.c CC ena_ethdev.o.pmd.o LD ena_ethdev.o CC ena_com.o /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c(346): error #3656: variable "dev_node" may be used before its value is set ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev, ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c (code 4) make[6]: *** [ena_com.o] Error 4 make[5]: *** [ena] Error 2 make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 freebsd10.3,10.3-RELEASE,4.8.5 x86_64-native-linuxapp-gcc sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command
[dpdk-dev] dpdk daily build error on dpdk16.07-rc2
Hi All, Patches for below two issues are verified by Yongjie. dpdk16.07-rc2 compile error on FC18 & UB1204 ena compile error on UB1404 & FC20 Best Regards, Yu Liu From: Gu, YongjieX Sent: Thursday, July 14, 2016 5:23 PM To: thomas.monjalon at 6wind.com; Richardson, Bruce ; Yigit, Ferruh ; Gonzalez Monroy, Sergio ; Jan Medala ; dev at dpdk.org Cc: Cao, Waterman ; Liu, Yu Y ; Chen, WeichunX ; Xu, HuilongX ; Gu, YongjieX Subject: dpdk daily build error on dpdk16.07-rc2 Hi,All, There are 4 build errors reported by our dpdk daily report,and can you take a look on these issues. Jan is working on ena issues,and I will help to test it. OS, Kernel , GCC , ICC Affected Targets Build errors comments FC18_64,3.6.10-4,4.7.2,14.0.0 x86_64-ivshmem-linuxapp-gcc CC test_kvargs.o UBT124_64,3.8.0-29,4.6.3,14.0.0 LD test SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `eal_alarm_callback': eal_alarm.c:(.text+0xd7): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_alarm.o): In function `rte_eal_alarm_set': eal_alarm.c:(.text+0x20f): undefined reference to `clock_gettime' /jenkins/workspace/DPDK_AUTO_IDT_VM_FC18_64_BUILD2/DPDK/x86_64-ivshmem-linuxapp-gcc/lib/librte_eal.a(eal_timer.o): In function `get_tsc_freq': eal_timer.c:(.text+0x108): undefined reference to `clock_gettime' eal_timer.c:(.text+0x146): undefined reference to `clock_gettime' collect2: error: ld returned 1 exit status make[5]: *** [test] Error 1 make[4]: *** [test] Error 2 make[3]: *** [app] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 SUSE11SP2_64,3.0.13-0,4.5.1,14.0.0 x86_64-native-linuxapp-gcc-examples == ipsec-secgw CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c:56:2: error: unknown field 'ip4' specified in initializer compilation terminated due to -Wfatal-errors. make[4]: *** [sa.o] Error 1 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-gcc_examples] Error 2 make: *** [examples] Error 2 x86_64-native-linuxapp-icc-examples == ipsec-secgw x86_64-ivshmem-linuxapp-icc-examples CC ipsec.o CC esp.o CC sp4.o CC sp6.o CC sa.o icc: command line warning #10158: ignoring option '-diag-disable'; argument must be separate /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c(56): error: a designator for an anonymous union member can only appear within braces corresponding to that anonymous union .src.ip4 = IPv4(172, 16, 1, 5), ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_SUSE11SP2_64_BUILD/DPDK/examples/ipsec-secgw/sa.c (code 4) make[4]: *** [sa.o] Error 4 make[3]: *** [all] Error 2 make[2]: *** [ipsec-secgw] Error 2 make[1]: *** [x86_64-native-linuxapp-icc_examples] Error 2 make: *** [examples] Error 2 UBT144_32,3.13.0-30,4.8.2,14.0.0 i686-native-linuxapp-icc == Build drivers/net/ena CC ena_ethdev.o PMDINFO ena_ethdev.o.pmd.c CC ena_ethdev.o.pmd.o LD ena_ethdev.o CC ena_com.o /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c(346): error #3656: variable "dev_node" may be used before its value is set ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev, ^ compilation aborted for /jenkins/workspace/DPDK_AUTO_IDT_VM_UBT144_32_BUILD/DPDK/drivers/net/ena/base/ena_com.c (code 4) make[6]: *** [ena_com.o] Error 4 make[5]: *** [ena] Error 2 make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 freebsd10.3,10.3-RELEASE,4.8.5 x86_64-native-linuxapp-gcc sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters at the end of h command sed: 1: "/usr/home/xugang/dpdk-1 ...": extra characters
Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information
Add Damjan from FD.io for awareness... Hi Thomas, Long time no see. Sorry I use outlook which is not friendly to community email. >Anyway I will propose to replace this API in the next release. Will your plan be affected by API/ABI stable plan? BTW, if you propose new change in next release, it will make DPDK consumer(FD.io) to change again. So even if it is not affected to the API/ABI stable plan, do we still have time to get a solution for everyone in DPDK 19.11 with your contribution/acceleration? > I suspect a real hidden issue in Intel CPUs that you try to mitigate. Please be rest assured it is not the case. This request is just from one FD.io project internal bug " tx/rx burst function is shown as nil" reported by Chenmin. My understanding is DPDK behavior was taken as bug for someone in FD.io project and potentially will mislead other DPDK consumer. Haiyue is working with Chenmin to address the issue and with your support it will be even better. Your support will be highly appreciated! Thanks & Regards, Yu Liu -Original Message- From: dev On Behalf Of Wang, Haiyue Sent: Saturday, November 2, 2019 1:30 PM To: Thomas Monjalon Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh ; jerinjac...@gmail.com; Ye, Xiaolong ; Kinsella, Ray ; Sun, Chenmin ; Slava Ovsiienko Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information > -Original Message- > From: Thomas Monjalon > Sent: Saturday, November 2, 2019 06:46 > To: Wang, Haiyue > Cc: dev@dpdk.org; arybche...@solarflare.com; Yigit, Ferruh > ; jerinjac...@gmail.com; Ye, Xiaolong > ; Kinsella, Ray ; Sun, > Chenmin ; Slava Ovsiienko > > Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting burst > mode information > > Thank you for trying to address comments done late. > > 31/10/2019 18:11, Haiyue Wang: > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) > > +#define RTE_ETH_BURST_NEON (1ULL << 3) > > +#define RTE_ETH_BURST_SSE (1ULL << 4) > > +#define RTE_ETH_BURST_AVX2 (1ULL << 5) > > +#define RTE_ETH_BURST_AVX512(1ULL << 6) > > Of course, I still believe that giving a special treatment to vector > instructions is wrong. > You did not justify why it needs to be defined in bits instead of > string. I am not asking again because anyway you don't really reply. I > think you are executing an order you received and I don't want to > blame you more. > I suspect a real hidden issue in Intel CPUs that you try to mitigate. > No need to reply to this comment. > Anyway I will propose to replace this API in the next release. Never mind, if this design is truly ugly, drop it all now. I also prefer to do the best, that's why open source is amazing, thanks! ;-)
