[dpdk-dev] Patch not seen in the Patchwork
Hi, My name is Leah Tekoa and I am working at Ethernity Networks. I am a new contributor to DPDK. I am trying to submit code to DPDK. I followed the instructions under: https://doc.dpdk.org/guides-18.08/contributing/patches.html * I registered to the DPDK development mailing list. * I registered to the DPDK Patchwork. * I also registered to: sta...@dpdk.org<mailto:sta...@dpdk.org> and us...@dpdk.org<mailto:us...@dpdk.org>. * I committed my change and followed the instructions regarding the commit message Subject Line and Body. * I ran the checkpatches.sh and verified the patch is OK. * I generated the patch with git-format-patch. * I sent the patch using git-send-mail and got: ‘Result: OK’. The problem is that I don’t see my patch in the Patchwork. Note that I did get an email with my patch, that has the dev@dpdk.org<mailto:dev@dpdk.org> on the TO. Also, an internal colleague got my patch email as well. Can you advise please? Thanks, Leah.
Re: [dpdk-dev] Patch not seen in the Patchwork
Hi, Can someone please take a look and help me with this? The patch I want to submit is just a small fix of correcting a typo and replacing 'Y' with 'R' while displaying the RED bytes statistics. As written in my previous email, I followed the instructions under: https://doc.dpdk.org/guides-18.08/contributing/patches.html but my patch was not added to the Patchwork. Appreciate your help, Leah. -Original Message- From: dev On Behalf Of Leah Tekoa Sent: October 9, 2018 10:01 AM To: dev@dpdk.org Cc: Shachar Beiser ; Barak Perlman Subject: [dpdk-dev] Patch not seen in the Patchwork Hi, My name is Leah Tekoa and I am working at Ethernity Networks. I am a new contributor to DPDK. I am trying to submit code to DPDK. I followed the instructions under: https://doc.dpdk.org/guides-18.08/contributing/patches.html * I registered to the DPDK development mailing list. * I registered to the DPDK Patchwork. * I also registered to: sta...@dpdk.org<mailto:sta...@dpdk.org> and us...@dpdk.org<mailto:us...@dpdk.org>. * I committed my change and followed the instructions regarding the commit message Subject Line and Body. * I ran the checkpatches.sh and verified the patch is OK. * I generated the patch with git-format-patch. * I sent the patch using git-send-mail and got: ‘Result: OK’. The problem is that I don’t see my patch in the Patchwork. Note that I did get an email with my patch, that has the dev@dpdk.org<mailto:dev@dpdk.org> on the TO. Also, an internal colleague got my patch email as well. Can you advise please? Thanks, Leah.
[dpdk-dev] [PATCH] app/testpmd: replace Y with R in RED bytes statistics
From: Leah Tekoa
Y stands for Yellow, R stands for Red.
Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing")
Cc: sta...@dpdk.org
Signed-off-by: Leah Tekoa
---
app/test-pmd/cmdline_mtr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index f908fb3..748515d 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -1440,7 +1440,7 @@ static void cmd_show_port_meter_stats_parsed(void
*parsed_result,
printf("\tPkts R: %" PRIu64 "\n",
stats.n_pkts[RTE_MTR_RED]);
if (stats_mask & RTE_MTR_STATS_N_BYTES_RED)
- printf("\tBytes Y: %" PRIu64 "\n",
+ printf("\tBytes R: %" PRIu64 "\n",
stats.n_bytes[RTE_MTR_RED]);
if (stats_mask & RTE_MTR_STATS_N_PKTS_DROPPED)
printf("\tPkts DROPPED: %" PRIu64 "\n",
--
1.8.3.1
[dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit
From: Leah Tekoa
memcpy should be used for copying rte_eth_link structure
Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF")
Signed-off-by: Leah Tekoa
---
lib/librte_ethdev/rte_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 5f85817..c187690 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -3266,7 +3266,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id,
uint16_t queue_idx,
dev = &rte_eth_devices[port_id];
rte_eth_dev_info_get(port_id, &dev_info);
- link = dev->data->dev_link;
+ memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link));
if (queue_idx > dev_info.max_tx_queues) {
RTE_ETHDEV_LOG(ERR,
--
1.8.3.1
Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit
We had problems with the way it is currently written and it didn't work for us.
We got zero in link.link_speed and the real value was not copied correctly.
-Original Message-
From: Ferruh Yigit
Sent: November 19, 2018 1:44 PM
To: Leah Tekoa ; dev@dpdk.org
Cc: Ouyang Changchun
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix copying bug in
rte_eth_set_queue_rate_limit
On 11/19/2018 8:38 AM, Leah Tekoa wrote:
> From: Leah Tekoa
>
> memcpy should be used for copying rte_eth_link structure
Why?
>
> Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF")
>
> Signed-off-by: Leah Tekoa
> ---
> lib/librte_ethdev/rte_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c
> b/lib/librte_ethdev/rte_ethdev.c index 5f85817..c187690 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -3266,7 +3266,7 @@ int rte_eth_set_queue_rate_limit(uint16_t
> port_id, uint16_t queue_idx,
>
> dev = &rte_eth_devices[port_id];
> rte_eth_dev_info_get(port_id, &dev_info);
> - link = dev->data->dev_link;
> + memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link));
>
> if (queue_idx > dev_info.max_tx_queues) {
> RTE_ETHDEV_LOG(ERR,
>
