[dpdk-dev] dpdk-1.7.0 bug report

[David Binderman]

Hello there,

dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) == 
0x1' is always false.

Source code is

??? return ((ea->addr_bytes[0] & ETHER_LOCAL_ADMIN_ADDR) == 1);

but

#define ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */

Regards

David Binderman

[dpdk-dev] dpdk-1.7.0 bug report

[David Binderman]

Hello there,


> 2014-07-23 14:24, David Binderman:
>> dpdk-1.7.0/lib/librte_ether/rte_ether.h:208]: (style) Expression '(X & 0x2) 
>> == 0x1' is always false.
>
> Which tool are you using?

cppcheck, available from sourceforge. Strongly recommended.

Regards

David Binderman