Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error
> -Original Message-
> From: dev On Behalf Of Alvin Zhang
> Sent: Tuesday, April 20, 2021 10:05 AM
> To: Wang, Haiyue ; Guo, Jia
> Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error
>
> When DEV_RX_OFFLOAD_KEEP_CRC is enabled, the PMD will minus 4 bytes of
> CRC from the size of a packet, but the NIC will strip the CRC because the CRC
> strip bit in DVMOLR register is not cleared. This will cause the size of a
> packet
> to be 4 bytes less.
>
> This patch updates the CRC strip bit according to whether
> DEV_RX_OFFLOAD_KEEP_CRC is enabled.
>
> Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alvin Zhang
Tested-by: Lingli Chen
Re: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Thursday, April 22, 2021 1:08 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v5] net/iavf: fix hash configuration on i40e VF > Tested-by: Yan Xia
Re: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR input set conflict issue
> -Original Message-
> From: dev On Behalf Of beilei.x...@intel.com
> Sent: Thursday, June 24, 2021 3:30 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR input set conflict issue
>
> From: Beilei Xing
>
> Currently, there'll be conflict error when running the following commands:
> 1. flow create 0 ingress
> pattern eth / ipv4 / udp src is 32 / end
> actions queue index 2 / end
> 2. flow destroy 0 rule 0
> 3. flow create 0 ingress
> pattern eth / ipv4 / udp dst is 32 / end
> actions queue index 2 / end
>
> This patch fixes the input set conflict issue.
>
> Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR")
> Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Beilei Xing
Tested-by: Lingli Chen
Re: [dpdk-dev] [PATCH v2] net/e1000: fix max Rx packet size
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Thursday, April 8, 2021 3:41 PM > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/e1000: fix max Rx packet size > Tested-by: Chen Lingli
RE: [PATCH] net/ixgbe: fix inverted test and set conditional
> -Original Message-
> From: Tyler Retzlaff
> Sent: Friday, June 16, 2023 3:30 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Wu, Wenjun1
> ; m...@smartsharesystems.com; Tyler Retzlaff
> ; david.march...@redhat.com
> Subject: [PATCH] net/ixgbe: fix inverted test and set conditional
>
> Correct a mistake when converting ixgbe to use __atomic_test_and_set
> instead of rte_atomic32_test_and_set. The return value from
> __atomic_test_and_set is inverted relative to rte_atomic32_test_and_set.
>
> Fixes: e90baf6b82f6 ("net/ixgbe: replace legacy atomics with GCC builtin
> atomics")
> Cc: roret...@linux.microsoft.com
> Cc: david.march...@redhat.com
> Cc: qiming.y...@intel.com
>
> Signed-off-by: Tyler Retzlaff
> ---
Tested-by: Lingli Chen
RE: [PATCH v1] examples/l3fwd: fix core dump after packet match
> -Original Message-
> From: Sean Morrissey
> Sent: Wednesday, September 7, 2022 7:34 PM
> To: Konstantin Ananyev ; Morrissey, Sean
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH v1] examples/l3fwd: fix core dump after packet match
>
> This patch fixes a core dump which occurs on 32-bit-builds after sending a
> matched packet due to overrunning an array.
>
> Fixes: 6de0ea50e9b9 ("examples/l3fwd: merge l3fwd-acl example")
> Cc: sean.morris...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Sean Morrissey
> ---
Tested-by: Lingli Chen
RE: [PATCH] net/i40e: fix PCTYPE configuration for X722
> -Original Message-
> From: Mingjin Ye
> Sent: Friday, November 4, 2022 12:57 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhou, YidingX ; Ye, MingjinX
> ; Zhang, Yuying ; Xing,
> Beilei ; Alvin Zhang ; Zhang,
> Qi Z
> Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722
>
> To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD
> programming descriptor is translated into different types by using
> GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP'
> and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the
> corresponding registers can not be configured after translation.
>
> This patch removes the transition before the FD filter is programmed.
>
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Mingjin Ye
> ---
Tested-by: Lingli Chen
Re: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alvin Zhang
> Sent: Monday, March 1, 2021 3:06 PM
> To: Guo, Jia ; Xing, Beilei ; Zhang,
> Qi Z ; Zhou, JunX W
> Cc: dev@dpdk.org; Zhang, AlvinX ;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] net/i40e: fix inputset field mask
>
> The absolute field offsets of IPv4 or IPv6 header are related to hardware
> configuration. The X710 and X722 have different hardware configurations,
> and users can even modify the hardware configuration.
> Therefore, The default values cannot be used when calculating mask offset.
>
> The following flows can be created on X722 NIC, but the packet will not enter
> the queue 3:
> flow create 0 ingress pattern eth / ipv4 proto is 255 / end
> actions queue index 3 / end
> pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
> queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
>
> This patch read the field offsets from the NIC and return the mask register
> value.
>
> Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director")
> Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alvin Zhang
all regression cases passed.
Tested-by: Chen Lingli
Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error
Tested-by: Chen, LingliX Regards, Chen, LingliX > -Original Message- > From: Walsh, Conor > Sent: Thursday, November 12, 2020 7:36 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; Chen, LingliX ; Walsh, Conor > > Subject: [PATCH v1] build: add Wformat to fix gcc compile error > > On some systems Wformat-nonliteral and Wformat-security could not be > checked without Wformat also being specified. This patch adds Wformat to > config/meson.build > > Signed-off-by: Conor Walsh > --- > config/meson.build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config/meson.build b/config/meson.build index > 258b01d068..15625c346a 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -192,6 +192,7 @@ warning_flags = [ > # additional warnings in alphabetical order > '-Wcast-qual', > '-Wdeprecated', > + '-Wformat', > '-Wformat-nonliteral', > '-Wformat-security', > '-Wmissing-declarations', > -- > 2.25.1
Re: [dpdk-dev] [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat
Tested-by: Chen, LingliX Regards, Chen, LingliX > -Original Message- > From: Walsh, Conor > Sent: Thursday, November 19, 2020 6:17 PM > To: Richardson, Bruce ; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; > bl...@debian.org; stuart.schac...@broadcom.com; > venkatkumar.duvv...@broadcom.com; michael.wi...@broadcom.com > Cc: dev@dpdk.org; sta...@dpdk.org; Chen, LingliX ; > tho...@monjalon.net; Walsh, Conor ; Chen > Subject: [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat
Re: [dpdk-dev] [PATCH] raw/ifpga/base: fix uninitialized variables gcc warning
Tested-by: Chen, LingliX Regards, Chen, LingliX > -Original Message- > From: Walsh, Conor > Sent: Thursday, November 19, 2020 11:00 PM > To: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Cc: dev@dpdk.org; sta...@dpdk.org; Chen, LingliX ; > Walsh, Conor > Subject: [PATCH] raw/ifpga/base: fix uninitialized variables gcc warning > > On Ubuntu 18.04 using gcc 7.5, gcc sees size and start as possibly being > uninitialized. This patch initialises size and start to correct this warning.
