RE: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield
> Hi Stephen,
>
> Thanks for commenting. See response inline.
>
> Regards,
> Nitin
>
> On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger
> wrote:
> >
> > On Tue, 1 Apr 2025 09:50:46 +0530
> > Nitin Saxena wrote:
> >
> > > +int rte_node_mbuf_dynfield_register(void)
> > > +{
> > > + struct node_mbuf_dynfield_mz *f = NULL;
> > > + const struct rte_memzone *mz = NULL;
> > > + int dyn_offset;
> > > +
> > > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_dynfield_t) <
> RTE_NODE_MBUF_DYNFIELD_SIZE);
> > > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_overload_fields_t) <
> > > + RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE);
> > > +
> > > + mz =
> rte_memzone_lookup(NODE_MBUF_DYNFIELD_MEMZONE_NAME);
> >
> > Seems wasteful to have a whole memzone for this, the data is small.
> > Is there a reason it could not just be a global variable like timestamp.
> >
> Replaced usage of memzone with global variable in v2
We need to use memzone to share the offset between primary and secondary
processes I don’t see any other way.
>
> > I would prefer this was a clone of timestamp code, and put in
> rte_mbuf_dynfield.c
> rte_node_mbuf_dynfield_register() is local to graph based rte_nodes
> and it is not targeted to be used by non-graph based applications
>
> Do you still think we should move this API definition to rte_mbuf_dyn.c?
[PATCH v3 2/2] node: use node mbuf dynfield in ip4 nodes
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes
- Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get()
Signed-off-by: Nitin Saxena
---
lib/node/ip4_lookup.c | 14 ---
lib/node/ip4_rewrite.c| 15 +---
lib/node/ip6_lookup.c | 15 +---
lib/node/ip6_rewrite.c| 14 ---
lib/node/node_private.h | 40 +++
lib/node/rte_node_mbuf_dynfield.h | 9 +++
6 files changed, 34 insertions(+), 73 deletions(-)
diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index 0b474cd2bc..7e9d21a9c9 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -31,8 +31,6 @@ struct ip4_lookup_node_ctx {
int mbuf_priv1_off;
};
-int node_mbuf_priv1_dynfield_offset = -1;
-
static struct ip4_lookup_node_main ip4_lookup_nm;
#define IP4_LOOKUP_NODE_LPM(ctx) \
@@ -180,17 +178,15 @@ ip4_lookup_node_init(const struct rte_graph *graph,
struct rte_node *node)
{
uint16_t socket, lcore_id;
static uint8_t init_once;
- int rc;
+ int rc, dyn;
RTE_SET_USED(graph);
RTE_BUILD_BUG_ON(sizeof(struct ip4_lookup_node_ctx) > RTE_NODE_CTX_SZ);
+ dyn = rte_node_mbuf_dynfield_register();
+ if (dyn < 0)
+ return -rte_errno;
if (!init_once) {
- node_mbuf_priv1_dynfield_offset = rte_mbuf_dynfield_register(
- &node_mbuf_priv1_dynfield_desc);
- if (node_mbuf_priv1_dynfield_offset < 0)
- return -rte_errno;
-
/* Setup LPM tables for all sockets */
RTE_LCORE_FOREACH(lcore_id)
{
@@ -208,7 +204,7 @@ ip4_lookup_node_init(const struct rte_graph *graph, struct
rte_node *node)
/* Update socket's LPM and mbuf dyn priv1 offset in node ctx */
IP4_LOOKUP_NODE_LPM(node->ctx) = ip4_lookup_nm.lpm_tbl[graph->socket];
- IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset;
+ IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = dyn;
#if defined(__ARM_NEON) || defined(RTE_ARCH_X86)
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
diff --git a/lib/node/ip4_rewrite.c b/lib/node/ip4_rewrite.c
index 34a920df5e..b05decc1a3 100644
--- a/lib/node/ip4_rewrite.c
+++ b/lib/node/ip4_rewrite.c
@@ -258,19 +258,16 @@ ip4_rewrite_node_process(struct rte_graph *graph, struct
rte_node *node,
static int
ip4_rewrite_node_init(const struct rte_graph *graph, struct rte_node *node)
{
- static bool init_once;
+ int dyn;
RTE_SET_USED(graph);
RTE_BUILD_BUG_ON(sizeof(struct ip4_rewrite_node_ctx) > RTE_NODE_CTX_SZ);
- if (!init_once) {
- node_mbuf_priv1_dynfield_offset = rte_mbuf_dynfield_register(
- &node_mbuf_priv1_dynfield_desc);
- if (node_mbuf_priv1_dynfield_offset < 0)
- return -rte_errno;
- init_once = true;
- }
- IP4_REWRITE_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset;
+ dyn = rte_node_mbuf_dynfield_register();
+ if (dyn < 0)
+ return -rte_errno;
+
+ IP4_REWRITE_NODE_PRIV1_OFF(node->ctx) = dyn;
node_dbg("ip4_rewrite", "Initialized ip4_rewrite node initialized");
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index f378d2d064..c140aa9cf3 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -316,18 +316,16 @@ ip6_lookup_node_init(const struct rte_graph *graph,
struct rte_node *node)
{
uint16_t socket, lcore_id;
static uint8_t init_once;
- int rc;
+ int rc, dyn;
RTE_SET_USED(graph);
RTE_BUILD_BUG_ON(sizeof(struct ip6_lookup_node_ctx) > RTE_NODE_CTX_SZ);
- if (!init_once) {
- node_mbuf_priv1_dynfield_offset =
- rte_mbuf_dynfield_register(
- &node_mbuf_priv1_dynfield_desc);
- if (node_mbuf_priv1_dynfield_offset < 0)
- return -rte_errno;
+ dyn = rte_node_mbuf_dynfield_register();
+ if (dyn < 0)
+ return -rte_errno;
+ if (!init_once) {
/* Setup LPM tables for all sockets */
RTE_LCORE_FOREACH(lcore_id)
{
@@ -345,8 +343,7 @@ ip6_lookup_node_init(const struct rte_graph *graph, struct
rte_node *node)
/* Update socket's LPM and mbuf dyn priv1 offset in node ctx */
IP6_LOOKUP_NODE_LPM(node->ctx) = ip6_lookup_nm.lpm_tbl[graph->socket];
- IP6_LOOKUP_NODE_PRIV1_OFF(node->ctx) =
- node_mbuf_priv1_dynfield_offset;
+ IP6_LOOKUP_NODE_PRIV1_OFF(node->ctx) = dyn;
node_dbg("ip6_lookup", "Initialized ip6_lookup node");
diff --git a/lib/node/ip6_rewrite.c b/lib/node/ip6_rewrite.c
index 198d8d8820..b9e223ab3a 100644
--- a/lib/node/ip6_rewrite.c
+++ b/lib/node/ip6_rewrite.
[PATCH v3 1/2] node: add global node mbuf dynfield
This patch defines rte_node specific dynamic field structure
(rte_node_mbuf_dynfield_t)
rte_node_mbuf_dynfield_t structure holds two types of fields
- Persistent data fields which are preserved across graph walk.
Currently size of persistent data fields is zero.
- Overloadable data fields which are used by any two adjacent nodes.
Same fields can be repurposed by any other adjacent nodes
This dynfield can be also be used by out-of-tree nodes.
Signed-off-by: Nitin Saxena
---
doc/api/doxy-api-index.md | 3 +-
doc/guides/rel_notes/release_25_07.rst | 6 ++
lib/node/meson.build | 2 +
lib/node/node_mbuf_dynfield.c | 44 +
lib/node/rte_node_mbuf_dynfield.h | 132 +
lib/node/version.map | 3 +
6 files changed, 189 insertions(+), 1 deletion(-)
create mode 100644 lib/node/node_mbuf_dynfield.c
create mode 100644 lib/node/rte_node_mbuf_dynfield.h
diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index b2fc24b3e4..6b93b3cd97 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -219,7 +219,8 @@ The public API headers are grouped by topics:
[ip4_node](@ref rte_node_ip4_api.h),
[ip6_node](@ref rte_node_ip6_api.h),
[udp4_input_node](@ref rte_node_udp4_input_api.h)
-
+ * graph_nodes_mbuf:
+[node_mbuf_dynfield](@ref rte_node_mbuf_dynfield.h)
- **basic**:
[bitops](@ref rte_bitops.h),
[approx fraction](@ref rte_approx.h),
diff --git a/doc/guides/rel_notes/release_25_07.rst
b/doc/guides/rel_notes/release_25_07.rst
index cd1025aac0..72d5d88ff3 100644
--- a/doc/guides/rel_notes/release_25_07.rst
+++ b/doc/guides/rel_notes/release_25_07.rst
@@ -55,6 +55,12 @@ New Features
Also, make sure to start the actual text at the margin.
===
+* **Added rte_node specific global mbuf dynamic field.**
+
+ Instead each node registering mbuf dynamic field for its own purpose, a
+ global structure is added which can be used/overloaded by all nodes
+ (including out-of-tree nodes). This minimizes footprint of node specific mbuf
+ dynamic field.
Removed Items
-
diff --git a/lib/node/meson.build b/lib/node/meson.build
index 0bed97a96c..4330d0450b 100644
--- a/lib/node/meson.build
+++ b/lib/node/meson.build
@@ -8,6 +8,7 @@ if is_windows
endif
sources = files(
+'node_mbuf_dynfield.c',
'ethdev_ctrl.c',
'ethdev_rx.c',
'ethdev_tx.c',
@@ -30,6 +31,7 @@ headers = files(
'rte_node_ip4_api.h',
'rte_node_ip6_api.h',
'rte_node_udp4_input_api.h',
+'rte_node_mbuf_dynfield.h'
)
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
diff --git a/lib/node/node_mbuf_dynfield.c b/lib/node/node_mbuf_dynfield.c
new file mode 100644
index 00..082918ae96
--- /dev/null
+++ b/lib/node/node_mbuf_dynfield.c
@@ -0,0 +1,44 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2025 Marvell International Ltd.
+ */
+#include
+#include
+#include
+
+#define NODE_MBUF_DYNFIELD_MEMZONE_NAME "__rte_node_mbuf_dynfield"
+
+struct node_mbuf_dynfield_mz {
+ int dynfield_offset;
+};
+
+static const struct rte_mbuf_dynfield node_mbuf_dynfield_desc = {
+ .name = "rte_node_mbuf_dynfield",
+ .size = sizeof(rte_node_mbuf_dynfield_t),
+ .align = alignof(rte_node_mbuf_dynfield_t),
+};
+
+int node_mbuf_dynfield_offset = -1;
+
+int rte_node_mbuf_dynfield_register(void)
+{
+ int dyn_offset;
+
+ RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_dynfield_t) <
RTE_NODE_MBUF_DYNFIELD_SIZE);
+ RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_overload_fields_t) <
+RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE);
+
+ if (node_mbuf_dynfield_offset == -1) {
+ dyn_offset =
rte_mbuf_dynfield_register(&node_mbuf_dynfield_desc);
+ if (dyn_offset < 0) {
+ node_err("node_mbuf_dyn", "rte_mbuf_dynfield_register
failed");
+ return -1;
+ }
+ node_mbuf_dynfield_offset = dyn_offset;
+
+ node_dbg("node_mbuf_dyn", "node mbuf dynfield size %zu at
offset: %d",
+ sizeof(rte_node_mbuf_dynfield_t),
node_mbuf_dynfield_offset);
+ } else {
+ dyn_offset = node_mbuf_dynfield_offset;
+ }
+ return dyn_offset;
+}
diff --git a/lib/node/rte_node_mbuf_dynfield.h
b/lib/node/rte_node_mbuf_dynfield.h
new file mode 100644
index 00..4293b3823d
--- /dev/null
+++ b/lib/node/rte_node_mbuf_dynfield.h
@@ -0,0 +1,132 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2025 Marvell International Ltd.
+ */
+
+#ifndef _RTE_GRAPH_MBUF_DYNFIELD_H_
+#define _RTE_GRAPH_MBUF_DYNFIELD_H_
+
+#include
+#include
+#include
+
+/**
+ * @file: rte_node_mbuf_dynfield.h
+ *
+ * Defines rte_node specific mbuf dynamic field region
[rte_node_mbuf_dynfield_t] which
[PATCH v3 0/2] node: add mbuf dynamic field for nodes
Currently each rte_node registers separate mbuf dynamic fields for their own purpose. This leads to wastage of mbuf space as once mbuf get passed a particular node, the registered dynamic field(by that node) is no longer used. This patch series adds a global/common mbuf dynamic field which is reusable by all the nodes(including out-of-tree nodes). This helps to repurpose same mbuf dynamic field for other nodes. It contains two types of fields: (a) persistent (b) overloadable. While persistent fields are those which does not often changes during a graph walk such as rx/tx interface, buffer flags etc. Currently there are no persistent fields added but they can be added later Overloadable fields are those which can be overloaded by two adjacent nodes. Overloadable fields can be repurposed by other two adjacent nodes. This patch series also updates ip4/ip6 lookup/rewrite nodes to use overlaodable mbuf dynamic fields. Changes in v3: - Fix CI build error Changes in v2: - removed usage of memzone for saving mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node/ip4_rewrite.c | 15 ++- lib/node/ip6_lookup.c | 15 ++- lib/node/ip6_rewrite.c | 14 +-- lib/node/meson.build | 2 + lib/node/node_mbuf_dynfield.c | 44 lib/node/node_private.h| 40 +-- lib/node/rte_node_mbuf_dynfield.h | 141 + lib/node/version.map | 3 + 11 files changed, 223 insertions(+), 74 deletions(-) create mode 100644 lib/node/node_mbuf_dynfield.c create mode 100644 lib/node/rte_node_mbuf_dynfield.h -- 2.43.0
Re: [PATCH v7 5/8] build: mark exported symbols
On 4/4/25 08:48, Hemant Agrawal wrote: for DPAA/FSLMC changes Acked-by: Hemant Agrawal For common/sfc_efx: Acked-by: Andrew Rybchenko
Re: [PATCH v12 10/10] drivers: remove use of term sanity check
On 4/3/25 02:23, Stephen Hemminger wrote: Don't use term "sanity" because it is considered derogatory. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal For sfc: Acked-by: Andrew Rybchenko
Re: [PATCH v7 5/8] build: mark exported symbols
On 4/3/25 19:58, David Marchand wrote: Annotate symbols with newly introduced export macros. For code not compiled via drivers/meson.build (think base drivers code), the exported symbols are added in some new XX_base_symbols.c file added to the sources variable so they get caught by drivers/meson.build. Signed-off-by: David Marchand For common/sfc_efx: Acked-by: Andrew Rybchenko
Re: [PATCH 1/2] node: add global node mbuf dynfield
Hi Stephen,
Thanks for commenting. See response inline.
Regards,
Nitin
On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger
wrote:
>
> On Tue, 1 Apr 2025 09:50:46 +0530
> Nitin Saxena wrote:
>
> > +int rte_node_mbuf_dynfield_register(void)
> > +{
> > + struct node_mbuf_dynfield_mz *f = NULL;
> > + const struct rte_memzone *mz = NULL;
> > + int dyn_offset;
> > +
> > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_dynfield_t) <
> > RTE_NODE_MBUF_DYNFIELD_SIZE);
> > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_overload_fields_t) <
> > + RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE);
> > +
> > + mz = rte_memzone_lookup(NODE_MBUF_DYNFIELD_MEMZONE_NAME);
>
> Seems wasteful to have a whole memzone for this, the data is small.
> Is there a reason it could not just be a global variable like timestamp.
>
Replaced usage of memzone with global variable in v2
> I would prefer this was a clone of timestamp code, and put in
> rte_mbuf_dynfield.c
rte_node_mbuf_dynfield_register() is local to graph based rte_nodes
and it is not targeted to be used by non-graph based applications
Do you still think we should move this API definition to rte_mbuf_dyn.c?
Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs
21/03/2025 10:20, Mcnamara, John: > > Subject: [PATCH V1] doc: add tested Intel platforms with Intel NICs > > > > Add tested Intel platforms with Intel NICs to v25.03 release note. > > Acked-by: John McNamara Applied, thanks.
[PATCH v2 1/2] eal: fix uncheck worker ID
The worker_id may come from user input.
So it is necessary to verify it.
Fixes: a95d70547c57 ("eal: factorize lcore main loop")
Cc: sta...@dpdk.org
Signed-off-by: Dengdui Huang
---
lib/eal/common/eal_common_launch.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/eal/common/eal_common_launch.c
b/lib/eal/common/eal_common_launch.c
index 5320c3bd3c..76313d5cdf 100644
--- a/lib/eal/common/eal_common_launch.c
+++ b/lib/eal/common/eal_common_launch.c
@@ -35,6 +35,9 @@ rte_eal_remote_launch(lcore_function_t *f, void *arg,
unsigned int worker_id)
{
int rc = -EBUSY;
+ if (!rte_lcore_has_role(worker_id, ROLE_RTE))
+ return -EINVAL;
+
/* Check if the worker is in 'WAIT' state. Use acquire order
* since 'state' variable is used as the guard variable.
*/
--
2.33.0
[PATCH v3 1/4] net/intel: use common Tx queue structure
Merge in additional fields used by the idpf driver and then convert it
over to using the common Tx queue structure.
Signed-off-by: Shaiq Wani
---
drivers/net/intel/common/tx.h | 18 ++
drivers/net/intel/cpfl/cpfl_ethdev.c | 2 +-
drivers/net/intel/cpfl/cpfl_ethdev.h | 2 +-
drivers/net/intel/cpfl/cpfl_rxtx.c| 26 -
drivers/net/intel/cpfl/cpfl_rxtx.h| 2 +-
drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h | 2 +-
drivers/net/intel/idpf/idpf_common_rxtx.c | 24
drivers/net/intel/idpf/idpf_common_rxtx.h | 56 +++
.../net/intel/idpf/idpf_common_rxtx_avx2.c| 6 +-
.../net/intel/idpf/idpf_common_rxtx_avx512.c | 20 +++
drivers/net/intel/idpf/idpf_common_virtchnl.c | 2 +-
drivers/net/intel/idpf/idpf_common_virtchnl.h | 2 +-
drivers/net/intel/idpf/idpf_ethdev.c | 2 +-
drivers/net/intel/idpf/idpf_rxtx.c| 22
drivers/net/intel/idpf/idpf_rxtx_vec_common.h | 4 +-
15 files changed, 82 insertions(+), 108 deletions(-)
diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..49722026de 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -35,6 +35,7 @@ struct ci_tx_queue {
volatile struct i40e_tx_desc *i40e_tx_ring;
volatile struct iavf_tx_desc *iavf_tx_ring;
volatile struct ice_tx_desc *ice_tx_ring;
+ volatile struct idpf_base_tx_desc *idpf_tx_ring;
volatile union ixgbe_adv_tx_desc *ixgbe_tx_ring;
};
volatile uint8_t *qtx_tail; /* register address of tail */
@@ -98,6 +99,23 @@ struct ci_tx_queue {
uint8_t wthresh; /**< Write-back threshold reg. */
uint8_t using_ipsec; /**< indicates that IPsec TX
feature is in use */
};
+ struct { /* idpf specific values */
+ volatile union {
+ struct idpf_flex_tx_sched_desc *desc_ring;
+ struct idpf_splitq_tx_compl_desc *compl_ring;
+ };
+ bool q_started;
+ const struct idpf_txq_ops *idpf_ops;
+ struct ci_tx_queue *complq;
+ /* only valid for split queue mode */
+ void **txqs;
+ uint32_t tx_start_qid;
+ uint16_t sw_nb_desc;
+ uint16_t sw_tail;
+ uint8_t expected_gen_id;
+#define IDPF_TX_CTYPE_NUM 8
+ uint16_t ctype[IDPF_TX_CTYPE_NUM];
+ };
};
};
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c
b/drivers/net/intel/cpfl/cpfl_ethdev.c
index 1817221652..2f071082e1 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.c
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
@@ -1167,7 +1167,7 @@ cpfl_hairpin_get_peer_ports(struct rte_eth_dev *dev,
uint16_t *peer_ports,
{
struct cpfl_vport *cpfl_vport =
(struct cpfl_vport *)dev->data->dev_private;
- struct idpf_tx_queue *txq;
+ struct ci_tx_queue *txq;
struct idpf_rx_queue *rxq;
struct cpfl_tx_queue *cpfl_txq;
struct cpfl_rx_queue *cpfl_rxq;
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.h
b/drivers/net/intel/cpfl/cpfl_ethdev.h
index 9a38a69194..d4e1176ab1 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.h
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.h
@@ -174,7 +174,7 @@ struct cpfl_vport {
uint16_t nb_p2p_txq;
struct idpf_rx_queue *p2p_rx_bufq;
- struct idpf_tx_queue *p2p_tx_complq;
+ struct ci_tx_queue *p2p_tx_complq;
bool p2p_manual_bind;
};
diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c
b/drivers/net/intel/cpfl/cpfl_rxtx.c
index 47351ca102..cf4320df0c 100644
--- a/drivers/net/intel/cpfl/cpfl_rxtx.c
+++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
@@ -11,7 +11,7 @@
#include "cpfl_rxtx_vec_common.h"
static inline void
-cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
+cpfl_tx_hairpin_descq_reset(struct ci_tx_queue *txq)
{
uint32_t i, size;
@@ -26,7 +26,7 @@ cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
}
static inline void
-cpfl_tx_hairpin_complq_reset(struct idpf_tx_queue *cq)
+cpfl_tx_hairpin_complq_reset(struct ci_tx_queue *cq)
{
uint32_t i, size;
@@ -320,7 +320,7 @@ static void
cpfl_tx_queue_release(void *txq)
{
struct cpfl_tx_queue *cpfl_txq = txq;
- struct idpf_tx_queue *q = NULL;
+ struct ci_tx_queue *q = NULL;
if (cpfl_txq == NULL)
return;
@@ -468,18 +468,18 @@ cpfl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t
queue_idx,
}
static int
-cpfl_tx_complq_setup(struct rte_eth_dev *dev, struct idpf_tx_queue *txq,
+cpfl_tx_complq_setup(struct rte_eth_dev *dev, struct ci_tx_queue *txq,
uint16_
[PATCH v4 02/11] net/intel: use common AVX build code
Remove driver-specific build instructions for the AVX2 and AVX-512 code,
and rely instead on the generic driver build file.
Signed-off-by: Bruce Richardson
---
drivers/net/intel/i40e/meson.build | 26 ++
drivers/net/intel/iavf/meson.build | 25 ++---
drivers/net/intel/ice/meson.build | 25 ++---
drivers/net/intel/idpf/meson.build | 25 ++---
4 files changed, 8 insertions(+), 93 deletions(-)
diff --git a/drivers/net/intel/i40e/meson.build
b/drivers/net/intel/i40e/meson.build
index 15993393fb..dae61222cf 100644
--- a/drivers/net/intel/i40e/meson.build
+++ b/drivers/net/intel/i40e/meson.build
@@ -40,31 +40,9 @@ includes += include_directories('base')
if arch_subdir == 'x86'
sources += files('i40e_rxtx_vec_sse.c')
+sources_avx2 += files('i40e_rxtx_vec_avx2.c')
+sources_avx512 += files('i40e_rxtx_vec_avx512.c')
-i40e_avx2_lib = static_library('i40e_avx2_lib',
-'i40e_rxtx_vec_avx2.c',
-dependencies: [static_rte_ethdev, static_rte_kvargs,
static_rte_hash],
-include_directories: includes,
-c_args: [cflags, cc_avx2_flags])
-objs += i40e_avx2_lib.extract_objects('i40e_rxtx_vec_avx2.c')
-
-if cc_has_avx512
-cflags += ['-DCC_AVX512_SUPPORT']
-avx512_args = cflags + cc_avx512_flags
-if cc.has_argument('-march=skylake-avx512')
-avx512_args += '-march=skylake-avx512'
-if cc.has_argument('-Wno-overriding-option')
-avx512_args += '-Wno-overriding-option'
-endif
-endif
-i40e_avx512_lib = static_library('i40e_avx512_lib',
-'i40e_rxtx_vec_avx512.c',
-dependencies: [static_rte_ethdev,
-static_rte_kvargs, static_rte_hash],
-include_directories: includes,
-c_args: avx512_args)
-objs += i40e_avx512_lib.extract_objects('i40e_rxtx_vec_avx512.c')
-endif
elif arch_subdir == 'ppc'
sources += files('i40e_rxtx_vec_altivec.c')
elif arch_subdir == 'arm'
diff --git a/drivers/net/intel/iavf/meson.build
b/drivers/net/intel/iavf/meson.build
index 833a63e6c8..1ca500c43c 100644
--- a/drivers/net/intel/iavf/meson.build
+++ b/drivers/net/intel/iavf/meson.build
@@ -28,30 +28,9 @@ includes += include_directories('base')
if arch_subdir == 'x86'
sources += files('iavf_rxtx_vec_sse.c')
+sources_avx2 += files('iavf_rxtx_vec_avx2.c')
+sources_avx512 += files('iavf_rxtx_vec_avx512.c')
-iavf_avx2_lib = static_library('iavf_avx2_lib',
-'iavf_rxtx_vec_avx2.c',
-dependencies: [static_rte_ethdev],
-include_directories: includes,
-c_args: [cflags, cc_avx2_flags])
-objs += iavf_avx2_lib.extract_objects('iavf_rxtx_vec_avx2.c')
-
-if cc_has_avx512
-cflags += ['-DCC_AVX512_SUPPORT']
-avx512_args = cflags + cc_avx512_flags
-if cc.has_argument('-march=skylake-avx512')
-avx512_args += '-march=skylake-avx512'
-if cc.has_argument('-Wno-overriding-option')
-avx512_args += '-Wno-overriding-option'
-endif
-endif
-iavf_avx512_lib = static_library('iavf_avx512_lib',
-'iavf_rxtx_vec_avx512.c',
-dependencies: [static_rte_ethdev],
-include_directories: includes,
-c_args: avx512_args)
-objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c')
-endif
elif arch_subdir == 'arm'
sources += files('iavf_rxtx_vec_neon.c')
endif
diff --git a/drivers/net/intel/ice/meson.build
b/drivers/net/intel/ice/meson.build
index 4d8f71cd4a..fa6c505450 100644
--- a/drivers/net/intel/ice/meson.build
+++ b/drivers/net/intel/ice/meson.build
@@ -34,30 +34,9 @@ endif
if arch_subdir == 'x86'
sources += files('ice_rxtx_vec_sse.c')
+sources_avx2 += files('ice_rxtx_vec_avx2.c')
+sources_avx512 += files('ice_rxtx_vec_avx512.c')
-ice_avx2_lib = static_library('ice_avx2_lib',
-'ice_rxtx_vec_avx2.c',
-dependencies: [static_rte_ethdev, static_rte_hash],
-include_directories: includes,
-c_args: [cflags, cc_avx2_flags])
-objs += ice_avx2_lib.extract_objects('ice_rxtx_vec_avx2.c')
-
-if cc_has_avx512
-cflags += ['-DCC_AVX512_SUPPORT']
-avx512_args = cflags + cc_avx512_flags
-if cc.has_argument('-march=skylake-avx512')
-avx512_args += '-march=skylake-avx512'
-if cc.has_argument('-Wno-overriding-option')
-avx512_args += '-Wno-overriding-option'
-endif
-endif
-ice_avx512_lib = static_library('ice_avx512_lib',
-'ice_rxtx_vec_avx512.c',
-dependencies: [static_rte_ethdev, static_rte_hash],
-include_directories: includes,
-c_args: avx512_args)
-objs += ice_avx512_lib.
[DPDK/other Bug 183] Problem using cloned rte_mbuf buffers with KNI interface
https://bugs.dpdk.org/show_bug.cgi?id=183 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||step...@networkplumber.org Resolution|--- |WONTFIX --- Comment #8 from Stephen Hemminger (step...@networkplumber.org) --- KNI is no longer supported, will not be fixed. -- You are receiving this mail because: You are the assignee for the bug.
Re: DPDK for rust
27/03/2025 17:17, Bruce Richardson: > On Thu, Mar 27, 2025 at 11:00:40AM +0200, Etelson, Gregory wrote: > > Hello Morten, > > > > Thank you for raising these questions ! > > > > > > > > Do we want the DPDK project itself to support rust? > > > Or should parts of this be a DPDK hosted project, like grout? > > > > Rust packages management is different. > > Also DPDK Rust code will eventually provide a different API. > > At this stage, DPDK hosted project looks like a good idea. > > > > For ease of use, that would mean hosting a cargo registry, no? Please could you explain why it is easier to have a cargo registry?
Re: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield
On Fri, 4 Apr 2025 08:11:07 +
Pavan Nikhilesh Bhagavatula wrote:
> > Hi Stephen,
> >
> > Thanks for commenting. See response inline.
> >
> > Regards,
> > Nitin
> >
> > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger
> > wrote:
> > >
> > > On Tue, 1 Apr 2025 09:50:46 +0530
> > > Nitin Saxena wrote:
> > >
> > > > +int rte_node_mbuf_dynfield_register(void)
> > > > +{
> > > > + struct node_mbuf_dynfield_mz *f = NULL;
> > > > + const struct rte_memzone *mz = NULL;
> > > > + int dyn_offset;
> > > > +
> > > > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_dynfield_t) <
> > RTE_NODE_MBUF_DYNFIELD_SIZE);
> > > > + RTE_BUILD_BUG_ON(sizeof(rte_node_mbuf_overload_fields_t) <
> > > > + RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE);
> > > > +
> > > > + mz =
> > rte_memzone_lookup(NODE_MBUF_DYNFIELD_MEMZONE_NAME);
> > >
> > > Seems wasteful to have a whole memzone for this, the data is small.
> > > Is there a reason it could not just be a global variable like timestamp.
> > >
> > Replaced usage of memzone with global variable in v2
>
> We need to use memzone to share the offset between primary and secondary
> processes I don’t see any other way.
Normally secondary just uses dynamic field lookup to find the offset.
[PATCH 09/10] net/txgbe: use common base code build handling
Use the base code build handling logic in the drivers/meson.build file,
rather than re-implementing it in the driver itself.
Signed-off-by: Bruce Richardson
---
drivers/net/txgbe/base/meson.build | 18 ++
drivers/net/txgbe/meson.build | 3 ---
2 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/net/txgbe/base/meson.build
b/drivers/net/txgbe/base/meson.build
index 4cf90a394a..0bb0782c92 100644
--- a/drivers/net/txgbe/base/meson.build
+++ b/drivers/net/txgbe/base/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2015-2020 Beijing WangXun Technology Co., Ltd.
-sources = [
+base_sources = files(
'txgbe_dcb_hw.c',
'txgbe_dcb.c',
'txgbe_eeprom.c',
@@ -10,18 +10,4 @@ sources = [
'txgbe_mng.c',
'txgbe_phy.c',
'txgbe_vf.c',
-]
-
-error_cflags = []
-
-c_args = cflags
-foreach flag: error_cflags
-if cc.has_argument(flag)
-c_args += flag
-endif
-endforeach
-
-base_lib = static_library('txgbe_base', sources,
-dependencies: [static_rte_eal, static_rte_net, static_rte_bus_pci],
-c_args: c_args)
-base_objs = base_lib.extract_all_objects(recursive: true)
+)
diff --git a/drivers/net/txgbe/meson.build b/drivers/net/txgbe/meson.build
index d9ca3743e2..4dbbf597bb 100644
--- a/drivers/net/txgbe/meson.build
+++ b/drivers/net/txgbe/meson.build
@@ -8,7 +8,6 @@ if is_windows
endif
subdir('base')
-objs = [base_objs]
sources = files(
'txgbe_ethdev.c',
@@ -32,6 +31,4 @@ elif arch_subdir == 'arm'
sources += files('txgbe_rxtx_vec_neon.c')
endif
-includes += include_directories('base')
-
install_headers('rte_pmd_txgbe.h')
--
2.45.2
Re: [PATCH v12 07/10] dts: replace use of sanity check in comment
Unfortunately I do find myself saying sanity check often... something to
cut out from my vocabulary. From a quick google it looks like many are
using coherence check in its place, or just explicitly writing out what the
check is as you did.
It would also probably be fine to just remove the comment entirely given
the assert immediately following it also contains its own explanation of
the check. But, I guess the original author thought it was useful to have
the comment, so we can keep it.
Reviewed-by: Patrick Robb
On Wed, Apr 2, 2025 at 7:24 PM Stephen Hemminger
wrote:
> Replace with better words.
>
> Signed-off-by: Stephen Hemminger
> ---
> dts/tests/TestSuite_blocklist.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/tests/TestSuite_blocklist.py
> b/dts/tests/TestSuite_blocklist.py
> index ce7da1cc8f..82109f72a1 100644
> --- a/dts/tests/TestSuite_blocklist.py
> +++ b/dts/tests/TestSuite_blocklist.py
> @@ -22,7 +22,7 @@ def verify_blocklisted_ports(self, ports_to_block:
> list[Port]):
> allowlisted_ports = {port.device_name for port in
> testpmd.show_port_info_all()}
> blocklisted_ports = {port.pci for port in ports_to_block}
>
> -# sanity check
> +# ensure at least one port is allowed
> allowed_len = len(allowlisted_ports - blocklisted_ports)
> self.verify(allowed_len > 0, "At least one port should have
> been allowed")
>
> --
> 2.47.2
>
>
Re: 24.11.2 patches review and test
I tested below 18 scenarios on RHEL 9.2 hosts and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput testing: PASS - PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS - PVP vhost-user 2Q throughput testing: PASS - PVP vhost-user 1Q - cross numa node throughput testing: PASS - VM with vhost-user 2 queues throughput testing: PASS - vhost-user reconnect with dpdk-client, qemu-server(qemu reconnect): PASS - vhost-user reconnect with dpdk-client, qemu-server(ovs reconnect): PASS - PVP reconnect with dpdk-client, qemu-server: PASS - PVP 1Q live migration testing: PASS - PVP 1Q cross numa node live migration testing: PASS - VM with ovs+dpdk+vhost-user 1Q live migration testing: PASS - VM with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS - VM with ovs+dpdk+vhost-user 2Q live migration testing: PASS - VM with ovs+dpdk+vhost-user 4Q live migration testing: PASS - Host PF + DPDK testing: PASS - Host VF + DPDK testing: PASS Test Versions: - qemu-kvm-7.2.0 - kernel 5.14 - libvirt 9.0 - ovs 3.1 - git log commit 03f2ed63a5f4e4b57365e358b49095ef4a82cf7d Author: Kevin Traynor Date: Wed Mar 26 17:10:40 2025 + version: 24.11.2-rc1 Signed-off-by: Kevin Traynor - Test device : X540-AT2 NIC(ixgbe, 10G) Tested-by: Yanghang Liu Best Regards, Yanghang Liu On Fri, Mar 28, 2025 at 6:14 PM Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 24.11.2. > > The planned date for the final release is 14 April. > > Please help with testing and validation of your use cases and report > any issues/results with reply-all to this mail. For the final release > the fixes and reported validations will be added to the release notes. > > A release candidate tarball can be found at: > > https://dpdk.org/browse/dpdk-stable/tag/?id=v24.11.2-rc1 > > These patches are located at branch 24.11 of dpdk-stable repo: > https://dpdk.org/browse/dpdk-stable/ > > Thanks. > > Kevin > > --- > Ajit Khaparde (2): > net/bnxt: fix Rx handler > net/bnxt: fix epoch bit calculation > > Aleksandr Loktionov (2): > net/igc/base: fix MAC address hash bit shift > net/e1000/base: fix MAC address hash bit shift > > Alex Vesker (1): > net/mlx5/hws: fix DV FT type convert > > Alexander Kozyrev (1): > net/mlx5/hws: fix fragmented packet type matching > > Amir Avivi (2): > net/igc/base: fix iterator type > net/e1000/base: fix iterator type > > Anatoly Burakov (4): > net/e1000/base: correct mPHY access logic > net/e1000: fix crashes in secondary processes > net/ixgbe: fix crashes in secondary processes > doc: add no-IOMMU mode in devbind tool guide > > Andre Muezerie (6): > eal/x86: fix some intrinsics header include for Windows > eventdev: fix format string data type in log messages > net/bnxt: fix indication of allocation > common/idpf: fix void function returning a value > net/intel: fix void functions returning a value > stack: fix pop in C11 implementation > > Andrew Boyer (1): > doc: update ionic driver guide > > Ariel Otilibili (8): > examples/flow_filtering: remove duplicate assignment > net/sfc: remove unnecessary assignment > net/octeon_ep: remove useless assignment > net/enetfec: remove useless assignment > buildtools: fix some Python regex syntax warnings > use Python raw string notation > eal/linux: remove useless assignments > mempool: fix errno in empty create > > Arkadiusz Kusztal (3): > test/crypto: fix check for OOP header data > crypto/qat: fix SM3 state size > common/qat: fix devargs parsing > > Barbara Skobiej (3): > net/igc/base: fix data type in MAC hash > net/e1000/base: fix data type in MAC hash > net/e1000/base: fix reset for 82580 > > Bing Zhao (3): > net/mlx5: fix leak of flow action data list > net/mlx5: fix unneeded stub flow table allocation > net/mlx5: fix flow group ID for action translation > > Bruce Richardson (9): > net/iavf: remove reset of Tx prepare function pointer > net/intel: fix build with icx > event/dlb2: fix event weight handling in SSE code path > test/dma: fix pointers in IOVA as PA mode > net/iavf: check interrupt registration failure > net/iavf: fix crash on app exit on FreeBSD > eal: fix undetected NUMA nodes > net/ixgbe: add checks for E610 VF > dma/idxd: add device ids for new HW versions > > Carolyn Wyborny (1): > net/e1000/base: skip management check for 82575 > > Chaoyong He (2): > net/nfp: fix firmware load from flash > net/nfp: fix init failure handling > > Chengwen Feng (2): > app/testpmd: sho
[PATCH] net/nfp: fix the hash key length logic problem
There does not exist an API for driver to get/set the hash key length
from/to the firmware.
---
#define NFP_NET_CFG_RSS_KEY_SZ 0x28
#define NFP_NET_CFG_MACADDR 0x0024
---
The original logic try to use the 'NFP_NET_CFG_RSS_KEY_SZ' as the
inexistent API, read from this address will get wrong hash key length
and write to this address will overwrite the MAC address unexpected,
which will cause very strange problem.
Fixes: 934e4c60fbff ("nfp: add RSS")
Cc: sta...@dpdk.org
Signed-off-by: Chaoyong He
Reviewed-by: Peng Zhang
---
drivers/net/nfp/nfp_net_common.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index aaa515bac2..62550e4cad 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -1966,9 +1966,6 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev,
/* Configuring where to apply the RSS hash */
nn_cfg_writel(hw, NFP_NET_CFG_RSS_CTRL, cfg_rss_ctrl);
- /* Writing the key size */
- nn_cfg_writeb(hw, NFP_NET_CFG_RSS_KEY_SZ, rss_conf->rss_key_len);
-
return 0;
}
@@ -2059,7 +2056,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,
rss_conf->rss_hf = rss_hf;
/* Reading the key size */
- rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);
+ rss_conf->rss_key_len = NFP_NET_CFG_RSS_KEY_SZ;
/* Reading the key byte a byte */
for (i = 0; i < rss_conf->rss_key_len; i++) {
--
2.43.5
Migrate DPDK 18.05.1 -> DPDK 24.11.1 LTS
Hi, In the 24.11.1 build, I have specific questions 1) I need the DPDK output in static lib format. How can I switch off the shared lib build? 2) I need to build librte_kni. a - Is this module deprecated in DPDK 24.11.1 3) How can I enable librte_pmd_* modules? In the driver/net folder, many pmd are available, but none of them are built in the default ninja build.? How to enable this? I used the build steps listed below cd dpdk meson build ninja -C build Will you please help?
[DPDK/vhost/virtio Bug 1685] [dpdk-22.11.8RC1] virtio_ipsec_cryptodev_func/test_aesni_mb_aes_cbc_sha1_hmac: dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu
https://bugs.dpdk.org/show_bug.cgi?id=1685 Bug ID: 1685 Summary: [dpdk-22.11.8RC1] virtio_ipsec_cryptodev_func/test_aesni_mb_aes_cbc_sha1 _hmac: dpdk-vhost_crypto Segmentation fault (core dumped) when launch qemu Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: vhost/virtio Assignee: dev@dpdk.org Reporter: yux.ji...@intel.com Target Milestone: --- [Environment] DPDK version: commit 684d996a20 (HEAD -> v22.11.8-rc1, tag: v22.11.8-rc1, origin/22.11) version: 22.11.8-rc1 OS: Ubuntu 18.04.5 LTS (Bionic Beaver); 5.4.0-150-generic Compiler: gcc version 7.5.0 Hardware platform: Intel(R) Xeon(R) Platinum 8180 CPU @ 2.50GHz QEMU: qemu-2.12 qemu version >= 2.12 in qemu enable vhost-user-crypto: ./configure --target-list=x86_64-softmmu --enable-vhost-crypto --prefix=/root/qemu-2.12 && make && make install Qemu version: 2.12 QAT: C62x Chipset QuickAssist Technology 37c8 [Test Setup] Steps to reproduce List the steps to reproduce the issue. 1, Build dpdk rm -rf x86_64-native-linuxapp-gcc CC=gcc meson --werror -Denable_kmods=False -Dlibdir=lib -Dexamples=all --default-library=static x86_64-native-linuxapp-gcc ninja -C x86_64-native-linuxapp-gcc -j 110 ls x86_64-native-linuxapp-gcc/examples/dpdk-vhost_crypto 2, Bind QAT device and run the dpdk vhost sample in HOST side usertools/dpdk-devbind.py --force --bind=vfio-pci :1a:01.0 :1c:01.0 :1e:01.0 x86_64-native-linuxapp-gcc/examples/dpdk-vhost_crypto -l 1,2,3,4,5 -a :1a:01.0 -a :1c:01.0 -a :1e:01.0 --vdev crypto_scheduler_pmd_1,worker=:1a:01.0_qat_sym,worker=:1c:01.0_qat_sym,worker=:1e:01.0_qat_sym,mode=round-robin,ordering=enable --socket-mem 2048,0 -n 4 -- --config "(2,0,0),(3,0,0),(4,0,0),(5,0,0)" --socket-file 2,/tmp/vm0_crypto0.sock --socket-file=3,/tmp/vm0_crypto1.sock --socket-file=4,/tmp/vm1_crypto0.sock --socket-file=5,/tmp/vm1_crypto1.sock 3, Bind NIC PF to vfio-pci usertools/dpdk-devbind.py --bind=vfio-pci :60:00.0 :60:00.1 :3b:00.0 :3b:00.1 4, Start VM0 by the qemu: taskset -c 11,12,13,14 /usr/local/qemu-2.12.0/bin/qemu-system-x86_64 -name vm0 -enable-kvm -pidfile /tmp/.vm0.pid -daemonize -monitor unix:/tmp/vm0_monitor.sock,server,nowait -device e1000,netdev=nttsip1 -netdev user,id=nttsip1,hostfwd=tcp:10.67.118.199:6410-:22 -device vfio-pci,host=:3b:00.0,id=pt_0 -device vfio-pci,host=:3b:00.1,id=pt_1 -cpu host -smp 4 -m 4096 -object memory-backend-file,id=mem,size=4096M,mem-path=/dev/hugepages,share=on -numa node,memdev=mem -mem-prealloc -chardev socket,path=/tmp/vm0_qga0.sock,server,nowait,id=vm0_qga0 -device virtio-serial -device virtserialport,chardev=vm0_qga0,name=org.qemu.guest_agent.0 -vnc :1 -chardev socket,path=/tmp/vm0_crypto0.sock,id=vm0_crypto0 -object cryptodev-vhost-user,id=cryptodev0,chardev=vm0_crypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 -chardev socket,path=/tmp/vm0_crypto1.sock,id=vm0_crypto1 -object cryptodev-vhost-user,id=cryptodev1,chardev=vm0_crypto1 -device virtio-crypto-pci,id=crypto1,cryptodev=cryptodev1 -drive file=/root/VMs/ubuntu2004-0.img [Actual Result] VM logs: root@dpdk-yaobing-purely147:~/dpdk# taskset -c 11,12,13,14 /usr/local/qemu-2.12.0/bin/qemu-system-x86_64 -name vm0 -enable-kvm -pidfile /tmp/.vm0.pid -daemonize -monitor unix:/tmp/vm0_monitor.sock,server,nowait -device e1000,netdev=nttsip1 -netdev user,id=nttsip1,hostfwd=tcp:10.67.118.199:6010-:22 -device vfio-pci,host=:3b:00.0,id=pt_0 -device vfio-pci,host=:3b:00.1,id=pt_1 -cpu host -smp 4 -m 4096 -object memory-backend-file,id=mem,size=4096M,mem-path=/dev/hugepages,share=on -numa node,memdev=mem -mem-prealloc -chardev socket,path=/tmp/vm0_qga0.sock,server,nowait,id=vm0_qga0 -device virtio-serial -device virtserialport,chardev=vm0_qga0,name=org.qemu.guest_agent.0 -vnc :1 -chardev socket,path=/tmp/vm0_crypto0.sock,id=vm0_crypto0 -object cryptodev-vhost-user,id=cryptodev0,chardev=vm0_crypto0 -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 -chardev socket,path=/tmp/vm0_crypto1.sock,id=vm0_crypto1 -object cryptodev-vhost-user,id=cryptodev1,chardev=vm0_crypto1 -device virtio-crypto-pci,id=crypto1,cryptodev=cryptodev1 -drive file=/root/VMs/ubuntu2004-0.img qemu-system-x86_64: -object cryptodev-vhost-user,id=cryptodev0,chardev=vm0_crypto0: Failed to read msg header. Read 0 instead of 12. Original request 1. qemu-system-x86_64: -object cryptodev-vhost-user,id=cryptodev0,chardev=vm0_crypto0: failed to init vhost_crypto for queue 0 DPDK VHOST sample HOST log: root@dpdk-yaobing-purely147:~/dpdk# x86_64-native-linuxapp-gcc/examples/dpdk-vhost_crypto -l 1,2,3,4,5 -a :1a:01.0 -a :1c:01.0 -a :1e:01.0 --vdev crypto_scheduler_pmd_1,worker=:1a:01.0_qat_sym,worker=:1c:0
Re: [PATCH 04/10] net/intel: use common base code build handling
On Wed, Apr 02, 2025 at 03:05:07PM +0200, David Marchand wrote:
> On Mon, Mar 31, 2025 at 6:10 PM Bruce Richardson
> wrote:
> > diff --git a/drivers/net/intel/ice/base/meson.build
> > b/drivers/net/intel/ice/base/meson.build
> > index e7ba9c34bc..f453005a1d 100644
> > --- a/drivers/net/intel/ice/base/meson.build
> > +++ b/drivers/net/intel/ice/base/meson.build
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: BSD-3-Clause
> > # Copyright(c) 2018-2021 Intel Corporation
> >
> > -sources = [
> > +base_sources = files(
> > 'ice_controlq.c',
> > 'ice_common.c',
> > 'ice_sched.c',
> > @@ -29,7 +29,7 @@ sources = [
> > 'ice_ddp.c',
> > 'ice_fwlog.c',
> > 'ice_vf_mbx.c',
> > -]
> > +)
> >
> > if is_ms_compiler
> > error_cflags = [
> > @@ -41,22 +41,14 @@ else
> > '-Wno-unused-but-set-variable',
> > '-Wno-unused-parameter',
> > ]
> > +# Bugzilla ID: 678
> > +#if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> > +#error_cflags += ['-Wno-array-bounds']
> > +#endif
>
> Why keep it commented?
>
>
This was an accidental change added in. In my testing with gcc 14, I
discovered that the warning flag was not necessary. However, I assume it is
still necessary for GCC 11 as originally added. I have not tested with a
range of GCC versions to be sure. Therefore, I'll just drop this diff in
next patch revision.
/Bruce
[PATCH 10/10] raw/ifpga: use common base code build handling
Use the base code build handling logic in the drivers/meson.build file,
rather than re-implementing it in the driver itself.
While making changes similar to that in other drivers, also move content
around dependencies from the base/meson.build file to the main
driver meson.build file, so that the base code file only contains the
list of base code files.
Signed-off-by: Bruce Richardson
---
drivers/raw/ifpga/base/meson.build | 21 ++---
drivers/raw/ifpga/meson.build | 15 ---
2 files changed, 14 insertions(+), 22 deletions(-)
diff --git a/drivers/raw/ifpga/base/meson.build
b/drivers/raw/ifpga/base/meson.build
index 2de8e7ea22..efebff94e9 100644
--- a/drivers/raw/ifpga/base/meson.build
+++ b/drivers/raw/ifpga/base/meson.build
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
-sources = [
+base_sources = files(
'ifpga_api.c',
'ifpga_enumerate.c',
'ifpga_feature_dev.c',
@@ -23,21 +23,4 @@ sources = [
'opae_i2c.c',
'opae_at24_eeprom.c',
'opae_eth_group.c',
-]
-
-rtdep = dependency('librt', required: false)
-if not rtdep.found()
-rtdep = cc.find_library('rt', required: false)
-endif
-if not rtdep.found()
-build = false
-reason = 'missing dependency, "librt"'
-subdir_done()
-endif
-
-ext_deps += rtdep
-
-base_lib = static_library('ifpga_rawdev_base', sources,
-dependencies: static_rte_eal,
-c_args: cflags)
-base_objs = base_lib.extract_all_objects(recursive: true)
+)
diff --git a/drivers/raw/ifpga/meson.build b/drivers/raw/ifpga/meson.build
index 444799cfb2..4295ec04bd 100644
--- a/drivers/raw/ifpga/meson.build
+++ b/drivers/raw/ifpga/meson.build
@@ -7,8 +7,19 @@ if not has_libfdt
subdir_done()
endif
+rtdep = dependency('librt', required: false)
+if not rtdep.found()
+rtdep = cc.find_library('rt', required: false)
+endif
+if not rtdep.found()
+build = false
+reason = 'missing dependency, "librt"'
+subdir_done()
+endif
+
+ext_deps += rtdep
+
subdir('base')
-objs = [base_objs]
deps += ['ethdev', 'rawdev', 'pci', 'bus_pci', 'kvargs',
'bus_vdev', 'bus_ifpga', 'net', 'net_i40e', 'net_ipn3ke']
@@ -17,6 +28,4 @@ sources = files('ifpga_rawdev.c', 'rte_pmd_ifpga.c',
'afu_pmd_core.c',
'afu_pmd_n3000.c', 'afu_pmd_he_lpbk.c', 'afu_pmd_he_mem.c',
'afu_pmd_he_hssi.c')
-includes += include_directories('base')
-
headers = files('rte_pmd_ifpga.h')
--
2.45.2
[PATCH v4 4/4] net/macb: add necessary docs and update related files
Added missing documentation in doc/guides/nics, mailmap entry, and updated MAINTAINERS file. Signed-off-by: liwencheng --- .mailmap | 1 + MAINTAINERS| 6 ++ doc/guides/nics/features/macb.ini | 27 +++ doc/guides/nics/index.rst | 1 + doc/guides/nics/macb.rst | 26 ++ doc/guides/rel_notes/release_25_03.rst | 5 + 6 files changed, 66 insertions(+) create mode 100644 doc/guides/nics/features/macb.ini create mode 100644 doc/guides/nics/macb.rst diff --git a/.mailmap b/.mailmap index d8439b7..001d7b2 100644 --- a/.mailmap +++ b/.mailmap @@ -1675,6 +1675,7 @@ Wen Chiu Wen-Chi Yang Wenfeng Liu Wenjie Li +Wencheng Li Wenjie Sun Wenjing Qiao Wenjun Wu diff --git a/MAINTAINERS b/MAINTAINERS index 4b01103..379645d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -920,6 +920,12 @@ F: doc/guides/platform/bluefield.rst F: doc/guides/nics/mlx5.rst F: doc/guides/nics/features/mlx5.ini +Phytium macb +M: Wencheng Li +F: drivers/net/macb +F: doc/guides/nics/macb.rst +F: doc/guides/nics/features/macb.ini + Microsoft mana M: Long Li M: Wei Hu diff --git a/doc/guides/nics/features/macb.ini b/doc/guides/nics/features/macb.ini new file mode 100644 index 000..cefc282 --- /dev/null +++ b/doc/guides/nics/features/macb.ini @@ -0,0 +1,27 @@ +; +; Supported features of the 'macb' network poll mode driver. +; +; Refer to default.ini for the full list of available PMD features. +; + +[Features] +Speed capabilities = Y +Link status = Y +Queue start/stop = Y +MTU update = Y +Allmulticast mode= Y +CRC offload = Y +L3 checksum offload = Y +L4 checksum offload = Y +Scattered Rx = Y +Rx descriptor status = Y +Basic stats = Y +Linux= Y + +[rte_flow items] +eth = Y +ipv4 = Y +ipv6 = Y +raw = Y +tcp = Y +udp = Y diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index 10a2eca..8ae1950 100644 --- a/doc/guides/nics/index.rst +++ b/doc/guides/nics/index.rst @@ -43,6 +43,7 @@ Network Interface Controller Drivers ionic ipn3ke ixgbe +macb mana memif mlx4 diff --git a/doc/guides/nics/macb.rst b/doc/guides/nics/macb.rst new file mode 100644 index 000..5614a63 --- /dev/null +++ b/doc/guides/nics/macb.rst @@ -0,0 +1,26 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright(c) 2022~2023 Phytium Technology Co., Ltd. + +MACB Poll Mode Driver += + +The MACB PMD provides poll mode driver support +for the Ethernet interface MAC 1/2.5/10 Gbps adapter. + +Supported Chipsets and NICs +--- + +Phytium Ethernet interface cdns,phytium-gem-1.0 +Phytium Ethernet interface cdns,phytium-gem-2.0 + +Features + + +Features of the MACB PMD are: + +* Speed capabilities +* Link status +* Tx Queue start/stop +* Multiple queues for TX and RX +* CRC offload +* Jumbo frames supported diff --git a/doc/guides/rel_notes/release_25_03.rst b/doc/guides/rel_notes/release_25_03.rst index 652562a..f53ccc9 100644 --- a/doc/guides/rel_notes/release_25_03.rst +++ b/doc/guides/rel_notes/release_25_03.rst @@ -127,6 +127,11 @@ New Features See the :doc:`../compressdevs/zsda` guide for more details on the new driver. +* **Added Phytium macb net driver.** + + Added a new network PMD which supports Phytium 1 and 10 Gigabit + Ethernet NICs. + * **Added atomic tests to the eventdev test application.** Added two atomic tests: ``atomic_queue`` and ``atomic_atq``. -- 2.7.4
[PATCH v6 6/8] build: use dynamically generated version maps
Switch to dynamically generated version maps.
As the map files get generated, tooling around checking, converting,
updating etc.. static version maps can be removed.
Signed-off-by: David Marchand
---
.github/workflows/build.yml | 1 -
MAINTAINERS | 7 -
buildtools/check-symbols.sh | 33 +-
buildtools/map-list-symbol.sh | 7 +-
buildtools/map_to_win.py | 41 ---
buildtools/meson.build| 1 -
devtools/check-symbol-change.sh | 186 ---
devtools/check-symbol-maps.sh | 101 --
devtools/checkpatches.sh | 2 +-
devtools/update-abi.sh| 46 ---
devtools/update_version_map_abi.py| 210
doc/guides/contributing/abi_policy.rst| 21 +-
doc/guides/contributing/coding_style.rst | 7 -
.../contributing/img/patch_cheatsheet.svg | 303 --
doc/guides/contributing/patches.rst | 6 +-
drivers/meson.build | 74 ++---
lib/meson.build | 73 ++---
17 files changed, 188 insertions(+), 931 deletions(-)
delete mode 100644 buildtools/map_to_win.py
delete mode 100755 devtools/check-symbol-change.sh
delete mode 100755 devtools/check-symbol-maps.sh
delete mode 100755 devtools/update-abi.sh
delete mode 100755 devtools/update_version_map_abi.py
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0cc4d12b0b..7a6b679fe5 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -31,7 +31,6 @@ jobs:
failed=
devtools/check-doc-vs-code.sh upstream/${{ env.REF_GIT_BRANCH }} ||
failed=true
devtools/check-meson.py || failed=true
-devtools/check-symbol-maps.sh || failed=true
[ -z "$failed" ]
ubuntu-vm-builds:
name: ${{ join(matrix.config.*, '-') }}
diff --git a/MAINTAINERS b/MAINTAINERS
index 42ea07854b..480972ef1e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -88,7 +88,6 @@ M: Thomas Monjalon
F: MAINTAINERS
F: devtools/build-dict.sh
F: devtools/check-abi.sh
-F: devtools/check-abi-version.sh
F: devtools/check-doc-vs-code.sh
F: devtools/check-dup-includes.sh
F: devtools/check-maintainers.sh
@@ -96,17 +95,13 @@ F: devtools/check-forbidden-tokens.awk
F: devtools/check-git-log.sh
F: devtools/check-spdx-tag.sh
F: devtools/check-symbol-change.py
-F: devtools/check-symbol-change.sh
-F: devtools/check-symbol-maps.sh
F: devtools/checkpatches.sh
F: devtools/get-maintainer.sh
F: devtools/git-log-fixes.sh
F: devtools/load-devel-config
F: devtools/parse-flow-support.sh
F: devtools/process-iwyu.py
-F: devtools/update-abi.sh
F: devtools/update-patches.py
-F: devtools/update_version_map_abi.py
F: devtools/libabigail.abignore
F: devtools/words-case.txt
F: license/
@@ -166,7 +161,6 @@ M: Tyler Retzlaff
F: lib/eal/common/
F: lib/eal/unix/
F: lib/eal/include/
-F: lib/eal/version.map
F: doc/guides/prog_guide/env_abstraction_layer.rst
F: app/test/test_alarm.c
F: app/test/test_atomic.c
@@ -396,7 +390,6 @@ Windows support
M: Dmitry Kozlyuk
M: Tyler Retzlaff
F: lib/eal/windows/
-F: buildtools/map_to_win.py
F: doc/guides/windows_gsg/
Windows memory allocation
diff --git a/buildtools/check-symbols.sh b/buildtools/check-symbols.sh
index b8ac24391e..0d6745ec14 100755
--- a/buildtools/check-symbols.sh
+++ b/buildtools/check-symbols.sh
@@ -7,29 +7,12 @@ OBJFILE=$2
ROOTDIR=$(readlink -f $(dirname $(readlink -f $0))/..)
LIST_SYMBOL=$ROOTDIR/buildtools/map-list-symbol.sh
-CHECK_SYMBOL_MAPS=$ROOTDIR/devtools/check-symbol-maps.sh
-
-# added check for "make -C test/" usage
-if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
-then
- exit 0
-fi
-
-if [ -d $MAPFILE ]
-then
- exit 0
-fi
-
DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XX)
trap 'rm -f "$DUMPFILE"' EXIT
objdump -t $OBJFILE >$DUMPFILE
ret=0
-if ! $CHECK_SYMBOL_MAPS $MAPFILE; then
- ret=1
-fi
-
for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`
do
if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE &&
@@ -37,8 +20,7 @@ do
$LIST_SYMBOL -s $SYM $MAPFILE | grep -q EXPERIMENTAL
then
cat >&2 <<- END_OF_MESSAGE
- $SYM is not flagged as experimental
- but is listed in version map
+ $SYM is not flagged as experimental but is exported as an
experimental symbol
Please add __rte_experimental to the definition of $SYM
END_OF_MESSAGE
ret=1
@@ -53,9 +35,8 @@ for SYM in `awk '{
do
$LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
cat >&2 <<- END_OF_MESSAGE
- $SYM is flagged as experimental
- but is not listed in version map
- Please add $SYM to the version map
+ $SYM is flagged as experimenta
[PATCH 0/2] dts: smoke test bugfixes
There are two smoke test bugfixes which have come in from our 25.03 DTS development and which should be resolved with this series. 1. The patchseries which we merged for 25.03 which added the testsuite specific configs inadvertently broke enabling smoke tests, as we build the tests config model using the test suite list coming in from the parsed test_run.yaml, before smoke_tests have been added. Then, later in the execution this produces a key error. I think that adding a placeholder smoke tests test suite config is the most reasonable solution to this. Users are unlikely to specify any test config for smoke tests as they don't require any, although if they happen to do so, I understand this change to be non-breaking (and I gave it a test run). 2. I am also seeing the smoke test which relies on regex on dpdk-devbind.py status output is failing on at least one of our systems currently. The fact that this broke is rather peculiar since regex syntax is obviously stable, and my reading of the current regex is that it "should" work. In any case, I simply changed the regex to a pattern which is more permissive and still captures the driver in use, which is what is needed for the testsuite. Patrick Robb (2): dts: include smoke tests in tests config dts: update dpdk-devbind script regex dts/framework/config/test_run.py | 3 +++ dts/tests/TestSuite_smoke_tests.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.48.1
[RFC PATCH 3/4] common/cnxk: provide port type from fwdata
Port type data is made available by firmware via CGX lmac specific
firmware data. Extract the same.
Signed-off-by: Nithin Dabilpuram
---
drivers/common/cnxk/hw/nix.h | 12
drivers/common/cnxk/roc_mbox.h| 4 ++--
drivers/common/cnxk/roc_nix.h | 1 +
drivers/common/cnxk/roc_nix_mac.c | 1 +
4 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/common/cnxk/hw/nix.h b/drivers/common/cnxk/hw/nix.h
index de989153ff..2aa23da037 100644
--- a/drivers/common/cnxk/hw/nix.h
+++ b/drivers/common/cnxk/hw/nix.h
@@ -2735,4 +2735,16 @@ enum cgx_mode {
CGX_MODE_MAX /* = 51 */
};
+/* CGX Port types from kernel */
+enum cgx_port_type {
+ CGX_PORT_TP = 0x0,
+ CGX_PORT_AUI,
+ CGX_PORT_MII,
+ CGX_PORT_FIBRE,
+ CGX_PORT_BNC,
+ CGX_PORT_DA,
+ CGX_PORT_NONE = 0xef,
+ CGX_PORT_OTHER = 0xff,
+};
+
#endif /* __NIX_HW_H__ */
diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
index 9038ca8fcf..1b0bfbc186 100644
--- a/drivers/common/cnxk/roc_mbox.h
+++ b/drivers/common/cnxk/roc_mbox.h
@@ -783,8 +783,8 @@ struct cgx_lmac_fwdata_s {
uint32_t __io lmac_type;
uint32_t __io portm_idx;
uint64_t __io mgmt_port : 1;
- uint64_t __io advertised_an : 1;
-#define LMAC_FWDATA_RESERVED_MEM 1019
+ uint64_t __io port;
+#define LMAC_FWDATA_RESERVED_MEM 1018
uint64_t __io reserved[LMAC_FWDATA_RESERVED_MEM];
};
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index c438a4447c..65778933dd 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -416,6 +416,7 @@ struct roc_nix_link_info {
struct roc_nix_mac_fwdata {
uint64_t advertised_link_modes;
uint64_t supported_link_modes;
+ uint64_t port_type;
};
/** Maximum name length for extended statistics counters */
diff --git a/drivers/common/cnxk/roc_nix_mac.c
b/drivers/common/cnxk/roc_nix_mac.c
index b99f93818a..026ff41ef2 100644
--- a/drivers/common/cnxk/roc_nix_mac.c
+++ b/drivers/common/cnxk/roc_nix_mac.c
@@ -436,6 +436,7 @@ roc_nix_mac_fwdata_get(struct roc_nix *roc_nix, struct
roc_nix_mac_fwdata *data)
nix->advertised_link_modes = fw_data->fwdata.advertised_link_modes;
data->supported_link_modes = nix->supported_link_modes;
data->advertised_link_modes = nix->advertised_link_modes;
+ data->port_type = fw_data->fwdata.port;
exit:
mbox_put(mbox);
return rc;
--
2.34.1
Re: [PATCH v3 1/2] node: add global node mbuf dynfield
On Fri, 4 Apr 2025 12:42:21 +0530 Nitin Saxena wrote: > diff --git a/lib/node/meson.build b/lib/node/meson.build > index 0bed97a96c..4330d0450b 100644 > --- a/lib/node/meson.build > +++ b/lib/node/meson.build > @@ -8,6 +8,7 @@ if is_windows > endif > > sources = files( > +'node_mbuf_dynfield.c', > 'ethdev_ctrl.c', > 'ethdev_rx.c', > 'ethdev_tx.c', > @@ -30,6 +31,7 @@ headers = files( > 'rte_node_ip4_api.h', > 'rte_node_ip6_api.h', > 'rte_node_udp4_input_api.h', > +'rte_node_mbuf_dynfield.h' > ) Github build is failing or this. Processing lib/node/meson.build Error: Missing trailing "," in list at lib/node/meson.build:3
[PATCH v2 1/3] eal: centralize core parameter parsing
Rather than parsing the lcore parameters as they are encountered, just
save off the lcore parameters and then parse them at the end. This
allows better knowledge of what parameters are available or not when
parsing.
Signed-off-by: Bruce Richardson
---
lib/eal/common/eal_common_options.c | 183 +---
1 file changed, 84 insertions(+), 99 deletions(-)
diff --git a/lib/eal/common/eal_common_options.c
b/lib/eal/common/eal_common_options.c
index 79db9a47dd..55c49a923f 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -151,7 +151,13 @@ TAILQ_HEAD_INITIALIZER(devopt_list);
static int main_lcore_parsed;
static int mem_parsed;
-static int core_parsed;
+static struct lcore_options {
+ const char *core_mask_opt;
+ const char *core_list_opt;
+ const char *core_map_opt;
+ const char *service_mask_opt;
+ const char *service_list_opt;
+} lcore_options = {0};
/* Allow the application to print its usage message too if set */
static rte_usage_hook_t rte_application_usage_hook;
@@ -674,7 +680,7 @@ eal_parse_service_coremask(const char *coremask)
if (count == 0)
return -1;
- if (core_parsed && taken_lcore_count != count) {
+ if (taken_lcore_count != count) {
EAL_LOG(WARNING,
"Not all service cores are in the coremask. "
"Please ensure -c or -l includes service cores");
@@ -684,17 +690,6 @@ eal_parse_service_coremask(const char *coremask)
return 0;
}
-static int
-eal_service_cores_parsed(void)
-{
- int idx;
- for (idx = 0; idx < RTE_MAX_LCORE; idx++) {
- if (lcore_config[idx].core_role == ROLE_SERVICE)
- return 1;
- }
- return 0;
-}
-
static int
update_lcore_config(int *cores)
{
@@ -903,7 +898,7 @@ eal_parse_service_corelist(const char *corelist)
if (count == 0)
return -1;
- if (core_parsed && taken_lcore_count != count) {
+ if (taken_lcore_count != count) {
EAL_LOG(WARNING,
"Not all service cores were in the coremask. "
"Please ensure -c or -l includes service cores");
@@ -1673,83 +1668,20 @@ eal_parse_common_option(int opt, const char *optarg,
a_used = 1;
break;
/* coremask */
- case 'c': {
- int lcore_indexes[RTE_MAX_LCORE];
-
- if (eal_service_cores_parsed())
- EAL_LOG(WARNING,
- "Service cores parsed before dataplane cores.
Please ensure -c is before -s or -S");
- if (rte_eal_parse_coremask(optarg, lcore_indexes) < 0) {
- EAL_LOG(ERR, "invalid coremask syntax");
- return -1;
- }
- if (update_lcore_config(lcore_indexes) < 0) {
- char *available = available_cores();
-
- EAL_LOG(ERR,
- "invalid coremask, please check specified cores
are part of %s",
- available);
- free(available);
- return -1;
- }
-
- if (core_parsed) {
- EAL_LOG(ERR, "Option -c is ignored, because (%s) is
set!",
- (core_parsed == LCORE_OPT_LST) ? "-l" :
- (core_parsed == LCORE_OPT_MAP) ? "--lcores" :
- "-c");
- return -1;
- }
-
- core_parsed = LCORE_OPT_MSK;
+ case 'c':
+ lcore_options.core_mask_opt = optarg;
break;
- }
/* corelist */
- case 'l': {
- int lcore_indexes[RTE_MAX_LCORE];
-
- if (eal_service_cores_parsed())
- EAL_LOG(WARNING,
- "Service cores parsed before dataplane cores.
Please ensure -l is before -s or -S");
-
- if (eal_parse_corelist(optarg, lcore_indexes) < 0) {
- EAL_LOG(ERR, "invalid core list syntax");
- return -1;
- }
- if (update_lcore_config(lcore_indexes) < 0) {
- char *available = available_cores();
-
- EAL_LOG(ERR,
- "invalid core list, please check specified
cores are part of %s",
- available);
- free(available);
- return -1;
- }
-
- if (core_parsed) {
- EAL_LOG(ERR, "Option -l is ignored, because (%s) is
set!",
- (core_parsed == LCORE_OPT_MSK) ? "-c" :
- (core_parsed == LCORE_OPT_MAP) ? "--lcores" :
- "-
[PATCH v2] mem: fix infinite loop
When the process address space is insufficient,
mmap will fail, which will cause an infinite loop.
This patch stops attempting mmap if it fails and
the requested size cannot be reduced.
Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
Cc: sta...@dpdk.org
Signed-off-by: Dengdui Huang
Acked-by: Dmitry Kozlyuk
---
lib/eal/common/eal_common_memory.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/eal/common/eal_common_memory.c
b/lib/eal/common/eal_common_memory.c
index a185e0b580..0c997201bd 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -101,8 +101,12 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
mapped_addr = eal_mem_reserve(
requested_addr, (size_t)map_sz, reserve_flags);
- if ((mapped_addr == NULL) && allow_shrink)
- *size -= page_sz;
+ if (mapped_addr == NULL) {
+ if (allow_shrink)
+ *size -= page_sz;
+ else
+ break;
+ }
if ((mapped_addr != NULL) && addr_is_hint &&
(mapped_addr != requested_addr)) {
--
2.33.0
[Patch v3 1/6] net/netvsc: introduce private data for storing vmbus device for secondary process
From: Long Li
To prepare for supporting to set hyperv event from secondary process
when the channel has monitoring disable, introduce a private data
region for storing the vmbus device. The secondary process will get
access to its vmbus device in case it needs to signal the host.
Signed-off-by: Long Li
---
drivers/net/netvsc/hn_ethdev.c | 44 +++---
drivers/net/netvsc/hn_nvs.h| 4
2 files changed, 39 insertions(+), 9 deletions(-)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index f848157b49..e5b052d569 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -1427,7 +1427,8 @@ static int eth_hn_probe(struct rte_vmbus_driver *drv
__rte_unused,
struct rte_vmbus_device *dev)
{
struct rte_eth_dev *eth_dev;
- int ret;
+ struct hn_nvs_process_priv *process_priv;
+ int ret = 0;
PMD_INIT_FUNC_TRACE();
@@ -1438,16 +1439,37 @@ static int eth_hn_probe(struct rte_vmbus_driver *drv
__rte_unused,
}
eth_dev = eth_dev_vmbus_allocate(dev, sizeof(struct hn_data));
- if (!eth_dev)
- return -ENOMEM;
+ if (!eth_dev) {
+ ret = -ENOMEM;
+ goto vmbus_alloc_failed;
+ }
- ret = eth_hn_dev_init(eth_dev);
- if (ret) {
- eth_dev_vmbus_release(eth_dev);
- rte_dev_event_monitor_stop();
- } else {
- rte_eth_dev_probing_finish(eth_dev);
+ process_priv = rte_zmalloc_socket("netvsc_proc_priv",
+ sizeof(struct hn_nvs_process_priv),
+ RTE_CACHE_LINE_SIZE,
+ dev->device.numa_node);
+ if (!process_priv) {
+ ret = -ENOMEM;
+ goto priv_alloc_failed;
}
+ process_priv->vmbus_dev = dev;
+ eth_dev->process_private = process_priv;
+
+ ret = eth_hn_dev_init(eth_dev);
+ if (ret)
+ goto dev_init_failed;
+
+ rte_eth_dev_probing_finish(eth_dev);
+ return ret;
+
+dev_init_failed:
+ rte_free(process_priv);
+
+priv_alloc_failed:
+ eth_dev_vmbus_release(eth_dev);
+
+vmbus_alloc_failed:
+ rte_dev_event_monitor_stop();
return ret;
}
@@ -1455,6 +1477,7 @@ static int eth_hn_probe(struct rte_vmbus_driver *drv
__rte_unused,
static int eth_hn_remove(struct rte_vmbus_device *dev)
{
struct rte_eth_dev *eth_dev;
+ struct hn_nvs_process_priv *process_priv;
int ret;
PMD_INIT_FUNC_TRACE();
@@ -1467,6 +1490,9 @@ static int eth_hn_remove(struct rte_vmbus_device *dev)
if (ret)
return ret;
+ process_priv = eth_dev->process_private;
+ rte_free(process_priv);
+
eth_dev_vmbus_release(eth_dev);
rte_dev_event_monitor_stop();
return 0;
diff --git a/drivers/net/netvsc/hn_nvs.h b/drivers/net/netvsc/hn_nvs.h
index 2843ef7b96..3950749359 100644
--- a/drivers/net/netvsc/hn_nvs.h
+++ b/drivers/net/netvsc/hn_nvs.h
@@ -65,6 +65,10 @@
#define NVS_TYPE_SUBCH_RESP133 /* same as SUBCH_REQ */
#define NVS_TYPE_TXTBL_NOTE134 /* notification */
+/* Private data for primary/secondary processes */
+struct hn_nvs_process_priv {
+ struct rte_vmbus_device *vmbus_dev;
+};
/* NVS message common header */
struct __rte_packed_begin hn_nvs_hdr {
--
2.34.1
[Patch v3 4/6] bus/vmbus: support channels without monitoring enabled
From: Long Li
Hyperv host may offer channels without monitor enabled. The max monitor
ID it supports is 128. Over those channels without monitor enabled,
Hyperv does not send or receive large amount of data traffic and almost all
the data traffic is going over the VF.
Change the code to not fail on creating channels without monitor enabled.
Use UINT8_MAX (256) to indicate this channel have no monitoring.
Signed-off-by: Long Li
---
drivers/bus/vmbus/linux/vmbus_bus.c | 9 ++---
drivers/bus/vmbus/linux/vmbus_uio.c | 4 ++--
drivers/bus/vmbus/vmbus_channel.c | 3 +++
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c
b/drivers/bus/vmbus/linux/vmbus_bus.c
index 01d8111b85..79fd3370b8 100644
--- a/drivers/bus/vmbus/linux/vmbus_bus.c
+++ b/drivers/bus/vmbus/linux/vmbus_bus.c
@@ -280,9 +280,12 @@ vmbus_scan_one(const char *name)
/* get monitor id */
snprintf(filename, sizeof(filename), "%s/monitor_id", dirname);
- if (eal_parse_sysfs_value(filename, &tmp) < 0)
- goto error;
- dev->monitor_id = tmp;
+ if (eal_parse_sysfs_value(filename, &tmp) >= 0) {
+ dev->monitor_id = tmp;
+ } else {
+ VMBUS_LOG(NOTICE, "monitor disabled on %s", name);
+ dev->monitor_id = UINT8_MAX;
+ }
/* get numa node (if present) */
snprintf(filename, sizeof(filename), "%s/numa_node",
diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c
b/drivers/bus/vmbus/linux/vmbus_uio.c
index 26edef342d..33edc151f6 100644
--- a/drivers/bus/vmbus/linux/vmbus_uio.c
+++ b/drivers/bus/vmbus/linux/vmbus_uio.c
@@ -451,9 +451,9 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,
err = vmbus_uio_sysfs_read(subchan_path, "monitor_id",
&monid, UINT8_MAX);
if (err) {
- VMBUS_LOG(NOTICE, "no monitor_id in %s:%s",
+ VMBUS_LOG(NOTICE, "no monitor_id in %s:%s use int mode",
subchan_path, strerror(-err));
- goto fail;
+ monid = UINT8_MAX;
}
err = vmbus_chan_create(dev, relid, subid, monid, subchan);
diff --git a/drivers/bus/vmbus/vmbus_channel.c
b/drivers/bus/vmbus/vmbus_channel.c
index 925c2aa081..d4b5ba1979 100644
--- a/drivers/bus/vmbus/vmbus_channel.c
+++ b/drivers/bus/vmbus/vmbus_channel.c
@@ -52,6 +52,9 @@ rte_vmbus_set_latency(const struct rte_vmbus_device *dev,
const struct vmbus_channel *chan,
uint32_t latency)
{
+ if (chan->monitor_id == UINT8_MAX)
+ return;
+
uint32_t trig_idx = chan->monitor_id / VMBUS_MONTRIG_LEN;
uint32_t trig_offs = chan->monitor_id % VMBUS_MONTRIG_LEN;
--
2.34.1
[Patch v3 0/6] Support VMBUS channels without monitoring enabled
From: root Hyperv may expose VMBUS channels without monitoring enabled. In this case, it programs almost all the data traffic to VF. This patchset enabled vmbus/netvsc to use channels without monitoring enabled. This needs to change the APIs exposed by drivers/bus/vmbus. Becuase those APIs are used only by NetVSC PMD and not feasible for use by a DPDK application, all VMBUS APIs are set to deprecate in upcoming 25.11 release. The notice for deprecation is accepted in the following patch: https://patchwork.dpdk.org/project/dpdk/patch/1742242184-19600-1-git-send-email-lon...@linuxonhyperv.com/ Long Li (6): net/netvsc: introduce private data for storing vmbus device for secondary process net/netvsc: introduce get_vmbus_device to get the vmbus device bus/vmbus: store UIO fd for secondary process bus/vmbus: support channels without monitoring enabled bus/vmbus: add rte_vmbus_device to all functions accessing vmbus bus/vmbus: set event for channel without monitoring support Change log: v3: Add in the comment on the VMBUS API deprecation notice drivers/bus/vmbus/linux/vmbus_bus.c | 9 +++-- drivers/bus/vmbus/linux/vmbus_uio.c | 6 ++-- drivers/bus/vmbus/private.h | 2 +- drivers/bus/vmbus/rte_bus_vmbus.h| 16 ++--- drivers/bus/vmbus/vmbus_channel.c| 52 drivers/bus/vmbus/vmbus_common_uio.c | 9 +++-- drivers/net/netvsc/hn_ethdev.c | 44 ++- drivers/net/netvsc/hn_nvs.c | 33 +- drivers/net/netvsc/hn_nvs.h | 21 +++ drivers/net/netvsc/hn_rndis.c| 11 +++--- drivers/net/netvsc/hn_rxtx.c | 16 - 11 files changed, 152 insertions(+), 67 deletions(-) -- 2.34.1
[Patch v3 6/6] bus/vmbus: set event for channel without monitoring support
From: Long Li
For vmbus channels without monitoring support, use kernel UIO interface
to indicate packet through interrupt page and UIO file handle.
Signed-off-by: Long Li
---
Change log:
v2: fixed compilation warnings
drivers/bus/vmbus/vmbus_channel.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/vmbus/vmbus_channel.c
b/drivers/bus/vmbus/vmbus_channel.c
index bccef168d3..81e8096190 100644
--- a/drivers/bus/vmbus/vmbus_channel.c
+++ b/drivers/bus/vmbus/vmbus_channel.c
@@ -24,6 +24,19 @@ vmbus_sync_set_bit(volatile RTE_ATOMIC(uint32_t) *addr,
uint32_t mask)
rte_atomic_fetch_or_explicit(addr, mask, rte_memory_order_seq_cst);
}
+static inline void
+vmbus_send_interrupt(const struct rte_vmbus_device *dev, uint32_t relid)
+{
+ RTE_ATOMIC(uint32_t) *int_addr;
+ uint32_t int_mask;
+
+ int_addr = (RTE_ATOMIC(uint32_t)*) (dev->int_page + relid / 32);
+ int_mask = 1u << (relid % 32);
+ vmbus_sync_set_bit(int_addr, int_mask);
+
+ vmbus_uio_irq_control(dev, 1);
+}
+
static inline void
vmbus_set_monitor(const struct vmbus_channel *channel, uint32_t monitor_id)
{
@@ -39,10 +52,12 @@ vmbus_set_monitor(const struct vmbus_channel *channel,
uint32_t monitor_id)
}
static void
-vmbus_set_event(struct rte_vmbus_device *dev __rte_unused,
- const struct vmbus_channel *chan)
+vmbus_set_event(struct rte_vmbus_device *dev, const struct vmbus_channel *chan)
{
- vmbus_set_monitor(chan, chan->monitor_id);
+ if (chan->monitor_id != UINT8_MAX)
+ vmbus_set_monitor(chan, chan->monitor_id);
+ else
+ vmbus_send_interrupt(dev, chan->relid);
}
/*
--
2.34.1
[Patch v3 3/6] bus/vmbus: store UIO fd for secondary process
From: Long Li Secondary process will get access to vmbus device and this UIO fd for signaling hyperv host on channels without monitoring support. Signed-off-by: Long Li --- drivers/bus/vmbus/vmbus_common_uio.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/bus/vmbus/vmbus_common_uio.c b/drivers/bus/vmbus/vmbus_common_uio.c index 4d4613513c..d55aee6537 100644 --- a/drivers/bus/vmbus/vmbus_common_uio.c +++ b/drivers/bus/vmbus/vmbus_common_uio.c @@ -86,8 +86,11 @@ vmbus_uio_map_secondary(struct rte_vmbus_device *dev) return -1; } - /* fd is not needed in secondary process, close it */ - close(fd); + if (rte_intr_fd_set(dev->intr_handle, fd)) + return -1; + + if (rte_intr_type_set(dev->intr_handle, RTE_INTR_HANDLE_UIO_INTX)) + return -1; /* Create and map primary channel */ if (vmbus_chan_create(dev, dev->relid, 0, @@ -256,7 +259,7 @@ vmbus_uio_unmap_resource(struct rte_vmbus_device *dev) /* free uio resource */ rte_free(uio_res); - /* close fd if in primary process */ + /* close fd */ if (rte_intr_fd_get(dev->intr_handle) >= 0) close(rte_intr_fd_get(dev->intr_handle)); -- 2.34.1
[Patch v3 5/6] bus/vmbus: add rte_vmbus_device to all functions accessing vmbus
From: Long Li
The secondary process can access its vmbus device through device private
region. Add and pass it on all call chains leading to vmbus code.
Signed-off-by: Long Li
---
drivers/bus/vmbus/linux/vmbus_uio.c | 2 +-
drivers/bus/vmbus/private.h | 2 +-
drivers/bus/vmbus/rte_bus_vmbus.h | 16 ++-
drivers/bus/vmbus/vmbus_channel.c | 32 +
drivers/net/netvsc/hn_nvs.c | 18
drivers/net/netvsc/hn_nvs.h | 15 +++---
drivers/net/netvsc/hn_rndis.c | 11 +-
drivers/net/netvsc/hn_rxtx.c| 16 +++
8 files changed, 63 insertions(+), 49 deletions(-)
diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c
b/drivers/bus/vmbus/linux/vmbus_uio.c
index 33edc151f6..8edec869ac 100644
--- a/drivers/bus/vmbus/linux/vmbus_uio.c
+++ b/drivers/bus/vmbus/linux/vmbus_uio.c
@@ -27,7 +27,7 @@
static void *vmbus_map_addr;
/* Control interrupts */
-void vmbus_uio_irq_control(struct rte_vmbus_device *dev, int32_t onoff)
+void vmbus_uio_irq_control(const struct rte_vmbus_device *dev, int32_t onoff)
{
if ((rte_intr_fd_get(dev->intr_handle) < 0) ||
write(rte_intr_fd_get(dev->intr_handle), &onoff,
diff --git a/drivers/bus/vmbus/private.h b/drivers/bus/vmbus/private.h
index abee1b29f0..25b8a27fcf 100644
--- a/drivers/bus/vmbus/private.h
+++ b/drivers/bus/vmbus/private.h
@@ -110,7 +110,7 @@ void vmbus_insert_device(struct rte_vmbus_device
*exist_vmbus_dev,
struct rte_vmbus_device *new_vmbus_dev);
void vmbus_remove_device(struct rte_vmbus_device *vmbus_device);
-void vmbus_uio_irq_control(struct rte_vmbus_device *dev, int32_t onoff);
+void vmbus_uio_irq_control(const struct rte_vmbus_device *dev, int32_t onoff);
int vmbus_uio_irq_read(struct rte_vmbus_device *dev);
int vmbus_uio_map_resource(struct rte_vmbus_device *dev);
diff --git a/drivers/bus/vmbus/rte_bus_vmbus.h
b/drivers/bus/vmbus/rte_bus_vmbus.h
index fd18bca73c..2e9898ed7f 100644
--- a/drivers/bus/vmbus/rte_bus_vmbus.h
+++ b/drivers/bus/vmbus/rte_bus_vmbus.h
@@ -176,7 +176,8 @@ bool rte_vmbus_chan_rx_empty(const struct vmbus_channel
*channel);
*
* Sends data in buffer directly to hyper-v via the vmbus
*/
-int rte_vmbus_chan_send(struct vmbus_channel *channel, uint16_t type,
+int rte_vmbus_chan_send(struct rte_vmbus_device *dev,
+ struct vmbus_channel *channel, uint16_t type,
void *data, uint32_t dlen,
uint64_t xact, uint32_t flags, bool *need_sig);
@@ -189,7 +190,8 @@ int rte_vmbus_chan_send(struct vmbus_channel *channel,
uint16_t type,
* Used when batching multiple sends and only signaling host
* after the last send.
*/
-void rte_vmbus_chan_signal_tx(const struct vmbus_channel *channel);
+void rte_vmbus_chan_signal_tx(struct rte_vmbus_device *dev,
+ const struct vmbus_channel *channel);
/* Structure for scatter/gather I/O */
struct iova_list {
@@ -223,7 +225,8 @@ struct iova_list {
*
* Sends data in buffer directly to hyper-v via the vmbus
*/
-int rte_vmbus_chan_send_sglist(struct vmbus_channel *channel,
+int rte_vmbus_chan_send_sglist(struct rte_vmbus_device *dev,
+ struct vmbus_channel *channel,
struct vmbus_gpa gpa[], uint32_t gpacnt,
void *data, uint32_t dlen,
uint64_t xact, bool *need_sig);
@@ -243,7 +246,8 @@ int rte_vmbus_chan_send_sglist(struct vmbus_channel
*channel,
* On success, returns 0
* On failure, returns negative errno.
*/
-int rte_vmbus_chan_recv(struct vmbus_channel *chan,
+int rte_vmbus_chan_recv(struct rte_vmbus_device *dev,
+ struct vmbus_channel *chan,
void *data, uint32_t *len,
uint64_t *request_id);
@@ -273,7 +277,9 @@ int rte_vmbus_chan_recv_raw(struct vmbus_channel *chan,
* @param bytes_read
* Number of bytes read since last signal
*/
-void rte_vmbus_chan_signal_read(struct vmbus_channel *chan, uint32_t
bytes_read);
+void rte_vmbus_chan_signal_read(struct rte_vmbus_device *dev,
+ struct vmbus_channel *chan,
+ uint32_t bytes_read);
/**
* Determine sub channel index of the given channel
diff --git a/drivers/bus/vmbus/vmbus_channel.c
b/drivers/bus/vmbus/vmbus_channel.c
index d4b5ba1979..bccef168d3 100644
--- a/drivers/bus/vmbus/vmbus_channel.c
+++ b/drivers/bus/vmbus/vmbus_channel.c
@@ -39,7 +39,8 @@ vmbus_set_monitor(const struct vmbus_channel *channel,
uint32_t monitor_id)
}
static void
-vmbus_set_event(const struct vmbus_channel *chan)
+vmbus_set_event(struct rte_vmbus_device *dev __rte_unused,
+ const struct vmbus_channel *chan)
{
vmbus_set_monitor(chan, chan->monitor_id);
}
@@ -80,7 +81,7 @@ rte_vmbus_set_latency(const struct rte_vmbus_dev
[Patch v3 2/6] net/netvsc: introduce get_vmbus_device to get the vmbus device
From: Long Li
Introduce a function get the vmbus device from hn_data. For secondary
process, the vmbus device is in eth_dev's private region.
Signed-off-by: Long Li
---
drivers/net/netvsc/hn_nvs.c | 15 +++
drivers/net/netvsc/hn_nvs.h | 2 ++
2 files changed, 17 insertions(+)
diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c
index 7db82af9f3..fd20e3d06d 100644
--- a/drivers/net/netvsc/hn_nvs.c
+++ b/drivers/net/netvsc/hn_nvs.c
@@ -44,6 +44,21 @@ static const uint32_t hn_nvs_version[] = {
NVS_VERSION_1
};
+struct rte_vmbus_device *get_vmbus_device(struct hn_data *hv)
+{
+ struct rte_vmbus_device *vmbus = hv->vmbus;
+
+ /* For secondary process, vmbus is in the eth_dev private */
+ if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+ struct rte_eth_dev *dev = &rte_eth_devices[hv->port_id];
+ struct hn_nvs_process_priv *process_priv = dev->process_private;
+
+ vmbus = process_priv->vmbus_dev;
+ }
+
+ return vmbus;
+}
+
static int hn_nvs_req_send(struct hn_data *hv,
void *req, uint32_t reqlen)
{
diff --git a/drivers/net/netvsc/hn_nvs.h b/drivers/net/netvsc/hn_nvs.h
index 3950749359..0d8fe27b65 100644
--- a/drivers/net/netvsc/hn_nvs.h
+++ b/drivers/net/netvsc/hn_nvs.h
@@ -221,6 +221,8 @@ voidhn_nvs_handle_vfassoc(struct rte_eth_dev *dev,
const struct vmbus_chanpkt_hdr *hdr,
const void *data);
+struct rte_vmbus_device *get_vmbus_device(struct hn_data *hv);
+
static inline int
hn_nvs_send(struct vmbus_channel *chan, uint16_t flags,
void *nvs_msg, int nvs_msglen, uintptr_t sndc,
--
2.34.1
Re: [PATCH] acl: fix build with GCC 15 on aarch64
Hi guys,
On Wed, Mar 26, 2025 at 11:40 AM David Marchand
wrote:
>
> Caught in OBS for Fedora Rawhide on aarch64:
>
> [ 198s] In file included from ../lib/acl/acl_run_neon.h:7,
> [ 198s] from ../lib/acl/acl_run_neon.c:5:
> [ 198s] In function ‘alloc_completion’,
> [ 198s] inlined from ‘acl_start_next_trie’ at
> ../lib/acl/acl_run.h:140:24,
> [ 198s] inlined from ‘search_neon_4.isra’ at
> ../lib/acl/acl_run_neon.h:239:20:
> [ 198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> uninitialized [-Werror=maybe-uninitialized]
> [ 198s]93 | if (p[n].count == 0) {
> [ 198s] | ^~
> [ 198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> [ 198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> [ 198s] 230 | struct completion cmplt[4];
> [ 198s] | ^
>
> The code was resetting sequentially cmpl[].count at the exact index that
> later call to alloc_completion uses.
> While this code seems correct, GCC 15 does not understand this (probably
> when applying some optimisations).
>
> Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> various vectorized implementations accordingly.
>
> Bugzilla ID: 1678
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
No pressure, but could you have a look?
This is for fixing some build issue in the CI (affecting main, at least).
--
David Marchand
