[PATCH] power/amd_uncore: add e-smi installation instructions

2024-11-28 Thread Sivaprasad Tummala 
Added section for installing and building the E-SMI library
for AMD EPYC Uncore support and version requirements.

Signed-off-by: Sivaprasad Tummala 
---
 doc/guides/prog_guide/power_man.rst | 32 +
 1 file changed, 32 insertions(+)

diff --git a/doc/guides/prog_guide/power_man.rst 
b/doc/guides/prog_guide/power_man.rst
index 74039e5786..d367a81596 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -249,6 +249,38 @@ Additionally, the EPYC System Management Interface In-band 
Library for Linux
 offers essential API, enabling user-space software
 to effectively manage system functions.
 
+E-SMI Installation
+--
+
+To build DPDK with AMD EPYC Uncore the user is required to download the e-smi
+library from `here `_
+and compile it on their user system before building DPDK.
+
+.. code-block:: console
+
+cd esmi_ib_library
+cmake .
+sudo make install
+cp /opt/e-sms/e_smi/lib/* /usr/local/lib/*
+cp /opt/e-sms/e_smi/include/* /usr/local/include/*
+
+Library file, header and tool are installed at /opt/e-sms.
+
+Note: Library is dependent on amd_hsmp.h header and without this, compilation 
will break.
+
+The library requires CMake (v3.5.0) to be built.
+
+As a reference, the following table shows a mapping between the DPDK versions
+and the E-SMI library and kernel version supported by them:
+
+.. table:: DPDK and E-SMI library and kernel version compatibility
+
+   ==  ==   =
+   DPDK versionE-SMI versionLinux Kernel version
+   ==  ==   =
+24.11+  4.0.06.7+
+   ==  ==   =
+
 Uncore API Overview
 ~~~
 
-- 
2.34.1

DPDK Release Status Meeting 2024-11-28

2024-11-28 Thread Mcnamara, John 
Release status meeting minutes 2024-11-28
=

Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens

Participants:
* ARM
* Intel
* Marvell
* Nvidia
* Red Hat


Release Dates
-

The following are the proposed working dates for 25.03:

- Proposal deadline (RFC/v1 patches): 4 January 2025
- API freeze (-rc1): 7 February 2025
- PMD features freeze (-rc2): 28 February 2025
- Builtin applications features freeze (-rc3): 7 March 2025
- Release: 14 March 2025

https://core.dpdk.org/roadmap/#dates


Subtrees


* next-net
  * RC4 released.

* next-net-intel
  * Some doc/fix patches for post RC4.

* next-net-mlx
  * No update.

* next-net-mvl
  * No update.

* next-eventdev
  * No update.

* next-baseband
  * Nothing beyond RC4.

* next-virtio
  * 2 patches posted. 1 fix and 1 revert.

* next-crypto
  * Nothing beyond RC4.

* next-dts
  * Up to date in RC4.

* main
  * RC4 release.
  * Prepping for release.
  * Release targeted for 29 November 2024
  * The following are the proposed dates for DPDK 25.03:
V1:  Jan 4
RC1: Feb 7
RC2: Feb 28
RC3: Mar 7
RC4: Mar 14
Rel: Mar 21



**Note**:
We will look to move this meeting to a US friendly time slot at
the start of December.


LTS
---

Status of the current LTSes

* 23.11.3 - In progress.
* 22.11.7 - In progress.
* 21.11.9 - In progress.

* 20.11.10 - Will only be updated with CVE and critical fixes.
* 19.11.15 - Will only be updated with CVE and critical fixes.


* Distros
  * Debian 12 contains DPDK v22.11
  * Ubuntu 24.04 contains DPDK v23.11
  * Ubuntu 23.04 contains DPDK v22.11
  * RHEL 8/9 contains DPDK 23.11

Defects
---

* Bugzilla links, 'Bugs',  added for hosted projects
  * https://www.dpdk.org/hosted-projects/



DPDK Release Status Meetings


The DPDK Release Status Meeting is intended for DPDK Committers to discuss the
status of the master tree and sub-trees, and for project managers to track
progress or milestone dates.

The meeting occurs on every Thursday at 9:30 DST over Jitsi on 
https://meet.jit.si/DPDK

You don't need an invite to join the meeting but if you want a calendar 
reminder just
send an email to "John McNamara john.mcnam...@intel.com" for the invite.

[PATCH v3 1/2] net/sxe: submit the build directory and rough doc documentation

2024-11-28 Thread Jie Liu 
Adding a minimum maintainable directory structure for the
network driver and request maintenance of the sxe driver.

Signed-off-by: Jie Liu 
---
 doc/guides/nics/features/sxe.ini|  8 +
 doc/guides/nics/features/sxe_vf.ini | 10 ++
 doc/guides/nics/sxe.rst | 41 +
 drivers/net/sxe/meson.build | 10 ++
 drivers/net/sxe/pf/sxe_ethdev.c |  3 ++
 drivers/net/sxe/pf/sxe_ethdev.h |  3 ++
 drivers/net/sxe/rte_pmd_sxe_version.map |  4 +++
 drivers/net/sxe/version.map |  3 ++
 8 files changed, 82 insertions(+)
 create mode 100644 doc/guides/nics/features/sxe.ini
 create mode 100644 doc/guides/nics/features/sxe_vf.ini
 create mode 100644 doc/guides/nics/sxe.rst
 create mode 100644 drivers/net/sxe/meson.build
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.c
 create mode 100644 drivers/net/sxe/pf/sxe_ethdev.h
 create mode 100644 drivers/net/sxe/rte_pmd_sxe_version.map
 create mode 100644 drivers/net/sxe/version.map

diff --git a/doc/guides/nics/features/sxe.ini b/doc/guides/nics/features/sxe.ini
new file mode 100644
index 00..209825a1fc
--- /dev/null
+++ b/doc/guides/nics/features/sxe.ini
@@ -0,0 +1,8 @@
+;
+; Supported features of the 'sxe' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux UIO= Y
+Linux VFIO   = Y
diff --git a/doc/guides/nics/features/sxe_vf.ini 
b/doc/guides/nics/features/sxe_vf.ini
new file mode 100644
index 00..76376dd4c3
--- /dev/null
+++ b/doc/guides/nics/features/sxe_vf.ini
@@ -0,0 +1,10 @@
+;
+; Supported features of the 'sxe_vf' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux= Y
+ARMv8= Y
+x86-32   = Y
+x86-64   = Y
diff --git a/doc/guides/nics/sxe.rst b/doc/guides/nics/sxe.rst
new file mode 100644
index 00..ba84d68ca6
--- /dev/null
+++ b/doc/guides/nics/sxe.rst
@@ -0,0 +1,41 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright (C), 2022, Linkdata Technology Co., Ltd.
+
+SXE Poll Mode Driver
+==
+
+The SXE PMD (librte_pmd_sxe) provides poll mode driver support
+for Linkdata 1160-2X 10GE Ethernet Adapter.
+
+
+Configuration
+-
+
+Dynamic Logging Parameters
+~~
+
+One may leverage EAL option "--log-level" to change default levels
+for the log types supported by the driver. The option is used with
+an argument typically consisting of two parts separated by a colon.
+
+SXE PMD provides the following log types available for control:
+
+- ``pmd.net.sxe.drv`` (default level is **DEBUG**)
+
+  Affects driver-wide messages unrelated to any particular devices.
+
+- ``pmd.net.sxe.init`` (default level is **DEBUG**)
+
+  Extra logging of the messages during PMD initialization.
+
+- ``pmd.net.sxe.rx`` (default level is **DEBUG**)
+
+  Affects rx-wide messages.
+- ``pmd.net.sxe.tx`` (default level is **DEBUG**)
+
+  Affects tx-wide messages.
+--
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC 
`
+for details.
+
diff --git a/drivers/net/sxe/meson.build b/drivers/net/sxe/meson.build
new file mode 100644
index 00..f8e1d54480
--- /dev/null
+++ b/drivers/net/sxe/meson.build
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (C), 2020, Wuxi Stars Micro System Technologies Co., Ltd.
+
+deps += ['hash']
+sources = files(
+   'pf/sxe_ethdev.c',
+)
+
+includes += include_directories('pf')
+
diff --git a/drivers/net/sxe/pf/sxe_ethdev.c b/drivers/net/sxe/pf/sxe_ethdev.c
new file mode 100644
index 00..e31a23deeb
--- /dev/null
+++ b/drivers/net/sxe/pf/sxe_ethdev.c
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
diff --git a/drivers/net/sxe/pf/sxe_ethdev.h b/drivers/net/sxe/pf/sxe_ethdev.h
new file mode 100644
index 00..e31a23deeb
--- /dev/null
+++ b/drivers/net/sxe/pf/sxe_ethdev.h
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2015-2024
+ */
diff --git a/drivers/net/sxe/rte_pmd_sxe_version.map 
b/drivers/net/sxe/rte_pmd_sxe_version.map
new file mode 100644
index 00..3a4ad25f1c
--- /dev/null
+++ b/drivers/net/sxe/rte_pmd_sxe_version.map
@@ -0,0 +1,4 @@
+DPDK_24.0 {
+   local: *;
+};
+
diff --git a/drivers/net/sxe/version.map b/drivers/net/sxe/version.map
new file mode 100644
index 00..17cc97bda6
--- /dev/null
+++ b/drivers/net/sxe/version.map
@@ -0,0 +1,3 @@
+DPDK_25 {
+   local: *;
+};
-- 
2.27.0

[PATCH v3 2/2] net/sxe: submit the build directory and rough doc documentation

2024-11-28 Thread Jie Liu 
Modify sxe pf document.

Signed-off-by: Jie Liu 
---
 doc/guides/nics/features/sxe.ini | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/sxe.ini b/doc/guides/nics/features/sxe.ini
index 209825a1fc..173ab48889 100644
--- a/doc/guides/nics/features/sxe.ini
+++ b/doc/guides/nics/features/sxe.ini
@@ -4,5 +4,7 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
-Linux UIO= Y
-Linux VFIO   = Y
+Linux= Y
+ARMv8= Y
+x86-32   = Y
+x86-64   = Y
-- 
2.27.0

Re: [PATCH v4] net/hns3: fix Rx packet without CRC data

2024-11-28 Thread Jie Hai 

Hi, stephen,

Kindly ping for review.

Thanks,
Jie Hai


On 2024/11/27 18:08, Jie Hai wrote:

From: Dengdui Huang 

When KEEP_CRC offload is enabled, the CRC data is still stripped
in following cases:
1. For HIP08 network engine, the packet type is TCP and the length
is less than or equal to 60B.
2. For HIP09 network engine, the packet type is IP and the length
is less than or equal to 60B.

So driver has to recaculate packet CRC for this rare scenarios.

In addition, to avoid impacting performance, KEEP_CRC is not
supported when NEON or SVE algorithm is used.

Fixes: 8973d7c4ca12 ("net/hns3: support keeping CRC")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Huisong Li 
Acked-by: Jie Hai 
---
  drivers/net/hns3/hns3_ethdev.c|   5 ++
  drivers/net/hns3/hns3_ethdev.h|  23 +
  drivers/net/hns3/hns3_rxtx.c  | 121 +-
  drivers/net/hns3/hns3_rxtx.h  |   3 +
  drivers/net/hns3/hns3_rxtx_vec.c  |   3 +-
  drivers/net/hns3/hns3_rxtx_vec_neon.h |  19 
  drivers/net/hns3/hns3_rxtx_vec_sve.c  |   3 +-
  7 files changed, 132 insertions(+), 45 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 72d1c30a7b2e..b3bd439d0dd5 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2739,6 +2739,7 @@ hns3_get_capability(struct hns3_hw *hw)
hw->udp_cksum_mode = HNS3_SPECIAL_PORT_SW_CKSUM_MODE;
pf->support_multi_tc_pause = false;
hw->rx_dma_addr_align = HNS3_RX_DMA_ADDR_ALIGN_64;
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_TCP;
return 0;
}
  
@@ -2760,6 +2761,10 @@ hns3_get_capability(struct hns3_hw *hw)

hw->udp_cksum_mode = HNS3_SPECIAL_PORT_HW_CKSUM_MODE;
pf->support_multi_tc_pause = true;
hw->rx_dma_addr_align = HNS3_RX_DMA_ADDR_ALIGN_128;
+   if (hw->revision == PCI_REVISION_ID_HIP09_A)
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_IP;
+   else
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_NONE;
  
  	return 0;

  }
diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index 7824503bb89f..01d473fd2e66 100644
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -54,6 +54,10 @@
  #define HNS3_SPECIAL_PORT_SW_CKSUM_MODE 0
  #define HNS3_SPECIAL_PORT_HW_CKSUM_MODE 1
  
+#define HNS3_STRIP_CRC_PTYPE_NONE 0

+#define HNS3_STRIP_CRC_PTYPE_TCP  1
+#define HNS3_STRIP_CRC_PTYPE_IP   2
+
  #define HNS3_UC_MACADDR_NUM   128
  #define HNS3_VF_UC_MACADDR_NUM48
  #define HNS3_MC_MACADDR_NUM   128
@@ -655,6 +659,25 @@ struct hns3_hw {
 */
uint8_t udp_cksum_mode;
  
+	/*

+* When KEEP_CRC offload is enabled, the CRC data of some type packets
+* whose length is less than or equal to HNS3_KEEP_CRC_OK_MIN_PKT_LEN
+* is still be stripped on some network engine. So here has to use this
+* field to distinguish the difference between different network 
engines.
+* value range:
+*  - HNS3_STRIP_CRC_PTYPE_TCP
+* This value for HIP08 network engine.
+* Indicates that only the IP-TCP packet type is stripped.
+*
+*  - HNS3_STRIP_CRC_PTYPE_IP
+* This value for HIP09 network engine.
+* Indicates that all IP packet types are stripped.
+*
+*  - HNS3_STRIP_CRC_PTYPE_NONE
+* Indicates that all packet types are not stripped.
+*/
+   uint8_t strip_crc_ptype;
+
struct hns3_port_base_vlan_config port_base_vlan_cfg;
  
  	pthread_mutex_t flows_lock; /* rte_flow ops lock */

diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index 03bbbc435fac..75fd4f55e73a 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -11,6 +11,7 @@
  #include 
  #include 
  #include 
+#include 
  #if defined(RTE_ARCH_ARM64)
  #include 
  #include 
@@ -1768,8 +1769,9 @@ hns3_rx_buf_len_calc(struct rte_mempool *mp, uint16_t 
*rx_buf_len)
  }
  
  static int

-hns3_rxq_conf_runtime_check(struct hns3_hw *hw, uint16_t buf_size,
-   uint16_t nb_desc)
+hns3_rxq_conf_runtime_check(struct hns3_hw *hw,
+   const struct rte_eth_rxconf *conf,
+   uint16_t buf_size, uint16_t nb_desc)
  {
struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
@@ -1802,6 +1804,14 @@ hns3_rxq_conf_runtime_check(struct hns3_hw *hw, uint16_t 
buf_size,
return -EINVAL;
}
}
+
+   if ((conf->offloads & RTE_ETH_RX_OFFLOAD_KEEP_CRC) &&
+   pkt_burst != hns3_recv_pkts_simple &&
+   pkt_burst != hns3_recv_scattered_pkts) {
+   hns3_err(hw, "KEEP_CRC offload is not

[PATCH v3] dts: remove html dir from nested docs

2024-11-28 Thread Paul Szczepanek 
To facilitate deploying docs to the website
and make paths more consistent remove the html
directory from docs nested in html directories.

Signed-off-by: Paul Szczepanek 
Reviewed-by: Luca Vizzarro 
---
 buildtools/call-sphinx-build.py | 6 --
 doc/api/meson.build | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/buildtools/call-sphinx-build.py b/buildtools/call-sphinx-build.py
index 2c7de54285..3e5fc813a2 100755
--- a/buildtools/call-sphinx-build.py
+++ b/buildtools/call-sphinx-build.py
@@ -30,8 +30,10 @@
 
 # run sphinx, putting the html output in a "html" directory
 with open(join(dst, 'sphinx_html.out'), 'w') as out:
-process = run(sphinx_cmd + ['-b', 'html', src, join(dst, 'html')],
-  stdout=out)
+# don't append html dir if dst is already nested in a html dir
+top_2_dirs = os.path.join(*os.path.normpath(dst).split(os.path.sep)[-2:])
+html_dst = dst if 'html' in top_2_dirs else join(dst, 'html')
+process = run(sphinx_cmd + ['-b', 'html', src, html_dst], stdout=out)
 
 # create a gcc format .d file giving all the dependencies of this doc build
 with open(join(dst, '.html.d'), 'w') as d:
diff --git a/doc/api/meson.build b/doc/api/meson.build
index f9f1326bbd..ac6eb8236d 100644
--- a/doc/api/meson.build
+++ b/doc/api/meson.build
@@ -37,7 +37,7 @@ cdata.set('OUTPUT', join_paths(dpdk_build_root, 'doc', 'api'))
 cdata.set('TOPDIR', dpdk_source_root)
 cdata.set('STRIP_FROM_PATH', ' '.join([dpdk_source_root, 
join_paths(dpdk_build_root, 'doc', 'api')]))
 cdata.set('WARN_AS_ERROR', 'NO')
-cdata.set('DTS_API_MAIN_PAGE', join_paths('.', 'dts', 'html', 'index.html'))
+cdata.set('DTS_API_MAIN_PAGE', join_paths('.', 'dts', 'index.html'))
 if get_option('werror')
 cdata.set('WARN_AS_ERROR', 'YES')
 endif
-- 
2.39.2

[PATCH v1] doc: update release notes for 24.11

2024-11-28 Thread John McNamara 
Fix grammar, spelling and formatting of DPDK 24.11 release notes.

Signed-off-by: John McNamara 
---
 doc/guides/rel_notes/release_24_11.rst | 158 +++--
 1 file changed, 93 insertions(+), 65 deletions(-)

diff --git a/doc/guides/rel_notes/release_24_11.rst 
b/doc/guides/rel_notes/release_24_11.rst
index 48b399cda7..b7e0f1224b 100644
--- a/doc/guides/rel_notes/release_24_11.rst
+++ b/doc/guides/rel_notes/release_24_11.rst
@@ -57,14 +57,14 @@ New Features
 
 * **Added new bit manipulation API.**
 
-  The support for bit-level operations on single 32- and 64-bit words in
-   has been extended with semantically well-defined functions.
+  Extended support for bit-level operations on single 32 and 64-bit words in
+   with semantically well-defined functions.
 
   * ``rte_bit_[test|set|clear|assign|flip]`` functions provide excellent
 performance (by avoiding restricting the compiler and CPU), but give
-no guarantees in regards to memory ordering or atomicity.
+no guarantees in relation to memory ordering or atomicity.
 
-  * ``rte_bit_atomic_*`` provide atomic bit-level operations, including
+  * ``rte_bit_atomic_*`` provides atomic bit-level operations including
 the possibility to specify memory ordering constraints.
 
   The new public API elements are polymorphic, using the _Generic-based
@@ -72,15 +72,17 @@ New Features
 
 * **Added multi-word bitset API.**
 
-  A new multi-word bitset API has been introduced in the EAL.
+  Introduced a new multi-word bitset API to the EAL.
+
   The RTE bitset is optimized for scenarios where the bitset size exceeds the
   capacity of a single word (e.g., larger than 64 bits), but is not large
   enough to justify the overhead and complexity of the more scalable,
-  yet slower,  API.
+  yet slower,  API.
+
   This addition provides an efficient and straightforward alternative
-  for handling bitsets of intermediate sizes.
+  for handling bitsets of intermediate size.
 
-* **Added per-lcore static memory allocation facility.**
+* **Added a per-lcore static memory allocation facility.**
 
   Added EAL API  for statically allocating small,
   frequently-accessed data structures, for which one instance should exist
@@ -89,10 +91,10 @@ New Features
   With lcore variables, data is organized spatially on a per-lcore id basis,
   rather than per library or PMD, avoiding the need for cache aligning
   (or RTE_CACHE_GUARDing) data structures, which in turn
-  reduces CPU cache internal fragmentation, improving performance.
+  reduces CPU cache internal fragmentation and improves performance.
 
   Lcore variables are similar to thread-local storage (TLS, e.g. C11 
``_Thread_local``),
-  but decoupling the values' life time from that of the threads.
+  but decouples the values' life times from those of the threads.
 
 * **Extended service cores statistics.**
 
@@ -101,7 +103,7 @@ New Features
   * ``RTE_SERVICE_ATTR_IDLE_CALL_COUNT`` tracks the number of service function
 invocations where no actual work was performed.
 
-  * ``RTE_SERVICE_ATTR_ERROR_CALL_COUNT`` tracks the number invocations
+  * ``RTE_SERVICE_ATTR_ERROR_CALL_COUNT`` tracks the number of invocations
 resulting in an error.
 
   The new statistics are useful for debugging and profiling.
@@ -110,17 +112,17 @@ New Features
 
   Added function attributes to ``rte_malloc`` and similar functions
   that can catch some obvious bugs at compile time (with GCC 11.0 or later).
-  Examples: calling ``free`` on pointer that was allocated with ``rte_malloc``
-  (and vice versa); freeing the same pointer twice in the same routine;
-  freeing an object that was not created by allocation; etc.
+  For example, calling ``free`` on a pointer that was allocated with 
``rte_malloc``
+  (and vice versa); freeing the same pointer twice in the same routine or
+  freeing an object that was not created by allocation.
 
-* **Updated logging library**
+* **Updated logging library.**
 
   * The log subsystem is initialized earlier in startup so all messages go 
through the library.
 
   * If the application is a systemd service and the log output is being sent 
to standard error
 then DPDK will switch to journal native protocol.
-This allows the more data such as severity to be sent.
+This allows more data such as severity to be sent.
 
   * The syslog option has changed.
 By default, messages are no longer sent to syslog unless the ``--syslog`` 
option is specified.
@@ -136,7 +138,7 @@ New Features
 
 * **Added more ICMP message types and codes.**
 
-  New ICMP message types and codes from RFC 792 were added in ``rte_icmp.h``.
+  Added new ICMP message types and codes from RFC 792 in ``rte_icmp.h``.
 
 * **Added IPv6 address structure and related utilities.**
 
@@ -154,7 +156,7 @@ New Features
 
 * **Extended flow table index features.**
 
-  * Extended the flow table insertion type enum with
+  * Extended the flow table insertion type enum with the
 ``RTE_FLOW_TABLE_INS

RE: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2024-11-28 Thread Mcnamara, John 
> From: Chen, LingliX 
> Subject: [PATCH V1] doc: add tested Intel platforms with Intel NICs

Acked-by: John McNamara

Re: [PATCH] eal: fix bus cleanup in secondary process

2024-11-28 Thread Stephen Hemminger 
On Thu, 28 Nov 2024 13:48:29 +0800
myang  wrote:

> eal_bus_cleanup has been added in rte_eal_cleanup. But for
> secondary process, eal_bus_cleanup will trigger vdev_cleanup
> which trigger rte_vdev_driver to remove. Then our crypto devices
> will execute ipsec_mb_remove to rte_cryptodev_pmd_destroy.
> 
> Finally error logs occur as below:
> CRYPTODEV: rte_cryptodev_close() line 1453: Device 0 must be
> stopped before closing
> EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad
> file descriptor
> EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket:ipsec_mb_mp_msg
> USER1: Create MR request to primary process failed.
> 
> Function call trace: rte_eal_cleanup->eal_bus_cleanup->
> vdev_cleanup->rte_vdev_driver->ipsec_mb_remove->
> 1. ipsec_mb_remove->rte_cryptodev_pmd_destroy->
> rte_cryptodev_pmd_release_device->rte_cryptodev_close
> 2. ipsec_mb_remove->ipsec_mb_qp_release->ipsec_mb_secondary_qp_op
> ->rte_mp_request_async->mp_request_async  
> 
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: myang 

There is was a reason for calling cleanup on shutdown.
It looks like more of a bug in the crypto device not the EAL.


Freebsd and Windows also calls eal_bus_cleanup.

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-28 Thread Stephen Hemminger 
On Thu, 28 Nov 2024 16:08:55 +
Anatoly Burakov  wrote:

> +# occasionally, system may report NUMA support but lspci will not, so we
> +# want to go through all devices and see if any of them do not have 
> NUMANode
> +# property - this will mean it is not safe to try to access it
> +for device_dict in devices.values():
> +if "NUMANode" not in device_dict:
> +return False

Any indication as to why this happens, what kernel, what device?

When the trace buffers are saved to disk?

2024-11-28 Thread Adel Belkhiri 
Hi all,

Recently, while tracing applications from the apps and examples
directories, I became confused about when the trace buffer is written to
disk. Is the trace data saved only when rte_save_trace() is called, or does
it also automatically save when the buffer becomes full?

>From my understanding, rte_save_trace() is invoked when the application
executes rte_eal_cleanup(). Does this mean the target application needs to
explicitly support tracing by calling rte_save_trace()—perhaps at regular
intervals—to dump the trace buffer to disk? Otherwise, will we only get a
fragment of the trace saved during rte_eal_cleanup() execution?

Thank you for clarifying this point.

Best,
Adel

Re: [EXTERNAL] Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-28 Thread Jason Wang 
On Thu, Nov 28, 2024 at 12:32 PM Gowrishankar Muthukrishnan
 wrote:
>
> Hi Jason,
> > Hello:
> >
> > On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan
> >  wrote:
> > >
> > > Hi,
> > > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK.
> >
> > I wonder what kind of vDPA device you are using? Is there a marvell specific
> > vDPA or just a standard virtio-pci device via vp-vdpa.
> >
> Yes, we have Marvell specific vDPA.
> https://github.com/ColinIanKing/linux-next/commit/8b6c724cdab85d8923dd8c474a5a9464228379c5
>

Right, I'm asking since it claims to support networking device only:

static struct virtio_device_id id_table[] = {
{ VIRTIO_ID_NET, VIRTIO_DEV_ANY_ID },
{ 0 },
};

Thanks

> Thanks,
> Gowrishankar
> > Thanks
>

[PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-28 Thread Anatoly Burakov 
On some systems, even though NUMA nodes may be present in sysfs, the lspci
command will not have NUMANode keys in them, which will cause an exception.
Fix to check if NUMANode keys are available in lspci output before enabling
NUMA node output.

Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node")

Signed-off-by: Anatoly Burakov 
---
 usertools/dpdk-devbind.py | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 34f8f3ed3b..8a4aac371c 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -113,7 +113,16 @@
 
 # check if this system has NUMA support
 def is_numa():
-return os.path.exists('/sys/devices/system/node')
+if not os.path.exists("/sys/devices/system/node"):
+return False
+# occasionally, system may report NUMA support but lspci will not, so we
+# want to go through all devices and see if any of them do not have 
NUMANode
+# property - this will mean it is not safe to try to access it
+for device_dict in devices.values():
+if "NUMANode" not in device_dict:
+return False
+# all checks passed
+return True
 
 
 # check if a specific kernel module is loaded
-- 
2.43.5