Re: [PATCH V3 1/7] mailmap: update user name

[Raslan Darawsheh]

Hi,

From: Minggang(Gavin) Li 
Sent: Tuesday, October 29, 2024 4:31 PM
To: Slava Ovsiienko; Matan Azrad; Ori Kam; NBU-Contact-Thomas Monjalon 
(EXTERNAL)
Cc: dev@dpdk.org; Raslan Darawsheh
Subject: [PATCH V3 1/7] mailmap: update user name

Signed-off-by: Minggang Li(Gavin) 
---
 .mailmap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 504c390f0f..0ce965084c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -462,7 +462,6 @@ Gary Mussar 
 Gaurav Singh 
 Gautam Dawar 
 Gavin Hu  
-Gavin Li 
 Geoffrey Le Gourriérec 
 Geoffrey Lv 
 Geoff Thorpe 
@@ -1024,6 +1023,7 @@ Mike Ximing Chen 
 Milena Olech 
 Min Cao 
 Minghuan Lian 
+Minggang Li(Gavin) 
 Mingjin Ye 
 Mingshan Zhang 
 Mingxia Liu 
--
2.34.1

Series applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

Re: [PATCH 0/3] net/mlx5: fix mingw link issues

[Raslan Darawsheh]

Hi,

From: Dariusz Sosnowski 
Sent: Wednesday, October 30, 2024 12:54 PM
To: Raslan Darawsheh; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan 
Azrad
Cc: dev@dpdk.org
Subject: [PATCH 0/3] net/mlx5: fix mingw link issues

This patchset fixes link issues with MinGW which appear in next-net-mlx-main 
tree.
It is based on commit 69461d18dfd5 ("net/mlx5/hws: fix TC to TOS fields mapping 
in NAT64").

Dariusz Sosnowski (3):
  net/mlx5: fix mingw stubs link issue in flow creation
  net/mlx5: fix mingw stubs link issue in flow destroy
  net/mlx5: fix stub for HWS context validation

 drivers/net/mlx5/meson.build  |  8 +++-
 drivers/net/mlx5/mlx5_flow.c  |  7 ---
 drivers/net/mlx5/mlx5_flow_hw_stubs.c | 22 +-
 3 files changed, 24 insertions(+), 13 deletions(-)

--
2.39.5


series squashed into relevant commits in next-net-mlx,

Kindest regards,
Raslan Darawsheh

[PATCH] crypto/qat: fix ecdsa session handling

[Arkadiusz Kusztal]

Fixed a problem with setting the key in the session
in the ECDSA alghoritm.

Fixes: badc0c6f6d6a ("cryptodev: set private and public keys in EC session")
Cc: sta...@dpdk.org

Signed-off-by: Arkadiusz Kusztal 
---
 drivers/crypto/qat/qat_asym.c | 42 +++
 1 file changed, 42 insertions(+)

diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index 9e97582e22..d404fe48c0 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -1346,6 +1346,46 @@ session_set_rsa(struct qat_asym_session *qat_session,
return ret;
 }
 
+static int
+session_set_ecdsa(struct qat_asym_session *qat_session,
+   struct rte_crypto_asym_xform *xform)
+{
+   uint8_t *pkey = xform->ec.pkey.data;
+   uint8_t *q_x = xform->ec.q.x.data;
+   uint8_t *q_y = xform->ec.q.y.data;
+
+   qat_session->xform.ec.pkey.data =
+   rte_malloc(NULL, xform->ec.pkey.length, 0);
+   if (qat_session->xform.ec.pkey.data == NULL)
+   return -ENOMEM;
+   qat_session->xform.ec.q.x.data = rte_malloc(NULL,
+   xform->ec.q.x.length, 0);
+   if (qat_session->xform.ec.q.x.data == NULL) {
+   rte_free(qat_session->xform.ec.pkey.data);
+   return -ENOMEM;
+   }
+   qat_session->xform.ec.q.y.data = rte_malloc(NULL,
+   xform->ec.q.y.length, 0);
+   if (qat_session->xform.ec.q.y.data == NULL) {
+   rte_free(qat_session->xform.ec.pkey.data);
+   rte_free(qat_session->xform.ec.q.x.data);
+   return -ENOMEM;
+   }
+
+   rte_memcpy(qat_session->xform.ec.pkey.data, pkey,
+   xform->ec.pkey.length);
+   qat_session->xform.ec.pkey.length = xform->ec.pkey.length;
+   rte_memcpy(qat_session->xform.ec.q.x.data, q_x,
+   xform->ec.q.x.length);
+   qat_session->xform.ec.q.x.length = xform->ec.q.x.length;
+   rte_memcpy(qat_session->xform.ec.q.y.data, q_y,
+   xform->ec.q.y.length);
+   qat_session->xform.ec.q.y.length = xform->ec.q.y.length;
+   qat_session->xform.ec.curve_id = xform->ec.curve_id;
+
+   return 0;
+}
+
 static void
 session_set_ec(struct qat_asym_session *qat_session,
struct rte_crypto_asym_xform *xform)
@@ -1384,6 +1424,8 @@ qat_asym_session_configure(struct rte_cryptodev *dev 
__rte_unused,
}
break;
case RTE_CRYPTO_ASYM_XFORM_ECDSA:
+   ret = session_set_ecdsa(qat_session, xform);
+   break;
case RTE_CRYPTO_ASYM_XFORM_ECPM:
case RTE_CRYPTO_ASYM_XFORM_ECDH:
session_set_ec(qat_session, xform);
-- 
2.34.1

[PATCH] crypto/qat: fix an unset length of modexp/inv

[Arkadiusz Kusztal]

This commit fixes an unset length in modular algorithms
in QAT asymmetric crypto PMD.

Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions")
Cc: sta...@dpdk.org

Signed-off-by: Arkadiusz Kusztal 
---
 drivers/crypto/qat/qat_asym.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index 9e97582e22..7bb2f6c1e0 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -277,6 +277,7 @@ modexp_collect(struct rte_crypto_asym_op *asym_op,
rte_memcpy(modexp_result,
cookie->output_array[0] + alg_bytesize
- n.length, n.length);
+   asym_op->modex.result.length = alg_bytesize;
HEXDUMP("ModExp result", cookie->output_array[0],
alg_bytesize);
return RTE_CRYPTO_OP_STATUS_SUCCESS;
@@ -338,6 +339,7 @@ modinv_collect(struct rte_crypto_asym_op *asym_op,
- n.length),
cookie->output_array[0] + alg_bytesize
- n.length, n.length);
+   asym_op->modinv.result.length = alg_bytesize;
HEXDUMP("ModInv result", cookie->output_array[0],
alg_bytesize);
return RTE_CRYPTO_OP_STATUS_SUCCESS;
-- 
2.34.1

RE: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function

[Kusztal, ArkadiuszX]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Wednesday, October 23, 2024 2:47 AM
> To: Kusztal, ArkadiuszX 
> Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian
> 
> Subject: Re: [PATCH v6 2/3] crypto/qat: add sm2 encryption/decryption function
> 
> On Tue, 22 Oct 2024 20:05:59 +0100
> Arkadiusz Kusztal  wrote:
> 
> > +   uint32_t alg_bytesize = cookie->alg_bytesize;
> > +
> > +   rte_memcpy(asym_op->sm2.c1.x.data, cookie->output_array[0],
> alg_bytesize);
> > +   rte_memcpy(asym_op->sm2.c1.y.data, cookie->output_array[1],
> alg_bytesize);
> > +   rte_memcpy(asym_op->sm2.kp.x.data, cookie->output_array[2],
> alg_bytesize);
> > +   rte_memcpy(asym_op->sm2.kp.y.data, cookie->output_array[3],
> > +alg_bytesize);
> 
> Since the copy is small and not in the fast path, there is no reason to use
> rte_memcpy().
> The memcpy() function is as fast inlines and has more checking from gcc,
> coverity, ASAN so it is preferred.

This function is called by the crypto_dequeue_op_burst function and in some 
other cases (like RSA) there may be a 1024 bytes per copy operation.
If you think that a regular memcpy will do no worse there, I may change it.

Re: [PATCH v4 1/8] dts: add pydantic dependency

[Nicholas Pratte]

Reviewed-by: Nicholas Pratte 

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> As part of configuration validation and deserialization improvements,
> this adds pydantic as a project dependency. Pydantic is a library that
> caters to all of the aforementioned needs, while improving the process
> and code.
>
> Signed-off-by: Luca Vizzarro 
> Reviewed-by: Paul Szczepanek 
> ---
>  dts/poetry.lock| 171 -
>  dts/pyproject.toml |   1 +
>  2 files changed, 170 insertions(+), 2 deletions(-)
>
> diff --git a/dts/poetry.lock b/dts/poetry.lock
> index cf5f6569c6..56c50ad52c 100644
> --- a/dts/poetry.lock
> +++ b/dts/poetry.lock
> @@ -1,4 +1,4 @@
> -# This file is automatically @generated by Poetry 1.8.2 and should not be 
> changed by hand.
> +# This file is automatically @generated by Poetry 1.8.3 and should not be 
> changed by hand.
>
>  [[package]]
>  name = "aenum"
> @@ -23,6 +23,17 @@ files = [
>  {file = "alabaster-0.7.13.tar.gz", hash = 
> "sha256:a27a4a084d5e690e16e01e03ad2b2e552c61a65469419b907243193de1a84ae2"},
>  ]
>
> +[[package]]
> +name = "annotated-types"
> +version = "0.7.0"
> +description = "Reusable constraint types to use with typing.Annotated"
> +optional = false
> +python-versions = ">=3.8"
> +files = [
> +{file = "annotated_types-0.7.0-py3-none-any.whl", hash = 
> "sha256:1f02e8b43a8fbbc3f3e0d4f0f4bfc8131bcb4eebe8849b8e5c773f3a1c582a53"},
> +{file = "annotated_types-0.7.0.tar.gz", hash = 
> "sha256:aff07c09a53a08bc8cfccb9c85b05f1aa9a2a6f23728d790723543408344ce89"},
> +]
> +
>  [[package]]
>  name = "attrs"
>  version = "23.1.0"
> @@ -567,6 +578,16 @@ files = [
>  {file = "MarkupSafe-2.1.3-cp311-cp311-musllinux_1_1_x86_64.whl", hash = 
> "sha256:5bbe06f8eeafd38e5d0a4894ffec89378b6c6a625ff57e3028921f8ff59318ac"},
>  {file = "MarkupSafe-2.1.3-cp311-cp311-win32.whl", hash = 
> "sha256:dd15ff04ffd7e05ffcb7fe79f1b98041b8ea30ae9234aed2a9168b5797c3effb"},
>  {file = "MarkupSafe-2.1.3-cp311-cp311-win_amd64.whl", hash = 
> "sha256:134da1eca9ec0ae528110ccc9e48041e0828d79f24121a1a146161103c76e686"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-macosx_10_9_universal2.whl", hash 
> = "sha256:f698de3fd0c4e6972b92290a45bd9b1536bffe8c6759c62471efaa8acb4c37bc"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-macosx_10_9_x86_64.whl", hash = 
> "sha256:aa57bd9cf8ae831a362185ee444e15a93ecb2e344c8e52e4d721ea3ab6ef1823"},
> +{file = 
> "MarkupSafe-2.1.3-cp312-cp312-manylinux_2_17_aarch64.manylinux2014_aarch64.whl",
>  hash = 
> "sha256:ffcc3f7c66b5f5b7931a5aa68fc9cecc51e685ef90282f4a82f0f5e9b704ad11"},
> +{file = 
> "MarkupSafe-2.1.3-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl",
>  hash = 
> "sha256:47d4f1c5f80fc62fddd0d40a2e9dda0a05883ab11374334f6c4de38adffd"},
> +{file = 
> "MarkupSafe-2.1.3-cp312-cp312-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl",
>  hash = 
> "sha256:1f67c7038d560d92149c060157d623c542173016c4babc0c1913cca0564b9939"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-musllinux_1_1_aarch64.whl", hash = 
> "sha256:9aad3c1755095ce347e26488214ef77e0485a3c34a50c5a5e2471dff60b9dd9c"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-musllinux_1_1_i686.whl", hash = 
> "sha256:14ff806850827afd6b07a5f32bd917fb7f45b046ba40c57abdb636674a8b559c"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-musllinux_1_1_x86_64.whl", hash = 
> "sha256:8f9293864fe09b8149f0cc42ce56e3f0e54de883a9de90cd427f191c346eb2e1"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-win32.whl", hash = 
> "sha256:715d3562f79d540f251b99ebd6d8baa547118974341db04f5ad06d5ea3eb8007"},
> +{file = "MarkupSafe-2.1.3-cp312-cp312-win_amd64.whl", hash = 
> "sha256:1b8dd8c3fd14349433c79fa8abeb573a55fc0fdd769133baac1f5e07abf54aeb"},
>  {file = "MarkupSafe-2.1.3-cp37-cp37m-macosx_10_9_x86_64.whl", hash = 
> "sha256:8e254ae696c88d98da6555f5ace2279cf7cd5b3f52be2b5cf97feafe883b58d2"},
>  {file = 
> "MarkupSafe-2.1.3-cp37-cp37m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl",
>  hash = 
> "sha256:cb0932dc158471523c9637e807d9bfb93e06a95cbf010f1a38b98623b929ef2b"},
>  {file = 
> "MarkupSafe-2.1.3-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl", 
> hash = 
> "sha256:9402b03f1a1b4dc4c19845e5c749e3ab82d5078d16a2a4c2cd2df62d57bb0707"},
> @@ -762,6 +783,130 @@ files = [
>  {file = "pycparser-2.21.tar.gz", hash = 
> "sha256:e644fdec12f7872f86c58ff790da456218b10f863970249516d60a5eaca77206"},
>  ]
>
> +[[package]]
> +name = "pydantic"
> +version = "2.9.2"
> +description = "Data validation using Python type hints"
> +optional = false
> +python-versions = ">=3.8"
> +files = [
> +{file = "pydantic-2.9.2-py3-none-any.whl", hash = 
> "sha256:f048cec7b26778210e28a0459867920654d48e5e62db0958433636cde4254f12"},
> +{file = "pydantic-2.9.2.tar.gz", hash = 
> "sha256:d155cef71265d1e9807ed1c32b4c8deec042a44a50a4188b25ac67ecd81a9c0f"},
> +]
> +
> +[package.dependencies]
> +annotated-types = ">=0.6.0"
> +pydantic

Re: [PATCH v4 2/8] dts: add TestSuiteSpec class and discovery

[Nicholas Pratte]

Reviewed-by: Nicholas Pratte 

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> Currently there is a lack of a definition which identifies all the test
> suites available to test. This change intends to simplify the process to
> discover all the test suites and idenfity them.
>
> Signed-off-by: Luca Vizzarro 
> Reviewed-by: Paul Szczepanek 
> ---
>  dts/framework/runner.py   |   2 +-
>  dts/framework/test_suite.py   | 189 +++---
>  dts/framework/testbed_model/capability.py |  12 +-
>  3 files changed, 177 insertions(+), 26 deletions(-)
>
> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index 8bbe698eaf..195622c653 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -225,7 +225,7 @@ def _get_test_suites_with_cases(
>  for test_suite_config in test_suite_configs:
>  test_suite_class = 
> self._get_test_suite_class(test_suite_config.test_suite)
>  test_cases: list[type[TestCase]] = []
> -func_test_cases, perf_test_cases = 
> test_suite_class.get_test_cases(
> +func_test_cases, perf_test_cases = 
> test_suite_class.filter_test_cases(
>  test_suite_config.test_cases
>  )
>  if func:
> diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py
> index cbe3b30ffc..936eb2cede 100644
> --- a/dts/framework/test_suite.py
> +++ b/dts/framework/test_suite.py
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2010-2014 Intel Corporation
>  # Copyright(c) 2023 PANTHEON.tech s.r.o.
> +# Copyright(c) 2024 Arm Limited
>
>  """Features common to all test suites.
>
> @@ -16,13 +17,20 @@
>  import inspect
>  from collections import Counter
>  from collections.abc import Callable, Sequence
> +from dataclasses import dataclass
>  from enum import Enum, auto
> +from functools import cached_property
> +from importlib import import_module
>  from ipaddress import IPv4Interface, IPv6Interface, ip_interface
> +from pkgutil import iter_modules
> +from types import ModuleType
>  from typing import ClassVar, Protocol, TypeVar, Union, cast
>
> +from pydantic.alias_generators import to_pascal
>  from scapy.layers.inet import IP  # type: ignore[import-untyped]
>  from scapy.layers.l2 import Ether  # type: ignore[import-untyped]
>  from scapy.packet import Packet, Padding, raw  # type: ignore[import-untyped]
> +from typing_extensions import Self
>
>  from framework.testbed_model.capability import TestProtocol
>  from framework.testbed_model.port import Port
> @@ -33,7 +41,7 @@
>  PacketFilteringConfig,
>  )
>
> -from .exception import ConfigurationError, TestCaseVerifyError
> +from .exception import ConfigurationError, InternalError, TestCaseVerifyError
>  from .logger import DTSLogger, get_dts_logger
>  from .utils import get_packet_summaries
>
> @@ -112,10 +120,24 @@ def __init__(
>  self._tg_ip_address_ingress = ip_interface("192.168.101.3/24")
>
>  @classmethod
> -def get_test_cases(
> +def get_test_cases(cls) -> list[type["TestCase"]]:
> +"""A list of all the available test cases."""
> +
> +def is_test_case(function: Callable) -> bool:
> +if inspect.isfunction(function):
> +# TestCase is not used at runtime, so we can't use 
> isinstance() with `function`.
> +# But function.test_type exists.
> +if hasattr(function, "test_type"):
> +return isinstance(function.test_type, TestCaseType)
> +return False
> +
> +return [test_case for _, test_case in inspect.getmembers(cls, 
> is_test_case)]
> +
> +@classmethod
> +def filter_test_cases(
>  cls, test_case_sublist: Sequence[str] | None = None
>  ) -> tuple[set[type["TestCase"]], set[type["TestCase"]]]:
> -"""Filter `test_case_subset` from this class.
> +"""Filter `test_case_sublist` from this class.
>
>  Test cases are regular (or bound) methods decorated with 
> :func:`func_test`
>  or :func:`perf_test`.
> @@ -129,17 +151,8 @@ def get_test_cases(
>  as methods are bound to instances and this method only has 
> access to the class.
>
>  Raises:
> -ConfigurationError: If a test case from `test_case_subset` is 
> not found.
> +ConfigurationError: If a test case from `test_case_sublist` is 
> not found.
>  """
> -
> -def is_test_case(function: Callable) -> bool:
> -if inspect.isfunction(function):
> -# TestCase is not used at runtime, so we can't use 
> isinstance() with `function`.
> -# But function.test_type exists.
> -if hasattr(function, "test_type"):
> -return isinstance(function.test_type, TestCaseType)
> -return False
> -
>  if test_case_sublist is None:
>  test_case_sublist = []
>
> @@ -149,22 +162,22 @@ de

Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton

[Stephen Hemminger]

On Thu, 31 Oct 2024 07:47:51 +
王颢  wrote:

> Dear Stephen,
> 
> I have modified the code related to braces in the latest patch. Recently, I 
> was reviewing the DPDK Coding Style and found the reason why I initially 
> removed the redundant braces. If symmetrical braces are required, it would be 
> better to update the DPDK Coding Style accordingly.
> 
> in https://doc.dpdk.org/guides/contributing/coding_style.html
> Braces that are not necessary should be left out.
> 
> if (test)
> stmt;
> else if (bar) {
> stmt;
> stmt;
> } else
> stmt;
> 
> Best Regards,
> Howard Wang

Thanks, the DPDK inherits DPDK from the Linux kernel, and the Linux kernel
community sometimes changes and adds things.

[PATCH v1 1/2] app/testpmd: fix flow update

[Danylo Vodopianov]

The testpmd command “flow update…“ provides a nullptr as the
context variable.
Thus "flow aged  destroy" command can not
execute successfully.

Fix was done with next steps
1. Generate new port flow entry to add/replace action(s).
2. Set age contest if exists.
3. Replace flow in the flow list.

Fixes: 2d9c7e56e52c ("app/testpmd: support updating flow rule actions")

Signed-off-by: Danylo Vodopianov 
---
 app/test-pmd/config.c | 20 +++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 88770b4dfc..bf50f6adef 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3882,7 +3882,8 @@ port_flow_update(portid_t port_id, uint32_t rule_id,
 const struct rte_flow_action *actions, bool is_user_id)
 {
struct rte_port *port;
-   struct port_flow **flow_list;
+   struct port_flow **flow_list, *uf;
+   struct rte_flow_action_age *age = age_action_get(actions);
 
if (port_id_is_invalid(port_id, ENABLED_WARN) ||
port_id == (portid_t)RTE_PORT_ALL)
@@ -3897,6 +3898,16 @@ port_flow_update(portid_t port_id, uint32_t rule_id,
flow_list = &flow->next;
continue;
}
+
+   /* Update flow action(s) with new action(s) */
+   uf = port_flow_new(flow->rule.attr_ro, flow->rule.pattern_ro, 
actions, &error);
+   if (!uf)
+   return port_flow_complain(&error);
+   if (age) {
+   flow->age_type = ACTION_AGE_CONTEXT_TYPE_FLOW;
+   age->context = &flow->age_type;
+   }
+
/*
 * Poisoning to make sure PMDs update it in case
 * of error.
@@ -3913,6 +3924,13 @@ port_flow_update(portid_t port_id, uint32_t rule_id,
printf("Flow rule #%"PRIu64
   " updated with new actions\n",
   flow->id);
+
+   uf->next = flow->next;
+   uf->id = flow->id;
+   uf->flow = flow->flow;
+   *flow_list = uf;
+
+   free(flow);
return 0;
}
printf("Failed to find flow %"PRIu32"\n", rule_id);
-- 
2.43.5

[PATCH v1 2/2] app/testpmd: fix flow destroy

[Danylo Vodopianov]

Avoid removal of additional flows after requested number of flows has
been already removed.

Issue with removal of multiple flows is internal testpmd bug at
port_flow_destroy(). This function goes through all flows and compares
given flow ‘id’ with them. However in some cases it can advance pointer
with “given ID” and thus remove additional flow.

Fixes: de956d5ecf08 ("app/testpmd: support age shared action context")

Signed-off-by: Danylo Vodopianov 
---
 app/test-pmd/config.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index bf50f6adef..50c4b018c1 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -4170,8 +4170,12 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
   ctx.pf->rule.attr->ingress ? 'i' : '-',
   ctx.pf->rule.attr->egress ? 'e' : '-',
   ctx.pf->rule.attr->transfer ? 't' : '-');
+   /* use local copy of id as ctx.pf is freed by
+* port_flow_destroy() during processing
+*/
+   uint64_t flow_id = ctx.pf->id;
if (destroy && !port_flow_destroy(port_id, 1,
- &ctx.pf->id, false))
+ &flow_id, false))
total++;
break;
case ACTION_AGE_CONTEXT_TYPE_INDIRECT_ACTION:
-- 
2.43.5

[PATCH v1 0/2] Testpmd flow update/destroy fixes

[Danylo Vodopianov]

These patches provide next fixes:
1. The testpmd command “flow update…“ provides a nullptr as the
   context variable.
2. Avoid removal of additional flows after requested number of flows has
   been already removed.

Danylo Vodopianov (2):
  app/testpmd: fix flow update
  app/testpmd: fix flow destroy

 app/test-pmd/config.c | 26 --
 1 file changed, 24 insertions(+), 2 deletions(-)

-- 
2.43.5

Re: [PATCH v7] testpmd: add hairpin map parameter

[Stephen Hemminger]

On Thu, 31 Oct 2024 06:58:17 +0200
Gregory Etelson  wrote:

> Hairpin offloads packet forwarding between ports.
> Packet is expected on Rx port , Rx queue  and is forwarded
> to Tx port  Tx queue .
> 
> Testpmd implements a static hairpin configuration scheme.
> 
> The new parameter allows explicit selection of Rx and Tx ports and
> queues in hairpin configuration.
> The new `hairpin-map` parameter is provided with 5 parameters,
> separated by `:`
> 
> `--hairpin-map=Rx port id:Rx queue:Tx port id:Tx queue:queues number`
> 
> Testpmd operator can provide several `hairpin-map` parameters for
> different hairpin maps.
> Example:
> 
> dpdk-testpmd  -- \
>\
>   --rxq=2 --txq=2 --hairpinq=2 --hairpin-mode=0x12 \
>   --hairpin-map=0:2:1:2:1 \ # [1]
>   --hairpin-map=0:3:2:2:3   # [2]
> 
> Hairpin map [1] binds Rx port 0, queue 2 with Tx port 1, queue 2.
> Hairpin map [2] binds
>   Rx port 0, queue 3 with Tx port 2, queue 2,
>   Rx port 0, queue 4 with Tx port 2, queue 3,
>   Rx port 0, queue 5 with Tx port 2, queue 4.
> 
> The new `hairpin-map` parameter is optional.
> If omitted, testpmd will create "default" hairpin maps.
> 
> Signed-off-by: Gregory Etelson 
> Acked-by: Dariusz Sosnowski 

Acked-by: Stephen Hemminger 

[PATCH 1/1] Cn10K crypto Tests: Added Marvell Cn10K specific crypto Tests to TestCryptoPerfCryptodevPerf

[Gnanesh]

Changes included in this patch:
-- New TestCases are added for Cn10K CPT Hardware crypto accelerator.
-- when Testing newly added Testcases it is found Necessary to make Below 
Changes
  1> tests/cryptodev_common.py
   --> bind_qat_device function is updated to generate VFs for the 
given crypto_dev_id
   --> added New function bind_mrvl_devices to accept list of PCI 
Ids and bind it to vfio_pci driver.
  2> framework/crb.py
   --> updated pci_devices_information_uncached_linux Method to 
handle additional Nic Speeds for Cavium,
   as it was restricting only to 1 GIG NIC speed
  3> framework/settings.py
   --> Changed the default Cavium NIC driver to rvu_nicpf.
  4> nics/net_device.py
   --> added Missing expect object
  5> conf/crypto_perf_cryptodev_perf.cfg
   --> added Marvell Cn10K configs for crypto_perf_cryptodev_perf
  6> framework/ssh_pexpect.py
   --> output.replace command's output is not set before returning 
from get_output_all method
   hence Unnecessarily returning Prompt along with the output
  7> tests/TestSuite_crypto_perf_cryptodev_perf.py
   -->  added Marvell CN10K Testcases
 Updated Below Private functions
6.1> _run_crypto_perf() --> receives additional KW arguments
6.2> _parse_output()  ---> Updated to handle Marvell Cn10K app 
command output
6.3> _run_crypto_perf_throughput() --> receives additional KW 
arguments


Signed-off-by: Gnanesh 
---
 conf/crypto_perf_cryptodev_perf.cfg   | 849 ++
 framework/crb.py  |   6 +-
 framework/settings.py |   4 +-
 framework/ssh_pexpect.py  |   2 +-
 nics/net_device.py|   3 +
 tests/TestSuite_crypto_perf_cryptodev_perf.py | 322 ++-
 tests/cryptodev_common.py |  11 +-
 7 files changed, 1172 insertions(+), 25 deletions(-)

diff --git a/conf/crypto_perf_cryptodev_perf.cfg 
b/conf/crypto_perf_cryptodev_perf.cfg
index f0c86a45..c152ad69 100644
--- a/conf/crypto_perf_cryptodev_perf.cfg
+++ b/conf/crypto_perf_cryptodev_perf.cfg
@@ -365,3 +365,852 @@ auth-op="generate"
 auth-key-sz=16
 auth-iv-sz=16
 digest-sz=4
+
+# Marvell Cn10K configs
+[test_perf_mrvl_aes_cbc]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-only"
+cipher-algo="aes-cbc"
+cipher-op="encrypt"
+cipher-key-sz="16"
+cipher-iv-sz="16"
+csv-friendly="True"
+
+[test_perf_mrvl_aes_gcm_encrypt]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="aead"
+aead-algo="aes-gcm"
+aead-op="encrypt"
+aead-key-sz="16"
+aead-iv-sz="12"
+aead-aad-sz="16"
+digest-sz="16"
+csv-friendly="True"
+
+[test_perf_mrvl_aes_cbc_cipher_then_auth]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-then-auth"
+cipher-algo="aes-cbc"
+cipher-op="encrypt"
+cipher-key-sz="32"
+cipher-iv-sz="16"
+auth-algo="sha1-hmac"
+auth-op="generate"
+auth-key-sz="64"
+digest-sz="20"
+csv-friendly="True"
+
+[test_perf_mrvl_aes_sha2_256_cipher_then_auth]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-then-auth"
+cipher-algo="aes-cbc"
+cipher-op="encrypt"
+cipher-key-sz="32"
+cipher-iv-sz="16"
+auth-algo="sha2-256"
+auth-op="generate"
+auth-key-sz="0"
+digest-sz="32"
+csv-friendly="True"
+
+[test_perf_mrvl_zuc_eea3_cipher_only]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-only"
+cipher-algo="zuc-eea3"
+cipher-op="encrypt"
+cipher-key-sz="16"
+cipher-iv-sz="16"
+csv-friendly="True"
+
+[test_perf_mrvl_zuc_eia3_auth_only]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="auth-only"
+auth-algo="zuc-eia3"
+auth-op="generate"
+auth-key-sz="16"
+auth-iv-sz="16"
+digest-sz="4"
+csv-friendly="True"
+
+[test_perf_mrvl_aes_gmac_auth_only]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="auth-only"
+auth-algo="aes-gmac"
+auth-op="generate"
+auth-key-sz="32"
+auth-iv-sz="12"
+digest-sz="16"
+csv-friendly="True"
+
+[test_perf_mrvl_null_cipher_only]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-only"
+cipher-algo="null"
+cipher-op="encrypt"
+cipher-key-sz="0"
+cipher-iv-sz="0"
+csv-friendly="True"
+
+[test_perf_mrvl_snow3g_uea2_cipher_only]
+silent="True"
+ptest="throughput"
+pool-sz="16384"
+total-ops="1000"
+burst-sz="32"
+optype="cipher-only"
+cipher-algo="snow3g-uea2"
+cipher-op="encrypt"
+cipher-key-sz="16"
+cipher-iv-sz="16"
+csv-friendly="True"
+
+[test_perf_mrvl_kasumi_f8_cipher_only]
+silent="True"
+ptest="throughput"
+pool-s

来自Huichao Cai的邮件

[Huichao Cai]

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: 
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EB02345C14;
Wed, 30 Oct 2024 13:13:05 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BD9794332E;
Wed, 30 Oct 2024 13:13:05 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173])
 by mails.dpdk.org (Postfix) with ESMTP id 58E324331C
 for ; Wed, 30 Oct 2024 13:13:04 +0100 (CET)
Received: from pps.filterd (m0431383.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49UB9BWb015545;
 Wed, 30 Oct 2024 05:12:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=
 cc:content-transfer-encoding:content-type:date:from:message-id
 :mime-version:subject:to; s=pfpt0220; bh=Qna+Tl4Us8yV2mGu69Z0Q+o
 RwNGhZqpD/aOsuKM1n9M=; b=bWIRNPAJVuM5o2Vta9LIUlsUhIGUt7ASp4yG6Pp
 FbPTfQYCKNLQjd8WIqz9gyx1Mk4CtZeXL5eIz7+lgdh+vKQZTBqsOxBttbC98IF1
 fcamlG1UG6lZ2vZ1ePdynavoqizyLGTruVAtBjJeqiosFYqoAF+z8Sq3leLvCnhC
 8dqKDiGh4u1CpKZTuiFyTiE39QBkATf6uoArLwpmuz0F0EMBmfyOdmhhOL0lUCAD
 tUhWNd4lrbtrT9VD5b1yLH1ZTyWUFpfkwJQOPHUivqFUizQk5dV3+Lvo4uhHwYZs
 aTml6Wlbfm5SRa+gltjmTJasHMr/BBIggyAdc9StDkv/aCA==
Received: from dc5-exch05.marvell.com ([199.233.59.128])
 by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42kdenrw2j-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Wed, 30 Oct 2024 05:12:53 -0700 (PDT)
Received: from DC5-EXCH05.marvell.com (10.69.176.209) by
 DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.1544.4; Wed, 30 Oct 2024 05:12:51 -0700
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com
 (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend
 Transport; Wed, 30 Oct 2024 05:12:51 -0700
Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com
 [10.28.164.106])
 by maili.marvell.com (Postfix) with ESMTP id CD2E85E6870;
 Wed, 30 Oct 2024 05:12:49 -0700 (PDT)
From: 
To: , Kiran Kumar K , "Nithin
 Dabilpuram" , Zhirun Yan 
CC: , Pavan Nikhilesh 
Subject: [PATCH] graph: fix memory leak in node clone
Date: Wed, 30 Oct 2024 17:42:47 +0530
Message-ID: <20241030121247.1400-1-pbhagavat...@marvell.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-GUID: cKDmExrVHYVonAF3pzidWFxHYyFlc2DX
X-Proofpoint-ORIG-GUID: cKDmExrVHYVonAF3pzidWFxHYyFlc2DX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475
 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions 
List-Unsubscribe: ,
 
List-Archive: 
List-Post: 
List-Help: 
List-Subscribe: ,
 
Errors-To: dev-boun...@dpdk.org

From: Pavan Nikhilesh 

Free memory allocated for the node when xstats memory
allocation fails.

Coverity issue: 445529
Fixes: 070db97e017b ("graph: support node xstats")

Signed-off-by: Pavan Nikhilesh 
---
 lib/graph/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/graph/node.c b/lib/graph/node.c
index f15922892e..eb685b409f 100644
--- a/lib/graph/node.c
+++ b/lib/graph/node.c
@@ -156,7 +156,7 @@ node_clone(struct node *node, const char *name)
 (node->xstats->nb_xstats * 
RTE_NODE_XSTAT_DESC_SIZE));
if (reg->xstats == NULL) {
rte_errno = ENOMEM;
-   goto fail;
+   goto free;
}
 
for (i = 0; i < node->xstats->nb_xstats; i++)
-- 
2.25.1
There is one more place in the node_clone function that needs to be modified:   
if (clone_name(reg->name, node->name, name))
//goto free;
goto free_xstat;

[PATCH v02] net/af_packet: add rollover and defrag options

[Gur Stavi]

net_af_packet PMD multi "queue" support relies on Linux FANOUT capability.
Linux FANOUT is a SW based load balancer that is similar to HW RSS which
is more common for DPDK PMDs. Instead of multiple HW descriptor queues,
AF PACKET uses multiple sockets.
HW RSS will typically drop a packet if its selected RX queue is empty.
However, Linux FANOUT, as a SW load balancer, can be configured to avoid
this packet drop by rolling over to the next socket.
This rollover functionality was ALWAYS enabled in net_af_packet. It is
surrounded by ifdef, but only to allow compilation on ancient Linux
versions that did not have it.

Since DPDK applications are usually designed for HW based PMDs, this
rollover functionality, which the developers are likely unaware of, could
be confusing.

Another option that is part of Linux FANOUT is DEFRAG that instructs Linux
to compose complete IP packet out of fragments before delivering it to the
PACKET socket. Again, this behavior typically does not exist for HW based
PMDs and may confuse users.

This patch adds 2 options to control these features:
rollover=[0|1],defrag=[0|1]
For backward compatibility both features are enabled by default even
though most users will probably want both of them disabled.

Signed-off-by: Gur Stavi 
---
v2:
* Improve error handling for parsing of arg strings. Add a wrapper around
  strtoul to replace atoi.
* Fix checkpatch indentation error due to copy-paste.

v1: https://mails.dpdk.org/archives/dev/2024-October/307451.html
---
 doc/guides/nics/af_packet.rst |  4 ++
 drivers/net/af_packet/rte_eth_af_packet.c | 77 ++-
 2 files changed, 65 insertions(+), 16 deletions(-)

diff --git a/doc/guides/nics/af_packet.rst b/doc/guides/nics/af_packet.rst
index 66b977e1a2..4bc748b50b 100644
--- a/doc/guides/nics/af_packet.rst
+++ b/doc/guides/nics/af_packet.rst
@@ -29,6 +29,8 @@ Some of these, in turn, will be used to configure the 
PACKET_MMAP settings.
 *   ``framesz`` - PACKET_MMAP frame size (optional, default 2048B; Note: 
multiple
 of 16B);
 *   ``framecnt`` - PACKET_MMAP frame count (optional, default 512).
+*   ``rollover`` - disable(0)/enable(1) PACKET_FANOUT_ROLLOVER (optional, 
default 1).
+*   ``defrag`` - disable(0)/enable(1) PACKET_FANOUT_FLAG_DEFRAG (optional, 
default 1).

 Because this implementation is based on PACKET_MMAP, and PACKET_MMAP has its
 own pre-requisites, it should be noted that the inner workings of PACKET_MMAP
@@ -47,6 +49,8 @@ For the full details behind PACKET_MMAP's structures and 
settings, consider
 reading the `PACKET_MMAP documentation in the Kernel
 `_.

+For details of ``rollover`` anb ``defrag`` refer to the *packet(7)* man page.
+
 Prerequisites
 -

diff --git a/drivers/net/af_packet/rte_eth_af_packet.c 
b/drivers/net/af_packet/rte_eth_af_packet.c
index 68870dd3e2..1a043e8398 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -36,6 +36,8 @@
 #define ETH_AF_PACKET_FRAMESIZE_ARG"framesz"
 #define ETH_AF_PACKET_FRAMECOUNT_ARG   "framecnt"
 #define ETH_AF_PACKET_QDISC_BYPASS_ARG "qdisc_bypass"
+#define ETH_AF_PACKET_ROLLOVER "rollover"
+#define ETH_AF_PACKET_DEFRAG   "defrag"

 #define DFLT_FRAME_SIZE(1 << 11)
 #define DFLT_FRAME_COUNT   (1 << 9)
@@ -91,6 +93,8 @@ static const char *valid_arguments[] = {
ETH_AF_PACKET_FRAMESIZE_ARG,
ETH_AF_PACKET_FRAMECOUNT_ARG,
ETH_AF_PACKET_QDISC_BYPASS_ARG,
+   ETH_AF_PACKET_ROLLOVER,
+   ETH_AF_PACKET_DEFRAG,
NULL
 };

@@ -659,6 +663,20 @@ open_packet_iface(const char *key __rte_unused,
return 0;
 }

+static int
+uint_arg_parse(const char *arg_str, unsigned int *arg_val)
+{
+   unsigned long val;
+   char *endptr;
+
+   val = strtoul(arg_str, &endptr, 10);
+   if (*arg_str == '\0' || *endptr != '\0')
+   return -EINVAL;
+
+   *arg_val = val;
+   return 0;
+}
+
 static int
 rte_pmd_init_internals(struct rte_vdev_device *dev,
const int sockfd,
@@ -676,6 +694,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
const unsigned int numa_node = dev->device.numa_node;
struct rte_eth_dev_data *data = NULL;
struct rte_kvargs_pair *pair = NULL;
+   const char *ifname = NULL;
struct ifreq ifr;
size_t ifnamelen;
unsigned k_idx;
@@ -686,6 +705,8 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
int rc, tpver, discard;
int qsockfd = -1;
unsigned int i, q, rdsize;
+   unsigned int rollover = 1;
+   unsigned int defrag = 1;
 #if defined(PACKET_FANOUT)
int fanout_arg;
 #endif
@@ -693,9 +714,30 @@ rte_pmd_init_internals(struct rte_vdev_device *dev,
for (k_idx = 0; k_idx < kvlist->count; k_idx++) {
pair = &kvlist->pairs[k_idx];
if (strstr(pair->key, ETH_AF_PAC

RE: RFC - Tap io_uring PMD

[Morten Brørup]

> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 30 October 2024 22.57
> 
> The current tap device is slow both due to architectural choices and
> the
> overhead of Linux system calls.

Yes; but isn't it only being used for (low volume) management traffic?
Is the TAP PMD performance an issue for anyone? What is their use case?

Or is the key issue that the TAP PMD makes system calls in the fast path, so 
you are looking to implement a new TAP PMD that doesn't make any system calls 
in the fast path?

> I am exploring a how to fix that but
> some
> of the choices require some tradeoffs. Which leads to some open
> questions:
> 
> 1. DPDK tap also support tunnel (TUN) mode where there is no Ethernet
> header
>only L3. Does anyone actually use this? It is different than what
> every other
>PMD expects.

If used for high volume (data plane) traffic, I would assume standard PMD 
behavior (i.e. incl. Ethernet headers) would suffice.

> 
> 2. The fastest way to use kernel TAP device would be to use io_uring.
>But this was added in 5.1 kernel (2019). Rather than having
> conditional or
>dual mode in DPDK tap device, perhaps there should just be a new PMD
> tap_uring?

If the features differ significantly, I'm in favor of a new PMD.
And it would be an opportunity to get rid of useless cruft, which I think you 
are already asking about here. :-)

Furthermore, a "clean sheet" implementation - adding all the experience 
accumulated since the old TAP PMD - could serve as showcase for "best 
practices" for software PMDs.

> 
> 3. Current TAP device provides hooks for several rte_flow types by
> playing
>games with kernel qdisc. Does anyone really use this? Propose just
> not doing
>this in new tap_uring.
> 
> 4. What other features of TAP device beyond basic send/receive make
> sense?
>It looks like new device could support better statistics.

IMHO, statistics about missed packets are relevant. If the ingress 
(kernel->DPDK) queue is full, and the kernel has to drop packets, this drop 
counter should be exposed to the application through the PMD.

I don't know if the existing TAP PMD supports it, but associating a port/queue 
with a "network namespace" or VRF in the kernel could also be relevant.

> 
> 5. What about Rx interrupt support?

RX interrupt support seems closely related to power management.
It could be used to reduce jitter/latency (and burstiness) when someone on the 
network communicates with an in-band management interface.

> 
> Probably the hardest part of using io_uring is figuring out how to
> collect
> completions. The simplest way would be to handle all completions rx and
> tx
> in the rx_burst function.

Please don't mix RX and TX, unless explicitly requested by the application 
through the recently introduced "mbuf recycle" feature.


Currently, rte_rx() does two jobs:
* Deliver packets received from the HW to the application.
* Replenish RX descriptors.

Similarly, rte_tx() does two jobs:
* Deliver packets to be transmitted from the application to the HW.
* Release completed TX descriptors.

It would complicate things, but these two associated jobs could be separated 
into separate functions, rx_pre_rx() for RX replenishment and tx_post_tx() for 
TX completion.
This would also give latency sensitive applications more control over when to 
do what.
And it could introduce a TX completion interrupt.


Why does this PMD need to handle TX completions differently than other PMDs?

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[David Marchand]

On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi  wrote:
>
> On Thu, 31 Oct 2024 at 12:52, David Marchand  
> wrote:
> >
> > On Thu, Oct 31, 2024 at 1:47 PM David Marchand
> >  wrote:
> > > Could you share a backtrace when hitting this deadlock?
> >
> > If the backtrace is not possible, running with
> > --log-level=lib.eal:debug may help.
>
> I cannot get backtraces. This runs via "meson test", how can that
> option be passed in?

# meson test -C build-debian --suite fast-tests --verbose -t 5
--test-args=--log-level=lib.eal:debug


-- 
David Marchand

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[Luca Boccassi]

On Thu, 31 Oct 2024 at 13:04, David Marchand  wrote:
>
> On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi  wrote:
> >
> > On Thu, 31 Oct 2024 at 12:52, David Marchand  
> > wrote:
> > >
> > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand
> > >  wrote:
> > > > Could you share a backtrace when hitting this deadlock?
> > >
> > > If the backtrace is not possible, running with
> > > --log-level=lib.eal:debug may help.
> >
> > I cannot get backtraces. This runs via "meson test", how can that
> > option be passed in?
>
> # meson test -C build-debian --suite fast-tests --verbose -t 5
> --test-args=--log-level=lib.eal:debug

https://paste.debian.net/1334095/

Re: [PATCH 0/6] reduce number of warnings being disabled

[Bruce Richardson]

On Wed, Oct 30, 2024 at 06:17:12PM +, Konstantin Ananyev wrote:
> 
> 
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Wednesday, October 30, 2024 5:38 PM
> > To: dev@dpdk.org
> > Cc: Bruce Richardson 
> > Subject: [PATCH 0/6] reduce number of warnings being disabled
> > 
> > for historical reasons, many drivers had extra warnings disabled,
> > especially in their base code directory. Many, but not all, of these
> > warning disabling flags are unnecessary so remove as many as we can.
> > 
> > Bruce Richardson (6):
> >   net/i40e/base: remove warning disable flags
> >   net/ice/base: remove warning disable flag
> >   net/e1000/base: remove warning disable flags
> >   net/iavf: remove warning disable flag
> >   net/fm10k/base: remove warning disable flags
> >   common/idpf/base: remove warning disable flags
> > 
> >  drivers/common/idpf/base/meson.build | 13 -
> >  drivers/net/e1000/base/meson.build   |  7 ---
> >  drivers/net/fm10k/base/meson.build   |  6 +++---
> >  drivers/net/i40e/base/meson.build|  9 +
> >  drivers/net/iavf/meson.build |  2 --
> >  drivers/net/ice/base/meson.build |  1 -
> >  6 files changed, 20 insertions(+), 18 deletions(-)
> > 
> > --
> 
> Series-Acked-by: Konstantin Ananyev 
>
Series applied to dpdk-next-net-intel.

@Konstantin: FYI, when running checks on the patches, I get warnings that the
address you used to ack the patches is not your main email address in
.mailmap. Not sure if you want to update your primary email in that file?

/Bruce

Re: [PATCH] graph: fix memory leak in node clone

[Huichao Cai]

There is one more place in the node_clone function that needs to be modified:
if (clone_name(reg->name, node->name, name))
//goto free;
goto free_xstat;


从 Windows 版邮件发送

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[David Marchand]

Hello Luca,

>
> This commit introduced a regression on arm64, causing a deadlock.
> lcores_autotest gets stuck and never terminates:
>
> [ 1077s] EAL: Detected CPU lcores: 4
> [ 1077s] EAL: Detected NUMA nodes: 1
> [ 1077s] EAL: Detected shared linkage of DPDK
> [ 1077s] EAL: Multi-process socket /tmp/dpdk/rte/mp_socket
> [ 1077s] EAL: Selected IOVA mode 'VA'
> [ 1077s] APP: HPET is not enabled, using TSC as default timer
> [ 1077s] RTE>>lcores_autotest
> [ 1127s] DPDK:fast-tests / lcores_autotest time out (After 50.0 seconds)
>
> This is 100% reproducible when running the fast tests suite
> after a package build on OBS. Reverting it reliably fixes the
> issue.
>
> This reverts commit b28c6196b132d1f25cb8c1bf781520fc41556b3a.
>
> Signed-off-by: Luca Boccassi 
> ---
> v2: add forgotten signed-off-by
>
> I have bisected this long standing issue and identified the commit
> that introduced it. If anybody can provide a different fix that would
> be better, but if it's not possible to find another solution, it would
> be good to revert it until it can be found, to resolve the regression.

Thanks for tracking this down.

There is one issue with reverting: iirc, it reintroduces a race / double-free.

Could you share a backtrace when hitting this deadlock?

On my side, I am not able to catch it neither on x86 nor in a ARM vm I borrowed.

I built dpdk manually in a Debian 12 container, trying to mimick OBS
cflags & friends.
# rm -rf build-debian; CC='ccache gcc' meson setup build-debian
-Dmachine=default -Dbuildtype=plain -Ddefault_library=shared
-Dc_args='-O2 -fstack-protector-strong -Wformat
-Werror=format-security -Werror -Wdate-time -D_FORTIFY_SOURCE=2' &&
ninja -C build-debian && meson test -C build-debian --suite fast-tests
--verbose -t 5
...
36/81 DPDK:fast-tests / lcores_autotest RUNNING
>>> LD_LIBRARY_PATH=/root/dpdk/build-debian/lib:/root/dpdk/build-debian/drivers 
>>> MALLOC_PERTURB_=90 DPDK_TEST=lcores_autotest 
>>> /root/dpdk/build-debian/app/dpdk-test --no-huge -m 2048 -d 
>>> /root/dpdk/build-debian/drivers

✀  

EAL: Detected CPU lcores: 3
EAL: Detected NUMA nodes: 1
EAL: Detected shared linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
VIRTIO_INIT: eth_virtio_pci_init(): Failed to init PCI device
PCI_BUS: Requested device :01:00.0 cannot be used
APP: HPET is not enabled, using TSC as default timer
RTE>>lcores_autotest
EAL threads count: 3, RTE_MAX_LCORE=256
lcore 0, socket 0, role RTE, cpuset 0
lcore 1, socket 0, role RTE, cpuset 1
lcore 2, socket 0, role RTE, cpuset 2
non-EAL threads count: 253
Warning: could not register new thread (this might be expected during
this test), reason Cannot allocate memory
non-EAL threads count: 254
Warning: could not register new thread (this might be expected during
this test), reason Cannot allocate memory
lcore 0, socket 0, role RTE, cpuset 0
lcore 1, socket 0, role RTE, cpuset 1
lcore 2, socket 0, role RTE, cpuset 2
lcore 3, socket 0, role NON_EAL, cpuset 0
lcore 0, socket 0, role RTE, cpuset 0
lcore 1, socket 0, role RTE, cpuset 1
lcore 2, socket 0, role RTE, cpuset 2
Control thread running successfully
Test OK
RTE>>
36/81 DPDK:fast-tests / lcores_autotest OK  1.87s



This vm runs on:
# lspcu
Architecture: aarch64
  CPU op-mode(s): 32-bit, 64-bit
  Byte Order: Little Endian
CPU(s):   3
  On-line CPU(s) list:0-2
Vendor ID:ARM
  BIOS Vendor ID: QEMU
  Model name: Neoverse-N1
BIOS Model name:  virt-rhel8.6.0  CPU @ 2.0GHz
...


-- 
David Marchand

[PATCH v9 3/9] net/zxdh: add zxdh device pci init implementation

[Junlong Wang]

Add device pci init implementation,
to obtain PCI capability and read configuration, etc.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/meson.build   |   1 +
 drivers/net/zxdh/zxdh_ethdev.c |  43 +
 drivers/net/zxdh/zxdh_ethdev.h |  18 ++-
 drivers/net/zxdh/zxdh_pci.c| 278 +
 drivers/net/zxdh/zxdh_pci.h| 138 
 drivers/net/zxdh/zxdh_queue.h  | 109 +
 drivers/net/zxdh/zxdh_rxtx.h   |  55 +++
 7 files changed, 641 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/zxdh/zxdh_pci.c
 create mode 100644 drivers/net/zxdh/zxdh_pci.h
 create mode 100644 drivers/net/zxdh/zxdh_queue.h
 create mode 100644 drivers/net/zxdh/zxdh_rxtx.h

diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build
index 932fb1c835..7db4e7bc71 100644
--- a/drivers/net/zxdh/meson.build
+++ b/drivers/net/zxdh/meson.build
@@ -15,4 +15,5 @@ endif
 
 sources = files(
 'zxdh_ethdev.c',
+'zxdh_pci.c',
 )
diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index c911284423..5c747882a7 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -8,6 +8,40 @@
 
 #include "zxdh_ethdev.h"
 #include "zxdh_logs.h"
+#include "zxdh_pci.h"
+
+struct zxdh_hw_internal zxdh_hw_internal[RTE_MAX_ETHPORTS];
+
+static int32_t zxdh_init_device(struct rte_eth_dev *eth_dev)
+{
+   struct zxdh_hw *hw = eth_dev->data->dev_private;
+   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
+   int ret = 0;
+
+   ret = zxdh_read_pci_caps(pci_dev, hw);
+   if (ret) {
+   PMD_INIT_LOG(ERR, "port 0x%x pci caps read failed .", 
hw->port_id);
+   goto err;
+   }
+
+   zxdh_hw_internal[hw->port_id].zxdh_vtpci_ops = &zxdh_dev_pci_ops;
+   zxdh_pci_reset(hw);
+   zxdh_get_pci_dev_config(hw);
+
+   rte_ether_addr_copy((struct rte_ether_addr *)hw->mac_addr, 
ð_dev->data->mac_addrs[0]);
+
+   /* If host does not support both status and MSI-X then disable LSC */
+   if (vtpci_with_feature(hw, ZXDH_NET_F_STATUS) && hw->use_msix != 
ZXDH_MSIX_NONE)
+   eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
+   else
+   eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC;
+
+   return 0;
+
+err:
+   PMD_INIT_LOG(ERR, "port %d init device failed", eth_dev->data->port_id);
+   return ret;
+}
 
 static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
 {
@@ -45,6 +79,15 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
hw->is_pf = 1;
}
 
+   ret = zxdh_init_device(eth_dev);
+   if (ret < 0)
+   goto err_zxdh_init;
+
+   return ret;
+
+err_zxdh_init:
+   rte_free(eth_dev->data->mac_addrs);
+   eth_dev->data->mac_addrs = NULL;
return ret;
 }
 
diff --git a/drivers/net/zxdh/zxdh_ethdev.h b/drivers/net/zxdh/zxdh_ethdev.h
index a11e3624a9..a22ac15065 100644
--- a/drivers/net/zxdh/zxdh_ethdev.h
+++ b/drivers/net/zxdh/zxdh_ethdev.h
@@ -5,6 +5,7 @@
 #ifndef ZXDH_ETHDEV_H
 #define ZXDH_ETHDEV_H
 
+#include 
 #include "ethdev_driver.h"
 
 #ifdef __cplusplus
@@ -24,15 +25,30 @@ extern "C" {
 #define ZXDH_MAX_MAC_ADDRS(ZXDH_MAX_UC_MAC_ADDRS + 
ZXDH_MAX_MC_MAC_ADDRS)
 
 #define ZXDH_NUM_BARS 2
+#define ZXDH_RX_QUEUES_MAX128U
+#define ZXDH_TX_QUEUES_MAX128U
 
 struct zxdh_hw {
struct rte_eth_dev *eth_dev;
-   uint64_t bar_addr[ZXDH_NUM_BARS];
+   struct zxdh_pci_common_cfg *common_cfg;
+   struct zxdh_net_config *dev_cfg;
 
+   uint64_t bar_addr[ZXDH_NUM_BARS];
+   uint64_t host_features;
+   uint64_t guest_features;
+   uint32_t max_queue_pairs;
uint32_t speed;
+   uint32_t notify_off_multiplier;
+   uint16_t *notify_base;
+   uint16_t pcie_id;
uint16_t device_id;
uint16_t port_id;
 
+   uint8_t *isr;
+   uint8_t weak_barriers;
+   uint8_t use_msix;
+   uint8_t mac_addr[RTE_ETHER_ADDR_LEN];
+
uint8_t duplex;
uint8_t is_pf;
 };
diff --git a/drivers/net/zxdh/zxdh_pci.c b/drivers/net/zxdh/zxdh_pci.c
new file mode 100644
index 00..a88d620f30
--- /dev/null
+++ b/drivers/net/zxdh/zxdh_pci.c
@@ -0,0 +1,278 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "zxdh_ethdev.h"
+#include "zxdh_pci.h"
+#include "zxdh_logs.h"
+#include "zxdh_queue.h"
+
+#define ZXDH_PMD_DEFAULT_GUEST_FEATURES   \
+   (1ULL << ZXDH_NET_F_MRG_RXBUF | \
+1ULL << ZXDH_NET_F_STATUS| \
+1ULL << ZXDH_NET_F_MQ| \
+1ULL << ZXDH_F_ANY_LAYOUT| \
+1ULL << ZXDH_F_VERSION_1 | \
+1ULL << ZXDH_F_RING_PACKED   | \
+1ULL << ZXDH_F_IN_ORDER  | \
+1ULL << ZXDH_F_NOTIFICATION_DATA | \
+1ULL << ZXDH_NET_F_MAC)
+
+static void zxdh_read_dev_c

[PATCH v9 5/9] net/zxdh: add msg chan enable implementation

[Junlong Wang]

Add msg chan enable implementation to support
send msg to backend(device side) get infos.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/zxdh_ethdev.c |   6 +
 drivers/net/zxdh/zxdh_ethdev.h |  12 +
 drivers/net/zxdh/zxdh_msg.c| 647 -
 drivers/net/zxdh/zxdh_msg.h| 131 ++-
 4 files changed, 790 insertions(+), 6 deletions(-)

diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index da454cdff3..21255b2190 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -97,6 +97,12 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
goto err_zxdh_init;
}
 
+   ret = zxdh_msg_chan_enable(eth_dev);
+   if (ret != 0) {
+   PMD_INIT_LOG(ERR, "zxdh_msg_bar_chan_enable failed ret %d", 
ret);
+   goto err_zxdh_init;
+   }
+
return ret;
 
 err_zxdh_init:
diff --git a/drivers/net/zxdh/zxdh_ethdev.h b/drivers/net/zxdh/zxdh_ethdev.h
index 20ead56e44..7434cc15d7 100644
--- a/drivers/net/zxdh/zxdh_ethdev.h
+++ b/drivers/net/zxdh/zxdh_ethdev.h
@@ -28,10 +28,22 @@ extern "C" {
 #define ZXDH_RX_QUEUES_MAX128U
 #define ZXDH_TX_QUEUES_MAX128U
 
+union zxdh_virport_num {
+   uint16_t vport;
+   struct {
+   uint16_t vfid:8;
+   uint16_t pfid:3;
+   uint16_t vf_flag:1;
+   uint16_t epid:3;
+   uint16_t direct_flag:1;
+   };
+};
+
 struct zxdh_hw {
struct rte_eth_dev *eth_dev;
struct zxdh_pci_common_cfg *common_cfg;
struct zxdh_net_config *dev_cfg;
+   union zxdh_virport_num vport;
 
uint64_t bar_addr[ZXDH_NUM_BARS];
uint64_t host_features;
diff --git a/drivers/net/zxdh/zxdh_msg.c b/drivers/net/zxdh/zxdh_msg.c
index 9dcf99f1f7..4f6607fcb0 100644
--- a/drivers/net/zxdh/zxdh_msg.c
+++ b/drivers/net/zxdh/zxdh_msg.c
@@ -17,6 +17,7 @@
 
 #define ZXDH_REPS_INFO_FLAG_USABLE  0x00
 #define ZXDH_BAR_SEQID_NUM_MAX  256
+#define ZXDH_REPS_INFO_FLAG_USED0xa0
 
 #define ZXDH_PCIEID_IS_PF_MASK  (0x0800)
 #define ZXDH_PCIEID_PF_IDX_MASK (0x0700)
@@ -33,15 +34,88 @@
 #define ZXDH_MAX_EP_NUM  (4)
 #define ZXDH_MAX_HARD_SPINLOCK_NUM   (511)
 
+#define ZXDH_LOCK_PRIMARY_ID_MASK   (0x8000)
+/* bar offset */
+#define ZXDH_BAR0_CHAN_RISC_OFFSET  (0x2000)
+#define ZXDH_BAR0_CHAN_PFVF_OFFSET  (0x3000)
 #define ZXDH_BAR0_SPINLOCK_OFFSET   (0x4000)
 #define ZXDH_FW_SHRD_OFFSET (0x5000)
 #define ZXDH_FW_SHRD_INNER_HW_LABEL_PAT (0x800)
 #define ZXDH_HW_LABEL_OFFSET   \
(ZXDH_FW_SHRD_OFFSET + ZXDH_FW_SHRD_INNER_HW_LABEL_PAT)
 
+#define ZXDH_CHAN_RISC_SPINLOCK_OFFSET \
+   (ZXDH_BAR0_SPINLOCK_OFFSET - ZXDH_BAR0_CHAN_RISC_OFFSET)
+#define ZXDH_CHAN_PFVF_SPINLOCK_OFFSET \
+   (ZXDH_BAR0_SPINLOCK_OFFSET - ZXDH_BAR0_CHAN_PFVF_OFFSET)
+#define ZXDH_CHAN_RISC_LABEL_OFFSET\
+   (ZXDH_HW_LABEL_OFFSET - ZXDH_BAR0_CHAN_RISC_OFFSET)
+#define ZXDH_CHAN_PFVF_LABEL_OFFSET\
+   (ZXDH_HW_LABEL_OFFSET - ZXDH_BAR0_CHAN_PFVF_OFFSET)
+
+#define ZXDH_REPS_HEADER_LEN_OFFSET  1
+#define ZXDH_REPS_HEADER_PAYLOAD_OFFSET  4
+#define ZXDH_REPS_HEADER_REPLYED 0xff
+
+#define ZXDH_BAR_MSG_CHAN_USABLE  0
+#define ZXDH_BAR_MSG_CHAN_USED1
+
+#define ZXDH_BAR_MSG_POL_MASK (0x10)
+#define ZXDH_BAR_MSG_POL_OFFSET   (4)
+
+#define ZXDH_BAR_ALIGN_WORD_MASK   0xfffc
+#define ZXDH_BAR_MSG_VALID_MASK1
+#define ZXDH_BAR_MSG_VALID_OFFSET  0
+
+#define ZXDH_BAR_PF_NUM 7
+#define ZXDH_BAR_VF_NUM 256
+#define ZXDH_BAR_INDEX_PF_TO_VF 0
+#define ZXDH_BAR_INDEX_MPF_TO_MPF   0xff
+#define ZXDH_BAR_INDEX_MPF_TO_PFVF  0
+#define ZXDH_BAR_INDEX_PFVF_TO_MPF  0
+
+#define ZXDH_MAX_HARD_SPINLOCK_ASK_TIMES  (1000)
+#define ZXDH_SPINLOCK_POLLING_SPAN_US (100)
+
+#define ZXDH_BAR_MSG_SRC_NUM   3
+#define ZXDH_BAR_MSG_SRC_MPF   0
+#define ZXDH_BAR_MSG_SRC_PF1
+#define ZXDH_BAR_MSG_SRC_VF2
+#define ZXDH_BAR_MSG_SRC_ERR   0xff
+#define ZXDH_BAR_MSG_DST_NUM   3
+#define ZXDH_BAR_MSG_DST_RISC  0
+#define ZXDH_BAR_MSG_DST_MPF   2
+#define ZXDH_BAR_MSG_DST_PFVF  1
+#define ZXDH_BAR_MSG_DST_ERR   0xff
+
+#define ZXDH_LOCK_TYPE_HARD(1)
+#define ZXDH_LOCK_TYPE_SOFT(0)
+#define ZXDH_BAR_INDEX_TO_RISC  0
+
+#define ZXDH_BAR_CHAN_INDEX_SEND  0
+#define ZXDH_BAR_CHAN_INDEX_RECV  1
+
+uint8_t subchan_id_tbl[ZXDH_BAR_MSG_SRC_NUM][ZXDH_BAR_MSG_DST_NUM] = {
+   {ZXDH_BAR_CHAN_INDEX_SEND, ZXDH_BAR_CHAN_INDEX_SEND, 
ZXDH_BAR_CHAN_INDEX_SEND},
+   {ZXDH_BAR_CHAN_INDEX_SEND, ZXDH_BAR_CHAN_INDEX_SEND, 
ZXDH_BAR_CHAN_INDEX_RECV},
+   {ZXDH_BAR_CHAN_INDEX_SEND, ZXDH_BAR_CHAN_INDEX_RECV, 
ZXDH_BAR_CHAN_INDEX_RECV}
+};
+
+uint8_t chan_id_tbl[ZXDH_BAR_MSG_SRC_NUM][ZXDH_BAR_MSG_DST_NUM] = {
+   {ZXDH_BAR_INDEX_TO_RISC, ZXDH_BAR_INDEX_MPF_TO_PFVF, 
ZXDH_BAR_INDEX_MPF_TO_MPF},
+   {ZXDH_BAR_INDEX_TO_RISC, ZXDH_BAR_INDEX_PF_TO_VF,   
ZXDH_BAR_INDEX_PFVF_TO_MPF},
+  

[PATCH v9 0/9] net/zxdh: introduce net zxdh driver

[Junlong Wang]

v9:
  - fix 'v8 3/9' patch use PCI bus API,
and common PCI constants according to David Marchand's comments.

v8:
  - fix flexible arrays、Waddress-of-packed-member error.
  - all structs、enum、define ,etc use zxdh/ZXDH_ prefixed.
  - use zxdh_try/release_lock,and move loop into zxdh_timedlock,
make hardware lock follow spinlock pattern.

v7:
  - add release notes and modify zxdh.rst issues.
  - avoid use pthread and use rte_spinlock_lock.
  - using the prefix ZXDH_ before some definitions.
  - resole issues according to thomas's comments.

v6:
  - Resolve ci/intel compilation issues.
  - fix meson.build indentation in earlier patch.

V5:
  - split driver into multiple patches,part of the zxdh driver,
later provide dev start/stop,queue_setup,npsdk_init,mac,vlan,rss ,etc.
  - fix errors reported by scripts.
  - move the product link in zxdh.rst.
  - fix meson check use RTE_ARCH_X86_64/RTE_ARCH_ARM64.
  - modify other comments according to Ferruh's comments.

Junlong Wang (9):
  net/zxdh: add zxdh ethdev pmd driver
  net/zxdh: add logging implementation
  net/zxdh: add zxdh device pci init implementation
  net/zxdh: add msg chan and msg hwlock init
  net/zxdh: add msg chan enable implementation
  net/zxdh: add zxdh get device backend infos
  net/zxdh: add configure zxdh intr implementation
  net/zxdh: add zxdh dev infos get ops
  net/zxdh: add zxdh dev configure ops

 MAINTAINERS|   6 +
 doc/guides/nics/features/zxdh.ini  |   9 +
 doc/guides/nics/index.rst  |   1 +
 doc/guides/nics/zxdh.rst   |  31 +
 doc/guides/rel_notes/release_24_11.rst |   4 +
 drivers/net/meson.build|   1 +
 drivers/net/zxdh/meson.build   |  22 +
 drivers/net/zxdh/zxdh_common.c | 385 ++
 drivers/net/zxdh/zxdh_common.h |  42 ++
 drivers/net/zxdh/zxdh_ethdev.c | 994 +
 drivers/net/zxdh/zxdh_ethdev.h | 102 +++
 drivers/net/zxdh/zxdh_logs.h   |  40 +
 drivers/net/zxdh/zxdh_msg.c| 986 
 drivers/net/zxdh/zxdh_msg.h| 229 ++
 drivers/net/zxdh/zxdh_pci.c| 402 ++
 drivers/net/zxdh/zxdh_pci.h| 175 +
 drivers/net/zxdh/zxdh_queue.c  | 123 +++
 drivers/net/zxdh/zxdh_queue.h  | 281 +++
 drivers/net/zxdh/zxdh_rxtx.h   |  55 ++
 19 files changed, 3888 insertions(+)
 create mode 100644 doc/guides/nics/features/zxdh.ini
 create mode 100644 doc/guides/nics/zxdh.rst
 create mode 100644 drivers/net/zxdh/meson.build
 create mode 100644 drivers/net/zxdh/zxdh_common.c
 create mode 100644 drivers/net/zxdh/zxdh_common.h
 create mode 100644 drivers/net/zxdh/zxdh_ethdev.c
 create mode 100644 drivers/net/zxdh/zxdh_ethdev.h
 create mode 100644 drivers/net/zxdh/zxdh_logs.h
 create mode 100644 drivers/net/zxdh/zxdh_msg.c
 create mode 100644 drivers/net/zxdh/zxdh_msg.h
 create mode 100644 drivers/net/zxdh/zxdh_pci.c
 create mode 100644 drivers/net/zxdh/zxdh_pci.h
 create mode 100644 drivers/net/zxdh/zxdh_queue.c
 create mode 100644 drivers/net/zxdh/zxdh_queue.h
 create mode 100644 drivers/net/zxdh/zxdh_rxtx.h

-- 
2.27.0

[PATCH v9 1/9] net/zxdh: add zxdh ethdev pmd driver

[Junlong Wang]

Add basic zxdh ethdev init and register PCI probe functions
Update doc files.

Signed-off-by: Junlong Wang 
---
 MAINTAINERS|  6 ++
 doc/guides/nics/features/zxdh.ini  |  9 +++
 doc/guides/nics/index.rst  |  1 +
 doc/guides/nics/zxdh.rst   | 31 +
 doc/guides/rel_notes/release_24_11.rst |  4 ++
 drivers/net/meson.build|  1 +
 drivers/net/zxdh/meson.build   | 18 +
 drivers/net/zxdh/zxdh_ethdev.c | 92 ++
 drivers/net/zxdh/zxdh_ethdev.h | 44 
 9 files changed, 206 insertions(+)
 create mode 100644 doc/guides/nics/features/zxdh.ini
 create mode 100644 doc/guides/nics/zxdh.rst
 create mode 100644 drivers/net/zxdh/meson.build
 create mode 100644 drivers/net/zxdh/zxdh_ethdev.c
 create mode 100644 drivers/net/zxdh/zxdh_ethdev.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 8919d78919..a5534be2ab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1051,6 +1051,12 @@ F: drivers/net/virtio/
 F: doc/guides/nics/virtio.rst
 F: doc/guides/nics/features/virtio*.ini
 
+ZTE zxdh
+M: Lijie Shan 
+F: drivers/net/zxdh/
+F: doc/guides/nics/zxdh.rst
+F: doc/guides/nics/features/zxdh.ini
+
 Wind River AVP
 M: Steven Webster 
 M: Matt Peters 
diff --git a/doc/guides/nics/features/zxdh.ini 
b/doc/guides/nics/features/zxdh.ini
new file mode 100644
index 00..05c8091ed7
--- /dev/null
+++ b/doc/guides/nics/features/zxdh.ini
@@ -0,0 +1,9 @@
+;
+; Supported features of the 'zxdh' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux= Y
+x86-64   = Y
+ARMv8= Y
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index c14bc7988a..8e371ac4a5 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -69,3 +69,4 @@ Network Interface Controller Drivers
 vhost
 virtio
 vmxnet3
+zxdh
diff --git a/doc/guides/nics/zxdh.rst b/doc/guides/nics/zxdh.rst
new file mode 100644
index 00..920ff5175e
--- /dev/null
+++ b/doc/guides/nics/zxdh.rst
@@ -0,0 +1,31 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2024 ZTE Corporation.
+
+ZXDH Poll Mode Driver
+==
+
+The ZXDH PMD (**librte_net_zxdh**) provides poll mode driver support
+for 25/100 Gbps ZXDH NX Series Ethernet Controller based on
+the ZTE Ethernet Controller E310/E312.
+
+- Learn about ZXDH NX Series Ethernet Controller NICs using
+  ``_.
+
+Features
+
+
+Features of the ZXDH PMD are:
+
+- Multi arch support: x86_64, ARMv8.
+
+
+Driver compilation and testing
+--
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC 
`
+for details.
+
+Limitations or Known issues
+---
+
+X86-32, Power8, ARMv7, RISC-V, Windows and BSD are not supported yet.
diff --git a/doc/guides/rel_notes/release_24_11.rst 
b/doc/guides/rel_notes/release_24_11.rst
index 15b64a1829..dd9048d561 100644
--- a/doc/guides/rel_notes/release_24_11.rst
+++ b/doc/guides/rel_notes/release_24_11.rst
@@ -162,6 +162,10 @@ New Features
   * Added initialization of FPGA modules related to flow HW offload.
   * Added basic handling of the virtual queues.
 
+* **Updated ZTE zxdh net driver.**
+
+  * Added ethdev driver support for zxdh NX Series Ethernet Controller.
+
 * **Added cryptodev queue pair reset support.**
 
   A new API ``rte_cryptodev_queue_pair_reset`` is added
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index fb6d34b782..0a12914534 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -62,6 +62,7 @@ drivers = [
 'vhost',
 'virtio',
 'vmxnet3',
+'zxdh',
 ]
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std
diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build
new file mode 100644
index 00..932fb1c835
--- /dev/null
+++ b/drivers/net/zxdh/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 ZTE Corporation
+
+if not is_linux
+build = false
+reason = 'only supported on Linux'
+subdir_done()
+endif
+
+if not dpdk_conf.has('RTE_ARCH_X86_64') or not dpdk_conf.get('RTE_ARCH_64')
+build = false
+reason = 'only supported on x86_64 and aarch64'
+subdir_done()
+endif
+
+sources = files(
+'zxdh_ethdev.c',
+)
diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
new file mode 100644
index 00..5b6c9ec1bf
--- /dev/null
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -0,0 +1,92 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include 
+#include 
+#include 
+
+#include "zxdh_ethdev.h"
+
+static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
+{
+  

[PATCH v9 8/9] net/zxdh: add zxdh dev infos get ops

[Junlong Wang]

Add support for zxdh infos get.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/zxdh_ethdev.c | 44 +-
 drivers/net/zxdh/zxdh_ethdev.h |  2 ++
 2 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index 2f8190a428..bbdbda3457 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -26,6 +26,43 @@ uint16_t zxdh_vport_to_vfid(union zxdh_virport_num v)
return (v.epid * 8 + v.pfid) + 1152;
 }
 
+static int32_t zxdh_dev_infos_get(struct rte_eth_dev *dev,
+   struct rte_eth_dev_info *dev_info)
+{
+   struct zxdh_hw *hw = dev->data->dev_private;
+
+   dev_info->speed_capa   = rte_eth_speed_bitflag(hw->speed, 
RTE_ETH_LINK_FULL_DUPLEX);
+   dev_info->max_rx_queues= RTE_MIN(hw->max_queue_pairs, 
ZXDH_RX_QUEUES_MAX);
+   dev_info->max_tx_queues= RTE_MIN(hw->max_queue_pairs, 
ZXDH_TX_QUEUES_MAX);
+   dev_info->min_rx_bufsize   = ZXDH_MIN_RX_BUFSIZE;
+   dev_info->max_rx_pktlen= ZXDH_MAX_RX_PKTLEN;
+   dev_info->max_mac_addrs= ZXDH_MAX_MAC_ADDRS;
+   dev_info->rx_offload_capa  = (RTE_ETH_RX_OFFLOAD_VLAN_STRIP |
+   RTE_ETH_RX_OFFLOAD_VLAN_FILTER |
+   RTE_ETH_RX_OFFLOAD_QINQ_STRIP);
+   dev_info->rx_offload_capa |= (RTE_ETH_RX_OFFLOAD_IPV4_CKSUM |
+   RTE_ETH_RX_OFFLOAD_UDP_CKSUM |
+   RTE_ETH_RX_OFFLOAD_TCP_CKSUM |
+   RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM);
+   dev_info->rx_offload_capa |= (RTE_ETH_RX_OFFLOAD_SCATTER);
+   dev_info->rx_offload_capa |=  RTE_ETH_RX_OFFLOAD_TCP_LRO;
+   dev_info->rx_offload_capa |=  RTE_ETH_RX_OFFLOAD_RSS_HASH;
+
+   dev_info->tx_offload_capa = (RTE_ETH_TX_OFFLOAD_MULTI_SEGS);
+   dev_info->tx_offload_capa |= (RTE_ETH_TX_OFFLOAD_TCP_TSO |
+   RTE_ETH_TX_OFFLOAD_UDP_TSO);
+   dev_info->tx_offload_capa |= (RTE_ETH_TX_OFFLOAD_VLAN_INSERT |
+   RTE_ETH_TX_OFFLOAD_QINQ_INSERT |
+   RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO);
+   dev_info->tx_offload_capa |= (RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |
+   RTE_ETH_TX_OFFLOAD_UDP_CKSUM |
+   RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
+   RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+   RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM);
+
+   return 0;
+}
+
 static void zxdh_queues_unbind_intr(struct rte_eth_dev *dev)
 {
struct zxdh_hw *hw = dev->data->dev_private;
@@ -321,6 +358,11 @@ static int32_t zxdh_configure_intr(struct rte_eth_dev *dev)
return ret;
 }
 
+/* dev_ops for zxdh, bare necessities for basic operation */
+static const struct eth_dev_ops zxdh_eth_dev_ops = {
+   .dev_infos_get   = zxdh_dev_infos_get,
+};
+
 static int32_t zxdh_init_device(struct rte_eth_dev *eth_dev)
 {
struct zxdh_hw *hw = eth_dev->data->dev_private;
@@ -377,7 +419,7 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
struct zxdh_hw *hw = eth_dev->data->dev_private;
int ret = 0;
 
-   eth_dev->dev_ops = NULL;
+   eth_dev->dev_ops = &zxdh_eth_dev_ops;
 
/* Allocate memory for storing MAC addresses */
eth_dev->data->mac_addrs = rte_zmalloc("zxdh_mac",
diff --git a/drivers/net/zxdh/zxdh_ethdev.h b/drivers/net/zxdh/zxdh_ethdev.h
index 65726f3a20..89c5a9bb5f 100644
--- a/drivers/net/zxdh/zxdh_ethdev.h
+++ b/drivers/net/zxdh/zxdh_ethdev.h
@@ -29,6 +29,8 @@ extern "C" {
 #define ZXDH_NUM_BARS 2
 #define ZXDH_RX_QUEUES_MAX128U
 #define ZXDH_TX_QUEUES_MAX128U
+#define ZXDH_MIN_RX_BUFSIZE   64
+#define ZXDH_MAX_RX_PKTLEN14000U
 
 union zxdh_virport_num {
uint16_t vport;
-- 
2.27.0

[PATCH v9 7/9] net/zxdh: add configure zxdh intr implementation

[Junlong Wang]

configure zxdh intr include risc,dtb. and release intr.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/zxdh_ethdev.c | 301 +
 drivers/net/zxdh/zxdh_ethdev.h |   6 +
 drivers/net/zxdh/zxdh_msg.c| 188 
 drivers/net/zxdh/zxdh_msg.h|  16 +-
 drivers/net/zxdh/zxdh_pci.c|  26 +++
 drivers/net/zxdh/zxdh_pci.h|  11 ++
 6 files changed, 546 insertions(+), 2 deletions(-)

diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index 23af69fece..2f8190a428 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -11,6 +11,7 @@
 #include "zxdh_pci.h"
 #include "zxdh_msg.h"
 #include "zxdh_common.h"
+#include "zxdh_queue.h"
 
 struct zxdh_hw_internal zxdh_hw_internal[RTE_MAX_ETHPORTS];
 
@@ -25,6 +26,301 @@ uint16_t zxdh_vport_to_vfid(union zxdh_virport_num v)
return (v.epid * 8 + v.pfid) + 1152;
 }
 
+static void zxdh_queues_unbind_intr(struct rte_eth_dev *dev)
+{
+   struct zxdh_hw *hw = dev->data->dev_private;
+   int32_t i;
+
+   for (i = 0; i < dev->data->nb_rx_queues; ++i) {
+   ZXDH_VTPCI_OPS(hw)->set_queue_irq(hw, hw->vqs[i * 2], 
ZXDH_MSI_NO_VECTOR);
+   ZXDH_VTPCI_OPS(hw)->set_queue_irq(hw, hw->vqs[i * 2 + 1], 
ZXDH_MSI_NO_VECTOR);
+   }
+}
+
+
+static int32_t zxdh_intr_unmask(struct rte_eth_dev *dev)
+{
+   struct zxdh_hw *hw = dev->data->dev_private;
+
+   if (rte_intr_ack(dev->intr_handle) < 0)
+   return -1;
+
+   hw->use_msix = zxdh_pci_msix_detect(RTE_ETH_DEV_TO_PCI(dev));
+
+   return 0;
+}
+
+static void zxdh_devconf_intr_handler(void *param)
+{
+   struct rte_eth_dev *dev = param;
+
+   if (zxdh_intr_unmask(dev) < 0)
+   PMD_DRV_LOG(ERR, "interrupt enable failed");
+}
+
+
+/* Interrupt handler triggered by NIC for handling specific interrupt. */
+static void zxdh_fromriscv_intr_handler(void *param)
+{
+   struct rte_eth_dev *dev = param;
+   struct zxdh_hw *hw = dev->data->dev_private;
+   uint64_t virt_addr = (uint64_t)(hw->bar_addr[ZXDH_BAR0_INDEX] + 
ZXDH_CTRLCH_OFFSET);
+
+   if (hw->is_pf) {
+   PMD_INIT_LOG(DEBUG, "zxdh_risc2pf_intr_handler");
+   zxdh_bar_irq_recv(ZXDH_MSG_CHAN_END_RISC, ZXDH_MSG_CHAN_END_PF, 
virt_addr, dev);
+   } else {
+   PMD_INIT_LOG(DEBUG, "zxdh_riscvf_intr_handler");
+   zxdh_bar_irq_recv(ZXDH_MSG_CHAN_END_RISC, ZXDH_MSG_CHAN_END_VF, 
virt_addr, dev);
+   }
+}
+
+/* Interrupt handler triggered by NIC for handling specific interrupt. */
+static void zxdh_frompfvf_intr_handler(void *param)
+{
+   struct rte_eth_dev *dev = param;
+   struct zxdh_hw *hw = dev->data->dev_private;
+   uint64_t virt_addr = (uint64_t)(hw->bar_addr[ZXDH_BAR0_INDEX] +
+   ZXDH_MSG_CHAN_PFVFSHARE_OFFSET);
+
+   if (hw->is_pf) {
+   PMD_INIT_LOG(DEBUG, "zxdh_vf2pf_intr_handler");
+   zxdh_bar_irq_recv(ZXDH_MSG_CHAN_END_VF, ZXDH_MSG_CHAN_END_PF, 
virt_addr, dev);
+   } else {
+   PMD_INIT_LOG(DEBUG, "zxdh_pf2vf_intr_handler");
+   zxdh_bar_irq_recv(ZXDH_MSG_CHAN_END_PF, ZXDH_MSG_CHAN_END_VF, 
virt_addr, dev);
+   }
+}
+
+static void zxdh_intr_cb_reg(struct rte_eth_dev *dev)
+{
+   struct zxdh_hw *hw = dev->data->dev_private;
+
+   if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+   rte_intr_callback_unregister(dev->intr_handle, 
zxdh_devconf_intr_handler, dev);
+
+   /* register callback to update dev config intr */
+   rte_intr_callback_register(dev->intr_handle, zxdh_devconf_intr_handler, 
dev);
+   /* Register rsic_v to pf interrupt callback */
+   struct rte_intr_handle *tmp = hw->risc_intr +
+   (ZXDH_MSIX_FROM_PFVF - ZXDH_MSIX_INTR_MSG_VEC_BASE);
+
+   rte_intr_callback_register(tmp, zxdh_frompfvf_intr_handler, dev);
+
+   tmp = hw->risc_intr + (ZXDH_MSIX_FROM_RISCV - 
ZXDH_MSIX_INTR_MSG_VEC_BASE);
+   rte_intr_callback_register(tmp, zxdh_fromriscv_intr_handler, dev);
+}
+
+static void zxdh_intr_cb_unreg(struct rte_eth_dev *dev)
+{
+   if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+   rte_intr_callback_unregister(dev->intr_handle, 
zxdh_devconf_intr_handler, dev);
+
+   struct zxdh_hw *hw = dev->data->dev_private;
+
+   /* register callback to update dev config intr */
+   rte_intr_callback_unregister(dev->intr_handle, 
zxdh_devconf_intr_handler, dev);
+   /* Register rsic_v to pf interrupt callback */
+   struct rte_intr_handle *tmp = hw->risc_intr +
+   (ZXDH_MSIX_FROM_PFVF - ZXDH_MSIX_INTR_MSG_VEC_BASE);
+
+   rte_intr_callback_unregister(tmp, zxdh_frompfvf_intr_handler, dev);
+   tmp = hw->risc_intr + (ZXDH_MSIX_FROM_RISCV - 
ZXDH_MSIX_INTR_MSG_VEC_BASE);
+   rte_intr_callback_unregister(tmp, zxdh_fromriscv_intr_handler, dev);
+}
+
+static int32_t zxdh_intr_disa

[PATCH v9 6/9] net/zxdh: add zxdh get device backend infos

[Junlong Wang]

Add zxdh get device backend infos,
use msg chan to send msg get.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/meson.build   |   1 +
 drivers/net/zxdh/zxdh_common.c | 250 +
 drivers/net/zxdh/zxdh_common.h |  30 
 drivers/net/zxdh/zxdh_ethdev.c |  35 +
 drivers/net/zxdh/zxdh_ethdev.h |   5 +
 drivers/net/zxdh/zxdh_msg.h|  21 +++
 6 files changed, 342 insertions(+)
 create mode 100644 drivers/net/zxdh/zxdh_common.c
 create mode 100644 drivers/net/zxdh/zxdh_common.h

diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build
index 2e0c8fddae..a16db47f89 100644
--- a/drivers/net/zxdh/meson.build
+++ b/drivers/net/zxdh/meson.build
@@ -17,4 +17,5 @@ sources = files(
 'zxdh_ethdev.c',
 'zxdh_pci.c',
 'zxdh_msg.c',
+'zxdh_common.c',
 )
diff --git a/drivers/net/zxdh/zxdh_common.c b/drivers/net/zxdh/zxdh_common.c
new file mode 100644
index 00..34749588d5
--- /dev/null
+++ b/drivers/net/zxdh/zxdh_common.c
@@ -0,0 +1,250 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include "zxdh_ethdev.h"
+#include "zxdh_logs.h"
+#include "zxdh_msg.h"
+#include "zxdh_common.h"
+
+#define ZXDH_MSG_RSP_SIZE_MAX 512
+
+#define ZXDH_COMMON_TABLE_READ0
+#define ZXDH_COMMON_TABLE_WRITE   1
+
+#define ZXDH_COMMON_FIELD_PHYPORT 6
+
+#define ZXDH_RSC_TBL_CONTENT_LEN_MAX  (257 * 2)
+
+#define ZXDH_REPS_HEADER_OFFSET   4
+#define ZXDH_TBL_MSG_PRO_SUCCESS  0xaa
+
+struct zxdh_common_msg {
+   uint8_t  type;/* 0:read table 1:write table */
+   uint8_t  field;
+   uint16_t pcie_id;
+   uint16_t slen;/* Data length for write table */
+   uint16_t reserved;
+} __rte_packed;
+
+struct zxdh_common_rsp_hdr {
+   uint8_t  rsp_status;
+   uint16_t rsp_len;
+   uint8_t  reserved;
+   uint8_t  payload_status;
+   uint8_t  rsv;
+   uint16_t payload_len;
+} __rte_packed;
+
+struct zxdh_tbl_msg_header {
+   uint8_t  type;  /* r/w */
+   uint8_t  field;
+   uint16_t pcieid;
+   uint16_t slen;
+   uint16_t rsv;
+};
+struct zxdh_tbl_msg_reps_header {
+   uint8_t  check;
+   uint8_t  rsv;
+   uint16_t len;
+};
+
+static int32_t zxdh_fill_common_msg(struct zxdh_hw *hw,
+   struct zxdh_pci_bar_msg *desc,
+   uint8_ttype,
+   uint8_tfield,
+   void  *buff,
+   uint16_t   buff_size)
+{
+   uint64_t msg_len = sizeof(struct zxdh_common_msg) + buff_size;
+
+   desc->payload_addr = rte_zmalloc(NULL, msg_len, 0);
+   if (unlikely(desc->payload_addr == NULL)) {
+   PMD_DRV_LOG(ERR, "Failed to allocate msg_data");
+   return -ENOMEM;
+   }
+   memset(desc->payload_addr, 0, msg_len);
+   desc->payload_len = msg_len;
+   struct zxdh_common_msg *msg_data = (struct zxdh_common_msg 
*)desc->payload_addr;
+
+   msg_data->type = type;
+   msg_data->field = field;
+   msg_data->pcie_id = hw->pcie_id;
+   msg_data->slen = buff_size;
+   if (buff_size != 0)
+   rte_memcpy(msg_data + 1, buff, buff_size);
+
+   return 0;
+}
+
+static int32_t zxdh_send_command(struct zxdh_hw *hw,
+   struct zxdh_pci_bar_msg  *desc,
+   enum ZXDH_BAR_MODULE_ID   module_id,
+   struct zxdh_msg_recviver_mem *msg_rsp)
+{
+   desc->virt_addr = (uint64_t)(hw->bar_addr[ZXDH_BAR0_INDEX] + 
ZXDH_CTRLCH_OFFSET);
+   desc->src = hw->is_pf ? ZXDH_MSG_CHAN_END_PF : ZXDH_MSG_CHAN_END_VF;
+   desc->dst = ZXDH_MSG_CHAN_END_RISC;
+   desc->module_id = module_id;
+   desc->src_pcieid = hw->pcie_id;
+
+   msg_rsp->buffer_len  = ZXDH_MSG_RSP_SIZE_MAX;
+   msg_rsp->recv_buffer = rte_zmalloc(NULL, msg_rsp->buffer_len, 0);
+   if (unlikely(msg_rsp->recv_buffer == NULL)) {
+   PMD_DRV_LOG(ERR, "Failed to allocate messages response");
+   return -ENOMEM;
+   }
+
+   if (zxdh_bar_chan_sync_msg_send(desc, msg_rsp) != ZXDH_BAR_MSG_OK) {
+   PMD_DRV_LOG(ERR, "Failed to send sync messages or receive 
response");
+   rte_free(msg_rsp->recv_buffer);
+   return -1;
+   }
+
+   return 0;
+}
+
+static int32_t zxdh_common_rsp_check(struct zxdh_msg_recviver_mem *msg_rsp,
+   void *buff, uint16_t len)
+{
+   struct zxdh_common_rsp_hdr *rsp_hdr = (struct zxdh_common_rsp_hdr 
*)msg_rsp->recv_buffer;
+
+   if (rsp_hdr->payload_status != 0xaa || rsp_hdr->payload_len != len) {
+   PMD_DRV_LOG(ERR, "Common response is invalid, status:0x%x 
rsp_len:%d",
+   rsp_hdr->payload_status, 
rsp_hdr->payload_len);
+

[PATCH v9 4/9] net/zxdh: add msg chan and msg hwlock init

[Junlong Wang]

Add msg channel and hwlock init implementation.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/meson.build   |   1 +
 drivers/net/zxdh/zxdh_ethdev.c |  15 +++
 drivers/net/zxdh/zxdh_ethdev.h |   1 +
 drivers/net/zxdh/zxdh_msg.c| 161 +
 drivers/net/zxdh/zxdh_msg.h|  67 ++
 5 files changed, 245 insertions(+)
 create mode 100644 drivers/net/zxdh/zxdh_msg.c
 create mode 100644 drivers/net/zxdh/zxdh_msg.h

diff --git a/drivers/net/zxdh/meson.build b/drivers/net/zxdh/meson.build
index 7db4e7bc71..2e0c8fddae 100644
--- a/drivers/net/zxdh/meson.build
+++ b/drivers/net/zxdh/meson.build
@@ -16,4 +16,5 @@ endif
 sources = files(
 'zxdh_ethdev.c',
 'zxdh_pci.c',
+'zxdh_msg.c',
 )
diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index 5c747882a7..da454cdff3 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -9,6 +9,7 @@
 #include "zxdh_ethdev.h"
 #include "zxdh_logs.h"
 #include "zxdh_pci.h"
+#include "zxdh_msg.h"
 
 struct zxdh_hw_internal zxdh_hw_internal[RTE_MAX_ETHPORTS];
 
@@ -83,9 +84,23 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
if (ret < 0)
goto err_zxdh_init;
 
+   ret = zxdh_msg_chan_init();
+   if (ret != 0) {
+   PMD_INIT_LOG(ERR, "Failed to init bar msg chan");
+   goto err_zxdh_init;
+   }
+   hw->msg_chan_init = 1;
+
+   ret = zxdh_msg_chan_hwlock_init(eth_dev);
+   if (ret != 0) {
+   PMD_INIT_LOG(ERR, "zxdh_msg_chan_hwlock_init failed ret %d", 
ret);
+   goto err_zxdh_init;
+   }
+
return ret;
 
 err_zxdh_init:
+   zxdh_bar_msg_chan_exit();
rte_free(eth_dev->data->mac_addrs);
eth_dev->data->mac_addrs = NULL;
return ret;
diff --git a/drivers/net/zxdh/zxdh_ethdev.h b/drivers/net/zxdh/zxdh_ethdev.h
index a22ac15065..20ead56e44 100644
--- a/drivers/net/zxdh/zxdh_ethdev.h
+++ b/drivers/net/zxdh/zxdh_ethdev.h
@@ -51,6 +51,7 @@ struct zxdh_hw {
 
uint8_t duplex;
uint8_t is_pf;
+   uint8_t msg_chan_init;
 };
 
 #ifdef __cplusplus
diff --git a/drivers/net/zxdh/zxdh_msg.c b/drivers/net/zxdh/zxdh_msg.c
new file mode 100644
index 00..9dcf99f1f7
--- /dev/null
+++ b/drivers/net/zxdh/zxdh_msg.c
@@ -0,0 +1,161 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "zxdh_ethdev.h"
+#include "zxdh_logs.h"
+#include "zxdh_msg.h"
+
+#define ZXDH_REPS_INFO_FLAG_USABLE  0x00
+#define ZXDH_BAR_SEQID_NUM_MAX  256
+
+#define ZXDH_PCIEID_IS_PF_MASK  (0x0800)
+#define ZXDH_PCIEID_PF_IDX_MASK (0x0700)
+#define ZXDH_PCIEID_VF_IDX_MASK (0x00ff)
+#define ZXDH_PCIEID_EP_IDX_MASK (0x7000)
+/* PCIEID bit field offset */
+#define ZXDH_PCIEID_PF_IDX_OFFSET   (8)
+#define ZXDH_PCIEID_EP_IDX_OFFSET   (12)
+
+#define ZXDH_MULTIPLY_BY_8(x)   ((x) << 3)
+#define ZXDH_MULTIPLY_BY_32(x)  ((x) << 5)
+#define ZXDH_MULTIPLY_BY_256(x) ((x) << 8)
+
+#define ZXDH_MAX_EP_NUM  (4)
+#define ZXDH_MAX_HARD_SPINLOCK_NUM   (511)
+
+#define ZXDH_BAR0_SPINLOCK_OFFSET   (0x4000)
+#define ZXDH_FW_SHRD_OFFSET (0x5000)
+#define ZXDH_FW_SHRD_INNER_HW_LABEL_PAT (0x800)
+#define ZXDH_HW_LABEL_OFFSET   \
+   (ZXDH_FW_SHRD_OFFSET + ZXDH_FW_SHRD_INNER_HW_LABEL_PAT)
+
+struct zxdh_dev_stat {
+   bool is_mpf_scanned;
+   bool is_res_init;
+   int16_t dev_cnt; /* probe cnt */
+};
+struct zxdh_dev_stat g_dev_stat = {0};
+
+struct zxdh_seqid_item {
+   void *reps_addr;
+   uint16_t id;
+   uint16_t buffer_len;
+   uint16_t flag;
+};
+
+struct zxdh_seqid_ring {
+   uint16_t cur_id;
+   rte_spinlock_t lock;
+   struct zxdh_seqid_item reps_info_tbl[ZXDH_BAR_SEQID_NUM_MAX];
+};
+struct zxdh_seqid_ring g_seqid_ring = {0};
+
+static uint16_t pcie_id_to_hard_lock(uint16_t src_pcieid, uint8_t dst)
+{
+   uint16_t lock_id = 0;
+   uint16_t pf_idx = (src_pcieid & ZXDH_PCIEID_PF_IDX_MASK) >> 
ZXDH_PCIEID_PF_IDX_OFFSET;
+   uint16_t ep_idx = (src_pcieid & ZXDH_PCIEID_EP_IDX_MASK) >> 
ZXDH_PCIEID_EP_IDX_OFFSET;
+
+   switch (dst) {
+   /* msg to risc */
+   case ZXDH_MSG_CHAN_END_RISC:
+   lock_id = ZXDH_MULTIPLY_BY_8(ep_idx) + pf_idx;
+   break;
+   /* msg to pf/vf */
+   case ZXDH_MSG_CHAN_END_VF:
+   case ZXDH_MSG_CHAN_END_PF:
+   lock_id = ZXDH_MULTIPLY_BY_8(ep_idx) + pf_idx +
+   ZXDH_MULTIPLY_BY_8(1 + ZXDH_MAX_EP_NUM);
+   break;
+   default:
+   lock_id = 0;
+   break;
+   }
+   if (lock_id >= ZXDH_MAX_HARD_SPINLOCK_NUM)
+   lock_id = 0;
+
+   return lock_id;
+}
+
+static void label_write(uint64_t label_lock_addr, uint32_t lock_id, uint16_t 
value)
+{
+   *(volatile uint1

[PATCH v9 2/9] net/zxdh: add logging implementation

[Junlong Wang]

Add zxdh logging implementation.

Signed-off-by: Junlong Wang 
---
 drivers/net/zxdh/zxdh_ethdev.c | 15 +++--
 drivers/net/zxdh/zxdh_logs.h   | 40 ++
 2 files changed, 53 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/zxdh/zxdh_logs.h

diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c
index 5b6c9ec1bf..c911284423 100644
--- a/drivers/net/zxdh/zxdh_ethdev.c
+++ b/drivers/net/zxdh/zxdh_ethdev.c
@@ -7,6 +7,7 @@
 #include 
 
 #include "zxdh_ethdev.h"
+#include "zxdh_logs.h"
 
 static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
 {
@@ -19,13 +20,18 @@ static int zxdh_eth_dev_init(struct rte_eth_dev *eth_dev)
/* Allocate memory for storing MAC addresses */
eth_dev->data->mac_addrs = rte_zmalloc("zxdh_mac",
ZXDH_MAX_MAC_ADDRS * RTE_ETHER_ADDR_LEN, 0);
-   if (eth_dev->data->mac_addrs == NULL)
+   if (eth_dev->data->mac_addrs == NULL) {
+   PMD_INIT_LOG(ERR, "Failed to allocate %d bytes store MAC 
addresses",
+   ZXDH_MAX_MAC_ADDRS * RTE_ETHER_ADDR_LEN);
return -ENOMEM;
+   }
 
memset(hw, 0, sizeof(*hw));
hw->bar_addr[0] = (uint64_t)pci_dev->mem_resource[0].addr;
-   if (hw->bar_addr[0] == 0)
+   if (hw->bar_addr[0] == 0) {
+   PMD_INIT_LOG(ERR, "Bad mem resource.");
return -EIO;
+   }
 
hw->device_id = pci_dev->id.device_id;
hw->port_id = eth_dev->data->port_id;
@@ -90,3 +96,8 @@ static struct rte_pci_driver zxdh_pmd = {
 RTE_PMD_REGISTER_PCI(net_zxdh, zxdh_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_zxdh, pci_id_zxdh_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_zxdh, "* vfio-pci");
+RTE_LOG_REGISTER_SUFFIX(zxdh_logtype_init, init, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(zxdh_logtype_driver, driver, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(zxdh_logtype_rx, rx, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(zxdh_logtype_tx, tx, NOTICE);
+RTE_LOG_REGISTER_SUFFIX(zxdh_logtype_msg, msg, NOTICE);
diff --git a/drivers/net/zxdh/zxdh_logs.h b/drivers/net/zxdh/zxdh_logs.h
new file mode 100644
index 00..a8a6a3135b
--- /dev/null
+++ b/drivers/net/zxdh/zxdh_logs.h
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 ZTE Corporation
+ */
+
+#ifndef ZXDH_LOGS_H
+#define ZXDH_LOGS_H
+
+#include 
+
+extern int zxdh_logtype_init;
+#define RTE_LOGTYPE_ZXDH_INIT zxdh_logtype_init
+#define PMD_INIT_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZXDH_INIT, "offload_zxdh %s(): ", \
+   __func__, __VA_ARGS__)
+
+extern int zxdh_logtype_driver;
+#define RTE_LOGTYPE_ZXDH_DRIVER zxdh_logtype_driver
+#define PMD_DRV_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZXDH_DRIVER, "offload_zxdh %s(): ", \
+   __func__, __VA_ARGS__)
+
+extern int zxdh_logtype_rx;
+#define RTE_LOGTYPE_ZXDH_RX zxdh_logtype_rx
+#define PMD_RX_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZXDH_RX, "offload_zxdh %s(): ", \
+   __func__, __VA_ARGS__)
+
+extern int zxdh_logtype_tx;
+#define RTE_LOGTYPE_ZXDH_TX zxdh_logtype_tx
+#define PMD_TX_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZXDH_TX, "offload_zxdh %s(): ", \
+   __func__, __VA_ARGS__)
+
+extern int zxdh_logtype_msg;
+#define RTE_LOGTYPE_ZXDH_MSG zxdh_logtype_msg
+#define PMD_MSG_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, ZXDH_MSG, "offload_zxdh %s(): ", \
+   __func__, __VA_ARGS__)
+
+#endif /* ZXDH_LOGS_H */
-- 
2.27.0

Re: [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization

[Thomas Monjalon]

29/10/2024 17:20, Stephen Hemminger:
> On Tue, 29 Oct 2024 15:42:52 +0200
> "Minggang Li(Gavin)"  wrote:
> 
> > From: Rongwei Liu 
> > 
> > Add a new devarg probe_opt_en to control probe optimization
> > in PMD.
> > 
> > By default, the value is 0 and no behavior changed.
> > 
> > Signed-off-by: Rongwei Liu 
> > Acked-by: Viacheslav Ovsiienko 
> 
> Once again, every option you introduce expands the test space by 2X.
> "Do or Do not. There is no try"
> Either it works all the time or it is a bad idea.

I fully agree.
We should not merge this series before providing a good answer,
or making it automatic.

One more thing: a commit log should always explain "why".
Here it should say why it is not automatic.
Is there a good reason to disable this feature?

> Sorry if I sound like a broken record, the project I used to work on
> had the same kind of "always add an option" policy. But every time
> an option was changed, there was a 50/50 chance that it was broken because
> that combination of options had not been tested since originally added
> and was non functional due to bit rot.

Re: [PATCH v4 3/8] dts: refactor build and node info classes

[Nicholas Pratte]

It took me a second to appreciate what the goal of separating this is,
but it makes complete sense to me now. This was an oversight on my end
as well when I was working on the config changes in once of the
patches I was assigned. Interestingly enough, I ran into a similar
problem with circular dependencies a long time ago when I was
attempting to do some 'arch' discovery changes, which I still intend
to implement. I think putting the node config in the os_session
component makes sense from a readability standpoint as well.

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> The DPDKBuildInfo and NodeInfo classes, representing information
> gathered in runtime, were erroneously placed in the configuration
> package. This moves them in more appropriate modules.
>
> NodeInfo, specifically, ia moved to os_session instead of node mostly

Small typo here, change 'ia' to 'is'.

> as a consequence of circular dependencies. And given os_session is the
> top-most module to reference it, it appears to be the most suitable
> place outside of node.

As I said, this makes sense to me, but I wonder if it might make sense
to change 'NodeInfo' to 'OSSessionInfo' or something like that. I'd
imagine that if any attributes were to be tacked on in the future they
would probably be os related, but maybe there would be system
information, and in this case "OSSessionInfo" might be a good middle
ground. There are existing changes that I've done where arch is
discovered during runtime, and this could probably be placed in this
'NodeInfo' class as well when I get around to revising it. My only
concern is whether or not having "NodeConfiguration" and "NodeInfo"
classes floating around might make the framework more confusing to
read.

Re: [PATCH v2] net/vmxnet3: support per-queue stats for fewer queues

[Ferruh Yigit]

On 10/25/2024 10:27 AM, Morten Brørup wrote:
> Removed the requirement that the configured number of queues to provide
> statistics for (RTE_ETHDEV_QUEUE_STAT_CNTRS) cannot be less than the
> driver's max number of supported transmit queues (VMXNET3_MAX_TX_QUEUES).
> 
> Also improved support for virtual hardware version 6.
> 
> Signed-off-by: Morten Brørup 
> ---
> v2:
> * Virtual hardware version 6 supports more queues; updated some arrays
>   accordingly.
> * Added support for larger MTU with virtual hardware version 6.
> ---
>  drivers/net/vmxnet3/vmxnet3_ethdev.c | 34 +---
>  drivers/net/vmxnet3/vmxnet3_ethdev.h |  4 ++--
>  2 files changed, 23 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index 78fac63ab6..1752c58069 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1470,42 +1470,52 @@ vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct 
> rte_eth_stats *stats)
>   struct vmxnet3_hw *hw = dev->data->dev_private;
>   struct UPT1_TxStats txStats;
>   struct UPT1_RxStats rxStats;
> + uint64_t packets, bytes;
>  
>   VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
>  
>   for (i = 0; i < hw->num_tx_queues; i++) {
>   vmxnet3_tx_stats_get(hw, i, &txStats);
>  
> - stats->q_opackets[i] = txStats.ucastPktsTxOK +
> + packets = txStats.ucastPktsTxOK +
>   txStats.mcastPktsTxOK +
>   txStats.bcastPktsTxOK;
>  
> - stats->q_obytes[i] = txStats.ucastBytesTxOK +
> + bytes = txStats.ucastBytesTxOK +
>   txStats.mcastBytesTxOK +
>   txStats.bcastBytesTxOK;
>  
> - stats->opackets += stats->q_opackets[i];
> - stats->obytes += stats->q_obytes[i];
> + stats->opackets += packets;
> + stats->obytes += bytes;
>   stats->oerrors += txStats.pktsTxError + txStats.pktsTxDiscard;
> +
> + if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> + stats->q_opackets[i] = packets;
> + stats->q_obytes[i] = bytes;
> + }
>   }
>  
>   for (i = 0; i < hw->num_rx_queues; i++) {
>   vmxnet3_rx_stats_get(hw, i, &rxStats);
>  
> - stats->q_ipackets[i] = rxStats.ucastPktsRxOK +
> + packets = rxStats.ucastPktsRxOK +
>   rxStats.mcastPktsRxOK +
>   rxStats.bcastPktsRxOK;
>  
> - stats->q_ibytes[i] = rxStats.ucastBytesRxOK +
> + bytes = rxStats.ucastBytesRxOK +
>   rxStats.mcastBytesRxOK +
>   rxStats.bcastBytesRxOK;
>  
> - stats->ipackets += stats->q_ipackets[i];
> - stats->ibytes += stats->q_ibytes[i];
> -
> - stats->q_errors[i] = rxStats.pktsRxError;
> + stats->ipackets += packets;
> + stats->ibytes += bytes;
>   stats->ierrors += rxStats.pktsRxError;
>   stats->imissed += rxStats.pktsRxOutOfBuf;
> +
> + if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
> + stats->q_ipackets[i] = packets;
> + stats->q_ibytes[i] = bytes;
> + stats->q_errors[i] = rxStats.pktsRxError;
> + }
>   }
>

Ack, this is also a fix, since queue size can be up to
'VMXNET3_EXT_MAX_RX_QUEUES' (32) for version 6, even if
'RTE_ETHDEV_QUEUE_STAT_CNTRS > VMXNET3_MAX_TX_QUEUES',
'RTE_ETHDEV_QUEUE_STAT_CNTRS ' still can be smaller than
'VMXNET3_EXT_MAX_RX_QUEUES', which will cause accessing out of boundary
to queue stats array.


>  
>   return 0;
> @@ -1521,8 +1531,6 @@ vmxnet3_dev_stats_reset(struct rte_eth_dev *dev)
>  
>   VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD, VMXNET3_CMD_GET_STATS);
>  
> - RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_TX_QUEUES);
> -
>   for (i = 0; i < hw->num_tx_queues; i++) {
>   vmxnet3_hw_tx_stats_get(hw, i, &txStats);
>   memcpy(&hw->snapshot_tx_stats[i], &txStats,
> @@ -1566,7 +1574,7 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev,
>   dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM;
>   dev_info->max_rx_pktlen = 16384; /* includes CRC, cf MAXFRS register */
>   dev_info->min_mtu = VMXNET3_MIN_MTU;
> - dev_info->max_mtu = VMXNET3_MAX_MTU;
> + dev_info->max_mtu = VMXNET3_VERSION_GE_6(hw) ? VMXNET3_V6_MAX_MTU : 
> VMXNET3_MAX_MTU;
>

Hi Morten,

The MTU update is unrelated with the main purpose of this patch, what do
you think to separate above to its own function.

>   dev_info->speed_capa = RTE_ETH_LINK_SPEED_10G;
>   dev_info->max_mac_addrs = VMXNET3_MAX_MAC_ADDRS;
>  
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h 
> b/drivers/net/vmxnet3/vmxnet3_ethdev.h
> index 2b3e2c4caa..e9ded6663d 100644
> --

Re: RFC - Tap io_uring PMD

[Stephen Hemminger]

On Thu, 31 Oct 2024 11:27:25 +0100
Morten Brørup  wrote:

> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Wednesday, 30 October 2024 22.57
> > 
> > The current tap device is slow both due to architectural choices and
> > the
> > overhead of Linux system calls.  
> 
> Yes; but isn't it only being used for (low volume) management traffic?
> Is the TAP PMD performance an issue for anyone? What is their use case?


In embedded systems, if you want to use DPDK for dataplane, you still need
to have a control plane path to the kernel. And most of the hardware used
does not support a bifurcated driver. Either that or have two NIC's.

> 
> Or is the key issue that the TAP PMD makes system calls in the fast path, so 
> you are looking to implement a new TAP PMD that doesn't make any system calls 
> in the fast path?

Even the control path performance matters. Think of a router with lots BGP
connections, or doing updates.

> 
> > I am exploring a how to fix that but
> > some
> > of the choices require some tradeoffs. Which leads to some open
> > questions:
> > 
> > 1. DPDK tap also support tunnel (TUN) mode where there is no Ethernet
> > header
> >only L3. Does anyone actually use this? It is different than what
> > every other
> >PMD expects.  
> 
> If used for high volume (data plane) traffic, I would assume standard PMD 
> behavior (i.e. incl. Ethernet headers) would suffice.
> 
> > 
> > 2. The fastest way to use kernel TAP device would be to use io_uring.
> >But this was added in 5.1 kernel (2019). Rather than having
> > conditional or
> >dual mode in DPDK tap device, perhaps there should just be a new PMD
> > tap_uring?  
> 
> If the features differ significantly, I'm in favor of a new PMD.
> And it would be an opportunity to get rid of useless cruft, which I think you 
> are already asking about here. :-)

Yes, and the TAP device was written to support a niche use case (all the flow 
stuff).
Also TAP device has lots of extra code, at some point doing bit-by-bit cleanup 
gets annoying.

> 
> Furthermore, a "clean sheet" implementation - adding all the experience 
> accumulated since the old TAP PMD - could serve as showcase for "best 
> practices" for software PMDs.
> 
> > 
> > 3. Current TAP device provides hooks for several rte_flow types by
> > playing
> >games with kernel qdisc. Does anyone really use this? Propose just
> > not doing
> >this in new tap_uring.
> > 
> > 4. What other features of TAP device beyond basic send/receive make
> > sense?
> >It looks like new device could support better statistics.  
> 
> IMHO, statistics about missed packets are relevant. If the ingress 
> (kernel->DPDK) queue is full, and the kernel has to drop packets, this drop 
> counter should be exposed to the application through the PMD.

It may require some kernel side additions to extract that, but not out of scope.

> 
> I don't know if the existing TAP PMD supports it, but associating a 
> port/queue with a "network namespace" or VRF in the kernel could also be 
> relevant.

All network devices can be put in network namespace; VRF in Linux is separate 
from netns it has to do with
which routing table is associated with the net device.

> 
> > 
> > 5. What about Rx interrupt support?  
> 
> RX interrupt support seems closely related to power management.
> It could be used to reduce jitter/latency (and burstiness) when someone on 
> the network communicates with an in-band management interface.

Not sure if ioring has wakeup mechanism, but probably epoll() is possible.

> 
> > 
> > Probably the hardest part of using io_uring is figuring out how to
> > collect
> > completions. The simplest way would be to handle all completions rx and
> > tx
> > in the rx_burst function.  
> 
> Please don't mix RX and TX, unless explicitly requested by the application 
> through the recently introduced "mbuf recycle" feature.

The issue is Rx and Tx share a single fd and ioring for completion is per fd.
The implementation for ioring came from the storage side so initially it was 
for fixing
the broken Linux AIO support.

Some other devices only have single interrupt or ring shared with rx/tx so not 
unique.
Virtio, netvsc, and some NIC's.

The problem is that if Tx completes descriptors then there needs to be locking
to prevent Rx thread and Tx thread overlapping. And a spin lock is a 
performance buzz kill.

Re: [PATCH v4 4/8] dts: use pydantic in the configuration

[Nicholas Pratte]

Reviewed-by: Nicholas Pratte 

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> This change brings in pydantic in place of warlock. Pydantic offers
> a built-in model validation system in the classes, which allows for
> a more resilient and simpler code. As a consequence of this change:
>
> - most validation is now built-in
> - further validation is added to verify:
>   - cross referencing of node names and ports
>   - test suite and test cases names
> - dictionaries representing the config schema are removed
> - the config schema is no longer used and therefore dropped
> - the TrafficGeneratorType enum has been changed from inheriting
>   StrEnum to the native str and Enum. This change was necessary to
>   enable the discriminator for object unions
> - the structure of the classes has been slightly changed to perfectly
>   match the structure of the configuration files
> - the test suite argument catches the ValidationError that
>   TestSuiteConfig can now raise
> - the DPDK location has been wrapped under another configuration
>   mapping `dpdk_location`
> - the DPDK locations are now structured and enforced by classes,
>   further simplifying the validation and handling thanks to
>   pattern matching
>
> Bugzilla ID: 1508
>
> Signed-off-by: Luca Vizzarro 
> Reviewed-by: Paul Szczepanek 
> ---
>  doc/api/dts/conf_yaml_schema.json |   1 -
>  doc/api/dts/framework.config.rst  |   6 -
>  doc/api/dts/framework.config.types.rst|   8 -
>  dts/conf.yaml |  11 +-
>  dts/framework/config/__init__.py  | 822 +-
>  dts/framework/config/conf_yaml_schema.json| 459 --
>  dts/framework/config/types.py | 149 
>  dts/framework/runner.py   |  57 +-
>  dts/framework/settings.py | 124 +--
>  dts/framework/testbed_model/node.py   |  15 +-
>  dts/framework/testbed_model/os_session.py |   4 +-
>  dts/framework/testbed_model/port.py   |   4 +-
>  dts/framework/testbed_model/posix_session.py  |  10 +-
>  dts/framework/testbed_model/sut_node.py   | 182 ++--
>  dts/framework/testbed_model/topology.py   |  11 +-
>  .../traffic_generator/__init__.py |   4 +-
>  .../traffic_generator/traffic_generator.py|   2 +-
>  dts/framework/utils.py|   2 +-
>  dts/tests/TestSuite_smoke_tests.py|   2 +-
>  19 files changed, 653 insertions(+), 1220 deletions(-)
>  delete mode 12 doc/api/dts/conf_yaml_schema.json
>  delete mode 100644 doc/api/dts/framework.config.types.rst
>  delete mode 100644 dts/framework/config/conf_yaml_schema.json
>  delete mode 100644 dts/framework/config/types.py
>
> diff --git a/doc/api/dts/conf_yaml_schema.json 
> b/doc/api/dts/conf_yaml_schema.json
> deleted file mode 12
> index 5978642d76..00
> --- a/doc/api/dts/conf_yaml_schema.json
> +++ /dev/null
> @@ -1 +0,0 @@
> -../../../dts/framework/config/conf_yaml_schema.json
> \ No newline at end of file
> diff --git a/doc/api/dts/framework.config.rst 
> b/doc/api/dts/framework.config.rst
> index 261997aefa..cc266276c1 100644
> --- a/doc/api/dts/framework.config.rst
> +++ b/doc/api/dts/framework.config.rst
> @@ -6,9 +6,3 @@ config - Configuration Package
>  .. automodule:: framework.config
> :members:
> :show-inheritance:
> -
> -.. toctree::
> -   :hidden:
> -   :maxdepth: 1
> -
> -   framework.config.types
> diff --git a/doc/api/dts/framework.config.types.rst 
> b/doc/api/dts/framework.config.types.rst
> deleted file mode 100644
> index a50a0c874a..00
> --- a/doc/api/dts/framework.config.types.rst
> +++ /dev/null
> @@ -1,8 +0,0 @@
> -.. SPDX-License-Identifier: BSD-3-Clause
> -
> -config.types - Configuration Types
> -==
> -
> -.. automodule:: framework.config.types
> -   :members:
> -   :show-inheritance:
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index 8a65a481d6..2496262854 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -5,11 +5,12 @@
>  test_runs:
># define one test run environment
>- dpdk_build:
> -  # dpdk_tree: Commented out because `tarball` is defined.
> -  tarball: dpdk-tarball.tar.xz
> -  # Either `dpdk_tree` or `tarball` can be defined, but not both.
> -  remote: false # Optional, defaults to false. If it's true, the 
> `dpdk_tree` or `tarball`
> -# is located on the SUT node, instead of the execution 
> host.
> +  dpdk_location:
> +# dpdk_tree: Commented out because `tarball` is defined.
> +tarball: dpdk-tarball.tar.xz
> +# Either `dpdk_tree` or `tarball` can be defined, but not both.
> +remote: false # Optional, defaults to false. If it's true, the 
> `dpdk_tree` or `tarball`
> +  # is located on the SUT node, instead of the execution 
> host.
>
># precompiled_build_dir: Commented out because `build_options` is 
> defined.
>

Re: [PATCH v4 6/8] dts: add autodoc pydantic

[Nicholas Pratte]

Definitely a set in the right direction here!
Just a small typo, but otherwise:

Reviewed-by: Nicholas Pratte 


> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -204,9 +204,10 @@ node, and then run the tests with the newly built 
> binaries.
>  Configuring DTS
>  ~~~
>
> -DTS configuration is split into nodes and test runs and build targets within 
> test runs,
> -and follows a defined schema as described in `Configuration Schema`_.
> -By default, DTS will try to use the ``dts/conf.yaml`` :ref:`config file 
> `,
> +DTS configuration is split into nodes and test runs, and must respect the 
> the model definitions as

There are two 'the' in the sentence above: "must respect the the model
definitions".

> +documented in the DTS API docs under the ``config`` page. The root of the 
> configuration is
> +represented by the ``Configuration`` model.
> +By default, DTS will try to use the ``dts/conf.yaml`` :ref:`config file 
> `,
>  which is a template that illustrates what can be configured in DTS.
>

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

[Jiawen Wu]

> > @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
> > if (!txq->resetting)
> > continue;
> >
> > +   txq->desc_error++;
> >
> 
> Why error value is increased in this function, which resets the Tx queue?
> Is the intention to reset the error value here?

When there is a desc error to cause Tx ring hang,  the interrupt directs to
reset of the queue. So we increase the error count in the specific queue
reset function. The queue is reset, but the error that led to the resetting
is recorded. The error count is only reset at the setup function.

Re: [PATCH v4 0/7] refactor kvargs test

[lihuisong (C)]

For this series,
Acked-by: Huisong Li 
在 2024/10/30 16:54, Chengwen Feng 写道:

When developing patchset [1], I found the kvargs test is hard to
understand when tried to add some testcase.

So refactor kvargs by:
1. introduce UT suite framework.
2. extract big test_valid_kvargs() to five part.
3. add new introduced rte_kvargs_process_opt() UT.

[1] 
https://patchwork.dpdk.org/project/dpdk/cover/20231103073811.13196-1-fengcheng...@huawei.com/

Chengwen Feng (7):
   app/test: introduce UT suite framework for kvargs
   app/test: extract basic token count testcase for kvargs
   app/test: extract without keys testcase for kvargs
   app/test: extract with keys testcase for kvargs
   app/test: extract parse list value testcase for kvargs
   app/test: extract parse empty elements testcase for kvargs
   app/test: add process opt testcase for kvargs

---
v4: remove maintainer commit.
v3: add rte_kvargs_process_opt()'s testcase.
v2: remove copyright line and add Stephen's ack.

  app/test/test_kvargs.c | 326 +
  1 file changed, 199 insertions(+), 127 deletions(-)

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

[Ferruh Yigit]

On 11/1/2024 2:06 AM, Jiawen Wu wrote:
>>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
>>> if (!txq->resetting)
>>> continue;
>>>
>>> +   txq->desc_error++;
>>>
>>
>> Why error value is increased in this function, which resets the Tx queue?
>> Is the intention to reset the error value here?
> 
> When there is a desc error to cause Tx ring hang,  the interrupt directs to
> reset of the queue. So we increase the error count in the specific queue
> reset function. The queue is reset, but the error that led to the resetting
> is recorded. The error count is only reset at the setup function.
> 

Got it. But this variable counts number of bad packets. Increasing it
when Tx ring hang too may be confusing as there are two different
reasons to increase the counter.

Btw, .stats_reset() needs to reset this error stat.

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

[Ferruh Yigit]

On 11/1/2024 1:52 AM, Jiawen Wu wrote:
> On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote:
>> On 10/28/2024 2:31 AM, Jiawen Wu wrote:
>>> Add checking of the Tx packet length to avoid TDM fatal error as far as
>>> possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
>>> and drop it directly in featured Tx code path.
>>>
>>> Signed-off-by: Jiawen Wu 
>>> ---
>>>  drivers/net/txgbe/txgbe_rxtx.c  | 33 +
>>>  drivers/net/txgbe/txgbe_rxtx_vec_neon.c | 10 +---
>>>  drivers/net/txgbe/txgbe_rxtx_vec_sse.c  | 11 ++---
>>>  3 files changed, 48 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
>>> index 2d2b437643..06acbd0881 100644
>>> --- a/drivers/net/txgbe/txgbe_rxtx.c
>>> +++ b/drivers/net/txgbe/txgbe_rxtx.c
>>> @@ -160,6 +160,8 @@ tx4(volatile struct txgbe_tx_desc *txdp, struct 
>>> rte_mbuf **pkts)
>>> for (i = 0; i < 4; ++i, ++txdp, ++pkts) {
>>> buf_dma_addr = rte_mbuf_data_iova(*pkts);
>>> pkt_len = (*pkts)->data_len;
>>> +   if (pkt_len < RTE_ETHER_HDR_LEN)
>>> +   pkt_len = TXGBE_FRAME_SIZE_DFT;
>>>
>>> /* write data to descriptor */
>>> txdp->qw0 = rte_cpu_to_le_64(buf_dma_addr);
>>> @@ -180,6 +182,8 @@ tx1(volatile struct txgbe_tx_desc *txdp, struct 
>>> rte_mbuf **pkts)
>>>
>>> buf_dma_addr = rte_mbuf_data_iova(*pkts);
>>> pkt_len = (*pkts)->data_len;
>>> +   if (pkt_len < RTE_ETHER_HDR_LEN)
>>> +   pkt_len = TXGBE_FRAME_SIZE_DFT;
>>>
>>> /* write data to descriptor */
>>> txdp->qw0 = cpu_to_le64(buf_dma_addr);
>>> @@ -813,6 +817,30 @@ txgbe_parse_tun_ptid(struct rte_mbuf *tx_pkt, uint8_t 
>>> tun_len)
>>> return ptid;
>>>  }
>>>
>>> +static inline bool
>>> +txgbe_check_pkt_err(struct rte_mbuf *tx_pkt)
>>> +{
>>> +   uint32_t total_len = 0, nb_seg = 0;
>>> +   struct rte_mbuf *mseg;
>>> +
>>> +   mseg = tx_pkt;
>>> +   do {
>>> +   if (mseg->data_len == 0)
>>> +   return true;
>>> +   total_len += mseg->data_len;
>>> +   nb_seg++;
>>> +   mseg = mseg->next;
>>> +   } while (mseg != NULL);
>>> +
>>> +   if (tx_pkt->pkt_len != total_len || tx_pkt->pkt_len == 0)
>>> +   return true;
>>> +
>>> +   if (tx_pkt->nb_segs != nb_seg || tx_pkt->nb_segs > 64)
>>> +   return true;
>>> +
>>> +   return false;
>>> +}
>>> +
>>>
>>
>> Hi Jiawen,
>>
>> Above are generic checks, we may add this function to ethdev driver
>> header (ethdev_driver.h) so that any PMD can use it, what do you think?
> 
> In fact, the limitation of tx_pkt->nb_segs is already implemented in
> .tx_pkt_prepare. But users developing their own apps don't necessarily call
> this function. So I'd like to add these in txgbe_xmit_pkts(). What are you
> going to do about it?
> 
> 

I had the same thought, that is why I am not suggesting to add these
checks to .tx_pkt_prepare() function.

But still these generic checks can go into a new static inline function
for drivers to use, not for end users, and any other driver can call
this function. Your two drivers already using the same function.

This is not hard requirement, but if there is a common code for multiple
drivers, that can go into a helper function in ethdev_driver.h

Re: [PATCH v7] testpmd: add hairpin map parameter

[Ferruh Yigit]

On 10/31/2024 3:51 PM, Stephen Hemminger wrote:
> On Thu, 31 Oct 2024 06:58:17 +0200
> Gregory Etelson  wrote:
> 
>> Hairpin offloads packet forwarding between ports.
>> Packet is expected on Rx port , Rx queue  and is forwarded
>> to Tx port  Tx queue .
>>
>> Testpmd implements a static hairpin configuration scheme.
>>
>> The new parameter allows explicit selection of Rx and Tx ports and
>> queues in hairpin configuration.
>> The new `hairpin-map` parameter is provided with 5 parameters,
>> separated by `:`
>>
>> `--hairpin-map=Rx port id:Rx queue:Tx port id:Tx queue:queues number`
>>
>> Testpmd operator can provide several `hairpin-map` parameters for
>> different hairpin maps.
>> Example:
>>
>> dpdk-testpmd  -- \
>>\
>>   --rxq=2 --txq=2 --hairpinq=2 --hairpin-mode=0x12 \
>>   --hairpin-map=0:2:1:2:1 \ # [1]
>>   --hairpin-map=0:3:2:2:3   # [2]
>>
>> Hairpin map [1] binds Rx port 0, queue 2 with Tx port 1, queue 2.
>> Hairpin map [2] binds
>>   Rx port 0, queue 3 with Tx port 2, queue 2,
>>   Rx port 0, queue 4 with Tx port 2, queue 3,
>>   Rx port 0, queue 5 with Tx port 2, queue 4.
>>
>> The new `hairpin-map` parameter is optional.
>> If omitted, testpmd will create "default" hairpin maps.
>>
>> Signed-off-by: Gregory Etelson 
>> Acked-by: Dariusz Sosnowski 
> 
> Acked-by: Stephen Hemminger 
>

Applied to dpdk-next-net/main, thanks.

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

[Stephen Hemminger]

On Fri, 1 Nov 2024 01:22:47 +
Ferruh Yigit  wrote:

> Hi Jiawen,
> 
> Above are generic checks, we may add this function to ethdev driver
> header (ethdev_driver.h) so that any PMD can use it, what do you think?

This is in the fastpath, and additional checks should not be added there.
Or at least put them under RTE_ETHDEV_DEBUG.

[PATCH v3 1/4] net/nfp: fix port index problem

[Chaoyong He]

Fix one port index problem imported by mistake.

Fixes: 97b6825d9a7b ("net/nfp: extract function to allocate PHY")
Fixes: fd1ec7bc8f0a ("net/nfp: extract function to initialize PF")
Fixes: bb9f9fdcbe00 ("net/nfp: extract function to allocate PF")
Fixes: c8e29c168c20 ("net/nfp: extract function to allocate VF")
Cc: peng.zh...@corigine.com

Signed-off-by: Chaoyong He 
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 1f1b462b41..56690ec42b 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -672,6 +672,7 @@ nfp_flower_repr_base_init(struct rte_eth_dev *eth_dev,
init_repr_data = repr_init->flower_repr;
 
/* Copy data here from the input representor template */
+   repr->idx  = init_repr_data->idx;
repr->vf_id= init_repr_data->vf_id;
repr->switch_domain_id = init_repr_data->switch_domain_id;
repr->port_id  = init_repr_data->port_id;
@@ -930,6 +931,7 @@ nfp_flower_phy_repr_alloc(struct nfp_net_hw_priv *hw_priv,
flower_repr->repr_type = NFP_REPR_TYPE_PHYS_PORT;
flower_repr->port_id = 
nfp_flower_get_phys_port_id(eth_port->index);
flower_repr->nfp_idx = eth_port->index;
+   flower_repr->idx = id;
 
/* Copy the real mac of the interface to the representor struct 
*/
rte_ether_addr_copy(ð_port->mac_addr, 
&flower_repr->mac_addr);
@@ -985,6 +987,7 @@ nfp_flower_vf_repr_alloc(struct nfp_net_hw_priv *hw_priv,
NFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF, i + 
pf_dev->vf_base_id, 0);
flower_repr->nfp_idx = 0;
flower_repr->vf_id = i;
+   flower_repr->idx = nfp_function_id_get(pf_dev, 0);
 
/* VF reprs get a random MAC address */
rte_eth_random_addr(flower_repr->mac_addr.addr_bytes);
@@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv *hw_priv,
 
/* Create a rte_eth_dev for PF vNIC representor */
flower_repr->repr_type = NFP_REPR_TYPE_PF;
+   flower_repr->idx = 0;
 
/* PF vNIC reprs get a random MAC address */
rte_eth_random_addr(flower_repr->mac_addr.addr_bytes);
-- 
2.43.5

[PATCH v3 2/4] net/nfp: extract function to check physical reprsentor

[Chaoyong He]

Extract a helper function to check the physical representor port.

Signed-off-by: Chaoyong He 
---
 .../net/nfp/flower/nfp_flower_representor.c| 18 --
 .../net/nfp/flower/nfp_flower_representor.h|  1 +
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 56690ec42b..5a45c44867 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -96,7 +96,7 @@ nfp_flower_repr_dev_start(struct rte_eth_dev *dev)
hw_priv = dev->process_private;
app_fw_flower = repr->app_fw_flower;
 
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
+   if (nfp_flower_repr_is_phy(repr)) {
ret = nfp_eth_set_configured(hw_priv->pf_dev->cpp, 
repr->nfp_idx, 1);
if (ret < 0)
return ret;
@@ -127,7 +127,7 @@ nfp_flower_repr_dev_stop(struct rte_eth_dev *dev)
 
nfp_flower_cmsg_port_mod(app_fw_flower, repr->port_id, false);
 
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
+   if (nfp_flower_repr_is_phy(repr)) {
ret = nfp_eth_set_configured(hw_priv->pf_dev->cpp, 
repr->nfp_idx, 0);
if (ret == 1)
ret = 0;
@@ -411,7 +411,7 @@ nfp_flower_repr_uninit(struct rte_eth_dev *eth_dev)
nfp_flower_repr_base_uninit(repr);
rte_free(repr->ring);
 
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
+   if (nfp_flower_repr_is_phy(repr)) {
index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr->port_id);
repr->app_fw_flower->phy_reprs[index] = NULL;
} else {
@@ -768,14 +768,14 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
goto ring_cleanup;
}
 
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT)
+   if (nfp_flower_repr_is_phy(repr))
eth_dev->data->representor_id = repr->vf_id;
else
eth_dev->data->representor_id = repr->vf_id +
app_fw_flower->num_phyport_reprs + 1;
 
/* Add repr to correct array */
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
+   if (nfp_flower_repr_is_phy(repr)) {
index = NFP_FLOWER_CMSG_PORT_PHYS_PORT_NUM(repr->port_id);
app_fw_flower->phy_reprs[index] = repr;
} else {
@@ -783,7 +783,7 @@ nfp_flower_repr_init(struct rte_eth_dev *eth_dev,
app_fw_flower->vf_reprs[index] = repr;
}
 
-   if (repr->repr_type == NFP_REPR_TYPE_PHYS_PORT) {
+   if (nfp_flower_repr_is_phy(repr)) {
repr->mac_stats = hw_priv->pf_dev->mac_stats_bar +
(repr->nfp_idx * NFP_MAC_STATS_SIZE);
}
@@ -1183,3 +1183,9 @@ nfp_flower_repr_is_vf(struct nfp_flower_representor *repr)
 {
return repr->repr_type == NFP_REPR_TYPE_VF;
 }
+
+bool
+nfp_flower_repr_is_phy(struct nfp_flower_representor *repr)
+{
+   return repr->repr_type == NFP_REPR_TYPE_PHYS_PORT;
+}
diff --git a/drivers/net/nfp/flower/nfp_flower_representor.h 
b/drivers/net/nfp/flower/nfp_flower_representor.h
index 4211ddf798..3f6ee32fe4 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.h
+++ b/drivers/net/nfp/flower/nfp_flower_representor.h
@@ -30,6 +30,7 @@ struct nfp_flower_representor {
 int nfp_flower_repr_create(struct nfp_app_fw_flower *app_fw_flower,
struct nfp_net_hw_priv *hw_priv);
 bool nfp_flower_repr_is_vf(struct nfp_flower_representor *repr);
+bool nfp_flower_repr_is_phy(struct nfp_flower_representor *repr);
 int nfp_flower_repr_stats_reset(struct rte_eth_dev *ethdev);
 
 #endif /* __NFP_FLOWER_REPRESENTOR_H__ */
-- 
2.43.5

[PATCH v3 3/4] net/nfp: add support for EEPROM functions

[Chaoyong He]

Add support for the following EEPROM function callbacks:

.get_eeprom_len
Get the maximum size of the device EEPROM data.

.get_eeprom
Get the device EEPROM data at a certain offset and length.

.set_eeprom
Set the device EEPROM data at a certain offset and length.

Note that for an nfp NIC, the "device EEPROM" is simply a field in the
hwinfo that is used to store a 6B mac address associated with a physical
port.

.get_module_info
Get information regarding the type and size of the plugin module EEPROM
for a specific port.

.get_module_eeprom
Get the data stored in the plugin module EEPROM for a specific port.

Signed-off-by: James Hershaw 
Signed-off-by: Chaoyong He 
---
 .../net/nfp/flower/nfp_flower_representor.c   |  76 ++
 drivers/net/nfp/nfp_ethdev.c  |   5 +
 drivers/net/nfp/nfp_net_common.c  | 256 ++
 drivers/net/nfp/nfp_net_common.h  |   6 +
 drivers/net/nfp/nfpcore/nfp_nsp.c |  96 +++
 drivers/net/nfp/nfpcore/nfp_nsp.h |   9 +
 6 files changed, 448 insertions(+)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 5a45c44867..04536ce15f 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -24,6 +24,70 @@ struct nfp_repr_init {
struct nfp_net_hw_priv *hw_priv;
 };
 
+static int
+nfp_repr_get_eeprom_len(struct rte_eth_dev *dev)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_get_eeprom_len(dev);
+}
+
+static int
+nfp_repr_get_eeprom(struct rte_eth_dev *dev,
+   struct rte_dev_eeprom_info *eeprom)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_get_eeprom(dev, eeprom);
+}
+
+static int
+nfp_repr_set_eeprom(struct rte_eth_dev *dev,
+   struct rte_dev_eeprom_info *eeprom)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_set_eeprom(dev, eeprom);
+}
+
+static int
+nfp_repr_get_module_info(struct rte_eth_dev *dev,
+   struct rte_eth_dev_module_info *info)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_get_module_info(dev, info);
+}
+
+static int
+nfp_repr_get_module_eeprom(struct rte_eth_dev *dev,
+   struct rte_dev_eeprom_info *info)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_get_module_eeprom(dev, info);
+}
+
 static int
 nfp_flower_repr_link_update(struct rte_eth_dev *dev,
__rte_unused int wait_to_complete)
@@ -553,6 +617,12 @@ static const struct eth_dev_ops 
nfp_flower_multiple_pf_repr_dev_ops = {
.xstats_get_names   = nfp_net_xstats_get_names,
.xstats_get_by_id   = nfp_net_xstats_get_by_id,
.xstats_get_names_by_id = nfp_net_xstats_get_names_by_id,
+
+   .get_eeprom_length= nfp_repr_get_eeprom_len,
+   .get_eeprom   = nfp_repr_get_eeprom,
+   .set_eeprom   = nfp_repr_set_eeprom,
+   .get_module_info  = nfp_repr_get_module_info,
+   .get_module_eeprom= nfp_repr_get_module_eeprom,
 };
 
 static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
@@ -585,6 +655,12 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
.xstats_get_names   = nfp_net_xstats_get_names,
.xstats_get_by_id   = nfp_net_xstats_get_by_id,
.xstats_get_names_by_id = nfp_net_xstats_get_names_by_id,
+
+   .get_eeprom_length= nfp_repr_get_eeprom_len,
+   .get_eeprom   = nfp_repr_get_eeprom,
+   .set_eeprom   = nfp_repr_set_eeprom,
+   .get_module_info  = nfp_repr_get_module_info,
+   .get_module_eeprom= nfp_repr_get_module_eeprom,
 };
 
 static uint32_t
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 77b95d2c5e..2ee76d309c 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -978,6 +978,11 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = {
.fec_get_capability = nfp_net_fec_get_capability,
.fec_get= nfp_net_fec_get,
.fec_set= nfp_net_fec_set,
+   .get_eeprom_length  = nfp_net_get_eeprom_len,
+   .get_eeprom = nfp_net_get_eeprom,
+   .set_eeprom = nfp_net_set_eeprom,
+   .get_module_info= nfp_ne

[PATCH v3 0/4] NFP PMD enhancement

[Chaoyong He]

This patch series fix one problem imported by mistake and add support of
two new APIs.

---
v3:
* Adapt to the multiple PF firmware.
v2:
* add one missing commit.
---

Chaoyong He (4):
  net/nfp: fix port index problem
  net/nfp: extract function to check physical reprsentor
  net/nfp: add support for EEPROM functions
  net/nfp: add support for port identify

 .../net/nfp/flower/nfp_flower_representor.c   | 128 +++-
 .../net/nfp/flower/nfp_flower_representor.h   |   1 +
 drivers/net/nfp/nfp_ethdev.c  |   7 +
 drivers/net/nfp/nfp_net_common.c  | 288 ++
 drivers/net/nfp/nfp_net_common.h  |   8 +
 drivers/net/nfp/nfpcore/nfp_nsp.c |  96 ++
 drivers/net/nfp/nfpcore/nfp_nsp.h |  10 +
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c |  36 +++
 8 files changed, 568 insertions(+), 6 deletions(-)

-- 
2.43.5

RE: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

[Jiawen Wu]

> -Original Message-
> From: Ferruh Yigit 
> Sent: Friday, November 1, 2024 10:46 AM
> To: Jiawen Wu ; dev@dpdk.org
> Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics
> 
> On 11/1/2024 2:06 AM, Jiawen Wu wrote:
> >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
> >>>   if (!txq->resetting)
> >>>   continue;
> >>>
> >>> + txq->desc_error++;
> >>>
> >>
> >> Why error value is increased in this function, which resets the Tx queue?
> >> Is the intention to reset the error value here?
> >
> > When there is a desc error to cause Tx ring hang,  the interrupt directs to
> > reset of the queue. So we increase the error count in the specific queue
> > reset function. The queue is reset, but the error that led to the resetting
> > is recorded. The error count is only reset at the setup function.
> >
> 
> Got it. But this variable counts number of bad packets. Increasing it
> when Tx ring hang too may be confusing as there are two different
> reasons to increase the counter.

I think I should add a comment here:
/* Increase the count of Tx desc error since it causes the queue reset. */

> Btw, .stats_reset() needs to reset this error stat.

I'll add it into .stats_reset() in patch set v3.

[PATCH v3 4/4] net/nfp: add support for port identify

[Chaoyong He]

Implement the necessary functions to allow user to visually identify a
physical port associated with a netdev by blinking an LED on that port.

Signed-off-by: James Hershaw 
Signed-off-by: Chaoyong He 
---
 .../net/nfp/flower/nfp_flower_representor.c   | 30 
 drivers/net/nfp/nfp_ethdev.c  |  2 ++
 drivers/net/nfp/nfp_net_common.c  | 32 +
 drivers/net/nfp/nfp_net_common.h  |  2 ++
 drivers/net/nfp/nfpcore/nfp_nsp.h |  1 +
 drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 36 +++
 6 files changed, 103 insertions(+)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 04536ce15f..4017f602a2 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -88,6 +88,30 @@ nfp_repr_get_module_eeprom(struct rte_eth_dev *dev,
return nfp_net_get_module_eeprom(dev, info);
 }
 
+static int
+nfp_flower_repr_led_on(struct rte_eth_dev *dev)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_led_on(dev);
+}
+
+static int
+nfp_flower_repr_led_off(struct rte_eth_dev *dev)
+{
+   struct nfp_flower_representor *repr;
+
+   repr = dev->data->dev_private;
+   if (!nfp_flower_repr_is_phy(repr))
+   return -EOPNOTSUPP;
+
+   return nfp_net_led_off(dev);
+}
+
 static int
 nfp_flower_repr_link_update(struct rte_eth_dev *dev,
__rte_unused int wait_to_complete)
@@ -623,6 +647,9 @@ static const struct eth_dev_ops 
nfp_flower_multiple_pf_repr_dev_ops = {
.set_eeprom   = nfp_repr_set_eeprom,
.get_module_info  = nfp_repr_get_module_info,
.get_module_eeprom= nfp_repr_get_module_eeprom,
+
+   .dev_led_on   = nfp_flower_repr_led_on,
+   .dev_led_off  = nfp_flower_repr_led_off,
 };
 
 static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
@@ -661,6 +688,9 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
.set_eeprom   = nfp_repr_set_eeprom,
.get_module_info  = nfp_repr_get_module_info,
.get_module_eeprom= nfp_repr_get_module_eeprom,
+
+   .dev_led_on   = nfp_flower_repr_led_on,
+   .dev_led_off  = nfp_flower_repr_led_off,
 };
 
 static uint32_t
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 2ee76d309c..f54483822f 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -983,6 +983,8 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = {
.set_eeprom = nfp_net_set_eeprom,
.get_module_info= nfp_net_get_module_info,
.get_module_eeprom  = nfp_net_get_module_eeprom,
+   .dev_led_on = nfp_net_led_on,
+   .dev_led_off= nfp_net_led_off,
 };
 
 static inline void
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index a45837353a..e68ce68229 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/drivers/net/nfp/nfp_net_common.c
@@ -3181,3 +3181,35 @@ nfp_net_get_module_eeprom(struct rte_eth_dev *dev,
nfp_nsp_close(nsp);
return ret;
 }
+
+static int
+nfp_net_led_control(struct rte_eth_dev *dev,
+   bool is_on)
+{
+   int ret;
+   uint32_t nfp_idx;
+   struct nfp_net_hw_priv *hw_priv;
+
+   hw_priv = dev->process_private;
+   nfp_idx = nfp_net_get_nfp_index(dev);
+
+   ret = nfp_eth_set_idmode(hw_priv->pf_dev->cpp, nfp_idx, is_on);
+   if (ret < 0) {
+   PMD_DRV_LOG(ERR, "Set nfp idmode failed.");
+   return ret;
+   }
+
+   return 0;
+}
+
+int
+nfp_net_led_on(struct rte_eth_dev *dev)
+{
+   return nfp_net_led_control(dev, true);
+}
+
+int
+nfp_net_led_off(struct rte_eth_dev *dev)
+{
+   return nfp_net_led_control(dev, false);
+}
diff --git a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h
index 5ad698cad2..d85a00a75e 100644
--- a/drivers/net/nfp/nfp_net_common.h
+++ b/drivers/net/nfp/nfp_net_common.h
@@ -399,6 +399,8 @@ int nfp_net_get_eeprom(struct rte_eth_dev *dev, struct 
rte_dev_eeprom_info *eepr
 int nfp_net_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info 
*eeprom);
 int nfp_net_get_module_info(struct rte_eth_dev *dev, struct 
rte_eth_dev_module_info *info);
 int nfp_net_get_module_eeprom(struct rte_eth_dev *dev, struct 
rte_dev_eeprom_info *info);
+int nfp_net_led_on(struct rte_eth_dev *dev);
+int nfp_net_led_off(struct rte_eth_dev *dev);
 
 #define NFP_PRIV_TO_APP_FW_NIC(app_fw_priv)\
((struct nfp_app_fw_nic *)app_fw_priv)
diff --git a/drivers/net/nfp/nfpcore/nfp_nsp.h 
b/drivers/net/nfp/nfpcore/nfp_nsp.h
index 0ae10dabfb..6230a84e34 100644
--- a/drivers/net/nfp/nfpcore/nfp_nsp.h
+++ b/drivers/net/n

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[Stephen Hemminger]

On Thu, 31 Oct 2024 14:05:16 +
Luca Boccassi  wrote:

> On Thu, 31 Oct 2024 at 13:04, David Marchand  
> wrote:
> >
> > On Thu, Oct 31, 2024 at 1:58 PM Luca Boccassi  
> > wrote:  
> > >
> > > On Thu, 31 Oct 2024 at 12:52, David Marchand  
> > > wrote:  
> > > >
> > > > On Thu, Oct 31, 2024 at 1:47 PM David Marchand
> > > >  wrote:  
> > > > > Could you share a backtrace when hitting this deadlock?  
> > > >
> > > > If the backtrace is not possible, running with
> > > > --log-level=lib.eal:debug may help.  
> > >
> > > I cannot get backtraces. This runs via "meson test", how can that
> > > option be passed in?  
> >
> > # meson test -C build-debian --suite fast-tests --verbose -t 5
> > --test-args=--log-level=lib.eal:debug  
> 
> https://paste.debian.net/1334095/

Could not repro this on Raspberry Pi 5. Main branch builds and runs

Re: [PATCH] net/hns3: remove roh devices

[Ferruh Yigit]

On 10/31/2024 6:30 AM, Jie Hai wrote:
> On 2024/10/26 14:38, Jie Hai wrote:
>> From: Dengdui Huang 
>>
>> The devices added in commit 3f1436d7006c ("net/hns3: support new device")
>> is no longer available, so revert it.
>>
>> Fixes: 3f1436d7006c ("net/hns3: support new device")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Dengdui Huang 
>> ---
>>   drivers/net/hns3/hns3_cmd.c    | 4 +---
>>   drivers/net/hns3/hns3_ethdev.c | 2 --
>>   drivers/net/hns3/hns3_ethdev.h | 2 --
>>   3 files changed, 1 insertion(+), 7 deletions(-)
>>
> Acked-by: Jie Hai 
>

Applied to dpdk-next-net/main, thanks.

Re: [PATCH v3 1/4] net/nfp: fix port index problem

[Stephen Hemminger]

On Fri,  1 Nov 2024 10:57:10 +0800
Chaoyong He  wrote:

> @@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv 
> *hw_priv,
>  
>   /* Create a rte_eth_dev for PF vNIC representor */
>   flower_repr->repr_type = NFP_REPR_TYPE_PF;
> + flower_repr->idx = 0;

That initialization does not look like it necessary since that structure
was initialized at start of the function.  Might be better to put all the init
for the data structure there, to avoid confusion.

答复: [PATCH v3 01/18] net/r8169: add PMD driver skeleton

[王颢]

Dear Stephen,

I have modified the code related to braces in the latest patch. Recently, I was 
reviewing the DPDK Coding Style and found the reason why I initially removed 
the redundant braces. If symmetrical braces are required, it would be better to 
update the DPDK Coding Style accordingly.

in https://doc.dpdk.org/guides/contributing/coding_style.html
Braces that are not necessary should be left out.

if (test)
stmt;
else if (bar) {
stmt;
stmt;
} else
stmt;

Best Regards,
Howard Wang

-邮件原件-
发件人: Stephen Hemminger  
发送时间: 2024年10月23日 13:18
收件人: 王颢 
抄送: dev@dpdk.org; pro_nic_d...@realtek.com
主题: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton


External mail.



On Wed, 23 Oct 2024 11:33:11 +0800
Howard Wang  wrote:

> Meson build infrastructure, r8169_ethdev minimal skeleton, header with 
> Realtek NIC device and vendor IDs.
>
> Signed-off-by: Howard Wang 

This version is much better than the last.
Still has some issues:
  - git whitespace
  - braces
  - one spelling error

For example, doing git apply showed.

Applying: net/r8169: add support for hardware operations
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2381: 
trailing whitespace.
  (BIT_15 | BIT_14 | BIT_13 | BIT_12 |
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:460: new 
blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2052: new 
blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2073: new 
blank line at EOF.
+
/home/shemminger/DPDK/main/.git/worktrees/r8169/rebase-apply/patch:2470: new 
blank line at EOF.
+
warning: squelched 13 whitespace errors
warning: 18 lines add whitespace errors.


Some minor checkpatch warnings.

CHECK:BRACES: braces {} should be used on all arms of this statement
#268: FILE: drivers/net/r8169/r8169_hw.c:67:
+   if (len <= 4 - val_shift)
[...]
+   else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#270: FILE: drivers/net/r8169/r8169_hw.c:69:
+   else {

CHECK:BRACES: braces {} should be used on all arms of this statement
#334: FILE: drivers/net/r8169/r8169_hw.c:133:
+   if (len <= 4 - val_shift)
[...]
+   else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#336: FILE: drivers/net/r8169/r8169_hw.c:135:
+   else {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#433: FILE: drivers/net/r8169/r8169_hw.c:232:
+
+   }

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#978: FILE: drivers/net/r8169/r8169_phy.c:2:
+ * Copyright(c) 2024 Realtek Corporation. All rights reserved */

CHECK:BRACES: braces {} should be used on all arms of this statement
#273: FILE: drivers/net/r8169/r8169_phy.c:536:
+   if (hw->hw_ram_code_ver == hw->sw_ram_code_ver) {
[...]
+   } else
[...]

### [PATCH] net/r8169: impelment MTU configuration

WARNING:TYPO_SPELLING: 'impelment' may be misspelled - perhaps 'implement'?
#4:
Subject: [PATCH] net/r8169: impelment MTU configuration
^
Suprised that you have to keep track of packets in SW.
The kernel driver is able to get them from the HW.

The kernel driver gets lots more counters from the HW which could go to xstats.

[PATCH v2] doc: add mlx5 xstats send scheduling counters description

[Viacheslav Ovsiienko]

The mlx5 provides the scheduling send on time capability.
To check the operating status of this feature the extended statistics
counters are provided. This patch adds the counter descriptions
and provides some meaningful information how to interpret
the counter values in runtime.

Signed-off-by: Viacheslav Ovsiienko 
---
 doc/guides/nics/mlx5.rst | 59 
 1 file changed, 59 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index b5522d50c5..5db4aeda1b 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -2662,3 +2662,62 @@ Destroy GENEVE TLV parser for specific port::
 
 This command doesn't destroy the global list,
 For releasing options, ``flush`` command should be used.
+
+
+Extended Statistics Counters
+
+
+Send Scheduling Extended Statistics Counters
+
+
+The mlx5 PMD provides a comprehensive set of counters designed for debugging
+and diagnostics related to packet scheduling during transmission. These 
counters
+are applicable only if the port was configured with the ``tx_pp`` devarg and
+reflect the status of the PMD scheduling infrastructure based on Clock and
+Rearm Queues, used as a workaround on ConnectX-6DX NICs.
+
+- ``tx_pp_missed_interrupt_errors`` - indicates that the Rearm Queue interrupt
+  was not serviced on time. The EAL manages interrupts in a dedicated thread,
+  and it is possible that other time-consuming actions were being processed
+  concurrently.
+
+- ``tx_pp_rearm_queue_errors`` - signifies hardware errors that occurred
+  on the Rearm Queue, typically caused by delays in servicing interrupts.
+
+- ``tx_pp_clock_queue_errors`` - reflects hardware errors on the Clock Queue,
+  which usually indicate configuration issues or problems with the internal NIC
+  hardware or firmware.
+
+- ``tx_pp_timestamp_past_errors`` - tracks the application attempted to send
+  packets with timestamps set in the past. It is useful for debugging 
application
+  code and does not indicate a malfunction of the PMD.
+
+- ``tx_pp_timestamp_future_errors`` - records attempts by the application to 
send
+  packets with timestamps set too far into the future, exceeding the 
hardware???s
+  scheduling capabilities. Like the previous counter, it aids in application
+  debugging without suggesting a PMD malfunction.
+
+- ``tx_pp_jitter`` - measures the internal NIC real-time clock jitter 
estimation
+  between two consecutive Clock Queue completions, expressed in nanoseconds.
+  Significant jitter may signal potential clock synchronization issues,
+  possibly due to inappropriate adjustments made by a system PTP
+  (Precision Time Protocol) agent.
+
+- ``tx_pp_wander`` - indicates the long-term stability of the internal NIC
+  real-time clock over 2^24 completions, measured in nanoseconds. Significant
+  wander may also suggest clock synchronization problems.
+
+- ``tx_pp_sync_lost`` - a general operational indicator; a non-zero value
+  indicates that the driver has lost synchronization with the Clock Queue,
+  resulting in improper scheduling operations. To restore correct scheduling
+  functionality, it is necessary to restart the port.
+
+The following counters are particularly valuable for verifying and debugging
+application code. They do not indicate driver or hardware malfunctions and
+are applicable to newer hardware with direct on-time scheduling capabilities
+(such as ConnectX-7 and above):
+
+- ``tx_pp_timestamp_order_errors`` - indicates attempts by the application
+  to send packets with timestamps that are not in strictly ascending order.
+  Since the PMD does not reorder packets within hardware queues, violations
+  of timestamp order can lead to packets being sent at incorrect times.
-- 
2.34.1

RE: [PATCH 1/1] net/ena: add histogram support

[Brandes, Shai]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Tuesday, October 29, 2024 6:23 PM
> To: Brandes, Shai 
> Cc: ferruh.yi...@amd.com; dev@dpdk.org; Bernstein, Amit
> 
> Subject: RE: [EXTERNAL] [PATCH 1/1] net/ena: add histogram support
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> On Tue, 29 Oct 2024 10:02:15 +0200
>  wrote:
> 
> > From: Shai Brandes 
> >
> > The framework computes the differences between specified start and end
> > points in the code, providing insights into performance by outputting
> > a histogram of the time intervals.
> > The histogram can be used to track metrics like packet processing
> > latency in the network driver.
> > This framework requires enablement via a compilation flag and is
> > excluded in release builds by default.
> >
> > Signed-off-by: Amit Bernstein 
> > Signed-off-by: Shai Brandes 
> 
> Could this be generic for all PMD's and built off of existing DPDK trace
> mechanism?
> 
> Yes, histogram is useful.
> But IMHO DPDK should discourage PMD specific features.
[Brandes, Shai] Acknowledged, thanks for your insights!

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[David Marchand]

On Thu, Oct 31, 2024 at 1:47 PM David Marchand
 wrote:
> Could you share a backtrace when hitting this deadlock?

If the backtrace is not possible, running with
--log-level=lib.eal:debug may help.


-- 
David Marchand

RE: [PATCH 0/1] net/ena: adding a histogram framework to 2.11.0

[Brandes, Shai]

> -Original Message-
> From: Morten Brørup 
> Sent: Tuesday, October 29, 2024 10:55 AM
> To: Brandes, Shai ; ferruh.yi...@amd.com
> Cc: dev@dpdk.org
> Subject: RE: [EXTERNAL] [PATCH 0/1] net/ena: adding a histogram framework
> to 2.11.0
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> > From: Shai Brandes 
> >
> > This update is an enhancement to the ENA driver version 2.11.0 release.
> > It is a "nice to have" feature for the 24.11 release, should it be
> > included before the code freeze deadline.
> >
> > This addition leverages an internal framework used in our testing
> > processes, which may offer significant benefits for customers.
> > It calculates the differences between specified start and end points
> > in the code, generating a histogram of time intervals to provide
> > detailed insights into performance.
> 
> Yes, histograms can be extremely useful.
> The SmartShare applications use histograms for a variety of purposes, e.g.
> function profiling (like yours), number of packets per RX burst, number of
> packets per flow, and much more.
> The distribution index can be linear (like yours), log2, or - for higher
> resolution - floating point with 3 or 4 bits mantissa and 5 or more bits
> exponent.
> 
> Please provide generic histograms as a proper library, not tied to a specific
> driver, and not specifically using "time" as parameter.
Acknowledged, thanks for your insights!

Re: [PATCH v2] Revert "eal/unix: fix thread creation"

[Luca Boccassi]

On Thu, 31 Oct 2024 at 12:52, David Marchand  wrote:
>
> On Thu, Oct 31, 2024 at 1:47 PM David Marchand
>  wrote:
> > Could you share a backtrace when hitting this deadlock?
>
> If the backtrace is not possible, running with
> --log-level=lib.eal:debug may help.

I cannot get backtraces. This runs via "meson test", how can that
option be passed in?

Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets

[Ferruh Yigit]

On 10/28/2024 2:31 AM, Jiawen Wu wrote:
> Add checking of the Tx packet length to avoid TDM fatal error as far as
> possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
> and drop it directly in featured Tx code path.
> 
> Signed-off-by: Jiawen Wu 
> ---
>  drivers/net/txgbe/txgbe_rxtx.c  | 33 +
>  drivers/net/txgbe/txgbe_rxtx_vec_neon.c | 10 +---
>  drivers/net/txgbe/txgbe_rxtx_vec_sse.c  | 11 ++---
>  3 files changed, 48 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
> index 2d2b437643..06acbd0881 100644
> --- a/drivers/net/txgbe/txgbe_rxtx.c
> +++ b/drivers/net/txgbe/txgbe_rxtx.c
> @@ -160,6 +160,8 @@ tx4(volatile struct txgbe_tx_desc *txdp, struct rte_mbuf 
> **pkts)
>   for (i = 0; i < 4; ++i, ++txdp, ++pkts) {
>   buf_dma_addr = rte_mbuf_data_iova(*pkts);
>   pkt_len = (*pkts)->data_len;
> + if (pkt_len < RTE_ETHER_HDR_LEN)
> + pkt_len = TXGBE_FRAME_SIZE_DFT;
>  
>   /* write data to descriptor */
>   txdp->qw0 = rte_cpu_to_le_64(buf_dma_addr);
> @@ -180,6 +182,8 @@ tx1(volatile struct txgbe_tx_desc *txdp, struct rte_mbuf 
> **pkts)
>  
>   buf_dma_addr = rte_mbuf_data_iova(*pkts);
>   pkt_len = (*pkts)->data_len;
> + if (pkt_len < RTE_ETHER_HDR_LEN)
> + pkt_len = TXGBE_FRAME_SIZE_DFT;
>  
>   /* write data to descriptor */
>   txdp->qw0 = cpu_to_le64(buf_dma_addr);
> @@ -813,6 +817,30 @@ txgbe_parse_tun_ptid(struct rte_mbuf *tx_pkt, uint8_t 
> tun_len)
>   return ptid;
>  }
>  
> +static inline bool
> +txgbe_check_pkt_err(struct rte_mbuf *tx_pkt)
> +{
> + uint32_t total_len = 0, nb_seg = 0;
> + struct rte_mbuf *mseg;
> +
> + mseg = tx_pkt;
> + do {
> + if (mseg->data_len == 0)
> + return true;
> + total_len += mseg->data_len;
> + nb_seg++;
> + mseg = mseg->next;
> + } while (mseg != NULL);
> +
> + if (tx_pkt->pkt_len != total_len || tx_pkt->pkt_len == 0)
> + return true;
> +
> + if (tx_pkt->nb_segs != nb_seg || tx_pkt->nb_segs > 64)
> + return true;
> +
> + return false;
> +}
> +
>

Hi Jiawen,

Above are generic checks, we may add this function to ethdev driver
header (ethdev_driver.h) so that any PMD can use it, what do you think?

Re: [PATCH] graph: fix memory leak in node clone

[Huichao cai]

There is one more place in the node_clone function that needs to be modified:
   if (clone_name(reg->name, node->name, name))
//goto free;
goto free_xstat;

Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics

[Ferruh Yigit]

On 10/28/2024 2:31 AM, Jiawen Wu wrote:
> Count the number of packets not sent due to Tx descriptor error.
> 
> Signed-off-by: Jiawen Wu 
> ---
>  drivers/net/txgbe/txgbe_ethdev.c | 6 ++
>  drivers/net/txgbe/txgbe_rxtx.c   | 3 +++
>  drivers/net/txgbe/txgbe_rxtx.h   | 1 +
>  3 files changed, 10 insertions(+)
> 
> diff --git a/drivers/net/txgbe/txgbe_ethdev.c 
> b/drivers/net/txgbe/txgbe_ethdev.c
> index bafa9cf829..0c76e986f4 100644
> --- a/drivers/net/txgbe/txgbe_ethdev.c
> +++ b/drivers/net/txgbe/txgbe_ethdev.c
> @@ -2344,6 +2344,7 @@ txgbe_dev_stats_get(struct rte_eth_dev *dev, struct 
> rte_eth_stats *stats)
>   struct txgbe_hw_stats *hw_stats = TXGBE_DEV_STATS(dev);
>   struct txgbe_stat_mappings *stat_mappings =
>   TXGBE_DEV_STAT_MAPPINGS(dev);
> + struct txgbe_tx_queue *txq;
>   uint32_t i, j;
>  
>   txgbe_read_stats_registers(hw, hw_stats);
> @@ -2398,6 +2399,11 @@ txgbe_dev_stats_get(struct rte_eth_dev *dev, struct 
> rte_eth_stats *stats)
>  
>   /* Tx Errors */
>   stats->oerrors  = 0;
> + for (i = 0; i < dev->data->nb_tx_queues; i++) {
> + txq = dev->data->tx_queues[i];
> + stats->oerrors += txq->desc_error;
> + }
> +

stats_get is implemented, but stats_reset also needs to be implemented
for this stat.

>   return 0;
>  }
>  
> diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
> index 06acbd0881..fc9e7b14f5 100644
> --- a/drivers/net/txgbe/txgbe_rxtx.c
> +++ b/drivers/net/txgbe/txgbe_rxtx.c
> @@ -894,6 +894,7 @@ txgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
>   tx_pkt = *tx_pkts++;
>   if (txgbe_check_pkt_err(tx_pkt)) {
>   rte_pktmbuf_free(tx_pkt);
> + txq->desc_error++;
>   continue;
>   }
>  
> @@ -2523,6 +2524,7 @@ txgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
>   txgbe_set_tx_function(dev, txq);
>  
>   txq->ops->reset(txq);
> + txq->desc_error = 0;
>  
>   dev->data->tx_queues[queue_idx] = txq;
>  
> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param)
>   if (!txq->resetting)
>   continue;
>  
> + txq->desc_error++;
>

Why error value is increased in this function, which resets the Tx queue?
Is the intention to reset the error value here?

>   txgbe_dev_save_tx_queue(hw, i);
>  
>   /* tx ring reset */
> diff --git a/drivers/net/txgbe/txgbe_rxtx.h b/drivers/net/txgbe/txgbe_rxtx.h
> index e668b60b1e..622a0d3981 100644
> --- a/drivers/net/txgbe/txgbe_rxtx.h
> +++ b/drivers/net/txgbe/txgbe_rxtx.h
> @@ -412,6 +412,7 @@ struct txgbe_tx_queue {
>   /**< indicates that IPsec TX feature is in use */
>  #endif
>   const struct rte_memzone *mz;
> + uint64_tdesc_error;
>   boolresetting;
>  };
>  

[RFC] kvargs: add free attribute annotation

[Stephen Hemminger]

Pointers created from parsing kvargs must be freed via
rte_kvargs_free. Use compiler attributes to catch misuse.

Signed-off-by: Stephen Hemminger 
---
 lib/kvargs/rte_kvargs.c | 10 --
 lib/kvargs/rte_kvargs.h | 40 
 2 files changed, 32 insertions(+), 18 deletions(-)

diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c
index 1d355516bc..cdfb7318f1 100644
--- a/lib/kvargs/rte_kvargs.c
+++ b/lib/kvargs/rte_kvargs.c
@@ -249,6 +249,13 @@ rte_kvargs_get(const struct rte_kvargs *kvlist, const char 
*key)
return rte_kvargs_get_with_value(kvlist, key, NULL);
 }
 
+/* Helper function to get a pointer with kvargs_free attribute */
+static __rte_dealloc_kvargs_free struct rte_kvargs *
+rte_kvargs_alloc(void)
+{
+   return calloc(1, sizeof(struct rte_kvargs));
+}
+
 /*
  * Parse the arguments "key=value,key=value,..." string and return
  * an allocated structure that contains a key/value list. Also
@@ -259,10 +266,9 @@ rte_kvargs_parse(const char *args, const char * const 
valid_keys[])
 {
struct rte_kvargs *kvlist;
 
-   kvlist = malloc(sizeof(*kvlist));
+   kvlist = rte_kvargs_alloc();
if (kvlist == NULL)
return NULL;
-   memset(kvlist, 0, sizeof(*kvlist));
 
if (rte_kvargs_tokenize(kvlist, args) < 0) {
rte_kvargs_free(kvlist);
diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h
index 73fa1e621b..11a78a109b 100644
--- a/lib/kvargs/rte_kvargs.h
+++ b/lib/kvargs/rte_kvargs.h
@@ -21,6 +21,8 @@
  * ethernet devices at initialization for arguments parsing.
  */
 
+#include 
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -62,6 +64,22 @@ struct rte_kvargs {
struct rte_kvargs_pair pairs[RTE_KVARGS_MAX]; /**< list of key/values */
 };
 
+/**
+ * Functions that expect return value to be freed with rte_kvargs_free()
+ */
+#define __rte_dealloc_kvargs_free __rte_dealloc(rte_kvargs_free, 1)
+
+/**
+ * Free a rte_kvargs structure
+ *
+ * Free a rte_kvargs structure previously allocated with
+ * rte_kvargs_parse().
+ *
+ * @param kvlist
+ *   The rte_kvargs structure. No error if NULL.
+ */
+void rte_kvargs_free(struct rte_kvargs *kvlist);
+
 /**
  * Allocate a rte_kvargs and store key/value associations from a string
  *
@@ -80,8 +98,9 @@ struct rte_kvargs {
  *   - A pointer to an allocated rte_kvargs structure on success
  *   - NULL on error
  */
-struct rte_kvargs *rte_kvargs_parse(const char *args,
-   const char *const valid_keys[]);
+struct rte_kvargs *
+rte_kvargs_parse(const char *args, const char *const valid_keys[])
+   __rte_malloc __rte_dealloc_kvargs_free;
 
 /**
  * Allocate a rte_kvargs and store key/value associations from a string.
@@ -108,20 +127,9 @@ struct rte_kvargs *rte_kvargs_parse(const char *args,
  *   - A pointer to an allocated rte_kvargs structure on success
  *   - NULL on error
  */
-struct rte_kvargs *rte_kvargs_parse_delim(const char *args,
-   const char *const valid_keys[],
-   const char *valid_ends);
-
-/**
- * Free a rte_kvargs structure
- *
- * Free a rte_kvargs structure previously allocated with
- * rte_kvargs_parse().
- *
- * @param kvlist
- *   The rte_kvargs structure. No error if NULL.
- */
-void rte_kvargs_free(struct rte_kvargs *kvlist);
+struct rte_kvargs *
+rte_kvargs_parse_delim(const char *args, const char *const valid_keys[], const 
char *valid_ends)
+   __rte_malloc __rte_dealloc_kvargs_free;
 
 /**
  * Get the value associated with a given key.
-- 
2.45.2

Re: [PATCH v4 5/8] dts: remove warlock dependency

[Nicholas Pratte]

Reviewed-by: Nicholas Pratte 

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> Since pydantic has completely replaced warlock, there is no more need to
> keep it as a dependency. This removes it.
>
> Signed-off-by: Luca Vizzarro 
> Reviewed-by: Paul Szczepanek 
> ---
>  dts/poetry.lock| 227 +
>  dts/pyproject.toml |   1 -
>  2 files changed, 1 insertion(+), 227 deletions(-)
>
> diff --git a/dts/poetry.lock b/dts/poetry.lock
> index 56c50ad52c..9f7db60793 100644
> --- a/dts/poetry.lock
> +++ b/dts/poetry.lock
> @@ -34,24 +34,6 @@ files = [
>  {file = "annotated_types-0.7.0.tar.gz", hash = 
> "sha256:aff07c09a53a08bc8cfccb9c85b05f1aa9a2a6f23728d790723543408344ce89"},
>  ]
>
> -[[package]]
> -name = "attrs"
> -version = "23.1.0"
> -description = "Classes Without Boilerplate"
> -optional = false
> -python-versions = ">=3.7"
> -files = [
> -{file = "attrs-23.1.0-py3-none-any.whl", hash = 
> "sha256:1f28b4522cdc2fb4256ac1a020c78acf9cba2c6b461ccd2c126f3aa8e8335d04"},
> -{file = "attrs-23.1.0.tar.gz", hash = 
> "sha256:6279836d581513a26f1bf235f9acd333bc9115683f14f7e8fae46c98fc50e015"},
> -]
> -
> -[package.extras]
> -cov = ["attrs[tests]", "coverage[toml] (>=5.3)"]
> -dev = ["attrs[docs,tests]", "pre-commit"]
> -docs = ["furo", "myst-parser", "sphinx", "sphinx-notfound-page", 
> "sphinxcontrib-towncrier", "towncrier", "zope-interface"]
> -tests = ["attrs[tests-no-zope]", "zope-interface"]
> -tests-no-zope = ["cloudpickle", "hypothesis", "mypy (>=1.1.1)", "pympler", 
> "pytest (>=4.3.0)", "pytest-mypy-plugins", "pytest-xdist[psutil]"]
> -
>  [[package]]
>  name = "babel"
>  version = "2.13.1"
> @@ -491,66 +473,6 @@ MarkupSafe = ">=2.0"
>  [package.extras]
>  i18n = ["Babel (>=2.7)"]
>
> -[[package]]
> -name = "jsonpatch"
> -version = "1.33"
> -description = "Apply JSON-Patches (RFC 6902)"
> -optional = false
> -python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, 
> !=3.5.*, !=3.6.*"
> -files = [
> -{file = "jsonpatch-1.33-py2.py3-none-any.whl", hash = 
> "sha256:0ae28c0cd062bbd8b8ecc26d7d164fbbea9652a1a3693f3b956c1eae5145dade"},
> -{file = "jsonpatch-1.33.tar.gz", hash = 
> "sha256:9fcd4009c41e6d12348b4a0ff2563ba56a2923a7dfee731d004e212e1ee5030c"},
> -]
> -
> -[package.dependencies]
> -jsonpointer = ">=1.9"
> -
> -[[package]]
> -name = "jsonpointer"
> -version = "2.4"
> -description = "Identify specific nodes in a JSON document (RFC 6901)"
> -optional = false
> -python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, 
> !=3.5.*, !=3.6.*"
> -files = [
> -{file = "jsonpointer-2.4-py2.py3-none-any.whl", hash = 
> "sha256:15d51bba20eea3165644553647711d150376234112651b4f1811022aecad7d7a"},
> -{file = "jsonpointer-2.4.tar.gz", hash = 
> "sha256:585cee82b70211fa9e6043b7bb89db6e1aa49524340dde8ad6b63206ea689d88"},
> -]
> -
> -[[package]]
> -name = "jsonschema"
> -version = "4.18.4"
> -description = "An implementation of JSON Schema validation for Python"
> -optional = false
> -python-versions = ">=3.8"
> -files = [
> -{file = "jsonschema-4.18.4-py3-none-any.whl", hash = 
> "sha256:971be834317c22daaa9132340a51c01b50910724082c2c1a2ac87eeec153a3fe"},
> -{file = "jsonschema-4.18.4.tar.gz", hash = 
> "sha256:fb3642735399fa958c0d2aad7057901554596c63349f4f6b283c493cf692a25d"},
> -]
> -
> -[package.dependencies]
> -attrs = ">=22.2.0"
> -jsonschema-specifications = ">=2023.03.6"
> -referencing = ">=0.28.4"
> -rpds-py = ">=0.7.1"
> -
> -[package.extras]
> -format = ["fqdn", "idna", "isoduration", "jsonpointer (>1.13)", 
> "rfc3339-validator", "rfc3987", "uri-template", "webcolors (>=1.11)"]
> -format-nongpl = ["fqdn", "idna", "isoduration", "jsonpointer (>1.13)", 
> "rfc3339-validator", "rfc3986-validator (>0.1.0)", "uri-template", "webcolors 
> (>=1.11)"]
> -
> -[[package]]
> -name = "jsonschema-specifications"
> -version = "2023.7.1"
> -description = "The JSON Schema meta-schemas and vocabularies, exposed as a 
> Registry"
> -optional = false
> -python-versions = ">=3.8"
> -files = [
> -{file = "jsonschema_specifications-2023.7.1-py3-none-any.whl", hash = 
> "sha256:05adf340b659828a004220a9613be00fa3f223f2b82002e273dee62fd50524b1"},
> -{file = "jsonschema_specifications-2023.7.1.tar.gz", hash = 
> "sha256:c91a50404e88a1f6ba40636778e2ee08f6e24c5613fe4c53ac24578a5a7f72bb"},
> -]
> -
> -[package.dependencies]
> -referencing = ">=0.28.0"
> -
>  [[package]]
>  name = "markupsafe"
>  version = "2.1.3"
> @@ -1073,21 +995,6 @@ files = [
>  {file = "PyYAML-6.0.1.tar.gz", hash = 
> "sha256:bfdf460b1736c775f2ba9f6a92bca30bc2095067b8a9d77876d1fad6cc3b4a43"},
>  ]
>
> -[[package]]
> -name = "referencing"
> -version = "0.30.0"
> -description = "JSON Referencing + Python"
> -optional = false
> -python-versions = ">=3.8"
> -files = [
> -{file = "referencing-0.30.0-py3-none-any.whl", hash = 
> "sha256:c257b08a399b6c2f5a3510a50d28ab5dbc7bbde049bcaf954d43c446f83ab548"},
> -{file = "referencing-0.30.0.tar.

Re: [PATCH v4 2/8] dts: add TestSuiteSpec class and discovery

[Nicholas Pratte]

On Mon, Oct 28, 2024 at 1:51 PM Luca Vizzarro  wrote:
>
> Currently there is a lack of a definition which identifies all the test
> suites available to test. This change intends to simplify the process to
> discover all the test suites and idenfity them.

Noticed this in the corner of my eye. 'idenfity' should be 'identify.'

RE: [PATCH v2 06/13] net/txgbe: check length of Tx packets

[Jiawen Wu]

On Fri, Nov 1, 2024 9:23 AM, Ferruh Yigit wrote:
> On 10/28/2024 2:31 AM, Jiawen Wu wrote:
> > Add checking of the Tx packet length to avoid TDM fatal error as far as
> > possible. Set the pkt_len=1518 for invalid packet in simple Tx code path,
> > and drop it directly in featured Tx code path.
> >
> > Signed-off-by: Jiawen Wu 
> > ---
> >  drivers/net/txgbe/txgbe_rxtx.c  | 33 +
> >  drivers/net/txgbe/txgbe_rxtx_vec_neon.c | 10 +---
> >  drivers/net/txgbe/txgbe_rxtx_vec_sse.c  | 11 ++---
> >  3 files changed, 48 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
> > index 2d2b437643..06acbd0881 100644
> > --- a/drivers/net/txgbe/txgbe_rxtx.c
> > +++ b/drivers/net/txgbe/txgbe_rxtx.c
> > @@ -160,6 +160,8 @@ tx4(volatile struct txgbe_tx_desc *txdp, struct 
> > rte_mbuf **pkts)
> > for (i = 0; i < 4; ++i, ++txdp, ++pkts) {
> > buf_dma_addr = rte_mbuf_data_iova(*pkts);
> > pkt_len = (*pkts)->data_len;
> > +   if (pkt_len < RTE_ETHER_HDR_LEN)
> > +   pkt_len = TXGBE_FRAME_SIZE_DFT;
> >
> > /* write data to descriptor */
> > txdp->qw0 = rte_cpu_to_le_64(buf_dma_addr);
> > @@ -180,6 +182,8 @@ tx1(volatile struct txgbe_tx_desc *txdp, struct 
> > rte_mbuf **pkts)
> >
> > buf_dma_addr = rte_mbuf_data_iova(*pkts);
> > pkt_len = (*pkts)->data_len;
> > +   if (pkt_len < RTE_ETHER_HDR_LEN)
> > +   pkt_len = TXGBE_FRAME_SIZE_DFT;
> >
> > /* write data to descriptor */
> > txdp->qw0 = cpu_to_le64(buf_dma_addr);
> > @@ -813,6 +817,30 @@ txgbe_parse_tun_ptid(struct rte_mbuf *tx_pkt, uint8_t 
> > tun_len)
> > return ptid;
> >  }
> >
> > +static inline bool
> > +txgbe_check_pkt_err(struct rte_mbuf *tx_pkt)
> > +{
> > +   uint32_t total_len = 0, nb_seg = 0;
> > +   struct rte_mbuf *mseg;
> > +
> > +   mseg = tx_pkt;
> > +   do {
> > +   if (mseg->data_len == 0)
> > +   return true;
> > +   total_len += mseg->data_len;
> > +   nb_seg++;
> > +   mseg = mseg->next;
> > +   } while (mseg != NULL);
> > +
> > +   if (tx_pkt->pkt_len != total_len || tx_pkt->pkt_len == 0)
> > +   return true;
> > +
> > +   if (tx_pkt->nb_segs != nb_seg || tx_pkt->nb_segs > 64)
> > +   return true;
> > +
> > +   return false;
> > +}
> > +
> >
> 
> Hi Jiawen,
> 
> Above are generic checks, we may add this function to ethdev driver
> header (ethdev_driver.h) so that any PMD can use it, what do you think?

In fact, the limitation of tx_pkt->nb_segs is already implemented in
.tx_pkt_prepare. But users developing their own apps don't necessarily call
this function. So I'd like to add these in txgbe_xmit_pkts(). What are you
going to do about it?