[PATCH] net/pcap: set live interface as non-blocking

2024-08-24 Thread Stephen Hemminger
The DPDK PMD's are supposed to be non-blocking and poll for packets.
Configure PCAP to do this on live interface.

Bugzilla ID: 1526
Reported-by: Ofer Dagan 
Signed-off-by: Stephen Hemminger 
---
 drivers/net/pcap/pcap_ethdev.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index bfec085045..c4e6c93d4a 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -522,6 +522,12 @@ open_iface_live(const char *iface, pcap_t **pcap) {
return -1;
}
 
+   if (pcap_setnonblock(*pcap, 1, errbuf)) {
+   PMD_LOG(ERR, "Couldn't set non-blocking on %s: %s", iface, 
errbuf);
+   pcap_close(*pcap);
+   return -1;
+   }
+
return 0;
 }
 
-- 
2.43.0



RE: [PATCH v8 2/3] eventdev: add support for independent enqueue

2024-08-24 Thread Pathak, Pravin


> -Original Message-
> From: Mattias Rönnblom 
> Sent: Friday, August 23, 2024 7:03 AM
> To: Sevincer, Abdullah ; dev@dpdk.org
> Cc: jer...@marvell.com; Richardson, Bruce ;
> Pathak, Pravin ; mattias.ronnb...@ericsson.com;
> Aggarwal, Manish 
> Subject: Re: [PATCH v8 2/3] eventdev: add support for independent enqueue
> 
> On 2024-08-12 22:00, Abdullah Sevincer wrote:
> > This commit adds support for independent enqueue feature and updates
> > Event Device and PMD feature list.
> >
> > A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced to
> > support independent enqueue to support PMD to enqueue in any order
> > even the underlined hardware device needs enqueues in a strict dequeue
> 
> This sentence needs to be rephrased.
> 
> My attempt:
> "A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. An
> application may, on an event device where independent enqueue is supported,
> using an event port where it is enabled, enqueue RTE_EVENT_OP_FORWARD or
> RELEASE type events in any order."
> 
> > order.

Will this work: 
A new capability, RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ, is introduced. It 
allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type 
events on an event port where this capability is enabled. 

> >
> > To use this capability applications need to set flag
> > RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the
> > capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists.
> >
> > Signed-off-by: Abdullah Sevincer 
> > ---
> >   doc/guides/eventdevs/features/default.ini |  1 +
> >   doc/guides/eventdevs/features/dlb2.ini|  1 +
> >   doc/guides/rel_notes/release_24_11.rst|  5 +++
> >   lib/eventdev/rte_eventdev.h   | 37 +++
> >   4 files changed, 44 insertions(+)
> >
> > diff --git a/doc/guides/eventdevs/features/default.ini
> > b/doc/guides/eventdevs/features/default.ini
> > index 1cc4303fe5..7c4ee99238 100644
> > --- a/doc/guides/eventdevs/features/default.ini
> > +++ b/doc/guides/eventdevs/features/default.ini
> > @@ -22,6 +22,7 @@ carry_flow_id  =
> >   maintenance_free   =
> >   runtime_queue_attr =
> >   profile_links  =
> > +independent_enq=
> >
> >   ;
> >   ; Features of a default Ethernet Rx adapter.
> > diff --git a/doc/guides/eventdevs/features/dlb2.ini
> > b/doc/guides/eventdevs/features/dlb2.ini
> > index 7b80286927..c7193b47c1 100644
> > --- a/doc/guides/eventdevs/features/dlb2.ini
> > +++ b/doc/guides/eventdevs/features/dlb2.ini
> > @@ -15,6 +15,7 @@ implicit_release_disable   = Y
> >   runtime_port_link  = Y
> >   multiple_queue_port= Y
> >   maintenance_free   = Y
> > +independent_enq= Y
> >
> >   [Eth Rx adapter Features]
> >
> > diff --git a/doc/guides/rel_notes/release_24_11.rst
> > b/doc/guides/rel_notes/release_24_11.rst
> > index f0ec07c263..04f389876a 100644
> > --- a/doc/guides/rel_notes/release_24_11.rst
> > +++ b/doc/guides/rel_notes/release_24_11.rst
> > @@ -30,6 +30,11 @@ New Features
> > ``RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ`` to enable the feature if the
> capability
> > ``RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ`` exists.
> >
> > +* **Updated Event Device Library for independent enqueue feature**
> > +
> > +  * Added support for independent enqueue feature. Updated Event Device
> and
> > +PMD feature list.
> > +
> >
> >   Removed Items
> >   -
> > diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> > index 08e5f9320b..48e6eadda9 100644
> > --- a/lib/eventdev/rte_eventdev.h
> > +++ b/lib/eventdev/rte_eventdev.h
> > @@ -446,6 +446,31 @@ struct rte_event;
> >* @see RTE_SCHED_TYPE_PARALLEL
> >*/
> >
> > +#define RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ  (1ULL << 16) /**< Event
> > +device is capable of independent enqueue.
> > + * A new capability, RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ, will indicate
> > +that Eventdev
> > + * supports the enqueue in any order or specifically in a different
> > +order than the
> > + * dequeue. Eventdev PMD can either transmit events in the changed
> > +order in which
> > + * they are enqueued or restore the original order before sending
> > +them to the
> > + * underlying hardware device. A flag is provided during the port
> > +configuration to
> > + * inform Eventdev PMD that the application intends to use an
> > +independent enqueue
> > + * order on a particular port. Note that this capability only matters
> > +for Eventdevs
> > + * supporting burst mode.
> > + *
> > + * To Inform PMD that the application plans to use independent
> > +enqueue order on a port
> > + * this code example can be used:
> > + *
> > + *  if (capability & RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ)
> > + * port_config = port_config |
> RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ;
> > + *
> > + * When an implicit release is enabled on a port, Eventdev PMD will
> > +also handle
> > + * the insertion of RELEASE events in place of dropped events. The
> > +independent e