RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Morten Brørup]

Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
traffic terminating) application, which doesn’t really care about the preceding 
headers, can benefit from having its actual data at a specific offset for 
alignment purposes. I don’t consider this very exotic. (Even the Linux kernel 
uses this trick to achieve improved IP header alignment on RX.)

 

I think the proper solution would be to add a new offload parameter to 
rte_eth_rxconf to specify how many bytes the driver should subtract from 
RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
Depending on driver support, this would make it configurable per device and per 
RX queue.

 

If this parameter is set, the driver should adjust m->data_off accordingly on 
RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still point 
to the Ethernet header.

 

 

Med venlig hilsen / Kind regards,

-Morten Brørup

 

From: Garrett D'Amore [mailto:garr...@damore.org] 
Sent: Monday, 25 March 2024 23.56



So we need (for reasons that I don't want to get to into in too much detail) 
that our UDP payload headers are at a specific offset in the packet.

This was not a problem as long as we only used IPv4.  (We have configured 40 
bytes of headroom, which is more than any of our PMDs need by a hefty margin.)

Now that we're extending to support IPv6, we need to reduce that headroom by 20 
bytes, to preserve our UDP payload offset.

This has big ramifications for how we fragment our own upper layer messages, 
and it has been determined that updating the PMDs to allow us to change the 
headroom for this use case (on a per port basis, as we will have some ports on 
IPv4 and others on IPv6) is the least effort, but a large margin.  (Well, 
copying the frames via memcpy would be less development effort, but would be a 
performance catastrophe.)

For transmit side we don't need this, as we can simply adjust the packet as 
needed.  But for the receive side, we are kind of stuck, as the PMDs rely on 
the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.

As far as header splitting, that would indeed be a much much nicer solution.

I haven't looked in the latest code to see if header splitting is even an 
option -- the version of the DPDK I'm working with is a little older (20.11) -- 
we have to update but we have other local changes and so updating is one of the 
things that we still have to do.

At any rate, the version I did look at doesn't seem to support header splits on 
any device other than FM10K.  That's not terrifically interesting for us.  We 
use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really -- ENA, 
virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on client 
systems in the field.

We also, unfortunately, have an older DPDK 18 with Mellanox contributions for 
IPoverIB though I'm not sure we will try to support IPv6 there.  (We are 
working towards replacing that part of stack with UCX.)

Unless header splitting will work on all of this (excepting the IPoIB piece), 
then it's not something we can really use.

On Mar 25, 2024 at 10:20 AM -0700, Stephen Hemminger 
, wrote:



On Mon, 25 Mar 2024 10:01:52 +
Bruce Richardson  wrote:




On Sat, Mar 23, 2024 at 01:51:25PM -0700, Garrett D'Amore wrote:



> So we right now (at WEKA) have a somewhat older version of DPDK that we
> have customized heavily, and I am going to to need to to make the
> headroom *dynamic* (passed in at run time, and per port.)
> We have this requirement because we need payload to be at a specific
> offset, but have to deal with different header lengths for IPv4 and now
> IPv6.
> My reason for pointing this out, is that I would dearly like if we
> could collaborate on this -- this change is going to touch pretty much
> every PMD (we don't need it on all of them as we only support a subset
> of PMDs, but its still a significant set.)
> I'm not sure if anyone else has considered such a need -- this
> particular message caught my eye as I'm looking specifically in this
> area right now.
>

Hi

thanks for reaching out. Can you clarify a little more as to the need for
this requirement? Can you not just set the headroom value to the max needed
value for any port and use that? Is there an issue with having blank space
at the start of a buffer?

Thanks,
/Bruce


If you have to make such a deep change across all PMD's then maybe
it is not the best solution. What about being able to do some form of buffer
chaining or pullup.

[DPDK/examples Bug 1398] [dpdk-24.03] ptpclient causes NIC I225/I226 port RX missed

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1398

tingtingx.l...@intel.com (tingtingx.l...@intel.com) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from tingtingx.l...@intel.com (tingtingx.l...@intel.com) ---
Verify on main dpdk-24.03.0-rc4: 3ce30fc64
Tested pass on regression I225-LM testbed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

RE: [PATCH 0/2] introduce PM QoS interface

[Morten Brørup]

> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> Sent: Tuesday, 26 March 2024 03.12
> 
> 在 2024/3/22 20:35, Morten Brørup 写道:
> >> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> >> Sent: Friday, 22 March 2024 09.54

[...]

> >> For the case need PM QoS in DPDK, I think, it is better to set cpu
> >> latency to zero to prevent service thread from the deeper the idle
> state.
> > It would defeat the purpose (i.e. not saving sufficient amounts of
> power) if the CPU cannot enter a deeper idle state.
> Yes, it is not good for power.
> AFAIS, PM QoS is just to decrease the influence for performance.
> Anyway, if we set to zero, system can be into Cstates-0 at least.
> >
> > Personally, I would think a wake-up latency of up to 10 microseconds
> should be fine for must purposes.
> > Default Linux timerslack is 50 microseconds, so you could also use
> that value.
> How much CPU latency is ok. Maybe, we can give the decision to the
> application.

Yes, the application should decide the acceptable worst-case latency.

> Linux will collect all these QoS request and use the minimum latency.
> what do you think, Morten?

For the example application, you could use a value of 50 microseconds and refer 
to this value also being the default timerslack in Linux.

RE: release candidate 24.03-rc3

[Xu, HailinX]

> -Original Message-
> From: Thomas Monjalon 
> Sent: Monday, March 18, 2024 11:46 AM
> To: annou...@dpdk.org
> Subject: release candidate 24.03-rc3
> 
> A new DPDK release candidate is ready for testing:
>   https://git.dpdk.org/dpdk/tag/?id=v24.03-rc3
> 
> There are 153 new patches in this snapshot.
> 
> Release notes:
>   https://doc.dpdk.org/guides/rel_notes/release_24_03.html
> 
> As usual, you can report any issue on https://bugs.dpdk.org
> 
> Only documentation and bug fixes should be accepted at this stage.
> 
> DPDK 24.03-rc4 should be the last release candidate.
> The final release should be done on 27th if no surprise.
> 
> Thank you everyone
> 
Update the test status for Intel part. dpdk24.03-rc3 all test is done. not 
found new issue.

# Basic Intel(R) NIC testing
* Build or compile:  
 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu23.10, Ubuntu22.04.3, Fedora39, RHEL8.9/9.2, 
Centos7.9, FreeBSD14.0, SUSE15, OpenAnolis8.8, CBL-Mariner2.0 etc.
- All test passed.
 *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.3 
and RHEL9.2.
- All test passed with latest dpdk.
* PF/VF(i40e, ixgbe): test scenarios including 
PF/VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test case is done. No new issue is found.
* PF/VF(igc): test scenarios including PF/VF-RTE_FLOW/TSO/Jumboframe/checksum 
offload/VLAN/VXLAN, etc. 
- All test case is done. No new issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow 
Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- Execution rate is done. No new issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single 
core performance test, RFC2544 Zero packet loss performance test, etc.
- Execution rate is done. No new issue is found.
* Power; IPsec; DLB; DSA dmadev: 
 * Power: test scenarios including bi-direction/Telemetry/Empty Poll 
Lib/Priority Base Frequency, etc. 
- Execution rate is done. No new issue is found.
 * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - 
QAT&SW/FIB library, etc.
- Execution rate is done. No new issue is found.
 * DLB: test scenarios including DLB2/DLB2.5
- Execution rate is done. No new issue is found.
 * DSA dmadev:  - Execution rate is done. found the second issue.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 8.0U1, etc.
- Execution rate is done. No new issue is found.
* Cryptodev: 
 *Function test: test scenarios including Cryptodev API testing/CompressDev 
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
- Execution rate is done. No new issue is found. 
 *Performance test: test scenarios including Throughput Performance /Cryptodev 
Latency, etc.
- Execution rate is done. No performance drop.

Regards,
Xu, Hailin

RE: [PATCH v13 01/11] windows: make getopt functions have const properties

[Morten Brørup]

> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, 26 March 2024 02.57
> 
> Having different prototypes on different platforms can lead
> to lots of unnecessary workarounds.  Looks like the version of
> getopt used from windows was based on an older out of date
> version from FreeBSD.
> 
> This patch changes getopt, getopt_long, etc to have the same const
> attributes as Linux and FreeBSD. The changes are derived from
> the current FreeBSD version of getopt_long.
> 
> Signed-off-by: Stephen Hemminger 
> Acked-by: Tyler Retzlaff 
> Acked-by: Dmitry Kozlyuk 
> ---

For the series,
Acked-by: Morten Brørup 

[PATCH] doc: add tested AMD platforms

[Ferruh Yigit]

Add tested AMD platforms to v24.03 release note.

Signed-off-by: Ferruh Yigit 
---
Cc: vipin.vargh...@amd.com
Cc: sivaprasad.tumm...@amd.com
Cc: keesang.s...@amd.com
---
 doc/guides/rel_notes/release_24_03.rst | 16 
 1 file changed, 16 insertions(+)

diff --git a/doc/guides/rel_notes/release_24_03.rst 
b/doc/guides/rel_notes/release_24_03.rst
index 9b92c81d0687..86f908132260 100644
--- a/doc/guides/rel_notes/release_24_03.rst
+++ b/doc/guides/rel_notes/release_24_03.rst
@@ -298,6 +298,22 @@ Tested Platforms
Also, make sure to start the actual text at the margin.
===
 
+* AMD platforms
+
+  * CPU
+
+* AMD EPYC\ |trade| 7543 32-Core Processor @ 3.70GHz
+
+  * BIOS 7.00.30.00
+
+* AMD EPYC\ |trade| 8534 64-Core Processor @ 3.10GHz
+
+  * BIOS 7.00.00.00
+
+  * OS:
+
+* Ubuntu 22.04.4 LTS
+
 * Intel\ |reg| platforms with Intel\ |reg| NICs combinations
 
   * CPU
-- 
2.34.1

RE: [PATCH 1/2] eal: provide macro for GCC builtin constant intrinsic

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 22.34
> 
> MSVC does not have a __builtin_constant_p intrinsic so provide
> __rte_constant(e) that expands false for MSVC and to the intrinsic for
> GCC.
> 
> Signed-off-by: Tyler Retzlaff 
> ---

Reviewed-by: Morten Brørup 

RE: [PATCH 2/2] mempool: use rte constant macro instead of GCC builtin

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 22.34
> 
> Use newly introduced __rte_constant(e) macro instead of directly using
> __builtin_constant_p() allowing mempool to be built by MSVC.
> 
> Signed-off-by: Tyler Retzlaff 
> ---

Reviewed-by: Morten Brørup 

RE: [PATCH v7 1/4] net/i40e: use inline prefetch function

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 23.02
> 
> Don't directly access the cacheline1 field in rte_mbuf struct for
> prefetch instead just use rte_mbuf_prefetch_part2() to prefetch.
> 
> Signed-off-by: Tyler Retzlaff 
> ---
>  drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> b/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> index f3050cd..0238b03 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_avx512.c
> @@ -826,7 +826,7 @@
>   free[0] = m;
>   nb_free = 1;
>   for (i = 1; i < n; i++) {
> - rte_prefetch0(&txep[i + 3].mbuf->cacheline1);
> + rte_mbuf_prefetch_part2(txep[i + 3].mbuf);

@Yuying Zhang:
If this prefetch is for m->next, I think it can be omitted if m->next is in the 
first cache line:

-   rte_prefetch0(&txep[i + 3].mbuf->cacheline1);
+#if RTE_IOVA_IN_MBUF
+   rte_mbuf_prefetch_part2(txep[i + 3].mbuf);
+#endif

If so, it belongs in a separate patch anyway.

>   m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
>   if (likely(m)) {
>   if (likely(m->pool == free[0]->pool)) {
> --
> 1.8.3.1

Reviewed-by: Morten Brørup 

RE: [PATCH v7 3/4] security: remove rte marker fields

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 23.02
> 
> RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
> RTE_MARKER fields from rte_mbuf struct.
> 
> Maintain alignment of fields after removed cacheline1 marker by placing
> C11 alignas(RTE_CACHE_LINE_MIN_SIZE).
> 
> Signed-off-by: Tyler Retzlaff 
> ---
>  doc/guides/rel_notes/release_24_03.rst | 3 +++
>  lib/security/rte_security_driver.h | 5 +++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index 4f18cca..75d40d4 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -219,6 +219,9 @@ Removed Items
>  * mbuf: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
>have been removed from ``struct rte_mbuf``.
> 
> +* security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
> +  have been removed from ``struct rte_security_session``.
> +
>  API Changes
>  ---
> 
> diff --git a/lib/security/rte_security_driver.h
> b/lib/security/rte_security_driver.h
> index 09829ab..18a1e3c 100644
> --- a/lib/security/rte_security_driver.h
> +++ b/lib/security/rte_security_driver.h
> @@ -12,6 +12,8 @@
>   * RTE Security Common Definitions
>   */
> 
> +#include 
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> @@ -24,7 +26,6 @@
>   * Security session to be used by library for internal usage
>   */
>  struct rte_security_session {
> - RTE_MARKER cacheline0;
>   uint64_t opaque_data;
>   /**< Opaque user defined data */
>   uint64_t fast_mdata;
> @@ -32,7 +33,7 @@ struct rte_security_session {
>   rte_iova_t driver_priv_data_iova;
>   /**< session private data IOVA address */
> 
> - alignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1;
> + alignas(RTE_CACHE_LINE_MIN_SIZE)
>   uint8_t driver_priv_data[];
>   /**< Private session material, variable size (depends on driver)
> */
>  };
> --
> 1.8.3.1

No explicit alignment was ever specified for the struct rte_security_session 
itself. I wonder which implicit alignment applies to it.

Anyway, the changes are correct, so
Reviewed-by: Morten Brørup 

Re: [PATCH v2 1/6] ethdev: support setting lanes

[Thomas Monjalon]

26/03/2024 02:42, lihuisong (C):
> 
> 在 2024/3/25 17:30, Thomas Monjalon 写道:
> > 25/03/2024 07:24, huangdengdui:
> >> On 2024/3/22 21:58, Thomas Monjalon wrote:
> >>> 22/03/2024 08:09, Dengdui Huang:
>  -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8)  /**< 10 Gbps */
>  -#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9)  /**< 20 Gbps */
>  -#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps */
>  -#define RTE_ETH_LINK_SPEED_40G RTE_BIT32(11) /**< 40 Gbps */
>  -#define RTE_ETH_LINK_SPEED_50G RTE_BIT32(12) /**< 50 Gbps */
>  -#define RTE_ETH_LINK_SPEED_56G RTE_BIT32(13) /**< 56 Gbps */
>  -#define RTE_ETH_LINK_SPEED_100GRTE_BIT32(14) /**< 100 Gbps */
>  -#define RTE_ETH_LINK_SPEED_200GRTE_BIT32(15) /**< 200 Gbps */
>  -#define RTE_ETH_LINK_SPEED_400GRTE_BIT32(16) /**< 400 Gbps */
>  +#define RTE_ETH_LINK_SPEED_10GRTE_BIT32(8)  /**< 10 Gbps */
>  +#define RTE_ETH_LINK_SPEED_20GRTE_BIT32(9)  /**< 20 Gbps 
>  2lanes */
>  +#define RTE_ETH_LINK_SPEED_25GRTE_BIT32(10) /**< 25 Gbps */
>  +#define RTE_ETH_LINK_SPEED_40GRTE_BIT32(11) /**< 40 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_50GRTE_BIT32(12) /**< 50 Gbps */
>  +#define RTE_ETH_LINK_SPEED_56GRTE_BIT32(13) /**< 56 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_100G   RTE_BIT32(14) /**< 100 Gbps */
>  +#define RTE_ETH_LINK_SPEED_200G   RTE_BIT32(15) /**< 200 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_400G   RTE_BIT32(16) /**< 400 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_10G_4LANES RTE_BIT32(17)  /**< 10 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_50G_2LANES RTE_BIT32(18) /**< 50 Gbps 2 
>  lanes */
>  +#define RTE_ETH_LINK_SPEED_100G_2LANESRTE_BIT32(19) /**< 100 Gbps 2 
>  lanes */
>  +#define RTE_ETH_LINK_SPEED_100G_4LANESRTE_BIT32(20) /**< 100 Gbps 
>  4lanes */
>  +#define RTE_ETH_LINK_SPEED_200G_2LANESRTE_BIT32(21) /**< 200 Gbps 
>  2lanes */
>  +#define RTE_ETH_LINK_SPEED_400G_8LANESRTE_BIT32(22) /**< 400 Gbps 
>  8lanes */
> >>> I don't think it is a good idea to make this more complex.
> >>> It brings nothing as far as I can see, compared to having speed and lanes 
> >>> separated.
> >>> Can we have lanes information a separate value? no need for bitmask.
> >>>
> >> Hi,Thomas, Ajit, roretzla, damodharam
> >>
> >> I also considered the option at the beginning of the design.
> >> But this option is not used due to the following reasons:
> >> 1. For the user, ethtool couples speed and lanes.
> >> The result of querying the NIC capability is as follows:
> >> Supported link modes:
> >>  10baseSR4/Full
> >>  10baseSR2/Full
> >> The NIC capability is configured as follows:
> >> ethtool -s eth1 speed 10 lanes 4 autoneg off
> >> ethtool -s eth1 speed 10 lanes 2 autoneg off
> >>
> >> Therefore, users are more accustomed to the coupling of speed and lanes.
> >>
> >> 2. For the PHY, When the physical layer capability is configured through 
> >> the MDIO,
> >> the speed and lanes are also coupled.
> >> For example:
> >> Table 45–7—PMA/PMD control 2 register bit definitions[1]
> >> PMA/PMD type selection
> >>  1 0 0 1 0 1 0 = 100GBASE-SR2 PMA/PMD
> >>  0 1 0 1 1 1 1 = 100GBASE-SR4 PMA/PMD
> >>
> >> Therefore, coupling speeds and lanes is easier to understand.
> >> And it is easier for the driver to report the support lanes.
> >>
> >> In addition, the code implementation is compatible with the old version.
> >> When the driver does not support the lanes setting, the code does not need 
> >> to be modified.
> >>
> >> So I think the speed and lanes coupling is better.
> > I don't think so.
> > You are mixing hardware implementation, user tool, and API.
> > Having a separate and simple API is cleaner and not more difficult to handle
> > in some get/set style functions.
> Having a separate and simple API is cleaner. It's good.
> But supported lane capabilities have a lot to do with the specified 
> speed. This is determined by releated specification.
> If we add a separate API for speed lanes, it probably is hard to check 
> the validity of the configuration for speed and lanes.
> And the setting lane API sepparated from speed is not good for 
> uniforming all PMD's behavior in ethdev layer.

Please let's be more specific.
There are 3 needs:
- set PHY lane config
- get PHY lane config
- get PHY lane capabilities

There is no problem providing a function to get the number of PHY lanes.
It is possible to set PHY lanes number after defining a fixed speed.

> The patch[1] is an example for this separate API.
> I think it is not very good. It cannot tell user and PMD the follow points:
> 1) user don't know what lanes should or can be set for a specified 

RE: [PATCH v7 4/4] cryptodev: remove rte marker fields

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 23.02
> 
> RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
> RTE_MARKER fields from rte_mbuf struct.
> 
> Maintain alignment of fields after removed cacheline1 marker by placing
> C11 alignas(RTE_CACHE_LINE_MIN_SIZE).
> 
> Signed-off-by: Tyler Retzlaff 
> ---
>  doc/guides/rel_notes/release_24_03.rst | 3 +++
>  lib/cryptodev/cryptodev_pmd.h  | 5 +++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index 75d40d4..d3e5abe 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -222,6 +222,9 @@ Removed Items
>  * security: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
>have been removed from ``struct rte_security_session``.
> 
> +* cryptodev: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
> +  have been removed from ``struct cryptodev_driver``.
> +
>  API Changes
>  ---
> 
> diff --git a/lib/cryptodev/cryptodev_pmd.h
> b/lib/cryptodev/cryptodev_pmd.h
> index d195b81..9daf129 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -5,6 +5,8 @@
>  #ifndef _CRYPTODEV_PMD_H_
>  #define _CRYPTODEV_PMD_H_
> 
> +#include 
> +
>  #ifdef __cplusplus
>  extern "C" {
>  #endif
> @@ -139,7 +141,6 @@ struct cryptodev_driver {
>   * has a fixed algo, key, op-type, digest_len etc.
>   */
>  struct rte_cryptodev_sym_session {
> - RTE_MARKER cacheline0;
>   uint64_t opaque_data;
>   /**< Can be used for external metadata */
>   uint32_t sess_data_sz;
> @@ -151,7 +152,7 @@ struct rte_cryptodev_sym_session {
>   rte_iova_t driver_priv_data_iova;
>   /**< Session driver data IOVA address */
> 
> - alignas(RTE_CACHE_LINE_MIN_SIZE) RTE_MARKER cacheline1;
> + alignas(RTE_CACHE_LINE_MIN_SIZE)
>   /**< Second cache line - start of the driver session data */
>   uint8_t driver_priv_data[];
>   /**< Driver specific session data, variable size */
> --
> 1.8.3.1

Reviewed-by: Morten Brørup 

Re: [PATCH] doc: add tested AMD platforms

[Thomas Monjalon]

26/03/2024 10:46, Ferruh Yigit:
> Add tested AMD platforms to v24.03 release note.
> 
> Signed-off-by: Ferruh Yigit 

Applied, thanks.

RE: [PATCH v7 2/4] mbuf: remove rte marker fields

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Wednesday, 20 March 2024 23.02
> 
> RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove
> RTE_MARKER fields from rte_mbuf struct.
> 
> Maintain alignment of fields after removed cacheline1 marker by placing
> C11 alignas(RTE_CACHE_LINE_MIN_SIZE).
> 
> Provide new rearm_data and rx_descriptor_fields1 fields in anonymous
> unions as single element arrays of with types matching the original
> markers to maintain API compatibility.
> 
> Signed-off-by: Tyler Retzlaff 

I agree with the concepts in this patch.
A few comments inline below.

> ---
>  doc/guides/rel_notes/release_24_03.rst |   2 +
>  lib/mbuf/rte_mbuf.h|   4 +-
>  lib/mbuf/rte_mbuf_core.h   | 188 ++
> ---
>  3 files changed, 104 insertions(+), 90 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_24_03.rst
> b/doc/guides/rel_notes/release_24_03.rst
> index 14826ea..4f18cca 100644
> --- a/doc/guides/rel_notes/release_24_03.rst
> +++ b/doc/guides/rel_notes/release_24_03.rst
> @@ -216,6 +216,8 @@ Removed Items
> 
>  * acc101: Removed obsolete code for non productized HW variant.
> 
> +* mbuf: ``RTE_MARKER`` fields ``cacheline0`` and ``cacheline1``
> +  have been removed from ``struct rte_mbuf``.
> 
>  API Changes
>  ---
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 286b32b..4c4722e 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -108,7 +108,7 @@
>  static inline void
>  rte_mbuf_prefetch_part1(struct rte_mbuf *m)
>  {
> - rte_prefetch0(&m->cacheline0);
> + rte_prefetch0(m);
>  }
> 
>  /**
> @@ -126,7 +126,7 @@
>  rte_mbuf_prefetch_part2(struct rte_mbuf *m)
>  {
>  #if RTE_CACHE_LINE_SIZE == 64
> - rte_prefetch0(&m->cacheline1);
> + rte_prefetch0(RTE_PTR_ADD(m, RTE_CACHE_LINE_MIN_SIZE));
>  #else
>   RTE_SET_USED(m);
>  #endif
> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
> index 9f58076..665213c 100644
> --- a/lib/mbuf/rte_mbuf_core.h
> +++ b/lib/mbuf/rte_mbuf_core.h
> @@ -465,8 +465,6 @@ enum {
>   * The generic rte_mbuf, containing a packet mbuf.
>   */
>  struct __rte_cache_aligned rte_mbuf {
> - RTE_MARKER cacheline0;
> -
>   void *buf_addr;   /**< Virtual address of segment buffer.
> */
>  #if RTE_IOVA_IN_MBUF
>   /**
> @@ -488,116 +486,130 @@ struct __rte_cache_aligned rte_mbuf {
>  #endif
> 
>   /* next 8 bytes are initialised on RX descriptor rearm */
> - RTE_MARKER64 rearm_data;
> - uint16_t data_off;
> -
> - /**
> -  * Reference counter. Its size should at least equal to the size
> -  * of port field (16 bits), to support zero-copy broadcast.
> -  * It should only be accessed using the following functions:
> -  * rte_mbuf_refcnt_update(), rte_mbuf_refcnt_read(), and
> -  * rte_mbuf_refcnt_set(). The functionality of these functions
> (atomic,
> -  * or non-atomic) is controlled by the RTE_MBUF_REFCNT_ATOMIC
> flag.
> -  */
> - RTE_ATOMIC(uint16_t) refcnt;
> + union {
> + uint64_t rearm_data[1];
> + __extension__
> + struct {
> + uint16_t data_off;
> +
> + /**
> +  * Reference counter. Its size should at least equal
> to the size
> +  * of port field (16 bits), to support zero-copy
> broadcast.
> +  * It should only be accessed using the following
> functions:
> +  * rte_mbuf_refcnt_update(), rte_mbuf_refcnt_read(),
> and
> +  * rte_mbuf_refcnt_set(). The functionality of these
> functions (atomic,
> +  * or non-atomic) is controlled by the
> RTE_MBUF_REFCNT_ATOMIC flag.
> +  */
> + RTE_ATOMIC(uint16_t) refcnt;
> 
> - /**
> -  * Number of segments. Only valid for the first segment of an mbuf
> -  * chain.
> -  */
> - uint16_t nb_segs;
> + /**
> +  * Number of segments. Only valid for the first
> segment of an mbuf
> +  * chain.
> +  */
> + uint16_t nb_segs;
> 
> - /** Input port (16 bits to support more than 256 virtual ports).
> -  * The event eth Tx adapter uses this field to specify the output
> port.
> -  */
> - uint16_t port;
> + /** Input port (16 bits to support more than 256
> virtual ports).
> +  * The event eth Tx adapter uses this field to
> specify the output port.
> +  */
> + uint16_t port;
> + };
> + };
> 
>   uint64_t ol_flags;/**< Offload features. */
> 
>   /* remaining bytes are set on RX when pulling packet from
> descriptor */
> - RTE_MARKER rx_descriptor_fields1;
> -
> - /*
> -  * The packet type, which is the combination of ou

Re: [PATCH v2 1/6] ethdev: support setting lanes

[lihuisong (C)]

在 2024/3/26 18:30, Thomas Monjalon 写道:

26/03/2024 02:42, lihuisong (C):

在 2024/3/25 17:30, Thomas Monjalon 写道:

25/03/2024 07:24, huangdengdui:

On 2024/3/22 21:58, Thomas Monjalon wrote:

22/03/2024 08:09, Dengdui Huang:

-#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8)  /**< 10 Gbps */
-#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9)  /**< 20 Gbps */
-#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps */
-#define RTE_ETH_LINK_SPEED_40G RTE_BIT32(11) /**< 40 Gbps */
-#define RTE_ETH_LINK_SPEED_50G RTE_BIT32(12) /**< 50 Gbps */
-#define RTE_ETH_LINK_SPEED_56G RTE_BIT32(13) /**< 56 Gbps */
-#define RTE_ETH_LINK_SPEED_100GRTE_BIT32(14) /**< 100 Gbps */
-#define RTE_ETH_LINK_SPEED_200GRTE_BIT32(15) /**< 200 Gbps */
-#define RTE_ETH_LINK_SPEED_400GRTE_BIT32(16) /**< 400 Gbps */
+#define RTE_ETH_LINK_SPEED_10GRTE_BIT32(8)  /**< 10 Gbps */
+#define RTE_ETH_LINK_SPEED_20GRTE_BIT32(9)  /**< 20 Gbps 2lanes */
+#define RTE_ETH_LINK_SPEED_25GRTE_BIT32(10) /**< 25 Gbps */
+#define RTE_ETH_LINK_SPEED_40GRTE_BIT32(11) /**< 40 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_50GRTE_BIT32(12) /**< 50 Gbps */
+#define RTE_ETH_LINK_SPEED_56GRTE_BIT32(13) /**< 56 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_100G   RTE_BIT32(14) /**< 100 Gbps */
+#define RTE_ETH_LINK_SPEED_200G   RTE_BIT32(15) /**< 200 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_400G   RTE_BIT32(16) /**< 400 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_10G_4LANES RTE_BIT32(17)  /**< 10 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_50G_2LANES RTE_BIT32(18) /**< 50 Gbps 2 lanes */
+#define RTE_ETH_LINK_SPEED_100G_2LANESRTE_BIT32(19) /**< 100 Gbps 2 lanes 
*/
+#define RTE_ETH_LINK_SPEED_100G_4LANESRTE_BIT32(20) /**< 100 Gbps 4lanes */
+#define RTE_ETH_LINK_SPEED_200G_2LANESRTE_BIT32(21) /**< 200 Gbps 2lanes */
+#define RTE_ETH_LINK_SPEED_400G_8LANESRTE_BIT32(22) /**< 400 Gbps 8lanes */

I don't think it is a good idea to make this more complex.
It brings nothing as far as I can see, compared to having speed and lanes 
separated.
Can we have lanes information a separate value? no need for bitmask.


Hi,Thomas, Ajit, roretzla, damodharam

I also considered the option at the beginning of the design.
But this option is not used due to the following reasons:
1. For the user, ethtool couples speed and lanes.
The result of querying the NIC capability is as follows:
Supported link modes:
  10baseSR4/Full
  10baseSR2/Full
The NIC capability is configured as follows:
ethtool -s eth1 speed 10 lanes 4 autoneg off
ethtool -s eth1 speed 10 lanes 2 autoneg off

Therefore, users are more accustomed to the coupling of speed and lanes.

2. For the PHY, When the physical layer capability is configured through the 
MDIO,
the speed and lanes are also coupled.
For example:
Table 45–7—PMA/PMD control 2 register bit definitions[1]
PMA/PMD type selection
  1 0 0 1 0 1 0 = 100GBASE-SR2 PMA/PMD
  0 1 0 1 1 1 1 = 100GBASE-SR4 PMA/PMD

Therefore, coupling speeds and lanes is easier to understand.
And it is easier for the driver to report the support lanes.

In addition, the code implementation is compatible with the old version.
When the driver does not support the lanes setting, the code does not need to 
be modified.

So I think the speed and lanes coupling is better.

I don't think so.
You are mixing hardware implementation, user tool, and API.
Having a separate and simple API is cleaner and not more difficult to handle
in some get/set style functions.

Having a separate and simple API is cleaner. It's good.
But supported lane capabilities have a lot to do with the specified
speed. This is determined by releated specification.
If we add a separate API for speed lanes, it probably is hard to check
the validity of the configuration for speed and lanes.
And the setting lane API sepparated from speed is not good for
uniforming all PMD's behavior in ethdev layer.

Please let's be more specific.
There are 3 needs:
- set PHY lane config
- get PHY lane config
- get PHY lane capabilities
IMO, this lane capabilities should be reported based on supported speed 
capabilities.


There is no problem providing a function to get the number of PHY lanes.
It is possible to set PHY lanes number after defining a fixed speed.

yes it's ok.



The patch[1] is an example for this separate API.
I think it is not very good. It cannot tell user and PMD the follow points:
1) user don't know what lanes should or can be set for a specified speed
on one NIC.

This is about capabilities.
Can we say a HW will support a maximum number of PHY lanes in general?
We may need to associate the maximum speed per lane?
Do we really need to associate PHY lane and PHY speed numbers for capabilities?

Personally, it should contain the below releationship at least.
speed 10G  --> 1lane 

Re: [PATCH 0/2] introduce PM QoS interface

[lihuisong (C)]

在 2024/3/26 16:27, Morten Brørup 写道:

From: lihuisong (C) [mailto:lihuis...@huawei.com]
Sent: Tuesday, 26 March 2024 03.12

在 2024/3/22 20:35, Morten Brørup 写道:

From: lihuisong (C) [mailto:lihuis...@huawei.com]
Sent: Friday, 22 March 2024 09.54

[...]


For the case need PM QoS in DPDK, I think, it is better to set cpu
latency to zero to prevent service thread from the deeper the idle

state.

It would defeat the purpose (i.e. not saving sufficient amounts of

power) if the CPU cannot enter a deeper idle state.
Yes, it is not good for power.
AFAIS, PM QoS is just to decrease the influence for performance.
Anyway, if we set to zero, system can be into Cstates-0 at least.

Personally, I would think a wake-up latency of up to 10 microseconds

should be fine for must purposes.

Default Linux timerslack is 50 microseconds, so you could also use

that value.
How much CPU latency is ok. Maybe, we can give the decision to the
application.

Yes, the application should decide the acceptable worst-case latency.


Linux will collect all these QoS request and use the minimum latency.
what do you think, Morten?

For the example application, you could use a value of 50 microseconds and refer 
to this value also being the default timerslack in Linux.

There is a description for "/proc//timerslack_ns" in Linux document [1]
"
This file provides the value of the task’s timerslack value in nanoseconds.
This value specifies an amount of time that normal timers may be 
deferred in order to coalesce timers and avoid unnecessary wakeups.
This allows a task’s interactivity vs power consumption tradeoff to be 
adjusted.

"
I cannot understand what the relationship is between the timerslack in 
Linux and cpu latency to wake up.
It seems that timerslack is just to defer the timer in order to coalesce 
timers and avoid unnecessary wakeups.
And it has not a lot to do with the CPU latency which is aimed to avoid 
task to enter deeper idle state and satify application request.

RE: [PATCH 0/2] introduce PM QoS interface

[Morten Brørup]

> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> Sent: Tuesday, 26 March 2024 13.15
> 
> 在 2024/3/26 16:27, Morten Brørup 写道:
> >> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> >> Sent: Tuesday, 26 March 2024 03.12
> >>
> >> 在 2024/3/22 20:35, Morten Brørup 写道:
>  From: lihuisong (C) [mailto:lihuis...@huawei.com]
>  Sent: Friday, 22 March 2024 09.54
> > [...]
> >
>  For the case need PM QoS in DPDK, I think, it is better to set cpu
>  latency to zero to prevent service thread from the deeper the idle
> >> state.
> >>> It would defeat the purpose (i.e. not saving sufficient amounts of
> >> power) if the CPU cannot enter a deeper idle state.
> >> Yes, it is not good for power.
> >> AFAIS, PM QoS is just to decrease the influence for performance.
> >> Anyway, if we set to zero, system can be into Cstates-0 at least.
> >>> Personally, I would think a wake-up latency of up to 10 microseconds
> >> should be fine for must purposes.
> >>> Default Linux timerslack is 50 microseconds, so you could also use
> >> that value.
> >> How much CPU latency is ok. Maybe, we can give the decision to the
> >> application.
> > Yes, the application should decide the acceptable worst-case latency.
> >
> >> Linux will collect all these QoS request and use the minimum latency.
> >> what do you think, Morten?
> > For the example application, you could use a value of 50 microseconds
> and refer to this value also being the default timerslack in Linux.
> There is a description for "/proc//timerslack_ns" in Linux document
> [1]
> "
> This file provides the value of the task’s timerslack value in
> nanoseconds.
> This value specifies an amount of time that normal timers may be
> deferred in order to coalesce timers and avoid unnecessary wakeups.
> This allows a task’s interactivity vs power consumption tradeoff to be
> adjusted.
> "
> I cannot understand what the relationship is between the timerslack in
> Linux and cpu latency to wake up.
> It seems that timerslack is just to defer the timer in order to coalesce
> timers and avoid unnecessary wakeups.
> And it has not a lot to do with the CPU latency which is aimed to avoid
> task to enter deeper idle state and satify application request.

Correct. They control two different things.

However, both can cause latency for the application, so my rationale for the 
relationship was:
If the application accepts X us of latency caused by kernel scheduling delays 
(caused by timerslack), the application should accept the same amount of 
latency caused by CPU wake-up latency.

This also means that if you want lower latency than 50 us, you should not only 
set cpu wake-up latency, you should also set timerslack.

Obviously, if the application is only affected by one of the two, the 
application only needs to adjust that one of them.

As for the 50 us value, someone in the Linux kernel team decided that 50 us was 
an acceptable amount of latency for the kernel; we could use the same value, 
referring to that. Or we could choose some other value, and describe how we 
came up with our own value. And if necessary, also adjust timerslack 
accordingly.

Re: [PATCH] graph: avoid id collisions

[Jerin Jacob]

On Mon, Mar 25, 2024 at 9:24 PM Robin Jarry  wrote:
>
> The graph id is determined based on a global variable that is
> incremented every time a graph is created, and decremented every time
> a graph is destroyed. This only works if graphs are destroyed in the
> reverse order in which they have been created.
>
> The following code produces duplicate graph IDs which can lead to
> use-after-free bugs and other undefined behaviours:
>
>   a = rte_graph_create(...); // id=0 graph_id=1
>   b = rte_graph_create(...); // id=1 graph_id=2
>   rte_graph_destroy(a);  // graph_id=1
>   c = rte_graph_create(...); // id=1 graph_id=2 (duplicate with b)
>   rte_graph_destroy(c);  // frees memory still used by b
>
> Remove the global counter. Make sure that the graph list is always
> ordered by increasing graph ids. When creating a new graph, pick a free
> id which is not allocated.


Please update app/test/test_graph.c to test this case.


>
> Signed-off-by: Robin Jarry 

[PATCH v7 00/14] fix lcore ID restriction

[Sivaprasad Tummala]

With modern CPUs, it is possible to have higher
CPU count thus we can have higher RTE_MAX_LCORES.
In DPDK sample applications, the current config
lcore options are hard limited to 255.

The patchset fixes these constraints by allowing
all lcore IDs up to RTE_MAX_LCORES. Also the rx
queue IDs are increased to support up to 65535.
The port ID constraints were also fixed to support
up to RTE_MAX_ETHPORTS.
  
v7: 
 - updated commit log with rx queue IDs
 - changed format specifier to %PRIu16
 - removed patch unrelated changes 

v6:
 - split queue_id, lcore_id and port_id changes as
   separate patches.
 - updated git commit description on individual
   patches
  
v5:
 - updated lcore_id type to uint32_t

v4:
 - fixed build errors with queue_id type
   in ipsec-secgw
 
v3:
 - updated queue_id type to uint16_t
 
v2:
 - fixed typo with lcore_id type in l3fwd

Sivaprasad Tummala (14):
  examples/l3fwd: fix queue ID restriction
  examples/l3fwd-power: fix queue ID restriction
  examples/l3fwd-graph: fix queue ID restriction
  examples/ipsec-secgw: fix queue ID restriction
  examples/l3fwd: fix lcore ID restriction
  examples/l3fwd-power: fix lcore ID restriction
  examples/l3fwd-graph: fix lcore ID restriction
  examples/ipsec-secgw: fix lcore ID restriction
  examples/qos_sched: fix lcore ID restriction
  examples/vm_power_manager: fix lcore ID restriction
  examples/l3fwd: fix port ID restriction
  examples/l3fwd-power: fix port ID restriction
  examples/l3fwd-graph: fix port ID restriction
  examples/ipsec-secgw: fix port ID restriction

 examples/ipsec-secgw/event_helper.h   |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c| 40 +++-
 examples/ipsec-secgw/ipsec.c  |  2 +-
 examples/ipsec-secgw/ipsec.h  |  6 +-
 examples/ipsec-secgw/ipsec_worker.c   | 10 ++-
 examples/l3fwd-graph/main.c   | 33 +-
 examples/l3fwd-power/main.c   | 65 ++-
 examples/l3fwd-power/main.h   |  4 +-
 examples/l3fwd-power/perf_core.c  | 19 --
 examples/l3fwd/l3fwd.h|  2 +-
 examples/l3fwd/l3fwd_acl.c|  4 +-
 examples/l3fwd/l3fwd_em.c |  4 +-
 examples/l3fwd/l3fwd_event.h  |  2 +-
 examples/l3fwd/l3fwd_fib.c|  4 +-
 examples/l3fwd/l3fwd_lpm.c|  5 +-
 examples/l3fwd/main.c | 42 +++-
 examples/qos_sched/args.c |  6 +-
 .../guest_cli/vm_power_cli_guest.c|  4 +-
 18 files changed, 135 insertions(+), 119 deletions(-)

-- 
2.25.1

[PATCH v7 01/14] examples/l3fwd: fix queue ID restriction

[Sivaprasad Tummala]

Currently application supports rx queue IDs up to 255
and max queues of 256 irrespective of device support.
This limits the number of active lcores to 256.

The patch fixes these constraints by increasing
the rx queue IDs to support up to 65535.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd/l3fwd.h   |  2 +-
 examples/l3fwd/l3fwd_acl.c   |  4 ++--
 examples/l3fwd/l3fwd_em.c|  4 ++--
 examples/l3fwd/l3fwd_event.h |  2 +-
 examples/l3fwd/l3fwd_fib.c   |  4 ++--
 examples/l3fwd/l3fwd_lpm.c   |  5 ++---
 examples/l3fwd/main.c| 24 +---
 7 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
index e7ae0e5834..12c264cb4c 100644
--- a/examples/l3fwd/l3fwd.h
+++ b/examples/l3fwd/l3fwd.h
@@ -74,7 +74,7 @@ struct mbuf_table {
 
 struct lcore_rx_queue {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
 } __rte_cache_aligned;
 
 struct lcore_conf {
diff --git a/examples/l3fwd/l3fwd_acl.c b/examples/l3fwd/l3fwd_acl.c
index 401692bcec..eec0361a3e 100644
--- a/examples/l3fwd/l3fwd_acl.c
+++ b/examples/l3fwd/l3fwd_acl.c
@@ -997,7 +997,7 @@ acl_main_loop(__rte_unused void *dummy)
uint64_t prev_tsc, diff_tsc, cur_tsc;
int i, nb_rx;
uint16_t portid;
-   uint8_t queueid;
+   uint16_t queueid;
struct lcore_conf *qconf;
int socketid;
const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1)
@@ -1020,7 +1020,7 @@ acl_main_loop(__rte_unused void *dummy)
portid = qconf->rx_queue_list[i].port_id;
queueid = qconf->rx_queue_list[i].queue_id;
RTE_LOG(INFO, L3FWD,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 "\n",
lcore_id, portid, queueid);
}
 
diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c
index 40e102b38a..f18ac0048b 100644
--- a/examples/l3fwd/l3fwd_em.c
+++ b/examples/l3fwd/l3fwd_em.c
@@ -586,7 +586,7 @@ em_main_loop(__rte_unused void *dummy)
unsigned lcore_id;
uint64_t prev_tsc, diff_tsc, cur_tsc;
int i, nb_rx;
-   uint8_t queueid;
+   uint16_t queueid;
uint16_t portid;
struct lcore_conf *qconf;
const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) /
@@ -609,7 +609,7 @@ em_main_loop(__rte_unused void *dummy)
portid = qconf->rx_queue_list[i].port_id;
queueid = qconf->rx_queue_list[i].queue_id;
RTE_LOG(INFO, L3FWD,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 "\n",
lcore_id, portid, queueid);
}
 
diff --git a/examples/l3fwd/l3fwd_event.h b/examples/l3fwd/l3fwd_event.h
index 9aad358003..c6a4a89127 100644
--- a/examples/l3fwd/l3fwd_event.h
+++ b/examples/l3fwd/l3fwd_event.h
@@ -78,8 +78,8 @@ struct l3fwd_event_resources {
uint8_t deq_depth;
uint8_t has_burst;
uint8_t enabled;
-   uint8_t eth_rx_queues;
uint8_t vector_enabled;
+   uint16_t eth_rx_queues;
uint16_t vector_size;
uint64_t vector_tmo_ns;
 };
diff --git a/examples/l3fwd/l3fwd_fib.c b/examples/l3fwd/l3fwd_fib.c
index 6a21984415..f38b19af3f 100644
--- a/examples/l3fwd/l3fwd_fib.c
+++ b/examples/l3fwd/l3fwd_fib.c
@@ -186,7 +186,7 @@ fib_main_loop(__rte_unused void *dummy)
uint64_t prev_tsc, diff_tsc, cur_tsc;
int i, nb_rx;
uint16_t portid;
-   uint8_t queueid;
+   uint16_t queueid;
struct lcore_conf *qconf;
const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) /
US_PER_S * BURST_TX_DRAIN_US;
@@ -208,7 +208,7 @@ fib_main_loop(__rte_unused void *dummy)
portid = qconf->rx_queue_list[i].port_id;
queueid = qconf->rx_queue_list[i].queue_id;
RTE_LOG(INFO, L3FWD,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 
"\n",
lcore_id, portid, queueid);
}
 
diff --git a/examples/l3fwd/l3fwd_lpm.c b/examples/l3fwd/l3fwd_lpm.c
index a484a33089..e8fd95aae9 100644
--- a/examples/l3fwd/l3fwd_lpm.c
+++ b/examples/l3fwd/l3fwd_lpm.c
@@ -148,8 +148,7 @@ lpm_main_loop(__rte_unused void *dummy)
unsigned lcore_id;
uint64_t prev_tsc, diff_tsc, cur_tsc;
int i, nb_rx;
-   uint16_t portid;
-   uint8_t queueid;
+   uint16_t portid, queueid;
struct lcore_conf *qconf;
const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1) /
US_PER_S * BURST_TX_DRAIN_US;
@@ -171,7

[PATCH v7 02/14] examples/l3fwd-power: fix queue ID restriction

[Sivaprasad Tummala]

Currently application supports rx queue IDs up to 255
and max queues of 256 irrespective of device support.
This limits the number of active lcores to 256.

The patch fixes these constraints by increasing the
rx queue IDs to support up to 65535.

Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores 
options")
Cc: radu.nico...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-power/main.c  | 49 +++-
 examples/l3fwd-power/main.h  |  2 +-
 examples/l3fwd-power/perf_core.c |  8 --
 3 files changed, 29 insertions(+), 30 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index f4adcf41b5..50aea99428 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -214,7 +214,7 @@ enum freq_scale_hint_t
 
 struct lcore_rx_queue {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
enum freq_scale_hint_t freq_up_hint;
uint32_t zero_rx_packet_count;
uint32_t idle_hint;
@@ -838,7 +838,7 @@ sleep_until_rx_interrupt(int num, int lcore)
struct rte_epoll_event event[num];
int n, i;
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
void *data;
 
if (status[lcore].wakeup) {
@@ -850,9 +850,9 @@ sleep_until_rx_interrupt(int num, int lcore)
n = rte_epoll_wait(RTE_EPOLL_PER_THREAD, event, num, 10);
for (i = 0; i < n; i++) {
data = event[i].epdata.data;
-   port_id = ((uintptr_t)data) >> CHAR_BIT;
+   port_id = ((uintptr_t)data) >> (sizeof(uint16_t) * CHAR_BIT);
queue_id = ((uintptr_t)data) &
-   RTE_LEN2MASK(CHAR_BIT, uint8_t);
+   RTE_LEN2MASK((sizeof(uint16_t) * CHAR_BIT), uint16_t);
RTE_LOG(INFO, L3FWD_POWER,
"lcore %u is waked up from rx interrupt on"
" port %d queue %d\n",
@@ -867,7 +867,7 @@ static void turn_on_off_intr(struct lcore_conf *qconf, bool 
on)
 {
int i;
struct lcore_rx_queue *rx_queue;
-   uint8_t queue_id;
+   uint16_t queue_id;
uint16_t port_id;
 
for (i = 0; i < qconf->n_rx_queue; ++i) {
@@ -887,7 +887,7 @@ static void turn_on_off_intr(struct lcore_conf *qconf, bool 
on)
 static int event_register(struct lcore_conf *qconf)
 {
struct lcore_rx_queue *rx_queue;
-   uint8_t queueid;
+   uint16_t queueid;
uint16_t portid;
uint32_t data;
int ret;
@@ -897,7 +897,7 @@ static int event_register(struct lcore_conf *qconf)
rx_queue = &(qconf->rx_queue_list[i]);
portid = rx_queue->port_id;
queueid = rx_queue->queue_id;
-   data = portid << CHAR_BIT | queueid;
+   data = portid << (sizeof(uint16_t) * CHAR_BIT) | queueid;
 
ret = rte_eth_dev_rx_intr_ctl_q(portid, queueid,
RTE_EPOLL_PER_THREAD,
@@ -917,8 +917,7 @@ static int main_intr_loop(__rte_unused void *dummy)
unsigned int lcore_id;
uint64_t prev_tsc, diff_tsc, cur_tsc;
int i, j, nb_rx;
-   uint8_t queueid;
-   uint16_t portid;
+   uint16_t portid, queueid;
struct lcore_conf *qconf;
struct lcore_rx_queue *rx_queue;
uint32_t lcore_rx_idle_count = 0;
@@ -946,7 +945,7 @@ static int main_intr_loop(__rte_unused void *dummy)
portid = qconf->rx_queue_list[i].port_id;
queueid = qconf->rx_queue_list[i].queue_id;
RTE_LOG(INFO, L3FWD_POWER,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 
"\n",
lcore_id, portid, queueid);
}
 
@@ -1083,8 +1082,7 @@ main_telemetry_loop(__rte_unused void *dummy)
unsigned int lcore_id;
uint64_t prev_tsc, diff_tsc, cur_tsc, prev_tel_tsc;
int i, j, nb_rx;
-   uint8_t queueid;
-   uint16_t portid;
+   uint16_t portid, queueid;
struct lcore_conf *qconf;
struct lcore_rx_queue *rx_queue;
uint64_t ep_nep[2] = {0}, fp_nfp[2] = {0};
@@ -1114,7 +1112,7 @@ main_telemetry_loop(__rte_unused void *dummy)
portid = qconf->rx_queue_list[i].port_id;
queueid = qconf->rx_queue_list[i].queue_id;
RTE_LOG(INFO, L3FWD_POWER, " -- lcoreid=%u portid=%u "
-   "rxqueueid=%hhu\n", lcore_id, portid, queueid);
+   "rxqueueid=%" PRIu16 "\n", lcore_id, portid, queueid);
}
 
while (!is_done()) {
@@ -1205,8 +1203,7 @@ main_legacy_loop(__rte_unused void *dummy)
uint64_t prev_tsc, diff_tsc, cur_tsc, tim_res_tsc, hz;
uint64_t prev_tsc_power = 0, cur_tsc_power, diff_tsc_power;

[PATCH v7 03/14] examples/l3fwd-graph: fix queue ID restriction

[Sivaprasad Tummala]

Currently application supports rx queue IDs up to 255
and max queues of 256 irrespective of device support.
This limits the number of active lcores to 256.

The patch fixes these constraints by increasing the
rx queue IDs to support up to 65535.

Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Cc: ndabilpu...@marvell.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-graph/main.c | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c
index 96cb1c81ff..4b018d1e78 100644
--- a/examples/l3fwd-graph/main.c
+++ b/examples/l3fwd-graph/main.c
@@ -90,7 +90,7 @@ static int pcap_trace_enable;
 
 struct lcore_rx_queue {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
char node_name[RTE_NODE_NAMESIZE];
 };
 
@@ -110,7 +110,7 @@ static struct lcore_conf lcore_conf[RTE_MAX_LCORE];
 
 struct lcore_params {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
uint8_t lcore_id;
 } __rte_cache_aligned;
 
@@ -205,14 +205,14 @@ check_worker_model_params(void)
 static int
 check_lcore_params(void)
 {
-   uint8_t queue, lcore;
+   uint16_t queue, i;
int socketid;
-   uint16_t i;
+   uint8_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
queue = lcore_params[i].queue_id;
if (queue >= MAX_RX_QUEUE_PER_PORT) {
-   printf("Invalid queue number: %hhu\n", queue);
+   printf("Invalid queue number: %" PRIu16 "\n", queue);
return -1;
}
lcore = lcore_params[i].lcore_id;
@@ -257,7 +257,7 @@ check_port_config(void)
return 0;
 }
 
-static uint8_t
+static uint16_t
 get_port_n_rx_queues(const uint16_t port)
 {
int queue = -1;
@@ -275,7 +275,7 @@ get_port_n_rx_queues(const uint16_t port)
}
}
 
-   return (uint8_t)(++queue);
+   return (uint16_t)(++queue);
 }
 
 static int
@@ -450,7 +450,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].port_id =
(uint8_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
-   (uint8_t)int_fld[FLD_QUEUE];
+   (uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
(uint8_t)int_fld[FLD_LCORE];
++nb_lcore_params;
@@ -1011,7 +1011,8 @@ main(int argc, char **argv)
"ethdev_tx-*",
"pkt_drop",
};
-   uint8_t nb_rx_queue, queue, socketid;
+   uint8_t socketid;
+   uint16_t nb_rx_queue, queue;
struct rte_graph_param graph_conf;
struct rte_eth_dev_info dev_info;
uint32_t nb_ports, nb_conf = 0;
-- 
2.25.1

[PATCH v7 04/14] examples/ipsec-secgw: fix queue ID restriction

[Sivaprasad Tummala]

Currently application supports rx queue IDs up to 255
and max queues of 256 irrespective of device support.
This limits the number of active lcores to 256.

The patch fixes these constraints by increasing the
rx queue IDs to support up to 65535.

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/ipsec-secgw/ipsec-secgw.c  | 19 +--
 examples/ipsec-secgw/ipsec.h|  2 +-
 examples/ipsec-secgw/ipsec_worker.c | 10 --
 3 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec-secgw.c 
b/examples/ipsec-secgw/ipsec-secgw.c
index 45a303850d..782535f4b5 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -220,7 +220,7 @@ static const char *cfgfile;
 
 struct lcore_params {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
uint8_t lcore_id;
 } __rte_cache_aligned;
 
@@ -695,8 +695,7 @@ ipsec_poll_mode_worker(void)
struct rte_mbuf *pkts[MAX_PKT_BURST];
uint32_t lcore_id;
uint64_t prev_tsc, diff_tsc, cur_tsc;
-   uint16_t i, nb_rx, portid;
-   uint8_t queueid;
+   uint16_t i, nb_rx, portid, queueid;
struct lcore_conf *qconf;
int32_t rc, socket_id;
const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1)
@@ -743,7 +742,7 @@ ipsec_poll_mode_worker(void)
portid = rxql[i].port_id;
queueid = rxql[i].queue_id;
RTE_LOG(INFO, IPSEC,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 "\n",
lcore_id, portid, queueid);
}
 
@@ -788,8 +787,7 @@ int
 check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)
 {
uint16_t i;
-   uint16_t portid;
-   uint8_t queueid;
+   uint16_t portid, queueid;
 
for (i = 0; i < nb_lcore_params; ++i) {
portid = lcore_params_array[i].port_id;
@@ -851,7 +849,7 @@ check_poll_mode_params(struct eh_conf *eh_conf)
return 0;
 }
 
-static uint8_t
+static uint16_t
 get_port_nb_rx_queues(const uint16_t port)
 {
int32_t queue = -1;
@@ -862,7 +860,7 @@ get_port_nb_rx_queues(const uint16_t port)
lcore_params[i].queue_id > queue)
queue = lcore_params[i].queue_id;
}
-   return (uint8_t)(++queue);
+   return (uint16_t)(++queue);
 }
 
 static int32_t
@@ -1050,6 +1048,7 @@ parse_config(const char *q_arg)
char *str_fld[_NUM_FLD];
int32_t i;
uint32_t size;
+   uint32_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};
 
nb_lcore_params = 0;
 
@@ -1070,7 +1069,7 @@ parse_config(const char *q_arg)
for (i = 0; i < _NUM_FLD; i++) {
errno = 0;
int_fld[i] = strtoul(str_fld[i], &end, 0);
-   if (errno != 0 || end == str_fld[i] || int_fld[i] > 255)
+   if (errno != 0 || end == str_fld[i] || int_fld[i] > 
max_fld[i])
return -1;
}
if (nb_lcore_params >= MAX_LCORE_PARAMS) {
@@ -1081,7 +1080,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].port_id =
(uint8_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
-   (uint8_t)int_fld[FLD_QUEUE];
+   (uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
(uint8_t)int_fld[FLD_LCORE];
++nb_lcore_params;
diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h
index bdcada1c40..29b9b283f0 100644
--- a/examples/ipsec-secgw/ipsec.h
+++ b/examples/ipsec-secgw/ipsec.h
@@ -285,7 +285,7 @@ struct cnt_blk {
 
 struct lcore_rx_queue {
uint16_t port_id;
-   uint8_t queue_id;
+   uint16_t queue_id;
void *sec_ctx;
 } __rte_cache_aligned;
 
diff --git a/examples/ipsec-secgw/ipsec_worker.c 
b/examples/ipsec-secgw/ipsec_worker.c
index 8d122e8519..c9c43ebd2b 100644
--- a/examples/ipsec-secgw/ipsec_worker.c
+++ b/examples/ipsec-secgw/ipsec_worker.c
@@ -1598,8 +1598,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)
int32_t socket_id;
uint32_t lcore_id;
int32_t i, nb_rx;
-   uint16_t portid;
-   uint8_t queueid;
+   uint16_t portid, queueid;
 
prev_tsc = 0;
lcore_id = rte_lcore_id();
@@ -1633,7 +1632,7 @@ ipsec_poll_mode_wrkr_inl_pr(void)
portid = rxql[i].port_id;
queueid = rxql[i].queue_id;
RTE_LOG(INFO, IPSEC,
-   " -- lcoreid=%u portid=%u rxqueueid=%hhu\n",
+   " -- lcoreid=%u portid=%u rxqueueid=%" PRIu16 "\n",
lcore_id, portid

[PATCH v7 05/14] examples/l3fwd: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd/main.c | 20 
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 039207b06c..47baf464e2 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -99,7 +99,7 @@ struct parm_cfg parm_config;
 struct lcore_params {
uint16_t port_id;
uint16_t queue_id;
-   uint8_t lcore_id;
+   uint32_t lcore_id;
 } __rte_cache_aligned;
 
 static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];
@@ -293,7 +293,7 @@ static int
 check_lcore_params(void)
 {
uint16_t queue, i;
-   uint8_t lcore;
+   uint32_t lcore;
int socketid;
 
for (i = 0; i < nb_lcore_params; ++i) {
@@ -304,12 +304,12 @@ check_lcore_params(void)
}
lcore = lcore_params[i].lcore_id;
if (!rte_lcore_is_enabled(lcore)) {
-   printf("error: lcore %hhu is not enabled in lcore 
mask\n", lcore);
+   printf("error: lcore %u is not enabled in lcore 
mask\n", lcore);
return -1;
}
if ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&
(numa_on == 0)) {
-   printf("warning: lcore %hhu is on socket %d with numa 
off \n",
+   printf("warning: lcore %u is on socket %d with numa 
off\n",
lcore, socketid);
}
}
@@ -359,14 +359,14 @@ static int
 init_lcore_rx_queues(void)
 {
uint16_t i, nb_rx_queue;
-   uint8_t lcore;
+   uint32_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
lcore = lcore_params[i].lcore_id;
nb_rx_queue = lcore_conf[lcore].n_rx_queue;
if (nb_rx_queue >= MAX_RX_QUEUE_PER_LCORE) {
printf("error: too many queues (%u) for lcore: %u\n",
-   (unsigned)nb_rx_queue + 1, (unsigned)lcore);
+   (unsigned int)nb_rx_queue + 1, lcore);
return -1;
} else {
lcore_conf[lcore].rx_queue_list[nb_rx_queue].port_id =
@@ -500,7 +500,11 @@ parse_config(const char *q_arg)
char *str_fld[_NUM_FLD];
int i;
unsigned size;
-   uint16_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};
+   uint16_t max_fld[_NUM_FLD] = {
+   255,
+   RTE_MAX_QUEUES_PER_PORT,
+   RTE_MAX_LCORE
+   };
 
nb_lcore_params = 0;
 
@@ -532,7 +536,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-   (uint8_t)int_fld[FLD_LCORE];
+   (uint32_t)int_fld[FLD_LCORE];
++nb_lcore_params;
}
lcore_params = lcore_params_array;
-- 
2.25.1

[PATCH v7 06/14] examples/l3fwd-power: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES.

Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores 
options")
Cc: radu.nico...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-power/main.c  | 18 +++---
 examples/l3fwd-power/main.h  |  2 +-
 examples/l3fwd-power/perf_core.c | 11 ---
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 50aea99428..eac92ef875 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1397,7 +1397,7 @@ static int
 check_lcore_params(void)
 {
uint16_t queue, i;
-   uint8_t lcore;
+   uint32_t lcore;
int socketid;
 
for (i = 0; i < nb_lcore_params; ++i) {
@@ -1408,13 +1408,13 @@ check_lcore_params(void)
}
lcore = lcore_params[i].lcore_id;
if (!rte_lcore_is_enabled(lcore)) {
-   printf("error: lcore %hhu is not enabled in lcore "
+   printf("error: lcore %u is not enabled in lcore "
"mask\n", lcore);
return -1;
}
if ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&
(numa_on == 0)) {
-   printf("warning: lcore %hhu is on socket %d with numa "
+   printf("warning: lcore %u is on socket %d with numa "
"off\n", lcore, socketid);
}
if (app_mode == APP_MODE_TELEMETRY && lcore == rte_lcore_id()) {
@@ -1466,14 +1466,14 @@ static int
 init_lcore_rx_queues(void)
 {
uint16_t i, nb_rx_queue;
-   uint8_t lcore;
+   uint32_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
lcore = lcore_params[i].lcore_id;
nb_rx_queue = lcore_conf[lcore].n_rx_queue;
if (nb_rx_queue >= MAX_RX_QUEUE_PER_LCORE) {
printf("error: too many queues (%u) for lcore: %u\n",
-   (unsigned)nb_rx_queue + 1, (unsigned)lcore);
+   (unsigned int)nb_rx_queue + 1, lcore);
return -1;
} else {
lcore_conf[lcore].rx_queue_list[nb_rx_queue].port_id =
@@ -1658,7 +1658,11 @@ parse_config(const char *q_arg)
char *str_fld[_NUM_FLD];
int i;
unsigned size;
-   unsigned int max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};
+   unsigned int max_fld[_NUM_FLD] = {
+   255,
+   RTE_MAX_QUEUES_PER_PORT,
+   RTE_MAX_LCORE
+   };
 
nb_lcore_params = 0;
 
@@ -1691,7 +1695,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-   (uint8_t)int_fld[FLD_LCORE];
+   (uint32_t)int_fld[FLD_LCORE];
++nb_lcore_params;
}
lcore_params = lcore_params_array;
diff --git a/examples/l3fwd-power/main.h b/examples/l3fwd-power/main.h
index 40b5194726..194bd82102 100644
--- a/examples/l3fwd-power/main.h
+++ b/examples/l3fwd-power/main.h
@@ -10,7 +10,7 @@
 struct lcore_params {
uint16_t port_id;
uint16_t queue_id;
-   uint8_t lcore_id;
+   uint32_t lcore_id;
 } __rte_cache_aligned;
 
 extern struct lcore_params *lcore_params;
diff --git a/examples/l3fwd-power/perf_core.c b/examples/l3fwd-power/perf_core.c
index f34442b9d0..fbd7864cb9 100644
--- a/examples/l3fwd-power/perf_core.c
+++ b/examples/l3fwd-power/perf_core.c
@@ -24,7 +24,7 @@ struct perf_lcore_params {
uint16_t port_id;
uint16_t queue_id;
uint8_t high_perf;
-   uint8_t lcore_idx;
+   uint32_t lcore_idx;
 } __rte_cache_aligned;
 
 static struct perf_lcore_params prf_lc_prms[MAX_LCORE_PARAMS];
@@ -132,7 +132,12 @@ parse_perf_config(const char *q_arg)
char *str_fld[_NUM_FLD];
int i;
unsigned int size;
-   unsigned int max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255, 
255};
+   unsigned int max_fld[_NUM_FLD] = {
+   255,
+   RTE_MAX_QUEUES_PER_PORT,
+   255,
+   RTE_MAX_LCORE
+   };
 
nb_prf_lc_prms = 0;
 
@@ -169,7 +174,7 @@ parse_perf_config(const char *q_arg)
prf_lc_prms[nb_prf_lc_prms].high_perf =
!!(uint8_t)int_fld[FLD_LCORE_HP];
prf_lc_prms[nb_prf_lc_prms].lcore_idx =
-

[PATCH v7 07/14] examples/l3fwd-graph: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are increased to support up to 65535.

Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Cc: ndabilpu...@marvell.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-graph/main.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c
index 4b018d1e78..dbc36362c3 100644
--- a/examples/l3fwd-graph/main.c
+++ b/examples/l3fwd-graph/main.c
@@ -111,7 +111,7 @@ static struct lcore_conf lcore_conf[RTE_MAX_LCORE];
 struct lcore_params {
uint16_t port_id;
uint16_t queue_id;
-   uint8_t lcore_id;
+   uint32_t lcore_id;
 } __rte_cache_aligned;
 
 static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];
@@ -207,7 +207,7 @@ check_lcore_params(void)
 {
uint16_t queue, i;
int socketid;
-   uint8_t lcore;
+   uint32_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
queue = lcore_params[i].queue_id;
@@ -217,7 +217,7 @@ check_lcore_params(void)
}
lcore = lcore_params[i].lcore_id;
if (!rte_lcore_is_enabled(lcore)) {
-   printf("Error: lcore %hhu is not enabled in lcore 
mask\n",
+   printf("Error: lcore %u is not enabled in lcore mask\n",
   lcore);
return -1;
}
@@ -228,7 +228,7 @@ check_lcore_params(void)
}
socketid = rte_lcore_to_socket_id(lcore);
if ((socketid != 0) && (numa_on == 0)) {
-   printf("Warning: lcore %hhu is on socket %d with numa 
off\n",
+   printf("Warning: lcore %u is on socket %d with numa 
off\n",
   lcore, socketid);
}
}
@@ -282,7 +282,7 @@ static int
 init_lcore_rx_queues(void)
 {
uint16_t i, nb_rx_queue;
-   uint8_t lcore;
+   uint32_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
lcore = lcore_params[i].lcore_id;
@@ -290,7 +290,7 @@ init_lcore_rx_queues(void)
if (nb_rx_queue >= MAX_RX_QUEUE_PER_LCORE) {
printf("Error: too many queues (%u) for lcore: %u\n",
   (unsigned int)nb_rx_queue + 1,
-  (unsigned int)lcore);
+  lcore);
return -1;
}
 
@@ -452,7 +452,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-   (uint8_t)int_fld[FLD_LCORE];
+   (uint32_t)int_fld[FLD_LCORE];
++nb_lcore_params;
}
lcore_params = lcore_params_array;
-- 
2.25.1

[PATCH v7 09/14] examples/qos_sched: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are increased to support up to 65535.

Fixes: de3cfa2c9823 ("sched: initial import")
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/qos_sched/args.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 8d61d3e454..886542b3c1 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -184,10 +184,10 @@ app_parse_flow_conf(const char *conf_str)
 
pconf->rx_port = vals[0];
pconf->tx_port = vals[1];
-   pconf->rx_core = (uint8_t)vals[2];
-   pconf->wt_core = (uint8_t)vals[3];
+   pconf->rx_core = vals[2];
+   pconf->wt_core = vals[3];
if (ret == 5)
-   pconf->tx_core = (uint8_t)vals[4];
+   pconf->tx_core = vals[4];
else
pconf->tx_core = pconf->wt_core;
 
-- 
2.25.1

[PATCH v7 11/14] examples/l3fwd: fix port ID restriction

[Sivaprasad Tummala]

Currently application supports port IDs up to 255
irrespective of RTE_MAX_ETHPORTS.

The patch fixes these constraints by allowing port
IDs up to RTE_MAX_ETHPORTS.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 47baf464e2..a239869ada 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -501,7 +501,7 @@ parse_config(const char *q_arg)
int i;
unsigned size;
uint16_t max_fld[_NUM_FLD] = {
-   255,
+   RTE_MAX_ETHPORTS,
RTE_MAX_QUEUES_PER_PORT,
RTE_MAX_LCORE
};
@@ -532,7 +532,7 @@ parse_config(const char *q_arg)
return -1;
}
lcore_params_array[nb_lcore_params].port_id =
-   (uint8_t)int_fld[FLD_PORT];
+   (uint16_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-- 
2.25.1

[PATCH v7 08/14] examples/ipsec-secgw: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are increased to support up to 65535.

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Cc: sergio.gonzalez.mon...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/ipsec-secgw/event_helper.h |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c  | 21 +
 examples/ipsec-secgw/ipsec.c|  2 +-
 examples/ipsec-secgw/ipsec.h|  4 ++--
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/examples/ipsec-secgw/event_helper.h 
b/examples/ipsec-secgw/event_helper.h
index dfb81bfcf1..be635685b4 100644
--- a/examples/ipsec-secgw/event_helper.h
+++ b/examples/ipsec-secgw/event_helper.h
@@ -102,7 +102,7 @@ struct eh_event_link_info {
/**< Event port ID */
uint8_t eventq_id;
/**< Event queue to be linked to the port */
-   uint8_t lcore_id;
+   uint32_t lcore_id;
/**< Lcore to be polling on this port */
 };
 
diff --git a/examples/ipsec-secgw/ipsec-secgw.c 
b/examples/ipsec-secgw/ipsec-secgw.c
index 782535f4b5..2d004d82fd 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -221,7 +221,7 @@ static const char *cfgfile;
 struct lcore_params {
uint16_t port_id;
uint16_t queue_id;
-   uint8_t lcore_id;
+   uint32_t lcore_id;
 } __rte_cache_aligned;
 
 static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];
@@ -807,7 +807,7 @@ check_flow_params(uint16_t fdir_portid, uint8_t fdir_qid)
 static int32_t
 check_poll_mode_params(struct eh_conf *eh_conf)
 {
-   uint8_t lcore;
+   uint32_t lcore;
uint16_t portid;
uint16_t i;
int32_t socket_id;
@@ -826,13 +826,13 @@ check_poll_mode_params(struct eh_conf *eh_conf)
for (i = 0; i < nb_lcore_params; ++i) {
lcore = lcore_params[i].lcore_id;
if (!rte_lcore_is_enabled(lcore)) {
-   printf("error: lcore %hhu is not enabled in "
+   printf("error: lcore %u is not enabled in "
"lcore mask\n", lcore);
return -1;
}
socket_id = rte_lcore_to_socket_id(lcore);
if (socket_id != 0 && numa_on == 0) {
-   printf("warning: lcore %hhu is on socket %d "
+   printf("warning: lcore %u is on socket %d "
"with numa off\n",
lcore, socket_id);
}
@@ -867,7 +867,7 @@ static int32_t
 init_lcore_rx_queues(void)
 {
uint16_t i, nb_rx_queue;
-   uint8_t lcore;
+   uint32_t lcore;
 
for (i = 0; i < nb_lcore_params; ++i) {
lcore = lcore_params[i].lcore_id;
@@ -1048,7 +1048,11 @@ parse_config(const char *q_arg)
char *str_fld[_NUM_FLD];
int32_t i;
uint32_t size;
-   uint32_t max_fld[_NUM_FLD] = {255, RTE_MAX_QUEUES_PER_PORT, 255};
+   uint32_t max_fld[_NUM_FLD] = {
+   255,
+   RTE_MAX_QUEUES_PER_PORT,
+   RTE_MAX_LCORE
+   };
 
nb_lcore_params = 0;
 
@@ -1082,7 +1086,7 @@ parse_config(const char *q_arg)
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-   (uint8_t)int_fld[FLD_LCORE];
+   (uint32_t)int_fld[FLD_LCORE];
++nb_lcore_params;
}
lcore_params = lcore_params_array;
@@ -1918,7 +1922,8 @@ port_init(uint16_t portid, uint64_t req_rx_offloads, 
uint64_t req_tx_offloads,
struct rte_eth_dev_info dev_info;
struct rte_eth_txconf *txconf;
uint16_t nb_tx_queue, nb_rx_queue;
-   uint16_t tx_queueid, rx_queueid, queue, lcore_id;
+   uint16_t tx_queueid, rx_queueid, queue;
+   uint32_t lcore_id;
int32_t ret, socket_id;
struct lcore_conf *qconf;
struct rte_ether_addr ethaddr;
diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index c321108119..b52b0ffc3d 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -259,7 +259,7 @@ create_lookaside_session(struct ipsec_ctx 
*ipsec_ctx_lcore[],
continue;
 
/* Looking for cryptodev, which can handle this SA */
-   key.lcore_id = (uint8_t)lcore_id;
+   key.lcore_id = lcore_id;
key.cipher_algo = (uint8_t)sa->cipher_algo;
key.auth_algo = (uint8_t)sa->auth_algo;
key.aead_algo = (uint8_t)sa->aead_algo;
diff --git a/example

[PATCH v7 10/14] examples/vm_power_manager: fix lcore ID restriction

[Sivaprasad Tummala]

Currently the config option allows lcore IDs up to 255,
irrespective of RTE_MAX_LCORES and needs to be fixed.

The patch fixes these constraints by allowing all
lcore IDs up to RTE_MAX_LCORES. Also the queue
IDs are increased to support up to 65535.

Fixes: 0e8f47491f09 ("examples/vm_power: add command to query CPU frequency")
Cc: marcinx.hajkow...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c 
b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index 94bfbbaf78..5eddb47847 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -401,7 +401,7 @@ check_response_cmd(unsigned int lcore_id, int *result)
 
 struct cmd_set_cpu_freq_result {
cmdline_fixed_string_t set_cpu_freq;
-   uint8_t lcore_id;
+   uint32_t lcore_id;
cmdline_fixed_string_t cmd;
 };
 
@@ -444,7 +444,7 @@ cmdline_parse_token_string_t cmd_set_cpu_freq =
set_cpu_freq, "set_cpu_freq");
 cmdline_parse_token_num_t cmd_set_cpu_freq_core_num =
TOKEN_NUM_INITIALIZER(struct cmd_set_cpu_freq_result,
-   lcore_id, RTE_UINT8);
+   lcore_id, RTE_UINT32);
 cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
TOKEN_STRING_INITIALIZER(struct cmd_set_cpu_freq_result,
cmd, "up#down#min#max#enable_turbo#disable_turbo");
-- 
2.25.1

[PATCH v7 12/14] examples/l3fwd-power: fix port ID restriction

[Sivaprasad Tummala]

Currently application supports port IDs up to 255
irrespective of RTE_MAX_ETHPORTS.

The patch fixes these constraints by allowing port
IDs up to RTE_MAX_ETHPORTS.

Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores 
options")
Cc: radu.nico...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-power/main.c  | 4 ++--
 examples/l3fwd-power/perf_core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index eac92ef875..a993af0408 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1659,7 +1659,7 @@ parse_config(const char *q_arg)
int i;
unsigned size;
unsigned int max_fld[_NUM_FLD] = {
-   255,
+   RTE_MAX_ETHPORTS,
RTE_MAX_QUEUES_PER_PORT,
RTE_MAX_LCORE
};
@@ -1691,7 +1691,7 @@ parse_config(const char *q_arg)
return -1;
}
lcore_params_array[nb_lcore_params].port_id =
-   (uint8_t)int_fld[FLD_PORT];
+   (uint16_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
diff --git a/examples/l3fwd-power/perf_core.c b/examples/l3fwd-power/perf_core.c
index fbd7864cb9..e4bdb62121 100644
--- a/examples/l3fwd-power/perf_core.c
+++ b/examples/l3fwd-power/perf_core.c
@@ -133,7 +133,7 @@ parse_perf_config(const char *q_arg)
int i;
unsigned int size;
unsigned int max_fld[_NUM_FLD] = {
-   255,
+   RTE_MAX_ETHPORTS,
RTE_MAX_QUEUES_PER_PORT,
255,
RTE_MAX_LCORE
@@ -168,7 +168,7 @@ parse_perf_config(const char *q_arg)
return -1;
}
prf_lc_prms[nb_prf_lc_prms].port_id =
-   (uint8_t)int_fld[FLD_PORT];
+   (uint16_t)int_fld[FLD_PORT];
prf_lc_prms[nb_prf_lc_prms].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
prf_lc_prms[nb_prf_lc_prms].high_perf =
-- 
2.25.1

[PATCH v7 13/14] examples/l3fwd-graph: fix port ID restriction

[Sivaprasad Tummala]

Currently application supports port IDs up to 255
irrespective of RTE_MAX_ETHPORTS.

The patch fixes these constraints by allowing port
IDs up to RTE_MAX_ETHPORTS.

Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")
Cc: ndabilpu...@marvell.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/l3fwd-graph/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c
index dbc36362c3..4ded69b4a0 100644
--- a/examples/l3fwd-graph/main.c
+++ b/examples/l3fwd-graph/main.c
@@ -448,7 +448,7 @@ parse_config(const char *q_arg)
}
 
lcore_params_array[nb_lcore_params].port_id =
-   (uint8_t)int_fld[FLD_PORT];
+   (uint16_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-- 
2.25.1

[PATCH v7 14/14] examples/ipsec-secgw: fix port ID restriction

[Sivaprasad Tummala]

Currently application supports port IDs up to 255
irrespective of RTE_MAX_ETHPORTS.

The patch fixes these constraints by allowing port
IDs up to RTE_MAX_ETHPORTS.

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Cc: sergio.gonzalez.mon...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Sivaprasad Tummala 
Acked-by: Konstantin Ananyev 
Acked-by: Morten Brørup 
Acked-by: Ferruh Yigit 
---
 examples/ipsec-secgw/ipsec-secgw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec-secgw.c 
b/examples/ipsec-secgw/ipsec-secgw.c
index 2d004d82fd..761b9cf396 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1049,7 +1049,7 @@ parse_config(const char *q_arg)
int32_t i;
uint32_t size;
uint32_t max_fld[_NUM_FLD] = {
-   255,
+   RTE_MAX_ETHPORTS,
RTE_MAX_QUEUES_PER_PORT,
RTE_MAX_LCORE
};
@@ -1082,7 +1082,7 @@ parse_config(const char *q_arg)
return -1;
}
lcore_params_array[nb_lcore_params].port_id =
-   (uint8_t)int_fld[FLD_PORT];
+   (uint16_t)int_fld[FLD_PORT];
lcore_params_array[nb_lcore_params].queue_id =
(uint16_t)int_fld[FLD_QUEUE];
lcore_params_array[nb_lcore_params].lcore_id =
-- 
2.25.1

[PATCH v7 00/14] fix lcore ID restriction

[Sivaprasad Tummala]

With modern CPUs, it is possible to have higher
CPU count thus we can have higher RTE_MAX_LCORES.
In DPDK sample applications, the current config
lcore options are hard limited to 255.

The patchset fixes these constraints by allowing
all lcore IDs up to RTE_MAX_LCORES. Also the rx
queue IDs are increased to support up to 65535.
The port ID constraints were also fixed to support
up to RTE_MAX_ETHPORTS.
  
v7: 
 - updated commit log with rx queue IDs
 - changed format specifier to %PRIu16
 - removed patch unrelated changes 

v6:
 - split queue_id, lcore_id and port_id changes as
   separate patches.
 - updated git commit description on individual
   patches
  
v5:
 - updated lcore_id type to uint32_t

v4:
 - fixed build errors with queue_id type
   in ipsec-secgw
 
v3:
 - updated queue_id type to uint16_t
 
v2:
 - fixed typo with lcore_id type in l3fwd

Sivaprasad Tummala (14):
  examples/l3fwd: fix queue ID restriction
  examples/l3fwd-power: fix queue ID restriction
  examples/l3fwd-graph: fix queue ID restriction
  examples/ipsec-secgw: fix queue ID restriction
  examples/l3fwd: fix lcore ID restriction
  examples/l3fwd-power: fix lcore ID restriction
  examples/l3fwd-graph: fix lcore ID restriction
  examples/ipsec-secgw: fix lcore ID restriction
  examples/qos_sched: fix lcore ID restriction
  examples/vm_power_manager: fix lcore ID restriction
  examples/l3fwd: fix port ID restriction
  examples/l3fwd-power: fix port ID restriction
  examples/l3fwd-graph: fix port ID restriction
  examples/ipsec-secgw: fix port ID restriction

 examples/ipsec-secgw/event_helper.h   |  2 +-
 examples/ipsec-secgw/ipsec-secgw.c| 40 +++-
 examples/ipsec-secgw/ipsec.c  |  2 +-
 examples/ipsec-secgw/ipsec.h  |  6 +-
 examples/ipsec-secgw/ipsec_worker.c   | 10 ++-
 examples/l3fwd-graph/main.c   | 33 +-
 examples/l3fwd-power/main.c   | 65 ++-
 examples/l3fwd-power/main.h   |  4 +-
 examples/l3fwd-power/perf_core.c  | 19 --
 examples/l3fwd/l3fwd.h|  2 +-
 examples/l3fwd/l3fwd_acl.c|  4 +-
 examples/l3fwd/l3fwd_em.c |  4 +-
 examples/l3fwd/l3fwd_event.h  |  2 +-
 examples/l3fwd/l3fwd_fib.c|  4 +-
 examples/l3fwd/l3fwd_lpm.c|  5 +-
 examples/l3fwd/main.c | 42 +++-
 examples/qos_sched/args.c |  6 +-
 .../guest_cli/vm_power_cli_guest.c|  4 +-
 18 files changed, 135 insertions(+), 119 deletions(-)

-- 
2.25.1

Re: [PATCH v2 1/6] ethdev: support setting lanes

[Ajit Khaparde]

On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C)  wrote:
>
>
> 在 2024/3/26 18:30, Thomas Monjalon 写道:
> > 26/03/2024 02:42, lihuisong (C):
> >> 在 2024/3/25 17:30, Thomas Monjalon 写道:
> >>> 25/03/2024 07:24, huangdengdui:
>  On 2024/3/22 21:58, Thomas Monjalon wrote:
> > 22/03/2024 08:09, Dengdui Huang:
> >> -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8)  /**< 10 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9)  /**< 20 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_40G RTE_BIT32(11) /**< 40 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_50G RTE_BIT32(12) /**< 50 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_56G RTE_BIT32(13) /**< 56 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_100GRTE_BIT32(14) /**< 100 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_200GRTE_BIT32(15) /**< 200 Gbps */
> >> -#define RTE_ETH_LINK_SPEED_400GRTE_BIT32(16) /**< 400 Gbps */
> >> +#define RTE_ETH_LINK_SPEED_10GRTE_BIT32(8)  /**< 10 Gbps 
> >> */
> >> +#define RTE_ETH_LINK_SPEED_20GRTE_BIT32(9)  /**< 20 Gbps 
> >> 2lanes */
> >> +#define RTE_ETH_LINK_SPEED_25GRTE_BIT32(10) /**< 25 Gbps 
> >> */
> >> +#define RTE_ETH_LINK_SPEED_40GRTE_BIT32(11) /**< 40 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_50GRTE_BIT32(12) /**< 50 Gbps 
> >> */
> >> +#define RTE_ETH_LINK_SPEED_56GRTE_BIT32(13) /**< 56 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_100G   RTE_BIT32(14) /**< 100 Gbps 
> >> */
> >> +#define RTE_ETH_LINK_SPEED_200G   RTE_BIT32(15) /**< 200 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_400G   RTE_BIT32(16) /**< 400 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_10G_4LANES RTE_BIT32(17)  /**< 10 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_50G_2LANES RTE_BIT32(18) /**< 50 Gbps 
> >> 2 lanes */
> >> +#define RTE_ETH_LINK_SPEED_100G_2LANESRTE_BIT32(19) /**< 100 Gbps 
> >> 2 lanes */
> >> +#define RTE_ETH_LINK_SPEED_100G_4LANESRTE_BIT32(20) /**< 100 Gbps 
> >> 4lanes */
> >> +#define RTE_ETH_LINK_SPEED_200G_2LANESRTE_BIT32(21) /**< 200 Gbps 
> >> 2lanes */
> >> +#define RTE_ETH_LINK_SPEED_400G_8LANESRTE_BIT32(22) /**< 400 Gbps 
> >> 8lanes */
> > I don't think it is a good idea to make this more complex.
> > It brings nothing as far as I can see, compared to having speed and 
> > lanes separated.
> > Can we have lanes information a separate value? no need for bitmask.
> >
>  Hi,Thomas, Ajit, roretzla, damodharam
> 
>  I also considered the option at the beginning of the design.
>  But this option is not used due to the following reasons:
>  1. For the user, ethtool couples speed and lanes.
>  The result of querying the NIC capability is as follows:
>  Supported link modes:
>    10baseSR4/Full
>    10baseSR2/Full
>  The NIC capability is configured as follows:
>  ethtool -s eth1 speed 10 lanes 4 autoneg off
>  ethtool -s eth1 speed 10 lanes 2 autoneg off
> 
>  Therefore, users are more accustomed to the coupling of speed and lanes.
> 
>  2. For the PHY, When the physical layer capability is configured through 
>  the MDIO,
>  the speed and lanes are also coupled.
>  For example:
>  Table 45–7—PMA/PMD control 2 register bit definitions[1]
>  PMA/PMD type selection
>    1 0 0 1 0 1 0 = 100GBASE-SR2 PMA/PMD
>    0 1 0 1 1 1 1 = 100GBASE-SR4 PMA/PMD
> 
>  Therefore, coupling speeds and lanes is easier to understand.
>  And it is easier for the driver to report the support lanes.
> 
>  In addition, the code implementation is compatible with the old version.
>  When the driver does not support the lanes setting, the code does not 
>  need to be modified.
> 
>  So I think the speed and lanes coupling is better.
> >>> I don't think so.
> >>> You are mixing hardware implementation, user tool, and API.
> >>> Having a separate and simple API is cleaner and not more difficult to 
> >>> handle
> >>> in some get/set style functions.
> >> Having a separate and simple API is cleaner. It's good.
> >> But supported lane capabilities have a lot to do with the specified
> >> speed. This is determined by releated specification.
> >> If we add a separate API for speed lanes, it probably is hard to check
> >> the validity of the configuration for speed and lanes.
> >> And the setting lane API sepparated from speed is not good for
> >> uniforming all PMD's behavior in ethdev layer.
> > Please let's be more specific.
> > There are 3 needs:
> >   - set PHY lane config
> >   - get PHY lane config
> >   - get PHY lane capabilities

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Garrett D'Amore]

This could work. Not that we would like to have the exceptional case of IPv6 
use less headroom.   So we would say 40 is our compiled in default and then we 
reduce it by 20 on IPv6 which doesn’t have to support all the same devices that 
IPv4 does. This would give the lowest disruption to the existing IPv4 stack and 
allow PMDs to updated incrementally.
On Mar 26, 2024 at 1:05 AM -0700, Morten Brørup , 
wrote:
> Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
> traffic terminating) application, which doesn’t really care about the 
> preceding headers, can benefit from having its actual data at a specific 
> offset for alignment purposes. I don’t consider this very exotic. (Even the 
> Linux kernel uses this trick to achieve improved IP header alignment on RX.)
>
> I think the proper solution would be to add a new offload parameter to 
> rte_eth_rxconf to specify how many bytes the driver should subtract from 
> RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
> Depending on driver support, this would make it configurable per device and 
> per RX queue.
>
> If this parameter is set, the driver should adjust m->data_off accordingly on 
> RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still 
> point to the Ethernet header.
>
>
> Med venlig hilsen / Kind regards,
> -Morten Brørup
>
> From: Garrett D'Amore [mailto:garr...@damore.org]
> Sent: Monday, 25 March 2024 23.56
>
> So we need (for reasons that I don't want to get to into in too much detail) 
> that our UDP payload headers are at a specific offset in the packet.
>
> This was not a problem as long as we only used IPv4.  (We have configured 40 
> bytes of headroom, which is more than any of our PMDs need by a hefty margin.)
>
> Now that we're extending to support IPv6, we need to reduce that headroom by 
> 20 bytes, to preserve our UDP payload offset.
>
> This has big ramifications for how we fragment our own upper layer messages, 
> and it has been determined that updating the PMDs to allow us to change the 
> headroom for this use case (on a per port basis, as we will have some ports 
> on IPv4 and others on IPv6) is the least effort, but a large margin.  (Well, 
> copying the frames via memcpy would be less development effort, but would be 
> a performance catastrophe.)
>
> For transmit side we don't need this, as we can simply adjust the packet as 
> needed.  But for the receive side, we are kind of stuck, as the PMDs rely on 
> the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.
>
> As far as header splitting, that would indeed be a much much nicer solution.
>
> I haven't looked in the latest code to see if header splitting is even an 
> option -- the version of the DPDK I'm working with is a little older (20.11) 
> -- we have to update but we have other local changes and so updating is one 
> of the things that we still have to do.
>
> At any rate, the version I did look at doesn't seem to support header splits 
> on any device other than FM10K.  That's not terrifically interesting for us.  
> We use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really -- ENA, 
> virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on client 
> systems in the field.
>
> We also, unfortunately, have an older DPDK 18 with Mellanox contributions for 
> IPoverIB though I'm not sure we will try to support IPv6 there.  (We are 
> working towards replacing that part of stack with UCX.)
>
> Unless header splitting will work on all of this (excepting the IPoIB piece), 
> then it's not something we can really use.
> On Mar 25, 2024 at 10:20 AM -0700, Stephen Hemminger 
> , wrote:
>
> On Mon, 25 Mar 2024 10:01:52 +
> Bruce Richardson  wrote:
>
>
> On Sat, Mar 23, 2024 at 01:51:25PM -0700, Garrett D'Amore wrote:
>
> > So we right now (at WEKA) have a somewhat older version of DPDK that we
> > have customized heavily, and I am going to to need to to make the
> > headroom *dynamic* (passed in at run time, and per port.)
> > We have this requirement because we need payload to be at a specific
> > offset, but have to deal with different header lengths for IPv4 and now
> > IPv6.
> > My reason for pointing this out, is that I would dearly like if we
> > could collaborate on this -- this change is going to touch pretty much
> > every PMD (we don't need it on all of them as we only support a subset
> > of PMDs, but its still a significant set.)
> > I'm not sure if anyone else has considered such a need -- this
> > particular message caught my eye as I'm looking specifically in this
> > area right now.
> >
> Hi
>
> thanks for reaching out. Can you clarify a little more as to the need for
> this requirement? Can you not just set the headroom value to the max needed
> value for any port and use that? Is there an issue with having blank space
> at the start of a buffer?
>
> Thanks,
> /Bruce
>
> If you have to make such a deep change across all PMD's then maybe
> it is not the bes

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Morten Brørup]

Something just struck me…

The buffer address field in the RX descriptor of some NICs may have alignment 
requirements, i.e. the lowest bits in the buffer address field of the NIC’s RX 
descriptor may be used for other purposes (and assumed zero for buffer address 
purposes). 40 is divisible by 8, but offset 20 requires that the NIC hardware 
supports 4-byte aligned addresses (so only the 2 lowest bits may be used for 
other purposes).

 

Here’s an example of what I mean:

https://docs.amd.com/r/en-US/am011-versal-acap-trm/RX-Descriptor-Words 
 

 

If any of your supported NICs have that restriction, i.e. requires an 8 byte 
aligned buffer address, your concept of having the UDP payload at the same 
fixed offset for both IPv4 and IPv6 is not going to be possible. (And you were 
lucky that the offset happens to be sufficiently aligned to work for IPv4 to 
begin with.)

 

It seems you need to read a bunch of datasheets before proceeding.

 

 

Med venlig hilsen / Kind regards,

-Morten Brørup

 

From: Garrett D'Amore [mailto:garr...@damore.org] 
Sent: Tuesday, 26 March 2024 15.19



This could work. Not that we would like to have the exceptional case of IPv6 
use less headroom.   So we would say 40 is our compiled in default and then we 
reduce it by 20 on IPv6 which doesn’t have to support all the same devices that 
IPv4 does. This would give the lowest disruption to the existing IPv4 stack and 
allow PMDs to updated incrementally. 

On Mar 26, 2024 at 1:05 AM -0700, Morten Brørup , 
wrote:



Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
traffic terminating) application, which doesn’t really care about the preceding 
headers, can benefit from having its actual data at a specific offset for 
alignment purposes. I don’t consider this very exotic. (Even the Linux kernel 
uses this trick to achieve improved IP header alignment on RX.)

 

I think the proper solution would be to add a new offload parameter to 
rte_eth_rxconf to specify how many bytes the driver should subtract from 
RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
Depending on driver support, this would make it configurable per device and per 
RX queue.

 

If this parameter is set, the driver should adjust m->data_off accordingly on 
RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still point 
to the Ethernet header.

 

 

Med venlig hilsen / Kind regards,

-Morten Brørup

 

From: Garrett D'Amore [mailto:garr...@damore.org]
Sent: Monday, 25 March 2024 23.56

So we need (for reasons that I don't want to get to into in too much detail) 
that our UDP payload headers are at a specific offset in the packet.

This was not a problem as long as we only used IPv4.  (We have configured 40 
bytes of headroom, which is more than any of our PMDs need by a hefty margin.)

Now that we're extending to support IPv6, we need to reduce that headroom by 20 
bytes, to preserve our UDP payload offset.

This has big ramifications for how we fragment our own upper layer messages, 
and it has been determined that updating the PMDs to allow us to change the 
headroom for this use case (on a per port basis, as we will have some ports on 
IPv4 and others on IPv6) is the least effort, but a large margin.  (Well, 
copying the frames via memcpy would be less development effort, but would be a 
performance catastrophe.)

For transmit side we don't need this, as we can simply adjust the packet as 
needed.  But for the receive side, we are kind of stuck, as the PMDs rely on 
the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.

As far as header splitting, that would indeed be a much much nicer solution.

I haven't looked in the latest code to see if header splitting is even an 
option -- the version of the DPDK I'm working with is a little older (20.11) -- 
we have to update but we have other local changes and so updating is one of the 
things that we still have to do.

At any rate, the version I did look at doesn't seem to support header splits on 
any device other than FM10K.  That's not terrifically interesting for us.  We 
use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really -- ENA, 
virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on client 
systems in the field.

We also, unfortunately, have an older DPDK 18 with Mellanox contributions for 
IPoverIB though I'm not sure we will try to support IPv6 there.  (We are 
working towards replacing that part of stack with UCX.)

Unless header splitting will work on all of this (excepting the IPoIB piece), 
then it's not something we can really use.

On Mar 25, 2024 at 10:20 AM -0700, Stephen Hemminger 
, wrote:

On Mon, 25 Mar 2024 10:01:52 +
Bruce Richardson  wrote:



On Sat, Mar 23, 2024 at 01:51:25PM -0700, Garrett D'Amore wrote:

> So we right now (at WEKA) have a somewhat older version of DPDK that we
> have customized heavily, a

[PATCH v2] graph: avoid id collisions

[Robin Jarry]

The graph id is determined based on a global variable that is
incremented every time a graph is created, and decremented every time
a graph is destroyed. This only works if graphs are destroyed in the
reverse order in which they have been created.

The following code produces duplicate graph IDs which can lead to
use-after-free bugs and other undefined behaviours:

  a = rte_graph_create(...); // id=0 graph_id=1
  b = rte_graph_create(...); // id=1 graph_id=2
  rte_graph_destroy(a);  // graph_id=1
  c = rte_graph_create(...); // id=1 graph_id=2 (duplicate with b)
  rte_graph_destroy(c);  // frees memory still used by b

Remove the global counter. Make sure that the graph list is always
ordered by increasing graph ids. When creating a new graph, pick a free
id which is not allocated.

Update unit tests to ensure it works as expected.

Signed-off-by: Robin Jarry 
---

Notes:
v2: Added unit test

 app/test/test_graph.c | 63 +++
 lib/graph/graph.c | 86 ++-
 2 files changed, 132 insertions(+), 17 deletions(-)

diff --git a/app/test/test_graph.c b/app/test/test_graph.c
index b8409bc60497..c650ac4f57b7 100644
--- a/app/test/test_graph.c
+++ b/app/test/test_graph.c
@@ -696,6 +696,68 @@ test_graph_clone(void)
return ret;
 }
 
+static int
+test_graph_id_collisions(void)
+{
+   static const char *node_patterns[] = {"test_node_source1", 
"test_node00"};
+   struct rte_graph_param gconf = {
+   .socket_id = SOCKET_ID_ANY,
+   .nb_node_patterns = 2,
+   .node_patterns = node_patterns,
+   };
+   rte_graph_t g1, g2, g3;
+
+   g1 = rte_graph_create("worker1", &gconf);
+   if (g1 == RTE_GRAPH_ID_INVALID) {
+   printf("Graph 1 creation failed with error = %d\n", rte_errno);
+   return -1;
+   }
+   g2 = rte_graph_create("worker2", &gconf);
+   if (g2 == RTE_GRAPH_ID_INVALID) {
+   printf("Graph 2 creation failed with error = %d\n", rte_errno);
+   return -1;
+   }
+   if (g1 == g2) {
+   printf("Graph ids should be different\n");
+   return -1;
+   }
+   if (rte_graph_destroy(g1) < 0) {
+   printf("Graph 1 suppression failed\n");
+   return -1;
+   }
+   g3 = rte_graph_create("worker3", &gconf);
+   if (g3 == RTE_GRAPH_ID_INVALID) {
+   printf("Graph 3 creation failed with error = %d\n", rte_errno);
+   return -1;
+   }
+   if (g3 == g2) {
+   printf("Graph ids should be different\n");
+   return -1;
+   }
+   g1 = rte_graph_clone(g2, "worker1", &gconf);
+   if (g1 == RTE_GRAPH_ID_INVALID) {
+   printf("Graph 2 clone failed with error = %d\n", rte_errno);
+   return -1;
+   }
+   if (g1 == g2 || g2 == g3 || g1 == g3) {
+   printf("Graph ids should be different\n");
+   return -1;
+   }
+   if (rte_graph_destroy(g1) < 0) {
+   printf("Graph 1 suppression failed\n");
+   return -1;
+   }
+   if (rte_graph_destroy(g2) < 0) {
+   printf("Graph 2 suppression failed\n");
+   return -1;
+   }
+   if (rte_graph_destroy(g3) < 0) {
+   printf("Graph 3 suppression failed\n");
+   return -1;
+   }
+   return 0;
+}
+
 static int
 test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
 {
@@ -977,6 +1039,7 @@ static struct unit_test_suite graph_testsuite = {
TEST_CASE(test_lookup_functions),
TEST_CASE(test_create_graph),
TEST_CASE(test_graph_clone),
+   TEST_CASE(test_graph_id_collisions),

TEST_CASE(test_graph_model_mcore_dispatch_node_lcore_affinity_set),
TEST_CASE(test_graph_model_mcore_dispatch_core_bind_unbind),
TEST_CASE(test_graph_worker_model_set_get),
diff --git a/lib/graph/graph.c b/lib/graph/graph.c
index 147bc6c685c5..50616580d06b 100644
--- a/lib/graph/graph.c
+++ b/lib/graph/graph.c
@@ -19,11 +19,54 @@
 
 static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list);
 static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER;
-static rte_graph_t graph_id;
-
-#define GRAPH_ID_CHECK(id) ID_CHECK(id, graph_id)
 
 /* Private functions */
+static struct graph *
+graph_from_id(rte_graph_t id)
+{
+   struct graph *graph;
+   STAILQ_FOREACH(graph, &graph_list, next) {
+   if (graph->id == id)
+   return graph;
+   }
+   rte_errno = EINVAL;
+   return NULL;
+}
+
+static rte_graph_t
+graph_next_free_id(void)
+{
+   struct graph *graph;
+   rte_graph_t id = 0;
+
+   STAILQ_FOREACH(graph, &graph_list, next) {
+   if (id < graph->id)
+   break;
+   id = graph->id + 1;
+   }
+
+   return id;

Re: [PATCH 0/2] introduce PM QoS interface

[Tyler Retzlaff]

On Tue, Mar 26, 2024 at 10:20:45AM +0800, lihuisong (C) wrote:
> Hi Tyler,
> 
> 在 2024/3/23 1:55, Tyler Retzlaff 写道:
> >On Fri, Mar 22, 2024 at 04:54:01PM +0800, lihuisong (C) wrote:
> >>+Tyler, +Alan, +Wei, +Long for asking this similar feature on Windows.
> >>
> >>在 2024/3/21 21:30, Morten Brørup 写道:
> From: lihuisong (C) [mailto:lihuis...@huawei.com]
> Sent: Thursday, 21 March 2024 04.04
> 
> Hi Moren,
> 
> Thanks for your revew.
> 
> 在 2024/3/20 22:05, Morten Brørup 写道:
> >>From: Huisong Li [mailto:lihuis...@huawei.com]
> >>Sent: Wednesday, 20 March 2024 11.55
> >>
> >>The system-wide CPU latency QoS limit has a positive impact on the idle
> >>state selection in cpuidle governor.
> >>
> >>Linux creates a cpu_dma_latency device under '/dev' directory to obtain 
> >>the
> >>CPU latency QoS limit on system and send the QoS request for userspace.
> >>Please see the PM QoS framework in the following link:
> >>https://docs.kernel.org/power/pm_qos_interface.html?highlight=qos
> >>This feature is supported by kernel-v2.6.25.
> >>
> >>The deeper the idle state, the lower the power consumption, but the 
> >>longer
> >>the resume time. Some service are delay sensitive and very except the 
> >>low
> >>resume time, like interrupt packet receiving mode.
> >>
> >>So this series introduce PM QoS interface.
> >This looks like a 1:1 wrapper for a Linux kernel feature.
> right
> >Does Windows or BSD offer something similar?
> How do we know Windows or BSD support this similar feature?
> >>>Ask Windows experts or research using Google.
> >>I download freebsd source code, I didn't find this similar feature.
> >>They don't even support cpuidle feature(this QoS feature affects cpuilde.).
> >>I don't find any useful about this on Windows from google.
> >>
> >>
> >>@Tyler, @Alan, @Wei and @Long
> >>
> >>Do you know windows support that userspace read and send CPU latency
> >>which has an impact on deep level of CPU idle?
> >it is unlikely you'll find an api that let's you manage things in terms
> >of raw latency values as the linux knobs here do. windows more often employs
> >policy centric schemes to permit the system to abstract implementation 
> >detail.
> >
> >powercfg is probably the closest thing you can use to tune the same
> >things on windows. where you select e.g. the 'performance' scheme but it
> >won't allow you to pick specific latency numbers.
> >
> >https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/powercfg-command-line-options
> 
> Thanks for your feedback. I will take a look at this tool.
> 
> >
> The DPDK power lib just work on Linux according to the meson.build under
> lib/power.
> If they support this features, they can open it.
> >>>The DPDK power lib currently only works on Linux, yes.
> >>>But its API should still be designed to be platform agnostic, so the 
> >>>functions can be implemented on other platforms in the future.
> >>>
> >>>DPDK is on track to work across multiple platforms, including Windows.
> >>>We must always consider other platforms, and not design DPDK APIs as if 
> >>>they are for Linux/BSD only.
> >>totally understand you.
> >since lib/power isn't built for windows at this time i don't think it's
> >appropriate to constrain your innovation. i do appreciate the engagement
> >though and would just offer general guidance that if you can design your
> >api with some kind of abstraction in mind that would be great and by all
> >means if you can figure out how to wrangle powercfg /Qh into satisfying the
> >api in a policy centric way it might be kind of nice.
> Testing this by using powercfg on Windows creates a very challenge for me.
> So I don't plan to do this on Windows. If you need, you can add it, ok?

ordinarily i would say it is appropriate to, however in this
circumstance i agree. there is quite possibly significant porting work
to be done so i would have to address it if we ever include it for
windows.

thanks

> >
> >i'll let other windows experts chime in here if they choose.
> >
> >thanks!
> >
> >Furthermore, any high-res timing should use nanoseconds, not 
> >microseconds or
> milliseconds.
> >I realize that the Linux kernel only uses microseconds for these APIs, 
> >but
> the DPDK API should use nanoseconds.
> Nanoseconds is more precise, it's good.
> But DPDK API how use nanoseconds as you said the the Linux kernel only
> uses microseconds for these APIs.
> Kernel interface just know an integer value with microseconds unit.
> >>>One solution is to expose nanoseconds in the DPDK API, and in the Linux 
> >>>specific implementation convert from/to microseconds.
> >>If so, we have to modify the implementation interface on Linux. This
> >>change the input/output unit about the interface.
> >>And DPDK also has to do this based on kernel version. It is not good.
> >>The cpuidle 

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Konstantin Ananyev]

Just wonder what would happen if you’ll receive an ipv6 packet with options or 
some fancy encapsulation IP-IP or so?
BTW, there is an  RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offload:
https://doc.dpdk.org/api/structrte__eth__rxseg__split.html
Which might be close to what you are looking for, but right now it is supported 
by mlx5 PMD only.

From: Garrett D'Amore 
Sent: Tuesday, March 26, 2024 2:19 PM
To: Bruce Richardson ; Stephen Hemminger 
; Morten Brørup 
Cc: dev@dpdk.org; Parthakumar Roy 
Subject: RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

This could work. Not that we would like to have the exceptional case of IPv6 
use less headroom.   So we would say 40 is our compiled in default and then we 
reduce it by 20 on IPv6 which doesn’t have to support all the same devices that 
IPv4 does. This would give the lowest disruption to the existing IPv4 stack and 
allow PMDs to updated incrementally.
On Mar 26, 2024 at 1:05 AM -0700, Morten Brørup 
mailto:m...@smartsharesystems.com>>, wrote:

Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
traffic terminating) application, which doesn’t really care about the preceding 
headers, can benefit from having its actual data at a specific offset for 
alignment purposes. I don’t consider this very exotic. (Even the Linux kernel 
uses this trick to achieve improved IP header alignment on RX.)

I think the proper solution would be to add a new offload parameter to 
rte_eth_rxconf to specify how many bytes the driver should subtract from 
RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
Depending on driver support, this would make it configurable per device and per 
RX queue.

If this parameter is set, the driver should adjust m->data_off accordingly on 
RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still point 
to the Ethernet header.


Med venlig hilsen / Kind regards,
-Morten Brørup

From: Garrett D'Amore [mailto:garr...@damore.org]
Sent: Monday, 25 March 2024 23.56
So we need (for reasons that I don't want to get to into in too much detail) 
that our UDP payload headers are at a specific offset in the packet.

This was not a problem as long as we only used IPv4.  (We have configured 40 
bytes of headroom, which is more than any of our PMDs need by a hefty margin.)

Now that we're extending to support IPv6, we need to reduce that headroom by 20 
bytes, to preserve our UDP payload offset.

This has big ramifications for how we fragment our own upper layer messages, 
and it has been determined that updating the PMDs to allow us to change the 
headroom for this use case (on a per port basis, as we will have some ports on 
IPv4 and others on IPv6) is the least effort, but a large margin.  (Well, 
copying the frames via memcpy would be less development effort, but would be a 
performance catastrophe.)

For transmit side we don't need this, as we can simply adjust the packet as 
needed.  But for the receive side, we are kind of stuck, as the PMDs rely on 
the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.

As far as header splitting, that would indeed be a much much nicer solution.

I haven't looked in the latest code to see if header splitting is even an 
option -- the version of the DPDK I'm working with is a little older (20.11) -- 
we have to update but we have other local changes and so updating is one of the 
things that we still have to do.

At any rate, the version I did look at doesn't seem to support header splits on 
any device other than FM10K.  That's not terrifically interesting for us.  We 
use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really -- ENA, 
virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on client 
systems in the field.

We also, unfortunately, have an older DPDK 18 with Mellanox contributions for 
IPoverIB though I'm not sure we will try to support IPv6 there.  (We are 
working towards replacing that part of stack with UCX.)

Unless header splitting will work on all of this (excepting the IPoIB piece), 
then it's not something we can really use.
On Mar 25, 2024 at 10:20 AM -0700, Stephen Hemminger 
mailto:step...@networkplumber.org>>, wrote:
On Mon, 25 Mar 2024 10:01:52 +
Bruce Richardson 
mailto:bruce.richard...@intel.com>> wrote:

On Sat, Mar 23, 2024 at 01:51:25PM -0700, Garrett D'Amore wrote:
> So we right now (at WEKA) have a somewhat older version of DPDK that we
> have customized heavily, and I am going to to need to to make the
> headroom *dynamic* (passed in at run time, and per port.)
> We have this requirement because we need payload to be at a specific
> offset, but have to deal with different header lengths for IPv4 and now
> IPv6.
> My reason for pointing this out, is that I would dearly like if we
> could collaborate on this -- this change is going to touch pretty much
> every PMD (we don't need it on all of them as we only support a subset
> of PMDs, but its still a significant set.)
> I'm not sure if anyon

[PATCH v14 00/15] Logging unification and improvments

[Stephen Hemminger]

Improvements and unification of logging library (for 24.07 release).
This version works on all platforms: Linux, Windows and FreeBSD.

This is update to rework patch set. It adds several new features
to the console log output.

  * Putting a timestamp on console output which is useful for
analyzing performance of startup codes. Timestamp is optional
and must be enabled on command line.

  * Displaying console output with colors.
It uses the standard conventions used by many other Linux commands
for colorized display.  The default is to enable color if the
console output is going to a terminal. But it can be always
on or disabled by command line flag. This default was chosen
based on what dmesg(1) command does.

I find color helpful because DPDK drivers and libraries print
lots of not very useful messages. And having error messages
highlighted in bold face helps. This might also get users to
pay more attention to error messages. Many bug reports have
earlier messages that are lost because there are so many
info messages.

  * Add support for automatic detection of systemd journal
protocol. If running as systemd service will get enhanced
logging.

  * Use of syslog is optional and the meaning of the
--syslog flag has changed. The default is *not* to use
syslog. 

Add myself as maintainer for log because by now have added
more than previous authors...
Will add a release note in next release (after this is merged)

v14 - fix Windows build, by having common asprintf shim
  fix asprintf memory leaks
  add log stream when using journal

Stephen Hemminger (15):
  maintainers: add for log library
  windows: make getopt functions have const properties
  windows: add os shim for localtime_r
  windows: common wrapper for vasprintf and asprintf
  eal: make eal_log_level_parse common
  eal: do not duplicate rte_init_alert() messages
  eal: change rte_exit() output to match rte_log()
  log: move handling of syslog facility out of eal
  eal: initialize log before everything else
  log: drop syslog support, and make code common
  log: add hook for printing log messages
  log: add timestamp option
  log: add optional support of syslog
  log: add support for systemd journal
  log: colorize log output

 MAINTAINERS   |   1 +
 app/test/test_eal_flags.c |  64 +-
 doc/guides/linux_gsg/linux_eal_parameters.rst |  27 -
 doc/guides/prog_guide/log_lib.rst |  57 ++
 drivers/bus/pci/pci_common.c  |  32 -
 lib/eal/common/eal_common_debug.c |  10 +-
 lib/eal/common/eal_common_options.c   | 117 ++--
 lib/eal/common/eal_options.h  |   5 +
 lib/eal/common/eal_private.h  |  10 -
 lib/eal/freebsd/eal.c |  64 +-
 lib/eal/linux/eal.c   |  68 +-
 lib/eal/windows/eal.c |  77 +--
 lib/eal/windows/getopt.c  |  23 +-
 lib/eal/windows/include/getopt.h  |   8 +-
 lib/eal/windows/include/rte_os_shim.h |  56 ++
 lib/log/log.c | 633 +-
 lib/log/log_freebsd.c |   5 +-
 lib/log/log_internal.h|  25 +-
 lib/log/log_linux.c   |  61 --
 lib/log/log_windows.c |  18 -
 lib/log/meson.build   |   5 +-
 lib/log/version.map   |   4 +-
 22 files changed, 942 insertions(+), 428 deletions(-)
 delete mode 100644 lib/log/log_linux.c
 delete mode 100644 lib/log/log_windows.c

-- 
2.43.0

[PATCH v14 01/15] maintainers: add for log library

[Stephen Hemminger]

"You touch it you own it"
Add myself as maintainer for log library.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7abb3aee49..54c28a601d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -180,6 +180,7 @@ F: app/test/test_threads.c
 F: app/test/test_version.c
 
 Logging
+M: Stephen Hemminger 
 F: lib/log/
 F: doc/guides/prog_guide/log_lib.rst
 F: app/test/test_logs.c
-- 
2.43.0

[PATCH v14 02/15] windows: make getopt functions have const properties

[Stephen Hemminger]

Having different prototypes on different platforms can lead
to lots of unnecessary workarounds.  Looks like the version of
getopt used from windows was based on an older out of date
version from FreeBSD.

This patch changes getopt, getopt_long, etc to have the same const
attributes as Linux and FreeBSD. The changes are derived from
the current FreeBSD version of getopt_long.

Signed-off-by: Stephen Hemminger 
Acked-by: Tyler Retzlaff 
Acked-by: Dmitry Kozlyuk 
---
 lib/eal/windows/getopt.c | 23 ---
 lib/eal/windows/include/getopt.h |  8 
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/lib/eal/windows/getopt.c b/lib/eal/windows/getopt.c
index a1f51c6c23..50ff71b930 100644
--- a/lib/eal/windows/getopt.c
+++ b/lib/eal/windows/getopt.c
@@ -20,7 +20,7 @@
 #include 
 #include 
 
-const char*optarg; /* argument associated with option */
+char*optarg;   /* argument associated with option */
 intopterr = 1; /* if error message should be printed */
 intoptind = 1; /* index into parent argv vector */
 intoptopt = '?';   /* character checked for validity */
@@ -39,9 +39,9 @@ static void pass(const char *a) {(void) a; }
 #defineBADARG  ((*options == ':') ? (int)':' : (int)'?')
 #defineINORDER 1
 
-#defineEMSG""
+static char EMSG[] = "";
 
-static const char *place = EMSG; /* option letter processing */
+static char *place = EMSG; /* option letter processing */
 
 /* XXX: set optreset to 1 rather than these two */
 static int nonopt_start = -1; /* first non option argument (for permute) */
@@ -80,7 +80,7 @@ gcd(int a, int b)
  */
 static void
 permute_args(int panonopt_start, int panonopt_end, int opt_end,
-   char **nargv)
+   char * const *nargv)
 {
int cstart, cyclelen, i, j, ncycle, nnonopts, nopts, pos;
char *swap;
@@ -101,11 +101,12 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
pos -= nnonopts;
else
pos += nopts;
+
swap = nargv[pos];
/* LINTED const cast */
-   ((char **) nargv)[pos] = nargv[cstart];
+   ((char **)(uintptr_t)nargv)[pos] = nargv[cstart];
/* LINTED const cast */
-   ((char **)nargv)[cstart] = swap;
+   ((char **)(uintptr_t)nargv)[cstart] = swap;
}
}
 }
@@ -116,7 +117,7 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
  * Returns -1 if short_too is set and the option does not match long_options.
  */
 static int
-parse_long_options(char **nargv, const char *options,
+parse_long_options(char * const *nargv, const char *options,
const struct option *long_options, int *idx, int short_too)
 {
const char *current_argv;
@@ -236,7 +237,7 @@ parse_long_options(char **nargv, const char *options,
  * Parse argc/argv argument vector.  Called by user level routines.
  */
 static int
-getopt_internal(int nargc, char **nargv, const char *options,
+getopt_internal(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx, int flags)
 {
char *oli;  /* option letter list index */
@@ -434,7 +435,7 @@ getopt_internal(int nargc, char **nargv, const char 
*options,
  * Parse argc/argv argument vector.
  */
 int
-getopt(int nargc, char *nargv[], const char *options)
+getopt(int nargc, char *const nargv[], const char *options)
 {
return getopt_internal(nargc, nargv, options, NULL, NULL,
   FLAG_PERMUTE);
@@ -445,7 +446,7 @@ getopt(int nargc, char *nargv[], const char *options)
  * Parse argc/argv argument vector.
  */
 int
-getopt_long(int nargc, char *nargv[], const char *options,
+getopt_long(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
@@ -458,7 +459,7 @@ getopt_long(int nargc, char *nargv[], const char *options,
  * Parse argc/argv argument vector.
  */
 int
-getopt_long_only(int nargc, char *nargv[], const char *options,
+getopt_long_only(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
diff --git a/lib/eal/windows/include/getopt.h b/lib/eal/windows/include/getopt.h
index 6f57af454b..e4cf6873cb 100644
--- a/lib/eal/windows/include/getopt.h
+++ b/lib/eal/windows/include/getopt.h
@@ -44,7 +44,7 @@
 
 
 /** argument to current option, or NULL if it has none */
-extern const char *optarg;
+extern char *optarg;
 /** Current position in arg string.  Starts from 1.
  * Setting to 0 resets state.
  */
@@ -80,14 +80,14 @@ struct option {
 };
 
 /** Compat: getopt */
-int getopt(int argc, char *argv[], const char *options);
+int getopt(int argc, char *const

[PATCH v14 03/15] windows: add os shim for localtime_r

[Stephen Hemminger]

Windows does not have localtime_r but it does have a similar
function that can be used instead.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/windows/include/rte_os_shim.h | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/lib/eal/windows/include/rte_os_shim.h 
b/lib/eal/windows/include/rte_os_shim.h
index eda8113662..e9741a9df2 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -110,4 +110,14 @@ rte_clock_gettime(clockid_t clock_id, struct timespec *tp)
 }
 #define clock_gettime(clock_id, tp) rte_clock_gettime(clock_id, tp)
 
+static inline struct tm *
+rte_localtime_r(const time_t *timer, struct tm *buf)
+{
+   if (localtime_s(buf, timer) == 0)
+   return buf;
+   else
+   return NULL;
+}
+#define localtime_r(timer, buf) rte_localtime_r(timer, buf)
+
 #endif /* _RTE_OS_SHIM_ */
-- 
2.43.0

[PATCH v14 04/15] windows: common wrapper for vasprintf and asprintf

[Stephen Hemminger]

Replace the windows version of asprintf() that was only usable
in eal. With a more generic one that supports both vasprintf()
and asprintf().  This also eliminates duplicate code.

Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information")
Fixes: 9ec521006db0 ("eal/windows: hide asprintf shim")

Signed-off-by: Stephen Hemminger 
---
 drivers/bus/pci/pci_common.c  | 32 ---
 lib/eal/common/eal_private.h  | 10 --
 lib/eal/windows/eal.c | 28 
 lib/eal/windows/include/rte_os_shim.h | 46 +++
 4 files changed, 46 insertions(+), 70 deletions(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 889a48d2af..80691c75a3 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -45,38 +45,6 @@ const char *rte_pci_get_sysfs_path(void)
return path;
 }
 
-#ifdef RTE_EXEC_ENV_WINDOWS
-#define asprintf pci_asprintf
-
-static int
-__rte_format_printf(2, 3)
-pci_asprintf(char **buffer, const char *format, ...)
-{
-   int size, ret;
-   va_list arg;
-
-   va_start(arg, format);
-   size = vsnprintf(NULL, 0, format, arg);
-   va_end(arg);
-   if (size < 0)
-   return -1;
-   size++;
-
-   *buffer = malloc(size);
-   if (*buffer == NULL)
-   return -1;
-
-   va_start(arg, format);
-   ret = vsnprintf(*buffer, size, format, arg);
-   va_end(arg);
-   if (ret != size - 1) {
-   free(*buffer);
-   return -1;
-   }
-   return ret;
-}
-#endif /* RTE_EXEC_ENV_WINDOWS */
-
 static struct rte_devargs *
 pci_devargs_lookup(const struct rte_pci_addr *pci_addr)
 {
diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 71523cfdb8..da8d77a134 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -737,16 +737,6 @@ void __rte_thread_init(unsigned int lcore_id, rte_cpuset_t 
*cpuset);
  */
 void __rte_thread_uninit(void);
 
-/**
- * asprintf(3) replacement for Windows.
- */
-#ifdef RTE_EXEC_ENV_WINDOWS
-__rte_format_printf(2, 3)
-int eal_asprintf(char **buffer, const char *format, ...);
-
-#define asprintf(buffer, format, ...) \
-   eal_asprintf(buffer, format, ##__VA_ARGS__)
-#endif
 
 #define EAL_LOG(level, ...) \
RTE_LOG_LINE(level, EAL, "" __VA_ARGS__)
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 52f0e7462d..8ca00c0f95 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -503,34 +503,6 @@ rte_eal_init(int argc, char **argv)
return fctret;
 }
 
-/* Don't use MinGW asprintf() to have identical code with all toolchains. */
-int
-eal_asprintf(char **buffer, const char *format, ...)
-{
-   int size, ret;
-   va_list arg;
-
-   va_start(arg, format);
-   size = vsnprintf(NULL, 0, format, arg);
-   va_end(arg);
-   if (size < 0)
-   return -1;
-   size++;
-
-   *buffer = malloc(size);
-   if (*buffer == NULL)
-   return -1;
-
-   va_start(arg, format);
-   ret = vsnprintf(*buffer, size, format, arg);
-   va_end(arg);
-   if (ret != size - 1) {
-   free(*buffer);
-   return -1;
-   }
-   return ret;
-}
-
 int
 rte_vfio_container_dma_map(__rte_unused int container_fd,
__rte_unused uint64_t vaddr,
diff --git a/lib/eal/windows/include/rte_os_shim.h 
b/lib/eal/windows/include/rte_os_shim.h
index e9741a9df2..b941476fe0 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -3,6 +3,7 @@
 #ifndef _RTE_OS_SHIM_
 #define _RTE_OS_SHIM_
 
+#include 
 #include 
 
 #include 
@@ -120,4 +121,49 @@ rte_localtime_r(const time_t *timer, struct tm *buf)
 }
 #define localtime_r(timer, buf) rte_localtime_r(timer, buf)
 
+/* print to allocated string */
+static inline int
+rte_vasprintf(char **strp, const char *fmt, va_list ap)
+{
+   char *str;
+   int len, ret;
+
+   *strp = NULL;
+
+   /* determine size of buffer needed */
+   len = _vscprintf(fmt, ap);
+   if (len < 0)
+   return -1;
+
+   len += 1;   /* for nul termination */
+   str = malloc(len);
+   if (str == NULL)
+   return -1;
+
+   ret = vsnprintf(str, len, fmt, ap);
+   if (ret < 0) {
+   free(str);
+   return -1;
+   } else {
+   *strp = str;
+   return ret;
+   }
+}
+#define vasprintf(strp, fmt, ap) rte_vasprintf(strp, fmt, ap)
+
+static inline int
+rte_asprintf(char **strp, const char *fmt, ...)
+{
+   int ret;
+
+   va_list ap;
+
+   va_start(ap, fmt);
+   ret = rte_vasprintf(strp, fmt, ap);
+   va_end(ap);
+
+   return ret;
+}
+
+#define asprintf(strp, fmt, ...) rte_asprintf(strp, fmt, __VA_ARGS__)
 #endif /* _RTE_OS_SHIM_ */
-- 
2.43.0

[PATCH v14 05/15] eal: make eal_log_level_parse common

[Stephen Hemminger]

The code to parse for log-level option should be same on
all OS variants.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_options.c | 46 +
 lib/eal/common/eal_options.h|  1 +
 lib/eal/freebsd/eal.c   | 42 --
 lib/eal/linux/eal.c | 39 
 lib/eal/windows/eal.c   | 35 --
 5 files changed, 47 insertions(+), 116 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index e541f07939..5435399b85 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -1640,6 +1640,51 @@ eal_parse_huge_unlink(const char *arg, struct 
hugepage_file_discipline *out)
return -1;
 }
 
+/* Parse the all arguments looking for log related ones */
+int
+eal_log_level_parse(int argc, char * const argv[])
+{
+   struct internal_config *internal_conf = 
eal_get_internal_configuration();
+   int option_index, opt;
+   const int old_optind = optind;
+   const int old_optopt = optopt;
+   const int old_opterr = opterr;
+   char *old_optarg = optarg;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   const int old_optreset = optreset;
+   optreset = 1;
+#endif
+
+   optind = 1;
+   opterr = 0;
+
+   while ((opt = getopt_long(argc, argv, eal_short_options,
+ eal_long_options, &option_index)) != EOF) {
+
+   switch (opt) {
+   case OPT_LOG_LEVEL_NUM:
+   if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
+   return -1;
+   break;
+   case '?':
+   /* getopt is not happy, stop right now */
+   goto out;
+   default:
+   continue;
+   }
+   }
+out:
+   /* restore getopt lib */
+   optind = old_optind;
+   optopt = old_optopt;
+   optarg = old_optarg;
+   opterr = old_opterr;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   optreset = old_optreset;
+#endif
+   return 0;
+}
+
 int
 eal_parse_common_option(int opt, const char *optarg,
struct internal_config *conf)
@@ -2173,6 +2218,7 @@ rte_vect_set_max_simd_bitwidth(uint16_t bitwidth)
return 0;
 }
 
+
 void
 eal_common_usage(void)
 {
diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h
index 3cc9cb6412..f3f2e104f6 100644
--- a/lib/eal/common/eal_options.h
+++ b/lib/eal/common/eal_options.h
@@ -96,6 +96,7 @@ enum {
 extern const char eal_short_options[];
 extern const struct option eal_long_options[];
 
+int eal_log_level_parse(int argc, char * const argv[]);
 int eal_parse_common_option(int opt, const char *argv,
struct internal_config *conf);
 int eal_option_device_parse(void);
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index bab77118e9..9825bcea0b 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -363,48 +363,6 @@ eal_get_hugepage_mem_size(void)
return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
 }
 
-/* Parse the arguments for --log-level only */
-static void
-eal_log_level_parse(int argc, char **argv)
-{
-   int opt;
-   char **argvopt;
-   int option_index;
-   const int old_optind = optind;
-   const int old_optopt = optopt;
-   const int old_optreset = optreset;
-   char * const old_optarg = optarg;
-   struct internal_config *internal_conf =
-   eal_get_internal_configuration();
-
-   argvopt = argv;
-   optind = 1;
-   optreset = 1;
-
-   while ((opt = getopt_long(argc, argvopt, eal_short_options,
- eal_long_options, &option_index)) != EOF) {
-
-   int ret;
-
-   /* getopt is not happy, stop right now */
-   if (opt == '?')
-   break;
-
-   ret = (opt == OPT_LOG_LEVEL_NUM) ?
-   eal_parse_common_option(opt, optarg, internal_conf) : 0;
-
-   /* common parser is not happy */
-   if (ret < 0)
-   break;
-   }
-
-   /* restore getopt lib */
-   optind = old_optind;
-   optopt = old_optopt;
-   optreset = old_optreset;
-   optarg = old_optarg;
-}
-
 /* Parse the argument given in the command line of the application */
 static int
 eal_parse_args(int argc, char **argv)
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index fd422f1f62..bffeb1f34e 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -546,45 +546,6 @@ eal_parse_vfio_vf_token(const char *vf_token)
return -1;
 }
 
-/* Parse the arguments for --log-level only */
-static void
-eal_log_level_parse(int argc, char **argv)
-{
-   int opt;
-   char **argvopt;
-   int option_index;
-   const int old_optind = optind;
-   const 

[PATCH v14 06/15] eal: do not duplicate rte_init_alert() messages

[Stephen Hemminger]

The message already goes through logging, and does not need
to be printed on stderr. Message level should be ALERT
to match function name.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/freebsd/eal.c | 3 +--
 lib/eal/linux/eal.c   | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 9825bcea0b..17b56f38aa 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -529,8 +529,7 @@ rte_eal_iopl_init(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-   fprintf(stderr, "EAL: FATAL: %s\n", msg);
-   EAL_LOG(ERR, "%s", msg);
+   EAL_LOG(ALERT, "%s", msg);
 }
 
 /* Launch threads, called at application init(). */
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index bffeb1f34e..23dc26b124 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-   fprintf(stderr, "EAL: FATAL: %s\n", msg);
-   EAL_LOG(ERR, "%s", msg);
+   EAL_LOG(ALERT, "%s", msg);
 }
 
 /*
-- 
2.43.0

[PATCH v14 07/15] eal: change rte_exit() output to match rte_log()

[Stephen Hemminger]

The rte_exit() output format confuses the timestamp and coloring
options. Change it to use be a single line with proper prefix.

Before:
[ 0.006481] EAL: Error - exiting with code: 1
  Cause: [ 0.006489] Cannot init EAL: Permission denied

After:
[ 0.006238] EAL: Error - exiting with code: 1
[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_debug.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/eal/common/eal_common_debug.c 
b/lib/eal/common/eal_common_debug.c
index 3e77995896..71bb5a7d34 100644
--- a/lib/eal/common/eal_common_debug.c
+++ b/lib/eal/common/eal_common_debug.c
@@ -34,17 +34,17 @@ void
 rte_exit(int exit_code, const char *format, ...)
 {
va_list ap;
+   char *msg = NULL;
 
if (exit_code != 0)
-   RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n"
-   "  Cause: ", exit_code);
+   EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code);
 
va_start(ap, format);
-   rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);
+   if (vasprintf(&msg, format, ap) > 0)
+   rte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, "EAL: Cause - %s", msg);
va_end(ap);
 
if (rte_eal_cleanup() != 0 && rte_errno != EALREADY)
-   EAL_LOG(CRIT,
-   "EAL could not release all resources");
+   EAL_LOG(CRIT, "EAL could not release all resources");
exit(exit_code);
 }
-- 
2.43.0

[PATCH v14 08/15] log: move handling of syslog facility out of eal

[Stephen Hemminger]

The syslog facility property is better handled in lib/log
rather than in eal. This also allows for changes to what
syslog flag means in later steps.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_options.c | 51 ++---
 lib/eal/freebsd/eal.c   |  5 ++-
 lib/eal/linux/eal.c |  7 ++--
 lib/eal/windows/eal.c   |  6 ++--
 lib/log/log_freebsd.c   |  2 +-
 lib/log/log_internal.h  |  5 ++-
 lib/log/log_linux.c | 47 --
 lib/log/log_windows.c   |  8 -
 lib/log/version.map |  1 +
 9 files changed, 68 insertions(+), 64 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 5435399b85..661b2db211 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -6,9 +6,6 @@
 #include 
 #include 
 #include 
-#ifndef RTE_EXEC_ENV_WINDOWS
-#include 
-#endif
 #include 
 #include 
 #include 
@@ -349,10 +346,6 @@ eal_reset_internal_config(struct internal_config 
*internal_cfg)
}
internal_cfg->base_virtaddr = 0;
 
-#ifdef LOG_DAEMON
-   internal_cfg->syslog_facility = LOG_DAEMON;
-#endif
-
/* if set to NONE, interrupt mode is determined automatically */
internal_cfg->vfio_intr_mode = RTE_INTR_MODE_NONE;
memset(internal_cfg->vfio_vf_token, 0,
@@ -1297,47 +1290,6 @@ eal_parse_lcores(const char *lcores)
return ret;
 }
 
-#ifndef RTE_EXEC_ENV_WINDOWS
-static int
-eal_parse_syslog(const char *facility, struct internal_config *conf)
-{
-   int i;
-   static const struct {
-   const char *name;
-   int value;
-   } map[] = {
-   { "auth", LOG_AUTH },
-   { "cron", LOG_CRON },
-   { "daemon", LOG_DAEMON },
-   { "ftp", LOG_FTP },
-   { "kern", LOG_KERN },
-   { "lpr", LOG_LPR },
-   { "mail", LOG_MAIL },
-   { "news", LOG_NEWS },
-   { "syslog", LOG_SYSLOG },
-   { "user", LOG_USER },
-   { "uucp", LOG_UUCP },
-   { "local0", LOG_LOCAL0 },
-   { "local1", LOG_LOCAL1 },
-   { "local2", LOG_LOCAL2 },
-   { "local3", LOG_LOCAL3 },
-   { "local4", LOG_LOCAL4 },
-   { "local5", LOG_LOCAL5 },
-   { "local6", LOG_LOCAL6 },
-   { "local7", LOG_LOCAL7 },
-   { NULL, 0 }
-   };
-
-   for (i = 0; map[i].name; i++) {
-   if (!strcmp(facility, map[i].name)) {
-   conf->syslog_facility = map[i].value;
-   return 0;
-   }
-   }
-   return -1;
-}
-#endif
-
 static void
 eal_log_usage(void)
 {
@@ -1663,6 +1615,7 @@ eal_log_level_parse(int argc, char * const argv[])
 
switch (opt) {
case OPT_LOG_LEVEL_NUM:
+   case OPT_SYSLOG_NUM:
if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
return -1;
break;
@@ -1882,7 +1835,7 @@ eal_parse_common_option(int opt, const char *optarg,
 
 #ifndef RTE_EXEC_ENV_WINDOWS
case OPT_SYSLOG_NUM:
-   if (eal_parse_syslog(optarg, conf) < 0) {
+   if (eal_log_syslog(optarg) < 0) {
EAL_LOG(ERR, "invalid parameters for --"
OPT_SYSLOG);
return -1;
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 17b56f38aa..6552f9c138 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -11,7 +11,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -392,8 +391,8 @@ eal_parse_args(int argc, char **argv)
goto out;
}
 
-   /* eal_log_level_parse() already handled this option */
-   if (opt == OPT_LOG_LEVEL_NUM)
+   /* eal_log_level_parse() already handled these */
+   if (opt == OPT_LOG_LEVEL_NUM || opt == OPT_LOG_SYSLOG_NUM)
continue;
 
ret = eal_parse_common_option(opt, optarg, internal_conf);
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 23dc26b124..3d0c34063e 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -610,8 +610,8 @@ eal_parse_args(int argc, char **argv)
goto out;
}
 
-   /* eal_log_level_parse() already handled this option */
-   if (opt == OPT_LOG_LEVEL_NUM)
+   /* eal_log_level_parse() already handled these options */
+   if (opt == OPT_LOG_LEVEL_NUM || opt == OPT_SYSLOG_NUM)
continue;
 
ret = eal_parse_common_option(opt, optarg, internal_conf);
@@ -1106,8 +1106,7 @@ rte_eal_init(int argc, ch

[PATCH v14 09/15] eal: initialize log before everything else

[Stephen Hemminger]

In order for all log messages (including CPU mismatch) to
come out through the logging library, it must be initialized
as early in rte_eal_init() as possible on all platforms.

Where it was done before was likely historical based on
the support of non-OS isolated CPU's which required a shared
memory buffer; that support was dropped before DPDK was
publicly released.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/freebsd/eal.c  | 12 +---
 lib/eal/linux/eal.c| 19 +--
 lib/eal/windows/eal.c  |  8 ++--
 lib/log/log_freebsd.c  |  3 +--
 lib/log/log_internal.h |  2 +-
 lib/log/log_linux.c| 14 ++
 lib/log/log_windows.c  |  4 +---
 7 files changed, 33 insertions(+), 29 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 6552f9c138..55ff27a4da 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -52,6 +52,7 @@
 #include "eal_options.h"
 #include "eal_memcfg.h"
 #include "eal_trace.h"
+#include "log_internal.h"
 
 #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
 
@@ -546,6 +547,14 @@ rte_eal_init(int argc, char **argv)
bool has_phys_addr;
enum rte_iova_mode iova_mode;
 
+   /* setup log as early as possible */
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
+   eal_log_init(getprogname());
+
/* checks if the machine is adequate */
if (!rte_cpu_is_supported()) {
rte_eal_init_alert("unsupported cpu type.");
@@ -565,9 +574,6 @@ rte_eal_init(int argc, char **argv)
/* clone argv to report out later in telemetry */
eal_save_args(argc, argv);
 
-   /* set log level as early as possible */
-   eal_log_level_parse(argc, argv);
-
if (rte_eal_cpu_init() < 0) {
rte_eal_init_alert("Cannot detect lcores.");
rte_errno = ENOTSUP;
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 3d0c34063e..b9a0fb1742 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -936,6 +936,15 @@ rte_eal_init(int argc, char **argv)
struct internal_config *internal_conf =
eal_get_internal_configuration();
 
+   /* setup log as early as possible */
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
+
+   eal_log_init(program_invocation_short_name);
+
/* checks if the machine is adequate */
if (!rte_cpu_is_supported()) {
rte_eal_init_alert("unsupported cpu type.");
@@ -952,9 +961,6 @@ rte_eal_init(int argc, char **argv)
 
eal_reset_internal_config(internal_conf);
 
-   /* set log level as early as possible */
-   eal_log_level_parse(argc, argv);
-
/* clone argv to report out later in telemetry */
eal_save_args(argc, argv);
 
@@ -1106,13 +1112,6 @@ rte_eal_init(int argc, char **argv)
 #endif
}
 
-   if (eal_log_init(program_invocation_short_name) < 0) {
-   rte_eal_init_alert("Cannot init logging.");
-   rte_errno = ENOMEM;
-   rte_atomic_store_explicit(&run_once, 0, 
rte_memory_order_relaxed);
-   return -1;
-   }
-
 #ifdef VFIO_PRESENT
if (rte_eal_vfio_setup() < 0) {
rte_eal_init_alert("Cannot init VFIO");
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 14e498a643..e59aba954e 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -250,9 +250,13 @@ rte_eal_init(int argc, char **argv)
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
char thread_name[RTE_THREAD_NAME_SIZE];
 
-   eal_log_init(NULL);
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
 
-   eal_log_level_parse(argc, argv);
+   eal_log_init(NULL);
 
if (eal_create_cpu_map() < 0) {
rte_eal_init_alert("Cannot discover CPU and NUMA.");
diff --git a/lib/log/log_freebsd.c b/lib/log/log_freebsd.c
index 953e371bee..33a0925c43 100644
--- a/lib/log/log_freebsd.c
+++ b/lib/log/log_freebsd.c
@@ -5,8 +5,7 @@
 #include 
 #include "log_internal.h"
 
-int
+void
 eal_log_init(__rte_unused const char *id)
 {
-   return 0;
 }
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index cb15cdff08..d5fabd7ef7 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -14,7 +14,7 @@
  * Initialize the default log stream.
  */
 __rte_internal
-int eal_log_init(const char *id);
+void eal_log_init(const char *id);
 
 /*
  * Determine where log data is written when no call to rte_openlog_stream.
diff --git a/lib/log/log_linux.c b/lib/log/log_linux.c
index 47aa074da2..6d7dc8f3ab 100644
--- a/lib/log/log_linux.c
+++ b/li

[PATCH v14 10/15] log: drop syslog support, and make code common

[Stephen Hemminger]

This patch makes the log setup code common across all platforms.

Drops syslog support for now, will come back in later patch.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  11 ++-
 lib/eal/common/eal_common_options.c |   3 -
 lib/log/log.c   |  29 +---
 lib/log/log_internal.h  |   6 --
 lib/log/log_linux.c | 102 
 lib/log/log_windows.c   |  22 --
 lib/log/meson.build |   5 +-
 lib/log/version.map |   1 -
 8 files changed, 26 insertions(+), 153 deletions(-)
 delete mode 100644 lib/log/log_linux.c
 delete mode 100644 lib/log/log_windows.c

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 6cb4b06757..36e3185a10 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -984,11 +984,10 @@ test_misc_flags(void)
const char *argv1[] = {prgname, prefix, mp_flag, "--no-pci"};
/* With -v */
const char *argv2[] = {prgname, prefix, mp_flag, "-v"};
+   /* With empty --syslog */
+   const char *argv3[] = {prgname, prefix, mp_flag, "--syslog"};
/* With valid --syslog */
-   const char *argv3[] = {prgname, prefix, mp_flag,
-   "--syslog", "syslog"};
-   /* With empty --syslog (should fail) */
-   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog"};
+   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog", "always"};
/* With invalid --syslog */
const char *argv5[] = {prgname, prefix, mp_flag, "--syslog", "error"};
/* With no-sh-conf, also use no-huge to ensure this test runs on BSD */
@@ -1083,8 +1082,8 @@ test_misc_flags(void)
printf("Error - process did not run ok with --syslog flag\n");
goto fail;
}
-   if (launch_proc(argv4) == 0) {
-   printf("Error - process run ok with empty --syslog flag\n");
+   if (launch_proc(argv4) != 0) {
+   printf("Error - process did not with --syslog always flag\n");
goto fail;
}
if (launch_proc(argv5) == 0) {
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 661b2db211..9ab512e8a1 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -2212,9 +2212,6 @@ eal_common_usage(void)
   "  (can be used multiple times)\n"
   "  --"OPT_VMWARE_TSC_MAP"Use VMware TSC map instead of 
native RDTSC\n"
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
-#ifndef RTE_EXEC_ENV_WINDOWS
-  "  --"OPT_SYSLOG"Set syslog facility\n"
-#endif
   "  --"OPT_LOG_LEVEL"= Set global log level\n"
   "  --"OPT_LOG_LEVEL"=:\n"
   "  Set specific log level\n"
diff --git a/lib/log/log.c b/lib/log/log.c
index 255f757d94..f597da2e39 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -70,12 +70,13 @@ struct log_cur_msg {
  /* per core log */
 static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);
 
-/* default logs */
-
 /* Change the stream that will be used by logging system */
 int
 rte_openlog_stream(FILE *f)
 {
+   if (rte_logs.file != NULL)
+   fclose(rte_logs.file);
+
rte_logs.file = f;
return 0;
 }
@@ -505,13 +506,20 @@ rte_log(uint32_t level, uint32_t logtype, const char 
*format, ...)
return ret;
 }
 
+/* Placeholder */
+int
+eal_log_syslog(const char *mode __rte_unused)
+{
+   return -1;
+}
+
 /*
- * Called by environment-specific initialization functions.
+ * Called by rte_eal_init
  */
 void
-eal_log_set_default(FILE *default_log)
+eal_log_init(const char *id __rte_unused)
 {
-   default_log_stream = default_log;
+   default_log_stream = stderr;
 
 #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
RTE_LOG(NOTICE, EAL,
@@ -525,8 +533,11 @@ eal_log_set_default(FILE *default_log)
 void
 rte_eal_log_cleanup(void)
 {
-   if (default_log_stream) {
-   fclose(default_log_stream);
-   default_log_stream = NULL;
-   }
+   FILE *log_stream = rte_log_get_stream();
+
+   /* don't close stderr on the application */
+   if (log_stream != stderr)
+   fclose(log_stream);
+
+   rte_logs.file = NULL;
 }
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index d5fabd7ef7..3c46328e7b 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -16,12 +16,6 @@
 __rte_internal
 void eal_log_init(const char *id);
 
-/*
- * Determine where log data is written when no call to rte_openlog_stream.
- */
-__rte_internal
-void eal_log_set_default(FILE *default_log);
-
 /*
  * Save a log option for later.
  */
diff --git a/lib/log/log_linux.c b/lib/log/log_linux.c
deleted file mode 100644
index 6d7dc8f3ab..00
--- a/lib/log/log_linux.c
+++ /dev/null

[PATCH v14 11/15] log: add hook for printing log messages

[Stephen Hemminger]

This is useful for when decorating log output for console
or journal. Provide basic version in this patch.

Signed-off-by: Stephen Hemminger 
---
 lib/log/log.c | 17 -
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/lib/log/log.c b/lib/log/log.c
index f597da2e39..acd4c320b6 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {
uint32_t loglevel;
 };
 
+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list 
ap);
+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);
+
 /** The rte_log structure. */
 static struct rte_logs {
uint32_t type;  /**< Bitfield with enabled logs. */
uint32_t level; /**< Log level. */
FILE *file; /**< Output file set by rte_openlog_stream, or NULL. */
+   log_print_t print_func;
size_t dynamic_types_len;
struct rte_log_dynamic_type *dynamic_types;
 } rte_logs = {
.type = UINT32_MAX,
.level = RTE_LOG_DEBUG,
+   .print_func = log_print,
 };
 
 struct rte_eal_opt_loglevel {
@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)
fclose(rte_logs.file);
 
rte_logs.file = f;
+   rte_logs.print_func = log_print;
return 0;
 }
 
@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char 
*format, va_list ap)
RTE_PER_LCORE(log_cur_msg).loglevel = level;
RTE_PER_LCORE(log_cur_msg).logtype = logtype;
 
-   ret = vfprintf(f, format, ap);
+   ret = (*rte_logs.print_func)(f, level, format, ap);
fflush(f);
return ret;
 }
@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)
return -1;
 }
 
+/* default log print function */
+__rte_format_printf(3, 0)
+static int
+log_print(FILE *f, uint32_t level __rte_unused,
+ const char *format, va_list ap)
+{
+   return vfprintf(f, format, ap);
+}
+
 /*
  * Called by rte_eal_init
  */
-- 
2.43.0

[PATCH v14 12/15] log: add timestamp option

[Stephen Hemminger]

When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing.

There are multiple timestamp formats similar to Linux dmesg.
The default is time relative since startup (when first
step of logging initialization is done by constructor).
Other alternative formats are delta, ctime, reltime and iso formats.

Example:
$ dpdk-testpmd --log-timestamp -- -i
[ 0.008610] EAL: Detected CPU lcores: 8
[ 0.008634] EAL: Detected NUMA nodes: 1
[ 0.008792] EAL: Detected static linkage of DPDK
[ 0.010620] EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
[ 0.012618] EAL: Selected IOVA mode 'VA'
[ 0.016675] testpmd: No probed ethernet devices
Interactive-mode selected

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  26 
 doc/guides/prog_guide/log_lib.rst   |  26 
 lib/eal/common/eal_common_options.c |  14 ++-
 lib/eal/common/eal_options.h|   2 +
 lib/eal/freebsd/eal.c   |   6 +-
 lib/eal/linux/eal.c |   4 +-
 lib/eal/windows/eal.c   |   4 +-
 lib/log/log.c   | 183 +++-
 lib/log/log_internal.h  |   9 ++
 lib/log/version.map |   1 +
 10 files changed, 268 insertions(+), 7 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 36e3185a10..e54f6e8b7f 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1054,6 +1054,19 @@ test_misc_flags(void)
const char * const argv22[] = {prgname, prefix, mp_flag,
   "--huge-worker-stack=512"};
 
+   /* Try running with --log-timestamp */
+   const char * const argv23[] = {prgname, prefix, mp_flag,
+  "--log-timestamp" };
+
+   /* Try running with --log-timestamp=iso */
+   const char * const argv24[] = {prgname, prefix, mp_flag,
+  "--log-timestamp=iso" };
+
+   /* Try running with invalid timestamp */
+   const char * const argv25[] = {prgname, prefix, mp_flag,
+  "--log-timestamp=invalid" };
+
+
/* run all tests also applicable to FreeBSD first */
 
if (launch_proc(argv0) == 0) {
@@ -1161,6 +1174,19 @@ test_misc_flags(void)
printf("Error - process did not run ok with 
--huge-worker-stack=size parameter\n");
goto fail;
}
+   if (launch_proc(argv23) != 0) {
+   printf("Error - process did not run ok with --log-timestamp 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv24) != 0) {
+   printf("Error - process did not run ok with --log-timestamp=iso 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv25) == 0) {
+   printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
+   goto fail;
+   }
+
 
rmdir(hugepath_dir3);
rmdir(hugepath_dir2);
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index ff9d1b54a2..504eefe1d2 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -59,6 +59,32 @@ For example::
 
 Within an application, the same result can be got using the 
``rte_log_set_level_pattern()`` or ``rte_log_set_level_regex()`` APIs.
 
+Log timestamp
+~
+
+An optional timestamp can be added before each message
+by adding the ``--log-timestamp`` option.
+For example::
+
+   /path/to/app --log-level=lib.*:debug --log-timestamp
+
+Multiple timestamp alternative timestamp formats are available:
+
+.. csv-table:: Log time stamp format
+   :header: "Format", "Description", "Example"
+   :widths: 6, 30, 32
+
+   "ctime", "Unix ctime", "``[Wed Mar 20 07:26:12 2024]``"
+   "delta", "Offset since last", "``[<3.162373>]``"
+   "reltime", "Seconds since last or time if minute changed", "``[  
+3.001791]`` or ``[Mar20 07:26:12]``"
+   "iso", "ISO-8601", "``[2024-03-20T07:26:12−07:00]``"
+
+To prefix all console messages with ISO format time the syntax is::
+
+   /path/to/app --log-timestamp=iso
+
+
+
 Using Logging APIs to Generate Log Messages
 ---
 
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 9ab512e8a1..5173835c2c 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -74,6 +74,7 @@ eal_long_options[] = {
{OPT_IOVA_MODE, 1, NULL, OPT_IOVA_MODE_NUM},
{OPT_LCORES,1, NULL, OPT_LCORES_NUM   },
{OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM},
+   {OPT_LOG_TIMESTAMP, 2, NULL, OPT_LOG_TIMESTAMP_NUM},
{OPT_TRACE, 1, NULL, OPT_TRACE_NUM

[PATCH v14 14/15] log: add support for systemd journal

[Stephen Hemminger]

If DPDK application is being run as a systemd service, then
it can use the journal protocol which allows putting more information
in the log such as priority and other information.

The use of journal protocol is automatically detected and
handled.  Rather than having a dependency on libsystemd,
just use the protocol directly as defined in:
https://systemd.io/JOURNAL_NATIVE_PROTOCOL/

Signed-off-by: Stephen Hemminger 
---
 lib/log/log.c | 162 +-
 1 file changed, 160 insertions(+), 2 deletions(-)

diff --git a/lib/log/log.c b/lib/log/log.c
index d8974c66db..8e2319b3f0 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -17,6 +17,10 @@
 #include 
 #else
 #include 
+#include 
+#include 
+#include 
+#include 
 #endif
 
 #include 
@@ -56,6 +60,7 @@ static struct rte_logs {
FILE *file; /**< Output file set by rte_openlog_stream, or NULL. */
 #ifndef RTE_EXEC_ENV_WINDOWS
enum eal_log_syslog syslog_opt;
+   int journal_fd;
 #endif
log_print_t print_func;
 
@@ -758,6 +763,146 @@ static cookie_io_functions_t syslog_log_func = {
.write = syslog_log_write,
.close = syslog_log_close,
 };
+
+/*
+ * send message using journal protocol to journald
+ */
+static int
+journal_send(uint32_t level, const char *buf, size_t len)
+{
+   struct iovec iov[3];
+   char msg[] = "MESSAGE=";
+   char prio[32];
+   int ret;
+
+   iov[0].iov_base = msg;
+   iov[0].iov_len = strlen(msg);
+
+   iov[1].iov_base = (char *)(uintptr_t)buf;
+   iov[1].iov_len = len;
+
+   /* priority value between 0 ("emerg") and 7 ("debug") */
+   iov[2].iov_base = prio;
+   iov[2].iov_len = snprintf(prio, sizeof(prio),
+ "PRIORITY=%i\n", level - 1);
+
+   ret = writev(rte_logs.journal_fd, iov, 3);
+   return ret;
+}
+
+__rte_format_printf(3, 0)
+static int
+journal_print(FILE *f __rte_unused, uint32_t level, const char *format, 
va_list ap)
+{
+   char *buf = NULL;
+   int ret, len;
+
+   len = vasprintf(&buf, format, ap);
+   if (len == 0)
+   return 0;
+
+   /* check that message ends with newline, if not add one */
+   if (buf[len - 1] != '\n') {
+   char *clone = malloc(len + 1);
+   if (clone == NULL) {
+   free(buf);
+   return 0;
+   }
+
+   memcpy(clone, buf, len);
+   clone[len++] = '\n';
+   free(buf);
+   buf = clone;
+   }
+
+   ret = journal_send(level, buf, len);
+   free(buf);
+   return ret;
+}
+
+/* wrapper for log stream to put messages into journal */
+static ssize_t
+journal_log_write(__rte_unused void *c, const char *buf, size_t size)
+{
+   return journal_send(rte_log_cur_msg_loglevel(), buf, size);
+}
+
+static cookie_io_functions_t journal_log_func = {
+   .write = journal_log_write,
+};
+
+/*
+ * Check if stderr is going to system journal.
+ * This is the documented way to handle systemd journal
+ *
+ * See: https://systemd.io/JOURNAL_NATIVE_PROTOCOL/
+ *
+ */
+static bool
+using_journal(void)
+{
+   char *jenv, *endp = NULL;
+   struct stat st;
+   unsigned long dev, ino;
+
+   jenv = getenv("JOURNAL_STREAM");
+   if (jenv == NULL)
+   return false;
+
+   if (fstat(STDERR_FILENO, &st) < 0)
+   return false;
+
+   /* systemd sets colon-separated list of device and inode number */
+   dev = strtoul(jenv, &endp, 10);
+   if (endp == NULL || *endp != ':')
+   return false;   /* missing colon */
+
+   ino = strtoul(endp + 1, NULL, 10);
+
+   return dev == st.st_dev && ino == st.st_ino;
+}
+
+/* Connect to systemd's journal service */
+static int
+open_journal(const char *id)
+{
+   char *syslog_id = NULL;
+   struct sockaddr_un sun = {
+   .sun_family = AF_UNIX,
+   .sun_path = "/run/systemd/journal/socket",
+   };
+   ssize_t len;
+   int s;
+
+   s = socket(AF_UNIX, SOCK_DGRAM, 0);
+   if (s < 0)
+   return -1;
+
+   if (connect(s, (struct sockaddr *)&sun, sizeof(sun)) < 0)
+   goto error;
+
+   /* Send syslog identifier as first message */
+   len = asprintf(&syslog_id, "SYSLOG_IDENTIFIER=%s\n", id);
+   if (len == 0)
+   goto error;
+
+   if (write(s, syslog_id, len) != len)
+   goto error;
+
+   free(syslog_id);
+
+   /* redirect other log messages to journal */
+   FILE *log_stream = fopencookie(NULL, "w", journal_log_func);
+   if (log_stream != NULL)
+   default_log_stream = log_stream;
+
+   return s;
+
+error:
+   free(syslog_id);
+   close(s);
+   return -1;
+}
 #endif
 
 
@@ -765,11 +910,24 @@ static cookie_io_functions_t syslog_log_func = {
 static void
 log_output_selection(const char *id)
 {
+#ifdef RTE_EXEC_ENV_WINDOWS
 

[PATCH v14 13/15] log: add optional support of syslog

[Stephen Hemminger]

Log to syslog only if option is specified. And if syslog is used
then normally only log to syslog, don't duplicate output.
Also enables syslog support on FreeBSD.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c |   5 +-
 doc/guides/linux_gsg/linux_eal_parameters.rst |  27 -
 doc/guides/prog_guide/log_lib.rst |  17 +++
 lib/eal/common/eal_common_options.c   |   5 +-
 lib/log/log.c | 101 --
 5 files changed, 117 insertions(+), 38 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index e54f6e8b7f..08f4866461 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -987,9 +987,10 @@ test_misc_flags(void)
/* With empty --syslog */
const char *argv3[] = {prgname, prefix, mp_flag, "--syslog"};
/* With valid --syslog */
-   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog", "always"};
+   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog=both"};
/* With invalid --syslog */
-   const char *argv5[] = {prgname, prefix, mp_flag, "--syslog", "error"};
+   const char *argv5[] = {prgname, prefix, mp_flag, "--syslog=invalid"};
+
/* With no-sh-conf, also use no-huge to ensure this test runs on BSD */
const char *argv6[] = {prgname, "-m", DEFAULT_MEM_SIZE,
no_shconf, nosh_prefix, no_huge};
diff --git a/doc/guides/linux_gsg/linux_eal_parameters.rst 
b/doc/guides/linux_gsg/linux_eal_parameters.rst
index ea8f381391..d86f94d8a8 100644
--- a/doc/guides/linux_gsg/linux_eal_parameters.rst
+++ b/doc/guides/linux_gsg/linux_eal_parameters.rst
@@ -108,30 +108,3 @@ Memory-related options
 *   ``--match-allocations``
 
 Free hugepages back to system exactly as they were originally allocated.
-
-Other options
-~
-
-*   ``--syslog ``
-
-Set syslog facility. Valid syslog facilities are::
-
-auth
-cron
-daemon
-ftp
-kern
-lpr
-mail
-news
-syslog
-user
-uucp
-local0
-local1
-local2
-local3
-local4
-local5
-local6
-local7
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index 504eefe1d2..abaedc7212 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -83,6 +83,23 @@ To prefix all console messages with ISO format time the 
syntax is::
 
/path/to/app --log-timestamp=iso
 
+Log output
+~~
+
+If desired, messages can be redirected to syslog (on Linux and FreeBSD) with 
the ``--syslog``
+option. There are three possible settings for this option:
+
+*always*
+Redirect all log output to syslog.
+
+*auto*
+Use console if it is a terminal, and use syslog if is not.
+
+*both*
+Print to both console and syslog.
+
+If ``--syslog`` option is not specified, then only console (stderr) will be 
used.
+
 
 
 Using Logging APIs to Generate Log Messages
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 5173835c2c..9ca7db04aa 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -91,7 +91,7 @@ eal_long_options[] = {
{OPT_PROC_TYPE, 1, NULL, OPT_PROC_TYPE_NUM},
{OPT_SOCKET_MEM,1, NULL, OPT_SOCKET_MEM_NUM   },
{OPT_SOCKET_LIMIT,  1, NULL, OPT_SOCKET_LIMIT_NUM },
-   {OPT_SYSLOG,1, NULL, OPT_SYSLOG_NUM   },
+   {OPT_SYSLOG,2, NULL, OPT_SYSLOG_NUM   },
{OPT_VDEV,  1, NULL, OPT_VDEV_NUM },
{OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM},
{OPT_VFIO_VF_TOKEN, 1, NULL, OPT_VFIO_VF_TOKEN_NUM},
@@ -2221,6 +2221,9 @@ eal_common_usage(void)
   "  (can be used multiple times)\n"
   "  --"OPT_VMWARE_TSC_MAP"Use VMware TSC map instead of 
native RDTSC\n"
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
+#ifndef RTE_EXEC_ENV_WINDOWS
+  "  --"OPT_SYSLOG"[=]   Enable use of syslog\n"
+#endif
   "  --"OPT_LOG_LEVEL"= Set global log level\n"
   "  --"OPT_LOG_LEVEL"=:\n"
   "  Set specific log level\n"
diff --git a/lib/log/log.c b/lib/log/log.c
index 2dca91306e..d8974c66db 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -13,15 +13,17 @@
 #include 
 #include 
 
+#ifdef RTE_EXEC_ENV_WINDOWS
+#include 
+#else
+#include 
+#endif
+
 #include 
 #include 
 
 #include "log_internal.h"
 
-#ifdef RTE_EXEC_ENV_WINDOWS
-#include 
-#endif
-
 struct rte_log_dynamic_type {
const char *name;
uint32_t loglevel;
@@ -36,14 +38,25 @@ enum eal_log_time_format {
EAL_LOG_TIMESTAMP_ISO,
 };
 
+enum eal_log_syslog {
+   EAL_LOG_SYSLOG_NON

[PATCH v14 15/15] log: colorize log output

[Stephen Hemminger]

Like dmesg, colorize the log output (unless redirected to file).
Timestamp is green, the subsystem is in yellow and the message
is red if urgent, boldface if an error, and normal for info and
debug messages.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  24 
 doc/guides/prog_guide/log_lib.rst   |  16 ++-
 lib/eal/common/eal_common_options.c |   2 +
 lib/eal/common/eal_options.h|   2 +
 lib/log/log.c   | 163 +++-
 lib/log/log_internal.h  |   5 +
 lib/log/version.map |   1 +
 7 files changed, 208 insertions(+), 5 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 08f4866461..c6c05e2e1d 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1067,6 +1067,18 @@ test_misc_flags(void)
const char * const argv25[] = {prgname, prefix, mp_flag,
   "--log-timestamp=invalid" };
 
+   /* Try running with --log-color */
+   const char * const argv26[] = {prgname, prefix, mp_flag,
+  "--log-color" };
+
+   /* Try running with --log-color=never */
+   const char * const argv27[] = {prgname, prefix, mp_flag,
+  "--log-color=never" };
+
+   /* Try running with --log-color=invalid */
+   const char * const argv28[] = {prgname, prefix, mp_flag,
+  "--log-color=invalid" };
+
 
/* run all tests also applicable to FreeBSD first */
 
@@ -1187,6 +1199,18 @@ test_misc_flags(void)
printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
goto fail;
}
+   if (launch_proc(argv26) != 0) {
+   printf("Error - process did not run ok with --log-color 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv27) != 0) {
+   printf("Error - process did not run ok with --log-color=none 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv28) == 0) {
+   printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
+   goto fail;
+   }
 
 
rmdir(hugepath_dir3);
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index abaedc7212..40727ebaae 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -59,6 +59,21 @@ For example::
 
 Within an application, the same result can be got using the 
``rte_log_set_level_pattern()`` or ``rte_log_set_level_regex()`` APIs.
 
+Color output
+
+
+The log library will highlight important messages.
+This is controlled by the ``--log-color`` option.
+he optional argument ``when`` can be ``auto``, ``never``, or ``always``.
+The default setting is ``auto`` which enables color when the output to
+``stderr`` is a terminal.
+If the ``when`` argument is omitted, it defaults to ``always``.
+
+For example to turn off all coloring::
+
+   /path/to/app --log-color=none
+
+
 Log timestamp
 ~
 
@@ -101,7 +116,6 @@ option. There are three possible settings for this option:
 If ``--syslog`` option is not specified, then only console (stderr) will be 
used.
 
 
-
 Using Logging APIs to Generate Log Messages
 ---
 
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 9ca7db04aa..709605e722 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -75,6 +75,7 @@ eal_long_options[] = {
{OPT_LCORES,1, NULL, OPT_LCORES_NUM   },
{OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM},
{OPT_LOG_TIMESTAMP, 2, NULL, OPT_LOG_TIMESTAMP_NUM},
+   {OPT_LOG_COLOR, 1, NULL, OPT_LOG_COLOR_NUM},
{OPT_TRACE, 1, NULL, OPT_TRACE_NUM},
{OPT_TRACE_DIR, 1, NULL, OPT_TRACE_DIR_NUM},
{OPT_TRACE_BUF_SIZE,1, NULL, OPT_TRACE_BUF_SIZE_NUM   },
@@ -2229,6 +2230,7 @@ eal_common_usage(void)
   "  Set specific log level\n"
   "  --"OPT_LOG_LEVEL"=helpShow log types and levels\n"
   "  --"OPT_LOG_TIMESTAMP"[=]  Timestamp log output\n"
+  "  --"OPT_LOG_COLOR"[=] Colorize log messages\n"
 #ifndef RTE_EXEC_ENV_WINDOWS
   "  --"OPT_TRACE"=\n"
   "  Enable trace based on regular expression 
trace name.\n"
diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h
index e24c9eca53..5a63c1dd3a 100644
--- a/lib/eal/common/eal_options.h
+++ b/lib/eal/common/eal_options.h
@@ -37,6 +37,8 @@ enum {
OPT_LOG_LEVEL_NUM,
 #define OPT_LOG_TIMESTAMP "log-timestamp"
OPT_LOG_TIMESTAMP_NUM,
+#define OPT_LOG_COLOR"log-color"
+   OPT_LOG_

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Garrett D'Amore]

This had occurred to me as well.  I think most hardware DMA engines can align 
on 32-bit boundaries.  I've yet to see a device that actually requires 64-bit 
DMA alignment.  (But I have only looked at a subset  of devices, and most of 
the  ones I have looked at are not ones that would be considered 'modern'.)
On Mar 26, 2024 at 8:06 AM -0700, Morten Brørup , 
wrote:
> Something just struck me…
> The buffer address field in the RX descriptor of some NICs may have alignment 
> requirements, i.e. the lowest bits in the buffer address field of the NIC’s 
> RX descriptor may be used for other purposes (and assumed zero for buffer 
> address purposes). 40 is divisible by 8, but offset 20 requires that the NIC 
> hardware supports 4-byte aligned addresses (so only the 2 lowest bits may be 
> used for other purposes).
>
> Here’s an example of what I mean:
> https://docs.amd.com/r/en-US/am011-versal-acap-trm/RX-Descriptor-Words
>
> If any of your supported NICs have that restriction, i.e. requires an 8 byte 
> aligned buffer address, your concept of having the UDP payload at the same 
> fixed offset for both IPv4 and IPv6 is not going to be possible. (And you 
> were lucky that the offset happens to be sufficiently aligned to work for 
> IPv4 to begin with.)
>
> It seems you need to read a bunch of datasheets before proceeding.
>
>
> Med venlig hilsen / Kind regards,
> -Morten Brørup
>
> From: Garrett D'Amore [mailto:garr...@damore.org]
> Sent: Tuesday, 26 March 2024 15.19
>
> This could work. Not that we would like to have the exceptional case of IPv6 
> use less headroom.   So we would say 40 is our compiled in default and then 
> we reduce it by 20 on IPv6 which doesn’t have to support all the same devices 
> that IPv4 does. This would give the lowest disruption to the existing IPv4 
> stack and allow PMDs to updated incrementally.
> On Mar 26, 2024 at 1:05 AM -0700, Morten Brørup , 
> wrote:
>
> Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
> traffic terminating) application, which doesn’t really care about the 
> preceding headers, can benefit from having its actual data at a specific 
> offset for alignment purposes. I don’t consider this very exotic. (Even the 
> Linux kernel uses this trick to achieve improved IP header alignment on RX.)
>
> I think the proper solution would be to add a new offload parameter to 
> rte_eth_rxconf to specify how many bytes the driver should subtract from 
> RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
> Depending on driver support, this would make it configurable per device and 
> per RX queue.
>
> If this parameter is set, the driver should adjust m->data_off accordingly on 
> RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still 
> point to the Ethernet header.
>
>
> Med venlig hilsen / Kind regards,
> -Morten Brørup
>
> From: Garrett D'Amore [mailto:garr...@damore.org]
> Sent: Monday, 25 March 2024 23.56
> So we need (for reasons that I don't want to get to into in too much detail) 
> that our UDP payload headers are at a specific offset in the packet.
>
> This was not a problem as long as we only used IPv4.  (We have configured 40 
> bytes of headroom, which is more than any of our PMDs need by a hefty margin.)
>
> Now that we're extending to support IPv6, we need to reduce that headroom by 
> 20 bytes, to preserve our UDP payload offset.
>
> This has big ramifications for how we fragment our own upper layer messages, 
> and it has been determined that updating the PMDs to allow us to change the 
> headroom for this use case (on a per port basis, as we will have some ports 
> on IPv4 and others on IPv6) is the least effort, but a large margin.  (Well, 
> copying the frames via memcpy would be less development effort, but would be 
> a performance catastrophe.)
>
> For transmit side we don't need this, as we can simply adjust the packet as 
> needed.  But for the receive side, we are kind of stuck, as the PMDs rely on 
> the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.
>
> As far as header splitting, that would indeed be a much much nicer solution.
>
> I haven't looked in the latest code to see if header splitting is even an 
> option -- the version of the DPDK I'm working with is a little older (20.11) 
> -- we have to update but we have other local changes and so updating is one 
> of the things that we still have to do.
>
> At any rate, the version I did look at doesn't seem to support header splits 
> on any device other than FM10K.  That's not terrifically interesting for us.  
> We use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really -- ENA, 
> virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on client 
> systems in the field.
>
> We also, unfortunately, have an older DPDK 18 with Mellanox contributions for 
> IPoverIB though I'm not sure we will try to support IPv6 there.  (We are 
> working towards replacing that part of stack with UCX.)
>
> 

RE: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Garrett D'Amore]

This ETH_RX_OFFLOAD_BUFFER_SPLIT sounds promising indeed.
On Mar 26, 2024 at 9:14 AM -0700, Konstantin Ananyev 
, wrote:
> Just wonder what would happen if you’ll receive an ipv6 packet with options 
> or some fancy encapsulation IP-IP or so?
> BTW, there is an  RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offload:
> https://doc.dpdk.org/api/structrte__eth__rxseg__split.html
> Which might be close to what you are looking for, but right now it is 
> supported by mlx5 PMD only.
>
> From: Garrett D'Amore 
> Sent: Tuesday, March 26, 2024 2:19 PM
> To: Bruce Richardson ; Stephen Hemminger 
> ; Morten Brørup 
> Cc: dev@dpdk.org; Parthakumar Roy 
> Subject: RE: meson option to customize RTE_PKTMBUF_HEADROOM patch
>
> This could work. Not that we would like to have the exceptional case of IPv6 
> use less headroom.   So we would say 40 is our compiled in default and then 
> we reduce it by 20 on IPv6 which doesn’t have to support all the same devices 
> that IPv4 does. This would give the lowest disruption to the existing IPv4 
> stack and allow PMDs to updated incrementally.
> On Mar 26, 2024 at 1:05 AM -0700, Morten Brørup , 
> wrote:
>
> > quote_type
> > Interesting requirement. I can easily imagine how a (non-forwarding, i.e. 
> > traffic terminating) application, which doesn’t really care about the 
> > preceding headers, can benefit from having its actual data at a specific 
> > offset for alignment purposes. I don’t consider this very exotic. (Even the 
> > Linux kernel uses this trick to achieve improved IP header alignment on RX.)
> >
> > I think the proper solution would be to add a new offload parameter to 
> > rte_eth_rxconf to specify how many bytes the driver should subtract from 
> > RTE_PKTMBUF_HEADROOM when writing the RX descriptor to the NIC hardware. 
> > Depending on driver support, this would make it configurable per device and 
> > per RX queue.
> >
> > If this parameter is set, the driver should adjust m->data_off accordingly 
> > on RX, so rte_pktmbuf_mtod[_offset]() and rte_pktmbuf_iova[_offset]() still 
> > point to the Ethernet header.
> >
> >
> > Med venlig hilsen / Kind regards,
> > -Morten Brørup
> >
> > From: Garrett D'Amore [mailto:garr...@damore.org]
> > Sent: Monday, 25 March 2024 23.56
> > So we need (for reasons that I don't want to get to into in too much 
> > detail) that our UDP payload headers are at a specific offset in the packet.
> >
> > This was not a problem as long as we only used IPv4.  (We have configured 
> > 40 bytes of headroom, which is more than any of our PMDs need by a hefty 
> > margin.)
> >
> > Now that we're extending to support IPv6, we need to reduce that headroom 
> > by 20 bytes, to preserve our UDP payload offset.
> >
> > This has big ramifications for how we fragment our own upper layer 
> > messages, and it has been determined that updating the PMDs to allow us to 
> > change the headroom for this use case (on a per port basis, as we will have 
> > some ports on IPv4 and others on IPv6) is the least effort, but a large 
> > margin.  (Well, copying the frames via memcpy would be less development 
> > effort, but would be a performance catastrophe.)
> >
> > For transmit side we don't need this, as we can simply adjust the packet as 
> > needed.  But for the receive side, we are kind of stuck, as the PMDs rely 
> > on the hard coded RTE_PKTMBUF_HEADROOM to program receive locations.
> >
> > As far as header splitting, that would indeed be a much much nicer solution.
> >
> > I haven't looked in the latest code to see if header splitting is even an 
> > option -- the version of the DPDK I'm working with is a little older 
> > (20.11) -- we have to update but we have other local changes and so 
> > updating is one of the things that we still have to do.
> >
> > At any rate, the version I did look at doesn't seem to support header 
> > splits on any device other than FM10K.  That's not terrifically interesting 
> > for us.  We use Mellanox, E810 (ICE), bnxt, cloud NICs (all of them really 
> > -- ENA, virtio-net, etc.)   We also have a fair amount of ixgbe and i40e on 
> > client systems in the field.
> >
> > We also, unfortunately, have an older DPDK 18 with Mellanox contributions 
> > for IPoverIB though I'm not sure we will try to support IPv6 there.  
> > (We are working towards replacing that part of stack with UCX.)
> >
> > Unless header splitting will work on all of this (excepting the IPoIB 
> > piece), then it's not something we can really use.
> > On Mar 25, 2024 at 10:20 AM -0700, Stephen Hemminger 
> > , wrote:
> > On Mon, 25 Mar 2024 10:01:52 +
> > Bruce Richardson  wrote:
> >
> > On Sat, Mar 23, 2024 at 01:51:25PM -0700, Garrett D'Amore wrote:
> > > So we right now (at WEKA) have a somewhat older version of DPDK that we
> > > have customized heavily, and I am going to to need to to make the
> > > headroom *dynamic* (passed in at run time, and per port.)
> > > We have this requirement because we need payload to be at a specific
> > > offset, but ha

Re: [PATCH v2 1/6] ethdev: support setting lanes

[Ajit Khaparde]

On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde
 wrote:
>
> On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C)  wrote:
> >
> >
> > 在 2024/3/26 18:30, Thomas Monjalon 写道:
> > > 26/03/2024 02:42, lihuisong (C):
> > >> 在 2024/3/25 17:30, Thomas Monjalon 写道:
> > >>> 25/03/2024 07:24, huangdengdui:
> >  On 2024/3/22 21:58, Thomas Monjalon wrote:
> > > 22/03/2024 08:09, Dengdui Huang:
> > >> -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8)  /**< 10 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9)  /**< 20 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_40G RTE_BIT32(11) /**< 40 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_50G RTE_BIT32(12) /**< 50 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_56G RTE_BIT32(13) /**< 56 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_100GRTE_BIT32(14) /**< 100 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_200GRTE_BIT32(15) /**< 200 Gbps */
> > >> -#define RTE_ETH_LINK_SPEED_400GRTE_BIT32(16) /**< 400 Gbps */
> > >> +#define RTE_ETH_LINK_SPEED_10GRTE_BIT32(8)  /**< 10 
> > >> Gbps */
> > >> +#define RTE_ETH_LINK_SPEED_20GRTE_BIT32(9)  /**< 20 
> > >> Gbps 2lanes */
> > >> +#define RTE_ETH_LINK_SPEED_25GRTE_BIT32(10) /**< 25 
> > >> Gbps */
> > >> +#define RTE_ETH_LINK_SPEED_40GRTE_BIT32(11) /**< 40 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_50GRTE_BIT32(12) /**< 50 
> > >> Gbps */
> > >> +#define RTE_ETH_LINK_SPEED_56GRTE_BIT32(13) /**< 56 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_100G   RTE_BIT32(14) /**< 100 
> > >> Gbps */
> > >> +#define RTE_ETH_LINK_SPEED_200G   RTE_BIT32(15) /**< 200 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_400G   RTE_BIT32(16) /**< 400 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_10G_4LANES RTE_BIT32(17)  /**< 10 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_50G_2LANES RTE_BIT32(18) /**< 50 
> > >> Gbps 2 lanes */
> > >> +#define RTE_ETH_LINK_SPEED_100G_2LANESRTE_BIT32(19) /**< 100 
> > >> Gbps 2 lanes */
> > >> +#define RTE_ETH_LINK_SPEED_100G_4LANESRTE_BIT32(20) /**< 100 
> > >> Gbps 4lanes */
> > >> +#define RTE_ETH_LINK_SPEED_200G_2LANESRTE_BIT32(21) /**< 200 
> > >> Gbps 2lanes */
> > >> +#define RTE_ETH_LINK_SPEED_400G_8LANESRTE_BIT32(22) /**< 400 
> > >> Gbps 8lanes */
> > > I don't think it is a good idea to make this more complex.
> > > It brings nothing as far as I can see, compared to having speed and 
> > > lanes separated.
> > > Can we have lanes information a separate value? no need for bitmask.
> > >
> >  Hi,Thomas, Ajit, roretzla, damodharam
> > 
> >  I also considered the option at the beginning of the design.
> >  But this option is not used due to the following reasons:
> >  1. For the user, ethtool couples speed and lanes.
> >  The result of querying the NIC capability is as follows:
> >  Supported link modes:
> >    10baseSR4/Full
> >    10baseSR2/Full
> >  The NIC capability is configured as follows:
> >  ethtool -s eth1 speed 10 lanes 4 autoneg off
> >  ethtool -s eth1 speed 10 lanes 2 autoneg off
> > 
> >  Therefore, users are more accustomed to the coupling of speed and 
> >  lanes.
> > 
> >  2. For the PHY, When the physical layer capability is configured 
> >  through the MDIO,
> >  the speed and lanes are also coupled.
> >  For example:
> >  Table 45–7—PMA/PMD control 2 register bit definitions[1]
> >  PMA/PMD type selection
> >    1 0 0 1 0 1 0 = 100GBASE-SR2 PMA/PMD
> >    0 1 0 1 1 1 1 = 100GBASE-SR4 PMA/PMD
> > 
> >  Therefore, coupling speeds and lanes is easier to understand.
> >  And it is easier for the driver to report the support lanes.
> > 
> >  In addition, the code implementation is compatible with the old 
> >  version.
> >  When the driver does not support the lanes setting, the code does not 
> >  need to be modified.
> > 
> >  So I think the speed and lanes coupling is better.
> > >>> I don't think so.
> > >>> You are mixing hardware implementation, user tool, and API.
> > >>> Having a separate and simple API is cleaner and not more difficult to 
> > >>> handle
> > >>> in some get/set style functions.
> > >> Having a separate and simple API is cleaner. It's good.
> > >> But supported lane capabilities have a lot to do with the specified
> > >> speed. This is determined by releated specification.
> > >> If we add a separate API for speed lanes, it probably is hard to check
> > >> the validity of the configuration for speed and lanes.
> > >> And the

Re: [PATCH v2 1/6] ethdev: support setting lanes

[Damodharam Ammepalli]

On Tue, Mar 26, 2024 at 11:12 AM Ajit Khaparde
 wrote:
>
> On Tue, Mar 26, 2024 at 6:47 AM Ajit Khaparde
>  wrote:
> >
> > On Tue, Mar 26, 2024 at 4:15 AM lihuisong (C)  wrote:
> > >
> > >
> > > 在 2024/3/26 18:30, Thomas Monjalon 写道:
> > > > 26/03/2024 02:42, lihuisong (C):
> > > >> 在 2024/3/25 17:30, Thomas Monjalon 写道:
> > > >>> 25/03/2024 07:24, huangdengdui:
> > >  On 2024/3/22 21:58, Thomas Monjalon wrote:
> > > > 22/03/2024 08:09, Dengdui Huang:
> > > >> -#define RTE_ETH_LINK_SPEED_10G RTE_BIT32(8)  /**< 10 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_20G RTE_BIT32(9)  /**< 20 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_25G RTE_BIT32(10) /**< 25 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_40G RTE_BIT32(11) /**< 40 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_50G RTE_BIT32(12) /**< 50 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_56G RTE_BIT32(13) /**< 56 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_100GRTE_BIT32(14) /**< 100 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_200GRTE_BIT32(15) /**< 200 Gbps */
> > > >> -#define RTE_ETH_LINK_SPEED_400GRTE_BIT32(16) /**< 400 Gbps */
> > > >> +#define RTE_ETH_LINK_SPEED_10GRTE_BIT32(8)  /**< 10 
> > > >> Gbps */
> > > >> +#define RTE_ETH_LINK_SPEED_20GRTE_BIT32(9)  /**< 20 
> > > >> Gbps 2lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_25GRTE_BIT32(10) /**< 25 
> > > >> Gbps */
> > > >> +#define RTE_ETH_LINK_SPEED_40GRTE_BIT32(11) /**< 40 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_50GRTE_BIT32(12) /**< 50 
> > > >> Gbps */
> > > >> +#define RTE_ETH_LINK_SPEED_56GRTE_BIT32(13) /**< 56 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_100G   RTE_BIT32(14) /**< 100 
> > > >> Gbps */
> > > >> +#define RTE_ETH_LINK_SPEED_200G   RTE_BIT32(15) /**< 200 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_400G   RTE_BIT32(16) /**< 400 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_10G_4LANES RTE_BIT32(17)  /**< 10 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_50G_2LANES RTE_BIT32(18) /**< 50 
> > > >> Gbps 2 lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_100G_2LANESRTE_BIT32(19) /**< 100 
> > > >> Gbps 2 lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_100G_4LANESRTE_BIT32(20) /**< 100 
> > > >> Gbps 4lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_200G_2LANESRTE_BIT32(21) /**< 200 
> > > >> Gbps 2lanes */
> > > >> +#define RTE_ETH_LINK_SPEED_400G_8LANESRTE_BIT32(22) /**< 400 
> > > >> Gbps 8lanes */
> > > > I don't think it is a good idea to make this more complex.
> > > > It brings nothing as far as I can see, compared to having speed and 
> > > > lanes separated.
> > > > Can we have lanes information a separate value? no need for bitmask.
> > > >
> > >  Hi,Thomas, Ajit, roretzla, damodharam
> > > 
> > >  I also considered the option at the beginning of the design.
> > >  But this option is not used due to the following reasons:
> > >  1. For the user, ethtool couples speed and lanes.
> > >  The result of querying the NIC capability is as follows:
> > >  Supported link modes:
> > >    10baseSR4/Full
> > >    10baseSR2/Full
> > >  The NIC capability is configured as follows:
> > >  ethtool -s eth1 speed 10 lanes 4 autoneg off
> > >  ethtool -s eth1 speed 10 lanes 2 autoneg off
> > > 
> > >  Therefore, users are more accustomed to the coupling of speed and 
> > >  lanes.
> > > 
> > >  2. For the PHY, When the physical layer capability is configured 
> > >  through the MDIO,
> > >  the speed and lanes are also coupled.
> > >  For example:
> > >  Table 45–7—PMA/PMD control 2 register bit definitions[1]
> > >  PMA/PMD type selection
> > >    1 0 0 1 0 1 0 = 100GBASE-SR2 PMA/PMD
> > >    0 1 0 1 1 1 1 = 100GBASE-SR4 PMA/PMD
> > > 
> > >  Therefore, coupling speeds and lanes is easier to understand.
> > >  And it is easier for the driver to report the support lanes.
> > > 
> > >  In addition, the code implementation is compatible with the old 
> > >  version.
> > >  When the driver does not support the lanes setting, the code does 
> > >  not need to be modified.
> > > 
> > >  So I think the speed and lanes coupling is better.
> > > >>> I don't think so.
> > > >>> You are mixing hardware implementation, user tool, and API.
> > > >>> Having a separate and simple API is cleaner and not more difficult to 
> > > >>> handle
> > > >>> in some get/set style functions.
> > > >> Having a separate and simple API is cleaner. It's good.
> > > >> But supported lane capabilities

[PATCH 0/6] dts: add testpmd params and statefulness

[Luca Vizzarro]

Hello!

Sending in some major work relating to Bugzilla Bug 1371. In a few words
I have created a common data structure to handle command line parameters
for shells. I applied this to the current EalParameters class, and made
it so it's reflected across the interactive shell classes for
consistency. Finally, I have implemented all the testpmd parameters
that are publicly documented in a class, and updated the buffer scatter
test suite to use it. The two statefulness patches are very basic and
hopefully the beginning of tracking some state in each testpmd session.

Here are some things I'd like to discuss about these patches:
- the testpmd params defaults. These are a mix between the declared
  defaults on testpmd doc page and some of which we are aware of. I have
  not used all the defaults declared on the testpmd doc page, because I
  have found some inconsistencies when going through testpmd's source
  code.
- the overall structure of the parameter classes. Each of the parameter
  classes are placed in different files, not following a proper
  structure. I'd be keen to restructure everything, and I am open to
  suggestions.
- most of the docstrings relating to the testpmd parameters class are
  effectively taking from testpmd's doc pages. Would this satisfy our
  needs?
- I've tested the docstrings against Juraj's pending API doc generation
  patches and noticed that union types are not correctly represented
  when these are more than two. Not sure if this is a bug or not, but if
  not, any suggestions on how we could solve this?

Looking forward to hearing your replies!

Best regards,
Luca

Luca Vizzarro (6):
  dts: add parameters data structure
  dts: use Params for interactive shells
  dts: add testpmd shell params
  dts: use testpmd params for scatter test suite
  dts: add statefulness to InteractiveShell
  dts: add statefulness to TestPmdShell

 dts/framework/params.py   | 232 ++
 .../remote_session/interactive_shell.py   |  26 +-
 dts/framework/remote_session/testpmd_shell.py | 680 +-
 dts/framework/testbed_model/__init__.py   |   2 +-
 dts/framework/testbed_model/node.py   |   4 +-
 dts/framework/testbed_model/os_session.py |   4 +-
 dts/framework/testbed_model/sut_node.py   | 106 ++-
 dts/tests/TestSuite_pmd_buffer_scatter.py |  20 +-
 8 files changed, 972 insertions(+), 102 deletions(-)
 create mode 100644 dts/framework/params.py

-- 
2.34.1

[PATCH 1/6] dts: add parameters data structure

[Luca Vizzarro]

This commit introduces a new "params" module, which adds a new way
to manage command line parameters. The provided Params dataclass
is able to read the fields of its child class and produce a string
representation to supply to the command line. Any data structure
that is intended to represent command line parameters can inherit
it. The representation can then manipulated by using the dataclass
field metadata in conjunction with the provided functions:

* value_only, used to supply a value without forming an option/flag
* options_end, used to prefix with an options end delimiter (`--`)
* short, used to define a short parameter name, e.g. `-p`
* long, used to define a long parameter name, e.g. `--parameter`
* multiple, used to turn a list into repeating parameters
* field_mixins, used to manipulate the string representation of the
  value

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 dts/framework/params.py | 232 
 1 file changed, 232 insertions(+)
 create mode 100644 dts/framework/params.py

diff --git a/dts/framework/params.py b/dts/framework/params.py
new file mode 100644
index 00..6b48c8353e
--- /dev/null
+++ b/dts/framework/params.py
@@ -0,0 +1,232 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Arm Limited
+
+"""Parameter manipulation module.
+
+This module provides :class:`~Params` which can be used to model any data 
structure
+that is meant to represent any command parameters.
+"""
+
+from dataclasses import dataclass, field, fields
+from typing import Any, Callable, Literal, Reversible, TypeVar, Iterable
+from enum import Flag
+
+
+T = TypeVar("T")
+#: Type for a Mixin.
+Mixin = Callable[[Any], str]
+#: Type for an option parameter.
+Option = Literal[True, None]
+#: Type for a yes/no option parameter.
+BooleanOption = Literal[True, False, None]
+
+META_VALUE_ONLY = "value_only"
+META_OPTIONS_END = "options_end"
+META_SHORT_NAME = "short_name"
+META_LONG_NAME = "long_name"
+META_MULTIPLE = "multiple"
+META_MIXINS = "mixins"
+
+
+def value_only(metadata: dict[str, Any] = {}) -> dict[str, Any]:
+"""Injects the value of the attribute as-is without flag. Metadata 
modifier for :func:`dataclasses.field`."""
+return {**metadata, META_VALUE_ONLY: True}
+
+
+def short(name: str, metadata: dict[str, Any] = {}) -> dict[str, Any]:
+"""Overrides any parameter name with the given short option. Metadata 
modifier for :func:`dataclasses.field`.
+
+.. code:: python
+
+logical_cores: str | None = field(default="1-4", metadata=short("l"))
+
+will render as ``-l=1-4`` instead of ``--logical-cores=1-4``.
+"""
+return {**metadata, META_SHORT_NAME: name}
+
+
+def long(name: str, metadata: dict[str, Any] = {}) -> dict[str, Any]:
+"""Overrides the inferred parameter name to the specified one. Metadata 
modifier for :func:`dataclasses.field`.
+
+.. code:: python
+
+x_name: str | None = field(default="y", metadata=long("x"))
+
+will render as ``--x=y``, but the field is accessed and modified through 
``x_name``.
+"""
+return {**metadata, META_LONG_NAME: name}
+
+
+def options_end(metadata: dict[str, Any] = {}) -> dict[str, Any]:
+"""Precedes the value with an options end delimiter (``--``). Metadata 
modifier for :func:`dataclasses.field`."""
+return {**metadata, META_OPTIONS_END: True}
+
+
+def multiple(metadata: dict[str, Any] = {}) -> dict[str, Any]:
+"""Specifies that this parameter is set multiple times. Must be a list. 
Metadata modifier for :func:`dataclasses.field`.
+
+.. code:: python
+
+ports: list[int] | None = field(default_factory=lambda: [0, 1, 2], 
metadata=multiple(param_name("port")))
+
+will render as ``--port=0 --port=1 --port=2``. Note that modifiers can be 
chained like in this example.
+"""
+return {**metadata, META_MULTIPLE: True}
+
+
+def field_mixins(*mixins: Mixin, metadata: dict[str, Any] = {}) -> dict[str, 
Any]:
+"""Takes in a variable number of mixins to manipulate the value's 
rendering. Metadata modifier for :func:`dataclasses.field`.
+
+The ``metadata`` keyword argument can be used to chain metadata modifiers 
together.
+
+Mixins can be chained together, executed from right to left in the 
arguments list order.
+
+Example:
+
+.. code:: python
+
+hex_bitmask: int | None = field(default=0b1101, 
metadata=field_mixins(hex, metadata=param_name("mask")))
+
+will render as ``--mask=0xd``. The :func:`hex` built-in can be used as a 
mixin turning a valid integer into a hexadecimal representation.
+"""
+return {**metadata, META_MIXINS: mixins}
+
+
+def _reduce_mixins(mixins: Reversible[Mixin], value: Any) -> str:
+for mixin in reversed(mixins):
+value = mixin(value)
+return value
+
+
+def str_mixins(*mixins: Mixin):
+"""Decorator which modifies the ``__str__`` method, enabling support for 
mixins.
+
+Mixins can be chaine

[PATCH 2/6] dts: use Params for interactive shells

[Luca Vizzarro]

Make it so that interactive shells accept an implementation of `Params`
for app arguments. Convert EalParameters to use `Params` instead.

String command line parameters can still be supplied by using the
`StrParams` implementation.

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 .../remote_session/interactive_shell.py   |   8 +-
 dts/framework/remote_session/testpmd_shell.py |  12 +-
 dts/framework/testbed_model/__init__.py   |   2 +-
 dts/framework/testbed_model/node.py   |   4 +-
 dts/framework/testbed_model/os_session.py |   4 +-
 dts/framework/testbed_model/sut_node.py   | 106 --
 dts/tests/TestSuite_pmd_buffer_scatter.py |   3 +-
 7 files changed, 73 insertions(+), 66 deletions(-)

diff --git a/dts/framework/remote_session/interactive_shell.py 
b/dts/framework/remote_session/interactive_shell.py
index 5cfe202e15..a2c7b30d9f 100644
--- a/dts/framework/remote_session/interactive_shell.py
+++ b/dts/framework/remote_session/interactive_shell.py
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2023 University of New Hampshire
+# Copyright(c) 2024 Arm Limited
 
 """Common functionality for interactive shell handling.
 
@@ -21,6 +22,7 @@
 from paramiko import Channel, SSHClient, channel  # type: ignore[import]
 
 from framework.logger import DTSLogger
+from framework.params import Params
 from framework.settings import SETTINGS
 
 
@@ -40,7 +42,7 @@ class InteractiveShell(ABC):
 _ssh_channel: Channel
 _logger: DTSLogger
 _timeout: float
-_app_args: str
+_app_args: Params | None
 
 #: Prompt to expect at the end of output when sending a command.
 #: This is often overridden by subclasses.
@@ -63,7 +65,7 @@ def __init__(
 interactive_session: SSHClient,
 logger: DTSLogger,
 get_privileged_command: Callable[[str], str] | None,
-app_args: str = "",
+app_args: Params | None = None,
 timeout: float = SETTINGS.timeout,
 ) -> None:
 """Create an SSH channel during initialization.
@@ -100,7 +102,7 @@ def _start_application(self, get_privileged_command: 
Callable[[str], str] | None
 get_privileged_command: A function (but could be any callable) 
that produces
 the version of the command with elevated privileges.
 """
-start_command = f"{self.path} {self._app_args}"
+start_command = f"{self.path} {self._app_args or ''}"
 if get_privileged_command is not None:
 start_command = get_privileged_command(start_command)
 self.send_command(start_command)
diff --git a/dts/framework/remote_session/testpmd_shell.py 
b/dts/framework/remote_session/testpmd_shell.py
index cb2ab6bd00..db3abb7600 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -21,6 +21,7 @@
 from typing import Callable, ClassVar
 
 from framework.exception import InteractiveCommandExecutionError
+from framework.params import StrParams
 from framework.settings import SETTINGS
 from framework.utils import StrEnum
 
@@ -118,8 +119,15 @@ def _start_application(self, get_privileged_command: 
Callable[[str], str] | None
 Also find the number of pci addresses which were allowed on the 
command line when the app
 was started.
 """
-self._app_args += " -i --mask-event intr_lsc"
-self.number_of_ports = self._app_args.count("-a ")
+from framework.testbed_model.sut_node import EalParameters
+
+assert isinstance(self._app_args, EalParameters)
+
+if isinstance(self._app_args.app_params, StrParams):
+self._app_args.app_params.value += " -i --mask-event intr_lsc"
+
+self.number_of_ports = len(self._app_args.ports) if 
self._app_args.ports is not None else 0
+
 super()._start_application(get_privileged_command)
 
 def start(self, verify: bool = True) -> None:
diff --git a/dts/framework/testbed_model/__init__.py 
b/dts/framework/testbed_model/__init__.py
index 6086512ca2..ef9520df4c 100644
--- a/dts/framework/testbed_model/__init__.py
+++ b/dts/framework/testbed_model/__init__.py
@@ -23,6 +23,6 @@
 from .cpu import LogicalCoreCount, LogicalCoreCountFilter, LogicalCoreList
 from .node import Node
 from .port import Port, PortLink
-from .sut_node import SutNode
+from .sut_node import SutNode, EalParameters
 from .tg_node import TGNode
 from .virtual_device import VirtualDevice
diff --git a/dts/framework/testbed_model/node.py 
b/dts/framework/testbed_model/node.py
index 74061f6262..ec9512d618 100644
--- a/dts/framework/testbed_model/node.py
+++ b/dts/framework/testbed_model/node.py
@@ -2,6 +2,7 @@
 # Copyright(c) 2010-2014 Intel Corporation
 # Copyright(c) 2022-2023 PANTHEON.tech s.r.o.
 # Copyright(c) 2022-2023 University of New Hampshire
+# Copyright(c) 2024 Arm Limited
 
 """Common functionality for node management.
 
@@ -24,6 +25,7 @@
 )

[PATCH 3/6] dts: add testpmd shell params

[Luca Vizzarro]

Implement all the testpmd shell parameters into a data structure.

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 dts/framework/remote_session/testpmd_shell.py | 633 +-
 1 file changed, 615 insertions(+), 18 deletions(-)

diff --git a/dts/framework/remote_session/testpmd_shell.py 
b/dts/framework/remote_session/testpmd_shell.py
index db3abb7600..a823dc53be 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2023 University of New Hampshire
 # Copyright(c) 2023 PANTHEON.tech s.r.o.
+# Copyright(c) 2024 Arm Limited
 
 """Testpmd interactive shell.
 
@@ -15,10 +16,25 @@
 testpmd_shell.close()
 """
 
+from dataclasses import dataclass, field
+from enum import auto, Enum, Flag, unique
 import time
-from enum import auto
 from pathlib import PurePath
-from typing import Callable, ClassVar
+from typing import Callable, ClassVar, Literal, NamedTuple
+from framework.params import (
+BooleanOption,
+Params,
+bracketed,
+comma_separated,
+Option,
+field_mixins,
+hex_from_flag_value,
+multiple,
+long,
+short,
+str_from_flag_value,
+str_mixins,
+)
 
 from framework.exception import InteractiveCommandExecutionError
 from framework.params import StrParams
@@ -28,26 +44,79 @@
 from .interactive_shell import InteractiveShell
 
 
-class TestPmdDevice(object):
-"""The data of a device that testpmd can recognize.
+@str_mixins(bracketed, comma_separated)
+class TestPmdPortNUMAConfig(NamedTuple):
+"""DPDK port to NUMA socket association tuple."""
 
-Attributes:
-pci_address: The PCI address of the device.
+port: int
+socket: int
+
+
+@str_mixins(str_from_flag_value)
+@unique
+class TestPmdFlowDirection(Flag):
+"""Flag indicating the direction of the flow.
+
+A bi-directional flow can be specified with the pipe:
+
+>>> TestPmdFlowDirection.RX | TestPmdFlowDirection.TX
+
 """
 
-pci_address: str
+#:
+RX = 1 << 0
+#:
+TX = 1 << 1
 
-def __init__(self, pci_address_line: str):
-"""Initialize the device from the testpmd output line string.
 
-Args:
-pci_address_line: A line of testpmd output that contains a device.
-"""
-self.pci_address = pci_address_line.strip().split(": ")[1].strip()
+@str_mixins(bracketed, comma_separated)
+class TestPmdRingNUMAConfig(NamedTuple):
+"""Tuple associating DPDK port, direction of the flow and NUMA socket."""
+
+port: int
+direction: TestPmdFlowDirection
+socket: int
+
+
+@str_mixins(comma_separated)
+class TestPmdEthPeer(NamedTuple):
+"""Tuple associating a MAC address to the specified DPDK port."""
+
+port_no: int
+mac_address: str
+
+
+@str_mixins(comma_separated)
+class TestPmdTxIPAddrPair(NamedTuple):
+"""Tuple specifying the source and destination IPs for the packets."""
+
+source_ip: str
+dest_ip: str
 
-def __str__(self) -> str:
-"""The PCI address captures what the device is."""
-return self.pci_address
+
+@str_mixins(comma_separated)
+class TestPmdTxUDPPortPair(NamedTuple):
+"""Tuple specifying the UDP source and destination ports for the packets.
+
+If leaving ``dest_port`` unspecified, ``source_port`` will be used for the 
destination port as well.
+"""
+
+source_port: int
+dest_port: int | None = None
+
+
+class TestPmdPortTopology(StrEnum):
+paired = auto()
+"""In paired mode, the forwarding is between pairs of ports,
+for example: (0,1), (2,3), (4,5)."""
+chained = auto()
+"""In chained mode, the forwarding is to the next available port in the 
port mask,
+for example: (0,1), (1,2), (2,0).
+
+The ordering of the ports can be changed using the portlist testpmd 
runtime function.
+"""
+loop = auto()
+"""In loop mode, ingress traffic is simply transmitted back on the same 
interface."""
 
 
 class TestPmdForwardingModes(StrEnum):
@@ -81,6 +150,534 @@ class TestPmdForwardingModes(StrEnum):
 recycle_mbufs = auto()
 
 
+@str_mixins(comma_separated)
+class XYPair(NamedTuple):
+#:
+X: int
+#:
+Y: int | None = None
+
+
+@str_mixins(hex_from_flag_value)
+@unique
+class TestPmdRXMultiQueueMode(Flag):
+#:
+RSS = 1 << 0
+#:
+DCB = 1 << 1
+#:
+VMDQ = 1 << 2
+
+
+@str_mixins(hex_from_flag_value)
+@unique
+class TestPmdHairpinMode(Flag):
+TWO_PORTS_LOOP = 1 << 0
+"""Two hairpin ports loop."""
+TWO_PORTS_PAIRED = 1 << 1
+"""Two hairpin ports paired."""
+EXPLICIT_TX_FLOW = 1 << 4
+"""Explicit Tx flow rule."""
+FORCE_RX_QUEUE_MEM_SETTINGS = 1 << 8
+"""Force memory settings of hairpin RX queue."""
+FORCE_TX_QUEUE_MEM_SETTINGS = 1 << 9
+"""Force memory settings of hairpin TX queue."""
+RX_QUEUE_USE_LOCKED_DEVICE_MEMORY = 1 << 12
+"""Ha

[PATCH 4/6] dts: use testpmd params for scatter test suite

[Luca Vizzarro]

Update the buffer scatter test suite to use TestPmdParameters
instead of the StrParams implementation.

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 dts/tests/TestSuite_pmd_buffer_scatter.py | 19 +++
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py 
b/dts/tests/TestSuite_pmd_buffer_scatter.py
index 4cdbdc4272..c6d313fc64 100644
--- a/dts/tests/TestSuite_pmd_buffer_scatter.py
+++ b/dts/tests/TestSuite_pmd_buffer_scatter.py
@@ -23,7 +23,11 @@
 from scapy.utils import hexstr  # type: ignore[import]
 
 from framework.params import StrParams
-from framework.remote_session.testpmd_shell import TestPmdForwardingModes, 
TestPmdShell
+from framework.remote_session.testpmd_shell import (
+TestPmdForwardingModes,
+TestPmdShell,
+TestPmdParameters,
+)
 from framework.test_suite import TestSuite
 
 
@@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: int) -> None:
 """
 testpmd = self.sut_node.create_interactive_shell(
 TestPmdShell,
-app_parameters=StrParams(
-"--mbcache=200 "
-f"--mbuf-size={mbsize} "
-"--max-pkt-len=9000 "
-"--port-topology=paired "
-"--tx-offloads=0x8000"
+app_parameters=TestPmdParameters(
+forward_mode=TestPmdForwardingModes.mac,
+mbcache=200,
+mbuf_size=[mbsize],
+max_pkt_len=9000,
+tx_offloads=0x8000,
 ),
 privileged=True,
 )
-testpmd.set_forward_mode(TestPmdForwardingModes.mac)
 testpmd.start()
 
 for offset in [-1, 0, 1, 4, 5]:
-- 
2.34.1

[PATCH 5/6] dts: add statefulness to InteractiveShell

[Luca Vizzarro]

The InteractiveShell class can be started in privileged mode, but this
is not saved for reference to the tests developer. Moreover, originally
a command timeout could only be set at initialisation, this can now be
amended and reset back as needed.

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 .../remote_session/interactive_shell.py| 18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/dts/framework/remote_session/interactive_shell.py 
b/dts/framework/remote_session/interactive_shell.py
index a2c7b30d9f..5d80061e8d 100644
--- a/dts/framework/remote_session/interactive_shell.py
+++ b/dts/framework/remote_session/interactive_shell.py
@@ -41,8 +41,10 @@ class InteractiveShell(ABC):
 _stdout: channel.ChannelFile
 _ssh_channel: Channel
 _logger: DTSLogger
+__default_timeout: float
 _timeout: float
 _app_args: Params | None
+_is_privileged: bool = False
 
 #: Prompt to expect at the end of output when sending a command.
 #: This is often overridden by subclasses.
@@ -88,7 +90,7 @@ def __init__(
 self._ssh_channel.settimeout(timeout)
 self._ssh_channel.set_combine_stderr(True)  # combines stdout and 
stderr streams
 self._logger = logger
-self._timeout = timeout
+self._timeout = self.__default_timeout = timeout
 self._app_args = app_args
 self._start_application(get_privileged_command)
 
@@ -105,6 +107,7 @@ def _start_application(self, get_privileged_command: 
Callable[[str], str] | None
 start_command = f"{self.path} {self._app_args or ''}"
 if get_privileged_command is not None:
 start_command = get_privileged_command(start_command)
+self._is_privileged = True
 self.send_command(start_command)
 
 def send_command(self, command: str, prompt: str | None = None) -> str:
@@ -150,3 +153,16 @@ def close(self) -> None:
 def __del__(self) -> None:
 """Make sure the session is properly closed before deleting the 
object."""
 self.close()
+
+@property
+def is_privileged(self) -> bool:
+"""Property specifying if the interactive shell is running in 
privileged mode."""
+return self._is_privileged
+
+def set_timeout(self, timeout: float):
+"""Set the timeout to use with the next commands."""
+self._timeout = timeout
+
+def reset_timeout(self):
+"""Reset the timeout to the default setting."""
+self._timeout = self.__default_timeout
-- 
2.34.1

[PATCH 6/6] dts: add statefulness to TestPmdShell

[Luca Vizzarro]

This commit provides a state container for TestPmdShell. It currently
only indicates whether the packet forwarding has started
or not, and the number of ports which were given to the shell.

This also fixes the behaviour of `wait_link_status_up` to use the
command timeout as inherited from InteractiveShell.

Signed-off-by: Luca Vizzarro 
Reviewed-by: Jack Bond-Preston 
Reviewed-by: Honnappa Nagarahalli 
---
 dts/framework/remote_session/testpmd_shell.py | 41 +--
 1 file changed, 28 insertions(+), 13 deletions(-)

diff --git a/dts/framework/remote_session/testpmd_shell.py 
b/dts/framework/remote_session/testpmd_shell.py
index a823dc53be..ea1d254f86 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -678,19 +678,27 @@ def __str__(self) -> str:
 return self.pci_address
 
 
+@dataclass(slots=True)
+class TestPmdState:
+"""Session state container."""
+
+#:
+packet_forwarding_started: bool = False
+
+#: The number of ports which were allowed on the command-line when testpmd 
was started.
+number_of_ports: int = 0
+
+
 class TestPmdShell(InteractiveShell):
 """Testpmd interactive shell.
 
 The testpmd shell users should never use
 the :meth:`~.interactive_shell.InteractiveShell.send_command` method 
directly, but rather
 call specialized methods. If there isn't one that satisfies a need, it 
should be added.
-
-Attributes:
-number_of_ports: The number of ports which were allowed on the 
command-line when testpmd
-was started.
 """
 
-number_of_ports: int
+#: Current state
+state: TestPmdState = TestPmdState()
 
 #: The path to the testpmd executable.
 path: ClassVar[PurePath] = PurePath("app", "dpdk-testpmd")
@@ -723,7 +731,13 @@ def _start_application(self, get_privileged_command: 
Callable[[str], str] | None
 if self._app_args.app_params is None:
 self._app_args.app_params = TestPmdParameters()
 
-self.number_of_ports = len(self._app_args.ports) if 
self._app_args.ports is not None else 0
+assert isinstance(self._app_args.app_params, TestPmdParameters)
+
+if self._app_args.app_params.auto_start:
+self.state.packet_forwarding_started = True
+
+if self._app_args.ports is not None:
+self.state.number_of_ports = len(self._app_args.ports)
 
 super()._start_application(get_privileged_command)
 
@@ -746,12 +760,14 @@ def start(self, verify: bool = True) -> None:
 self._logger.debug(f"Failed to start packet forwarding: 
\n{start_cmd_output}")
 raise InteractiveCommandExecutionError("Testpmd failed to 
start packet forwarding.")
 
-for port_id in range(self.number_of_ports):
+for port_id in range(self.state.number_of_ports):
 if not self.wait_link_status_up(port_id):
 raise InteractiveCommandExecutionError(
 "Not all ports came up after starting packet 
forwarding in testpmd."
 )
 
+self.state.packet_forwarding_started = True
+
 def stop(self, verify: bool = True) -> None:
 """Stop packet forwarding.
 
@@ -773,6 +789,8 @@ def stop(self, verify: bool = True) -> None:
 self._logger.debug(f"Failed to stop packet forwarding: 
\n{stop_cmd_output}")
 raise InteractiveCommandExecutionError("Testpmd failed to stop 
packet forwarding.")
 
+self.state.packet_forwarding_started = False
+
 def get_devices(self) -> list[TestPmdDevice]:
 """Get a list of device names that are known to testpmd.
 
@@ -788,19 +806,16 @@ def get_devices(self) -> list[TestPmdDevice]:
 dev_list.append(TestPmdDevice(line))
 return dev_list
 
-def wait_link_status_up(self, port_id: int, timeout=SETTINGS.timeout) -> 
bool:
-"""Wait until the link status on the given port is "up".
+def wait_link_status_up(self, port_id: int) -> bool:
+"""Wait until the link status on the given port is "up". Times out.
 
 Arguments:
 port_id: Port to check the link status on.
-timeout: Time to wait for the link to come up. The default value 
for this
-argument may be modified using the :option:`--timeout` 
command-line argument
-or the :envvar:`DTS_TIMEOUT` environment variable.
 
 Returns:
 Whether the link came up in time or not.
 """
-time_to_stop = time.time() + timeout
+time_to_stop = time.time() + self._timeout
 port_info: str = ""
 while time.time() < time_to_stop:
 port_info = self.send_command(f"show port info {port_id}")
-- 
2.34.1

Re: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Stephen Hemminger]

On Tue, 26 Mar 2024 10:43:30 -0700
Garrett D'Amore  wrote:

> This had occurred to me as well.  I think most hardware DMA engines can align 
> on 32-bit boundaries.  I've yet to see a device that actually requires 64-bit 
> DMA alignment.  (But I have only looked at a subset  of devices, and most of 
> the  ones I have looked at are not ones that would be considered 'modern'.)

There maybe a PCI transaction performance penalty if not aligned.

Re: meson option to customize RTE_PKTMBUF_HEADROOM patch

[Garrett D'Amore]

Fair enough... I think that is just something we're going to have to live with.

The other solutions are either much more painful, or much more work.

If we can use header/buffer splitting that would be superior.  Right now we 
can't use that everywhere because it isn't available everywhere.
On Mar 26, 2024 at 1:35 PM -0700, Stephen Hemminger 
, wrote:
> On Tue, 26 Mar 2024 10:43:30 -0700
> Garrett D'Amore  wrote:
>
> > This had occurred to me as well.  I think most hardware DMA engines can 
> > align on 32-bit boundaries.  I've yet to see a device that actually 
> > requires 64-bit DMA alignment.  (But I have only looked at a subset  of 
> > devices, and most of the  ones I have looked at are not ones that would be 
> > considered 'modern'.)
>
> There maybe a PCI transaction performance penalty if not aligned.

[PATCH v15 00/15] Logging unification and improvements

[Stephen Hemminger]

Improvements and unification of logging library (for 24.07 release).
This version works on all platforms: Linux, Windows and FreeBSD.

This is update to rework patch set. It adds several new features
to the console log output.

  * Putting a timestamp on console output which is useful for
analyzing performance of startup codes. Timestamp is optional
and must be enabled on command line.

  * Displaying console output with colors.
It uses the standard conventions used by many other Linux commands
for colorized display.  The default is to enable color if the
console output is going to a terminal. But it can be always
on or disabled by command line flag. This default was chosen
based on what dmesg(1) command does.

I find color helpful because DPDK drivers and libraries print
lots of not very useful messages. And having error messages
highlighted in bold face helps. This might also get users to
pay more attention to error messages. Many bug reports have
earlier messages that are lost because there are so many
info messages.

  * Add support for automatic detection of systemd journal
protocol. If running as systemd service will get enhanced
logging.

  * Use of syslog is optional and the meaning of the
--syslog flag has changed. The default is *not* to use
syslog. 

Add myself as maintainer for log because by now have added
more than previous authors...
Will add a release note in next release (after this is merged)

v15 - fix log test cases
  avoid use of malloc (ie vasprintf) in log path because
  malloc pool maybe corrupted.

Stephen Hemminger (15):
  maintainers: add for log library
  windows: make getopt functions have const properties
  windows: add os shim for localtime_r
  windows: common wrapper for vasprintf and asprintf
  eal: make eal_log_level_parse common
  eal: do not duplicate rte_init_alert() messages
  eal: change rte_exit() output to match rte_log()
  log: move handling of syslog facility out of eal
  eal: initialize log before everything else
  log: drop syslog support, and make code common
  log: add hook for printing log messages
  log: add timestamp option
  log: add optional support of syslog
  log: add support for systemd journal
  log: colorize log output

 MAINTAINERS   |   1 +
 app/test/test_eal_flags.c |  64 +-
 doc/guides/linux_gsg/linux_eal_parameters.rst |  27 -
 doc/guides/prog_guide/log_lib.rst |  57 ++
 drivers/bus/pci/pci_common.c  |  32 -
 lib/eal/common/eal_common_debug.c |  10 +-
 lib/eal/common/eal_common_options.c   | 126 ++--
 lib/eal/common/eal_options.h  |   5 +
 lib/eal/common/eal_private.h  |  10 -
 lib/eal/freebsd/eal.c |  64 +-
 lib/eal/linux/eal.c   |  68 +-
 lib/eal/windows/eal.c |  77 +--
 lib/eal/windows/getopt.c  |  23 +-
 lib/eal/windows/include/getopt.h  |   8 +-
 lib/eal/windows/include/rte_os_shim.h |  56 ++
 lib/log/log.c | 646 +-
 lib/log/log_freebsd.c |   5 +-
 lib/log/log_internal.h|  25 +-
 lib/log/log_linux.c   |  61 --
 lib/log/log_windows.c |  18 -
 lib/log/meson.build   |   5 +-
 lib/log/version.map   |   4 +-
 22 files changed, 964 insertions(+), 428 deletions(-)
 delete mode 100644 lib/log/log_linux.c
 delete mode 100644 lib/log/log_windows.c

-- 
2.43.0

[PATCH v15 01/15] maintainers: add for log library

[Stephen Hemminger]

"You touch it you own it"
Add myself as maintainer for log library.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7abb3aee49..54c28a601d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -180,6 +180,7 @@ F: app/test/test_threads.c
 F: app/test/test_version.c
 
 Logging
+M: Stephen Hemminger 
 F: lib/log/
 F: doc/guides/prog_guide/log_lib.rst
 F: app/test/test_logs.c
-- 
2.43.0

[PATCH v15 02/15] windows: make getopt functions have const properties

[Stephen Hemminger]

Having different prototypes on different platforms can lead
to lots of unnecessary workarounds.  Looks like the version of
getopt used from windows was based on an older out of date
version from FreeBSD.

This patch changes getopt, getopt_long, etc to have the same const
attributes as Linux and FreeBSD. The changes are derived from
the current FreeBSD version of getopt_long.

Signed-off-by: Stephen Hemminger 
Acked-by: Tyler Retzlaff 
Acked-by: Dmitry Kozlyuk 
---
 lib/eal/windows/getopt.c | 23 ---
 lib/eal/windows/include/getopt.h |  8 
 2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/lib/eal/windows/getopt.c b/lib/eal/windows/getopt.c
index a1f51c6c23..50ff71b930 100644
--- a/lib/eal/windows/getopt.c
+++ b/lib/eal/windows/getopt.c
@@ -20,7 +20,7 @@
 #include 
 #include 
 
-const char*optarg; /* argument associated with option */
+char*optarg;   /* argument associated with option */
 intopterr = 1; /* if error message should be printed */
 intoptind = 1; /* index into parent argv vector */
 intoptopt = '?';   /* character checked for validity */
@@ -39,9 +39,9 @@ static void pass(const char *a) {(void) a; }
 #defineBADARG  ((*options == ':') ? (int)':' : (int)'?')
 #defineINORDER 1
 
-#defineEMSG""
+static char EMSG[] = "";
 
-static const char *place = EMSG; /* option letter processing */
+static char *place = EMSG; /* option letter processing */
 
 /* XXX: set optreset to 1 rather than these two */
 static int nonopt_start = -1; /* first non option argument (for permute) */
@@ -80,7 +80,7 @@ gcd(int a, int b)
  */
 static void
 permute_args(int panonopt_start, int panonopt_end, int opt_end,
-   char **nargv)
+   char * const *nargv)
 {
int cstart, cyclelen, i, j, ncycle, nnonopts, nopts, pos;
char *swap;
@@ -101,11 +101,12 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
pos -= nnonopts;
else
pos += nopts;
+
swap = nargv[pos];
/* LINTED const cast */
-   ((char **) nargv)[pos] = nargv[cstart];
+   ((char **)(uintptr_t)nargv)[pos] = nargv[cstart];
/* LINTED const cast */
-   ((char **)nargv)[cstart] = swap;
+   ((char **)(uintptr_t)nargv)[cstart] = swap;
}
}
 }
@@ -116,7 +117,7 @@ permute_args(int panonopt_start, int panonopt_end, int 
opt_end,
  * Returns -1 if short_too is set and the option does not match long_options.
  */
 static int
-parse_long_options(char **nargv, const char *options,
+parse_long_options(char * const *nargv, const char *options,
const struct option *long_options, int *idx, int short_too)
 {
const char *current_argv;
@@ -236,7 +237,7 @@ parse_long_options(char **nargv, const char *options,
  * Parse argc/argv argument vector.  Called by user level routines.
  */
 static int
-getopt_internal(int nargc, char **nargv, const char *options,
+getopt_internal(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx, int flags)
 {
char *oli;  /* option letter list index */
@@ -434,7 +435,7 @@ getopt_internal(int nargc, char **nargv, const char 
*options,
  * Parse argc/argv argument vector.
  */
 int
-getopt(int nargc, char *nargv[], const char *options)
+getopt(int nargc, char *const nargv[], const char *options)
 {
return getopt_internal(nargc, nargv, options, NULL, NULL,
   FLAG_PERMUTE);
@@ -445,7 +446,7 @@ getopt(int nargc, char *nargv[], const char *options)
  * Parse argc/argv argument vector.
  */
 int
-getopt_long(int nargc, char *nargv[], const char *options,
+getopt_long(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
@@ -458,7 +459,7 @@ getopt_long(int nargc, char *nargv[], const char *options,
  * Parse argc/argv argument vector.
  */
 int
-getopt_long_only(int nargc, char *nargv[], const char *options,
+getopt_long_only(int nargc, char *const nargv[], const char *options,
const struct option *long_options, int *idx)
 {
 
diff --git a/lib/eal/windows/include/getopt.h b/lib/eal/windows/include/getopt.h
index 6f57af454b..e4cf6873cb 100644
--- a/lib/eal/windows/include/getopt.h
+++ b/lib/eal/windows/include/getopt.h
@@ -44,7 +44,7 @@
 
 
 /** argument to current option, or NULL if it has none */
-extern const char *optarg;
+extern char *optarg;
 /** Current position in arg string.  Starts from 1.
  * Setting to 0 resets state.
  */
@@ -80,14 +80,14 @@ struct option {
 };
 
 /** Compat: getopt */
-int getopt(int argc, char *argv[], const char *options);
+int getopt(int argc, char *const

[PATCH v15 03/15] windows: add os shim for localtime_r

[Stephen Hemminger]

Windows does not have localtime_r but it does have a similar
function that can be used instead.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/windows/include/rte_os_shim.h | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/lib/eal/windows/include/rte_os_shim.h 
b/lib/eal/windows/include/rte_os_shim.h
index eda8113662..e9741a9df2 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -110,4 +110,14 @@ rte_clock_gettime(clockid_t clock_id, struct timespec *tp)
 }
 #define clock_gettime(clock_id, tp) rte_clock_gettime(clock_id, tp)
 
+static inline struct tm *
+rte_localtime_r(const time_t *timer, struct tm *buf)
+{
+   if (localtime_s(buf, timer) == 0)
+   return buf;
+   else
+   return NULL;
+}
+#define localtime_r(timer, buf) rte_localtime_r(timer, buf)
+
 #endif /* _RTE_OS_SHIM_ */
-- 
2.43.0

[PATCH v15 04/15] windows: common wrapper for vasprintf and asprintf

[Stephen Hemminger]

Replace the windows version of asprintf() that was only usable
in eal. With a more generic one that supports both vasprintf()
and asprintf().  This also eliminates duplicate code.

Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information")
Fixes: 9ec521006db0 ("eal/windows: hide asprintf shim")

Signed-off-by: Stephen Hemminger 
---
 drivers/bus/pci/pci_common.c  | 32 ---
 lib/eal/common/eal_private.h  | 10 --
 lib/eal/windows/eal.c | 28 
 lib/eal/windows/include/rte_os_shim.h | 46 +++
 4 files changed, 46 insertions(+), 70 deletions(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 889a48d2af..80691c75a3 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -45,38 +45,6 @@ const char *rte_pci_get_sysfs_path(void)
return path;
 }
 
-#ifdef RTE_EXEC_ENV_WINDOWS
-#define asprintf pci_asprintf
-
-static int
-__rte_format_printf(2, 3)
-pci_asprintf(char **buffer, const char *format, ...)
-{
-   int size, ret;
-   va_list arg;
-
-   va_start(arg, format);
-   size = vsnprintf(NULL, 0, format, arg);
-   va_end(arg);
-   if (size < 0)
-   return -1;
-   size++;
-
-   *buffer = malloc(size);
-   if (*buffer == NULL)
-   return -1;
-
-   va_start(arg, format);
-   ret = vsnprintf(*buffer, size, format, arg);
-   va_end(arg);
-   if (ret != size - 1) {
-   free(*buffer);
-   return -1;
-   }
-   return ret;
-}
-#endif /* RTE_EXEC_ENV_WINDOWS */
-
 static struct rte_devargs *
 pci_devargs_lookup(const struct rte_pci_addr *pci_addr)
 {
diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 71523cfdb8..da8d77a134 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -737,16 +737,6 @@ void __rte_thread_init(unsigned int lcore_id, rte_cpuset_t 
*cpuset);
  */
 void __rte_thread_uninit(void);
 
-/**
- * asprintf(3) replacement for Windows.
- */
-#ifdef RTE_EXEC_ENV_WINDOWS
-__rte_format_printf(2, 3)
-int eal_asprintf(char **buffer, const char *format, ...);
-
-#define asprintf(buffer, format, ...) \
-   eal_asprintf(buffer, format, ##__VA_ARGS__)
-#endif
 
 #define EAL_LOG(level, ...) \
RTE_LOG_LINE(level, EAL, "" __VA_ARGS__)
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 52f0e7462d..8ca00c0f95 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -503,34 +503,6 @@ rte_eal_init(int argc, char **argv)
return fctret;
 }
 
-/* Don't use MinGW asprintf() to have identical code with all toolchains. */
-int
-eal_asprintf(char **buffer, const char *format, ...)
-{
-   int size, ret;
-   va_list arg;
-
-   va_start(arg, format);
-   size = vsnprintf(NULL, 0, format, arg);
-   va_end(arg);
-   if (size < 0)
-   return -1;
-   size++;
-
-   *buffer = malloc(size);
-   if (*buffer == NULL)
-   return -1;
-
-   va_start(arg, format);
-   ret = vsnprintf(*buffer, size, format, arg);
-   va_end(arg);
-   if (ret != size - 1) {
-   free(*buffer);
-   return -1;
-   }
-   return ret;
-}
-
 int
 rte_vfio_container_dma_map(__rte_unused int container_fd,
__rte_unused uint64_t vaddr,
diff --git a/lib/eal/windows/include/rte_os_shim.h 
b/lib/eal/windows/include/rte_os_shim.h
index e9741a9df2..b941476fe0 100644
--- a/lib/eal/windows/include/rte_os_shim.h
+++ b/lib/eal/windows/include/rte_os_shim.h
@@ -3,6 +3,7 @@
 #ifndef _RTE_OS_SHIM_
 #define _RTE_OS_SHIM_
 
+#include 
 #include 
 
 #include 
@@ -120,4 +121,49 @@ rte_localtime_r(const time_t *timer, struct tm *buf)
 }
 #define localtime_r(timer, buf) rte_localtime_r(timer, buf)
 
+/* print to allocated string */
+static inline int
+rte_vasprintf(char **strp, const char *fmt, va_list ap)
+{
+   char *str;
+   int len, ret;
+
+   *strp = NULL;
+
+   /* determine size of buffer needed */
+   len = _vscprintf(fmt, ap);
+   if (len < 0)
+   return -1;
+
+   len += 1;   /* for nul termination */
+   str = malloc(len);
+   if (str == NULL)
+   return -1;
+
+   ret = vsnprintf(str, len, fmt, ap);
+   if (ret < 0) {
+   free(str);
+   return -1;
+   } else {
+   *strp = str;
+   return ret;
+   }
+}
+#define vasprintf(strp, fmt, ap) rte_vasprintf(strp, fmt, ap)
+
+static inline int
+rte_asprintf(char **strp, const char *fmt, ...)
+{
+   int ret;
+
+   va_list ap;
+
+   va_start(ap, fmt);
+   ret = rte_vasprintf(strp, fmt, ap);
+   va_end(ap);
+
+   return ret;
+}
+
+#define asprintf(strp, fmt, ...) rte_asprintf(strp, fmt, __VA_ARGS__)
 #endif /* _RTE_OS_SHIM_ */
-- 
2.43.0

[PATCH v15 05/15] eal: make eal_log_level_parse common

[Stephen Hemminger]

The code to parse for log-level option should be same on
all OS variants.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_options.c | 46 +
 lib/eal/common/eal_options.h|  1 +
 lib/eal/freebsd/eal.c   | 42 --
 lib/eal/linux/eal.c | 39 
 lib/eal/windows/eal.c   | 35 --
 5 files changed, 47 insertions(+), 116 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index e541f07939..5435399b85 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -1640,6 +1640,51 @@ eal_parse_huge_unlink(const char *arg, struct 
hugepage_file_discipline *out)
return -1;
 }
 
+/* Parse the all arguments looking for log related ones */
+int
+eal_log_level_parse(int argc, char * const argv[])
+{
+   struct internal_config *internal_conf = 
eal_get_internal_configuration();
+   int option_index, opt;
+   const int old_optind = optind;
+   const int old_optopt = optopt;
+   const int old_opterr = opterr;
+   char *old_optarg = optarg;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   const int old_optreset = optreset;
+   optreset = 1;
+#endif
+
+   optind = 1;
+   opterr = 0;
+
+   while ((opt = getopt_long(argc, argv, eal_short_options,
+ eal_long_options, &option_index)) != EOF) {
+
+   switch (opt) {
+   case OPT_LOG_LEVEL_NUM:
+   if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
+   return -1;
+   break;
+   case '?':
+   /* getopt is not happy, stop right now */
+   goto out;
+   default:
+   continue;
+   }
+   }
+out:
+   /* restore getopt lib */
+   optind = old_optind;
+   optopt = old_optopt;
+   optarg = old_optarg;
+   opterr = old_opterr;
+#ifdef RTE_EXEC_ENV_FREEBSD
+   optreset = old_optreset;
+#endif
+   return 0;
+}
+
 int
 eal_parse_common_option(int opt, const char *optarg,
struct internal_config *conf)
@@ -2173,6 +2218,7 @@ rte_vect_set_max_simd_bitwidth(uint16_t bitwidth)
return 0;
 }
 
+
 void
 eal_common_usage(void)
 {
diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h
index 3cc9cb6412..f3f2e104f6 100644
--- a/lib/eal/common/eal_options.h
+++ b/lib/eal/common/eal_options.h
@@ -96,6 +96,7 @@ enum {
 extern const char eal_short_options[];
 extern const struct option eal_long_options[];
 
+int eal_log_level_parse(int argc, char * const argv[]);
 int eal_parse_common_option(int opt, const char *argv,
struct internal_config *conf);
 int eal_option_device_parse(void);
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index bab77118e9..9825bcea0b 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -363,48 +363,6 @@ eal_get_hugepage_mem_size(void)
return (size < SIZE_MAX) ? (size_t)(size) : SIZE_MAX;
 }
 
-/* Parse the arguments for --log-level only */
-static void
-eal_log_level_parse(int argc, char **argv)
-{
-   int opt;
-   char **argvopt;
-   int option_index;
-   const int old_optind = optind;
-   const int old_optopt = optopt;
-   const int old_optreset = optreset;
-   char * const old_optarg = optarg;
-   struct internal_config *internal_conf =
-   eal_get_internal_configuration();
-
-   argvopt = argv;
-   optind = 1;
-   optreset = 1;
-
-   while ((opt = getopt_long(argc, argvopt, eal_short_options,
- eal_long_options, &option_index)) != EOF) {
-
-   int ret;
-
-   /* getopt is not happy, stop right now */
-   if (opt == '?')
-   break;
-
-   ret = (opt == OPT_LOG_LEVEL_NUM) ?
-   eal_parse_common_option(opt, optarg, internal_conf) : 0;
-
-   /* common parser is not happy */
-   if (ret < 0)
-   break;
-   }
-
-   /* restore getopt lib */
-   optind = old_optind;
-   optopt = old_optopt;
-   optreset = old_optreset;
-   optarg = old_optarg;
-}
-
 /* Parse the argument given in the command line of the application */
 static int
 eal_parse_args(int argc, char **argv)
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index fd422f1f62..bffeb1f34e 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -546,45 +546,6 @@ eal_parse_vfio_vf_token(const char *vf_token)
return -1;
 }
 
-/* Parse the arguments for --log-level only */
-static void
-eal_log_level_parse(int argc, char **argv)
-{
-   int opt;
-   char **argvopt;
-   int option_index;
-   const int old_optind = optind;
-   const 

[PATCH v15 06/15] eal: do not duplicate rte_init_alert() messages

[Stephen Hemminger]

The message already goes through logging, and does not need
to be printed on stderr. Message level should be ALERT
to match function name.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/freebsd/eal.c | 3 +--
 lib/eal/linux/eal.c   | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 9825bcea0b..17b56f38aa 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -529,8 +529,7 @@ rte_eal_iopl_init(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-   fprintf(stderr, "EAL: FATAL: %s\n", msg);
-   EAL_LOG(ERR, "%s", msg);
+   EAL_LOG(ALERT, "%s", msg);
 }
 
 /* Launch threads, called at application init(). */
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index bffeb1f34e..23dc26b124 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void)
 
 static void rte_eal_init_alert(const char *msg)
 {
-   fprintf(stderr, "EAL: FATAL: %s\n", msg);
-   EAL_LOG(ERR, "%s", msg);
+   EAL_LOG(ALERT, "%s", msg);
 }
 
 /*
-- 
2.43.0

[PATCH v15 07/15] eal: change rte_exit() output to match rte_log()

[Stephen Hemminger]

The rte_exit() output format confuses the timestamp and coloring
options. Change it to use be a single line with proper prefix.

Before:
[ 0.006481] EAL: Error - exiting with code: 1
  Cause: [ 0.006489] Cannot init EAL: Permission denied

After:
[ 0.006238] EAL: Error - exiting with code: 1
[ 0.006250] EAL: Cause - Cannot init EAL: Permission denied

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_debug.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/eal/common/eal_common_debug.c 
b/lib/eal/common/eal_common_debug.c
index 3e77995896..71bb5a7d34 100644
--- a/lib/eal/common/eal_common_debug.c
+++ b/lib/eal/common/eal_common_debug.c
@@ -34,17 +34,17 @@ void
 rte_exit(int exit_code, const char *format, ...)
 {
va_list ap;
+   char *msg = NULL;
 
if (exit_code != 0)
-   RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n"
-   "  Cause: ", exit_code);
+   EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code);
 
va_start(ap, format);
-   rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap);
+   if (vasprintf(&msg, format, ap) > 0)
+   rte_log(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, "EAL: Cause - %s", msg);
va_end(ap);
 
if (rte_eal_cleanup() != 0 && rte_errno != EALREADY)
-   EAL_LOG(CRIT,
-   "EAL could not release all resources");
+   EAL_LOG(CRIT, "EAL could not release all resources");
exit(exit_code);
 }
-- 
2.43.0

[PATCH v15 08/15] log: move handling of syslog facility out of eal

[Stephen Hemminger]

The syslog facility property is better handled in lib/log
rather than in eal. This also allows for changes to what
syslog flag means in later steps.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/common/eal_common_options.c | 51 ++---
 lib/eal/freebsd/eal.c   |  5 ++-
 lib/eal/linux/eal.c |  7 ++--
 lib/eal/windows/eal.c   |  6 ++--
 lib/log/log_freebsd.c   |  2 +-
 lib/log/log_internal.h  |  5 ++-
 lib/log/log_linux.c | 47 --
 lib/log/log_windows.c   |  8 -
 lib/log/version.map |  1 +
 9 files changed, 68 insertions(+), 64 deletions(-)

diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 5435399b85..661b2db211 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -6,9 +6,6 @@
 #include 
 #include 
 #include 
-#ifndef RTE_EXEC_ENV_WINDOWS
-#include 
-#endif
 #include 
 #include 
 #include 
@@ -349,10 +346,6 @@ eal_reset_internal_config(struct internal_config 
*internal_cfg)
}
internal_cfg->base_virtaddr = 0;
 
-#ifdef LOG_DAEMON
-   internal_cfg->syslog_facility = LOG_DAEMON;
-#endif
-
/* if set to NONE, interrupt mode is determined automatically */
internal_cfg->vfio_intr_mode = RTE_INTR_MODE_NONE;
memset(internal_cfg->vfio_vf_token, 0,
@@ -1297,47 +1290,6 @@ eal_parse_lcores(const char *lcores)
return ret;
 }
 
-#ifndef RTE_EXEC_ENV_WINDOWS
-static int
-eal_parse_syslog(const char *facility, struct internal_config *conf)
-{
-   int i;
-   static const struct {
-   const char *name;
-   int value;
-   } map[] = {
-   { "auth", LOG_AUTH },
-   { "cron", LOG_CRON },
-   { "daemon", LOG_DAEMON },
-   { "ftp", LOG_FTP },
-   { "kern", LOG_KERN },
-   { "lpr", LOG_LPR },
-   { "mail", LOG_MAIL },
-   { "news", LOG_NEWS },
-   { "syslog", LOG_SYSLOG },
-   { "user", LOG_USER },
-   { "uucp", LOG_UUCP },
-   { "local0", LOG_LOCAL0 },
-   { "local1", LOG_LOCAL1 },
-   { "local2", LOG_LOCAL2 },
-   { "local3", LOG_LOCAL3 },
-   { "local4", LOG_LOCAL4 },
-   { "local5", LOG_LOCAL5 },
-   { "local6", LOG_LOCAL6 },
-   { "local7", LOG_LOCAL7 },
-   { NULL, 0 }
-   };
-
-   for (i = 0; map[i].name; i++) {
-   if (!strcmp(facility, map[i].name)) {
-   conf->syslog_facility = map[i].value;
-   return 0;
-   }
-   }
-   return -1;
-}
-#endif
-
 static void
 eal_log_usage(void)
 {
@@ -1663,6 +1615,7 @@ eal_log_level_parse(int argc, char * const argv[])
 
switch (opt) {
case OPT_LOG_LEVEL_NUM:
+   case OPT_SYSLOG_NUM:
if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
return -1;
break;
@@ -1882,7 +1835,7 @@ eal_parse_common_option(int opt, const char *optarg,
 
 #ifndef RTE_EXEC_ENV_WINDOWS
case OPT_SYSLOG_NUM:
-   if (eal_parse_syslog(optarg, conf) < 0) {
+   if (eal_log_syslog(optarg) < 0) {
EAL_LOG(ERR, "invalid parameters for --"
OPT_SYSLOG);
return -1;
diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 17b56f38aa..6552f9c138 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -11,7 +11,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -392,8 +391,8 @@ eal_parse_args(int argc, char **argv)
goto out;
}
 
-   /* eal_log_level_parse() already handled this option */
-   if (opt == OPT_LOG_LEVEL_NUM)
+   /* eal_log_level_parse() already handled these */
+   if (opt == OPT_LOG_LEVEL_NUM || opt == OPT_LOG_SYSLOG_NUM)
continue;
 
ret = eal_parse_common_option(opt, optarg, internal_conf);
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 23dc26b124..3d0c34063e 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -610,8 +610,8 @@ eal_parse_args(int argc, char **argv)
goto out;
}
 
-   /* eal_log_level_parse() already handled this option */
-   if (opt == OPT_LOG_LEVEL_NUM)
+   /* eal_log_level_parse() already handled these options */
+   if (opt == OPT_LOG_LEVEL_NUM || opt == OPT_SYSLOG_NUM)
continue;
 
ret = eal_parse_common_option(opt, optarg, internal_conf);
@@ -1106,8 +1106,7 @@ rte_eal_init(int argc, ch

[PATCH v15 09/15] eal: initialize log before everything else

[Stephen Hemminger]

In order for all log messages (including CPU mismatch) to
come out through the logging library, it must be initialized
as early in rte_eal_init() as possible on all platforms.

Where it was done before was likely historical based on
the support of non-OS isolated CPU's which required a shared
memory buffer; that support was dropped before DPDK was
publicly released.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/freebsd/eal.c  | 12 +---
 lib/eal/linux/eal.c| 19 +--
 lib/eal/windows/eal.c  |  8 ++--
 lib/log/log_freebsd.c  |  3 +--
 lib/log/log_internal.h |  2 +-
 lib/log/log_linux.c| 14 ++
 lib/log/log_windows.c  |  4 +---
 7 files changed, 33 insertions(+), 29 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index 6552f9c138..55ff27a4da 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -52,6 +52,7 @@
 #include "eal_options.h"
 #include "eal_memcfg.h"
 #include "eal_trace.h"
+#include "log_internal.h"
 
 #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
 
@@ -546,6 +547,14 @@ rte_eal_init(int argc, char **argv)
bool has_phys_addr;
enum rte_iova_mode iova_mode;
 
+   /* setup log as early as possible */
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
+   eal_log_init(getprogname());
+
/* checks if the machine is adequate */
if (!rte_cpu_is_supported()) {
rte_eal_init_alert("unsupported cpu type.");
@@ -565,9 +574,6 @@ rte_eal_init(int argc, char **argv)
/* clone argv to report out later in telemetry */
eal_save_args(argc, argv);
 
-   /* set log level as early as possible */
-   eal_log_level_parse(argc, argv);
-
if (rte_eal_cpu_init() < 0) {
rte_eal_init_alert("Cannot detect lcores.");
rte_errno = ENOTSUP;
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 3d0c34063e..b9a0fb1742 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -936,6 +936,15 @@ rte_eal_init(int argc, char **argv)
struct internal_config *internal_conf =
eal_get_internal_configuration();
 
+   /* setup log as early as possible */
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
+
+   eal_log_init(program_invocation_short_name);
+
/* checks if the machine is adequate */
if (!rte_cpu_is_supported()) {
rte_eal_init_alert("unsupported cpu type.");
@@ -952,9 +961,6 @@ rte_eal_init(int argc, char **argv)
 
eal_reset_internal_config(internal_conf);
 
-   /* set log level as early as possible */
-   eal_log_level_parse(argc, argv);
-
/* clone argv to report out later in telemetry */
eal_save_args(argc, argv);
 
@@ -1106,13 +1112,6 @@ rte_eal_init(int argc, char **argv)
 #endif
}
 
-   if (eal_log_init(program_invocation_short_name) < 0) {
-   rte_eal_init_alert("Cannot init logging.");
-   rte_errno = ENOMEM;
-   rte_atomic_store_explicit(&run_once, 0, 
rte_memory_order_relaxed);
-   return -1;
-   }
-
 #ifdef VFIO_PRESENT
if (rte_eal_vfio_setup() < 0) {
rte_eal_init_alert("Cannot init VFIO");
diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
index 14e498a643..e59aba954e 100644
--- a/lib/eal/windows/eal.c
+++ b/lib/eal/windows/eal.c
@@ -250,9 +250,13 @@ rte_eal_init(int argc, char **argv)
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
char thread_name[RTE_THREAD_NAME_SIZE];
 
-   eal_log_init(NULL);
+   if (eal_log_level_parse(argc, argv) < 0) {
+   rte_eal_init_alert("invalid log arguments.");
+   rte_errno = EINVAL;
+   return -1;
+   }
 
-   eal_log_level_parse(argc, argv);
+   eal_log_init(NULL);
 
if (eal_create_cpu_map() < 0) {
rte_eal_init_alert("Cannot discover CPU and NUMA.");
diff --git a/lib/log/log_freebsd.c b/lib/log/log_freebsd.c
index 953e371bee..33a0925c43 100644
--- a/lib/log/log_freebsd.c
+++ b/lib/log/log_freebsd.c
@@ -5,8 +5,7 @@
 #include 
 #include "log_internal.h"
 
-int
+void
 eal_log_init(__rte_unused const char *id)
 {
-   return 0;
 }
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index cb15cdff08..d5fabd7ef7 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -14,7 +14,7 @@
  * Initialize the default log stream.
  */
 __rte_internal
-int eal_log_init(const char *id);
+void eal_log_init(const char *id);
 
 /*
  * Determine where log data is written when no call to rte_openlog_stream.
diff --git a/lib/log/log_linux.c b/lib/log/log_linux.c
index 47aa074da2..6d7dc8f3ab 100644
--- a/lib/log/log_linux.c
+++ b/li

[PATCH v15 10/15] log: drop syslog support, and make code common

[Stephen Hemminger]

This patch makes the log setup code common across all platforms.

Drops syslog support for now, will come back in later patch.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  11 ++-
 lib/eal/common/eal_common_options.c |   3 -
 lib/log/log.c   |  29 +---
 lib/log/log_internal.h  |   6 --
 lib/log/log_linux.c | 102 
 lib/log/log_windows.c   |  22 --
 lib/log/meson.build |   5 +-
 lib/log/version.map |   1 -
 8 files changed, 26 insertions(+), 153 deletions(-)
 delete mode 100644 lib/log/log_linux.c
 delete mode 100644 lib/log/log_windows.c

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 6cb4b06757..36e3185a10 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -984,11 +984,10 @@ test_misc_flags(void)
const char *argv1[] = {prgname, prefix, mp_flag, "--no-pci"};
/* With -v */
const char *argv2[] = {prgname, prefix, mp_flag, "-v"};
+   /* With empty --syslog */
+   const char *argv3[] = {prgname, prefix, mp_flag, "--syslog"};
/* With valid --syslog */
-   const char *argv3[] = {prgname, prefix, mp_flag,
-   "--syslog", "syslog"};
-   /* With empty --syslog (should fail) */
-   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog"};
+   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog", "always"};
/* With invalid --syslog */
const char *argv5[] = {prgname, prefix, mp_flag, "--syslog", "error"};
/* With no-sh-conf, also use no-huge to ensure this test runs on BSD */
@@ -1083,8 +1082,8 @@ test_misc_flags(void)
printf("Error - process did not run ok with --syslog flag\n");
goto fail;
}
-   if (launch_proc(argv4) == 0) {
-   printf("Error - process run ok with empty --syslog flag\n");
+   if (launch_proc(argv4) != 0) {
+   printf("Error - process did not with --syslog always flag\n");
goto fail;
}
if (launch_proc(argv5) == 0) {
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 661b2db211..9ab512e8a1 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -2212,9 +2212,6 @@ eal_common_usage(void)
   "  (can be used multiple times)\n"
   "  --"OPT_VMWARE_TSC_MAP"Use VMware TSC map instead of 
native RDTSC\n"
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
-#ifndef RTE_EXEC_ENV_WINDOWS
-  "  --"OPT_SYSLOG"Set syslog facility\n"
-#endif
   "  --"OPT_LOG_LEVEL"= Set global log level\n"
   "  --"OPT_LOG_LEVEL"=:\n"
   "  Set specific log level\n"
diff --git a/lib/log/log.c b/lib/log/log.c
index 255f757d94..f597da2e39 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -70,12 +70,13 @@ struct log_cur_msg {
  /* per core log */
 static RTE_DEFINE_PER_LCORE(struct log_cur_msg, log_cur_msg);
 
-/* default logs */
-
 /* Change the stream that will be used by logging system */
 int
 rte_openlog_stream(FILE *f)
 {
+   if (rte_logs.file != NULL)
+   fclose(rte_logs.file);
+
rte_logs.file = f;
return 0;
 }
@@ -505,13 +506,20 @@ rte_log(uint32_t level, uint32_t logtype, const char 
*format, ...)
return ret;
 }
 
+/* Placeholder */
+int
+eal_log_syslog(const char *mode __rte_unused)
+{
+   return -1;
+}
+
 /*
- * Called by environment-specific initialization functions.
+ * Called by rte_eal_init
  */
 void
-eal_log_set_default(FILE *default_log)
+eal_log_init(const char *id __rte_unused)
 {
-   default_log_stream = default_log;
+   default_log_stream = stderr;
 
 #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
RTE_LOG(NOTICE, EAL,
@@ -525,8 +533,11 @@ eal_log_set_default(FILE *default_log)
 void
 rte_eal_log_cleanup(void)
 {
-   if (default_log_stream) {
-   fclose(default_log_stream);
-   default_log_stream = NULL;
-   }
+   FILE *log_stream = rte_log_get_stream();
+
+   /* don't close stderr on the application */
+   if (log_stream != stderr)
+   fclose(log_stream);
+
+   rte_logs.file = NULL;
 }
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index d5fabd7ef7..3c46328e7b 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -16,12 +16,6 @@
 __rte_internal
 void eal_log_init(const char *id);
 
-/*
- * Determine where log data is written when no call to rte_openlog_stream.
- */
-__rte_internal
-void eal_log_set_default(FILE *default_log);
-
 /*
  * Save a log option for later.
  */
diff --git a/lib/log/log_linux.c b/lib/log/log_linux.c
deleted file mode 100644
index 6d7dc8f3ab..00
--- a/lib/log/log_linux.c
+++ /dev/null

[PATCH v15 11/15] log: add hook for printing log messages

[Stephen Hemminger]

This is useful for when decorating log output for console
or journal. Provide basic version in this patch.

Signed-off-by: Stephen Hemminger 
---
 lib/log/log.c | 17 -
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/lib/log/log.c b/lib/log/log.c
index f597da2e39..acd4c320b6 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -26,16 +26,21 @@ struct rte_log_dynamic_type {
uint32_t loglevel;
 };
 
+typedef int (*log_print_t)(FILE *f, uint32_t level, const char *fmt, va_list 
ap);
+static int log_print(FILE *f, uint32_t level, const char *format, va_list ap);
+
 /** The rte_log structure. */
 static struct rte_logs {
uint32_t type;  /**< Bitfield with enabled logs. */
uint32_t level; /**< Log level. */
FILE *file; /**< Output file set by rte_openlog_stream, or NULL. */
+   log_print_t print_func;
size_t dynamic_types_len;
struct rte_log_dynamic_type *dynamic_types;
 } rte_logs = {
.type = UINT32_MAX,
.level = RTE_LOG_DEBUG,
+   .print_func = log_print,
 };
 
 struct rte_eal_opt_loglevel {
@@ -78,6 +83,7 @@ rte_openlog_stream(FILE *f)
fclose(rte_logs.file);
 
rte_logs.file = f;
+   rte_logs.print_func = log_print;
return 0;
 }
 
@@ -484,7 +490,7 @@ rte_vlog(uint32_t level, uint32_t logtype, const char 
*format, va_list ap)
RTE_PER_LCORE(log_cur_msg).loglevel = level;
RTE_PER_LCORE(log_cur_msg).logtype = logtype;
 
-   ret = vfprintf(f, format, ap);
+   ret = (*rte_logs.print_func)(f, level, format, ap);
fflush(f);
return ret;
 }
@@ -513,6 +519,15 @@ eal_log_syslog(const char *mode __rte_unused)
return -1;
 }
 
+/* default log print function */
+__rte_format_printf(3, 0)
+static int
+log_print(FILE *f, uint32_t level __rte_unused,
+ const char *format, va_list ap)
+{
+   return vfprintf(f, format, ap);
+}
+
 /*
  * Called by rte_eal_init
  */
-- 
2.43.0

[PATCH v15 12/15] log: add timestamp option

[Stephen Hemminger]

When debugging driver or startup issues, it is useful to have
a timestamp on each message printed. The messages in syslog
already have a timestamp, but often syslog is not available
during testing.

There are multiple timestamp formats similar to Linux dmesg.
The default is time relative since startup (when first
step of logging initialization is done by constructor).
Other alternative formats are delta, ctime, reltime and iso formats.

Example:
$ dpdk-testpmd --log-timestamp -- -i
[ 0.008610] EAL: Detected CPU lcores: 8
[ 0.008634] EAL: Detected NUMA nodes: 1
[ 0.008792] EAL: Detected static linkage of DPDK
[ 0.010620] EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
[ 0.012618] EAL: Selected IOVA mode 'VA'
[ 0.016675] testpmd: No probed ethernet devices
Interactive-mode selected

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  26 
 doc/guides/prog_guide/log_lib.rst   |  26 
 lib/eal/common/eal_common_options.c |  14 ++-
 lib/eal/common/eal_options.h|   2 +
 lib/eal/freebsd/eal.c   |   6 +-
 lib/eal/linux/eal.c |   4 +-
 lib/eal/windows/eal.c   |   4 +-
 lib/log/log.c   | 183 +++-
 lib/log/log_internal.h  |   9 ++
 lib/log/version.map |   1 +
 10 files changed, 268 insertions(+), 7 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 36e3185a10..e54f6e8b7f 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1054,6 +1054,19 @@ test_misc_flags(void)
const char * const argv22[] = {prgname, prefix, mp_flag,
   "--huge-worker-stack=512"};
 
+   /* Try running with --log-timestamp */
+   const char * const argv23[] = {prgname, prefix, mp_flag,
+  "--log-timestamp" };
+
+   /* Try running with --log-timestamp=iso */
+   const char * const argv24[] = {prgname, prefix, mp_flag,
+  "--log-timestamp=iso" };
+
+   /* Try running with invalid timestamp */
+   const char * const argv25[] = {prgname, prefix, mp_flag,
+  "--log-timestamp=invalid" };
+
+
/* run all tests also applicable to FreeBSD first */
 
if (launch_proc(argv0) == 0) {
@@ -1161,6 +1174,19 @@ test_misc_flags(void)
printf("Error - process did not run ok with 
--huge-worker-stack=size parameter\n");
goto fail;
}
+   if (launch_proc(argv23) != 0) {
+   printf("Error - process did not run ok with --log-timestamp 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv24) != 0) {
+   printf("Error - process did not run ok with --log-timestamp=iso 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv25) == 0) {
+   printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
+   goto fail;
+   }
+
 
rmdir(hugepath_dir3);
rmdir(hugepath_dir2);
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index ff9d1b54a2..504eefe1d2 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -59,6 +59,32 @@ For example::
 
 Within an application, the same result can be got using the 
``rte_log_set_level_pattern()`` or ``rte_log_set_level_regex()`` APIs.
 
+Log timestamp
+~
+
+An optional timestamp can be added before each message
+by adding the ``--log-timestamp`` option.
+For example::
+
+   /path/to/app --log-level=lib.*:debug --log-timestamp
+
+Multiple timestamp alternative timestamp formats are available:
+
+.. csv-table:: Log time stamp format
+   :header: "Format", "Description", "Example"
+   :widths: 6, 30, 32
+
+   "ctime", "Unix ctime", "``[Wed Mar 20 07:26:12 2024]``"
+   "delta", "Offset since last", "``[<3.162373>]``"
+   "reltime", "Seconds since last or time if minute changed", "``[  
+3.001791]`` or ``[Mar20 07:26:12]``"
+   "iso", "ISO-8601", "``[2024-03-20T07:26:12−07:00]``"
+
+To prefix all console messages with ISO format time the syntax is::
+
+   /path/to/app --log-timestamp=iso
+
+
+
 Using Logging APIs to Generate Log Messages
 ---
 
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 9ab512e8a1..5173835c2c 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -74,6 +74,7 @@ eal_long_options[] = {
{OPT_IOVA_MODE, 1, NULL, OPT_IOVA_MODE_NUM},
{OPT_LCORES,1, NULL, OPT_LCORES_NUM   },
{OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM},
+   {OPT_LOG_TIMESTAMP, 2, NULL, OPT_LOG_TIMESTAMP_NUM},
{OPT_TRACE, 1, NULL, OPT_TRACE_NUM

[PATCH v15 13/15] log: add optional support of syslog

[Stephen Hemminger]

Log to syslog only if option is specified. And if syslog is used
then normally only log to syslog, don't duplicate output.
Also enables syslog support on FreeBSD.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c |   5 +-
 doc/guides/linux_gsg/linux_eal_parameters.rst |  27 
 doc/guides/prog_guide/log_lib.rst |  17 +++
 lib/eal/common/eal_common_options.c   |   5 +-
 lib/log/log.c | 121 --
 5 files changed, 137 insertions(+), 38 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index e54f6e8b7f..08f4866461 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -987,9 +987,10 @@ test_misc_flags(void)
/* With empty --syslog */
const char *argv3[] = {prgname, prefix, mp_flag, "--syslog"};
/* With valid --syslog */
-   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog", "always"};
+   const char *argv4[] = {prgname, prefix, mp_flag, "--syslog=both"};
/* With invalid --syslog */
-   const char *argv5[] = {prgname, prefix, mp_flag, "--syslog", "error"};
+   const char *argv5[] = {prgname, prefix, mp_flag, "--syslog=invalid"};
+
/* With no-sh-conf, also use no-huge to ensure this test runs on BSD */
const char *argv6[] = {prgname, "-m", DEFAULT_MEM_SIZE,
no_shconf, nosh_prefix, no_huge};
diff --git a/doc/guides/linux_gsg/linux_eal_parameters.rst 
b/doc/guides/linux_gsg/linux_eal_parameters.rst
index ea8f381391..d86f94d8a8 100644
--- a/doc/guides/linux_gsg/linux_eal_parameters.rst
+++ b/doc/guides/linux_gsg/linux_eal_parameters.rst
@@ -108,30 +108,3 @@ Memory-related options
 *   ``--match-allocations``
 
 Free hugepages back to system exactly as they were originally allocated.
-
-Other options
-~
-
-*   ``--syslog ``
-
-Set syslog facility. Valid syslog facilities are::
-
-auth
-cron
-daemon
-ftp
-kern
-lpr
-mail
-news
-syslog
-user
-uucp
-local0
-local1
-local2
-local3
-local4
-local5
-local6
-local7
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index 504eefe1d2..abaedc7212 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -83,6 +83,23 @@ To prefix all console messages with ISO format time the 
syntax is::
 
/path/to/app --log-timestamp=iso
 
+Log output
+~~
+
+If desired, messages can be redirected to syslog (on Linux and FreeBSD) with 
the ``--syslog``
+option. There are three possible settings for this option:
+
+*always*
+Redirect all log output to syslog.
+
+*auto*
+Use console if it is a terminal, and use syslog if is not.
+
+*both*
+Print to both console and syslog.
+
+If ``--syslog`` option is not specified, then only console (stderr) will be 
used.
+
 
 
 Using Logging APIs to Generate Log Messages
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 5173835c2c..9ca7db04aa 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -91,7 +91,7 @@ eal_long_options[] = {
{OPT_PROC_TYPE, 1, NULL, OPT_PROC_TYPE_NUM},
{OPT_SOCKET_MEM,1, NULL, OPT_SOCKET_MEM_NUM   },
{OPT_SOCKET_LIMIT,  1, NULL, OPT_SOCKET_LIMIT_NUM },
-   {OPT_SYSLOG,1, NULL, OPT_SYSLOG_NUM   },
+   {OPT_SYSLOG,2, NULL, OPT_SYSLOG_NUM   },
{OPT_VDEV,  1, NULL, OPT_VDEV_NUM },
{OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM},
{OPT_VFIO_VF_TOKEN, 1, NULL, OPT_VFIO_VF_TOKEN_NUM},
@@ -2221,6 +2221,9 @@ eal_common_usage(void)
   "  (can be used multiple times)\n"
   "  --"OPT_VMWARE_TSC_MAP"Use VMware TSC map instead of 
native RDTSC\n"
   "  --"OPT_PROC_TYPE" Type of this process 
(primary|secondary|auto)\n"
+#ifndef RTE_EXEC_ENV_WINDOWS
+  "  --"OPT_SYSLOG"[=]   Enable use of syslog\n"
+#endif
   "  --"OPT_LOG_LEVEL"= Set global log level\n"
   "  --"OPT_LOG_LEVEL"=:\n"
   "  Set specific log level\n"
diff --git a/lib/log/log.c b/lib/log/log.c
index 2dca91306e..ec0d55273e 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -13,15 +13,17 @@
 #include 
 #include 
 
+#ifdef RTE_EXEC_ENV_WINDOWS
+#include 
+#else
+#include 
+#endif
+
 #include 
 #include 
 
 #include "log_internal.h"
 
-#ifdef RTE_EXEC_ENV_WINDOWS
-#include 
-#endif
-
 struct rte_log_dynamic_type {
const char *name;
uint32_t loglevel;
@@ -36,14 +38,25 @@ enum eal_log_time_format {
EAL_LOG_TIMESTAMP_ISO,
 };
 
+enum eal_log_syslog {
+   EAL_LOG_SYSLOG_NONE

[PATCH v15 14/15] log: add support for systemd journal

[Stephen Hemminger]

If DPDK application is being run as a systemd service, then
it can use the journal protocol which allows putting more information
in the log such as priority and other information.

The use of journal protocol is automatically detected and
handled.  Rather than having a dependency on libsystemd,
just use the protocol directly as defined in:
https://systemd.io/JOURNAL_NATIVE_PROTOCOL/

Signed-off-by: Stephen Hemminger 
---
 lib/log/log.c | 154 +-
 1 file changed, 152 insertions(+), 2 deletions(-)

diff --git a/lib/log/log.c b/lib/log/log.c
index ec0d55273e..650d294120 100644
--- a/lib/log/log.c
+++ b/lib/log/log.c
@@ -17,6 +17,10 @@
 #include 
 #else
 #include 
+#include 
+#include 
+#include 
+#include 
 #endif
 
 #include 
@@ -56,6 +60,7 @@ static struct rte_logs {
FILE *file; /**< Output file set by rte_openlog_stream, or NULL. */
 #ifndef RTE_EXEC_ENV_WINDOWS
enum eal_log_syslog syslog_opt;
+   int journal_fd;
 #endif
log_print_t print_func;
 
@@ -775,6 +780,138 @@ static cookie_io_functions_t syslog_log_func = {
.close = syslog_log_close,
 };
 
+/*
+ * send message using journal protocol to journald
+ */
+static int
+journal_send(uint32_t level, const char *buf, size_t len)
+{
+   struct iovec iov[3];
+   char msg[] = "MESSAGE=";
+   char prio[32];
+   int ret;
+
+   iov[0].iov_base = msg;
+   iov[0].iov_len = strlen(msg);
+
+   iov[1].iov_base = (char *)(uintptr_t)buf;
+   iov[1].iov_len = len;
+
+   /* priority value between 0 ("emerg") and 7 ("debug") */
+   iov[2].iov_base = prio;
+   iov[2].iov_len = snprintf(prio, sizeof(prio),
+ "PRIORITY=%i\n", level - 1);
+
+   ret = writev(rte_logs.journal_fd, iov, 3);
+   return ret;
+}
+
+__rte_format_printf(3, 0)
+static int
+journal_print(FILE *f __rte_unused, uint32_t level, const char *format, 
va_list ap)
+{
+   char buf[BUFSIZ];
+   size_t len;
+
+   len = vsnprintf(buf, sizeof(buf), format, ap);
+   if (len == 0)
+   return 0;
+
+   /* check for truncation */
+   if (len >= sizeof(buf) - 1)
+   len = sizeof(buf) - 1;
+
+   /* check that message ends with newline, if not add one */
+   if (buf[len - 1] != '\n')
+   buf[len++] = '\n';
+
+   return journal_send(level, buf, len);
+}
+
+/* wrapper for log stream to put messages into journal */
+static ssize_t
+journal_log_write(__rte_unused void *c, const char *buf, size_t size)
+{
+   return journal_send(rte_log_cur_msg_loglevel(), buf, size);
+}
+
+static cookie_io_functions_t journal_log_func = {
+   .write = journal_log_write,
+};
+
+/*
+ * Check if stderr is going to system journal.
+ * This is the documented way to handle systemd journal
+ *
+ * See: https://systemd.io/JOURNAL_NATIVE_PROTOCOL/
+ *
+ */
+static bool
+is_journal(int fd)
+{
+   char *jenv, *endp = NULL;
+   struct stat st;
+   unsigned long dev, ino;
+
+   jenv = getenv("JOURNAL_STREAM");
+   if (jenv == NULL)
+   return false;
+
+   if (fstat(fd, &st) < 0)
+   return false;
+
+   /* systemd sets colon-separated list of device and inode number */
+   dev = strtoul(jenv, &endp, 10);
+   if (endp == NULL || *endp != ':')
+   return false;   /* missing colon */
+
+   ino = strtoul(endp + 1, NULL, 10);
+
+   return dev == st.st_dev && ino == st.st_ino;
+}
+
+/* Connect to systemd's journal service */
+static int
+open_journal(const char *id)
+{
+   char *syslog_id = NULL;
+   struct sockaddr_un sun = {
+   .sun_family = AF_UNIX,
+   .sun_path = "/run/systemd/journal/socket",
+   };
+   ssize_t len;
+   int s;
+
+   s = socket(AF_UNIX, SOCK_DGRAM, 0);
+   if (s < 0)
+   return -1;
+
+   if (connect(s, (struct sockaddr *)&sun, sizeof(sun)) < 0)
+   goto error;
+
+   /* Send syslog identifier as first message */
+   len = asprintf(&syslog_id, "SYSLOG_IDENTIFIER=%s\n", id);
+   if (len == 0)
+   goto error;
+
+   if (write(s, syslog_id, len) != len)
+   goto error;
+
+   free(syslog_id);
+
+   /* redirect other log messages to journal */
+   FILE *log_stream = fopencookie(NULL, "w", journal_log_func);
+   if (log_stream != NULL)
+   default_log_stream = log_stream;
+
+   return s;
+
+error:
+   free(syslog_id);
+   close(s);
+   return -1;
+}
+
 static void
 log_open_syslog(const char *id, bool is_terminal)
 {
@@ -797,11 +934,24 @@ log_open_syslog(const char *id, bool is_terminal)
 static void
 log_output_selection(const char *id)
 {
+#ifdef RTE_EXEC_ENV_WINDOWS
RTE_SET_USED(id);
-
-#ifndef RTE_EXEC_ENV_WINDOWS
+#else
bool is_terminal = isatty(STDERR_FILENO);
 
+   /* If stderr is redirected to systemd journal then upgrade */
+  

[PATCH v15 15/15] log: colorize log output

[Stephen Hemminger]

Like dmesg, colorize the log output (unless redirected to file).
Timestamp is green, the subsystem is in yellow and the message
is red if urgent, boldface if an error, and normal for info and
debug messages.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_eal_flags.c   |  24 
 doc/guides/prog_guide/log_lib.rst   |  16 ++-
 lib/eal/common/eal_common_options.c |  11 ++
 lib/eal/common/eal_options.h|   2 +
 lib/log/log.c   | 164 +++-
 lib/log/log_internal.h  |   5 +
 lib/log/version.map |   1 +
 7 files changed, 218 insertions(+), 5 deletions(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 08f4866461..c6c05e2e1d 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1067,6 +1067,18 @@ test_misc_flags(void)
const char * const argv25[] = {prgname, prefix, mp_flag,
   "--log-timestamp=invalid" };
 
+   /* Try running with --log-color */
+   const char * const argv26[] = {prgname, prefix, mp_flag,
+  "--log-color" };
+
+   /* Try running with --log-color=never */
+   const char * const argv27[] = {prgname, prefix, mp_flag,
+  "--log-color=never" };
+
+   /* Try running with --log-color=invalid */
+   const char * const argv28[] = {prgname, prefix, mp_flag,
+  "--log-color=invalid" };
+
 
/* run all tests also applicable to FreeBSD first */
 
@@ -1187,6 +1199,18 @@ test_misc_flags(void)
printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
goto fail;
}
+   if (launch_proc(argv26) != 0) {
+   printf("Error - process did not run ok with --log-color 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv27) != 0) {
+   printf("Error - process did not run ok with --log-color=none 
parameter\n");
+   goto fail;
+   }
+   if (launch_proc(argv28) == 0) {
+   printf("Error - process did run ok with --log-timestamp=invalid 
parameter\n");
+   goto fail;
+   }
 
 
rmdir(hugepath_dir3);
diff --git a/doc/guides/prog_guide/log_lib.rst 
b/doc/guides/prog_guide/log_lib.rst
index abaedc7212..40727ebaae 100644
--- a/doc/guides/prog_guide/log_lib.rst
+++ b/doc/guides/prog_guide/log_lib.rst
@@ -59,6 +59,21 @@ For example::
 
 Within an application, the same result can be got using the 
``rte_log_set_level_pattern()`` or ``rte_log_set_level_regex()`` APIs.
 
+Color output
+
+
+The log library will highlight important messages.
+This is controlled by the ``--log-color`` option.
+he optional argument ``when`` can be ``auto``, ``never``, or ``always``.
+The default setting is ``auto`` which enables color when the output to
+``stderr`` is a terminal.
+If the ``when`` argument is omitted, it defaults to ``always``.
+
+For example to turn off all coloring::
+
+   /path/to/app --log-color=none
+
+
 Log timestamp
 ~
 
@@ -101,7 +116,6 @@ option. There are three possible settings for this option:
 If ``--syslog`` option is not specified, then only console (stderr) will be 
used.
 
 
-
 Using Logging APIs to Generate Log Messages
 ---
 
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index 9ca7db04aa..5e7ab29ae3 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -75,6 +75,7 @@ eal_long_options[] = {
{OPT_LCORES,1, NULL, OPT_LCORES_NUM   },
{OPT_LOG_LEVEL, 1, NULL, OPT_LOG_LEVEL_NUM},
{OPT_LOG_TIMESTAMP, 2, NULL, OPT_LOG_TIMESTAMP_NUM},
+   {OPT_LOG_COLOR, 2, NULL, OPT_LOG_COLOR_NUM},
{OPT_TRACE, 1, NULL, OPT_TRACE_NUM},
{OPT_TRACE_DIR, 1, NULL, OPT_TRACE_DIR_NUM},
{OPT_TRACE_BUF_SIZE,1, NULL, OPT_TRACE_BUF_SIZE_NUM   },
@@ -1618,6 +1619,7 @@ eal_log_level_parse(int argc, char * const argv[])
case OPT_LOG_LEVEL_NUM:
case OPT_SYSLOG_NUM:
case OPT_LOG_TIMESTAMP_NUM:
+   case OPT_LOG_COLOR_NUM:
if (eal_parse_common_option(opt, optarg, internal_conf) 
< 0)
return -1;
break;
@@ -1862,6 +1864,14 @@ eal_parse_common_option(int opt, const char *optarg,
}
break;
 
+   case OPT_LOG_COLOR_NUM:
+   if (eal_log_color(optarg) < 0) {
+   EAL_LOG(ERR, "invalid parameters for --"
+   OPT_LOG_COLOR);
+   return -1;
+   }
+   break;
+
 #ifndef RTE_EXEC_ENV_WINDOWS
case OPT_TRACE_NUM

RE: [EXTERNAL] [PATCH v2] graph: avoid id collisions

[Kiran Kumar Kokkilagadda]

> -Original Message-
> From: Robin Jarry 
> Sent: Tuesday, March 26, 2024 9:20 PM
> To: dev@dpdk.org; Jerin Jacob ; Kiran Kumar
> Kokkilagadda ; Nithin Kumar Dabilpuram
> ; Zhirun Yan 
> Subject: [EXTERNAL] [PATCH v2] graph: avoid id collisions
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> --
> The graph id is determined based on a global variable that is incremented
> every time a graph is created, and decremented every time a graph is
> destroyed. This only works if graphs are destroyed in the reverse order in
> which they have been created.
> 
> The following code produces duplicate graph IDs which can lead to use-after-
> free bugs and other undefined behaviours:
> 
>   a = rte_graph_create(...); // id=0 graph_id=1
>   b = rte_graph_create(...); // id=1 graph_id=2
>   rte_graph_destroy(a);  // graph_id=1
>   c = rte_graph_create(...); // id=1 graph_id=2 (duplicate with b)
>   rte_graph_destroy(c);  // frees memory still used by b
> 
> Remove the global counter. Make sure that the graph list is always ordered by
> increasing graph ids. When creating a new graph, pick a free id which is not
> allocated.
> 
> Update unit tests to ensure it works as expected.
> 
> Signed-off-by: Robin Jarry 
> ---

Acked-by: Kiran Kumar Kokkilagadda 

> 
> Notes:
> v2: Added unit test
> 
>  app/test/test_graph.c | 63 +++
>  lib/graph/graph.c | 86 ++-
>  2 files changed, 132 insertions(+), 17 deletions(-)
> 
> diff --git a/app/test/test_graph.c b/app/test/test_graph.c index
> b8409bc60497..c650ac4f57b7 100644
> --- a/app/test/test_graph.c
> +++ b/app/test/test_graph.c
> @@ -696,6 +696,68 @@ test_graph_clone(void)
>   return ret;
>  }
> 
> +static int
> +test_graph_id_collisions(void)
> +{
> + static const char *node_patterns[] = {"test_node_source1",
> "test_node00"};
> + struct rte_graph_param gconf = {
> + .socket_id = SOCKET_ID_ANY,
> + .nb_node_patterns = 2,
> + .node_patterns = node_patterns,
> + };
> + rte_graph_t g1, g2, g3;
> +
> + g1 = rte_graph_create("worker1", &gconf);
> + if (g1 == RTE_GRAPH_ID_INVALID) {
> + printf("Graph 1 creation failed with error = %d\n", rte_errno);
> + return -1;
> + }
> + g2 = rte_graph_create("worker2", &gconf);
> + if (g2 == RTE_GRAPH_ID_INVALID) {
> + printf("Graph 2 creation failed with error = %d\n", rte_errno);
> + return -1;
> + }
> + if (g1 == g2) {
> + printf("Graph ids should be different\n");
> + return -1;
> + }
> + if (rte_graph_destroy(g1) < 0) {
> + printf("Graph 1 suppression failed\n");
> + return -1;
> + }
> + g3 = rte_graph_create("worker3", &gconf);
> + if (g3 == RTE_GRAPH_ID_INVALID) {
> + printf("Graph 3 creation failed with error = %d\n", rte_errno);
> + return -1;
> + }
> + if (g3 == g2) {
> + printf("Graph ids should be different\n");
> + return -1;
> + }
> + g1 = rte_graph_clone(g2, "worker1", &gconf);
> + if (g1 == RTE_GRAPH_ID_INVALID) {
> + printf("Graph 2 clone failed with error = %d\n", rte_errno);
> + return -1;
> + }
> + if (g1 == g2 || g2 == g3 || g1 == g3) {
> + printf("Graph ids should be different\n");
> + return -1;
> + }
> + if (rte_graph_destroy(g1) < 0) {
> + printf("Graph 1 suppression failed\n");
> + return -1;
> + }
> + if (rte_graph_destroy(g2) < 0) {
> + printf("Graph 2 suppression failed\n");
> + return -1;
> + }
> + if (rte_graph_destroy(g3) < 0) {
> + printf("Graph 3 suppression failed\n");
> + return -1;
> + }
> + return 0;
> +}
> +
>  static int
>  test_graph_model_mcore_dispatch_node_lcore_affinity_set(void)
>  {
> @@ -977,6 +1039,7 @@ static struct unit_test_suite graph_testsuite = {
>   TEST_CASE(test_lookup_functions),
>   TEST_CASE(test_create_graph),
>   TEST_CASE(test_graph_clone),
> + TEST_CASE(test_graph_id_collisions),
> 
>   TEST_CASE(test_graph_model_mcore_dispatch_node_lcore_affinity_s
> et),
> 
>   TEST_CASE(test_graph_model_mcore_dispatch_core_bind_unbind),
>   TEST_CASE(test_graph_worker_model_set_get),
> diff --git a/lib/graph/graph.c b/lib/graph/graph.c index
> 147bc6c685c5..50616580d06b 100644
> --- a/lib/graph/graph.c
> +++ b/lib/graph/graph.c
> @@ -19,11 +19,54 @@
> 
>  static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list);
>  static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER; -static
> rte_graph_t graph_id;
> -
> -#define GRAPH_ID_CHECK(id) ID_CHECK(id, g

[PATCH v1] net/i40e: updated 24.03 recommended matching list

[hailinx]

Signed-off-by: hailinx 
---
 doc/guides/nics/i40e.rst | 4 
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 38eab76539..ca6caa0cff 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -104,6 +104,8 @@ For X710/XL710/XXV710,
+--+---+--+
| DPDK version | Kernel driver version | Firmware version |
+==+===+==+
+   |24.03 | 2.24.6|   9.40   |
+   +--+---+--+
|23.11 | 2.23.17   |   9.30   |
+--+---+--+
|23.07 | 2.22.20   |   9.20   |
@@ -169,6 +171,8 @@ For X722,
+--+---+--+
| DPDK version | Kernel driver version | Firmware version |
+==+===+==+
+   |24.03 | 2.24.6|   6.20   |
+   +--+---+--+
|23.11 | 2.23.17   |   6.20   |
+--+---+--+
|23.07 | 2.22.20   |   6.20   |
-- 
2.25.1

[PATCH v1] net/ice: updated 24.03 recommended matching list

[hailinx]

Signed-off-by: hailinx 
---
 doc/guides/nics/ice.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst
index 3aeb3a32a4..3deeea9e6c 100644
--- a/doc/guides/nics/ice.rst
+++ b/doc/guides/nics/ice.rst
@@ -77,6 +77,8 @@ are listed in the Tested Platforms section of the Release 
Notes for each release

+---+---+-+---+--+---+
|23.11  | 1.13.7|  1.3.36 |  1.3.46   |1.3.14|  
  4.4|

+---+---+-+---+--+---+
+   |24.03  | 1.13.7|  1.3.35 |  1.3.45   |1.3.13|  
  4.4|
+   
+---+---+-+---+--+---+
 
 Configuration
 -
-- 
2.25.1