[PATCH] event/dsw: optimize serving port logic
To reduce flow migration overhead, replace the array-based
representation of which set of ports are bound to a particular queue
by a bitmask-based one.
The maximum number of DSW event ports remains 64, but after this
change can no longer easily be increased by modifying DSW_MAX_PORTS
and recompile.
Signed-off-by: Mattias Rönnblom
---
drivers/event/dsw/dsw_evdev.c | 39 +--
drivers/event/dsw/dsw_evdev.h | 5 -
drivers/event/dsw/dsw_event.c | 10 +++--
3 files changed, 31 insertions(+), 23 deletions(-)
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 1209e73a9d..629c929cb2 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -144,24 +144,23 @@ dsw_queue_release(struct rte_eventdev *dev __rte_unused,
static void
queue_add_port(struct dsw_queue *queue, uint16_t port_id)
{
- queue->serving_ports[queue->num_serving_ports] = port_id;
+ uint64_t port_mask = UINT64_C(1) << port_id;
+
+ queue->serving_ports |= port_mask;
queue->num_serving_ports++;
}
static bool
queue_remove_port(struct dsw_queue *queue, uint16_t port_id)
{
- uint16_t i;
+ uint64_t port_mask = UINT64_C(1) << port_id;
+
+ if (queue->serving_ports & port_mask) {
+ queue->num_serving_ports--;
+ queue->serving_ports ^= port_mask;
+ return true;
+ }
- for (i = 0; i < queue->num_serving_ports; i++)
- if (queue->serving_ports[i] == port_id) {
- uint16_t last_idx = queue->num_serving_ports - 1;
- if (i != last_idx)
- queue->serving_ports[i] =
- queue->serving_ports[last_idx];
- queue->num_serving_ports--;
- return true;
- }
return false;
}
@@ -256,10 +255,20 @@ initial_flow_to_port_assignment(struct dsw_evdev *dsw)
struct dsw_queue *queue = &dsw->queues[queue_id];
uint16_t flow_hash;
for (flow_hash = 0; flow_hash < DSW_MAX_FLOWS; flow_hash++) {
- uint8_t port_idx =
- rte_rand() % queue->num_serving_ports;
- uint8_t port_id =
- queue->serving_ports[port_idx];
+ uint8_t skip =
+ rte_rand_max(queue->num_serving_ports);
+ uint8_t port_id;
+
+ for (port_id = 0;; port_id++) {
+ uint64_t port_mask = UINT64_C(1) << port_id;
+
+ if (queue->serving_ports & port_mask) {
+ if (skip == 0)
+ break;
+ skip--;
+ }
+ }
+
dsw->queues[queue_id].flow_to_port_map[flow_hash] =
port_id;
}
diff --git a/drivers/event/dsw/dsw_evdev.h b/drivers/event/dsw/dsw_evdev.h
index 6416a8a898..8166340e1e 100644
--- a/drivers/event/dsw/dsw_evdev.h
+++ b/drivers/event/dsw/dsw_evdev.h
@@ -234,12 +234,15 @@ struct dsw_port {
struct dsw_queue {
uint8_t schedule_type;
- uint8_t serving_ports[DSW_MAX_PORTS];
+ uint64_t serving_ports;
uint16_t num_serving_ports;
uint8_t flow_to_port_map[DSW_MAX_FLOWS] __rte_cache_aligned;
};
+/* Limited by the size of the 'serving_ports' bitmask */
+static_assert(DSW_MAX_PORTS <= 64);
+
struct dsw_evdev {
struct rte_eventdev_data *data;
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index 93bbeead2e..23488d9030 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -447,13 +447,9 @@ static bool
dsw_is_serving_port(struct dsw_evdev *dsw, uint8_t port_id, uint8_t queue_id)
{
struct dsw_queue *queue = &dsw->queues[queue_id];
- uint16_t i;
-
- for (i = 0; i < queue->num_serving_ports; i++)
- if (queue->serving_ports[i] == port_id)
- return true;
+ uint64_t port_mask = UINT64_C(1) << port_id;
- return false;
+ return queue->serving_ports & port_mask;
}
static bool
@@ -575,7 +571,7 @@ dsw_schedule(struct dsw_evdev *dsw, uint8_t queue_id,
uint16_t flow_hash)
/* A single-link queue, or atomic/ordered/parallel but
* with just a single serving port.
*/
- port_id = queue->serving_ports[0];
+ port_id = rte_bsf64(queue->serving_ports);
DSW_LOG_DP(DEBUG, "Event with queue_id %d flow_hash %d is scheduled "
"to port %d.\n", queue_id, flow_hash, port_id);
--
2.34.1
Re: [PATCH v3 0/7] fix race-condition of proactive error handling mode
Kindly ping. On 2023/12/5 10:30, fengchengwen wrote: > Hi Ferruh, > > I notice this patchset was delegated to you, so could you take a view? > > Thanks. > > On 2023/11/6 21:11, Chengwen Feng wrote: >> This patch fixes race-condition of proactive error handling mode, the >> discussion thread [1]. >> >> [1] >> http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ >> >> Chengwen Feng (7): >> ethdev: fix race-condition of proactive error handling mode >> net/hns3: replace fp ops config function >> net/bnxt: fix race-condition when report error recovery >> net/bnxt: use fp ops setup function >> app/testpmd: add error recovery usage demo >> app/testpmd: extract event handling to event.c >> doc: testpmd support event handling section >> >> --- >> v3: >> - adjust the usage of RTE_ETH_EVENT_QUEUE_STATE in 7/7 commit. >> - add ack-by from Konstantin Ananyev, Ajit Khaparde and Huisong Li. >> v2: >> - extract event handling to event.c and document it, which address >> Ferruh's comment. >> - add ack-by from Konstantin Ananyev and Dongdong Liu. >> >> app/test-pmd/event.c | 390 +++ >> app/test-pmd/meson.build | 1 + >> app/test-pmd/parameters.c| 36 +- >> app/test-pmd/testpmd.c | 247 +--- >> app/test-pmd/testpmd.h | 10 +- >> doc/guides/prog_guide/poll_mode_drv.rst | 20 +- >> doc/guides/testpmd_app_ug/event_handling.rst | 81 >> doc/guides/testpmd_app_ug/index.rst | 1 + >> drivers/net/bnxt/bnxt_cpr.c | 18 +- >> drivers/net/bnxt/bnxt_ethdev.c | 9 +- >> drivers/net/hns3/hns3_rxtx.c | 21 +- >> lib/ethdev/ethdev_driver.c | 8 + >> lib/ethdev/ethdev_driver.h | 10 + >> lib/ethdev/rte_ethdev.h | 32 +- >> lib/ethdev/version.map | 1 + >> 15 files changed, 552 insertions(+), 333 deletions(-) >> create mode 100644 app/test-pmd/event.c >> create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst >> > . >
[PATCH 0/8] optimize the firmware loading process
This patch series aims to speedup the DPDK application start by optimize the firmware loading process in sereval places. We also simplify the port name in multiple PF firmware case to make the customer happy. Peng Zhang (8): net/nfp: add the interface for getting the firmware name net/nfp: speed up the firmware loading process net/nfp: optimize loading the firmware process net/nfp: enlarge the range of skipping loading the firmware net/nfp: add the step of clearing the beat time net/nfp: add the elf module net/nfp: reload the firmware only when firmware changed net/nfp: simplify the port name for multiple PFs drivers/net/nfp/meson.build |1 + drivers/net/nfp/nfp_ethdev.c | 264 +-- drivers/net/nfp/nfp_net_common.c | 17 + drivers/net/nfp/nfp_net_common.h |2 + drivers/net/nfp/nfpcore/nfp_elf.c | 1078 + drivers/net/nfp/nfpcore/nfp_elf.h | 13 + drivers/net/nfp/nfpcore/nfp_mip.c | 30 +- drivers/net/nfp/nfpcore/nfp_mip.h | 70 +- 8 files changed, 1388 insertions(+), 87 deletions(-) create mode 100644 drivers/net/nfp/nfpcore/nfp_elf.c create mode 100644 drivers/net/nfp/nfpcore/nfp_elf.h -- 2.39.1
[PATCH 1/8] net/nfp: add the interface for getting the firmware name
From: Peng Zhang
Add the interfce for getting the suitable firmware name.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 79 ++--
1 file changed, 48 insertions(+), 31 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 886b568d96..434d664573 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -954,14 +954,13 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
#define DEFAULT_FW_PATH "/lib/firmware/netronome"
static int
-nfp_fw_upload(struct rte_pci_device *dev,
+nfp_fw_get_name(struct rte_pci_device *dev,
struct nfp_nsp *nsp,
- char *card)
+ char *card,
+ char *fw_name,
+ size_t fw_size)
{
- void *fw_buf;
- size_t fsize;
char serial[40];
- char fw_name[125];
uint16_t interface;
uint32_t cpp_serial_len;
const uint8_t *cpp_serial;
@@ -980,30 +979,43 @@ nfp_fw_upload(struct rte_pci_device *dev,
"serial-%02x-%02x-%02x-%02x-%02x-%02x-%02x-%02x",
cpp_serial[0], cpp_serial[1], cpp_serial[2],
cpp_serial[3],
cpp_serial[4], cpp_serial[5], interface >> 8, interface
& 0xff);
- snprintf(fw_name, sizeof(fw_name), "%s/%s.nffw", DEFAULT_FW_PATH,
serial);
+ snprintf(fw_name, fw_size, "%s/%s.nffw", DEFAULT_FW_PATH, serial);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
- if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0)
- goto load_fw;
+ if (access(fw_name, F_OK) == 0)
+ return 0;
/* Then try the PCI name */
- snprintf(fw_name, sizeof(fw_name), "%s/pci-%s.nffw", DEFAULT_FW_PATH,
+ snprintf(fw_name, fw_size, "%s/pci-%s.nffw", DEFAULT_FW_PATH,
dev->name);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
- if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0)
- goto load_fw;
+ if (access(fw_name, F_OK) == 0)
+ return 0;
/* Finally try the card type and media */
- snprintf(fw_name, sizeof(fw_name), "%s/%s", DEFAULT_FW_PATH, card);
+ snprintf(fw_name, fw_size, "%s/%s", DEFAULT_FW_PATH, card);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
- if (rte_firmware_read(fw_name, &fw_buf, &fsize) == 0)
- goto load_fw;
+ if (access(fw_name, F_OK) == 0)
+ return 0;
- PMD_DRV_LOG(ERR, "Can't find suitable firmware.");
return -ENOENT;
+}
+
+static int
+nfp_fw_upload(struct nfp_nsp *nsp,
+ char *fw_name)
+{
+ int err;
+ void *fw_buf;
+ size_t fsize;
+
+ err = rte_firmware_read(fw_name, &fw_buf, &fsize);
+ if (err != 0) {
+ PMD_DRV_LOG(ERR, "firmware %s not found!", fw_name);
+ return -ENOENT;
+ }
-load_fw:
PMD_DRV_LOG(INFO, "Firmware file found at %s with size: %zu",
fw_name, fsize);
PMD_DRV_LOG(INFO, "Uploading the firmware ...");
@@ -1034,14 +1046,13 @@ nfp_fw_unload(struct nfp_cpp *cpp)
}
static int
-nfp_fw_reload(struct rte_pci_device *dev,
- struct nfp_nsp *nsp,
- char *card_desc)
+nfp_fw_reload(struct nfp_nsp *nsp,
+ char *fw_name)
{
int err;
nfp_nsp_device_soft_reset(nsp);
- err = nfp_fw_upload(dev, nsp, card_desc);
+ err = nfp_fw_upload(nsp, fw_name);
if (err != 0)
PMD_DRV_LOG(ERR, "NFP firmware load failed");
@@ -1049,9 +1060,8 @@ nfp_fw_reload(struct rte_pci_device *dev,
}
static int
-nfp_fw_loaded_check_alive(struct rte_pci_device *dev,
- struct nfp_nsp *nsp,
- char *card_desc,
+nfp_fw_loaded_check_alive(struct nfp_nsp *nsp,
+ char *fw_name,
const struct nfp_dev_info *dev_info,
struct nfp_multi_pf *multi_pf)
{
@@ -1077,13 +1087,12 @@ nfp_fw_loaded_check_alive(struct rte_pci_device *dev,
}
}
- return nfp_fw_reload(dev, nsp, card_desc);
+ return nfp_fw_reload(nsp, fw_name);
}
static int
-nfp_fw_reload_for_multipf(struct rte_pci_device *dev,
- struct nfp_nsp *nsp,
- char *card_desc,
+nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
+ char *fw_name,
struct nfp_cpp *cpp,
const struct nfp_dev_info *dev_info,
struct nfp_multi_pf *multi_pf)
@@ -1095,9 +1104,9 @@ nfp_fw_reload_for_multipf(struct rte_pci_device *dev,
PMD_DRV_LOG(ERR, "NFP write beat failed");
if (nfp_nsp_fw_loaded(nsp))
- err = nfp_fw_loaded_check_alive(dev, nsp, card_desc, dev_info,
multi_pf);
+ err = nfp_fw_loaded_check_alive(nsp, fw_name, dev_info,
multi_pf);
[PATCH 2/8] net/nfp: speed up the firmware loading process
From: Peng Zhang
The previous design spent too much time checking whether
the port was alive, now optimize this process and speed
up the firmware loading process.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 434d664573..e06e6b7f59 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1065,24 +1065,29 @@ nfp_fw_loaded_check_alive(struct nfp_nsp *nsp,
const struct nfp_dev_info *dev_info,
struct nfp_multi_pf *multi_pf)
{
- int offset;
- uint32_t i;
- uint64_t beat;
+ uint8_t i;
+ uint64_t tmp_beat;
uint32_t port_num;
+ uint64_t beat[dev_info->pf_num_per_unit];
+ uint32_t offset[dev_info->pf_num_per_unit];
+
+ for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) {
+ offset[port_num] = NFP_BEAT_OFFSET(port_num);
+ beat[port_num] = nn_readq(multi_pf->beat_addr +
offset[port_num]);
+ }
/*
* If the beats of any other port changed in 3s,
* we should not reload the firmware.
*/
- for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) {
- if (port_num == multi_pf->function_id)
- continue;
-
- offset = NFP_BEAT_OFFSET(port_num);
- beat = nn_readq(multi_pf->beat_addr + offset);
- for (i = 0; i < 3; i++) {
- sleep(1);
- if (nn_readq(multi_pf->beat_addr + offset) != beat)
+ for (i = 0; i < 3; i++) {
+ sleep(1);
+ for (port_num = 0; port_num < dev_info->pf_num_per_unit;
port_num++) {
+ if (port_num == multi_pf->function_id)
+ continue;
+
+ tmp_beat = nn_readq(multi_pf->beat_addr +
offset[port_num]);
+ if (tmp_beat != beat[port_num])
return 0;
}
}
--
2.39.1
[PATCH 3/8] net/nfp: optimize loading the firmware process
From: Peng Zhang
Add the skip loading firmware flag, when any other
port is alive, this flag will be true.
Also make sure the order of starting the keepalive
is earlier than getting the firmware status.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 36 +---
1 file changed, 21 insertions(+), 15 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index e06e6b7f59..e908fc8472 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1059,10 +1059,8 @@ nfp_fw_reload(struct nfp_nsp *nsp,
return err;
}
-static int
-nfp_fw_loaded_check_alive(struct nfp_nsp *nsp,
- char *fw_name,
- const struct nfp_dev_info *dev_info,
+static bool
+nfp_fw_skip_load(const struct nfp_dev_info *dev_info,
struct nfp_multi_pf *multi_pf)
{
uint8_t i;
@@ -1088,11 +1086,11 @@ nfp_fw_loaded_check_alive(struct nfp_nsp *nsp,
tmp_beat = nn_readq(multi_pf->beat_addr +
offset[port_num]);
if (tmp_beat != beat[port_num])
- return 0;
+ return true;
}
}
- return nfp_fw_reload(nsp, fw_name);
+ return false;
}
static int
@@ -1103,17 +1101,11 @@ nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
struct nfp_multi_pf *multi_pf)
{
int err;
+ bool skip_load_fw = false;
err = nfp_net_keepalive_init(cpp, multi_pf);
- if (err != 0)
- PMD_DRV_LOG(ERR, "NFP write beat failed");
-
- if (nfp_nsp_fw_loaded(nsp))
- err = nfp_fw_loaded_check_alive(nsp, fw_name, dev_info,
multi_pf);
- else
- err = nfp_fw_reload(nsp, fw_name);
if (err != 0) {
- nfp_net_keepalive_uninit(multi_pf);
+ PMD_DRV_LOG(ERR, "NFP init beat failed");
return err;
}
@@ -1121,9 +1113,23 @@ nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
if (err != 0) {
nfp_net_keepalive_uninit(multi_pf);
PMD_DRV_LOG(ERR, "NFP write beat failed");
+ return err;
}
- return err;
+ if (nfp_nsp_fw_loaded(nsp))
+ skip_load_fw = nfp_fw_skip_load(dev_info, multi_pf);
+
+ if (skip_load_fw)
+ return 0;
+
+ err = nfp_fw_reload(nsp, fw_name);
+ if (err != 0) {
+ nfp_net_keepalive_stop(multi_pf);
+ nfp_net_keepalive_uninit(multi_pf);
+ return err;
+ }
+
+ return 0;
}
static int
--
2.39.1
[PATCH 4/8] net/nfp: enlarge the range of skipping loading the firmware
From: Peng Zhang
Enlarge the range of skip loading firmware by add the condition
there is no port with the condition of abnormal.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 30 --
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index e908fc8472..25f5fe483f 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1066,28 +1066,46 @@ nfp_fw_skip_load(const struct nfp_dev_info *dev_info,
uint8_t i;
uint64_t tmp_beat;
uint32_t port_num;
+ uint8_t in_use = 0;
uint64_t beat[dev_info->pf_num_per_unit];
uint32_t offset[dev_info->pf_num_per_unit];
+ uint8_t abnormal = dev_info->pf_num_per_unit;
for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) {
offset[port_num] = NFP_BEAT_OFFSET(port_num);
beat[port_num] = nn_readq(multi_pf->beat_addr +
offset[port_num]);
+ if (beat[port_num] == 0)
+ abnormal--;
}
- /*
-* If the beats of any other port changed in 3s,
-* we should not reload the firmware.
-*/
+ if (abnormal == 0)
+ return true;
+
for (i = 0; i < 3; i++) {
sleep(1);
for (port_num = 0; port_num < dev_info->pf_num_per_unit;
port_num++) {
if (port_num == multi_pf->function_id)
continue;
+ if (beat[port_num] == 0)
+ continue;
+
tmp_beat = nn_readq(multi_pf->beat_addr +
offset[port_num]);
- if (tmp_beat != beat[port_num])
- return true;
+ if (tmp_beat != beat[port_num]) {
+ in_use++;
+ abnormal--;
+ beat[port_num] = 0;
+ }
}
+
+ if (abnormal == 0)
+ return true;
+ }
+
+ if (in_use != 0) {
+ PMD_DRV_LOG(WARNING, "Abnormal %u != 0, the nic has port which
is exit abnormally.",
+ abnormal);
+ return true;
}
return false;
--
2.39.1
[PATCH 5/8] net/nfp: add the step of clearing the beat time
From: Peng Zhang
Add the step of clearing the beat time of specific
port when DPDK exit. Add the step of clearing the
beat time of other ports when reload firmware.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 25f5fe483f..46bb09a211 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -470,6 +470,27 @@ nfp_net_keepalive_start(struct nfp_multi_pf *multi_pf)
return 0;
}
+static void
+nfp_net_keepalive_clear(uint8_t *beat_addr,
+ uint8_t function_id)
+{
+ nn_writeq(0, beat_addr + NFP_BEAT_OFFSET(function_id));
+}
+
+static void
+nfp_net_keepalive_clear_others(const struct nfp_dev_info *dev_info,
+ struct nfp_multi_pf *multi_pf)
+{
+ uint8_t port_num;
+
+ for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) {
+ if (port_num == multi_pf->function_id)
+ continue;
+
+ nfp_net_keepalive_clear(multi_pf->beat_addr, port_num);
+ }
+}
+
static void
nfp_net_keepalive_stop(struct nfp_multi_pf *multi_pf)
{
@@ -524,6 +545,7 @@ nfp_pf_uninit(struct nfp_pf_dev *pf_dev)
free(pf_dev->sym_tbl);
if (pf_dev->multi_pf.enabled) {
nfp_net_keepalive_stop(&pf_dev->multi_pf);
+ nfp_net_keepalive_clear(pf_dev->multi_pf.beat_addr,
pf_dev->multi_pf.function_id);
nfp_net_keepalive_uninit(&pf_dev->multi_pf);
}
free(pf_dev->nfp_eth_table);
@@ -1147,6 +1169,8 @@ nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
return err;
}
+ nfp_net_keepalive_clear_others(dev_info, multi_pf);
+
return 0;
}
@@ -1779,6 +1803,7 @@ nfp_pf_init(struct rte_pci_device *pci_dev)
fw_cleanup:
nfp_fw_unload(cpp);
nfp_net_keepalive_stop(&pf_dev->multi_pf);
+ nfp_net_keepalive_clear(pf_dev->multi_pf.beat_addr,
pf_dev->multi_pf.function_id);
nfp_net_keepalive_uninit(&pf_dev->multi_pf);
eth_table_cleanup:
free(nfp_eth_table);
--
2.39.1
[PATCH 6/8] net/nfp: add the elf module
From: Peng Zhang
Add the elf module, which can get mip information from the
firmware ELF file.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/meson.build |1 +
drivers/net/nfp/nfpcore/nfp_elf.c | 1078 +
drivers/net/nfp/nfpcore/nfp_elf.h | 13 +
drivers/net/nfp/nfpcore/nfp_mip.c | 30 +-
drivers/net/nfp/nfpcore/nfp_mip.h | 70 +-
5 files changed, 1167 insertions(+), 25 deletions(-)
create mode 100644 drivers/net/nfp/nfpcore/nfp_elf.c
create mode 100644 drivers/net/nfp/nfpcore/nfp_elf.h
diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build
index 46be6f60cd..a4060b4cd5 100644
--- a/drivers/net/nfp/meson.build
+++ b/drivers/net/nfp/meson.build
@@ -17,6 +17,7 @@ sources = files(
'nfdk/nfp_nfdk_dp.c',
'nfpcore/nfp_cppcore.c',
'nfpcore/nfp_crc.c',
+'nfpcore/nfp_elf.c',
'nfpcore/nfp_hwinfo.c',
'nfpcore/nfp_mip.c',
'nfpcore/nfp_mutex.c',
diff --git a/drivers/net/nfp/nfpcore/nfp_elf.c
b/drivers/net/nfp/nfpcore/nfp_elf.c
new file mode 100644
index 00..2826fcd410
--- /dev/null
+++ b/drivers/net/nfp/nfpcore/nfp_elf.c
@@ -0,0 +1,1078 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Corigine, Inc.
+ * All rights reserved.
+ */
+
+#include "nfp_elf.h"
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+
+#include "nfp_logs.h"
+#include "nfp_mip.h"
+
+/*
+ * NFP Chip Families.
+ *
+ * These are not enums, because they need to be microcode compatible.
+ * They are also not maskable.
+ *
+ * Note: The NFP-4xxx family is handled as NFP-6xxx in most software
+ * components.
+ */
+#define NFP_CHIP_FAMILY_NFP3800 0x3800
+#define NFP_CHIP_FAMILY_NFP6000 0x6000
+
+/* Standard ELF */
+#define NFP_ELF_EI_NIDENT 16
+#define NFP_ELF_EI_MAG0 0
+#define NFP_ELF_EI_MAG1 1
+#define NFP_ELF_EI_MAG2 2
+#define NFP_ELF_EI_MAG3 3
+#define NFP_ELF_EI_CLASS 4
+#define NFP_ELF_EI_DATA 5
+#define NFP_ELF_EI_VERSION6
+#define NFP_ELF_EI_PAD7
+#define NFP_ELF_ELFMAG0 0x7f
+#define NFP_ELF_ELFMAG1 'E'
+#define NFP_ELF_ELFMAG2 'L'
+#define NFP_ELF_ELFMAG3 'F'
+#define NFP_ELF_ELFCLASSNONE 0
+#define NFP_ELF_ELFCLASS321
+#define NFP_ELF_ELFCLASS642
+#define NFP_ELF_ELFDATANONE 0
+#define NFP_ELF_ELFDATA2LSB 1
+#define NFP_ELF_ELFDATA2MSB 2
+
+#define NFP_ELF_ET_NONE 0
+#define NFP_ELF_ET_REL1
+#define NFP_ELF_ET_EXEC 2
+#define NFP_ELF_ET_DYN3
+#define NFP_ELF_ET_CORE 4
+#define NFP_ELF_ET_LOPROC 0xFF00
+#define NFP_ELF_ET_HIPROC 0x
+#define NFP_ELF_ET_NFP_PARTIAL_REL (NFP_ELF_ET_LOPROC + NFP_ELF_ET_REL)
+#define NFP_ELF_ET_NFP_PARTIAL_EXEC (NFP_ELF_ET_LOPROC + NFP_ELF_ET_EXEC)
+
+#define NFP_ELF_EM_NFP250
+#define NFP_ELF_EM_NFP60000x6000
+
+#define NFP_ELF_SHT_NULL 0
+#define NFP_ELF_SHT_PROGBITS 1
+#define NFP_ELF_SHT_SYMTAB2
+#define NFP_ELF_SHT_STRTAB3
+#define NFP_ELF_SHT_RELA 4
+#define NFP_ELF_SHT_HASH 5
+#define NFP_ELF_SHT_DYNAMIC 6
+#define NFP_ELF_SHT_NOTE 7
+#define NFP_ELF_SHT_NOBITS8
+#define NFP_ELF_SHT_REL 9
+#define NFP_ELF_SHT_SHLIB 10
+#define NFP_ELF_SHT_DYNSYM11
+#define NFP_ELF_SHT_LOPROC0x7000
+#define NFP_ELF_SHT_HIPROC0x7fff
+#define NFP_ELF_SHT_LOUSER0x8000
+#define NFP_ELF_SHT_HIUSER0x8fff
+
+#define NFP_ELF_EV_NONE 0
+#define NFP_ELF_EV_CURRENT1
+
+#define NFP_ELF_SHN_UNDEF 0
+
+/* EM_NFP ELF flags */
+
+/*
+ * Valid values for FAMILY are:
+ * 0x6000 - NFP-6xxx/NFP-4xxx
+ * 0x3800 - NFP-38xx
+ */
+#define NFP_ELF_EF_NFP_FAMILY_MASK0x
+#define NFP_ELF_EF_NFP_FAMILY_LSB 8
+
+#define NFP_ELF_SHT_NFP_MECONFIG (NFP_ELF_SHT_LOPROC + 1)
+#define NFP_ELF_SHT_NFP_INITREG (NFP_ELF_SHT_LOPROC + 2)
+#define NFP_ELF_SHT_UOF_DEBUG (NFP_ELF_SHT_LOUSER)
+
+/* NFP target revision note type */
+#define NFP_ELT_NOTE_NAME_NFP "NFP\0"
+#define NFP_ELT_NOTE_NAME_NFP_SZ 4
+#define NFP_ELT_NOTE_NAME_NFP_USER"NFP_USR\0"
+#define NFP_ELT_NOTE_NAME_NFP_USER_SZ 8
+#define NFP_ELF_NT_NFP_BUILD_INFO 0x100
+#define NFP_ELF_NT_NFP_REVS 0x101
+#define NFP_ELF_NT_NFP_MIP_LOCATION 0x102
+#define NFP_ELF_NT_NFP_USER 0xf000
+
+
+/* Standard ELF structures */
+struct nfp_elf_elf64_ehdr {
+ uint8_t e_ident[NFP_ELF_EI_NIDENT];
+ rte_le16_t e_type;
+ rte_le16_t e_machine;
+ rte_le32_t e_version;
+ rte_le64_t e_entry;
+ rte_le64_t e_phoff;
+ rte_le64_t e_shoff;
+ rte_le32_t e_flags;
+ rte_le16_t e_ehsize;
+ rte_le16_t e_phentsize;
+ rte_le16_t e_phnum;
+ rte_le16_t e_shentsize;
+ rte_le16_t e_shnum;
+ rte_le16_t e_shstrndx;
+};
+
+struct nfp_elf_elf64_shdr {
+ rte_le32_t sh_name;
+
[PATCH 7/8] net/nfp: reload the firmware only when firmware changed
From: Peng Zhang
Add the interfaces of getting firmware build time from BSP
and ELF file, only reloading the firmware when the build
time is different, which means the firmware has changed.
This will accelerate the average startup time for both
multi-PF and single-PF firmware.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 86
drivers/net/nfp/nfp_net_common.c | 17 +++
drivers/net/nfp/nfp_net_common.h | 2 +
3 files changed, 94 insertions(+), 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 46bb09a211..22edf11253 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -19,6 +19,7 @@
#include "nfpcore/nfp_nsp.h"
#include "nfpcore/nfp6000_pcie.h"
#include "nfpcore/nfp_resource.h"
+#include "nfpcore/nfp_elf.h"
#include "nfp_cpp_bridge.h"
#include "nfp_ipsec.h"
@@ -1067,6 +1068,36 @@ nfp_fw_unload(struct nfp_cpp *cpp)
nfp_nsp_close(nsp);
}
+/* 0 is firmware not change, 1 is firmware changed, < 0 has error */
+static int
+nfp_fw_check_change(struct nfp_cpp *cpp,
+ char *fw_name,
+ bool *fw_changed)
+{
+ int ret;
+ struct nfp_net_hw hw;
+ uint32_t new_buildtime = 0;
+ uint32_t old_buildtime = 0;
+
+ ret = nfp_elf_get_fw_buildtime(&new_buildtime, fw_name);
+ if (ret < 0)
+ return ret;
+
+ hw.cpp = cpp;
+ nfp_net_get_fw_buildtime(&hw, &old_buildtime);
+ if (new_buildtime != old_buildtime) {
+ PMD_DRV_LOG(INFO, "FW version is changed, new %u, old %u",
+ new_buildtime, old_buildtime);
+ *fw_changed = true;
+ } else {
+ PMD_DRV_LOG(INFO, "FW version is not changed, build_time is
%u.",
+ new_buildtime);
+ *fw_changed = false;
+ }
+
+ return 0;
+}
+
static int
nfp_fw_reload(struct nfp_nsp *nsp,
char *fw_name)
@@ -1132,15 +1163,39 @@ nfp_fw_skip_load(const struct nfp_dev_info *dev_info,
return false;
}
+static int
+nfp_fw_reload_for_single_pf(struct nfp_nsp *nsp,
+ char *fw_name,
+ struct nfp_cpp *cpp)
+{
+ int err;
+ bool fw_changed = true;
+
+ if (nfp_nsp_fw_loaded(nsp)) {
+ err = nfp_fw_check_change(cpp, fw_name, &fw_changed);
+ if (err < 0)
+ return err;
+ }
+
+ if (!fw_changed)
+ return 0;
+
+ err = nfp_fw_reload(nsp, fw_name);
+ if (err < 0)
+ return err;
+
+ return 0;
+}
static int
-nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
+nfp_fw_reload_for_multi_pf(struct nfp_nsp *nsp,
char *fw_name,
struct nfp_cpp *cpp,
const struct nfp_dev_info *dev_info,
struct nfp_multi_pf *multi_pf)
{
int err;
+ bool fw_changed = true;
bool skip_load_fw = false;
err = nfp_net_keepalive_init(cpp, multi_pf);
@@ -1151,27 +1206,36 @@ nfp_fw_reload_for_multipf(struct nfp_nsp *nsp,
err = nfp_net_keepalive_start(multi_pf);
if (err != 0) {
- nfp_net_keepalive_uninit(multi_pf);
PMD_DRV_LOG(ERR, "NFP write beat failed");
- return err;
+ goto keepalive_uninit;
}
- if (nfp_nsp_fw_loaded(nsp))
+ if (nfp_nsp_fw_loaded(nsp)) {
+ err = nfp_fw_check_change(cpp, fw_name, &fw_changed);
+ if (err < 0)
+ goto keepalive_stop;
+ }
+
+ if (!fw_changed)
skip_load_fw = nfp_fw_skip_load(dev_info, multi_pf);
if (skip_load_fw)
return 0;
err = nfp_fw_reload(nsp, fw_name);
- if (err != 0) {
- nfp_net_keepalive_stop(multi_pf);
- nfp_net_keepalive_uninit(multi_pf);
- return err;
- }
+ if (err != 0)
+ goto keepalive_stop;
nfp_net_keepalive_clear_others(dev_info, multi_pf);
return 0;
+
+keepalive_stop:
+ nfp_net_keepalive_stop(multi_pf);
+keepalive_uninit:
+ nfp_net_keepalive_uninit(multi_pf);
+
+ return err;
}
static int
@@ -1228,9 +1292,9 @@ nfp_fw_setup(struct rte_pci_device *dev,
}
if (multi_pf->enabled)
- err = nfp_fw_reload_for_multipf(nsp, fw_name, cpp, dev_info,
multi_pf);
+ err = nfp_fw_reload_for_multi_pf(nsp, fw_name, cpp, dev_info,
multi_pf);
else
- err = nfp_fw_reload(nsp, fw_name);
+ err = nfp_fw_reload_for_single_pf(nsp, fw_name, cpp);
nfp_nsp_close(nsp);
return err;
diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c
index a438eb5871..7b8c175a36 100644
--- a/drivers/net/nfp/nfp_net_common.c
+++ b/driver
[PATCH 8/8] net/nfp: simplify the port name for multiple PFs
From: Peng Zhang
For the firmware which does not support multiple PF feature,
there are multiple PFs corresponding to a single PCI BDF address,
so we have to distinguish them by using a '_port*' postfix for
the device name.
For the firmware which supports multiple PFs feature, there is
only one PF corresponding to a PCI BDF address, so actually we
does not need this postfix anymore, and which is in line with
the mainstream.
Add the corresponding logic to simplify the port name for multiple
PFs case, which will make the user happy.
Signed-off-by: Peng Zhang
Reviewed-by: Chaoyong He
Reviewed-by: Long Wu
---
drivers/net/nfp/nfp_ethdev.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 22edf11253..31b2302db6 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1451,9 +1451,12 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,
/* Loop through all physical ports on PF */
numa_node = rte_socket_id();
for (i = 0; i < app_fw_nic->total_phyports; i++) {
- id = nfp_function_id_get(pf_dev, i);
- snprintf(port_name, sizeof(port_name), "%s_port%u",
- pf_dev->pci_dev->device.name, id);
+ if (pf_dev->multi_pf.enabled)
+ snprintf(port_name, sizeof(port_name), "%s",
+ pf_dev->pci_dev->device.name);
+ else
+ snprintf(port_name, sizeof(port_name), "%s_port%u",
+ pf_dev->pci_dev->device.name, i);
/* Allocate a eth_dev for this phyport */
eth_dev = rte_eth_dev_allocate(port_name);
@@ -1473,6 +1476,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,
}
hw = eth_dev->data->dev_private;
+ id = nfp_function_id_get(pf_dev, i);
/* Add this device to the PF's array of physical ports */
app_fw_nic->ports[id] = hw;
@@ -1902,14 +1906,15 @@ nfp_secondary_init_app_fw_nic(struct nfp_pf_dev *pf_dev)
}
for (i = 0; i < total_vnics; i++) {
- uint32_t id = i;
struct rte_eth_dev *eth_dev;
char port_name[RTE_ETH_NAME_MAX_LEN];
if (nfp_check_multi_pf_from_fw(total_vnics))
- id = function_id;
- snprintf(port_name, sizeof(port_name), "%s_port%u",
- pf_dev->pci_dev->device.name, id);
+ snprintf(port_name, sizeof(port_name), "%s",
+ pf_dev->pci_dev->device.name);
+ else
+ snprintf(port_name, sizeof(port_name), "%s_port%u",
+ pf_dev->pci_dev->device.name, i);
PMD_INIT_LOG(DEBUG, "Secondary attaching to port %s",
port_name);
eth_dev = rte_eth_dev_attach_secondary(port_name);
--
2.39.1
Re: [PATCH v2 00/16] verify strdup return value
Friendly ping. On 2023/11/10 18:01, Chengwen Feng wrote: > This patchset mainly fix the return value of strdup not checked which > may lead to segment fault. It also include two commits which fix memory > leak of strdup. > > Chengwen Feng (16): > eal: verify strdup return value > bus/dpaa: verify strdup return value > bus/fslmc: verify strdup return value > bus/vdev: verify strdup return value > dma/idxd: verify strdup return value > event/cnxk: verify strdup return value > net/failsafe: fix memory leak when parse args > net/nfp: verify strdup return value > app/dumpcap: verify strdup return value > app/pdump: verify strdup return value > app/test: verify strdup return value > app/test-crypto-perf: verify strdup return value > app/test-dma-perf: verify strdup return value > app/testpmd: verify strdup return value > examples/qos_sched: fix memory leak when parse args > examples/vhost: verify strdup return value > > --- > v2: fix 0-day warning of app/dumpcap commit. > > app/dumpcap/main.c | 5 > app/pdump/main.c | 3 +++ > app/test-crypto-perf/cperf_options_parsing.c | 4 > app/test-dma-perf/main.c | 2 ++ > app/test-pmd/cmdline.c | 2 ++ > app/test/process.h | 5 +++- > drivers/bus/dpaa/dpaa_bus.c | 4 > drivers/bus/fslmc/fslmc_bus.c| 4 > drivers/bus/vdev/vdev.c | 4 > drivers/dma/idxd/idxd_bus.c | 10 ++-- > drivers/event/cnxk/cnxk_eventdev.c | 3 +++ > drivers/net/failsafe/failsafe_args.c | 2 +- > drivers/net/nfp/nfp_ipsec.c | 5 > examples/qos_sched/args.c| 4 +++- > examples/vhost/main.c| 3 +++ > lib/eal/common/eal_common_options.c | 24 ++-- > lib/eal/linux/eal_dev.c | 3 +++ > 17 files changed, 80 insertions(+), 7 deletions(-) >
RE: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission fix
> -Original Message-
> From: Anoob Joseph
> Sent: Wednesday, January 10, 2024 10:47 PM
> To: Suanming Mou
> Cc: dev@dpdk.org; sta...@dpdk.org; ciara.po...@intel.com
> Subject: RE: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission fix
>
> Hi Suanming,
>
> Please see inline.
>
> Thanks,
> Anoob
>
> > -Original Message-
> > From: Suanming Mou
> > Sent: Friday, January 5, 2024 12:26 PM
> > To: Anoob Joseph ; ciara.po...@intel.com
> > Cc: dev@dpdk.org; sta...@dpdk.org
> > Subject: [EXT] [PATCH] app/test-crypto-perf: add missed resubmission
> > fix
> >
> > External Email
> >
> > --
> > Currently, after enqueue_burst, there may be ops_unused ops left for
> > next round enqueue. And in next round preparation, only ops_needed ops
> > will be added. But if in the final round the left ops is less than
> > ops_needed, there will be invalid ops between the new needed ops and
> previous unused ops.
> > The previous unused ops should be moved front after the needed ops.
> >
> > In the commit[1], an resubmission fix was added to throughput test,
> > and the fix was missed for verify.
> >
> > This commit adds the missed resubmission fix for verify.
> >
> > [1] 44e2980b70d1 ("app/crypto-perf: fix crypto operation
> > resubmission")
> >
> > Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> > application")
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Suanming Mou
> > ---
> > app/test-crypto-perf/cperf_test_verify.c | 14 +-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-crypto-perf/cperf_test_verify.c
> > b/app/test-crypto- perf/cperf_test_verify.c index
> > 2b0d3f142b..0328bb5724 100644
> > --- a/app/test-crypto-perf/cperf_test_verify.c
> > +++ b/app/test-crypto-perf/cperf_test_verify.c
> > @@ -275,7 +275,6 @@ cperf_verify_test_runner(void *test_ctx)
> > ops_needed, ctx->sess, ctx->options,
> > ctx->test_vector, iv_offset, &imix_idx, NULL);
> >
> > -
> > /* Populate the mbuf with the test vector, for verification */
> > for (i = 0; i < ops_needed; i++)
> > cperf_mbuf_set(ops[i]->sym->m_src,
> > @@ -293,6 +292,19 @@ cperf_verify_test_runner(void *test_ctx)
> > }
> > #endif /* CPERF_LINEARIZATION_ENABLE */
> >
> > + /**
> > +* When ops_needed is smaller than ops_enqd, the
> > +* unused ops need to be moved to the front for
> > +* next round use.
> > +*/
> > + if (unlikely(ops_enqd > ops_needed)) {
> > + size_t nb_b_to_mov = ops_unused * sizeof(
> > + struct rte_crypto_op *);
>
> [Anoob] The alignment is relaxed to 100 chars now. In case you think it
> improve
> code legibility.
>
> Patch looks good either way.
Make sense, it is due to the code was copied directly from previous fix. Will
try to update v2. Thanks.
>
> Acked-by: Anoob Joseph
>
> > +
> > + memmove(&ops[ops_needed], &ops[ops_enqd],
> > + nb_b_to_mov);
> > + }
> > +
> > /* Enqueue burst of ops on crypto device */
> > ops_enqd = rte_cryptodev_enqueue_burst(ctx->dev_id,
> > ctx->qp_id,
> > ops, burst_size);
> > --
> > 2.34.1
RE: 21.11.6 patches review and test
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, December 20, 2023 9:23 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Stokes, Ian ; Jerin Jacob > ; Mcnamara, John ; Ju- > Hyoung Lee ; Kevin Traynor > ; Luca Boccassi ; Pei Zhang > ; qian.q...@intel.com; Raslan Darawsheh > ; Thomas Monjalon ; > yangh...@redhat.com; yuan.p...@intel.com; zhaoyan.c...@intel.com > Subject: 21.11.6 patches review and test > > Hi all, > > Here is a list of patches targeted for stable release 21.11.6. > > The planned date for the final release is 12 January. > > Please help with testing and validation of your use cases and report any > issues/results with reply-all to this mail. For the final release the fixes > and > reported validations will be added to the release notes. > > A release candidate tarball can be found at: > > https://dpdk.org/browse/dpdk-stable/tag/?id=v21.11.6-rc1 > > These patches are located at branch 21.11 of dpdk-stable repo: > https://dpdk.org/browse/dpdk-stable/ > > Thanks. > > Kevin Update the test status for Intel part. completed dpdk21.11.6-rc1 all validation. No critical issue is found. # Basic Intel(R) NIC testing * Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as Ubuntu20.04, Ubuntu22.04, Fedora35, Fedora38, RHEL8.9, RHEL9.2, FreeBSD13.2, SUSE15, CentOS7.9, etc. - All test done. No new dpdk issue is found. * PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. - All test done. No new dpdk issue is found. * VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. - All test done. No new dpdk issue is found. * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc. - All test done. No new dpdk issue is found. * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc. - All test done. No new dpdk issue is found. * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc. - All test done. No new dpdk issue is found. # Basic cryptodev and virtio testing * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc. - All test done. No new dpdk issue is found. * Cryptodev: *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc. - All test done. No new dpdk issue is found. *Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc. - All test done. No new dpdk issue is found. Regards, Xu, Hailin
