[PATCH v6 0/2] net/iavf: fix Rx/Tx burst and add diagnostics
Fixed Rx/Tx crash in multi-process environment and added Tx diagnostic feature. Mingjin Ye (2): net/iavf: fix Rx/Tx burst in multi-process net/iavf: add diagnostic support in TX path doc/guides/nics/intel_vf.rst | 4 + drivers/net/iavf/iavf.h| 54 ++- drivers/net/iavf/iavf_ethdev.c | 68 drivers/net/iavf/iavf_rxtx.c | 282 + drivers/net/iavf/iavf_rxtx.h | 10 ++ 5 files changed, 389 insertions(+), 29 deletions(-) -- 2.25.1
[PATCH v6 1/2] net/iavf: fix Rx/Tx burst in multi-process
In a multi-process environment, a secondary process operates on shared
memory and changes the function pointer of the primary process, resulting
in a crash when the primary process cannot find the function address
during an Rx/Tx burst.
Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down")
Cc: sta...@dpdk.org
Signed-off-by: Mingjin Ye
---
v2: Add fix for Rx burst.
---
drivers/net/iavf/iavf.h | 42 +++-
drivers/net/iavf/iavf_rxtx.c | 184 ++-
drivers/net/iavf/iavf_rxtx.h | 8 ++
3 files changed, 205 insertions(+), 29 deletions(-)
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index 10868f2c30..8db9f3d7cd 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -313,6 +313,44 @@ struct iavf_devargs {
struct iavf_security_ctx;
+enum iavf_rx_burst_type {
+ IAVF_RX_BURST_DEFAULT,
+ IAVF_RX_BURST_FRXD,
+ IAVF_RX_BURST_BULK_ALLOC,
+ IAVF_RX_BURST_SCATTERED,
+ IAVF_RX_BURST_SFRXD,
+ IAVF_RX_BURST_VEC_SSE,
+ IAVF_RX_BURST_VEC_AVX2,
+ IAVF_RX_BURST_VEC_AVX2_OFFLOAD,
+ IAVF_RX_BURST_VEC_SSE_FRXD,
+ IAVF_RX_BURST_VEC_AVX2_FRXD,
+ IAVF_RX_BURST_VEC_AVX2_FRXD_OFFLOAD,
+ IAVF_RX_BURST_VEC_SSE_SCATTERED,
+ IAVF_RX_BURST_VEC_AVX2_SCATTERED,
+ IAVF_RX_BURST_VEC_AVX2_SCATTERED_OFFLOAD,
+ IAVF_RX_BURST_VEC_SSE_SFLEX_RXD,
+ IAVF_RX_BURST_VEC_AVX2_SFLEX_RXD,
+ IAVF_RX_BURST_VEC_AVX2_SFRXD_OFFLOAD,
+ IAVF_RX_BURST_VEC_AVX512,
+ IAVF_RX_BURST_VEC_AVX512_OFFLOAD,
+ IAVF_RX_BURST_VEC_AVX512_FRXD,
+ IAVF_RX_BURST_VEC_AVX512_FRXD_OFFLOAD,
+ IAVF_RX_BURST_VEC_AVX512_SCATTERED,
+ IAVF_RX_BURST_VEC_AVX512_SCATTERED_OFFLOAD,
+ IAVF_RX_BURST_VEC_AVX512_SFLEX_RXD,
+ IAVF_RX_BURST_VEC_AVX512_SFRXD_OFFLOAD,
+};
+
+enum iavf_tx_burst_type {
+ IAVF_TX_BURST_DEFAULT,
+ IAVF_TX_BURST_VEC_SSE,
+ IAVF_TX_BURST_VEC_AVX2,
+ IAVF_TX_BURST_VEC_AVX2_OFFLOAD,
+ IAVF_TX_BURST_VEC_AVX512,
+ IAVF_TX_BURST_VEC_AVX512_OFFLOAD,
+ IAVF_TX_BURST_VEC_AVX512_CTX_OFFLOAD,
+};
+
/* Structure to store private data for each VF instance. */
struct iavf_adapter {
struct iavf_hw hw;
@@ -328,8 +366,8 @@ struct iavf_adapter {
bool stopped;
bool closed;
bool no_poll;
- eth_rx_burst_t rx_pkt_burst;
- eth_tx_burst_t tx_pkt_burst;
+ enum iavf_rx_burst_type rx_burst_type;
+ enum iavf_tx_burst_type tx_burst_type;
uint16_t fdir_ref_cnt;
struct iavf_devargs devargs;
};
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index f19aa14646..152f755206 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -3707,15 +3707,88 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct
rte_mbuf **tx_pkts,
return i;
}
+static const
+struct iavf_rx_burst_ops iavf_rx_pkt_burst_ops[] = {
+ [IAVF_RX_BURST_DEFAULT].rx_pkt_burst = iavf_recv_pkts,
+ [IAVF_RX_BURST_FRXD].rx_pkt_burst = iavf_recv_pkts_flex_rxd,
+ [IAVF_RX_BURST_BULK_ALLOC].rx_pkt_burst = iavf_recv_pkts_bulk_alloc,
+ [IAVF_RX_BURST_SCATTERED].rx_pkt_burst = iavf_recv_scattered_pkts,
+ [IAVF_RX_BURST_SFRXD].rx_pkt_burst =
+ iavf_recv_scattered_pkts_flex_rxd,
+#ifdef RTE_ARCH_X86
+ [IAVF_RX_BURST_VEC_SSE].rx_pkt_burst = iavf_recv_pkts_vec,
+ [IAVF_RX_BURST_VEC_AVX2].rx_pkt_burst = iavf_recv_pkts_vec_avx2,
+ [IAVF_RX_BURST_VEC_AVX2_OFFLOAD].rx_pkt_burst =
+ iavf_recv_pkts_vec_avx2_offload,
+ [IAVF_RX_BURST_VEC_SSE_FRXD].rx_pkt_burst =
+ iavf_recv_pkts_vec_flex_rxd,
+ [IAVF_RX_BURST_VEC_AVX2_FRXD].rx_pkt_burst =
+ iavf_recv_pkts_vec_avx2_flex_rxd,
+ [IAVF_RX_BURST_VEC_AVX2_FRXD_OFFLOAD].rx_pkt_burst =
+ iavf_recv_pkts_vec_avx2_flex_rxd_offload,
+ [IAVF_RX_BURST_VEC_SSE_SCATTERED].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec,
+ [IAVF_RX_BURST_VEC_AVX2_SCATTERED].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec_avx2,
+ [IAVF_RX_BURST_VEC_AVX2_SCATTERED_OFFLOAD].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec_avx2_offload,
+ [IAVF_RX_BURST_VEC_SSE_SFLEX_RXD].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec_flex_rxd,
+ [IAVF_RX_BURST_VEC_AVX2_SFLEX_RXD].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec_avx2_flex_rxd,
+ [IAVF_RX_BURST_VEC_AVX2_SFRXD_OFFLOAD].rx_pkt_burst =
+ iavf_recv_scattered_pkts_vec_avx2_flex_rxd_offload,
+#ifdef CC_AVX512_SUPPORT
+ [IAVF_RX_BURST_VEC_AVX512].rx_pkt_burst = iavf_recv_pkts_vec_avx512,
+ [IAVF_RX_BURST_VEC_AVX512_OFFLOAD].rx_pkt_burst =
+ iavf_recv_pkts_vec_avx512_offload,
+ [IAVF_RX_BURST_VEC_AVX512_FRXD].rx_pkt_burst =
+ iavf_recv_pkts_vec_avx512_flex_rxd,
+ [IAVF_RX_BURST_VEC_AVX512_FRXD_OFFLOAD].rx_pk
[PATCH v6 2/2] net/iavf: add diagnostic support in TX path
The only way to enable diagnostics for TX paths is to modify the
application source code. Making it difficult to diagnose faults.
In this patch, the devarg option "mbuf_check" is introduced and the
parameters are configured to enable the corresponding diagnostics.
supported cases: mbuf, size, segment, offload.
1. mbuf: check for corrupted mbuf.
2. size: check min/max packet length according to hw spec.
3. segment: check number of mbuf segments not exceed hw limitation.
4. offload: check any unsupported offload flag.
parameter format: mbuf_check=[mbuf,,]
eg: dpdk-testpmd -a :81:01.0,mbuf_check=[mbuf,size] -- -i
Signed-off-by: Mingjin Ye
---
v2: Remove call chain.
---
v3: Optimisation implementation.
---
v4: Fix Windows os compilation error.
---
v5: Split Patch.
---
v6: remove strict.
---
doc/guides/nics/intel_vf.rst | 4 ++
drivers/net/iavf/iavf.h| 12 +
drivers/net/iavf/iavf_ethdev.c | 68 +++
drivers/net/iavf/iavf_rxtx.c | 98 ++
drivers/net/iavf/iavf_rxtx.h | 2 +
5 files changed, 184 insertions(+)
diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
index ad08198f0f..8e39bc831c 100644
--- a/doc/guides/nics/intel_vf.rst
+++ b/doc/guides/nics/intel_vf.rst
@@ -111,6 +111,10 @@ For more detail on SR-IOV, please refer to the following
documents:
by setting the ``devargs`` parameter like ``-a
18:01.0,no-poll-on-link-down=1``
when IAVF is backed by an Intel\ |reg| E810 device or an Intel\ |reg| 700
Series Ethernet device.
+Enable mbuf check for Tx diagnostics by setting the devargs parameter like
+``-a 18:01.0,mbuf_check=[mbuf,,]`` when IAVF is backed by an
+Intel\ |reg| E810 device or an Intel\ |reg| 700 Series Ethernet device.
+
The PCIE host-interface of Intel Ethernet Switch FM1 Series VF
infrastructure
^
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index 8db9f3d7cd..0a7053e311 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -113,9 +113,14 @@ struct iavf_ipsec_crypto_stats {
} ierrors;
};
+struct iavf_mbuf_stats {
+ uint64_t tx_pkt_errors;
+};
+
struct iavf_eth_xstats {
struct virtchnl_eth_stats eth_stats;
struct iavf_ipsec_crypto_stats ips_stats;
+ struct iavf_mbuf_stats mbuf_stats;
};
/* Structure that defines a VSI, associated with a adapter. */
@@ -309,10 +314,16 @@ struct iavf_devargs {
uint32_t watchdog_period;
int auto_reset;
int no_poll_on_link_down;
+ int mbuf_check;
};
struct iavf_security_ctx;
+#define IAVF_MBUF_CHECK_F_TX_MBUF(1ULL << 0)
+#define IAVF_MBUF_CHECK_F_TX_SIZE(1ULL << 1)
+#define IAVF_MBUF_CHECK_F_TX_SEGMENT (1ULL << 2)
+#define IAVF_MBUF_CHECK_F_TX_OFFLOAD (1ULL << 3)
+
enum iavf_rx_burst_type {
IAVF_RX_BURST_DEFAULT,
IAVF_RX_BURST_FRXD,
@@ -368,6 +379,7 @@ struct iavf_adapter {
bool no_poll;
enum iavf_rx_burst_type rx_burst_type;
enum iavf_tx_burst_type tx_burst_type;
+ uint64_t mc_flags; /* mbuf check flags. */
uint16_t fdir_ref_cnt;
struct iavf_devargs devargs;
};
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index d1edb0dd5c..a7a0d99868 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -13,6 +13,7 @@
#include
#include
#include
+#include
#include
#include
@@ -39,6 +40,8 @@
#define IAVF_RESET_WATCHDOG_ARG"watchdog_period"
#define IAVF_ENABLE_AUTO_RESET_ARG "auto_reset"
#define IAVF_NO_POLL_ON_LINK_DOWN_ARG "no-poll-on-link-down"
+#define IAVF_MBUF_CHECK_ARG "mbuf_check"
+
uint64_t iavf_timestamp_dynflag;
int iavf_timestamp_dynfield_offset = -1;
@@ -48,6 +51,7 @@ static const char * const iavf_valid_args[] = {
IAVF_RESET_WATCHDOG_ARG,
IAVF_ENABLE_AUTO_RESET_ARG,
IAVF_NO_POLL_ON_LINK_DOWN_ARG,
+ IAVF_MBUF_CHECK_ARG,
NULL
};
@@ -174,6 +178,7 @@ static const struct rte_iavf_xstats_name_off
rte_iavf_stats_strings[] = {
{"tx_broadcast_packets", _OFF_OF(eth_stats.tx_broadcast)},
{"tx_dropped_packets", _OFF_OF(eth_stats.tx_discards)},
{"tx_error_packets", _OFF_OF(eth_stats.tx_errors)},
+ {"tx_mbuf_error_packets", _OFF_OF(mbuf_stats.tx_pkt_errors)},
{"inline_ipsec_crypto_ipackets", _OFF_OF(ips_stats.icount)},
{"inline_ipsec_crypto_ibytes", _OFF_OF(ips_stats.ibytes)},
@@ -1881,6 +1886,8 @@ static int iavf_dev_xstats_get(struct rte_eth_dev *dev,
{
int ret;
unsigned int i;
+ struct iavf_tx_queue *txq;
+ uint64_t mbuf_errors = 0;
struct iavf_adapter *adapter =
IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
@@ -1904,6 +1911,15 @@ static int iavf_dev_xst
Re: [PATCH v3 00/18] bnxt patchset
On Tue, Dec 26, 2023 at 8:21 PM Ajit Khaparde wrote: > > This patchset contains more code fixes and reafctoring, apart from > extending more support for the newer P7 device family. > The patchset adds vector mode support for compressed Rx CQE. > This patchset includes support for checksum and XOR RSS hash mode. > It also adds support for forced speeds and autoneg support upto 400G. > > v1->v2: > - Fixed a redefinition of page size and used rte variant instead. > - Fixed typo in some commit logs > > v2->v3: > - Fixed some warnings > - Fixed the use of __builtin helpers > - Renamed a function in patch 16 Patchset merged in the dpdk-next-net-brcm for-next-net branch. Thanks > > Ajit Khaparde (9): > net/bnxt: add support for UDP GSO > net/bnxt: add support for compressed Rx CQE > net/bnxt: reattempt mbuf allocation for Rx and AGG rings > net/bnxt: refactor Rx doorbell during Rx flush > net/bnxt: extend RSS hash support for P7 devices > net/bnxt: add ESP and AH header based RSS support > net/bnxt: set allmulti mode if multicast filter fails > net/bnxt: add AVX2 support for compressed CQE > net/bnxt: enable SSE mode for compressed CQE > > Damodharam Ammepalli (4): > net/bnxt: add flow query callback > net/bnxt: add tunnel TPA support > net/bnxt: add 400G get support for P7 devices > net/bnxt: query extended stats from firmware > > Jay Ding (1): > net/bnxt: add VF FLR async event handler > > Kalesh AP (4): > net/bnxt: fix a typo while parsing link speed > net/bnxt: fix setting 50G and 100G forced speed > net/bnxt: fix speed change from 200G to 25G on Thor > net/bnxt: support backward compatibility > > drivers/net/bnxt/bnxt.h| 106 ++- > drivers/net/bnxt/bnxt_cpr.c| 20 + > drivers/net/bnxt/bnxt_cpr.h| 3 +- > drivers/net/bnxt/bnxt_ethdev.c | 253 ++-- > drivers/net/bnxt/bnxt_flow.c | 98 ++- > drivers/net/bnxt/bnxt_hwrm.c | 853 +++-- > drivers/net/bnxt/bnxt_hwrm.h | 16 +- > drivers/net/bnxt/bnxt_reps.c | 2 +- > drivers/net/bnxt/bnxt_ring.c | 19 +- > drivers/net/bnxt/bnxt_rxq.c| 8 +- > drivers/net/bnxt/bnxt_rxq.h| 1 + > drivers/net/bnxt/bnxt_rxr.c| 320 -- > drivers/net/bnxt/bnxt_rxr.h| 59 ++ > drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 309 + > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 167 - > drivers/net/bnxt/bnxt_stats.c | 279 +++- > drivers/net/bnxt/bnxt_txq.c| 2 + > drivers/net/bnxt/bnxt_txr.c| 7 +- > drivers/net/bnxt/bnxt_vnic.c | 195 +- > drivers/net/bnxt/bnxt_vnic.h | 20 +- > drivers/net/bnxt/hsi_struct_def_dpdk.h | 10 +- > 21 files changed, 2542 insertions(+), 205 deletions(-) > > -- > 2.39.2 (Apple Git-143) > smime.p7s Description: S/MIME Cryptographic Signature
RE: [PATCH] net/e1000: support launchtime feature
>>
>> >> +static int
>> >> +eth_igb_read_clock(__rte_unused struct rte_eth_dev *dev, uint64_t
>> >> +*clock) {
>> >> + uint64_t systime_cycles;
>> >> + struct e1000_adapter *adapter = dev->data->dev_private;
>> >> +
>> >> + systime_cycles = igb_read_systime_cyclecounter(dev);
>> >> + uint64_t ns = rte_timecounter_update(&adapter->systime_tc,
>> >> systime_cycles);
>> >
>> >Do you also run "ptp timesync" when testing this launchtime feature?
>> >
>>
>> I used `rte_eth_timesync_enable` function during the test. I am not familiar
>> with the `ptp timesync` in DPDK. If you are referring to something else,
>> could
>> you please guide me on how to test it?
>
>Do you use your own application or DPDK application to test this launchtime
>feature,
>for example, dpdk testpmd?
Yes, I used my own application to test it. The benefit of launch time feature
in boundable delay and jitter is significant compared with when it is disabled.
Specifically, my app periodically calls `rte_eth_tx_burst` with
`rte_dynfield_timestamp`
field on talker, and compares whether the receiving time in NIC hardware
timestamp
on listener is as expected. Talker and listener are directly connected by a
RJ45 cable,
both installed with i210 NIC. The feature works perfect in my test.
I also tested it with testpmd with `txtimes` config. However it seems there is
an issue
in testpmd. Specifically the tx_only mode sends packets as fast as possible,
results
in an increasing gap between the current time and the scheduled transmission
time.
Based on i210 NIC sheet Sec 7.2.2.2.3, the launch time should be within
(current_time, current time + 0.5 Sec), thus most of tx packets are not
scheduled.
I got the similar test results with dpdk igc driver which already implemeted
launch
time feature.
Following is how I try to test with testpmd. Please let me know if I did
something wrong.
sudo ./dpdk-testpmd -- -i --forward-mode=txonly
testpmd> port stop 0
testpmd> set burst 1
testpmd> set txtimes 1,0
testpmd> port config 0 tx_offload send_on_timestamp on
testpmd> port start 0
testpmd> start
>
>> +---+---+---+---+---+---+
>> | 1G| 16880 | 16880 | 16880 | 16880
>> | 16880 |
>> +---+---+---+---+---+---+
>>
>> Any suggestions here? Is it supposed to be embedded directly here or left to
>> the application level to compensate? I can fix it accordingly.
>
>I think it can be put here directly just as you do.
Got it. Will keep this delay compensiation here and revise it in the next batch
version.
[Bug 1339] Ice pmd driver ice_rss_init error message "not support in safe mode"
https://bugs.dpdk.org/show_bug.cgi?id=1339 Bug ID: 1339 Summary: Ice pmd driver ice_rss_init error message "not support in safe mode" Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: 501359...@qq.com Target Milestone: --- In the ice pmd driver code, ad ->is_safe_mode uninitialized ,with a random value may cause ice_rss_Init() return error message " not support in safe mode " .To solve this problem, it is necessary to add code at the beginning of the ice_dev_init() "ad->safe_mode=0;" // I encountered this issue while debugging the e810 network card. The ice driver code uses rte_socket_zmalloc, but this function does not initialize the memory to 0 (but the annotation will clear 0? A bug ? only memset 0 in debug code), which caused the above problem. -- You are receiving this mail because: You are the assignee for the bug.
