Re: [PATCH] eal: introduce missing rte_thread wrappers

[David Vodak]

On 11/27/23 18:27, Tyler Retzlaff wrote:


On Mon, Nov 27, 2023 at 10:25:02AM +0100, David Vodak wrote:

Function rte_ctrl_thread_create has been replaced by rte_thread_create_control,
encouraging Linux users to switch from the pthread_t API to the rte_thread API.
However the rte_thread API does not provide wrappers for all pthread functions.
This commit introduces equivalent functions for pthread_timedjoin_np,
pthread_getname_np and pthread_cancel.

Bugzilla ID: 1330
---

NAK this series. the rte thread API is not a POSIX emulation API.

the point of EAL is not to require applications to have to conditionally
compile code around the use of EAL API or handle "not supported"
failures it defeats the purpose of being an abstraction library.

Hi,

I understand that these changes may not be the best alternative. But 
what other options do we have,
if we are already using functions such as pthread_timedjoin_np? Should 
we just keep using them and

treat rte_thread_id.opaque_id as pthread_t?

Regards
David Vodak

Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature

[Ferruh Yigit]

On 11/28/2023 1:21 AM, lihuisong (C) wrote:
> 
> 在 2023/11/27 23:43, Ferruh Yigit 写道:
>> On 11/27/2023 1:12 PM, lihuisong (C) wrote:
>>> 在 2023/11/27 20:19, Ferruh Yigit 写道:
 On 11/25/2023 1:47 AM, Huisong Li wrote:
> Add hash algorithm feature introduced by 23.11 and fix some RSS
> features
> description.
>
> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
>
> Signed-off-by: Huisong Li 
> Acked-by: Chengwen Feng 
> ---
>    doc/guides/nics/features.rst | 26 ++
>    1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/nics/features.rst
> b/doc/guides/nics/features.rst
> index 1a1dc16c1e..0d38c5c525 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -277,10 +277,12 @@ RSS hash
>    Supports RSS hashing on RX.
>      * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` =
> ``RTE_ETH_MQ_RX_RSS_FLAG``.
> -* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
> +* **[uses] user config**: ``rss_conf.rss_hf``.
>
 Feature title is "RSS hash", it can be two things,
 1. "Receive Side Scaling" support
 2. Provide RSS hash to application

 When this document first prepared RSS hash value was always provided to
 the application when RSS enabled.
 So intention with this feature was "Receive Side Scaling" support,
 hence
 'RTE_ETH_MQ_RX_RSS_FLAG' added.

 Later providing RSS has to the application separated as optimization,
 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this
 support.
>>> What should I do for above two comments？
>>> To tell application how to use it?
>>>
>> Just tried to give some context.
> got it.
>>  
>>
 As the intention of this feature is "Receive Side Scaling" support, we
 shouldn't reduce configuration struct to 'rss_conf.rss_hf'.

 Instead perhaps can expand to:
 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf'
>>>   I just pick their common part.😁
>>>
>>> ok, will fix it.
>>>

>    * **[uses] rte_eth_rxconf,rte_eth_rxmode**:
> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>    * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
>    * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``,
> ``mbuf.rss``.
> +* **[related]  API**: ``rte_eth_dev_configure``,
> ``rte_eth_dev_rss_hash_update``
> +  ``rte_eth_dev_rss_hash_conf_get()``.
>    
 ack

>      .. _nic_features_inner_rss:
> @@ -288,7 +290,7 @@ Supports RSS hashing on RX.
>    Inner RSS
>    -
>    -Supports RX RSS hashing on Inner headers.
> +Supports RX RSS hashing on Inner headers by rte_flow API.
>    
 This should be clarified with details below, not sure if it required to
 limit description to rte_flow.
>>> But this block like rte_flow_action_rss is from rte_flow.
>>> And ethdev ops doesn't support inner RSS.
>>> So I think it is ok.
>>>
>> Yes it is supported by rte_flow, and '[uses]' information should already
>> clarify it.
> Should we remove the 'rte_flow API' wrods I added in above description?
>

I think it can be removed.


>>

 And I guess similar confusion exist with the providing hash to user.
 Need to check if rte_flow implementation puts hash to mbuf along with
 doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload,
 and update below items accordingly.
>>> Do we need to tell user how to use it here?
>>> I feel this document is a little simple and main to list interface for
>>> user.
>>> In addition, it is better that the more detail about RSS should be
>>> presented  in rte_flow features.
>>>
>> No, I am not suggesting to add more detail.
>>
>> My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be
>> correct, ethdev APIs checks offload flags, but does rte_flow
>> implementation check it?
> As far as I know, It is possibly verified in PMD if have or required.
>>
>> My suggestion is double check that piece of information and fix it if
>> required.
>>
>>

>    * **[uses]    rte_flow_action_rss**: ``level``.
>    * **[uses]    rte_eth_rxconf,rte_eth_rxmode**:
> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
> @@ -303,9 +305,25 @@ RSS key update
>    Supports configuration of Receive Side Scaling (RSS) hash
> computation. Updating
>    Receive Side Scaling (RSS) hash key.
>    -* **[implements] eth_dev_ops**: ``rss_hash_update``,
> ``rss_hash_conf_get``.
> +* **[implements] eth_dev_ops**: ``dev_configure``,
> ``rss_hash_update``, ``rss_hash_conf_get``.
> +* **[uses] user config**: ``rss_conf.rss_key``,
> ``rss_conf.rss_key_len``
>    * **[provides]   rte_eth_dev_info**: ``hash_key_size``.
> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``,
> +* **[related]    API**: ``rte_eth_dev_conf

Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature

[Ferruh Yigit]

On 11/28/2023 1:34 AM, lihuisong (C) wrote:
> 
> 在 2023/11/28 0:35, Ferruh Yigit 写道:
>> On 11/27/2023 3:43 PM, Ferruh Yigit wrote:
>>> On 11/27/2023 1:12 PM, lihuisong (C) wrote:
 在 2023/11/27 20:19, Ferruh Yigit 写道:
> On 11/25/2023 1:47 AM, Huisong Li wrote:
>> Add hash algorithm feature introduced by 23.11 and fix some RSS
>> features
>> description.
>>
>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
>>
>> Signed-off-by: Huisong Li 
>> Acked-by: Chengwen Feng 
>> ---
>>    doc/guides/nics/features.rst | 26 ++
>>    1 file changed, 22 insertions(+), 4 deletions(-)
>>
>> diff --git a/doc/guides/nics/features.rst
>> b/doc/guides/nics/features.rst
>> index 1a1dc16c1e..0d38c5c525 100644
>> --- a/doc/guides/nics/features.rst
>> +++ b/doc/guides/nics/features.rst
>> @@ -277,10 +277,12 @@ RSS hash
>>    Supports RSS hashing on RX.
>>      * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` =
>> ``RTE_ETH_MQ_RX_RSS_FLAG``.
>> -* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
>> +* **[uses] user config**: ``rss_conf.rss_hf``.
>>
> Feature title is "RSS hash", it can be two things,
> 1. "Receive Side Scaling" support
> 2. Provide RSS hash to application
>
> When this document first prepared RSS hash value was always
> provided to
> the application when RSS enabled.
> So intention with this feature was "Receive Side Scaling" support,
> hence
> 'RTE_ETH_MQ_RX_RSS_FLAG' added.
>
> Later providing RSS has to the application separated as optimization,
> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for
> this
> support.
 What should I do for above two comments？
 To tell application how to use it?

>>> Just tried to give some context.
>>>
>>>
> As the intention of this feature is "Receive Side Scaling" support, we
> shouldn't reduce configuration struct to 'rss_conf.rss_hf'.
>
> Instead perhaps can expand to:
> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf'
   I just pick their common part.😁

 ok, will fix it.

>
>>    * **[uses] rte_eth_rxconf,rte_eth_rxmode**:
>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>>    * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
>>    * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``,
>> ``mbuf.rss``.
>> +* **[related]  API**: ``rte_eth_dev_configure``,
>> ``rte_eth_dev_rss_hash_update``
>> +  ``rte_eth_dev_rss_hash_conf_get()``.
>>    
> ack
>
>>      .. _nic_features_inner_rss:
>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX.
>>    Inner RSS
>>    -
>>    -Supports RX RSS hashing on Inner headers.
>> +Supports RX RSS hashing on Inner headers by rte_flow API.
>>    
> This should be clarified with details below, not sure if it
> required to
> limit description to rte_flow.
 But this block like rte_flow_action_rss is from rte_flow.
 And ethdev ops doesn't support inner RSS.
 So I think it is ok.

>>> Yes it is supported by rte_flow, and '[uses]' information should already
>>> clarify it.
>>>
>>>
>
> And I guess similar confusion exist with the providing hash to user.
> Need to check if rte_flow implementation puts hash to mbuf along with
> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload,
> and update below items accordingly.
 Do we need to tell user how to use it here?
 I feel this document is a little simple and main to list interface for
 user.
 In addition, it is better that the more detail about RSS should be
 presented  in rte_flow features.

>>> No, I am not suggesting to add more detail.
>>>
>>> My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be
>>> correct, ethdev APIs checks offload flags, but does rte_flow
>>> implementation check it?
>>>
>>> My suggestion is double check that piece of information and fix it if
>>> required.
>>>
>> Thinking twice, ethdev API or rte_flow or different ways to configure
>> RSS, but datapath that puts hash value to mbuf is same.
>> So same 'RTE_ETH_RX_OFFLOAD_RSS_HASH' check is used for both method, and
>> it is OK to have it documented.
> There was a check for  RTE_ETH_RX_OFFLOAD_RSS_HASH in
> rte_eth_dev_configure().
> This offload flag depends on the RTE_ETH_MQ_RX_RSS_FLAG mode.
> As far as I know, ethdev ops allows to enable RSS hash only when
> RTE_ETH_MQ_RX_RSS_FLAG mode is set.
> But rte flow API enable RSS hash doesn't depend on this MQ mode.
> So I guess that the mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH and mbuf.rss
> also be set to report application when create RSS hash flow, even if
> application don't set RTE_ETH_MQ_RX_RSS_FLAG mode by ethdev ops.
>

Even rte_flow is used for RSS, application may want to control expo

Re: [PATCH 0/3] fix some bug for hns3

[Thomas Monjalon]

28/11/2023 04:33, Jie Hai:
> On 2023/11/28 2:33, Ferruh Yigit wrote:
> > On 11/27/2023 1:55 PM, Jie Hai wrote:
> >> On 2023/11/27 21:39, Dengdui Huang wrote:
> >>> Dengdui Huang (3):
> >>> net/hns3: fix reset detect be ignored
> >>> net/hns3: fix VF wrong clear reset status
> >>> net/hns3: fix the VF reset interrupted possibly
> >> Hi, Dengdui,
> >>
> >> Good fix.
> >> For the patchset,
> >> Acked-by: Jie Hai 
> >>
> > 
> > 
> > Hi Jie, Dengdui, is this set for this release, which is a few days away?
> > My suggestion is to wait next version as issues doesn't look critical.
> > 
> > 
> > I applied set to next-net, but leaving decision to pull it for the
> > release or not to Thomas/David.
> > 
> > Applied to dpdk-next-net/main, thanks.
> > 
> Hi, Ferruh, Thomas and David,
> 
> I'm sorry that this problem is a little serious.
> 
> a) Without [PATCH 2/3], when the VF executes the 
> hns3_clear_reset_event(), unexpected memory is written.
> As a result, unexpected errors occur in the program or even the app may 
> crash.
> b) Without [PATCH 3/3], there is a low probability that the app is 
> unavailable after the FLR reset is done.
> c) In addition, some LTS versions have the same problem.
> 
> Therefore, we hope that the problem can be solved in the current version.

OK applied, thanks.

Re: [PATCH 01/11] doc: add Traffic Manager feature

[Ferruh Yigit]

On 11/28/2023 6:09 AM, Huisong Li wrote:
> Add Traffic Manager feature.
> 
> Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> Acked-by: Chengwen Feng 
> 

Acked-by: Ferruh Yigit 

Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf

[Ferruh Yigit]

On 11/28/2023 6:09 AM, Huisong Li wrote:
> Add Traffic Manager feature for iavf.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> ---
>  doc/guides/nics/features/iavf.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/iavf.ini 
> b/doc/guides/nics/features/iavf.ini
> index db4f92ce71..385799c650 100644
> --- a/doc/guides/nics/features/iavf.ini
> +++ b/doc/guides/nics/features/iavf.ini
> @@ -35,6 +35,7 @@ Inner L4 checksum= Y
>  Packet type parsing  = Y
>  Rx descriptor status = Y
>  Tx descriptor status = Y
> +Traffic manager  = Y
>  Inline crypto= Y
>  Basic stats  = Y
>  Multiprocess aware   = Y

Can you please keep the order in the default.ini and other files same,
here 'Inline crypto' seems put into wrong order that is causing the
confusion,
but new fields seems need to go between 'VLAN filter' & 'CRC offload'.

RE: [PATCH 01/11] doc: add Traffic Manager feature

[Hemant Agrawal]

> -Original Message-
> From: Ferruh Yigit 
> Sent: Tuesday, November 28, 2023 4:02 PM
> To: Huisong Li ; dev@dpdk.org;
> tho...@monjalon.net; Hemant Agrawal ;
> Balasubramanian Manoharan
> ; Cristian Dumitrescu
> ; Jerin Jacob
> 
> Cc: liuyongl...@huawei.com
> Subject: Re: [PATCH 01/11] doc: add Traffic Manager feature
> Importance: High
> 
> On 11/28/2023 6:09 AM, Huisong Li wrote:
> > Add Traffic Manager feature.
> >
> > Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Huisong Li 
> > Acked-by: Chengwen Feng 
> >
> 
> Acked-by: Ferruh Yigit 
> 
Acked-by: Hemant Agrawal 

RE: [PATCH 09/11] doc: add Traffic Manager feature for dpaa2

[Hemant Agrawal]

> -Original Message-
> From: Huisong Li 
> Sent: Tuesday, November 28, 2023 11:40 AM
> To: dev@dpdk.org; ferruh.yi...@amd.com; tho...@monjalon.net; Hemant
> Agrawal ; Sachin Saxena
> 
> Cc: liuyongl...@huawei.com; lihuis...@huawei.com
> Subject: [PATCH 09/11] doc: add Traffic Manager feature for dpaa2
> Importance: High
> 
> Add Traffic Manager feature for dpaa2.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> ---
>  doc/guides/nics/features/dpaa2.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/dpaa2.ini
> b/doc/guides/nics/features/dpaa2.ini
> index 26dc8c2178..f02da463d9 100644
> --- a/doc/guides/nics/features/dpaa2.ini
> +++ b/doc/guides/nics/features/dpaa2.ini
> @@ -17,6 +17,7 @@ Unicast MAC filter   = Y
>  RSS hash = Y
>  VLAN filter  = Y
>  Flow control = Y
> +Traffic manager  = Y
>  VLAN offload = Y
>  L3 checksum offload  = Y
>  L4 checksum offload  = Y
> --
> 2.33.0
Acked-by: Hemant Agrawal 

Re: [PATCH 08/11] doc: add Traffic Manager feature for mvpp2

[Ferruh Yigit]

On 11/28/2023 6:09 AM, Huisong Li wrote:
> Add Traffic Manager feature for mvpp2.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> ---
>  doc/guides/nics/features/mvpp2.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/mvpp2.ini 
> b/doc/guides/nics/features/mvpp2.ini
> index 653c9d08cb..69767d6317 100644
> --- a/doc/guides/nics/features/mvpp2.ini
> +++ b/doc/guides/nics/features/mvpp2.ini
> @@ -13,6 +13,7 @@ Unicast MAC filter   = Y
>  Multicast MAC filter = Y
>  RSS hash = Y
>  Flow control = Y
> +Traffic manager  = Y
>  VLAN filter  = Y
>  CRC offload  = Y
>  L3 checksum offload  = Y

Similarly original order looks wrong, but can move new update below
'VLAN filter'.

Re: [PATCH 11/11] doc: add Traffic Manager feature for ice

[Ferruh Yigit]

On 11/28/2023 6:09 AM, Huisong Li wrote:
> Add Traffic Manager feature for ice.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> ---
>  doc/guides/nics/features/ice.ini | 1 +
>  doc/guides/nics/features/ice_dcf.ini | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/doc/guides/nics/features/ice.ini 
> b/doc/guides/nics/features/ice.ini
> index 13f8871dcc..d26ab7e6a9 100644
> --- a/doc/guides/nics/features/ice.ini
> +++ b/doc/guides/nics/features/ice.ini
> @@ -25,6 +25,7 @@ Unicast MAC filter   = Y
>  RSS hash = Y
>  RSS key update   = Y
>  RSS reta update  = Y
> +Traffic manager  = Y
>  VLAN filter  = Y
>  CRC offload  = Y
>  VLAN offload = Y
>

Please move below 'VLAN filter'



> diff --git a/doc/guides/nics/features/ice_dcf.ini 
> b/doc/guides/nics/features/ice_dcf.ini
> index 3b11622d4c..210c08fc9a 100644
> --- a/doc/guides/nics/features/ice_dcf.ini
> +++ b/doc/guides/nics/features/ice_dcf.ini
> @@ -21,6 +21,7 @@ MTU update   = Y
>  Promiscuous mode = Y
>  Allmulticast mode= Y
>  Unicast MAC filter   = Y
> +Traffic manager  = Y
>  VLAN filter  = Y
>  VLAN offload = Y
>  Extended stats   = Y
>

Please move below 'VLAN filter'

RE: [PATCH 01/11] doc: add Traffic Manager feature

[Dumitrescu, Cristian]

> -Original Message-
> From: Ferruh Yigit 
> Sent: Tuesday, November 28, 2023 10:32 AM
> To: Huisong Li ; dev@dpdk.org; tho...@monjalon.net;
> Hemant Agrawal ; Balasubramanian Manoharan
> ; Dumitrescu, Cristian
> ; Jerin Jacob
> 
> Cc: liuyongl...@huawei.com
> Subject: Re: [PATCH 01/11] doc: add Traffic Manager feature
> 
> On 11/28/2023 6:09 AM, Huisong Li wrote:
> > Add Traffic Manager feature.
> >
> > Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Huisong Li 
> > Acked-by: Chengwen Feng 
> >
> 
> Acked-by: Ferruh Yigit 
> 

Acked-by: Cristian Dumitrescu 

Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Thomas Monjalon]

08/11/2023 16:23, Thomas Monjalon:
> 08/11/2023 15:42, Srikanth Yalavarthi:
> > From: Thomas Monjalon 
> > > 08/11/2023 10:28, Srikanth Yalavarthi:
> > > > As part of deprecating kmods meson option, 'kernel/linux'
> > > > directory is removed from the repository.
> > > >
> > > > This patch removes non-existing 'kernel/linux' directory from
> > > > linux_sources of build tags script.
> > > >
> > > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> > > 
> > > If it is an old commit, you should probably add Cc: sta...@dpdk.org You 
> > > can
> > > check with devtools/check-git-log.sh
> > 
> > The fixes commit (a52d472c5c94) was merged after 23.11-rc0. 
> > check-git-log.sh script wasn't suggested to submit this to sta...@dpdk.log
> > 
> > My understanding is that Cc:sta...@dpdk.org is need only if we need to 
> > backport the patch to older releases?
> 
> Your understanding is correct.
> But here:
>   git describe a52d472c5c94
>   v23.07-183-ga52d472c5c

No you are right, it is part of 23.11 cycle.

Applied with adding Ferruh's suggestion:

Fixes: f78c100bc871 ("remove KNI")
Acked-by: Ferruh Yigit 

Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature

[lihuisong (C)]

在 2023/11/28 18:09, Ferruh Yigit 写道:

On 11/28/2023 1:21 AM, lihuisong (C) wrote:

在 2023/11/27 23:43, Ferruh Yigit 写道:

On 11/27/2023 1:12 PM, lihuisong (C) wrote:

在 2023/11/27 20:19, Ferruh Yigit 写道:

On 11/25/2023 1:47 AM, Huisong Li wrote:

Add hash algorithm feature introduced by 23.11 and fix some RSS
features
description.

Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
    doc/guides/nics/features.rst | 26 ++
    1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/doc/guides/nics/features.rst
b/doc/guides/nics/features.rst
index 1a1dc16c1e..0d38c5c525 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -277,10 +277,12 @@ RSS hash
    Supports RSS hashing on RX.
      * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` =
``RTE_ETH_MQ_RX_RSS_FLAG``.
-* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
+* **[uses] user config**: ``rss_conf.rss_hf``.


Feature title is "RSS hash", it can be two things,
1. "Receive Side Scaling" support
2. Provide RSS hash to application

When this document first prepared RSS hash value was always provided to
the application when RSS enabled.
So intention with this feature was "Receive Side Scaling" support,
hence
'RTE_ETH_MQ_RX_RSS_FLAG' added.

Later providing RSS has to the application separated as optimization,
'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this
support.

What should I do for above two comments？
To tell application how to use it?


Just tried to give some context.

got it.
  


As the intention of this feature is "Receive Side Scaling" support, we
shouldn't reduce configuration struct to 'rss_conf.rss_hf'.

Instead perhaps can expand to:
'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf'

   I just pick their common part.😁

ok, will fix it.


    * **[uses] rte_eth_rxconf,rte_eth_rxmode**:
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
    * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
    * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``,
``mbuf.rss``.
+* **[related]  API**: ``rte_eth_dev_configure``,
``rte_eth_dev_rss_hash_update``
+  ``rte_eth_dev_rss_hash_conf_get()``.


ack


      .. _nic_features_inner_rss:
@@ -288,7 +290,7 @@ Supports RSS hashing on RX.
    Inner RSS
    -
    -Supports RX RSS hashing on Inner headers.
+Supports RX RSS hashing on Inner headers by rte_flow API.


This should be clarified with details below, not sure if it required to
limit description to rte_flow.

But this block like rte_flow_action_rss is from rte_flow.
And ethdev ops doesn't support inner RSS.
So I think it is ok.


Yes it is supported by rte_flow, and '[uses]' information should already
clarify it.

Should we remove the 'rte_flow API' wrods I added in above description?


I think it can be removed.

The latest version(V5, only three fix doc patch) has been sent out.
Do we I need to send V6 for this?😂




And I guess similar confusion exist with the providing hash to user.
Need to check if rte_flow implementation puts hash to mbuf along with
doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload,
and update below items accordingly.

Do we need to tell user how to use it here?
I feel this document is a little simple and main to list interface for
user.
In addition, it is better that the more detail about RSS should be
presented  in rte_flow features.


No, I am not suggesting to add more detail.

My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be
correct, ethdev APIs checks offload flags, but does rte_flow
implementation check it?

As far as I know, It is possibly verified in PMD if have or required.

My suggestion is double check that piece of information and fix it if
required.



    * **[uses]    rte_flow_action_rss**: ``level``.
    * **[uses]    rte_eth_rxconf,rte_eth_rxmode**:
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
@@ -303,9 +305,25 @@ RSS key update
    Supports configuration of Receive Side Scaling (RSS) hash
computation. Updating
    Receive Side Scaling (RSS) hash key.
    -* **[implements] eth_dev_ops**: ``rss_hash_update``,
``rss_hash_conf_get``.
+* **[implements] eth_dev_ops**: ``dev_configure``,
``rss_hash_update``, ``rss_hash_conf_get``.
+* **[uses] user config**: ``rss_conf.rss_key``,
``rss_conf.rss_key_len``
    * **[provides]   rte_eth_dev_info**: ``hash_key_size``.
-* **[related]    API**: ``rte_eth_dev_rss_hash_update()``,
+* **[related]    API**: ``rte_eth_dev_configure``,
``rte_eth_dev_rss_hash_update()``,
+  ``rte_eth_dev_rss_hash_conf_get()``.
+

ack

There is an inconsistency in the documentation but I think it is
good to
use '()' when documenting API, like: 'rte_eth_dev_configure()'

+1 will fix it.

+
+.. _nic_features_rss_hash_algo_update:
+
+RSS hash algorithm update
+-
+
+Supports configuration of Receive Side Scaling (RSS) hash algorith

Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf

[lihuisong (C)]

在 2023/11/28 18:35, Ferruh Yigit 写道:

On 11/28/2023 6:09 AM, Huisong Li wrote:

Add Traffic Manager feature for iavf.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
  doc/guides/nics/features/iavf.ini | 1 +
  1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini 
b/doc/guides/nics/features/iavf.ini
index db4f92ce71..385799c650 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -35,6 +35,7 @@ Inner L4 checksum= Y
  Packet type parsing  = Y
  Rx descriptor status = Y
  Tx descriptor status = Y
+Traffic manager  = Y
  Inline crypto= Y
  Basic stats  = Y
  Multiprocess aware   = Y

Can you please keep the order in the default.ini and other files same,
here 'Inline crypto' seems put into wrong order that is causing the
confusion,
but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
Yes, I also find that the order of some driver's ini file is different 
from the one of default.ini.

Fix the order in this patch?

.

Re: [PATCH 08/11] doc: add Traffic Manager feature for mvpp2

[lihuisong (C)]

在 2023/11/28 18:39, Ferruh Yigit 写道:

On 11/28/2023 6:09 AM, Huisong Li wrote:

Add Traffic Manager feature for mvpp2.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
  doc/guides/nics/features/mvpp2.ini | 1 +
  1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/mvpp2.ini 
b/doc/guides/nics/features/mvpp2.ini
index 653c9d08cb..69767d6317 100644
--- a/doc/guides/nics/features/mvpp2.ini
+++ b/doc/guides/nics/features/mvpp2.ini
@@ -13,6 +13,7 @@ Unicast MAC filter   = Y
  Multicast MAC filter = Y
  RSS hash = Y
  Flow control = Y
+Traffic manager  = Y
  VLAN filter  = Y
  CRC offload  = Y
  L3 checksum offload  = Y

Similarly original order looks wrong, but can move new update below
'VLAN filter'.

ok, will fix it for mvpp2.

.

Re: [PATCH 11/11] doc: add Traffic Manager feature for ice

[lihuisong (C)]

在 2023/11/28 18:41, Ferruh Yigit 写道:

On 11/28/2023 6:09 AM, Huisong Li wrote:

Add Traffic Manager feature for ice.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
  doc/guides/nics/features/ice.ini | 1 +
  doc/guides/nics/features/ice_dcf.ini | 1 +
  2 files changed, 2 insertions(+)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 13f8871dcc..d26ab7e6a9 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -25,6 +25,7 @@ Unicast MAC filter   = Y
  RSS hash = Y
  RSS key update   = Y
  RSS reta update  = Y
+Traffic manager  = Y
  VLAN filter  = Y
  CRC offload  = Y
  VLAN offload = Y


Please move below 'VLAN filter'

Ack





diff --git a/doc/guides/nics/features/ice_dcf.ini 
b/doc/guides/nics/features/ice_dcf.ini
index 3b11622d4c..210c08fc9a 100644
--- a/doc/guides/nics/features/ice_dcf.ini
+++ b/doc/guides/nics/features/ice_dcf.ini
@@ -21,6 +21,7 @@ MTU update   = Y
  Promiscuous mode = Y
  Allmulticast mode= Y
  Unicast MAC filter   = Y
+Traffic manager  = Y
  VLAN filter  = Y
  VLAN offload = Y
  Extended stats   = Y


Please move below 'VLAN filter'

Ack

.

Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf

[lihuisong (C)]

在 2023/11/28 18:35, Ferruh Yigit 写道:

On 11/28/2023 6:09 AM, Huisong Li wrote:

Add Traffic Manager feature for iavf.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
  doc/guides/nics/features/iavf.ini | 1 +
  1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini 
b/doc/guides/nics/features/iavf.ini
index db4f92ce71..385799c650 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -35,6 +35,7 @@ Inner L4 checksum= Y
  Packet type parsing  = Y
  Rx descriptor status = Y
  Tx descriptor status = Y
+Traffic manager  = Y
  Inline crypto= Y
  Basic stats  = Y
  Multiprocess aware   = Y

Can you please keep the order in the default.ini and other files same,
here 'Inline crypto' seems put into wrong order that is causing the
confusion,
but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
.

Hi Ferruh,

I find that there are many place which is different from the order of 
default.ini.

And other drivers also have this problem.
I want to do it for all drivers after this series.
What do you think of that?

Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature

[Ferruh Yigit]

On 11/28/2023 11:29 AM, lihuisong (C) wrote:
> 
> 在 2023/11/28 18:09, Ferruh Yigit 写道:
>> On 11/28/2023 1:21 AM, lihuisong (C) wrote:
>>> 在 2023/11/27 23:43, Ferruh Yigit 写道:
 On 11/27/2023 1:12 PM, lihuisong (C) wrote:
> 在 2023/11/27 20:19, Ferruh Yigit 写道:
>> On 11/25/2023 1:47 AM, Huisong Li wrote:
>>> Add hash algorithm feature introduced by 23.11 and fix some RSS
>>> features
>>> description.
>>>
>>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
>>>
>>> Signed-off-by: Huisong Li 
>>> Acked-by: Chengwen Feng 
>>> ---
>>>     doc/guides/nics/features.rst | 26 ++
>>>     1 file changed, 22 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/doc/guides/nics/features.rst
>>> b/doc/guides/nics/features.rst
>>> index 1a1dc16c1e..0d38c5c525 100644
>>> --- a/doc/guides/nics/features.rst
>>> +++ b/doc/guides/nics/features.rst
>>> @@ -277,10 +277,12 @@ RSS hash
>>>     Supports RSS hashing on RX.
>>>       * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` =
>>> ``RTE_ETH_MQ_RX_RSS_FLAG``.
>>> -* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
>>> +* **[uses] user config**: ``rss_conf.rss_hf``.
>>>
>> Feature title is "RSS hash", it can be two things,
>> 1. "Receive Side Scaling" support
>> 2. Provide RSS hash to application
>>
>> When this document first prepared RSS hash value was always
>> provided to
>> the application when RSS enabled.
>> So intention with this feature was "Receive Side Scaling" support,
>> hence
>> 'RTE_ETH_MQ_RX_RSS_FLAG' added.
>>
>> Later providing RSS has to the application separated as optimization,
>> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for
>> this
>> support.
> What should I do for above two comments？
> To tell application how to use it?
>
 Just tried to give some context.
>>> got it.
  
>> As the intention of this feature is "Receive Side Scaling"
>> support, we
>> shouldn't reduce configuration struct to 'rss_conf.rss_hf'.
>>
>> Instead perhaps can expand to:
>> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf'
>    I just pick their common part.😁
>
> ok, will fix it.
>
>>>     * **[uses] rte_eth_rxconf,rte_eth_rxmode**:
>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>>>     * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
>>>     * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``,
>>> ``mbuf.rss``.
>>> +* **[related]  API**: ``rte_eth_dev_configure``,
>>> ``rte_eth_dev_rss_hash_update``
>>> +  ``rte_eth_dev_rss_hash_conf_get()``.
>>>     
>> ack
>>
>>>       .. _nic_features_inner_rss:
>>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX.
>>>     Inner RSS
>>>     -
>>>     -Supports RX RSS hashing on Inner headers.
>>> +Supports RX RSS hashing on Inner headers by rte_flow API.
>>>     
>> This should be clarified with details below, not sure if it
>> required to
>> limit description to rte_flow.
> But this block like rte_flow_action_rss is from rte_flow.
> And ethdev ops doesn't support inner RSS.
> So I think it is ok.
>
 Yes it is supported by rte_flow, and '[uses]' information should
 already
 clarify it.
>>> Should we remove the 'rte_flow API' wrods I added in above description?
>>>
>> I think it can be removed.
> The latest version(V5, only three fix doc patch) has been sent out.
> Do we I need to send V6 for this?😂
>

Nope, no new version needed for this, I already acked the one with it,
but if there will be a new version this can be updated.

Thanks Huisong for improving the documentation.

>>
>>
>> And I guess similar confusion exist with the providing hash to user.
>> Need to check if rte_flow implementation puts hash to mbuf along with
>> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload,
>> and update below items accordingly.
> Do we need to tell user how to use it here?
> I feel this document is a little simple and main to list interface for
> user.
> In addition, it is better that the more detail about RSS should be
> presented  in rte_flow features.
>
 No, I am not suggesting to add more detail.

 My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be
 correct, ethdev APIs checks offload flags, but does rte_flow
 implementation check it?
>>> As far as I know, It is possibly verified in PMD if have or required.
 My suggestion is double check that piece of information and fix it if
 required.


>>>     * **[uses]    rte_flow_action_rss**: ``level``.
>>>     * **[uses]    rte_eth_rxconf,rte_eth_rxmode**:
>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>>> @@ -303,9 +305,25 @@ RSS k

Re: [dpdk-dev] [PATCH 2/2] devtools: forbid rte symbols in cnxk base driver

[Thomas Monjalon]

04/10/2023 14:27, jer...@marvell.com:
> From: Jerin Jacob 
> 
> cnxk base code is shared between different driver environments.
> 
> Forbid the direct usage of rte_ symbols instead use plt_
> symbol as alternatives.
> 
> roc_platform.[ch] files abstract the difference of driver
> environment, hence skip those files for rules check.
> 
> Suggested-by: David Marchand 
> Signed-off-by: Jerin Jacob 

Series applied, thanks.

I've moved the check in a more appropriate place
to keep a kind of ordering in all checks.
Also, I've changed a word to mention "API":
MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver'

Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf

[Ferruh Yigit]

On 11/28/2023 11:47 AM, lihuisong (C) wrote:
> 
> 在 2023/11/28 18:35, Ferruh Yigit 写道:
>> On 11/28/2023 6:09 AM, Huisong Li wrote:
>>> Add Traffic Manager feature for iavf.
>>>
>>> Cc: sta...@dpdk.org
>>>
>>> Signed-off-by: Huisong Li 
>>> ---
>>>   doc/guides/nics/features/iavf.ini | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/doc/guides/nics/features/iavf.ini
>>> b/doc/guides/nics/features/iavf.ini
>>> index db4f92ce71..385799c650 100644
>>> --- a/doc/guides/nics/features/iavf.ini
>>> +++ b/doc/guides/nics/features/iavf.ini
>>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>>>   Packet type parsing  = Y
>>>   Rx descriptor status = Y
>>>   Tx descriptor status = Y
>>> +Traffic manager  = Y
>>>   Inline crypto    = Y
>>>   Basic stats  = Y
>>>   Multiprocess aware   = Y
>> Can you please keep the order in the default.ini and other files same,
>> here 'Inline crypto' seems put into wrong order that is causing the
>> confusion,
>> but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
>> .
> Hi Ferruh,
> 
> I find that there are many place which is different from the order of
> default.ini.
> And other drivers also have this problem.
> I want to do it for all drivers after this series.
> What do you think of that?
>

Agree to fix the order later with a separate patch, and keep the order
as best as possible in this series.

RE: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'

[Ori Kam]

Hi Joey,

> -Original Message-
> From: Sunyang Wu 
> Sent: Friday, November 24, 2023 5:31 AM
> To: dev@dpdk.org
> Cc: Ori Kam ; sta...@dpdk.org; Joey Xing
> 
> Subject: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'
> 
> Fix the issue of incorrect definition of 'NVGRE_ENCAP', and
> modified the error comments of 'rte_flow_action_nvgre_encap'.
> 
> Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter")
> Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Joey Xing 
> Signed-off-by: Sunyang Wu 
> ---

Acked-by: Ori Kam 
Best,
Ori

Re: [PATCH 02/11] doc: add Traffic Manager feature for iavf

[lihuisong (C)]

在 2023/11/28 19:55, Ferruh Yigit 写道:

On 11/28/2023 11:47 AM, lihuisong (C) wrote:

在 2023/11/28 18:35, Ferruh Yigit 写道:

On 11/28/2023 6:09 AM, Huisong Li wrote:

Add Traffic Manager feature for iavf.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
   doc/guides/nics/features/iavf.ini | 1 +
   1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/iavf.ini
b/doc/guides/nics/features/iavf.ini
index db4f92ce71..385799c650 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -35,6 +35,7 @@ Inner L4 checksum    = Y
   Packet type parsing  = Y
   Rx descriptor status = Y
   Tx descriptor status = Y
+Traffic manager  = Y
   Inline crypto    = Y
   Basic stats  = Y
   Multiprocess aware   = Y

Can you please keep the order in the default.ini and other files same,
here 'Inline crypto' seems put into wrong order that is causing the
confusion,
but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
.

Hi Ferruh,

I find that there are many place which is different from the order of
default.ini.
And other drivers also have this problem.
I want to do it for all drivers after this series.
What do you think of that?


Agree to fix the order later with a separate patch, and keep the order
as best as possible in this series.


ok，will adjust the order of this file a little bit.


.

[PATCH v2 00/11] add Traffic Manager feature

[Huisong Li]

The traffic management API has been introduced for a long time, please see
commit 5d109deffa87 ("ethdev: add traffic management API").
And many PMD also support this feature. So this series add this feature to
features.rst, default.ini and driver.ini.

---
 v2:
  - fix the order of some feature for patch 2/11, 8/11 and 11/11.

Huisong Li (11):
  doc: add Traffic Manager feature
  doc: add Traffic Manager feature for iavf
  doc: add Traffic Manager feature for i40e
  doc: add Traffic Manager feature for ixgbe
  doc: add Traffic Manager feature for cnxk
  doc: add Traffic Manager feature for hns3
  doc: add Traffic Manager feature for txgbe
  doc: add Traffic Manager feature for mvpp2
  doc: add Traffic Manager feature for dpaa2
  doc: add Traffic Manager feature for ipn3ke
  doc: add Traffic Manager feature for ice

 doc/guides/nics/features.rst | 13 +
 doc/guides/nics/features/cnxk.ini|  1 +
 doc/guides/nics/features/default.ini |  1 +
 doc/guides/nics/features/dpaa2.ini   |  1 +
 doc/guides/nics/features/hns3.ini|  1 +
 doc/guides/nics/features/i40e.ini|  1 +
 doc/guides/nics/features/iavf.ini|  3 ++-
 doc/guides/nics/features/ice.ini |  1 +
 doc/guides/nics/features/ice_dcf.ini |  1 +
 doc/guides/nics/features/ipn3ke.ini  |  1 +
 doc/guides/nics/features/ixgbe.ini   |  1 +
 doc/guides/nics/features/mvpp2.ini   |  3 ++-
 doc/guides/nics/features/txgbe.ini   |  1 +
 13 files changed, 27 insertions(+), 2 deletions(-)

-- 
2.33.0

[PATCH v2 02/11] doc: add Traffic Manager feature for iavf

[Huisong Li]

Add Traffic Manager feature for iavf and fix the position of "Inline
crypto" feature to keep the order of default.ini as best as possible.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/iavf.ini | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/iavf.ini 
b/doc/guides/nics/features/iavf.ini
index db4f92ce71..c59115ae15 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -25,6 +25,8 @@ RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
 VLAN filter  = Y
+Traffic manager  = Y
+Inline crypto= Y
 CRC offload  = Y
 VLAN offload = P
 L3 checksum offload  = Y
@@ -35,7 +37,6 @@ Inner L4 checksum= Y
 Packet type parsing  = Y
 Rx descriptor status = Y
 Tx descriptor status = Y
-Inline crypto= Y
 Basic stats  = Y
 Multiprocess aware   = Y
 FreeBSD  = Y
-- 
2.33.0

[PATCH v2 01/11] doc: add Traffic Manager feature

[Huisong Li]

Add Traffic Manager feature.

Fixes: 5d109deffa87 ("ethdev: add traffic management API")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
Acked-by: Ferruh Yigit 
Acked-by: Hemant Agrawal 
Acked-by: Cristian Dumitrescu 
---
 doc/guides/nics/features.rst | 13 +
 doc/guides/nics/features/default.ini |  1 +
 2 files changed, 14 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 1a1dc16c1e..e93b97a5b8 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -740,6 +740,19 @@ Supports congestion management.
   ``rte_eth_cman_config_set()``, ``rte_eth_cman_config_get()``.
 
 
+.. _nic_features_traffic_manager:
+
+Traffic manager
+---
+
+Supports Traffic manager.
+
+* **[implements] rte_tm_ops**: ``capabilities_get``, ``shaper_profile_add``,
+  ``hierarchy_commit`` and so on.
+* **[related]API**: ``rte_tm_capabilities_get()``, 
``rte_tm_shaper_profile_add()``,
+  ``rte_tm_hierarchy_commit()`` and so on.
+
+
 .. _nic_features_fw_version:
 
 FW version
diff --git a/doc/guides/nics/features/default.ini 
b/doc/guides/nics/features/default.ini
index 806cb033ff..64ee0f8c2f 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -42,6 +42,7 @@ VLAN filter  =
 Flow control =
 Rate limitation  =
 Congestion management =
+Traffic manager  =
 Inline crypto=
 Inline protocol  =
 CRC offload  =
-- 
2.33.0

[PATCH v2 03/11] doc: add Traffic Manager feature for i40e

[Huisong Li]

Add Traffic Manager feature for i40e.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/i40e.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/i40e.ini 
b/doc/guides/nics/features/i40e.ini
index e241dad047..2d168199f0 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -27,6 +27,7 @@ SR-IOV   = Y
 DCB  = Y
 VLAN filter  = Y
 Flow control = Y
+Traffic manager  = Y
 CRC offload  = Y
 VLAN offload = Y
 QinQ offload = P
-- 
2.33.0

[PATCH v2 04/11] doc: add Traffic Manager feature for ixgbe

[Huisong Li]

Add Traffic Manager feature for ixgbe.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ixgbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ixgbe.ini 
b/doc/guides/nics/features/ixgbe.ini
index 8590ac857f..f05fcec455 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -27,6 +27,7 @@ DCB  = Y
 VLAN filter  = Y
 Flow control = Y
 Rate limitation  = Y
+Traffic manager  = Y
 Inline crypto= Y
 CRC offload  = P
 VLAN offload = P
-- 
2.33.0

[PATCH v2 06/11] doc: add Traffic Manager feature for hns3

[Huisong Li]

Add Traffic Manager feature for hns3.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/hns3.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/hns3.ini 
b/doc/guides/nics/features/hns3.ini
index 338b4e6864..a20ece20e8 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -28,6 +28,7 @@ RSS reta update  = Y
 DCB  = Y
 VLAN filter  = Y
 Flow control = Y
+Traffic manager  = Y
 CRC offload  = Y
 VLAN offload = Y
 FEC  = Y
-- 
2.33.0

[PATCH v2 07/11] doc: add Traffic Manager feature for txgbe

[Huisong Li]

Add Traffic Manager feature for txgbe.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/txgbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/txgbe.ini 
b/doc/guides/nics/features/txgbe.ini
index e21083052c..3a11fb2037 100644
--- a/doc/guides/nics/features/txgbe.ini
+++ b/doc/guides/nics/features/txgbe.ini
@@ -26,6 +26,7 @@ DCB  = Y
 VLAN filter  = Y
 Flow control = Y
 Rate limitation  = Y
+Traffic manager  = Y
 Inline crypto= Y
 CRC offload  = P
 VLAN offload = P
-- 
2.33.0

[PATCH v2 09/11] doc: add Traffic Manager feature for dpaa2

[Huisong Li]

Add Traffic Manager feature for dpaa2.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Hemant Agrawal 
---
 doc/guides/nics/features/dpaa2.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/dpaa2.ini 
b/doc/guides/nics/features/dpaa2.ini
index 26dc8c2178..f02da463d9 100644
--- a/doc/guides/nics/features/dpaa2.ini
+++ b/doc/guides/nics/features/dpaa2.ini
@@ -17,6 +17,7 @@ Unicast MAC filter   = Y
 RSS hash = Y
 VLAN filter  = Y
 Flow control = Y
+Traffic manager  = Y
 VLAN offload = Y
 L3 checksum offload  = Y
 L4 checksum offload  = Y
-- 
2.33.0

[PATCH v2 05/11] doc: add Traffic Manager feature for cnxk

[Huisong Li]

Add Traffic Manager feature for cnxk.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/cnxk.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/cnxk.ini 
b/doc/guides/nics/features/cnxk.ini
index ac7de9a0f0..f85813ab52 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -28,6 +28,7 @@ RSS key update   = Y
 RSS reta update  = Y
 Inner RSS= Y
 Congestion management = Y
+Traffic manager  = Y
 Inline protocol  = Y
 Flow control = Y
 Scattered Rx = Y
-- 
2.33.0

[PATCH v2 08/11] doc: add Traffic Manager feature for mvpp2

[Huisong Li]

Add Traffic Manager feature for mvpp2 and fix the position of "Flow
control" feature to keep the order of default.ini as best as possible.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/mvpp2.ini | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/features/mvpp2.ini 
b/doc/guides/nics/features/mvpp2.ini
index 653c9d08cb..ccc2c2d4f8 100644
--- a/doc/guides/nics/features/mvpp2.ini
+++ b/doc/guides/nics/features/mvpp2.ini
@@ -12,8 +12,9 @@ Allmulticast mode= Y
 Unicast MAC filter   = Y
 Multicast MAC filter = Y
 RSS hash = Y
-Flow control = Y
 VLAN filter  = Y
+Flow control = Y
+Traffic manager  = Y
 CRC offload  = Y
 L3 checksum offload  = Y
 L4 checksum offload  = Y
-- 
2.33.0

[PATCH v2 11/11] doc: add Traffic Manager feature for ice

[Huisong Li]

Add Traffic Manager feature for ice.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ice.ini | 1 +
 doc/guides/nics/features/ice_dcf.ini | 1 +
 2 files changed, 2 insertions(+)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 13f8871dcc..8febbc4f1e 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -26,6 +26,7 @@ RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
 VLAN filter  = Y
+Traffic manager  = Y
 CRC offload  = Y
 VLAN offload = Y
 QinQ offload = P
diff --git a/doc/guides/nics/features/ice_dcf.ini 
b/doc/guides/nics/features/ice_dcf.ini
index 3b11622d4c..0e86338990 100644
--- a/doc/guides/nics/features/ice_dcf.ini
+++ b/doc/guides/nics/features/ice_dcf.ini
@@ -22,6 +22,7 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 Unicast MAC filter   = Y
 VLAN filter  = Y
+Traffic manager  = Y
 VLAN offload = Y
 Extended stats   = Y
 Basic stats  = Y
-- 
2.33.0

[PATCH v2 10/11] doc: add Traffic Manager feature for ipn3ke

[Huisong Li]

Add Traffic Manager feature for ipn3ke.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Rosen Xu 
---
 doc/guides/nics/features/ipn3ke.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ipn3ke.ini 
b/doc/guides/nics/features/ipn3ke.ini
index 1f6b780273..e412978820 100644
--- a/doc/guides/nics/features/ipn3ke.ini
+++ b/doc/guides/nics/features/ipn3ke.ini
@@ -25,6 +25,7 @@ SR-IOV   = Y
 DCB  = Y
 VLAN filter  = Y
 Flow control = Y
+Traffic manager  = Y
 CRC offload  = Y
 VLAN offload = Y
 QinQ offload = Y
-- 
2.33.0

Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature

[lihuisong (C)]

在 2023/11/28 19:52, Ferruh Yigit 写道:

On 11/28/2023 11:29 AM, lihuisong (C) wrote:

在 2023/11/28 18:09, Ferruh Yigit 写道:

On 11/28/2023 1:21 AM, lihuisong (C) wrote:

在 2023/11/27 23:43, Ferruh Yigit 写道:

On 11/27/2023 1:12 PM, lihuisong (C) wrote:

在 2023/11/27 20:19, Ferruh Yigit 写道:

On 11/25/2023 1:47 AM, Huisong Li wrote:

Add hash algorithm feature introduced by 23.11 and fix some RSS
features
description.

Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
     doc/guides/nics/features.rst | 26 ++
     1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/doc/guides/nics/features.rst
b/doc/guides/nics/features.rst
index 1a1dc16c1e..0d38c5c525 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -277,10 +277,12 @@ RSS hash
     Supports RSS hashing on RX.
       * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` =
``RTE_ETH_MQ_RX_RSS_FLAG``.
-* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
+* **[uses] user config**: ``rss_conf.rss_hf``.


Feature title is "RSS hash", it can be two things,
1. "Receive Side Scaling" support
2. Provide RSS hash to application

When this document first prepared RSS hash value was always
provided to
the application when RSS enabled.
So intention with this feature was "Receive Side Scaling" support,
hence
'RTE_ETH_MQ_RX_RSS_FLAG' added.

Later providing RSS has to the application separated as optimization,
'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for
this
support.

What should I do for above two comments？
To tell application how to use it?


Just tried to give some context.

got it.
  

As the intention of this feature is "Receive Side Scaling"
support, we
shouldn't reduce configuration struct to 'rss_conf.rss_hf'.

Instead perhaps can expand to:
'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf'

    I just pick their common part.😁

ok, will fix it.


     * **[uses] rte_eth_rxconf,rte_eth_rxmode**:
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
     * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
     * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``,
``mbuf.rss``.
+* **[related]  API**: ``rte_eth_dev_configure``,
``rte_eth_dev_rss_hash_update``
+  ``rte_eth_dev_rss_hash_conf_get()``.
 

ack


       .. _nic_features_inner_rss:
@@ -288,7 +290,7 @@ Supports RSS hashing on RX.
     Inner RSS
     -
     -Supports RX RSS hashing on Inner headers.
+Supports RX RSS hashing on Inner headers by rte_flow API.
 

This should be clarified with details below, not sure if it
required to
limit description to rte_flow.

But this block like rte_flow_action_rss is from rte_flow.
And ethdev ops doesn't support inner RSS.
So I think it is ok.


Yes it is supported by rte_flow, and '[uses]' information should
already
clarify it.

Should we remove the 'rte_flow API' wrods I added in above description?


I think it can be removed.

The latest version(V5, only three fix doc patch) has been sent out.
Do we I need to send V6 for this?😂


Nope, no new version needed for this, I already acked the one with it,
but if there will be a new version this can be updated.

ok

Thanks Huisong for improving the documentation.


Willing to contribute my strength to the community.😁






And I guess similar confusion exist with the providing hash to user.
Need to check if rte_flow implementation puts hash to mbuf along with
doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload,
and update below items accordingly.

Do we need to tell user how to use it here?
I feel this document is a little simple and main to list interface for
user.
In addition, it is better that the more detail about RSS should be
presented  in rte_flow features.


No, I am not suggesting to add more detail.

My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be
correct, ethdev APIs checks offload flags, but does rte_flow
implementation check it?

As far as I know, It is possibly verified in PMD if have or required.

My suggestion is double check that piece of information and fix it if
required.



     * **[uses]    rte_flow_action_rss**: ``level``.
     * **[uses]    rte_eth_rxconf,rte_eth_rxmode**:
``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
@@ -303,9 +305,25 @@ RSS key update
     Supports configuration of Receive Side Scaling (RSS) hash
computation. Updating
     Receive Side Scaling (RSS) hash key.
     -* **[implements] eth_dev_ops**: ``rss_hash_update``,
``rss_hash_conf_get``.
+* **[implements] eth_dev_ops**: ``dev_configure``,
``rss_hash_update``, ``rss_hash_conf_get``.
+* **[uses] user config**: ``rss_conf.rss_key``,
``rss_conf.rss_key_len``
     * **[provides]   rte_eth_dev_info**: ``hash_key_size``.
-* **[related]    API**: ``rte_eth_dev_rss_hash_update()``,
+* **[related]    API**: ``rte_eth_dev_configure``,
``rte_eth_dev_rss_hash_update()``,
+  ``rte_eth_dev_rss_hash_c

[PATCH 00/16] add link speed configuration feature

[Huisong Li]

The link speed configuration feature which is from dev_conf.link_speeds
has been introduced for a long time. This setting interface is used to
set fixed speed and link autonegotiation with speed capabilities feature.
It is very important for NIC. For this, many PMDs have also supported
this feature.

So this series suggest that add this feature to features.rst, default.ini
and driver.ini.

Huisong Li (16):
  doc: add features for link speeds
  doc: add link speed configuration feature for i40e
  doc: add link speed configuration feature for bnxt
  doc: add link speed configuration feature for igc
  doc: add link speed configuration feature for ixgbe
  doc: add link speed configuration feature for atlantic
  doc: add link speed configuration feature for octeontx
  doc: add link speed configuration feature for hns3
  doc: add link speed configuration feature for ngbe
  doc: add link speed configuration feature for txgbe
  doc: add link speed configuration feature for igb
  doc: add link speed configuration feature for thunderx
  doc: add link speed configuration feature for ice
  doc: add link speed configuration feature for ionic
  doc: add link speed configuration feature for dpaa
  doc: add link speed configuration feature for sfc

 doc/guides/nics/features.rst  | 11 +++
 doc/guides/nics/features/atlantic.ini |  1 +
 doc/guides/nics/features/bnxt.ini |  1 +
 doc/guides/nics/features/default.ini  |  1 +
 doc/guides/nics/features/dpaa.ini |  1 +
 doc/guides/nics/features/hns3.ini |  1 +
 doc/guides/nics/features/i40e.ini |  1 +
 doc/guides/nics/features/ice.ini  |  1 +
 doc/guides/nics/features/igb.ini  |  1 +
 doc/guides/nics/features/igc.ini  |  1 +
 doc/guides/nics/features/ionic.ini|  1 +
 doc/guides/nics/features/ixgbe.ini|  1 +
 doc/guides/nics/features/ngbe.ini |  1 +
 doc/guides/nics/features/octeontx.ini |  1 +
 doc/guides/nics/features/sfc.ini  |  1 +
 doc/guides/nics/features/thunderx.ini |  1 +
 doc/guides/nics/features/txgbe.ini|  1 +
 17 files changed, 27 insertions(+)

-- 
2.33.0

[PATCH 01/16] doc: add features for link speeds

[Huisong Li]

Add features for link speeds.

Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 doc/guides/nics/features.rst | 11 +++
 doc/guides/nics/features/default.ini |  1 +
 2 files changed, 12 insertions(+)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 1a1dc16c1e..f4285aba96 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -34,6 +34,17 @@ Supports getting the speed capabilities that the current 
device is capable of.
 * **[related]  API**: ``rte_eth_dev_info_get()``.
 
 
+.. _nic_features_link_speeds_config:
+
+Link speed configuration
+
+
+Supports configurating fixed speed and link autonegotiation.
+
+* **[uses] user config**: ``dev_conf.link_speeds:RTE_ETH_LINK_SPEED_*``.
+* **[related]  API**: ``rte_eth_dev_configure()``.
+
+
 .. _nic_features_link_status:
 
 Link status
diff --git a/doc/guides/nics/features/default.ini 
b/doc/guides/nics/features/default.ini
index 806cb033ff..4de7d9765f 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -8,6 +8,7 @@
 ;
 [Features]
 Speed capabilities   =
+Link speed configuration =
 Link status  =
 Link status event=
 Removal event=
-- 
2.33.0

[PATCH 03/16] doc: add link speed configuration feature for bnxt

[Huisong Li]

Add link speed configuration feature for bnxt.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/bnxt.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/bnxt.ini 
b/doc/guides/nics/features/bnxt.ini
index bd4e2295dc..c33889663d 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 04/16] doc: add link speed configuration feature for igc

[Huisong Li]

Add link speed configuration feature for igc.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/igc.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nics/features/igc.ini
index 47d9344435..d6db18c1e8 100644
--- a/doc/guides/nics/features/igc.ini
+++ b/doc/guides/nics/features/igc.ini
@@ -4,6 +4,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 FW version   = Y
-- 
2.33.0

[PATCH 05/16] doc: add link speed configuration feature for ixgbe

[Huisong Li]

Add link speed configuration feature for ixgbe.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ixgbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ixgbe.ini 
b/doc/guides/nics/features/ixgbe.ini
index 8590ac857f..0ceffcd85d 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 07/16] doc: add link speed configuration feature for octeontx

[Huisong Li]

Add link speed configuration feature for octeontx.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/octeontx.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/octeontx.ini 
b/doc/guides/nics/features/octeontx.ini
index fa1e18b120..46ae8318a9 100644
--- a/doc/guides/nics/features/octeontx.ini
+++ b/doc/guides/nics/features/octeontx.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Lock-free Tx queue   = Y
-- 
2.33.0

[PATCH 06/16] doc: add link speed configuration feature for atlantic

[Huisong Li]

Add link speed configuration feature for atlantic.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/atlantic.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/atlantic.ini 
b/doc/guides/nics/features/atlantic.ini
index ef4155027c..29969c1493 100644
--- a/doc/guides/nics/features/atlantic.ini
+++ b/doc/guides/nics/features/atlantic.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Queue start/stop = Y
-- 
2.33.0

[PATCH 02/16] doc: add link speed configuration feature for i40e

[Huisong Li]

Add link speed configuration feature for i40e.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/i40e.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/i40e.ini 
b/doc/guides/nics/features/i40e.ini
index e241dad047..1c6a476a51 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 08/16] doc: add link speed configuration feature for hns3

[Huisong Li]

Add link speed configuration feature for hns3.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/hns3.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/hns3.ini 
b/doc/guides/nics/features/hns3.ini
index 338b4e6864..24e9784c25 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 09/16] doc: add link speed configuration feature for ngbe

[Huisong Li]

Add link speed configuration feature for ngbe.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ngbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ngbe.ini 
b/doc/guides/nics/features/ngbe.ini
index 2701c5f051..1dfd92e96b 100644
--- a/doc/guides/nics/features/ngbe.ini
+++ b/doc/guides/nics/features/ngbe.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Free Tx mbuf on demand = Y
-- 
2.33.0

[PATCH 10/16] doc: add link speed configuration feature for txgbe

[Huisong Li]

Add link speed configuration feature for txgbe.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/txgbe.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/txgbe.ini 
b/doc/guides/nics/features/txgbe.ini
index e21083052c..f697642783 100644
--- a/doc/guides/nics/features/txgbe.ini
+++ b/doc/guides/nics/features/txgbe.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 11/16] doc: add link speed configuration feature for igb

[Huisong Li]

Add link speed configuration feature for igb.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/igb.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/igb.ini b/doc/guides/nics/features/igb.ini
index 7b4af6f86c..ee2408f3ee 100644
--- a/doc/guides/nics/features/igb.ini
+++ b/doc/guides/nics/features/igb.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = P
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 12/16] doc: add link speed configuration feature for thunderx

[Huisong Li]

Add link speed configuration feature for thunderx.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/thunderx.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/thunderx.ini 
b/doc/guides/nics/features/thunderx.ini
index b33bb37c82..2ab8db7239 100644
--- a/doc/guides/nics/features/thunderx.ini
+++ b/doc/guides/nics/features/thunderx.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Queue start/stop = Y
-- 
2.33.0

[PATCH 13/16] doc: add link speed configuration feature for ice

[Huisong Li]

Add link speed configuration feature for ice.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ice.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 13f8871dcc..390558f495 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -8,6 +8,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH 14/16] doc: add link speed configuration feature for ionic

[Huisong Li]

Add link speed configuration feature for ionic.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/ionic.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/ionic.ini 
b/doc/guides/nics/features/ionic.ini
index af0fc5462a..64b2316288 100644
--- a/doc/guides/nics/features/ionic.ini
+++ b/doc/guides/nics/features/ionic.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Fast mbuf free   = Y
-- 
2.33.0

[PATCH 15/16] doc: add link speed configuration feature for dpaa

[Huisong Li]

Add link speed configuration feature for dpaa.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/dpaa.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/dpaa.ini 
b/doc/guides/nics/features/dpaa.ini
index a382c7160c..b136ed191a 100644
--- a/doc/guides/nics/features/dpaa.ini
+++ b/doc/guides/nics/features/dpaa.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Burst mode info  = Y
-- 
2.33.0

[PATCH 16/16] doc: add link speed configuration feature for sfc

[Huisong Li]

Add link speed configuration feature for sfc.

Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 doc/guides/nics/features/sfc.ini | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini
index 8a9198adcb..f9654e69ed 100644
--- a/doc/guides/nics/features/sfc.ini
+++ b/doc/guides/nics/features/sfc.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link speed configuration = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
-- 
2.33.0

[PATCH] net/ice: fix link update

[Qi Zhang]

The ice_aq_get_link_info function is not thread-safe. However,
it is possible to simultaneous invocations during both the dev_start
and the LSC interrupt handler, potentially leading to unexpected adminq
errors. This patch addresses the issue by introducing a thread-safe
wrapper that utilizes a spinlock.

Fixes: cf911d90e366 ("net/ice: support link update")
Cc: sta...@dpdk.org

Signed-off-by: Qi Zhang 
---
 drivers/net/ice/ice_ethdev.c | 26 --
 drivers/net/ice/ice_ethdev.h |  3 +++
 2 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 3ccba4db80..1f8ab5158a 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1804,6 +1804,7 @@ ice_pf_setup(struct ice_pf *pf)
}
 
pf->main_vsi = vsi;
+   rte_spinlock_init(&pf->link_lock);
 
return 0;
 }
@@ -3621,17 +3622,31 @@ ice_rxq_intr_setup(struct rte_eth_dev *dev)
return 0;
 }
 
+static enum ice_status
+ice_get_link_info_safe(struct ice_pf *pf, bool ena_lse,
+  struct ice_link_status *link)
+{
+   struct ice_hw *hw = ICE_PF_TO_HW(pf);
+   int ret;
+
+   rte_spinlock_lock(&pf->link_lock);
+
+   ret = ice_aq_get_link_info(hw->port_info, ena_lse, link, NULL);
+
+   rte_spinlock_unlock(&pf->link_lock);
+
+   return ret;
+}
+
 static void
 ice_get_init_link_status(struct rte_eth_dev *dev)
 {
-   struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
bool enable_lse = dev->data->dev_conf.intr_conf.lsc ? true : false;
struct ice_link_status link_status;
int ret;
 
-   ret = ice_aq_get_link_info(hw->port_info, enable_lse,
-  &link_status, NULL);
+   ret = ice_get_link_info_safe(pf, enable_lse, &link_status);
if (ret != ICE_SUCCESS) {
PMD_DRV_LOG(ERR, "Failed to get link info");
pf->init_link_up = false;
@@ -3996,7 +4011,7 @@ ice_link_update(struct rte_eth_dev *dev, int 
wait_to_complete)
 {
 #define CHECK_INTERVAL 50  /* 50ms */
 #define MAX_REPEAT_TIME 40  /* 2s (40 * 50ms) in total */
-   struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
struct ice_link_status link_status;
struct rte_eth_link link, old;
int status;
@@ -4010,8 +4025,7 @@ ice_link_update(struct rte_eth_dev *dev, int 
wait_to_complete)
 
do {
/* Get link status information from hardware */
-   status = ice_aq_get_link_info(hw->port_info, enable_lse,
- &link_status, NULL);
+   status = ice_get_link_info_safe(pf, enable_lse, &link_status);
if (status != ICE_SUCCESS) {
link.link_speed = RTE_ETH_SPEED_NUM_100M;
link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index abe6dcdc23..691893be13 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -548,6 +548,9 @@ struct ice_pf {
uint64_t rss_hf;
struct ice_tm_conf tm_conf;
uint16_t outer_ethertype;
+   /* lock prevent race condition between lsc interrupt handler
+* and link status update during dev_start */
+   rte_spinlock_t link_lock;
 };
 
 #define ICE_MAX_QUEUE_NUM  2048
-- 
2.31.1

Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

[Thomas Monjalon]

07/03/2023 13:05, Ankur Dwivedi:
> This patch series adds a validation in checkpatch tool to check if
> tracepoint is present in any new function added in ethdev, eventdev
> cryptodev and mempool library.
> 
> v5:
>  - Copied the build_map_changes function from check-symbol-change.sh to
>check-tracepoint.sh.
>  - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh.

Why did you decide to copy the function in v5,
instead of having a common file usable by different scripts?

Re: [PATCH 0/2] minor changes in script used for backports

[Thomas Monjalon]

These patches have been forgotten.
Adding more Cc.

18/04/2023 16:07, Thomas Monjalon:
> While looking again at git-log-fixes.sh,
> I've found a minor bug and a small improvement.
> 
> Thomas Monjalon (2):
>   devtools: fix check of multiple commits fixed at once
>   devtools: deduplicate function to mark fixes

Re: [PATCH v5 1/3] doc: fix the description of RSS related feature

[Thomas Monjalon]

28/11/2023 06:59, Huisong Li:
> This patch fixes the description of RSS feature.
> And the settinf ot hash algorithm is introduced by 23.11, so add it.
> 
> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
> 
> Signed-off-by: Huisong Li 
> Acked-by: Chengwen Feng 
> Acked-by: Ferruh Yigit 
> ---
>  * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` = 
> ``RTE_ETH_MQ_RX_RSS_FLAG``.
> -* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.
> +* **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf.rss_hf``. 
> ``rss_conf.rss_hf``

No need to keep dev_conf.rx_adv_conf

>  * **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>  * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
>  * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, 
> ``mbuf.rss``.
> +* **[related]  API**: ``rte_eth_dev_configure()``, 
> ``rte_eth_dev_rss_hash_update``
> +  ``rte_eth_dev_rss_hash_conf_get()``.
> +
> +Support RSS hash algorithm on Rx.
> +
> +* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, 
> ``rss_hash_conf_get``.
> +* **[uses] user config**: ``rss_conf.algorithm``
> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``.
> +* **[related]API**: ``rte_eth_dev_configure()``, 
> ``rte_eth_dev_rss_hash_update()``,
> +  ``rte_eth_dev_rss_hash_conf_get()``.

Fixed typos, alignment and applied, thanks.

Note: the rest of the series is not applied in 23.11.
They are additions which may require reviews.

[PATCH 1/1] ml/cnxk: exclude caching run stats from xstats

[Srikanth Yalavarthi]

From: Anup Prabhu 

Exclude the hardware and firmware latency of model data
caching run from xstats calculation.

Fixes: 9cfad6c334f2 ("ml/cnxk: update device and model xstats functions")

Signed-off-by: Anup Prabhu 
Acked-by: Srikanth Yalavarthi 
---
 drivers/ml/cnxk/cn10k_ml_ops.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
index 7f7e5efceac..53700387335 100644
--- a/drivers/ml/cnxk/cn10k_ml_ops.c
+++ b/drivers/ml/cnxk/cn10k_ml_ops.c
@@ -288,6 +288,7 @@ cn10k_ml_model_xstat_get(struct cnxk_ml_dev *cnxk_mldev, 
struct cnxk_ml_layer *l
 static int
 cn10k_ml_cache_model_data(struct cnxk_ml_dev *cnxk_mldev, struct cnxk_ml_layer 
*layer)
 {
+   struct cn10k_ml_layer_xstats *xstats;
char str[RTE_MEMZONE_NAMESIZE];
const struct plt_memzone *mz;
uint64_t isize = 0;
@@ -309,6 +310,16 @@ cn10k_ml_cache_model_data(struct cnxk_ml_dev *cnxk_mldev, 
struct cnxk_ml_layer *
  PLT_PTR_ADD(mz->addr, isize), 1);
plt_memzone_free(mz);
 
+   /* Reset sync xstats. */
+   xstats = layer->glow.sync_xstats;
+   xstats->hw_latency_tot = 0;
+   xstats->hw_latency_min = UINT64_MAX;
+   xstats->hw_latency_max = 0;
+   xstats->fw_latency_tot = 0;
+   xstats->fw_latency_min = UINT64_MAX;
+   xstats->fw_latency_max = 0;
+   xstats->dequeued_count = 0;
+
return ret;
 }
 
-- 
2.42.0

RE: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

[Ankur Dwivedi]

>07/03/2023 13:05, Ankur Dwivedi:
>> This patch series adds a validation in checkpatch tool to check if
>> tracepoint is present in any new function added in ethdev, eventdev
>> cryptodev and mempool library.
>>
>> v5:
>>  - Copied the build_map_changes function from check-symbol-change.sh to
>>check-tracepoint.sh.
>>  - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh.
>
>Why did you decide to copy the function in v5, instead of having a common
>file usable by different scripts?
>
There was comments in v2 of the patch that common scripts may not work well and 
to keep the scripts specialized.

Re: [PATCH 2/2] devtools: deduplicate function to mark fixes

[Luca Boccassi]

On Tue, 18 Apr 2023 at 15:08, Thomas Monjalon  wrote:
>
> In the commit 8070d8fecb4e ("devtools: add fixes flag to commit listing")
> the function to mark a commit for "stable" was duplicated for "Fixes:" mark.
>
> The code is a bit smaller by using a single function for both marks.
>
> Signed-off-by: Thomas Monjalon 
> ---
>  devtools/git-log-fixes.sh | 22 ++
>  1 file changed, 6 insertions(+), 16 deletions(-)

Acked-by: Luca Boccassi 

Re: [PATCH 1/2] devtools: fix check of multiple commits fixed at once

[Luca Boccassi]

On Tue, 18 Apr 2023 at 15:08, Thomas Monjalon  wrote:
>
> When looking for fixes to backport,
> only the first origin commit hash (from "Fixes:") was checked.
> There is very little chance that the next commits being fixed
> have a wrong hash in the commit log of the fix,
> but it is fixed by checking them all before proceeding further.
>
> Fixes: 752d8e097ec1 ("scripts: show fixes with release version of bug")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Thomas Monjalon 
> ---
>  devtools/git-log-fixes.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Luca Boccassi 

Re: [PATCH v2] doc: update release notes for 23.11

[Thomas Monjalon]

24/11/2023 16:20, John McNamara:
> Fix grammar, spelling and formatting of DPDK 23.11 release notes.
> 
> Signed-off-by: John McNamara 
> ---
>  * **Added support for power intrinsics with AMD processors.**
>  
> +  Added power intrinsics support for AMD processors.

Replacing with:

  Added AMD ``MONITORX``/``MWAITX`` instructions in EAL for power optimisation.

Removed comments, and applied, thanks.

RE: [PATCH v7 1/2] vfio: add get device info API

[Gupta, Nipun]

[AMD Official Use Only - General]

> -Original Message-
> From: Mingjin Ye 
> Sent: Wednesday, November 22, 2023 3:53 PM
> To: dev@dpdk.org
> Cc: qiming.y...@intel.com; Mingjin Ye ; Anatoly
> Burakov 
> Subject: [PATCH v7 1/2] vfio: add get device info API
>
> This patch adds an API to support getting device information.
>
> The driver can use the "rte_vfio_get_device_info" helper to get
> device information from EAL.
>
> Signed-off-by: Mingjin Ye 

Acked-by: Nipun Gupta 

Re: [PATCH v2] eal/linux: force iova-mode va without pa available

[Christian Ehrhardt]

On Fri, Nov 24, 2023 at 11:29 AM Dmitry Kozlyuk 
wrote:

> 2023-11-24 11:09 (UTC+0100), christian.ehrha...@canonical.com:
> [...]
> > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
> > index 57da058cec..2f1fce3c54 100644
> > --- a/lib/eal/linux/eal.c
> > +++ b/lib/eal/linux/eal.c
> > @@ -1067,6 +1067,16 @@ rte_eal_init(int argc, char **argv)
> >
> >   phys_addrs = rte_eal_using_phys_addrs() != 0;
> >
> > + if (!phys_addrs) {
> > + /* if we have no access to physical addresses, pick IOVA
> as VA mode. */
> > + if (internal_conf->iova_mode == RTE_IOVA_PA)
> > + RTE_LOG(WARNING, EAL, "WARNING: --iova-mode=pa,
> but Physical addresses are unavailable, selecting IOVA as VA mode.\n");
>
> If an impossible combination of options is requested,
> initialization should fail instead.
>

You are absolutely right Dmitry.
In fact I was only trying to rebase an old patch that we used to carry.
But the more I look at and think about it the less I like the approach.

A production setup has an admin that should do this consciously.
What we actually should change is not the behavior of EAL, but just the
test automation to work on no-huge ppc64.
That is simpler and has much less impact and therefore probably is the
right solution.

Consider this patch here withdrawn.
I'll submit the fix to the tests in a few seconds.


> > + else
> > + RTE_LOG(DEBUG, EAL, "Physical addresses are
> unavailable, selecting IOVA as VA mode.\n");
> > + internal_conf->iova_mode = RTE_IOVA_VA;
> > + rte_eal_get_configuration()->iova_mode =
> internal_conf->iova_mode;
> > + }
> > +
> >   /* if no EAL option "--iova-mode=", use bus IOVA scheme */
> >   if (internal_conf->iova_mode == RTE_IOVA_DC) {
> >   /* autodetect the IOVA mapping mode */
>
> What do you think about keeping the existing code structure:
>
> if (--iova-mode not specified) {
> iova_mode = VA if !phys_addrs or !RTE_IOVA_IN_MBUF (with logs)
> if (iova_mode == DC) {
> // autodetect from bus requirements and IOMMU (with logs)
> }
> rte_eal_get_configuration()->iova_mode = iova_mode;
> } else {
> rte_eal_get_configuration()->iova_mode =
> internal_conf->iova_mode;
> }
> // verify rte_eal_get_configuration()->iova_mode
>
> Note: the logic should be consistent across OS when possible.
>
>

-- 
Christian Ehrhardt
Director of Engineering, Ubuntu Server
Canonical Ltd

[PATCH] test: set iova=va mode on ppc64 with --no-huge

[christian . ehrhardt]

From: Christian Ehrhardt 

On ppc64, without huge pages, pa would be the default but fails like:
  EAL: Cannot use IOVA as 'PA' since physical addresses are not available

On a normal system setup we'd expect an admin to set up huge pages
and for the unlikely case that they do not do that set iova=va
themselve. But the testing infrastructure does not have this conscious
admin that will do that, so fix test execution that by adjusting the
tests arguments accordingly if the conditions are met.

Signed-off-by: Christian Ehrhardt 
---
 app/test/suites/meson.build | 8 
 1 file changed, 8 insertions(+)

diff --git a/app/test/suites/meson.build b/app/test/suites/meson.build
index 478f245a54..8efbb165bf 100644
--- a/app/test/suites/meson.build
+++ b/app/test/suites/meson.build
@@ -10,6 +10,14 @@ test_no_huge_args = ['--no-huge', '-m', '2048']
 has_hugepage = run_command(has_hugepages_cmd, check: true).stdout().strip() != 
'0'
 message('hugepage availability: @0@'.format(has_hugepage))
 
+# On ppc64, without huge pages, pa would be the default but fails like:
+# EAL: Cannot use IOVA as 'PA' since physical addresses are not available
+if not has_hugepage
+if arch_subdir == 'ppc'
+test_no_huge_args += '--iova-mode=va'
+endif
+endif
+
 # process source files to determine the different unit test suites
 # - fast_tests
 # - perf_tests
-- 
2.34.1

Re: [PATCH] test: set iova=va mode on ppc64 with --no-huge

[Luca Boccassi]

On Tue, 28 Nov 2023 at 14:40,  wrote:
>
> From: Christian Ehrhardt 
>
> On ppc64, without huge pages, pa would be the default but fails like:
>   EAL: Cannot use IOVA as 'PA' since physical addresses are not available
>
> On a normal system setup we'd expect an admin to set up huge pages
> and for the unlikely case that they do not do that set iova=va
> themselve. But the testing infrastructure does not have this conscious
> admin that will do that, so fix test execution that by adjusting the
> tests arguments accordingly if the conditions are met.
>
> Signed-off-by: Christian Ehrhardt 
> ---
>  app/test/suites/meson.build | 8 
>  1 file changed, 8 insertions(+)

Acked-by: Luca Boccassi 

RE: [RFC PATCH] ethdev: introduce NAT64 action

[Bing Zhao]

Hi Ferruh,

The full patch set will be sent for the coming 24.03 release.

Thank you.

> -Original Message-
> From: Ferruh Yigit 
> Sent: Tuesday, October 10, 2023 5:56 PM
> To: Ori Kam ; Bing Zhao ; NBU-
> Contact-Thomas Monjalon (EXTERNAL) ;
> andrew.rybche...@oktetlabs.ru
> Cc: dev@dpdk.org
> Subject: Re: [RFC PATCH] ethdev: introduce NAT64 action
> 
> External email: Use caution opening links or attachments
> 
> 
> On 9/21/2023 4:45 PM, Ferruh Yigit wrote:
> > On 9/19/2023 11:05 AM, Ori Kam wrote:
> >> Hi Bing
> >>
> >>> -Original Message-
> >>> From: Bing Zhao 
> >>> Sent: Friday, August 11, 2023 5:07 PM
> >>> Subject: [RFC PATCH] ethdev: introduce NAT64 action
> >>>
> >>> In order to support the communication between IPv4 and IPv6 nodes in
> >>> the network, different technologies are used, like dual-stacks,
> >>> tunneling and NAT64. In some IPv4-only clients, it is hard to deploy
> >>> new software and hardware to support IPv6.
> >>>
> >>> NAT64 is a choice and it will also reduce the unnecessary overhead
> >>> of the traffic in the network. The NAT64 gateways take the
> >>> responsibility of the packet headers translation between the IPv6
> >>> clouds and IPv4-only clouds.
> >>>
> >>> This action should support the offloading of the IP headers'
> >>> translation. The following fields should be reset correctly in the
> >>> translation.
> >>>   - Version
> >>>   - Traffic Class / TOS
> >>>   - Flow Label (0 in v4)
> >>>   - Payload Length / Total length
> >>>   - Next Header
> >>>   - Hop Limit / TTL
> >>>
> >>> Since there are different mapping and translating modes of the
> >>> addresses, it will depend on the capabilities of each vendor.
> >>>
> >>> The ICMP* and transport layers protocol is out of the scope of NAT64
> >>> rte_flow action.
> >>>
> >>> Reference links:
> >>>   - https://datatracker.ietf.org/doc/html/rfc6146
> >>>   - https://datatracker.ietf.org/doc/html/rfc6052
> >>>   - https://datatracker.ietf.org/doc/html/rfc6145
> >>>
> >>> Signed-off-by: Bing Zhao 
> >>> ---
> >>
> >> Acked-by: Ori Kam 
> >>
> >
> > Hi Bing,
> >
> > This is a RFC, but we are not having more comment & objection, so what
> > do you think to continue with a patch including testpmd implementation?
> >
> >
> 
> Hi Bing, what is the latest status of the patch?

BR. Bing

Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

[Thomas Monjalon]

28/11/2023 15:07, Ankur Dwivedi:
> >07/03/2023 13:05, Ankur Dwivedi:
> >> This patch series adds a validation in checkpatch tool to check if
> >> tracepoint is present in any new function added in ethdev, eventdev
> >> cryptodev and mempool library.
> >>
> >> v5:
> >>  - Copied the build_map_changes function from check-symbol-change.sh to
> >>check-tracepoint.sh.
> >>  - Added eventdev, cryptodev and mempool in libdir in check-tracepoint.sh.
> >
> >Why did you decide to copy the function in v5, instead of having a common
> >file usable by different scripts?
> >
> There was comments in v2 of the patch that common scripts may not work well 
> and to keep the scripts specialized.

I meant you can have a common file specialized in symbols.
In general, you should reply, establish a discussion, so we share the same 
understanding.

DPDK 23.11 released

[David Marchand]

A new major release is available:
https://fast.dpdk.org/rel/dpdk-23.11.tar.xz

The number of commits has been stable for the 23.xx releases:
1161 commits from 161 authors
1647 files changed, 97078 insertions(+), 44688 deletions(-)

The branch 23.11 should be supported for three years,
making it recommended for system integration and deployment.

The new major ABI version is 24.
The next releases 24.03 and 24.07 will be ABI-compatible with 23.11.

Below are some highlights of this release:
- build requires C11 compiler
- early support of MSVC build
- new atomic operations API
- power management on AMD CPU
- mbuf recycling
- RSS algorithm management
- maximum Rx buffer size
- flow action type for P4-defined actions
- flow group miss action
- flow item for packet type matching
- TLS record offload
- security Rx inject
- eventdev link profiles
- eventdev adapter for dmadev
- event dispatcher library
- nfp vDPA driver
- graph application
- removed flow_classify library
- removed KNI library and driver

More details in the release notes:
https://doc.dpdk.org/guides/rel_notes/release_23_11.html


There are 40 new contributors (including authors, reviewers and testers).
Welcome to Alan Brady, Ales Musil, Andrey Ignatov, Artemy Kovalyov,
Chang Miao, Fengjiang Liu, Igor de Paula, Jayaprakash Shanmugam,
John Romein, Jonathan Erb, Jonathan Tsai, Josh Hay, Julian Grajkowski,
Karen Kelly, Kuan Xu, Madhu Chittim, Mahesh Adulla, Matthew Dirba,
Paul Szczepanek, Peter Nilsson, Sam Andrew, Sampath Peechu,
Saurabh Singhal, Shailendra Bhatnagar, Shihong Wang, Shubham Rohila,
Shujing Dong, Sibaranjan Pattnayak, Sinan Kaya, Sivaprasad Tummala,
Sivaramakrishnan Venkat, Timothy Miskell, Tomer Shmilovich, Trevor Tao,
Trevor Tao, Vamsi Krishna Attunuru, Wajeeh Atrash, Wei Hu,
Xiaoming Jiang, Zhenning Xiao.

Below is the number of commits per employer (with authors count):
240Marvell (29)
203Intel (39)
140Corigine (9)
139NVIDIA (25)
 96Huawei (4)
 90Red Hat (4)
 71Microsoft (5)
 64step...@networkplumber.org (1)
 24AMD (9)
 16NXP (4)
 13Trustnet (1)
 12Arm (5)
...

A big thank to all courageous people who took on the non rewarding task
of reviewing other's job.
Based on Reviewed-by and Acked-by tags, the top non-PMD reviewers are:
78 Morten Brørup 
60 Bruce Richardson 
55 David Marchand 
47 Ferruh Yigit 
33 Konstantin Ananyev 
29 Maxime Coquelin 
27 Tyler Retzlaff 
21 Chengwen Feng 
20 Stephen Hemminger 
20 Akhil Goyal 

A special thanks to Stephen Hemminger who started cleaning stale patches in
patchwork.
We still have many Bugzilla tickets and unattended patches, all help is
welcome.


The next version will be 24.03 in March.
The new features for 24.03 can be submitted during the next weeks:
http://core.dpdk.org/roadmap#dates

Please share your roadmap.

Thanks everyone!


-- 
David Marchand

[Bug 1326] rxtx_offload/txoffload_port: tx_offload switch is opposite to expected

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1326

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Thomas Monjalon (tho...@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=d407a155e0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1269] test-dma-perf running in iova-mode as PA for rte_memcpy results in seg-fault.

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1269

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Thomas Monjalon (tho...@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=2f2f7af667

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1271] Using dumpcap to capture packets with multiple pmds and enable mbuf check can lead to dpdk proc core

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1271

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Thomas Monjalon (tho...@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=27a26d65f8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 870] Fragmented packets incorrect RSS distribution with TAP PMD on Hyper-V platform

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=870

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Thomas Monjalon (tho...@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=db6a3ddb16

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1295] Virtio driver, packed mode, the first desc misses the next flag, causing the message to be sent abnormally

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1295

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Thomas Monjalon (tho...@monjalon.net) ---
Resolved in http://git.dpdk.org/dpdk/commit/?id=f923636411

-- 
You are receiving this mail because:
You are the assignee for the bug.

[PATCH v1] maintainers: remove tianfei from ifpga

[Wei Huang]

Signed-off-by: Wei Huang 
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0d1c812..6eedea1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1440,7 +1440,6 @@ Rawdev Drivers
 
 Intel FPGA
 M: Rosen Xu 
-M: Tianfei zhang 
 T: git://dpdk.org/next/dpdk-next-net-intel
 F: drivers/raw/ifpga/
 F: doc/guides/rawdevs/ifpga.rst
-- 
1.8.3.1

RE: [PATCH v1] maintainers: remove tianfei from ifpga

[Xu, Rosen]

Hi,

> -Original Message-
> From: Huang, Wei 
> Sent: Wednesday, November 29, 2023 9:45 AM
> To: dev@dpdk.org; tho...@monjalon.net
> Cc: sta...@dpdk.org; Xu, Rosen ; Mcnamara, John
> ; Huang, Wei 
> Subject: [PATCH v1] maintainers: remove tianfei from ifpga
> 
> Signed-off-by: Wei Huang 
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d1c812..6eedea1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1440,7 +1440,6 @@ Rawdev Drivers
> 
>  Intel FPGA
>  M: Rosen Xu 
> -M: Tianfei zhang 
>  T: git://dpdk.org/next/dpdk-next-net-intel
>  F: drivers/raw/ifpga/
>  F: doc/guides/rawdevs/ifpga.rst
> --
> 1.8.3.1

Acked-by: Rosen Xu 

Re: [PATCH v7 1/2] vfio: add get device info API

[Chenbo Xia]

On Nov 22, 2023, at 18:22, Mingjin Ye  wrote:
> 
> External email: Use caution opening links or attachments
> 
> 
> This patch adds an API to support getting device information.
> 
> The driver can use the "rte_vfio_get_device_info" helper to get
> device information from EAL.
> 
> Signed-off-by: Mingjin Ye 
> ---
> lib/eal/include/rte_vfio.h | 29 +
> lib/eal/linux/eal_vfio.c   | 27 +++
> lib/eal/version.map|  3 +++
> 3 files changed, 59 insertions(+)
> 

Comments not addressed:

https://mails.dpdk.org/archives/dev/2023-November/282200.html

/Chenbo

[PATCH v5 00/10] Replace zero length arrays

[Stephen Hemminger]

Zero length arrays are a GNU extension that has been
superseded by flex arrays.

https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html

These are places found by cocci/zero_length_array.cocci

v5 - revised version of dpaxx ip_hdr fix
 rebase to 23.11

Stephen Hemminger (10):
  member: replace zero length array with flex array
  cryptodev: replace zero length array with flex array
  security: replace zero length array with flex array
  pipeline: replace zero length array with flex array
  net/nfp: replace zero length array with flex array
  net/enic: replace zero length array with flex array
  net/mlx5: replace zero length array with flex array
  pdcp: replace zero length array with flex array
  net/cpfl: replace zero length array with flex array
  common/dpaxx: replace zero length array

 drivers/common/dpaax/caamflib/desc/ipsec.h | 20 ++--
 drivers/common/mlx5/mlx5_prm.h |  2 +-
 drivers/crypto/cnxk/cn10k_ipsec.h  |  4 +++-
 drivers/crypto/cnxk/cn9k_ipsec.h   |  4 +++-
 drivers/crypto/cnxk/cnxk_se.h  |  5 -
 drivers/net/cpfl/cpfl_flow_engine_fxp.c|  2 +-
 drivers/net/enic/base/vnic_devcmd.h|  2 +-
 drivers/net/mlx5/mlx5.h|  4 ++--
 drivers/net/mlx5/mlx5_flow.h   |  2 +-
 drivers/net/mlx5/mlx5_tx.h |  3 ++-
 drivers/net/nfp/flower/nfp_flower_cmsg.h   |  2 +-
 lib/cryptodev/cryptodev_pmd.h  |  2 +-
 lib/member/rte_member_heap.h   |  2 +-
 lib/pdcp/pdcp_entity.h |  2 +-
 lib/pipeline/rte_swx_pipeline_internal.h   |  2 +-
 lib/security/rte_security_driver.h |  2 +-
 16 files changed, 38 insertions(+), 22 deletions(-)

-- 
2.42.0

[PATCH v5 01/10] member: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
---
 lib/member/rte_member_heap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h
index 9c4a01aebe95..ab6319bc2de4 100644
--- a/lib/member/rte_member_heap.h
+++ b/lib/member/rte_member_heap.h
@@ -26,7 +26,7 @@ struct hash {
uint16_t bkt_cnt;
uint16_t num_item;
uint32_t seed;
-   struct hash_bkt buckets[0];
+   struct hash_bkt buckets[];
 };
 
 struct node {
-- 
2.42.0

[PATCH v5 02/10] cryptodev: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
Acked-by: Anoob Joseph 
---
 drivers/crypto/cnxk/cnxk_se.h | 5 -
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h
index c2a807fa9428..f86b859a08a4 100644
--- a/drivers/crypto/cnxk/cnxk_se.h
+++ b/drivers/crypto/cnxk/cnxk_se.h
@@ -29,8 +29,11 @@ enum cpt_dp_thread_type {
CPT_DP_THREAD_TYPE_PT,
 };
 
+#define SYM_SESS_SIZE sizeof(struct rte_cryptodev_sym_session)
+
 struct cnxk_se_sess {
-   struct rte_cryptodev_sym_session rte_sess;
+   uint8_t rte_sess[SYM_SESS_SIZE];
+
uint8_t aes_gcm : 1;
uint8_t aes_ccm : 1;
uint8_t aes_ctr : 1;
diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 3bb3d95c1338..0732b356883c 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -153,7 +153,7 @@ struct rte_cryptodev_sym_session {
 
RTE_MARKER cacheline1 __rte_cache_min_aligned;
/**< Second cache line - start of the driver session data */
-   uint8_t driver_priv_data[0];
+   uint8_t driver_priv_data[];
/**< Driver specific session data, variable size */
 };
 
-- 
2.42.0

[PATCH v5 03/10] security: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
Acked-by: Anoob Joseph 
---
 drivers/crypto/cnxk/cn10k_ipsec.h  | 4 +++-
 drivers/crypto/cnxk/cn9k_ipsec.h   | 4 +++-
 lib/security/rte_security_driver.h | 2 +-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/cnxk/cn10k_ipsec.h 
b/drivers/crypto/cnxk/cn10k_ipsec.h
index 8a93d7406204..144bc8319dea 100644
--- a/drivers/crypto/cnxk/cn10k_ipsec.h
+++ b/drivers/crypto/cnxk/cn10k_ipsec.h
@@ -24,8 +24,10 @@ struct cn10k_ipsec_sa {
};
 } __rte_aligned(ROC_ALIGN);
 
+#define SEC_SESS_SIZE sizeof(struct rte_security_session)
+
 struct cn10k_sec_session {
-   struct rte_security_session rte_sess;
+   uint8_t rte_sess[SEC_SESS_SIZE];
 
/** PMD private space */
 
diff --git a/drivers/crypto/cnxk/cn9k_ipsec.h b/drivers/crypto/cnxk/cn9k_ipsec.h
index 1ea946afd8a9..d28642e3a627 100644
--- a/drivers/crypto/cnxk/cn9k_ipsec.h
+++ b/drivers/crypto/cnxk/cn9k_ipsec.h
@@ -20,8 +20,10 @@ struct cn9k_ipsec_sa {
};
 } __rte_aligned(8);
 
+#define SEC_SESS_SIZE sizeof(struct rte_security_session)
+
 struct cn9k_sec_session {
-   struct rte_security_session rte_sess;
+   uint8_t rte_sess[SEC_SESS_SIZE];
 
/** PMD private space */
 
diff --git a/lib/security/rte_security_driver.h 
b/lib/security/rte_security_driver.h
index 62664dacdbb4..faa4074f1965 100644
--- a/lib/security/rte_security_driver.h
+++ b/lib/security/rte_security_driver.h
@@ -33,7 +33,7 @@ struct rte_security_session {
/**< session private data IOVA address */
 
RTE_MARKER cacheline1 __rte_cache_min_aligned;
-   uint8_t driver_priv_data[0];
+   uint8_t driver_priv_data[];
/**< Private session material, variable size (depends on driver) */
 };
 
-- 
2.42.0

[PATCH v5 04/10] pipeline: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
---
 lib/pipeline/rte_swx_pipeline_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/pipeline/rte_swx_pipeline_internal.h 
b/lib/pipeline/rte_swx_pipeline_internal.h
index a67b6e965de7..8ec12263b989 100644
--- a/lib/pipeline/rte_swx_pipeline_internal.h
+++ b/lib/pipeline/rte_swx_pipeline_internal.h
@@ -213,7 +213,7 @@ TAILQ_HEAD(rss_tailq, rss);
 
 struct rss_runtime {
uint32_t key_size; /* key size in bytes. */
-   uint8_t key[0]; /* key. */
+   uint8_t key[]; /* key. */
 };
 
 /*
-- 
2.42.0

[PATCH v5 05/10] net/nfp: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Acked-by: Niklas Söderlund 
Reviewed-by: Tyler Retzlaff 
Acked-by: Chaoyong He 
---
 drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.h 
b/drivers/net/nfp/flower/nfp_flower_cmsg.h
index c2938fb6f63c..f00d2e838d8f 100644
--- a/drivers/net/nfp/flower/nfp_flower_cmsg.h
+++ b/drivers/net/nfp/flower/nfp_flower_cmsg.h
@@ -73,7 +73,7 @@ struct nfp_flower_cmsg_mac_repr {
uint8_t info;
uint8_t nbi_port;
uint8_t phys_port;
-   } ports[0];
+   } ports[];
 };
 
 /*
-- 
2.42.0

[PATCH v5 06/10] net/enic: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Acked-by: John Daley 
Reviewed-by: Tyler Retzlaff 
---
 drivers/net/enic/base/vnic_devcmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/enic/base/vnic_devcmd.h 
b/drivers/net/enic/base/vnic_devcmd.h
index 253a791c3f65..f91cc3078d63 100644
--- a/drivers/net/enic/base/vnic_devcmd.h
+++ b/drivers/net/enic/base/vnic_devcmd.h
@@ -765,7 +765,7 @@ struct vnic_devcmd_notify {
 struct vnic_devcmd_provinfo {
uint8_t oui[3];
uint8_t type;
-   uint8_t data[0];
+   uint8_t data[];
 };
 
 /*
-- 
2.42.0

[PATCH v5 07/10] net/mlx5: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
Acked-by: Dariusz Sosnowski 
---
 drivers/common/mlx5/mlx5_prm.h | 2 +-
 drivers/net/mlx5/mlx5.h| 4 ++--
 drivers/net/mlx5/mlx5_flow.h   | 2 +-
 drivers/net/mlx5/mlx5_tx.h | 3 ++-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index 9e22dce6da13..932b89bd79d3 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -5181,7 +5181,7 @@ struct mlx5_ifc_flow_context_bits {
u8 reserved_at_e0[0x40];
u8 encrypt_decrypt_obj_id[0x20];
u8 reserved_at_140[0x16c0];
-   union mlx5_ifc_dest_format_flow_counter_list_auto_bits destination[0];
+   union mlx5_ifc_dest_format_flow_counter_list_auto_bits destination[];
 };
 
 struct mlx5_ifc_set_fte_in_bits {
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 263ebead7f29..f2e2e04429d1 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -1314,7 +1314,7 @@ struct mlx5_aso_ct_pool {
};
struct mlx5_aso_sq *sq; /* Async ASO SQ. */
struct mlx5_aso_sq *shared_sq; /* Shared ASO SQ. */
-   struct mlx5_aso_ct_action actions[0];
+   struct mlx5_aso_ct_action actions[];
/* CT action structures bulk. */
 };
 
@@ -1331,7 +1331,7 @@ struct mlx5_aso_ct_pools_mng {
rte_spinlock_t ct_sl; /* The ASO CT free list lock. */
rte_rwlock_t resize_rwl; /* The ASO CT pool resize lock. */
struct aso_ct_list free_cts; /* Free ASO CT objects list. */
-   struct mlx5_aso_sq aso_sqs[0]; /* ASO queue objects. */
+   struct mlx5_aso_sq aso_sqs[]; /* ASO queue objects. */
 };
 
 #ifdef PEDANTIC
diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 6dde9de688b9..b35079b30a6e 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -1257,7 +1257,7 @@ struct rte_flow_hw {
cnt_id_t cnt_id;
uint32_t mtr_id;
uint32_t rule_idx;
-   uint8_t rule[0]; /* HWS layer data struct. */
+   uint8_t rule[]; /* HWS layer data struct. */
 } __rte_packed;
 
 #ifdef PEDANTIC
diff --git a/drivers/net/mlx5/mlx5_tx.h b/drivers/net/mlx5/mlx5_tx.h
index e59ce37667ba..b1e8ea19a2a1 100644
--- a/drivers/net/mlx5/mlx5_tx.h
+++ b/drivers/net/mlx5/mlx5_tx.h
@@ -171,11 +171,12 @@ struct mlx5_txq_data {
struct mlx5_txq_stats stats; /* TX queue counters. */
struct mlx5_txq_stats stats_reset; /* stats on last reset. */
struct mlx5_uar_data uar_data;
-   struct rte_mbuf *elts[0];
+   struct rte_mbuf *elts[];
/* Storage for queued packets, must be the last field. */
 } __rte_cache_aligned;
 
 /* TX queue control descriptor. */
+__extension__
 struct mlx5_txq_ctrl {
LIST_ENTRY(mlx5_txq_ctrl) next; /* Pointer to the next element. */
uint32_t refcnt; /* Reference counter. */
-- 
2.42.0

[PATCH v5 08/10] pdcp: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
Acked-by: Anoob Joseph 
---
 lib/pdcp/pdcp_entity.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/pdcp/pdcp_entity.h b/lib/pdcp/pdcp_entity.h
index 4fc6342a5ced..f854192e98dc 100644
--- a/lib/pdcp/pdcp_entity.h
+++ b/lib/pdcp/pdcp_entity.h
@@ -185,7 +185,7 @@ struct entity_priv_dl_part {
/** Reorder packet buffer */
struct pdcp_reorder reorder;
/** Bitmap memory region */
-   uint8_t bitmap_mem[0];
+   uint8_t bitmap_mem[];
 };
 
 struct entity_priv_ul_part {
-- 
2.42.0

[PATCH v5 09/10] net/cpfl: replace zero length array with flex array

[Stephen Hemminger]

Zero length arrays are GNU extension. Replace with
standard flex array.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Tyler Retzlaff 
---
 drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c 
b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
index 8a4e1419b4db..39a281fa61ee 100644
--- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c
+++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
@@ -53,7 +53,7 @@ struct cpfl_rule_info_meta {
uint32_t pr_num;/* number of pattern rules */
uint32_t mr_num;/* number of modification rules 
*/
uint32_t rule_num;  /* number of all rules */
-   struct cpfl_rule_info rules[0];
+   struct cpfl_rule_info rules[];
 };
 
 static uint32_t cpfl_fxp_mod_idx_alloc(struct cpfl_adapter_ext *ad);
-- 
2.42.0

[PATCH v5 10/10] common/dpaxx: replace zero length array

[Stephen Hemminger]

The zero length ip_header is used as an overlay to the
encap IP header. Since the code is already assuming the layout
of the structure, replace the array with direct access.

Signed-off-by: Stephen Hemminger 
Acked-by: Hemant Agrawal 
---
 drivers/common/dpaax/caamflib/desc/ipsec.h | 20 ++--
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/drivers/common/dpaax/caamflib/desc/ipsec.h 
b/drivers/common/dpaax/caamflib/desc/ipsec.h
index 95fc3ea5ba3b..d1411cc6aab4 100644
--- a/drivers/common/dpaax/caamflib/desc/ipsec.h
+++ b/drivers/common/dpaax/caamflib/desc/ipsec.h
@@ -334,9 +334,7 @@ struct ipsec_encap_gcm {
  * @seq_num: IPsec sequence number
  * @spi: IPsec SPI (Security Parameters Index)
  * @ip_hdr_len: optional IP Header length (in bytes)
- *  reserved - 16b
- *  Opt. IP Hdr Len - 16b
- * @ip_hdr: optional IP Header content (only for IPsec legacy mode)
+ *  Ip header must follow directly after ipsec_encap_pdb
  */
 struct ipsec_encap_pdb {
uint32_t options;
@@ -350,7 +348,6 @@ struct ipsec_encap_pdb {
};
uint32_t spi;
uint32_t ip_hdr_len;
-   uint8_t ip_hdr[0];
 };
 
 static inline unsigned int
@@ -776,7 +773,12 @@ cnstr_shdsc_ipsec_encap(uint32_t *descbuf, bool ps, bool 
swap,
PROGRAM_SET_36BIT_ADDR(p);
phdr = SHR_HDR(p, share, hdr, 0);
__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);
-   COPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);
+
+   /* ip header if any follows the encap_pdb */
+   if (pdb->ip_hdr_len > 0) {
+   void *ip_hdr = pdb + 1;
+   COPY_DATA(p, ip_hdr, pdb->ip_hdr_len);
+   }
SET_LABEL(p, hdr);
pkeyjmp = JUMP(p, keyjmp, LOCAL_JUMP, ALL_TRUE, BOTH|SHRD);
if (authdata->keylen)
@@ -913,7 +915,13 @@ cnstr_shdsc_ipsec_encap_des_aes_xcbc(uint32_t *descbuf,
PROGRAM_CNTXT_INIT(p, descbuf, 0);
phdr = SHR_HDR(p, share, hdr, 0);
__rta_copy_ipsec_encap_pdb(p, pdb, cipherdata->algtype);
-   COPY_DATA(p, pdb->ip_hdr, pdb->ip_hdr_len);
+
+   /* ip header if any follows the encap_pdb */
+   if (pdb->ip_hdr_len > 0) {
+   void *ip_hdr = pdb + 1;
+   COPY_DATA(p, ip_hdr, pdb->ip_hdr_len);
+   }
+
SET_LABEL(p, hdr);
pkeyjump = JUMP(p, keyjump, LOCAL_JUMP, ALL_TRUE, SHRD | SELF);
/*
-- 
2.42.0

DPDK Tech Board Meeting - Tomorrow Wed. Nov. 29th - 7am Pacific/10am Eastern/1500h UTC, 1600h France Time

[Nathan Southern]

Good evening DPDK Community,

Tomorrow is our biweekly DPDK Tech Board meeting.  7am Pacific/10am
Eastern/1500h UTC, 1600h France Time. A read-only copy of the agenda can be
found here:

 https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db



And zoom information to follow. We look forward to seeing you there.

Many thanks,

Nathan

You have been invited to a recurring meeting for Data Plane Development Kit
(DPDK)

Ways to join meeting:

1. Join from PC, Mac, iPad, or Android

https://zoom-lfx.platform.linuxfoundation.org/meeting/96459488340?password=d808f1f6-0a28-4165-929e-5a5bcae7efeb


2. Join via audio

One tap mobile:
US: +12532158782,,96459488340# or +13462487799,,96459488340

Or dial:
US: +1 253 215 8782 or +1 346 248 7799 or +1 669 900 6833 or +1 301 715
8592 or +1 312 626 6799 or +1 646 374 8656 or 877 369 0926 (Toll Free) or
855 880 1246 (Toll Free)
Canada: +1 647 374 4685 or +1 647 558 0588 or +1 778 907 2071 or +1 204 272
7920 or +1 438 809 7799 or +1 587 328 1099 or 855 703 8985 (Toll Free)

Meeting ID: 96459488340

Meeting Passcode: 699526


International numbers: https://zoom.us/u/alwnPIaVT

RE: release candidate 23.11-rc4

[Xu, HailinX]

> -Original Message-
> From: Thomas Monjalon 
> Sent: Thursday, November 23, 2023 10:28 AM
> To: annou...@dpdk.org
> Subject: release candidate 23.11-rc4
> 
> A new DPDK release candidate is ready for testing:
>   https://git.dpdk.org/dpdk/tag/?id=v23.11-rc4
> 
> There are 58 new patches in this snapshot.
> 
> Release notes:
>   https://doc.dpdk.org/guides/rel_notes/release_23_11.html
> 
> There are more doc and tools updates to be merged before closing this
> release cycle.
> 
> Please check there is no major bug.
> 
> You may share some release validation results by replying to this message at
> dev@dpdk.org and by adding tested hardware in the release notes.
> 
> The final release should happen at the end of this week.
> 
> Please think about sharing your roadmap now for DPDK 24.03.
> 
> Thank you everyone
> 
Update the test status for Intel part. dpdk23.11-rc4 all test is done. found 
one new issues.

New issues:
1. command "port 0 txq 0 tx_offload vlan_insert off/on" reported an error. -> 
Intel dev is under investigating

# Basic Intel(R) NIC testing
* Build or compile:  
 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.3, Fedora38, 
RHEL8.7/9.2, Centos7.9, OpenAnolis8.8, CBL-Mariner2.0 etc.
  - All test passed.
 *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.2 
and RHEL9.0.
  - All test passed with latest dpdk.

* PF/VF(i40e, ixgbe): test scenarios including 
PF/VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
  - All test case is done. found 1 issue.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow 
Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
  - All test case is done. found 1 issue.
* MEV test: test scenarios including PF/TSO/MTU/Jumboframe/checksum offload, etc
  - All test case is done. No new issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single 
core performance test, RFC2544 Zero packet loss performance test, etc.
  - All test case is done. No new issue is found.
* Power and IPsec: 
 * Power: test scenarios including bi-direction/Telemetry/Empty Poll 
Lib/Priority Base Frequency, etc. 
  - All test case is done. No new issue is found.
 * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - 
QAT&SW/FIB library, etc.
  - All test case is done. No new issue is found.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 8.0, etc.
  - All test case is done. No new issue is found.
* Cryptodev: 
 *Function test: test scenarios including Cryptodev API testing/CompressDev 
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
  - All test case is done. No new issue is found. 
 *Performance test: test scenarios including Throughput Performance /Cryptodev 
Latency, etc.
  - All test case is done. No new issue is found.

Regards,
Xu, Hailin

RE: [PATCH 15/16] doc: add link speed configuration feature for dpaa

[Hemant Agrawal]

Acked-by: Hemant Agrawal 

> -Original Message-
> From: Huisong Li 
> Sent: Tuesday, November 28, 2023 6:30 PM
> To: dev@dpdk.org; ferruh.yi...@amd.com; tho...@monjalon.net; Hemant
> Agrawal ; Sachin Saxena
> 
> Cc: liuyongl...@huawei.com; lihuis...@huawei.com
> Subject: [PATCH 15/16] doc: add link speed configuration feature for dpaa
> Importance: High
> 
> Add link speed configuration feature for dpaa.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Huisong Li 
> ---
>  doc/guides/nics/features/dpaa.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/dpaa.ini
> b/doc/guides/nics/features/dpaa.ini
> index a382c7160c..b136ed191a 100644
> --- a/doc/guides/nics/features/dpaa.ini
> +++ b/doc/guides/nics/features/dpaa.ini
> @@ -5,6 +5,7 @@
>  ;
>  [Features]
>  Speed capabilities   = Y
> +Link speed configuration = Y
>  Link status  = Y
>  Link status event= Y
>  Burst mode info  = Y
> --
> 2.33.0