[Bug 1317] Fashionhikes

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1317

Bug ID: 1317
   Summary: Fashionhikes
   Product: DPDK
   Version: 22.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: core
  Assignee: dev@dpdk.org
  Reporter: fashionhi...@gmail.com
  Target Milestone: ---

How to Get Grease Out of Clothes
Removing grease stains from clothes involves applying an absorbent material
like cornstarch or baking soda to soak up excess grease. Pre-treat the stain
with dish soap or a commercial stain remover, then launder the garment as
usual.

Read More - https://fashionhikes.com/how-to-get-grease-out-of-clothes/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[PATCH] raw/cnxk_bphy: switch to dynamic logging

[Tomasz Duszynski]

Dynamically allocated log type is a standard approach among all drivers.
Switch to it.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_bphy/cnxk_bphy.c  | 32 +-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c  |  4 ++-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h  |  7 +
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 32 ++
 4 files changed, 44 insertions(+), 31 deletions(-)

diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c 
b/drivers/raw/cnxk_bphy/cnxk_bphy.c
index 15dbc4c1a6..af3bf97a4d 100644
--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c
+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c
@@ -6,6 +6,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -15,6 +16,11 @@
 #include "cnxk_bphy_irq.h"
 #include "rte_pmd_bphy.h"
 
+extern int bphy_rawdev_logtype;
+
+#define BPHY_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, bphy_rawdev_logtype, "%s(): " fmt "\n", 
__func__, ##args)
+
 static const struct rte_pci_id pci_bphy_map[] = {
{RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CNXK_BPHY)},
{
@@ -81,7 +87,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
goto err_desc;
if (descs != 1) {
ret = -ENODEV;
-   plt_err("Wrong number of descs reported\n");
+   BPHY_LOG(ERR, "Wrong number of descs reported\n");
goto err_desc;
}
 
@@ -95,7 +101,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
 
ret = rte_pmd_bphy_intr_init(dev_id);
if (ret) {
-   plt_err("intr init failed");
+   BPHY_LOG(ERR, "intr init failed");
return ret;
}
 
@@ -103,7 +109,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
 
test = rte_zmalloc("BPHY", max_irq * sizeof(*test), 0);
if (test == NULL) {
-   plt_err("intr alloc failed");
+   BPHY_LOG(ERR, "intr alloc failed");
goto err_alloc;
}
 
@@ -132,7 +138,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
}
 
if (ret) {
-   plt_err("intr register failed at irq %d", i);
+   BPHY_LOG(ERR, "intr register failed at irq %d", i);
goto err_register;
}
}
@@ -142,12 +148,12 @@ bphy_rawdev_selftest(uint16_t dev_id)
 
for (i = 0; i < max_irq; i++) {
if (!test[i].handled_intr) {
-   plt_err("intr %u not handled", i);
+   BPHY_LOG(ERR, "intr %u not handled", i);
ret = -1;
break;
}
if (test[i].handled_data != test[i].test_data) {
-   plt_err("intr %u has wrong handler", i);
+   BPHY_LOG(ERR, "intr %u has wrong handler", i);
ret = -1;
break;
}
@@ -251,7 +257,7 @@ cnxk_bphy_irq_enqueue_bufs(struct rte_rawdev *dev,
 
/* get rid of last response if any */
if (qp->rsp) {
-   RTE_LOG(WARNING, PMD, "Previous response got overwritten\n");
+   BPHY_LOG(WARNING, "Previous response got overwritten");
rte_free(qp->rsp);
}
qp->rsp = rsp;
@@ -332,9 +338,8 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv,
return 0;
 
if (!pci_dev->mem_resource[0].addr) {
-   plt_err("BARs have invalid values: BAR0 %p\n BAR2 %p",
-   pci_dev->mem_resource[0].addr,
-   pci_dev->mem_resource[2].addr);
+   BPHY_LOG(ERR, "BARs have invalid values: BAR0 %p\n BAR2 %p",
+pci_dev->mem_resource[0].addr, 
pci_dev->mem_resource[2].addr);
return -ENODEV;
}
 
@@ -346,7 +351,7 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv,
bphy_rawdev = rte_rawdev_pmd_allocate(name, sizeof(*bphy_dev),
  rte_socket_id());
if (bphy_rawdev == NULL) {
-   plt_err("Failed to allocate rawdev");
+   BPHY_LOG(ERR, "Failed to allocate rawdev");
return -ENOMEM;
}
 
@@ -381,14 +386,14 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)
return 0;
 
if (pci_dev == NULL) {
-   plt_err("invalid pci_dev");
+   BPHY_LOG(ERR, "invalid pci_dev");
return -EINVAL;
}
 
bphy_rawdev_get_name(name, pci_dev);
rawdev = rte_rawdev_pmd_get_named_dev(name);
if (rawdev == NULL) {
-   plt_err("invalid device name (%s)", name);
+   BPHY_LOG(ERR, "invalid device name (%s)", name);
return -EINVAL;
}
 
@@ -410,3 +415,4 @@ static struct rte_pci_driver cnxk_bphy_rawdev_pmd = {
 RTE_PMD_REGISTER_PCI(bphy_rawdev_pci_driver, cnxk_bphy_rawdev_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(bphy_rawdev_pci_driver, pci_bphy_map);

RE: [PATCH] net/mlx5/hws: fix typo in the log

[Raslan Darawsheh]

Hi,


> -Original Message-
> From: Bing Zhao 
> Sent: Monday, November 13, 2023 9:21 AM
> To: Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> Suanming Mou ; Ori Kam 
> Cc: dev@dpdk.org; Erez Shitrit ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5/hws: fix typo in the log
> 
> Change "cureent" to "current".
> 
> Fixes: fa16fead9a68 ("net/mlx5/hws: support rule update after its creation")
> Cc: ere...@nvidia.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bing Zhao 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

RE: [PATCH] net/mlx5: fix shared Rx queue list management

[Raslan Darawsheh]

Hi,

> -Original Message-
> From: Bing Zhao 
> Sent: Monday, November 13, 2023 9:25 AM
> To: Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> Suanming Mou ; Ori Kam 
> Cc: dev@dpdk.org; Xueming(Steven) Li ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix shared Rx queue list management
> 
> In shared Rx queue case, the shared control structure could only be released
> after the last port's dereference in the group.
> 
> There is another management list that holding all of the used Rx queues'
> structures for a port. If the reference count of a control structure is 
> changed to
> zero during port close, it can be removed from the list directly without 
> freeing
> the resource.
> 
> Fixes: 09c2555303be ("net/mlx5: support shared Rx queue")
> Cc: xuemi...@nvidia.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bing Zhao 
> Acked-by: Viacheslav Ovsiienko 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

RE: [PATCH] net/mlx5: zero encap UDP csum for IPv4 too

[Raslan Darawsheh]

Hi,

> -Original Message-
> From: Bing Zhao 
> Sent: Monday, November 13, 2023 9:30 AM
> To: Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> Suanming Mou ; Ori Kam 
> Cc: dev@dpdk.org; Eli Britstein ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: zero encap UDP csum for IPv4 too
> 
> From: Eli Britstein 
> 
> A zero UDP csum indicates it should not be validated by the receiver.
> The HW may not calculate UDP csum after encap.
> 
> The cited commit made sure the UDP csum is zero for UDP over IPv6,
> mistakenly not handling UDP over IPv4. Fix it.
> 
> Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Eli Britstein 
> ---

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

[PATCH 05/43] node: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/node/kernel_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/node/kernel_tx.c b/lib/node/kernel_tx.c
index 27d1808c71..ab92f22cb9 100644
--- a/lib/node/kernel_tx.c
+++ b/lib/node/kernel_tx.c
@@ -36,7 +36,7 @@ kernel_tx_process_mbuf(struct rte_node *node, struct rte_mbuf 
**mbufs, uint16_t
sin.sin_addr.s_addr = ip4->dst_addr;
 
if (sendto(ctx->sock, buf, len, 0, (struct sockaddr *)&sin, 
sizeof(sin)) < 0)
-   node_err("kernel_tx", "Unable to send packets: %s\n", 
strerror(errno));
+   node_err("kernel_tx", "Unable to send packets: %s\n", 
rte_strerror(errno));
}
 }
 
-- 
2.33.0

[PATCH 03/43] eventdev: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 6db03adf04..d45c2c899e 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1106,7 +1106,7 @@ rxa_intr_ring_enqueue(struct event_eth_rx_adapter 
*rx_adapter, void *data)
 */
if (err)
RTE_EDEV_LOG_ERR("Failed to enqueue interrupt"
-   " to ring: %s", strerror(-err));
+   " to ring: %s", rte_strerror(-err));
else
rte_eth_dev_rx_intr_disable(port_id, queue);
}
-- 
2.33.0

[PATCH 06/43] pdump: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/pdump/rte_pdump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 80b90c6f7d..7b7b87bbd1 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -340,7 +340,7 @@ set_pdump_rxtx_cbs(const struct pdump_request *p)
if (ret != 0) {
PDUMP_LOG(ERR,
"Error during getting device (port %u) info: 
%s\n",
-   port, strerror(-ret));
+   port, rte_strerror(-ret));
return ret;
}
 
@@ -410,7 +410,7 @@ pdump_server(const struct rte_mp_msg *mp_msg, const void 
*peer)
mp_resp.num_fds = 0;
if (rte_mp_reply(&mp_resp, peer) < 0) {
PDUMP_LOG(ERR, "failed to send to client:%s\n",
- strerror(rte_errno));
+ rte_strerror(rte_errno));
return -1;
}
 
@@ -741,7 +741,7 @@ rte_pdump_stats(uint16_t port, struct rte_pdump_stats 
*stats)
if (ret != 0) {
PDUMP_LOG(ERR,
  "Error during getting device (port %u) info: %s\n",
- port, strerror(-ret));
+ port, rte_strerror(-ret));
return ret;
}
 
-- 
2.33.0

[PATCH 01/43] devtools: forbid use of strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
rte_strerror() has been provided in DPDK to replace it.

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 devtools/checkpatches.sh | 8 
 1 file changed, 8 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 066449d147..7fbd0df3b3 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -159,6 +159,14 @@ check_forbidden_additions() { # 
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
 
+   # refrain from using strerror() for drivers and libs
+   awk -v FOLDERS="lib drivers" \
+   -v EXPRESSIONS="\\\sstrerror\\\(" \
+   -v RET_ON_FAIL=1 \
+   -v MESSAGE='Using strerror, prefer rte_strerror' \
+   -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+   "$1" || res=1
+
# refrain from using RTE_LOG_REGISTER for drivers and libs
awk -v FOLDERS='lib drivers' \
-v EXPRESSIONS='\\' \
-- 
2.33.0

[PATCH 00/43] replace strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This series of patches fix it. In this patchset, only the libs and
drivers are modified.

Dengdui Huang (43):
  devtools: forbid use of strerror
  eal: use rte strerror
  eventdev: use rte strerror
  latency: use rte strerror
  node: use rte strerror
  pdump: use rte strerror
  power: use rte strerror
  telemetry: replace strerror
  vhost: use rte strerror
  bpf: use rte strerror
  bus/cdx: use rte strerror
  bus/dpaa: use rte strerror
  bus/fslmc: use rte strerror
  bus/pci: use rte strerror
  bus/vdev: use rte strerror
  bus/vmbus: use rte strerror
  common/cnxk: use rte strerror
  common/mlx5: use rte strerror
  crypto/caam_jr: use rte strerror
  dma/idxd: use rte strerror
  net/af_packet: use rte strerror
  net/bnxt: use rte strerror
  net/af_xdp: use rte strerror
  net/bonding: use rte strerror
  net/dpaa: use rte strerror
  net/dpaa2: use rte strerror
  net/enetfec: use rte strerror
  net/failsafe: use rte strerror
  net/i40e: use rte strerror
  net/ice: use rte strerror
  net/ixgbe: use rte strerror
  net/memif: use rte strerror
  net/mlx4: use rte strerror
  net/mlx5: use rte strerror
  net/qede: use rte strerror
  net/sfc: use rte strerror
  net/tap: use rte strerror
  net/vhost: use rte strerror
  net/virtio: use rte strerror
  raw/ifpga: use rte strerror
  vdpa/ifc: use rte strerror
  vdpa/mlx5: use rte strerror
  vdpa/sfc: use rte strerror

 devtools/checkpatches.sh  |   8 +
 drivers/bus/cdx/cdx.c |   2 +-
 drivers/bus/cdx/cdx_vfio.c|  13 +-
 drivers/bus/dpaa/base/fman/fman.c |   2 +-
 drivers/bus/dpaa/dpaa_bus.c   |   2 +-
 drivers/bus/fslmc/fslmc_vfio.c|  12 +-
 drivers/bus/pci/bsd/pci.c |   8 +-
 drivers/bus/pci/linux/pci.c   |   7 +-
 drivers/bus/pci/linux/pci_uio.c   |  23 +-
 drivers/bus/pci/linux/pci_vfio.c  |  23 +-
 drivers/bus/pci/pci_common_uio.c  |   3 +-
 drivers/bus/vdev/vdev.c   |   2 +-
 drivers/bus/vmbus/linux/vmbus_bus.c   |   7 +-
 drivers/bus/vmbus/linux/vmbus_uio.c   |  21 +-
 drivers/bus/vmbus/vmbus_common.c  |   4 +-
 drivers/bus/vmbus/vmbus_common_uio.c  |   3 +-
 drivers/common/cnxk/roc_dev.c |   4 +-
 drivers/common/cnxk/roc_model.c   |   4 +-
 drivers/common/cnxk/roc_utils.c   |   4 +-
 drivers/common/mlx5/linux/mlx5_nl.c   |  12 +-
 drivers/common/mlx5/mlx5_common.c |   6 +-
 drivers/common/mlx5/mlx5_devx_cmds.c  |   2 +-
 drivers/crypto/caam_jr/caam_jr_uio.c  |   5 +-
 drivers/dma/idxd/idxd_bus.c   |  14 +-
 drivers/net/af_packet/rte_eth_af_packet.c |   2 +-
 drivers/net/af_xdp/rte_eth_af_xdp.c   |  12 +-
 drivers/net/bnxt/bnxt_stats.c |   2 +-
 drivers/net/bnxt/rte_pmd_bnxt.c   |  26 +-
 drivers/net/bnxt/tf_core/tf_core.c| 240 +-
 drivers/net/bnxt/tf_core/tf_em_common.c   |  26 +-
 .../net/bnxt/tf_core/tf_em_hash_internal.c|   4 +-
 drivers/net/bnxt/tf_core/tf_em_host.c |  24 +-
 drivers/net/bnxt/tf_core/tf_em_internal.c |  14 +-
 drivers/net/bnxt/tf_core/tf_global_cfg.c  |  10 +-
 drivers/net/bnxt/tf_core/tf_identifier.c  |   8 +-
 drivers/net/bnxt/tf_core/tf_if_tbl.c  |   6 +-
 drivers/net/bnxt/tf_core/tf_msg.c | 160 ++--
 drivers/net/bnxt/tf_core/tf_rm.c  |   6 +-
 drivers/net/bnxt/tf_core/tf_session.c |  72 +++---
 drivers/net/bnxt/tf_core/tf_sram_mgr.c|  22 +-
 drivers/net/bnxt/tf_core/tf_tbl.c |  28 +-
 drivers/net/bnxt/tf_core/tf_tbl_sram.c|  48 ++--
 drivers/net/bnxt/tf_core/tf_tcam.c|  24 +-
 drivers/net/bonding/bonding_testpmd.c |   4 +-
 drivers/net/bonding/rte_eth_bond_api.c|   2 +-
 drivers/net/bonding/rte_eth_bond_flow.c   |   4 +-
 drivers/net/bonding/rte_eth_bond_pmd.c|   6 +-
 drivers/net/dpaa/dpaa_ethdev.c|   4 +-
 drivers/net/dpaa/fmlib/fm_lib.c   |   6 +-
 drivers/net/dpaa2/dpaa2_ethdev.c  |   4 +-
 drivers/net/enetfec/enet_uio.c|   2 +-
 drivers/net/failsafe/failsafe.c   |   8 +-
 drivers/net/failsafe/failsafe_args.c  |   4 +-
 drivers/net/failsafe/failsafe_eal.c   |   4 +-
 drivers/net/failsafe/failsafe_flow.c  |   4 +-
 drivers/net/failsafe/failsafe_ops.c   |   2 +-
 drivers/net/failsafe/failsafe_private.h   |   6 +-
 drivers/net/i40e/i40e_testpmd.c   |  42 +--
 drivers/net/ice/ice_testpmd.c |   4 +-
 drivers/net/ixgbe/ixgbe_testpmd.c |  12 +-
 drivers/net/memif/memif_socket.c  |   4 +-
 drivers/net/memif/rte_eth_memif.c |  20 +-
 drivers/net/mlx4/mlx4.c   |  14 

[PATCH 04/43] latency: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/latencystats/rte_latencystats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/latencystats/rte_latencystats.c 
b/lib/latencystats/rte_latencystats.c
index 8985a377db..a395f9b3bc 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -265,7 +265,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
if (ret != 0) {
RTE_LOG(INFO, LATENCY_STATS,
"Error during getting device (port %u) info: 
%s\n",
-   pid, strerror(-ret));
+   pid, rte_strerror(-ret));
 
continue;
}
@@ -309,7 +309,7 @@ rte_latencystats_uninit(void)
if (ret != 0) {
RTE_LOG(INFO, LATENCY_STATS,
"Error during getting device (port %u) info: 
%s\n",
-   pid, strerror(-ret));
+   pid, rte_strerror(-ret));
 
continue;
}
-- 
2.33.0

[PATCH 08/43] telemetry: replace strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses strerror_r() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/telemetry/telemetry.c| 28 ++--
 lib/telemetry/telemetry_legacy.c |  5 -
 2 files changed, 26 insertions(+), 7 deletions(-)

diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 92982842a8..03be0d342a 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -411,6 +411,9 @@ client_handler(void *sock_id)
 static void *
 socket_listener(void *socket)
 {
+#define ERR_BUFF_SZ 256
+   char err_buf[ERR_BUFF_SZ] = {0};
+
while (1) {
pthread_t th;
int rc;
@@ -433,8 +436,9 @@ socket_listener(void *socket)
rc = pthread_create(&th, NULL, s->fn,
(void *)(uintptr_t)s_accepted);
if (rc != 0) {
+   strerror_r(rc, err_buf, sizeof(err_buf));
TMTY_LOG(ERR, "Error with create client thread: %s\n",
-strerror(rc));
+err_buf);
close(s_accepted);
if (s->num_clients != NULL)
rte_atomic_fetch_sub_explicit(s->num_clients, 1,
@@ -467,9 +471,13 @@ unlink_sockets(void)
 static int
 create_socket(char *path)
 {
+#define ERR_BUFF_SZ 256
+   char err_buf[ERR_BUFF_SZ] = {0};
+
int sock = socket(AF_UNIX, SOCK_SEQPACKET, 0);
if (sock < 0) {
-   TMTY_LOG(ERR, "Error with socket creation, %s\n", 
strerror(errno));
+   strerror_r(errno, err_buf, sizeof(err_buf));
+   TMTY_LOG(ERR, "Error with socket creation, %s\n", err_buf);
return -1;
}
 
@@ -499,14 +507,16 @@ create_socket(char *path)
TMTY_LOG(DEBUG, "Attempting unlink and retrying bind\n");
unlink(sun.sun_path);
if (bind(sock, (void *) &sun, sizeof(sun)) < 0) {
-   TMTY_LOG(ERR, "Error binding socket: %s\n", 
strerror(errno));
+   strerror_r(errno, err_buf, sizeof(err_buf));
+   TMTY_LOG(ERR, "Error binding socket: %s\n", err_buf);
close(sock);
return -errno; /* if unlink failed, this will be 
-EADDRINUSE as above */
}
}
 
if (listen(sock, 1) < 0) {
-   TMTY_LOG(ERR, "Error calling listen for socket: %s\n", 
strerror(errno));
+   strerror_r(errno, err_buf, sizeof(err_buf));
+   TMTY_LOG(ERR, "Error calling listen for socket: %s\n", err_buf);
unlink(sun.sun_path);
close(sock);
return -errno;
@@ -531,6 +541,8 @@ set_thread_name(pthread_t id __rte_unused, const char *name 
__rte_unused)
 static int
 telemetry_legacy_init(void)
 {
+#define ERR_BUFF_SZ 256
+   char err_buf[ERR_BUFF_SZ] = {0};
pthread_t t_old;
int rc;
 
@@ -552,8 +564,9 @@ telemetry_legacy_init(void)
}
rc = pthread_create(&t_old, NULL, socket_listener, &v1_socket);
if (rc != 0) {
+   strerror_r(rc, err_buf, sizeof(err_buf));
TMTY_LOG(ERR, "Error with create legacy socket thread: %s\n",
-strerror(rc));
+err_buf);
close(v1_socket.sock);
v1_socket.sock = -1;
unlink(v1_socket.path);
@@ -570,7 +583,9 @@ telemetry_legacy_init(void)
 static int
 telemetry_v2_init(void)
 {
+#define ERR_BUFF_SZ 256
char spath[sizeof(v2_socket.path)];
+   char err_buf[ERR_BUFF_SZ] = {0};
pthread_t t_new;
short suffix = 0;
int rc;
@@ -606,8 +621,9 @@ telemetry_v2_init(void)
}
rc = pthread_create(&t_new, NULL, socket_listener, &v2_socket);
if (rc != 0) {
+   strerror_r(rc, err_buf, sizeof(err_buf));
TMTY_LOG(ERR, "Error with create socket thread: %s\n",
-strerror(rc));
+err_buf);
close(v2_socket.sock);
v2_socket.sock = -1;
unlink(v2_socket.path);
diff --git a/lib/telemetry/telemetry_legacy.c b/lib/telemetry/telemetry_legacy.c
index 4c1d1c353a..3253dd9c1f 100644
--- a/lib/telemetry/telemetry_legacy.c
+++ b/lib/telemetry/telemetry_legacy.c
@@ -81,6 +81,8 @@ register_client(const char *cmd __rte_unused, const char 
*params,
char *buffer __rte_unused, int buf_len __rte_unused)
 {
 #ifndef RTE_EXEC_ENV_WINDOWS
+#define ERR_BUFF_SZ 256
+   char err_buf[ERR_BUFF_SZ] = {0};
pthread_t th;
char data[BUF_SIZE];
int fd;
@@ -117,8 +119,9 @@ register_client(const char *cmd __rte_unused, const char 
*params,
rc = pthread_create(&th, NULL, &legacy_client_handler,
  

[PATCH 07/43] power: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/power/guest_channel.c| 7 ---
 lib/power/power_kvm_vm.c | 3 ++-
 lib/power/power_pstate_cpufreq.c | 7 ---
 lib/power/rte_power_pmd_mgmt.c   | 2 +-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index 7b2ae0b650..1484b384df 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -14,6 +14,7 @@
 
 #include 
 #include 
+#include 
 
 #include "guest_channel.h"
 
@@ -75,7 +76,7 @@ guest_channel_host_connect(const char *path, unsigned int 
lcore_id)
fd = open(fd_path, O_RDWR);
if (fd < 0) {
RTE_LOG(ERR, GUEST_CHANNEL, "Unable to connect to '%s' with 
error "
-   "%s\n", fd_path, strerror(errno));
+   "%s\n", fd_path, rte_strerror(errno));
return -1;
}
 
@@ -104,7 +105,7 @@ guest_channel_host_connect(const char *path, unsigned int 
lcore_id)
if (ret != 0) {
RTE_LOG(ERR, GUEST_CHANNEL,
"Error on channel '%s' communications test: 
%s\n",
-   fd_path, ret > 0 ? strerror(ret) :
+   fd_path, ret > 0 ? rte_strerror(ret) :
"channel not connected");
goto error;
}
@@ -184,7 +185,7 @@ int power_guest_channel_read_msg(void *pkt,
return -1;
} else if (ret < 0) {
RTE_LOG(ERR, GUEST_CHANNEL, "Error occurred during poll 
function: %s\n",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
diff --git a/lib/power/power_kvm_vm.c b/lib/power/power_kvm_vm.c
index 6a8109d449..bb9c9b95fe 100644
--- a/lib/power/power_kvm_vm.c
+++ b/lib/power/power_kvm_vm.c
@@ -5,6 +5,7 @@
 #include 
 
 #include 
+#include 
 
 #include "rte_power_guest_channel.h"
 #include "guest_channel.h"
@@ -82,7 +83,7 @@ send_msg(unsigned int lcore_id, uint32_t scale_direction)
if (ret == 0)
return 1;
RTE_LOG(DEBUG, POWER, "Error sending message: %s\n",
-   ret > 0 ? strerror(ret) : "channel not connected");
+   ret > 0 ? rte_strerror(ret) : "channel not connected");
return -1;
 }
 
diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c
index 5ca5f60bcd..eeb0f3831b 100644
--- a/lib/power/power_pstate_cpufreq.c
+++ b/lib/power/power_pstate_cpufreq.c
@@ -13,6 +13,7 @@
 
 #include 
 #include 
+#include 
 
 #include "rte_power_pmd_mgmt.h"
 #include "power_pstate_cpufreq.h"
@@ -83,7 +84,7 @@ power_read_turbo_pct(uint64_t *outVal)
 
if (fd < 0) {
RTE_LOG(ERR, POWER, "Error opening '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
-strerror(errno));
+rte_strerror(errno));
return fd;
}
 
@@ -91,7 +92,7 @@ power_read_turbo_pct(uint64_t *outVal)
 
if (ret < 0) {
RTE_LOG(ERR, POWER, "Error reading '%s': %s\n", 
POWER_SYSFILE_TURBO_PCT,
-strerror(errno));
+rte_strerror(errno));
goto out;
}
 
@@ -99,7 +100,7 @@ power_read_turbo_pct(uint64_t *outVal)
*outVal = (uint64_t) strtol(val, &endptr, 10);
if (errno != 0 || (*endptr != 0 && *endptr != '\n')) {
RTE_LOG(ERR, POWER, "Error converting str to digits, read from 
%s: %s\n",
-POWER_SYSFILE_TURBO_PCT, strerror(errno));
+POWER_SYSFILE_TURBO_PCT, rte_strerror(errno));
ret = -1;
goto out;
}
diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
index 38f8384085..a61a5c8f98 100644
--- a/lib/power/rte_power_pmd_mgmt.c
+++ b/lib/power/rte_power_pmd_mgmt.c
@@ -574,7 +574,7 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id, 
uint16_t port_id,
ret = queue_list_add(lcore_cfg, &qdata);
if (ret < 0) {
RTE_LOG(DEBUG, POWER, "Failed to add queue to list: %s\n",
-   strerror(-ret));
+   rte_strerror(-ret));
goto end;
}
/* new queue is always added last */
-- 
2.33.0

[PATCH 10/43] bpf: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/bpf/bpf_load_elf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bpf/bpf_load_elf.c b/lib/bpf/bpf_load_elf.c
index 02a5d8ba0d..6fc7018ddf 100644
--- a/lib/bpf/bpf_load_elf.c
+++ b/lib/bpf/bpf_load_elf.c
@@ -310,7 +310,7 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char 
*fname,
if (fd < 0) {
rc = errno;
RTE_BPF_LOG(ERR, "%s(%s) error code: %d(%s)\n",
-   __func__, fname, rc, strerror(rc));
+   __func__, fname, rc, rte_strerror(rc));
rte_errno = EINVAL;
return NULL;
}
-- 
2.33.0

[PATCH 12/43] bus/dpaa: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/dpaa/base/fman/fman.c | 2 +-
 drivers/bus/dpaa/dpaa_bus.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/dpaa/base/fman/fman.c 
b/drivers/bus/dpaa/base/fman/fman.c
index 1814372a40..fe694e447c 100644
--- a/drivers/bus/dpaa/base/fman/fman.c
+++ b/drivers/bus/dpaa/base/fman/fman.c
@@ -725,7 +725,7 @@ fman_finish(void)
if (unlikely(_errno < 0))
fprintf(stderr, "%s:%d:%s(): munmap() = %d (%s)\n",
__FILE__, __LINE__, __func__,
-   -errno, strerror(errno));
+   -errno, rte_strerror(errno));
printf("Tearing down %s\n", __if->node_path);
list_del(&__if->__if.node);
rte_free(__if);
diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index e57159f5d8..ea80168b7c 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -605,7 +605,7 @@ static int rte_dpaa_setup_intr(struct rte_intr_handle 
*intr_handle)
fd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
if (fd < 0) {
DPAA_BUS_ERR("Cannot set up eventfd, error %i (%s)",
-errno, strerror(errno));
+errno, rte_strerror(errno));
return errno;
}
 
-- 
2.33.0

[PATCH 09/43] vhost: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/vhost/socket.c | 13 +++--
 lib/vhost/vduse.c  | 30 +++---
 lib/vhost/vhost_user.c | 11 ++-
 3 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index 5882e44176..0b030222d6 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -16,6 +16,7 @@
 
 #include 
 #include 
+#include 
 
 #include "fd_man.h"
 #include "vduse.h"
@@ -129,7 +130,7 @@ read_fd_message(char *ifname, int sockfd, char *buf, int 
buflen, int *fds, int m
if (ret <= 0) {
if (ret)
VHOST_LOG_CONFIG(ifname, ERR, "recvmsg failed on fd %d 
(%s)\n",
-   sockfd, strerror(errno));
+   sockfd, rte_strerror(errno));
return ret;
}
 
@@ -200,7 +201,7 @@ send_fd_message(char *ifname, int sockfd, char *buf, int 
buflen, int *fds, int f
 
if (ret < 0) {
VHOST_LOG_CONFIG(ifname, ERR, "sendmsg error on fd %d (%s)\n",
-   sockfd, strerror(errno));
+   sockfd, rte_strerror(errno));
return ret;
}
 
@@ -358,7 +359,7 @@ create_unix_socket(struct vhost_user_socket *vsocket)
if (!vsocket->is_server && fcntl(fd, F_SETFL, O_NONBLOCK)) {
VHOST_LOG_CONFIG(vsocket->path, ERR,
"vhost-user: can't set nonblocking mode for socket, fd: 
%d (%s)\n",
-   fd, strerror(errno));
+   fd, rte_strerror(errno));
close(fd);
return -1;
}
@@ -392,7 +393,7 @@ vhost_user_start_server(struct vhost_user_socket *vsocket)
ret = bind(fd, (struct sockaddr *)&vsocket->un, sizeof(vsocket->un));
if (ret < 0) {
VHOST_LOG_CONFIG(path, ERR, "failed to bind: %s; remove it and 
try again\n",
-   strerror(errno));
+   rte_strerror(errno));
goto err;
}
VHOST_LOG_CONFIG(path, INFO, "binding succeeded\n");
@@ -445,7 +446,7 @@ vhost_user_connect_nonblock(char *path, int fd, struct 
sockaddr *un, size_t sz)
flags = fcntl(fd, F_GETFL, 0);
if (flags < 0) {
VHOST_LOG_CONFIG(path, ERR, "can't get flags for connfd %d 
(%s)\n",
-   fd, strerror(errno));
+   fd, rte_strerror(errno));
return -2;
}
if ((flags & O_NONBLOCK) && fcntl(fd, F_SETFL, flags & ~O_NONBLOCK)) {
@@ -539,7 +540,7 @@ vhost_user_start_client(struct vhost_user_socket *vsocket)
return 0;
}
 
-   VHOST_LOG_CONFIG(path, WARNING, "failed to connect: %s\n", 
strerror(errno));
+   VHOST_LOG_CONFIG(path, WARNING, "failed to connect: %s\n", 
rte_strerror(errno));
 
if (ret == -2 || !vsocket->reconnect) {
close(fd);
diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
index 080b58f7de..12e4b9c891 100644
--- a/lib/vhost/vduse.c
+++ b/lib/vhost/vduse.c
@@ -135,7 +135,7 @@ vduse_control_queue_event(int fd, void *arg, int *remove 
__rte_unused)
ret = read(fd, &buf, sizeof(buf));
if (ret < 0) {
VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to read control 
queue event: %s\n",
-   strerror(errno));
+   rte_strerror(errno));
return;
}
 
@@ -157,7 +157,7 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int 
index)
ret = ioctl(dev->vduse_dev_fd, VDUSE_VQ_GET_INFO, &vq_info);
if (ret) {
VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to get VQ %u info: 
%s\n",
-   index, strerror(errno));
+   index, rte_strerror(errno));
return;
}
 
@@ -183,7 +183,7 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int 
index)
vq->kickfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
if (vq->kickfd < 0) {
VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to init kickfd for 
VQ %u: %s\n",
-   index, strerror(errno));
+   index, rte_strerror(errno));
vq->kickfd = VIRTIO_INVALID_EVENTFD;
return;
}
@@ -213,7 +213,7 @@ vduse_vring_setup(struct virtio_net *dev, unsigned int 
index)
ret = ioctl(dev->vduse_dev_fd, VDUSE_VQ_SETUP_KICKFD, &vq_efd);
if (ret) {
VHOST_LOG_CONFIG(dev->ifname, ERR, "Failed to setup kickfd for 
VQ %u: %s\n",
-   index, strerror(errno));
+   index, rte_strerror(errno));
close(vq->kickfd);
vq->kickfd = VIRTIO_UNINITIALIZED_

[PATCH 02/43] eal: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 lib/eal/common/eal_common_fbarray.c |  2 +-
 lib/eal/common/eal_common_options.c |  7 ++--
 lib/eal/common/eal_common_proc.c| 12 +++
 lib/eal/common/eal_common_trace_utils.c |  6 ++--
 lib/eal/freebsd/eal.c   |  4 +--
 lib/eal/freebsd/eal_interrupts.c|  8 ++---
 lib/eal/freebsd/eal_memory.c|  2 +-
 lib/eal/freebsd/eal_timer.c |  6 ++--
 lib/eal/linux/eal.c | 10 +++---
 lib/eal/linux/eal_dev.c |  2 +-
 lib/eal/linux/eal_hugepage_info.c   |  5 +--
 lib/eal/linux/eal_interrupts.c  | 18 +-
 lib/eal/linux/eal_memalloc.c| 47 +
 lib/eal/linux/eal_memory.c  | 43 +++---
 lib/eal/linux/eal_timer.c   |  2 +-
 lib/eal/linux/eal_vfio.c| 40 ++---
 lib/eal/unix/eal_filesystem.c   |  5 +--
 lib/eal/unix/eal_unix_memory.c  |  6 ++--
 lib/eal/unix/rte_thread.c   |  6 ++--
 19 files changed, 118 insertions(+), 113 deletions(-)

diff --git a/lib/eal/common/eal_common_fbarray.c 
b/lib/eal/common/eal_common_fbarray.c
index 2055bfa57d..a2936bbd91 100644
--- a/lib/eal/common/eal_common_fbarray.c
+++ b/lib/eal/common/eal_common_fbarray.c
@@ -1027,7 +1027,7 @@ rte_fbarray_destroy(struct rte_fbarray *arr)
eal_get_fbarray_path(path, sizeof(path), arr->name);
if (unlink(path)) {
RTE_LOG(DEBUG, EAL, "Cannot unlink fbarray: %s\n",
-   strerror(errno));
+   rte_strerror(errno));
rte_errno = errno;
/*
 * we're still holding an exclusive lock, so drop it to
diff --git a/lib/eal/common/eal_common_options.c 
b/lib/eal/common/eal_common_options.c
index a6d21f1cba..8a09fe2719 100644
--- a/lib/eal/common/eal_common_options.c
+++ b/lib/eal/common/eal_common_options.c
@@ -44,6 +44,7 @@
 #ifndef RTE_EXEC_ENV_WINDOWS
 #include "eal_trace.h"
 #endif
+#include 
 
 #define BITS_PER_HEX 4
 #define LCORE_OPT_LST 1
@@ -391,7 +392,7 @@ eal_plugindir_init(const char *path)
d = opendir(path);
if (d == NULL) {
RTE_LOG(ERR, EAL, "failed to open directory %s: %s\n",
-   path, strerror(errno));
+   path, rte_strerror(errno));
return -1;
}
 
@@ -443,7 +444,7 @@ verify_perms(const char *dirpath)
/* call stat to check for permissions and ensure not world writable */
if (stat(dirpath, &st) != 0) {
RTE_LOG(ERR, EAL, "Error with stat on %s, %s\n",
-   dirpath, strerror(errno));
+   dirpath, rte_strerror(errno));
return -1;
}
if (st.st_mode & S_IWOTH) {
@@ -471,7 +472,7 @@ eal_dlopen(const char *pathname)
}
if (realp == NULL) {
RTE_LOG(ERR, EAL, "Error with realpath for %s, %s\n",
-   pathname, strerror(errno));
+   pathname, rte_strerror(errno));
goto out;
}
if (strnlen(realp, PATH_MAX) == PATH_MAX) {
diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c
index 728815c4a9..2e39180d40 100644
--- a/lib/eal/common/eal_common_proc.c
+++ b/lib/eal/common/eal_common_proc.c
@@ -291,7 +291,7 @@ read_msg(int fd, struct mp_msg_internal *m, struct 
sockaddr_un *s)
if (errno == EINTR)
goto retry;
 
-   RTE_LOG(ERR, EAL, "recvmsg failed, %s\n", strerror(errno));
+   RTE_LOG(ERR, EAL, "recvmsg failed, %s\n", rte_strerror(errno));
return -1;
}
 
@@ -583,7 +583,7 @@ open_socket_fd(void)
 
if (bind(mp_fd, (struct sockaddr *)&un, sizeof(un)) < 0) {
RTE_LOG(ERR, EAL, "failed to bind %s: %s\n",
-   un.sun_path, strerror(errno));
+   un.sun_path, rte_strerror(errno));
close(mp_fd);
return -1;
}
@@ -631,13 +631,13 @@ rte_mp_channel_init(void)
dir_fd = open(mp_dir_path, O_RDONLY);
if (dir_fd < 0) {
RTE_LOG(ERR, EAL, "failed to open %s: %s\n",
-   mp_dir_path, strerror(errno));
+   mp_dir_path, rte_strerror(errno));
return -1;
}
 
if (flock(dir_fd, LOCK_EX)) {
RTE_LOG(ERR, EAL, "failed to lock %s: %s\n",
-   mp_dir_path, strerror(errno));
+   mp_dir_path, rte_strerror(errno));
close(dir_fd);
return -1;
}
@@ -650,7 +650,7 @@ 

[PATCH 11/43] bus/cdx: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/cdx/cdx.c  |  2 +-
 drivers/bus/cdx/cdx_vfio.c | 13 +++--
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 541aae76c3..a3161f8ee4 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -271,7 +271,7 @@ cdx_scan(void)
dir = opendir(RTE_CDX_BUS_DEVICES_PATH);
if (dir == NULL) {
CDX_BUS_INFO("%s(): opendir failed: %s", __func__,
-   strerror(errno));
+   rte_strerror(errno));
return 0;
}
 
diff --git a/drivers/bus/cdx/cdx_vfio.c b/drivers/bus/cdx/cdx_vfio.c
index 8a3ac0b995..6fb38abfac 100644
--- a/drivers/bus/cdx/cdx_vfio.c
+++ b/drivers/bus/cdx/cdx_vfio.c
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "bus_cdx_driver.h"
 #include "cdx_logs.h"
@@ -198,7 +199,7 @@ cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int 
vfio_dev_fd,
ret = ioctl(vfio_dev_fd, VFIO_DEVICE_GET_IRQ_INFO, &irq);
if (ret < 0) {
CDX_BUS_ERR("Cannot get VFIO IRQ info, error %i (%s)",
-   errno, strerror(errno));
+   errno, rte_strerror(errno));
return -1;
}
 
@@ -216,7 +217,7 @@ cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int 
vfio_dev_fd,
fd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
if (fd < 0) {
CDX_BUS_ERR("Cannot set up eventfd, error %i (%s)",
-   errno, strerror(errno));
+   errno, rte_strerror(errno));
return -1;
}
 
@@ -252,7 +253,7 @@ cdx_vfio_setup_device(struct rte_cdx_device *dev, int 
vfio_dev_fd,
 */
if (ioctl(vfio_dev_fd, VFIO_DEVICE_RESET) && errno != EINVAL) {
CDX_BUS_ERR("Unable to reset device! Error: %d (%s)", errno,
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
@@ -410,7 +411,7 @@ cdx_vfio_map_resource_primary(struct rte_cdx_device *dev)
ret = cdx_vfio_get_region_info(vfio_dev_fd, ®, i);
if (ret < 0) {
CDX_BUS_ERR("%s cannot get device region info error %i 
(%s)",
-   dev_name, errno, strerror(errno));
+   dev_name, errno, rte_strerror(errno));
goto err_vfio_res;
}
 
@@ -438,7 +439,7 @@ cdx_vfio_map_resource_primary(struct rte_cdx_device *dev)
ret = cdx_vfio_mmap_resource(vfio_dev_fd, vfio_res, i, 0);
if (ret < 0) {
CDX_BUS_ERR("%s mapping region %i failed: %s",
-   cdx_addr, i, strerror(errno));
+   cdx_addr, i, rte_strerror(errno));
free(reg);
goto err_vfio_res;
}
@@ -506,7 +507,7 @@ cdx_vfio_map_resource_secondary(struct rte_cdx_device *dev)
ret = cdx_vfio_mmap_resource(vfio_dev_fd, vfio_res, i, 
MAP_FIXED);
if (ret < 0) {
CDX_BUS_ERR("%s mapping MMIO region %i failed: %s",
-   dev_name, i, strerror(errno));
+   dev_name, i, rte_strerror(errno));
goto err_vfio_dev_fd;
}
 
-- 
2.33.0

[PATCH 13/43] bus/fslmc: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/fslmc/fslmc_vfio.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 5966776a85..1cbbcf9019 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -481,7 +481,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char 
*dev_addr,
if (ret) {
DPAA2_BUS_ERR("  %s cannot get group status, "
"error %i (%s)\n", dev_addr,
-   errno, strerror(errno));
+   errno, rte_strerror(errno));
close(vfio_group_fd);
rte_vfio_clear_group(vfio_group_fd);
return -1;
@@ -504,7 +504,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char 
*dev_addr,
if (ret) {
DPAA2_BUS_ERR("  %s cannot add VFIO group to container, 
"
"error %i (%s)\n", dev_addr,
-   errno, strerror(errno));
+   errno, rte_strerror(errno));
close(vfio_group_fd);
close(vfio_container_fd);
rte_vfio_clear_group(vfio_group_fd);
@@ -551,7 +551,7 @@ fslmc_vfio_setup_device(const char *sysfs_base, const char 
*dev_addr,
ret = ioctl(*vfio_dev_fd, VFIO_DEVICE_GET_INFO, device_info);
if (ret) {
DPAA2_BUS_ERR("  %s cannot get device info, error %i (%s)",
-   dev_addr, errno, strerror(errno));
+   dev_addr, errno, rte_strerror(errno));
close(*vfio_dev_fd);
close(vfio_group_fd);
close(vfio_container_fd);
@@ -617,7 +617,7 @@ int rte_dpaa2_intr_enable(struct rte_intr_handle 
*intr_handle, int index)
if (ret) {
DPAA2_BUS_ERR("Error:dpaa2 SET IRQs fd=%d, err = %d(%s)",
  rte_intr_fd_get(intr_handle), errno,
- strerror(errno));
+ rte_strerror(errno));
return ret;
}
 
@@ -667,7 +667,7 @@ rte_dpaa2_vfio_setup_intr(struct rte_intr_handle 
*intr_handle,
ret = ioctl(vfio_dev_fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info);
if (ret < 0) {
DPAA2_BUS_ERR("Cannot get IRQ(%d) info, error %i (%s)",
- i, errno, strerror(errno));
+ i, errno, rte_strerror(errno));
return -1;
}
 
@@ -682,7 +682,7 @@ rte_dpaa2_vfio_setup_intr(struct rte_intr_handle 
*intr_handle,
fd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
if (fd < 0) {
DPAA2_BUS_ERR("Cannot set up eventfd, error %i (%s)",
- errno, strerror(errno));
+ errno, rte_strerror(errno));
return -1;
}
 
-- 
2.33.0

[PATCH 15/43] bus/vdev: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/vdev/vdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 7974b27295..bdb5fa8fce 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -432,7 +432,7 @@ vdev_action(const struct rte_mp_msg *mp_msg, const void 
*peer)
strlcpy(ou->name, devname, RTE_DEV_NAME_MAX_LEN);
if (rte_mp_sendmsg(&mp_resp) < 0)
VDEV_LOG(ERR, "send vdev, %s, failed, %s",
-devname, strerror(rte_errno));
+devname, rte_strerror(rte_errno));
num++;
}
rte_spinlock_recursive_unlock(&vdev_device_list_lock);
-- 
2.33.0

[PATCH 16/43] bus/vmbus: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/vmbus/linux/vmbus_bus.c  |  7 ---
 drivers/bus/vmbus/linux/vmbus_uio.c  | 21 +++--
 drivers/bus/vmbus/vmbus_common.c |  4 ++--
 drivers/bus/vmbus/vmbus_common_uio.c |  3 ++-
 4 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c 
b/drivers/bus/vmbus/linux/vmbus_bus.c
index 01d8111b85..0c92c1d4dd 100644
--- a/drivers/bus/vmbus/linux/vmbus_bus.c
+++ b/drivers/bus/vmbus/linux/vmbus_bus.c
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "eal_filesystem.h"
 #include "private.h"
@@ -50,7 +51,7 @@ parse_sysfs_uuid(const char *filename, rte_uuid_t uu)
f = fopen(filename, "r");
if (f == NULL) {
VMBUS_LOG(ERR, "cannot open sysfs value %s: %s",
- filename, strerror(errno));
+ filename, rte_strerror(errno));
return -1;
}
 
@@ -92,7 +93,7 @@ get_sysfs_string(const char *filename, char *buf, size_t 
buflen)
f = fopen(filename, "r");
if (f == NULL) {
VMBUS_LOG(ERR, "cannot open sysfs value %s:%s",
- filename, strerror(errno));
+ filename, rte_strerror(errno));
return -1;
}
 
@@ -350,7 +351,7 @@ rte_vmbus_scan(void)
return 0;
 
VMBUS_LOG(ERR, "opendir %s failed: %s",
- SYSFS_VMBUS_DEVICES, strerror(errno));
+ SYSFS_VMBUS_DEVICES, rte_strerror(errno));
return -1;
}
 
diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c 
b/drivers/bus/vmbus/linux/vmbus_uio.c
index 26edef342d..5fce68d880 100644
--- a/drivers/bus/vmbus/linux/vmbus_uio.c
+++ b/drivers/bus/vmbus/linux/vmbus_uio.c
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "private.h"
 
@@ -34,7 +35,7 @@ void vmbus_uio_irq_control(struct rte_vmbus_device *dev, 
int32_t onoff)
  sizeof(onoff)) < 0) {
VMBUS_LOG(ERR, "cannot write to %d:%s",
  rte_intr_fd_get(dev->intr_handle),
- strerror(errno));
+ rte_strerror(errno));
}
 }
 
@@ -51,7 +52,7 @@ int vmbus_uio_irq_read(struct rte_vmbus_device *dev)
if (cc < (int)sizeof(count)) {
if (cc < 0) {
VMBUS_LOG(ERR, "IRQ read failed %s",
- strerror(errno));
+ rte_strerror(errno));
return -errno;
}
VMBUS_LOG(ERR, "can't read IRQ count");
@@ -91,7 +92,7 @@ vmbus_uio_alloc_resource(struct rte_vmbus_device *dev,
fd = open(devname, O_RDWR);
if (fd < 0) {
VMBUS_LOG(ERR, "Cannot open %s: %s",
-   devname, strerror(errno));
+   devname, rte_strerror(errno));
goto error;
}
 
@@ -158,7 +159,7 @@ vmbus_uio_map_resource_by_index(struct rte_vmbus_device 
*dev, int idx,
fd = open(uio_res->path, O_RDWR);
if (fd < 0) {
VMBUS_LOG(ERR, "Cannot open %s: %s",
- uio_res->path, strerror(errno));
+ uio_res->path, rte_strerror(errno));
return -1;
}
 
@@ -256,13 +257,13 @@ static int vmbus_uio_map_subchan(const struct 
rte_vmbus_device *dev,
fd = open(ring_path, O_RDWR);
if (fd < 0) {
VMBUS_LOG(ERR, "Cannot open %s: %s",
- ring_path, strerror(errno));
+ ring_path, rte_strerror(errno));
return -errno;
}
 
if (fstat(fd, &sb) < 0) {
VMBUS_LOG(ERR, "Cannot state %s: %s",
- ring_path, strerror(errno));
+ ring_path, rte_strerror(errno));
close(fd);
return -errno;
}
@@ -342,7 +343,7 @@ static int vmbus_uio_sysfs_read(const char *dir, const char 
*name,
f = fopen(path, "r");
if (!f) {
VMBUS_LOG(ERR, "can't open %s:%s",
- path, strerror(errno));
+ path, rte_strerror(errno));
return -errno;
}
 
@@ -404,7 +405,7 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,
chan_dir = opendir(chan_path);
if (!chan_dir) {
VMBUS_LOG(ERR, "cannot open %s: %s",
- chan_path, strerror(errno));
+ chan_path, rte_strerror(errno));
return -errno;
}
 
@@ -441,7 +442,7 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,

[PATCH 14/43] bus/pci: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/bus/pci/bsd/pci.c|  8 
 drivers/bus/pci/linux/pci.c  |  7 ---
 drivers/bus/pci/linux/pci_uio.c  | 23 ---
 drivers/bus/pci/linux/pci_vfio.c | 23 ---
 drivers/bus/pci/pci_common_uio.c |  3 ++-
 5 files changed, 34 insertions(+), 30 deletions(-)

diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c
index 27f12590d4..ce08372931 100644
--- a/drivers/bus/pci/bsd/pci.c
+++ b/drivers/bus/pci/bsd/pci.c
@@ -125,7 +125,7 @@ pci_uio_alloc_resource(struct rte_pci_device *dev,
 
if (rte_intr_fd_get(dev->intr_handle) < 0) {
RTE_LOG(ERR, EAL, "Cannot open %s: %s\n",
-   devname, strerror(errno));
+   devname, rte_strerror(errno));
goto error;
}
 
@@ -169,7 +169,7 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, 
int res_idx,
maps[map_idx].path = rte_malloc(NULL, strlen(devname) + 1, 0);
if (maps[map_idx].path == NULL) {
RTE_LOG(ERR, EAL, "Cannot allocate memory for path: %s\n",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
@@ -179,7 +179,7 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, 
int res_idx,
fd = open(devname, O_RDWR);
if (fd < 0) {
RTE_LOG(ERR, EAL, "Cannot open %s: %s\n",
-   devname, strerror(errno));
+   devname, rte_strerror(errno));
goto error;
}
 
@@ -353,7 +353,7 @@ rte_pci_scan(void)
unsigned i;
if (ioctl(fd, PCIOCGETCONF, &conf_io) < 0) {
RTE_LOG(ERR, EAL, "%s(): error with ioctl on /dev/pci: 
%s\n",
-   __func__, strerror(errno));
+   __func__, rte_strerror(errno));
goto error;
}
 
diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 3d237398d9..7d870b43d2 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -12,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "eal_filesystem.h"
 
@@ -455,7 +456,7 @@ rte_pci_scan(void)
dir = opendir(rte_pci_get_sysfs_path());
if (dir == NULL) {
RTE_LOG(ERR, EAL, "%s(): opendir failed: %s\n",
-   __func__, strerror(errno));
+   __func__, rte_strerror(errno));
return -1;
}
 
@@ -506,7 +507,7 @@ pci_device_iommu_support_va(const struct rte_pci_device 
*dev)
return true;
 
RTE_LOG(ERR, EAL, "%s(): can't open %s: %s\n",
-   __func__, filename, strerror(errno));
+   __func__, filename, rte_strerror(errno));
return false;
}
 
@@ -557,7 +558,7 @@ pci_device_iommu_support_va(__rte_unused const struct 
rte_pci_device *dev)
 
if (fp == NULL) {
RTE_LOG(ERR, EAL, "%s(): can't open %s: %s\n",
-   __func__, filename, strerror(errno));
+   __func__, filename, rte_strerror(errno));
return ret;
}
 
diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c
index 97d740dfe5..2ee0179ea2 100644
--- a/drivers/bus/pci/linux/pci_uio.c
+++ b/drivers/bus/pci/linux/pci_uio.c
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "eal_filesystem.h"
 #include "pci_init.h"
@@ -111,7 +112,7 @@ pci_mknod_uio_dev(const char *sysfs_uio_path, unsigned 
uio_num)
ret = mknod(filename, S_IFCHR | S_IRUSR | S_IWUSR, dev);
if (ret != 0) {
RTE_LOG(ERR, EAL, "%s(): mknod() failed %s\n",
-   __func__, strerror(errno));
+   __func__, rte_strerror(errno));
return -1;
}
 
@@ -241,7 +242,7 @@ pci_uio_alloc_resource(struct rte_pci_device *dev,
fd = open(devname, O_RDWR);
if (fd < 0) {
RTE_LOG(ERR, EAL, "Cannot open %s: %s\n",
-   devname, strerror(errno));
+   devname, rte_strerror(errno));
goto error;
}
 
@@ -254,7 +255,7 @@ pci_uio_alloc_resource(struct rte_pci_device *dev,
uio_cfg_fd = open(cfgname, O_RDWR);
if (uio_cfg_fd < 0) {
RTE_LOG(ERR, EAL, "Cannot open %s: %s\n",
-   cfgname, strerror(errno));
+   cfgname, rte_strerror(errno));
goto error;
}
 
@@ -314,7 +315,7 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, 
int res_idx,
maps[map

[PATCH 17/43] common/cnxk: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/common/cnxk/roc_dev.c   | 4 +++-
 drivers/common/cnxk/roc_model.c | 4 +++-
 drivers/common/cnxk/roc_utils.c | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
index e7e89bf3d6..812e6890f0 100644
--- a/drivers/common/cnxk/roc_dev.c
+++ b/drivers/common/cnxk/roc_dev.c
@@ -8,6 +8,8 @@
 #include 
 #include 
 
+#include 
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -1313,7 +1315,7 @@ dev_lmt_setup(struct dev *dev)
mz = plt_lmt_region_reserve_aligned(name, LMT_REGION_SIZE,
LMT_REGION_SIZE);
if (!mz) {
-   plt_err("Memory alloc failed: %s", strerror(errno));
+   plt_err("Memory alloc failed: %s", rte_strerror(errno));
goto fail;
}
 
diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c
index 6dc2afe7f0..647af4b7ab 100644
--- a/drivers/common/cnxk/roc_model.c
+++ b/drivers/common/cnxk/roc_model.c
@@ -6,6 +6,8 @@
 #include 
 #include 
 
+#include 
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -154,7 +156,7 @@ cn10k_part_pass_get(uint32_t *part, uint32_t *pass)
dir = opendir(SYSFS_PCI_DEVICES);
if (dir == NULL) {
plt_err("%s(): opendir failed: %s\n", __func__,
-   strerror(errno));
+   rte_strerror(errno));
return -errno;
}
 
diff --git a/drivers/common/cnxk/roc_utils.c b/drivers/common/cnxk/roc_utils.c
index 9af2ae9b69..418cd6b477 100644
--- a/drivers/common/cnxk/roc_utils.c
+++ b/drivers/common/cnxk/roc_utils.c
@@ -2,6 +2,8 @@
  * Copyright(C) 2021 Marvell.
  */
 
+#include 
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -245,7 +247,7 @@ roc_error_msg_get(int errorcode)
 * Handle general error (as defined in linux errno.h)
 */
if (abs(errorcode) < 300)
-   err_msg = strerror(abs(errorcode));
+   err_msg = rte_strerror(abs(errorcode));
else
err_msg = "Unknown error code";
break;
-- 
2.33.0

[PATCH 18/43] common/mlx5: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/common/mlx5/linux/mlx5_nl.c  | 12 ++--
 drivers/common/mlx5/mlx5_common.c|  6 +++---
 drivers/common/mlx5/mlx5_devx_cmds.c |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/common/mlx5/linux/mlx5_nl.c 
b/drivers/common/mlx5/linux/mlx5_nl.c
index 28a1f56dba..1de867089f 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -547,7 +547,7 @@ mlx5_nl_mac_addr_list(int nlsk_fd, unsigned int iface_idx,
return 0;
 error:
DRV_LOG(DEBUG, "Interface %u cannot retrieve MAC address list %s",
-   iface_idx, strerror(rte_errno));
+   iface_idx, rte_strerror(rte_errno));
return -rte_errno;
 }
 
@@ -617,7 +617,7 @@ mlx5_nl_mac_addr_modify(int nlsk_fd, unsigned int iface_idx,
DRV_LOG(DEBUG,
"Interface %u cannot %s MAC address %s %s",
iface_idx,
-   add ? "add" : "remove", m, strerror(rte_errno));
+   add ? "add" : "remove", m, rte_strerror(rte_errno));
}
 #endif
return -rte_errno;
@@ -704,7 +704,7 @@ mlx5_nl_vf_mac_addr_modify(int nlsk_fd, unsigned int 
iface_idx,
RTE_ETHER_ADDR_PRT_FMT " : %s",
vf_index,
RTE_ETHER_ADDR_BYTES(mac),
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
return -rte_errno;
 }
 
@@ -929,7 +929,7 @@ mlx5_nl_promisc(int nlsk_fd, unsigned int iface_idx, int 
enable)
DRV_LOG(DEBUG,
"Interface %u cannot %s promisc mode: Netlink error %s",
iface_idx, enable ? "enable" : "disable",
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
return ret;
 }
 
@@ -956,7 +956,7 @@ mlx5_nl_allmulti(int nlsk_fd, unsigned int iface_idx, int 
enable)
DRV_LOG(DEBUG,
"Interface %u cannot %s allmulti : Netlink error %s",
iface_idx, enable ? "enable" : "disable",
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
return ret;
 }
 
@@ -1934,7 +1934,7 @@ mlx5_nl_read_events(int nlsk_fd, mlx5_nl_event_cb *cb, 
void *cb_arg)
if (errno == EINTR)
continue;
DRV_LOG(DEBUG, "Failed to receive netlink message: %s",
-   strerror(errno));
+   rte_strerror(errno));
rte_errno = errno;
return -rte_errno;
}
diff --git a/drivers/common/mlx5/mlx5_common.c 
b/drivers/common/mlx5/mlx5_common.c
index ca8543e36e..7aafd0083d 100644
--- a/drivers/common/mlx5/mlx5_common.c
+++ b/drivers/common/mlx5/mlx5_common.c
@@ -762,7 +762,7 @@ mlx5_common_dev_create(struct rte_device *eal_dev, uint32_t 
classes,
ret = mlx5_common_config_get(mkvlist, &cdev->config);
if (ret < 0) {
DRV_LOG(ERR, "Failed to process device arguments: %s",
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
rte_free(cdev);
return NULL;
}
@@ -837,7 +837,7 @@ mlx5_common_probe_again_args_validate(struct 
mlx5_common_device *cdev,
ret = mlx5_common_config_get(mkvlist, config);
if (ret) {
DRV_LOG(ERR, "Failed to process device configure: %s",
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
mlx5_free(config);
return ret;
}
@@ -1011,7 +1011,7 @@ mlx5_common_dev_probe(struct rte_device *eal_dev)
if (ret) {
DRV_LOG(ERR,
"Probe again parameters aren't compatible : %s",
-   strerror(rte_errno));
+   rte_strerror(rte_errno));
goto class_err;
}
}
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c 
b/drivers/common/mlx5/mlx5_devx_cmds.c
index 4d8818924a..b33b5d3044 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -640,7 +640,7 @@ mlx5_devx_cmd_match_sample_info_query(void *ctx, uint32_t 
sample_field_id,
rc = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out));
if (rc) {
DRV_LOG(ERR, "Failed to query match sample info using DevX: %s",
-   strerror(rc));
+   rte_strerror(rc));
rte_errno = rc;
return -rc;
}
-- 
2.33.0

[PATCH 20/43] dma/idxd: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/dma/idxd/idxd_bus.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c
index 3b2d4c2b65..a230976c98 100644
--- a/drivers/dma/idxd/idxd_bus.c
+++ b/drivers/dma/idxd/idxd_bus.c
@@ -145,7 +145,7 @@ read_wq_string(struct rte_dsa_device *dev, const char 
*filename,
fd = open(sysfs_node, O_RDONLY);
if (fd < 0) {
IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
return -1;
}
 
@@ -153,7 +153,7 @@ read_wq_string(struct rte_dsa_device *dev, const char 
*filename,
close(fd);
if (len < 0) {
IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
return -1;
}
value[len] = '\0';
@@ -173,13 +173,13 @@ read_wq_int(struct rte_dsa_device *dev, const char 
*filename,
f = fopen(sysfs_node, "r");
if (f == NULL) {
IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
return -1;
}
 
if (fscanf(f, "%d", value) != 1) {
IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
ret = -1;
}
 
@@ -200,13 +200,13 @@ read_device_int(struct rte_dsa_device *dev, const char 
*filename,
f = fopen(sysfs_node, "r");
if (f == NULL) {
IDXD_PMD_ERR("%s(): opening file '%s' failed: %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
return -1;
}
 
if (fscanf(f, "%d", value) != 1) {
IDXD_PMD_ERR("%s(): error reading file '%s': %s",
-   __func__, sysfs_node, strerror(errno));
+   __func__, sysfs_node, rte_strerror(errno));
ret = -1;
}
 
@@ -317,7 +317,7 @@ dsa_scan(void)
if (errno == ENOENT)
return 0; /* no bus, return without error */
IDXD_PMD_ERR("%s(): opendir '%s' failed: %s",
-   __func__, path, strerror(errno));
+   __func__, path, rte_strerror(errno));
return -1;
}
 
-- 
2.33.0

[PATCH 19/43] crypto/caam_jr: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/crypto/caam_jr/caam_jr_uio.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c 
b/drivers/crypto/caam_jr/caam_jr_uio.c
index 583ba3b523..b612407c41 100644
--- a/drivers/crypto/caam_jr/caam_jr_uio.c
+++ b/drivers/crypto/caam_jr/caam_jr_uio.c
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -355,7 +356,7 @@ free_job_ring(int uio_fd)
if (munmap(job_ring->register_base_addr, job_ring->map_size)) {
CAAM_JR_INFO("cannot munmap(%p, 0x%lx): %s",
job_ring->register_base_addr,
-   (unsigned long)job_ring->map_size, strerror(errno));
+   (unsigned long)job_ring->map_size, rte_strerror(errno));
} else
CAAM_JR_DEBUG("JR UIO memory is unmapped");
 
@@ -419,7 +420,7 @@ sec_configure(void)
d = opendir(SEC_UIO_DEVICE_SYS_ATTR_PATH);
if (d == NULL) {
printf("\nError opening directory '%s': %s\n",
-   SEC_UIO_DEVICE_SYS_ATTR_PATH, strerror(errno));
+   SEC_UIO_DEVICE_SYS_ATTR_PATH, rte_strerror(errno));
return -1;
}
 
-- 
2.33.0

[PATCH 21/43] net/af_packet: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/af_packet/rte_eth_af_packet.c 
b/drivers/net/af_packet/rte_eth_af_packet.c
index 397a32db58..2f884d4b7f 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -108,7 +108,7 @@ RTE_LOG_REGISTER_DEFAULT(af_packet_logtype, NOTICE);
 
 #define PMD_LOG_ERRNO(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, af_packet_logtype, \
-   "%s(): " fmt ":%s\n", __func__, ##args, strerror(errno))
+   "%s(): " fmt ":%s\n", __func__, ##args, rte_strerror(errno))
 
 static uint16_t
 eth_af_packet_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
-- 
2.33.0

[PATCH 27/43] net/enetfec: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/enetfec/enet_uio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/enetfec/enet_uio.c b/drivers/net/enetfec/enet_uio.c
index 6539cbb354..93520e9760 100644
--- a/drivers/net/enetfec/enet_uio.c
+++ b/drivers/net/enetfec/enet_uio.c
@@ -231,7 +231,7 @@ enetfec_configure(void)
d = opendir(FEC_UIO_DEVICE_SYS_ATTR_PATH);
if (d == NULL) {
ENETFEC_PMD_ERR("\nError opening directory '%s': %s\n",
-   FEC_UIO_DEVICE_SYS_ATTR_PATH, strerror(errno));
+   FEC_UIO_DEVICE_SYS_ATTR_PATH, rte_strerror(errno));
return -1;
}
 
-- 
2.33.0

[PATCH 23/43] net/af_xdp: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c 
b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 353c8688ec..087b6e33db 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -1165,7 +1165,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals 
*internals,
&rxq->fq, &rxq->cq, &usr_config);
if (ret) {
AF_XDP_LOG(ERR, "Failed to create umem [%d]: [%s]\n",
-  errno, strerror(errno));
+  errno, rte_strerror(errno));
goto err;
}
umem->buffer = base_addr;
@@ -1367,7 +1367,7 @@ init_uds_sock(struct sockaddr_un *server)
if (connect(sock, (struct sockaddr *)server, sizeof(struct 
sockaddr_un)) < 0) {
close(sock);
AF_XDP_LOG(ERR, "Error connecting stream socket errno = [%d]: 
[%s]\n",
-  errno, strerror(errno));
+  errno, rte_strerror(errno));
return -1;
}
 
@@ -1451,7 +1451,7 @@ read_msg(int sock, char *response, struct sockaddr_un *s, 
int *fd)
return 0;
 
if (msglen < 0) {
-   AF_XDP_LOG(ERR, "recvmsg failed, %s\n", strerror(errno));
+   AF_XDP_LOG(ERR, "recvmsg failed, %s\n", rte_strerror(errno));
return -1;
}
 
@@ -1486,7 +1486,7 @@ make_request_cni(int sock, struct sockaddr_un *server, 
char *request,
rval = send_msg(sock, request, req_fd);
 
if (rval < 0) {
-   AF_XDP_LOG(ERR, "Write error %s\n", strerror(errno));
+   AF_XDP_LOG(ERR, "Write error %s\n", rte_strerror(errno));
return -1;
}
 
@@ -1970,7 +1970,7 @@ parse_prog_arg(const char *key __rte_unused,
 
if (access(value, F_OK) != 0) {
AF_XDP_LOG(ERR, "Error accessing %s: %s\n",
-  value, strerror(errno));
+  value, rte_strerror(errno));
return -EINVAL;
}
 
@@ -2421,7 +2421,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, 
afxdp_mp_send_fds);
if (ret < 0 && rte_errno != ENOTSUP) {
AF_XDP_LOG(ERR, "%s: Failed to register multi-process 
IPC callback: %s\n",
-  name, strerror(rte_errno));
+  name, rte_strerror(rte_errno));
return -1;
}
}
-- 
2.33.0

[PATCH 26/43] net/dpaa2: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 8e610b6bba..48f1a2fafb 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -1166,7 +1166,7 @@ dpaa2_eth_setup_irqs(struct rte_eth_dev *dev, int enable)
irq_index, mask);
if (err < 0) {
DPAA2_PMD_ERR("Error: dpni_set_irq_mask():%d (%s)", err,
- strerror(-err));
+ rte_strerror(-err));
return err;
}
 
@@ -1174,7 +1174,7 @@ dpaa2_eth_setup_irqs(struct rte_eth_dev *dev, int enable)
  irq_index, enable);
if (err < 0)
DPAA2_PMD_ERR("Error: dpni_set_irq_enable():%d (%s)", err,
- strerror(-err));
+ rte_strerror(-err));
 
return err;
 }
-- 
2.33.0

[PATCH 25/43] net/dpaa: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/dpaa/dpaa_ethdev.c  | 4 ++--
 drivers/net/dpaa/fmlib/fm_lib.c | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index ef4c06db6a..214627986f 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -1080,7 +1080,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
ret = qman_init_fq(rxq, flags, &opts);
if (ret) {
DPAA_PMD_ERR("Channel/Q association failed. fqid 0x%x "
-   "ret:%d(%s)", rxq->fqid, ret, strerror(ret));
+   "ret:%d(%s)", rxq->fqid, ret, 
rte_strerror(ret));
return ret;
}
if (dpaa_svr_family == SVR_LS1043A_FAMILY) {
@@ -1210,7 +1210,7 @@ dpaa_eth_eventq_attach(const struct rte_eth_dev *dev,
ret = qman_init_fq(rxq, flags, &opts);
if (ret) {
DPAA_PMD_ERR("Ev-Channel/Q association failed. fqid 0x%x "
-   "ret:%d(%s)", rxq->fqid, ret, strerror(ret));
+   "ret:%d(%s)", rxq->fqid, ret, 
rte_strerror(ret));
return ret;
}
 
diff --git a/drivers/net/dpaa/fmlib/fm_lib.c b/drivers/net/dpaa/fmlib/fm_lib.c
index 1d6816050c..d4382d7065 100644
--- a/drivers/net/dpaa/fmlib/fm_lib.c
+++ b/drivers/net/dpaa/fmlib/fm_lib.c
@@ -103,7 +103,7 @@ fm_get_api_version(t_handle h_fm, ioc_fm_api_version_t 
*p_version)
ret = ioctl(p_dev->fd, FM_IOC_GET_API_VERSION, p_version);
if (ret) {
DPAA_PMD_ERR("cannot get API version, error %i (%s)\n",
-errno, strerror(errno));
+errno, rte_strerror(errno));
RETURN_ERROR(MINOR, E_INVALID_OPERATION, NO_MSG);
}
_fml_dbg("Finishing.\n");
@@ -276,7 +276,7 @@ fm_pcd_kg_scheme_set(t_handle h_fm_pcd,
ret = ioctl(p_pcd_dev->fd, FM_PCD_IOC_KG_SCHEME_SET, params);
if (ret) {
DPAA_PMD_ERR("  cannot set kg scheme, error %i (%s)\n",
-errno, strerror(errno));
+errno, rte_strerror(errno));
return NULL;
}
 
@@ -310,7 +310,7 @@ fm_pcd_kg_scheme_delete(t_handle h_scheme)
 
if (ioctl(p_pcd_dev->fd, FM_PCD_IOC_KG_SCHEME_DELETE, &id)) {
DPAA_PMD_WARN("cannot delete kg scheme, error %i (%s)\n",
- errno, strerror(errno));
+ errno, rte_strerror(errno));
RETURN_ERROR(MINOR, E_INVALID_OPERATION, NO_MSG);
}
 
-- 
2.33.0

[PATCH 30/43] net/ice: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/ice/ice_testpmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ice/ice_testpmd.c b/drivers/net/ice/ice_testpmd.c
index a7a8d0c53c..e1392059e0 100644
--- a/drivers/net/ice/ice_testpmd.c
+++ b/drivers/net/ice/ice_testpmd.c
@@ -60,7 +60,7 @@ cmd_ddp_dump_parsed(void *parsed_result,
default:
fprintf(stderr,
"Failed to dump DDP runtime configure,"
-   " error: (%s)\n", strerror(-ret));
+   " error: (%s)\n", rte_strerror(-ret));
}
}
free(buff);
@@ -127,7 +127,7 @@ cmd_ddp_dump_switch_parsed(void *parsed_result,
default:
fprintf(stderr,
"Failed to dump DDP switch runtime configure,"
-   " error: (%s)\n", strerror(-ret));
+   " error: (%s)\n", rte_strerror(-ret));
}
}
free(buff);
-- 
2.33.0

[PATCH 28/43] net/failsafe: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/failsafe/failsafe.c | 8 
 drivers/net/failsafe/failsafe_args.c| 4 ++--
 drivers/net/failsafe/failsafe_eal.c | 4 ++--
 drivers/net/failsafe/failsafe_flow.c| 4 ++--
 drivers/net/failsafe/failsafe_ops.c | 2 +-
 drivers/net/failsafe/failsafe_private.h | 6 +++---
 6 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
index 32811403b4..f89c946ce4 100644
--- a/drivers/net/failsafe/failsafe.c
+++ b/drivers/net/failsafe/failsafe.c
@@ -92,7 +92,7 @@ failsafe_hotplug_alarm_cancel(struct rte_eth_dev *dev)
rte_eal_alarm_cancel(fs_hotplug_alarm, dev);
if (rte_errno) {
ERROR("rte_eal_alarm_cancel failed (errno: %s)",
- strerror(rte_errno));
+ rte_strerror(rte_errno));
ret = -rte_errno;
} else {
PRIV(dev)->pending_alarm = 0;
@@ -138,18 +138,18 @@ fs_mutex_init(struct fs_priv *priv)
 
ret = pthread_mutexattr_init(&attr);
if (ret) {
-   ERROR("Cannot initiate mutex attributes - %s", strerror(ret));
+   ERROR("Cannot initiate mutex attributes - %s", 
rte_strerror(ret));
return ret;
}
/* Allow mutex relocks for the thread holding the mutex. */
ret = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);
if (ret) {
-   ERROR("Cannot set mutex type - %s", strerror(ret));
+   ERROR("Cannot set mutex type - %s", rte_strerror(ret));
return ret;
}
ret = pthread_mutex_init(&priv->hotplug_mutex, &attr);
if (ret) {
-   ERROR("Cannot initiate mutex - %s", strerror(ret));
+   ERROR("Cannot initiate mutex - %s", rte_strerror(ret));
return ret;
}
return 0;
diff --git a/drivers/net/failsafe/failsafe_args.c 
b/drivers/net/failsafe/failsafe_args.c
index b203e02d9a..77169b7bbe 100644
--- a/drivers/net/failsafe/failsafe_args.c
+++ b/drivers/net/failsafe/failsafe_args.c
@@ -112,7 +112,7 @@ fs_execute_cmd(struct sub_device *sdev, char *cmdline)
fp = popen(sdev->cmdline, "r");
if (fp == NULL) {
ret = -errno;
-   ERROR("popen: %s", strerror(errno));
+   ERROR("popen: %s", rte_strerror(errno));
return ret;
}
/* We only read one line */
@@ -131,7 +131,7 @@ fs_execute_cmd(struct sub_device *sdev, char *cmdline)
ERROR("Parsing device '%s' failed", output);
 ret_pclose:
if (pclose(fp) == -1)
-   ERROR("pclose: %s", strerror(errno));
+   ERROR("pclose: %s", rte_strerror(errno));
return ret;
 }
 
diff --git a/drivers/net/failsafe/failsafe_eal.c 
b/drivers/net/failsafe/failsafe_eal.c
index d71b512f81..b06579692a 100644
--- a/drivers/net/failsafe/failsafe_eal.c
+++ b/drivers/net/failsafe/failsafe_eal.c
@@ -52,7 +52,7 @@ fs_bus_init(struct rte_eth_dev *dev)
if (ret < 0) {
ERROR("sub_device %d probe failed %s%s%s", i,
  rte_errno ? "(" : "",
- rte_errno ? strerror(rte_errno) : "",
+ rte_errno ? rte_strerror(rte_errno) : "",
  rte_errno ? ")" : "");
continue;
}
@@ -100,7 +100,7 @@ fs_bus_init(struct rte_eth_dev *dev)
ret = rte_eth_dev_owner_set(pid, &PRIV(dev)->my_owner);
if (ret < 0) {
INFO("sub_device %d owner set failed (%s), "
-"will try again later", i, strerror(-ret));
+"will try again later", i, 
rte_strerror(-ret));
continue;
} else if (strncmp(rte_eth_devices[pid].device->name,
   da->name, strlen(da->name)) != 0) {
diff --git a/drivers/net/failsafe/failsafe_flow.c 
b/drivers/net/failsafe/failsafe_flow.c
index 707e6c63b5..5d17182cc5 100644
--- a/drivers/net/failsafe/failsafe_flow.c
+++ b/drivers/net/failsafe/failsafe_flow.c
@@ -33,7 +33,7 @@ fs_flow_allocate(const struct rte_flow_attr *attr,
if (ret < 0) {
ERROR("Unable to process flow rule (%s): %s",
  error.message ? error.message : "unspecified",
- strerror(rte_errno));
+ rte_strerror(rte_errno));
return NULL;
}
flow = rte_zmalloc(NULL, offsetof(struct rte_flow, rule) + ret,
@@ -47,7 +47,7 @@ fs_flow_allocate(const struct rte_fl

[PATCH 29/43] net/i40e: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/i40e/i40e_testpmd.c | 42 -
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c
index b6ef5d6e42..d0995531bc 100644
--- a/drivers/net/i40e/i40e_testpmd.c
+++ b/drivers/net/i40e/i40e_testpmd.c
@@ -53,7 +53,7 @@ cmd_queue_region_parsed(void *parsed_result,
break;
default:
fprintf(stderr, "queue region config error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
}
 }
 
@@ -148,7 +148,7 @@ cmd_region_flowtype_parsed(void *parsed_result,
break;
default:
fprintf(stderr, "region flowtype config error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
}
 }
 
@@ -233,7 +233,7 @@ cmd_user_priority_region_parsed(void *parsed_result,
break;
default:
fprintf(stderr, "user_priority region config error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
}
 }
 
@@ -320,7 +320,7 @@ cmd_flush_queue_region_parsed(void *parsed_result,
break;
default:
fprintf(stderr, "queue region config flush error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
}
 }
 
@@ -433,7 +433,7 @@ cmd_show_queue_region_info_parsed(void *parsed_result,
break;
default:
fprintf(stderr, "queue region config info show error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
}
 }
 
@@ -536,7 +536,7 @@ cmd_flow_director_filter_parsed(void *parsed_result,
add);
if (ret < 0)
fprintf(stderr, "flow director config error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
close_file(conf.input.packet);
 }
 
@@ -666,7 +666,7 @@ cmd_set_vf_promisc_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -745,7 +745,7 @@ cmd_set_vf_allmulti_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -825,7 +825,7 @@ cmd_set_vf_broadcast_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -908,7 +908,7 @@ cmd_set_vf_vlan_tag_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -1013,7 +1013,7 @@ cmd_vf_max_bw_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -1108,7 +1108,7 @@ cmd_vf_tc_min_bw_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -1158,7 +1158,7 @@ cmd_vf_tc_max_bw_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -1207,7 +1207,7 @@ cmd_strict_link_prio_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, 

[PATCH 24/43] net/bonding: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/bonding/bonding_testpmd.c   | 4 ++--
 drivers/net/bonding/rte_eth_bond_api.c  | 2 +-
 drivers/net/bonding/rte_eth_bond_flow.c | 4 ++--
 drivers/net/bonding/rte_eth_bond_pmd.c  | 6 +++---
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bonding/bonding_testpmd.c 
b/drivers/net/bonding/bonding_testpmd.c
index 8fcd6cadd0..111f9de0e7 100644
--- a/drivers/net/bonding/bonding_testpmd.c
+++ b/drivers/net/bonding/bonding_testpmd.c
@@ -551,7 +551,7 @@ static void cmd_set_bond_mac_addr_parsed(void 
*parsed_result,
/* check the return value and print it if is < 0 */
if (ret < 0)
fprintf(stderr, "set_bond_mac_addr error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
 }
 
 static cmdline_parse_token_string_t cmd_set_bond_mac_addr_set =
@@ -604,7 +604,7 @@ static void cmd_set_bond_mon_period_parsed(void 
*parsed_result,
/* check the return value and print it if is < 0 */
if (ret < 0)
fprintf(stderr, "set_bond_mac_addr error: (%s)\n",
-   strerror(-ret));
+   rte_strerror(-ret));
 }
 
 static cmdline_parse_token_string_t cmd_set_bond_mon_period_set =
diff --git a/drivers/net/bonding/rte_eth_bond_api.c 
b/drivers/net/bonding/rte_eth_bond_api.c
index 99e496556a..1d20d421bc 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -483,7 +483,7 @@ __eth_bond_member_add_lock_free(uint16_t bonding_port_id, 
uint16_t member_port_i
if (ret != 0) {
RTE_BOND_LOG(ERR,
"%s: Error during getting device (port %u) info: %s\n",
-   __func__, member_port_id, strerror(-ret));
+   __func__, member_port_id, rte_strerror(-ret));
 
return ret;
}
diff --git a/drivers/net/bonding/rte_eth_bond_flow.c 
b/drivers/net/bonding/rte_eth_bond_flow.c
index 71a91675f7..b7e966f393 100644
--- a/drivers/net/bonding/rte_eth_bond_flow.c
+++ b/drivers/net/bonding/rte_eth_bond_flow.c
@@ -31,7 +31,7 @@ bond_flow_alloc(int numa_node, const struct rte_flow_attr 
*attr,
if (ret < 0) {
RTE_BOND_LOG(ERR, "Unable to process flow rule (%s): %s",
 error.message ? error.message : "unspecified",
-strerror(rte_errno));
+rte_strerror(rte_errno));
return NULL;
}
flow = rte_zmalloc_socket(NULL, offsetof(struct rte_flow, rule) + ret,
@@ -45,7 +45,7 @@ bond_flow_alloc(int numa_node, const struct rte_flow_attr 
*attr,
if (ret < 0) {
RTE_BOND_LOG(ERR, "Failed to copy flow rule (%s): %s",
 error.message ? error.message : "unspecified",
-strerror(rte_errno));
+rte_strerror(rte_errno));
rte_free(flow);
return NULL;
}
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c 
b/drivers/net/bonding/rte_eth_bond_pmd.c
index c40d18d128..fdf152a51a 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -192,7 +192,7 @@ bond_ethdev_8023ad_flow_verify(struct rte_eth_dev *bond_dev,
if (ret != 0) {
RTE_BOND_LOG(ERR,
"%s: Error during getting device (port %u) info: %s\n",
-   __func__, member_port, strerror(-ret));
+   __func__, member_port, rte_strerror(-ret));
 
return ret;
}
@@ -223,7 +223,7 @@ bond_8023ad_slow_pkt_hw_filter_supported(uint16_t port_id) {
RTE_BOND_LOG(ERR,
"%s: Error during getting device (port %u) 
info: %s\n",
__func__, bond_dev->data->port_id,
-   strerror(-ret));
+   rte_strerror(-ret));
 
return ret;
}
@@ -2292,7 +2292,7 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
"%s: Error during getting device (port 
%u) info: %s\n",
__func__,
member.port_id,
-   strerror(-ret));
+   rte_strerror(-ret));
 
return ret;
}
-- 
2.33.0

[PATCH 31/43] net/ixgbe: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/ixgbe/ixgbe_testpmd.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_testpmd.c 
b/drivers/net/ixgbe/ixgbe_testpmd.c
index e0d161eafe..3c6d648844 100644
--- a/drivers/net/ixgbe/ixgbe_testpmd.c
+++ b/drivers/net/ixgbe/ixgbe_testpmd.c
@@ -141,7 +141,7 @@ cmd_set_vf_split_drop_en_parsed(void *parsed_result,
fprintf(stderr, "not supported on port %d\n", res->port_id);
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -243,7 +243,7 @@ cmd_set_macsec_offload_on_parsed(void *parsed_result,
fprintf(stderr, "not supported on port %d\n", port_id);
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -327,7 +327,7 @@ cmd_set_macsec_offload_off_parsed(void *parsed_result,
fprintf(stderr, "not supported on port %d\n", port_id);
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -402,7 +402,7 @@ cmd_set_macsec_sc_parsed(void *parsed_result,
fprintf(stderr, "not supported on port %d\n", res->port_id);
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -510,7 +510,7 @@ cmd_set_macsec_sa_parsed(void *parsed_result,
fprintf(stderr, "not supported on port %d\n", res->port_id);
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
@@ -599,7 +599,7 @@ cmd_tc_min_bw_parsed(void *parsed_result,
fprintf(stderr, "function not implemented\n");
break;
default:
-   fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
+   fprintf(stderr, "programming error: (%s)\n", 
rte_strerror(-ret));
}
 }
 
-- 
2.33.0

[PATCH 32/43] net/memif: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/memif/memif_socket.c  |  4 ++--
 drivers/net/memif/rte_eth_memif.c | 20 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c
index 649f8d0e61..592b71979a 100644
--- a/drivers/net/memif/memif_socket.c
+++ b/drivers/net/memif/memif_socket.c
@@ -71,7 +71,7 @@ memif_msg_send_from_queue(struct memif_control_channel *cc)
size = memif_msg_send(rte_intr_fd_get(cc->intr_handle), &e->msg,
  e->fd);
if (size != sizeof(memif_msg_t)) {
-   MIF_LOG(ERR, "sendmsg fail: %s.", strerror(errno));
+   MIF_LOG(ERR, "sendmsg fail: %s.", rte_strerror(errno));
ret = -1;
} else {
MIF_LOG(DEBUG, "Sent msg type %u.", e->msg.type);
@@ -975,7 +975,7 @@ memif_socket_create(char *key, uint8_t listener, bool 
is_abstract, uid_t owner_u
return sock;
 
  error:
-   MIF_LOG(ERR, "Failed to setup socket %s: %s", key, strerror(errno));
+   MIF_LOG(ERR, "Failed to setup socket %s: %s", key, rte_strerror(errno));
if (sock != NULL) {
rte_intr_instance_free(sock->intr_handle);
rte_free(sock);
diff --git a/drivers/net/memif/rte_eth_memif.c 
b/drivers/net/memif/rte_eth_memif.c
index 7cc8c0da91..f7697394f1 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -805,7 +805,7 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t 
nb_pkts)
 sizeof(a));
if (unlikely(size < 0)) {
MIF_LOG(WARNING,
-   "Failed to send interrupt. %s", 
strerror(errno));
+   "Failed to send interrupt. %s", 
rte_strerror(errno));
}
}
 
@@ -960,7 +960,7 @@ eth_memif_tx_zc(void *queue, struct rte_mbuf **bufs, 
uint16_t nb_pkts)
 &a, sizeof(a));
if (unlikely(size < 0)) {
MIF_LOG(WARNING,
-   "Failed to send interrupt. %s", 
strerror(errno));
+   "Failed to send interrupt. %s", 
rte_strerror(errno));
}
}
 
@@ -1082,27 +1082,27 @@ memif_region_init_shm(struct rte_eth_dev *dev, uint8_t 
has_buffers)
 
r->fd = memfd_create(shm_name, MFD_ALLOW_SEALING);
if (r->fd < 0) {
-   MIF_LOG(ERR, "Failed to create shm file: %s.", strerror(errno));
+   MIF_LOG(ERR, "Failed to create shm file: %s.", 
rte_strerror(errno));
ret = -1;
goto error;
}
 
ret = fcntl(r->fd, F_ADD_SEALS, F_SEAL_SHRINK);
if (ret < 0) {
-   MIF_LOG(ERR, "Failed to add seals to shm file: %s.", 
strerror(errno));
+   MIF_LOG(ERR, "Failed to add seals to shm file: %s.", 
rte_strerror(errno));
goto error;
}
 
ret = ftruncate(r->fd, r->region_size);
if (ret < 0) {
-   MIF_LOG(ERR, "Failed to truncate shm file: %s.", 
strerror(errno));
+   MIF_LOG(ERR, "Failed to truncate shm file: %s.", 
rte_strerror(errno));
goto error;
}
 
r->addr = mmap(NULL, r->region_size, PROT_READ |
   PROT_WRITE, MAP_SHARED, r->fd, 0);
if (r->addr == MAP_FAILED) {
-   MIF_LOG(ERR, "Failed to mmap shm region: %s.", strerror(ret));
+   MIF_LOG(ERR, "Failed to mmap shm region: %s.", 
rte_strerror(ret));
ret = -1;
goto error;
}
@@ -1223,7 +1223,7 @@ memif_init_queues(struct rte_eth_dev *dev)
if (rte_intr_fd_get(mq->intr_handle) < 0) {
MIF_LOG(WARNING,
"Failed to create eventfd for tx queue %d: 
%s.", i,
-   strerror(errno));
+   rte_strerror(errno));
}
mq->buffers = NULL;
if (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY) {
@@ -1247,7 +1247,7 @@ memif_init_queues(struct rte_eth_dev *dev)
if (rte_intr_fd_get(mq->intr_handle) < 0) {
MIF_LOG(WARNING,
"Failed to create eventfd for rx queue %d: 
%s.", i,
-   strerror(errno));
+   rte_strerror(errno));
}
mq->buffers = NULL;
if (pmd->flags & ETH_MEMIF_FLAG_ZERO_COPY) {
@@ -1299,7 +1299,7 @@ memif_connect(struct rte_eth_dev *dev)
MAP_SHARED, mr->fd, 0);
if (mr->addr == MAP_FAILED) {
  

[PATCH 35/43] net/qede: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/qede/qede_regs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_regs.c b/drivers/net/qede/qede_regs.c
index d2ea1c9108..3aa31a42c2 100644
--- a/drivers/net/qede/qede_regs.c
+++ b/drivers/net/qede/qede_regs.c
@@ -221,7 +221,7 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t 
len)
 
if (!f) {
fprintf(stderr, "Can't open file %s: %s\n",
-   dump_file, strerror(errno));
+   dump_file, rte_strerror(errno));
return 1;
}
bytes = fwrite(dump, 1, len, f);
@@ -234,7 +234,7 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t 
len)
 
if (fclose(f)) {
fprintf(stderr, "Can't close file %s: %s\n",
-   dump_file, strerror(errno));
+   dump_file, rte_strerror(errno));
err = 1;
}
 
-- 
2.33.0

[PATCH 36/43] net/sfc: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/sfc/sfc_flow.c|  2 +-
 drivers/net/sfc/sfc_flow_tunnel.c |  2 +-
 drivers/net/sfc/sfc_mae.c | 58 +++
 3 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 1b50aefe5c..304628026d 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1403,7 +1403,7 @@ sfc_flow_parse_pattern(struct sfc_adapter *sa,
rc = item->parse(pattern, parse_ctx, error);
if (rc != 0) {
sfc_err(sa, "failed to parse item %s: %s",
-   item->name, strerror(-rc));
+   item->name, rte_strerror(-rc));
return rc;
}
 
diff --git a/drivers/net/sfc/sfc_flow_tunnel.c 
b/drivers/net/sfc/sfc_flow_tunnel.c
index 889fee569a..898d00dd6d 100644
--- a/drivers/net/sfc/sfc_flow_tunnel.c
+++ b/drivers/net/sfc/sfc_flow_tunnel.c
@@ -120,7 +120,7 @@ sfc_ft_tunnel_rule_detect(struct sfc_adapter *sa,
if (rc != 0) {
/* The loop above might have spotted wrong actions. */
sfc_err(sa, "FT: TUNNEL: invalid actions: %s",
-   strerror(rc));
+   rte_strerror(rc));
goto fail;
}
 
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index e5ec0ae49d..accde9bcb0 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -429,7 +429,7 @@ sfc_mae_outer_rule_enable(struct sfc_adapter *sa,
   &fw_rsrc->rule_id);
if (rc != 0) {
sfc_err(sa, "failed to enable outer_rule=%p: %s",
-   rule, strerror(rc));
+   rule, rte_strerror(rc));
return rc;
}
}
@@ -446,7 +446,7 @@ sfc_mae_outer_rule_enable(struct sfc_adapter *sa,
fw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;
}
 
-   sfc_err(sa, "can't match on outer rule ID: %s", strerror(rc));
+   sfc_err(sa, "can't match on outer rule ID: %s", 
rte_strerror(rc));
 
return rc;
}
@@ -485,7 +485,7 @@ sfc_mae_outer_rule_disable(struct sfc_adapter *sa,
  &invalid_rule_id);
if (rc != 0) {
sfc_err(sa, "cannot restore match on invalid outer rule ID: %s",
-   strerror(rc));
+   rte_strerror(rc));
return;
}
 
@@ -504,7 +504,7 @@ sfc_mae_outer_rule_disable(struct sfc_adapter *sa,
rule, fw_rsrc->rule_id.id);
} else {
sfc_err(sa, "failed to disable outer_rule=%p with 
OR_ID=0x%08x: %s",
-   rule, fw_rsrc->rule_id.id, strerror(rc));
+   rule, fw_rsrc->rule_id.id, rte_strerror(rc));
}
fw_rsrc->rule_id.id = EFX_MAE_RSRC_ID_INVALID;
}
@@ -618,7 +618,7 @@ sfc_mae_mac_addr_enable(struct sfc_adapter *sa,
&fw_rsrc->mac_id);
if (rc != 0) {
sfc_err(sa, "failed to enable mac_addr=%p: %s",
-   mac_addr, strerror(rc));
+   mac_addr, rte_strerror(rc));
return rc;
}
}
@@ -644,7 +644,7 @@ sfc_mae_mac_addr_enable(struct sfc_adapter *sa,
}
 
sfc_err(sa, "cannot fill in MAC address entry ID: %s",
-   strerror(rc));
+   rte_strerror(rc));
 
return rc;
}
@@ -687,7 +687,7 @@ sfc_mae_mac_addr_disable(struct sfc_adapter *sa,
mac_addr, fw_rsrc->mac_id.id);
} else {
sfc_err(sa, "failed to disable mac_addr=%p with 
MAC_ID=0x%08x: %s",
-   mac_addr, fw_rsrc->mac_id.id, strerror(rc));
+   mac_addr, fw_rsrc->mac_id.id, rte_strerror(rc));
}
fw_rsrc->mac_id.id = EFX_MAE_RSRC_ID_INVALID;
}
@@ -820,7 +820,7 @@ sfc_mae_encap_header_update(struct sfc_adapter *sa,
  bounce_eh->size);
if (ret != 0) {
sfc_err(sa, "failed to update encap_header=%p: %s",
-   encap_header, strerror(ret));
+   encap_header, rte_strerror(ret));
rte_free(buf);

[PATCH 33/43] net/mlx4: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/mlx4/mlx4.c| 14 +++---
 drivers/net/mlx4/mlx4_ethdev.c | 18 +-
 drivers/net/mlx4/mlx4_rxq.c| 10 +-
 drivers/net/mlx4/mlx4_txq.c| 10 +-
 4 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index a1a7e93288..f06a6fee6e 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -255,7 +255,7 @@ mlx4_dev_configure(struct rte_eth_dev *dev)
if (ret) {
ERROR("cannot set up internal flow rules (code %d, \"%s\"),"
  " flow error type %d, cause %p, message: %s",
- -ret, strerror(-ret), error.type, error.cause,
+ -ret, rte_strerror(-ret), error.type, error.cause,
  error.message ? error.message : "(unspecified)");
goto exit;
}
@@ -302,7 +302,7 @@ mlx4_dev_start(struct rte_eth_dev *dev)
ret = mlx4_rss_init(priv);
if (ret) {
ERROR("%p: cannot initialize RSS resources: %s",
- (void *)dev, strerror(-ret));
+ (void *)dev, rte_strerror(-ret));
goto err;
}
 #ifdef RTE_LIBRTE_MLX4_DEBUG
@@ -319,7 +319,7 @@ mlx4_dev_start(struct rte_eth_dev *dev)
ERROR("%p: cannot attach flow rules (code %d, \"%s\"),"
  " flow error type %d, cause %p, message: %s",
  (void *)dev,
- -ret, strerror(-ret), error.type, error.cause,
+ -ret, rte_strerror(-ret), error.type, error.cause,
  error.message ? error.message : "(unspecified)");
goto err;
}
@@ -793,7 +793,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct 
rte_pci_device *pci_dev)
err = mlx4_init_once();
if (err) {
ERROR("unable to init PMD global data: %s",
- strerror(rte_errno));
+ rte_strerror(rte_errno));
return -rte_errno;
}
MLX4_ASSERT(pci_drv == &mlx4_driver);
@@ -946,7 +946,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct 
rte_pci_device *pci_dev)
err = mlx4_glue->query_port(ctx, port, &port_attr);
if (err) {
err = ENODEV;
-   ERROR("port query failed: %s", strerror(err));
+   ERROR("port query failed: %s", rte_strerror(err));
goto port_error;
}
if (port_attr.link_layer != IBV_LINK_LAYER_ETHERNET) {
@@ -963,7 +963,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct 
rte_pci_device *pci_dev)
err = mlx4_fd_set_non_blocking(ctx->async_fd);
if (err) {
ERROR("cannot make asynchronous FD non-blocking: %s",
- strerror(err));
+ rte_strerror(err));
goto port_error;
}
/* Allocate protection domain. */
@@ -1024,7 +1024,7 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct 
rte_pci_device *pci_dev)
err = mlx4_get_mac(priv, &mac.addr_bytes);
if (err) {
ERROR("cannot get MAC address, is mlx4_en loaded?"
- " (error: %s)", strerror(err));
+ " (error: %s)", rte_strerror(err));
goto port_error;
}
INFO("port %u MAC address is " RTE_ETHER_ADDR_PRT_FMT,
diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethdev.c
index bb1dd33e7c..a1cd345aae 100644
--- a/drivers/net/mlx4/mlx4_ethdev.c
+++ b/drivers/net/mlx4/mlx4_ethdev.c
@@ -373,7 +373,7 @@ mlx4_rxmode_toggle(struct rte_eth_dev *dev, enum 
rxmode_toggle toggle)
 
ERROR("cannot toggle %s mode (code %d, \"%s\"),"
  " flow error type %d, cause %p, message: %s",
- mode, rte_errno, strerror(rte_errno), error.type, error.cause,
+ mode, rte_errno, rte_strerror(rte_errno), error.type, error.cause,
  error.message ? error.message : "(unspecified)");
return ret;
 }
@@ -462,7 +462,7 @@ mlx4_mac_addr_remove(struct rte_eth_dev *dev, uint32_t 
index)
ERROR("failed to synchronize flow rules after removing MAC address"
  " at index %d (code %d, \"%s\"),"
  " flow error type %d, cause %p, message: %s",
- index, rte_errno, strerror(rte_errno), error.type, error.cause,
+ index, rte_errno, rte_strerror(rte_errno), error.type, 
error.cause,
  error.message ? error.message : "(unspecified)");
 }
 
@@ -501,7 +501,7 @@ mlx4_mac_addr_a

[PATCH 22/43] net/bnxt: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/bnxt/bnxt_stats.c |   2 +-
 drivers/net/bnxt/rte_pmd_bnxt.c   |  26 +-
 drivers/net/bnxt/tf_core/tf_core.c| 240 +-
 drivers/net/bnxt/tf_core/tf_em_common.c   |  26 +-
 .../net/bnxt/tf_core/tf_em_hash_internal.c|   4 +-
 drivers/net/bnxt/tf_core/tf_em_host.c |  24 +-
 drivers/net/bnxt/tf_core/tf_em_internal.c |  14 +-
 drivers/net/bnxt/tf_core/tf_global_cfg.c  |  10 +-
 drivers/net/bnxt/tf_core/tf_identifier.c  |   8 +-
 drivers/net/bnxt/tf_core/tf_if_tbl.c  |   6 +-
 drivers/net/bnxt/tf_core/tf_msg.c | 160 ++--
 drivers/net/bnxt/tf_core/tf_rm.c  |   6 +-
 drivers/net/bnxt/tf_core/tf_session.c |  72 +++---
 drivers/net/bnxt/tf_core/tf_sram_mgr.c|  22 +-
 drivers/net/bnxt/tf_core/tf_tbl.c |  28 +-
 drivers/net/bnxt/tf_core/tf_tbl_sram.c|  48 ++--
 drivers/net/bnxt/tf_core/tf_tcam.c|  24 +-
 17 files changed, 360 insertions(+), 360 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
index 0e25207fc3..4212065b32 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -942,7 +942,7 @@ int bnxt_dev_xstats_reset_op(struct rte_eth_dev *eth_dev)
ret = bnxt_hwrm_port_clr_stats(bp);
if (ret != 0)
PMD_DRV_LOG(ERR, "Failed to reset xstats: %s\n",
-   strerror(-ret));
+   rte_strerror(-ret));
 
bnxt_clear_prev_stat(bp);
 
diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
index 964a5aeb05..558085ec0c 100644
--- a/drivers/net/bnxt/rte_pmd_bnxt.c
+++ b/drivers/net/bnxt/rte_pmd_bnxt.c
@@ -149,7 +149,7 @@ int rte_pmd_bnxt_set_vf_mac_addr(uint16_t port, uint16_t vf,
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -191,7 +191,7 @@ int rte_pmd_bnxt_set_vf_rate_limit(uint16_t port, uint16_t 
vf,
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -249,7 +249,7 @@ int rte_pmd_bnxt_set_vf_mac_anti_spoof(uint16_t port, 
uint16_t vf, uint8_t on)
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -308,7 +308,7 @@ int rte_pmd_bnxt_set_vf_vlan_anti_spoof(uint16_t port, 
uint16_t vf, uint8_t on)
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -365,7 +365,7 @@ rte_pmd_bnxt_set_vf_vlan_stripq(uint16_t port, uint16_t vf, 
uint8_t on)
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -409,7 +409,7 @@ int rte_pmd_bnxt_set_vf_rxmode(uint16_t port, uint16_t vf,
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -600,7 +600,7 @@ int rte_pmd_bnxt_get_vf_stats(uint16_t port,
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -636,7 +636,7 @@ int rte_pmd_bnxt_reset_vf_stats(uint16_t port,
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   port, strerror(-rc));
+   port, rte_strerror(-rc));
 
return rc;
}
@@ -670,7 +670,7 @@ int rte_pmd_bnxt_get_vf_rx_status(uint16_t port, uint16_t 
vf_id)
if (rc != 0) {
PMD_DRV_LOG(ERR,
"Error during getting device (port %u) info: %s\n",
-   po

[PATCH 38/43] net/vhost: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/vhost/rte_eth_vhost.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vhost/rte_eth_vhost.c 
b/drivers/net/vhost/rte_eth_vhost.c
index 21bbb008e0..75b48dc31e 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -567,7 +567,7 @@ eth_vhost_update_intr(struct rte_eth_dev *eth_dev, uint16_t 
rxq_idx)
if (vq->kickfd >= 0 && vq->kickfd != vring.kickfd) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_DEL, vq->kickfd, 
&vq->ev) < 0) {
VHOST_LOG(DEBUG, "Failed to unregister %d from rxq-%d 
epoll: %s\n",
-   vq->kickfd, rxq_idx, strerror(errno));
+   vq->kickfd, rxq_idx, rte_strerror(errno));
} else {
VHOST_LOG(DEBUG, "Unregistered %d from rxq-%d epoll\n",
vq->kickfd, rxq_idx);
@@ -579,7 +579,7 @@ eth_vhost_update_intr(struct rte_eth_dev *eth_dev, uint16_t 
rxq_idx)
if (vq->kickfd != vring.kickfd && vring.kickfd >= 0) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_ADD, vring.kickfd, 
&vq->ev) < 0) {
VHOST_LOG(ERR, "Failed to register %d in rxq-%d epoll: 
%s\n",
-   vring.kickfd, rxq_idx, strerror(errno));
+   vring.kickfd, rxq_idx, rte_strerror(errno));
} else {
vq->kickfd = vring.kickfd;
VHOST_LOG(DEBUG, "Registered %d in rxq-%d epoll\n",
@@ -730,7 +730,7 @@ eth_vhost_unconfigure_intr(struct rte_eth_dev *eth_dev)
if (vq->kickfd >= 0) {
if (epoll_ctl(vq->ev.data.fd, EPOLL_CTL_DEL, 
vq->kickfd, &vq->ev) < 0) {
VHOST_LOG(DEBUG, "Failed to unregister %d from 
rxq-%d epoll: %s\n",
-   vq->kickfd, i, strerror(errno));
+   vq->kickfd, i, rte_strerror(errno));
} else {
VHOST_LOG(DEBUG, "Unregistered %d from rxq-%d 
epoll\n",
vq->kickfd, i);
-- 
2.33.0

[PATCH 40/43] raw/ifpga: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/raw/ifpga/afu_pmd_n3000.c  |  5 +++--
 drivers/raw/ifpga/base/ifpga_fme_rsu.c | 12 +++-
 drivers/raw/ifpga/ifpga_rawdev.c   |  2 +-
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c 
b/drivers/raw/ifpga/afu_pmd_n3000.c
index 67b3941265..d7302edc3f 100644
--- a/drivers/raw/ifpga/afu_pmd_n3000.c
+++ b/drivers/raw/ifpga/afu_pmd_n3000.c
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "afu_pmd_core.h"
 #include "afu_pmd_n3000.h"
@@ -693,7 +694,7 @@ static int poll_interrupt(struct dma_afu_ctx *ctx)
pfd.events = POLLIN;
poll_ret = poll(&pfd, 1, DMA_TIMEOUT_MSEC);
if (poll_ret < 0) {
-   IFPGA_RAWDEV_PMD_ERR("Error %s", strerror(errno));
+   IFPGA_RAWDEV_PMD_ERR("Error %s", rte_strerror(errno));
ret = -EFAULT;
goto out;
} else if (poll_ret == 0) {
@@ -708,7 +709,7 @@ static int poll_interrupt(struct dma_afu_ctx *ctx)
ret = 0;
} else {
IFPGA_RAWDEV_PMD_ERR("Failed %s", bytes_read > 0 ?
-   strerror(errno) : "zero bytes read");
+   rte_strerror(errno) : "zero bytes read");
ret = -EIO;
}
}
diff --git a/drivers/raw/ifpga/base/ifpga_fme_rsu.c 
b/drivers/raw/ifpga/base/ifpga_fme_rsu.c
index f147aaa1e8..8e8a611f9a 100644
--- a/drivers/raw/ifpga/base/ifpga_fme_rsu.c
+++ b/drivers/raw/ifpga/base/ifpga_fme_rsu.c
@@ -7,6 +7,8 @@
 #include 
 #include "ifpga_sec_mgr.h"
 
+#include 
+
 static struct ifpga_sec_mgr *sec_mgr;
 
 static void set_rsu_control(struct ifpga_sec_mgr *smgr, uint32_t ctrl)
@@ -112,7 +114,7 @@ static int write_flash_image(struct ifpga_sec_mgr *smgr, 
const char *image,
if (fd < 0) {
dev_err(smgr,
"Failed to open \'%s\' for RD [e:%s]\n",
-   image, strerror(errno));
+   image, rte_strerror(errno));
return -EIO;
}
 
@@ -130,14 +132,14 @@ static int write_flash_image(struct ifpga_sec_mgr *smgr, 
const char *image,
IFPGA_RSU_DATA_BLK_SIZE : length;
if (lseek(fd, offset, SEEK_SET) < 0) {
dev_err(smgr, "Failed to seek in \'%s\' [e:%s]\n",
-   image, strerror(errno));
+   image, rte_strerror(errno));
ret = -EIO;
goto end;
}
read_size = read(fd, buf, to_transfer);
if (read_size < 0) {
dev_err(smgr, "Failed to read from \'%s\' [e:%s]\n",
-   image, strerror(errno));
+   image, rte_strerror(errno));
ret = -EIO;
goto end;
}
@@ -316,7 +318,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char 
*image,
if (fd < 0) {
dev_err(smgr,
"Failed to open \'%s\' for RD [e:%s]\n",
-   image, strerror(errno));
+   image, rte_strerror(errno));
return -EIO;
}
len = lseek(fd, 0, SEEK_END);
@@ -325,7 +327,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char 
*image,
if (len < 0) {
dev_err(smgr,
"Failed to get file length of \'%s\' [e:%s]\n",
-   image, strerror(errno));
+   image, rte_strerror(errno));
return -EIO;
}
if (len == 0) {
diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index f89bd3f9e2..56d3ec02eb 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -847,7 +847,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
if (file_fd < 0) {
IFPGA_RAWDEV_PMD_ERR("%s: open file error: %s\n",
__func__, file_name);
-   IFPGA_RAWDEV_PMD_ERR("Message : %s\n", strerror(errno));
+   IFPGA_RAWDEV_PMD_ERR("Message : %s\n", rte_strerror(errno));
return -EINVAL;
}
ret = stat(file_name, &file_stat);
-- 
2.33.0

[PATCH 34/43] net/mlx5: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/mlx5/hws/mlx5dr_matcher.c |  2 +-
 drivers/net/mlx5/linux/mlx5_ethdev_os.c   | 20 ++--
 drivers/net/mlx5/linux/mlx5_os.c  | 18 +-
 drivers/net/mlx5/linux/mlx5_socket.c  | 16 
 drivers/net/mlx5/linux/mlx5_verbs.c   |  8 
 drivers/net/mlx5/mlx5.c   |  8 
 drivers/net/mlx5/mlx5_devx.c  |  4 ++--
 drivers/net/mlx5/mlx5_mac.c   |  2 +-
 drivers/net/mlx5/mlx5_rxmode.c|  8 
 drivers/net/mlx5/mlx5_rxq.c   |  4 ++--
 drivers/net/mlx5/mlx5_rxtx.c  |  2 +-
 drivers/net/mlx5/mlx5_stats.c |  4 ++--
 drivers/net/mlx5/mlx5_testpmd.c   | 14 +++---
 drivers/net/mlx5/mlx5_trigger.c   | 12 ++--
 drivers/net/mlx5/mlx5_vlan.c  |  2 +-
 drivers/net/mlx5/windows/mlx5_ethdev_os.c |  2 +-
 drivers/net/mlx5/windows/mlx5_os.c| 12 ++--
 17 files changed, 69 insertions(+), 69 deletions(-)

diff --git a/drivers/net/mlx5/hws/mlx5dr_matcher.c 
b/drivers/net/mlx5/hws/mlx5dr_matcher.c
index 4ea161eae6..e5247c1295 100644
--- a/drivers/net/mlx5/hws/mlx5dr_matcher.c
+++ b/drivers/net/mlx5/hws/mlx5dr_matcher.c
@@ -1421,7 +1421,7 @@ mlx5dr_match_template_create(const struct rte_flow_item 
items[],
if (ret <= 0) {
DR_LOG(ERR, "Unable to process items (%s): %s",
   error.message ? error.message : "unspecified",
-  strerror(rte_errno));
+  rte_strerror(rte_errno));
goto free_template;
}
 
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c 
b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index dd5a0c546d..f2364ff44e 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -398,7 +398,7 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev,
ret = mlx5_ifreq(dev, SIOCGIFFLAGS, &ifr);
if (ret) {
DRV_LOG(WARNING, "port %u ioctl(SIOCGIFFLAGS) failed: %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
dev_link = (struct rte_eth_link) {
@@ -435,7 +435,7 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev,
DRV_LOG(WARNING,
"port %u ioctl(SIOCETHTOOL,"
" ETHTOOL_GSET) failed: %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
}
@@ -490,7 +490,7 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
ret = mlx5_ifreq(dev, SIOCGIFFLAGS, &ifr);
if (ret) {
DRV_LOG(WARNING, "port %u ioctl(SIOCGIFFLAGS) failed: %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
dev_link = (struct rte_eth_link) {
@@ -525,7 +525,7 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
DRV_LOG(DEBUG,
"port %u ioctl(SIOCETHTOOL,"
" ETHTOOL_GLINKSETTINGS) failed: %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
}
@@ -543,7 +543,7 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
DRV_LOG(DEBUG,
"port %u ioctl(SIOCETHTOOL,"
"ETHTOOL_GLINKSETTINGS) failed: %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
dev_link.link_speed = (ecmd->speed == UINT32_MAX) ?
@@ -674,7 +674,7 @@ mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
DRV_LOG(WARNING,
"port %u ioctl(SIOCETHTOOL, ETHTOOL_GPAUSEPARAM) 
failed:"
" %s",
-   dev->data->port_id, strerror(rte_errno));
+   dev->data->port_id, rte_strerror(rte_errno));
return ret;
}
fc_conf->autoneg = ethpause.autoneg;
@@ -727,7 +727,7 @@ mlx5_dev_set_flow_ctrl(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
DRV_LOG(WARNING,
"port %u ioctl(SIOCETHTOOL, ETHTOOL_SPAUSEPARAM)"
" failed:

[PATCH 37/43] net/tap: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/tap/rte_eth_tap.c | 26 +-
 drivers/net/tap/tap_flow.c| 18 +-
 drivers/net/tap/tap_netlink.c |  5 +++--
 drivers/net/tap/tap_tcmsgs.c  |  6 --
 4 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index b41fa971cb..ff290ea5bf 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -196,7 +196,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int 
persistent)
/* Set the TUN/TAP configuration and set the name if needed */
if (ioctl(fd, TUNSETIFF, (void *)&ifr) < 0) {
TAP_LOG(WARNING, "Unable to set TUNSETIFF for %s: %s",
-   ifr.ifr_name, strerror(errno));
+   ifr.ifr_name, rte_strerror(errno));
goto error;
}
 
@@ -204,7 +204,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int 
persistent)
if (persistent && ioctl(fd, TUNSETPERSIST, 1) < 0) {
TAP_LOG(WARNING,
"Unable to set persist %s: %s",
-   ifr.ifr_name, strerror(errno));
+   ifr.ifr_name, rte_strerror(errno));
goto error;
}
 
@@ -224,7 +224,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int 
persistent)
if (ioctl(fd, TUNSETQUEUE, (void *)&ifr) < 0) {
TAP_LOG(WARNING,
"Unable to detach keep-alive queue for %s: %s",
-   ifr.ifr_name, strerror(errno));
+   ifr.ifr_name, rte_strerror(errno));
goto error;
}
}
@@ -242,7 +242,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int 
persistent)
if (fcntl(fd, F_SETFL, flags) < 0) {
TAP_LOG(WARNING,
"Unable to set %s to nonblocking: %s",
-   ifr.ifr_name, strerror(errno));
+   ifr.ifr_name, rte_strerror(errno));
goto error;
}
 
@@ -295,18 +295,18 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, 
int persistent)
/* Enable signal on file descriptor */
if (fcntl(fd, F_SETSIG, signo) < 0) {
TAP_LOG(WARNING, "Unable to set signo %d for fd %d: %s",
-   signo, fd, strerror(errno));
+   signo, fd, rte_strerror(errno));
goto error;
}
if (fcntl(fd, F_SETFL, flags | O_ASYNC) < 0) {
TAP_LOG(WARNING, "Unable to set fcntl flags: %s",
-   strerror(errno));
+   rte_strerror(errno));
goto error;
}
 
if (fcntl(fd, F_SETOWN, getpid()) < 0) {
TAP_LOG(WARNING, "Unable to set fcntl owner: %s",
-   strerror(errno));
+   rte_strerror(errno));
goto error;
}
}
@@ -821,7 +821,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request,
 
 error:
TAP_LOG(DEBUG, "%s(%s) failed: %s(%d)", ifr->ifr_name,
-   tap_ioctl_req2str(request), strerror(errno), errno);
+   tap_ioctl_req2str(request), rte_strerror(errno), errno);
return -errno;
 }
 
@@ -1966,7 +1966,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const 
char *tap_name,
if (pmd->ioctl_sock == -1) {
TAP_LOG(ERR,
"%s Unable to get a socket for management: %s",
-   tuntap_name, strerror(errno));
+   tuntap_name, rte_strerror(errno));
goto error_exit;
}
 
@@ -2127,7 +2127,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const 
char *tap_name,
 
 disable_rte_flow:
TAP_LOG(ERR, " Disabling rte flow support: %s(%d)",
-   strerror(errno), errno);
+   rte_strerror(errno), errno);
if (strlen(remote_iface)) {
TAP_LOG(ERR, "Remote feature requires flow support.");
goto error_exit;
@@ -2137,7 +2137,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const 
char *tap_name,
 
 error_remote:
TAP_LOG(ERR, " Can't set up remote feature: %s(%d)",
-   strerror(errno), errno);
+   rte_strerror(errno), errno);
tap_flow_implicit_flush(pmd, NULL);
 
 error_exit:
@@ -2475,7 +2475,7 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
ret = rte_mp_action_register(TAP_MP_REQ_START_RXTX, 
tap_mp_req_start_rxtx);

[PATCH 39/43] net/virtio: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/net/virtio/virtio_user/vhost_kernel.c |  8 +++---
 .../net/virtio/virtio_user/vhost_kernel_tap.c | 25 ++-
 drivers/net/virtio/virtio_user/vhost_user.c   | 20 +++
 drivers/net/virtio/virtio_user/vhost_vdpa.c   | 12 -
 .../net/virtio/virtio_user/virtio_user_dev.c  |  8 +++---
 drivers/net/virtio/virtio_user_ethdev.c   |  6 ++---
 6 files changed, 40 insertions(+), 39 deletions(-)

diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c 
b/drivers/net/virtio/virtio_user/vhost_kernel.c
index e42bb35935..b1dec119fc 100644
--- a/drivers/net/virtio/virtio_user/vhost_kernel.c
+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c
@@ -92,7 +92,7 @@ vhost_kernel_ioctl(int fd, uint64_t request, void *arg)
ret = ioctl(fd, request, arg);
if (ret) {
PMD_DRV_LOG(ERR, "Vhost-kernel ioctl %"PRIu64" failed (%s)",
-   request, strerror(errno));
+   request, rte_strerror(errno));
return -1;
}
 
@@ -428,7 +428,7 @@ vhost_kernel_setup(struct virtio_user_dev *dev)
for (i = 0; i < dev->max_queue_pairs; ++i) {
vhostfd = open(dev->path, O_RDWR);
if (vhostfd < 0) {
-   PMD_DRV_LOG(ERR, "fail to open %s, %s", dev->path, 
strerror(errno));
+   PMD_DRV_LOG(ERR, "fail to open %s, %s", dev->path, 
rte_strerror(errno));
goto err_tapfds;
}
data->vhostfds[i] = vhostfd;
@@ -511,14 +511,14 @@ vhost_kernel_set_backend(int vhostfd, int tapfd)
f.index = 0;
if (ioctl(vhostfd, VHOST_NET_SET_BACKEND, &f) < 0) {
PMD_DRV_LOG(ERR, "VHOST_NET_SET_BACKEND fails, %s",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
f.index = 1;
if (ioctl(vhostfd, VHOST_NET_SET_BACKEND, &f) < 0) {
PMD_DRV_LOG(ERR, "VHOST_NET_SET_BACKEND fails, %s",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c 
b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
index 611e2e25ec..4542ccbf04 100644
--- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
+++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
@@ -13,6 +13,7 @@
 #include 
 
 #include 
+#include 
 
 #include "vhost_kernel_tap.h"
 #include "../virtio_logs.h"
@@ -27,12 +28,12 @@ tap_support_features(unsigned int *tap_features)
tapfd = open(PATH_NET_TUN, O_RDWR);
if (tapfd < 0) {
PMD_DRV_LOG(ERR, "fail to open %s: %s",
-   PATH_NET_TUN, strerror(errno));
+   PATH_NET_TUN, rte_strerror(errno));
return -1;
}
 
if (ioctl(tapfd, TUNGETFEATURES, tap_features) == -1) {
-   PMD_DRV_LOG(ERR, "TUNGETFEATURES failed: %s", strerror(errno));
+   PMD_DRV_LOG(ERR, "TUNGETFEATURES failed: %s", 
rte_strerror(errno));
close(tapfd);
return -1;
}
@@ -49,11 +50,11 @@ tap_open(const char *ifname, unsigned int r_flags, bool 
multi_queue)
 
tapfd = open(PATH_NET_TUN, O_RDWR);
if (tapfd < 0) {
-   PMD_DRV_LOG(ERR, "fail to open %s: %s", PATH_NET_TUN, 
strerror(errno));
+   PMD_DRV_LOG(ERR, "fail to open %s: %s", PATH_NET_TUN, 
rte_strerror(errno));
return -1;
}
if (fcntl(tapfd, F_SETFL, O_NONBLOCK) < 0) {
-   PMD_DRV_LOG(ERR, "fcntl tapfd failed: %s", strerror(errno));
+   PMD_DRV_LOG(ERR, "fcntl tapfd failed: %s", rte_strerror(errno));
close(tapfd);
return -1;
}
@@ -68,12 +69,12 @@ tap_open(const char *ifname, unsigned int r_flags, bool 
multi_queue)
if (multi_queue) {
PMD_DRV_LOG(DEBUG,
"TUNSETIFF failed (will retry without 
IFF_MULTI_QUEUE): %s",
-   strerror(errno));
+   rte_strerror(errno));
multi_queue = false;
goto retry_mono_q;
}
 
-   PMD_DRV_LOG(ERR, "TUNSETIFF failed: %s", strerror(errno));
+   PMD_DRV_LOG(ERR, "TUNSETIFF failed: %s", rte_strerror(errno));
close(tapfd);
tapfd = -1;
}
@@ -88,7 +89,7 @@ tap_get_name(int tapfd, char **name)
 
memset(&ifr, 0, sizeof(ifr));
if (ioctl(tapfd, TUNGETIFF, (void *)&ifr) == -1) {
-   PMD_DRV_LOG(ERR, "TUNGETIFF failed: %s",

[PATCH 43/43] vdpa/sfc: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/vdpa/sfc/sfc_vdpa_ops.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index 00f9a4b04c..56fb7f96d8 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -137,7 +137,7 @@ sfc_vdpa_enable_vfio_intr(struct sfc_vdpa_ops_data 
*ops_data)
if (rc) {
sfc_vdpa_err(ops_data->dev_handle,
 "error enabling MSI-X interrupts: %s",
-strerror(errno));
+rte_strerror(errno));
return -1;
}
 
@@ -165,7 +165,7 @@ sfc_vdpa_disable_vfio_intr(struct sfc_vdpa_ops_data 
*ops_data)
if (rc) {
sfc_vdpa_err(ops_data->dev_handle,
 "error disabling MSI-X interrupts: %s",
-strerror(errno));
+rte_strerror(errno));
return -1;
}
 
@@ -841,7 +841,7 @@ sfc_vdpa_get_notify_area(int vid, int qid, uint64_t 
*offset, uint64_t *size)
ret = ioctl(vfio_dev_fd, VFIO_DEVICE_GET_REGION_INFO, ®);
if (ret != 0) {
sfc_vdpa_err(dev, "could not get device region info: %s",
-strerror(errno));
+rte_strerror(errno));
return ret;
}
 
-- 
2.33.0

[PATCH 42/43] vdpa/mlx5: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c 
b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
index 607e290995..243abef588 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
@@ -44,7 +44,7 @@ mlx5_vdpa_virtq_kick_handler(void *cb_arg)
errno == EAGAIN)
continue;
DRV_LOG(ERR,  "Failed to read kickfd of virtq %d: %s.",
-   virtq->index, strerror(errno));
+   virtq->index, rte_strerror(errno));
}
break;
}
-- 
2.33.0

[PATCH 41/43] vdpa/ifc: use rte strerror

[Dengdui Huang]

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Chengwen Feng 
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 23 ---
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index f034bd59ba..34ea450d00 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "base/ifcvf.h"
 
@@ -446,7 +447,7 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool 
m_rx)
fd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
if (fd < 0) {
DRV_LOG(ERR, "can't setup eventfd: %s",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
internal->intr_fd[i] = fd;
@@ -457,7 +458,7 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool 
m_rx)
ret = ioctl(internal->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);
if (ret) {
DRV_LOG(ERR, "Error enabling MSI-X interrupts: %s",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
@@ -489,7 +490,7 @@ vdpa_disable_vfio_intr(struct ifcvf_internal *internal)
ret = ioctl(internal->vfio_dev_fd, VFIO_DEVICE_SET_IRQS, irq_set);
if (ret) {
DRV_LOG(ERR, "Error disabling MSI-X interrupts: %s",
-   strerror(errno));
+   rte_strerror(errno));
return -1;
}
 
@@ -526,7 +527,7 @@ notify_relay(void *arg)
rte_vhost_get_vhost_vring(internal->vid, qid, &vring);
ev.data.u64 = qid | (uint64_t)vring.kickfd << 32;
if (epoll_ctl(epfd, EPOLL_CTL_ADD, vring.kickfd, &ev) < 0) {
-   DRV_LOG(ERR, "epoll add error: %s", strerror(errno));
+   DRV_LOG(ERR, "epoll add error: %s", 
rte_strerror(errno));
return 1;
}
}
@@ -552,7 +553,7 @@ notify_relay(void *arg)
continue;
DRV_LOG(INFO, "Error reading "
"kickfd: %s",
-   strerror(errno));
+   rte_strerror(errno));
}
break;
} while (1);
@@ -628,7 +629,7 @@ intr_relay(void *arg)
ev.data.fd = rte_intr_fd_get(internal->pdev->intr_handle);
if (epoll_ctl(csc_epfd, EPOLL_CTL_ADD,
rte_intr_fd_get(internal->pdev->intr_handle), &ev) < 0) {
-   DRV_LOG(ERR, "epoll add error: %s", strerror(errno));
+   DRV_LOG(ERR, "epoll add error: %s", rte_strerror(errno));
goto out;
}
 
@@ -653,7 +654,7 @@ intr_relay(void *arg)
continue;
DRV_LOG(ERR, "Error reading from file 
descriptor %d: %s\n",
csc_event.data.fd,
-   strerror(errno));
+   rte_strerror(errno));
goto out;
} else if (nbytes == 0) {
DRV_LOG(ERR, "Read nothing from file descriptor 
%d\n",
@@ -947,7 +948,7 @@ vring_relay(void *arg)
rte_vhost_get_vhost_vring(vid, qid, &vring);
ev.data.u64 = qid << 1 | (uint64_t)vring.kickfd << 32;
if (epoll_ctl(epfd, EPOLL_CTL_ADD, vring.kickfd, &ev) < 0) {
-   DRV_LOG(ERR, "epoll add error: %s", strerror(errno));
+   DRV_LOG(ERR, "epoll add error: %s", 
rte_strerror(errno));
return 1;
}
}
@@ -961,7 +962,7 @@ vring_relay(void *arg)
(uint64_t)internal->intr_fd[qid] << 32;
if (epoll_ctl(epfd, EPOLL_CTL_ADD, internal->intr_fd[qid], &ev)
< 0) {
-   DRV_LOG(ERR, "epoll add error: %s", strerror(errno));
+   DRV_LOG(ERR, "epoll add error: %s", 
rte_strerror(errno));
return 1;
}
update_used_ring(internal, qid);
@@ -992,7 +993,7 @@ vring_relay(void *arg)
continue;
DRV_LOG(INFO, "Error reading "
"kickfd: %s",
-   

RE: Question about loop unrolling in rte_ring datastructure.

[Morten Brørup]

> From: Aditya Ambadipudi [mailto:aditya.ambadip...@arm.com] 
> Sent: Monday, 13 November 2023 19.15
> 
> Hello all.
> 
> My name is Aditya Ambadipudi. I am not the sharpest tool in the shed.
> 
> I was reading through the rte_ring datastructure. And I have two questions 
> about the optimizations that are being made there.
> 1. Loop unrolling:
> https://github.com/DPDK/dpdk/blob/main/lib/ring/rte_ring_elem_pvt.h#L28-L35
> Why are we unrolling these loops manually. GCC will generate SIMD 
> instructions for these loops automatically. Irrespective of wheither or not 
> we unroll the loops
> Unrolled loop: https://godbolt.org/z/n97noqYn7
> Regular loop:https://godbolt.org/z/h6G9o9773

You should make "int count" a function parameter, to make it unknown at compile 
time.
In your examples, the compiler knows that count is 100, and can optimize for 
that.

> 
> This is true of both x86 and ARM.

Much of the code in DPDK is quite old, dating back to a time when compilers 
were not good at optimizing, so the developers optimized by hand.
Some of the optimizations, such as manual loop unrolling, may not be relevant 
anymore, where modern compilers might do a better job.

I don't know if this is the case here.

Experiments and suggestions for improvements are welcome!

After building DPDK, you can test the ring library performance with this 
command:

./app/test/dpdk-test --no-huge ring_perf_autotest

> 
> 2. Normalizing to few fixed types:
> 
> It looks like we separate out enqueue/dequeue operations into 3 functions. 
> One for each element size 32, 64, 128.
> 
> Again I am not clear on why we are doing this. Both 128 & 64 are multiples of 
> 32. Why can't we just normalize everything to 32?
> 
> I feel like this is in some shape or form related to loop unrolling. But I am 
> not able to figure it out on my own.

They are optimization for some common use cases.

Please note that the "esize" parameter is known at compile time, so the 
compiler will e.g. for __rte_ring_dequeue_elems() choose 
__rte_ring_dequeue_elems_64(), __rte_ring_dequeue_elems_128() or the 32-bit 
loop at build time, and omit the alternatives.

If nothing else, they tell the compiler that "count" (number of 32 bit 
elements) is divisble by 4 (for 128 bit element size) or 2 (for 64 bit element 
size):

Some CPU architectures have 64 and/or 128 bit registers, so a copy loop using 
those registers does not need to be followed by a trailing copy of any 
remaining 32-bit memory when the element size is known to be 64 or 128 bit.

> 
> I am working on a patch that is closely related to this. And I would greatly 
> appreciate any assistance anyone can provide on this. 
> 
> Thank you,
> Aditya Ambadipudi

> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose the 
> contents to any other person, use it for any purpose, or store or copy the 
> information in any medium. Thank you. 

It does not remain confidential when you post it on a public mailing list.
Please omit this footer when posting to the DPDK mailing lists.


Med venlig hilsen / Kind regards,
-Morten Brørup

RE: [PATCH] net/mlx5: allow jump to current group

[Raslan Darawsheh]

Hi Michael,

> -Original Message-
> From: Michael Baum 
> Sent: Monday, November 13, 2023 12:44 PM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko ; Ori Kam
> ; Suanming Mou 
> Subject: [PATCH] net/mlx5: allow jump to current group
I think this is a fix 
> 
> In current implementation, jump action is allowed only if target
> group is different than the current flow group.
> 
> Change jump action validation such that it allows jump to current group.
also don't forget to add Fixes tag
You should have a Cc: sta...@dpdk.org

Kindest regards
Raslan Darawsheh

RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain

[Raslan Darawsheh]

Hi,

> -Original Message-
> From: Bing Zhao 
> Sent: Monday, November 13, 2023 2:42 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh ;
> Suanming Mou ; Ori Kam 
> Cc: dev@dpdk.org; Dariusz Sosnowski ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the LACP redirection in Rx domain
> 
> When the "lacp_by_user" is not set from the application in bond
> mode, the LACP traffic should be handled by the kernel driver by
> default.
> 
> This commit adds the missing support in the template API when
> "dv_flow_en=2". The behavior will be the same as that in the DV
> mode with "dv_flow_en=1". The LACP packets will be redirected to the
> kernel when starting the steering in the NIC Rx domain.
> 
> With this commit, the DEFAULT_MISS action usage is refactored a bit.
> In the HWS, one unique action can be created with supported bits set
> in the "flag" per port. The *ROOT_FDB and *HWS_FDB flag bits will
> only be set when the port is in switchdev mode and working as the
> E-Switch manager proxy port. The SF/VF and all other representors
> won't have the FDB flag bits when creating the DEFAULT_MISS action.
> 
> Fixes: 9fa7c1cddb85 ("net/mlx5: create control flow rules with HWS")
> Cc: dsosnow...@nvidia.com
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bing Zhao 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh

RE: [PATCH] net/mlx5: fix MPRQ stride size check

[Raslan Darawsheh]

Hi,
> -Original Message-
> From: Alexander Kozyrev 
> Sent: Thursday, October 12, 2023 7:35 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Suanming Mou ; Slava
> Ovsiienko 
> Subject: [PATCH] net/mlx5: fix MPRQ stride size check
> 
> We should only check that MPRQ stride size is bigger than the mbuf size in
> case no devarg configuration has been provided. Headroom check was
> indtroduced recently and removed this condition inadvertently.
> Restore this condition and only check if mprq_log_stride_size is not set.
> 
> Fixes: 8e7925aa77 ("net/mlx5: fix MPRQ stride size to accommodate the
> headroom")

fixed the wrong fixes line
> 
> Signed-off-by: Alexander Kozyrev 

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh

[PATCH v2 01/22] app/graph: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 5c59002a34f3 ("app/graph: add graph commands")
Fixes: 984a315a5804 ("app/graph: add parser utility")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/graph/graph.c |  5 +++--
 app/graph/utils.c | 15 +--
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/app/graph/graph.c b/app/graph/graph.c
index a65723a196da..ed9405ea4bac 100644
--- a/app/graph/graph.c
+++ b/app/graph/graph.c
@@ -103,9 +103,10 @@ parser_usecases_read(char *usecases)
 {
bool valid = false;
uint32_t i, j = 0;
+   char *sp = NULL;
char *token;
 
-   token = strtok(usecases, ",");
+   token = strtok_s(usecases, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(supported_usecases); i++) {
if (strcmp(supported_usecases[i], token) == 0) {
@@ -116,7 +117,7 @@ parser_usecases_read(char *usecases)
break;
}
}
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
}
 
return valid;
diff --git a/app/graph/utils.c b/app/graph/utils.c
index c7b6ae83cf1f..f7525f0b70af 100644
--- a/app/graph/utils.c
+++ b/app/graph/utils.c
@@ -101,13 +101,14 @@ int
 parser_ip4_read(uint32_t *value, char *p)
 {
uint8_t shift = 24;
+   char *sp = NULL;
uint32_t ip = 0;
char *token;
 
-   token = strtok(p, ".");
+   token = strtok_s(p, ".", &sp);
while (token != NULL) {
ip |= (((uint32_t)strtoul(token, NULL, 10)) << shift);
-   token = strtok(NULL, ".");
+   token = strtok_s(NULL, ".", &sp);
shift -= 8;
}
 
@@ -120,13 +121,14 @@ int
 parser_ip6_read(uint8_t *value, char *p)
 {
uint64_t val = 0;
+   char *sp = NULL;
char *token;
 
-   token = strtok(p, ":");
+   token = strtok_s(p, ":", &sp);
while (token != NULL) {
hex_string_to_uint64(&val, token);
*value = val;
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
value++;
val = 0;
}
@@ -139,13 +141,14 @@ parser_mac_read(uint64_t *value, char *p)
 {
uint64_t mac = 0, val = 0;
uint8_t shift = 40;
+   char *sp = NULL;
char *token;
 
-   token = strtok(p, ":");
+   token = strtok_s(p, ":", &sp);
while (token != NULL) {
hex_string_to_uint64(&val, token);
mac |= val << shift;
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
shift -= 8;
val = 0;
}
-- 
2.30.0

[PATCH v2 00/22] replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

This patchset replaces strtok with strtok_s in app, example, lib
and drivers. And adds check for use of strtok in checkpatches.sh.

--
v2:
1. fix commit log.
2. add check in checkpatches.sh.
3. replace strtok_r with strtok_s.
4. add Acked-by.
--

Jie Hai (22):
  app/graph: replace strtok with reentrant version
  app/bbdev: replace strtok with reentrant version
  app/compress-perf: replace strtok with reentrant version
  app/crypto-perf: replace strtok with reentrant version
  app/dma-perf: replace strtok with reentrant version
  app/test-fib: replace strtok with reentrant version
  app/flow-perf: replace strtok with reentrant version
  app/test-mldev: replace strtok with reentrant version
  dmadev: replace strtok with reentrant version
  eal: replace strtok with reentrant version
  ethdev: replace strtok with reentrant version
  eventdev: replace strtok with reentrant version
  security: replace strtok with reentrant version
  telemetry: replace strtok with reentrant version
  bus/fslmc: replace strtok with reentrant version
  common/cnxk: replace strtok with reentrant version
  event/cnxk: replace strtok with reentrant version
  net/ark: replace strtok with reentrant version
  raw/cnxk_gpio: replace strtok with reentrant version
  examples/l2fwd-crypto: replace strtok with reentrant version
  examples/vhost: replace strtok with reentrant version
  devtools: check for some reentrant function

 app/graph/graph.c |  5 ++-
 app/graph/utils.c | 15 +---
 app/test-bbdev/test_bbdev_vector.c| 25 +++-
 .../comp_perf_options_parse.c | 16 
 app/test-crypto-perf/cperf_options_parsing.c  | 16 
 .../cperf_test_vector_parsing.c   | 10 +++--
 app/test-dma-perf/main.c  | 13 ---
 app/test-fib/main.c   | 10 ++---
 app/test-flow-perf/main.c | 22 ++-
 app/test-mldev/ml_options.c   | 18 -
 devtools/checkpatches.sh  |  8 
 drivers/bus/fslmc/fslmc_bus.c |  5 ++-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
 drivers/common/cnxk/cnxk_telemetry_nix.c  | 12 +++---
 drivers/event/cnxk/cnxk_eventdev.c| 10 +++--
 drivers/event/cnxk/cnxk_tim_evdev.c   | 11 +++---
 drivers/net/ark/ark_pktchkr.c | 10 ++---
 drivers/net/ark/ark_pktgen.c  | 10 ++---
 drivers/raw/cnxk_gpio/cnxk_gpio.c |  6 +--
 examples/l2fwd-crypto/main.c  |  6 +--
 examples/vhost/main.c |  3 +-
 lib/dmadev/rte_dmadev.c   |  4 +-
 lib/eal/common/eal_common_memory.c|  8 ++--
 lib/ethdev/rte_ethdev_telemetry.c |  6 ++-
 lib/eventdev/rte_event_eth_rx_adapter.c   | 38 +--
 lib/eventdev/rte_eventdev.c   | 18 -
 lib/security/rte_security.c   |  3 +-
 lib/telemetry/telemetry.c |  5 ++-
 28 files changed, 177 insertions(+), 140 deletions(-)

-- 
2.30.0

[PATCH v2 02/22] app/bbdev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases")
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-bbdev/test_bbdev_vector.c | 25 +++--
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_vector.c 
b/app/test-bbdev/test_bbdev_vector.c
index c26727cd35c4..00a0f99801b7 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -63,8 +63,9 @@ parse_values(char *tokens, uint32_t **data, uint32_t 
*data_length)
 
uint32_t *values, *values_resized;
char *tok, *error = NULL;
+   char *sp = NULL;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_s(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -98,7 +99,7 @@ parse_values(char *tokens, uint32_t **data, uint32_t 
*data_length)
 
*data_length = *data_length + (strlen(tok) - strlen("0x"))/2;
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_s(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
 
@@ -299,8 +300,9 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,
 {
char *tok = NULL;
uint32_t op_flag_value = 0;
+   char *sp = NULL;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_s(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -330,7 +332,7 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,
 
*op_flags = *op_flags | op_flag_value;
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_s(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
}
@@ -368,9 +370,10 @@ static int
 parse_expected_status(char *tokens, int *status, enum rte_bbdev_op_type 
op_type)
 {
char *tok = NULL;
+   char *sp = NULL;
bool status_ok = false;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_s(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -401,7 +404,7 @@ parse_expected_status(char *tokens, int *status, enum 
rte_bbdev_op_type op_type)
return -1;
}
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_s(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
}
@@ -894,6 +897,7 @@ parse_fft_params(const char *key_token, char *token,
int ret = 0, status = 0, i, shift;
uint32_t op_flags = 0;
char *tok, *err = NULL;
+   char *sp = NULL;
 
struct rte_bbdev_op_fft *fft = &vector->fft;
 
@@ -922,7 +926,7 @@ parse_fft_params(const char *key_token, char *token,
fft->output_leading_depadding = (uint32_t) strtoul(token, &err, 
0);
ret = ((err == NULL) || (*err != '\0')) ? -1 : 0;
} else if (!strcmp(key_token, "window_index")) {
-   tok = strtok(token, VALUE_DELIMITER);
+   tok = strtok_s(token, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
for (i = 0; i < FFT_WIN_SIZE; i++) {
@@ -930,7 +934,7 @@ parse_fft_params(const char *key_token, char *token,
fft->window_index[i / 2] |= (uint32_t) strtoul(tok, 
&err, 0)
<< shift;
if (i < (FFT_WIN_SIZE - 1)) {
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_s(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
}
@@ -995,6 +999,7 @@ static int
 parse_entry(char *entry, struct test_bbdev_vector *vector)
 {
int ret = 0;
+   char *sp = NULL;
char *token, *key_token;
enum rte_bbdev_op_type op_type = RTE_BBDEV_OP_NONE;
 
@@ -1004,10 +1009,10 @@ parse_entry(char *entry, struct test_bbdev_vector 
*vector)
}
 
/* get key */
-   token = strtok(entry, ENTRY_DELIMITER);
+   token = strtok_s(entry, ENTRY_DELIMITER, &sp);
key_token = token;
/* get values for key */
-   token = strtok(NULL, ENTRY_DELIMITER);
+   token = strtok_s(NULL, ENTRY_DELIMITER, &sp);
 
if (key_token == NULL || token == NULL) {
printf("Expected 'key = values' but was '%.40s'..\n", entry);
-- 
2.30.0

[PATCH v2 03/22] app/compress-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: e0b6287c035d ("app/compress-perf: add parser")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-compress-perf/comp_perf_options_parse.c | 16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/test-compress-perf/comp_perf_options_parse.c 
b/app/test-compress-perf/comp_perf_options_parse.c
index 6d8c370fc2ea..a390fa36c56c 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -177,6 +177,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
 {
char *token;
uint8_t number;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -184,7 +185,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ":");
+   token = strtok_s(copy_arg, ":", &sp);
 
/* Parse minimum value */
if (token != NULL) {
@@ -197,7 +198,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
 
/* Parse increment value */
if (token != NULL) {
@@ -211,7 +212,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
 
/* Parse maximum value */
if (token != NULL) {
@@ -225,7 +226,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   if (strtok(NULL, ":") != NULL)
+   if (strtok_s(NULL, ":", &sp) != NULL)
goto err_range;
 
free(copy_arg);
@@ -244,6 +245,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
uint8_t count = 0;
uint32_t temp_min;
uint32_t temp_max;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -251,7 +253,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ",");
+   token = strtok_s(copy_arg, ",", &sp);
 
/* Parse first value */
if (token != NULL) {
@@ -266,7 +268,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
} else
goto err_list;
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
 
while (token != NULL) {
if (count == MAX_LIST) {
@@ -288,7 +290,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
if (number > temp_max)
temp_max = number;
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
}
 
if (min)
-- 
2.30.0

[PATCH v2 04/22] app/crypto-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-crypto-perf/cperf_options_parsing.c | 16 +---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 10 ++
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/app/test-crypto-perf/cperf_options_parsing.c 
b/app/test-crypto-perf/cperf_options_parsing.c
index 75afedc7fd6e..81fa4a925291 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -161,6 +161,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
 {
char *token;
uint32_t number;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -168,7 +169,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ":");
+   token = strtok_s(copy_arg, ":", &sp);
 
/* Parse minimum value */
if (token != NULL) {
@@ -182,7 +183,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
 
/* Parse increment value */
if (token != NULL) {
@@ -196,7 +197,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_s(NULL, ":", &sp);
 
/* Parse maximum value */
if (token != NULL) {
@@ -211,7 +212,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   if (strtok(NULL, ":") != NULL)
+   if (strtok_s(NULL, ":", &sp) != NULL)
goto err_range;
 
free(copy_arg);
@@ -230,6 +231,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
uint8_t count = 0;
uint32_t temp_min;
uint32_t temp_max;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -237,7 +239,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ",");
+   token = strtok_s(copy_arg, ",", &sp);
 
/* Parse first value */
if (token != NULL) {
@@ -253,7 +255,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
} else
goto err_list;
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
 
while (token != NULL) {
if (count == MAX_LIST) {
@@ -275,7 +277,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
if (number > temp_max)
temp_max = number;
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
}
 
if (min)
diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c 
b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 737d61d4af6b..3557d767b55c 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -220,8 +220,9 @@ parse_values(char *tokens, uint8_t **data, uint32_t 
*data_length)
 
uint8_t *values, *values_resized;
char *tok, *error = NULL;
+   char *sp = NULL;
 
-   tok = strtok(tokens, CPERF_VALUE_DELIMITER);
+   tok = strtok_s(tokens, CPERF_VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -252,7 +253,7 @@ parse_values(char *tokens, uint8_t **data, uint32_t 
*data_length)
return -1;
}
 
-   tok = strtok(NULL, CPERF_VALUE_DELIMITER);
+   tok = strtok_s(NULL, CPERF_VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
 
@@ -283,6 +284,7 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
 
uint8_t *data = NULL;
char *token, *key_token;
+   char *sp = NULL;
 
if (entry == NULL) {
printf("Expected entry value\n");
@@ -290,10 +292,10 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
}
 
/* get key */
-   token = strtok(entry, CPERF_ENTRY_DELIMITER);
+   token = strtok_s(entry, CPERF_ENTRY_DELIMITER, &sp);
key_token = token;
/* get values for key */
-   token = strtok(NU

[PATCH v2 06/22] app/test-fib: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-fib/main.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index 75a56135f212..95f6bd467b49 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -223,9 +223,9 @@ parse_distrib(uint8_t depth_lim, const uint32_t n)
uint32_t nrpd[128 + 1] = {0}; /* number of routes per depth */
uint32_t n_routes;
uint8_t depth, ratio, ratio_acc = 0;
-   char *in;
+   char *in, *sp = NULL;
 
-   in = strtok(distrib_string, ",");
+   in = strtok_s(distrib_string, ",", &sp);
 
/*parse configures routes percentage ratios*/
while (in != NULL) {
@@ -265,7 +265,7 @@ parse_distrib(uint8_t depth_lim, const uint32_t n)
}
 
/*number of configured depths in*/
-   in = strtok(NULL, ",");
+   in = strtok_s(NULL, ",", &sp);
}
 
if (ratio_acc > 100) {
@@ -542,10 +542,10 @@ parse_lookup(FILE *f, int af)
int ret, i = 0;
uint8_t *tbl = (uint8_t *)config.lookup_tbl;
int step = (af == AF_INET) ? 4 : 16;
-   char *s;
+   char *s, *sp = NULL;
 
while (fgets(line, sizeof(line), f) != NULL) {
-   s = strtok(line, " \t\n");
+   s = strtok_s(line, " \t\n", &sp);
if (s == NULL)
return -EINVAL;
ret = inet_pton(af, s, &tbl[i]);
-- 
2.30.0

[PATCH v2 05/22] app/dma-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-dma-perf/main.c | 13 -
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index e5bccc27da5e..e34f9f8aaa7c 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -164,6 +164,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
uint16_t len;
char *input;
struct lcore_dma_map_t *lcore_dma_map;
+   char *sp = NULL;
 
if (test_case == NULL || value == NULL)
return -1;
@@ -175,7 +176,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
 
memset(lcore_dma_map, 0, sizeof(struct lcore_dma_map_t));
 
-   char *token = strtok(input, ", ");
+   char *token = strtok_s(input, ", ", &sp);
while (token != NULL) {
if (lcore_dma_map->cnt >= MAX_LCORE_NB) {
free(input);
@@ -185,7 +186,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
uint16_t lcore_id = atoi(token);
lcore_dma_map->lcores[lcore_dma_map->cnt++] = lcore_id;
 
-   token = strtok(NULL, ", ");
+   token = strtok_s(NULL, ", ", &sp);
}
 
free(input);
@@ -201,6 +202,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
char *start, *end, *substr;
uint16_t lcore_id;
int ret = 0;
+   char *sp = NULL;
 
if (test_case == NULL || value == NULL)
return -1;
@@ -216,7 +218,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
goto out;
}
 
-   substr = strtok(addrs, ",");
+   substr = strtok_s(addrs, ",", &sp);
if (substr == NULL) {
fprintf(stderr, "No input DMA address\n");
ret = -1;
@@ -258,7 +260,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
strlcpy(lcore_dma_map->dma_names[lcore_dma_map->cnt], ptrs[1],
RTE_DEV_NAME_MAX_LEN);
lcore_dma_map->cnt++;
-   substr = strtok(NULL, ",");
+   substr = strtok_s(NULL, ",", &sp);
} while (substr != NULL);
 
 out:
@@ -486,6 +488,7 @@ main(int argc, char *argv[])
char *rst_path_ptr = NULL;
char rst_path[PATH_MAX];
int new_argc;
+   char *sp = NULL;
 
memset(args, 0, sizeof(args));
 
@@ -504,7 +507,7 @@ main(int argc, char *argv[])
}
if (rst_path_ptr == NULL) {
strlcpy(rst_path, cfg_path_ptr, PATH_MAX);
-   char *token = strtok(basename(rst_path), ".");
+   char *token = strtok_s(basename(rst_path), ".", &sp);
if (token == NULL) {
printf("Config file error.\n");
return -1;
-- 
2.30.0

[PATCH v2 07/22] app/flow-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 0c8f1f4ab90e ("app/flow-perf: support raw encap/decap actions")
Fixes: 7f37f0936a19 ("app/flow-perf: support meter policy API")
Fixes: 80a323319745 ("app/flow-perf: add destination ports parameter")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-flow-perf/main.c | 22 --
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index e224ef67983d..04ce7e38a539 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -602,6 +602,7 @@ read_meter_policy(char *prog, char *arg)
 {
char *token;
size_t i, j, k;
+   char *sp = NULL;
 
j = 0;
k = 0;
@@ -612,9 +613,9 @@ read_meter_policy(char *prog, char *arg)
token = strsep(&arg, ":\0");
}
j = 0;
-   token = strtok(actions_str[0], ",\0");
+   token = strtok_s(actions_str[0], ",\0", &sp);
while (token == NULL && j < RTE_COLORS - 1)
-   token = strtok(actions_str[++j], ",\0");
+   token = strtok_s(actions_str[++j], ",\0", &sp);
while (j < RTE_COLORS && token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); i++) {
if (!strcmp(token, flow_options[i].str)) {
@@ -628,9 +629,9 @@ read_meter_policy(char *prog, char *arg)
usage(prog);
rte_exit(EXIT_SUCCESS, "Invalid colored actions\n");
}
-   token = strtok(NULL, ",\0");
+   token = strtok_s(NULL, ",\0", &sp);
while (!token && j < RTE_COLORS - 1) {
-   token = strtok(actions_str[++j], ",\0");
+   token = strtok_s(actions_str[++j], ",\0", &sp);
k = 0;
}
}
@@ -641,6 +642,7 @@ args_parse(int argc, char **argv)
 {
uint64_t pm, seed;
uint64_t hp_conf;
+   char *sp = NULL;
char **argvopt;
uint32_t prio;
char *token;
@@ -804,7 +806,7 @@ args_parse(int argc, char **argv)
RTE_FLOW_ACTION_TYPE_RAW_ENCAP
);
 
-   token = strtok(optarg, ",");
+   token = strtok_s(optarg, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); 
i++) {
if (strcmp(flow_options[i].str, 
token) == 0) {
@@ -817,7 +819,7 @@ args_parse(int argc, char **argv)
rte_exit(EXIT_FAILURE,
"Invalid encap 
item: %s\n", token);
}
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
}
printf(" / ");
}
@@ -828,7 +830,7 @@ args_parse(int argc, char **argv)
RTE_FLOW_ACTION_TYPE_RAW_DECAP
);
 
-   token = strtok(optarg, ",");
+   token = strtok_s(optarg, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); 
i++) {
if (strcmp(flow_options[i].str, 
token) == 0) {
@@ -841,7 +843,7 @@ args_parse(int argc, char **argv)
rte_exit(EXIT_FAILURE,
"Invalid decap 
item %s\n", token);
}
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
}
printf(" / ");
}
@@ -910,10 +912,10 @@ args_parse(int argc, char **argv)
uint16_t port_idx = 0;
char *token;
 
-   token = strtok(optarg, ",");
+   token = strtok_s(optarg, ",", &sp);
while (token != NULL) {
dst_ports[port_idx++] = atoi(token);
-   token = strtok(NULL, ",

[PATCH v2 09/22] dmadev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 39b5ab60df30 ("dmadev: add telemetry")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/dmadev/rte_dmadev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index 4e5e420c82a5..e9c052304393 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -971,7 +971,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
struct rte_dma_info dma_info;
struct rte_dma_stats dma_stats;
int dev_id, ret, vchan_id;
-   char *end_param;
+   char *end_param, *sp = NULL;
const char *vchan_param;
 
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -990,7 +990,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
if (dma_info.nb_vchans == 1 && *end_param == '\0')
vchan_id = 0;
else {
-   vchan_param = strtok(end_param, ",");
+   vchan_param = strtok_s(end_param, ",", &sp);
if (!vchan_param || strlen(vchan_param) == 0 || 
!isdigit(*vchan_param))
return -EINVAL;
 
-- 
2.30.0

[PATCH v2 08/22] app/test-mldev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-mldev/ml_options.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/test-mldev/ml_options.c b/app/test-mldev/ml_options.c
index 72357c1c393d..3e93a8b7356c 100644
--- a/app/test-mldev/ml_options.c
+++ b/app/test-mldev/ml_options.c
@@ -75,12 +75,12 @@ ml_parse_models(struct ml_options *opt, const char *arg)
 {
const char *delim = ",";
char models[PATH_MAX];
-   char *token;
+   char *token, *sp = NULL;
int ret = 0;
 
strlcpy(models, arg, PATH_MAX);
 
-   token = strtok(models, delim);
+   token = strtok_s(models, delim, &sp);
while (token != NULL) {
strlcpy(opt->filelist[opt->nb_filelist].model, token, PATH_MAX);
opt->nb_filelist++;
@@ -90,7 +90,7 @@ ml_parse_models(struct ml_options *opt, const char *arg)
ret = -EINVAL;
break;
}
-   token = strtok(NULL, delim);
+   token = strtok_s(NULL, delim, &sp);
}
 
if (opt->nb_filelist == 0) {
@@ -106,7 +106,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
 {
const char *delim = ",";
char filelist[PATH_MAX];
-   char *token;
+   char *token, *sp = NULL;
 
if (opt->nb_filelist >= ML_TEST_MAX_MODELS) {
ml_err("Exceeded filelist count, max = %d\n", 
ML_TEST_MAX_MODELS);
@@ -116,7 +116,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(filelist, arg, PATH_MAX);
 
/* model */
-   token = strtok(filelist, delim);
+   token = strtok_s(filelist, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, model not specified = %s\n", arg);
return -EINVAL;
@@ -124,7 +124,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].model, token, PATH_MAX);
 
/* input */
-   token = strtok(NULL, delim);
+   token = strtok_s(NULL, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, input not specified = %s\n", arg);
return -EINVAL;
@@ -132,7 +132,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].input, token, PATH_MAX);
 
/* output */
-   token = strtok(NULL, delim);
+   token = strtok_s(NULL, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, output not specified = %s\n", arg);
return -EINVAL;
@@ -140,14 +140,14 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].output, token, PATH_MAX);
 
/* reference - optional */
-   token = strtok(NULL, delim);
+   token = strtok_s(NULL, delim, &sp);
if (token != NULL)
strlcpy(opt->filelist[opt->nb_filelist].reference, token, 
PATH_MAX);
else
memset(opt->filelist[opt->nb_filelist].reference, 0, PATH_MAX);
 
/* check for extra tokens */
-   token = strtok(NULL, delim);
+   token = strtok_s(NULL, delim, &sp);
if (token != NULL) {
ml_err("Invalid filelist. Entries > 4\n.");
return -EINVAL;
-- 
2.30.0

[PATCH v2 10/22] eal: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 2054f31a1fcd ("mem: add memseg info in telemetry")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/eal/common/eal_common_memory.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/eal/common/eal_common_memory.c 
b/lib/eal/common/eal_common_memory.c
index d9433db62345..327eb0f65289 100644
--- a/lib/eal/common/eal_common_memory.c
+++ b/lib/eal/common/eal_common_memory.c
@@ -1273,22 +1273,22 @@ parse_params(const char *params, uint32_t *vals, size_t 
n_vals)
char dlim[2] = ",";
char *params_args;
size_t count = 0;
-   char *token;
+   char *token, *sp = NULL;
 
if (vals == NULL || params == NULL || strlen(params) == 0)
return -1;
 
-   /* strtok expects char * and param is const char *. Hence on using
+   /* strtok_s expects char * and param is const char *. Hence on using
 * params as "const char *" compiler throws warning.
 */
params_args = strdup(params);
if (params_args == NULL)
return -1;
 
-   token = strtok(params_args, dlim);
+   token = strtok_s(params_args, dlim, &sp);
while (token && isdigit(*token) && count < n_vals) {
vals[count++] = strtoul(token, NULL, 10);
-   token = strtok(NULL, dlim);
+   token = strtok_s(NULL, dlim, &sp);
}
 
free(params_args);
-- 
2.30.0

[PATCH v2 11/22] ethdev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: f38f62650f7b ("ethdev: add Rx queue telemetry query")
Fixes: 9e7533aeb80a ("ethdev: add telemetry command for TM level capabilities")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/ethdev/rte_ethdev_telemetry.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/ethdev/rte_ethdev_telemetry.c 
b/lib/ethdev/rte_ethdev_telemetry.c
index b01028ce9b60..658f7e54de03 100644
--- a/lib/ethdev/rte_ethdev_telemetry.c
+++ b/lib/ethdev/rte_ethdev_telemetry.c
@@ -477,6 +477,7 @@ ethdev_parse_queue_params(const char *params, bool is_rx,
const char *qid_param;
uint16_t nb_queues;
char *end_param;
+   char *sp = NULL;
uint64_t qid;
int ret;
 
@@ -489,7 +490,7 @@ ethdev_parse_queue_params(const char *params, bool is_rx,
if (nb_queues == 1 && *end_param == '\0')
qid = 0;
else {
-   qid_param = strtok(end_param, ",");
+   qid_param = strtok_s(end_param, ",", &sp);
if (!qid_param || strlen(qid_param) == 0 || 
!isdigit(*qid_param))
return -EINVAL;
 
@@ -1221,9 +1222,10 @@ static int
 eth_dev_parse_tm_params(char *params, uint32_t *result)
 {
const char *splited_param;
+   char *sp = NULL;
uint64_t ret;
 
-   splited_param = strtok(params, ",");
+   splited_param = strtok_s(params, ",", &sp);
if (!splited_param || strlen(splited_param) == 0 || 
!isdigit(*splited_param))
return -EINVAL;
 
-- 
2.30.0

[PATCH v2 12/22] eventdev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 38 -
 lib/eventdev/rte_eventdev.c | 18 ++--
 2 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 6db03adf0463..91e535e983d3 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3651,7 +3651,7 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
uint8_t rx_adapter_id;
uint16_t rx_queue_id;
int eth_dev_id, ret = -1;
-   char *token, *l_params;
+   char *token, *l_params, *sp;
struct rte_event_eth_rx_adapter_queue_conf queue_conf;
 
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -3661,19 +3661,19 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
l_params = strdup(params);
if (l_params == NULL)
return -ENOMEM;
-   token = strtok(l_params, ",");
+   token = strtok_s(l_params, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
rx_adapter_id = strtoul(token, NULL, 10);
RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(rx_adapter_id, 
-EINVAL);
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
/* Get device ID from parameter string */
eth_dev_id = strtoul(token, NULL, 10);
RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -EINVAL);
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
/* Get Rx queue ID from parameter string */
@@ -3684,7 +3684,7 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
goto error;
}
 
-   token = strtok(NULL, "\0");
+   token = strtok_s(NULL, "\0", &sp);
if (token != NULL)
RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
 " telemetry command, ignoring");
@@ -3723,7 +3723,7 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
uint8_t rx_adapter_id;
uint16_t rx_queue_id;
int eth_dev_id, ret = -1;
-   char *token, *l_params;
+   char *token, *l_params, *sp = NULL;
struct rte_event_eth_rx_adapter_queue_stats q_stats;
 
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -3733,19 +3733,19 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
l_params = strdup(params);
if (l_params == NULL)
return -ENOMEM;
-   token = strtok(l_params, ",");
+   token = strtok_s(l_params, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
rx_adapter_id = strtoul(token, NULL, 10);
RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_GOTO_ERR_RET(rx_adapter_id, 
-EINVAL);
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
/* Get device ID from parameter string */
eth_dev_id = strtoul(token, NULL, 10);
RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -EINVAL);
 
-   token = strtok(NULL, ",");
+   token = strtok_s(NULL, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
 
/* Get Rx queue ID from parameter string */
@@ -3756,7 +3756,7 @@ handle_rxa_get_queue_stats(const char *cmd __rte_unused,
goto error;
}
 
-   token = strtok(NULL, "\0");
+   token = strtok_s(NULL, "\0", &sp);
if (token != NULL)
RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
 " telemetry command, ignoring");
@@ -3794,7 +3794,7 @@ handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
uint8_t rx_adapter_id;
uint16_t rx_queue_id;
int eth_dev_id, ret = -1;
-   char *token, *l_params;
+   char *token, *l_params, *sp = NULL;
 
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
return -1;
@@ -3803,19 +3803,19 @@ handle_rxa_queue_stats_reset(const char *cmd 
__rte_unused,
l_params = strdup(params);
if (l_params == NULL)
return -ENOMEM;
-   token = strtok(l_params, ",");
+   token = strtok_s(l_params, ",", &sp);
RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(token, -1);
rx_adapter_id 

[PATCH v2 13/22] security: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 259ca6d1617f ("security: add telemetry endpoint for capabilities")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/security/rte_security.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c
index b082a290296b..51e3a669e6ec 100644
--- a/lib/security/rte_security.c
+++ b/lib/security/rte_security.c
@@ -496,13 +496,14 @@ security_handle_cryptodev_crypto_caps(const char *cmd 
__rte_unused, const char *
int dev_id, capa_id;
int crypto_caps_n;
char *end_param;
+   char *sp = NULL;
int rc;
 
if (!params || strlen(params) == 0 || !isdigit(*params))
return -EINVAL;
 
dev_id = strtoul(params, &end_param, 0);
-   capa_param = strtok(end_param, ",");
+   capa_param = strtok_s(end_param, ",", &sp);
if (!capa_param || strlen(capa_param) == 0 || !isdigit(*capa_param))
return -EINVAL;
 
-- 
2.30.0

[PATCH v2 15/22] bus/fslmc: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 9ccb76b24c1d ("bus/fslmc: enable portal interrupt handling")
Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 drivers/bus/fslmc/fslmc_bus.c| 5 +++--
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 57bfb5111a97..2aa0e45c3d1b 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -131,6 +131,7 @@ scan_one_fslmc_device(char *dev_name)
 {
char *dup_dev_name, *t_ptr;
struct rte_dpaa2_device *dev = NULL;
+   char *sp = NULL;
int ret = -1;
 
if (!dev_name)
@@ -168,7 +169,7 @@ scan_one_fslmc_device(char *dev_name)
}
 
/* Parse the device name and ID */
-   t_ptr = strtok(dup_dev_name, ".");
+   t_ptr = strtok_s(dup_dev_name, ".", &sp);
if (!t_ptr) {
DPAA2_BUS_ERR("Invalid device found: (%s)", dup_dev_name);
ret = -EINVAL;
@@ -199,7 +200,7 @@ scan_one_fslmc_device(char *dev_name)
else
dev->dev_type = DPAA2_UNKNOWN;
 
-   t_ptr = strtok(NULL, ".");
+   t_ptr = strtok_s(NULL, ".", &sp);
if (!t_ptr) {
DPAA2_BUS_ERR("Skipping invalid device (%s)", dup_dev_name);
ret = 0;
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c 
b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
index 4aec7b2cd8ba..b788d7681866 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c
@@ -129,7 +129,7 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, 
int cpu_id)
uint32_t cpu_mask = 1;
int ret;
size_t len = 0;
-   char *temp = NULL, *token = NULL;
+   char *temp = NULL, *token = NULL, *sp = NULL;
char string[STRING_LEN], command[COMMAND_LEN];
FILE *file;
 
@@ -141,7 +141,7 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, 
int cpu_id)
}
while (getline(&temp, &len, file) != -1) {
if ((strstr(temp, string)) != NULL) {
-   token = strtok(temp, ":");
+   token = strtok_s(temp, ":", &sp);
break;
}
}
-- 
2.30.0

[PATCH v2 14/22] telemetry: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/telemetry/telemetry.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 92982842a860..ef5cc87c34d1 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -371,6 +371,7 @@ static void *
 client_handler(void *sock_id)
 {
int s = (int)(uintptr_t)sock_id;
+   char *sp = NULL;
char buffer[1024];
char info_str[1024];
snprintf(info_str, sizeof(info_str),
@@ -385,8 +386,8 @@ client_handler(void *sock_id)
int bytes = read(s, buffer, sizeof(buffer) - 1);
while (bytes > 0) {
buffer[bytes] = 0;
-   const char *cmd = strtok(buffer, ",");
-   const char *param = strtok(NULL, "\0");
+   const char *cmd = strtok_s(buffer, ",", &sp);
+   const char *param = strtok_s(NULL, "\0", &sp);
telemetry_cb fn = unknown_command;
int i;
 
-- 
2.30.0

[PATCH v2 16/22] common/cnxk: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 drivers/common/cnxk/cnxk_telemetry_nix.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/common/cnxk/cnxk_telemetry_nix.c 
b/drivers/common/cnxk/cnxk_telemetry_nix.c
index ccae5d7853af..eff1517951e9 100644
--- a/drivers/common/cnxk/cnxk_telemetry_nix.c
+++ b/drivers/common/cnxk/cnxk_telemetry_nix.c
@@ -761,7 +761,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char 
*params,
   struct plt_tel_data *d)
 {
struct nix_tel_node *node;
-   char *name, *param;
+   char *name, *param, *sp = NULL;
char buf[1024];
int rc = -1;
 
@@ -769,11 +769,11 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char 
*params,
goto exit;
 
plt_strlcpy(buf, params, PCI_PRI_STR_SIZE + 1);
-   name = strtok(buf, ",");
+   name = strtok_s(buf, ",", &sp);
if (name == NULL)
goto exit;
 
-   param = strtok(NULL, "\0");
+   param = strtok_s(NULL, "\0", &sp);
 
node = nix_tel_node_get_by_pcidev_name(name);
if (!node)
@@ -782,7 +782,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char 
*params,
plt_tel_data_start_dict(d);
 
if (strstr(cmd, "rq")) {
-   char *tok = strtok(param, ",");
+   char *tok = strtok_s(param, ",", &sp);
int rq;
 
if (!tok)
@@ -798,7 +798,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char 
*params,
rc = cnxk_tel_nix_rq(node->rqs[rq], d);
 
} else if (strstr(cmd, "cq")) {
-   char *tok = strtok(param, ",");
+   char *tok = strtok_s(param, ",", &sp);
int cq;
 
if (!tok)
@@ -814,7 +814,7 @@ cnxk_nix_tel_handle_info_x(const char *cmd, const char 
*params,
rc = cnxk_tel_nix_cq(node->cqs[cq], d);
 
} else if (strstr(cmd, "sq")) {
-   char *tok = strtok(param, ",");
+   char *tok = strtok_s(param, ",", &sp);
int sq;
 
if (!tok)
-- 
2.30.0

[PATCH v2 17/22] event/cnxk: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 drivers/event/cnxk/cnxk_eventdev.c  | 10 ++
 drivers/event/cnxk/cnxk_tim_evdev.c | 11 ++-
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/drivers/event/cnxk/cnxk_eventdev.c 
b/drivers/event/cnxk/cnxk_eventdev.c
index 0c61f4c20eec..1067c403ee02 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -478,7 +478,8 @@ parse_queue_param(char *value, void *opaque)
struct cnxk_sso_qos queue_qos = {0};
uint16_t *val = (uint16_t *)&queue_qos;
struct cnxk_sso_evdev *dev = opaque;
-   char *tok = strtok(value, "-");
+   char *sp = NULL;
+   char *tok = strtok_s(value, "-", &sp);
struct cnxk_sso_qos *old_ptr;
 
if (!strlen(value))
@@ -486,7 +487,7 @@ parse_queue_param(char *value, void *opaque)
 
while (tok != NULL) {
*val = atoi(tok);
-   tok = strtok(NULL, "-");
+   tok = strtok_s(NULL, "-", &sp);
val++;
}
 
@@ -514,7 +515,8 @@ parse_stash_param(char *value, void *opaque)
struct cnxk_sso_stash queue_stash = {0};
struct cnxk_sso_evdev *dev = opaque;
struct cnxk_sso_stash *old_ptr;
-   char *tok = strtok(value, "|");
+   char *sp = NULL;
+   char *tok = strtok_s(value, "|", &sp);
uint16_t *val;
 
if (!strlen(value))
@@ -523,7 +525,7 @@ parse_stash_param(char *value, void *opaque)
val = (uint16_t *)&queue_stash;
while (tok != NULL) {
*val = atoi(tok);
-   tok = strtok(NULL, "|");
+   tok = strtok_s(NULL, "|", &sp);
val++;
}
 
diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c 
b/drivers/event/cnxk/cnxk_tim_evdev.c
index 6d59fdf90983..82975ec8c6e7 100644
--- a/drivers/event/cnxk/cnxk_tim_evdev.c
+++ b/drivers/event/cnxk/cnxk_tim_evdev.c
@@ -420,7 +420,8 @@ cnxk_tim_parse_ring_param(char *value, void *opaque)
 {
struct cnxk_tim_evdev *dev = opaque;
struct cnxk_tim_ctl ring_ctl = {0};
-   char *tok = strtok(value, "-");
+   char *sp = NULL;
+   char *tok = strtok_s(value, "-", &sp);
struct cnxk_tim_ctl *old_ptr;
uint16_t *val;
 
@@ -431,7 +432,7 @@ cnxk_tim_parse_ring_param(char *value, void *opaque)
 
while (tok != NULL) {
*val = atoi(tok);
-   tok = strtok(NULL, "-");
+   tok = strtok_s(NULL, "-", &sp);
val++;
}
 
@@ -507,16 +508,16 @@ cnxk_tim_parse_clk_list(const char *value, void *opaque)
  ROC_TIM_CLK_SRC_INVALID};
struct cnxk_tim_evdev *dev = opaque;
char *str = strdup(value);
-   char *tok;
+   char *tok, *sp = NULL;
int i = 0;
 
if (str == NULL || !strlen(str))
goto free;
 
-   tok = strtok(str, "-");
+   tok = strtok_s(str, "-", &sp);
while (tok != NULL && src[i] != ROC_TIM_CLK_SRC_INVALID) {
dev->ext_clk_freq[src[i]] = strtoull(tok, NULL, 10);
-   tok = strtok(NULL, "-");
+   tok = strtok_s(NULL, "-", &sp);
i++;
}
 
-- 
2.30.0

[PATCH v2 18/22] net/ark: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 9c7188a68d7b ("net/ark: provide API for hardware modules pktchkr and 
pktgen")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 drivers/net/ark/ark_pktchkr.c | 10 +-
 drivers/net/ark/ark_pktgen.c  | 10 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pktchkr.c
index e1f336c73c2a..c1c1033eb75e 100644
--- a/drivers/net/ark/ark_pktchkr.c
+++ b/drivers/net/ark/ark_pktchkr.c
@@ -359,14 +359,14 @@ set_arg(char *arg, char *val)
 void
 ark_pktchkr_parse(char *args)
 {
-   char *argv, *v;
+   char *argv, *v, *sp = NULL;
const char toks[] = "=\n\t\v\f \r";
-   argv = strtok(args, toks);
-   v = strtok(NULL, toks);
+   argv = strtok_s(args, toks, &sp);
+   v = strtok_s(NULL, toks, &sp);
while (argv && v) {
set_arg(argv, v);
-   argv = strtok(NULL, toks);
-   v = strtok(NULL, toks);
+   argv = strtok_s(NULL, toks, &sp);
+   v = strtok_s(NULL, toks, &sp);
}
 }
 
diff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c
index 69ff7072b2ab..4b564099d2d6 100644
--- a/drivers/net/ark/ark_pktgen.c
+++ b/drivers/net/ark/ark_pktgen.c
@@ -340,14 +340,14 @@ pmd_set_arg(char *arg, char *val)
 void
 ark_pktgen_parse(char *args)
 {
-   char *argv, *v;
+   char *argv, *v, *sp = NULL;
const char toks[] = " =\n\t\v\f \r";
-   argv = strtok(args, toks);
-   v = strtok(NULL, toks);
+   argv = strtok_s(args, toks, &sp);
+   v = strtok_s(NULL, toks, &sp);
while (argv && v) {
pmd_set_arg(argv, v);
-   argv = strtok(NULL, toks);
-   v = strtok(NULL, toks);
+   argv = strtok_s(NULL, toks, &sp);
+   v = strtok_s(NULL, toks, &sp);
}
 }
 
-- 
2.30.0

[PATCH v2 19/22] raw/cnxk_gpio: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: ecc0dd455e9a ("raw/cnxk_gpio: add option to select subset of GPIOs")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 29c250672646..0e6ee31d35c9 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -190,7 +190,7 @@ static int
 cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, char *allowlist)
 {
int i, ret, val, queue = 0;
-   char *token;
+   char *token, *sp = NULL;
int *list;
 
list = rte_calloc(NULL, gpiochip->num_gpios, sizeof(*list), 0);
@@ -208,7 +208,7 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, 
char *allowlist)
allowlist[strlen(allowlist) - 1] = ' ';
 
/* quiesce -Wcast-qual */
-   token = strtok((char *)(uintptr_t)allowlist, ",");
+   token = strtok_s((char *)(uintptr_t)allowlist, ",", &sp);
do {
errno = 0;
val = strtol(token, NULL, 10);
@@ -234,7 +234,7 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip, 
char *allowlist)
}
if (i == queue)
list[queue++] = val;
-   } while ((token = strtok(NULL, ",")));
+   } while ((token = strtok_s(NULL, ",", &sp)));
 
free(allowlist);
gpiochip->allowlist = list;
-- 
2.30.0

[PATCH v2 21/22] examples/vhost: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 examples/vhost/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index ce5c1efddf5c..3949d83be212 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -246,6 +246,7 @@ open_dma(const char *value)
char *ptrs[2];
char *start, *end, *substr;
int64_t socketid, vring_id;
+   char *sp = NULL;
 
struct rte_dma_info info;
struct rte_dma_conf dev_config = { .nb_vchans = 1 };
@@ -269,7 +270,7 @@ open_dma(const char *value)
 
/* process DMA devices within bracket. */
addrs++;
-   substr = strtok(addrs, ";]");
+   substr = strtok_s(addrs, ";]", &sp);
if (!substr) {
ret = -1;
goto out;
-- 
2.30.0

[PATCH v2 20/22] examples/l2fwd-crypto: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: ff5d5b01f8f2 ("examples/l2fwd-crypto: support AES-CCM")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 examples/l2fwd-crypto/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index efe7eea2a768..7327ff1128df 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -1105,12 +1105,12 @@ static int
 parse_bytes(uint8_t *data, char *input_arg, uint16_t max_size)
 {
unsigned byte_count;
-   char *token;
+   char *token, *sp = NULL;
 
errno = 0;
-   for (byte_count = 0, token = strtok(input_arg, ":");
+   for (byte_count = 0, token = strtok_s(input_arg, ":", &sp);
(byte_count < max_size) && (token != NULL);
-   token = strtok(NULL, ":")) {
+   token = strtok_s(NULL, ":", &sp)) {
 
int number = (int)strtol(token, NULL, 16);
 
-- 
2.30.0

[PATCH v2 22/22] devtools: check for some reentrant function

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

This patch adds check in checkpatches.sh for strtok, which is
non-reentrant.

Signed-off-by: Jie Hai 
---
 devtools/checkpatches.sh | 8 
 1 file changed, 8 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 066449d147e8..0a936219c069 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -119,6 +119,14 @@ check_forbidden_additions() { # 
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
 
+   # refrain from using some non-reentrant functions
+   awk -v FOLDERS="lib drivers app examples" \
+   -v EXPRESSIONS="strtok\\\(" \
+   -v RET_ON_FAIL=1 \
+   -v MESSAGE='Using non-reentrant function strtok, prefer 
strtok_s' \
+   -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+   "$1" || res=1
+
# refrain from using some pthread functions
awk -v FOLDERS="lib drivers app examples" \
-v 
EXPRESSIONS="pthread_(create|join|detach|set(_?name_np|affinity_np)|attr_set(inheritsched|schedpolicy))\\\("
 \
-- 
2.30.0

l3fwd build errors in debug DPDK build with RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG

[Kundapura, Ganapati]

Hi DPDK,
   When DPDK is built in debug mode by setting RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG, 
l3fwd build fails due to
static inline functions dump_acl4_rule(), dump_acl6_rule() defined in 
l3fwd_acl.c are called from l3fwd_acl_scalar.h:l3fwd_acl_send_packets() and
other typo errors as below.
Can I post a patch to fix the below l3fwd build errors?

../../examples/l3fwd/l3fwd_acl_scalar.h: In function 'l3fwd_acl_send_packets':
../../examples/l3fwd/l3fwd_acl_scalar.h:96:34: error: invalid operands to 
binary & (have 'uint32_t *' {aka 'unsigned int *'} and 'unsigned int')
   96 | if ((res & ACL_DENY_SIGNATURE) != 0) {
  |  ^

../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: implicit declaration of 
function 'dump_acl4_rule' [-Wimplicit-function-declaration]
   98 | dump_acl4_rule(pkts[i], res[i]);
  | ^~
../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: nested extern 
declaration of 'dump_acl4_rule' [-Wnested-externs]

../../examples/l3fwd/l3fwd_acl_scalar.h:99:62: error: 'pkt' undeclared (first 
use in this function); did you mean 'pkts'?
   99 | else if 
(RTE_ETH_IS_IPV6_HDR(pkt[i]->packet_type))
  |  ^~~

In file included from ../../examples/l3fwd/l3fwd_acl.c:268:
../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: implicit declaration 
of function 'dump_acl6_rule' [-Wimplicit-function-declaration]
  100 | dump_acl6_rule(pkt[i], res[i]);
  | ^~
../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: nested extern 
declaration of 'dump_acl6_rule' [-Wnested-externs]
../../examples/l3fwd/l3fwd_acl.c: At top level:
../../examples/l3fwd/l3fwd_acl.c:870:1: warning: conflicting types for 
'dump_acl4_rule'; have 'void(struct rte_mbuf *, uint32_t)' {aka 'void(struct 
rte_mbuf *, unsigned int)'}
  870 | dump_acl4_rule(struct rte_mbuf *m, uint32_t sig)
  | ^~
../../examples/l3fwd/l3fwd_acl.c:870:1: error: static declaration of 
'dump_acl4_rule' follows non-static declaration
In file included from ../../examples/l3fwd/l3fwd_acl.c:268:
../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: note: previous implicit 
declaration of 'dump_acl4_rule' with type 'void(struct rte_mbuf *, uint32_t)' 
{aka 'void(struct rte_mbuf *, unsigned int)'}
   98 | dump_acl4_rule(pkts[i], res[i]);
  | ^~

../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl4_rule':
../../examples/l3fwd/l3fwd_acl.c:878:61: warning: passing argument 2 of 
'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]
  878 | printf("Packet Src:%s ", inet_ntop(AF_INET, ipv4_hdr->src_addr,
  | ^~
  | |
  | rte_be32_t 
{aka unsigned int}
In file included from ../../lib/net/rte_ip.h:26,
 from ../../lib/ethdev/rte_flow.h:24,
 from ../../lib/ethdev/rte_eth_ctrl.h:11,
 from ../../lib/ethdev/rte_ethdev.h:1492,
 from ../../examples/l3fwd/l3fwd.h:8,
 from ../../examples/l3fwd/l3fwd_acl.c:5:
/tools/AGRreleases/yocto/snr/snr_h_60c911d4/5.10/tools/sysroots/snr-64-intelaxxia-linux/usr/include/arpa/inet.h:64:64:
 note: expected 'const void * restrict' but argument is of type 'rte_be32_t' 
{aka 'unsigned int'}
   64 | extern const char *inet_ntop (int __af, const void *__restrict __cp,
  | ~~~^~~~
../../examples/l3fwd/l3fwd_acl.c:880:54: warning: passing argument 2 of 
'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]
  880 | printf("Dst:%s ", inet_ntop(AF_INET, ipv4_hdr->dst_addr,
  |  ^~
  |  |
  |  rte_be32_t {aka 
unsigned int}


../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl6_rule':
../../examples/l3fwd/l3fwd_acl.c:914:39: error: 'struct ' has no 
member named 'rule_ipv6'
  914 | print_one_ipv6_rule(acl_config.rule_ipv6 + offset, 1);
  |   ^
../../examples/l3fwd/l3fwd_acl.c: In function 'setup_acl':
../../examples/l3fwd/l3fwd_acl.c:985:19: error: 'struct ' has no 
member named 'rule_ipv4'
  985 | acl_config.rule_ipv4 = (struct acl4_rule *)acl_base_ipv4;
  |   ^
../../examples/l3fwd/l3fwd_acl.c:986:19: error: 'struct ' has no 
member named 'rule_ipv6'
  986 | a

[Bug 1317] Fashionhikes

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1317

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 CC||tho...@monjalon.net
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Thomas Monjalon (tho...@monjalon.net) ---
SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1318] l3fwd build errors in debug DPDK build with RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1318

Bug ID: 1318
   Summary: l3fwd build errors in debug DPDK build with
RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG
   Product: DPDK
   Version: 23.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: examples
  Assignee: dev@dpdk.org
  Reporter: ganapati.kundap...@intel.com
  Target Milestone: ---

When DPDK is built in debug mode by setting RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG,
l3fwd build fails due to
static inline functions dump_acl4_rule(), dump_acl6_rule() defined in
l3fwd_acl.c are called from l3fwd_acl_scalar.h:l3fwd_acl_send_packets() and 
other typo errors as below.

../../examples/l3fwd/l3fwd_acl_scalar.h: In function 'l3fwd_acl_send_packets':
../../examples/l3fwd/l3fwd_acl_scalar.h:96:34: error: invalid operands to
binary & (have 'uint32_t *' {aka 'unsigned int *'} and 'unsigned int')
   96 | if ((res & ACL_DENY_SIGNATURE) != 0) {  
  |  ^

../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: implicit declaration of
function 'dump_acl4_rule' [-Wimplicit-function-declaration]
   98 | dump_acl4_rule(pkts[i],
res[i]);
  | ^~
../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: nested extern
declaration of 'dump_acl4_rule' [-Wnested-externs]

../../examples/l3fwd/l3fwd_acl_scalar.h:99:62: error: 'pkt' undeclared (first
use in this function); did you mean 'pkts'?
   99 | else if
(RTE_ETH_IS_IPV6_HDR(pkt[i]->packet_type))
  |  ^~~

In file included from ../../examples/l3fwd/l3fwd_acl.c:268:
../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: implicit declaration
of function 'dump_acl6_rule' [-Wimplicit-function-declaration]
  100 | dump_acl6_rule(pkt[i], res[i]);
  | ^~
../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: nested extern
declaration of 'dump_acl6_rule' [-Wnested-externs]
../../examples/l3fwd/l3fwd_acl.c: At top level:
../../examples/l3fwd/l3fwd_acl.c:870:1: warning: conflicting types for
'dump_acl4_rule'; have 'void(struct rte_mbuf *, uint32_t)' {aka 'void(struct
rte_mbuf *, unsigned int)'}
  870 | dump_acl4_rule(struct rte_mbuf *m, uint32_t sig)
  | ^~
../../examples/l3fwd/l3fwd_acl.c:870:1: error: static declaration of
'dump_acl4_rule' follows non-static declaration
In file included from ../../examples/l3fwd/l3fwd_acl.c:268:
../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: note: previous implicit
declaration of 'dump_acl4_rule' with type 'void(struct rte_mbuf *, uint32_t)'
{aka 'void(struct rte_mbuf *, unsigned int)'}
   98 | dump_acl4_rule(pkts[i],
res[i]);
  | ^~

../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl4_rule':
../../examples/l3fwd/l3fwd_acl.c:878:61: warning: passing argument 2 of
'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]
  878 | printf("Packet Src:%s ", inet_ntop(AF_INET, ipv4_hdr->src_addr,
  | ^~
  | |
  | rte_be32_t
{aka unsigned int}
In file included from ../../lib/net/rte_ip.h:26,
 from ../../lib/ethdev/rte_flow.h:24,
 from ../../lib/ethdev/rte_eth_ctrl.h:11,
 from ../../lib/ethdev/rte_ethdev.h:1492,
 from ../../examples/l3fwd/l3fwd.h:8,
 from ../../examples/l3fwd/l3fwd_acl.c:5:
/tools/AGRreleases/yocto/snr/snr_h_60c911d4/5.10/tools/sysroots/snr-64-intelaxxia-linux/usr/include/arpa/inet.h:64:64:
note: expected 'const void * restrict' but argument is of type 'rte_be32_t'
{aka 'unsigned int'}
   64 | extern const char *inet_ntop (int __af, const void *__restrict __cp,
  | ~~~^~~~
../../examples/l3fwd/l3fwd_acl.c:880:54: warning: passing argument 2 of
'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]
  880 | printf("Dst:%s ", inet_ntop(AF_INET, ipv4_hdr->dst_addr,
  |  ^~
  |  |
  |  rte_be32_t {aka
unsigned int}


../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl6_rule':
../../examples/l3fwd/l3fwd_acl.c:914:39: error: 'struct ' has no
member named 'rule_ipv6'
  914 | print_one_ipv6_rule(acl_config.rule_ipv6 + o

[Bug 1319] Einsteinhorsemag

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1319

Bug ID: 1319
   Summary: Einsteinhorsemag
   Product: DPDK
   Version: 23.03
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: doc
  Assignee: dev@dpdk.org
  Reporter: einsteinhorse...@gmail.com
  Target Milestone: ---

How Much Does Invisalign Cost
The cost of Invisalign, a popular teeth-straightening treatment, varies based
on the complexity of your case, your location, and the dental provider. It can
range from a few thousand to several thousand dollars. Consult with an
orthodontist for a personalized estimate.

Read More - https://einsteinhorsemag.com/how-much-does-invisalign-cost/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1319] Einsteinhorsemag

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1319

Thomas Monjalon (tho...@monjalon.net) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||tho...@monjalon.net
 Resolution|--- |INVALID

--- Comment #1 from Thomas Monjalon (tho...@monjalon.net) ---
SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1320] ContourCafe

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1320

Bug ID: 1320
   Summary: ContourCafe
   Product: DPDK
   Version: 23.07
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: cryptodev
  Assignee: dev@dpdk.org
  Reporter: countourcafe7...@gmail.com
  Target Milestone: ---

Chris Hemsworth Net Worth
As of my last knowledge update in September 2021, Chris Hemsworth, known for
his role as Thor in the Marvel Cinematic Universe, had an estimated net worth
of over $130 million. His earnings come from acting, endorsements, and business
ventures.

Read More - https://www.contourcafe.com/2020/05/21/chris-hemsworth-net-worth/

-- 
You are receiving this mail because:
You are the assignee for the bug.

RE: release candidate 23.11-rc2

[Xu, HailinX]

From: Xu, HailinX
Sent: Thursday, November 9, 2023 4:34 PM
To: 'Thomas Monjalon' ; dev@dpdk.org
Cc: Kovacevic, Marko ; Mcnamara, John 
; Richardson, Bruce ; 
Ferruh Yigit 
Subject: RE: release candidate 23.11-rc2


> -Original Message-

> From: Thomas Monjalon mailto:tho...@monjalon.net>>

> Sent: Tuesday, November 7, 2023 6:22 AM

> To: annou...@dpdk.org

> Subject: release candidate 23.11-rc2

>

> A new DPDK release candidate is ready for testing:

>https://git.dpdk.org/dpdk/tag/?id=v23.11-rc2

>

> There are 320 new patches in this snapshot.

>

> Release notes:

>https://doc.dpdk.org/guides/rel_notes/release_23_11.html

>

> Highlights of 23.11-rc2:

>- RSS algorithm management

>- maximum Rx buffer size

>- nfp vDPA driver

>- graph application

>

> There were a lot of updates in drivers.

> The driver features should be frozen now.

>

> Please test and report issues on bugs.dpdk.org.

>

> DPDK 23.11-rc3 is expected in approximately one week.

>

> Thank you everyone

>

Update the test status for Intel part. Till now dpdk23.11-rc2 test execution 
rate is 60%. found five new issues.



New issues:

1. ice dcf get vf resource failed when launch testpmd. -> Intel dev is under 
investigating

2. multiprocess_iavf/test_multiprocess_symmetric_mp_packet: Failed to start two 
processes. -> Intel dev is under investigating

3. https://bugs.dpdk.org/show_bug.cgi?id=1308 meson_tests/driver: 
link_bonding_rssconf_autotest test failed. -> not fix yet

4. DPDK 23.11-RC2 TSO Tests failing. -> Intel dev is under investigating

5. mev_cpfl_rte_flow/test_mac_ipv4_udp_encap_vxlan_io_to_vf: received incorrect 
packet. -> has fix patch



# Basic Intel(R) NIC testing

* Build or compile:

 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.3, Fedora38, 
RHEL8.7/9.2, Centos7.9, OpenAnolis8.8, CBL-Mariner2.0 etc.

  - All test passed.

*Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.2 
and RHEL9.0.

  - All test passed with latest dpdk.



* PF/VF(i40e, ixgbe, igc): test scenarios including 
PF/VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.

  - Execution rate is 90%. found 3 issues.

* PF/VF(ice): test scenarios including Switch features/Package Management/Flow 
Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.

  - Execution rate is 70%. found 1&2&3 issues.

* MEV test: test scenarios including PF/TSO/MTU/Jumboframe/checksum offload, etc

  - Execution rate is 90%. found 5 issue.

* Intel NIC single core/NIC performance: test scenarios including PF/VF single 
core performance test, RFC2544 Zero packet loss performance test, etc.

  - Execution rate is 70%. No new issue is found.

* Power and IPsec:

 * Power: test scenarios including bi-direction/Telemetry/Empty Poll 
Lib/Priority Base Frequency, etc.

  - Execution rate is 60%. No new issue is found.

* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - 
QAT&SW/FIB library, etc.

  - Execution rate is 50%. found 4 issue.

# Basic cryptodev and virtio testing

* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 8.0, etc.

  - Execution rate is 70%. No new issue is found.

* Cryptodev:

 *Function test: test scenarios including Cryptodev API testing/CompressDev 
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.

  - on going. No new issue is found.

 *Performance test: test scenarios including Throughput Performance /Cryptodev 
Latency, etc.

  - on going. No new issue is found.





Regards,

Xu, Hailin



Update the test status for Intel part. dpdk23.11-rc2 all test execution is 
done. found nine new issues.



New issues:

1. [mev] mev_cpfl_rte_flow/exclusive_rule: rule can be created repeatedly -> 
Intel dev is under investigating

2. CVL: vf failed to start testpmd with 256 queue -> Intel dev is under 
investigating

3. vf_pf_reset/test_pf_reset_trigger_vf_reset: Failed to manually reset vf -> 
Intel dev is under investigating

4. https://bugs.dpdk.org/show_bug.cgi?id=1311 Launch dpdk-l3fwd-power core 
dumped on SPR -> not fix yet

5. ice dcf get vf resource failed when launch testpmd. -> Intel dev is under 
investigating

6. multiprocess_iavf/test_multiprocess_symmetric_mp_packet: Failed to start two 
processes. -> has fix patch

7. https://bugs.dpdk.org/show_bug.cgi?id=1308 
meson_tests/driver：link_bonding_rssconf_autotest test failed. -> has fix patch

8. DPDK 23.11-RC2 TSO Tests failing. -> Intel dev is under investigating

9. mev_cpfl_rte_flow/test_mac_ipv4_udp_encap_vxlan_io_to_vf: received incorrect 
packet. -> has fix patch



# Basic Intel(R) NIC testing

* Build or compile:

 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu20.04.5, 

[Bug 1321] Tattoomagz

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1321

Bug ID: 1321
   Summary: Tattoomagz
   Product: DPDK
   Version: 23.03
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: doc
  Assignee: dev@dpdk.org
  Reporter: tattooma...@gmail.com
  Target Milestone: ---

Treatments for Heat Rash
Heat rash, often caused by sweat trapped in sweat ducts, can be relieved with
cooling measures. Stay in a cool environment, wear breathable clothing, and use
topical treatments like calamine lotion to alleviate discomfort.

Read More - https://tattoomagz.com/treatments-for-heat-rash/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 1322] Sharetok

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1322

Bug ID: 1322
   Summary: Sharetok
   Product: DPDK
   Version: 22.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: doc
  Assignee: dev@dpdk.org
  Reporter: sre79...@gmail.com
  Target Milestone: ---

How to Eat Chia Seeds
Chia seeds are a versatile and nutritious addition to your diet. They can be
soaked in liquid to create a gel-like texture or added to smoothies, yogurt, or
oatmeal. Chia seeds are rich in fiber, omega-3 fatty acids, and other essential
nutrients.

Read More - https://www.sharetok.com/how-to-eat-chia-seeds/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[PATCH] vfio: add get device info API

[Mingjin Ye]

This patch adds an API to support getting device information.

The driver can use the "rte_vfio_get_device_info" helper to get
device information from EAL.

Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
 lib/eal/include/rte_vfio.h | 26 ++
 lib/eal/linux/eal_vfio.c   | 19 +++
 lib/eal/version.map|  3 +++
 3 files changed, 48 insertions(+)

diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
index 3487c4f2a2..b3f55963e3 100644
--- a/lib/eal/include/rte_vfio.h
+++ b/lib/eal/include/rte_vfio.h
@@ -212,6 +212,32 @@ int
 rte_vfio_get_group_num(const char *sysfs_base,
  const char *dev_addr, int *iommu_group_num);
 
+/**
+ * Get device information
+ *
+ * This function is only relevant to linux and will return
+ * an error on BSD.
+ *
+ * @param sysfs_base
+ *   sysfs path prefix.
+ *
+ * @param dev_addr
+ *   device location.
+ *
+ * @param vfio_dev_fd
+ *   VFIO fd.
+ *
+ * @param device_info
+ *   Device information.
+ *
+ * @return
+ *   0 on success.
+ *   <0 on failure.
+ */
+int
+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info);
+
 /**
  * Open a new VFIO container fd
  *
diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
index ad3c1654b2..5810d9fcd7 100644
--- a/lib/eal/linux/eal_vfio.c
+++ b/lib/eal/linux/eal_vfio.c
@@ -1222,6 +1222,25 @@ vfio_set_iommu_type(int vfio_container_fd)
return NULL;
 }
 
+int
+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info)
+{
+   if (!device_info || *vfio_dev_fd < 0)
+   return -1;
+
+   if (*vfio_dev_fd == 0) {
+   if (rte_vfio_setup_device(sysfs_base, dev_addr,
+   vfio_dev_fd, device_info))
+   return -1;
+   } else {
+   if (ioctl(*vfio_dev_fd, VFIO_DEVICE_GET_INFO, &device_info))
+   return -1;
+   }
+
+   return 0;
+}
+
 int
 vfio_has_supported_extensions(int vfio_container_fd)
 {
diff --git a/lib/eal/version.map b/lib/eal/version.map
index e00a844805..8a211aaefd 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -413,6 +413,9 @@ EXPERIMENTAL {
# added in 23.07
rte_memzone_max_get;
rte_memzone_max_set;
+
+   # added in 23.11
+   rte_vfio_get_device_info; # WINDOWS_NO_EXPORT
 };
 
 INTERNAL {
-- 
2.25.1

[PATCH v6] bus/pci: fix legacy device IO port map

[Mingjin Ye]

When doing IO port mapping for legacy device in secondary process, the
region information is missing, so, we need to refill it.

Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value")
Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
v6:
 - split patch
v5:
 - adding checks to vfio setup
v4:
 - adjusting commit log
v3:
 - adjusting variable settings
v2:
 - add release of device in pci_vfio_ioport_unmap
---
 drivers/bus/pci/linux/pci_vfio.c | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index 3f3201daf2..a18161c27b 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -1230,6 +1230,32 @@ pci_vfio_ioport_map(struct rte_pci_device *dev, int bar,
return -1;
}
 
+   if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
+   struct vfio_device_info device_info = { .argsz = 
sizeof(device_info) };
+   char pci_addr[PATH_MAX];
+   int vfio_dev_fd;
+   struct rte_pci_addr *loc = &dev->addr;
+
+   /* store PCI address string */
+   snprintf(pci_addr, sizeof(pci_addr), PCI_PRI_FMT,
+   loc->domain, loc->bus, loc->devid, 
loc->function);
+
+   vfio_dev_fd = rte_intr_dev_fd_get(dev->intr_handle);
+   if (vfio_dev_fd < 0) {
+   return -1;
+   } else if (vfio_dev_fd == 0) {
+   if (rte_vfio_get_device_info(rte_pci_get_sysfs_path(), 
pci_addr,
+   &vfio_dev_fd, &device_info) != 0)
+   return -1;
+   /* we need save vfio_dev_fd, so it can be used during 
release */
+   if (rte_intr_dev_fd_set(dev->intr_handle, vfio_dev_fd))
+   return -1;
+
+   if (pci_vfio_fill_regions(dev, vfio_dev_fd, 
&device_info) != 0)
+   return -1;
+   }
+   }
+
if (pci_vfio_get_region(dev, bar, &size, &offset) != 0) {
RTE_LOG(ERR, EAL, "Cannot get offset of region %d.\n", bar);
return -1;
-- 
2.25.1

[PATCH v7] app/test: secondary process passes allow parameters

[Mingjin Ye]

In EAL related test cases, the allow parameters are not passed to
the secondary process, resulting in unexpected NICs being loaded.

This patch fixes this issue by appending the allow parameters to
the secondary process.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
v5: Optimized.
---
v6: Optimized.
---
v7: Fix CI errors.
---
 app/test/process.h | 46 ++
 1 file changed, 42 insertions(+), 4 deletions(-)

diff --git a/app/test/process.h b/app/test/process.h
index af7bc3e0de..06b2f8b192 100644
--- a/app/test/process.h
+++ b/app/test/process.h
@@ -17,6 +17,7 @@
 #include 
 
 #include  /* strlcpy */
+#include 
 
 #ifdef RTE_EXEC_ENV_FREEBSD
 #define self "curproc"
@@ -34,6 +35,34 @@ extern uint16_t flag_for_send_pkts;
 #endif
 #endif
 
+#define PREFIX_ALLOW "--allow="
+
+static int
+add_parameter_allow(char **argv, int max_capacity)
+{
+   struct rte_devargs *devargs;
+   int count = 0;
+
+   RTE_EAL_DEVARGS_FOREACH(NULL, devargs) {
+   if (strlen(devargs->name) == 0)
+   continue;
+
+   if (devargs->data == NULL || strlen(devargs->data) == 0) {
+   if (asprintf(&argv[count], PREFIX_ALLOW"%s", 
devargs->name) < 0)
+   break;
+   } else {
+   if (asprintf(&argv[count], PREFIX_ALLOW"%s,%s",
+devargs->name, devargs->data) < 0)
+   break;
+   }
+
+   if (++count == max_capacity)
+   break;
+   }
+
+   return count;
+}
+
 /*
  * launches a second copy of the test process using the given argv parameters,
  * which should include argv[0] as the process name. To identify in the
@@ -43,8 +72,10 @@ extern uint16_t flag_for_send_pkts;
 static inline int
 process_dup(const char *const argv[], int numargs, const char *env_value)
 {
-   int num;
-   char *argv_cpy[numargs + 1];
+   int num = 0;
+   char **argv_cpy;
+   int allow_num;
+   int argv_num;
int i, status;
char path[32];
 #ifdef RTE_LIB_PDUMP
@@ -58,11 +89,18 @@ process_dup(const char *const argv[], int numargs, const 
char *env_value)
if (pid < 0)
return -1;
else if (pid == 0) {
+   allow_num = rte_devargs_type_count(RTE_DEVTYPE_ALLOWED);
+   argv_num = numargs + allow_num + 1;
+   argv_cpy = calloc(argv_num, sizeof(char *));
+   if (!argv_cpy)
+   rte_panic("Memory allocation failed\n");
+
/* make a copy of the arguments to be passed to exec */
for (i = 0; i < numargs; i++)
argv_cpy[i] = strdup(argv[i]);
-   argv_cpy[i] = NULL;
-   num = numargs;
+   if (allow_num > 0)
+   num = add_parameter_allow(&argv_cpy[i], allow_num);
+   num += numargs;
 
 #ifdef RTE_EXEC_ENV_LINUX
{
-- 
2.25.1

RE: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

[Matan Azrad]

From: Suanming Mou
> > > Adding Dariusz Sosnowski as NVIDIA mlx5 maintainer.
> > >
> > > Signed-off-by: Maayan Kashani 
> >
> > Welcome, Dariusz
> > Acked-by: Viacheslav Ovsiienko 
> Acked-by: Suanming Mou 

Welcome Dariusz!

Acked-by: Matan Azrad 

[PATCH] vfio: add get device info API

[Mingjin Ye]

This patch adds an API to support getting device information.

The driver can use the "rte_vfio_get_device_info" helper to get
device information from EAL.

Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
 lib/eal/include/rte_vfio.h | 26 ++
 lib/eal/linux/eal_vfio.c   | 19 +++
 lib/eal/version.map|  1 +
 3 files changed, 46 insertions(+)

diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h
index 3487c4f2a2..b3f55963e3 100644
--- a/lib/eal/include/rte_vfio.h
+++ b/lib/eal/include/rte_vfio.h
@@ -212,6 +212,32 @@ int
 rte_vfio_get_group_num(const char *sysfs_base,
  const char *dev_addr, int *iommu_group_num);
 
+/**
+ * Get device information
+ *
+ * This function is only relevant to linux and will return
+ * an error on BSD.
+ *
+ * @param sysfs_base
+ *   sysfs path prefix.
+ *
+ * @param dev_addr
+ *   device location.
+ *
+ * @param vfio_dev_fd
+ *   VFIO fd.
+ *
+ * @param device_info
+ *   Device information.
+ *
+ * @return
+ *   0 on success.
+ *   <0 on failure.
+ */
+int
+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info);
+
 /**
  * Open a new VFIO container fd
  *
diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
index ad3c1654b2..5810d9fcd7 100644
--- a/lib/eal/linux/eal_vfio.c
+++ b/lib/eal/linux/eal_vfio.c
@@ -1222,6 +1222,25 @@ vfio_set_iommu_type(int vfio_container_fd)
return NULL;
 }
 
+int
+rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr,
+   int *vfio_dev_fd, struct vfio_device_info *device_info)
+{
+   if (!device_info || *vfio_dev_fd < 0)
+   return -1;
+
+   if (*vfio_dev_fd == 0) {
+   if (rte_vfio_setup_device(sysfs_base, dev_addr,
+   vfio_dev_fd, device_info))
+   return -1;
+   } else {
+   if (ioctl(*vfio_dev_fd, VFIO_DEVICE_GET_INFO, &device_info))
+   return -1;
+   }
+
+   return 0;
+}
+
 int
 vfio_has_supported_extensions(int vfio_container_fd)
 {
diff --git a/lib/eal/version.map b/lib/eal/version.map
index e00a844805..8b4a9c237e 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -300,6 +300,7 @@ DPDK_24 {
rte_vfio_noiommu_is_enabled; # WINDOWS_NO_EXPORT
rte_vfio_release_device; # WINDOWS_NO_EXPORT
rte_vfio_setup_device; # WINDOWS_NO_EXPORT
+   rte_vfio_get_device_info; # WINDOWS_NO_EXPORT
rte_zmalloc;
rte_zmalloc_socket;
 
-- 
2.25.1

[PATCH v3 00/22] replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

This patchset replaces strtok with strtok_s in app, example, lib
and drivers. And adds check for use of strtok in checkpatches.sh.

--
v3:
1. fix compile error.
2. use strtok_r instead.
v2:
1. fix commit log.
2. add check in checkpatches.sh.
3. replace strtok_r with strtok_s.
4. add Acked-by.
--

Jie Hai (22):
  app/graph: replace strtok with reentrant version
  app/bbdev: replace strtok with reentrant version
  app/compress-perf: replace strtok with reentrant version
  app/crypto-perf: replace strtok with reentrant version
  app/dma-perf: replace strtok with reentrant version
  app/test-fib: replace strtok with reentrant version
  app/flow-perf: replace strtok with reentrant version
  app/test-mldev: replace strtok with reentrant version
  dmadev: replace strtok with reentrant version
  eal: replace strtok with reentrant version
  ethdev: replace strtok with reentrant version
  eventdev: replace strtok with reentrant version
  security: replace strtok with reentrant version
  telemetry: replace strtok with reentrant version
  bus/fslmc: replace strtok with reentrant version
  common/cnxk: replace strtok with reentrant version
  event/cnxk: replace strtok with reentrant version
  net/ark: replace strtok with reentrant version
  raw/cnxk_gpio: replace strtok with reentrant version
  examples/l2fwd-crypto: replace strtok with reentrant version
  examples/vhost: replace strtok with reentrant version
  devtools: check for some reentrant function

 app/graph/graph.c |  5 ++-
 app/graph/utils.c | 15 +---
 app/test-bbdev/test_bbdev_vector.c| 25 +++-
 .../comp_perf_options_parse.c | 16 
 app/test-crypto-perf/cperf_options_parsing.c  | 16 
 .../cperf_test_vector_parsing.c   | 10 +++--
 app/test-dma-perf/main.c  | 13 ---
 app/test-fib/main.c   | 10 ++---
 app/test-flow-perf/main.c | 22 ++-
 app/test-mldev/ml_options.c   | 18 -
 devtools/checkpatches.sh  |  8 
 drivers/bus/fslmc/fslmc_bus.c |  5 ++-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  4 +-
 drivers/common/cnxk/cnxk_telemetry_nix.c  | 12 +++---
 drivers/event/cnxk/cnxk_eventdev.c| 10 +++--
 drivers/event/cnxk/cnxk_tim_evdev.c   | 11 +++---
 drivers/net/ark/ark_pktchkr.c | 10 ++---
 drivers/net/ark/ark_pktgen.c  | 10 ++---
 drivers/raw/cnxk_gpio/cnxk_gpio.c |  6 +--
 examples/l2fwd-crypto/main.c  |  6 +--
 examples/vhost/main.c |  3 +-
 lib/dmadev/rte_dmadev.c   |  4 +-
 lib/eal/common/eal_common_memory.c|  8 ++--
 lib/ethdev/rte_ethdev_telemetry.c |  6 ++-
 lib/eventdev/rte_event_eth_rx_adapter.c   | 38 +--
 lib/eventdev/rte_eventdev.c   | 18 -
 lib/security/rte_security.c   |  3 +-
 lib/telemetry/telemetry.c |  5 ++-
 28 files changed, 177 insertions(+), 140 deletions(-)

-- 
2.30.0

[PATCH v3 01/22] app/graph: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 5c59002a34f3 ("app/graph: add graph commands")
Fixes: 984a315a5804 ("app/graph: add parser utility")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/graph/graph.c |  5 +++--
 app/graph/utils.c | 15 +--
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/app/graph/graph.c b/app/graph/graph.c
index a65723a196da..316950948160 100644
--- a/app/graph/graph.c
+++ b/app/graph/graph.c
@@ -103,9 +103,10 @@ parser_usecases_read(char *usecases)
 {
bool valid = false;
uint32_t i, j = 0;
+   char *sp = NULL;
char *token;
 
-   token = strtok(usecases, ",");
+   token = strtok_r(usecases, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(supported_usecases); i++) {
if (strcmp(supported_usecases[i], token) == 0) {
@@ -116,7 +117,7 @@ parser_usecases_read(char *usecases)
break;
}
}
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
}
 
return valid;
diff --git a/app/graph/utils.c b/app/graph/utils.c
index c7b6ae83cf1f..ae2ff225c394 100644
--- a/app/graph/utils.c
+++ b/app/graph/utils.c
@@ -101,13 +101,14 @@ int
 parser_ip4_read(uint32_t *value, char *p)
 {
uint8_t shift = 24;
+   char *sp = NULL;
uint32_t ip = 0;
char *token;
 
-   token = strtok(p, ".");
+   token = strtok_r(p, ".", &sp);
while (token != NULL) {
ip |= (((uint32_t)strtoul(token, NULL, 10)) << shift);
-   token = strtok(NULL, ".");
+   token = strtok_r(NULL, ".", &sp);
shift -= 8;
}
 
@@ -120,13 +121,14 @@ int
 parser_ip6_read(uint8_t *value, char *p)
 {
uint64_t val = 0;
+   char *sp = NULL;
char *token;
 
-   token = strtok(p, ":");
+   token = strtok_r(p, ":", &sp);
while (token != NULL) {
hex_string_to_uint64(&val, token);
*value = val;
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
value++;
val = 0;
}
@@ -139,13 +141,14 @@ parser_mac_read(uint64_t *value, char *p)
 {
uint64_t mac = 0, val = 0;
uint8_t shift = 40;
+   char *sp = NULL;
char *token;
 
-   token = strtok(p, ":");
+   token = strtok_r(p, ":", &sp);
while (token != NULL) {
hex_string_to_uint64(&val, token);
mac |= val << shift;
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
shift -= 8;
val = 0;
}
-- 
2.30.0

[PATCH v3 05/22] app/dma-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-dma-perf/main.c | 13 -
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index e5bccc27da5e..38780939578e 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -164,6 +164,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
uint16_t len;
char *input;
struct lcore_dma_map_t *lcore_dma_map;
+   char *sp = NULL;
 
if (test_case == NULL || value == NULL)
return -1;
@@ -175,7 +176,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
 
memset(lcore_dma_map, 0, sizeof(struct lcore_dma_map_t));
 
-   char *token = strtok(input, ", ");
+   char *token = strtok_r(input, ", ", &sp);
while (token != NULL) {
if (lcore_dma_map->cnt >= MAX_LCORE_NB) {
free(input);
@@ -185,7 +186,7 @@ parse_lcore(struct test_configure *test_case, const char 
*value)
uint16_t lcore_id = atoi(token);
lcore_dma_map->lcores[lcore_dma_map->cnt++] = lcore_id;
 
-   token = strtok(NULL, ", ");
+   token = strtok_r(NULL, ", ", &sp);
}
 
free(input);
@@ -201,6 +202,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
char *start, *end, *substr;
uint16_t lcore_id;
int ret = 0;
+   char *sp = NULL;
 
if (test_case == NULL || value == NULL)
return -1;
@@ -216,7 +218,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
goto out;
}
 
-   substr = strtok(addrs, ",");
+   substr = strtok_r(addrs, ",", &sp);
if (substr == NULL) {
fprintf(stderr, "No input DMA address\n");
ret = -1;
@@ -258,7 +260,7 @@ parse_lcore_dma(struct test_configure *test_case, const 
char *value)
strlcpy(lcore_dma_map->dma_names[lcore_dma_map->cnt], ptrs[1],
RTE_DEV_NAME_MAX_LEN);
lcore_dma_map->cnt++;
-   substr = strtok(NULL, ",");
+   substr = strtok_r(NULL, ",", &sp);
} while (substr != NULL);
 
 out:
@@ -486,6 +488,7 @@ main(int argc, char *argv[])
char *rst_path_ptr = NULL;
char rst_path[PATH_MAX];
int new_argc;
+   char *sp = NULL;
 
memset(args, 0, sizeof(args));
 
@@ -504,7 +507,7 @@ main(int argc, char *argv[])
}
if (rst_path_ptr == NULL) {
strlcpy(rst_path, cfg_path_ptr, PATH_MAX);
-   char *token = strtok(basename(rst_path), ".");
+   char *token = strtok_r(basename(rst_path), ".", &sp);
if (token == NULL) {
printf("Config file error.\n");
return -1;
-- 
2.30.0

[PATCH v3 06/22] app/test-fib: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-fib/main.c | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index 75a56135f212..8e5d17b13028 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -223,9 +223,9 @@ parse_distrib(uint8_t depth_lim, const uint32_t n)
uint32_t nrpd[128 + 1] = {0}; /* number of routes per depth */
uint32_t n_routes;
uint8_t depth, ratio, ratio_acc = 0;
-   char *in;
+   char *in, *sp = NULL;
 
-   in = strtok(distrib_string, ",");
+   in = strtok_r(distrib_string, ",", &sp);
 
/*parse configures routes percentage ratios*/
while (in != NULL) {
@@ -265,7 +265,7 @@ parse_distrib(uint8_t depth_lim, const uint32_t n)
}
 
/*number of configured depths in*/
-   in = strtok(NULL, ",");
+   in = strtok_r(NULL, ",", &sp);
}
 
if (ratio_acc > 100) {
@@ -542,10 +542,10 @@ parse_lookup(FILE *f, int af)
int ret, i = 0;
uint8_t *tbl = (uint8_t *)config.lookup_tbl;
int step = (af == AF_INET) ? 4 : 16;
-   char *s;
+   char *s, *sp = NULL;
 
while (fgets(line, sizeof(line), f) != NULL) {
-   s = strtok(line, " \t\n");
+   s = strtok_r(line, " \t\n", &sp);
if (s == NULL)
return -EINVAL;
ret = inet_pton(af, s, &tbl[i]);
-- 
2.30.0

[PATCH v3 03/22] app/compress-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: e0b6287c035d ("app/compress-perf: add parser")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-compress-perf/comp_perf_options_parse.c | 16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/test-compress-perf/comp_perf_options_parse.c 
b/app/test-compress-perf/comp_perf_options_parse.c
index 6d8c370fc2ea..d997fa667a94 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -177,6 +177,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
 {
char *token;
uint8_t number;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -184,7 +185,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ":");
+   token = strtok_r(copy_arg, ":", &sp);
 
/* Parse minimum value */
if (token != NULL) {
@@ -197,7 +198,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
 
/* Parse increment value */
if (token != NULL) {
@@ -211,7 +212,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
 
/* Parse maximum value */
if (token != NULL) {
@@ -225,7 +226,7 @@ parse_range(const char *arg, uint8_t *min, uint8_t *max, 
uint8_t *inc)
} else
goto err_range;
 
-   if (strtok(NULL, ":") != NULL)
+   if (strtok_r(NULL, ":", &sp) != NULL)
goto err_range;
 
free(copy_arg);
@@ -244,6 +245,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
uint8_t count = 0;
uint32_t temp_min;
uint32_t temp_max;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -251,7 +253,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ",");
+   token = strtok_r(copy_arg, ",", &sp);
 
/* Parse first value */
if (token != NULL) {
@@ -266,7 +268,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
} else
goto err_list;
 
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
 
while (token != NULL) {
if (count == MAX_LIST) {
@@ -288,7 +290,7 @@ parse_list(const char *arg, uint8_t *list, uint8_t *min, 
uint8_t *max)
if (number > temp_max)
temp_max = number;
 
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
}
 
if (min)
-- 
2.30.0

[PATCH v3 02/22] app/bbdev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases")
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-bbdev/test_bbdev_vector.c | 25 +++--
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_vector.c 
b/app/test-bbdev/test_bbdev_vector.c
index c26727cd35c4..5c966e79645e 100644
--- a/app/test-bbdev/test_bbdev_vector.c
+++ b/app/test-bbdev/test_bbdev_vector.c
@@ -63,8 +63,9 @@ parse_values(char *tokens, uint32_t **data, uint32_t 
*data_length)
 
uint32_t *values, *values_resized;
char *tok, *error = NULL;
+   char *sp = NULL;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_r(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -98,7 +99,7 @@ parse_values(char *tokens, uint32_t **data, uint32_t 
*data_length)
 
*data_length = *data_length + (strlen(tok) - strlen("0x"))/2;
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_r(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
 
@@ -299,8 +300,9 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,
 {
char *tok = NULL;
uint32_t op_flag_value = 0;
+   char *sp = NULL;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_r(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -330,7 +332,7 @@ parse_turbo_flags(char *tokens, uint32_t *op_flags,
 
*op_flags = *op_flags | op_flag_value;
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_r(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
}
@@ -368,9 +370,10 @@ static int
 parse_expected_status(char *tokens, int *status, enum rte_bbdev_op_type 
op_type)
 {
char *tok = NULL;
+   char *sp = NULL;
bool status_ok = false;
 
-   tok = strtok(tokens, VALUE_DELIMITER);
+   tok = strtok_r(tokens, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -401,7 +404,7 @@ parse_expected_status(char *tokens, int *status, enum 
rte_bbdev_op_type op_type)
return -1;
}
 
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_r(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
}
@@ -894,6 +897,7 @@ parse_fft_params(const char *key_token, char *token,
int ret = 0, status = 0, i, shift;
uint32_t op_flags = 0;
char *tok, *err = NULL;
+   char *sp = NULL;
 
struct rte_bbdev_op_fft *fft = &vector->fft;
 
@@ -922,7 +926,7 @@ parse_fft_params(const char *key_token, char *token,
fft->output_leading_depadding = (uint32_t) strtoul(token, &err, 
0);
ret = ((err == NULL) || (*err != '\0')) ? -1 : 0;
} else if (!strcmp(key_token, "window_index")) {
-   tok = strtok(token, VALUE_DELIMITER);
+   tok = strtok_r(token, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
for (i = 0; i < FFT_WIN_SIZE; i++) {
@@ -930,7 +934,7 @@ parse_fft_params(const char *key_token, char *token,
fft->window_index[i / 2] |= (uint32_t) strtoul(tok, 
&err, 0)
<< shift;
if (i < (FFT_WIN_SIZE - 1)) {
-   tok = strtok(NULL, VALUE_DELIMITER);
+   tok = strtok_r(NULL, VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
}
@@ -995,6 +999,7 @@ static int
 parse_entry(char *entry, struct test_bbdev_vector *vector)
 {
int ret = 0;
+   char *sp = NULL;
char *token, *key_token;
enum rte_bbdev_op_type op_type = RTE_BBDEV_OP_NONE;
 
@@ -1004,10 +1009,10 @@ parse_entry(char *entry, struct test_bbdev_vector 
*vector)
}
 
/* get key */
-   token = strtok(entry, ENTRY_DELIMITER);
+   token = strtok_r(entry, ENTRY_DELIMITER, &sp);
key_token = token;
/* get values for key */
-   token = strtok(NULL, ENTRY_DELIMITER);
+   token = strtok_r(NULL, ENTRY_DELIMITER, &sp);
 
if (key_token == NULL || token == NULL) {
printf("Expected 'key = values' but was '%.40s'..\n", entry);
-- 
2.30.0

[PATCH v3 04/22] app/crypto-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes")
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-crypto-perf/cperf_options_parsing.c | 16 +---
 app/test-crypto-perf/cperf_test_vector_parsing.c | 10 ++
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/app/test-crypto-perf/cperf_options_parsing.c 
b/app/test-crypto-perf/cperf_options_parsing.c
index 75afedc7fd6e..77cda0eb8e6f 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -161,6 +161,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
 {
char *token;
uint32_t number;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -168,7 +169,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ":");
+   token = strtok_r(copy_arg, ":", &sp);
 
/* Parse minimum value */
if (token != NULL) {
@@ -182,7 +183,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
 
/* Parse increment value */
if (token != NULL) {
@@ -196,7 +197,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   token = strtok(NULL, ":");
+   token = strtok_r(NULL, ":", &sp);
 
/* Parse maximum value */
if (token != NULL) {
@@ -211,7 +212,7 @@ parse_range(const char *arg, uint32_t *min, uint32_t *max, 
uint32_t *inc)
} else
goto err_range;
 
-   if (strtok(NULL, ":") != NULL)
+   if (strtok_r(NULL, ":", &sp) != NULL)
goto err_range;
 
free(copy_arg);
@@ -230,6 +231,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
uint8_t count = 0;
uint32_t temp_min;
uint32_t temp_max;
+   char *sp = NULL;
 
char *copy_arg = strdup(arg);
 
@@ -237,7 +239,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
return -1;
 
errno = 0;
-   token = strtok(copy_arg, ",");
+   token = strtok_r(copy_arg, ",", &sp);
 
/* Parse first value */
if (token != NULL) {
@@ -253,7 +255,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
} else
goto err_list;
 
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
 
while (token != NULL) {
if (count == MAX_LIST) {
@@ -275,7 +277,7 @@ parse_list(const char *arg, uint32_t *list, uint32_t *min, 
uint32_t *max)
if (number > temp_max)
temp_max = number;
 
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
}
 
if (min)
diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c 
b/app/test-crypto-perf/cperf_test_vector_parsing.c
index 737d61d4af6b..4d2e6053e745 100644
--- a/app/test-crypto-perf/cperf_test_vector_parsing.c
+++ b/app/test-crypto-perf/cperf_test_vector_parsing.c
@@ -220,8 +220,9 @@ parse_values(char *tokens, uint8_t **data, uint32_t 
*data_length)
 
uint8_t *values, *values_resized;
char *tok, *error = NULL;
+   char *sp = NULL;
 
-   tok = strtok(tokens, CPERF_VALUE_DELIMITER);
+   tok = strtok_r(tokens, CPERF_VALUE_DELIMITER, &sp);
if (tok == NULL)
return -1;
 
@@ -252,7 +253,7 @@ parse_values(char *tokens, uint8_t **data, uint32_t 
*data_length)
return -1;
}
 
-   tok = strtok(NULL, CPERF_VALUE_DELIMITER);
+   tok = strtok_r(NULL, CPERF_VALUE_DELIMITER, &sp);
if (tok == NULL)
break;
 
@@ -283,6 +284,7 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
 
uint8_t *data = NULL;
char *token, *key_token;
+   char *sp = NULL;
 
if (entry == NULL) {
printf("Expected entry value\n");
@@ -290,10 +292,10 @@ parse_entry(char *entry, struct cperf_test_vector *vector,
}
 
/* get key */
-   token = strtok(entry, CPERF_ENTRY_DELIMITER);
+   token = strtok_r(entry, CPERF_ENTRY_DELIMITER, &sp);
key_token = token;
/* get values for key */
-   token = strtok(NU

[PATCH v3 08/22] app/test-mldev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-mldev/ml_options.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/test-mldev/ml_options.c b/app/test-mldev/ml_options.c
index 72357c1c393d..3f3dc8f69890 100644
--- a/app/test-mldev/ml_options.c
+++ b/app/test-mldev/ml_options.c
@@ -75,12 +75,12 @@ ml_parse_models(struct ml_options *opt, const char *arg)
 {
const char *delim = ",";
char models[PATH_MAX];
-   char *token;
+   char *token, *sp = NULL;
int ret = 0;
 
strlcpy(models, arg, PATH_MAX);
 
-   token = strtok(models, delim);
+   token = strtok_r(models, delim, &sp);
while (token != NULL) {
strlcpy(opt->filelist[opt->nb_filelist].model, token, PATH_MAX);
opt->nb_filelist++;
@@ -90,7 +90,7 @@ ml_parse_models(struct ml_options *opt, const char *arg)
ret = -EINVAL;
break;
}
-   token = strtok(NULL, delim);
+   token = strtok_r(NULL, delim, &sp);
}
 
if (opt->nb_filelist == 0) {
@@ -106,7 +106,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
 {
const char *delim = ",";
char filelist[PATH_MAX];
-   char *token;
+   char *token, *sp = NULL;
 
if (opt->nb_filelist >= ML_TEST_MAX_MODELS) {
ml_err("Exceeded filelist count, max = %d\n", 
ML_TEST_MAX_MODELS);
@@ -116,7 +116,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(filelist, arg, PATH_MAX);
 
/* model */
-   token = strtok(filelist, delim);
+   token = strtok_r(filelist, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, model not specified = %s\n", arg);
return -EINVAL;
@@ -124,7 +124,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].model, token, PATH_MAX);
 
/* input */
-   token = strtok(NULL, delim);
+   token = strtok_r(NULL, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, input not specified = %s\n", arg);
return -EINVAL;
@@ -132,7 +132,7 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].input, token, PATH_MAX);
 
/* output */
-   token = strtok(NULL, delim);
+   token = strtok_r(NULL, delim, &sp);
if (token == NULL) {
ml_err("Invalid filelist, output not specified = %s\n", arg);
return -EINVAL;
@@ -140,14 +140,14 @@ ml_parse_filelist(struct ml_options *opt, const char *arg)
strlcpy(opt->filelist[opt->nb_filelist].output, token, PATH_MAX);
 
/* reference - optional */
-   token = strtok(NULL, delim);
+   token = strtok_r(NULL, delim, &sp);
if (token != NULL)
strlcpy(opt->filelist[opt->nb_filelist].reference, token, 
PATH_MAX);
else
memset(opt->filelist[opt->nb_filelist].reference, 0, PATH_MAX);
 
/* check for extra tokens */
-   token = strtok(NULL, delim);
+   token = strtok_r(NULL, delim, &sp);
if (token != NULL) {
ml_err("Invalid filelist. Entries > 4\n.");
return -EINVAL;
-- 
2.30.0

[PATCH v3 07/22] app/flow-perf: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 0c8f1f4ab90e ("app/flow-perf: support raw encap/decap actions")
Fixes: 7f37f0936a19 ("app/flow-perf: support meter policy API")
Fixes: 80a323319745 ("app/flow-perf: add destination ports parameter")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 app/test-flow-perf/main.c | 22 --
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index e224ef67983d..36e7c1d72019 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -602,6 +602,7 @@ read_meter_policy(char *prog, char *arg)
 {
char *token;
size_t i, j, k;
+   char *sp = NULL;
 
j = 0;
k = 0;
@@ -612,9 +613,9 @@ read_meter_policy(char *prog, char *arg)
token = strsep(&arg, ":\0");
}
j = 0;
-   token = strtok(actions_str[0], ",\0");
+   token = strtok_r(actions_str[0], ",\0", &sp);
while (token == NULL && j < RTE_COLORS - 1)
-   token = strtok(actions_str[++j], ",\0");
+   token = strtok_r(actions_str[++j], ",\0", &sp);
while (j < RTE_COLORS && token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); i++) {
if (!strcmp(token, flow_options[i].str)) {
@@ -628,9 +629,9 @@ read_meter_policy(char *prog, char *arg)
usage(prog);
rte_exit(EXIT_SUCCESS, "Invalid colored actions\n");
}
-   token = strtok(NULL, ",\0");
+   token = strtok_r(NULL, ",\0", &sp);
while (!token && j < RTE_COLORS - 1) {
-   token = strtok(actions_str[++j], ",\0");
+   token = strtok_r(actions_str[++j], ",\0", &sp);
k = 0;
}
}
@@ -641,6 +642,7 @@ args_parse(int argc, char **argv)
 {
uint64_t pm, seed;
uint64_t hp_conf;
+   char *sp = NULL;
char **argvopt;
uint32_t prio;
char *token;
@@ -804,7 +806,7 @@ args_parse(int argc, char **argv)
RTE_FLOW_ACTION_TYPE_RAW_ENCAP
);
 
-   token = strtok(optarg, ",");
+   token = strtok_r(optarg, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); 
i++) {
if (strcmp(flow_options[i].str, 
token) == 0) {
@@ -817,7 +819,7 @@ args_parse(int argc, char **argv)
rte_exit(EXIT_FAILURE,
"Invalid encap 
item: %s\n", token);
}
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
}
printf(" / ");
}
@@ -828,7 +830,7 @@ args_parse(int argc, char **argv)
RTE_FLOW_ACTION_TYPE_RAW_DECAP
);
 
-   token = strtok(optarg, ",");
+   token = strtok_r(optarg, ",", &sp);
while (token != NULL) {
for (i = 0; i < RTE_DIM(flow_options); 
i++) {
if (strcmp(flow_options[i].str, 
token) == 0) {
@@ -841,7 +843,7 @@ args_parse(int argc, char **argv)
rte_exit(EXIT_FAILURE,
"Invalid decap 
item %s\n", token);
}
-   token = strtok(NULL, ",");
+   token = strtok_r(NULL, ",", &sp);
}
printf(" / ");
}
@@ -910,10 +912,10 @@ args_parse(int argc, char **argv)
uint16_t port_idx = 0;
char *token;
 
-   token = strtok(optarg, ",");
+   token = strtok_r(optarg, ",", &sp);
while (token != NULL) {
dst_ports[port_idx++] = atoi(token);
-   token = strtok(NULL, ",

[PATCH v3 09/22] dmadev: replace strtok with reentrant version

[Jie Hai]

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant version.

Fixes: 39b5ab60df30 ("dmadev: add telemetry")
Cc: sta...@dpdk.org

Signed-off-by: Jie Hai 
Acked-by: Chengwen Feng 
---
 lib/dmadev/rte_dmadev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index 4e5e420c82a5..f856cc7d0905 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -971,7 +971,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
struct rte_dma_info dma_info;
struct rte_dma_stats dma_stats;
int dev_id, ret, vchan_id;
-   char *end_param;
+   char *end_param, *sp = NULL;
const char *vchan_param;
 
if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -990,7 +990,7 @@ dmadev_handle_dev_stats(const char *cmd __rte_unused,
if (dma_info.nb_vchans == 1 && *end_param == '\0')
vchan_id = 0;
else {
-   vchan_param = strtok(end_param, ",");
+   vchan_param = strtok_r(end_param, ",", &sp);
if (!vchan_param || strlen(vchan_param) == 0 || 
!isdigit(*vchan_param))
return -EINVAL;
 
-- 
2.30.0