Re: [PATCH v3 22/29] vhost: remove experimental from some API's

[Maxime Coquelin]

On 10/19/23 18:55, Stephen Hemminger wrote:

All API's that before 22.11 release should have experimental
tag removed.

Signed-off-by: Stephen Hemminger 
---
  lib/vhost/rte_vhost.h|  5 
  lib/vhost/rte_vhost_async.h  | 19 --
  lib/vhost/rte_vhost_crypto.h |  1 -
  lib/vhost/version.map| 51 ++--
  4 files changed, 19 insertions(+), 57 deletions(-)

diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index fec650b1dbba..db92f0534431 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -509,7 +509,6 @@ rte_vhost_driver_get_vdpa_device(const char *path);
   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_driver_get_vdpa_dev_type(const char *path, uint32_t *type);
  
@@ -648,7 +647,6 @@ int rte_vhost_get_negotiated_features(int vid, uint64_t *features);

   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_get_negotiated_protocol_features(int vid,
   uint64_t *protocol_features);
@@ -960,7 +958,6 @@ int rte_vhost_vring_call(int vid, uint16_t vring_idx);
   * @return
   *  0 on success, -1 on failure, -EAGAIN for another retry
   */
-__rte_experimental
  int rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx);
  
  /**

@@ -987,7 +984,6 @@ uint32_t rte_vhost_rx_queue_count(int vid, uint16_t qid);
   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
struct rte_vhost_power_monitor_cond *pmc);
@@ -1102,7 +1098,6 @@ rte_vhost_get_vdpa_device(int vid);
   * @return
   *  0 on success, < 0 on failure
   */
-__rte_experimental
  int
  rte_vhost_backend_config_change(int vid, bool need_reply);
  
diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h

index 8f190dd44b1b..3370026415fb 100644
--- a/lib/vhost/rte_vhost_async.h
+++ b/lib/vhost/rte_vhost_async.h
@@ -24,7 +24,6 @@ extern "C" {
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_register(int vid, uint16_t queue_id);
  
  /**

@@ -37,7 +36,6 @@ int rte_vhost_async_channel_register(int vid, uint16_t 
queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_unregister(int vid, uint16_t queue_id);
  
  /**

@@ -54,7 +52,6 @@ int rte_vhost_async_channel_unregister(int vid, uint16_t 
queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_register_thread_unsafe(int vid, uint16_t 
queue_id);
  
  /**

@@ -71,7 +68,6 @@ int rte_vhost_async_channel_register_thread_unsafe(int vid, 
uint16_t queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_unregister_thread_unsafe(int vid,
uint16_t queue_id);
  
@@ -95,7 +91,6 @@ int rte_vhost_async_channel_unregister_thread_unsafe(int vid,

   * @return
   *  num of packets enqueued
   */
-__rte_experimental
  uint16_t rte_vhost_submit_enqueue_burst(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -120,7 +115,6 @@ uint16_t rte_vhost_submit_enqueue_burst(int vid, uint16_t 
queue_id,
   * @return
   *  num of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -136,7 +130,6 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t 
queue_id,
   * @return
   *  the amount of in-flight packets on success; -1 on failure
   */
-__rte_experimental
  int rte_vhost_async_get_inflight(int vid, uint16_t queue_id);
  
  /**

@@ -153,7 +146,6 @@ int rte_vhost_async_get_inflight(int vid, uint16_t 
queue_id);
   * @return
   * the amount of in-flight packets on success; -1 on failure
   */
-__rte_experimental
  int rte_vhost_async_get_inflight_thread_unsafe(int vid, uint16_t queue_id);
  
  /**

@@ -178,7 +170,6 @@ int rte_vhost_async_get_inflight_thread_unsafe(int vid, 
uint16_t queue_id);
   * @return
   *  Number of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -203,7 +194,6 @@ uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, 
uint16_t queue_id,
   * @return
   *  Number of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_clear_queue(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -226,13 +216,9 @@ uint16_t rte_vhost_clear_queue(int vid, uint16_t queue_id,
   * @return
   *  0 on success, and -1 on failure
   */
-__rte_experime

Re: [PATCH v4 21/28] vhost: remove experimental from some API's

[Maxime Coquelin]

On 10/19/23 21:10, Stephen Hemminger wrote:

All API's that before 22.11 release should have experimental
tag removed.

Signed-off-by: Stephen Hemminger 
---
  lib/vhost/rte_vhost.h|  5 
  lib/vhost/rte_vhost_async.h  | 19 --
  lib/vhost/rte_vhost_crypto.h |  1 -
  lib/vhost/version.map| 51 ++--
  4 files changed, 19 insertions(+), 57 deletions(-)

diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index fec650b1dbba..db92f0534431 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -509,7 +509,6 @@ rte_vhost_driver_get_vdpa_device(const char *path);
   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_driver_get_vdpa_dev_type(const char *path, uint32_t *type);
  
@@ -648,7 +647,6 @@ int rte_vhost_get_negotiated_features(int vid, uint64_t *features);

   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_get_negotiated_protocol_features(int vid,
   uint64_t *protocol_features);
@@ -960,7 +958,6 @@ int rte_vhost_vring_call(int vid, uint16_t vring_idx);
   * @return
   *  0 on success, -1 on failure, -EAGAIN for another retry
   */
-__rte_experimental
  int rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx);
  
  /**

@@ -987,7 +984,6 @@ uint32_t rte_vhost_rx_queue_count(int vid, uint16_t qid);
   * @return
   *  0 on success, -1 on failure
   */
-__rte_experimental
  int
  rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
struct rte_vhost_power_monitor_cond *pmc);
@@ -1102,7 +1098,6 @@ rte_vhost_get_vdpa_device(int vid);
   * @return
   *  0 on success, < 0 on failure
   */
-__rte_experimental
  int
  rte_vhost_backend_config_change(int vid, bool need_reply);
  
diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h

index 8f190dd44b1b..3370026415fb 100644
--- a/lib/vhost/rte_vhost_async.h
+++ b/lib/vhost/rte_vhost_async.h
@@ -24,7 +24,6 @@ extern "C" {
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_register(int vid, uint16_t queue_id);
  
  /**

@@ -37,7 +36,6 @@ int rte_vhost_async_channel_register(int vid, uint16_t 
queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_unregister(int vid, uint16_t queue_id);
  
  /**

@@ -54,7 +52,6 @@ int rte_vhost_async_channel_unregister(int vid, uint16_t 
queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_register_thread_unsafe(int vid, uint16_t 
queue_id);
  
  /**

@@ -71,7 +68,6 @@ int rte_vhost_async_channel_register_thread_unsafe(int vid, 
uint16_t queue_id);
   * @return
   *  0 on success, -1 on failures
   */
-__rte_experimental
  int rte_vhost_async_channel_unregister_thread_unsafe(int vid,
uint16_t queue_id);
  
@@ -95,7 +91,6 @@ int rte_vhost_async_channel_unregister_thread_unsafe(int vid,

   * @return
   *  num of packets enqueued
   */
-__rte_experimental
  uint16_t rte_vhost_submit_enqueue_burst(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -120,7 +115,6 @@ uint16_t rte_vhost_submit_enqueue_burst(int vid, uint16_t 
queue_id,
   * @return
   *  num of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -136,7 +130,6 @@ uint16_t rte_vhost_poll_enqueue_completed(int vid, uint16_t 
queue_id,
   * @return
   *  the amount of in-flight packets on success; -1 on failure
   */
-__rte_experimental
  int rte_vhost_async_get_inflight(int vid, uint16_t queue_id);
  
  /**

@@ -153,7 +146,6 @@ int rte_vhost_async_get_inflight(int vid, uint16_t 
queue_id);
   * @return
   * the amount of in-flight packets on success; -1 on failure
   */
-__rte_experimental
  int rte_vhost_async_get_inflight_thread_unsafe(int vid, uint16_t queue_id);
  
  /**

@@ -178,7 +170,6 @@ int rte_vhost_async_get_inflight_thread_unsafe(int vid, 
uint16_t queue_id);
   * @return
   *  Number of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -203,7 +194,6 @@ uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, 
uint16_t queue_id,
   * @return
   *  Number of packets returned
   */
-__rte_experimental
  uint16_t rte_vhost_clear_queue(int vid, uint16_t queue_id,
struct rte_mbuf **pkts, uint16_t count, int16_t dma_id,
uint16_t vchan_id);
@@ -226,13 +216,9 @@ uint16_t rte_vhost_clear_queue(int vid, uint16_t queue_id,
   * @return
   *  0 on success, and -1 on failure
   */
-__rte_experime

Re: [PATCH v4 22/28] bbdev: remove experimental tag

[Maxime Coquelin]

On 10/19/23 21:10, Stephen Hemminger wrote:

The API's for bbdev were last added to in 22.11.
Remove experimental flag now.

Signed-off-by: Stephen Hemminger 
---
  lib/bbdev/rte_bbdev.h|  4 
  lib/bbdev/rte_bbdev_op.h |  2 --
  lib/bbdev/version.map| 15 +++
  3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index d12e2e7fbcf3..b43e98ef9d1b 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -675,7 +675,6 @@ rte_bbdev_enqueue_ldpc_dec_ops(uint16_t dev_id, uint16_t 
queue_id,
   *   The number of operations actually enqueued.
   *   (This is the number of processed entries in the @p ops array.)
   */
-__rte_experimental
  static inline uint16_t
  rte_bbdev_enqueue_fft_ops(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_fft_op **ops, uint16_t num_ops)
@@ -860,7 +859,6 @@ rte_bbdev_dequeue_ldpc_dec_ops(uint16_t dev_id, uint16_t 
queue_id,
   *   The number of operations actually dequeued (this is the number of entries
   *   copied into the @p ops array).
   */
-__rte_experimental
  static inline uint16_t
  rte_bbdev_dequeue_fft_ops(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_fft_op **ops, uint16_t num_ops)
@@ -1042,7 +1040,6 @@ rte_bbdev_queue_intr_ctl(uint16_t dev_id, uint16_t 
queue_id, int epfd, int op,
   * @returns
   *   Device status as string or NULL if invalid.
   */
-__rte_experimental
  const char*
  rte_bbdev_device_status_str(enum rte_bbdev_device_status status);
  
@@ -1055,7 +1052,6 @@ rte_bbdev_device_status_str(enum rte_bbdev_device_status status);

   * @returns
   *   Queue status as string or NULL if op_type is invalid.
   */
-__rte_experimental
  const char*
  rte_bbdev_enqueue_status_str(enum rte_bbdev_enqueue_status status);
  
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h

index 369ac331bf9b..459631d0d0b7 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -1130,7 +1130,6 @@ rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
   *   - 0 on success.
   *   - EINVAL if invalid mempool is provided.
   */
-__rte_experimental
  static inline int
  rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
struct rte_bbdev_fft_op **ops, unsigned int num_ops)
@@ -1220,7 +1219,6 @@ rte_bbdev_enc_op_free_bulk(struct rte_bbdev_enc_op **ops, 
unsigned int num_ops)
   * @param num_ops
   *   Number of structures.
   */
-__rte_experimental
  static inline void
  rte_bbdev_fft_op_free_bulk(struct rte_bbdev_fft_op **ops, unsigned int 
num_ops)
  {
diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map
index eeb7ed475a6c..1840d2b2a491 100644
--- a/lib/bbdev/version.map
+++ b/lib/bbdev/version.map
@@ -10,11 +10,17 @@ DPDK_24 {
rte_bbdev_dec_op_free_bulk;
rte_bbdev_dequeue_dec_ops;
rte_bbdev_dequeue_enc_ops;
+   rte_bbdev_dequeue_fft_ops;
+   rte_bbdev_device_status_str;
rte_bbdev_devices;
rte_bbdev_enc_op_alloc_bulk;
rte_bbdev_enc_op_free_bulk;
rte_bbdev_enqueue_dec_ops;
rte_bbdev_enqueue_enc_ops;
+   rte_bbdev_enqueue_fft_ops;
+   rte_bbdev_enqueue_status_str;
+   rte_bbdev_fft_op_alloc_bulk;
+   rte_bbdev_fft_op_free_bulk;
rte_bbdev_find_next;
rte_bbdev_get_named_dev;
rte_bbdev_info_get;
@@ -43,14 +49,7 @@ DPDK_24 {
  EXPERIMENTAL {
global:
  
-	# added in 22.11

-   rte_bbdev_dequeue_fft_ops;
-   rte_bbdev_device_status_str;
-   rte_bbdev_enqueue_fft_ops;
-   rte_bbdev_enqueue_status_str;
-   rte_bbdev_fft_op_alloc_bulk;
-   rte_bbdev_fft_op_free_bulk;
-   #added in 23.11
+   # added in 23.11
rte_bbdev_dequeue_mldts_ops;
rte_bbdev_enqueue_mldts_ops;
rte_bbdev_mldts_op_alloc_bulk;


Acked-by: Maxime Coquelin 

Thanks,
Maxime

Re: [PATCH 1/7] vhost: fix missing vring call check on virtqueue access

[Maxime Coquelin]

On 10/19/23 09:24, David Marchand wrote:

On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin
 wrote:


Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.


Even if adding the lock was not enough, I would flag Fixes:
6c299bb7322f ("vhost: introduce vring call API")


Makes sense, adding it to v2.

Thanks,
Maxime



Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection")
Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt")
Cc: sta...@dpdk.org

Reported-by: Li Feng 
Signed-off-by: Maxime Coquelin 

[PATCH v2 1/7] vhost: fix missing vring call check on virtqueue access

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: 6c299bb7322f ("vhost: introduce vring call API")
Fixes: c5736998305d ("vhost: fix missing virtqueue lock protection")
Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt")
Cc: sta...@dpdk.org

Reported-by: Li Feng 
Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 7fde412ef3..0d2bc1a48b 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1330,6 +1330,7 @@ rte_vhost_vring_call(int vid, uint16_t vring_idx)
 {
struct virtio_net *dev;
struct vhost_virtqueue *vq;
+   int ret = 0;
 
dev = get_device(vid);
if (!dev)
@@ -1344,14 +1345,20 @@ rte_vhost_vring_call(int vid, uint16_t vring_idx)
 
rte_rwlock_read_lock(&vq->access_lock);
 
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
if (vq_is_packed(dev))
vhost_vring_call_packed(dev, vq);
else
vhost_vring_call_split(dev, vq);
 
+out_unlock:
rte_rwlock_read_unlock(&vq->access_lock);
 
-   return 0;
+   return ret;
 }
 
 int
@@ -1359,6 +1366,7 @@ rte_vhost_vring_call_nonblock(int vid, uint16_t vring_idx)
 {
struct virtio_net *dev;
struct vhost_virtqueue *vq;
+   int ret = 0;
 
dev = get_device(vid);
if (!dev)
@@ -1374,14 +1382,20 @@ rte_vhost_vring_call_nonblock(int vid, uint16_t 
vring_idx)
if (rte_rwlock_read_trylock(&vq->access_lock))
return -EAGAIN;
 
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
if (vq_is_packed(dev))
vhost_vring_call_packed(dev, vq);
else
vhost_vring_call_split(dev, vq);
 
+out_unlock:
rte_rwlock_read_unlock(&vq->access_lock);
 
-   return 0;
+   return ret;
 }
 
 uint16_t
-- 
2.41.0

[PATCH v2 0/7] vhost: ensure virtqueue access status is checked

[Maxime Coquelin]

Li Feng initially reported segmentation fault in rte_vhost_vring_call()
because of not checking the virtqueue metadata can be accessed.

This should be achieved by checking the access_ok status field of
the virtqueue.

This series also takes the opportunity to fix the other APIs.
This is split in multiple patches to ease LTS maintainers backports,
but could be squashed if preferred.

Changes in v2:
--
- Rebased to apply on -rc1 (David)
- Add Fixes tag in patch 1 (David)
- Fix various typos in commit logs (David)

Maxime Coquelin (7):
  vhost: fix missing vring call check on virtqueue access
  vhost: fix missing check on virtqueue access
  vhost: fix checking virtqueue access when notifying guest
  vhost: fix check on virtqueue access in async registration
  vhost: fix check on virtqueue access in in-flight getter
  vhost: fix missing lock protection in power monitor API
  vhost: fix checking virtqueue access in stats API

 lib/vhost/vhost.c | 92 +++
 1 file changed, 85 insertions(+), 7 deletions(-)

-- 
2.41.0

[PATCH v2 2/7] vhost: fix missing check on virtqueue access

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: 4e0de8dac853 ("vhost: protect vring access done by application")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 16 ++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 0d2bc1a48b..446bca1574 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1418,7 +1418,10 @@ rte_vhost_avail_entries(int vid, uint16_t queue_id)
 
rte_rwlock_write_lock(&vq->access_lock);
 
-   if (unlikely(!vq->enabled || vq->avail == NULL))
+   if (unlikely(!vq->access_ok))
+   goto out;
+
+   if (unlikely(!vq->enabled))
goto out;
 
ret = *(volatile uint16_t *)&vq->avail->idx - vq->last_used_idx;
@@ -1510,9 +1513,15 @@ rte_vhost_enable_guest_notification(int vid, uint16_t 
queue_id, int enable)
 
rte_rwlock_write_lock(&vq->access_lock);
 
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
vq->notif_enable = enable;
ret = vhost_enable_guest_notification(dev, vq, enable);
 
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
return ret;
@@ -1605,7 +1614,10 @@ rte_vhost_rx_queue_count(int vid, uint16_t qid)
 
rte_rwlock_write_lock(&vq->access_lock);
 
-   if (unlikely(!vq->enabled || vq->avail == NULL))
+   if (unlikely(!vq->access_ok))
+   goto out;
+
+   if (unlikely(!vq->enabled))
goto out;
 
ret = *((volatile uint16_t *)&vq->avail->idx) - vq->last_avail_idx;
-- 
2.41.0

[PATCH v2 3/7] vhost: fix checking virtqueue access when notifying guest

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: d761d455a0e4 ("vhost: add operation to offload the interrupt kick")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 446bca1574..5428ff4a25 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1542,6 +1542,9 @@ rte_vhost_notify_guest(int vid, uint16_t queue_id)
 
rte_rwlock_read_lock(&vq->access_lock);
 
+   if (unlikely(!vq->access_ok))
+   goto out_unlock;
+
__atomic_store_n(&vq->irq_pending, false, __ATOMIC_RELEASE);
 
if (dev->backend_ops->inject_irq(dev, vq)) {
@@ -1556,6 +1559,7 @@ rte_vhost_notify_guest(int vid, uint16_t queue_id)
dev->notify_ops->guest_notified(dev->vid);
}
 
+out_unlock:
rte_rwlock_read_unlock(&vq->access_lock);
 }
 
-- 
2.41.0

[PATCH v2 5/7] vhost: fix check on virtqueue access in in-flight getter

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index ccd3c0e865..a243f88398 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -2073,9 +2073,15 @@ rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
return ret;
}
 
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
if (vq->async)
ret = vq->async->pkts_inflight_n;
 
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
return ret;
-- 
2.41.0

[PATCH v2 7/7] vhost: fix checking virtqueue access in stats API

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: be75dc99ea1f ("vhost: support per-virtqueue statistics")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 21 +++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index d8d74623d4..b03e3b391d 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -2199,6 +2199,7 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
struct virtio_net *dev = get_device(vid);
struct vhost_virtqueue *vq;
unsigned int i;
+   int ret = VHOST_NB_VQ_STATS;
 
if (dev == NULL)
return -1;
@@ -2215,6 +2216,12 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
vq = dev->virtqueue[queue_id];
 
rte_rwlock_write_lock(&vq->access_lock);
+
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
for (i = 0; i < VHOST_NB_VQ_STATS; i++) {
/*
 * No need to the read atomic counters as such, due to the
@@ -2224,15 +2231,18 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
*(uint64_t *)(((char *)vq) + 
vhost_vq_stat_strings[i].offset);
stats[i].id = i;
}
+
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
-   return VHOST_NB_VQ_STATS;
+   return ret;
 }
 
 int rte_vhost_vring_stats_reset(int vid, uint16_t queue_id)
 {
struct virtio_net *dev = get_device(vid);
struct vhost_virtqueue *vq;
+   int ret = 0;
 
if (dev == NULL)
return -1;
@@ -2246,14 +2256,21 @@ int rte_vhost_vring_stats_reset(int vid, uint16_t 
queue_id)
vq = dev->virtqueue[queue_id];
 
rte_rwlock_write_lock(&vq->access_lock);
+
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
/*
 * No need to the reset atomic counters as such, due to the
 * above write access_lock preventing them to be updated.
 */
memset(&vq->stats, 0, sizeof(vq->stats));
+
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
-   return 0;
+   return ret;
 }
 
 int
-- 
2.41.0

[PATCH v2 4/7] vhost: fix check on virtqueue access in async registration

[Maxime Coquelin]

Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.

The access status must also be checked.

Fixes: 78639d54563a ("vhost: introduce async enqueue registration API")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 5428ff4a25..ccd3c0e865 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -1857,7 +1857,15 @@ rte_vhost_async_channel_register(int vid, uint16_t 
queue_id)
return -1;
 
rte_rwlock_write_lock(&vq->access_lock);
+
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
ret = async_channel_register(dev, vq);
+
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
return ret;
@@ -1909,6 +1917,11 @@ rte_vhost_async_channel_unregister(int vid, uint16_t 
queue_id)
return ret;
}
 
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
if (!vq->async) {
ret = 0;
} else if (vq->async->pkts_inflight_n) {
@@ -1920,6 +1933,7 @@ rte_vhost_async_channel_unregister(int vid, uint16_t 
queue_id)
ret = 0;
}
 
+out_unlock:
rte_rwlock_write_unlock(&vq->access_lock);
 
return ret;
-- 
2.41.0

[PATCH v2 6/7] vhost: fix missing lock protection in power monitor API

[Maxime Coquelin]

The power monitor get API is missing both access lock
protection and access status check.

Fixes: 34fd4373ce76 ("vhost: add power monitor API")
Cc: sta...@dpdk.org

Signed-off-by: Maxime Coquelin 
---
 lib/vhost/vhost.c | 13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index a243f88398..d8d74623d4 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -2121,6 +2121,7 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
 {
struct virtio_net *dev = get_device(vid);
struct vhost_virtqueue *vq;
+   int ret = 0;
 
if (dev == NULL)
return -1;
@@ -2131,6 +2132,13 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
if (vq == NULL)
return -1;
 
+   rte_rwlock_read_lock(&vq->access_lock);
+
+   if (unlikely(!vq->access_ok)) {
+   ret = -1;
+   goto out_unlock;
+   }
+
if (vq_is_packed(dev)) {
struct vring_packed_desc *desc;
desc = vq->desc_packed;
@@ -2150,7 +2158,10 @@ rte_vhost_get_monitor_addr(int vid, uint16_t queue_id,
pmc->match = 0;
}
 
-   return 0;
+out_unlock:
+   rte_rwlock_read_unlock(&vq->access_lock);
+
+   return ret;
 }
 
 
-- 
2.41.0

[PATCH] maintainers: update email address

[Chenbo Xia]

I left Intel and joined Nvidia, so update my email address.

Signed-off-by: Chenbo Xia 
---
 .mailmap|  2 +-
 MAINTAINERS | 12 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..2ff31b008f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -213,7 +213,7 @@ Charles Brett 
 Charles Myers 
 Charles Stoll 
 Chas Williams <3ch...@gmail.com>  
-Chenbo Xia 
+Chenbo Xia 
 Chengchang Tang  
 Chengfeng Ye 
 Chenghu Yao 
diff --git a/MAINTAINERS b/MAINTAINERS
index 4083658697..b1c9495a00 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -50,7 +50,7 @@ T: git://dpdk.org/next/dpdk-next-net-mlx
 
 Next-virtio Tree
 M: Maxime Coquelin 
-M: Chenbo Xia 
+M: Chenbo Xia 
 T: git://dpdk.org/next/dpdk-next-virtio
 
 Next-crypto Tree
@@ -594,7 +594,7 @@ F: drivers/bus/dpaa/
 F: drivers/bus/fslmc/
 
 PCI bus driver
-M: Chenbo Xia 
+M: Chenbo Xia 
 M: Nipun Gupta 
 F: drivers/bus/pci/
 
@@ -983,7 +983,7 @@ F: doc/guides/nics/features/vmxnet3.ini
 
 Vhost-user
 M: Maxime Coquelin 
-M: Chenbo Xia 
+M: Chenbo Xia 
 T: git://dpdk.org/next/dpdk-next-virtio
 F: lib/vhost/
 F: doc/guides/prog_guide/vhost_lib.rst
@@ -997,7 +997,7 @@ F: doc/guides/sample_app_ug/vdpa.rst
 
 Vhost PMD
 M: Maxime Coquelin 
-M: Chenbo Xia 
+M: Chenbo Xia 
 T: git://dpdk.org/next/dpdk-next-virtio
 F: drivers/net/vhost/
 F: doc/guides/nics/vhost.rst
@@ -1005,7 +1005,7 @@ F: doc/guides/nics/features/vhost.ini
 
 Virtio PMD
 M: Maxime Coquelin 
-M: Chenbo Xia 
+M: Chenbo Xia 
 T: git://dpdk.org/next/dpdk-next-virtio
 F: drivers/net/virtio/
 F: doc/guides/nics/virtio.rst
@@ -1661,7 +1661,7 @@ F: app/test/test_rcu*
 F: doc/guides/prog_guide/rcu_lib.rst
 
 PCI
-M: Chenbo Xia 
+M: Chenbo Xia 
 M: Gaetan Rivet 
 F: lib/pci/
 
-- 
2.39.3 (Apple Git-145)

Re: [PATCH] net/virtio: fix the setting of the vector for link state interrupt

[Maxime Coquelin]

Hi Wenwu,

Please reword the commit title to something:
net/virtio: fix link state interrupt vector setting

On 8/7/23 05:15, Wenwu Ma wrote:

The settings of the vector for link state interrupts
should be done before the initialization of the device
is completed.

Fixes: ee85024cf5f7 ("net/virtio: complete init stage at the right place")
Cc: sta...@dpdk.org

Signed-off-by: Wenwu Ma 
---
  drivers/net/virtio/virtio_ethdev.c | 16 
  1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.c 
b/drivers/net/virtio/virtio_ethdev.c
index 2c23f1c00e..1801b0ae47 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1912,6 +1912,14 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t 
req_features)
}
}
  
+	if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)

+   /* Enable vector (0) for Link State Interrupt */
+   if (VIRTIO_OPS(hw)->set_config_irq(hw, 0) ==
+   VIRTIO_MSI_NO_VECTOR) {
+   PMD_DRV_LOG(ERR, "failed to set config vector");
+   return -EBUSY;
+   }
+
virtio_reinit_complete(hw);
  
  	return 0;

@@ -2237,14 +2245,6 @@ virtio_dev_configure(struct rte_eth_dev *dev)
hw->has_tx_offload = tx_offload_enabled(hw);
hw->has_rx_offload = rx_offload_enabled(hw);
  
-	if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)

-   /* Enable vector (0) for Link State Interrupt */
-   if (VIRTIO_OPS(hw)->set_config_irq(hw, 0) ==
-   VIRTIO_MSI_NO_VECTOR) {
-   PMD_DRV_LOG(ERR, "failed to set config vector");
-   return -EBUSY;
-   }
-
if (virtio_with_packed_queue(hw)) {
  #if defined(RTE_ARCH_X86_64) && defined(CC_AVX512_SUPPORT)
if ((hw->use_vec_rx || hw->use_vec_tx) &&


It looks good to me, so I can change the title myself while applying if
Ok for you.

Reviewed-by: Maxime Coquelin 

By the way, can you tell me with which backends have you tested it with?
Only Virtio-PCI? Or also Virtio-user?

Thanks,
Maxime

Re: [PATCH] maintainers: update email address

[Maxime Coquelin]

On 10/20/23 10:51, Chenbo Xia wrote:

I left Intel and joined Nvidia, so update my email address.

Signed-off-by: Chenbo Xia 
---
  .mailmap|  2 +-
  MAINTAINERS | 12 ++--
  2 files changed, 7 insertions(+), 7 deletions(-)



Welcime back Chenbo :)

Acked-by: Maxime Coquelin 

Maxime

Re: [PATCH v2 16/29] power: remove experimental from API's

[Hunt, David]

On 09/08/2023 01:10, Stephen Hemminger wrote:

The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.

Signed-off-by: Stephen Hemminger 
---


Acked-by: David Hunt

Re: [PATCH v4 16/28] power: remove experimental from API's

[Hunt, David]

On 19/10/2023 20:10, Stephen Hemminger wrote:

The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.

Signed-off-by: Stephen Hemminger 
---


Acked-by: David Hunt

[PATCH v2 3/7] net/bnxt: fix race-condition when report error recovery

[Chengwen Feng]

If set data path functions to dummy functions before reports error
recovering event, there maybe a race-condition with data path threads,
this patch fixes it by setting data path functions to dummy functions
only after reports such event.

Fixes: e11052f3a46f ("net/bnxt: support proactive error handling mode")
Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng 
Acked-by: Konstantin Ananyev 
---
 drivers/net/bnxt/bnxt_cpr.c| 13 +++--
 drivers/net/bnxt/bnxt_ethdev.c |  4 ++--
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index 0733cf4df2..d8947d5b5f 100644
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/drivers/net/bnxt/bnxt_cpr.c
@@ -168,14 +168,9 @@ void bnxt_handle_async_event(struct bnxt *bp,
PMD_DRV_LOG(INFO, "Port conn async event\n");
break;
case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY:
-   /*
-* Avoid any rx/tx packet processing during firmware reset
-* operation.
-*/
-   bnxt_stop_rxtx(bp->eth_dev);
-
/* Ignore reset notify async events when stopping the port */
if (!bp->eth_dev->data->dev_started) {
+   bnxt_stop_rxtx(bp->eth_dev);
bp->flags |= BNXT_FLAG_FATAL_ERROR;
return;
}
@@ -184,6 +179,12 @@ void bnxt_handle_async_event(struct bnxt *bp,
 RTE_ETH_EVENT_ERR_RECOVERING,
 NULL);
 
+   /*
+* Avoid any rx/tx packet processing during firmware reset
+* operation.
+*/
+   bnxt_stop_rxtx(bp->eth_dev);
+
pthread_mutex_lock(&bp->err_recovery_lock);
event_data = data1;
/* timestamp_lo/hi values are in units of 100ms */
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 5c4d96d4b1..003a6eec11 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4616,14 +4616,14 @@ static void bnxt_check_fw_health(void *arg)
bp->flags |= BNXT_FLAG_FATAL_ERROR;
bp->flags |= BNXT_FLAG_FW_RESET;
 
-   bnxt_stop_rxtx(bp->eth_dev);
-
PMD_DRV_LOG(ERR, "Detected FW dead condition\n");
 
rte_eth_dev_callback_process(bp->eth_dev,
 RTE_ETH_EVENT_ERR_RECOVERING,
 NULL);
 
+   bnxt_stop_rxtx(bp->eth_dev);
+
if (bnxt_is_primary_func(bp))
wait_msec = info->primary_func_wait_period;
else
-- 
2.17.1

[PATCH v2 1/7] ethdev: fix race-condition of proactive error handling mode

[Chengwen Feng]

In the proactive error handling mode, the PMD will set the data path
pointers to dummy functions and then try recovery, in this period the
application may still invoking data path API. This will introduce a
race-condition with data path which may lead to crash [1].

Although the PMD added delay after setting data path pointers to cover
the above race-condition, it reduces the probability, but it doesn't
solve the problem.

To solve the race-condition problem fundamentally, the following
requirements are added:
1. The PMD should set the data path pointers to dummy functions after
   report RTE_ETH_EVENT_ERR_RECOVERING event.
2. The application should stop data path API invocation when process
   the RTE_ETH_EVENT_ERR_RECOVERING event.
3. The PMD should set the data path pointers to valid functions before
   report RTE_ETH_EVENT_RECOVERY_SUCCESS event.
4. The application should enable data path API invocation when process
   the RTE_ETH_EVENT_RECOVERY_SUCCESS event.

Also, this patch introduce a driver internal function
rte_eth_fp_ops_setup which used as an help function for PMD.

[1] 
http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/

Fixes: eb0d471a8941 ("ethdev: add proactive error handling mode")
Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng 
Acked-by: Konstantin Ananyev 
---
 doc/guides/prog_guide/poll_mode_drv.rst | 20 +++-
 lib/ethdev/ethdev_driver.c  |  8 +++
 lib/ethdev/ethdev_driver.h  | 10 
 lib/ethdev/rte_ethdev.h | 32 +++--
 lib/ethdev/version.map  |  1 +
 5 files changed, 46 insertions(+), 25 deletions(-)

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index c145a9066c..e380ff135a 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -638,14 +638,9 @@ different from the application invokes recovery in PASSIVE 
mode,
 the PMD automatically recovers from error in PROACTIVE mode,
 and only a small amount of work is required for the application.
 
-During error detection and automatic recovery,
-the PMD sets the data path pointers to dummy functions
-(which will prevent the crash),
-and also make sure the control path operations fail with a return code 
``-EBUSY``.
-
-Because the PMD recovers automatically,
-the application can only sense that the data flow is disconnected for a while
-and the control API returns an error in this period.
+During error detection and automatic recovery, the PMD sets the data path
+pointers to dummy functions and also make sure the control path operations
+failed with a return code ``-EBUSY``.
 
 In order to sense the error happening/recovering,
 as well as to restore some additional configuration,
@@ -653,9 +648,9 @@ three events are available:
 
 ``RTE_ETH_EVENT_ERR_RECOVERING``
Notify the application that an error is detected
-   and the recovery is being started.
+   and the recovery is about to start.
Upon receiving the event, the application should not invoke
-   any control path function until receiving
+   any control and data path API until receiving
``RTE_ETH_EVENT_RECOVERY_SUCCESS`` or ``RTE_ETH_EVENT_RECOVERY_FAILED`` 
event.
 
 .. note::
@@ -666,8 +661,9 @@ three events are available:
 
 ``RTE_ETH_EVENT_RECOVERY_SUCCESS``
Notify the application that the recovery from error is successful,
-   the PMD already re-configures the port,
-   and the effect is the same as a restart operation.
+   the PMD already re-configures the port.
+   The application should restore some additional configuration, and then
+   enable data path API invocation.
 
 ``RTE_ETH_EVENT_RECOVERY_FAILED``
Notify the application that the recovery from error failed,
diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c
index fff4b7b4cd..65ead7b910 100644
--- a/lib/ethdev/ethdev_driver.c
+++ b/lib/ethdev/ethdev_driver.c
@@ -537,6 +537,14 @@ rte_eth_dma_zone_free(const struct rte_eth_dev *dev, const 
char *ring_name,
return rc;
 }
 
+void
+rte_eth_fp_ops_setup(struct rte_eth_dev *dev)
+{
+   if (dev == NULL)
+   return;
+   eth_dev_fp_ops_setup(rte_eth_fp_ops + dev->data->port_id, dev);
+}
+
 const struct rte_memzone *
 rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,
 uint16_t queue_id, size_t size, unsigned int align,
diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
index deb23ada18..8567b96f53 100644
--- a/lib/ethdev/ethdev_driver.h
+++ b/lib/ethdev/ethdev_driver.h
@@ -1636,6 +1636,16 @@ int
 rte_eth_dma_zone_free(const struct rte_eth_dev *eth_dev, const char *name,
 uint16_t queue_id);
 
+/**
+ * @internal
+ * Setup eth fast-path API to ethdev values.
+ *
+ * @param dev
+ *  Pointer to struct rte_eth_dev.
+ */
+__rte_internal
+void rte_eth_fp_ops_setup(struct rte_eth_dev *dev);
+
 /**
  * @inte

[PATCH v2 2/7] net/hns3: replace fp ops config function

[Chengwen Feng]

This patch replace hns3_eth_dev_fp_ops_config() with
rte_eth_fp_ops_setup().

Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng 
Acked-by: Dongdong Liu 
---
 drivers/net/hns3/hns3_rxtx.c | 21 +++--
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index f3c3b38c55..f43f1eb9ad 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -4434,21 +4434,6 @@ hns3_trace_rxtx_function(struct rte_eth_dev *dev)
 rx_mode.info, tx_mode.info);
 }
 
-static void
-hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev)
-{
-   struct rte_eth_fp_ops *fpo = rte_eth_fp_ops;
-   uint16_t port_id = dev->data->port_id;
-
-   fpo[port_id].rx_pkt_burst = dev->rx_pkt_burst;
-   fpo[port_id].tx_pkt_burst = dev->tx_pkt_burst;
-   fpo[port_id].tx_pkt_prepare = dev->tx_pkt_prepare;
-   fpo[port_id].rx_descriptor_status = dev->rx_descriptor_status;
-   fpo[port_id].tx_descriptor_status = dev->tx_descriptor_status;
-   fpo[port_id].rxq.data = dev->data->rx_queues;
-   fpo[port_id].txq.data = dev->data->tx_queues;
-}
-
 void
 hns3_set_rxtx_function(struct rte_eth_dev *eth_dev)
 {
@@ -4471,7 +4456,7 @@ hns3_set_rxtx_function(struct rte_eth_dev *eth_dev)
}
 
hns3_trace_rxtx_function(eth_dev);
-   hns3_eth_dev_fp_ops_config(eth_dev);
+   rte_eth_fp_ops_setup(eth_dev);
 }
 
 void
@@ -4824,7 +4809,7 @@ hns3_stop_tx_datapath(struct rte_eth_dev *dev)
 {
dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
dev->tx_pkt_prepare = NULL;
-   hns3_eth_dev_fp_ops_config(dev);
+   rte_eth_fp_ops_setup(dev);
 
if (rte_eal_process_type() == RTE_PROC_SECONDARY)
return;
@@ -4841,7 +4826,7 @@ hns3_start_tx_datapath(struct rte_eth_dev *dev)
 {
dev->tx_pkt_burst = hns3_get_tx_function(dev);
dev->tx_pkt_prepare = hns3_get_tx_prepare(dev);
-   hns3_eth_dev_fp_ops_config(dev);
+   rte_eth_fp_ops_setup(dev);
 
if (rte_eal_process_type() == RTE_PROC_SECONDARY)
return;
-- 
2.17.1

[PATCH v2 4/7] net/bnxt: use fp ops setup function

[Chengwen Feng]

Use rte_eth_fp_ops_setup() instead of directly manipulating
rte_eth_fp_ops variable.

Cc: sta...@dpdk.org

Signed-off-by: Chengwen Feng 
---
 drivers/net/bnxt/bnxt_cpr.c| 5 +
 drivers/net/bnxt/bnxt_ethdev.c | 5 +
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index d8947d5b5f..3a08028331 100644
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/drivers/net/bnxt/bnxt_cpr.c
@@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev)
eth_dev->rx_pkt_burst = rte_eth_pkt_burst_dummy;
eth_dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
 
-   rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =
-   eth_dev->rx_pkt_burst;
-   rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =
-   eth_dev->tx_pkt_burst;
+   rte_eth_fp_ops_setup(eth_dev);
rte_mb();
 
/* Allow time for threads to exit the real burst functions. */
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 003a6eec11..9d9b9ae8cf 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4428,10 +4428,7 @@ static void bnxt_dev_recover(void *arg)
if (rc)
goto err_start;
 
-   rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =
-   bp->eth_dev->rx_pkt_burst;
-   rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =
-   bp->eth_dev->tx_pkt_burst;
+   rte_eth_fp_ops_setup(bp->eth_dev);
rte_mb();
 
PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n",
-- 
2.17.1

[PATCH v2 5/7] app/testpmd: add error recovery usage demo

[Chengwen Feng]

This patch adds error recovery usage demo which will:
1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event
   is received.
2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS
   event is received.
3. prompt the ports that fail to recovery and need to be removed when
   the RTE_ETH_EVENT_RECOVERY_FAILED event is received.

In addition, a message is added to the printed information, requiring
no command to be executed during the error recovery.

Signed-off-by: Chengwen Feng 
Acked-by: Konstantin Ananyev 
---
 app/test-pmd/testpmd.c | 80 ++
 app/test-pmd/testpmd.h |  4 ++-
 2 files changed, 83 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 595b77748c..39a25238e5 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3942,6 +3942,77 @@ rmv_port_callback(void *arg)
start_packet_forwarding(0);
 }
 
+static int need_start_when_recovery_over;
+
+static bool
+has_port_in_err_recovering(void)
+{
+   struct rte_port *port;
+   portid_t pid;
+
+   RTE_ETH_FOREACH_DEV(pid) {
+   port = &ports[pid];
+   if (port->err_recovering)
+   return true;
+   }
+
+   return false;
+}
+
+static void
+err_recovering_callback(portid_t port_id)
+{
+   if (!has_port_in_err_recovering())
+   printf("Please stop executing any commands until recovery 
result events are received!\n");
+
+   ports[port_id].err_recovering = 1;
+   ports[port_id].recover_failed = 0;
+
+   /* To simplify implementation, stop forwarding regardless of whether 
the port is used. */
+   if (!test_done) {
+   printf("Stop packet forwarding because some ports are in error 
recovering!\n");
+   stop_packet_forwarding();
+   need_start_when_recovery_over = 1;
+   }
+}
+
+static void
+recover_success_callback(portid_t port_id)
+{
+   ports[port_id].err_recovering = 0;
+   if (has_port_in_err_recovering())
+   return;
+
+   if (need_start_when_recovery_over) {
+   printf("Recovery success! Restart packet forwarding!\n");
+   start_packet_forwarding(0);
+   need_start_when_recovery_over = 0;
+   } else {
+   printf("Recovery success!\n");
+   }
+}
+
+static void
+recover_failed_callback(portid_t port_id)
+{
+   struct rte_port *port;
+   portid_t pid;
+
+   ports[port_id].err_recovering = 0;
+   ports[port_id].recover_failed = 1;
+   if (has_port_in_err_recovering())
+   return;
+
+   need_start_when_recovery_over = 0;
+   printf("The ports:");
+   RTE_ETH_FOREACH_DEV(pid) {
+   port = &ports[pid];
+   if (port->recover_failed)
+   printf(" %u", pid);
+   }
+   printf(" recovery failed! Please remove them!\n");
+}
+
 /* This function is used by the interrupt thread */
 static int
 eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
@@ -3997,6 +4068,15 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
}
break;
}
+   case RTE_ETH_EVENT_ERR_RECOVERING:
+   err_recovering_callback(port_id);
+   break;
+   case RTE_ETH_EVENT_RECOVERY_SUCCESS:
+   recover_success_callback(port_id);
+   break;
+   case RTE_ETH_EVENT_RECOVERY_FAILED:
+   recover_failed_callback(port_id);
+   break;
default:
break;
}
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 09a36b90b8..42782d5a05 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -342,7 +342,9 @@ struct rte_port {
uint8_t member_flag : 1, /**< bonding member port */
bond_flag : 1, /**< port is bond device */
fwd_mac_swap : 1, /**< swap packet MAC before 
forward */
-   update_conf : 1; /**< need to update bonding 
device configuration */
+   update_conf : 1, /**< need to update bonding 
device configuration */
+   err_recovering : 1, /**< port is in error 
recovering */
+   recover_failed : 1; /**< port recover failed */
struct port_template*pattern_templ_list; /**< Pattern templates. */
struct port_template*actions_templ_list; /**< Actions templates. */
struct port_table   *table_list; /**< Flow tables. */
-- 
2.17.1

[PATCH v2 6/7] app/testpmd: extract event handling to event.c

[Chengwen Feng]

This patch extract event handling (including eth-event and dev-event)
to a new file 'event.c'.

Signed-off-by: Chengwen Feng 
---
 app/test-pmd/event.c  | 390 ++
 app/test-pmd/meson.build  |   1 +
 app/test-pmd/parameters.c |  36 +---
 app/test-pmd/testpmd.c| 327 +---
 app/test-pmd/testpmd.h|   6 +
 5 files changed, 407 insertions(+), 353 deletions(-)
 create mode 100644 app/test-pmd/event.c

diff --git a/app/test-pmd/event.c b/app/test-pmd/event.c
new file mode 100644
index 00..8393e105d7
--- /dev/null
+++ b/app/test-pmd/event.c
@@ -0,0 +1,390 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 HiSilicon Limited
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#ifdef RTE_NET_MLX5
+#include "mlx5_testpmd.h"
+#endif
+
+#include "testpmd.h"
+
+/* Pretty printing of ethdev events */
+static const char * const eth_event_desc[] = {
+   [RTE_ETH_EVENT_UNKNOWN] = "unknown",
+   [RTE_ETH_EVENT_INTR_LSC] = "link state change",
+   [RTE_ETH_EVENT_QUEUE_STATE] = "queue state",
+   [RTE_ETH_EVENT_INTR_RESET] = "reset",
+   [RTE_ETH_EVENT_VF_MBOX] = "VF mbox",
+   [RTE_ETH_EVENT_IPSEC] = "IPsec",
+   [RTE_ETH_EVENT_MACSEC] = "MACsec",
+   [RTE_ETH_EVENT_INTR_RMV] = "device removal",
+   [RTE_ETH_EVENT_NEW] = "device probed",
+   [RTE_ETH_EVENT_DESTROY] = "device released",
+   [RTE_ETH_EVENT_FLOW_AGED] = "flow aged",
+   [RTE_ETH_EVENT_RX_AVAIL_THRESH] = "RxQ available descriptors threshold 
reached",
+   [RTE_ETH_EVENT_ERR_RECOVERING] = "error recovering",
+   [RTE_ETH_EVENT_RECOVERY_SUCCESS] = "error recovery successful",
+   [RTE_ETH_EVENT_RECOVERY_FAILED] = "error recovery failed",
+   [RTE_ETH_EVENT_MAX] = NULL,
+};
+
+/*
+ * Display or mask ether events
+ * Default to all events except VF_MBOX
+ */
+uint32_t event_print_mask = (UINT32_C(1) << RTE_ETH_EVENT_UNKNOWN) |
+   (UINT32_C(1) << RTE_ETH_EVENT_INTR_LSC) |
+   (UINT32_C(1) << RTE_ETH_EVENT_QUEUE_STATE) |
+   (UINT32_C(1) << RTE_ETH_EVENT_INTR_RESET) |
+   (UINT32_C(1) << RTE_ETH_EVENT_IPSEC) |
+   (UINT32_C(1) << RTE_ETH_EVENT_MACSEC) |
+   (UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV) |
+   (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED) |
+   (UINT32_C(1) << RTE_ETH_EVENT_ERR_RECOVERING) |
+   (UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_SUCCESS) |
+   (UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_FAILED);
+
+int
+get_event_name_mask(const char *name, uint32_t *mask)
+{
+   if (!strcmp(name, "unknown"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_UNKNOWN;
+   else if (!strcmp(name, "intr_lsc"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_INTR_LSC;
+   else if (!strcmp(name, "queue_state"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_QUEUE_STATE;
+   else if (!strcmp(name, "intr_reset"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_INTR_RESET;
+   else if (!strcmp(name, "vf_mbox"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_VF_MBOX;
+   else if (!strcmp(name, "ipsec"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_IPSEC;
+   else if (!strcmp(name, "macsec"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_MACSEC;
+   else if (!strcmp(name, "intr_rmv"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV;
+   else if (!strcmp(name, "dev_probed"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_NEW;
+   else if (!strcmp(name, "dev_released"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_DESTROY;
+   else if (!strcmp(name, "flow_aged"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED;
+   else if (!strcmp(name, "err_recovering"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_ERR_RECOVERING;
+   else if (!strcmp(name, "recovery_success"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_SUCCESS;
+   else if (!strcmp(name, "recovery_failed"))
+   *mask = UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_FAILED;
+   else if (!strcmp(name, "all"))
+   *mask = ~UINT32_C(0);
+   else
+   return -1;
+
+   return 0;
+}
+
+static void
+rmv_port_callback(void *arg)
+{
+   int need_to_start = 0;
+   int org_no_link_check = no_link_check;
+   portid_t port_id = (intptr_t)arg;
+   struct rte_eth_dev_info dev_info;
+   int ret;
+
+   RTE_ETH_VALID_PORTID_OR_RET(port_id);
+
+   if (!test_done && port_is_forwarding(port_id)) {
+   need_to_start = 1;
+   stop_packet_forwarding();
+   }
+   no_link_check = 1;
+   stop_port(port_id);
+   no_link_check = org_no_link_check;
+
+   ret = eth_dev_info_get_print_err(port_id,

[PATCH v2 7/7] doc: testpmd support event handling section

[Chengwen Feng]

Add new section of event handling, which documented the ethdev and
device events.

Signed-off-by: Chengwen Feng 
---
 doc/guides/testpmd_app_ug/event_handling.rst | 80 
 doc/guides/testpmd_app_ug/index.rst  |  1 +
 2 files changed, 81 insertions(+)
 create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst

diff --git a/doc/guides/testpmd_app_ug/event_handling.rst 
b/doc/guides/testpmd_app_ug/event_handling.rst
new file mode 100644
index 00..c116753ad0
--- /dev/null
+++ b/doc/guides/testpmd_app_ug/event_handling.rst
@@ -0,0 +1,80 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2023 HiSilicon Limited.
+
+Event Handling
+==
+
+The ``testpmd`` application supports following two type event handling:
+
+ethdev events
+-
+
+The ``testpmd`` provide options "--print-event" and "--mask-event" to control
+whether display such as "Port x y event" when received "y" event on port "x".
+This is named as default processing.
+
+This section details the support events, unless otherwise specified, only the
+default processing is support.
+
+- ``RTE_ETH_EVENT_INTR_LSC``:
+  If device started with lsc enabled, the PMD will launch this event when it
+  detect link status changes.
+
+- ``RTE_ETH_EVENT_QUEUE_STATE``:
+  Used only within vhost PMD to report vring whether enabled.
+
+- ``RTE_ETH_EVENT_INTR_RESET``:
+  Used to report reset interrupt happened, this event only reported when the
+  PMD supports ``RTE_ETH_ERROR_HANDLE_MODE_PASSIVE``.
+
+- ``RTE_ETH_EVENT_VF_MBOX``:
+  Used as a PF to process mailbox messages of the VFs to which the PF belongs.
+
+- ``RTE_ETH_EVENT_INTR_RMV``:
+  Used to report device removal event. The ``testpmd`` will remove the port
+  later.
+
+- ``RTE_ETH_EVENT_NEW``:
+  Used to report port was probed event. The ``testpmd`` will setup the port
+  later.
+
+- ``RTE_ETH_EVENT_DESTROY``:
+  Used to report port was released event. The ``testpmd`` will changes the
+  port's status.
+
+- ``RTE_ETH_EVENT_MACSEC``:
+  Used to report MACsec offload related event.
+
+- ``RTE_ETH_EVENT_IPSEC``:
+  Used to report IPsec offload related event.
+
+- ``RTE_ETH_EVENT_FLOW_AGED``:
+  Used to report new aged-out flows was detected. Only valid with mlx5 PMD.
+
+- ``RTE_ETH_EVENT_RX_AVAIL_THRESH``:
+  Used to report available Rx descriptors was smaller than the threshold. Only
+  valid with mlx5 PMD.
+
+- ``RTE_ETH_EVENT_ERR_RECOVERING``:
+  Used to report error happened, and PMD will do recover after report this
+  event. The ``testpmd`` will stop packet forwarding when received the event.
+
+- ``RTE_ETH_EVENT_RECOVERY_SUCCESS``:
+  Used to report error recovery success. The ``testpmd`` will restart packet
+  forwarding when received the event.
+
+- ``RTE_ETH_EVENT_RECOVERY_FAILED``:
+  Used to report error recovery failed. The ``testpmd`` will display one
+  message to show which ports failed.
+
+.. note::
+
+   The ``RTE_ETH_EVENT_ERR_RECOVERING``, ``RTE_ETH_EVENT_RECOVERY_SUCCESS`` and
+   ``RTE_ETH_EVENT_RECOVERY_FAILED`` only reported when the PMD supports
+   ``RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE``.
+
+device events
+-
+
+Including two events ``RTE_DEV_EVENT_ADD`` and ``RTE_DEV_EVENT_ADD``, and
+enabled only when the ``testpmd`` stated with options "--hot-plug".
diff --git a/doc/guides/testpmd_app_ug/index.rst 
b/doc/guides/testpmd_app_ug/index.rst
index 1ac0d25d57..3c09448c4e 100644
--- a/doc/guides/testpmd_app_ug/index.rst
+++ b/doc/guides/testpmd_app_ug/index.rst
@@ -14,3 +14,4 @@ Testpmd Application User Guide
 build_app
 run_app
 testpmd_funcs
+event_handling
-- 
2.17.1

[PATCH v2 0/7] fix race-condition of proactive error handling mode

[Chengwen Feng]

This patch fixes race-condition of proactive error handling mode, the
discussion thread [1].

[1] 
http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/

Chengwen Feng (7):
  ethdev: fix race-condition of proactive error handling mode
  net/hns3: replace fp ops config function
  net/bnxt: fix race-condition when report error recovery
  net/bnxt: use fp ops setup function
  app/testpmd: add error recovery usage demo
  app/testpmd: extract event handling to event.c
  doc: testpmd support event handling section

---
v2: 
- extract event handling to event.c and document it, which address
  Ferruh's comment.
- add ack-by from Konstantin Ananyev and Dongdong Liu.

 app/test-pmd/event.c | 390 +++
 app/test-pmd/meson.build |   1 +
 app/test-pmd/parameters.c|  36 +-
 app/test-pmd/testpmd.c   | 247 +---
 app/test-pmd/testpmd.h   |  10 +-
 doc/guides/prog_guide/poll_mode_drv.rst  |  20 +-
 doc/guides/testpmd_app_ug/event_handling.rst |  80 
 doc/guides/testpmd_app_ug/index.rst  |   1 +
 drivers/net/bnxt/bnxt_cpr.c  |  18 +-
 drivers/net/bnxt/bnxt_ethdev.c   |   9 +-
 drivers/net/hns3/hns3_rxtx.c |  21 +-
 lib/ethdev/ethdev_driver.c   |   8 +
 lib/ethdev/ethdev_driver.h   |  10 +
 lib/ethdev/rte_ethdev.h  |  32 +-
 lib/ethdev/version.map   |   1 +
 15 files changed, 551 insertions(+), 333 deletions(-)
 create mode 100644 app/test-pmd/event.c
 create mode 100644 doc/guides/testpmd_app_ug/event_handling.rst

-- 
2.17.1

RE: [PATCH v4 28/28] port: make API's stable

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Dumitrescu,
> Cristian 
> Subject: [PATCH v4 28/28] port: make API's stable
> 
> Follow the guidelines already in deprecation.rst and
> make the API's stable, even though they are marked as deprecated.
> 
> Note: this library never properly marked its experimental API's.
> The API's were in the EXPERIMENTAL section but the macro
> __rte_experimental was missing.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  doc/guides/rel_notes/deprecation.rst |   4 -
>  lib/pipeline/rte_port_in_action.h|   8 --
>  lib/pipeline/rte_swx_ctl.h   |  57 ---
>  lib/pipeline/rte_swx_pipeline.h  |  29 --
>  lib/pipeline/rte_table_action.h  |  16 ---
>  lib/pipeline/version.map | 140 ---
>  lib/port/version.map |  24 ++---
>  7 files changed, 69 insertions(+), 209 deletions(-)
> 

NAK.

As the deprecation notice states, the old API is planned for removal:
https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n135

As discussed before, it is bad practice to mark as stable API that is planned 
for removal.

RE: [PATCH v4 27/28] table: remove experimental from API

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Dumitrescu,
> Cristian 
> Subject: [PATCH v4 27/28] table: remove experimental from API
> 
> Though this library is marked for deprecation in future.
> This patch follows the guideline in deprecation notice which
> states the experimental API's will become stable.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  doc/guides/rel_notes/deprecation.rst |  2 --
>  lib/table/rte_swx_table_learner.h| 10 --
>  lib/table/rte_swx_table_selector.h   |  6 --
>  lib/table/rte_table_hash_func.h  |  9 -
>  lib/table/version.map| 18 ++
>  5 files changed, 2 insertions(+), 43 deletions(-)
> 

NAK.

As the deprecation notice states, the old API is planned for removal:
https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rst#n135

As discussed before, it is bad practice to mark as stable API that is planned 
for removal.

RE: [PATCH v4 15/28] meter: remove experimental warning from comments

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Richardson, Bruce
> ; Dumitrescu, Cristian
> 
> Subject: [PATCH v4 15/28] meter: remove experimental warning from
> comments
> 
> The API's for rte_meter_trtcm were never properly flagged
> as experimental; missing __rte_experimental but there was
> an experimental comment in the docbook comment.
> Remove the comment.
> 
> Signed-off-by: Stephen Hemminger 
> Acked-by: Bruce Richardson 
> ---
>  lib/meter/rte_meter.h | 12 
>  1 file changed, 12 deletions(-)
> 

Acked-by: Cristian Dumitrescu 

RE: [PATCH v4 13/28] sched: remove experimental

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Dumitrescu,
> Cristian 
> Subject: [PATCH v4 13/28] sched: remove experimental
> 
> The overcommit and PIE support was added back in 2020.
> Remove experimental tag.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  lib/sched/rte_pie.h   |  8 
>  lib/sched/rte_sched.h |  5 -
>  lib/sched/version.map | 18 --
>  3 files changed, 4 insertions(+), 27 deletions(-)
> 

Acked-by: Cristian Dumitrescu 

RE: [PATCH v4 04/28] ethdev: mark rte_tm API's as stable

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Thomas Monjalon
> ; Dumitrescu, Cristian
> ; Ferruh Yigit ;
> Andrew Rybchenko 
> Subject: [PATCH v4 04/28] ethdev: mark rte_tm API's as stable
> 
> These API's have been around since 20.11, mark them as not
> experimental.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  MAINTAINERS|  2 +-
>  lib/ethdev/rte_tm.h| 34 ---
>  lib/ethdev/version.map | 62 --
>  3 files changed, 31 insertions(+), 67 deletions(-)
> 

Acked-by: Cristian Dumitrescu 

RE: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable

[Dumitrescu, Cristian]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Thursday, October 19, 2023 8:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Thomas Monjalon
> ; Dumitrescu, Cristian
> ; Ferruh Yigit ;
> Andrew Rybchenko 
> Subject: [PATCH v4 03/28] ethdev: mark rte_mtr API's as stable
> 
> These haven't changed in a while, time has come to make them
> not experimental.
> 
> Signed-off-by: Stephen Hemminger 
> ---

NAK.

This API needs more drivers to use it and more time before transitioning to 
stable.

Re: [PATCH] maintainers: update email address

[David Marchand]

Hi Chenbo,

On Fri, Oct 20, 2023 at 10:52 AM Chenbo Xia  wrote:
>
> I left Intel and joined Nvidia, so update my email address.
>
> Signed-off-by: Chenbo Xia 
> ---
>  .mailmap|  2 +-
>  MAINTAINERS | 12 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index 3f5bab26a8..2ff31b008f 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -213,7 +213,7 @@ Charles Brett 
>  Charles Myers 
>  Charles Stoll 
>  Chas Williams <3ch...@gmail.com>  
> -Chenbo Xia 
> +Chenbo Xia 

Please leave your intel mail address.
Chenbo Xia  

This will help get-maintainers.sh, when copying you about past changes
for example.


-- 
David Marchand

RE: [PATCH v4 06/28] pcapng: mark API's as stable

[Morten Brørup]

> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, 19 October 2023 21.10
> 
> This API was added in 23.11 and can now be marked as not
> experimental.

If they were added in 23.11 they would be brand new.

The same typo is present in other patches in this series.

Coverity components list needs updating

[Morten Brørup]

Lincoln,
CC: DPDK Coverity admins,

Could you please (delegate to someone to) update the list of Components in 
Coverity.
The list uses the obsolete directory names /lib/librte_xyz/ instead of 
/lib/xyz/, and thus the vast majority of code is bundled into the catch-all 
"Other" category. This makes the Coverity metrics overview pretty useless, and 
makes it impossible to filter by component.

Here's a video showing how:
https://community.synopsys.com/s/article/Coverity-Tutorial-Components

NB: I signed up to Coverity to fix this myself, but it seems Admin privileges 
is required, so I can't do it.


Med venlig hilsen / Kind regards,
-Morten Brørup

[PATCH] ethdev: refresh shared memory reference in secondary process

[David Marchand]

In the process of releasing ethdev port in the primary process,
secondary processes are asked to stop referencing such a port.
Doing so, those processes can't predict whether the primary process
will later invalidate/free the shared memory. So they may live with a
reference to an old shared memory memzone and location in memory.

Refresh the shared memory pointer in secondary process when requesting
access to the shared memory: this is the best moment ethdev can check
it because the primary process will (re-)create a shared memory only if
no secondary process is referencing a ethdev port.

Bugzilla ID: 1303
Fixes: 36c46e738120 ("ethdev: cleanup shared data with the last port")

Signed-off-by: David Marchand 
---
 lib/ethdev/ethdev_private.c | 46 -
 1 file changed, 30 insertions(+), 16 deletions(-)

diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c
index 7cc7f28296..a78a66bbfd 100644
--- a/lib/ethdev/ethdev_private.c
+++ b/lib/ethdev/ethdev_private.c
@@ -324,17 +324,18 @@ rte_eth_call_tx_callbacks(uint16_t port_id, uint16_t 
queue_id,
 void *
 eth_dev_shared_data_prepare(void)
 {
-   const unsigned int flags = 0;
const struct rte_memzone *mz;
 
-   if (eth_dev_shared_mz == NULL) {
-   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
-   /* Allocate port data and ownership shared memory. */
-   mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
-   sizeof(*eth_dev_shared_data),
-   rte_socket_id(), flags);
-   } else
-   mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA);
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
+   const unsigned int flags = 0;
+
+   if (eth_dev_shared_mz != NULL)
+   goto out;
+
+   /* Allocate port data and ownership shared memory. */
+   mz = rte_memzone_reserve(MZ_RTE_ETH_DEV_DATA,
+   sizeof(*eth_dev_shared_data),
+   rte_socket_id(), flags);
if (mz == NULL) {
RTE_ETHDEV_LOG(ERR, "Cannot allocate ethdev shared 
data\n");
goto out;
@@ -342,14 +343,27 @@ eth_dev_shared_data_prepare(void)
 
eth_dev_shared_mz = mz;
eth_dev_shared_data = mz->addr;
-   if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
-   eth_dev_shared_data->allocated_owners = 0;
-   eth_dev_shared_data->next_owner_id =
-   RTE_ETH_DEV_NO_OWNER + 1;
-   eth_dev_shared_data->allocated_ports = 0;
-   memset(eth_dev_shared_data->data, 0,
-  sizeof(eth_dev_shared_data->data));
+   eth_dev_shared_data->allocated_owners = 0;
+   eth_dev_shared_data->next_owner_id =
+   RTE_ETH_DEV_NO_OWNER + 1;
+   eth_dev_shared_data->allocated_ports = 0;
+   memset(eth_dev_shared_data->data, 0,
+  sizeof(eth_dev_shared_data->data));
+   } else {
+   mz = rte_memzone_lookup(MZ_RTE_ETH_DEV_DATA);
+   if (mz == NULL) {
+   /* Clean remaining any traces of a previous shared mem 
*/
+   eth_dev_shared_mz = NULL;
+   eth_dev_shared_data = NULL;
+   RTE_ETHDEV_LOG(ERR, "Cannot lookup ethdev shared 
data\n");
+   goto out;
}
+   if (mz == eth_dev_shared_mz && mz->addr == eth_dev_shared_data)
+   goto out;
+
+   /* Shared mem changed in primary process, refresh pointers */
+   eth_dev_shared_mz = mz;
+   eth_dev_shared_data = mz->addr;
}
 out:
return eth_dev_shared_data;
-- 
2.41.0

[PATCH] ethdev: fix incorrect function name in comment

[Bruce Richardson]

For those using the function comments as a guide, provide the name of
the correct callback function to use when wanting to count dropped
packets from the ethdev tx buffering system.

Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 lib/ethdev/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 85b9af7a02..2fd3cd808d 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3732,7 +3732,7 @@ rte_eth_tx_buffer_init(struct rte_eth_dev_tx_buffer 
*buffer, uint16_t size);
  * for example, to count dropped packets, or to retry transmission of packets
  * which cannot be sent, this function should be used to register a suitable
  * callback function to implement the desired behaviour.
- * The example callback "rte_eth_count_unsent_packet_callback()" is also
+ * The example callback "rte_eth_tx_buffer_count_callback()" is also
  * provided as reference.
  *
  * @param buffer
-- 
2.39.2

[PATCH] docs: add note about experimental API in LTS

[Kevin Traynor]

The justification and impact for changing experimental API on LTS
branches is different from the main branch. So the policy that is
being used for allowing experimental APIs to change is stricter on
the LTS branches.

This was not documented anywhere, so add some documentation.

Suggested-by: David Marchand 
Signed-off-by: Kevin Traynor 
---
 doc/guides/contributing/stable.rst | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/contributing/stable.rst 
b/doc/guides/contributing/stable.rst
index 9ee7b4b7cc..8156b72b20 100644
--- a/doc/guides/contributing/stable.rst
+++ b/doc/guides/contributing/stable.rst
@@ -127,4 +127,12 @@ but may be considered in some cases where:
 * An existing feature in LTS is not usable as intended without it.
 
+APIs marked as ``experimental`` are not considered part of the ABI version
+and can be changed without prior notice. This is necessary for the API to be
+improved and stabilized and become part of the ABI version in the future.
+
+However, in LTS releases ``experimental`` API should not be changed as there
+will not be a future ABI version on the branch and compatibility with previous
+release of an LTS version is of the highest importance.
+
 The Stable Mailing List
 ---
-- 
2.41.0

[PATCH] mempool: fix internal function documentation

[Ferruh Yigit]

static function `rte_mempool_do_generic_get()` returns zero on success,
not >=0 as its function comment documents.

Since this function called by public API, the comment causes confusion
on the public API return value.

Fixing the internal function documentation for return value.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Reported-by: Mahesh Adulla 
Signed-off-by: Ferruh Yigit 
---
 .mailmap  | 1 +
 lib/mempool/rte_mempool.h | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 3f5bab26a81f..bfe451980f1c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -836,6 +836,7 @@ Maciej Rabeda 
 Maciej Szwed 
 Madhu Chittim 
 Madhuker Mythri 
+Mahesh Adulla 
 Mahipal Challa 
 Mah Yock Gen 
 Mairtin o Loingsigh 
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index f70bf36080fb..86598bc639e6 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1484,7 +1484,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
  * @param cache
  *   A pointer to a mempool cache structure. May be NULL if not needed.
  * @return
- *   - >=0: Success; number of objects supplied.
+ *   - 0: Success; number of objects supplied.
  *   - <0: Error; code of driver dequeue function.
  */
 static __rte_always_inline int
-- 
2.34.1

Re: [PATCH v4] app/test: add support for skipping tests

[Patrick Robb]

On Mon, Oct 9, 2023 at 4:03 PM Patrick Robb  wrote:

>
>> Hello,
>
> Yes, backporting would be ideal from a CI perspective because without it
> we can't run arm64 testing on LTS tests. But I know there are other
> considerations which also have to be weighed.
>
> David also has a patch[1] which should resolve the underlying issue which
> introduces the failures on the unit test we want to skip. If that patch is
> accepted, and backported, fixing our original problem with unit testing on
> our arm testbeds, that's another solution, at least for this specific unit
> test issue.
>
> It would still be nice to have this feature in case we need it otherwise.
>
> [1]
> https://patches.dpdk.org/project/dpdk/patch/20230821085806.3062613-4-david.march...@redhat.com/
>
> Hi. just to close the loops on this, yes David's aforementioned patch did
resolve the unit test failure which was preventing us from running
fast-tests on our arm64 test beds. But, it is not (yet, at least)
backported for LTS releases.

Even if it were, having Bruce's patch here backported would mean the CI
testing approach could be common across releases in situations where
testcases have to be skipped.

Anyways, whether it's possible or "worth it" is ultimately down to the
community's bandwidth, but I didn't want to let the conversation lapse
without an update, and raising what the benefits would be.

In any case, thanks again Bruce for the rework, it's a great addition.

Re: [PATCH] docs: add note about experimental API in LTS

[Bruce Richardson]

On Fri, Oct 20, 2023 at 03:19:30PM +0100, Kevin Traynor wrote:
> The justification and impact for changing experimental API on LTS
> branches is different from the main branch. So the policy that is
> being used for allowing experimental APIs to change is stricter on
> the LTS branches.
> 
> This was not documented anywhere, so add some documentation.
> 
> Suggested-by: David Marchand 
> Signed-off-by: Kevin Traynor 
> ---
Acked-by: Bruce Richardson 

Re: [PATCH v4] app/test: add support for skipping tests

[Bruce Richardson]

+stable on CC, to allow it be considered for possible backport. It's a
change to the unit test app, so not affecting any ABI or any end-user app.

On Fri, Oct 20, 2023 at 11:02:07AM -0400, Patrick Robb wrote:
>On Mon, Oct 9, 2023 at 4:03 PM Patrick Robb <[1]pr...@iol.unh.edu>
>wrote:
> 
>Hello,
>Yes, backporting would be ideal from a CI perspective because without
>it we can't run arm64 testing on LTS tests. But I know there are other
>considerations which also have to be weighed.
>David also has a patch[1] which should resolve the underlying issue
>which introduces the failures on the unit test we want to skip. If that
>patch is accepted, and backported, fixing our original problem with
>unit testing on our arm testbeds, that's another solution, at least for
>this specific unit test issue.
>It would still be nice to have this feature in case we need it
>otherwise.
>[1] [2]https://patches.dpdk.org/project/dpdk/patch/20230821085806.30626
>13-4-david.march...@redhat.com/
> 
>Hi. just to close the loops on this, yes David's aforementioned patch
>did resolve the unit test failure which was preventing us from running
>fast-tests on our arm64 test beds. But, it is not (yet, at least)
>backported for LTS releases.
>Even if it were, having Bruce's patch here backported would mean the CI
>testing approach could be common across releases in situations where
>testcases have to be skipped.
>Anyways, whether it's possible or "worth it" is ultimately down to the
>community's bandwidth, but I didn't want to let the conversation lapse
>without an update, and raising what the benefits would be.
>In any case, thanks again Bruce for the rework, it's a great addition.
> 
> References
> 
>1. mailto:pr...@iol.unh.edu
>2. 
> https://patches.dpdk.org/project/dpdk/patch/20230821085806.3062613-4-david.march...@redhat.com/

Re: [PATCH] ethdev: fix incorrect function name in comment

[Ferruh Yigit]

On 10/20/2023 2:05 PM, Bruce Richardson wrote:
> For those using the function comments as a guide, provide the name of
> the correct callback function to use when wanting to count dropped
> packets from the ethdev tx buffering system.
> 
> Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Bruce Richardson 
> 

Acked-by: Ferruh Yigit 

Re: [PATCH] docs: add note about experimental API in LTS

[Ferruh Yigit]

On 10/20/2023 4:01 PM, Bruce Richardson wrote:
> On Fri, Oct 20, 2023 at 03:19:30PM +0100, Kevin Traynor wrote:
>> The justification and impact for changing experimental API on LTS
>> branches is different from the main branch. So the policy that is
>> being used for allowing experimental APIs to change is stricter on
>> the LTS branches.
>>
>> This was not documented anywhere, so add some documentation.
>>
>> Suggested-by: David Marchand 
>> Signed-off-by: Kevin Traynor 
>> ---
> Acked-by: Bruce Richardson 
>

Acked-by: Ferruh Yigit 

RE: [PATCH] mempool: fix internal function documentation

[Morten Brørup]

> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Friday, 20 October 2023 16.47
> 
> static function `rte_mempool_do_generic_get()` returns zero on success,
> not >=0 as its function comment documents.
> 
> Since this function called by public API, the comment causes confusion
> on the public API return value.
> 
> Fixing the internal function documentation for return value.
> 
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
> 
> Reported-by: Mahesh Adulla 
> Signed-off-by: Ferruh Yigit 
> ---

I agree that this is the current situation, and is relied upon elsewhere in 
DPDK.

Reviewed-by: Morten Brørup 

However, the documentation for the mempool driver dequeue function type, 
rte_mempool_dequeue_t [1], does not specify allowed return values, so some 
future mempool driver might return a positive value. Please consider updating 
this too. (Also, the mempool driver enqueue/dequeue functions work on a bulk of 
objects, not "an object", as their documentation says.)

[1]: 
https://elixir.bootlin.com/dpdk/latest/source/lib/mempool/rte_mempool.h#L476

Minutes of Technical Board meeting 18-October-23

[Kevin Traynor]

Members Attending
-
Aaron Conole
Bruce Richardson
Hemant Agrawal
Honappa Nagarahalli
Jerin Jacob
Kevin Traynor (Chair)
Konstantin Ananyev
Maxime Coquelin
Stephen Hemminger
Thomas Monjalon

NOTE: The technical board meetings are on every second Wednesday at 3 pm
UTC.
Meetings are public, and DPDK community members are welcome to attend.
Agenda and minutes can be found at http://core.dpdk.org/techboard/minutes

Next meeting will be on Wednesday 2023-Nov-02 @ 3pm UTC, and will
be chaired by Aaron.

Agenda Items


Experimental API promotion (David)
--
- Some experimental API being called from inline helper triggering a
warning in applications not compile with experimental API (e.g. OVS)
- Patch submitted to promote those API to stable early
(https://patchwork.dpdk.org/project/dpdk/patch/20231018091123.1594324-1-david.march...@redhat.com/)
- Simple signature, not likely to need to be changed
- Promotion to stable API approved
- Some increased documentation on endianness needed
- Checks can be added to CI to prevent a re-occurrence as a later step

Increase max lcores for AMD EPYC CPUs (Sivaprasad)
--
- Patch to increase max core count for native AMD EPYC builds
(http://inbox.dpdk.org/dev/20230925151027.558546-1-sivaprasad.tumm...@amd.com)
- There is some asks for more than 128 worker cores
- Discussion about generally increasing the default max core count and
trade-offs with memory consumption but this is longer term issue
- Acceptance for the direction of this patch in the short term
- Details of whether it should be for EPYC only or x86 to be figured out
on mailing list

Conclusion of joint meeting yesterday between two boards (Nathan)
-
- Exploring option of adding developer in UNH for DTS
- Ben presented some ideas around developer focused campaigns for 2024
-- reports/code challenges/swag as well as continuing user stories/blogs
- Discussion on exploring how DPDK can help with Cloud/Security/AI

Website meeting minutes/invite (Kevin/Thomas)
-
- Any TB minutes available but missing from list Thomas sent, please let
him know
- Thomas will send patch with updated TB minutes and new meeting invite

AOB
---
- UNH lab will give update on 2023 progress in next TB meeting
-- Discussion may start on 2024 priorities
-- Aaron will poll for 2024 items soon

- Ferruh would like more reviews on bonding patches that have specific
APIs and change ethdev structs
(https://patchwork.dpdk.org/project/dpdk/list/?series=29900&state=*)

- Some maintainers have changed priorities and have less time now
-- There is a need for more maintainers to help with patch review/merging

[PATCH 1/1] build: update link args and includes for libarchive

[Srikanth Yalavarthi]

In order to avoid linking with all libraries listed as
Libs.private in libarchive.pc, libarchive is not added
to ext_deps during meson setup.

Since libarchive is not added to ext_deps, cross-compilation
or native compilation with libarchive installed in non-standard
location fails with errors related to "cannot find -larchive"
or "archive.h: No such file or directory". In order to fix the
build failures, user is required to define the 'c_args' and
'c_link_args' with '-I' and '-L'.

This patch updates meson build files to add libarchive's
includedir and libdir to compiler flags and would not require
setting c_args and c_link_args externally.

Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org

Signed-off-by: Srikanth Yalavarthi 
---
 config/meson.build  | 1 +
 lib/eal/meson.build | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/config/meson.build b/config/meson.build
index d56b0f9bce..1bacea74ab 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -239,6 +239,7 @@ if libarchive.found()
 # Push libarchive link dependency at the project level to support
 # statically linking dpdk apps. Details at:
 # https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/
+add_project_link_arguments('-L' + libarchive.get_variable(pkgconfig: 
'libdir'), language: 'c')
 add_project_link_arguments('-larchive', language: 'c')
 dpdk_extra_ldflags += '-larchive'
 endif
diff --git a/lib/eal/meson.build b/lib/eal/meson.build
index 9942104386..741a5cd088 100644
--- a/lib/eal/meson.build
+++ b/lib/eal/meson.build
@@ -21,6 +21,9 @@ endif
 if dpdk_conf.has('RTE_USE_LIBBSD')
 ext_deps += libbsd
 endif
+if dpdk_conf.has('RTE_HAS_LIBARCHIVE')
+includes += include_directories(libarchive.get_variable(pkgconfig: 
'includedir'))
+endif
 if cc.has_function('getentropy', prefix : '#include ')
 cflags += '-DRTE_LIBEAL_USE_GETENTROPY'
 endif
-- 
2.42.0

[PATCH] distributor: enhance error handling for consistency

[Volkan Atlı]

>From fe8850cb3b7c1051784e5587b9f79beeaf87a804 Mon Sep 17 00:00:00 2001From: 
>bullvolkan Date: Fri, 20 Oct 2023 21:48:30 
>+0300Subject: [PATCH] distributor: enhance error handling for consistency
 
This commit improves error handling in the distributor component to 
ensureconsistency and reliability. It addresses invalid 'num' values in 
'lcore_worker',corrects 'retptr64' initialization in 
'rte_distributor_request_pkt', and checksthe validity of 'num' in 
'rte_distributor_return_pkt'. These changes enhanceerror handling and maintain 
code consistency.
 
Signed-off-by: Volkan Atli --- .mailmap        
                  |  2 +- examples/distributor/main.c       |  9 +++-- 
lib/distributor/rte_distributor.c | 24 ++-- 
lib/distributor/rte_distributor.h | 11 ++- 4 files changed, 32 
insertions(+), 14 deletions(-)
 
diff --git a/.mailmap b/.mailmapindex 3f5bab26a8..d0fe75fa8b 100644--- 
a/.mailmap+++ b/.mailmap@@ -63,7 +63,7 @@ Alfredo Cardigliano 
 Ali Alnubani  
 Alice Michael  Alin 
Rauta -Ali Volkan Atli 
+Ali Volkan Atli 
 Allain Legacy 
 Allen Hubbe  
Alok Makhariya diff --git 
a/examples/distributor/main.c b/examples/distributor/main.cindex 
21304d6618..58369c3faa 100644--- a/examples/distributor/main.c+++ 
b/examples/distributor/main.c@@ -634,8 +634,8 @@ lcore_worker(struct 
lcore_params *p) {     struct rte_distributor *d = p->d;     const unsigned 
id = p->worker_id;-    unsigned int num = 0;-    unsigned int i;+    int num 
= 0;+    int i;      /*      * for single port, xor_val will be zero so we 
won't modify the output@@ -652,6 +652,11 @@ lcore_worker(struct lcore_params 
*p)     printf("\nCore %u acting as worker core.\n", rte_lcore_id());     while 
(!quit_signal_work) {         num = rte_distributor_get_pkt(d, id, buf, buf, 
num);++        if (unlikely(num < 0 || num > 8)) {+            
rte_exit(EXIT_FAILURE, "strange retcount %u\n", num);+        }+         /* Do 
a little bit of work for each packet */         for (i = 0; i < num; i++) {  
           uint64_t t = rte_rdtsc()+100;diff --git 
a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.cindex 
5ca80dd44f..92653dd9ca 100644--- a/lib/distributor/rte_distributor.c+++ 
b/lib/distributor/rte_distributor.c@@ -64,15 +64,16 @@ 
rte_distributor_request_pkt(struct rte_distributor *d,      * handshake bits. 
Populate the retptrs with returning packets.      */ -    for (i = count; i 
< RTE_DIST_BURST_SIZE; i++)-        buf->retptr64[i] = 0;-     /* Set 
VALID_BUF bit for each packet returned */-    for (i = count; i-- > 0; )+    
size_t arr_len = sizeof(buf->retptr64) / sizeof(buf->retptr64[0]);+    
for (i = 0; i < RTE_MIN(count, arr_len); ++i)         buf->retptr64[i] =  
           (((int64_t)(uintptr_t)(oldpkt[i])) <<             
RTE_DISTRIB_FLAG_BITS) | RTE_DISTRIB_VALID_BUF; +    for (i = count; i < 
RTE_DIST_BURST_SIZE; i++)+        buf->retptr64[i] = 0;+     /*      * 
Finally, set the GET_BUF  to signal to distributor that cache      * line is 
ready for processing@@ -161,7 +162,7 @@ rte_distributor_return_pkt(struct 
rte_distributor *d,         unsigned int worker_id, struct rte_mbuf **oldpkt, 
int num) {     struct rte_distributor_buffer *buf = 
&d->bufs[worker_id];-    unsigned int i;+    int i;      if 
(unlikely(d->alg_type == RTE_DIST_ALG_SINGLE)) {         if (num == 1)@@ 
-186,16 +187,19 @@ rte_distributor_return_pkt(struct rte_distributor *d,        
     rte_pause();     } +    if (unlikely(num > RTE_DIST_BURST_SIZE || num 
< 0)) {+        return -EINVAL;+    }+     /* Sync with distributor to 
acquire retptrs */     __atomic_thread_fence(__ATOMIC_ACQUIRE);-    for (i = 0; 
i < RTE_DIST_BURST_SIZE; i++)-        /* Switch off the return bit first */- 
       buf->retptr64[i] = 0;--    for (i = num; i-- > 0; )+    for (i = 
0; i < num; i++)         buf->retptr64[i] = 
(((int64_t)(uintptr_t)oldpkt[i]) <<             RTE_DISTRIB_FLAG_BITS) | 
RTE_DISTRIB_VALID_BUF; +    for (i = num; i < RTE_DIST_BURST_SIZE; i++)+     
   buf->retptr64[i] = 0;+     /* Use RETURN_BUF on bufptr64 to notify 
distributor that      * we won't read any mbufs from there even if GET_BUF is 
set.      * This allows distributor to retrieve in-flight already sent 
packets.diff --git a/lib/distributor/rte_distributor.h 
b/lib/distributor/rte_distributor.hindex a073e64612..337ff8e0fe 100644--- 
a/lib/distributor/rte_distributor.h+++ b/lib/distributor/rte_distributor.h@@ 
-160,7 +160,11 @@ rte_distributor_clear_returns(struct rte_distributor *d);  *  
 The number of packets being returned  *  * @return- *   The number of packets 
in the pkts array+ *   The number of packets in the pkts array or+ *   -EINVAL 
if num is gre

Re: [PATCH v3 22/29] vhost: remove experimental from some API's

[Stephen Hemminger]

On Fri, 20 Oct 2023 09:41:48 +0200
Maxime Coquelin  wrote:

> I think we should wait before remove experimental tag on all the Vhost
> async APIs. Indeed, it was intended to be used by OVS, but the proposed
> architecture was nacked by the OVS maintainers. I'm not aware of any
> other user of these APIs.
> 
> So we are not sure the proposed API is a good fit.
> Furthermore, it is not clear the team who implemented Vhost Async are
> still going to maintain it.
> 
> Chenbo, what do you think?
> 
> Thanks,
> Maxime

If it was not accepted then maybe the right answer is to mark it
as deprecated. It is hard to remove API's but if is experimental
maybe drop it all together now?

[PATCH v5 00/26] Promote many experimental API's to stable

[Stephen Hemminger]

Since 23.11 is an LTS release it is time to remove the experimental
bandaid off many API's. There are about 890 API's marked with experimental
on current main branch. This addresses the easy to remove ones and
gets it down to about 510 places.

The rule is any API that has been in since 22.11 needs to have
experimental removed (or have API deleted). The experimental flag is not a
"get out of ABI stability for free" card

v5 - fix missing symbol in power version map
 drop mtr, vhost, port and table changes
 add eventdev and cryptodev

Stephen Hemminger (26):
  bpf: make rte_bpf_dump and rte_bpf_convert stable API's
  cmdline: make experimental API's stable
  ethdev: mark rte_tm API's as stable
  pdump: make API's stable
  pcapng: mark API's as stable
  net: remove experimental from functions
  rcu: remove experimental from rte_rcu_qbsr
  lpm: remove experimental
  mbuf: remove experimental from create_extbuf
  hash: remove experimental from toeplitz hash
  timer: remove experimental from rte_timer_next_ticks
  sched: remove experimental
  dmadev: mark API's as not experimental
  meter: remove experimental warning from comments
  power: remove experimental from API's
  kvargs: remove experimental flag
  ip_frag: mark a couple of functions stable
  member: remove experimental tag
  security: remove experimental flag from macsec
  bbdev: remove experimental tag
  ipsec: remove experimental from SA API
  compressdev: remove experimental flag
  regexdev: remove experimental tag
  node: remove some of the experimental tags
  eventdev: make many API's stable
  cryptodev: mark older API's stable

 MAINTAINERS |  8 +--
 lib/bbdev/rte_bbdev.h   |  4 --
 lib/bbdev/rte_bbdev_op.h|  2 -
 lib/bbdev/version.map   | 15 ++--
 lib/bpf/rte_bpf.h   |  2 -
 lib/bpf/version.map |  9 +--
 lib/cmdline/cmdline.h   |  1 -
 lib/cmdline/cmdline_parse.h |  4 --
 lib/cmdline/cmdline_rdline.h|  4 --
 lib/cmdline/version.map | 26 +++
 lib/compressdev/rte_comp.h  |  6 --
 lib/compressdev/rte_compressdev.h   | 26 ---
 lib/compressdev/rte_compressdev_pmd.h   |  6 --
 lib/compressdev/version.map |  2 +-
 lib/cryptodev/rte_cryptodev.h   | 31 -
 lib/cryptodev/version.map   | 77 +
 lib/dmadev/rte_dmadev.h | 85 ---
 lib/dmadev/version.map  |  2 +-
 lib/ethdev/rte_tm.h | 34 -
 lib/ethdev/version.map  | 62 -
 lib/eventdev/rte_event_crypto_adapter.h |  4 --
 lib/eventdev/rte_event_eth_rx_adapter.h |  6 --
 lib/eventdev/rte_event_eth_tx_adapter.h |  3 -
 lib/eventdev/rte_event_timer_adapter.h  |  3 -
 lib/eventdev/rte_eventdev.h |  4 --
 lib/eventdev/version.map| 34 -
 lib/hash/rte_thash.h| 44 
 lib/hash/rte_thash_gfni.h   |  8 ---
 lib/hash/rte_thash_x86_gfni.h   |  8 ---
 lib/hash/version.map| 16 ++---
 lib/ip_frag/rte_ip_frag.h   |  2 -
 lib/ip_frag/version.map |  9 +--
 lib/ipsec/rte_ipsec.h   |  2 -
 lib/ipsec/version.map   |  9 +--
 lib/kvargs/rte_kvargs.h |  4 --
 lib/kvargs/version.map  |  8 +--
 lib/lpm/rte_lpm.h   |  4 --
 lib/lpm/version.map |  7 +-
 lib/mbuf/rte_mbuf.h |  1 -
 lib/mbuf/version.map|  8 +--
 lib/member/rte_member.h | 54 ---
 lib/member/version.map  | 12 +---
 lib/meter/rte_meter.h   | 12 
 lib/net/rte_ip.h| 19 -
 lib/node/rte_node_eth_api.h |  1 -
 lib/node/rte_node_ip4_api.h |  2 -
 lib/node/version.map| 16 +++--
 lib/pcapng/rte_pcapng.h | 11 ---
 lib/pcapng/version.map  |  6 +-
 lib/pdump/rte_pdump.h   | 12 
 lib/pdump/version.map   | 11 +--
 lib/power/rte_power.h   |  4 --
 lib/power/rte_power_guest_channel.h |  4 --
 lib/power/rte_power_pmd_mgmt.h  | 40 ---
 lib/power/rte_power_uncore.h|  5 --
 lib/power/version.map   | 41 ---
 lib/rcu/rte_rcu_qsbr.h  | 20 --
 lib/rcu/version.map | 15 ++--
 lib/regexdev/rte_regexdev.h | 92 -
 lib/regexdev/version.map|  2 +-
 lib/sched/rte_pie.h |  8 ---
 lib/sched/rte_sched.h   |  5 --
 lib/sched/version.map   | 18 ++---
 lib/security/rte_security.h | 27 
 lib/security/version.map| 18 ++---
 lib/

[PATCH v5 01/26] bpf: make rte_bpf_dump and rte_bpf_convert stable API's

[Stephen Hemminger]

These two API's were introduced in 22.11 and can now be
made not experimental.

Signed-off-by: Stephen Hemminger 
Acked-by: Konstantin Ananyev 
---
 lib/bpf/rte_bpf.h   | 2 --
 lib/bpf/version.map | 9 ++---
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/lib/bpf/rte_bpf.h b/lib/bpf/rte_bpf.h
index 4d71120dbd9d..f70d8dacd0d3 100644
--- a/lib/bpf/rte_bpf.h
+++ b/lib/bpf/rte_bpf.h
@@ -209,7 +209,6 @@ rte_bpf_get_jit(const struct rte_bpf *bpf, struct 
rte_bpf_jit *jit);
  * @param len
  *   Number of BPF instructions to dump.
  */
-__rte_experimental
 void
 rte_bpf_dump(FILE *f, const struct ebpf_insn *buf, uint32_t len);
 
@@ -229,7 +228,6 @@ struct bpf_program;
  *   - ENOMEM - can't reserve enough memory
  *   - ENOTSUP - operation not supported
  */
-__rte_experimental
 struct rte_bpf_prm *
 rte_bpf_convert(const struct bpf_program *prog);
 
diff --git a/lib/bpf/version.map b/lib/bpf/version.map
index c49bf1701f0a..2e957494e9df 100644
--- a/lib/bpf/version.map
+++ b/lib/bpf/version.map
@@ -1,7 +1,9 @@
 DPDK_24 {
global:
 
+   rte_bpf_convert;
rte_bpf_destroy;
+   rte_bpf_dump;
rte_bpf_elf_load;
rte_bpf_eth_rx_elf_load;
rte_bpf_eth_rx_unload;
@@ -14,10 +16,3 @@ DPDK_24 {
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_bpf_convert;
-   rte_bpf_dump;
-};
-- 
2.39.2

[PATCH v5 02/26] cmdline: make experimental API's stable

[Stephen Hemminger]

These API's have all ben around for several releases.

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 lib/cmdline/cmdline.h|  1 -
 lib/cmdline/cmdline_parse.h  |  4 
 lib/cmdline/cmdline_rdline.h |  4 
 lib/cmdline/version.map  | 26 --
 4 files changed, 8 insertions(+), 27 deletions(-)

diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h
index 992c84591456..dd41e1054378 100644
--- a/lib/cmdline/cmdline.h
+++ b/lib/cmdline/cmdline.h
@@ -39,7 +39,6 @@ void cmdline_printf(const struct cmdline *cl, const char 
*fmt, ...)
 int cmdline_in(struct cmdline *cl, const char *buf, int size);
 int cmdline_write_char(struct rdline *rdl, char c);
 
-__rte_experimental
 struct rdline *
 cmdline_get_rdline(struct cmdline *cl);
 
diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h
index a852ac411c59..41b4db1f76f9 100644
--- a/lib/cmdline/cmdline_parse.h
+++ b/lib/cmdline/cmdline_parse.h
@@ -155,9 +155,6 @@ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t;
 int cmdline_parse(struct cmdline *cl, const char *buf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Try to parse a buffer according to the specified context, but do not
  * perform any function calls if parse is successful.
  *
@@ -166,7 +163,6 @@ int cmdline_parse(struct cmdline *cl, const char *buf);
  * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0)
  * on successful parse.
  */
-__rte_experimental
 int cmdline_parse_check(struct cmdline *cl, const char *buf);
 
 /**
diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h
index 1b4cc7ce5773..c6bb636a 100644
--- a/lib/cmdline/cmdline_rdline.h
+++ b/lib/cmdline/cmdline_rdline.h
@@ -58,7 +58,6 @@ typedef int (rdline_complete_t)(struct rdline *rdl, const 
char *buf,
  *
  * \return New rdline object on success, NULL on failure.
  */
-__rte_experimental
 struct rdline *rdline_new(rdline_write_char_t *write_char,
  rdline_validate_t *validate,
  rdline_complete_t *complete,
@@ -70,7 +69,6 @@ struct rdline *rdline_new(rdline_write_char_t *write_char,
  * \param rdl A pointer to an initialized struct rdline.
  *If NULL, this function is a no-op.
  */
-__rte_experimental
 void rdline_free(struct rdline *rdl);
 
 /**
@@ -163,13 +161,11 @@ char *rdline_get_history_item(struct rdline *rdl, 
unsigned int i);
 /**
  * Get maximum history buffer size.
  */
-__rte_experimental
 size_t rdline_get_history_buffer_size(struct rdline *rdl);
 
 /**
  * Get the opaque pointer supplied on struct rdline creation.
  */
-__rte_experimental
 void *rdline_get_opaque(struct rdline *rdl);
 
 #ifdef __cplusplus
diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map
index 97166789016c..88174e39bcb7 100644
--- a/lib/cmdline/version.map
+++ b/lib/cmdline/version.map
@@ -30,11 +30,13 @@ DPDK_24 {
cmdline_get_help_num;
cmdline_get_help_portlist;
cmdline_get_help_string;
+   cmdline_get_rdline;
cmdline_in;
cmdline_interact;
cmdline_isendoftoken;
cmdline_new;
cmdline_parse;
+   cmdline_parse_check;
cmdline_parse_etheraddr;
cmdline_parse_ipaddr;
cmdline_parse_num;
@@ -51,37 +53,25 @@ DPDK_24 {
cmdline_token_portlist_ops;
cmdline_token_string_ops;
cmdline_write_char;
+
rdline_add_history;
rdline_char_in;
rdline_clear_history;
+   rdline_free;
rdline_get_buffer;
+   rdline_get_history_buffer_size;
rdline_get_history_item;
+   rdline_get_opaque;
+   rdline_new;
rdline_newline;
rdline_quit;
rdline_redisplay;
rdline_reset;
rdline_restart;
rdline_stop;
+
vt100_init;
vt100_parser;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   # added in 20.11
-   cmdline_get_rdline;
-
-   # added in 21.11
-   rdline_new;
-   rdline_free;
-   rdline_get_history_buffer_size;
-   rdline_get_opaque;
-
-   # added in 22.07
-   cmdline_parse_check;
-
-   local: *;
-};
-- 
2.39.2

[PATCH v5 03/26] ethdev: mark rte_tm API's as stable

[Stephen Hemminger]

These API's have been around since 20.11, mark them as not
experimental.

Signed-off-by: Stephen Hemminger 
Acked-by: Cristian Dumitrescu 
---
 MAINTAINERS|  2 +-
 lib/ethdev/rte_tm.h| 34 ---
 lib/ethdev/version.map | 62 --
 3 files changed, 31 insertions(+), 67 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4083658697fb..e5d92aa74926 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -421,7 +421,7 @@ F: app/test-pmd/cmdline_flow.c
 F: doc/guides/prog_guide/rte_flow.rst
 F: lib/ethdev/rte_flow*
 
-Traffic Management API - EXPERIMENTAL
+Traffic Management API
 M: Cristian Dumitrescu 
 T: git://dpdk.org/next/dpdk-next-net
 F: lib/ethdev/rte_tm*
diff --git a/lib/ethdev/rte_tm.h b/lib/ethdev/rte_tm.h
index 08c5fafecdf3..799b92aadaa9 100644
--- a/lib/ethdev/rte_tm.h
+++ b/lib/ethdev/rte_tm.h
@@ -14,10 +14,6 @@
  * This interface provides the ability to configure the traffic manager in a
  * generic way. It includes features such as: hierarchical scheduling,
  * traffic shaping, congestion management, packet marking, etc.
- *
- * @warning
- * @b EXPERIMENTAL:
- * All functions in this file may be changed or removed without prior notice.
  */
 
 #include 
@@ -1242,7 +1238,6 @@ struct rte_tm_error {
  * @return
  *   0 on success, non-zero error code otherwise.
  */
-__rte_experimental
 int
 rte_tm_get_number_of_leaf_nodes(uint16_t port_id,
uint32_t *n_leaf_nodes,
@@ -1267,7 +1262,6 @@ rte_tm_get_number_of_leaf_nodes(uint16_t port_id,
  * @return
  *   0 on success, non-zero error code otherwise.
  */
-__rte_experimental
 int
 rte_tm_node_type_get(uint16_t port_id,
uint32_t node_id,
@@ -1286,7 +1280,6 @@ rte_tm_node_type_get(uint16_t port_id,
  * @return
  *   0 on success, non-zero error code otherwise.
  */
-__rte_experimental
 int
 rte_tm_capabilities_get(uint16_t port_id,
struct rte_tm_capabilities *cap,
@@ -1307,7 +1300,6 @@ rte_tm_capabilities_get(uint16_t port_id,
  * @return
  *   0 on success, non-zero error code otherwise.
  */
-__rte_experimental
 int
 rte_tm_level_capabilities_get(uint16_t port_id,
uint32_t level_id,
@@ -1328,7 +1320,6 @@ rte_tm_level_capabilities_get(uint16_t port_id,
  * @return
  *   0 on success, non-zero error code otherwise.
  */
-__rte_experimental
 int
 rte_tm_node_capabilities_get(uint16_t port_id,
uint32_t node_id,
@@ -1354,7 +1345,6 @@ rte_tm_node_capabilities_get(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::cman_wred_context_n_max
  */
-__rte_experimental
 int
 rte_tm_wred_profile_add(uint16_t port_id,
uint32_t wred_profile_id,
@@ -1378,7 +1368,6 @@ rte_tm_wred_profile_add(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::cman_wred_context_n_max
  */
-__rte_experimental
 int
 rte_tm_wred_profile_delete(uint16_t port_id,
uint32_t wred_profile_id,
@@ -1410,7 +1399,6 @@ rte_tm_wred_profile_delete(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::cman_wred_context_shared_n_max
  */
-__rte_experimental
 int
 rte_tm_shared_wred_context_add_update(uint16_t port_id,
uint32_t shared_wred_context_id,
@@ -1435,7 +1423,6 @@ rte_tm_shared_wred_context_add_update(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::cman_wred_context_shared_n_max
  */
-__rte_experimental
 int
 rte_tm_shared_wred_context_delete(uint16_t port_id,
uint32_t shared_wred_context_id,
@@ -1460,7 +1447,6 @@ rte_tm_shared_wred_context_delete(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::shaper_n_max
  */
-__rte_experimental
 int
 rte_tm_shaper_profile_add(uint16_t port_id,
uint32_t shaper_profile_id,
@@ -1484,7 +1470,6 @@ rte_tm_shaper_profile_add(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::shaper_n_max
  */
-__rte_experimental
 int
 rte_tm_shaper_profile_delete(uint16_t port_id,
uint32_t shaper_profile_id,
@@ -1514,7 +1499,6 @@ rte_tm_shaper_profile_delete(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::shaper_shared_n_max
  */
-__rte_experimental
 int
 rte_tm_shared_shaper_add_update(uint16_t port_id,
uint32_t shared_shaper_id,
@@ -1538,7 +1522,6 @@ rte_tm_shared_shaper_add_update(uint16_t port_id,
  *
  * @see struct rte_tm_capabilities::shaper_shared_n_max
  */
-__rte_experimental
 int
 rte_tm_shared_shaper_delete(uint16_t port_id,
uint32_t shared_shaper_id,
@@ -1607,7 +1590,6 @@ rte_tm_shared_shaper_delete(uint16_t port_id,
  * @see RTE_TM_NODE_LEVEL_ID_ANY
  * @see struct rte_tm_capabilities
  */
-__rte_experimental
 int
 rte_tm_node_add(uint16_t port_id,
uint32_t node_id,
@@ -1641,7 +1623,6 @@ rte_tm_node_add(uint16_t port_id,
  *
  * @see RTE_TM_UPDATE_NODE_ADD_DELETE
  */
-__rte_experimental
 int
 rte_tm_node_delete(uint16_t port_id,
uint32_t node_id,
@@ -1666,7 +1647,6 @@ rte_tm_node_delete(uint16_t port_id,
  * @see rte_tm_node_resume()
  * @see RTE_TM_UPDATE_NODE_SUSPEND_RESUME
  */
-__rte_experimental
 int
 rte_tm_node_suspend(

[PATCH v5 04/26] pdump: make API's stable

[Stephen Hemminger]

The filtering API's were added in 22.11 and can now be marked
as not experimental.

Signed-off-by: Stephen Hemminger 
---
 lib/pdump/rte_pdump.h | 12 
 lib/pdump/version.map | 11 +++
 2 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h
index b1a391830c1d..414931a12cce 100644
--- a/lib/pdump/rte_pdump.h
+++ b/lib/pdump/rte_pdump.h
@@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t 
flags,
void *filter);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Enables packet capturing on given port and queue with filtering.
  *
  * @param port_id
@@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t 
flags,
  * @return
  *0 on success, -1 on error, rte_errno is set accordingly.
  */
-__rte_experimental
 int
 rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue,
 uint32_t flags, uint32_t snaplen,
@@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t 
queue,
void *filter);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Enables packet capturing on given device id and queue with filtering.
  * device_id can be name or pci address of device.
  *
@@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t 
queue,
  * @return
  *0 on success, -1 on error, rte_errno is set accordingly.
  */
-__rte_experimental
 int
 rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue,
 uint32_t flags, uint32_t snaplen,
@@ -242,9 +234,6 @@ struct rte_pdump_stats {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Retrieve the packet capture statistics for a queue.
  *
  * @param port_id
@@ -254,7 +243,6 @@ struct rte_pdump_stats {
  * @return
  *   Zero if successful. -1 on error and rte_errno is set.
  */
-__rte_experimental
 int
 rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats);
 
diff --git a/lib/pdump/version.map b/lib/pdump/version.map
index 225830dc85a7..ea5bd157cdb1 100644
--- a/lib/pdump/version.map
+++ b/lib/pdump/version.map
@@ -4,17 +4,12 @@ DPDK_24 {
rte_pdump_disable;
rte_pdump_disable_by_deviceid;
rte_pdump_enable;
+   rte_pdump_enable_bpf;
+   rte_pdump_enable_bpf_by_deviceid;
rte_pdump_enable_by_deviceid;
rte_pdump_init;
+   rte_pdump_stats;
rte_pdump_uninit;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_pdump_enable_bpf;
-   rte_pdump_enable_bpf_by_deviceid;
-   rte_pdump_stats;
-};
-- 
2.39.2

[PATCH v5 05/26] pcapng: mark API's as stable

[Stephen Hemminger]

This API was added in 22.11 and can now be marked as not
experimental.

Signed-off-by: Stephen Hemminger 
---
 lib/pcapng/rte_pcapng.h | 11 ---
 lib/pcapng/version.map  |  6 ++
 2 files changed, 2 insertions(+), 15 deletions(-)

diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h
index d93cc9f73ad5..c96c8994f38b 100644
--- a/lib/pcapng/rte_pcapng.h
+++ b/lib/pcapng/rte_pcapng.h
@@ -6,10 +6,6 @@
  * @file
  * RTE pcapng
  *
- * @warning
- * @b EXPERIMENTAL:
- * All functions in this file may be changed or removed without prior notice.
- *
  * Pcapng is an evolution from the pcap format, created to address some of
  * its deficiencies. Namely, the lack of extensibility and inability to store
  * additional information.
@@ -54,7 +50,6 @@ typedef struct rte_pcapng rte_pcapng_t;
  * @return
  *   handle to library, or NULL in case of error (and rte_errno is set).
  */
-__rte_experimental
 rte_pcapng_t *
 rte_pcapng_fdopen(int fd,
  const char *osname, const char *hardware,
@@ -66,7 +61,6 @@ rte_pcapng_fdopen(int fd,
  * @param self
  *  handle to library
  */
-__rte_experimental
 void
 rte_pcapng_close(rte_pcapng_t *self);
 
@@ -89,7 +83,6 @@ rte_pcapng_close(rte_pcapng_t *self);
  * and before any packet record. All ports used in packet capture
  * must be added.
  */
-__rte_experimental
 int
 rte_pcapng_add_interface(rte_pcapng_t *self, uint16_t port,
 const char *ifname, const char *ifdescr,
@@ -132,7 +125,6 @@ enum rte_pcapng_direction {
  *   - The pointer to the new mbuf formatted for pcapng_write
  *   - NULL if allocation fails.
  */
-__rte_experimental
 struct rte_mbuf *
 rte_pcapng_copy(uint16_t port_id, uint32_t queue,
const struct rte_mbuf *m, struct rte_mempool *mp,
@@ -149,7 +141,6 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue,
  *   The minimum size of mbuf data to handle packet with length bytes.
  *   Accounting for required header and trailer fields
  */
-__rte_experimental
 uint32_t
 rte_pcapng_mbuf_size(uint32_t length);
 
@@ -174,7 +165,6 @@ rte_pcapng_mbuf_size(uint32_t length);
  *  The number of bytes written to file, -1 on failure to write file.
  *  The mbuf's in *pkts* are always freed.
  */
-__rte_experimental
 ssize_t
 rte_pcapng_write_packets(rte_pcapng_t *self,
 struct rte_mbuf *pkts[], uint16_t nb_pkts);
@@ -205,7 +195,6 @@ rte_pcapng_write_packets(rte_pcapng_t *self,
  * @return
  *  number of bytes written to file, -1 on failure to write file
  */
-__rte_experimental
 ssize_t
 rte_pcapng_write_stats(rte_pcapng_t *self, uint16_t port,
   const char *comment,
diff --git a/lib/pcapng/version.map b/lib/pcapng/version.map
index 36393914d97c..81c9652ad6b5 100644
--- a/lib/pcapng/version.map
+++ b/lib/pcapng/version.map
@@ -1,6 +1,7 @@
-EXPERIMENTAL {
+DPDK_24 {
global:
 
+   rte_pcapng_add_interface;
rte_pcapng_close;
rte_pcapng_copy;
rte_pcapng_fdopen;
@@ -8,8 +9,5 @@ EXPERIMENTAL {
rte_pcapng_write_packets;
rte_pcapng_write_stats;
 
-   # added in 23.03
-   rte_pcapng_add_interface;
-
local: *;
 };
-- 
2.39.2

[PATCH v5 06/26] net: remove experimental from functions

[Stephen Hemminger]

These functions have been around long enough should no
longer be experimental.

Signed-off-by: Stephen Hemminger 
---
 lib/net/rte_ip.h | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index 7f58dc6f6a9c..2cb5be222cdd 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -435,9 +435,6 @@ __rte_ipv4_udptcp_cksum_mbuf(const struct rte_mbuf *m,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Compute the IPv4 UDP/TCP checksum of a packet.
  *
  * @param m
@@ -449,7 +446,6 @@ __rte_ipv4_udptcp_cksum_mbuf(const struct rte_mbuf *m,
  * @return
  *   The complemented checksum to set in the L4 header.
  */
-__rte_experimental
 static inline uint16_t
 rte_ipv4_udptcp_cksum_mbuf(const struct rte_mbuf *m,
   const struct rte_ipv4_hdr *ipv4_hdr, uint16_t l4_off)
@@ -482,7 +478,6 @@ rte_ipv4_udptcp_cksum_mbuf(const struct rte_mbuf *m,
  * @return
  *   Return 0 if the checksum is correct, else -1.
  */
-__rte_experimental
 static inline int
 rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
 const void *l4_hdr)
@@ -496,9 +491,6 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr 
*ipv4_hdr,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Verify the IPv4 UDP/TCP checksum of a packet.
  *
  * In case of UDP, the caller must first check if udp_hdr->dgram_cksum is 0
@@ -513,7 +505,6 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr 
*ipv4_hdr,
  * @return
  *   Return 0 if the checksum is correct, else -1.
  */
-__rte_experimental
 static inline int
 rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
  const struct rte_ipv4_hdr *ipv4_hdr,
@@ -687,9 +678,6 @@ __rte_ipv6_udptcp_cksum_mbuf(const struct rte_mbuf *m,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Process the IPv6 UDP or TCP checksum of a packet.
  *
  * The IPv6 header must not be followed by extension headers. The layer 4
@@ -704,7 +692,6 @@ __rte_ipv6_udptcp_cksum_mbuf(const struct rte_mbuf *m,
  * @return
  *   The complemented checksum to set in the L4 header.
  */
-__rte_experimental
 static inline uint16_t
 rte_ipv6_udptcp_cksum_mbuf(const struct rte_mbuf *m,
   const struct rte_ipv6_hdr *ipv6_hdr, uint16_t l4_off)
@@ -738,7 +725,6 @@ rte_ipv6_udptcp_cksum_mbuf(const struct rte_mbuf *m,
  * @return
  *   Return 0 if the checksum is correct, else -1.
  */
-__rte_experimental
 static inline int
 rte_ipv6_udptcp_cksum_verify(const struct rte_ipv6_hdr *ipv6_hdr,
 const void *l4_hdr)
@@ -752,9 +738,6 @@ rte_ipv6_udptcp_cksum_verify(const struct rte_ipv6_hdr 
*ipv6_hdr,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Validate the IPv6 UDP or TCP checksum of a packet.
  *
  * In case of UDP, the caller must first check if udp_hdr->dgram_cksum is 0:
@@ -770,7 +753,6 @@ rte_ipv6_udptcp_cksum_verify(const struct rte_ipv6_hdr 
*ipv6_hdr,
  * @return
  *   Return 0 if the checksum is correct, else -1.
  */
-__rte_experimental
 static inline int
 rte_ipv6_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
  const struct rte_ipv6_hdr *ipv6_hdr,
@@ -825,7 +807,6 @@ struct rte_ipv6_fragment_ext {
  * @return
  *   next protocol number if proto is an IPv6 extension, -EINVAL otherwise
  */
-__rte_experimental
 static inline int
 rte_ipv6_get_next_ext(const uint8_t *p, int proto, size_t *ext_len)
 {
-- 
2.39.2

[PATCH v5 07/26] rcu: remove experimental from rte_rcu_qbsr

[Stephen Hemminger]

These functions were added back in 2020.
Remove experimental flag.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Honnappa Nagarahalli 
---
 lib/rcu/rte_rcu_qsbr.h | 20 
 lib/rcu/version.map| 15 ---
 2 files changed, 4 insertions(+), 31 deletions(-)

diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 87e1b55153b5..74ef41e0fac1 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -10,10 +10,6 @@
  *
  * RTE Quiescent State Based Reclamation (QSBR).
  *
- * @warning
- * @b EXPERIMENTAL:
- * All functions in this file may be changed or removed without prior notice.
- *
  * Quiescent State (QS) is any point in the thread execution
  * where the thread does not hold a reference to a data structure
  * in shared memory. While using lock-less data structures, the writer
@@ -727,9 +723,6 @@ int
 rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Create a queue used to store the data structure elements that can
  * be freed later. This queue is referred to as 'defer queue'.
  *
@@ -742,14 +735,10 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v);
  *   - EINVAL - NULL parameters are passed
  *   - ENOMEM - Not enough memory
  */
-__rte_experimental
 struct rte_rcu_qsbr_dq *
 rte_rcu_qsbr_dq_create(const struct rte_rcu_qsbr_dq_parameters *params);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Enqueue one resource to the defer queue and start the grace period.
  * The resource will be freed later after at least one grace period
  * is over.
@@ -777,14 +766,10 @@ rte_rcu_qsbr_dq_create(const struct 
rte_rcu_qsbr_dq_parameters *params);
  * if the defer queue size is equal (or larger) than the
  * number of elements in the data structure.
  */
-__rte_experimental
 int
 rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq *dq, void *e);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Free resources from the defer queue.
  *
  * This API is multi-thread safe.
@@ -806,15 +791,11 @@ rte_rcu_qsbr_dq_enqueue(struct rte_rcu_qsbr_dq *dq, void 
*e);
  *   On error - 1 with rte_errno set to
  *   - EINVAL - NULL parameters are passed
  */
-__rte_experimental
 int
 rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, unsigned int n,
unsigned int *freed, unsigned int *pending, unsigned int *available);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Delete a defer queue.
  *
  * It tries to reclaim all the resources on the defer queue.
@@ -832,7 +813,6 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq *dq, 
unsigned int n,
  *   - EAGAIN - Some of the resources have not completed at least 1 grace
  * period, try again.
  */
-__rte_experimental
 int
 rte_rcu_qsbr_dq_delete(struct rte_rcu_qsbr_dq *dq);
 
diff --git a/lib/rcu/version.map b/lib/rcu/version.map
index 9218ed1f3399..982ffd59d9cd 100644
--- a/lib/rcu/version.map
+++ b/lib/rcu/version.map
@@ -2,6 +2,10 @@ DPDK_24 {
global:
 
rte_rcu_log_type;
+   rte_rcu_qsbr_dq_create;
+   rte_rcu_qsbr_dq_delete;
+   rte_rcu_qsbr_dq_enqueue;
+   rte_rcu_qsbr_dq_reclaim;
rte_rcu_qsbr_dump;
rte_rcu_qsbr_get_memsize;
rte_rcu_qsbr_init;
@@ -11,14 +15,3 @@ DPDK_24 {
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_rcu_qsbr_dq_create;
-   rte_rcu_qsbr_dq_enqueue;
-   rte_rcu_qsbr_dq_reclaim;
-   rte_rcu_qsbr_dq_delete;
-
-   local: *;
-};
-- 
2.39.2

[PATCH v5 08/26] lpm: remove experimental

[Stephen Hemminger]

The function to associate RCU with LPM was added several releases ago.
Remove experimental.

Signed-off-by: Stephen Hemminger 
---
 lib/lpm/rte_lpm.h   | 4 
 lib/lpm/version.map | 7 +--
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/lpm/rte_lpm.h b/lib/lpm/rte_lpm.h
index 75e27ff164ab..40825c5b8038 100644
--- a/lib/lpm/rte_lpm.h
+++ b/lib/lpm/rte_lpm.h
@@ -186,9 +186,6 @@ void
 rte_lpm_free(struct rte_lpm *lpm);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Associate RCU QSBR variable with an LPM object.
  *
  * @param lpm
@@ -203,7 +200,6 @@ rte_lpm_free(struct rte_lpm *lpm);
  *   - EEXIST - already added QSBR
  *   - ENOMEM - memory allocation failure
  */
-__rte_experimental
 int rte_lpm_rcu_qsbr_add(struct rte_lpm *lpm, struct rte_lpm_rcu_config *cfg);
 
 /**
diff --git a/lib/lpm/version.map b/lib/lpm/version.map
index 9ba73b2f938b..b6bee8c18b8a 100644
--- a/lib/lpm/version.map
+++ b/lib/lpm/version.map
@@ -18,12 +18,7 @@ DPDK_24 {
rte_lpm_find_existing;
rte_lpm_free;
rte_lpm_is_rule_present;
+   rte_lpm_rcu_qsbr_add;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_lpm_rcu_qsbr_add;
-};
-- 
2.39.2

[PATCH v5 09/26] mbuf: remove experimental from create_extbuf

[Stephen Hemminger]

This API was added in 2020 and should no longer be experimental.

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 lib/mbuf/rte_mbuf.h  | 1 -
 lib/mbuf/version.map | 8 +---
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 913c459b1cc6..30fa3df85f53 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -800,7 +800,6 @@ struct rte_pktmbuf_extmem {
  *- EEXIST - a memzone with the same name already exists
  *- ENOMEM - no appropriate memory area found in which to create memzone
  */
-__rte_experimental
 struct rte_mempool *
 rte_pktmbuf_pool_create_extbuf(const char *name, unsigned int n,
unsigned int cache_size, uint16_t priv_size,
diff --git a/lib/mbuf/version.map b/lib/mbuf/version.map
index f010d4692e3e..daa65e2bbdb2 100644
--- a/lib/mbuf/version.map
+++ b/lib/mbuf/version.map
@@ -38,14 +38,8 @@ DPDK_24 {
rte_pktmbuf_init;
rte_pktmbuf_pool_create;
rte_pktmbuf_pool_create_by_ops;
+   rte_pktmbuf_pool_create_extbuf;
rte_pktmbuf_pool_init;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_pktmbuf_pool_create_extbuf;
-
-};
-- 
2.39.2

[PATCH v5 10/26] hash: remove experimental from toeplitz hash

[Stephen Hemminger]

The rte_thash_ functions have been around since 2020.
Remove experimental tag.

Signed-off-by: Stephen Hemminger 
---
 lib/hash/rte_thash.h  | 44 ---
 lib/hash/rte_thash_gfni.h |  8 ---
 lib/hash/rte_thash_x86_gfni.h |  8 ---
 lib/hash/version.map  | 16 -
 4 files changed, 4 insertions(+), 72 deletions(-)

diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
index da06cd53c0e0..071730c7bab9 100644
--- a/lib/hash/rte_thash.h
+++ b/lib/hash/rte_thash.h
@@ -221,14 +221,10 @@ rte_softrss_be(uint32_t *input_tuple, uint32_t input_len,
 /**
  * Indicates if GFNI implementations of the Toeplitz hash are supported.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @return
  *  1 if GFNI is supported
  *  0 otherwise
  */
-__rte_experimental
 int
 rte_thash_gfni_supported(void);
 
@@ -236,9 +232,6 @@ rte_thash_gfni_supported(void);
  * Converts Toeplitz hash key (RSS key) into matrixes required
  * for GFNI implementation
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param matrixes
  *  pointer to the memory where matrices will be written.
  *  Note: the size of this memory must be equal to size * 8
@@ -247,7 +240,6 @@ rte_thash_gfni_supported(void);
  * @param size
  *  Size of the rss_key in bytes.
  */
-__rte_experimental
 void
 rte_thash_complete_matrix(uint64_t *matrixes, const uint8_t *rss_key,
int size);
@@ -276,9 +268,6 @@ struct rte_thash_subtuple_helper;
 /**
  * Create a new thash context.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param name
  *  Context name
  * @param key_len
@@ -298,7 +287,6 @@ struct rte_thash_subtuple_helper;
  *  A pointer to the created context on success
  *  NULL otherwise
  */
-__rte_experimental
 struct rte_thash_ctx *
 rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,
uint8_t *key, uint32_t flags);
@@ -306,9 +294,6 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, 
uint32_t reta_sz,
 /**
  * Find an existing thash context and return a pointer to it.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param name
  *  Name of the thash context
  * @return
@@ -316,20 +301,15 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, 
uint32_t reta_sz,
  *  set appropriately. Possible rte_errno values include:
  *   - ENOENT - required entry not available to return.
  */
-__rte_experimental
 struct rte_thash_ctx *
 rte_thash_find_existing(const char *name);
 
 /**
  * Free a thash context object
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param ctx
  *  Thash context
  */
-__rte_experimental
 void
 rte_thash_free_ctx(struct rte_thash_ctx *ctx);
 
@@ -339,9 +319,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);
  * to calculate toeplitz hash collisions.
  * This function is not multi-thread safe.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param ctx
  *  Thash context
  * @param name
@@ -355,7 +332,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);
  *  0 on success
  *  negative on error
  */
-__rte_experimental
 int
 rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,
uint32_t offset);
@@ -363,9 +339,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char 
*name, uint32_t len,
 /**
  * Find a helper in the context by the given name
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param ctx
  *  Thash context
  * @param name
@@ -373,7 +346,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char 
*name, uint32_t len,
  * @return
  *  Pointer to the thash helper or NULL if it was not found.
  */
-__rte_experimental
 struct rte_thash_subtuple_helper *
 rte_thash_get_helper(struct rte_thash_ctx *ctx, const char *name);
 
@@ -392,7 +364,6 @@ rte_thash_get_helper(struct rte_thash_ctx *ctx, const char 
*name);
  * @return
  *  A complementary value which must be xored with the corresponding subtuple
  */
-__rte_experimental
 uint32_t
 rte_thash_get_complement(struct rte_thash_subtuple_helper *h,
uint32_t hash, uint32_t desired_hash);
@@ -402,15 +373,11 @@ rte_thash_get_complement(struct rte_thash_subtuple_helper 
*h,
  * It changes after each addition of a helper. It should be installed to
  * the NIC.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param ctx
  *  Thash context
  * @return
  *  A pointer to the toeplitz hash key
  */
-__rte_experimental
 const uint8_t *
 rte_thash_get_key(struct rte_thash_ctx *ctx);
 
@@ -420,16 +387,12 @@ rte_thash_get_key(struct rte_thash_ctx *ctx);
  * CPU supports GFNI.
  * Matrices changes after each addition of a helper.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * @param ctx
  *  Thash context

[PATCH v5 11/26] timer: remove experimental from rte_timer_next_ticks

[Stephen Hemminger]

Function was added in 20.11, remove experimental flag.

Signed-off-by: Stephen Hemminger 
---
 lib/timer/rte_timer.h | 4 
 lib/timer/version.map | 7 +--
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/timer/rte_timer.h b/lib/timer/rte_timer.h
index d3927d5b6bac..153d1993573f 100644
--- a/lib/timer/rte_timer.h
+++ b/lib/timer/rte_timer.h
@@ -331,9 +331,6 @@ void rte_timer_stop_sync(struct rte_timer *tim);
 int rte_timer_pending(struct rte_timer *tim);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Time until the next timer on the current lcore
  * This function gives the ticks until the next timer will be active.
  *
@@ -343,7 +340,6 @@ int rte_timer_pending(struct rte_timer *tim);
  *   - 0: a timer is pending and will run at next rte_timer_manage()
  *   - >0: ticks until the next timer is ready
  */
-__rte_experimental
 int64_t rte_timer_next_ticks(void);
 
 /**
diff --git a/lib/timer/version.map b/lib/timer/version.map
index e3d5a043034c..b180708e2488 100644
--- a/lib/timer/version.map
+++ b/lib/timer/version.map
@@ -10,6 +10,7 @@ DPDK_24 {
rte_timer_dump_stats;
rte_timer_init;
rte_timer_manage;
+   rte_timer_next_ticks;
rte_timer_pending;
rte_timer_reset;
rte_timer_reset_sync;
@@ -21,9 +22,3 @@ DPDK_24 {
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_timer_next_ticks;
-};
-- 
2.39.2

[PATCH v5 12/26] sched: remove experimental

[Stephen Hemminger]

The overcommit and PIE support was added back in 2020.
Remove experimental tag.

Signed-off-by: Stephen Hemminger 
Acked-by: Cristian Dumitrescu 
---
 lib/sched/rte_pie.h   |  8 
 lib/sched/rte_sched.h |  5 -
 lib/sched/version.map | 18 --
 3 files changed, 4 insertions(+), 27 deletions(-)

diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h
index e0d6d5a3cdcd..631c657980eb 100644
--- a/lib/sched/rte_pie.h
+++ b/lib/sched/rte_pie.h
@@ -78,7 +78,6 @@ struct rte_pie {
  * @retval !0 error
  */
 int
-__rte_experimental
 rte_pie_rt_data_init(struct rte_pie *pie);
 
 /**
@@ -95,7 +94,6 @@ rte_pie_rt_data_init(struct rte_pie *pie);
  * @retval !0 error
  */
 int
-__rte_experimental
 rte_pie_config_init(struct rte_pie_config *pie_cfg,
const uint16_t qdelay_ref,
const uint16_t dp_update_interval,
@@ -116,7 +114,6 @@ rte_pie_config_init(struct rte_pie_config *pie_cfg,
  * @retval !0 drop the packet
  */
 static int
-__rte_experimental
 rte_pie_enqueue_empty(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie,
uint32_t pkt_len)
@@ -148,7 +145,6 @@ rte_pie_enqueue_empty(const struct rte_pie_config *pie_cfg,
  * @param time [in] current time (measured in cpu cycles)
  */
 static void
-__rte_experimental
 _calc_drop_probability(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie, uint64_t time)
 {
@@ -212,7 +208,6 @@ _calc_drop_probability(const struct rte_pie_config *pie_cfg,
  * @retval 1 drop the packet
  */
 static inline int
-__rte_experimental
 _rte_pie_drop(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie)
 {
@@ -261,7 +256,6 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg,
  * @retval 2 drop the packet based on mark probability criterion
  */
 static inline int
-__rte_experimental
 rte_pie_enqueue_nonempty(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie,
uint32_t pkt_len,
@@ -329,7 +323,6 @@ rte_pie_enqueue_nonempty(const struct rte_pie_config 
*pie_cfg,
  * @retval 1 drop the packet based on drop probability criteria
  */
 static inline int
-__rte_experimental
 rte_pie_enqueue(const struct rte_pie_config *pie_cfg,
struct rte_pie *pie,
const unsigned int qlen,
@@ -354,7 +347,6 @@ rte_pie_enqueue(const struct rte_pie_config *pie_cfg,
  * @param time [in] current time stamp in cpu cycles
  */
 static inline void
-__rte_experimental
 rte_pie_dequeue(struct rte_pie *pie,
uint32_t pkt_len,
uint64_t time)
diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h
index a9ac5909ad0c..77fc78ce2fe9 100644
--- a/lib/sched/rte_sched.h
+++ b/lib/sched/rte_sched.h
@@ -353,9 +353,6 @@ rte_sched_subport_pipe_profile_add(struct rte_sched_port 
*port,
uint32_t *pipe_profile_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Hierarchical scheduler subport bandwidth profile add
  * Note that this function is safe to use in runtime for adding new
  * subport bandwidth profile as it doesn't have any impact on hierarchical
@@ -369,7 +366,6 @@ rte_sched_subport_pipe_profile_add(struct rte_sched_port 
*port,
  * @return
  *   0 upon success, error code otherwise
  */
-__rte_experimental
 int
 rte_sched_port_subport_profile_add(struct rte_sched_port *port,
struct rte_sched_subport_profile_params *profile,
@@ -592,7 +588,6 @@ rte_sched_port_dequeue(struct rte_sched_port *port, struct 
rte_mbuf **pkts, uint
  * @return
  *   0 upon success, error code otherwise
  */
-__rte_experimental
 int
 rte_sched_subport_tc_ov_config(struct rte_sched_port *port, uint32_t 
subport_id, bool tc_ov_enable);
 
diff --git a/lib/sched/version.map b/lib/sched/version.map
index d9ce68be1449..be1decaeee46 100644
--- a/lib/sched/version.map
+++ b/lib/sched/version.map
@@ -2,6 +2,8 @@ DPDK_24 {
global:
 
rte_approx;
+   rte_pie_config_init;
+   rte_pie_rt_data_init;
rte_red_config_init;
rte_red_log2_1_minus_Wq;
rte_red_pow2_frac_inv;
@@ -17,24 +19,12 @@ DPDK_24 {
rte_sched_port_pkt_read_color;
rte_sched_port_pkt_read_tree_path;
rte_sched_port_pkt_write;
+   rte_sched_port_subport_profile_add;
rte_sched_queue_read_stats;
rte_sched_subport_config;
rte_sched_subport_pipe_profile_add;
rte_sched_subport_read_stats;
+   rte_sched_subport_tc_ov_config;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   # added in 20.11
-   rte_sched_port_subport_profile_add;
-
-   # added in 21.11
-   rte_pie_rt_data_init;
-   rte_pie_config_init;
-
-   # added in 22.07
-   rte_sched_subport_tc_ov_config;
-};
-- 
2.39.2

[PATCH v5 13/26] dmadev: mark API's as not experimental

[Stephen Hemminger]

These were added in 20.11 time now to remove experimental flag.

Signed-off-by: Stephen Hemminger 
Acked-by: Chengwen Feng 
Acked-by: Bruce Richardson 
---
 MAINTAINERS |  2 +-
 lib/dmadev/rte_dmadev.h | 85 -
 lib/dmadev/version.map  |  2 +-
 3 files changed, 2 insertions(+), 87 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e5d92aa74926..2f1ab5a0f328 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -483,7 +483,7 @@ F: doc/guides/prog_guide/mldev.rst
 F: app/test-mldev/
 F: doc/guides/tools/testmldev.rst
 
-DMA device API - EXPERIMENTAL
+DMA device API
 M: Chengwen Feng 
 F: lib/dmadev/
 F: drivers/dma/skeleton/
diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
index 493263a5d627..2c09939ff6c5 100644
--- a/lib/dmadev/rte_dmadev.h
+++ b/lib/dmadev/rte_dmadev.h
@@ -158,9 +158,6 @@ extern "C" {
 #define RTE_DMADEV_DEFAULT_MAX 64
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Configure the maximum number of dmadevs.
  * @note This function can be invoked before the primary process rte_eal_init()
  * to change the maximum number of dmadevs. If not invoked, the maximum number
@@ -172,13 +169,9 @@ extern "C" {
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_dev_max(size_t dev_max);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get the device identifier for the named DMA device.
  *
  * @param name
@@ -188,13 +181,9 @@ int rte_dma_dev_max(size_t dev_max);
  *   Returns DMA device identifier on success.
  *   - <0: Failure to find named DMA device.
  */
-__rte_experimental
 int rte_dma_get_dev_id_by_name(const char *name);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Check whether the dev_id is valid.
  *
  * @param dev_id
@@ -203,20 +192,15 @@ int rte_dma_get_dev_id_by_name(const char *name);
  * @return
  *   - If the device index is valid (true) or not (false).
  */
-__rte_experimental
 bool rte_dma_is_valid(int16_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get the total number of DMA devices that have been successfully
  * initialised.
  *
  * @return
  *   The total number of usable DMA devices.
  */
-__rte_experimental
 uint16_t rte_dma_count_avail(void);
 
 /**
@@ -227,7 +211,6 @@ uint16_t rte_dma_count_avail(void);
  * @return
  *   Next valid dmadev, UINT16_MAX if there is none.
  */
-__rte_experimental
 int16_t rte_dma_next_dev(int16_t start_dev_id);
 
 /** Utility macro to iterate over all available dmadevs */
@@ -318,9 +301,6 @@ struct rte_dma_info {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Retrieve information of a DMA device.
  *
  * @param dev_id
@@ -332,7 +312,6 @@ struct rte_dma_info {
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_info_get(int16_t dev_id, struct rte_dma_info *dev_info);
 
 /**
@@ -357,9 +336,6 @@ struct rte_dma_conf {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Configure a DMA device.
  *
  * This function must be invoked first before any other function in the
@@ -375,13 +351,9 @@ struct rte_dma_conf {
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_configure(int16_t dev_id, const struct rte_dma_conf *dev_conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Start a DMA device.
  *
  * The device start step is the last one and consists of setting the DMA
@@ -393,13 +365,9 @@ int rte_dma_configure(int16_t dev_id, const struct 
rte_dma_conf *dev_conf);
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_start(int16_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Stop a DMA device.
  *
  * The device can be restarted with a call to rte_dma_start().
@@ -410,13 +378,9 @@ int rte_dma_start(int16_t dev_id);
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_stop(int16_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Close a DMA device.
  *
  * The device cannot be restarted after this call.
@@ -427,7 +391,6 @@ int rte_dma_stop(int16_t dev_id);
  * @return
  *   0 on success. Otherwise negative value is returned.
  */
-__rte_experimental
 int rte_dma_close(int16_t dev_id);
 
 /**
@@ -620,9 +583,6 @@ struct rte_dma_vchan_conf {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Allocate and set up a virtual DMA channel.
  *
  * @param dev_id
@@ -637,7 +597,6 @@ struct rte_dma_vchan_conf {
  * @return
  *   0 on success. Otherwise negative value 

[PATCH v5 14/26] meter: remove experimental warning from comments

[Stephen Hemminger]

The API's for rte_meter_trtcm were never properly flagged
as experimental; missing __rte_experimental but there was
an experimental comment in the docbook comment.
Remove the comment.

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
Acked-by: Cristian Dumitrescu 
---
 lib/meter/rte_meter.h | 12 
 1 file changed, 12 deletions(-)

diff --git a/lib/meter/rte_meter.h b/lib/meter/rte_meter.h
index 6ba99674361a..bd68cbe38903 100644
--- a/lib/meter/rte_meter.h
+++ b/lib/meter/rte_meter.h
@@ -124,9 +124,6 @@ int
 rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p,
struct rte_meter_trtcm_params *params);
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * trTCM RFC 4115 profile configuration
  *
  * @param p
@@ -170,9 +167,6 @@ rte_meter_trtcm_config(struct rte_meter_trtcm *m,
struct rte_meter_trtcm_profile *p);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * trTCM RFC 4115 configuration per metered traffic flow
  *
  * @param m
@@ -273,9 +267,6 @@ rte_meter_trtcm_color_aware_check(struct rte_meter_trtcm *m,
enum rte_color pkt_color);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * trTCM RFC4115 color blind traffic metering
  *
  * @param m
@@ -297,9 +288,6 @@ rte_meter_trtcm_rfc4115_color_blind_check(
uint32_t pkt_len);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * trTCM RFC4115 color aware traffic metering
  *
  * @param m
-- 
2.39.2

[PATCH v5 15/26] power: remove experimental from API's

[Stephen Hemminger]

The power management API's were last changed in 22.11 release.
Therefore remove experimental for 23.11 release.

Signed-off-by: Stephen Hemminger 
Acked-by: David Hunt
---
 lib/power/rte_power.h   |  4 ---
 lib/power/rte_power_guest_channel.h |  4 ---
 lib/power/rte_power_pmd_mgmt.h  | 40 
 lib/power/rte_power_uncore.h|  5 
 lib/power/version.map   | 41 ++---
 5 files changed, 14 insertions(+), 80 deletions(-)

diff --git a/lib/power/rte_power.h b/lib/power/rte_power.h
index e79bf1c4dd0c..4b624a01c5d7 100644
--- a/lib/power/rte_power.h
+++ b/lib/power/rte_power.h
@@ -25,9 +25,6 @@ enum power_management_env {PM_ENV_NOT_SET, 
PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,
PM_ENV_AMD_PSTATE_CPUFREQ};
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Check if a specific power management environment type is supported on a
  * currently running system.
  *
@@ -39,7 +36,6 @@ enum power_management_env {PM_ENV_NOT_SET, 
PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,
  *   - 0 if unsupported
  *   - -1 if error, with rte_errno indicating reason for error.
  */
-__rte_experimental
 int rte_power_check_env_supported(enum power_management_env env);
 
 /**
diff --git a/lib/power/rte_power_guest_channel.h 
b/lib/power/rte_power_guest_channel.h
index b5de1bd24318..55b76dfc4c08 100644
--- a/lib/power/rte_power_guest_channel.h
+++ b/lib/power/rte_power_guest_channel.h
@@ -135,9 +135,6 @@ int rte_power_guest_channel_send_msg(struct 
rte_power_channel_packet *pkt,
unsigned int lcore_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Receive a message contained in pkt over the Virtio-Serial
  * from the host endpoint.
  *
@@ -155,7 +152,6 @@ int rte_power_guest_channel_send_msg(struct 
rte_power_channel_packet *pkt,
  *  - 0 on success.
  *  - Negative on error.
  */
-__rte_experimental
 int rte_power_guest_channel_receive_msg(void *pkt,
size_t pkt_len,
unsigned int lcore_id);
diff --git a/lib/power/rte_power_pmd_mgmt.h b/lib/power/rte_power_pmd_mgmt.h
index 0f1a2eb22eb4..456145661917 100644
--- a/lib/power/rte_power_pmd_mgmt.h
+++ b/lib/power/rte_power_pmd_mgmt.h
@@ -33,9 +33,6 @@ enum rte_power_pmd_mgmt_type {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Enable power management on a specified Ethernet device Rx queue and lcore.
  *
  * @note This function is not thread-safe.
@@ -55,16 +52,12 @@ enum rte_power_pmd_mgmt_type {
  *   0 on success
  *   <0 on error
  */
-__rte_experimental
 int
 rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id,
uint16_t port_id, uint16_t queue_id,
enum rte_power_pmd_mgmt_type mode);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Disable power management on a specified Ethernet device Rx queue and lcore.
  *
  * @note This function is not thread-safe.
@@ -82,42 +75,30 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id,
  *   0 on success
  *   <0 on error
  */
-__rte_experimental
 int
 rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
uint16_t port_id, uint16_t queue_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Set a emptypoll_max to specified value. Used to specify the number of empty
  * polls to wait before entering sleep state.
  *
  * @param max
  *   The value to set emptypoll_max to.
  */
-__rte_experimental
 void
 rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Get the current value of emptypoll_max.
  *
  * @return
  *   The current emptypoll_max value
  */
-__rte_experimental
 unsigned int
 rte_power_pmd_mgmt_get_emptypoll_max(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Set the pause_duration. Used to adjust the pause mode callback duration.
  *
  * @note Duration must be greater than zero.
@@ -128,27 +109,19 @@ rte_power_pmd_mgmt_get_emptypoll_max(void);
  *   0 on success
  *   <0 on error
  */
-__rte_experimental
 int
 rte_power_pmd_mgmt_set_pause_duration(unsigned int duration);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Get the current value of pause_duration.
  *
  * @return
  *   The current pause_duration value.
  */
-__rte_experimental
 unsigned int
 rte_power_pmd_mgmt_get_pause_duration(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
- *
  * Set the min frequency to be used for frequency scaling or zero to use 
defaults.
  *
  * @note Supported by: Pstate mode.
@@ -161,14 

[PATCH v5 16/26] kvargs: remove experimental flag

[Stephen Hemminger]

The function rte_kvargs_get_with_value was added in 21.11
so experimental flag can be removed.

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 lib/kvargs/rte_kvargs.h | 4 
 lib/kvargs/version.map  | 8 +---
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h
index 4900b750bc0b..36804cfb1543 100644
--- a/lib/kvargs/rte_kvargs.h
+++ b/lib/kvargs/rte_kvargs.h
@@ -145,9 +145,6 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);
 const char *rte_kvargs_get(const struct rte_kvargs *kvlist, const char *key);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get the value associated with a given key and value.
  *
  * Find the first entry in the kvlist whose key and value match the
@@ -167,7 +164,6 @@ const char *rte_kvargs_get(const struct rte_kvargs *kvlist, 
const char *key);
  *   NULL if no key matches the input,
  *   a value associated with a matching key otherwise.
  */
-__rte_experimental
 const char *rte_kvargs_get_with_value(const struct rte_kvargs *kvlist,
  const char *key, const char *value);
 
diff --git a/lib/kvargs/version.map b/lib/kvargs/version.map
index 387a94e725cf..cda85d171f32 100644
--- a/lib/kvargs/version.map
+++ b/lib/kvargs/version.map
@@ -4,16 +4,10 @@ DPDK_24 {
rte_kvargs_count;
rte_kvargs_free;
rte_kvargs_get;
+   rte_kvargs_get_with_value;
rte_kvargs_parse;
rte_kvargs_parse_delim;
rte_kvargs_process;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   # added in 21.11
-   rte_kvargs_get_with_value;
-};
-- 
2.39.2

[PATCH v5 17/26] ip_frag: mark a couple of functions stable

[Stephen Hemminger]

There were two functions added in 22.11 which were
marked as experimental. Remove the experimental tag.

Signed-off-by: Stephen Hemminger 
Acked-by: Konstantin Ananyev 
---
 lib/ip_frag/rte_ip_frag.h | 2 --
 lib/ip_frag/version.map   | 9 ++---
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
index feab72ae64b9..cd3a3e143ee7 100644
--- a/lib/ip_frag/rte_ip_frag.h
+++ b/lib/ip_frag/rte_ip_frag.h
@@ -205,7 +205,6 @@ int32_t rte_ipv4_fragment_packet(struct rte_mbuf *pkt_in,
  *   in the pkts_out array.
  *   Otherwise - (-1) * errno.
  */
-__rte_experimental
 int32_t
 rte_ipv4_fragment_copy_nonseg_packet(struct rte_mbuf *pkt_in,
struct rte_mbuf **pkts_out,
@@ -289,7 +288,6 @@ rte_ip_frag_table_statistics_dump(FILE * f, const struct 
rte_ip_frag_tbl *tbl);
  * @param tms
  *   Current timestamp
  */
-__rte_experimental
 void
 rte_ip_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
struct rte_ip_frag_death_row *dr, uint64_t tms);
diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
index 7ba446c9938b..3e7e573dc412 100644
--- a/lib/ip_frag/version.map
+++ b/lib/ip_frag/version.map
@@ -3,19 +3,14 @@ DPDK_24 {
 
rte_ip_frag_free_death_row;
rte_ip_frag_table_create;
+   rte_ip_frag_table_del_expired_entries;
rte_ip_frag_table_destroy;
rte_ip_frag_table_statistics_dump;
rte_ipv4_frag_reassemble_packet;
+   rte_ipv4_fragment_copy_nonseg_packet;
rte_ipv4_fragment_packet;
rte_ipv6_frag_reassemble_packet;
rte_ipv6_fragment_packet;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_ip_frag_table_del_expired_entries;
-   rte_ipv4_fragment_copy_nonseg_packet;
-};
-- 
2.39.2

[PATCH v5 18/26] member: remove experimental tag

[Stephen Hemminger]

The member library last received new API's in 22.11.
All the API's should be marked stable by now.

Signed-off-by: Stephen Hemminger 
---
 lib/member/rte_member.h | 54 -
 lib/member/version.map  | 12 +++--
 2 files changed, 3 insertions(+), 63 deletions(-)

diff --git a/lib/member/rte_member.h b/lib/member/rte_member.h
index a15e0d69e696..a6bf22651700 100644
--- a/lib/member/rte_member.h
+++ b/lib/member/rte_member.h
@@ -15,9 +15,6 @@
  * bloom filter (vBF). For HT setsummary, two subtypes or modes are available,
  * cache and non-cache modes. The table below summarize some properties of
  * the different implementations.
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
  */
 
 /**
@@ -117,17 +114,11 @@ extern int librte_member_logtype;
 struct rte_member_setsum;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Parameter struct used to create set summary
  */
 struct rte_member_parameters;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Define different set summary types
  */
 enum rte_member_setsum_type {
@@ -207,9 +198,6 @@ struct rte_member_setsum {
 } __rte_cache_aligned;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Parameters used when create the set summary table. Currently user can
  * specify two types of setsummary: HT based and vBF. For HT based, user can
  * specify cache or non-cache mode. Here is a table to describe some 
differences
@@ -351,9 +339,6 @@ struct rte_member_parameters {
 } __rte_cache_aligned;
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Find an existing set-summary and return a pointer to it.
  *
  * @param name
@@ -367,9 +352,6 @@ struct rte_member_setsum *
 rte_member_find_existing(const char *name);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Create set-summary (SS).
  *
  * @param params
@@ -382,9 +364,6 @@ struct rte_member_setsum *
 rte_member_create(const struct rte_member_parameters *params);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Lookup key in set-summary (SS).
  * Single key lookup and return as soon as the first match found
  *
@@ -402,9 +381,6 @@ rte_member_lookup(const struct rte_member_setsum *setsum, 
const void *key,
member_set_t *set_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Lookup bulk of keys in set-summary (SS).
  * Each key lookup returns as soon as the first match found
  *
@@ -427,9 +403,6 @@ rte_member_lookup_bulk(const struct rte_member_setsum 
*setsum,
member_set_t *set_ids);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Lookup a key in set-summary (SS) for multiple matches.
  * The key lookup will find all matched entries (multiple match).
  * Note that for cache mode of HT, each key can have at most one match. This is
@@ -456,9 +429,6 @@ rte_member_lookup_multi(const struct rte_member_setsum 
*setsum,
member_set_t *set_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Lookup a bulk of keys in set-summary (SS) for multiple matches each key.
  * Each key lookup will find all matched entries (multiple match).
  * Note that for cache mode HT, each key can have at most one match. So
@@ -489,9 +459,6 @@ rte_member_lookup_multi_bulk(const struct rte_member_setsum 
*setsum,
member_set_t *set_ids);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Insert key into set-summary (SS).
  *
  * @param setsum
@@ -522,9 +489,6 @@ rte_member_add(const struct rte_member_setsum *setsum, 
const void *key,
member_set_t set_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Add the packet byte size into the sketch.
  *
  * @param setsum
@@ -536,15 +500,11 @@ rte_member_add(const struct rte_member_setsum *setsum, 
const void *key,
  * @return
  * Return -EINVAL for invalid parameters, otherwise return 0.
  */
-__rte_experimental
 int
 rte_member_add_byte_count(const struct rte_member_setsum *setsum,
  const void *key, uint32_t byte_count);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Query packet count for a certain flow-key.
  *
  * @param setsum
@@ -556,16 +516,12 @@ rte_member_add_byte_count(const struct rte_member_setsum 
*setsum,
  * @return
  *   Return -EINVAL for invalid parameters.
  */
-__rte_experimental
 int
 rte_member_query_count(const struct rte_member_setsum *setsum,
   const void *key, uint64_t *count);
 
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Report heavyhitt

[PATCH v5 20/26] bbdev: remove experimental tag

[Stephen Hemminger]

The API's for bbdev were last added to in 22.11.
Remove experimental flag now.

Signed-off-by: Stephen Hemminger 
Acked-by: Maxime Coquelin 
---
 lib/bbdev/rte_bbdev.h|  4 
 lib/bbdev/rte_bbdev_op.h |  2 --
 lib/bbdev/version.map| 15 +++
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index d12e2e7fbcf3..b43e98ef9d1b 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -675,7 +675,6 @@ rte_bbdev_enqueue_ldpc_dec_ops(uint16_t dev_id, uint16_t 
queue_id,
  *   The number of operations actually enqueued.
  *   (This is the number of processed entries in the @p ops array.)
  */
-__rte_experimental
 static inline uint16_t
 rte_bbdev_enqueue_fft_ops(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_fft_op **ops, uint16_t num_ops)
@@ -860,7 +859,6 @@ rte_bbdev_dequeue_ldpc_dec_ops(uint16_t dev_id, uint16_t 
queue_id,
  *   The number of operations actually dequeued (this is the number of entries
  *   copied into the @p ops array).
  */
-__rte_experimental
 static inline uint16_t
 rte_bbdev_dequeue_fft_ops(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_fft_op **ops, uint16_t num_ops)
@@ -1042,7 +1040,6 @@ rte_bbdev_queue_intr_ctl(uint16_t dev_id, uint16_t 
queue_id, int epfd, int op,
  * @returns
  *   Device status as string or NULL if invalid.
  */
-__rte_experimental
 const char*
 rte_bbdev_device_status_str(enum rte_bbdev_device_status status);
 
@@ -1055,7 +1052,6 @@ rte_bbdev_device_status_str(enum rte_bbdev_device_status 
status);
  * @returns
  *   Queue status as string or NULL if op_type is invalid.
  */
-__rte_experimental
 const char*
 rte_bbdev_enqueue_status_str(enum rte_bbdev_enqueue_status status);
 
diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 369ac331bf9b..459631d0d0b7 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -1130,7 +1130,6 @@ rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
  *   - 0 on success.
  *   - EINVAL if invalid mempool is provided.
  */
-__rte_experimental
 static inline int
 rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
struct rte_bbdev_fft_op **ops, unsigned int num_ops)
@@ -1220,7 +1219,6 @@ rte_bbdev_enc_op_free_bulk(struct rte_bbdev_enc_op **ops, 
unsigned int num_ops)
  * @param num_ops
  *   Number of structures.
  */
-__rte_experimental
 static inline void
 rte_bbdev_fft_op_free_bulk(struct rte_bbdev_fft_op **ops, unsigned int num_ops)
 {
diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map
index eeb7ed475a6c..1840d2b2a491 100644
--- a/lib/bbdev/version.map
+++ b/lib/bbdev/version.map
@@ -10,11 +10,17 @@ DPDK_24 {
rte_bbdev_dec_op_free_bulk;
rte_bbdev_dequeue_dec_ops;
rte_bbdev_dequeue_enc_ops;
+   rte_bbdev_dequeue_fft_ops;
+   rte_bbdev_device_status_str;
rte_bbdev_devices;
rte_bbdev_enc_op_alloc_bulk;
rte_bbdev_enc_op_free_bulk;
rte_bbdev_enqueue_dec_ops;
rte_bbdev_enqueue_enc_ops;
+   rte_bbdev_enqueue_fft_ops;
+   rte_bbdev_enqueue_status_str;
+   rte_bbdev_fft_op_alloc_bulk;
+   rte_bbdev_fft_op_free_bulk;
rte_bbdev_find_next;
rte_bbdev_get_named_dev;
rte_bbdev_info_get;
@@ -43,14 +49,7 @@ DPDK_24 {
 EXPERIMENTAL {
global:
 
-   # added in 22.11
-   rte_bbdev_dequeue_fft_ops;
-   rte_bbdev_device_status_str;
-   rte_bbdev_enqueue_fft_ops;
-   rte_bbdev_enqueue_status_str;
-   rte_bbdev_fft_op_alloc_bulk;
-   rte_bbdev_fft_op_free_bulk;
-   #added in 23.11
+   # added in 23.11
rte_bbdev_dequeue_mldts_ops;
rte_bbdev_enqueue_mldts_ops;
rte_bbdev_mldts_op_alloc_bulk;
-- 
2.39.2

[PATCH v5 19/26] security: remove experimental flag from macsec

[Stephen Hemminger]

The rte_security API's for macsec were added in 22.11.
Therefore remove the experimental tag.

There is also one helper function for setting packet
metadata that should have been marked internal.

Signed-off-by: Stephen Hemminger 
Acked-by: Akhil Goyal 
---
 lib/security/rte_security.h | 27 ---
 lib/security/version.map| 18 +-
 2 files changed, 9 insertions(+), 36 deletions(-)

diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
index d2d2af23d5d2..a19544906f21 100644
--- a/lib/security/rte_security.h
+++ b/lib/security/rte_security.h
@@ -815,7 +815,6 @@ rte_security_session_create(void *instance,
  *  - On success returns 0
  *  - On failure returns a negative errno value.
  */
-__rte_experimental
 int
 rte_security_session_update(void *instance,
void *sess,
@@ -851,9 +850,6 @@ int
 rte_security_session_destroy(void *instance, void *sess);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Create MACsec security channel (SC).
  *
  * @param   instance   security instance
@@ -865,15 +861,11 @@ rte_security_session_destroy(void *instance, void *sess);
  *  - -ENOMEM if PMD is not capable to create more SC.
  *  - other negative value for other errors.
  */
-__rte_experimental
 int
 rte_security_macsec_sc_create(void *instance,
  struct rte_security_macsec_sc *conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Destroy MACsec security channel (SC).
  *
  * @param   instance   security instance
@@ -884,15 +876,11 @@ rte_security_macsec_sc_create(void *instance,
  *  - -EINVAL if sc_id is invalid or instance is NULL.
  *  - -EBUSY if sc is being used by some session.
  */
-__rte_experimental
 int
 rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id,
   enum rte_security_macsec_direction dir);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Create MACsec security association (SA).
  *
  * @param   instance   security instance
@@ -904,15 +892,11 @@ rte_security_macsec_sc_destroy(void *instance, uint16_t 
sc_id,
  *  - -ENOMEM if PMD is not capable to create more SAs.
  *  - other negative value for other errors.
  */
-__rte_experimental
 int
 rte_security_macsec_sa_create(void *instance,
  struct rte_security_macsec_sa *conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Destroy MACsec security association (SA).
  *
  * @param   instance   security instance
@@ -923,7 +907,6 @@ rte_security_macsec_sa_create(void *instance,
  *  - -EINVAL if sa_id is invalid or instance is NULL.
  *  - -EBUSY if sa is being used by some session.
  */
-__rte_experimental
 int
 rte_security_macsec_sa_destroy(void *instance, uint16_t sa_id,
   enum rte_security_macsec_direction dir);
@@ -1059,7 +1042,6 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t 
fdata)
 }
 
 /** Function to call PMD specific function pointer set_pkt_metadata() */
-__rte_experimental
 int __rte_security_set_pkt_metadata(void *instance,
void *sess,
struct rte_mbuf *m, void *params);
@@ -1230,16 +1212,12 @@ struct rte_security_stats {
  *  - On success, return 0
  *  - On failure, a negative value
  */
-__rte_experimental
 int
 rte_security_session_stats_get(void *instance,
   void *sess,
   struct rte_security_stats *stats);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get MACsec SA statistics.
  *
  * @param  instancesecurity instance
@@ -1250,16 +1228,12 @@ rte_security_session_stats_get(void *instance,
  *  - On success, return 0.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_security_macsec_sa_stats_get(void *instance,
 uint16_t sa_id, enum 
rte_security_macsec_direction dir,
 struct rte_security_macsec_sa_stats *stats);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get MACsec SC statistics.
  *
  * @param  instancesecurity instance
@@ -1270,7 +1244,6 @@ rte_security_macsec_sa_stats_get(void *instance,
  *  - On success, return 0.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_security_macsec_sc_stats_get(void *instance,
 uint16_t sc_id, enum 
rte_security_macsec_direction dir,
diff --git a/lib/security/version.map b/lib/security/version.map
index e07fca33a1e6..54c9a556798d 100644
--- a/lib/security/version.map
+++ b/lib/security/version.map
@@ -1,19 +1,12 @@
 DPDK_24 {
global:
 
+   __rte_security_set_pkt_metadata;
rte_security_capabilities_get;
rte_security_capa

[PATCH v5 21/26] ipsec: remove experimental from SA API

[Stephen Hemminger]

These API's were added in 21.11, remove experimental flag.

Signed-off-by: Stephen Hemminger 
Acked-by: Konstantin Ananyev 
---
 lib/ipsec/rte_ipsec.h | 2 --
 lib/ipsec/version.map | 9 +
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/lib/ipsec/rte_ipsec.h b/lib/ipsec/rte_ipsec.h
index 04129926b69f..81624f909192 100644
--- a/lib/ipsec/rte_ipsec.h
+++ b/lib/ipsec/rte_ipsec.h
@@ -168,7 +168,6 @@ rte_ipsec_pkt_process(const struct rte_ipsec_session *ss, 
struct rte_mbuf *mb[],
  * @return
  *   0 on success, negative value otherwise.
  */
-__rte_experimental
 int
 rte_ipsec_telemetry_sa_add(const struct rte_ipsec_sa *sa);
 
@@ -178,7 +177,6 @@ rte_ipsec_telemetry_sa_add(const struct rte_ipsec_sa *sa);
  * @param sa
  *   Pointer to the *rte_ipsec_sa* object that will have telemetry disabled.
  */
-__rte_experimental
 void
 rte_ipsec_telemetry_sa_del(const struct rte_ipsec_sa *sa);
 
diff --git a/lib/ipsec/version.map b/lib/ipsec/version.map
index f0063af354f0..9d01ebeadc4c 100644
--- a/lib/ipsec/version.map
+++ b/lib/ipsec/version.map
@@ -16,15 +16,8 @@ DPDK_24 {
rte_ipsec_sad_lookup;
rte_ipsec_ses_from_crypto;
rte_ipsec_session_prepare;
-
-   local: *;
-};
-
-EXPERIMENTAL {
-   global:
-
-   # added in 21.11
rte_ipsec_telemetry_sa_add;
rte_ipsec_telemetry_sa_del;
 
+   local: *;
 };
-- 
2.39.2

[PATCH v5 22/26] compressdev: remove experimental flag

[Stephen Hemminger]

The compressdev can not hide under the experimental flag.
Remove the experimental flag and require ABI to be stable.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS   |  2 +-
 lib/compressdev/rte_comp.h|  6 --
 lib/compressdev/rte_compressdev.h | 26 --
 lib/compressdev/rte_compressdev_pmd.h |  6 --
 lib/compressdev/version.map   |  2 +-
 5 files changed, 2 insertions(+), 40 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2f1ab5a0f328..789507ddccb7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -459,7 +459,7 @@ F: lib/security/
 F: doc/guides/prog_guide/rte_security.rst
 F: app/test/test_security*
 
-Compression API - EXPERIMENTAL
+Compression API
 M: Fan Zhang 
 M: Ashish Gupta 
 T: git://dpdk.org/next/dpdk-next-crypto
diff --git a/lib/compressdev/rte_comp.h b/lib/compressdev/rte_comp.h
index bf896d07223c..232564cf5e9a 100644
--- a/lib/compressdev/rte_comp.h
+++ b/lib/compressdev/rte_comp.h
@@ -499,7 +499,6 @@ struct rte_comp_op {
  *  - On success pointer to mempool
  *  - On failure NULL
  */
-__rte_experimental
 struct rte_mempool *
 rte_comp_op_pool_create(const char *name,
unsigned int nb_elts, unsigned int cache_size,
@@ -515,7 +514,6 @@ rte_comp_op_pool_create(const char *name,
  * - On success returns a valid rte_comp_op structure
  * - On failure returns NULL
  */
-__rte_experimental
 struct rte_comp_op *
 rte_comp_op_alloc(struct rte_mempool *mempool);
 
@@ -532,7 +530,6 @@ rte_comp_op_alloc(struct rte_mempool *mempool);
  *   - nb_ops: Success, the nb_ops requested was allocated
  *   - 0: Not enough entries in the mempool; no ops are retrieved.
  */
-__rte_experimental
 int
 rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
struct rte_comp_op **ops, uint16_t nb_ops);
@@ -546,7 +543,6 @@ rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
  *   Compress operation pointer allocated from rte_comp_op_alloc()
  *   If op is NULL, no operation is performed.
  */
-__rte_experimental
 void
 rte_comp_op_free(struct rte_comp_op *op);
 
@@ -561,7 +557,6 @@ rte_comp_op_free(struct rte_comp_op *op);
  * @param nb_ops
  *   Number of operations to free
  */
-__rte_experimental
 void
 rte_comp_op_bulk_free(struct rte_comp_op **ops, uint16_t nb_ops);
 
@@ -574,7 +569,6 @@ rte_comp_op_bulk_free(struct rte_comp_op **ops, uint16_t 
nb_ops);
  * @return
  *   The name of this flag, or NULL if it's not a valid feature flag.
  */
-__rte_experimental
 const char *
 rte_comp_get_feature_name(uint64_t flag);
 
diff --git a/lib/compressdev/rte_compressdev.h 
b/lib/compressdev/rte_compressdev.h
index 13a418631893..8cb5db0e3f7d 100644
--- a/lib/compressdev/rte_compressdev.h
+++ b/lib/compressdev/rte_compressdev.h
@@ -10,10 +10,6 @@
  *
  * RTE Compression Device APIs.
  *
- * @warning
- * @b EXPERIMENTAL:
- * All functions in this file may be changed or removed without prior notice.
- *
  * Defines comp device APIs for the provisioning of compression operations.
  */
 
@@ -54,7 +50,6 @@ struct rte_compressdev_capabilities {
 #define RTE_COMP_END_OF_CAPABILITIES_LIST() \
{ RTE_COMP_ALGO_UNSPECIFIED }
 
-__rte_experimental
 const struct rte_compressdev_capabilities *
 rte_compressdev_capability_get(uint8_t dev_id,
enum rte_comp_algorithm algo);
@@ -94,7 +89,6 @@ rte_compressdev_capability_get(uint8_t dev_id,
  * @return
  *   The name of this flag, or NULL if it's not a valid feature flag.
  */
-__rte_experimental
 const char *
 rte_compressdev_get_feature_name(uint64_t flag);
 
@@ -133,7 +127,6 @@ struct rte_compressdev_stats {
  *   - Returns compress device identifier on success.
  *   - Return -1 on failure to find named compress device.
  */
-__rte_experimental
 int
 rte_compressdev_get_dev_id(const char *name);
 
@@ -146,7 +139,6 @@ rte_compressdev_get_dev_id(const char *name);
  *   - Returns compress device name.
  *   - Returns NULL if compress device is not present.
  */
-__rte_experimental
 const char *
 rte_compressdev_name_get(uint8_t dev_id);
 
@@ -157,7 +149,6 @@ rte_compressdev_name_get(uint8_t dev_id);
  * @return
  *   - The total number of usable compress devices.
  */
-__rte_experimental
 uint8_t
 rte_compressdev_count(void);
 
@@ -175,7 +166,6 @@ rte_compressdev_count(void);
  * @return
  *   Returns number of attached compress devices.
  */
-__rte_experimental
 uint8_t
 rte_compressdev_devices_get(const char *driver_name, uint8_t *devices,
uint8_t nb_devices);
@@ -190,7 +180,6 @@ rte_compressdev_devices_get(const char *driver_name, 
uint8_t *devices,
  *   a default of zero if the socket could not be determined.
  *   -1 if returned is the dev_id value is out of range.
  */
-__rte_experimental
 int
 rte_compressdev_socket_id(uint8_t dev_id);
 
@@ -221,7 +210,6 @@ struct rte_compressdev_config {
  *   - 0: Success, device configured.
  *   - <0: Error code returned by the driver configuration function.
  */
-__rte_experimental
 in

[PATCH v5 23/26] regexdev: remove experimental tag

[Stephen Hemminger]

This library was added in 22.11.
Time to make it not experimental.

Signed-off-by: Stephen Hemminger 
---
 lib/regexdev/rte_regexdev.h | 92 -
 lib/regexdev/version.map|  2 +-
 2 files changed, 1 insertion(+), 93 deletions(-)

diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
index d50af775b551..3ea1f0c061a0 100644
--- a/lib/regexdev/rte_regexdev.h
+++ b/lib/regexdev/rte_regexdev.h
@@ -226,9 +226,6 @@ extern int rte_regexdev_logtype;
 } while (0)
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Check if dev_id is ready.
  *
  * @param dev_id
@@ -238,27 +235,19 @@ extern int rte_regexdev_logtype;
  *   - 0 if device state is not in ready state.
  *   - 1 if device state is ready state.
  */
-__rte_experimental
 int rte_regexdev_is_valid_dev(uint16_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get the total number of RegEx devices that have been successfully
  * initialised.
  *
  * @return
  *   The total number of usable RegEx devices.
  */
-__rte_experimental
 uint8_t
 rte_regexdev_count(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get the device identifier for the named RegEx device.
  *
  * @param name
@@ -268,7 +257,6 @@ rte_regexdev_count(void);
  *   Returns RegEx device identifier on success.
  *   - <0: Failure to find named RegEx device.
  */
-__rte_experimental
 int
 rte_regexdev_get_dev_id(const char *name);
 
@@ -628,9 +616,6 @@ struct rte_regexdev_info {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Retrieve the contextual information of a RegEx device.
  *
  * @param dev_id
@@ -644,7 +629,6 @@ struct rte_regexdev_info {
  *   - 0: Success, driver updates the contextual information of the RegEx 
device
  *   - <0: Error code returned by the driver info get function.
  */
-__rte_experimental
 int
 rte_regexdev_info_get(uint8_t dev_id, struct rte_regexdev_info *dev_info);
 
@@ -723,9 +707,6 @@ struct rte_regexdev_config {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Configure a RegEx device.
  *
  * This function must be invoked first before any other function in the
@@ -743,7 +724,6 @@ struct rte_regexdev_config {
  * @return
  *   - 0: Success, device configured. Otherwise negative errno is returned.
  */
-__rte_experimental
 int
 rte_regexdev_configure(uint8_t dev_id, const struct rte_regexdev_config *cfg);
 
@@ -782,9 +762,6 @@ struct rte_regexdev_qp_conf {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Allocate and set up a RegEx queue pair for a RegEx device.
  *
  * @param dev_id
@@ -799,15 +776,11 @@ struct rte_regexdev_qp_conf {
  * @return
  *   0 on success. Otherwise negative errno is returned.
  */
-__rte_experimental
 int
 rte_regexdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
  const struct rte_regexdev_qp_conf *qp_conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Start a RegEx device.
  *
  * The device start step is the last one and consists of setting the RegEx
@@ -822,14 +795,10 @@ rte_regexdev_queue_pair_setup(uint8_t dev_id, uint16_t 
queue_pair_id,
  * @return
  *   0 on success. Otherwise negative errno is returned.
  */
-__rte_experimental
 int
 rte_regexdev_start(uint8_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Stop a RegEx device.
  *
  * Stop a RegEx device. The device can be restarted with a call to
@@ -845,14 +814,10 @@ rte_regexdev_start(uint8_t dev_id);
  * @return
  *   0 on success. Otherwise negative errno is returned.
  */
-__rte_experimental
 int
 rte_regexdev_stop(uint8_t dev_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Close a RegEx device. The device cannot be restarted!
  *
  * @param dev_id
@@ -861,7 +826,6 @@ rte_regexdev_stop(uint8_t dev_id);
  * @return
  *   0 on success. Otherwise negative errno is returned.
  */
-__rte_experimental
 int
 rte_regexdev_close(uint8_t dev_id);
 
@@ -897,9 +861,6 @@ enum rte_regexdev_attr_id {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get an attribute from a RegEx device.
  *
  * @param dev_id
@@ -915,15 +876,11 @@ enum rte_regexdev_attr_id {
  *   - -EINVAL: Invalid device or  *attr_id* provided, or *attr_value* is NULL.
  *   - -ENOTSUP: if the device doesn't support specific *attr_id*.
  */
-__rte_experimental
 int
 rte_regexdev_attr_get(uint8_t dev_id, enum rte_regexdev_attr_id attr_id,
  void *attr_value);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Set an attribute to a RegEx device.
  *
  * @param dev_id
@@ -939,7 +896,6 @@ rte_regexdev_attr_get(ui

[PATCH v5 24/26] node: remove some of the experimental tags

[Stephen Hemminger]

The node library has been around long enough that experimental
tag should be removed.  The IPv6 support was added in 23.03
but that is still enough time that it can be marked stable.

The logtype variable should have been marked internal
since it is not intended to be used outside of library.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS |  2 +-
 lib/node/rte_node_eth_api.h |  1 -
 lib/node/rte_node_ip4_api.h |  2 --
 lib/node/version.map| 16 
 4 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 789507ddccb7..f6ea602da41f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1735,7 +1735,7 @@ F: app/test/test_graph*
 F: examples/l3fwd-graph/
 F: doc/guides/sample_app_ug/l3_forward_graph.rst
 
-Nodes - EXPERIMENTAL
+Nodes
 M: Nithin Dabilpuram 
 M: Pavan Nikhilesh 
 F: lib/node/
diff --git a/lib/node/rte_node_eth_api.h b/lib/node/rte_node_eth_api.h
index 40b2021f01f9..eaae50772dbe 100644
--- a/lib/node/rte_node_eth_api.h
+++ b/lib/node/rte_node_eth_api.h
@@ -55,7 +55,6 @@ struct rte_node_ethdev_config {
  * @return
  *   0 on successful initialization, negative otherwise.
  */
-__rte_experimental
 int rte_node_eth_config(struct rte_node_ethdev_config *cfg,
uint16_t cnt, uint16_t nb_graphs);
 #ifdef __cplusplus
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index a84dbb3b5499..24f8ec843a27 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -82,7 +82,6 @@ struct rte_node_ip4_reassembly_cfg {
  * @return
  *   0 on success, negative otherwise.
  */
-__rte_experimental
 int rte_node_ip4_route_add(uint32_t ip, uint8_t depth, uint16_t next_hop,
   enum rte_node_ip4_lookup_next next_node);
 
@@ -101,7 +100,6 @@ int rte_node_ip4_route_add(uint32_t ip, uint8_t depth, 
uint16_t next_hop,
  * @return
  *   0 on success, negative otherwise.
  */
-__rte_experimental
 int rte_node_ip4_rewrite_add(uint16_t next_hop, uint8_t *rewrite_data,
 uint8_t rewrite_len, uint16_t dst_port);
 
diff --git a/lib/node/version.map b/lib/node/version.map
index 3855569228e3..59c72ca76fd3 100644
--- a/lib/node/version.map
+++ b/lib/node/version.map
@@ -1,11 +1,15 @@
-EXPERIMENTAL {
+DPDK_24 {
global:
 
-   # added in 20.05
rte_node_eth_config;
rte_node_ip4_route_add;
rte_node_ip4_rewrite_add;
-   rte_node_logtype;
+
+   local: *;
+};
+
+EXPERIMENTAL {
+   global:
 
# added in 23.07
rte_node_ip6_rewrite_add;
@@ -15,6 +19,10 @@ EXPERIMENTAL {
rte_node_ip4_reassembly_configure;
rte_node_udp4_dst_port_add;
rte_node_udp4_usr_node_add;
+};
 
-   local: *;
+INTERNAL {
+   global:
+
+   rte_node_logtype;
 };
-- 
2.39.2

[PATCH v5 25/26] eventdev: make many API's stable

[Stephen Hemminger]

All API's in eventdev up to 22.11 release should be made stable.

Signed-off-by: Stephen Hemminger 
---
 lib/eventdev/rte_event_crypto_adapter.h |  4 ---
 lib/eventdev/rte_event_eth_rx_adapter.h |  6 -
 lib/eventdev/rte_event_eth_tx_adapter.h |  3 ---
 lib/eventdev/rte_event_timer_adapter.h  |  3 ---
 lib/eventdev/rte_eventdev.h |  4 ---
 lib/eventdev/version.map| 34 ++---
 6 files changed, 13 insertions(+), 41 deletions(-)

diff --git a/lib/eventdev/rte_event_crypto_adapter.h 
b/lib/eventdev/rte_event_crypto_adapter.h
index 4e1f1bb3a8e6..e07f159b7760 100644
--- a/lib/eventdev/rte_event_crypto_adapter.h
+++ b/lib/eventdev/rte_event_crypto_adapter.h
@@ -694,9 +694,6 @@ rte_event_crypto_adapter_runtime_params_get(uint8_t id,
struct rte_event_crypto_adapter_runtime_params *params);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Retrieve vector limits for a given event dev and crypto dev pair.
  * @see rte_event_crypto_adapter_vector_limits
  *
@@ -712,7 +709,6 @@ rte_event_crypto_adapter_runtime_params_get(uint8_t id,
  *  - 0: Success.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int rte_event_crypto_adapter_vector_limits_get(
uint8_t dev_id, uint16_t cdev_id,
struct rte_event_crypto_adapter_vector_limits *limits);
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h 
b/lib/eventdev/rte_event_eth_rx_adapter.h
index 842581e87e02..cf42c69b0d71 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/eventdev/rte_event_eth_rx_adapter.h
@@ -466,7 +466,6 @@ int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t 
dev_id,
  *   - 0: Success
  *   - <0: Error code on failure
  */
-__rte_experimental
 int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config,
struct rte_event_eth_rx_adapter_params *rxa_params);
@@ -711,7 +710,6 @@ int rte_event_eth_rx_adapter_vector_limits_get(
  *  - 0: Success, Receive queue added correctly.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
uint16_t eth_dev_id,
uint16_t rx_queue_id,
@@ -736,7 +734,6 @@ int rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
  *  - 0: Success, queue buffer stats retrieved.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int
 rte_event_eth_rx_adapter_queue_stats_get(uint8_t id,
uint16_t eth_dev_id,
@@ -759,7 +756,6 @@ rte_event_eth_rx_adapter_queue_stats_get(uint8_t id,
  *  - 0: Success, queue buffer stats retrieved.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int
 rte_event_eth_rx_adapter_queue_stats_reset(uint8_t id,
uint16_t eth_dev_id,
@@ -780,7 +776,6 @@ rte_event_eth_rx_adapter_queue_stats_reset(uint8_t id,
  *  - <0: Error code on failure, if the adapter doesn't use a rte_service
  * function, this function returns -ESRCH.
  */
-__rte_experimental
 int
 rte_event_eth_rx_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
 
@@ -801,7 +796,6 @@ rte_event_eth_rx_adapter_event_port_get(uint8_t id, uint8_t 
*event_port_id);
  *  -  0: Success
  *  - <0: Error code on failure
  */
-__rte_experimental
 int
 rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
  uint16_t rx_queue_id,
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h 
b/lib/eventdev/rte_event_eth_tx_adapter.h
index 1ea9a153164d..b38b3fce979b 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.h
+++ b/lib/eventdev/rte_event_eth_tx_adapter.h
@@ -492,7 +492,6 @@ rte_event_eth_tx_adapter_service_id_get(uint8_t id, 
uint32_t *service_id);
  *  -  0: Success
  *  - <0: Error code on failure
  */
-__rte_experimental
 int
 rte_event_eth_tx_adapter_instance_get(uint16_t eth_dev_id,
  uint16_t tx_queue_id,
@@ -527,7 +526,6 @@ rte_event_eth_tx_adapter_instance_get(uint16_t eth_dev_id,
  *   - 0: Success
  *   - <0: Error code on failure
  */
-__rte_experimental
 int
 rte_event_eth_tx_adapter_queue_start(uint16_t eth_dev_id, uint16_t 
tx_queue_id);
 
@@ -546,7 +544,6 @@ rte_event_eth_tx_adapter_queue_start(uint16_t eth_dev_id, 
uint16_t tx_queue_id);
  *   - 0: Success
  *   - <0: Error code on failure
  */
-__rte_experimental
 int
 rte_event_eth_tx_adapter_queue_stop(uint16_t eth_dev_id, uint16_t tx_queue_id);
 
diff --git a/lib/eventdev/rte_event_timer_adapter.h 
b/lib/eventdev/rte_event_timer_adapter.h
index fbdddf8f91bd..686cf80a675f 100644
--- a/lib/eventdev/rte_event_timer_adapter.h
+++ b/lib/eventdev/rte_event_timer_adapter.h
@@ -689,9 +689,6 @@ rte_event_timer_cancel_burst(const struct 
rte_event_timer_adapter *adapter,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Get the number of ticks remaining until event timer expiry.
  *
  * @pa

[PATCH v5 26/26] cryptodev: mark older API's stable

[Stephen Hemminger]

All the cryptodev API's from 2022 backwards shoudl be stable
at this point.

Signed-off-by: Stephen Hemminger 
---
 lib/cryptodev/rte_cryptodev.h | 31 --
 lib/cryptodev/version.map | 77 +++
 2 files changed, 32 insertions(+), 76 deletions(-)

diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
index be0698ce9fc6..aa5b5529f44c 100644
--- a/lib/cryptodev/rte_cryptodev.h
+++ b/lib/cryptodev/rte_cryptodev.h
@@ -257,7 +257,6 @@ rte_cryptodev_sym_capability_get(uint8_t dev_id,
  *   - Return description of the asymmetric crypto capability if exist.
  *   - Return NULL if the capability not exist.
  */
-__rte_experimental
 const struct rte_cryptodev_asymmetric_xform_capability *
 rte_cryptodev_asym_capability_get(uint8_t dev_id,
const struct rte_cryptodev_asym_capability_idx *idx);
@@ -327,7 +326,6 @@ rte_cryptodev_sym_capability_check_aead(
  *   - Return 1 if the op type is supported
  *   - Return 0 if unsupported
  */
-__rte_experimental
 int
 rte_cryptodev_asym_xform_capability_check_optype(
const struct rte_cryptodev_asymmetric_xform_capability *capability,
@@ -343,7 +341,6 @@ rte_cryptodev_asym_xform_capability_check_optype(
  *   - Return 0 if the parameters are in range of the capability.
  *   - Return -1 if the parameters are out of range of the capability.
  */
-__rte_experimental
 int
 rte_cryptodev_asym_xform_capability_check_modlen(
const struct rte_cryptodev_asymmetric_xform_capability *capability,
@@ -359,7 +356,6 @@ rte_cryptodev_asym_xform_capability_check_modlen(
  *   - Return true if the hash algorithm is supported.
  *   - Return false if the hash algorithm is not supported.
  */
-__rte_experimental
 bool
 rte_cryptodev_asym_xform_capability_check_hash(
const struct rte_cryptodev_asymmetric_xform_capability *capability,
@@ -421,7 +417,6 @@ rte_cryptodev_get_aead_algo_enum(enum 
rte_crypto_aead_algorithm *algo_enum,
  * - Return -1 if string is not valid
  * - Return 0 if the string is valid
  */
-__rte_experimental
 int
 rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum,
const char *xform_string);
@@ -860,7 +855,6 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t 
queue_pair_id,
  *  - 1: qp was configured
  *  - -EINVAL: device was not configured
  */
-__rte_experimental
 int
 rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id);
 
@@ -1039,7 +1033,6 @@ rte_cryptodev_get_sec_ctx(uint8_t dev_id);
  *  - On success returns the created session mempool pointer
  *  - On failure returns NULL
  */
-__rte_experimental
 struct rte_mempool *
 rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,
uint32_t elt_size, uint32_t cache_size, uint16_t priv_size,
@@ -1066,7 +1059,6 @@ rte_cryptodev_sym_session_pool_create(const char *name, 
uint32_t nb_elts,
  *  - On success return mempool
  *  - On failure returns NULL
  */
-__rte_experimental
 struct rte_mempool *
 rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,
uint32_t cache_size, uint16_t user_data_size, int socket_id);
@@ -1108,7 +1100,6 @@ rte_cryptodev_sym_session_create(uint8_t dev_id,
  *  - -ENOMEM on memory error for session allocation.
  *  - -ENOTSUP if device doesn't support session configuration.
  */
-__rte_experimental
 int
 rte_cryptodev_asym_session_create(uint8_t dev_id,
struct rte_crypto_asym_xform *xforms, struct rte_mempool *mp,
@@ -1141,7 +1132,6 @@ rte_cryptodev_sym_session_free(uint8_t dev_id,
  *  - 0 if successful.
  *  - -EINVAL if device is invalid or session is NULL.
  */
-__rte_experimental
 int
 rte_cryptodev_asym_session_free(uint8_t dev_id, void *sess);
 
@@ -1151,7 +1141,6 @@ rte_cryptodev_asym_session_free(uint8_t dev_id, void 
*sess);
  * @return
  *   Size of the asymmetric header session.
  */
-__rte_experimental
 unsigned int
 rte_cryptodev_asym_get_header_session_size(void);
 
@@ -1179,7 +1168,6 @@ rte_cryptodev_sym_get_private_session_size(uint8_t 
dev_id);
  *   - Size of the asymmetric private data, if successful
  *   - 0 if device is invalid or does not have private session
  */
-__rte_experimental
 unsigned int
 rte_cryptodev_asym_get_private_session_size(uint8_t dev_id);
 
@@ -1226,7 +1214,6 @@ const char *rte_cryptodev_driver_name_get(uint8_t 
driver_id);
  *  - On success, zero.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_cryptodev_sym_session_set_user_data(void *sess,
void *data,
@@ -1263,7 +1250,6 @@ rte_cryptodev_sym_session_opaque_data_set(void *sess, 
uint64_t opaque)
  *  - On success return pointer to user data.
  *  - On failure returns NULL.
  */
-__rte_experimental
 void *
 rte_cryptodev_sym_session_get_user_data(void *sess);
 
@@ -1280,7 +1266,6 @@ rte_cryptodev_sym_session_get_user_data(void *sess);
  *  - -EINVAL if the session pointer is invalid.
  *  - -ENOMEM if

[PATCH v2 00/14] eal: mark older API's as stable

[Stephen Hemminger]

About 80 function in EAL were marked experimental
and should have been made stable by now.

v2 - rebase and fix some bits in wrong patch

Stephen Hemminger (14):
  eal: make bitops a stable API
  eal: mark rte_dev API's as stable
  eal: make rte_class API's stable
  eal: make rte_drand a stable API
  eal: make rte_service_lcore_may_be_active stable
  eal: make rte_devargs_reset stable
  eal: make pflock API stable
  eal: make seqcount and seqlock stable
  eal: mark rte_intr_XXX API's as stable
  eal: mark rte_atomic128_cmp_exchange as stable
  eal: mark rte_power API's stable
  eal: mark rte_eal_vfio_get_token stable
  eal: mark rte_vect simd bandwidth API as stable
  eal: make rte_version API's stable

 lib/eal/arm/include/rte_atomic_64.h   |  1 -
 lib/eal/include/generic/rte_atomic.h  |  1 -
 .../include/generic/rte_power_intrinsics.h| 16 
 lib/eal/include/generic/rte_vect.h|  8 --
 lib/eal/include/rte_bitmap.h  |  8 --
 lib/eal/include/rte_bitops.h  | 40 
 lib/eal/include/rte_class.h   |  4 -
 lib/eal/include/rte_dev.h | 32 ---
 lib/eal/include/rte_devargs.h |  1 -
 lib/eal/include/rte_eal.h |  4 -
 lib/eal/include/rte_interrupts.h  | 28 --
 lib/eal/include/rte_pflock.h  | 20 
 lib/eal/include/rte_random.h  |  4 -
 lib/eal/include/rte_seqcount.h| 23 -
 lib/eal/include/rte_seqlock.h | 21 
 lib/eal/include/rte_service.h |  1 -
 lib/eal/include/rte_version.h |  6 --
 lib/eal/version.map   | 96 ---
 lib/eal/x86/include/rte_atomic_64.h   |  1 -
 19 files changed, 38 insertions(+), 277 deletions(-)

-- 
2.39.2

[PATCH v2 01/14] eal: make bitops a stable API

[Stephen Hemminger]

These were added in 20.05 release.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_bitmap.h |  8 
 lib/eal/include/rte_bitops.h | 40 
 2 files changed, 48 deletions(-)

diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h
index 46a822768d50..ec819595624c 100644
--- a/lib/eal/include/rte_bitmap.h
+++ b/lib/eal/include/rte_bitmap.h
@@ -203,9 +203,6 @@ rte_bitmap_init(uint32_t n_bits, uint8_t *mem, uint32_t 
mem_size)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Bitmap clear slab overhead bits.
  *
  * @param slabs
@@ -215,7 +212,6 @@ rte_bitmap_init(uint32_t n_bits, uint8_t *mem, uint32_t 
mem_size)
  * @param pos
  *   The start bit position in the slabs to be cleared.
  */
-__rte_experimental
 static inline void
 __rte_bitmap_clear_slab_overhead_bits(uint64_t *slabs, uint32_t slab_size,
  uint32_t pos)
@@ -235,9 +231,6 @@ __rte_bitmap_clear_slab_overhead_bits(uint64_t *slabs, 
uint32_t slab_size,
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Bitmap initialization with all bits set
  *
  * @param n_bits
@@ -249,7 +242,6 @@ __rte_bitmap_clear_slab_overhead_bits(uint64_t *slabs, 
uint32_t slab_size,
  * @return
  *   Handle to bitmap instance.
  */
-__rte_experimental
 static inline struct rte_bitmap *
 rte_bitmap_init_with_all_set(uint32_t n_bits, uint8_t *mem, uint32_t mem_size)
 {
diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h
index 6b8ae8d3acf6..29d24b3a780e 100644
--- a/lib/eal/include/rte_bitops.h
+++ b/lib/eal/include/rte_bitops.h
@@ -42,9 +42,6 @@ extern "C" {
 /* 32-bit relaxed operations */
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Get the target bit from a 32-bit value without memory ordering.
  *
  * @param nr
@@ -54,7 +51,6 @@ extern "C" {
  * @return
  *   The target bit.
  */
-__rte_experimental
 static inline uint32_t
 rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)
 {
@@ -65,9 +61,6 @@ rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t 
*addr)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Set the target bit in a 32-bit value to 1 without memory ordering.
  *
  * @param nr
@@ -75,7 +68,6 @@ rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t 
*addr)
  * @param addr
  *   The address holding the bit.
  */
-__rte_experimental
 static inline void
 rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t *addr)
 {
@@ -86,9 +78,6 @@ rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t 
*addr)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Clear the target bit in a 32-bit value to 0 without memory ordering.
  *
  * @param nr
@@ -96,7 +85,6 @@ rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t 
*addr)
  * @param addr
  *   The address holding the bit.
  */
-__rte_experimental
 static inline void
 rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t *addr)
 {
@@ -107,9 +95,6 @@ rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t 
*addr)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Return the original bit from a 32-bit value, then set it to 1 without
  * memory ordering.
  *
@@ -120,7 +105,6 @@ rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t 
*addr)
  * @return
  *   The original bit.
  */
-__rte_experimental
 static inline uint32_t
 rte_bit_relaxed_test_and_set32(unsigned int nr, volatile uint32_t *addr)
 {
@@ -133,9 +117,6 @@ rte_bit_relaxed_test_and_set32(unsigned int nr, volatile 
uint32_t *addr)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Return the original bit from a 32-bit value, then clear it to 0 without
  * memory ordering.
  *
@@ -146,7 +127,6 @@ rte_bit_relaxed_test_and_set32(unsigned int nr, volatile 
uint32_t *addr)
  * @return
  *   The original bit.
  */
-__rte_experimental
 static inline uint32_t
 rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile uint32_t *addr)
 {
@@ -161,9 +141,6 @@ rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile 
uint32_t *addr)
 /* 64-bit relaxed operations */
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Get the target bit from a 64-bit value without memory ordering.
  *
  * @param nr
@@ -173,7 +150,6 @@ rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile 
uint32_t *addr)
  * @return
  *   The target bit.
  */
-__rte_experimental
 static inline uint64_t
 rte_bit_relaxed_get64(unsigned int nr, volatile uint64_t *addr)
 {
@@ -184,9 +160,6 @@ rte_bit_relaxed_get64(unsigned int nr, vol

[PATCH v2 02/14] eal: mark rte_dev API's as stable

[Stephen Hemminger]

These have been around since 2020.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_dev.h | 32 
 lib/eal/version.map   | 28 +++-
 2 files changed, 11 insertions(+), 49 deletions(-)

diff --git a/lib/eal/include/rte_dev.h b/lib/eal/include/rte_dev.h
index 8568535ac04b..86ef2f54235d 100644
--- a/lib/eal/include/rte_dev.h
+++ b/lib/eal/include/rte_dev.h
@@ -341,7 +341,6 @@ typedef void *(*rte_dev_iterate_t)(const void *start,
  *   0 on successful initialization.
  *   <0 on error.
  */
-__rte_experimental
 int
 rte_dev_iterator_init(struct rte_dev_iterator *it, const char *str);
 
@@ -361,7 +360,6 @@ rte_dev_iterator_init(struct rte_dev_iterator *it, const 
char *str);
  *   NULL if an error occurred (rte_errno is set).
  *   NULL if no device could be found (rte_errno is not set).
  */
-__rte_experimental
 struct rte_device *
 rte_dev_iterator_next(struct rte_dev_iterator *it);
 
@@ -372,9 +370,6 @@ rte_dev_iterator_next(struct rte_dev_iterator *it);
 dev = rte_dev_iterator_next(it))
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * It registers the callback for the specific device.
  * Multiple callbacks can be registered at the same time.
  *
@@ -390,16 +385,12 @@ rte_dev_iterator_next(struct rte_dev_iterator *it);
  *  - On success, zero.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_event_callback_register(const char *device_name,
rte_dev_event_cb_fn cb_fn,
void *cb_arg);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * It unregisters the callback according to the specified device.
  *
  * @param device_name
@@ -415,16 +406,12 @@ rte_dev_event_callback_register(const char *device_name,
  *  - On success, return the number of callback entities removed.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_event_callback_unregister(const char *device_name,
  rte_dev_event_cb_fn cb_fn,
  void *cb_arg);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Executes all the user application registered callbacks for
  * the specific device.
  *
@@ -433,64 +420,47 @@ rte_dev_event_callback_unregister(const char *device_name,
  * @param event
  *  the device event type.
  */
-__rte_experimental
 void
 rte_dev_event_callback_process(const char *device_name,
   enum rte_dev_event_type event);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Start the device event monitoring.
  *
  * @return
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_event_monitor_start(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Stop the device event monitoring.
  *
  * @return
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_event_monitor_stop(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Enable hotplug handling for devices.
  *
  * @return
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_hotplug_handle_enable(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Disable hotplug handling for devices.
  *
  * @return
  *   - On success, zero.
  *   - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_dev_hotplug_handle_disable(void);
 
@@ -514,7 +484,6 @@ rte_dev_hotplug_handle_disable(void);
  * 0 if mapping was successful.
  * Negative value and rte_errno is set otherwise.
  */
-__rte_experimental
 int
 rte_dev_dma_map(struct rte_device *dev, void *addr, uint64_t iova, size_t len);
 
@@ -538,7 +507,6 @@ rte_dev_dma_map(struct rte_device *dev, void *addr, 
uint64_t iova, size_t len);
  * 0 if un-mapping was successful.
  * Negative value and rte_errno is set otherwise.
  */
-__rte_experimental
 int
 rte_dev_dma_unmap(struct rte_device *dev, void *addr, uint64_t iova,
  size_t len);
diff --git a/lib/eal/version.map b/lib/eal/version.map
index e00a844805bb..01ff887358fa 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -28,8 +28,19 @@ DPDK_24 {
rte_dev_bus;
rte_dev_bus_info;
rte_dev_devargs;
+   rte_dev_dma_map;
+   rte_dev_dma_unmap;
rte_dev_driver;
+   rte_dev_event_callback_process;
+   rte_dev_event_callback_register;
+   rte_dev_event_callback_unregister;
+   rte_dev_event_monitor_start;
+   rte_dev_event_monitor_stop;
+   rte_dev_hotplug_handle_disable;
+   rte_dev_hotplug_handle_enable;
rte_dev_is_probed;
+   rte_dev_iterator_init;
+   rte_dev_iterator

[PATCH v2 03/14] eal: make rte_class API's stable

[Stephen Hemminger]

These API's have been around for a while.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_class.h |  4 
 lib/eal/version.map | 10 --
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/lib/eal/include/rte_class.h b/lib/eal/include/rte_class.h
index 47b1764e7bf9..487d1abcde72 100644
--- a/lib/eal/include/rte_class.h
+++ b/lib/eal/include/rte_class.h
@@ -76,7 +76,6 @@ typedef int (*rte_class_cmp_t)(const struct rte_class *cls, 
const void *data);
  * @return
  *  A pointer to a rte_class structure or NULL in case no class matches
  */
-__rte_experimental
 struct rte_class *
 rte_class_find(const struct rte_class *start, rte_class_cmp_t cmp,
   const void *data);
@@ -84,7 +83,6 @@ rte_class_find(const struct rte_class *start, rte_class_cmp_t 
cmp,
 /**
  * Find the registered class for a given name.
  */
-__rte_experimental
 struct rte_class *
 rte_class_find_by_name(const char *name);
 
@@ -95,7 +93,6 @@ rte_class_find_by_name(const char *name);
  *   A pointer to a rte_class structure describing the class
  *   to be registered.
  */
-__rte_experimental
 void rte_class_register(struct rte_class *cls);
 
 /**
@@ -105,7 +102,6 @@ void rte_class_register(struct rte_class *cls);
  *   A pointer to a rte_class structure describing the class
  *   to be unregistered.
  */
-__rte_experimental
 void rte_class_unregister(struct rte_class *cls);
 
 /**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 01ff887358fa..5fd7ceec94fb 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -17,6 +17,10 @@ DPDK_24 {
rte_bus_scan;
rte_calloc;
rte_calloc_socket;
+   rte_class_find;
+   rte_class_find_by_name;
+   rte_class_register;
+   rte_class_unregister;
rte_cpu_get_flag_enabled;
rte_cpu_get_flag_name;
rte_cpu_is_supported; # WINDOWS_NO_EXPORT
@@ -320,12 +324,6 @@ DPDK_24 {
 EXPERIMENTAL {
global:
 
-   # added in 18.08
-   rte_class_find;
-   rte_class_find_by_name;
-   rte_class_register;
-   rte_class_unregister;
-
# added in 20.05
__rte_eal_trace_generic_double;
__rte_eal_trace_generic_float;
-- 
2.39.2

[PATCH v2 04/14] eal: make rte_drand a stable API

[Stephen Hemminger]

This API was added in 2020.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_random.h | 4 
 lib/eal/version.map  | 4 +---
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h
index c12eb07ea818..ea74ca020044 100644
--- a/lib/eal/include/rte_random.h
+++ b/lib/eal/include/rte_random.h
@@ -70,9 +70,6 @@ uint64_t
 rte_rand_max(uint64_t upper_bound);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Generates a pseudo-random floating point number.
  *
  * This function returns a non-negative double-precision floating random
@@ -87,7 +84,6 @@ rte_rand_max(uint64_t upper_bound);
  * @return
  *   A pseudo-random value between 0 and 1.0.
  */
-__rte_experimental
 double rte_drand(void);
 
 #ifdef __cplusplus
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 5fd7ceec94fb..edeb7ff518e2 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -57,6 +57,7 @@ DPDK_24 {
rte_devargs_parsef;
rte_devargs_remove;
rte_devargs_type_count;
+   rte_drand;
rte_driver_name;
rte_dump_physmem_layout;
rte_dump_stack;
@@ -395,9 +396,6 @@ EXPERIMENTAL {
rte_intr_type_get;
rte_intr_type_set;
 
-   # added in 22.07
-   rte_drand;
-
# added in 23.03
rte_lcore_register_usage_cb;
__rte_eal_trace_generic_blob;
-- 
2.39.2

[PATCH v2 05/14] eal: make rte_service_lcore_may_be_active stable

[Stephen Hemminger]

This API was added in 2020.

Signed-off-by: Stephen Hemminger 
Acked-by: Harry van Haaren 
---
 lib/eal/include/rte_service.h | 1 -
 lib/eal/version.map   | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/eal/include/rte_service.h b/lib/eal/include/rte_service.h
index a77f33be488c..da5e246f7abf 100644
--- a/lib/eal/include/rte_service.h
+++ b/lib/eal/include/rte_service.h
@@ -275,7 +275,6 @@ int32_t rte_service_lcore_stop(uint32_t lcore_id);
  * @retval 1 Service thread is in the service core polling loop.
  * @retval -EINVAL Invalid *lcore_id* provided.
  */
-__rte_experimental
 int32_t rte_service_lcore_may_be_active(uint32_t lcore_id);
 
 /**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index edeb7ff518e2..89feb98fea7c 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -249,6 +249,7 @@ DPDK_24 {
rte_service_lcore_count_services;
rte_service_lcore_del;
rte_service_lcore_list;
+   rte_service_lcore_may_be_active;
rte_service_lcore_reset_all;
rte_service_lcore_start;
rte_service_lcore_stop;
@@ -366,7 +367,6 @@ EXPERIMENTAL {
# added in 20.11
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
-   rte_service_lcore_may_be_active;
rte_vect_get_max_simd_bitwidth;
rte_vect_set_max_simd_bitwidth;
 
-- 
2.39.2

[PATCH v2 06/14] eal: make rte_devargs_reset stable

[Stephen Hemminger]

Was added in 20.05 release.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_devargs.h | 1 -
 lib/eal/version.map   | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/eal/include/rte_devargs.h b/lib/eal/include/rte_devargs.h
index 91267981b1de..add8032e73cb 100644
--- a/lib/eal/include/rte_devargs.h
+++ b/lib/eal/include/rte_devargs.h
@@ -168,7 +168,6 @@ __rte_format_printf(2, 0);
  * @param da
  *   The devargs structure holding the device information.
  */
-__rte_experimental
 void
 rte_devargs_reset(struct rte_devargs *da);
 
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 89feb98fea7c..d7f6ea24581e 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -56,6 +56,7 @@ DPDK_24 {
rte_devargs_parse;
rte_devargs_parsef;
rte_devargs_remove;
+   rte_devargs_reset;
rte_devargs_type_count;
rte_drand;
rte_driver_name;
@@ -376,7 +377,6 @@ EXPERIMENTAL {
rte_power_pause; # WINDOWS_NO_EXPORT
 
# added in 21.05
-   rte_devargs_reset;
rte_intr_callback_unregister_sync;
rte_version_minor;
rte_version_month;
-- 
2.39.2

[PATCH v2 07/14] eal: make pflock API stable

[Stephen Hemminger]

Added in 21.11 release.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_pflock.h | 20 
 1 file changed, 20 deletions(-)

diff --git a/lib/eal/include/rte_pflock.h b/lib/eal/include/rte_pflock.h
index 553504bb6dd9..9aaf56f715cc 100644
--- a/lib/eal/include/rte_pflock.h
+++ b/lib/eal/include/rte_pflock.h
@@ -80,15 +80,11 @@ typedef struct rte_pflock rte_pflock_t;
 #define RTE_PFLOCK_INITIALIZER {  }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Initialize the pflock to an unlocked state.
  *
  * @param pf
  *   A pointer to the pflock.
  */
-__rte_experimental
 static inline void
 rte_pflock_init(struct rte_pflock *pf)
 {
@@ -99,15 +95,11 @@ rte_pflock_init(struct rte_pflock *pf)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Take a pflock for read.
  *
  * @param pf
  *   A pointer to a pflock structure.
  */
-__rte_experimental
 static inline void
 rte_pflock_read_lock(rte_pflock_t *pf)
 {
@@ -127,15 +119,11 @@ rte_pflock_read_lock(rte_pflock_t *pf)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Release a pflock locked for reading.
  *
  * @param pf
  *   A pointer to the pflock structure.
  */
-__rte_experimental
 static inline void
 rte_pflock_read_unlock(rte_pflock_t *pf)
 {
@@ -143,15 +131,11 @@ rte_pflock_read_unlock(rte_pflock_t *pf)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Take the pflock for write.
  *
  * @param pf
  *   A pointer to the pflock structure.
  */
-__rte_experimental
 static inline void
 rte_pflock_write_lock(rte_pflock_t *pf)
 {
@@ -181,15 +165,11 @@ rte_pflock_write_lock(rte_pflock_t *pf)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Release a pflock held for writing.
  *
  * @param pf
  *   A pointer to a pflock structure.
  */
-__rte_experimental
 static inline void
 rte_pflock_write_unlock(rte_pflock_t *pf)
 {
-- 
2.39.2

[PATCH v2 08/14] eal: make seqcount and seqlock stable

[Stephen Hemminger]

These were add back in 22.07 release.

Signed-off-by: Stephen Hemminger 
Acked-by: Mattias Rönnblom 
---
 lib/eal/include/rte_seqcount.h | 23 ---
 lib/eal/include/rte_seqlock.h  | 21 -
 2 files changed, 44 deletions(-)

diff --git a/lib/eal/include/rte_seqcount.h b/lib/eal/include/rte_seqcount.h
index 4f9cefb33862..ff8985310377 100644
--- a/lib/eal/include/rte_seqcount.h
+++ b/lib/eal/include/rte_seqcount.h
@@ -41,15 +41,11 @@ typedef struct {
 #define RTE_SEQCOUNT_INITIALIZER { .sn = 0 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Initialize the sequence counter.
  *
  * @param seqcount
  *   A pointer to the sequence counter.
  */
-__rte_experimental
 static inline void
 rte_seqcount_init(rte_seqcount_t *seqcount)
 {
@@ -57,9 +53,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Begin a read-side critical section.
  *
  * A call to this function marks the beginning of a read-side critical
@@ -101,8 +94,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
  *
  * @see rte_seqcount_read_retry()
  */
-
-__rte_experimental
 static inline uint32_t
 rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
 {
@@ -114,9 +105,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * End a read-side critical section.
  *
  * A call to this function marks the end of a read-side critical
@@ -146,8 +134,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
  *
  * @see rte_seqcount_read_begin()
  */
-
-__rte_experimental
 static inline bool
 rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
 {
@@ -172,9 +158,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, 
uint32_t begin_sn)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Begin a write-side critical section.
  *
  * A call to this function marks the beginning of a write-side
@@ -196,8 +179,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, 
uint32_t begin_sn)
  *
  * @see rte_seqcount_write_end()
  */
-
-__rte_experimental
 static inline void
 rte_seqcount_write_begin(rte_seqcount_t *seqcount)
 {
@@ -214,9 +195,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * End a write-side critical section.
  *
  * A call to this function marks the end of the write-side critical
@@ -228,7 +206,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
  *
  * @see rte_seqcount_write_begin()
  */
-__rte_experimental
 static inline void
 rte_seqcount_write_end(rte_seqcount_t *seqcount)
 {
diff --git a/lib/eal/include/rte_seqlock.h b/lib/eal/include/rte_seqlock.h
index fcbb9c586668..589c98188529 100644
--- a/lib/eal/include/rte_seqlock.h
+++ b/lib/eal/include/rte_seqlock.h
@@ -114,9 +114,6 @@ typedef struct {
}
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Initialize the seqlock.
  *
  * This function initializes the seqlock, and leaves the writer-side
@@ -125,7 +122,6 @@ typedef struct {
  * @param seqlock
  *   A pointer to the seqlock.
  */
-__rte_experimental
 static inline void
 rte_seqlock_init(rte_seqlock_t *seqlock)
 {
@@ -134,9 +130,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Begin a read-side critical section.
  *
  * See rte_seqcount_read_retry() for details.
@@ -150,8 +143,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
  * @see rte_seqlock_read_retry()
  * @see rte_seqcount_read_retry()
  */
-
-__rte_experimental
 static inline uint32_t
 rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
 {
@@ -159,9 +150,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * End a read-side critical section.
  *
  * See rte_seqcount_read_retry() for details.
@@ -177,7 +165,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
  *
  * @see rte_seqlock_read_begin()
  */
-__rte_experimental
 static inline bool
 rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
 {
@@ -185,9 +172,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, 
uint32_t begin_sn)
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Begin a write-side critical section.
  *
  * A call to this function acquires the write lock associated @p
@@ -212,7 +196,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, 
uint32_t begin_sn)
  *
  * @see rte_seqlock_write_unlock()
  */
-__rte_experimental
 static inline void
 rte_seqlock_write_lock(rte_seqlock_t *seqlock)
__rte_exclusive_lock_function(&seqlock->lock)
@@ -224,9 +207,6 @@ rte_seqlock_wri

[PATCH v2 09/14] eal: mark rte_intr_XXX API's as stable

[Stephen Hemminger]

These were added back in 2020.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_interrupts.h | 28 
 lib/eal/version.map  | 14 +++---
 2 files changed, 7 insertions(+), 35 deletions(-)

diff --git a/lib/eal/include/rte_interrupts.h b/lib/eal/include/rte_interrupts.h
index bcafdd58a912..1b9a0b2a78f3 100644
--- a/lib/eal/include/rte_interrupts.h
+++ b/lib/eal/include/rte_interrupts.h
@@ -127,9 +127,6 @@ rte_intr_callback_unregister_pending(const struct 
rte_intr_handle *intr_handle,
rte_intr_unregister_callback_fn ucb_fn);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Loop until rte_intr_callback_unregister() succeeds.
  * After a call to this function,
  * the callback provided by the specified interrupt handle is unregistered.
@@ -146,7 +143,6 @@ rte_intr_callback_unregister_pending(const struct 
rte_intr_handle *intr_handle,
  *  - On success, return the number of callback entities removed.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_intr_callback_unregister_sync(const struct rte_intr_handle *intr_handle,
rte_intr_callback_fn cb, void *cb_arg);
@@ -201,9 +197,6 @@ int rte_intr_ack(const struct rte_intr_handle *intr_handle);
 int rte_thread_is_intr(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * It allocates memory for interrupt instance. API takes flag as an argument
  * which define from where memory should be allocated i.e. using DPDK memory
  * management library APIs or normal heap allocation.
@@ -221,28 +214,20 @@ int rte_thread_is_intr(void);
  *  - On success, address of interrupt handle.
  *  - On failure, NULL.
  */
-__rte_experimental
 struct rte_intr_handle *
 rte_intr_instance_alloc(uint32_t flags);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Free the memory allocated for interrupt handle resources.
  *
  * @param intr_handle
  *  Interrupt handle allocated with rte_intr_instance_alloc().
  *  If intr_handle is NULL, no operation is performed.
  */
-__rte_experimental
 void
 rte_intr_instance_free(struct rte_intr_handle *intr_handle);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Set the fd field of interrupt handle with user provided
  * file descriptor.
  *
@@ -255,14 +240,10 @@ rte_intr_instance_free(struct rte_intr_handle 
*intr_handle);
  *  - On success, zero.
  *  - On failure, a negative value and rte_errno is set.
  */
-__rte_experimental
 int
 rte_intr_fd_set(struct rte_intr_handle *intr_handle, int fd);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Returns the fd field of the given interrupt handle instance.
  *
  * @param intr_handle
@@ -272,14 +253,10 @@ rte_intr_fd_set(struct rte_intr_handle *intr_handle, int 
fd);
  *  - On success, fd field.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_intr_fd_get(const struct rte_intr_handle *intr_handle);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Set the type field of interrupt handle with user provided
  * interrupt type.
  *
@@ -292,15 +269,11 @@ rte_intr_fd_get(const struct rte_intr_handle 
*intr_handle);
  *  - On success, zero.
  *  - On failure, a negative value and rte_errno is set.
  */
-__rte_experimental
 int
 rte_intr_type_set(struct rte_intr_handle *intr_handle,
  enum rte_intr_handle_type type);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Returns the type field of the given interrupt handle instance.
  *
  * @param intr_handle
@@ -310,7 +283,6 @@ rte_intr_type_set(struct rte_intr_handle *intr_handle,
  *  - On success, interrupt type
  *  - On failure, RTE_INTR_HANDLE_UNKNOWN.
  */
-__rte_experimental
 enum rte_intr_handle_type
 rte_intr_type_get(const struct rte_intr_handle *intr_handle);
 
diff --git a/lib/eal/version.map b/lib/eal/version.map
index d7f6ea24581e..0dbd8b0573dd 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -137,8 +137,15 @@ DPDK_24 {
rte_intr_callback_register;
rte_intr_callback_unregister;
rte_intr_callback_unregister_pending;
+   rte_intr_callback_unregister_sync;
rte_intr_disable;
rte_intr_enable;
+   rte_intr_fd_get;
+   rte_intr_fd_set;
+   rte_intr_instance_alloc;
+   rte_intr_instance_free;
+   rte_intr_type_get;
+   rte_intr_type_set;
rte_keepalive_create; # WINDOWS_NO_EXPORT
rte_keepalive_dispatch_pings; # WINDOWS_NO_EXPORT
rte_keepalive_mark_alive; # WINDOWS_NO_EXPORT
@@ -377,7 +384,6 @@ EXPERIMENTAL {
rte_power_pause; # WINDOWS_NO_EXPORT
 
# added in 21.05
-   rte_intr_callback_unregister_sync;
rte_version_minor;
rte_version_month;
rte_version_prefi

[PATCH v2 10/14] eal: mark rte_atomic128_cmp_exchange as stable

[Stephen Hemminger]

This has been around since 2021.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/arm/include/rte_atomic_64.h  | 1 -
 lib/eal/include/generic/rte_atomic.h | 1 -
 lib/eal/x86/include/rte_atomic_64.h  | 1 -
 3 files changed, 3 deletions(-)

diff --git a/lib/eal/arm/include/rte_atomic_64.h 
b/lib/eal/arm/include/rte_atomic_64.h
index 75d8ba6092cc..96205e6ad372 100644
--- a/lib/eal/arm/include/rte_atomic_64.h
+++ b/lib/eal/arm/include/rte_atomic_64.h
@@ -94,7 +94,6 @@ __ATOMIC128_CAS_OP(__cas_128_acq_rel, "caspal")
 
 #endif
 
-__rte_experimental
 static inline int
 rte_atomic128_cmp_exchange(rte_int128_t *dst, rte_int128_t *exp,
const rte_int128_t *src, unsigned int weak, int success,
diff --git a/lib/eal/include/generic/rte_atomic.h 
b/lib/eal/include/generic/rte_atomic.h
index db6797e379f3..048b547ea62b 100644
--- a/lib/eal/include/generic/rte_atomic.h
+++ b/lib/eal/include/generic/rte_atomic.h
@@ -1147,7 +1147,6 @@ typedef struct {
  * @return
  *   Non-zero on success; 0 on failure.
  */
-__rte_experimental
 static inline int
 rte_atomic128_cmp_exchange(rte_int128_t *dst,
   rte_int128_t *exp,
diff --git a/lib/eal/x86/include/rte_atomic_64.h 
b/lib/eal/x86/include/rte_atomic_64.h
index 0edee8627224..e968bbf0ce65 100644
--- a/lib/eal/x86/include/rte_atomic_64.h
+++ b/lib/eal/x86/include/rte_atomic_64.h
@@ -182,7 +182,6 @@ static inline void rte_atomic64_clear(rte_atomic64_t *v)
 
 /* 128 bit atomic operations 
-*/
 
-__rte_experimental
 static inline int
 rte_atomic128_cmp_exchange(rte_int128_t *dst,
   rte_int128_t *exp,
-- 
2.39.2

[PATCH v2 11/14] eal: mark rte_power API's stable

[Stephen Hemminger]

These were added back in 2020.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/generic/rte_power_intrinsics.h | 16 
 lib/eal/version.map| 12 
 2 files changed, 4 insertions(+), 24 deletions(-)

diff --git a/lib/eal/include/generic/rte_power_intrinsics.h 
b/lib/eal/include/generic/rte_power_intrinsics.h
index f981df7d75a1..922c32c83fdb 100644
--- a/lib/eal/include/generic/rte_power_intrinsics.h
+++ b/lib/eal/include/generic/rte_power_intrinsics.h
@@ -54,9 +54,6 @@ struct rte_power_monitor_cond {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Monitor specific address for changes. This will cause the CPU to enter an
  * architecture-defined optimized power state until either the specified
  * memory address is written to, a certain TSC timestamp is reached, or other
@@ -84,14 +81,10 @@ struct rte_power_monitor_cond {
  *   -EINVAL on invalid parameters
  *   -ENOTSUP if unsupported
  */
-__rte_experimental
 int rte_power_monitor(const struct rte_power_monitor_cond *pmc,
const uint64_t tsc_timestamp);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Wake up a specific lcore that is in a power optimized state and is 
monitoring
  * an address.
  *
@@ -104,13 +97,9 @@ int rte_power_monitor(const struct rte_power_monitor_cond 
*pmc,
  * @param lcore_id
  *   Lcore ID of a sleeping thread.
  */
-__rte_experimental
 int rte_power_monitor_wakeup(const unsigned int lcore_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Enter an architecture-defined optimized power state until a certain TSC
  * timestamp is reached.
  *
@@ -126,13 +115,9 @@ int rte_power_monitor_wakeup(const unsigned int lcore_id);
  *   -EINVAL on invalid parameters
  *   -ENOTSUP if unsupported
  */
-__rte_experimental
 int rte_power_pause(const uint64_t tsc_timestamp);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Monitor a set of addresses for changes. This will cause the CPU to enter an
  * architecture-defined optimized power state until either one of the specified
  * memory addresses is written to, a certain TSC timestamp is reached, or other
@@ -160,7 +145,6 @@ int rte_power_pause(const uint64_t tsc_timestamp);
  *   -EINVAL on invalid parameters
  *   -ENOTSUP if unsupported
  */
-__rte_experimental
 int rte_power_monitor_multi(const struct rte_power_monitor_cond pmc[],
const uint32_t num, const uint64_t tsc_timestamp);
 
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 0dbd8b0573dd..3d4f6b5f79e6 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -233,6 +233,10 @@ DPDK_24 {
rte_mp_request_async;
rte_mp_request_sync;
rte_mp_sendmsg;
+   rte_power_monitor; # WINDOWS_NO_EXPORT
+   rte_power_monitor_wakeup; # WINDOWS_NO_EXPORT
+   rte_power_pause; # WINDOWS_NO_EXPORT
+   rte_power_monitor_multi; # WINDOWS_NO_EXPORT
rte_rand;
rte_rand_max;
rte_realloc;
@@ -378,11 +382,6 @@ EXPERIMENTAL {
rte_vect_get_max_simd_bitwidth;
rte_vect_set_max_simd_bitwidth;
 
-   # added in 21.02
-   rte_power_monitor; # WINDOWS_NO_EXPORT
-   rte_power_monitor_wakeup; # WINDOWS_NO_EXPORT
-   rte_power_pause; # WINDOWS_NO_EXPORT
-
# added in 21.05
rte_version_minor;
rte_version_month;
@@ -391,9 +390,6 @@ EXPERIMENTAL {
rte_version_suffix;
rte_version_year;
 
-   # added in 21.08
-   rte_power_monitor_multi; # WINDOWS_NO_EXPORT
-
# added in 21.11
 
# added in 23.03
-- 
2.39.2

[PATCH v2 12/14] eal: mark rte_eal_vfio_get_token stable

[Stephen Hemminger]

This API was added in 20.08 release.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_eal.h | 4 
 lib/eal/version.map   | 4 +---
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h
index cd318ee14152..c2256f832e51 100644
--- a/lib/eal/include/rte_eal.h
+++ b/lib/eal/include/rte_eal.h
@@ -409,16 +409,12 @@ int rte_eal_create_uio_dev(void);
 enum rte_intr_mode rte_eal_vfio_intr_mode(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Copy the user-configured vfio VF token.
  *
  * @param vf_token
  *   vfio VF token configured with the command line is copied
  *   into this parameter, zero uuid by default.
  */
-__rte_experimental
 void rte_eal_vfio_get_vf_token(rte_uuid_t vf_token);
 
 /**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 3d4f6b5f79e6..529963b61b15 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -88,6 +88,7 @@ DPDK_24 {
rte_eal_tailq_lookup;
rte_eal_tailq_register;
rte_eal_using_phys_addrs;
+   rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT
rte_eal_vfio_intr_mode; # WINDOWS_NO_EXPORT
rte_eal_wait_lcore;
rte_epoll_ctl;
@@ -373,9 +374,6 @@ EXPERIMENTAL {
rte_trace_regexp; # WINDOWS_NO_EXPORT
rte_trace_save; # WINDOWS_NO_EXPORT
 
-   # added in 20.08
-   rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT
-
# added in 20.11
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
-- 
2.39.2

[PATCH v2 13/14] eal: mark rte_vect simd bandwidth API as stable

[Stephen Hemminger]

These were added back in 20.11.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/generic/rte_vect.h | 8 
 lib/eal/version.map| 4 ++--
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/lib/eal/include/generic/rte_vect.h 
b/lib/eal/include/generic/rte_vect.h
index 777510cc3df4..2314eb9d374b 100644
--- a/lib/eal/include/generic/rte_vect.h
+++ b/lib/eal/include/generic/rte_vect.h
@@ -208,21 +208,14 @@ enum rte_vect_max_simd {
 };
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Get the supported SIMD bitwidth.
  *
  * @return
  *   uint16_t bitwidth.
  */
-__rte_experimental
 uint16_t rte_vect_get_max_simd_bitwidth(void);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
- *
  * Set the supported SIMD bitwidth.
  * This API should only be called once at initialization, before EAL init.
  *
@@ -233,7 +226,6 @@ uint16_t rte_vect_get_max_simd_bitwidth(void);
  *   - -EINVAL on invalid bitwidth parameter.
  *   - -EPERM if bitwidth is forced.
  */
-__rte_experimental
 int rte_vect_set_max_simd_bitwidth(uint16_t bitwidth);
 
 #endif /* _RTE_VECT_H_ */
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 529963b61b15..756f446524c2 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -314,6 +314,8 @@ DPDK_24 {
rte_uuid_is_null;
rte_uuid_parse;
rte_uuid_unparse;
+   rte_vect_get_max_simd_bitwidth;
+   rte_vect_set_max_simd_bitwidth;
rte_version;
rte_vfio_clear_group; # WINDOWS_NO_EXPORT
rte_vfio_container_create; # WINDOWS_NO_EXPORT
@@ -377,8 +379,6 @@ EXPERIMENTAL {
# added in 20.11
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
-   rte_vect_get_max_simd_bitwidth;
-   rte_vect_set_max_simd_bitwidth;
 
# added in 21.05
rte_version_minor;
-- 
2.39.2

[PATCH v2 14/14] eal: make rte_version API's stable

[Stephen Hemminger]

These have been around since 2020 releases.

Signed-off-by: Stephen Hemminger 
---
 lib/eal/include/rte_version.h |  6 --
 lib/eal/version.map   | 16 ++--
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/lib/eal/include/rte_version.h b/lib/eal/include/rte_version.h
index 414b6167f286..121d75bdbe28 100644
--- a/lib/eal/include/rte_version.h
+++ b/lib/eal/include/rte_version.h
@@ -35,37 +35,31 @@ extern "C" {
 /**
  * Function to return DPDK version prefix string
  */
-__rte_experimental
 const char *rte_version_prefix(void);
 
 /**
  * Function to return DPDK version year
  */
-__rte_experimental
 unsigned int rte_version_year(void);
 
 /**
  * Function to return DPDK version month
  */
-__rte_experimental
 unsigned int rte_version_month(void);
 
 /**
  * Function to return DPDK minor version number
  */
-__rte_experimental
 unsigned int rte_version_minor(void);
 
 /**
  * Function to return DPDK version suffix for any release candidates
  */
-__rte_experimental
 const char *rte_version_suffix(void);
 
 /**
  * Function to return DPDK version release candidate value
  */
-__rte_experimental
 unsigned int rte_version_release(void);
 
 /**
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 756f446524c2..a68986eb2773 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -317,6 +317,12 @@ DPDK_24 {
rte_vect_get_max_simd_bitwidth;
rte_vect_set_max_simd_bitwidth;
rte_version;
+   rte_version_minor;
+   rte_version_month;
+   rte_version_prefix;
+   rte_version_release;
+   rte_version_suffix;
+   rte_version_year;
rte_vfio_clear_group; # WINDOWS_NO_EXPORT
rte_vfio_container_create; # WINDOWS_NO_EXPORT
rte_vfio_container_destroy; # WINDOWS_NO_EXPORT
@@ -380,16 +386,6 @@ EXPERIMENTAL {
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT
rte_cpu_get_intrinsics_support; # WINDOWS_NO_EXPORT
 
-   # added in 21.05
-   rte_version_minor;
-   rte_version_month;
-   rte_version_prefix;
-   rte_version_release;
-   rte_version_suffix;
-   rte_version_year;
-
-   # added in 21.11
-
# added in 23.03
rte_lcore_register_usage_cb;
__rte_eal_trace_generic_blob;
-- 
2.39.2

Re: [PATCH] mempool: fix internal function documentation

[lihuisong (C)]

Acked-by: Huisong Li 

在 2023/10/20 22:46, Ferruh Yigit 写道:

static function `rte_mempool_do_generic_get()` returns zero on success,
not >=0 as its function comment documents.

Since this function called by public API, the comment causes confusion
on the public API return value.

Fixing the internal function documentation for return value.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Reported-by: Mahesh Adulla 
Signed-off-by: Ferruh Yigit 
---
  .mailmap  | 1 +
  lib/mempool/rte_mempool.h | 2 +-
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 3f5bab26a81f..bfe451980f1c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -836,6 +836,7 @@ Maciej Rabeda 
  Maciej Szwed 
  Madhu Chittim 
  Madhuker Mythri 
+Mahesh Adulla 
  Mahipal Challa 
  Mah Yock Gen 
  Mairtin o Loingsigh 
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index f70bf36080fb..86598bc639e6 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1484,7 +1484,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)
   * @param cache
   *   A pointer to a mempool cache structure. May be NULL if not needed.
   * @return
- *   - >=0: Success; number of objects supplied.
+ *   - 0: Success; number of objects supplied.
   *   - <0: Error; code of driver dequeue function.
   */
  static __rte_always_inline int

Re: [PATCH] ethdev: fix incorrect function name in comment

[lihuisong (C)]

在 2023/10/20 23:12, Ferruh Yigit 写道:

On 10/20/2023 2:05 PM, Bruce Richardson wrote:

For those using the function comments as a guide, provide the name of
the correct callback function to use when wanting to count dropped
packets from the ethdev tx buffering system.

Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 


Acked-by: Ferruh Yigit 


correct, rte_eth_count_unsent_packet_callback is not even exist.

Acked-by: Huisong Li 



.