RE: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf

[Naga Harish K, S V]

> -Original Message-
> From: Rahul Bhansali 
> Sent: Wednesday, September 20, 2023 10:18 PM
> To: dev@dpdk.org; Naga Harish K, S V ; Jerin
> Jacob ; Kundapura, Ganapati
> 
> Cc: Rahul Bhansali ; sta...@dpdk.org
> Subject: [PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf
> 
> For eventdev internal port, timestamp dynamic field registration in mbuf is 
> not
> required as that will be done from net device.
> For SW eventdev, Rx timestamp field registration will be done during Rxa
> service initialization.
> 
> Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf
> field")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Rahul Bhansali 

Acked-by: Naga Harish K S V 

> ---
> v3 changes:
> - timestamp register move before other Rxa init config.
> 
> v2 changes:
> - addresses the review comment to have registration in rxa_init_service()
> 
>  lib/eventdev/rte_event_eth_rx_adapter.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 3ebfa5366d..8df92247fa 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1910,6 +1910,13 @@ rxa_init_service(struct event_eth_rx_adapter
> *rx_adapter, uint8_t id)
>   if (rx_adapter->service_inited)
>   return 0;
> 
> + if (rte_mbuf_dyn_rx_timestamp_register(
> + &event_eth_rx_timestamp_dynfield_offset,
> + &event_eth_rx_timestamp_dynflag) != 0) {
> + RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> + return -rte_errno;
> + }
> +
>   memset(&service, 0, sizeof(service));
>   snprintf(service.name, ETH_RX_ADAPTER_SERVICE_NAME_LEN,
>   "rte_event_eth_rx_adapter_%d", id);
> @@ -2472,13 +2479,6 @@ rxa_create(uint8_t id, uint8_t dev_id,
>   if (conf_cb == rxa_default_conf_cb)
>   rx_adapter->default_cb_arg = 1;
> 
> - if (rte_mbuf_dyn_rx_timestamp_register(
> - &event_eth_rx_timestamp_dynfield_offset,
> - &event_eth_rx_timestamp_dynflag) != 0) {
> - RTE_EDEV_LOG_ERR("Error registering timestamp field in
> mbuf\n");
> - return -rte_errno;
> - }
> -
>   rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb,
>   conf_arg);
>   return 0;
> --
> 2.25.1

[PATCH v3] security: hide security context

[Akhil Goyal]

rte_security_ctx is used by all security APIs to identify
which device security_op it need to call and hence it should
be opaque to the application.
Hence, it is now moved to internal header file and all
APIs will now take an opaque pointer for it.
The fast path inline APIs like set metadata need to get flags
from security_ctx. The flags are now retrieved using inline APIs
which use macros to get the offset of flags in security_ctx.

Signed-off-by: Akhil Goyal 
Acked-by: Ciara Power 
---
Changes in v3: Updated release notes and removed deprecation notice.
Changes in v2: Rebased.

 app/test-crypto-perf/cperf_ops.c  |  9 +--
 app/test-crypto-perf/cperf_test_latency.c |  3 +-
 .../cperf_test_pmd_cyclecount.c   |  8 +-
 app/test-crypto-perf/cperf_test_throughput.c  |  9 +--
 app/test-crypto-perf/cperf_test_verify.c  |  4 +-
 app/test-security-perf/test_security_perf.c   |  2 +-
 app/test/test_cryptodev.c | 22 ++
 app/test/test_cryptodev_security_ipsec.c  |  2 +-
 app/test/test_cryptodev_security_ipsec.h  |  2 +-
 app/test/test_security_inline_macsec.c| 10 +--
 app/test/test_security_inline_proto.c | 14 ++--
 doc/guides/rel_notes/deprecation.rst  |  3 -
 doc/guides/rel_notes/release_23_11.rst|  3 +
 examples/ipsec-secgw/ipsec-secgw.c|  2 +-
 examples/ipsec-secgw/ipsec.c  | 15 ++--
 examples/ipsec-secgw/ipsec.h  |  2 +-
 examples/ipsec-secgw/ipsec_worker.c   |  2 +-
 examples/ipsec-secgw/ipsec_worker.h   |  4 +-
 lib/security/rte_security.c   | 61 +--
 lib/security/rte_security.h   | 77 +--
 lib/security/rte_security_driver.h| 24 ++
 21 files changed, 143 insertions(+), 135 deletions(-)

diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
index 93b9bfb240..84945d1313 100644
--- a/app/test-crypto-perf/cperf_ops.c
+++ b/app/test-crypto-perf/cperf_ops.c
@@ -749,8 +749,7 @@ create_ipsec_session(struct rte_mempool *sess_mp,
else
sess_conf.ipsec.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS;
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, sess_mp);
@@ -853,8 +852,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
.crypto_xform = &cipher_xform
};
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
@@ -901,8 +899,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
} },
.crypto_xform = &cipher_xform
};
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
diff --git a/app/test-crypto-perf/cperf_test_latency.c 
b/app/test-crypto-perf/cperf_test_latency.c
index f1676a9aa9..484bc9eb4e 100644
--- a/app/test-crypto-perf/cperf_test_latency.c
+++ b/app/test-crypto-perf/cperf_test_latency.c
@@ -53,8 +53,7 @@ cperf_latency_test_free(struct cperf_latency_ctx *ctx)
else if (ctx->options->op_type == CPERF_PDCP ||
 ctx->options->op_type == CPERF_DOCSIS ||
 ctx->options->op_type == CPERF_IPSEC) {
-   struct rte_security_ctx *sec_ctx =
-   rte_cryptodev_get_sec_ctx(ctx->dev_id);
+   void *sec_ctx = rte_cryptodev_get_sec_ctx(ctx->dev_id);
rte_security_session_destroy(sec_ctx, ctx->sess);
}
 #endif
diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c 
b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
index 0307e82996..4a60f6d558 100644
--- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
+++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
@@ -67,11 +67,9 @@ cperf_pmd_cyclecount_test_free(struct 
cperf_pmd_cyclecount_ctx *ctx)
 #ifdef RTE_LIB_SECURITY
if (ctx->options->op_type == CPERF_PDCP ||
ctx->options->op_type == CPERF_DOCSIS) {
-   struct rte_security_ctx *sec_ctx =
-   (struct rte_security_ctx *)
-   rte_cryptod

Re: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf

[Jerin Jacob]

On Mon, Sep 25, 2023 at 3:48 PM Naga Harish K, S V
 wrote:
>
> As per the DPDK contribution guidelines,
> Ideally, the review should be done within 1 week of patch submission to the 
> mailing list.
> https://doc.dpdk.org/guides/contributing/patches.html
>
> Surprised to see this review request ping message the very next day of the 
> patch.
> Better to follow the contribution guidelines.

+ @Thomas Monjalon @Ali Alnubani @Ferruh Yigit @David Marchand
@Andrew Rybchenko @Ajit Khaparde @Qi Zhang @Raslan Darawsheh @Maxime
Coquelin @cheng1.ji...@intel.com @Akhil Goyal @Richardson, Bruce

Yes, and I agree, and thanks for reporting this. I usually merge a set
of patches together and call for review action if something pending in
my list. I was not looking to the timestamp as it was manual.

Seems like good feature additions in patchwork if it not ready
available or if available then we can configure for DPDK.
i.e., if patchwork can track email time for the patch and flag for no
reviewed happened in N days(N as configurable) to help maintainers.
Also, Get list of pending patches on component maintainers(I think,
currently we can get only based on tree delegation) not per component
maintainer.


>
> -Harish

DPDK patch

[John Romein]

Dear Elena, Aaron,

I hope you had a nice time after the DPDK workshop.

I was unable to solve the issues with our mailserver to submit a patch 
with git sendmail.  So I created a pull request: 
https://github.com/DPDK/dpdk/pull/69
@Elena, could you please handle the pull request?  I will submit another 
pull request for the mempool_get_extmem optimization shortly.


Thanks,  John

Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset

[Bruce Richardson]

On Fri, Sep 15, 2023 at 01:02:49PM +, Shiyang He wrote:
> Originally, the iavf PMD does not perform special actions when it
> receives a PF-to-VF reset event, resulting in vf being offline and
> unavailable.
> 
> This patch enables vf auto-reset by setting 'watchdog_period' devargs
> to true. The iavf PMD will perform an automatic reset to bring the vf
> back online when it receives a PF-to-VF event.
> 
> v2: handling reset by event handler
> v3: change reset process
> 
> Signed-off-by: Shiyang He 
> Signed-off-by: Liang-Min Larry Wang 
> ---
>  doc/guides/nics/intel_vf.rst   |  3 +
>  doc/guides/rel_notes/release_23_11.rst |  3 +
>  drivers/net/iavf/iavf.h|  7 +++
>  drivers/net/iavf/iavf_ethdev.c | 86 +++---
>  drivers/net/iavf/iavf_rxtx.c   | 52 ++--
>  drivers/net/iavf/iavf_vchnl.c  | 11 +++-
>  6 files changed, 135 insertions(+), 27 deletions(-)
> 
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
> index d365dbc185..c0acd2a7f5 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the following 
> documents:
>  Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog 
> period in microseconds, or set it to 0 to disable the watchdog,
>  for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a 
> 18:01.0,watchdog_period=0``.
>  
> +Enable vf auto-reset by setting the ``devargs`` parameter like ``-a 
> 18:01.0,enable_auto_reset=1`` when IAVF is backed
> +by an Intel® E810 device or an Intel® 700 Series Ethernet device.
> +

Why do we need a devargs for this? If the VF is unavailable - as you
mention in the commit log above - should this behaviour not always be the
case without the user having to ask?

/Bruce

[PATCH v2] net/iavf: support no data path polling mode

[Mingjin Ye]

Currently, during a PF to VF reset due to an action such as changing
trust settings on a VF, the DPDK application running with iavf PMD
loses connectivity, and the only solution is to reset the DPDK
application.

Instead of forcing a reset of the DPDK application to restore
connectivity, the iavf PMD driver handles the PF to VF reset event
normally by performing all necessary steps to bring the VF back
online.

To minimize downtime, a devargs "no-poll-on-link-down" is introduced
in iavf PMD. When this flag is set, the PMD switches to no-poll mode
when the link state is down (rx/tx bursts return to 0 immediately).
When the link state returns to normal, the PMD switches to normal
rx/tx burst state.

Signed-off-by: Mingjin Ye 
---
 doc/guides/nics/intel_vf.rst|  3 ++
 drivers/net/iavf/iavf.h |  2 ++
 drivers/net/iavf/iavf_ethdev.c  | 16 +-
 drivers/net/iavf/iavf_rxtx.c| 29 +++--
 drivers/net/iavf/iavf_rxtx.h|  1 +
 drivers/net/iavf/iavf_rxtx_vec_avx2.c   | 29 ++---
 drivers/net/iavf/iavf_rxtx_vec_avx512.c | 42 ++---
 drivers/net/iavf/iavf_rxtx_vec_sse.c| 21 -
 drivers/net/iavf/iavf_vchnl.c   | 20 
 9 files changed, 150 insertions(+), 13 deletions(-)

diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
index 7613e1c5e5..19c461c3de 100644
--- a/doc/guides/nics/intel_vf.rst
+++ b/doc/guides/nics/intel_vf.rst
@@ -104,6 +104,9 @@ For more detail on SR-IOV, please refer to the following 
documents:
 Enable vf auto-reset by setting the ``devargs`` parameter like ``-a 
18:01.0,auto_reset=1`` when IAVF is backed
 by an Intel® E810 device or an Intel® 700 Series Ethernet device.
 
+Enable vf no-poll-on-link-down by setting the ``devargs`` parameter like 
``-a 18:01.0,no-poll-on-link-down=1`` when IAVF is backed
+by an Intel® E810 device or an Intel® 700 Series Ethernet device.
+
 The PCIE host-interface of Intel Ethernet Switch FM1 Series VF 
infrastructure
 
^
 
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index 04774ce124..71cb08f0b1 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -308,6 +308,7 @@ struct iavf_devargs {
uint16_t quanta_size;
uint32_t watchdog_period;
uint8_t  auto_reset;
+   uint16_t no_poll_on_link_down;
 };
 
 struct iavf_security_ctx;
@@ -326,6 +327,7 @@ struct iavf_adapter {
uint32_t ptype_tbl[IAVF_MAX_PKT_TYPE] __rte_cache_min_aligned;
bool stopped;
bool closed;
+   bool no_poll;
uint16_t fdir_ref_cnt;
struct iavf_devargs devargs;
 };
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 5b2634a4e3..98cc5c8ea8 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -38,7 +38,7 @@
 #define IAVF_QUANTA_SIZE_ARG   "quanta_size"
 #define IAVF_RESET_WATCHDOG_ARG"watchdog_period"
 #define IAVF_ENABLE_AUTO_RESET_ARG "auto_reset"
-
+#define IAVF_NO_POLL_ON_LINK_DOWN_ARG "no-poll-on-link-down"
 uint64_t iavf_timestamp_dynflag;
 int iavf_timestamp_dynfield_offset = -1;
 
@@ -47,6 +47,7 @@ static const char * const iavf_valid_args[] = {
IAVF_QUANTA_SIZE_ARG,
IAVF_RESET_WATCHDOG_ARG,
IAVF_ENABLE_AUTO_RESET_ARG,
+   IAVF_NO_POLL_ON_LINK_DOWN_ARG,
NULL
 };
 
@@ -2291,6 +2292,7 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
struct rte_kvargs *kvlist;
int ret;
int watchdog_period = -1;
+   uint16_t no_poll_on_link_down;
 
if (!devargs)
return 0;
@@ -2324,6 +2326,15 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
else
ad->devargs.watchdog_period = watchdog_period;
 
+   ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG,
+&parse_u16, &no_poll_on_link_down);
+   if (ret)
+   goto bail;
+   if (no_poll_on_link_down == 0)
+   ad->devargs.no_poll_on_link_down = 0;
+   else
+   ad->devargs.no_poll_on_link_down = 1;
+
if (ad->devargs.quanta_size != 0 &&
(ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||
 ad->devargs.quanta_size & 0x40)) {
@@ -2337,6 +2348,9 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
if (ret)
goto bail;
 
+   if (ad->devargs.auto_reset != 0)
+   ad->devargs.no_poll_on_link_down = 1;
+
 bail:
rte_kvargs_free(kvlist);
return ret;
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index 0484988d13..a5f63ce30d 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -777,6 +777,7 @@ iavf_dev_tx_queue_setup(struct rte_eth_dev *dev,
IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data

[PATCH v4] security: hide security context

[Akhil Goyal]

rte_security_ctx is used by all security APIs to identify
which device security_op it need to call and hence it should
be opaque to the application.
Hence, it is now moved to internal header file and all
APIs will now take an opaque pointer for it.
The fast path inline APIs like set metadata need to get flags
from security_ctx. The flags are now retrieved using inline APIs
which use macros to get the offset of flags in security_ctx.

Signed-off-by: Akhil Goyal 
Acked-by: Ciara Power 
---
Changes in v4: Updated rte_security doc.
Changes in v3: Updated release notes and removed deprecation notice.
Changes in v2: Rebased.

 app/test-crypto-perf/cperf_ops.c  |  9 +--
 app/test-crypto-perf/cperf_test_latency.c |  3 +-
 .../cperf_test_pmd_cyclecount.c   |  8 +-
 app/test-crypto-perf/cperf_test_throughput.c  |  9 +--
 app/test-crypto-perf/cperf_test_verify.c  |  4 +-
 app/test-security-perf/test_security_perf.c   |  2 +-
 app/test/test_cryptodev.c | 22 ++
 app/test/test_cryptodev_security_ipsec.c  |  2 +-
 app/test/test_cryptodev_security_ipsec.h  |  2 +-
 app/test/test_security_inline_macsec.c| 10 +--
 app/test/test_security_inline_proto.c | 14 ++--
 doc/guides/prog_guide/rte_security.rst|  2 +-
 doc/guides/rel_notes/deprecation.rst  |  3 -
 doc/guides/rel_notes/release_23_11.rst|  3 +
 examples/ipsec-secgw/ipsec-secgw.c|  2 +-
 examples/ipsec-secgw/ipsec.c  | 15 ++--
 examples/ipsec-secgw/ipsec.h  |  2 +-
 examples/ipsec-secgw/ipsec_worker.c   |  2 +-
 examples/ipsec-secgw/ipsec_worker.h   |  4 +-
 lib/security/rte_security.c   | 61 +--
 lib/security/rte_security.h   | 77 +--
 lib/security/rte_security_driver.h| 24 ++
 22 files changed, 144 insertions(+), 136 deletions(-)

diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
index 93b9bfb240..84945d1313 100644
--- a/app/test-crypto-perf/cperf_ops.c
+++ b/app/test-crypto-perf/cperf_ops.c
@@ -749,8 +749,7 @@ create_ipsec_session(struct rte_mempool *sess_mp,
else
sess_conf.ipsec.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS;
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, sess_mp);
@@ -853,8 +852,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
.crypto_xform = &cipher_xform
};
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
@@ -901,8 +899,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
} },
.crypto_xform = &cipher_xform
};
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
diff --git a/app/test-crypto-perf/cperf_test_latency.c 
b/app/test-crypto-perf/cperf_test_latency.c
index f1676a9aa9..484bc9eb4e 100644
--- a/app/test-crypto-perf/cperf_test_latency.c
+++ b/app/test-crypto-perf/cperf_test_latency.c
@@ -53,8 +53,7 @@ cperf_latency_test_free(struct cperf_latency_ctx *ctx)
else if (ctx->options->op_type == CPERF_PDCP ||
 ctx->options->op_type == CPERF_DOCSIS ||
 ctx->options->op_type == CPERF_IPSEC) {
-   struct rte_security_ctx *sec_ctx =
-   rte_cryptodev_get_sec_ctx(ctx->dev_id);
+   void *sec_ctx = rte_cryptodev_get_sec_ctx(ctx->dev_id);
rte_security_session_destroy(sec_ctx, ctx->sess);
}
 #endif
diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c 
b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
index 0307e82996..4a60f6d558 100644
--- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
+++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
@@ -67,11 +67,9 @@ cperf_pmd_cyclecount_test_free(struct 
cperf_pmd_cyclecount_ctx *ctx)
 #ifdef RTE_LIB_SECURITY
if (ctx->options->op_type == CPERF_PDCP ||
ctx->options->op_type == CPERF_DOCSIS) {
-   struct rte_security_ctx *sec_ctx =
-  

RE: [PATCH v4] security: hide security context

[Hemant Agrawal]

Acked-by: Hemant Agrawal 

RE: [PATCH v1 2/2] test/dma: add source buffer offload free test

[Amit Prakash Shukla]

Hi Anoob,

Thanks for the review and feedback. I will make the suggested changes in next 
version of the patch.

Thanks,
Amit Shukla

> -Original Message-
> From: Anoob Joseph 
> Sent: Tuesday, September 19, 2023 5:19 PM
> To: Amit Prakash Shukla ; Chengwen Feng
> ; Kevin Laatz ; Bruce
> Richardson 
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ;
> conor.wa...@intel.com; Vamsi Krishna Attunuru ;
> g.si...@nxp.com; sachin.sax...@oss.nxp.com; hemant.agra...@nxp.com;
> cheng1.ji...@intel.com; Nithin Kumar Dabilpuram
> ; Amit Prakash Shukla
> 
> Subject: RE: [PATCH v1 2/2] test/dma: add source buffer offload free test
> 
> Hi Amit,
> 
> Please see inline.
> 
> Thanks,
> Anoob
> 
> > -Original Message-
> > From: Amit Prakash Shukla 
> > Sent: Thursday, September 7, 2023 1:41 PM
> > To: Chengwen Feng ; Kevin Laatz
> > ; Bruce Richardson 
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ;
> > conor.wa...@intel.com; Vamsi Krishna Attunuru
> ;
> > g.si...@nxp.com; sachin.sax...@oss.nxp.com;
> hemant.agra...@nxp.com;
> > cheng1.ji...@intel.com; Nithin Kumar Dabilpuram
> > ; Anoob Joseph ;
> Amit
> > Prakash Shukla 
> > Subject: [PATCH v1 2/2] test/dma: add source buffer offload free test
> >
> > Add a test case to validate the functionality of drivers' dma source
> > buffer offload free. As part of dmadev_autotest, test case will be
> > executed only if the driver supports source buffer offload free and if
> > the test is exported by env variable DPDK_ADD_DMA_TEST.
> >
> > Signed-off-by: Amit Prakash Shukla 
> > ---
> >  app/test/test_dmadev.c | 132
> > -
> >  1 file changed, 131 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index
> > 6ef875e545..48da4664ae 100644
> > --- a/app/test/test_dmadev.c
> > +++ b/app/test/test_dmadev.c
> > @@ -18,11 +18,26 @@
> >
> >  #define ERR_RETURN(...) do { print_err(__func__, __LINE__,
> > __VA_ARGS__); return -1; } while (0)
> >
> > +#define TEST_RINGSIZE 512
> >  #define COPY_LEN 1024
> >
> >  static struct rte_mempool *pool;
> >  static uint16_t id_count;
> >
> > +enum {
> > +   TEST_SRC_BUF_FREE = 0,
> > +   TEST_MAX,
> > +};
> > +
> > +struct dma_add_test {
> > +   const char *name;
> > +   bool enabled;
> > +};
> > +
> > +struct dma_add_test dma_add_test[] = {
> > +   [TEST_SRC_BUF_FREE] = {.name = "sbuf_free", .enabled = false}, };
> > +
> >  static void
> >  __rte_format_printf(3, 4)
> >  print_err(const char *func, int lineno, const char *format, ...) @@
> > -797,10
> > +812,93 @@ test_burst_capacity(int16_t dev_id, uint16_t vchan)
> > return 0;
> >  }
> >
> > +static int
> > +test_sbuf_free(int16_t dev_id, uint16_t vchan) { #define NR_MBUF 256
> > +   int i, ret = 0;
> > +   int retry = 100;
> > +   uint16_t nb_done = 0;
> > +   bool dma_err = false;
> > +   uint32_t buf_cnt1, buf_cnt2;
> > +   struct rte_mempool_ops *ops;
> > +   uint64_t remote_addr = 0x4000ull;
> 
> [Anoob] Can you make remote_addr as a variable read from env variable?
> Hard coding may not be the right approach.
> 
> > +   struct rte_mbuf *src[NR_MBUF], *dst[NR_MBUF];
> > +   const struct rte_dma_vchan_conf qconf = {
> > +   .direction = RTE_DMA_DIR_MEM_TO_DEV,
> > +   .nb_desc = TEST_RINGSIZE,
> > +   .mem_to_dev_src_buf_pool = pool,
> > +   .dst_port.port_type = RTE_DMA_PORT_PCIE,
> > +   /* Assuming pemid as 0. */
> > +   .dst_port.pcie.coreid = 0,
> > +   };
> > +   static int dev_init;
> 
> [Anoob] Can you use bool instead of int for dev_init?
> 
> > +
> > +   if (!dev_init) {
> > +   /* Stop the device to reconfigure vchan. */
> > +   if (rte_dma_stop(dev_id) < 0)
> > +   ERR_RETURN("Error stopping device %u\n", dev_id);
> > +
> > +   if (rte_dma_vchan_setup(dev_id, vchan, &qconf) < 0)
> > +   ERR_RETURN("Error with queue configuration\n");
> > +
> > +   if (rte_dma_start(dev_id) != 0)
> > +   ERR_RETURN("Error with rte_dma_start()\n");
> > +
> > +   dev_init++;
> > +   }
> > +
> > +   if (rte_pktmbuf_alloc_bulk(pool, dst, NR_MBUF) != 0)
> > +   ERR_RETURN("alloc dst mbufs failed.\n");
> > +
> > +   for (i = 0; i < NR_MBUF; i++) {
> > +   /* Using mbuf structure to hold remote iova address. */
> > +   rte_mbuf_iova_set(dst[i], (rte_iova_t)remote_addr);
> > +   dst[i]->data_off = 0;
> > +   }
> > +
> > +   /* Capture buffer count before allocating source buffer. */
> > +   ops = rte_mempool_get_ops(pool->ops_index);
> > +   buf_cnt1 = ops->get_count(pool);
> > +
> > +   if (rte_pktmbuf_alloc_bulk(pool, src, NR_MBUF) != 0)
> > +   ERR_RETURN("alloc src mbufs failed.\n");
> 
> [Anoob] The memory is not freed in case of errors. May be you can free
> them in the end and use goto as required.
> 
> > +
> > +   if ((buf_cnt1 - NR_MBUF) != ops->get_count(pool))
> > +   ERR_RETURN("Buffer count check failed.\n");

RE: [PATCH v4] security: hide security context

[Akhil Goyal]

> Subject: [PATCH v4] security: hide security context
> 
> rte_security_ctx is used by all security APIs to identify
> which device security_op it need to call and hence it should
> be opaque to the application.
> Hence, it is now moved to internal header file and all
> APIs will now take an opaque pointer for it.
> The fast path inline APIs like set metadata need to get flags
> from security_ctx. The flags are now retrieved using inline APIs
> which use macros to get the offset of flags in security_ctx.
> 
> Signed-off-by: Akhil Goyal 
> Acked-by: Ciara Power 
Applied to dpdk-next-crypto

Re: [PATCH v13 2/4] net/i40e: implement mbufs recycle mode

[Ferruh Yigit]

On 9/25/2023 4:19 AM, Feifei Wang wrote:
> Define specific function implementation for i40e driver.
> Currently, mbufs recycle mode can support 128bit
> vector path and avx2 path. And can be enabled both in
> fast free and no fast free mode.
> 
> Suggested-by: Honnappa Nagarahalli 
> Signed-off-by: Feifei Wang 
> Reviewed-by: Ruifeng Wang 
> Reviewed-by: Honnappa Nagarahalli 
> 

Hi Konstantin,

I guess this patch was under discussion, can you please check the latest
version?



Hi Yuying, Beilei, Qiming, Wenjun,

This set includes i40e & ixgbe recycle_mbufs implementations, patch will
be merged if there is no objection.

RE: [PATCH v2 00/15] fixes and improvements to cnxk crypto PMD

[Anoob Joseph]

> 
> This series adds improvements and support for raw cryptodev API in cnxk
> crypto PMD.
> 
> v2:
> * Updated feature file for cn10k
> * Updated commit message
> 
> Aakash Sasidharan (1):
>   crypto/cnxk: add support for packets with cipher len zero
> 
> Anoob Joseph (4):
>   crypto/cnxk: clear rptr and dptr fields
>   common/cnxk: set cipher key only for non-null cipher
>   crypto/cnxk: add support for raw APIs
>   test/crypto: enable raw crypto tests for crypto_cn10k
> 
> Gowrishankar Muthukrishnan (1):
>   crypto/cnxk: update private key length in ECDSA param
> 
> Tejasree Kondoj (4):
>   crypto/cnxk: fix IPsec CCM and GCM capabilities
>   crypto/cnxk: remove pdcp chain bit from capabilities
>   crypto/cnxk: make IV pointers as constant
>   crypto/cnxk: set PDCP chain IV offset based on FVC
> 
> Vidya Sagar Velumuri (5):
>   common/cnxk: update SE context fields to match ucode spec
>   crypto/cnxk: check for sg version in SE engine capabilities
>   crypto/cnxk: fix control flow issues
>   crypto/cnxk: minor shuffling in the sess structure
>   crypto/cnxk: update the iv from proper param for gmac
> 
>  app/test/test_cryptodev.c |   8 +
>  doc/guides/cryptodevs/features/cn10k.ini  |   1 +
>  drivers/common/cnxk/hw/cpt.h  |   7 +-
>  drivers/common/cnxk/roc_se.c  |  11 +-
>  drivers/common/cnxk/roc_se.h  |  15 +-
>  drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 461 +++
>  drivers/crypto/cnxk/cnxk_ae.h |   4 +-
>  drivers/crypto/cnxk/cnxk_cryptodev.c  |  20 +-
>  .../crypto/cnxk/cnxk_cryptodev_capabilities.c |  10 +-
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  13 +-
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.h  |   6 +-
>  drivers/crypto/cnxk/cnxk_se.h | 527 ++
>  12 files changed, 937 insertions(+), 146 deletions(-)
> 
> --
> 2.25.1

Series Acked-by: Anoob Joseph 

RE: [PATCH v13 2/4] net/i40e: implement mbufs recycle mode

[Konstantin Ananyev]

> On 9/25/2023 4:19 AM, Feifei Wang wrote:
> > Define specific function implementation for i40e driver.
> > Currently, mbufs recycle mode can support 128bit
> > vector path and avx2 path. And can be enabled both in
> > fast free and no fast free mode.
> >
> > Suggested-by: Honnappa Nagarahalli 
> > Signed-off-by: Feifei Wang 
> > Reviewed-by: Ruifeng Wang 
> > Reviewed-by: Honnappa Nagarahalli 
> >
> 
> Hi Konstantin,
> 
> I guess this patch was under discussion, can you please check the latest
> version?

Hi Ferruh,

Yes, I saw the new version, but didn't have time yet, to review/ack it.
Will try to do it by today's COB. 
Konstantin
 
> 
> 
> 
> Hi Yuying, Beilei, Qiming, Wenjun,
> 
> This set includes i40e & ixgbe recycle_mbufs implementations, patch will
> be merged if there is no objection.

Re: [PATCH v4] ethdev: advertise flow restore in mbuf

[David Marchand]

Hello Ilya,

On Mon, Jul 31, 2023 at 10:40 PM Ilya Maximets  wrote:
> On 6/21/23 16:43, David Marchand wrote:
> > As reported by Ilya [1], unconditionally calling
> > rte_flow_get_restore_info() impacts an application performance for drivers
> > that do not provide this ops.
> > It could also impact processing of packets that require no call to
> > rte_flow_get_restore_info() at all.
> >
> > Register a dynamic mbuf flag when an application negotiates tunnel
> > metadata delivery (calling rte_eth_rx_metadata_negotiate() with
> > RTE_ETH_RX_METADATA_TUNNEL_ID).
> >
> > Drivers then advertise that metadata can be extracted by setting this
> > dynamic flag in each mbuf.
> >
> > The application then calls rte_flow_get_restore_info() only when required.
> >
> > Link: 
> > http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8-7f659bfa4...@ovn.org/
> > Signed-off-by: David Marchand 
> > Acked-by: Andrew Rybchenko 
> > Acked-by: Viacheslav Ovsiienko 
> > Tested-by: Ali Alnubani 
> > Acked-by: Ori Kam 
> > ---
> > Changes since RFC v3:
> > - rebased on next-net,
> > - sending as non RFC for CIs that skip RFC patches,
> >
> > Changes since RFC v2:
> > - fixed crash introduced in v2 and removed unneeded argument to
> >   rte_flow_restore_info_dynflag_register(),
> >
> > Changes since RFC v1:
> > - rebased,
> > - updated vectorized datapath functions for net/mlx5,
> > - moved dynamic flag register to rte_eth_rx_metadata_negotiate() and
> >   hid rte_flow_restore_info_dynflag_register() into ethdev internals,
> >
> > ---
> >  app/test-pmd/util.c  |  9 +++--
> >  drivers/net/mlx5/mlx5.c  |  2 +
> >  drivers/net/mlx5/mlx5.h  |  5 ++-
> >  drivers/net/mlx5/mlx5_flow.c | 47 +---
> >  drivers/net/mlx5/mlx5_rx.c   |  2 +-
> >  drivers/net/mlx5/mlx5_rx.h   |  1 +
> >  drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 16 
> >  drivers/net/mlx5/mlx5_rxtx_vec_neon.h|  6 +--
> >  drivers/net/mlx5/mlx5_rxtx_vec_sse.h |  6 +--
> >  drivers/net/mlx5/mlx5_trigger.c  |  4 +-
> >  drivers/net/sfc/sfc_dp.c | 14 +--
> >  lib/ethdev/rte_ethdev.c  |  5 +++
> >  lib/ethdev/rte_flow.c| 27 ++
> >  lib/ethdev/rte_flow.h| 18 -
> >  lib/ethdev/rte_flow_driver.h |  6 +++
> >  lib/ethdev/version.map   |  1 +
> >  16 files changed, 128 insertions(+), 41 deletions(-)
>
> 
>
> > diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h
> > index 356b60f523..f9fb01b8a2 100644
> > --- a/lib/ethdev/rte_flow_driver.h
> > +++ b/lib/ethdev/rte_flow_driver.h
> > @@ -376,6 +376,12 @@ struct rte_flow_ops {
> >  const struct rte_flow_ops *
> >  rte_flow_ops_get(uint16_t port_id, struct rte_flow_error *error);
> >
> > +/**
> > + * Register mbuf dynamic flag for rte_flow_get_restore_info.
> > + */
> > +int
> > +rte_flow_restore_info_dynflag_register(void);
> > +
>
> Hi, David, others.
>
> Is there a reason to not expose this function to the application?
>
> The point is that application will likely want to know the value
> of the flag before creating any devices.  I.e. request it once
> and use for all devices later without performing a call to an
> external library (DPDK).  In current implementation, application
> will need to open some device first, and only then the result of
> rte_flow_restore_info_dynflag() will become meaningful.
>
> There is no need to require application to call this function,
> it can still be called from the rx negotiation API, but it would
> be nice if application could know it beforehand, i.e. had control
> over when the flag is actually becomes visible.

DPDK tries to register flags only when needed, as there is not a lot
of space for dyn flags.
Some drivers take some space and applications want some share too.

DPDK can export the _register function for applications to call it
regardless of what driver will be used later.

Yet, I want to be sure why it matters in OVS context.
Is it not enough resolving the flag (by calling
rte_flow_restore_info_dynflag()) once rte_eth_rx_metadata_negotiate
for tunnel metadata is called?
Do you want to avoid an atomic store/load between OVS main thread and
PMD threads?


-- 
David Marchand

RE: [PATCH V2] ethdev: add flow API support for P4-programmable devices

[Ori Kam]

Hi,

> -Original Message-
> From: Cristian Dumitrescu 
> Sent: Monday, September 25, 2023 3:34 PM
> Subject: [PATCH V2] ethdev: add flow API support for P4-programmable
> devices
> 
> This patch introduces the new "program" action type to enable flow API
> support for P4-programmable devices.
> 
> In the case of P4-programmable devices, the device is initially blank.
> The flow items and actions are defined by the user (outside of any
> vendor control) through the P4 program, which is typically compiled
> into firmware that is loaded on the device at init time. These flow
> items and actions are then used during the run-time phase to add flows
> on the device.
> 
> Signed-off-by: Cristian Dumitrescu 
> Signed-off-by: Qi Zhang 
> ---
> Change log:
> 
> V2:
> -Adjusted field names and improved some comments based on Ori's
> feedback:
> https://mails.dpdk.org/archives/dev/2023-September/277358.html
> 
> V1:
> -Incorporated the feedback from the DPDK Summit 2023, sincere thanks
> to the many colleagues who contributed!
> -Based on Ori's suggestion, decided to reuse the existing "flex" flow
> item instead of defining a new flow item, so only the new "program"
> action type is required.
> 
> RFC:
> -RFC link: https://mails.dpdk.org/archives/dev/2023-August/273703.html
> 
>  lib/ethdev/rte_flow.h | 50 +++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index 2ebb76dbc0..fe2bb9c948 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -2981,6 +2981,15 @@ enum rte_flow_action_type {
>* @see struct rte_flow_action_indirect_list
>*/
>   RTE_FLOW_ACTION_TYPE_INDIRECT_LIST,
> +
> + /**
> +  * Program action. These actions are defined by the program currently
> +  * loaded on the device. For example, these actions are applicable to
> +  * devices that can be programmed through the P4 language.
> +  *
> +  * @see struct rte_flow_action_prog.
> +  */
> + RTE_FLOW_ACTION_TYPE_PROG,
>  };
> 
>  /**
> @@ -4055,6 +4064,48 @@ struct
> rte_flow_indirect_update_flow_meter_mark {
>   enum rte_color init_color;
>  };
> 
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice.
> + *
> + * Program action argument configuration parameters.
> + *
> + * For each action argument, its *size* must be non-zero and its *value*
> must
> + * point to a valid array of *size* bytes specified in network byte order.
> + *
> + * @see struct rte_flow_action_prog
> + */
> +struct rte_flow_action_prog_argument {
> + /** Argument name. */
> + const char *name;
> + /** Argument size in bytes. */
> + uint32_t size;
> + /** Argument value. */
> + const uint8_t *value;
> +};
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice.
> + *
> + * RTE_FLOW_ACTION_TYPE_PROG
> + *
> + * Program action configuration parameters.
> + *
> + * Each action can have zero or more arguments. When *args_num* is non-
> zero, the
> + * *args* parameter must point to a valid array of *args_num* elements.
> + *
> + * @see RTE_FLOW_ACTION_TYPE_PROG
> + */
> +struct rte_flow_action_prog {
> + /** Action name. */
> + const char *name;
> + /** Number of action arguments. */
> + uint32_t args_num;
> + /** Action arguments array. */
> + const struct rte_flow_action_prog_argument *args;
> +};
> +
>  /* Mbuf dynamic field offset for metadata. */
>  extern int32_t rte_flow_dynf_metadata_offs;
> 
> --
> 2.34.1


Acked-by: Ori Kam 
Best,
Ori

Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info

[Maxime Coquelin]

On 9/22/23 18:41, Chautru, Nicolas wrote:

Hi Maxime,


-Original Message-
From: Maxime Coquelin 
Sent: Friday, September 22, 2023 1:15 AM
To: Chautru, Nicolas ;
hemant.agra...@nxp.com; dev@dpdk.org
Cc: david.march...@redhat.com; Vargas, Hernan

Subject: Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info

Hi Nicolas,

On 9/19/23 22:51, Chautru, Nicolas wrote:

Hi Maxime,

This is neither part of 3GPP per se, nor specific to VRB device. Let me provide

more context.

The SRS processing chain

(https://doc.dpdk.org/guides/prog_guide/bbdev.html#bbdev-fft-operation)
includes a pointwise multiplication by time window.

The generic API include some control of these windowing function but still

the actual shape need to be programmed onto any device (ie. rectangular,
taped, sinc, different width or offset, any abritraty shape defined as an array
of scalars). These degrees of liberties cannot be exposed through a generic API
(information is multi-kB, ie the data itself) and can be user specific 
(external to
the HW IP itself or outside of Intel control).

Thanks for the explanations. I also did my homework as my FFT knowledge
was buried quite deep in my memory. :)

So this is a vendor-specific way to express generic paramaters.


Unsure this is that vendor specific. At least the interface allows to know a 
hash of the table being loaded (which is just pointwise data really, 
non-proprietary format). I did not state the content is a simple md5sum of the 
bin file being loaded from linux.


Ok, I think it would be better to provide an API to get the table
directly, and have the format being described in the documentation.

With that, we can also provide the hash as you'd like, but the method to 
calculate the hash should also be provided. Or the application can

perform the hash itself if it needs it.

The fact that it is several KB is not an issue, as this information
would only be queried once at init time if really needed.

An non-DPDK alternative could be to pass such information to the pod via
the device plugin (as a mounted file for instance, or variable).


Regarding VRB device, is this table per device or per VF?
Could it be configured by the application directly, or has it to be done through
the PF?


This is configured for the device at platform level, ie. through operator. 
Common to all application/devices. This captures the windows shape assumptions.


Thanks for the information!




As an illustration for VRB device pf_bb_config provides to user an option to

include such windowing data as an input ("FFT LUT bin file"), but more
generally at platform level for any bb device this big Look-Up Table or big
array can be configured on the host during platform initialization for a given
deployment or vendor.

What is required here is for the user application to have knowledge of what

version of such array is being used on the given platform, as this information
would be relevant to processing done outside of bbdev (notably for noise
estimate). Through that mechanism, the user can now map through that API
which possible file was being used, and act accordingly.

The content itself is not specified, for VRB we just use the md5sum of that

binary file (which is just a big array of int16 for point wise multiplication) 
so
that this can be used to share knowledge between initialized platform
configuration and at run-time user application assumption.

It is also important to under that the user/vendor may use any array or

shape (based on their algorithm) regardless of Intel or IP, and still be able to
share information mapping between what is configured on the platform
(multiple versions possible) and what the application enumerates.


I can add more details in the documentation indeed but above should

arguably make sense. The name FFT_version naming may be quite vague, this
is more related to the FFT pointwise windowing array variant assumed on the
platform. I did not want to impose for it to be an md5sum necessarily, hence
the vagueness, as it could be any hash shared between the device
programming and the user application related to the semi-static FFT
processing programming.


Let me know if unclear or if any other thought,


I think this is clear now to me.

In my opinion, this is not good to have this part of the BBDEV API, as every
vendor will have their own way to represent this.

Other alternative is to have a vendor specific API. This is far from ideal and
should be avoided as much as possible, but in this case the application has to
know anyways which device it is driving. It would be at least clear the field 
has
to be interpreted in a vendor-specific way.

@Hemant, I would be interested in your opinion. (I don't know if NXP has or
plans to have FFT accelerator IP)


Yes looking forward to it.


Thanks,
Maxime





Regards,
Maxime


Thanks
Nic


-Original Message-
From: Maxime Coquelin 
Sent: Tuesday, September 19, 2023 2:56 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc:

[PATCH] maintainers: update for hns3

[Jie Hai]

Dongdong Liu currently do not work for the hns3 PMD.
I will do the work, so update the hns3 maintainers.

Signed-off-by: Jie Hai 
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 698608cdb26a..72779b80355b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -718,7 +718,7 @@ F: doc/guides/nics/gve.rst
 F: doc/guides/nics/features/gve.ini
 
 Hisilicon hns3
-M: Dongdong Liu 
+M: Jie Hai 
 M: Yisen Zhuang 
 F: drivers/net/hns3/
 F: doc/guides/nics/hns3.rst
-- 
2.33.0

[PATCH v4 00/12] event DMA adapter library support

[Amit Prakash Shukla]

This series adds support for event DMA adapter library. API's defined
as part of this library can be used by the application for DMA transfer
of data using event based mechanism.

v4:
- Fixed compilation error.

v3:
- Resolved checkpatch warnings.
- Fixed compilation error on intel.
- Updated git commit message.

v2:
- Resolved review comments.
- Patch split into multiple patches.

Amit Prakash Shukla (12):
  eventdev: introduce event DMA adapter library
  eventdev: api to get DMA adapter capabilities
  eventdev: create and free API for DMA adapter
  eventdev: add API support for vchan add and delete
  eventdev: add support for DMA adapter service function
  eventdev: add support for DMA adapter start and stop
  eventdev: add support for DMA adapter service ID get
  eventdev: add DMA adapter support for runtime params
  eventdev: add support for DMA adapter stats
  eventdev: add support for DMA adapter enqueue
  eventdev: add DMA adapter event port get
  app/test: add event DMA adapter auto-test

 MAINTAINERS   |5 +
 app/test/meson.build  |1 +
 app/test/test_event_dma_adapter.c |  805 ++
 config/rte_config.h   |1 +
 doc/api/doxy-api-index.md |1 +
 doc/guides/eventdevs/features/default.ini |8 +
 doc/guides/prog_guide/event_dma_adapter.rst   |  264 +++
 doc/guides/prog_guide/eventdev.rst|8 +-
 .../img/event_dma_adapter_op_forward.svg  | 1086 +
 .../img/event_dma_adapter_op_new.svg  | 1079 +
 doc/guides/prog_guide/index.rst   |1 +
 doc/guides/rel_notes/release_23_11.rst|4 +-
 lib/eventdev/eventdev_pmd.h   |  175 +-
 lib/eventdev/eventdev_private.c   |   10 +
 lib/eventdev/meson.build  |4 +-
 lib/eventdev/rte_event_dma_adapter.c  | 1431 +
 lib/eventdev/rte_event_dma_adapter.h  |  582 +++
 lib/eventdev/rte_eventdev.c   |   23 +
 lib/eventdev/rte_eventdev.h   |   44 +
 lib/eventdev/rte_eventdev_core.h  |8 +-
 lib/eventdev/version.map  |   16 +
 lib/meson.build   |2 +-
 22 files changed, 5550 insertions(+), 8 deletions(-)
 create mode 100644 app/test/test_event_dma_adapter.c
 create mode 100644 doc/guides/prog_guide/event_dma_adapter.rst
 create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_forward.svg
 create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_new.svg
 create mode 100644 lib/eventdev/rte_event_dma_adapter.c
 create mode 100644 lib/eventdev/rte_event_dma_adapter.h

-- 
2.25.1

[PATCH v4 01/12] eventdev: introduce event DMA adapter library

[Amit Prakash Shukla]

Introduce event DMA adapter APIs. The change provides information
on adapter modes and usage. Application can use this event adapter
interface to transfer packets between DMA device and event device.

Signed-off-by: Amit Prakash Shukla 
---
 MAINTAINERS   |5 +
 doc/api/doxy-api-index.md |1 +
 doc/guides/eventdevs/features/default.ini |8 +
 doc/guides/prog_guide/event_dma_adapter.rst   |  264 
 doc/guides/prog_guide/eventdev.rst|8 +-
 .../img/event_dma_adapter_op_forward.svg  | 1086 +
 .../img/event_dma_adapter_op_new.svg  | 1079 
 doc/guides/prog_guide/index.rst   |1 +
 doc/guides/rel_notes/release_23_11.rst|4 +-
 lib/eventdev/eventdev_pmd.h   |  175 ++-
 lib/eventdev/eventdev_private.c   |   10 +
 lib/eventdev/meson.build  |1 +
 lib/eventdev/rte_event_dma_adapter.h  |  582 +
 lib/eventdev/rte_eventdev.h   |   44 +
 lib/eventdev/rte_eventdev_core.h  |8 +-
 lib/eventdev/version.map  |   16 +
 16 files changed, 3286 insertions(+), 6 deletions(-)
 create mode 100644 doc/guides/prog_guide/event_dma_adapter.rst
 create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_forward.svg
 create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_new.svg
 create mode 100644 lib/eventdev/rte_event_dma_adapter.h

diff --git a/MAINTAINERS b/MAINTAINERS
index a926155f26..a6b8fc88d0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -548,6 +548,11 @@ F: drivers/raw/skeleton/
 F: app/test/test_rawdev.c
 F: doc/guides/prog_guide/rawdev.rst
 
+Eventdev DMA Adapter API
+M: Amit Prakash Shukla 
+T: git://dpdk.org/next/dpdk-next-eventdev
+F: lib/eventdev/*dma_adapter*
+F: doc/guides/prog_guide/event_dma_adapter.rst
 
 Memory Pool Drivers
 ---
diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index fdeda13932..b7df7be4d9 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -29,6 +29,7 @@ The public API headers are grouped by topics:
   [event_eth_tx_adapter](@ref rte_event_eth_tx_adapter.h),
   [event_timer_adapter](@ref rte_event_timer_adapter.h),
   [event_crypto_adapter](@ref rte_event_crypto_adapter.h),
+  [event_dma_adapter](@ref rte_event_dma_adapter.h),
   [rawdev](@ref rte_rawdev.h),
   [metrics](@ref rte_metrics.h),
   [bitrate](@ref rte_bitrate.h),
diff --git a/doc/guides/eventdevs/features/default.ini 
b/doc/guides/eventdevs/features/default.ini
index 00360f60c6..73a52d915b 100644
--- a/doc/guides/eventdevs/features/default.ini
+++ b/doc/guides/eventdevs/features/default.ini
@@ -44,6 +44,14 @@ internal_port_op_fwd   =
 internal_port_qp_ev_bind   =
 session_private_data   =
 
+;
+; Features of a default DMA adapter.
+;
+[DMA adapter Features]
+internal_port_op_new   =
+internal_port_op_fwd   =
+internal_port_vchan_ev_bind =
+
 ;
 ; Features of a default Timer adapter.
 ;
diff --git a/doc/guides/prog_guide/event_dma_adapter.rst 
b/doc/guides/prog_guide/event_dma_adapter.rst
new file mode 100644
index 00..eeb9ce6dfd
--- /dev/null
+++ b/doc/guides/prog_guide/event_dma_adapter.rst
@@ -0,0 +1,264 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright (c) 2023 Marvell.
+
+Event DMA Adapter Library
+=
+
+DPDK :doc:`Eventdev library ` provides event driven programming 
model with features
+to schedule events. :doc:`DMA Device library ` provides an interface 
to DMA poll mode
+drivers that support DMA operations. Event DMA Adapter is intended to bridge 
between the event
+device and the DMA device.
+
+Packet flow from DMA device to the event device can be accomplished using 
software and hardware
+based transfer mechanisms. The adapter queries an eventdev PMD to determine 
which mechanism to
+be used. The adapter uses an EAL service core function for software based 
packet transfer and
+uses the eventdev PMD functions to configure hardware based packet transfer 
between DMA device
+and the event device. DMA adapter uses a new event type called 
``RTE_EVENT_TYPE_DMADEV`` to
+indicate the source of event.
+
+Application can choose to submit an DMA operation directly to an DMA device or 
send it to an DMA
+adapter via eventdev based on RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD 
capability. The
+first mode is known as the event new (RTE_EVENT_DMA_ADAPTER_OP_NEW) mode and 
the second as the
+event forward (RTE_EVENT_DMA_ADAPTER_OP_FORWARD) mode. Choice of mode can be 
specified while
+creating the adapter. In the former mode, it is the application's 
responsibility to enable
+ingress packet ordering. In the latter mode, it is the adapter's 
responsibility to enable
+ingress packet ordering.
+
+
+Adapter Modes
+-
+
+RTE_EVENT_DMA_ADAPTER_OP_NEW mode
+~
+
+In the RTE_EVENT_DMA_ADAPTER_OP_NEW mode,

[PATCH v4 02/12] eventdev: api to get DMA adapter capabilities

[Amit Prakash Shukla]

Added a new eventdev API rte_event_dma_adapter_caps_get(), to get
DMA adapter capabilities supported by the driver.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/meson.build|  2 +-
 lib/eventdev/rte_eventdev.c | 23 +++
 lib/eventdev/rte_eventdev.h |  2 +-
 lib/meson.build |  2 +-
 4 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
index 21347f7c4c..b46bbbc9aa 100644
--- a/lib/eventdev/meson.build
+++ b/lib/eventdev/meson.build
@@ -43,5 +43,5 @@ driver_sdk_headers += files(
 'event_timer_adapter_pmd.h',
 )
 
-deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev']
+deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev', 
'dmadev']
 deps += ['telemetry']
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 6ab4524332..60509c6efb 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -20,6 +20,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -224,6 +225,28 @@ rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t 
eth_port_id,
: 0;
 }
 
+int
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dma_dev_id, uint32_t 
*caps)
+{
+   struct rte_eventdev *dev;
+
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
+   if (!rte_dma_is_valid(dma_dev_id))
+   return -EINVAL;
+
+   dev = &rte_eventdevs[dev_id];
+
+   if (caps == NULL)
+   return -EINVAL;
+
+   *caps = 0;
+
+   if (dev->dev_ops->dma_adapter_caps_get)
+   return (*dev->dev_ops->dma_adapter_caps_get)(dev, dma_dev_id, 
caps);
+
+   return 0;
+}
+
 static inline int
 event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
 {
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index 2c6ecc7f8f..41743f91b1 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1504,7 +1504,7 @@ rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t 
cdev_id,
  */
 __rte_experimental
 int
-rte_event_dma_adapter_caps_get(uint8_t dev_id, int16_t dmadev_id, uint32_t 
*caps);
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dmadev_id, uint32_t 
*caps);
 
 /* Ethdev Tx adapter capability bitmap flags */
 #define RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT 0x1
diff --git a/lib/meson.build b/lib/meson.build
index 53155be8e9..f3191f10b6 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -33,6 +33,7 @@ libraries = [
 'compressdev',
 'cryptodev',
 'distributor',
+'dmadev',
 'efd',
 'eventdev',
 'gpudev',
@@ -48,7 +49,6 @@ libraries = [
 'rawdev',
 'regexdev',
 'mldev',
-'dmadev',
 'rib',
 'reorder',
 'sched',
-- 
2.25.1

[PATCH v4 03/12] eventdev: create and free API for DMA adapter

[Amit Prakash Shukla]

Added API support to create and free DMA adapter. Create function shall be
called with event device to be associated with the adapter and port
configuration to setup an event port.

Signed-off-by: Amit Prakash Shukla 
---
 config/rte_config.h  |   1 +
 lib/eventdev/meson.build |   1 +
 lib/eventdev/rte_event_dma_adapter.c | 335 +++
 3 files changed, 337 insertions(+)
 create mode 100644 lib/eventdev/rte_event_dma_adapter.c

diff --git a/config/rte_config.h b/config/rte_config.h
index 400e44e3cf..401727703f 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -77,6 +77,7 @@
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
 #define RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE 32
+#define RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE 32
 
 /* rawdev defines */
 #define RTE_RAWDEV_MAX_DEVS 64
diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
index b46bbbc9aa..250abcb154 100644
--- a/lib/eventdev/meson.build
+++ b/lib/eventdev/meson.build
@@ -17,6 +17,7 @@ sources = files(
 'eventdev_private.c',
 'eventdev_trace_points.c',
 'rte_event_crypto_adapter.c',
+'rte_event_dma_adapter.c',
 'rte_event_eth_rx_adapter.c',
 'rte_event_eth_tx_adapter.c',
 'rte_event_ring.c',
diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
new file mode 100644
index 00..c7ffba1b47
--- /dev/null
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -0,0 +1,335 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Marvell.
+ */
+
+#include "rte_eventdev.h"
+#include "eventdev_pmd.h"
+#include "rte_event_dma_adapter.h"
+
+#define DMA_BATCH_SIZE 32
+#define DMA_DEFAULT_MAX_NB 128
+#define DMA_ADAPTER_NAME_LEN 32
+#define DMA_ADAPTER_BUFFER_SIZE 1024
+
+#define DMA_ADAPTER_OPS_BUFFER_SIZE (DMA_BATCH_SIZE + DMA_BATCH_SIZE)
+
+#define DMA_ADAPTER_ARRAY "event_dma_adapter_array"
+
+/* Macros to check for valid adapter */
+#define EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
+   do { \
+   if (!edma_adapter_valid_id(id)) { \
+   RTE_EDEV_LOG_ERR("Invalid DMA adapter id = %d\n", id); \
+   return retval; \
+   } \
+   } while (0)
+
+/* DMA ops circular buffer */
+struct dma_ops_circular_buffer {
+   /* Index of head element */
+   uint16_t head;
+
+   /* Index of tail element */
+   uint16_t tail;
+
+   /* Number of elements in buffer */
+   uint16_t count;
+
+   /* Size of circular buffer */
+   uint16_t size;
+
+   /* Pointer to hold rte_event_dma_adapter_op for processing */
+   struct rte_event_dma_adapter_op **op_buffer;
+} __rte_cache_aligned;
+
+/* DMA device information */
+struct dma_device_info {
+   /* Number of vchans configured for a DMA device. */
+   uint16_t num_dma_dev_vchan;
+} __rte_cache_aligned;
+
+struct event_dma_adapter {
+   /* Event device identifier */
+   uint8_t eventdev_id;
+
+   /* Event port identifier */
+   uint8_t event_port_id;
+
+   /* Adapter mode */
+   enum rte_event_dma_adapter_mode mode;
+
+   /* Memory allocation name */
+   char mem_name[DMA_ADAPTER_NAME_LEN];
+
+   /* Socket identifier cached from eventdev */
+   int socket_id;
+
+   /* Lock to serialize config updates with service function */
+   rte_spinlock_t lock;
+
+   /* DMA device structure array */
+   struct dma_device_info *dma_devs;
+
+   /* Circular buffer for processing DMA ops to eventdev */
+   struct dma_ops_circular_buffer ebuf;
+
+   /* Configuration callback for rte_service configuration */
+   rte_event_dma_adapter_conf_cb conf_cb;
+
+   /* Configuration callback argument */
+   void *conf_arg;
+
+   /* Set if  default_cb is being used */
+   int default_cb_arg;
+} __rte_cache_aligned;
+
+static struct event_dma_adapter **event_dma_adapter;
+
+static inline int
+edma_adapter_valid_id(uint8_t id)
+{
+   return id < RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE;
+}
+
+static inline struct event_dma_adapter *
+edma_id_to_adapter(uint8_t id)
+{
+   return event_dma_adapter ? event_dma_adapter[id] : NULL;
+}
+
+static int
+edma_array_init(void)
+{
+   const struct rte_memzone *mz;
+   uint32_t sz;
+
+   mz = rte_memzone_lookup(DMA_ADAPTER_ARRAY);
+   if (mz == NULL) {
+   sz = sizeof(struct event_dma_adapter *) * 
RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE;
+   sz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);
+
+   mz = rte_memzone_reserve_aligned(DMA_ADAPTER_ARRAY, sz, 
rte_socket_id(), 0,
+RTE_CACHE_LINE_SIZE);
+   if (mz == NULL) {
+   RTE_EDEV_LOG_ERR("Failed to reserve memzone : %s, err = 
%d",
+DMA_ADAPTER_ARRAY, rte_errno);
+   return -rte_errno

[PATCH v4 04/12] eventdev: add API support for vchan add and delete

[Amit Prakash Shukla]

Added API support to add and delete vchan's from the DMA adapter. DMA devid
and vchan are added to the addapter instance by calling
rte_event_dma_adapter_vchan_add and
deleted using rte_event_dma_adapter_vchan_del.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 204 +++
 1 file changed, 204 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index c7ffba1b47..dd58188bf3 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -42,8 +42,31 @@ struct dma_ops_circular_buffer {
struct rte_event_dma_adapter_op **op_buffer;
 } __rte_cache_aligned;
 
+/* Vchan information */
+struct dma_vchan_info {
+   /* Set to indicate vchan queue is enabled */
+   bool vq_enabled;
+
+   /* Circular buffer for batching DMA ops to dma_dev */
+   struct dma_ops_circular_buffer dma_buf;
+} __rte_cache_aligned;
+
 /* DMA device information */
 struct dma_device_info {
+   /* Pointer to vchan queue info */
+   struct dma_vchan_info *vchanq;
+
+   /* Pointer to vchan queue info.
+* This holds ops passed by application till the
+* dma completion is done.
+*/
+   struct dma_vchan_info *tqmap;
+
+   /* If num_vchanq > 0, the start callback will
+* be invoked if not already invoked
+*/
+   uint16_t num_vchanq;
+
/* Number of vchans configured for a DMA device. */
uint16_t num_dma_dev_vchan;
 } __rte_cache_aligned;
@@ -81,6 +104,9 @@ struct event_dma_adapter {
 
/* Set if  default_cb is being used */
int default_cb_arg;
+
+   /* No. of vchan queue configured */
+   uint16_t nb_vchanq;
 } __rte_cache_aligned;
 
 static struct event_dma_adapter **event_dma_adapter;
@@ -333,3 +359,181 @@ rte_event_dma_adapter_free(uint8_t id)
 
return 0;
 }
+
+static void
+edma_update_vchanq_info(struct event_dma_adapter *adapter, struct 
dma_device_info *dev_info,
+   uint16_t vchan, uint8_t add)
+{
+   struct dma_vchan_info *vchan_info;
+   struct dma_vchan_info *tqmap_info;
+   int enabled;
+   uint16_t i;
+
+   if (dev_info->vchanq == NULL)
+   return;
+
+   if (vchan == RTE_DMA_ALL_VCHAN) {
+   for (i = 0; i < dev_info->num_dma_dev_vchan; i++)
+   edma_update_vchanq_info(adapter, dev_info, i, add);
+   } else {
+   tqmap_info = &dev_info->tqmap[vchan];
+   vchan_info = &dev_info->vchanq[vchan];
+   enabled = vchan_info->vq_enabled;
+   if (add) {
+   adapter->nb_vchanq += !enabled;
+   dev_info->num_vchanq += !enabled;
+   } else {
+   adapter->nb_vchanq -= enabled;
+   dev_info->num_vchanq -= enabled;
+   }
+   vchan_info->vq_enabled = !!add;
+   tqmap_info->vq_enabled = !!add;
+   }
+}
+
+int
+rte_event_dma_adapter_vchan_add(uint8_t id, int16_t dma_dev_id, uint16_t vchan,
+   const struct rte_event *event)
+{
+   struct event_dma_adapter *adapter;
+   struct dma_device_info *dev_info;
+   struct rte_eventdev *dev;
+   uint32_t cap;
+   int ret;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   if (!rte_dma_is_valid(dma_dev_id)) {
+   RTE_EDEV_LOG_ERR("Invalid dma_dev_id = %" PRIu8, dma_dev_id);
+   return -EINVAL;
+   }
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL)
+   return -EINVAL;
+
+   dev = &rte_eventdevs[adapter->eventdev_id];
+   ret = rte_event_dma_adapter_caps_get(adapter->eventdev_id, dma_dev_id, 
&cap);
+   if (ret) {
+   RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %u dma_dev 
%u", id, dma_dev_id);
+   return ret;
+   }
+
+   if ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) && 
(event == NULL)) {
+   RTE_EDEV_LOG_ERR("Event can not be NULL for dma_dev_id = %u", 
dma_dev_id);
+   return -EINVAL;
+   }
+
+   dev_info = &adapter->dma_devs[dma_dev_id];
+   if (vchan != RTE_DMA_ALL_VCHAN && vchan >= dev_info->num_dma_dev_vchan) 
{
+   RTE_EDEV_LOG_ERR("Invalid vhcan %u", vchan);
+   return -EINVAL;
+   }
+
+   /* In case HW cap is RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, no
+* need of service core as HW supports event forward capability.
+*/
+   if ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+   (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND &&
+adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW) ||
+   (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
+adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW)) {
+   if (*dev->dev_ops

[PATCH v4 05/12] eventdev: add support for DMA adapter service function

[Amit Prakash Shukla]

Added support for DMA adapter service function for event devices.
Enqueue and dequeue of event from eventdev and DMA device are done
based on the adapter mode and the supported HW capabilities.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 589 +++
 1 file changed, 589 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index dd58188bf3..8349b95796 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -2,6 +2,8 @@
  * Copyright (c) 2023 Marvell.
  */
 
+#include 
+
 #include "rte_eventdev.h"
 #include "eventdev_pmd.h"
 #include "rte_event_dma_adapter.h"
@@ -69,6 +71,10 @@ struct dma_device_info {
 
/* Number of vchans configured for a DMA device. */
uint16_t num_dma_dev_vchan;
+
+   /* Next queue pair to be processed */
+   uint16_t next_vchan_id;
+
 } __rte_cache_aligned;
 
 struct event_dma_adapter {
@@ -90,6 +96,9 @@ struct event_dma_adapter {
/* Lock to serialize config updates with service function */
rte_spinlock_t lock;
 
+   /* Next dma device to be processed */
+   uint16_t next_dmadev_id;
+
/* DMA device structure array */
struct dma_device_info *dma_devs;
 
@@ -107,6 +116,26 @@ struct event_dma_adapter {
 
/* No. of vchan queue configured */
uint16_t nb_vchanq;
+
+   /* Per adapter EAL service ID */
+   uint32_t service_id;
+
+   /* Service initialization state */
+   uint8_t service_initialized;
+
+   /* Max DMA ops processed in any service function invocation */
+   uint32_t max_nb;
+
+   /* Store event port's implicit release capability */
+   uint8_t implicit_release_disabled;
+
+   /* Flag to indicate backpressure at dma_dev
+* Stop further dequeuing events from eventdev
+*/
+   bool stop_enq_to_dma_dev;
+
+   /* Loop counter to flush dma ops */
+   uint16_t transmit_loop_count;
 } __rte_cache_aligned;
 
 static struct event_dma_adapter **event_dma_adapter;
@@ -148,6 +177,18 @@ edma_array_init(void)
return 0;
 }
 
+static inline bool
+edma_circular_buffer_batch_ready(struct dma_ops_circular_buffer *bufp)
+{
+   return bufp->count >= DMA_BATCH_SIZE;
+}
+
+static inline bool
+edma_circular_buffer_space_for_batch(struct dma_ops_circular_buffer *bufp)
+{
+   return (bufp->size - bufp->count) >= DMA_BATCH_SIZE;
+}
+
 static inline int
 edma_circular_buffer_init(const char *name, struct dma_ops_circular_buffer 
*buf, uint16_t sz)
 {
@@ -166,6 +207,67 @@ edma_circular_buffer_free(struct dma_ops_circular_buffer 
*buf)
rte_free(buf->op_buffer);
 }
 
+static inline int
+edma_circular_buffer_add(struct dma_ops_circular_buffer *bufp, struct 
rte_event_dma_adapter_op *op)
+{
+   uint16_t *tail = &bufp->tail;
+
+   bufp->op_buffer[*tail] = op;
+
+   /* circular buffer, go round */
+   *tail = (*tail + 1) % bufp->size;
+   bufp->count++;
+
+   return 0;
+}
+
+static inline int
+edma_circular_buffer_flush_to_dma_dev(struct event_dma_adapter *adapter,
+ struct dma_ops_circular_buffer *bufp, 
uint8_t dma_dev_id,
+ uint16_t vchan, uint16_t *nb_ops_flushed)
+{
+   struct rte_event_dma_adapter_op *op;
+   struct dma_vchan_info *tq;
+   uint16_t *head = &bufp->head;
+   uint16_t *tail = &bufp->tail;
+   uint16_t n;
+   uint16_t i;
+   int ret;
+
+   if (*tail > *head)
+   n = *tail - *head;
+   else if (*tail < *head)
+   n = bufp->size - *head;
+   else {
+   *nb_ops_flushed = 0;
+   return 0; /* buffer empty */
+   }
+
+   tq = &adapter->dma_devs[dma_dev_id].tqmap[vchan];
+
+   for (i = 0; i < n; i++) {
+   op = bufp->op_buffer[*head];
+   ret = rte_dma_copy_sg(dma_dev_id, vchan, op->src_seg, 
op->dst_seg,
+ op->nb_src, op->nb_dst, op->flags);
+   if (ret < 0)
+   break;
+
+   /* Enqueue in transaction queue. */
+   edma_circular_buffer_add(&tq->dma_buf, op);
+
+   *head = (*head + 1) % bufp->size;
+   }
+
+   *nb_ops_flushed = i;
+   bufp->count -= *nb_ops_flushed;
+   if (!bufp->count) {
+   *head = 0;
+   *tail = 0;
+   }
+
+   return *nb_ops_flushed == n ? 0 : -1;
+}
+
 static int
 edma_default_config_cb(uint8_t id, uint8_t evdev_id, struct 
rte_event_dma_adapter_conf *conf,
   void *arg)
@@ -360,6 +462,406 @@ rte_event_dma_adapter_free(uint8_t id)
return 0;
 }
 
+static inline unsigned int
+edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev, 
unsigned int cnt)
+{
+   struct dma_vchan_info *vchan_qinfo = NULL;
+   struct rte_event_dma_adapter_op *dma_op;
+   uint

[PATCH v4 06/12] eventdev: add support for DMA adapter start and stop

[Amit Prakash Shukla]

Added API support to start and stop DMA adapter.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 69 
 1 file changed, 69 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index 8349b95796..e5c2be3a2f 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -75,6 +75,13 @@ struct dma_device_info {
/* Next queue pair to be processed */
uint16_t next_vchan_id;
 
+   /* Set to indicate processing has been started */
+   uint8_t dev_started;
+
+   /* Set to indicate dmadev->eventdev packet
+* transfer uses a hardware mechanism
+*/
+   uint8_t internal_event_port;
 } __rte_cache_aligned;
 
 struct event_dma_adapter {
@@ -1126,3 +1133,65 @@ rte_event_dma_adapter_vchan_del(uint8_t id, int16_t 
dma_dev_id, uint16_t vchan)
 
return ret;
 }
+
+static int
+edma_adapter_ctrl(uint8_t id, int start)
+{
+   struct event_dma_adapter *adapter;
+   struct dma_device_info *dev_info;
+   struct rte_eventdev *dev;
+   uint16_t num_dma_dev;
+   int stop = !start;
+   int use_service;
+   uint32_t i;
+
+   use_service = 0;
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL)
+   return -EINVAL;
+
+   num_dma_dev = rte_dma_count_avail();
+   dev = &rte_eventdevs[adapter->eventdev_id];
+
+   for (i = 0; i < num_dma_dev; i++) {
+   dev_info = &adapter->dma_devs[i];
+   /* start check for num queue pairs */
+   if (start && !dev_info->num_vchanq)
+   continue;
+   /* stop check if dev has been started */
+   if (stop && !dev_info->dev_started)
+   continue;
+   use_service |= !dev_info->internal_event_port;
+   dev_info->dev_started = start;
+   if (dev_info->internal_event_port == 0)
+   continue;
+   start ? (*dev->dev_ops->dma_adapter_start)(dev, i) :
+   (*dev->dev_ops->dma_adapter_stop)(dev, i);
+   }
+
+   if (use_service)
+   rte_service_runstate_set(adapter->service_id, start);
+
+   return 0;
+}
+
+int
+rte_event_dma_adapter_start(uint8_t id)
+{
+   struct event_dma_adapter *adapter;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL)
+   return -EINVAL;
+
+   return edma_adapter_ctrl(id, 1);
+}
+
+int
+rte_event_dma_adapter_stop(uint8_t id)
+{
+   return edma_adapter_ctrl(id, 0);
+}
-- 
2.25.1

[PATCH v4 07/12] eventdev: add support for DMA adapter service ID get

[Amit Prakash Shukla]

Added API support to get DMA adapter service ID. Service id
returned in the variable by the API call shall be used by application
to map a service core.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 17 +
 1 file changed, 17 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index e5c2be3a2f..9e7ed622f2 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1134,6 +1134,23 @@ rte_event_dma_adapter_vchan_del(uint8_t id, int16_t 
dma_dev_id, uint16_t vchan)
return ret;
 }
 
+int
+rte_event_dma_adapter_service_id_get(uint8_t id, uint32_t *service_id)
+{
+   struct event_dma_adapter *adapter;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL || service_id == NULL)
+   return -EINVAL;
+
+   if (adapter->service_initialized)
+   *service_id = adapter->service_id;
+
+   return adapter->service_initialized ? 0 : -ESRCH;
+}
+
 static int
 edma_adapter_ctrl(uint8_t id, int start)
 {
-- 
2.25.1

[PATCH v4 08/12] eventdev: add DMA adapter support for runtime params

[Amit Prakash Shukla]

Added support to set and get runtime params for DMA adapter. The
parameters that can be set/get are defined in
struct rte_event_dma_adapter_runtime_params.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 93 
 1 file changed, 93 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index 9e7ed622f2..cf53e7f429 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1212,3 +1212,96 @@ rte_event_dma_adapter_stop(uint8_t id)
 {
return edma_adapter_ctrl(id, 0);
 }
+
+#define DEFAULT_MAX_NB 128
+
+int
+rte_event_dma_adapter_runtime_params_init(struct 
rte_event_dma_adapter_runtime_params *params)
+{
+   if (params == NULL)
+   return -EINVAL;
+
+   memset(params, 0, sizeof(*params));
+   params->max_nb = DEFAULT_MAX_NB;
+
+   return 0;
+}
+
+static int
+dma_adapter_cap_check(struct event_dma_adapter *adapter)
+{
+   uint32_t caps;
+   int ret;
+
+   if (!adapter->nb_vchanq)
+   return -EINVAL;
+
+   ret = rte_event_dma_adapter_caps_get(adapter->eventdev_id, 
adapter->next_dmadev_id, &caps);
+   if (ret) {
+   RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8 " 
cdev %" PRIu8,
+adapter->eventdev_id, adapter->next_dmadev_id);
+   return ret;
+   }
+
+   if ((caps & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+   (caps & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
+   return -ENOTSUP;
+
+   return 0;
+}
+
+int
+rte_event_dma_adapter_runtime_params_set(uint8_t id,
+struct 
rte_event_dma_adapter_runtime_params *params)
+{
+   struct event_dma_adapter *adapter;
+   int ret;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   if (params == NULL) {
+   RTE_EDEV_LOG_ERR("params pointer is NULL\n");
+   return -EINVAL;
+   }
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL)
+   return -EINVAL;
+
+   ret = dma_adapter_cap_check(adapter);
+   if (ret)
+   return ret;
+
+   rte_spinlock_lock(&adapter->lock);
+   adapter->max_nb = params->max_nb;
+   rte_spinlock_unlock(&adapter->lock);
+
+   return 0;
+}
+
+int
+rte_event_dma_adapter_runtime_params_get(uint8_t id,
+struct 
rte_event_dma_adapter_runtime_params *params)
+{
+   struct event_dma_adapter *adapter;
+   int ret;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   if (params == NULL) {
+   RTE_EDEV_LOG_ERR("params pointer is NULL\n");
+   return -EINVAL;
+   }
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL)
+   return -EINVAL;
+
+   ret = dma_adapter_cap_check(adapter);
+   if (ret)
+   return ret;
+
+   params->max_nb = adapter->max_nb;
+
+   return 0;
+}
-- 
2.25.1

[PATCH v4 09/12] eventdev: add support for DMA adapter stats

[Amit Prakash Shukla]

Added DMA adapter stats API support to get and reset stats. DMA
SW adapter stats and eventdev driver supported stats for enqueue
and dequeue are reported by get API.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 95 
 1 file changed, 95 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index cf53e7f429..35acec6caf 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -143,6 +143,9 @@ struct event_dma_adapter {
 
/* Loop counter to flush dma ops */
uint16_t transmit_loop_count;
+
+   /* Per instance stats structure */
+   struct rte_event_dma_adapter_stats dma_stats;
 } __rte_cache_aligned;
 
 static struct event_dma_adapter **event_dma_adapter;
@@ -472,6 +475,7 @@ rte_event_dma_adapter_free(uint8_t id)
 static inline unsigned int
 edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev, 
unsigned int cnt)
 {
+   struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
struct dma_vchan_info *vchan_qinfo = NULL;
struct rte_event_dma_adapter_op *dma_op;
uint16_t vchan, nb_enqueued = 0;
@@ -481,6 +485,7 @@ edma_enq_to_dma_dev(struct event_dma_adapter *adapter, 
struct rte_event *ev, uns
 
ret = 0;
n = 0;
+   stats->event_deq_count += cnt;
 
for (i = 0; i < cnt; i++) {
dma_op = ev[i].event_ptr;
@@ -503,6 +508,7 @@ edma_enq_to_dma_dev(struct event_dma_adapter *adapter, 
struct rte_event *ev, uns
ret = edma_circular_buffer_flush_to_dma_dev(adapter, 
&vchan_qinfo->dma_buf,
dma_dev_id, 
vchan,

&nb_enqueued);
+   stats->dma_enq_count += nb_enqueued;
n += nb_enqueued;
 
/**
@@ -549,6 +555,7 @@ edma_adapter_dev_flush(struct event_dma_adapter *adapter, 
int16_t dma_dev_id,
 static unsigned int
 edma_adapter_enq_flush(struct event_dma_adapter *adapter)
 {
+   struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
int16_t dma_dev_id;
uint16_t nb_enqueued = 0;
uint16_t nb_ops_flushed = 0;
@@ -563,6 +570,8 @@ edma_adapter_enq_flush(struct event_dma_adapter *adapter)
if (!nb_ops_flushed)
adapter->stop_enq_to_dma_dev = false;
 
+   stats->dma_enq_count += nb_enqueued;
+
return nb_enqueued;
 }
 
@@ -574,6 +583,7 @@ edma_adapter_enq_flush(struct event_dma_adapter *adapter)
 static int
 edma_adapter_enq_run(struct event_dma_adapter *adapter, unsigned int max_enq)
 {
+   struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
uint8_t event_port_id = adapter->event_port_id;
uint8_t event_dev_id = adapter->eventdev_id;
struct rte_event ev[DMA_BATCH_SIZE];
@@ -593,6 +603,7 @@ edma_adapter_enq_run(struct event_dma_adapter *adapter, 
unsigned int max_enq)
break;
}
 
+   stats->event_poll_count++;
n = rte_event_dequeue_burst(event_dev_id, event_port_id, ev, 
DMA_BATCH_SIZE, 0);
 
if (!n)
@@ -613,6 +624,7 @@ static inline uint16_t
 edma_ops_enqueue_burst(struct event_dma_adapter *adapter, struct 
rte_event_dma_adapter_op **ops,
   uint16_t num)
 {
+   struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
uint8_t event_port_id = adapter->event_port_id;
uint8_t event_dev_id = adapter->eventdev_id;
struct rte_event events[DMA_BATCH_SIZE];
@@ -652,6 +664,10 @@ edma_ops_enqueue_burst(struct event_dma_adapter *adapter, 
struct rte_event_dma_a
 
} while (retry++ < DMA_ADAPTER_MAX_EV_ENQ_RETRIES && nb_enqueued < 
nb_ev);
 
+   stats->event_enq_fail_count += nb_ev - nb_enqueued;
+   stats->event_enq_count += nb_enqueued;
+   stats->event_enq_retry_count += retry - 1;
+
return nb_enqueued;
 }
 
@@ -706,6 +722,7 @@ edma_ops_buffer_flush(struct event_dma_adapter *adapter)
 static inline unsigned int
 edma_adapter_deq_run(struct event_dma_adapter *adapter, unsigned int max_deq)
 {
+   struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
struct dma_vchan_info *vchan_info;
struct dma_ops_circular_buffer *tq_buf;
struct rte_event_dma_adapter_op *ops;
@@ -743,6 +760,7 @@ edma_adapter_deq_run(struct event_dma_adapter *adapter, 
unsigned int max_deq)
continue;
 
done = false;
+   stats->dma_deq_count += n;
 
tq_buf = &dev_info->tqmap[vchan].dma_buf;
 
@@ -1305,3 +1323,80 @@ rte_event_dma_adapter_runtime_params_get(uint8_t id,
 
return 0;
 }
+
+int
+rte_event_dma_adapter_stats_get(uint8_t id,

[PATCH v4 10/12] eventdev: add support for DMA adapter enqueue

[Amit Prakash Shukla]

Added API support to enqueue a DMA operation to the DMA driver.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 13 +
 1 file changed, 13 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index 35acec6caf..9770b0b8df 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1400,3 +1400,16 @@ rte_event_dma_adapter_stats_reset(uint8_t id)
 
return 0;
 }
+
+uint16_t
+rte_event_dma_adapter_enqueue(uint8_t dev_id, uint8_t port_id, struct 
rte_event ev[],
+ uint16_t nb_events)
+{
+   const struct rte_event_fp_ops *fp_ops;
+   void *port;
+
+   fp_ops = &rte_event_fp_ops[dev_id];
+   port = fp_ops->data[port_id];
+
+   return fp_ops->dma_enqueue(port, ev, nb_events);
+}
-- 
2.25.1

[PATCH v4 11/12] eventdev: add DMA adapter event port get

[Amit Prakash Shukla]

Added support for DMA adapter event port get.

Signed-off-by: Amit Prakash Shukla 
---
 lib/eventdev/rte_event_dma_adapter.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/lib/eventdev/rte_event_dma_adapter.c 
b/lib/eventdev/rte_event_dma_adapter.c
index 9770b0b8df..2b0919d705 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -472,6 +472,22 @@ rte_event_dma_adapter_free(uint8_t id)
return 0;
 }
 
+int
+rte_event_dma_adapter_event_port_get(uint8_t id, uint8_t *event_port_id)
+{
+   struct event_dma_adapter *adapter;
+
+   EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+   adapter = edma_id_to_adapter(id);
+   if (adapter == NULL || event_port_id == NULL)
+   return -EINVAL;
+
+   *event_port_id = adapter->event_port_id;
+
+   return 0;
+}
+
 static inline unsigned int
 edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev, 
unsigned int cnt)
 {
-- 
2.25.1

[PATCH v4 12/12] app/test: add event DMA adapter auto-test

[Amit Prakash Shukla]

Added testsuite to test the dma adapter functionality.
The testsuite detects event and DMA device capability
and accordingly dma adapter is configured and modes are
tested.

Signed-off-by: Amit Prakash Shukla 
---
 app/test/meson.build  |   1 +
 app/test/test_event_dma_adapter.c | 805 ++
 2 files changed, 806 insertions(+)
 create mode 100644 app/test/test_event_dma_adapter.c

diff --git a/app/test/meson.build b/app/test/meson.build
index 05bae9216d..7caf5ae5fc 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -66,6 +66,7 @@ source_file_deps = {
 'test_errno.c': [],
 'test_ethdev_link.c': ['ethdev'],
 'test_event_crypto_adapter.c': ['cryptodev', 'eventdev', 'bus_vdev'],
+'test_event_dma_adapter.c': ['dmadev', 'eventdev', 'bus_vdev'],
 'test_event_eth_rx_adapter.c': ['ethdev', 'eventdev', 'bus_vdev'],
 'test_event_eth_tx_adapter.c': ['bus_vdev', 'ethdev', 'net_ring', 
'eventdev'],
 'test_event_ring.c': ['eventdev'],
diff --git a/app/test/test_event_dma_adapter.c 
b/app/test/test_event_dma_adapter.c
new file mode 100644
index 00..fe1311e7f8
--- /dev/null
+++ b/app/test/test_event_dma_adapter.c
@@ -0,0 +1,805 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Marvell.
+ */
+
+#include "test.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#ifdef RTE_EXEC_ENV_WINDOWS
+static int
+test_event_dma_adapter(void)
+{
+   printf("event_dma_adapter not supported on Windows, skipping test\n");
+   return TEST_SKIPPED;
+}
+
+#else
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define NUM_MBUFS (8191)
+#define MBUF_CACHE_SIZE   (256)
+#define TEST_APP_PORT_ID   0
+#define TEST_APP_EV_QUEUE_ID   0
+#define TEST_APP_EV_PRIORITY   0
+#define TEST_APP_EV_FLOWID 0xAABB
+#define TEST_DMA_EV_QUEUE_ID   1
+#define TEST_ADAPTER_ID0
+#define TEST_DMA_DEV_ID0
+#define TEST_DMA_VCHAN_ID  0
+#define PACKET_LENGTH  1024
+#define NB_TEST_PORTS  1
+#define NB_TEST_QUEUES 2
+#define NUM_CORES  2
+#define DMA_OP_POOL_SIZE   128
+#define TEST_MAX_OP128
+#define TEST_RINGSIZE  512
+
+#define MBUF_SIZE  (RTE_PKTMBUF_HEADROOM + PACKET_LENGTH)
+
+/* Handle log statements in same manner as test macros */
+#define LOG_DBG(...)RTE_LOG(DEBUG, EAL, __VA_ARGS__)
+
+struct event_dma_adapter_test_params {
+   struct rte_mempool *src_mbuf_pool;
+   struct rte_mempool *dst_mbuf_pool;
+   struct rte_mempool *op_mpool;
+   uint8_t dma_event_port_id;
+   uint8_t internal_port_op_fwd;
+};
+
+struct rte_event dma_response_info = {
+   .queue_id = TEST_APP_EV_QUEUE_ID,
+   .sched_type = RTE_SCHED_TYPE_ATOMIC,
+   .flow_id = TEST_APP_EV_FLOWID,
+   .priority = TEST_APP_EV_PRIORITY
+};
+
+static struct event_dma_adapter_test_params params;
+static uint8_t dma_adapter_setup_done;
+static uint32_t slcore_id;
+static int evdev;
+
+static int
+send_recv_ev(struct rte_event *ev)
+{
+   struct rte_event recv_ev[TEST_MAX_OP];
+   uint16_t nb_enqueued = 0;
+   int i = 0;
+
+   if (params.internal_port_op_fwd) {
+   nb_enqueued = rte_event_dma_adapter_enqueue(evdev, 
TEST_APP_PORT_ID, ev,
+   TEST_MAX_OP);
+   } else {
+   while (nb_enqueued < TEST_MAX_OP) {
+   nb_enqueued += rte_event_enqueue_burst(evdev, 
TEST_APP_PORT_ID,
+  
&ev[nb_enqueued], TEST_MAX_OP -
+  nb_enqueued);
+   }
+   }
+
+   TEST_ASSERT_EQUAL(nb_enqueued, TEST_MAX_OP, "Failed to send event to 
dma adapter\n");
+
+   while (i < TEST_MAX_OP) {
+   if (rte_event_dequeue_burst(evdev, TEST_APP_PORT_ID, 
&recv_ev[i], 1, 0) != 1)
+   continue;
+   i++;
+   }
+
+   TEST_ASSERT_EQUAL(i, TEST_MAX_OP, "Test failed. Failed to dequeue 
events.\n");
+
+   return TEST_SUCCESS;
+}
+
+static int
+test_dma_adapter_stats(void)
+{
+   struct rte_event_dma_adapter_stats stats;
+
+   rte_event_dma_adapter_stats_get(TEST_ADAPTER_ID, &stats);
+   printf(" +--+\n");
+   printf(" + DMA adapter stats for instance %u:\n", TEST_ADAPTER_ID);
+   printf(" + Event port poll count 0x%" PRIx64 "\n",
+   stats.event_poll_count);
+   printf(" + Event dequeue count   0x%" PRIx64 "\n",
+   stats.event_deq_count);
+   printf(" + DMA dev enqueue count 0x%" PRIx64 "\n",
+   stats.dma_enq_count);
+   printf(" + DMA dev enqueue failed count  0x%" PRIx64 "\n",
+   stats.dma_enq_fail_count);
+   prin

[PATCH v6 00/12] add CLI based graph application

[skori]

From: Sunil Kumar Kori 

In the continuation of following feedback
https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vattun...@marvell.com/
this patch series adds dpdk-graph application to exercise various
usecases using graph.

1. Each use case is defined in terms of .cli file which will contain
set of commands to configure the system and to create a graph for
that use case.

2. Each module like ethdev, mempool, route etc exposes its set of commands
to do global and node specific configuration.

3. Command parsing is backed by command line library.

Rakesh Kudurumalla (5):
  app/graph: add mempool command line interfaces
  app/graph: add ipv6_lookup command line interfaces
  app/graph: add ethdev_rx command line interfaces
  app/graph: add graph command line interfaces
  app/graph: add l3fwd use case

Sunil Kumar Kori (7):
  app/graph: add application framework to read CLI
  app/graph: add telnet connectivity framework
  app/graph: add parser utility APIs
  app/graph: add ethdev command line interfaces
  app/graph: add ipv4_lookup command line interfaces
  app/graph: add neigh command line interfaces
  app/graph: add CLI option to enable graph stats

 MAINTAINERS  |   7 +
 app/graph/cli.c  | 136 +++
 app/graph/cli.h  |  32 +
 app/graph/conn.c | 282 ++
 app/graph/conn.h |  46 +
 app/graph/ethdev.c   | 885 +++
 app/graph/ethdev.h   |  40 +
 app/graph/ethdev_priv.h  | 112 +++
 app/graph/ethdev_rx.c| 165 
 app/graph/ethdev_rx.h|  37 +
 app/graph/ethdev_rx_priv.h   |  39 +
 app/graph/examples/l3fwd.cli |  87 ++
 app/graph/graph.c| 536 +++
 app/graph/graph.h|  20 +
 app/graph/graph_priv.h   |  70 ++
 app/graph/ip4_route.c| 205 +
 app/graph/ip6_route.c| 210 +
 app/graph/l3fwd.c| 136 +++
 app/graph/l3fwd.h|  11 +
 app/graph/main.c | 237 +
 app/graph/mempool.c  | 140 +++
 app/graph/mempool.h  |  24 +
 app/graph/mempool_priv.h |  34 +
 app/graph/meson.build|  24 +
 app/graph/module_api.h   |  31 +
 app/graph/neigh.c| 331 +++
 app/graph/neigh.h|  17 +
 app/graph/neigh_priv.h   |  49 +
 app/graph/route.h|  40 +
 app/graph/route_priv.h   |  44 +
 app/graph/utils.c| 156 
 app/graph/utils.h|  14 +
 app/meson.build  |   1 +
 doc/guides/tools/graph.rst   | 241 +
 doc/guides/tools/img/graph-usecase-l3fwd.svg | 210 +
 doc/guides/tools/index.rst   |   1 +
 36 files changed, 4650 insertions(+)
 create mode 100644 app/graph/cli.c
 create mode 100644 app/graph/cli.h
 create mode 100644 app/graph/conn.c
 create mode 100644 app/graph/conn.h
 create mode 100644 app/graph/ethdev.c
 create mode 100644 app/graph/ethdev.h
 create mode 100644 app/graph/ethdev_priv.h
 create mode 100644 app/graph/ethdev_rx.c
 create mode 100644 app/graph/ethdev_rx.h
 create mode 100644 app/graph/ethdev_rx_priv.h
 create mode 100644 app/graph/examples/l3fwd.cli
 create mode 100644 app/graph/graph.c
 create mode 100644 app/graph/graph.h
 create mode 100644 app/graph/graph_priv.h
 create mode 100644 app/graph/ip4_route.c
 create mode 100644 app/graph/ip6_route.c
 create mode 100644 app/graph/l3fwd.c
 create mode 100644 app/graph/l3fwd.h
 create mode 100644 app/graph/main.c
 create mode 100644 app/graph/mempool.c
 create mode 100644 app/graph/mempool.h
 create mode 100644 app/graph/mempool_priv.h
 create mode 100644 app/graph/meson.build
 create mode 100644 app/graph/module_api.h
 create mode 100644 app/graph/neigh.c
 create mode 100644 app/graph/neigh.h
 create mode 100644 app/graph/neigh_priv.h
 create mode 100644 app/graph/route.h
 create mode 100644 app/graph/route_priv.h
 create mode 100644 app/graph/utils.c
 create mode 100644 app/graph/utils.h
 create mode 100644 doc/guides/tools/graph.rst
 create mode 100644 doc/guides/tools/img/graph-usecase-l3fwd.svg

-- 
2.25.1

[PATCH v6 01/12] app/graph: add application framework to read CLI

[skori]

From: Sunil Kumar Kori 

It adds base framework to read a given .cli file as a command line
parameter "-s".

Example:
 # ./dpdk-graph -c 0xff -- -s ./app/graph/examples/dummy.cli

Each .cli file will contain commands to configure different module like
mempool, ethdev, lookup tables, graph etc. Command parsing is backed by
commandline library.

Each module needs to expose its supported commands & corresponding
callback functions to commandline library to get them parsed.

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
v5..v6:
 - Fix build errors.
 - Fix checkpatch errors.
 - Fix individual patch build errors.

v4..v5:
 - Fix application exit issue.
 - Enable graph packet capture feature.
 - Fix graph coremask synchronization with eal coremask.
 - Update user guide.

https://patches.dpdk.org/project/dpdk/patch/20230919160455.1678716-1-sk...@marvell.com/

v3..v4:
 - Use commandline library to parse command tokens.
 - Split to multiple smaller patches.
 - Make neigh and route as dynamic database.
 - add ethdev and graph stats command via telnet.
 - Update user guide.

https://patches.dpdk.org/project/dpdk/patch/20230908104907.4060511-1-sk...@marvell.com/

 MAINTAINERS|   7 ++
 app/graph/cli.c| 113 
 app/graph/cli.h|  32 ++
 app/graph/main.c   | 128 +
 app/graph/meson.build  |  14 
 app/graph/module_api.h |  16 +
 app/meson.build|   1 +
 doc/guides/tools/graph.rst |  82 
 doc/guides/tools/index.rst |   1 +
 9 files changed, 394 insertions(+)
 create mode 100644 app/graph/cli.c
 create mode 100644 app/graph/cli.h
 create mode 100644 app/graph/main.c
 create mode 100644 app/graph/meson.build
 create mode 100644 app/graph/module_api.h
 create mode 100644 doc/guides/tools/graph.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index 00f5a5f9e6..7998be98f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1811,6 +1811,13 @@ F: dts/
 F: devtools/dts-check-format.sh
 F: doc/guides/tools/dts.rst
 
+Graph application
+M: Sunil Kumar Kori 
+M: Rakesh Kudurumalla 
+F: app/graph/
+F: doc/guides/tools/graph.rst
+F: doc/guides/tools/img/graph-usecase-l3fwd.svg
+
 
 Other Example Applications
 --
diff --git a/app/graph/cli.c b/app/graph/cli.c
new file mode 100644
index 00..473fa1635a
--- /dev/null
+++ b/app/graph/cli.c
@@ -0,0 +1,113 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "module_api.h"
+
+#define CMD_MAX_TOKENS 256
+#define MAX_LINE_SIZE 2048
+
+cmdline_parse_ctx_t modules_ctx[] = {
+   NULL,
+};
+
+static struct cmdline *cl;
+
+static int
+is_comment(char *in)
+{
+   if ((strlen(in) && index("!#%;", in[0])) ||
+   (strncmp(in, "//", 2) == 0) ||
+   (strncmp(in, "--", 2) == 0))
+   return 1;
+
+   return 0;
+}
+
+void
+cli_init(void)
+{
+   cl = cmdline_stdin_new(modules_ctx, "");
+}
+
+void
+cli_exit(void)
+{
+   cmdline_stdin_exit(cl);
+}
+
+void
+cli_process(char *in, char *out, size_t out_size, __rte_unused void *obj)
+{
+   int rc;
+
+   if (is_comment(in))
+   return;
+
+   rc = cmdline_parse(cl, in);
+   if (rc == CMDLINE_PARSE_AMBIGUOUS)
+   snprintf(out, out_size, MSG_CMD_FAIL, "Ambiguous command");
+   else if (rc == CMDLINE_PARSE_NOMATCH)
+   snprintf(out, out_size, MSG_CMD_FAIL, "Command mismatch");
+   else if (rc == CMDLINE_PARSE_BAD_ARGS)
+   snprintf(out, out_size, MSG_CMD_FAIL, "Bad arguments");
+
+   return;
+
+}
+
+int
+cli_script_process(const char *file_name, size_t msg_in_len_max, size_t 
msg_out_len_max, void *obj)
+{
+   char *msg_in = NULL, *msg_out = NULL;
+   FILE *f = NULL;
+
+   /* Check input arguments */
+   if ((file_name == NULL) || (strlen(file_name) == 0) || (msg_in_len_max 
== 0) ||
+   (msg_out_len_max == 0))
+   return -EINVAL;
+
+   msg_in = malloc(msg_in_len_max + 1);
+   msg_out = malloc(msg_out_len_max + 1);
+   if ((msg_in == NULL) || (msg_out == NULL)) {
+   free(msg_out);
+   free(msg_in);
+   return -ENOMEM;
+   }
+
+   /* Open input file */
+   f = fopen(file_name, "r");
+   if (f == NULL) {
+   free(msg_out);
+   free(msg_in);
+   return -EIO;
+   }
+
+   /* Read file */
+   while (fgets(msg_in, msg_in_len_max, f) != NULL) {
+   msg_out[0] = 0;
+
+   cli_process(msg_in, msg_out, msg_out_len_max, obj);
+
+   if (strlen(msg_out))
+   printf("%s", msg_out);
+   }
+
+   /* Close file */
+   fclose(f);
+   free(msg_out);
+   free(msg_in);
+   re

[PATCH v6 02/12] app/graph: add telnet connectivity framework

[skori]

From: Sunil Kumar Kori 

It adds framework to initiate a telnet session with application.

Some configurations and debug commands are exposed as runtime APIs.
Those commands can be invoked using telnet session.

Application initiates a telnet server with host address 0.0.0.0
and port number 8086 by default.

To make it configurable, "-h" and "-p" options are provided.
Using them user can pass host address and port number on which
application will start telnet server.

Using same host address and port number, telnet client can connect
to application.

Syntax to connect with application:
# telnet  

Once session is connected, "graph> " prompt will be available.
Example:
# telnet 10.28.35.207 5
  Trying 10.28.35.207...
  Connected to 10.28.35.207.
  Escape character is '^]'.

  Welcome!

  graph>

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/conn.c   | 282 +
 app/graph/conn.h   |  46 ++
 app/graph/main.c   | 103 +-
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   3 +
 doc/guides/tools/graph.rst |  38 +
 6 files changed, 468 insertions(+), 5 deletions(-)
 create mode 100644 app/graph/conn.c
 create mode 100644 app/graph/conn.h

diff --git a/app/graph/conn.c b/app/graph/conn.c
new file mode 100644
index 00..8c88500605
--- /dev/null
+++ b/app/graph/conn.c
@@ -0,0 +1,282 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "module_api.h"
+
+#define MSG_CMD_TOO_LONG "Command too long."
+
+static int
+data_event_handle(struct conn *conn, int fd_client)
+{
+   ssize_t len, i, rc = 0;
+
+   /* Read input message */
+   len = read(fd_client, conn->buf, conn->buf_size);
+   if (len == -1) {
+   if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
+   return 0;
+
+   return -1;
+   }
+
+   if (len == 0)
+   return rc;
+
+   /* Handle input messages */
+   for (i = 0; i < len; i++) {
+   if (conn->buf[i] == '\n') {
+   size_t n;
+
+   conn->msg_in[conn->msg_in_len] = 0;
+   conn->msg_out[0] = 0;
+
+   conn->msg_handle(conn->msg_in, conn->msg_out, 
conn->msg_out_len_max,
+conn->msg_handle_arg);
+
+   n = strlen(conn->msg_out);
+   if (n) {
+   rc = write(fd_client, conn->msg_out, n);
+   if (rc == -1)
+   goto exit;
+   }
+
+   conn->msg_in_len = 0;
+   } else if (conn->msg_in_len < conn->msg_in_len_max) {
+   conn->msg_in[conn->msg_in_len] = conn->buf[i];
+   conn->msg_in_len++;
+   } else {
+   rc = write(fd_client, MSG_CMD_TOO_LONG, 
strlen(MSG_CMD_TOO_LONG));
+   if (rc == -1)
+   goto exit;
+
+   conn->msg_in_len = 0;
+   }
+   }
+
+   /* Write prompt */
+   rc = write(fd_client, conn->prompt, strlen(conn->prompt));
+   rc = (rc == -1) ? -1 : 0;
+
+exit:
+   return rc;
+}
+
+static int
+control_event_handle(struct conn *conn, int fd_client)
+{
+   int rc;
+
+   rc = epoll_ctl(conn->fd_client_group, EPOLL_CTL_DEL, fd_client, NULL);
+   if (rc == -1)
+   goto exit;
+
+   rc = close(fd_client);
+   if (rc == -1)
+   goto exit;
+
+   rc = 0;
+
+exit:
+   return rc;
+}
+
+struct conn *
+conn_init(struct conn_params *p)
+{
+   int fd_server, fd_client_group, rc;
+   struct sockaddr_in server_address;
+   struct conn *conn = NULL;
+   int reuse = 1;
+
+   memset(&server_address, 0, sizeof(server_address));
+
+   /* Check input arguments */
+   if ((p == NULL) || (p->welcome == NULL) || (p->prompt == NULL) || 
(p->addr == NULL) ||
+   (p->buf_size == 0) || (p->msg_in_len_max == 0) || 
(p->msg_out_len_max == 0) ||
+   (p->msg_handle == NULL))
+   goto exit;
+
+   rc = inet_aton(p->addr, &server_address.sin_addr);
+   if (rc == 0)
+   goto exit;
+
+   /* Memory allocation */
+   conn = calloc(1, sizeof(struct conn));
+   if (conn == NULL)
+   goto exit;
+
+   conn->welcome = calloc(1, CONN_WELCOME_LEN_MAX + 1);
+   conn->prompt = calloc(1, CONN_PROMPT_LEN_MAX + 1);
+   conn->buf = calloc(1, p->buf_size);
+   conn->msg_in = calloc(1, p->msg_in_len_max + 1);
+   conn->msg_out = calloc(1, p->msg_out_len_max + 1);
+
+   if ((conn->welcome == NULL)

[PATCH v6 03/12] app/graph: add parser utility APIs

[skori]

From: Sunil Kumar Kori 

It adds some helper functions to parse IPv4, IPv6 and MAC addresses
string into respective datatype.

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   1 +
 app/graph/utils.c  | 156 +
 app/graph/utils.h  |  14 
 4 files changed, 172 insertions(+)
 create mode 100644 app/graph/utils.c
 create mode 100644 app/graph/utils.h

diff --git a/app/graph/meson.build b/app/graph/meson.build
index 7e1ab0a214..ed3bcb1567 100644
--- a/app/graph/meson.build
+++ b/app/graph/meson.build
@@ -12,4 +12,5 @@ sources = files(
 'cli.c',
 'conn.c',
 'main.c',
+'utils.c',
 )
diff --git a/app/graph/module_api.h b/app/graph/module_api.h
index 9826303f0c..ad4fb50989 100644
--- a/app/graph/module_api.h
+++ b/app/graph/module_api.h
@@ -10,6 +10,7 @@
 
 #include "cli.h"
 #include "conn.h"
+#include "utils.h"
 /*
  * Externs
  */
diff --git a/app/graph/utils.c b/app/graph/utils.c
new file mode 100644
index 00..c7b6ae83cf
--- /dev/null
+++ b/app/graph/utils.c
@@ -0,0 +1,156 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "module_api.h"
+
+#define white_spaces_skip(pos) \
+({ \
+   __typeof__(pos) _p = (pos); \
+   for ( ; isspace(*_p); _p++) \
+   ;   \
+   _p; \
+})
+
+static void
+hex_string_to_uint64(uint64_t *dst, const char *hexs)
+{
+   char buf[2] = {0};
+   uint8_t shift = 4;
+   int iter = 0;
+   char c;
+
+   while ((c = *hexs++)) {
+   buf[0] = c;
+   *dst |= (strtol(buf, NULL, 16) << shift);
+   shift -= 4;
+   iter++;
+   if (iter == 2) {
+   iter = 0;
+   shift = 4;
+   dst++;
+   }
+   }
+}
+
+int
+parser_uint64_read(uint64_t *value, const char *p)
+{
+   char *next;
+   uint64_t val;
+
+   p = white_spaces_skip(p);
+   if (!isdigit(*p))
+   return -EINVAL;
+
+   val = strtoul(p, &next, 0);
+   if (p == next)
+   return -EINVAL;
+
+   p = next;
+   switch (*p) {
+   case 'T':
+   val *= 1024ULL;
+   /* fall through */
+   case 'G':
+   val *= 1024ULL;
+   /* fall through */
+   case 'M':
+   val *= 1024ULL;
+   /* fall through */
+   case 'k':
+   case 'K':
+   val *= 1024ULL;
+   p++;
+   break;
+   }
+
+   p = white_spaces_skip(p);
+   if (*p != '\0')
+   return -EINVAL;
+
+   *value = val;
+   return 0;
+}
+
+int
+parser_uint32_read(uint32_t *value, const char *p)
+{
+   uint64_t val = 0;
+   int rc = parser_uint64_read(&val, p);
+
+   if (rc < 0)
+   return rc;
+
+   if (val > UINT32_MAX)
+   return -ERANGE;
+
+   *value = val;
+   return 0;
+}
+
+int
+parser_ip4_read(uint32_t *value, char *p)
+{
+   uint8_t shift = 24;
+   uint32_t ip = 0;
+   char *token;
+
+   token = strtok(p, ".");
+   while (token != NULL) {
+   ip |= (((uint32_t)strtoul(token, NULL, 10)) << shift);
+   token = strtok(NULL, ".");
+   shift -= 8;
+   }
+
+   *value = ip;
+
+   return 0;
+}
+
+int
+parser_ip6_read(uint8_t *value, char *p)
+{
+   uint64_t val = 0;
+   char *token;
+
+   token = strtok(p, ":");
+   while (token != NULL) {
+   hex_string_to_uint64(&val, token);
+   *value = val;
+   token = strtok(NULL, ":");
+   value++;
+   val = 0;
+   }
+
+   return 0;
+}
+
+int
+parser_mac_read(uint64_t *value, char *p)
+{
+   uint64_t mac = 0, val = 0;
+   uint8_t shift = 40;
+   char *token;
+
+   token = strtok(p, ":");
+   while (token != NULL) {
+   hex_string_to_uint64(&val, token);
+   mac |= val << shift;
+   token = strtok(NULL, ":");
+   shift -= 8;
+   val = 0;
+   }
+
+   *value = mac;
+
+   return 0;
+}
diff --git a/app/graph/utils.h b/app/graph/utils.h
new file mode 100644
index 00..0ebb5de55a
--- /dev/null
+++ b/app/graph/utils.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#ifndef APP_GRAPH_UTILS_H
+#define APP_GRAPH_UTILS_H
+
+int parser_uint64_read(uint64_t *value, const char *p);
+int parser_uint32_read(uint32_t *value, const char *p);
+int parser_ip4_read(uint32_t *value, char *p);
+int parser_ip6_read(uint8_t *value, char *p);
+int parser_

[PATCH v6 04/12] app/graph: add mempool command line interfaces

[skori]

From: Rakesh Kudurumalla 

It adds mempool module which will be creating mempools.

Following commands are exposed:
 - mempool  size  buffers  \
cache  numa 
 - help mempool

User will add this command in .cli file according to its need.

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   2 +
 app/graph/mempool.c| 140 +
 app/graph/mempool.h|  24 +++
 app/graph/mempool_priv.h   |  34 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   2 +
 doc/guides/tools/graph.rst |   8 +++
 7 files changed, 211 insertions(+)
 create mode 100644 app/graph/mempool.c
 create mode 100644 app/graph/mempool.h
 create mode 100644 app/graph/mempool_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index 473fa1635a..c9f932517e 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -20,6 +20,8 @@
 #define MAX_LINE_SIZE 2048
 
 cmdline_parse_ctx_t modules_ctx[] = {
+   (cmdline_parse_inst_t *)&mempool_config_cmd_ctx,
+   (cmdline_parse_inst_t *)&mempool_help_cmd_ctx,
NULL,
 };
 
diff --git a/app/graph/mempool.c b/app/graph/mempool.c
new file mode 100644
index 00..901f07f461
--- /dev/null
+++ b/app/graph/mempool.c
@@ -0,0 +1,140 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "mempool_priv.h"
+#include "module_api.h"
+
+static const char
+cmd_mempool_help[] = "mempool  size  buffers 
 "
+"cache  numa ";
+
+struct mempools mpconfig;
+
+int
+mempool_process(struct mempool_config *config)
+{
+   struct rte_mempool *mp;
+   uint8_t nb_pools;
+
+   nb_pools = mpconfig.nb_pools;
+   strcpy(mpconfig.config[nb_pools].name, config->name);
+   mpconfig.config[nb_pools].pool_size = config->pool_size;
+   mpconfig.config[nb_pools].buffer_size = config->buffer_size;
+   mpconfig.config[nb_pools].cache_size = config->cache_size;
+   mpconfig.config[nb_pools].numa_node = config->numa_node;
+
+   mp = rte_pktmbuf_pool_create(config->name, config->pool_size, 
config->cache_size,
+   64, config->buffer_size, config->numa_node);
+   if (!mp)
+   return -EINVAL;
+
+   mpconfig.mp[nb_pools] = mp;
+   nb_pools++;
+   mpconfig.nb_pools = nb_pools;
+
+   return 0;
+}
+
+static void
+cli_mempool_help(__rte_unused void *parsed_result, __rte_unused struct cmdline 
*cl,
+__rte_unused void *data)
+{
+   size_t len;
+
+   len = strlen(conn->msg_out);
+   conn->msg_out += len;
+   snprintf(conn->msg_out, conn->msg_out_len_max, "\n%s\n%s\n",
+"- mempool command help 
-",
+cmd_mempool_help);
+
+   len = strlen(conn->msg_out);
+   conn->msg_out_len_max -= len;
+}
+
+static void
+cli_mempool(void *parsed_result, __rte_unused struct cmdline *cl, __rte_unused 
void *data)
+{
+   struct mempool_config_cmd_tokens *res = parsed_result;
+   struct mempool_config config;
+   int rc = -EINVAL;
+
+
+   strcpy(config.name, res->name);
+   config.name[strlen(res->name)] = '\0';
+   config.pool_size = res->nb_bufs;
+   config.buffer_size = res->buf_sz;
+   config.cache_size = res->cache_size;
+   config.numa_node = res->node;
+
+   rc = mempool_process(&config);
+   if (rc < 0)
+   printf(MSG_CMD_FAIL, "mempool");
+}
+
+cmdline_parse_token_string_t mempool_config_add_mempool =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, mempool, 
"mempool");
+cmdline_parse_token_string_t mempool_config_add_name =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, name, NULL);
+cmdline_parse_token_string_t mempool_config_add_size =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, size, 
"size");
+cmdline_parse_token_num_t mempool_config_add_buf_sz =
+   TOKEN_NUM_INITIALIZER(struct mempool_config_cmd_tokens, buf_sz, 
RTE_UINT16);
+cmdline_parse_token_string_t mempool_config_add_buffers =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, buffers, 
"buffers");
+cmdline_parse_token_num_t mempool_config_add_nb_bufs =
+   TOKEN_NUM_INITIALIZER(struct mempool_config_cmd_tokens, nb_bufs, 
RTE_UINT16);
+cmdline_parse_token_string_t mempool_config_add_cache =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, cache, 
"cache");
+cmdline_parse_token_num_t mempool_config_add_cache_size =
+   TOKEN_NUM_INITIALIZER(struct mempool_config_cmd_tokens, cache_size, 
RTE_UINT16);
+cmdline_parse_token_string_t mempool_config_add_numa =
+   TOKEN_STRING_INITIALIZER(struct mempool_config_cmd_tokens, numa, 
"numa");
+cmdline_parse_token_num_t mempool_config_add_node =
+   TOKEN_NUM_INITIALIZER(struct mempool_config_cmd_t

[PATCH v6 05/12] app/graph: add ethdev command line interfaces

[skori]

From: Sunil Kumar Kori 

It adds ethdev module to configure ethernet devices.

Following commands are exposed:
 - ethdev  rxq  txq  
 - ethdev  mtu 
 - ethdev  promiscuous 
 - ethdev  show
 - ethdev  stats
 - ethdev  ip4 addr add  netmask 
 - ethdev  ip6 addr add  netmask 
 - help ethdev

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   8 +
 app/graph/ethdev.c | 882 +
 app/graph/ethdev.h |  40 ++
 app/graph/ethdev_priv.h| 112 +
 app/graph/main.c   |   1 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   1 +
 doc/guides/tools/graph.rst |  47 ++
 8 files changed, 1092 insertions(+)
 create mode 100644 app/graph/ethdev.c
 create mode 100644 app/graph/ethdev.h
 create mode 100644 app/graph/ethdev_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index c9f932517e..c4b5cf3ce1 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -22,6 +22,14 @@
 cmdline_parse_ctx_t modules_ctx[] = {
(cmdline_parse_inst_t *)&mempool_config_cmd_ctx,
(cmdline_parse_inst_t *)&mempool_help_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_show_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_stats_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_mtu_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_prom_mode_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_ip4_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_ip6_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_help_cmd_ctx,
NULL,
 };
 
diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
new file mode 100644
index 00..81ad8c4757
--- /dev/null
+++ b/app/graph/ethdev.c
@@ -0,0 +1,882 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "ethdev_priv.h"
+#include "module_api.h"
+
+static const char
+cmd_ethdev_mtu_help[] = "ethdev  mtu ";
+
+static const char
+cmd_ethdev_prom_mode_help[] = "ethdev  promiscuous ";
+
+static const char
+cmd_ethdev_help[] = "ethdev  rxq  txq  
";
+static const char
+cmd_ethdev_show_help[] = "ethdev  show";
+
+static const char
+cmd_ethdev_ip4_addr_help[] = "ethdev  ip4 addr add  netmask 
";
+
+static const char
+cmd_ethdev_ip6_addr_help[] = "ethdev  ip6 addr add  netmask 
";
+
+static struct rte_eth_conf port_conf_default = {
+   .link_speeds = 0,
+   .rxmode = {
+   .mq_mode = RTE_ETH_MQ_RX_NONE,
+   .mtu = 9000 - (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN), /* Jumbo 
frame MTU */
+   },
+   .rx_adv_conf = {
+   .rss_conf = {
+   .rss_key = NULL,
+   .rss_key_len = 40,
+   .rss_hf = 0,
+   },
+   },
+   .txmode = {
+   .mq_mode = RTE_ETH_MQ_TX_NONE,
+   },
+   .lpbk_mode = 0,
+};
+
+uint32_t enabled_port_mask;
+static struct ethdev_head eth_node = TAILQ_HEAD_INITIALIZER(eth_node);
+
+
+static struct ethdev*
+ethdev_port_by_id(uint16_t port_id)
+{
+   struct ethdev *port;
+
+   TAILQ_FOREACH(port, ð_node, next) {
+   if (port->config.port_id == port_id)
+   return port;
+   }
+   return NULL;
+}
+
+void *
+ethdev_mempool_list_by_portid(uint16_t portid)
+{
+   struct ethdev *port;
+
+   if (portid >= RTE_MAX_ETHPORTS)
+   return NULL;
+
+   port = ethdev_port_by_id(portid);
+   if (port)
+   return &(port->config.rx.mp);
+   else
+   return NULL;
+}
+
+int16_t
+ethdev_portid_by_ip4(uint32_t ip, uint32_t mask)
+{
+   int portid = -EINVAL;
+   struct ethdev *port;
+
+   TAILQ_FOREACH(port, ð_node, next) {
+   if (mask == 0) {
+   if ((port->ip4_addr.ip & port->ip4_addr.mask) == (ip & 
port->ip4_addr.mask))
+   return port->config.port_id;
+   } else {
+   if ((port->ip4_addr.ip & port->ip4_addr.mask) == (ip & 
mask))
+   return port->config.port_id;
+   }
+   }
+
+   return portid;
+}
+
+int16_t
+ethdev_portid_by_ip6(uint8_t *ip, uint8_t *mask)
+{
+   int portid = -EINVAL;
+   struct ethdev *port;
+   int j;
+
+   TAILQ_FOREACH(port, ð_node, next) {
+   for (j = 0; j < ETHDEV_IPV6_ADDR_LEN; j++) {
+   if (mask == NULL) {
+   if ((port->ip6_addr.ip[j] & 
port->ip6_addr.mask[j]) !=
+   (ip[j] & port->ip6_addr.mask[j]))
+   break;
+
+   } else {
+   if ((port->ip6_addr.ip[j] & 
port->ip6_addr.mask[j]) !=
+   (ip[j] & mask[j]))
+   break;
+   }

[PATCH v6 06/12] app/graph: add ipv4_lookup command line interfaces

[skori]

From: Sunil Kumar Kori 

It adds ipv4_lookup module to configure LPM table. This LPM table
will be used for IPv4 lookup and forwarding.

Following commands are exposed:
 - ipv4_lookup route add ipv4  netmask  via 
 - help ipv4_lookup

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   2 +
 app/graph/ethdev.c |   2 +-
 app/graph/ip4_route.c  | 205 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   1 +
 app/graph/route.h  |  26 +
 app/graph/route_priv.h |  44 
 doc/guides/tools/graph.rst |   9 ++
 8 files changed, 289 insertions(+), 1 deletion(-)
 create mode 100644 app/graph/ip4_route.c
 create mode 100644 app/graph/route.h
 create mode 100644 app/graph/route_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index c4b5cf3ce1..430750db6e 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -30,6 +30,8 @@ cmdline_parse_ctx_t modules_ctx[] = {
(cmdline_parse_inst_t *)ðdev_ip6_cmd_ctx,
(cmdline_parse_inst_t *)ðdev_cmd_ctx,
(cmdline_parse_inst_t *)ðdev_help_cmd_ctx,
+   (cmdline_parse_inst_t *)&ipv4_lookup_cmd_ctx,
+   (cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx,
NULL,
 };
 
diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
index 81ad8c4757..cb29c9054d 100644
--- a/app/graph/ethdev.c
+++ b/app/graph/ethdev.c
@@ -160,7 +160,7 @@ ethdev_stop(void)
}
 
ethdev_list_clean();
-   rte_eal_cleanup();
+   route_ip4_list_clean();
printf("Bye...\n");
 }
 
diff --git a/app/graph/ip4_route.c b/app/graph/ip4_route.c
new file mode 100644
index 00..a8fb8ba8d5
--- /dev/null
+++ b/app/graph/ip4_route.c
@@ -0,0 +1,205 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "module_api.h"
+#include "route_priv.h"
+
+static const char
+cmd_ipv4_lookup_help[] = "ipv4_lookup route add ipv4  netmask  via 
";
+
+struct ip4_route route4 = TAILQ_HEAD_INITIALIZER(route4);
+
+
+void
+route_ip4_list_clean(void)
+{
+   struct route_ipv4_config *route;
+
+   while (!TAILQ_EMPTY(&route4)) {
+   route = TAILQ_FIRST(&route4);
+   TAILQ_REMOVE(&route4, route, next);
+   }
+}
+
+static struct route_ipv4_config *
+find_route4_entry(struct route_ipv4_config *route)
+{
+   struct route_ipv4_config *ipv4route;
+
+   TAILQ_FOREACH(ipv4route, &route4, next) {
+   if (!memcmp(ipv4route, route, sizeof(*route)))
+   return ipv4route;
+   }
+   return NULL;
+
+}
+
+static uint8_t
+convert_netmask_to_depth(uint32_t netmask)
+{
+   uint8_t zerobits = 0;
+
+   while ((netmask & 0x1) == 0) {
+   netmask = netmask >> 1;
+   zerobits++;
+   }
+
+   return (32 - zerobits);
+}
+
+static int
+route_ip4_add(struct route_ipv4_config *route)
+{
+   struct route_ipv4_config *ipv4route;
+
+   ipv4route = find_route4_entry(route);
+
+   if (!ipv4route) {
+   ipv4route = malloc(sizeof(struct route_ipv4_config));
+   if (!ipv4route)
+   return -ENOMEM;
+   } else {
+   return 0;
+   }
+
+   ipv4route->ip = route->ip;
+   ipv4route->netmask = route->netmask;
+   ipv4route->via = route->via;
+   ipv4route->is_used = true;
+
+   TAILQ_INSERT_TAIL(&route4, ipv4route, next);
+   return 0;
+}
+
+int
+route_ip4_add_to_lookup(void)
+{
+   struct route_ipv4_config *route = NULL;
+   int rc = -EINVAL;
+   uint8_t depth;
+   int portid;
+
+   TAILQ_FOREACH(route, &route4, next) {
+   portid = ethdev_portid_by_ip4(route->via, route->netmask);
+   if (portid < 0) {
+   printf("Invalid portid found to install the route\n");
+   return rc;
+   }
+
+   depth = convert_netmask_to_depth(route->netmask);
+
+   rc = rte_node_ip4_route_add(route->ip, depth, portid,
+   RTE_NODE_IP4_LOOKUP_NEXT_REWRITE);
+   if (rc < 0)
+   return rc;
+   }
+
+   return 0;
+}
+
+static void
+cli_ipv4_lookup_help(__rte_unused void *parsed_result, __rte_unused struct 
cmdline *cl,
+__rte_unused void *data)
+{
+   size_t len;
+
+   len = strlen(conn->msg_out);
+   conn->msg_out += len;
+   snprintf(conn->msg_out, conn->msg_out_len_max, "\n%s\n%s\n",
+"--- ipv4_lookup command help 
---",
+cmd_ipv4_lookup_help);
+
+   len = strlen(conn->msg_out);
+   conn->msg_out_len_max -= len;
+}
+
+static void
+cli_ipv4_lookup(void *parsed_result, __rte_unused struct cmdline *cl, void 
*data __rte_unused)
+{
+   struct ip4_lookup_cmd_tokens

[PATCH v6 07/12] app/graph: add ipv6_lookup command line interfaces

[skori]

From: Rakesh Kudurumalla 

It adds ipv6_lookup module to configure LPM6 table. This LPM6 table
will be used for IPv6 lookup and forwarding.

Following commands are exposed:
 - ipv6_lookup route add ipv6  netmask  via 
 - help ipv6_lookup

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   2 +
 app/graph/ethdev.c |   1 +
 app/graph/ip6_route.c  | 210 +
 app/graph/meson.build  |   1 +
 app/graph/route.h  |  14 +++
 doc/guides/tools/graph.rst |   9 ++
 6 files changed, 237 insertions(+)
 create mode 100644 app/graph/ip6_route.c

diff --git a/app/graph/cli.c b/app/graph/cli.c
index 430750db6e..7213a91ad2 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -32,6 +32,8 @@ cmdline_parse_ctx_t modules_ctx[] = {
(cmdline_parse_inst_t *)ðdev_help_cmd_ctx,
(cmdline_parse_inst_t *)&ipv4_lookup_cmd_ctx,
(cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx,
+   (cmdline_parse_inst_t *)&ipv6_lookup_cmd_ctx,
+   (cmdline_parse_inst_t *)&ipv6_lookup_help_cmd_ctx,
NULL,
 };
 
diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
index cb29c9054d..0a4eb7be4f 100644
--- a/app/graph/ethdev.c
+++ b/app/graph/ethdev.c
@@ -161,6 +161,7 @@ ethdev_stop(void)
 
ethdev_list_clean();
route_ip4_list_clean();
+   route_ip6_list_clean();
printf("Bye...\n");
 }
 
diff --git a/app/graph/ip6_route.c b/app/graph/ip6_route.c
new file mode 100644
index 00..93c2c967aa
--- /dev/null
+++ b/app/graph/ip6_route.c
@@ -0,0 +1,210 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "module_api.h"
+#include "route_priv.h"
+
+static const char
+cmd_ipv6_lookup_help[] = "ipv6_lookup route add ipv6  netmask  via 
";
+
+struct ip6_route route6 = TAILQ_HEAD_INITIALIZER(route6);
+
+void
+route_ip6_list_clean(void)
+{
+   struct route_ipv6_config *route;
+
+   while (!TAILQ_EMPTY(&route6)) {
+   route = TAILQ_FIRST(&route6);
+   TAILQ_REMOVE(&route6, route, next);
+   }
+}
+
+static struct route_ipv6_config *
+find_route6_entry(struct route_ipv6_config *route)
+{
+   struct route_ipv6_config *ipv6route;
+
+   TAILQ_FOREACH(ipv6route, &route6, next) {
+   if (!memcmp(ipv6route, route, sizeof(*route)))
+   return ipv6route;
+   }
+   return NULL;
+}
+
+static uint8_t
+convert_ip6_netmask_to_depth(uint8_t *netmask)
+{
+   uint8_t setbits = 0;
+   uint8_t mask;
+   int i;
+
+   for (i = 0; i < ETHDEV_IPV6_ADDR_LEN; i++) {
+   mask = netmask[i];
+   while (mask & 0x80) {
+   mask = mask << 1;
+   setbits++;
+   }
+   }
+
+   return setbits;
+}
+
+static int
+route_ip6_add(struct route_ipv6_config *route)
+{
+   int j;
+
+   struct route_ipv6_config *ipv6route;
+
+   ipv6route = find_route6_entry(route);
+   if (!ipv6route) {
+   ipv6route = malloc(sizeof(struct route_ipv6_config));
+   if (!ipv6route)
+   return -ENOMEM;
+   } else {
+   return 0;
+   }
+
+   for (j = 0; j < ETHDEV_IPV6_ADDR_LEN; j++) {
+   ipv6route->ip[j] = route->ip[j];
+   ipv6route->mask[j] = route->mask[j];
+   ipv6route->gateway[j] = route->gateway[j];
+   }
+   ipv6route->is_used = true;
+
+   return 0;
+}
+
+int
+route_ip6_add_to_lookup(void)
+{
+   struct route_ipv6_config *route = NULL;
+   int rc = -EINVAL;
+   uint8_t depth;
+   int portid;
+
+   TAILQ_FOREACH(route, &route6, next) {
+
+   portid = ethdev_portid_by_ip6(route->gateway, route->mask);
+   if (portid < 0) {
+   printf("Invalid portid found to install the route\n");
+   return rc;
+   }
+   depth = convert_ip6_netmask_to_depth(route->mask);
+
+   rc = rte_node_ip6_route_add(route->ip, depth, portid,
+RTE_NODE_IP6_LOOKUP_NEXT_REWRITE);
+   if (rc < 0)
+   return rc;
+   }
+
+   return 0;
+}
+
+static void
+cli_ipv6_lookup_help(__rte_unused void *parsed_result, __rte_unused struct 
cmdline *cl,
+__rte_unused void *data)
+{
+   size_t len;
+
+   len = strlen(conn->msg_out);
+   conn->msg_out += len;
+   snprintf(conn->msg_out, conn->msg_out_len_max, "\n%s\n%s\n",
+"--- ipv6_lookup command help 
---",
+cmd_ipv6_lookup_help);
+
+   len = strlen(conn->msg_out);
+   conn->msg_out_len_max -= len;
+}
+
+static void
+cli_ipv6_lookup(void *parsed_result, __rte_unused struct cmdline *cl, v

[PATCH v6 08/12] app/graph: add neigh command line interfaces

[skori]

From: Sunil Kumar Kori 

It adds neigh module to configure arp/neigh. This module uses
ipv4_rewrite and ipv6_rewrite node to write neigh information.

Following commands are exposed:
 - neigh add ipv4  
 - neigh add ipv6  
 - help neigh

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   3 +
 app/graph/ethdev.c |   2 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   2 +
 app/graph/neigh.c  | 331 +
 app/graph/neigh.h  |  17 ++
 app/graph/neigh_priv.h |  49 ++
 doc/guides/tools/graph.rst |  12 ++
 8 files changed, 417 insertions(+)
 create mode 100644 app/graph/neigh.c
 create mode 100644 app/graph/neigh.h
 create mode 100644 app/graph/neigh_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index 7213a91ad2..36338d5173 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -34,6 +34,9 @@ cmdline_parse_ctx_t modules_ctx[] = {
(cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx,
(cmdline_parse_inst_t *)&ipv6_lookup_cmd_ctx,
(cmdline_parse_inst_t *)&ipv6_lookup_help_cmd_ctx,
+   (cmdline_parse_inst_t *)&neigh_v4_cmd_ctx,
+   (cmdline_parse_inst_t *)&neigh_v6_cmd_ctx,
+   (cmdline_parse_inst_t *)&neigh_help_cmd_ctx,
NULL,
 };
 
diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c
index 0a4eb7be4f..fc0bd8f05f 100644
--- a/app/graph/ethdev.c
+++ b/app/graph/ethdev.c
@@ -162,6 +162,8 @@ ethdev_stop(void)
ethdev_list_clean();
route_ip4_list_clean();
route_ip6_list_clean();
+   neigh4_list_clean();
+   neigh6_list_clean();
printf("Bye...\n");
 }
 
diff --git a/app/graph/meson.build b/app/graph/meson.build
index 6841a25eb6..c0b8418b89 100644
--- a/app/graph/meson.build
+++ b/app/graph/meson.build
@@ -16,5 +16,6 @@ sources = files(
 'ip6_route.c',
 'main.c',
 'mempool.c',
+'neigh.c',
 'utils.c',
 )
diff --git a/app/graph/module_api.h b/app/graph/module_api.h
index bd4d245c75..e9e42da7cc 100644
--- a/app/graph/module_api.h
+++ b/app/graph/module_api.h
@@ -12,8 +12,10 @@
 #include "conn.h"
 #include "ethdev.h"
 #include "mempool.h"
+#include "neigh.h"
 #include "route.h"
 #include "utils.h"
+
 /*
  * Externs
  */
diff --git a/app/graph/neigh.c b/app/graph/neigh.c
new file mode 100644
index 00..f59d61152b
--- /dev/null
+++ b/app/graph/neigh.c
@@ -0,0 +1,331 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "neigh_priv.h"
+#include "module_api.h"
+
+static const char
+cmd_neigh_v4_help[] = "neigh add ipv4  ";
+
+static const char
+cmd_neigh_v6_help[] = "neigh add ipv6  ";
+
+struct neigh4_head neigh4 = TAILQ_HEAD_INITIALIZER(neigh4);
+struct neigh6_head neigh6 = TAILQ_HEAD_INITIALIZER(neigh6);
+
+void
+neigh4_list_clean(void)
+{
+   struct neigh_ipv4_config *v4_config;
+
+   while (!TAILQ_EMPTY(&neigh4)) {
+   v4_config = TAILQ_FIRST(&neigh4);
+   TAILQ_REMOVE(&neigh4, v4_config, next);
+   }
+}
+
+void
+neigh6_list_clean(void)
+{
+   struct neigh_ipv6_config *v6_config;
+
+   while (!TAILQ_EMPTY(&neigh6)) {
+   v6_config = TAILQ_FIRST(&neigh6);
+   TAILQ_REMOVE(&neigh6, v6_config, next);
+   }
+}
+
+static struct neigh_ipv4_config *
+find_neigh4_entry(uint32_t ip, uint64_t mac)
+{
+   struct neigh_ipv4_config *v4_config;
+
+   TAILQ_FOREACH(v4_config, &neigh4, next) {
+   if ((v4_config->ip == ip) && (v4_config->mac == mac))
+   return v4_config;
+   }
+   return NULL;
+}
+
+static struct neigh_ipv6_config *
+find_neigh6_entry(uint8_t *ip, uint64_t mac)
+{
+   struct neigh_ipv6_config *v6_config;
+
+   TAILQ_FOREACH(v6_config, &neigh6, next) {
+   if (!(memcmp(v6_config->ip, ip, 16)) && (v6_config->mac == mac))
+   return v6_config;
+   }
+   return NULL;
+}
+
+static int
+neigh_ip4_add(uint32_t ip, uint64_t mac)
+{
+   struct neigh_ipv4_config *v4_config;
+
+   v4_config = find_neigh4_entry(ip, mac);
+
+   if (!v4_config) {
+   v4_config = malloc(sizeof(struct neigh_ipv4_config));
+   if (!v4_config)
+   return -ENOMEM;
+   }
+
+   v4_config->ip = ip;
+   v4_config->mac = mac;
+   v4_config->is_used = true;
+
+   TAILQ_INSERT_TAIL(&neigh4, v4_config, next);
+   return 0;
+}
+
+static int
+neigh_ip6_add(uint8_t *ip, uint64_t mac)
+{
+   int j;
+   struct neigh_ipv6_config *v6_config;
+
+   v6_config = find_neigh6_entry(ip, mac);
+
+   if (!v6_config) {
+   v6_config = malloc(sizeof(struct neigh_ipv6_config));
+   if (!v6_config)
+   return -ENOMEM;
+   }
+
+   for (j = 0; j < E

[PATCH v6 09/12] app/graph: add ethdev_rx command line interfaces

[skori]

From: Rakesh Kudurumalla 

It adds ethdev_rx module to create port-queue-core mapping.

Mapping will be used to launch graph worker thread and dequeue
packets on mentioned core from desired port/queue.

Following commands are exposed:
 - ethdev_rx map port  queue  core 
 - help ethdev_rx

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   2 +
 app/graph/ethdev_rx.c  | 165 +
 app/graph/ethdev_rx.h  |  37 +
 app/graph/ethdev_rx_priv.h |  39 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   1 +
 doc/guides/tools/graph.rst |  10 +++
 7 files changed, 255 insertions(+)
 create mode 100644 app/graph/ethdev_rx.c
 create mode 100644 app/graph/ethdev_rx.h
 create mode 100644 app/graph/ethdev_rx_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index 36338d5173..e947f61ee4 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -30,6 +30,8 @@ cmdline_parse_ctx_t modules_ctx[] = {
(cmdline_parse_inst_t *)ðdev_ip6_cmd_ctx,
(cmdline_parse_inst_t *)ðdev_cmd_ctx,
(cmdline_parse_inst_t *)ðdev_help_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_rx_cmd_ctx,
+   (cmdline_parse_inst_t *)ðdev_rx_help_cmd_ctx,
(cmdline_parse_inst_t *)&ipv4_lookup_cmd_ctx,
(cmdline_parse_inst_t *)&ipv4_lookup_help_cmd_ctx,
(cmdline_parse_inst_t *)&ipv6_lookup_cmd_ctx,
diff --git a/app/graph/ethdev_rx.c b/app/graph/ethdev_rx.c
new file mode 100644
index 00..f2cb8cf9a5
--- /dev/null
+++ b/app/graph/ethdev_rx.c
@@ -0,0 +1,165 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "ethdev_rx_priv.h"
+#include "module_api.h"
+
+static const char
+cmd_ethdev_rx_help[] = "ethdev_rx map port  queue  core 
";
+
+static struct lcore_params lcore_params_array[ETHDEV_RX_LCORE_PARAMS_MAX];
+struct rte_node_ethdev_config ethdev_conf[RTE_MAX_ETHPORTS];
+struct lcore_params *lcore_params = lcore_params_array;
+struct lcore_conf lcore_conf[RTE_MAX_LCORE];
+uint16_t nb_lcore_params;
+
+static void
+rx_map_configure(uint8_t port_id, uint32_t queue, uint32_t core)
+{
+   uint8_t n_rx_queue;
+
+   n_rx_queue = lcore_conf[core].n_rx_queue;
+   lcore_conf[core].rx_queue_list[n_rx_queue].port_id = port_id;
+   lcore_conf[core].rx_queue_list[n_rx_queue].queue_id = queue;
+   lcore_conf[core].n_rx_queue++;
+}
+
+uint8_t
+ethdev_rx_num_rx_queues_get(uint16_t port)
+{
+   int queue = -1;
+   uint16_t i;
+
+   for (i = 0; i < nb_lcore_params; ++i) {
+   if (lcore_params[i].port_id == port) {
+   if (lcore_params[i].queue_id == queue + 1)
+   queue = lcore_params[i].queue_id;
+   else
+   rte_exit(EXIT_FAILURE,
+"Queue ids of the port %d must be"
+" in sequence and must start with 0\n",
+lcore_params[i].port_id);
+   }
+   }
+
+   return (uint8_t)(++queue);
+}
+
+static int
+ethdev_rx_map_add(char *name, uint32_t queue, uint32_t core)
+{
+   uint64_t coremask;
+   uint16_t port_id;
+   int rc;
+
+   if (nb_lcore_params >= ETHDEV_RX_LCORE_PARAMS_MAX)
+   return -EINVAL;
+
+   rc = rte_eth_dev_get_port_by_name(name, &port_id);
+   if (rc)
+   return -EINVAL;
+
+   coremask = 0xff; /* FIXME: Read from graph configuration */
+
+   if (!(coremask & (1 << core)))
+   return -EINVAL;
+
+   rx_map_configure(port_id, queue, core);
+
+   lcore_params_array[nb_lcore_params].port_id = port_id;
+   lcore_params_array[nb_lcore_params].queue_id = queue;
+   lcore_params_array[nb_lcore_params].lcore_id = core;
+   nb_lcore_params++;
+   return 0;
+}
+
+static void
+cli_ethdev_rx_help(__rte_unused void *parsed_result, __rte_unused struct 
cmdline *cl,
+  __rte_unused void *data)
+{
+   size_t len;
+
+   len = strlen(conn->msg_out);
+   conn->msg_out += len;
+   snprintf(conn->msg_out, conn->msg_out_len_max, "\n%s\n%s\n",
+"- ethdev_rx command help 
-",
+cmd_ethdev_rx_help);
+
+   len = strlen(conn->msg_out);
+   conn->msg_out_len_max -= len;
+}
+
+static void
+cli_ethdev_rx(void *parsed_result, __rte_unused struct cmdline *cl, void *data 
__rte_unused)
+{
+   struct ethdev_rx_cmd_tokens *res = parsed_result;
+   int rc = -EINVAL;
+
+   rc = ethdev_rx_map_add(res->dev, res->qid, res->core_id);
+   if (rc < 0) {
+   cli_exit();
+   printf(MSG_CMD_FAIL, res->cmd);
+   rte_exit(EXIT_FAILURE, "input core is Invalid\n");
+   }
+
+}
+
+cmdline_p

[PATCH v6 10/12] app/graph: add graph command line interfaces

[skori]

From: Rakesh Kudurumalla 

It adds graph module to create a graph for a given use case like
l3fwd.

Following commands are exposed:
 - graph  [bsz ] [tmo ] [coremask ] \
model  pcap_enable <0 | 1> num_pcap_pkts  \
pcap_file 
 - graph start
 - graph stats show
 - help graph

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/cli.c|   4 +
 app/graph/ethdev_rx.c  |   2 +-
 app/graph/graph.c  | 536 +
 app/graph/graph.h  |  20 ++
 app/graph/graph_priv.h |  70 +
 app/graph/meson.build  |   1 +
 app/graph/module_api.h |   1 +
 doc/guides/tools/graph.rst |  19 +-
 8 files changed, 650 insertions(+), 3 deletions(-)
 create mode 100644 app/graph/graph.c
 create mode 100644 app/graph/graph.h
 create mode 100644 app/graph/graph_priv.h

diff --git a/app/graph/cli.c b/app/graph/cli.c
index e947f61ee4..c43af5925c 100644
--- a/app/graph/cli.c
+++ b/app/graph/cli.c
@@ -20,6 +20,10 @@
 #define MAX_LINE_SIZE 2048
 
 cmdline_parse_ctx_t modules_ctx[] = {
+   (cmdline_parse_inst_t *)&graph_config_cmd_ctx,
+   (cmdline_parse_inst_t *)&graph_start_cmd_ctx,
+   (cmdline_parse_inst_t *)&graph_stats_cmd_ctx,
+   (cmdline_parse_inst_t *)&graph_help_cmd_ctx,
(cmdline_parse_inst_t *)&mempool_config_cmd_ctx,
(cmdline_parse_inst_t *)&mempool_help_cmd_ctx,
(cmdline_parse_inst_t *)ðdev_show_cmd_ctx,
diff --git a/app/graph/ethdev_rx.c b/app/graph/ethdev_rx.c
index f2cb8cf9a5..03f8effcca 100644
--- a/app/graph/ethdev_rx.c
+++ b/app/graph/ethdev_rx.c
@@ -69,7 +69,7 @@ ethdev_rx_map_add(char *name, uint32_t queue, uint32_t core)
if (rc)
return -EINVAL;
 
-   coremask = 0xff; /* FIXME: Read from graph configuration */
+   coremask = graph_coremask_get();
 
if (!(coremask & (1 << core)))
return -EINVAL;
diff --git a/app/graph/graph.c b/app/graph/graph.c
new file mode 100644
index 00..1e543ea7aa
--- /dev/null
+++ b/app/graph/graph.c
@@ -0,0 +1,536 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Marvell.
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "graph_priv.h"
+#include "module_api.h"
+
+#define RTE_LOGTYPE_APP_GRAPH RTE_LOGTYPE_USER1
+
+static const char
+cmd_graph_help[] = "graph  bsz  tmo  coremask  "
+  "model  pcap_enable <0 | 1> 
num_pcap_pkts "
+  "pcap_file ";
+
+static const char * const supported_usecases[] = {"l3fwd"};
+struct graph_config graph_config;
+
+/* Check the link rc of all ports in up to 9s, and print them finally */
+static void
+check_all_ports_link_status(uint32_t port_mask)
+{
+#define CHECK_INTERVAL 100 /* 100ms */
+#define MAX_CHECK_TIME 90  /* 9s (90 * 100ms) in total */
+   char link_rc_text[RTE_ETH_LINK_MAX_STR_LEN];
+   uint8_t count, all_ports_up, print_flag = 0;
+   struct rte_eth_link link;
+   uint16_t portid;
+   int rc;
+
+   printf("\nChecking link rc");
+   fflush(stdout);
+   for (count = 0; count <= MAX_CHECK_TIME; count++) {
+   if (force_quit)
+   return;
+
+   all_ports_up = 1;
+   RTE_ETH_FOREACH_DEV(portid)
+   {
+   if (force_quit)
+   return;
+
+   if ((port_mask & (1 << portid)) == 0)
+   continue;
+
+   memset(&link, 0, sizeof(link));
+   rc = rte_eth_link_get_nowait(portid, &link);
+   if (rc < 0) {
+   all_ports_up = 0;
+   if (print_flag == 1)
+   printf("Port %u link get failed: %s\n",
+  portid, rte_strerror(-rc));
+   continue;
+   }
+
+   /* Print link rc if flag set */
+   if (print_flag == 1) {
+   rte_eth_link_to_str(link_rc_text, 
sizeof(link_rc_text),
+   &link);
+   printf("Port %d %s\n", portid, link_rc_text);
+   continue;
+   }
+
+   /* Clear all_ports_up flag if any link down */
+   if (link.link_status == RTE_ETH_LINK_DOWN) {
+   all_ports_up = 0;
+   break;
+   }
+   }
+
+   /* After finally printing all link rc, get out */
+   if (print_flag == 1)
+   break;
+
+   if (all_ports_up == 0) {
+   printf(".");
+   fflush(stdout);
+   rte_delay_ms(CHECK_INTERVAL);
+ 

[PATCH v6 11/12] app/graph: add CLI option to enable graph stats

[skori]

From: Sunil Kumar Kori 

It adds application's command line parameter "--enable-graph-stats"
to enable dumping graph stats on console.

By default, no graph stats will be printed on console but same can
be dumped via telnet session using "graph stats show" command.

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/main.c   | 17 -
 app/graph/module_api.h |  2 ++
 doc/guides/tools/graph.rst |  4 
 3 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/app/graph/main.c b/app/graph/main.c
index c1cb435588..465376425c 100644
--- a/app/graph/main.c
+++ b/app/graph/main.c
@@ -21,12 +21,13 @@
 volatile bool force_quit;
 struct conn *conn;
 
-static const char usage[] = "%s EAL_ARGS -- -s SCRIPT [-h HOST] [-p PORT] "
+static const char usage[] = "%s EAL_ARGS -- -s SCRIPT [-h HOST] [-p PORT] 
[--enable-graph-stats] "
"[--help]\n";
 
 static struct app_params {
struct conn_params conn;
char *script_name;
+   bool enable_graph_stats;
 } app = {
.conn = {
.welcome = "\nWelcome!\n\n",
@@ -40,6 +41,7 @@ static struct app_params {
.msg_handle_arg = NULL, /* set later. */
},
.script_name = NULL,
+   .enable_graph_stats = false,
 };
 
 static void
@@ -56,6 +58,7 @@ app_args_parse(int argc, char **argv)
 {
struct option lgopts[] = {
{"help", 0, 0, 'H'},
+   {"enable-graph-stats", 0, 0, 'g'},
};
int h_present, p_present, s_present, n_args, i;
char *app_name = argv[0];
@@ -133,6 +136,12 @@ app_args_parse(int argc, char **argv)
}
break;
 
+   case 'g':
+   app.enable_graph_stats = true;
+   printf("WARNING! Telnet session can not be accessed 
with"
+  "--enable-graph-stats");
+   break;
+
case 'H':
default:
printf(usage, app_name);
@@ -144,6 +153,12 @@ app_args_parse(int argc, char **argv)
return 0;
 }
 
+bool
+app_graph_stats_enabled(void)
+{
+   return app.enable_graph_stats;
+}
+
 bool
 app_graph_exit(void)
 {
diff --git a/app/graph/module_api.h b/app/graph/module_api.h
index 392dcfb222..a7d287f5c8 100644
--- a/app/graph/module_api.h
+++ b/app/graph/module_api.h
@@ -24,5 +24,7 @@
 extern volatile bool force_quit;
 extern struct conn *conn;
 
+bool app_graph_stats_enabled(void);
 bool app_graph_exit(void);
+
 #endif
diff --git a/doc/guides/tools/graph.rst b/doc/guides/tools/graph.rst
index 2c06f8e958..649e802d73 100644
--- a/doc/guides/tools/graph.rst
+++ b/doc/guides/tools/graph.rst
@@ -57,6 +57,10 @@ Following are the application command-line options:
 a mandatory parameter which will be used to create desired graph
 for a given use case.
 
+* ``--enable-graph-stats``
+
+   Enable graph statistics printing on console. By default graph 
statistics are disabled.
+
 * ``--help``
 
Dumps application usage
-- 
2.25.1

[PATCH v6 12/12] app/graph: add l3fwd use case

[skori]

From: Rakesh Kudurumalla 

It adds an use case l3fwd. It contains a dedicated l3fwd.cli file
mentioning commands to configure the required resources.

Once application successfully parses the l3fwd.cli then a graph is
created having below nodes:
 - ethdev_rx -> pkt_cls

 - pkt_cls -> ip4_lookup
 - pkt_cls -> ip6_lookup
 - pkt_cls -> pkt_drop

 - ip4_lookup -> ip4_rewrite
 - ip4_lookup -> pkt_drop

 - ip6_lookup -> ip6_rewrite
 - ip6_lookup -> pkt_drop

 - ip4_rewrite -> ethdev_tx
 - ip4_rewrite -> pkt_drop

 - ip6_rewrite -> ethdev_tx
 - ip6_rewrite -> pkt_drop

 - ethdev_tx -> pkt_drop

Signed-off-by: Sunil Kumar Kori 
Signed-off-by: Rakesh Kudurumalla 
---
 app/graph/examples/l3fwd.cli |  87 
 app/graph/graph.c|   2 +-
 app/graph/l3fwd.c| 136 
 app/graph/l3fwd.h|  11 +
 app/graph/meson.build|   1 +
 app/graph/module_api.h   |   1 +
 doc/guides/tools/graph.rst   |   9 +-
 doc/guides/tools/img/graph-usecase-l3fwd.svg | 210 +++
 8 files changed, 455 insertions(+), 2 deletions(-)
 create mode 100644 app/graph/examples/l3fwd.cli
 create mode 100644 app/graph/l3fwd.c
 create mode 100644 app/graph/l3fwd.h
 create mode 100644 doc/guides/tools/img/graph-usecase-l3fwd.svg

diff --git a/app/graph/examples/l3fwd.cli b/app/graph/examples/l3fwd.cli
new file mode 100644
index 00..1038fde04e
--- /dev/null
+++ b/app/graph/examples/l3fwd.cli
@@ -0,0 +1,87 @@
+; SPDX-License-Identifier: BSD-3-Clause
+; Copyright(c) 2023 Marvell.
+
+;
+; Graph configuration for given usecase
+;
+graph l3fwd coremask 0xff bsz 32 tmo 10 model default pcap_enable 1 
num_pcap_pkts 10 pcap_file /tmp/output.pcap
+
+;
+; Mempools to be attached with ethdev
+;
+mempool mempool0 size 8192 buffers 4000 cache 256 numa 0
+
+;
+; DPDK devices and configuration.
+;
+; Note: Customize the parameters below to match your setup.
+;
+ethdev 0002:04:00.0 rxq 1 txq 8 mempool0
+ethdev 0002:05:00.0 rxq 1 txq 8 mempool0
+ethdev 0002:06:00.0 rxq 1 txq 8 mempool0
+ethdev 0002:07:00.0 rxq 1 txq 8 mempool0
+ethdev 0002:04:00.0 mtu 1700
+ethdev 0002:05:00.0 promiscuous on
+
+;
+; IPv4 addresses assigned to DPDK devices
+;
+ethdev 0002:04:00.0 ip4 addr add 10.0.2.1 netmask 255.255.255.0
+ethdev 0002:05:00.0 ip4 addr add 20.0.2.1 netmask 255.255.255.0
+ethdev 0002:06:00.0 ip4 addr add 30.0.2.1 netmask 255.255.255.0
+ethdev 0002:07:00.0 ip4 addr add 40.0.2.1 netmask 255.255.255.0
+
+;
+; IPv6 addresses assigned to DPDK devices
+;
+ethdev 0002:04:00.0 ip6 addr add 
52:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4A netmask 
FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00
+ethdev 0002:05:00.0 ip6 addr add 
62:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4B netmask 
FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00
+ethdev 0002:06:00.0 ip6 addr add 
72:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4C netmask 
FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00
+ethdev 0002:07:00.0 ip6 addr add 
82:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4D netmask 
FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00
+
+;
+; IPv4 routes which are installed to ipv4_lookup node for LPM processing
+;
+ipv4_lookup route add ipv4 10.0.2.0 netmask 255.255.255.0 via 10.0.2.1
+ipv4_lookup route add ipv4 20.0.2.0 netmask 255.255.255.0 via 20.0.2.1
+ipv4_lookup route add ipv4 30.0.2.0 netmask 255.255.255.0 via 30.0.2.1
+ipv4_lookup route add ipv4 40.0.2.0 netmask 255.255.255.0 via 40.0.2.1
+
+;
+; IPv6 routes which are installed to ipv6_lookup node for LPM processing
+;
+ipv6_lookup route add ipv6 52:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4A 
netmask FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00 via 
52:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4A
+ipv6_lookup route add ipv6 62:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4B 
netmask FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00 via 
62:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4B
+ipv6_lookup route add ipv6 72:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4C 
netmask FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00 via 
72:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4C
+ipv6_lookup route add ipv6 82:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4D 
netmask FF:FF:FF:FF:FF:FF:FF:FF:FF:00:00:00:00:00:00:00 via 
82:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4D
+
+;
+; Peer MAC and IPv4 address mapping
+;
+neigh add ipv4 10.0.2.2 52:20:DA:4F:68:70
+neigh add ipv4 20.0.2.2 62:20:DA:4F:68:70
+neigh add ipv4 30.0.2.2 72:20:DA:4F:68:70
+neigh add ipv4 40.0.2.2 82:20:DA:4F:68:70
+
+;
+; Peer MAC and IPv6 address mapping
+;
+neigh add ipv6 52:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4A 
52:20:DA:4F:68:70
+neigh add ipv6 62:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4B 
62:20:DA:4F:68:70
+neigh add ipv6 72:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4C 
72:20:DA:4F:68:70
+neigh add ipv6 82:20:DA:4F:68:70:52:20:DA:4F:68:70:52:20:DA:4D 
82:20:DA:4F:68:70
+
+;
+; Port-Queue-Core mapping fo

RE: [EXT] Re: [PATCH v2] dmadev: get DMA device using device ID

[Amit Prakash Shukla]

> -Original Message-
> From: Jerin Jacob 
> Sent: Thursday, September 21, 2023 9:13 PM
> To: Amit Prakash Shukla 
> Cc: Chengwen Feng ; Kevin Laatz
> ; Bruce Richardson ;
> dev@dpdk.org; Jerin Jacob Kollanukkaran ;
> conor.wa...@intel.com; Vamsi Krishna Attunuru ;
> g.si...@nxp.com; sachin.sax...@oss.nxp.com; hemant.agra...@nxp.com;
> cheng1.ji...@intel.com; Nithin Kumar Dabilpuram
> ; Anoob Joseph ;
> m...@smartsharesystems.com
> Subject: [EXT] Re: [PATCH v2] dmadev: get DMA device using device ID
> 
> External Email
> 
> --
> On Tue, Sep 19, 2023 at 5:12 PM Amit Prakash Shukla
>  wrote:
> >
> > DMA library has a function to get DMA device based on device name but
> > there is no function to get DMA device using device id.
> >
> > Added a function that lookup for the dma device using device id and
> > returns the pointer to the same.
> 
> Looks like it is useful for getting nb_vchan. Could you use info_get() API
> instead as it can be cached in slow path for DMA adapter?

Yeah, we can cache nb_vchan using rte_dma_info_get. We can drop the patch. 
Thanks.

[PATCH] ethdev: add calculate hash function

[Ori Kam]

rte_flow supports insert by index table[1].

Using the above table, the application can create rules
that are based on hash.
For example application can create the following logic in order
to create load balancing:
1. Create insert by index table with 2 rules, that hashes based on dmac
2. Insert to index 0 a rule that sends the traffic to port A.
3. Insert to index 1 a rule that sends the traffic to port B.

Let's also assume that before this table, there is a 5 tuple
match table that jumps to the above table.

So each packet that matches one of the 5 tuple rules is RSSed
to port A or B, based on dmac hash.

The issue arises when there is a miss on the 5 tuple table,
which resulted due to the packet being the first packet of this flow, or
fragmented packet or any other reason.
In this case, the application must calculate what would be the
hash calculated by the HW so it can send the packet to the correct
port.

This new API allows applications to calculate the hash value of a given
packet for a given table.

[1] - 
http://patches.dpdk.org/project/dpdk/patch/20230208030624.78465-2-akozy...@nvidia.com/

Signed-off-by: Ori Kam 
---
 app/test-pmd/cmdline_flow.c  | 86 +++-
 app/test-pmd/config.c| 54 ++
 app/test-pmd/testpmd.h   |  2 +
 lib/ethdev/rte_flow.c| 21 +
 lib/ethdev/rte_flow.h| 32 ++
 lib/ethdev/rte_flow_driver.h |  5 +++
 lib/ethdev/version.map   |  1 +
 7 files changed, 200 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 94827bcc4a..e1e4bb49fa 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -101,6 +101,7 @@ enum index {
QUEUE,
PUSH,
PULL,
+   HASH,
 
/* Flex arguments */
FLEX_ITEM_INIT,
@@ -206,6 +207,11 @@ enum index {
TABLE_PATTERN_TEMPLATE,
TABLE_ACTIONS_TEMPLATE,
 
+   /* Hash calculation arguments. */
+   HASH_CALC_TABLE,
+   HASH_CALC_PATTERN_INDEX,
+   HASH_CALC_PATTERN,
+
/* Tunnel arguments. */
TUNNEL_CREATE,
TUNNEL_CREATE_TYPE,
@@ -2678,6 +2684,9 @@ static int parse_push(struct context *, const struct 
token *,
 static int parse_pull(struct context *, const struct token *,
  const char *, unsigned int,
  void *, unsigned int);
+static int parse_hash(struct context *, const struct token *,
+ const char *, unsigned int,
+ void *, unsigned int);
 static int parse_tunnel(struct context *, const struct token *,
const char *, unsigned int,
void *, unsigned int);
@@ -3035,7 +3044,8 @@ static const struct token token_list[] = {
  FLEX,
  QUEUE,
  PUSH,
- PULL)),
+ PULL,
+ HASH)),
.call = parse_init,
},
/* Top-level command. */
@@ -3680,6 +3690,33 @@ static const struct token token_list[] = {
.args = ARGS(ARGS_ENTRY(struct buffer, queue)),
},
/* Top-level command. */
+   [HASH] = {
+   .name = "hash",
+   .help = "calculate hash for a given pattern in a given template 
table",
+   .next = NEXT(NEXT_ENTRY(HASH_CALC_TABLE), 
NEXT_ENTRY(COMMON_PORT_ID)),
+   .args = ARGS(ARGS_ENTRY(struct buffer, port)),
+   .call = parse_hash,
+   },
+   /* Sub-level commands. */
+   [HASH_CALC_TABLE] = {
+   .name = "template_table",
+   .help = "specify table id",
+   .next = NEXT(NEXT_ENTRY(HASH_CALC_PATTERN_INDEX),
+NEXT_ENTRY(COMMON_TABLE_ID)),
+   .args = ARGS(ARGS_ENTRY(struct buffer,
+   args.vc.table_id)),
+   .call = parse_hash,
+   },
+   [HASH_CALC_PATTERN_INDEX] = {
+   .name = "pattern_template",
+   .help = "specify pattern template id",
+   .next = NEXT(NEXT_ENTRY(ITEM_PATTERN),
+NEXT_ENTRY(COMMON_UNSIGNED)),
+   .args = ARGS(ARGS_ENTRY(struct buffer,
+   args.vc.pat_templ_id)),
+   .call = parse_hash,
+   },
+   /* Top-level command. */
[INDIRECT_ACTION] = {
.name = "indirect_action",
.type = "{command} {port_id} [{arg} [...]]",
@@ -10449,6 +10486,48 @@ parse_pull(struct context *ctx, const struct token 
*token,
return len;
 }
 
+/** Parse tokens for hash calculation commands. */
+static int
+parse_hash(struct context *ctx, const struct token *token,
+const char *str, unsigned int len,
+void *buf, unsigned int size)
+{
+   struct buffer *out = buf;
+
+   /*

Re: [PATCH v4 1/7] ethdev: recomment some definitions related to RSS

[Jie Hai]

On 2023/9/21 0:39, Ferruh Yigit wrote:

On 9/8/2023 9:00 AM, Jie Hai wrote:

1. Recomment fields of 'rte_eth_rss_conf'.
2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT.

Signed-off-by: Jie Hai 
---
  lib/ethdev/rte_ethdev.h | 28 +---
  lib/ethdev/rte_flow.h   |  4 
  2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 04a2564f222a..40cfbb7efddd 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -448,24 +448,22 @@ struct rte_vlan_filter_conf {
  /**
   * A structure used to configure the Receive Side Scaling (RSS) feature
   * of an Ethernet port.
- * If not NULL, the *rss_key* pointer of the *rss_conf* structure points
- * to an array holding the RSS key to use for hashing specific header
- * fields of received packets. The length of this array should be indicated
- * by *rss_key_len* below. Otherwise, a default random hash key is used by
- * the device driver.
- *
- * The *rss_key_len* field of the *rss_conf* structure indicates the length
- * in bytes of the array pointed by *rss_key*. To be compatible, this length
- * will be checked in i40e only. Others assume 40 bytes to be used as before.
- *
- * The *rss_hf* field of the *rss_conf* structure indicates the different
- * types of IPv4/IPv6 packets to which the RSS hashing must be applied.
- * Supplying an *rss_hf* equal to zero disables the RSS feature.
   */
  struct rte_eth_rss_conf {
-   uint8_t *rss_key;/**< If not NULL, 40-byte hash key. */
+   /**
+* If not NULL, 40-byte hash key to use for hashing specific header
+* fields of received packets. The size of rss_key should be indicated
+* by *rss_key_len* below.



It says key length is 40 bytes, also says key length is defined by
'rss_key_len'. I wonder how can we clarify this more, what about like:

If not NULL, hash key to use for hashing.
The size of rss_key should be indicated by *rss_key_len* below. Drivers
are free to ignore the *rss_key_len* and assume key length is 40 bytes.


Not all drivers use 40-bytes hash key,
e.g. the cnxk driver use hash key with length ROC_NIX_RSS_KEY_LEN(48).
I think it's best not to mention '40 bytes' in the comments.

This structure is used for querying and configuring, How about the 
following statements:


/**
 * If used to query, the'rss_key_len' indicates the sizeof rss key of
 * the hardware. And only when rss_key_len is not zero, the 'rss_key'
 * is valid.
 * If used to configure, rss_key_len indicates the length of the
 * 'rss_key' if 'rss_key' is not empty.
 */



+* Otherwise, a default random hash key is used by the device driver.
+*/
+   uint8_t *rss_key;
uint8_t rss_key_len; /**< hash key length in bytes. */
-   uint64_t rss_hf; /**< Hash functions to apply - see below. */
+   /**
+* The different types of packets to which the RSS hashing must be
+* applied, may be combined with SRC/DST_ONLY, see below.


I find this difficult to understand, can we simplify it?

The name 'hf' (hash function) is confusing on its own, but it is too
much burden to update it, at least we can clarify it with the above
documentation.

rte_flow defines it as 'types' (rte_flow_action_rss.type)
(and it has 'func' for "hash algorithm" to increase confusion).

Can we define something like (please don't use as it is, just thinking):
"
Set part of the packet that hashing will be applied for RSS purposes
(see RTE_ETH_RSS_*).
How about "Indicating which type of packets and which part of the 
packets to be applied for RSS hash, (see RTE_ETH_RSS_*)."

"


+* Supplying an *rss_hf* equal to zero disables the RSS feature.
+*/


s/Supply/Set/ ?
"Setting *rss_hf* to zero disables the RSS feature."

Will correct.



+   uint64_t rss_hf;
  };
  
  /*

diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 2ebb76dbc083..3bd0dc64fbe2 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -3187,6 +3187,10 @@ struct rte_flow_query_count {
   * Hash function types.
   */
  enum rte_eth_hash_function {
+   /**
+* DEFAULT means that conformance to a specific hash algorithm is
+* uncared to the caller. The driver can pick the one it deems optimal.


Not sure about word 'uncared' usage here, what about:

"
DEFAULT means driver decides which hash algorithm to pick.
"


That's better.


.

[PATCH v2 1/2] doc: increase python max line length to 100

[Juraj Linkeš]

Unify with C recommendations which allow line length of up to 100
characters.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 .editorconfig| 2 +-
 doc/doc_build/meson-private/meson.lock   | 0
 doc/guides/contributing/coding_style.rst | 3 +++
 3 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 doc/doc_build/meson-private/meson.lock

diff --git a/.editorconfig b/.editorconfig
index ab41c95085..1e7d74213f 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -16,7 +16,7 @@ max_line_length = 100
 [*.py]
 indent_style = space
 indent_size = 4
-max_line_length = 79
+max_line_length = 100
 
 [meson.build]
 indent_style = space
diff --git a/doc/doc_build/meson-private/meson.lock 
b/doc/doc_build/meson-private/meson.lock
new file mode 100644
index 00..e69de29bb2
diff --git a/doc/guides/contributing/coding_style.rst 
b/doc/guides/contributing/coding_style.rst
index 648849899d..a42cd3d58d 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -880,6 +880,9 @@ All Python code should be compliant with
 `PEP8 (Style Guide for Python Code) 
`_.
 
 The ``pep8`` tool can be used for testing compliance with the guidelines.
+Note that line lengths are acceptable up to 100 characters, which is in line 
with C recommendations.
+
+..
 
 Integrating with the Build System
 -
-- 
2.34.1

[PATCH v2 2/2] dts: reformat to 100 line length

[Juraj Linkeš]

Reformat to 100 from the previous 88 to unify with C recommendations.

Signed-off-by: Juraj Linkeš 
---
 dts/framework/config/__init__.py  | 20 ++-
 dts/framework/dts.py  | 12 +---
 dts/framework/exception.py|  3 +-
 dts/framework/remote_session/__init__.py  |  4 +-
 dts/framework/remote_session/linux_session.py | 39 -
 dts/framework/remote_session/posix_session.py | 30 +++---
 .../remote/interactive_remote_session.py  |  7 +--
 .../remote/interactive_shell.py   |  4 +-
 .../remote_session/remote/remote_session.py   |  8 +--
 .../remote_session/remote/ssh_session.py  | 16 ++
 .../remote_session/remote/testpmd_shell.py|  8 +--
 dts/framework/settings.py |  4 +-
 dts/framework/test_result.py  | 16 ++
 dts/framework/test_suite.py   | 57 +--
 .../capturing_traffic_generator.py|  4 +-
 dts/framework/testbed_model/hw/cpu.py | 20 ++-
 dts/framework/testbed_model/node.py   |  8 +--
 dts/framework/testbed_model/scapy.py  | 16 ++
 dts/framework/testbed_model/sut_node.py   | 38 -
 dts/framework/testbed_model/tg_node.py|  7 +--
 dts/framework/utils.py| 20 ++-
 dts/pyproject.toml|  4 +-
 dts/tests/TestSuite_hello_world.py|  4 +-
 dts/tests/TestSuite_smoke_tests.py| 11 +---
 24 files changed, 93 insertions(+), 267 deletions(-)

diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py
index cb7e00ba34..9b32cf0532 100644
--- a/dts/framework/config/__init__.py
+++ b/dts/framework/config/__init__.py
@@ -140,9 +140,7 @@ def from_dict(d: dict) -> Union["SutNodeConfiguration", 
"TGNodeConfiguration"]:
 
 if "traffic_generator" in d:
 return TGNodeConfiguration(
-traffic_generator=TrafficGeneratorConfig.from_dict(
-d["traffic_generator"]
-),
+
traffic_generator=TrafficGeneratorConfig.from_dict(d["traffic_generator"]),
 **common_config,
 )
 else:
@@ -249,9 +247,7 @@ def from_dict(
 build_targets: list[BuildTargetConfiguration] = list(
 map(BuildTargetConfiguration.from_dict, d["build_targets"])
 )
-test_suites: list[TestSuiteConfig] = list(
-map(TestSuiteConfig.from_dict, d["test_suites"])
-)
+test_suites: list[TestSuiteConfig] = 
list(map(TestSuiteConfig.from_dict, d["test_suites"]))
 sut_name = d["system_under_test_node"]["node_name"]
 skip_smoke_tests = d.get("skip_smoke_tests", False)
 assert sut_name in node_map, f"Unknown SUT {sut_name} in execution {d}"
@@ -268,9 +264,7 @@ def from_dict(
 ), f"Invalid TG configuration {traffic_generator_node}"
 
 vdevs = (
-d["system_under_test_node"]["vdevs"]
-if "vdevs" in d["system_under_test_node"]
-else []
+d["system_under_test_node"]["vdevs"] if "vdevs" in 
d["system_under_test_node"] else []
 )
 return ExecutionConfiguration(
 build_targets=build_targets,
@@ -299,9 +293,7 @@ def from_dict(d: dict) -> "Configuration":
 assert len(nodes) == len(node_map), "Duplicate node names are not 
allowed"
 
 executions: list[ExecutionConfiguration] = list(
-map(
-ExecutionConfiguration.from_dict, d["executions"], [node_map 
for _ in d]
-)
+map(ExecutionConfiguration.from_dict, d["executions"], [node_map 
for _ in d])
 )
 
 return Configuration(executions=executions)
@@ -315,9 +307,7 @@ def load_config() -> Configuration:
 with open(SETTINGS.config_file_path, "r") as f:
 config_data = yaml.safe_load(f)
 
-schema_path = os.path.join(
-pathlib.Path(__file__).parent.resolve(), "conf_yaml_schema.json"
-)
+schema_path = os.path.join(pathlib.Path(__file__).parent.resolve(), 
"conf_yaml_schema.json")
 
 with open(schema_path, "r") as f:
 schema = json.load(f)
diff --git a/dts/framework/dts.py b/dts/framework/dts.py
index f773f0c38d..e2aada5a23 100644
--- a/dts/framework/dts.py
+++ b/dts/framework/dts.py
@@ -92,9 +92,7 @@ def _run_execution(
 Run the given execution. This involves running the execution setup as well 
as
 running all build targets in the given execution.
 """
-dts_logger.info(
-f"Running execution with SUT 
'{execution.system_under_test_node.name}'."
-)
+dts_logger.info(f"Running execution with SUT 
'{execution.system_under_test_node.name}'.")
 execution_result = result.add_execution(sut_node.config)
 execution_result.add_sut_info(sut_node.node_info)
 
@@ -107,9 +105,7 @@ def _run_execution(
 
 else:
 for build_target in execution.build_targets:
-_run_buil

RE: [PATCH v3] net/iavf: add devargs to enable vf auto-reset

[Zhang, Qi Z]

> -Original Message-
> From: Bruce Richardson 
> Sent: Tuesday, September 26, 2023 3:49 PM
> To: He, ShiyangX 
> Cc: dev@dpdk.org; Zhou, YidingX ; Wang, Liang-
> min ; Su, Simei ; Wu,
> Wenjun1 ; Zhang, Yuying
> ; Xing, Beilei ; Yang,
> Qiming ; Wu, Jingjing 
> Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset
> 
> On Fri, Sep 15, 2023 at 01:02:49PM +, Shiyang He wrote:
> > Originally, the iavf PMD does not perform special actions when it
> > receives a PF-to-VF reset event, resulting in vf being offline and
> > unavailable.
> >
> > This patch enables vf auto-reset by setting 'watchdog_period' devargs
> > to true. The iavf PMD will perform an automatic reset to bring the vf
> > back online when it receives a PF-to-VF event.
> >
> > v2: handling reset by event handler
> > v3: change reset process
> >
> > Signed-off-by: Shiyang He 
> > Signed-off-by: Liang-Min Larry Wang 
> > ---
> >  doc/guides/nics/intel_vf.rst   |  3 +
> >  doc/guides/rel_notes/release_23_11.rst |  3 +
> >  drivers/net/iavf/iavf.h|  7 +++
> >  drivers/net/iavf/iavf_ethdev.c | 86 +++---
> >  drivers/net/iavf/iavf_rxtx.c   | 52 ++--
> >  drivers/net/iavf/iavf_vchnl.c  | 11 +++-
> >  6 files changed, 135 insertions(+), 27 deletions(-)
> >
> > diff --git a/doc/guides/nics/intel_vf.rst
> > b/doc/guides/nics/intel_vf.rst index d365dbc185..c0acd2a7f5 100644
> > --- a/doc/guides/nics/intel_vf.rst
> > +++ b/doc/guides/nics/intel_vf.rst
> > @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the
> following documents:
> >  Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog
> period in microseconds, or set it to 0 to disable the watchdog,
> >  for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a
> 18:01.0,watchdog_period=0``.
> >
> > +Enable vf auto-reset by setting the ``devargs`` parameter like ``-a
> 18:01.0,enable_auto_reset=1`` when IAVF is backed
> > +by an Intel(r) E810 device or an Intel(r) 700 Series Ethernet device.
> > +
> 
> Why do we need a devargs for this? If the VF is unavailable - as you mention
> in the commit log above - should this behaviour not always be the case
> without the user having to ask?

Ideally it does not need, but with below considerations:

1. Not break existing scenario, which still assume some application will call 
dev_reset /dev_configure/ queue_setup / ...  after receive 
RTE_ETH_EVENT_INTR_RESET event to recover the VF manually, the devargs make 
sure application be aware of this new feature and will not call 
rte_eth_dev_reset which will fail now.

2. intent to ensure a smoother transition, in case some corner case issues 
evaded our validation, keeping this devargs provides us with the flexibility to 
remove it once we determine that the implementation is stable enough.  

> 
> /Bruce

[PATCH v2 0/2] offload support to free dma source buffer

[Amit Prakash Shukla]

This series adds offload support to free source buffer in dma library
and adds a test support in dmadev_autotest to validate the
functionality.

v2:
- Resolved review comments.
- Fixed compilation issue.

v1:
- Implementation from RFC.
- Add test support to validate functionality.

Amit Prakash Shukla (2):
  dmadev: offload to free source buffer
  test/dma: add source buffer offload free test

 app/test/test_dmadev.c  | 167 +++-
 lib/dmadev/rte_dmadev.h |  27 +++
 2 files changed, 193 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH v2 1/2] dmadev: offload to free source buffer

[Amit Prakash Shukla]

This changeset adds support in DMA library to free source DMA buffer by
hardware. On a supported hardware, application can pass on the mempool
information as part of vchan config when the DMA transfer direction is
configured as RTE_DMA_DIR_MEM_TO_DEV.

Signed-off-by: Amit Prakash Shukla 
Acked-by: Morten Brørup 
Acked-by: Anoob Joseph 
---
 lib/dmadev/rte_dmadev.h | 27 +++
 1 file changed, 27 insertions(+)

diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
index b157ab7600..f7a6af2528 100644
--- a/lib/dmadev/rte_dmadev.h
+++ b/lib/dmadev/rte_dmadev.h
@@ -278,6 +278,13 @@ int16_t rte_dma_next_dev(int16_t start_dev_id);
 #define RTE_DMA_CAPA_OPS_COPY_SG   RTE_BIT64(33)
 /** Support fill operation. */
 #define RTE_DMA_CAPA_OPS_FILL  RTE_BIT64(34)
+/** Support for source buffer free for mem to dev transfer.
+ *
+ * @note Even though the DMA driver has this capability, it may not support all
+ * mempool drivers. If the mempool is not supported by the DMA driver,
+ * rte_dma_vchan_setup() will fail.
+ **/
+#define RTE_DMA_CAPA_MEM_TO_DEV_SOURCE_BUFFER_FREE RTE_BIT64(35)
 /**@}*/
 
 /**
@@ -581,6 +588,19 @@ struct rte_dma_vchan_conf {
 * @see struct rte_dma_port_param
 */
struct rte_dma_port_param dst_port;
+   /** Mempool from which source buffer is allocated. Mempool info is used
+* for freeing source buffer by hardware when configured direction is
+* RTE_DMA_DIR_MEM_TO_DEV. To free the source buffer by hardware,
+* RTE_DMA_OP_FLAG_FREE_SBUF must be set while calling rte_dma_copy and
+* rte_dma_copy_sg().
+*
+* @note If the mempool is not supported by the DMA device,
+* rte_dma_vchan_setup() will fail.
+*
+* @see RTE_DMA_OP_FLAG_FREE_SBUF
+*/
+   struct rte_mempool *mem_to_dev_src_buf_pool;
+
 };
 
 /**
@@ -818,6 +838,13 @@ struct rte_dma_sge {
  * capability bit for this, driver should not return error if this flag was 
set.
  */
 #define RTE_DMA_OP_FLAG_LLC RTE_BIT64(2)
+/** Mem to dev source buffer free flag.
+ * Used for freeing source DMA buffer by hardware when the transfer direction 
is
+ * configured as RTE_DMA_DIR_MEM_TO_DEV.
+ *
+ * @see struct rte_dma_vchan_conf::mem_to_dev_src_buf_pool
+ */
+#define RTE_DMA_OP_FLAG_FREE_SBUF  RTE_BIT64(3)
 /**@}*/
 
 /**
-- 
2.25.1

[PATCH v2 2/2] test/dma: add source buffer offload free test

[Amit Prakash Shukla]

Add a test case to validate the functionality of drivers' dma
source buffer offload free. As part of dmadev_autotest, test case
will be executed only if the driver supports source buffer offload
free and if the test is exported by env variable DPDK_ADD_DMA_TEST.

Signed-off-by: Amit Prakash Shukla 
---
 app/test/test_dmadev.c | 167 -
 1 file changed, 166 insertions(+), 1 deletion(-)

diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index 6ef875e545..45f1f12b17 100644
--- a/app/test/test_dmadev.c
+++ b/app/test/test_dmadev.c
@@ -18,11 +18,37 @@
 
 #define ERR_RETURN(...) do { print_err(__func__, __LINE__, __VA_ARGS__); 
return -1; } while (0)
 
+#define TEST_RINGSIZE 512
 #define COPY_LEN 1024
 
 static struct rte_mempool *pool;
 static uint16_t id_count;
 
+enum {
+   TEST_PARAM_REMOTE_ADDR = 0,
+   TEST_PARAM_MAX,
+};
+
+static const char * const dma_test_param[] = {
+   [TEST_PARAM_REMOTE_ADDR] = "remote_addr",
+};
+
+static uint64_t env_test_param[TEST_PARAM_MAX];
+
+enum {
+   TEST_SRC_BUF_FREE = 0,
+   TEST_MAX,
+};
+
+struct dma_add_test {
+   const char *name;
+   bool enabled;
+};
+
+struct dma_add_test dma_add_test[] = {
+   [TEST_SRC_BUF_FREE] = {.name = "sbuf_free", .enabled = false},
+};
+
 static void
 __rte_format_printf(3, 4)
 print_err(const char *func, int lineno, const char *format, ...)
@@ -797,10 +823,104 @@ test_burst_capacity(int16_t dev_id, uint16_t vchan)
return 0;
 }
 
+static int
+test_sbuf_free(int16_t dev_id, uint16_t vchan)
+{
+#define NR_MBUF 256
+   struct rte_mbuf *src[NR_MBUF], *dst[NR_MBUF];
+   const struct rte_dma_vchan_conf qconf = {
+   .direction = RTE_DMA_DIR_MEM_TO_DEV,
+   .nb_desc = TEST_RINGSIZE,
+   .mem_to_dev_src_buf_pool = pool,
+   .dst_port.port_type = RTE_DMA_PORT_PCIE,
+   /* Assuming pemid as 0. */
+   .dst_port.pcie.coreid = 0,
+   };
+   uint32_t buf_cnt1, buf_cnt2;
+   struct rte_mempool_ops *ops;
+   static bool dev_init;
+   uint16_t nb_done = 0;
+   bool dma_err = false;
+   int retry = 100;
+   int i, ret = 0;
+
+   if (!dev_init) {
+   /* Stop the device to reconfigure vchan. */
+   if (rte_dma_stop(dev_id) < 0)
+   ERR_RETURN("Error stopping device %u\n", dev_id);
+
+   if (rte_dma_vchan_setup(dev_id, vchan, &qconf) < 0)
+   ERR_RETURN("Error with queue configuration\n");
+
+   if (rte_dma_start(dev_id) != 0)
+   ERR_RETURN("Error with rte_dma_start()\n");
+
+   dev_init = true;
+   }
+
+   if (rte_pktmbuf_alloc_bulk(pool, dst, NR_MBUF) != 0)
+   ERR_RETURN("alloc dst mbufs failed.\n");
+
+   for (i = 0; i < NR_MBUF; i++) {
+   /* Using mbuf structure to hold remote iova address. */
+   rte_mbuf_iova_set(dst[i], 
(rte_iova_t)env_test_param[TEST_PARAM_REMOTE_ADDR]);
+   dst[i]->data_off = 0;
+   }
+
+   /* Capture buffer count before allocating source buffer. */
+   ops = rte_mempool_get_ops(pool->ops_index);
+   buf_cnt1 = ops->get_count(pool);
+
+   if (rte_pktmbuf_alloc_bulk(pool, src, NR_MBUF) != 0) {
+   printf("alloc src mbufs failed.\n");
+   ret = -1;
+   goto done;
+   }
+
+   if ((buf_cnt1 - NR_MBUF) != ops->get_count(pool)) {
+   printf("Buffer count check failed.\n");
+   ret = -1;
+   goto done;
+   }
+
+   for (i = 0; i < NR_MBUF; i++) {
+   ret = rte_dma_copy(dev_id, vchan, rte_mbuf_data_iova(src[i]),
+   rte_mbuf_data_iova(dst[i]), COPY_LEN,
+   RTE_DMA_OP_FLAG_FREE_SBUF);
+
+   if (ret < 0) {
+   printf("rte_dma_copy returned error.\n");
+   goto done;
+   }
+   }
+
+   rte_dma_submit(dev_id, vchan);
+   do {
+   nb_done += rte_dma_completed(dev_id, vchan, (NR_MBUF - 
nb_done), NULL, &dma_err);
+   if (dma_err)
+   break;
+   /* Sleep for 1 millisecond */
+   rte_delay_us_sleep(1000);
+   } while (retry-- && (nb_done < NR_MBUF));
+
+   buf_cnt2 = ops->get_count(pool);
+   if ((buf_cnt1 != buf_cnt2) || dma_err) {
+   printf("Free source buffer test failed.\n");
+   ret = -1;
+   }
+
+done:
+   rte_pktmbuf_free_bulk(dst, NR_MBUF);
+   /* If the test passes source buffer will be freed in hardware. */
+   if (ret < 0)
+   rte_pktmbuf_free_bulk(&src[nb_done], (NR_MBUF - nb_done));
+
+   return ret;
+}
+
 static int
 test_dmadev_instance(int16_t dev_id)
 {
-#define TEST_RINGSIZE 512
 #define CHECK_ERRStrue
struct rte_dma_stats stats;
struct rte_dma_info i

Re: [PATCH v2 1/2] doc: increase python max line length to 100

[Bruce Richardson]

On Tue, Sep 26, 2023 at 02:10:12PM +0200, Juraj Linkeš wrote:
> Unify with C recommendations which allow line length of up to 100
> characters.
> 
> Signed-off-by: Owen Hilyard 
> Signed-off-by: Juraj Linkeš 
> ---
Acked-by: Bruce Richardson 

Re: [PATCH v5 01/32] net/sssnic: add build and doc infrastructure

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Adding minimum PMD code, doc and build infrastructure for sssnic.
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> @@ -633,6 +633,13 @@ F: drivers/net/af_xdp/
>  F: doc/guides/nics/af_xdp.rst
>  F: doc/guides/nics/features/af_xdp.ini
>  
> +3SNIC sssnic
> +M: Renyong Wan 
> +M: Steven Song 
> +F: drivers/net/sssnic/
> +F: doc/guides/nics/sssnic.rst
> +F: doc/guides/nics/features/sssnic.ini
> +
>

The list is sorted by the company name, I am aware above virtual devices
(af_xdp, af_packet & bondign) are causing the confusion, they are not
sorted clearly, please move the driver as first net driver, we can fix
the virtual ones later.


>  Amazon ENA
>  M: Michal Krawczyk 
>  M: Shai Brandes 
> diff --git a/doc/guides/nics/features/sssnic.ini 
> b/doc/guides/nics/features/sssnic.ini
> new file mode 100644
> index 00..6d9786db7e
> --- /dev/null
> +++ b/doc/guides/nics/features/sssnic.ini
> @@ -0,0 +1,9 @@
> +;
> +; Supported features of the 'sssnic' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Linux= Y
> +ARMv8= Y
> +x86-64   = Y
> diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
> index 7bfcac880f..9d2b29383b 100644
> --- a/doc/guides/nics/index.rst
> +++ b/doc/guides/nics/index.rst
> @@ -61,6 +61,7 @@ Network Interface Controller Drivers
>  qede
>  sfc_efx
>  softnic
> +sssnic
>  tap
>  thunderx
>  txgbe
> diff --git a/doc/guides/nics/sssnic.rst b/doc/guides/nics/sssnic.rst
> new file mode 100644
> index 00..fe0180c2e6
> --- /dev/null
> +++ b/doc/guides/nics/sssnic.rst
> @@ -0,0 +1,73 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +Copyright(c) 2022 Shenzhen 3SNIC Information Technology Co., Ltd.
> +
> +SSSNIC Poll Mode Driver
> +===
> +
> +The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
> +for 3SNIC 9x0 serials family of Ethernet adapters.
> +
> +
> +Supported NICs
> +--
> +
> +- 3S910 Dual Port SFP28 10/25GbE Ethernet adapter
> +- 3S920 Quad Port SFP28 10/25GbE Ethernet adapter
> +- 3S920 Quad Port QSFP28 100GbE Ethernet adapter
>

3S930 ?
I can see from your website, that is the one with 100GbE interface.

It can be nice to have a link to each device page, if possible.


> +
> +
> +Features
> +
> +
> +Features of sssnic PMD are:
> +
> +- Link status
> +- Link status event
> +- Queue start/stop
> +- Rx interrupt
> +- Scattered Rx
> +- TSO
> +- LRO
> +- Promiscuous mode
> +- Allmulticast mode
> +- Unicast MAC filter
> +- Multicast MAC filte
> +- RSS hash
> +- RSS key update
> +- RSS reta update
> +- Inner RSS
> +- VLAN filter
> +- VLAN offload
> +- L3 checksum offload
> +- L4 checksum offload
> +- Inner L3 checksum
> +- Inner L4 checksum
> +- Basic stats
> +- Extended stats
> +- Stats per queue
> +- Flow control
> +- FW version
> +- Generic flow API
> +
>

Can you please update this list as features added to the code? Similar
to what you are already doing with sssnic.ini.

This helps whoever checking the git history can find the relevant code
from documentation git blame.


> +
> +Prerequisites
> +-
> +
> +- Learning about 3SNIC Ethernet NICs using
> +  ``_.
> +
> +- Follow the DPDK :ref:`Getting Started Guide for Linux ` to 
> setup the basic DPDK environment.
> +
> +
> +Driver compilation and testing
> +--
> +
> +Refer to the document :ref:`compiling and testing a PMD for a NIC 
> `
> +for details.
> +
> +
> +Limitations or Known issues
> +---
> +
> +Build with ICC is not supported yet.
>

I don't know listing ICC as relevant anymore, I am not aware of anyone
testing it. So can drop this limitation.

Re: [PATCH v5 11/32] net/sssnic: add dev MAC ops

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> +int
> +sssnic_mac_addr_update(struct sssnic_hw *hw, uint8_t *new, uint8_t *old)
> +{
> + int ret;
> + struct sssnic_mac_addr_update_cmd cmd;
> + struct sssnic_msg msg;
> + uint32_t cmd_len;
> + uint16_t func;
> +
> + if (hw == NULL || new == NULL || old == NULL)
> + return -EINVAL;
> +
> + if (SSSNIC_FUNC_TYPE(hw) == SSSNIC_FUNC_TYPE_VF)
> + func = SSSNIC_PF_FUNC_IDX(hw);
> + else
> + func = SSSNIC_MPU_FUNC_IDX;
> +
> + memset(&cmd, 0, sizeof(cmd));
> + cmd_len = sizeof(cmd);
> + cmd.function = SSSNIC_FUNC_IDX(hw);
> + rte_memcpy(cmd.new_addr, new, 6);
> + rte_memcpy(cmd.old_addr, old, 6);>

Can use 'RTE_ETHER_ADDR_LEN' instead of hardcoded '6', same for a few
other locations,

<...>

> +static int
> +sssnic_ethdev_mac_addrs_init(struct rte_eth_dev *ethdev)
> +{
> + int ret;
> + struct sssnic_netdev *netdev;
> + struct sssnic_hw *hw;
> + struct rte_ether_addr default_addr;
> + char mac_str[RTE_ETHER_ADDR_FMT_SIZE];
> +
> + PMD_INIT_FUNC_TRACE();
> +
> + netdev = SSSNIC_ETHDEV_PRIVATE(ethdev);
> + hw = SSSNIC_NETDEV_TO_HW(netdev);
> +
> + ethdev->data->mac_addrs = rte_zmalloc(NULL,
> + SSSNIC_ETHDEV_MAX_NUM_UC_MAC * sizeof(struct rte_ether_addr),
> + 0);
> + if (ethdev->data->mac_addrs == NULL) {
> + PMD_DRV_LOG(ERR,
> + "Failed to allocate memory to store %u mac addresses",
> + SSSNIC_ETHDEV_MAX_NUM_UC_MAC);
> + return -ENOMEM;
> + }
> +
> + netdev->mcast_addrs = rte_zmalloc(NULL,
> + SSSNIC_ETHDEV_MAX_NUM_MC_MAC * sizeof(struct rte_ether_addr),
> + 0);
> + if (netdev->mcast_addrs == NULL) {
> + PMD_DRV_LOG(ERR,
> + "Failed to allocate memory to store %u mcast addresses",
> + SSSNIC_ETHDEV_MAX_NUM_MC_MAC);
> + ret = -ENOMEM;
> + goto alloc_mcast_addr_fail;
> + }
> +
> + /* initialize default MAC address */
> + memset(&default_addr, 0, sizeof(default_addr));
> + ret = sssnic_mac_addr_get(hw, default_addr.addr_bytes);
> + if (ret != 0)
> + PMD_DRV_LOG(NOTICE,
> + "Could not get default MAC address, will use random 
> address");
> +
> + if (rte_is_zero_ether_addr(&default_addr))
> + rte_eth_random_addr(default_addr.addr_bytes);
> +
> + rte_ether_format_addr(mac_str, RTE_ETHER_ADDR_FMT_SIZE, &default_addr);
> +
> + ret = sssnic_mac_addr_add(hw, default_addr.addr_bytes);
> + if (ret != 0) {
> + PMD_DRV_LOG(ERR, "Failed to add default MAC address: %s",
> + mac_str);
> + goto add_ether_addr_fail;
> + }
> +
> + rte_ether_addr_copy(&default_addr, ðdev->data->mac_addrs[0]);
> + rte_ether_addr_copy(&default_addr, &netdev->default_addr);
> +
>

Is there a reason to keep 'default_addr' in the device private data,
when it is already stored in 'ethdev->data->mac_addrs[0]'?

<...>

> @@ -80,6 +333,7 @@ sssnic_ethdev_release(struct rte_eth_dev *ethdev)
>  {
>   struct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);
>  
> + sssnic_ethdev_mac_addrs_clean(ethdev);
>

Should 'netdev->mcast_addrs' freed in this context?
As far as I can see it is not freed anywhere.

<...>

> @@ -140,7 +408,7 @@ sssnic_ethdev_uninit(struct rte_eth_dev *ethdev)
>  
>   sssnic_ethdev_release(ethdev);
>  
> - return -EINVAL;
> + return 0;
>

This should be in previous patch, 4/32, which updates uninit function.

Re: [PATCH v5 13/32] net/sssnic: support link status event

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> diff --git a/drivers/net/sssnic/base/meson.build 
> b/drivers/net/sssnic/base/meson.build
> index e93ca7b24b..cf0c177cab 100644
> --- a/drivers/net/sssnic/base/meson.build
> +++ b/drivers/net/sssnic/base/meson.build
> @@ -9,6 +9,7 @@ sources = [
>  'sssnic_workq.c',
>  'sssnic_ctrlq.c',
>  'sssnic_api.c',
> + 'sssnic_exception.c',
>

There is an indendation issue, overall there are some meson warnings,
can you please address them:

$ ./devtools/check-meson.py
Error parsing drivers/net/sssnic/base/meson.build:11, got some tabulation
Error: Incorrect indent at drivers/net/sssnic/base/meson.build:12
Error parsing drivers/net/sssnic/base/meson.build:16, got some tabulation
Error parsing drivers/net/sssnic/base/meson.build:17, got some tabulation

Re: [PATCH v5 19/32] net/sssnic: support dev start and stop

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> diff --git a/drivers/net/sssnic/sssnic_ethdev_rx.c 
> b/drivers/net/sssnic/sssnic_ethdev_rx.c
> index 9c1b2f20d1..fd4975dfd5 100644
> --- a/drivers/net/sssnic/sssnic_ethdev_rx.c
> +++ b/drivers/net/sssnic/sssnic_ethdev_rx.c
> @@ -185,7 +185,7 @@ sssnic_ethdev_rxq_doorbell_ring(struct sssnic_ethdev_rxq 
> *rxq, uint16_t pi)
>   db.qid = rxq->qid;
>   db.pi_hi = (hw_pi >> 8) & 0xff;
>  
> - db_addr = (uint64_t *)(rxq->doorbell + (hw_pi & 0xff));
> + db_addr = ((uint64_t *)rxq->doorbell) + (hw_pi & 0xff);
>  

Can you please fix this where it is introduced at first place?

Re: [PATCH v5 20/32] net/sssnic: support dev close and reset

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> +static int
> +sssnic_ethdev_close(struct rte_eth_dev *ethdev)
> +{
> + sssnic_ethdev_release(ethdev);
> +
>

As close() is mostly empty, I just want to remind that all resources
should be freed in this function.

I am not aware anything missing, but can you please double check all
driver allocated memory is freed in this function?

Re: [PATCH v5 24/32] net/sssnic: support Tx packet burst

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> +static inline int
> +sssnic_ethdev_tx_offload_check(struct rte_mbuf *tx_mbuf,
> + struct sssnic_ethdev_tx_info *tx_info)
> +{
> + uint64_t ol_flags = tx_mbuf->ol_flags;
> +
> + if ((ol_flags & SSSNIC_ETHDEV_TX_OFFLOAD_MASK) == 0) {
> + tx_info->offload_en = 0;
> + return 0;
> + }
> +
> +#ifdef RTE_LIBRTE_ETHDEV_DEBUG
> + if (rte_validate_tx_offload(tx_mbuf) != 0) {
> + SSSNIC_TX_LOG(ERR, "Bad tx mbuf offload flags: %" PRIx64, 
> ol_flags);
> + return -EINVAL;
> + }
> +#endif
>

'RTE_LIBRTE_ETHDEV_DEBUG' kept as backward compatibilty alias, better to
prefer fine grained RTE_ETHDEV_DEBUG_TX.

Re: [PATCH v5 32/32] net/sssnic: add VF dev support

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> In comparison to PF, VF PMD does not support the following features:
> 
> 1. link up and link down set
> 2. promiscuous enable and disable
> 3. MAC stats in extend xstats
> 

Does it make sense to document these in the driver documentation?

Re: [PATCH v5 29/32] net/sssnic: add dev flow control ops

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> ---
>  doc/guides/nics/features/sssnic.ini  |  1 +
>  drivers/net/sssnic/base/sssnic_api.c | 68 
>  drivers/net/sssnic/base/sssnic_api.h |  4 ++
>  drivers/net/sssnic/base/sssnic_cmd.h | 11 +
>  drivers/net/sssnic/sssnic_ethdev.c   | 65 ++
>  5 files changed, 149 insertions(+)
> 
> diff --git a/doc/guides/nics/features/sssnic.ini 
> b/doc/guides/nics/features/sssnic.ini
> index a40b509558..9bf05cb968 100644
> --- a/doc/guides/nics/features/sssnic.ini
> +++ b/doc/guides/nics/features/sssnic.ini
> @@ -26,6 +26,7 @@ Inner L4 checksum= Y
>  Basic stats  = Y
>  Extended stats   = Y
>  Stats per queue  = Y
> +Flow control = P
>

Can you please describe in the commit log, why flow control is supported
partially?

Re: [PATCH v5 07/32] net/sssnic/base: add mailbox support

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> Mailbox is a message channel used to communicate between PF and
> VF as well as driver and hardware functions.
> Mailbox messages are received by driver through event queue, and
> sent by driver through registers of mailbox.
> There are two transfer modes for sending mailbox message, one is
> DMA mode used to send message to PF, another is inline mode used
> to send message to VF.
> 
> Signed-off-by: Steven Song 
> Signed-off-by: Renyong Wan 
> 

<...>

> diff --git a/drivers/net/sssnic/base/sssnic_mbox.h 
> b/drivers/net/sssnic/base/sssnic_mbox.h
> new file mode 100644
> index 00..00fa02ea78
> --- /dev/null
> +++ b/drivers/net/sssnic/base/sssnic_mbox.h
> @@ -0,0 +1,45 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018-2022 Shenzhen 3SNIC Information Technology Co., Ltd.
> + */
> +
> +#ifndef _SSSNIC_MBOX_H_
> +#define _SSSNIC_MBOX_H_
> +
> +#include 
> +
> +#include "sssnic_msg.h"
> +
> +enum sssnic_mbox_state {
> + /* Mbox is sending message or waiting for response */
> + SSSNIC_MBOX_STATE_RUNNING,
> + /* Waiting for response timed out*/
> + SSSNIC_MBOX_STATE_TIMEOUT,
> + /* Mbox failed to send message */
> + SSSNIC_MBOX_STATE_FAILED,
> + /* Response is ready */
> + SSSNIC_MBOX_STATE_READY,
> + /* Mbox is idle, it can send message */
> + SSSNIC_MBOX_STATE_IDLE,
> +};
> +
> +struct sssnic_sendbox;
> +
> +struct sssnic_mbox {
> + struct sssnic_hw *hw;
> + /* just be used for sending request msg*/
> + pthread_mutex_t req_lock;
>

This is causing build error in my local environment for armv8 cross
compile, I guess including pthread header explicitly is required:

 In file included from ../drivers/net/sssnic/base/sssnic_ctrlq.c:15:
 ../drivers/net/sssnic/base/sssnic_mbox.h:30:9: error: unknown type name
‘pthread_mutex_t’
30 | pthread_mutex_t req_lock;
   | ^~~

Re: [PATCH v5 00/32] Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters

[Ferruh Yigit]

On 9/4/2023 5:56 AM, wa...@3snic.com wrote:
> From: Renyong Wan 
> 
> The sssnic PMD (**librte_pmd_sssnic**) provides poll mode driver support
> for 3SNIC 9x0 serials family of Ethernet adapters.
> 
> Supported NICs are:
> 
> - 3S910 Dual Port SFP28 10/25GbE Ethernet adapter
> - 3S920 Quad Port SFP28 10/25GbE Ethernet adapter
> - 3S920 Quad Port QSFP28 100GbE Ethernet adapter
> 
> Features of sssnic PMD are:
> 
> - Link status
> - Link status event
> - Queue start/stop
> - Rx interrupt
> - Scattered Rx
> - TSO
> - LRO
> - Promiscuous mode
> - Allmulticast mode
> - Unicast MAC filter
> - Multicast MAC filte
> - RSS hash
> - RSS key update
> - RSS reta update
> - Inner RSS
> - VLAN filter
> - VLAN offload
> - L3 checksum offload
> - L4 checksum offload
> - Inner L3 checksum
> - Inner L4 checksum
> - Basic stats
> - Extended stats
> - Stats per queue
> - Flow control
> - FW version
> - Generic flow API
> 
> ---
> v2:
> * Fixed 'Title underline too short' in doc/guides/nics/sssnic.rst.
> * Removed error.h from including files.
> * Fixed variable 'cmd_len' is uninitialized when used.
> * Fixed 'EINVAL' undeclared.
> * Fixed wrong format of printing uint64_t.
> * Fixed 'mask->hdr.src_addr' will always evaluate to 'true'.
> 
> v3:
> * Fixed dereferencing type-punned pointer in base/sssnic_mbox.c.
> 
> v4:
> * Fixed dereferencing type-punned pointer in base/sssnic_eventq.c.
> * Fixed coding style issue of COMPLEX_MACRO.
> * Fixed coding style issue of REPEATED_WORD.
> 
> v5:
> * Fixed rebase mistake.
> * Fixed incorrect path in MAINTAINERS file.
> ---
> 
> Renyong Wan (32):
>   net/sssnic: add build and doc infrastructure
>   net/sssnic: add log type and log macros
>   net/sssnic: support probe and remove
>   net/sssnic: initialize hardware base
>   net/sssnic: add event queue
>   net/sssnic/base: add message definition and utility
>   net/sssnic/base: add mailbox support
>   net/sssnic/base: add work queue
>   net/sssnic/base: add control queue
>   net/sssnic: add dev configure and infos get
>   net/sssnic: add dev MAC ops
>   net/sssnic: support dev link status
>   net/sssnic: support link status event
>   net/sssnic: support Rx queue setup and release
>   net/sssnic: support Tx queue setup and release
>   net/sssnic: support Rx queue start and stop
>   net/sssnic: support Tx queue start and stop
>   net/sssnic: add Rx interrupt support
>   net/sssnic: support dev start and stop
>   net/sssnic: support dev close and reset
>   net/sssnic: add allmulticast and promiscuous ops
>   net/sssnic: add basic and extended stats ops
>   net/sssnic: support Rx packet burst
>   net/sssnic: support Tx packet burst
>   net/sssnic: add RSS support
>   net/sssnic: support dev MTU set
>   net/sssnic: support dev queue info get
>   net/sssnic: support dev firmware version get
>   net/sssnic: add dev flow control ops
>   net/sssnic: support VLAN offload and filter
>   net/sssnic: add generic flow ops
>   net/sssnic: add VF dev support
> 

Hi Renyong,

Driver mostly looks good, I did put some minor comments, I guess driver
can be merged soon with those issues addressed.

Also agree on Stephen's comments, if you apply them in next version,
please feel free to keep Stephen's ack in next version.

Thanks,
ferruh

Re: [PATCH v4 2/7] ethdev: support setting and querying RSS algorithm

[Jie Hai]

On 2023/9/21 0:39, Ferruh Yigit wrote:

On 9/8/2023 9:00 AM, Jie Hai wrote:

Currently, rte_eth_rss_conf supports configuring and querying
RSS hash functions, rss key and it's length, but not RSS hash
algorithm.

The structure ``rte_eth_rss_conf`` is extended by adding a new
field "func". This represents the RSS algorithms to apply. The
following API will be affected:
- rte_eth_dev_configure
- rte_eth_dev_rss_hash_update
- rte_eth_dev_rss_hash_conf_get



The problem with adding new configuration fields is, none of the drivers
are using it.

I can see you are updating hns3 driver in next patch, but what about
others, application will set this field and almost all drivers will
ignore it for now.
And in near future, some will be supporting it and some won't, still
frustrating for the application perspective.

In the past I was gathering list of these items and follow
implementation of them with drivers, but as the number of drivers
increased this became very hard to manage.

Another way to manage this is go and update all drivers, and if the
configuration requests anything other than
'RTE_ETH_HASH_FUNCTION_DEFAULT', return error. So that application can
know this is not supported by this driver.
Do you have better solution for this?


I know this may not be reasonable, how about adding new ops to
the query and configuration of the RSS algorithm?



If the value of "func" used for configuration is a gibberish
value, report the error and return. Do the same for
rte_eth_dev_rss_hash_update and rte_eth_dev_configure.

To check whether the drivers report the "func" field, it is set
to default value before querying.

Signed-off-by: Jie Hai 
Signed-off-by: Dongdong Liu 
---
  doc/guides/rel_notes/release_23_11.rst |  2 ++
  lib/ethdev/rte_ethdev.c| 17 +
  lib/ethdev/rte_ethdev.h| 21 +
  lib/ethdev/rte_flow.c  |  1 -
  lib/ethdev/rte_flow.h  | 22 ++
  5 files changed, 42 insertions(+), 21 deletions(-)

diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index 333e1d95a283..deb019fbe4c1 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -129,6 +129,8 @@ ABI Changes
 Also, make sure to start the actual text at the margin.
 ===
  
+* ethdev: Added "func" field to ``rte_eth_rss_conf`` structure for RSS hash

+  algorithm.
  
  Known Issues

  
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 0840d2b5942a..4cbcdb344cac 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1445,6 +1445,14 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t 
nb_rx_q, uint16_t nb_tx_q,
goto rollback;
}
  
+	if (dev_conf->rx_adv_conf.rss_conf.func >= RTE_ETH_HASH_FUNCTION_MAX) {

+   RTE_ETHDEV_LOG(ERR,
+   "Ethdev port_id=%u invalid rss hash function (%u)\n",
+   port_id, dev_conf->rx_adv_conf.rss_conf.func);
+   ret = -EINVAL;
+   goto rollback;
+   }
+
/* Check if Rx RSS distribution is disabled but RSS hash is enabled. */
if (((dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) == 0) &&
(dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH)) {
@@ -4630,6 +4638,13 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,
return -ENOTSUP;
}
  
+	if (rss_conf->func >= RTE_ETH_HASH_FUNCTION_MAX) {

+   RTE_ETHDEV_LOG(ERR,
+   "Ethdev port_id=%u invalid rss hash function (%u)\n",
+   port_id, rss_conf->func);
+   return -EINVAL;
+   }
+
if (*dev->dev_ops->rss_hash_update == NULL)
return -ENOTSUP;
ret = eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev,
@@ -4657,6 +4672,8 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,
return -EINVAL;
}
  
+	rss_conf->func = RTE_ETH_HASH_FUNCTION_DEFAULT;

+



I think setting this in ethdev level is not required if you update all
drivers to not accept anything other than DEFAULT.


I initialized this field to prevent some drivers from not reporting RSS 
algorithms.
If an improper parameter is transferred before an API is invoked, the 
query result will be incorrect.

if (*dev->dev_ops->rss_hash_conf_get == NULL)
return -ENOTSUP;
ret = eth_err(port_id, (*dev->dev_ops->rss_hash_conf_get)(dev,
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 40cfbb7efddd..33cec3570f85 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -445,6 +445,26 @@ struct rte_vlan_filter_conf {
uint64_t ids[64];
  };
  
+/**

+ * Hash function types.
+ */
+enum rte_eth_hash_function {
+   /**
+* DEFAULT means that conformance to a specifi

[PATCH v2 1/1] eal: update xz read support and ignore warning

[Srikanth Yalavarthi]

archive_read_support_filter_xz returns a warning when
compression is not fully supported and is supported
through external program. This warning can be ignored
when reading the files through firmware open as only
decompression is required.

Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org

Signed-off-by: Srikanth Yalavarthi 
Change-Id: I38cce556ec637af03dbde74d7d18318af48082d6
---
 lib/eal/unix/eal_firmware.c | 28 
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
index d1616b0bd9..16690b4245 100644
--- a/lib/eal/unix/eal_firmware.c
+++ b/lib/eal/unix/eal_firmware.c
@@ -25,19 +25,31 @@ static int
 firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t 
blocksize)
 {
struct archive_entry *e;
+   int err;
 
ctx->a = archive_read_new();
if (ctx->a == NULL)
return -1;
-   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
-   archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||
-   archive_read_open_filename(ctx->a, name, blocksize) != 
ARCHIVE_OK ||
-   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
-   archive_read_free(ctx->a);
-   ctx->a = NULL;
-   return -1;
-   }
+
+   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
+   goto error;
+
+   err = archive_read_support_filter_xz(ctx->a);
+   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
+   goto error;
+
+   if (archive_read_open_filename(ctx->a, name, blocksize) != ARCHIVE_OK)
+   goto error;
+
+   if (archive_read_next_header(ctx->a, &e))
+   goto error;
+
return 0;
+
+error:
+   archive_read_free(ctx->a);
+   ctx->a = NULL;
+   return -1;
 }
 
 static ssize_t
-- 
2.41.0

Re: [PATCH v13 4/4] app/testpmd: add recycle mbufs engine

[Konstantin Ananyev]

25.09.2023 04:19, Feifei Wang пишет:

Add recycle mbufs engine for testpmd. This engine forward pkts with
I/O forward mode. But enable mbufs recycle feature to recycle used
txq mbufs for rxq mbuf ring, which can bypass mempool path and save
CPU cycles.

Suggested-by: Jerin Jacob 
Signed-off-by: Feifei Wang 
Reviewed-by: Ruifeng Wang 
---



Acked-by: Konstantin Ananyev 

Re: [PATCH v13 3/4] net/ixgbe: implement mbufs recycle mode

[Konstantin Ananyev]

25.09.2023 04:19, Feifei Wang пишет:

Define specific function implementation for ixgbe driver.
Currently, recycle buffer mode can support 128bit
vector path. And can be enabled both in fast free and
no fast free mode.

Suggested-by: Honnappa Nagarahalli 
Signed-off-by: Feifei Wang 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Honnappa Nagarahalli 
---




Acked-by: Konstantin Ananyev 

RE: [EXT] Re: [PATCH 1/1] eal: enable xz read support and ignore warning

[Srikanth Yalavarthi]

> -Original Message-
> From: David Marchand 
> Sent: 25 September 2023 14:40
> To: Srikanth Yalavarthi 
> Cc: Aaron Conole ; Igor Russkikh
> ; dev@dpdk.org; Shivah Shankar Shankar Narayan
> Rao ; Anup Prabhu ;
> Prince Takkar ; jerinjac...@gmail.com;
> sta...@dpdk.org; Srikanth Yalavarthi 
> Subject: [EXT] Re: [PATCH 1/1] eal: enable xz read support and ignore
> warning
> 
> External Email
> 
> --
> Hello,
> 
> Thank you for the patch.
> 
> On Fri, Sep 22, 2023 at 6:54 PM Srikanth Yalavarthi
>  wrote:
> >
> > archive_read_support_filter_xz returns a warning when compression is
> > not fully supported and is supported through external program. This
> > warning can be ignored when reading the files through firmware open as
> > only decompression is required.
> 
> - I don't understand the last sentence, it seems to state something about
> *only* needing decompression support but well,
> archive_read_support_filter_xz (like archive_read_support_filter_* other
> helpers) *is about* decompressing a file.

What I meant is, in rte_firmware_read, we will be reading / decompressing the 
archive files.
Since support to write compressed files is required here, we can ignore the 
ARCHIVE_WARN.

> 
> 
> - I can't reproduce this ARCHIVE_WARN thing, not sure which libarchive you
> use, or which knob/build option triggered this behavior you observe.
> So I need you to to double check how this change affects the code.
> 

In our build setup, we are cross-compiling libarchive without any dependency 
libs/headers like zlib, bzip2, lzma enabled.
I guess this is causing libarchive to be built without compression support.

> Please pass a xz-compressed mldev fw .bin file and confirm it still works.

I have tested 3 cases.
(1) ml-fw.bin -> A decompressed binary file
(2) ml-fw.bin.xz -> A compressed archive created from mlip-fw.bin (1)
(3) ml-fw.bin -> mlip-fw.bin.xz (2) renamed as ml-fw.bin


> 
> 
> >
> > Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Srikanth Yalavarthi 
> > ---
> >  lib/eal/unix/eal_firmware.c | 9 -
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
> > index d1616b0bd9..05c06c222a 100644
> > --- a/lib/eal/unix/eal_firmware.c
> > +++ b/lib/eal/unix/eal_firmware.c
> > @@ -25,12 +25,19 @@ static int
> >  firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t
> > blocksize)  {
> > struct archive_entry *e;
> > +   int err;
> >
> > ctx->a = archive_read_new();
> > if (ctx->a == NULL)
> > return -1;
> > +
> > +   err = archive_read_support_filter_xz(ctx->a);
> > +   if (err != ARCHIVE_OK && err != ARCHIVE_WARN) {
> > +   ctx->a = NULL;
> > +   return -1;
> > +   }
> 
> - This patch leaks ctx->a content on error.
> 
> Plus I prefer we keep the original order of the code because it matches what
> libarchive does: first look for an archive format, then next look for
> compression matters.
> 
> The simpler is to add an error label like I did in the debug patch.
> Something like:

Submitted v2 patch with suggested changes.

> 
> diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c index
> d1616b0bd9..269688d550 100644
> --- a/lib/eal/unix/eal_firmware.c
> +++ b/lib/eal/unix/eal_firmware.c
> @@ -25,19 +25,27 @@ static int
>  firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t
> blocksize)
>  {
> struct archive_entry *e;
> +   int err;
> 
> ctx->a = archive_read_new();
> if (ctx->a == NULL)
> return -1;
> -   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
> -   archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK 
> ||
> -   archive_read_open_filename(ctx->a, name,
> blocksize) != ARCHIVE_OK ||
> -   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
> -   archive_read_free(ctx->a);
> -   ctx->a = NULL;
> -   return -1;
> -   }
> +   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
> +   goto error;
> +   err = archive_read_support_filter_xz(ctx->a);
> +   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
> +   goto error;
> +   if (archive_read_open_filename(ctx->a, name, blocksize) !=
> ARCHIVE_OK)
> +   goto error;
> +   if (archive_read_next_header(ctx->a, &e))
> +   goto error;
> +
> return 0;
> +
> +error:
> +   archive_read_free(ctx->a);
> +   ctx->a = NULL;
> +   return -1;
>  }
> 
>  static ssize_t
> 
> 
> --
> David Marchand

Re: [PATCH v13 2/4] net/i40e: implement mbufs recycle mode

[Konstantin Ananyev]

25.09.2023 04:19, Feifei Wang пишет:

Define specific function implementation for i40e driver.
Currently, mbufs recycle mode can support 128bit
vector path and avx2 path. And can be enabled both in
fast free and no fast free mode.

Suggested-by: Honnappa Nagarahalli 
Signed-off-by: Feifei Wang 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Honnappa Nagarahalli 
---



Acked-by: Konstantin Ananyev 

Re: [PATCH v1] examples/l3fwd: relax the RSS/Offload requirement

[Konstantin Ananyev]

Hi Trevor,





At 2023-09-18 02:04:19, "Konstantin Ananyev"  
wrote:

03/09/2023 05:01, Trevor Tao пишет:

Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS, and offload
mode set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hardware
and/or virtual interface does not support the RSS and offload mode
presupposed, e.g., some virtio interfaces in the cloud don't support
RSS and may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/
RTE_ETH_RX_OFFLOAD_TCP_CKSUM,
but not RTE_ETH_RX_OFFLOAD_IPV4_CKSUM, and the error msg here:

virtio_dev_configure(): RSS support requested but not supported by
the device
Port0 dev_configure = -95

and:
Ethdev port_id=0 requested Rx offloads 0xe does not match Rx offloads
capabilities 0x201d in rte_eth_dev_configure()

So to enable the l3fwd running in that environment, the Rx mode requirement
can be relaxed to reflect the hardware feature reality here, and the l3fwd
can run smoothly then.
A warning msg would be provided to user in case it happens here.

On the other side, enabling the software cksum check in case the
hw support missing.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org


I don't think there was abug here.
We are talking about changing current requirements for the app.
So not sure it is a real fix and that such change can be



propagated to stable releases.

Trevor: I think it's not a bug fix but a feature enhancement, it would enable 
l3fwd to work smoothly on the HW/virtual interfaces which don't support RSS 
and/or cksum offloading.



Yes. it seems like sort of an enhancement.
While 'Fixes: ...' are for bugs only.
AFAIK, only bug-fixes are take for backporting by stable releases.
That's why there seems no point to add CC: sta...@dpdk.org

Another generic things:

 >- l3fwd doc and release notes probably need to be updated
*Trevor>>I think it's ok to update the l3fwd doc and release notes, but 
I would like to know which part of the doc/notes is approriate to add 
the enhancement declaration. *


 think both:
http://doc.dpdk.org/guides/sample_app_ug/l3_forward.html
and elease notes in doc/guides/rel_notes/ need to be updated.


- as you areintroducing 2 distinct features: no-rss and no-ipv4-cksum
  it is probably better to split it into 2 different patches (in the 

 >same series).
*Trevor>>I think it's ok to split it into 2 patches here in the same 
series, if you would like to.*

*Thanks.*


That is not my own desire, but usual contrution practise we all try
to comply with.
You can find more details at:
https://doc.dpdk.org/guides/contributing/patches.html

Thanks
Konstantin











Signed-off-by: Trevor Tao 
---
  examples/l3fwd/l3fwd.h | 12 +++-
  examples/l3fwd/main.c  | 21 +++--
  2 files changed, 30 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h
index b55855c932..cc10643c4b 100644
--- a/examples/l3fwd/l3fwd.h
+++ b/examples/l3fwd/l3fwd.h
@@ -115,6 +115,8 @@ extern struct acl_algorithms acl_alg[];
  
  extern uint32_t max_pkt_len;
  
+extern struct rte_eth_conf port_conf;

+
  /* Send burst of packets on an output interface */
  static inline int
  send_burst(struct lcore_conf *qconf, uint16_t n, uint16_t port)
@@ -170,7 +172,15 @@ is_valid_ipv4_pkt(struct rte_ipv4_hdr *pkt, uint32_t 
link_len)
return -1;
  
  	/* 2. The IP checksum must be correct. */

-   /* this is checked in H/W */
+   /* if this is not checked in H/W, check it. */
+   if ((port_conf.rxmode.offloads & RTE_ETH_RX_OFFLOAD_IPV4_CKSUM) == 0) {


Might be better to check particular mbuf flag:
if ((mbuf->ol_flags & RTE_MBUF_F_RX_IP_CKSUM_MASK) == 



TE_MBUF_F_RX_IP_CKSUM_UNKNOWN) {...}

Trevor: the utility function is_valid_ipv4_pkt is just against an IPv4 pkt, and 
there's no mbuf information, and if needed, there would be an extra ol_flags 
added here to check if it was already done by the ethernet device, but look for 
a sample in:
https://github.com/DPDK/dpdk/blob/main/examples/l3fwd-power/main.c#L487
so I think it's ok to just use the port_conf here. If you still think it's better 
to use m->ol_flags, please tell me.



Yep, passing ol_flags, or mbuf itself seems like a proper way to do it.
Aproach taken in l3fwd-power doesn't look right to me, see below.




+   uint16_t actual_cksum, expected_cksum;
+   actual_cksum = pkt->hdr_checksum;
+   pkt->hdr_checksum = 0;
+   expected_cksum = rte_ipv4_cksum(pkt);
+   if (actual_cksum != expected_cksum)
+   return -2;
+   }
  
  	/*

 * 3. The IP version number must be 4. If the version number is not 4
diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
index 6063eb1399..37aec64718 100644
--- a/examples/l3fwd/main.c
+++ b/examples/l3fwd/main.c
@@ -117,7 +117,7 @@ static struct lcore_params * lcore_params = 
lcore_params_array_default;
  static uint16_t nb_lcore_params = sizeof(lcore_params_array_default) /
   

[PATCH v3 1/1] eal: update xz read support and ignore warning

[Srikanth Yalavarthi]

archive_read_support_filter_xz returns a warning when
compression is not fully supported and is supported
through external program. This warning can be ignored
when reading the files through firmware open as only
decompression is required.

Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org

Signed-off-by: Srikanth Yalavarthi 
---
v3:
* removed gerrit change-id

v2: 
* updated code as per review comments


 lib/eal/unix/eal_firmware.c | 28 
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
index d1616b0bd9..16690b4245 100644
--- a/lib/eal/unix/eal_firmware.c
+++ b/lib/eal/unix/eal_firmware.c
@@ -25,19 +25,31 @@ static int
 firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t 
blocksize)
 {
struct archive_entry *e;
+   int err;
 
ctx->a = archive_read_new();
if (ctx->a == NULL)
return -1;
-   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
-   archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||
-   archive_read_open_filename(ctx->a, name, blocksize) != 
ARCHIVE_OK ||
-   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
-   archive_read_free(ctx->a);
-   ctx->a = NULL;
-   return -1;
-   }
+
+   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
+   goto error;
+
+   err = archive_read_support_filter_xz(ctx->a);
+   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
+   goto error;
+
+   if (archive_read_open_filename(ctx->a, name, blocksize) != ARCHIVE_OK)
+   goto error;
+
+   if (archive_read_next_header(ctx->a, &e))
+   goto error;
+
return 0;
+
+error:
+   archive_read_free(ctx->a);
+   ctx->a = NULL;
+   return -1;
 }
 
 static ssize_t
-- 
2.41.0

Re: [PATCH v2 1/1] eal: update xz read support and ignore warning

[David Marchand]

On Tue, Sep 26, 2023 at 3:30 PM Srikanth Yalavarthi
 wrote:
>
> archive_read_support_filter_xz returns a warning when
> compression is not fully supported and is supported
> through external program. This warning can be ignored
> when reading the files through firmware open as only
> decompression is required.

Same comment as before, this sentence is confusing.
Compressing files does not matter in DPDK rte_firmware_ API.

The commit title and commitlog won't help people understand in which
case the issue is reproduced, and how this patch fixes it.

Suggesting the following title and commitlog:

"""
eal/unix: fix firmware reading with external xz support

libarchive may support xz decompression only through an external
(slower) helper.
In such a case, archive_read_support_filter_xz() returns ARCHIVE_WARN.

Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org
"""

>
> Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Srikanth Yalavarthi 
> Change-Id: I38cce556ec637af03dbde74d7d18318af48082d6

This is internal scm stuff and must be dropped.

> ---
>  lib/eal/unix/eal_firmware.c | 28 
>  1 file changed, 20 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
> index d1616b0bd9..16690b4245 100644
> --- a/lib/eal/unix/eal_firmware.c
> +++ b/lib/eal/unix/eal_firmware.c
> @@ -25,19 +25,31 @@ static int
>  firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t 
> blocksize)
>  {
> struct archive_entry *e;
> +   int err;
>
> ctx->a = archive_read_new();
> if (ctx->a == NULL)
> return -1;
> -   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
> -   archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK 
> ||
> -   archive_read_open_filename(ctx->a, name, blocksize) 
> != ARCHIVE_OK ||
> -   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
> -   archive_read_free(ctx->a);
> -   ctx->a = NULL;
> -   return -1;
> -   }
> +
> +   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
> +   goto error;
> +
> +   err = archive_read_support_filter_xz(ctx->a);
> +   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
> +   goto error;
> +
> +   if (archive_read_open_filename(ctx->a, name, blocksize) != ARCHIVE_OK)
> +   goto error;
> +
> +   if (archive_read_next_header(ctx->a, &e))

I did a typo when quickly writting the snippet previously.
It should be "archive_read_next_header(ctx->a, &e) != ARCHIVE_OK"


> +   goto error;
> +
> return 0;
> +
> +error:
> +   archive_read_free(ctx->a);
> +   ctx->a = NULL;
> +   return -1;
>  }
>
>  static ssize_t
> --
> 2.41.0
>


-- 
David Marchand

Re: [PATCH 00/36] fix Rx and Tx queue state

[Jie Hai]

On 2023/9/22 14:41, David Marchand wrote:

Hello,

On Fri, Sep 22, 2023 at 4:41 AM Jie Hai  wrote:

On 2023/9/19 0:54, Ferruh Yigit wrote:

On 9/8/2023 12:50 PM, David Marchand wrote:

On Fri, Sep 8, 2023 at 1:32 PM Jie Hai  wrote:


The DPDK framework reports the queue state, which is stored in
dev->data->tx_queue_state and dev->data->rx_queue_state. The
state is maintained by the driver. Users may determine whether
a queue participates in packet forwarding based on the state,
for example,


The driver is maintaining this state in dev_start / dev_stop and per
queue start/stop handlers.



[1] 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding"
[2] 141a520b35f7 ("app/testpmd: fix primary process not polling all queues")

Therefore, the drivers need to modify the queue state in time
according to the actual situation, especially when dev_start
and dev_stop are called. see [3] for more information.

[3] https://inbox.dpdk.org/dev/20230721160422.3848154-1-ferruh.yi...@amd.com/

This patchset also resubmit the patch [2] and makes some fixes on the patch.


I just had a quick look at some patches and I wonder if a better fix
would be at the ethdev level, rather than fixing all drivers.




I came here to make the same comment,

Jie, I forgot if we discuss this already but,

does it work if we update queue state in 'rte_eth_dev_start()' &
'rte_eth_dev_stop()' when 'dev_start' & 'dev_stop' dev_ops succeeds?

This solves the case driver forgets to update the queue state.



Hi, Furrh and David,

It's OK for dev_stop, but not enough for dev_start.
Some drivers also support deferred_start.
Therefore, not all queues are in the start state after dev_start.

If we want to get that correct queue state at the framework level, I
offer the following options:

step 1. A capability(e.g. RTE_ETH_DEV_CAPA_DEFERRED_START) is added to
the framework, indicating whether the driver supports deferred_start.
The capability should be reported by the driver and user can get it by
rte_eth_dev_info_get().
step 2. All drivers that support deferred_start should report configuration
information about deferred_start through
rte_eth_rx_queue_info_get |rte_eth_tx_queue_info_get.
step 3.The framework updates the queue status based on the support and
configuration of deferred_start.


rte_eth_dev_start must only update the queue state if
rx_deferred_start is unset (see struct
rte_eth_rxconf::rx_deferred_start).
And the queue state needs to be updated in ethdev
rte_eth_dev_rx_queue_start/stop.

So I don't see where we need a new capability.


Hi, David,

Thanks and you are right.
The driver reports whether the queue is configured with deferred_start 
through rxq_info_get & rxq_info_get ops.
The framework can obtain queue configuration through 
rte_eth_rx_queue_info_get & rte_eth_tx_queue_info_get.
According to your suggestion, the prerequisite is that all drivers that 
support deferred_start support

rxq_info_get & rxq_info_get ops reporting it.
Currently, not all drivers support reporting  the deferred_start 
configuration. Therefore, we need to modify some driver.

I'll send V2 after finishing.

Best, regards
Jie Hai

Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset

[Bruce Richardson]

On Tue, Sep 26, 2023 at 01:15:28PM +0100, Zhang, Qi Z wrote:
> 
> 
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Tuesday, September 26, 2023 3:49 PM
> > To: He, ShiyangX 
> > Cc: dev@dpdk.org; Zhou, YidingX ; Wang, Liang-
> > min ; Su, Simei ; Wu,
> > Wenjun1 ; Zhang, Yuying
> > ; Xing, Beilei ; Yang,
> > Qiming ; Wu, Jingjing 
> > Subject: Re: [PATCH v3] net/iavf: add devargs to enable vf auto-reset
> > 
> > On Fri, Sep 15, 2023 at 01:02:49PM +, Shiyang He wrote:
> > > Originally, the iavf PMD does not perform special actions when it
> > > receives a PF-to-VF reset event, resulting in vf being offline and
> > > unavailable.
> > >
> > > This patch enables vf auto-reset by setting 'watchdog_period' devargs
> > > to true. The iavf PMD will perform an automatic reset to bring the vf
> > > back online when it receives a PF-to-VF event.
> > >
> > > v2: handling reset by event handler
> > > v3: change reset process
> > >
> > > Signed-off-by: Shiyang He 
> > > Signed-off-by: Liang-Min Larry Wang 
> > > ---
> > >  doc/guides/nics/intel_vf.rst   |  3 +
> > >  doc/guides/rel_notes/release_23_11.rst |  3 +
> > >  drivers/net/iavf/iavf.h|  7 +++
> > >  drivers/net/iavf/iavf_ethdev.c | 86 +++---
> > >  drivers/net/iavf/iavf_rxtx.c   | 52 ++--
> > >  drivers/net/iavf/iavf_vchnl.c  | 11 +++-
> > >  6 files changed, 135 insertions(+), 27 deletions(-)
> > >
> > > diff --git a/doc/guides/nics/intel_vf.rst
> > > b/doc/guides/nics/intel_vf.rst index d365dbc185..c0acd2a7f5 100644
> > > --- a/doc/guides/nics/intel_vf.rst
> > > +++ b/doc/guides/nics/intel_vf.rst
> > > @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the
> > following documents:
> > >  Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog
> > period in microseconds, or set it to 0 to disable the watchdog,
> > >  for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a
> > 18:01.0,watchdog_period=0``.
> > >
> > > +Enable vf auto-reset by setting the ``devargs`` parameter like ``-a
> > 18:01.0,enable_auto_reset=1`` when IAVF is backed
> > > +by an Intel(r) E810 device or an Intel(r) 700 Series Ethernet device.
> > > +
> > 
> > Why do we need a devargs for this? If the VF is unavailable - as you mention
> > in the commit log above - should this behaviour not always be the case
> > without the user having to ask?
> 
> Ideally it does not need, but with below considerations:
> 
> 1. Not break existing scenario, which still assume some application will call 
> dev_reset /dev_configure/ queue_setup / ...  after receive 
> RTE_ETH_EVENT_INTR_RESET event to recover the VF manually, the devargs make 
> sure application be aware of this new feature and will not call 
> rte_eth_dev_reset which will fail now.
> 
> 2. intent to ensure a smoother transition, in case some corner case issues 
> evaded our validation, keeping this devargs provides us with the flexibility 
> to remove it once we determine that the implementation is stable enough.  
> 
Thanks for the clear explanation.

One small suggestion: in the commit log, at the end of the first paragraph
change "resulting in the VF being offline and unavailable" to "... offline
and unavailable until the application resets the device on receipt of the
RTE_ETH_EVENT_INTR_RESET event". Similarly at the end of the second
paragraph you could add "This change removes the need for the application
to handle the reset event, as it is transparently handled inside the
driver".

Regards,
/Bruce

RE: [PATCH v2 00/15] fixes and improvements to cnxk crypto PMD

[Akhil Goyal]

> Subject: [PATCH v2 00/15] fixes and improvements to cnxk crypto PMD
> 
> This series adds improvements and support for raw
> cryptodev API in cnxk crypto PMD.
> 
> v2:
> * Updated feature file for cn10k
> * Updated commit message
> 
> Aakash Sasidharan (1):
>   crypto/cnxk: add support for packets with cipher len zero
> 
> Anoob Joseph (4):
>   crypto/cnxk: clear rptr and dptr fields
>   common/cnxk: set cipher key only for non-null cipher
>   crypto/cnxk: add support for raw APIs
>   test/crypto: enable raw crypto tests for crypto_cn10k
> 
> Gowrishankar Muthukrishnan (1):
>   crypto/cnxk: update private key length in ECDSA param
> 
> Tejasree Kondoj (4):
>   crypto/cnxk: fix IPsec CCM and GCM capabilities
>   crypto/cnxk: remove pdcp chain bit from capabilities
>   crypto/cnxk: make IV pointers as constant
>   crypto/cnxk: set PDCP chain IV offset based on FVC
> 
> Vidya Sagar Velumuri (5):
>   common/cnxk: update SE context fields to match ucode spec
>   crypto/cnxk: check for sg version in SE engine capabilities
>   crypto/cnxk: fix control flow issues
>   crypto/cnxk: minor shuffling in the sess structure
>   crypto/cnxk: update the iv from proper param for gmac
> 
>  app/test/test_cryptodev.c |   8 +
>  doc/guides/cryptodevs/features/cn10k.ini  |   1 +
>  drivers/common/cnxk/hw/cpt.h  |   7 +-
>  drivers/common/cnxk/roc_se.c  |  11 +-
>  drivers/common/cnxk/roc_se.h  |  15 +-
>  drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 461 +++
>  drivers/crypto/cnxk/cnxk_ae.h |   4 +-
>  drivers/crypto/cnxk/cnxk_cryptodev.c  |  20 +-
>  .../crypto/cnxk/cnxk_cryptodev_capabilities.c |  10 +-
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  13 +-
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.h  |   6 +-
>  drivers/crypto/cnxk/cnxk_se.h | 527 ++
>  12 files changed, 937 insertions(+), 146 deletions(-)
> 
Series applied to dpdk-next-crypto

Updated title and description of some of the patches. Please review.

Thanks.

[PATCH v4 1/1] eal/unix: fix firmware reading with external xz helper

[Srikanth Yalavarthi]

libarchive may support xz decompression only through an
external (slower) helper.

In such a case, archive_read_support_filter_xz() returns
ARCHIVE_WARN.

Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org

Signed-off-by: Srikanth Yalavarthi 
---
v4:
* updated commit message
* fixed checking archive_read_next_header

v3:
* removed gerrit change-id

v2: 
* updated code as per review comments

 lib/eal/unix/eal_firmware.c | 28 
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
index d1616b0bd9..1a7cf8e7b7 100644
--- a/lib/eal/unix/eal_firmware.c
+++ b/lib/eal/unix/eal_firmware.c
@@ -25,19 +25,31 @@ static int
 firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t 
blocksize)
 {
struct archive_entry *e;
+   int err;
 
ctx->a = archive_read_new();
if (ctx->a == NULL)
return -1;
-   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
-   archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||
-   archive_read_open_filename(ctx->a, name, blocksize) != 
ARCHIVE_OK ||
-   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
-   archive_read_free(ctx->a);
-   ctx->a = NULL;
-   return -1;
-   }
+
+   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
+   goto error;
+
+   err = archive_read_support_filter_xz(ctx->a);
+   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
+   goto error;
+
+   if (archive_read_open_filename(ctx->a, name, blocksize) != ARCHIVE_OK)
+   goto error;
+
+   if (archive_read_next_header(ctx->a, &e) != ARCHIVE_OK)
+   goto error;
+
return 0;
+
+error:
+   archive_read_free(ctx->a);
+   ctx->a = NULL;
+   return -1;
 }
 
 static ssize_t
-- 
2.41.0

RE: [EXT] Re: [PATCH v2 1/1] eal: update xz read support and ignore warning

[Srikanth Yalavarthi]

> -Original Message-
> From: David Marchand 
> Sent: 26 September 2023 19:27
> To: Srikanth Yalavarthi 
> Cc: Aaron Conole ; Igor Russkikh
> ; dev@dpdk.org; Shivah Shankar Shankar Narayan
> Rao ; Anup Prabhu ;
> Prince Takkar ; jerinjac...@gmail.com;
> sta...@dpdk.org
> Subject: [EXT] Re: [PATCH v2 1/1] eal: update xz read support and ignore
> warning
> 
> External Email
> 
> --
> On Tue, Sep 26, 2023 at 3:30 PM Srikanth Yalavarthi
>  wrote:
> >
> > archive_read_support_filter_xz returns a warning when compression is
> > not fully supported and is supported through external program. This
> > warning can be ignored when reading the files through firmware open as
> > only decompression is required.
> 
> Same comment as before, this sentence is confusing.
> Compressing files does not matter in DPDK rte_firmware_ API.
> 
> The commit title and commitlog won't help people understand in which case
> the issue is reproduced, and how this patch fixes it.
> 
> Suggesting the following title and commitlog:
> 
> """
> eal/unix: fix firmware reading with external xz support
> 
> libarchive may support xz decompression only through an external
> (slower) helper.
> In such a case, archive_read_support_filter_xz() returns ARCHIVE_WARN.
> 
> Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> Cc: sta...@dpdk.org
> """
> 
> >
> > Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Srikanth Yalavarthi 
> > Change-Id: I38cce556ec637af03dbde74d7d18318af48082d6
> 
> This is internal scm stuff and must be dropped.
> 
> > ---
> >  lib/eal/unix/eal_firmware.c | 28 
> >  1 file changed, 20 insertions(+), 8 deletions(-)
> >
> > diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
> > index d1616b0bd9..16690b4245 100644
> > --- a/lib/eal/unix/eal_firmware.c
> > +++ b/lib/eal/unix/eal_firmware.c
> > @@ -25,19 +25,31 @@ static int
> >  firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t
> > blocksize)  {
> > struct archive_entry *e;
> > +   int err;
> >
> > ctx->a = archive_read_new();
> > if (ctx->a == NULL)
> > return -1;
> > -   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
> > -   archive_read_support_filter_xz(ctx->a) != 
> > ARCHIVE_OK ||
> > -   archive_read_open_filename(ctx->a, name, blocksize) 
> > !=
> ARCHIVE_OK ||
> > -   archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) 
> > {
> > -   archive_read_free(ctx->a);
> > -   ctx->a = NULL;
> > -   return -1;
> > -   }
> > +
> > +   if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK)
> > +   goto error;
> > +
> > +   err = archive_read_support_filter_xz(ctx->a);
> > +   if (err != ARCHIVE_OK && err != ARCHIVE_WARN)
> > +   goto error;
> > +
> > +   if (archive_read_open_filename(ctx->a, name, blocksize) !=
> ARCHIVE_OK)
> > +   goto error;
> > +
> > +   if (archive_read_next_header(ctx->a, &e))
> 
> I did a typo when quickly writting the snippet previously.
> It should be "archive_read_next_header(ctx->a, &e) != ARCHIVE_OK"
> 
> 
> > +   goto error;
> > +
> > return 0;
> > +
> > +error:
> > +   archive_read_free(ctx->a);
> > +   ctx->a = NULL;
> > +   return -1;
> >  }
> >
> >  static ssize_t
> > --
> > 2.41.0
> >
> 

Submitted patch version 4 with suggested changes.

> 
> --
> David Marchand

Re: [PATCH 0/2] add checks for tests not in a suite

[Aaron Conole]

David Marchand  writes:

> On Tue, Sep 19, 2023 at 10:36 AM Bruce Richardson
>  wrote:
>>
>> On Tue, Sep 19, 2023 at 10:29:07AM +0200, David Marchand wrote:
>> > On Fri, Sep 15, 2023 at 1:52 PM Bruce Richardson
>> >  wrote:
>> > >
>> > > To help ensure that we don't have "orphaned" tests not in any test
>> > > suites we can add the following checks:
>> > >
>> > > * In developer-mode builds, emit a warning for each test defined using
>> > >   REGISTER_TEST_COMMAND
>> > > * In checkpatches, add a check to prevent the addition of new tests
>> > >   using the REGISTER_TEST_COMMAND macro
>> > >
>> > > Bruce Richardson (2):
>> > >   app/test: emit warning for tests not in a test suite
>> > >   devtools: check for tests added without a test suite
>> > >
>> > >  app/test/suites/meson.build   | 13 -
>> > >  buildtools/get-test-suites.py | 12 +---
>> > >  devtools/checkpatches.sh  |  8 
>> > >  3 files changed, 29 insertions(+), 4 deletions(-)
>> >
>> > The "non_suite_tests" testsuite returned by
>> > buildtools/get-test-suites.py is a bit strange, as it is not a
>> > testsuite from meson pov.
>>
>> Yeah, it is a bit strange, and I'm open to new ideas on other solutions. I
>> did it that way to avoid having yet another script to scan the files - I
>> figured it was faster (in terms of runtime, not dev time) to do the
>
> I had figured it was "faster dev time" that won :-).
> I am fine with it, I don't expect more complications in this area in the 
> future.
>
>
>> scanning when the files are already being opened and processed by this one.
>>
>> Of course, if we can get the un-suitened [:-)] test cases down to zero, we
>> can theoretically drop this check in future, and  just use the checkpatch
>> one.
>
> Well, that's still a question that nobody seems to comment on.
>
> What should we do with tests that don't enter one of those testsuites,
> and are not invoked by the CI?
>
> Though we may be removing some level of coverage, I am for
> cleaning/unused dead code.

I guess it does require actually looking at these tests and classifying
them to either put them into the proper suites.  As of now, we aren't
really removing coverage if they aren't being run - but are any
maintainers or developers actually running them?

Re: DPDK patch

[Aaron Conole]

John Romein  writes:

> Dear Elena, Aaron,

Hi John,

> I hope you had a nice time after the DPDK workshop.
>
> I was unable to solve the issues with our mailserver to submit a patch
> with git sendmail.  So I created a pull request:
> https://github.com/DPDK/dpdk/pull/69
> @Elena, could you please handle the pull request?  I will submit
> another pull request for the mempool_get_extmem optimization shortly.

Okay - we typically don't use pull requests.  If you and others are are
okay, I can take the patches and repost them to the ML from the pull
requests with a note indicating such.

> Thanks,  John

Re: [PATCH 0/1] make file prefix unit test more resilient

[Aaron Conole]

Bruce Richardson  writes:

> On Sat, Sep 23, 2023 at 10:21:04AM +0200, Thomas Monjalon wrote:
>> 22/09/2023 15:23, Bruce Richardson:
>> > On Fri, Sep 22, 2023 at 02:57:32PM +0200, Thomas Monjalon wrote:
>> > > 20/09/2023 12:09, Bruce Richardson:
>> > > > On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote:
>> > > > > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson
>> > > > >  wrote:
>> > > > > >
>> > > > > > When examining the IOL testing failures for patch series [1], I 
>> > > > > > observed
>> > > > > > that the failures reported were in the eal_flags_file_prefix unit 
>> > > > > > test.
>> > > > > > I was able to reproduce this on my system by passing an additional
>> > > > > > "--on-pci" flag to the test run, since the log to the test has 
>> > > > > > errors
>> > > > > > about device availability. Adding the "no-pci" flag to the 
>> > > > > > individual
>> > > > > 
>> > > > > Something is not clear to me.
>> > > > > 
>> > > > > While I understand that passing "no-pci" helps avoiding the issue (as
>> > > > > described below), I have some trouble understanding this passage
>> > > > > (above) with "--on-pci".
>> > > > 
>> > > > That's a typo for no-pci. When I ran the test on my system with the 
>> > > > main
>> > > > process using no-pci, I was able to reproduce the issue seen in the IOL
>> > > > lab. Otherwise I couldn't reproduce it.
>> > > > 
>> > > > > How did you reproduce the issue?
>> > > > > 
>> > > > > 
>> > > > > > test commands used by the unit tests fixed the issue thereafter,
>> > > > > > allowing the test to pass in all cases for me. Therefore, I am
>> > > > > > submitting this patch in the hopes of making the test more robust, 
>> > > > > > since
>> > > > > > the observed failures seem unrelated to the original patchset [1] I
>> > > > > > submitted.
>> > > > > >
>> > > > > > [1] http://patches.dpdk.org/project/dpdk/list/?series=29406
>> > > > > >
>> > > > > > Bruce Richardson (1):
>> > > > > >   app/test: skip PCI bus scan when testing prefix flags
>> > > > > >
>> > > > > >  app/test/test_eal_flags.c | 20 ++--
>> > > > > >  1 file changed, 10 insertions(+), 10 deletions(-)
>> > > > > 
>> > > > > Iiuc, the problem is that the file_prefix unit test can fail if any
>> > > > > DPDK subsystem forgets to release some memory and some hugepages are
>> > > > > left behind at the cleanup step.
>> > > > > Passing --no-pci as you suggest hides issues coming from PCI drivers.
>> > > > > 
>> > > > > This is something I tried to fix too, with
>> > > > > https://patchwork.dpdk.org/project/dpdk/list/?series=29288 though my
>> > > > > fix only handles a part of the issue (here, the ethdev drivers).
>> > > > > 
>> > > > > Another way to make the file prefix more robust would be to remove 
>> > > > > the
>> > > > > check on released memory, or move it to another test.
>> > > > > 
>> > > > I actually think the test is a good one to have. Also, taking in your 
>> > > > patch
>> > > > to help with the issue is a good idea also.
>> > > > 
>> > > > I'd still suggest that this patch be considered anyway, as there is no 
>> > > > need
>> > > > to do PCI bus scanning as part of this test. Therefore I'd view it as a
>> > > > harmless addition that may help things.
>> > > 
>> > > I'm hesitating.
>> > > This test is checking if some memory is left, and I think it is sane.
>> > > If we add --no-pci, we reduce the coverage of this check.
>> > > 
>> > > Now that the root cause is fixed by David in ethdev
>> > > (https://patches.dpdk.org/project/dpdk/patch/20230821085806.3062613-4-david.march...@redhat.com/)
>> > > we could continue checking memory freeing with PCI drivers.
>> > > So I tend to reject this patch.
>> > > 
>> > > Other opinions?
>> > > 
>> > No objection to this patch being rejected if not necessary.
>> > 
>> > However, I'd question if the normal case is actually checking for freeing
>> > memory in PCI drivers. I suspect that in EAL cleanup we delete all files we
>> > use, irrespective of whether the mappings are still in use. Then when the
>> > process exits the hugepages will be completely freed back - even if some
>> > components leaked memory. I believe this case is checking for correct EAL
>> > cleanup of hugepage files, not for any memory leaks, and in that regard
>> > omitting some components should make no difference.
>> 
>> You're right, that's why I'm hesitating.
>> Fortunately it helped to discover a memory leak.
>> Do we want to add a new specific test for memory leaks,
>> or is it OK to have it in this one?
>> 
>
> Not really sure. I'd tend towards saying that special memory leak checkers
> like valgrind are better to use than trying to detect them in unit tests
> directly. However, not an expert in this area.

I do tend to agree that we should rely on more generic memory infra like
valgrind.  However, the way we use mempools doesn't always lend itself
to leak checkers like valgrind which usually expect to own all the
individual blocks.  Maybe newer versions can work

Re: [PATCH] testpmd: unregister event callback

[Singh, Aman Deep]

On 9/15/2023 9:56 AM, ok...@kernel.org wrote:

From: Sinan Kaya 


Header format doesn't requires to add "From: "
as author "Signed-off" is already present.



Cleanup event registry during shutdown to prevent memory
leaks.

Signed-off-by: Sinan Kaya 


Acked-by: Aman Singh 


---
  app/test-pmd/testpmd.c | 27 +++
  1 file changed, 27 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index c6ad9b18bf..1de7b7cd51 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -4009,6 +4009,28 @@ register_eth_event_callback(void)
return 0;
  }
  
+static int

+unregister_eth_event_callback(void)
+{
+   int ret;
+   enum rte_eth_event_type event;
+
+   for (event = RTE_ETH_EVENT_UNKNOWN;
+   event < RTE_ETH_EVENT_MAX; event++) {
+   ret = rte_eth_dev_callback_unregister(RTE_ETH_ALL,
+   event,
+   eth_event_callback,
+   NULL);
+   if (ret != 0) {
+   TESTPMD_LOG(ERR, "Failed to unregister callback for "
+   "%s event\n", eth_event_desc[event]);
+   return -1;
+   }
+   }
+
+   return 0;
+}
+
  /* This function is used by the interrupt thread */
  static void
  dev_event_callback(const char *device_name, enum rte_dev_event_type type,
@@ -4737,6 +4759,11 @@ main(int argc, char** argv)
rte_latencystats_uninit();
  #endif
  
+	ret = unregister_eth_event_callback();

+   if (ret != 0)
+   rte_exit(EXIT_FAILURE, "Cannot unregister for ethdev events");
+
+
ret = rte_eal_cleanup();
if (ret != 0)
rte_exit(EXIT_FAILURE,

[PATCH] net/mlx5: supporting group set miss actions API

[Tomer Shmilovich]

Add implementation for rte_flow_group_set_miss_actions() API.

Signed-off-by: Tomer Shmilovich 
---
Depends-on: series-29572 ("ethdev: add group set miss actions API")
Depends-on: patch-130772 ("net/mlx5: fix jump ipool entry size")
Depends-on: patch-131567 ("net/mlx5/hws: supporting default miss table in HWS")

 drivers/net/mlx5/mlx5.h |   2 +
 drivers/net/mlx5/mlx5_flow.c|  41 +
 drivers/net/mlx5/mlx5_flow.h|   9 +
 drivers/net/mlx5/mlx5_flow_hw.c | 301 
 4 files changed, 353 insertions(+)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index c587e13c63..1323bb4165 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -1848,6 +1848,8 @@ struct mlx5_priv {
struct mlx5_hw_q *hw_q;
/* HW steering rte flow table list header. */
LIST_HEAD(flow_hw_tbl, rte_flow_template_table) flow_hw_tbl;
+   /* HW steering rte flow group list header */
+   LIST_HEAD(flow_hw_grp, mlx5_flow_group) flow_hw_grp;
struct mlx5dr_action *hw_push_vlan[MLX5DR_TABLE_TYPE_MAX];
struct mlx5dr_action *hw_pop_vlan[MLX5DR_TABLE_TYPE_MAX];
struct mlx5dr_action **hw_vport;
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f7f8f54eb4..2204fa05d2 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1027,6 +1027,12 @@ static int
 mlx5_flow_table_destroy(struct rte_eth_dev *dev,
struct rte_flow_template_table *table,
struct rte_flow_error *error);
+static int
+mlx5_flow_group_set_miss_actions(struct rte_eth_dev *dev,
+uint32_t group_id,
+const struct rte_flow_group_attr *attr,
+const struct rte_flow_action actions[],
+struct rte_flow_error *error);
 static struct rte_flow *
 mlx5_flow_async_flow_create(struct rte_eth_dev *dev,
uint32_t queue,
@@ -1151,6 +1157,7 @@ static const struct rte_flow_ops mlx5_flow_ops = {
.actions_template_destroy = mlx5_flow_actions_template_destroy,
.template_table_create = mlx5_flow_table_create,
.template_table_destroy = mlx5_flow_table_destroy,
+   .group_set_miss_actions = mlx5_flow_group_set_miss_actions,
.async_create = mlx5_flow_async_flow_create,
.async_create_by_index = mlx5_flow_async_flow_create_by_index,
.async_destroy = mlx5_flow_async_flow_destroy,
@@ -9286,6 +9293,40 @@ mlx5_flow_table_destroy(struct rte_eth_dev *dev,
return fops->template_table_destroy(dev, table, error);
 }

+/**
+ * PMD group set miss actions.
+ *
+ * @param[in] dev
+ *   Pointer to the rte_eth_dev structure.
+ * @param[in] attr
+ *   Pointer to group attributes
+ * @param[in] actions
+ *   Array of actions
+ * @param[out] error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_group_set_miss_actions(struct rte_eth_dev *dev,
+uint32_t group_id,
+const struct rte_flow_group_attr *attr,
+const struct rte_flow_action actions[],
+struct rte_flow_error *error)
+{
+   const struct mlx5_flow_driver_ops *fops;
+   struct rte_flow_attr fattr = {0};
+
+   if (flow_get_drv_type(dev, &fattr) != MLX5_FLOW_TYPE_HW)
+   return rte_flow_error_set(error, ENOTSUP,
+   RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+   NULL,
+   "group set miss actions with incorrect steering 
mode");
+   fops = flow_get_drv_ops(MLX5_FLOW_TYPE_HW);
+   return fops->group_set_miss_actions(dev, group_id, attr, actions, 
error);
+}
+
 /**
  * Enqueue flow creation.
  *
diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 3a97975d69..5963474e10 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -1369,9 +1369,11 @@ struct mlx5_hw_action_template {
 /* mlx5 flow group struct. */
 struct mlx5_flow_group {
struct mlx5_list_entry entry;
+   LIST_ENTRY(mlx5_flow_group) next;
struct rte_eth_dev *dev; /* Reference to corresponding device. */
struct mlx5dr_table *tbl; /* HWS table object. */
struct mlx5_hw_jump_action jump; /* Jump action. */
+   struct mlx5_flow_group *miss_group; /* Group pointed to by miss action. 
*/
enum mlx5dr_table_type type; /* Table type. */
uint32_t group_id; /* Group id. */
uint32_t idx; /* Group memory index. */
@@ -1872,6 +1874,12 @@ typedef int (*mlx5_flow_table_destroy_t)
(struct rte_eth_dev *dev,
 struct rte_flow_template_table *table,
 struct rte_flow_error *error);
+typedef int (*ml

[RFC PATCH] usertools: add telemetry exporter

[Robin Jarry]

For now the telemetry socket is local to the machine running a DPDK
application. Also, there is no official "schema" for the exposed
metrics. Add a framework and a script to collect and expose these
metrics to telemetry and observability agree gators such as Prometheus,
Carbon or Influxdb. The exposed data must be done with end-users in
mind, some DPDK terminology or internals may not make sense to everyone.

The script only serves as an entry point and does not know anything
about any specific metrics nor JSON data structures exposed in the
telemetry socket.

It uses dynamically loaded endpoint exporters which are basic python
files that must implement two functions:

 def info() -> dict[MetricName, MetricInfo]:
 Mapping of metric names to their description and type.

 def metrics(sock: TelemetrySocket) -> list[MetricValue]:
 Request data from sock and return it as metric values. A metric
 value is a 3-tuple: (name: str, value: any, labels: dict). Each
 name must be present in info().

The sock argument passed to metrics() has a single method:

 def cmd(self, uri: str, arg: any = None) -> dict | list:
 Request JSON data to the telemetry socket and parse it to python
 values.

The main script invokes endpoints and exports the data into an output
format. For now, only two formats are implemented:

* openmetrics/prometheus: text based format exported via a local HTTP
  server.
* carbon/graphite: binary (python pickle) format exported to a distant
  carbon TCP server.

As a starting point, 3 built-in endpoints are implemented:

* counters: ethdev hardware counters
* cpu: lcore usage
* memory: overall memory usage

The goal is to keep all built-in endpoints in the DPDK repository so
that they can be updated along with the telemetry JSON data structures.

Example output for the openmetrics:// format:

 ~# dpdk-telemetry-exporter.py -o openmetrics://:9876 &
 INFO using endpoint: counters (from .../telemetry-endpoints/counters.py)
 INFO using endpoint: cpu (from .../telemetry-endpoints/cpu.py)
 INFO using endpoint: memory (from .../telemetry-endpoints/memory.py)
 INFO listening on port 9876
 [1] 838829

 ~$ curl http://127.0.0.1:9876/
 # HELP dpdk_cpu_total_cycles Total number of CPU cycles.
 # TYPE dpdk_cpu_total_cycles counter
 # HELP dpdk_cpu_busy_cycles Number of busy CPU cycles.
 # TYPE dpdk_cpu_busy_cycles counter
 dpdk_cpu_total_cycles{cpu="73", numa="0"} 4353385274702980
 dpdk_cpu_busy_cycles{cpu="73", numa="0"} 6215932860
 dpdk_cpu_total_cycles{cpu="9", numa="0"} 4353385274745740
 dpdk_cpu_busy_cycles{cpu="9", numa="0"} 6215932860
 dpdk_cpu_total_cycles{cpu="8", numa="0"} 4353383451895540
 dpdk_cpu_busy_cycles{cpu="8", numa="0"} 6171923160
 dpdk_cpu_total_cycles{cpu="72", numa="0"} 4353385274817320
 dpdk_cpu_busy_cycles{cpu="72", numa="0"} 6215932860
 # HELP dpdk_memory_total_bytes The total size of reserved memory in bytes.
 # TYPE dpdk_memory_total_bytes gauge
 # HELP dpdk_memory_used_bytes The currently used memory in bytes.
 # TYPE dpdk_memory_used_bytes gauge
 dpdk_memory_total_bytes 1073741824
 dpdk_memory_used_bytes 794197376

Link: 
https://prometheus.io/docs/instrumenting/exposition_formats/#text-based-format
Link: 
https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#text-format
Link: 
https://graphite.readthedocs.io/en/latest/feeding-carbon.html#the-pickle-protocol
Link: 
https://github.com/influxdata/telegraf/tree/master/plugins/inputs/prometheus
Signed-off-by: Robin Jarry 
---

Notes:
v1:

* Ideally, this script should be tested in CI to avoid breakage when the
  telemetry data structures change. I don't know where such a test could
  be done.

* There was work done 3/4 years ago in collectd to add DPDK telemetry
  support but I think this has now been abandoned.

  https://github.com/collectd/collectd/blob/main/src/dpdk_telemetry.c

  I think that keeping the exporters in the DPDK repository makes more
  sense from a maintainability perspective.

 usertools/dpdk-telemetry-exporter.py  | 376 ++
 usertools/meson.build |   6 +
 usertools/telemetry-endpoints/counters.py |  47 +++
 usertools/telemetry-endpoints/cpu.py  |  29 ++
 usertools/telemetry-endpoints/memory.py   |  37 +++
 5 files changed, 495 insertions(+)
 create mode 100755 usertools/dpdk-telemetry-exporter.py
 create mode 100644 usertools/telemetry-endpoints/counters.py
 create mode 100644 usertools/telemetry-endpoints/cpu.py
 create mode 100644 usertools/telemetry-endpoints/memory.py

diff --git a/usertools/dpdk-telemetry-exporter.py 
b/usertools/dpdk-telemetry-exporter.py
new file mode 100755
index ..6c1495a9e1e8
--- /dev/null
+++ b/usertools/dpdk-telemetry-exporter.py
@@ -0,0 +1,376 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2023 Robin Jarry
+
+'''
+DPDK telemetry exporter.
+
+It uses dynamically loaded endpoint exporters

[PATCH] test/pdcp: add data walkthrough test

[Aakash Sasidharan]

Enable data walkthrough test in combined mode.
The test covers data size ranging from 0B to 9000B
both inclusive.

Signed-off-by: Aakash Sasidharan 
---
 app/test/test_pdcp.c | 55 +---
 1 file changed, 52 insertions(+), 3 deletions(-)

diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c
index 49bc8641a0..0a2827f2ef 100644
--- a/app/test/test_pdcp.c
+++ b/app/test/test_pdcp.c
@@ -27,6 +27,8 @@
 #define NB_BASIC_TESTS RTE_DIM(pdcp_test_params)
 #define NB_SDAP_TESTS RTE_DIM(list_pdcp_sdap_tests)
 #define PDCP_IV_LEN 16
+#define PDCP_MBUF_SIZE (sizeof(struct rte_mbuf) + \
+RTE_PKTMBUF_HEADROOM + RTE_PDCP_CTRL_PDU_SIZE_MAX)
 
 /* Assert that condition is true, or goto the mark */
 #define ASSERT_TRUE_OR_GOTO(cond, mark, ...) do {\
@@ -79,8 +81,11 @@ enum pdcp_test_suite_type {
PDCP_TEST_SUITE_TY_SDAP,
 };
 
+static bool silent;
+
 static int create_test_conf_from_index(const int index, struct pdcp_test_conf 
*conf,
   enum pdcp_test_suite_type suite_type);
+static void test_conf_input_data_modify(struct pdcp_test_conf *conf, int 
inp_len);
 
 typedef int (*test_with_conf_t)(struct pdcp_test_conf *conf);
 
@@ -364,7 +369,7 @@ testsuite_setup(void)
memset(ts_params, 0, sizeof(*ts_params));
 
ts_params->mbuf_pool = rte_pktmbuf_pool_create("mbuf_pool", NUM_MBUFS, 
MBUF_CACHE_SIZE, 0,
-  MBUF_SIZE, 
SOCKET_ID_ANY);
+  PDCP_MBUF_SIZE, 
SOCKET_ID_ANY);
if (ts_params->mbuf_pool == NULL) {
RTE_LOG(ERR, USER1, "Could not create mbuf pool\n");
return TEST_FAILED;
@@ -522,8 +527,10 @@ pdcp_known_vec_verify(struct rte_mbuf *m, const uint8_t 
*expected, uint32_t expe
uint8_t *actual = rte_pktmbuf_mtod(m, uint8_t *);
uint32_t actual_pkt_len = rte_pktmbuf_pkt_len(m);
 
-   debug_hexdump(stdout, "Received:", actual, actual_pkt_len);
-   debug_hexdump(stdout, "Expected:", expected, expected_pkt_len);
+   if (!silent) {
+   debug_hexdump(stdout, "Received:", actual, actual_pkt_len);
+   debug_hexdump(stdout, "Expected:", expected, expected_pkt_len);
+   }
 
TEST_ASSERT_EQUAL(actual_pkt_len, expected_pkt_len,
  "Mismatch in packet lengths [expected: %d, received: 
%d]",
@@ -1038,6 +1045,13 @@ create_test_conf_from_index(const int index, struct 
pdcp_test_conf *conf,
return 0;
 }
 
+static void
+test_conf_input_data_modify(struct pdcp_test_conf *conf, int inp_len)
+{
+   conf->input_len = inp_len;
+   memset(conf->input, 0xab, inp_len);
+}
+
 static struct rte_pdcp_entity*
 test_entity_create(const struct pdcp_test_conf *t_conf, int *rc)
 {
@@ -2055,6 +2069,38 @@ test_combined(struct pdcp_test_conf *ul_conf)
return ret;
 }
 
+#define MIN_DATA_LEN 0
+#define MAX_DATA_LEN 9000
+
+static int
+test_combined_data_walkthrough(struct pdcp_test_conf *test_conf)
+{
+   uint32_t data_len;
+   int ret;
+
+   ret = test_combined(test_conf);
+   if (ret != TEST_SUCCESS)
+   return ret;
+
+   if (!silent)
+   silent = true;
+
+   /* With the passing config, perform a data walkthrough test. */
+   for (data_len = MIN_DATA_LEN; data_len <= MAX_DATA_LEN; data_len++) {
+   test_conf_input_data_modify(test_conf, data_len);
+   ret = test_combined(test_conf);
+
+   if (ret == TEST_FAILED) {
+   printf("Data walkthrough failed for input len: %d\n", 
data_len);
+   return TEST_FAILED;
+   }
+   }
+
+   silent = false;
+
+   return TEST_SUCCESS;
+}
+
 #ifdef RTE_LIB_EVENTDEV
 static inline void
 eventdev_conf_default_set(struct rte_event_dev_config *dev_conf, struct 
rte_event_dev_info *info)
@@ -2190,6 +2236,9 @@ static struct unit_test_suite combined_mode_cases  = {
.unit_test_cases = {
TEST_CASE_NAMED_WITH_DATA("combined mode", ut_setup_pdcp, 
ut_teardown_pdcp,
run_test_with_all_known_vec, test_combined),
+   TEST_CASE_NAMED_WITH_DATA("combined mode data walkthrough",
+   ut_setup_pdcp, ut_teardown_pdcp,
+   run_test_with_all_known_vec, 
test_combined_data_walkthrough),
TEST_CASES_END() /**< NULL terminate unit test array */
}
 };
-- 
2.25.1

Re: [PATCH v13 4/4] app/testpmd: add recycle mbufs engine

[Ajit Khaparde]

On Tue, Sep 26, 2023 at 6:30 AM Konstantin Ananyev
 wrote:
>
> 25.09.2023 04:19, Feifei Wang пишет:
> > Add recycle mbufs engine for testpmd. This engine forward pkts with
> > I/O forward mode. But enable mbufs recycle feature to recycle used
> > txq mbufs for rxq mbuf ring, which can bypass mempool path and save
> > CPU cycles.
> >
> > Suggested-by: Jerin Jacob 
> > Signed-off-by: Feifei Wang 
> > Reviewed-by: Ruifeng Wang 
> > ---
>
>
> Acked-by: Konstantin Ananyev 
Acked-by: Ajit Khaparde 

>


smime.p7s
Description: S/MIME Cryptographic Signature

[PATCH v7 0/8] add rte flow support for cpfl

[yuying . zhang]

From: Yuying 

This patchset add rte flow support for cpfl driver.
It depends on the following patch set:
http://patchwork.dpdk.org/project/dpdk/cover/20230912173039.1612287-1-beilei.x...@intel.com/

Wenjing Qiao (2):
  net/cpfl: add json parser for rte flow pattern rules
  net/cpfl: build action mapping rules from JSON

Yuying Zhang (6):
  net/cpfl: set up rte flow skeleton
  net/cpfl: set up control path
  net/cpfl: add FXP low level implementation
  net/cpfl: add fxp rule module
  net/cpfl: add fxp flow engine
  net/cpfl: add flow support for representor
---
v7:
* refine commit log
* fix compile issues

v6:
* use existed jansson instead of json-c library.
* refine "add FXP low level implementation"

V5:
* Add input validation for some functions.


 doc/guides/nics/cpfl.rst|   53 +
 doc/guides/rel_notes/release_23_11.rst  |1 +
 drivers/net/cpfl/cpfl_actions.h |  858 +++
 drivers/net/cpfl/cpfl_controlq.c|  801 ++
 drivers/net/cpfl/cpfl_controlq.h|   75 +
 drivers/net/cpfl/cpfl_ethdev.c  |  392 -
 drivers/net/cpfl/cpfl_ethdev.h  |  128 ++
 drivers/net/cpfl/cpfl_flow.c|  339 +
 drivers/net/cpfl/cpfl_flow.h|   85 ++
 drivers/net/cpfl/cpfl_flow_engine_fxp.c |  667 
 drivers/net/cpfl/cpfl_flow_parser.c | 1839 +++
 drivers/net/cpfl/cpfl_flow_parser.h |  267 
 drivers/net/cpfl/cpfl_fxp_rule.c|  296 
 drivers/net/cpfl/cpfl_fxp_rule.h|   68 +
 drivers/net/cpfl/cpfl_representor.c |   29 +
 drivers/net/cpfl/cpfl_rules.c   |  126 ++
 drivers/net/cpfl/cpfl_rules.h   |  306 
 drivers/net/cpfl/cpfl_vchnl.c   |  144 ++
 drivers/net/cpfl/meson.build|   12 +
 19 files changed, 6485 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/cpfl/cpfl_actions.h
 create mode 100644 drivers/net/cpfl/cpfl_controlq.c
 create mode 100644 drivers/net/cpfl/cpfl_controlq.h
 create mode 100644 drivers/net/cpfl/cpfl_flow.c
 create mode 100644 drivers/net/cpfl/cpfl_flow.h
 create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.h
 create mode 100644 drivers/net/cpfl/cpfl_rules.c
 create mode 100644 drivers/net/cpfl/cpfl_rules.h

-- 
2.34.1

[PATCH v7 1/8] net/cpfl: add json parser for rte flow pattern rules

[yuying . zhang]

From: Wenjing Qiao 

Add devargs "flow_parser" for rte flow json parser which depends
on jansson library.

Example:
-a ca:00.0,flow_parser="refpkg.json"

Add json parser for rte flow pattern rules which can build rules
that maps from a set of rte flow items to hardware representations.

The cpfl PMD supports utilizing a JSON configuration file to translate
rte flow tokens into low level hardware resources. The JSON configuration
file is provided by the hardware vendor and is intended to work exclusively
with a specific P4 pipeline configuration, which must be compiled and
programmed into the hardware.

The format of the JSON file strictly follows the internal specifications
of the hardware vendor and is not meant to be modified directly by
users.

Signed-off-by: Wenjing Qiao 
---
 doc/guides/nics/cpfl.rst|   38 +
 drivers/net/cpfl/cpfl_ethdev.c  |   38 +-
 drivers/net/cpfl/cpfl_ethdev.h  |   76 ++
 drivers/net/cpfl/cpfl_flow_parser.c | 1303 +++
 drivers/net/cpfl/cpfl_flow_parser.h |  167 
 drivers/net/cpfl/meson.build|7 +
 6 files changed, 1628 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.c
 create mode 100644 drivers/net/cpfl/cpfl_flow_parser.h

diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst
index 83a18c3f2e..e17347d15c 100644
--- a/doc/guides/nics/cpfl.rst
+++ b/doc/guides/nics/cpfl.rst
@@ -128,12 +128,32 @@ Runtime Configuration
 
 -a BDF,representor=vf[0-3],representor=c1pf1
 
+- ``flow_parser`` (default ``not enabled``)
+
+  The cpfl PMD supports utilizing a JSON config file to translate rte_flow 
tokens into
+  low-level hardware resources.
+
+  The JSON configuration file is provided by the hardware vendor and is 
intended to work
+  exclusively with a specific P4 pipeline configuration, which must be 
compiled and programmed
+  into the hardware.
+
+  The format of the JSON file strictly follows the internal specifications of 
the hardware
+  vendor and is not meant to be modified directly by users.
+
+  Using the ``devargs`` option ``flow_parser`` the user can specify the path
+  of a json file, for example::
+
+-a ca:00.0,flow_parser="refpkg.json"
+
+  Then the PMD will load json file for device ``ca:00.0``.
+  The parameter is optional.
 
 Driver compilation and testing
 --
 
 Refer to the document :doc:`build_and_test` for details.
 
+The jansson library must be installed to use rte_flow.
 
 Features
 
@@ -164,3 +184,21 @@ Hairpin queue
 E2100 Series can loopback packets from RX port to TX port.
 This feature is called port-to-port or hairpin.
 Currently, the PMD only supports single port hairpin.
+
+Rte_flow
+~
+
+PMD uses a json file to direct CPF PMD to parse rte_flow tokens into
+low level hardware resources.
+
+- Required Libraries
+
+  * jansson
+
+* For Ubuntu, it can be installed using `apt install libjansson-dev`
+
+- run testpmd with the json file
+
+   .. code-block:: console
+
+   dpdk-testpmd -c 0x3 -n 4 -a 
:af:00.6,vport=[0],flow_parser="refpkg.json" -- -i
diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index 189072ab33..1745f703c8 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -21,6 +21,10 @@
 #define CPFL_RX_SINGLE_Q   "rx_single"
 #define CPFL_VPORT "vport"
 
+#ifdef RTE_HAS_JANSSON
+#define CPFL_FLOW_PARSER   "flow_parser"
+#endif
+
 rte_spinlock_t cpfl_adapter_lock;
 /* A list for all adapters, one adapter matches one PCI device */
 struct cpfl_adapter_list cpfl_adapter_list;
@@ -31,6 +35,9 @@ static const char * const cpfl_valid_args_first[] = {
CPFL_TX_SINGLE_Q,
CPFL_RX_SINGLE_Q,
CPFL_VPORT,
+#ifdef RTE_HAS_JANSSON
+   CPFL_FLOW_PARSER,
+#endif
NULL
 };
 
@@ -1537,6 +1544,24 @@ parse_repr(const char *key __rte_unused, const char 
*value, void *args)
return 0;
 }
 
+#ifdef RTE_HAS_JANSSON
+static int
+parse_file(const char *key, const char *value, void *args)
+{
+   char *name = args;
+
+   if (strlen(value) > CPFL_FLOW_FILE_LEN - 1) {
+   PMD_DRV_LOG(ERR, "file path(%s) is too long.", value);
+   return -1;
+   }
+
+   PMD_DRV_LOG(DEBUG, "value:\"%s\" for key:\"%s\"", value, key);
+   strlcpy(name, value, CPFL_FLOW_FILE_LEN);
+
+   return 0;
+}
+#endif
+
 static int
 cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext 
*adapter, bool first)
 {
@@ -1585,7 +1610,18 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev, 
struct cpfl_adapter_ext *adap
 &adapter->base.is_rx_singleq);
if (ret != 0)
goto fail;
-
+#ifdef RTE_HAS_JANSSON
+   if (rte_kvargs_get(kvlist, CPFL_FLOW_PARSER)) {
+   ret = rte_kvargs_process(kvlist, CPFL_FLOW_PARSER,
+&parse_file, cpfl_args->flow_parser);
+ 

[PATCH v7 2/8] net/cpfl: build action mapping rules from JSON

[yuying . zhang]

From: Wenjing Qiao 

Build rules that maps from an rte flow action vxlan_encap or
vxlan_decap to hardware representations.

Signed-off-by: Wenjing Qiao 
---
 drivers/net/cpfl/cpfl_flow_parser.c | 538 +++-
 drivers/net/cpfl/cpfl_flow_parser.h | 100 ++
 2 files changed, 637 insertions(+), 1 deletion(-)

diff --git a/drivers/net/cpfl/cpfl_flow_parser.c 
b/drivers/net/cpfl/cpfl_flow_parser.c
index 308f9c9736..81ccbbd8e5 100644
--- a/drivers/net/cpfl/cpfl_flow_parser.c
+++ b/drivers/net/cpfl/cpfl_flow_parser.c
@@ -32,6 +32,18 @@ cpfl_get_item_type_by_str(const char *type)
return RTE_FLOW_ITEM_TYPE_VOID;
 }
 
+static enum rte_flow_action_type
+cpfl_get_action_type_by_str(const char *type)
+{
+   if (strcmp(type, "vxlan_encap") == 0)
+   return RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP;
+   else if (strcmp(type, "vxlan_decap") == 0)
+   return RTE_FLOW_ACTION_TYPE_VXLAN_DECAP;
+
+   PMD_DRV_LOG(ERR, "Not support this type: %s.", type);
+   return RTE_FLOW_ACTION_TYPE_VOID;
+}
+
 static const char *
 cpfl_json_t_to_string(json_t *object, const char *name)
 {
@@ -50,6 +62,29 @@ cpfl_json_t_to_string(json_t *object, const char *name)
return json_string_value(subobject);
 }
 
+static int
+cpfl_json_t_to_int(json_t *object, const char *name, int *value)
+{
+   json_t *subobject;
+
+   if (!object) {
+   PMD_DRV_LOG(ERR, "object doesn't exist.");
+   return -EINVAL;
+   }
+   subobject = json_object_get(object, name);
+   if (!subobject) {
+   PMD_DRV_LOG(ERR, "%s doesn't exist.", name);
+   return -EINVAL;
+   }
+   if (!json_is_integer(subobject)) {
+   PMD_DRV_LOG(ERR, "%s is not an integer.", name);
+   return -EINVAL;
+   }
+   *value = (int)json_integer_value(subobject);
+
+   return 0;
+}
+
 static int
 cpfl_json_t_to_uint16(json_t *object, const char *name, uint16_t *value)
 {
@@ -522,6 +557,228 @@ cpfl_flow_js_pattern_rule(json_t *ob_root, struct 
cpfl_flow_js_parser *parser)
return -EINVAL;
 }
 
+static int
+cpfl_flow_js_mr_key(json_t *ob_mr_keys, struct cpfl_flow_js_mr_key *js_mr_key)
+{
+   int len, i;
+
+   len = json_array_size(ob_mr_keys);
+   if (len == 0)
+   return 0;
+   js_mr_key->actions = rte_malloc(NULL, sizeof(struct 
cpfl_flow_js_mr_key_action) * len, 0);
+   if (!js_mr_key->actions) {
+   PMD_DRV_LOG(ERR, "Failed to alloc memory.");
+   return -ENOMEM;
+   }
+   js_mr_key->actions_size = len;
+   for (i = 0; i < len; i++) {
+   json_t *object, *ob_data;
+   const char *type;
+   enum rte_flow_action_type act_type;
+
+   object = json_array_get(ob_mr_keys, i);
+   /* mr->key->actions->type */
+   type = cpfl_json_t_to_string(object, "type");
+   if (!type) {
+   PMD_DRV_LOG(ERR, "Can not parse string 'type'.");
+   goto err;
+   }
+   act_type = cpfl_get_action_type_by_str(type);
+   if (act_type == RTE_FLOW_ACTION_TYPE_VOID)
+   goto err;
+   js_mr_key->actions[i].type = act_type;
+   /* mr->key->actions->data */
+   ob_data = json_object_get(object, "data");
+   if (js_mr_key->actions[i].type == 
RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP) {
+   json_t *ob_protos;
+   int proto_size, j;
+   struct cpfl_flow_js_mr_key_action_vxlan_encap *encap;
+
+   ob_protos = json_object_get(ob_data, "protocols");
+   encap = &js_mr_key->actions[i].encap;
+   if (!ob_protos) {
+   encap->proto_size = 0;
+   continue;
+   }
+   proto_size = json_array_size(ob_protos);
+   encap->proto_size = proto_size;
+   for (j = 0; j < proto_size; j++) {
+   const char *s;
+   json_t *subobject;
+   enum rte_flow_item_type proto_type;
+
+   subobject = json_array_get(ob_protos, j);
+   s = json_string_value(subobject);
+   proto_type = cpfl_get_item_type_by_str(s);
+   if (proto_type == RTE_FLOW_ITEM_TYPE_VOID) {
+   PMD_DRV_LOG(ERR, "parse VXLAN_ENCAP 
failed.");
+   goto err;
+   }
+   encap->protocols[j] = proto_type;
+   }
+   } else if (js_mr_key->actions[i].type != 
RTE_FLOW_ACTION_TYPE_VXLAN_DECAP) {
+   PMD_DRV_LOG(ERR, "

[PATCH v7 3/8] net/cpfl: set up rte flow skeleton

[yuying . zhang]

From: Yuying Zhang 

Set up the rte_flow backend skeleton. Introduce the framework
to support different engines as rte_flow backend. Bridge rte_flow
driver API to flow engines.

Signed-off-by: Yuying Zhang 
---
 drivers/net/cpfl/cpfl_ethdev.c |  53 ++
 drivers/net/cpfl/cpfl_ethdev.h |   5 +
 drivers/net/cpfl/cpfl_flow.c   | 339 +
 drivers/net/cpfl/cpfl_flow.h   |  85 +
 drivers/net/cpfl/meson.build   |   1 +
 5 files changed, 483 insertions(+)
 create mode 100644 drivers/net/cpfl/cpfl_flow.c
 create mode 100644 drivers/net/cpfl/cpfl_flow.h

diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index 1745f703c8..c350728861 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -15,6 +15,7 @@
 #include "cpfl_ethdev.h"
 #include 
 #include "cpfl_rxtx.h"
+#include "cpfl_flow.h"
 
 #define CPFL_REPRESENTOR   "representor"
 #define CPFL_TX_SINGLE_Q   "tx_single"
@@ -1074,6 +1075,19 @@ cpfl_dev_stop(struct rte_eth_dev *dev)
return 0;
 }
 
+static void
+cpfl_flow_free(struct cpfl_vport *vport)
+{
+   struct rte_flow *p_flow;
+
+   while ((p_flow = TAILQ_FIRST(&vport->itf.flow_list))) {
+   TAILQ_REMOVE(&vport->itf.flow_list, p_flow, next);
+   if (p_flow->engine->free)
+   p_flow->engine->free(p_flow);
+   rte_free(p_flow);
+   }
+}
+
 static int
 cpfl_p2p_queue_grps_del(struct idpf_vport *vport)
 {
@@ -1105,6 +1119,7 @@ cpfl_dev_close(struct rte_eth_dev *dev)
if (!adapter->base.is_rx_singleq && !adapter->base.is_tx_singleq)
cpfl_p2p_queue_grps_del(vport);
 
+   cpfl_flow_free(cpfl_vport);
idpf_vport_deinit(vport);
rte_free(cpfl_vport->p2p_q_chunks_info);
 
@@ -1117,6 +1132,29 @@ cpfl_dev_close(struct rte_eth_dev *dev)
return 0;
 }
 
+static int
+cpfl_dev_flow_ops_get(struct rte_eth_dev *dev,
+ const struct rte_flow_ops **ops)
+{
+   struct cpfl_itf *itf;
+
+   if (!dev)
+   return -EINVAL;
+
+   itf = CPFL_DEV_TO_ITF(dev);
+
+   /* only vport support rte_flow */
+   if (itf->type != CPFL_ITF_TYPE_VPORT)
+   return -ENOTSUP;
+#ifdef RTE_HAS_JANSSON
+   *ops = &cpfl_flow_ops;
+#else
+   *ops = NULL;
+   PMD_DRV_LOG(NOTICE, "not support rte_flow, please install json-c 
library.");
+#endif
+   return 0;
+}
+
 static int
 cpfl_hairpin_get_peer_ports(struct rte_eth_dev *dev, uint16_t *peer_ports,
size_t len, uint32_t tx)
@@ -1318,6 +1356,7 @@ static const struct eth_dev_ops cpfl_eth_dev_ops = {
.xstats_get = cpfl_dev_xstats_get,
.xstats_get_names   = cpfl_dev_xstats_get_names,
.xstats_reset   = cpfl_dev_xstats_reset,
+   .flow_ops_get   = cpfl_dev_flow_ops_get,
.hairpin_cap_get= cpfl_hairpin_cap_get,
.rx_hairpin_queue_setup = cpfl_rx_hairpin_queue_setup,
.tx_hairpin_queue_setup = cpfl_tx_hairpin_queue_setup,
@@ -2021,6 +2060,13 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, 
struct cpfl_adapter_ext *a
goto err_vports_alloc;
}
 
+#ifdef RTE_HAS_JANSSON
+   ret = cpfl_flow_init(adapter);
+   if (ret) {
+   PMD_INIT_LOG(ERR, "Failed to init flow module");
+   goto err_flow_init;
+   }
+#endif
adapter->cur_vports = 0;
adapter->cur_vport_nb = 0;
 
@@ -2028,6 +2074,9 @@ cpfl_adapter_ext_init(struct rte_pci_device *pci_dev, 
struct cpfl_adapter_ext *a
 
return ret;
 
+#ifdef RTE_HAS_JANSSON
+err_flow_init:
+#endif
 err_vports_alloc:
rte_eal_alarm_cancel(cpfl_dev_alarm_handler, adapter);
cpfl_repr_allowlist_uninit(adapter);
@@ -2182,6 +2231,7 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void 
*init_params)
cpfl_vport->itf.type = CPFL_ITF_TYPE_VPORT;
cpfl_vport->itf.adapter = adapter;
cpfl_vport->itf.data = dev->data;
+   TAILQ_INIT(&cpfl_vport->itf.flow_list);
adapter->vports[param->idx] = cpfl_vport;
adapter->cur_vports |= RTE_BIT32(param->devarg_id);
adapter->cur_vport_nb++;
@@ -2262,6 +2312,9 @@ cpfl_find_adapter_ext(struct rte_pci_device *pci_dev)
 static void
 cpfl_adapter_ext_deinit(struct cpfl_adapter_ext *adapter)
 {
+#ifdef RTE_HAS_JANSSON
+   cpfl_flow_uninit(adapter);
+#endif
rte_eal_alarm_cancel(cpfl_dev_alarm_handler, adapter);
cpfl_vport_map_uninit(adapter);
idpf_adapter_deinit(&adapter->base);
diff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h
index 383dbd14c6..69bf32cfbd 100644
--- a/drivers/net/cpfl/cpfl_ethdev.h
+++ b/drivers/net/cpfl/cpfl_ethdev.h
@@ -140,9 +140,12 @@ enum cpfl_itf_type {
CPFL_ITF_TYPE_REPRESENTOR,
 };
 
+TAILQ_HEAD(cpfl_flow_list, rte_flow);
+
 struct cpfl_itf {
enum cpfl_itf_type 

[PATCH v7 4/8] net/cpfl: set up control path

[yuying . zhang]

From: Yuying Zhang 

Set up control vport and control queue for flow offloading.

Signed-off-by: Yuying Zhang 
---
 drivers/net/cpfl/cpfl_controlq.c | 801 +++
 drivers/net/cpfl/cpfl_controlq.h |  75 +++
 drivers/net/cpfl/cpfl_ethdev.c   | 270 +++
 drivers/net/cpfl/cpfl_ethdev.h   |  14 +
 drivers/net/cpfl/cpfl_vchnl.c| 144 ++
 drivers/net/cpfl/meson.build |   1 +
 6 files changed, 1305 insertions(+)
 create mode 100644 drivers/net/cpfl/cpfl_controlq.c
 create mode 100644 drivers/net/cpfl/cpfl_controlq.h

diff --git a/drivers/net/cpfl/cpfl_controlq.c b/drivers/net/cpfl/cpfl_controlq.c
new file mode 100644
index 00..4a925bc338
--- /dev/null
+++ b/drivers/net/cpfl/cpfl_controlq.c
@@ -0,0 +1,801 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2001-2023 Intel Corporation
+ */
+
+#include "cpfl_controlq.h"
+#include "base/idpf_controlq.h"
+#include "rte_common.h"
+
+/**
+ * cpfl_check_dma_mem_parameters - verify DMA memory params from CP
+ * @qinfo: pointer to create control queue info struct
+ *
+ * Verify that DMA parameter of each DMA memory struct is present and
+ * consistent with control queue parameters
+ */
+static inline int
+cpfl_check_dma_mem_parameters(struct cpfl_ctlq_create_info *qinfo)
+{
+   struct idpf_dma_mem *ring = &qinfo->ring_mem;
+   struct idpf_dma_mem *buf = &qinfo->buf_mem;
+
+   if (!ring->va || !ring->size)
+   return -EINVAL;
+
+   if (ring->size != qinfo->len * sizeof(struct idpf_ctlq_desc))
+   return -EINVAL;
+
+   /* no need for buffer checks for TX queues */
+   if (qinfo->type == IDPF_CTLQ_TYPE_MAILBOX_TX ||
+   qinfo->type == IDPF_CTLQ_TYPE_CONFIG_TX ||
+   qinfo->type == IDPF_CTLQ_TYPE_RDMA_TX)
+   return 0;
+
+   if (!buf->va || !buf->size)
+   return -EINVAL;
+
+   /* accommodate different types of rx ring buffer sizes */
+   if ((qinfo->type == IDPF_CTLQ_TYPE_MAILBOX_RX &&
+buf->size != CPFL_CTLQ_MAILBOX_BUFFER_SIZE * qinfo->len) ||
+   (qinfo->type == IDPF_CTLQ_TYPE_CONFIG_RX &&
+buf->size != CPFL_CFGQ_RING_LEN * CPFL_CTLQ_CFGQ_BUFFER_SIZE))
+   return -EINVAL;
+
+   return 0;
+}
+
+/**
+ * cpfl_ctlq_alloc_ring_res - store memory for descriptor ring and bufs
+ * @hw: pointer to hw struct
+ * @cq: pointer to control queue struct
+ * @qinfo: pointer to create queue info struct
+ *
+ * The CP takes care of all DMA memory allocations. Store the allocated memory
+ * information for the descriptor ring and buffers. If the memory for either 
the
+ * descriptor ring or the buffers is not allocated properly and/or inconsistent
+ * with the control queue parameters, this routine will free the memory for
+ * both the descriptors and the buffers
+ */
+int
+cpfl_ctlq_alloc_ring_res(struct idpf_hw *hw __rte_unused, struct 
idpf_ctlq_info *cq,
+struct cpfl_ctlq_create_info *qinfo)
+{
+   int ret_code = 0;
+   unsigned int elem_size;
+   int i = 0;
+
+   ret_code = cpfl_check_dma_mem_parameters(qinfo);
+   if (ret_code)
+   /* TODO: Log an error message per CP */
+   goto err;
+
+   cq->desc_ring.va = qinfo->ring_mem.va;
+   cq->desc_ring.pa = qinfo->ring_mem.pa;
+   cq->desc_ring.size = qinfo->ring_mem.size;
+
+   switch (cq->cq_type) {
+   case IDPF_CTLQ_TYPE_MAILBOX_RX:
+   case IDPF_CTLQ_TYPE_CONFIG_RX:
+   case IDPF_CTLQ_TYPE_EVENT_RX:
+   case IDPF_CTLQ_TYPE_RDMA_RX:
+   /* Only receive queues will have allocated buffers
+* during init.  CP allocates one big chunk of DMA
+* region who size is equal to ring_len * buff_size.
+* In CPFLib, the block gets broken down to multiple
+* smaller blocks that actually gets programmed in the hardware.
+*/
+
+   cq->bi.rx_buff = (struct idpf_dma_mem **)
+   idpf_calloc(hw, cq->ring_size,
+   sizeof(struct idpf_dma_mem *));
+   if (!cq->bi.rx_buff) {
+   ret_code = -ENOMEM;
+   /* TODO: Log an error message per CP */
+   goto err;
+   }
+
+   elem_size = qinfo->buf_size;
+   for (i = 0; i < cq->ring_size; i++) {
+   cq->bi.rx_buff[i] = (struct idpf_dma_mem *)idpf_calloc
+   (hw, 1,
+sizeof(struct idpf_dma_mem));
+   if (!cq->bi.rx_buff[i]) {
+   ret_code = -ENOMEM;
+   goto free_rx_buffs;
+   }
+   cq->bi.rx_buff[i]->va =
+   (uint64_t *)((char *)qinfo->buf_mem.va + (i * 
elem_size));
+   cq->bi.rx_buff[i]->pa = qinf

[PATCH v7 5/8] net/cpfl: add FXP low level implementation

[yuying . zhang]

From: Yuying Zhang 

Add low level implementation for CPFL PMD to create / delete
rules on IPU's Flexible Packet Processor(FXP).

Signed-off-by: Yuying Zhang 
---
 drivers/net/cpfl/cpfl_actions.h | 858 
 drivers/net/cpfl/cpfl_rules.c   | 126 +
 drivers/net/cpfl/cpfl_rules.h   | 306 
 drivers/net/cpfl/meson.build|   1 +
 4 files changed, 1291 insertions(+)
 create mode 100644 drivers/net/cpfl/cpfl_actions.h
 create mode 100644 drivers/net/cpfl/cpfl_rules.c
 create mode 100644 drivers/net/cpfl/cpfl_rules.h

diff --git a/drivers/net/cpfl/cpfl_actions.h b/drivers/net/cpfl/cpfl_actions.h
new file mode 100644
index 00..7b82119e39
--- /dev/null
+++ b/drivers/net/cpfl/cpfl_actions.h
@@ -0,0 +1,858 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2001-2023 Intel Corporation
+ */
+
+#ifndef _CPFL_ACTIONS_H_
+#define _CPFL_ACTIONS_H_
+
+#include "base/idpf_osdep.h"
+
+#pragma pack(1)
+
+union cpfl_action_set {
+   uint32_t data;
+
+   struct {
+   uint32_t val : 24;
+   uint32_t idx : 4;
+   uint32_t tag : 1;
+   uint32_t prec : 3;
+   } set_24b_a;
+
+   struct {
+   uint32_t val : 24;
+   uint32_t idx : 3;
+   uint32_t tag : 2;
+   uint32_t prec : 3;
+   } set_24b_b;
+
+   struct {
+   uint32_t val : 16;
+   uint32_t idx : 4;
+   uint32_t unused : 6;
+   uint32_t tag : 3;
+   uint32_t prec : 3;
+   } set_16b;
+
+   struct {
+   uint32_t val_a : 8;
+   uint32_t val_b : 8;
+   uint32_t idx_a : 4;
+   uint32_t idx_b : 4;
+   uint32_t tag : 5;
+   uint32_t prec : 3;
+   } set_8b;
+
+   struct {
+   uint32_t val : 10;
+   uint32_t ena : 10;
+   uint32_t idx : 4;
+   uint32_t tag : 5;
+   uint32_t prec : 3;
+   } set_1b;
+
+   struct {
+   uint32_t val : 24;
+   uint32_t tag : 5;
+   uint32_t prec : 3;
+   } nop;
+
+   struct {
+   uint32_t val : 24;
+   uint32_t tag : 5;
+   uint32_t prec : 3;
+   } chained_24b;
+
+   struct {
+   uint32_t val : 24;
+   uint32_t tag : 5;
+   uint32_t prec : 3;
+   } aux_flags;
+};
+
+struct cpfl_action_set_ext {
+#define CPFL_ACTION_SET_EXT_CNT 2
+   union cpfl_action_set acts[CPFL_ACTION_SET_EXT_CNT];
+};
+
+#pragma pack()
+
+/**
+ * cpfl_act_nop - Encode a NOP action
+ */
+static inline union cpfl_action_set
+cpfl_act_nop(void)
+{
+   union cpfl_action_set act;
+
+   act.data = 0;
+   return act;
+}
+
+/**
+ * cpfl_is_nop_action - Indicate if an action set is a NOP
+ */
+static inline bool
+cpfl_is_nop_action(union cpfl_action_set *act)
+{
+   return act->data == cpfl_act_nop().data;
+}
+
+#define CPFL_MAKE_MASK32(b, s) uint32_t)1 << (b)) - 1) << (s))
+
+#define CPFL_ACT_PREC_MAX  7
+#define CPFL_ACT_PREC_S29
+#define CPFL_ACT_PREC_MCPFL_MAKE_MASK32(3, CPFL_ACT_PREC_S)
+#define CPFL_ACT_PREC_SET(p)   \
+   (((uint32_t)(p) << CPFL_ACT_PREC_S) & CPFL_ACT_PREC_M)
+#define CPFL_ACT_PREC_CHECK(p) ((p) > 0 && (p) <= CPFL_ACT_PREC_MAX)
+
+#define CPFL_METADATA_ID_CNT   32  /* Max number of metadata IDs */
+#define CPFL_METADATA_STRUCT_MAX_SZ128 /* Max metadata size per ID */
+
+/***
+ * 1-Bit Actions
+ 
**/
+#define CPFL_ACT_1B_OP_S   24
+#define CPFL_ACT_1B_OP_M   CPFL_MAKE_MASK32(5, CPFL_ACT_1B_OP_S)
+#define CPFL_ACT_1B_OP ((uint32_t)(0x01) << CPFL_ACT_1B_OP_S)
+
+#define CPFL_ACT_1B_VAL_S  0
+#define CPFL_ACT_1B_VAL_M  CPFL_MAKE_MASK32(10, CPFL_ACT_1B_VAL_S)
+#define CPFL_ACT_1B_EN_S   10
+#define CPFL_ACT_1B_EN_M   CPFL_MAKE_MASK32(10, CPFL_ACT_1B_EN_S)
+#define CPFL_ACT_1B_INDEX_S20
+#define CPFL_ACT_1B_INDEX_MCPFL_MAKE_MASK32(4, CPFL_ACT_1B_INDEX_S)
+
+/* 1-bit actions currently uses only INDEX of 0 */
+#define CPFL_ACT_MAKE_1B(prec, en, val) \
+   ((CPFL_ACT_PREC_SET(prec)) | CPFL_ACT_1B_OP | \
+uint32_t)0) << CPFL_ACT_1B_INDEX_S) & CPFL_ACT_1B_INDEX_M) | \
+(((uint32_t)(en) << CPFL_ACT_1B_EN_S) & CPFL_ACT_1B_EN_M) | \
+(((uint32_t)(val) << CPFL_ACT_1B_VAL_S) & CPFL_ACT_1B_VAL_M))
+
+enum cpfl_act_1b_op {
+   CPFL_ACT_1B_OP_DROP = 0x01,
+   CPFL_ACT_1B_OP_HDR_SPLIT= 0x02,
+   CPFL_ACT_1B_OP_DIR_CHANGE   = 0x04,
+   CPFL_ACT_1B_OP_DEFER_DROP   = 0x08,
+   CPFL_ACT_1B_OP_ORIG_MIR_MD  = 0x80
+};
+
+#define CPFL_ACT_1B_COMMIT_MODE_S  4
+#define CPFL_ACT_1B_COMMIT_MODE_M  \
+   CPFL_MAKE_MASK32(3, 

[PATCH v7 6/8] net/cpfl: add fxp rule module

[yuying . zhang]

From: Yuying Zhang 

Implement FXP rule creation / destroying.

Signed-off-by: Yuying Zhang 
---
 drivers/net/cpfl/cpfl_ethdev.c   |  31 
 drivers/net/cpfl/cpfl_ethdev.h   |   6 +
 drivers/net/cpfl/cpfl_fxp_rule.c | 296 +++
 drivers/net/cpfl/cpfl_fxp_rule.h |  68 +++
 drivers/net/cpfl/meson.build |   1 +
 5 files changed, 402 insertions(+)
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.c
 create mode 100644 drivers/net/cpfl/cpfl_fxp_rule.h

diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c
index a2bc6784d0..da78e79652 100644
--- a/drivers/net/cpfl/cpfl_ethdev.c
+++ b/drivers/net/cpfl/cpfl_ethdev.c
@@ -16,6 +16,7 @@
 #include 
 #include "cpfl_rxtx.h"
 #include "cpfl_flow.h"
+#include "cpfl_rules.h"
 
 #define CPFL_REPRESENTOR   "representor"
 #define CPFL_TX_SINGLE_Q   "tx_single"
@@ -1127,6 +1128,7 @@ cpfl_dev_close(struct rte_eth_dev *dev)
adapter->cur_vport_nb--;
dev->data->dev_private = NULL;
adapter->vports[vport->sw_idx] = NULL;
+   idpf_free_dma_mem(NULL, &cpfl_vport->itf.flow_dma);
rte_free(cpfl_vport);
 
return 0;
@@ -2466,6 +2468,26 @@ cpfl_p2p_queue_info_init(struct cpfl_vport *cpfl_vport,
return 0;
 }
 
+int
+cpfl_alloc_dma_mem_batch(struct idpf_dma_mem *orig_dma, struct idpf_dma_mem 
*dma, uint32_t size,
+int batch_size)
+{
+   int i;
+
+   if (!idpf_alloc_dma_mem(NULL, orig_dma, size * (1 + batch_size))) {
+   PMD_INIT_LOG(ERR, "Could not alloc dma memory");
+   return -ENOMEM;
+   }
+
+   for (i = 0; i < batch_size; i++) {
+   dma[i].va = (void *)((uint64_t)orig_dma->va + size * (i + 1));
+   dma[i].pa = orig_dma->pa + size * (i + 1);
+   dma[i].size = size;
+   dma[i].zone = NULL;
+   }
+   return 0;
+}
+
 static int
 cpfl_dev_vport_init(struct rte_eth_dev *dev, void *init_params)
 {
@@ -2515,6 +2537,15 @@ cpfl_dev_vport_init(struct rte_eth_dev *dev, void 
*init_params)
rte_ether_addr_copy((struct rte_ether_addr *)vport->default_mac_addr,
&dev->data->mac_addrs[0]);
 
+   memset(cpfl_vport->itf.dma, 0, sizeof(cpfl_vport->itf.dma));
+   memset(cpfl_vport->itf.msg, 0, sizeof(cpfl_vport->itf.msg));
+   ret = cpfl_alloc_dma_mem_batch(&cpfl_vport->itf.flow_dma,
+  cpfl_vport->itf.dma,
+  sizeof(union cpfl_rule_cfg_pkt_record),
+  CPFL_FLOW_BATCH_SIZE);
+   if (ret < 0)
+   goto err_mac_addrs;
+
if (!adapter->base.is_rx_singleq && !adapter->base.is_tx_singleq) {
memset(&p2p_queue_grps_info, 0, sizeof(p2p_queue_grps_info));
ret = cpfl_p2p_q_grps_add(vport, &p2p_queue_grps_info, 
p2p_q_vc_out_info);
diff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h
index 7f83d170d7..8eeeac9910 100644
--- a/drivers/net/cpfl/cpfl_ethdev.h
+++ b/drivers/net/cpfl/cpfl_ethdev.h
@@ -147,10 +147,14 @@ enum cpfl_itf_type {
 
 TAILQ_HEAD(cpfl_flow_list, rte_flow);
 
+#define CPFL_FLOW_BATCH_SIZE  490
 struct cpfl_itf {
enum cpfl_itf_type type;
struct cpfl_adapter_ext *adapter;
struct cpfl_flow_list flow_list;
+   struct idpf_dma_mem flow_dma;
+   struct idpf_dma_mem dma[CPFL_FLOW_BATCH_SIZE];
+   struct idpf_ctlq_msg msg[CPFL_FLOW_BATCH_SIZE];
void *data;
 };
 
@@ -240,6 +244,8 @@ int cpfl_cc_vport_info_get(struct cpfl_adapter_ext *adapter,
 int cpfl_vc_create_ctrl_vport(struct cpfl_adapter_ext *adapter);
 int cpfl_config_ctlq_rx(struct cpfl_adapter_ext *adapter);
 int cpfl_config_ctlq_tx(struct cpfl_adapter_ext *adapter);
+int cpfl_alloc_dma_mem_batch(struct idpf_dma_mem *orig_dma, struct 
idpf_dma_mem *dma,
+uint32_t size, int batch_size);
 
 #define CPFL_DEV_TO_PCI(eth_dev)   \
RTE_DEV_TO_PCI((eth_dev)->device)
diff --git a/drivers/net/cpfl/cpfl_fxp_rule.c b/drivers/net/cpfl/cpfl_fxp_rule.c
new file mode 100644
index 00..50fac55432
--- /dev/null
+++ b/drivers/net/cpfl/cpfl_fxp_rule.c
@@ -0,0 +1,296 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+#include "cpfl_ethdev.h"
+
+#include "cpfl_fxp_rule.h"
+#include "cpfl_logs.h"
+
+#define CTLQ_SEND_RETRIES 100
+#define CTLQ_RECEIVE_RETRIES 100
+
+int
+cpfl_send_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 
num_q_msg,
+  struct idpf_ctlq_msg q_msg[])
+{
+   struct idpf_ctlq_msg **msg_ptr_list;
+   u16 clean_count = 0;
+   int num_cleaned = 0;
+   int retries = 0;
+   int ret = 0;
+
+   msg_ptr_list = calloc(num_q_msg, sizeof(struct idpf_ctlq_msg *));
+   if (!msg_ptr_list) {
+   PMD_INIT_LOG(ERR, "no memory for cleaning ctlq");
+   ret = -ENOMEM;
+   goto err;
+   

[PATCH v7 7/8] net/cpfl: add fxp flow engine

[yuying . zhang]

From: Yuying Zhang 

Adapt a flow engine to FXP implementation.

Signed-off-by: Yuying Zhang 
---
 drivers/net/cpfl/cpfl_ethdev.h  |  27 ++
 drivers/net/cpfl/cpfl_flow_engine_fxp.c | 583 
 drivers/net/cpfl/meson.build|   1 +
 3 files changed, 611 insertions(+)
 create mode 100644 drivers/net/cpfl/cpfl_flow_engine_fxp.c

diff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h
index 8eeeac9910..efb0eb5251 100644
--- a/drivers/net/cpfl/cpfl_ethdev.h
+++ b/drivers/net/cpfl/cpfl_ethdev.h
@@ -85,6 +85,8 @@
 
 #define CPFL_RX_CFGQ_NUM   4
 #define CPFL_TX_CFGQ_NUM   4
+#define CPFL_FPCP_CFGQ_TX  0
+#define CPFL_FPCP_CFGQ_RX  1
 #define CPFL_CFGQ_NUM  8
 
 /* bit[15:14] type
@@ -219,6 +221,8 @@ struct cpfl_adapter_ext {
struct rte_hash *repr_allowlist_hash;
 
struct cpfl_flow_js_parser *flow_parser;
+   struct rte_bitmap *mod_bm;
+   void *mod_bm_mem;
 
struct cpfl_metadata meta;
 
@@ -312,4 +316,27 @@ cpfl_get_vsi_id(struct cpfl_itf *itf)
return CPFL_INVALID_HW_ID;
 }
 
+static inline struct cpfl_itf *
+cpfl_get_itf_by_port_id(uint16_t port_id)
+{
+   struct rte_eth_dev *dev;
+
+   if (port_id >= RTE_MAX_ETHPORTS) {
+   PMD_DRV_LOG(ERR, "port_id should be < %d.", RTE_MAX_ETHPORTS);
+   return NULL;
+   }
+
+   dev = &rte_eth_devices[port_id];
+   if (dev->state == RTE_ETH_DEV_UNUSED) {
+   PMD_DRV_LOG(ERR, "eth_dev[%d] is unused.", port_id);
+   return NULL;
+   }
+
+   if (!dev->data) {
+   PMD_DRV_LOG(ERR, "eth_dev[%d] data not be allocated.", port_id);
+   return NULL;
+   }
+
+   return CPFL_DEV_TO_ITF(dev);
+}
 #endif /* _CPFL_ETHDEV_H_ */
diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c 
b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
new file mode 100644
index 00..154af5bd35
--- /dev/null
+++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
@@ -0,0 +1,583 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2022 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "cpfl_rules.h"
+#include "cpfl_logs.h"
+#include "cpfl_ethdev.h"
+#include "cpfl_flow.h"
+#include "cpfl_fxp_rule.h"
+#include "cpfl_flow_parser.h"
+
+#define CPFL_COOKIE_DEF0x1000
+#define CPFL_MOD_COOKIE_DEF0x1237561
+#define CPFL_PREC_DEF  1
+#define CPFL_PREC_SET  5
+#define CPFL_TYPE_ID   3
+#define CPFL_OFFSET0x0a
+#define CPFL_HOST_ID_DEF   0
+#define CPFL_PF_NUM_DEF0
+#define CPFL_PORT_NUM_DEF  0
+#define CPFL_RESP_REQ_DEF  2
+#define CPFL_PIN_TO_CACHE_DEF  0
+#define CPFL_CLEAR_MIRROR_1ST_STATE_DEF0
+#define CPFL_FIXED_FETCH_DEF   0
+#define CPFL_PTI_DEF   0
+#define CPFL_MOD_OBJ_SIZE_DEF  0
+#define CPFL_PIN_MOD_CONTENT_DEF   0
+
+#define CPFL_MAX_MOD_CONTENT_INDEX 256
+#define CPFL_MAX_MR_ACTION_NUM 8
+
+/* Struct used when parse detailed rule information with json file */
+struct cpfl_rule_info_meta {
+   struct cpfl_flow_pr_action pr_action;   /* json action field of pattern 
rule */
+   uint32_t pr_num;/* number of pattern rules */
+   uint32_t mr_num;/* number of modification rules 
*/
+   uint32_t rule_num;  /* number of all rules */
+   struct cpfl_rule_info rules[0];
+};
+
+static uint32_t cpfl_fxp_mod_idx_alloc(struct cpfl_adapter_ext *ad);
+static void cpfl_fxp_mod_idx_free(struct cpfl_adapter_ext *ad, uint32_t idx);
+uint64_t cpfl_rule_cookie = CPFL_COOKIE_DEF;
+
+static int
+cpfl_fxp_create(struct rte_eth_dev *dev,
+   struct rte_flow *flow,
+   void *meta,
+   struct rte_flow_error *error)
+{
+   int ret = 0;
+   uint32_t cpq_id = 0;
+   struct cpfl_itf *itf = CPFL_DEV_TO_ITF(dev);
+   struct cpfl_adapter_ext *ad = itf->adapter;
+   struct cpfl_rule_info_meta *rim = meta;
+   struct cpfl_vport *vport;
+
+   if (!rim)
+   return ret;
+
+   if (itf->type == CPFL_ITF_TYPE_VPORT) {
+   vport = (struct cpfl_vport *)itf;
+   /* Every vport has one pair control queues configured to handle 
message.
+* Even index is tx queue and odd index is rx queue.
+*/
+   cpq_id = vport->base.devarg_id * 2;
+   } else {
+   rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, 
NULL,
+  "fail to find correct control queue");
+   return -rte_errno;
+   }
+
+   ret = cpfl_rule_process(itf, ad->ctlqp[cpq_id], ad->ctlqp[cpq_id + 1],
+   rim->rules, rim->rule_num, true);
+   if 

[PATCH v7 8/8] net/cpfl: add flow support for representor

[yuying . zhang]

From: Yuying Zhang 

Add flow support for representor, so representor can
create, destroy, validate and flush rules.

Signed-off-by: Yuying Zhang 
---
 doc/guides/nics/cpfl.rst| 19 +-
 doc/guides/rel_notes/release_23_11.rst  |  1 +
 drivers/net/cpfl/cpfl_flow_engine_fxp.c | 88 -
 drivers/net/cpfl/cpfl_representor.c | 29 
 4 files changed, 133 insertions(+), 4 deletions(-)

diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst
index e17347d15c..ee2fabd99c 100644
--- a/doc/guides/nics/cpfl.rst
+++ b/doc/guides/nics/cpfl.rst
@@ -197,8 +197,23 @@ low level hardware resources.
 
 * For Ubuntu, it can be installed using `apt install libjansson-dev`
 
-- run testpmd with the json file
+- run testpmd with the json file, create two vports and two VF representors
 
.. code-block:: console
 
-   dpdk-testpmd -c 0x3 -n 4 -a 
:af:00.6,vport=[0],flow_parser="refpkg.json" -- -i
+   dpdk-testpmd -c 0x3 -n 4 -a 
:af:00.6,vport=[0-1],representor=vf[0,1],flow_parser="refpkg.json" -- -i
+
+#. Create one flow to forward ETH-IPV4-TCP from I/O port to a local(CPF's) 
vport. Flow should be created on
+   vport X. Group M should match fxp module. Action port_representor Y means 
forward packet to local vport Y.
+   If want to send a packet to VF representor, action represented_port can be 
used::
+
+   .. code-block:: console
+
+   flow create X ingress group M pattern eth dst is 00:01:00:00:03:14 / ipv4 
src is 192.168.0.1 \
+   dst is 192.168.0.2 / tcp / end actions port_representor port_id Y / end
+
+#. Send a matched packet, and it should be displayed on PMD::
+
+   .. code-block:: console
+
+   
sendp(Ether(dst='00:01:00:00:03:14')/IP(src='192.168.0.1',dst='192.168.0.2')/TCP(),iface="ens25f0")
diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index 3d9be208d0..bad71ad3fd 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -81,6 +81,7 @@ New Features
 * **Updated Intel cpfl driver.**
 
   * Added support for port representor.
+  * Added support for rte_flow.
 
 Removed Items
 -
diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c 
b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
index 154af5bd35..fed18d8349 100644
--- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c
+++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
@@ -73,6 +73,7 @@ cpfl_fxp_create(struct rte_eth_dev *dev,
struct cpfl_adapter_ext *ad = itf->adapter;
struct cpfl_rule_info_meta *rim = meta;
struct cpfl_vport *vport;
+   struct cpfl_repr *repr;
 
if (!rim)
return ret;
@@ -83,6 +84,10 @@ cpfl_fxp_create(struct rte_eth_dev *dev,
 * Even index is tx queue and odd index is rx queue.
 */
cpq_id = vport->base.devarg_id * 2;
+   } else if (itf->type == CPFL_ITF_TYPE_REPRESENTOR) {
+   repr = (struct cpfl_repr *)itf;
+   cpq_id = ((repr->repr_id.pf_id  + repr->repr_id.vf_id) &
+ (CPFL_TX_CFGQ_NUM - 1)) * 2;
} else {
rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, 
NULL,
   "fail to find correct control queue");
@@ -122,6 +127,7 @@ cpfl_fxp_destroy(struct rte_eth_dev *dev,
struct cpfl_rule_info_meta *rim;
uint32_t i;
struct cpfl_vport *vport;
+   struct cpfl_repr *repr;
 
rim = flow->rule;
if (!rim) {
@@ -135,6 +141,10 @@ cpfl_fxp_destroy(struct rte_eth_dev *dev,
if (itf->type == CPFL_ITF_TYPE_VPORT) {
vport = (struct cpfl_vport *)itf;
cpq_id = vport->base.devarg_id * 2;
+   } else if (itf->type == CPFL_ITF_TYPE_REPRESENTOR) {
+   repr = (struct cpfl_repr *)itf;
+   cpq_id = ((repr->repr_id.pf_id  + repr->repr_id.vf_id) &
+ (CPFL_TX_CFGQ_NUM - 1)) * 2;
} else {
rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, 
NULL,
   "fail to find correct control queue");
@@ -257,6 +267,7 @@ cpfl_fxp_parse_action(struct cpfl_itf *itf,
int queue_id = -1;
bool fwd_vsi = false;
bool fwd_q = false;
+   bool is_vsi;
uint32_t i;
struct cpfl_rule_info *rinfo = &rim->rules[index];
union cpfl_action_set *act_set = (void *)rinfo->act_bytes;
@@ -267,6 +278,7 @@ cpfl_fxp_parse_action(struct cpfl_itf *itf,
action_type = action->type;
switch (action_type) {
case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR:
+   case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
if (!fwd_vsi)
fwd_vsi = true;
else
@@ -285,12 +297,20 @@ cpfl_fxp_parse_action(struct cpfl_itf *itf,
queue_id = CPFL_INVALID_QUEUE_ID;

[PATCH] gpu/cuda: Add missing stdlib include

[Aaron Conole]

From: John Romein 

getenv needs stdlib.h to be included.

Bugzilla ID: 1133

Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by: John Romein 
---
NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the
  mailing list.

 drivers/gpu/cuda/gdrcopy.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
index 322a5dbeb20..f19ad396f14 100644
--- a/drivers/gpu/cuda/gdrcopy.c
+++ b/drivers/gpu/cuda/gdrcopy.c
@@ -2,6 +2,8 @@
  * Copyright (c) 2022 NVIDIA Corporation & Affiliates
  */
 
+#include 
+
 #include "common.h"
 
 #ifdef DRIVERS_GPU_CUDA_GDRCOPY_H
---
2.40.1

Re: [PATCH v4 1/3] lib: introduce dispatcher library

[Jerin Jacob]

On Mon, Sep 25, 2023 at 12:41 PM Mattias Rönnblom  wrote:
>
> On 2023-09-22 09:38, Mattias Rönnblom wrote:
>
> 
>
> > +int
> > +rte_dispatcher_create(uint8_t id, uint8_t event_dev_id)
> > +{
>
>
> There are two changes I'm considering:
>
> 1) Removing the "id" to identify the dispatcher, replacing it with an
> forward-declared rte_dispatcher struct pointer.
>
> struct rte_dispatcher;
>
> struct rte_dispatcher *
> rte_dispatcher_create(uint8_t event_dev_id);
>
>
> The original reason for using an integer id to identify a dispatcher is
> to make it look like everything else in Eventdev. I find this pattern a
> little awkward to use - in particular the fact the id is
> application-allocated (and thus require coordination between different
> part of the application in case multiple instances are used).
>
> 2) Adding a flags field to the create function "for future use". But
> since the API is experimental, there may not be that much need to
> attempt to be future-proof?
>
> Any thoughts are appreciated.

IMO, better to have rte_dispatcher_create(struct
rte_dispatch_create_params *params)
for better future proofing with specific
rte_dispatch_crearte_params_init() API(No need to add reserved fields
in rte_dispatch_create_params  now, may need only for before removing
experimental status)

Just 2c.

>
> 

Re: [PATCH v7 1/8] net/cpfl: add json parser for rte flow pattern rules

[Stephen Hemminger]

On Tue, 26 Sep 2023 18:16:56 +
yuying.zh...@intel.com wrote:

> From: Wenjing Qiao 
> 
> Add devargs "flow_parser" for rte flow json parser which depends
> on jansson library.
> 
> Example:
> -a ca:00.0,flow_parser="refpkg.json"
> 
> Add json parser for rte flow pattern rules which can build rules
> that maps from a set of rte flow items to hardware representations.
> 
> The cpfl PMD supports utilizing a JSON configuration file to translate
> rte flow tokens into low level hardware resources. The JSON configuration
> file is provided by the hardware vendor and is intended to work exclusively
> with a specific P4 pipeline configuration, which must be compiled and
> programmed into the hardware.
> 
> The format of the JSON file strictly follows the internal specifications
> of the hardware vendor and is not meant to be modified directly by
> users.
> 
> Signed-off-by: Wenjing Qiao 

It is good to see the code is now using the same JSON parser as elsewhere in 
DPDK.

How does this interact with the P4 work done by Cristian, is this part of that?
Is this treated as opaque firmware?
Why is it driver specific? DPDK P4 support needs to be vendor neutral to 
acceptable.

Re: [PATCH v4] ethdev: advertise flow restore in mbuf

[Ilya Maximets]

On 9/26/23 11:17, David Marchand wrote:
> Hello Ilya,
> 
> On Mon, Jul 31, 2023 at 10:40 PM Ilya Maximets  wrote:
>> On 6/21/23 16:43, David Marchand wrote:
>>> As reported by Ilya [1], unconditionally calling
>>> rte_flow_get_restore_info() impacts an application performance for drivers
>>> that do not provide this ops.
>>> It could also impact processing of packets that require no call to
>>> rte_flow_get_restore_info() at all.
>>>
>>> Register a dynamic mbuf flag when an application negotiates tunnel
>>> metadata delivery (calling rte_eth_rx_metadata_negotiate() with
>>> RTE_ETH_RX_METADATA_TUNNEL_ID).
>>>
>>> Drivers then advertise that metadata can be extracted by setting this
>>> dynamic flag in each mbuf.
>>>
>>> The application then calls rte_flow_get_restore_info() only when required.
>>>
>>> Link: 
>>> http://inbox.dpdk.org/dev/5248c2ca-f2a6-3fb0-38b8-7f659bfa4...@ovn.org/
>>> Signed-off-by: David Marchand 
>>> Acked-by: Andrew Rybchenko 
>>> Acked-by: Viacheslav Ovsiienko 
>>> Tested-by: Ali Alnubani 
>>> Acked-by: Ori Kam 
>>> ---
>>> Changes since RFC v3:
>>> - rebased on next-net,
>>> - sending as non RFC for CIs that skip RFC patches,
>>>
>>> Changes since RFC v2:
>>> - fixed crash introduced in v2 and removed unneeded argument to
>>>   rte_flow_restore_info_dynflag_register(),
>>>
>>> Changes since RFC v1:
>>> - rebased,
>>> - updated vectorized datapath functions for net/mlx5,
>>> - moved dynamic flag register to rte_eth_rx_metadata_negotiate() and
>>>   hid rte_flow_restore_info_dynflag_register() into ethdev internals,
>>>
>>> ---
>>>  app/test-pmd/util.c  |  9 +++--
>>>  drivers/net/mlx5/mlx5.c  |  2 +
>>>  drivers/net/mlx5/mlx5.h  |  5 ++-
>>>  drivers/net/mlx5/mlx5_flow.c | 47 +---
>>>  drivers/net/mlx5/mlx5_rx.c   |  2 +-
>>>  drivers/net/mlx5/mlx5_rx.h   |  1 +
>>>  drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 16 
>>>  drivers/net/mlx5/mlx5_rxtx_vec_neon.h|  6 +--
>>>  drivers/net/mlx5/mlx5_rxtx_vec_sse.h |  6 +--
>>>  drivers/net/mlx5/mlx5_trigger.c  |  4 +-
>>>  drivers/net/sfc/sfc_dp.c | 14 +--
>>>  lib/ethdev/rte_ethdev.c  |  5 +++
>>>  lib/ethdev/rte_flow.c| 27 ++
>>>  lib/ethdev/rte_flow.h| 18 -
>>>  lib/ethdev/rte_flow_driver.h |  6 +++
>>>  lib/ethdev/version.map   |  1 +
>>>  16 files changed, 128 insertions(+), 41 deletions(-)
>>
>> 
>>
>>> diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h
>>> index 356b60f523..f9fb01b8a2 100644
>>> --- a/lib/ethdev/rte_flow_driver.h
>>> +++ b/lib/ethdev/rte_flow_driver.h
>>> @@ -376,6 +376,12 @@ struct rte_flow_ops {
>>>  const struct rte_flow_ops *
>>>  rte_flow_ops_get(uint16_t port_id, struct rte_flow_error *error);
>>>
>>> +/**
>>> + * Register mbuf dynamic flag for rte_flow_get_restore_info.
>>> + */
>>> +int
>>> +rte_flow_restore_info_dynflag_register(void);
>>> +
>>
>> Hi, David, others.
>>
>> Is there a reason to not expose this function to the application?
>>
>> The point is that application will likely want to know the value
>> of the flag before creating any devices.  I.e. request it once
>> and use for all devices later without performing a call to an
>> external library (DPDK).  In current implementation, application
>> will need to open some device first, and only then the result of
>> rte_flow_restore_info_dynflag() will become meaningful.
>>
>> There is no need to require application to call this function,
>> it can still be called from the rx negotiation API, but it would
>> be nice if application could know it beforehand, i.e. had control
>> over when the flag is actually becomes visible.
> 
> DPDK tries to register flags only when needed, as there is not a lot
> of space for dyn flags.
> Some drivers take some space and applications want some share too.
> 
> DPDK can export the _register function for applications to call it
> regardless of what driver will be used later.
> 
> Yet, I want to be sure why it matters in OVS context.
> Is it not enough resolving the flag (by calling
> rte_flow_restore_info_dynflag()) once rte_eth_rx_metadata_negotiate
> for tunnel metadata is called?
> Do you want to avoid an atomic store/load between OVS main thread and
> PMD threads?

Yeas, something like this.  I do not have a solid implementation idea
for that though.  I replied to your OVS patch.

Best regards, Ilya Maximets.

RE: [v1 1/6] crypto/openssl: include SM2 in asymmetric capabilities

[Kusztal, ArkadiuszX]

> -Original Message-
> From: Gowrishankar Muthukrishnan 
> Sent: Thursday, August 10, 2023 11:35 AM
> To: dev@dpdk.org
> Cc: ano...@marvell.com; Akhil Goyal ; Fan Zhang
> ; Ji, Kai ; Gowrishankar
> Muthukrishnan 
> Subject: [v1 1/6] crypto/openssl: include SM2 in asymmetric capabilities
> 
> Include SM2 algorithm in the asymmetric capabilities supported by OpenSSL
> PMD.
> 
> Fixes: 3b7d638fb11f ("crypto/openssl: support asymmetric SM2")
> 
> Signed-off-by: Gowrishankar Muthukrishnan 
> ---
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c | 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> index 85a4fa3e55..2eb450fcfd 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> +  (1 << RTE_CRYPTO_ASYM_OP_DECRYPT)),
> + }
> + }
> + }
> + },
> 
>   RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
>  };
> --
> 2.25.1

Acked-by: Arkadiusz Kusztal 

RE: [v1 2/6] cryptodev: add RNG capability in EC based xform

[Kusztal, ArkadiuszX]

> -Original Message-
> From: Gowrishankar Muthukrishnan 
> Sent: Thursday, August 10, 2023 11:35 AM
> To: dev@dpdk.org
> Cc: ano...@marvell.com; Akhil Goyal ; Fan Zhang
> ; Ji, Kai ; Gowrishankar
> Muthukrishnan 
> Subject: [v1 2/6] cryptodev: add RNG capability in EC based xform
> 
> 
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
> index 2eb450fcfd..0f88669f41 100644
>* Value 0 mean implementation default
>*/
> +
> + uint8_t internal_rng;
> + /**< Availability of random number generator for Elliptic curve
> based xform.
> +  * Value 0 means unavailable, and application should pass the
> required
> +  * random value. Otherwise, PMD would internally compute the
> random number.
> +  */
>   };
>  };
> 
> --
> 2.25.1

Acked-by: Arkadiusz Kusztal