[PATCH] common/idpf: fix Tx checksum offload
From: Beilei Xing
For multi-segment packets, the Tx checksum offload doesn't work
except the last segment, because other segments don't enable HW
checksum offload successfully.
Fixes: ef47d95e9031 ("net/idpf: fix TSO")
Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path")
Cc: sta...@dpdk.org
Signed-off-by: Beilei Xing
---
drivers/common/idpf/idpf_common_rxtx.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/common/idpf/idpf_common_rxtx.c
b/drivers/common/idpf/idpf_common_rxtx.c
index e6d2486272..83b131ef28 100644
--- a/drivers/common/idpf/idpf_common_rxtx.c
+++ b/drivers/common/idpf/idpf_common_rxtx.c
@@ -871,6 +871,7 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
uint16_t nb_to_clean;
uint16_t nb_tx = 0;
uint64_t ol_flags;
+ uint8_t cmd_dtype;
uint16_t nb_ctx;
if (unlikely(txq == NULL) || unlikely(!txq->q_started))
@@ -902,6 +903,7 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
if (txq->nb_free < tx_pkt->nb_segs)
break;
+ cmd_dtype = 0;
ol_flags = tx_pkt->ol_flags;
tx_offload.l2_len = tx_pkt->l2_len;
tx_offload.l3_len = tx_pkt->l3_len;
@@ -911,6 +913,9 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
nb_ctx = idpf_calc_context_desc(ol_flags);
nb_used = tx_pkt->nb_segs + nb_ctx;
+ if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK)
+ cmd_dtype = IDPF_TXD_FLEX_FLOW_CMD_CS_EN;
+
/* context descriptor */
if (nb_ctx != 0) {
volatile union idpf_flex_tx_ctx_desc *ctx_desc =
@@ -933,8 +938,8 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
/* Setup TX descriptor */
txd->buf_addr =
rte_cpu_to_le_64(rte_mbuf_data_iova(tx_pkt));
- txd->qw1.cmd_dtype =
-
rte_cpu_to_le_16(IDPF_TX_DESC_DTYPE_FLEX_FLOW_SCHE);
+ cmd_dtype |= IDPF_TX_DESC_DTYPE_FLEX_FLOW_SCHE;
+ txd->qw1.cmd_dtype = cmd_dtype;
txd->qw1.rxr_bufsize = tx_pkt->data_len;
txd->qw1.compl_tag = sw_id;
tx_id++;
@@ -948,8 +953,6 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
/* fill the last descriptor with End of Packet (EOP) bit */
txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_EOP;
- if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK)
- txd->qw1.cmd_dtype |= IDPF_TXD_FLEX_FLOW_CMD_CS_EN;
txq->nb_free = (uint16_t)(txq->nb_free - nb_used);
txq->nb_used = (uint16_t)(txq->nb_used + nb_used);
@@ -1424,6 +1427,9 @@ idpf_dp_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
}
}
+ if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK)
+ td_cmd |= IDPF_TX_FLEX_DESC_CMD_CS_EN;
+
if (nb_ctx != 0) {
/* Setup TX context descriptor if required */
volatile union idpf_flex_tx_ctx_desc *ctx_txd =
@@ -1487,9 +1493,6 @@ idpf_dp_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
txq->nb_used = 0;
}
- if (ol_flags & IDPF_TX_CKSUM_OFFLOAD_MASK)
- td_cmd |= IDPF_TX_FLEX_DESC_CMD_CS_EN;
-
txd->qw1 |= rte_cpu_to_le_16(td_cmd << IDPF_TXD_QW1_CMD_S);
}
--
2.34.1
[PATCH v4 0/3] Add dispatcher library
The purpose of the dispatcher library is to decouple different parts of an eventdev-based application (e.g., processing pipeline stages), sharing the same underlying event device. The dispatcher replaces the conditional logic (often, a switch statement) that typically follows an event device dequeue operation, where events are dispatched to different parts of the application based on event meta data, such as the queue id or scheduling type. The concept is similar to a UNIX file descriptor event loop library. Instead of tying callback functions to fds as for example libevent does, the dispatcher relies on application-supplied matching callback functions to decide where to deliver events. A dispatcher is configured to dequeue events from a specific event device, and ties into the service core framework, to do its (and the application's) work. The dispatcher provides a convenient way for an eventdev-based application to use service cores for application-level processing, and thus for sharing those cores with other DPDK services. Although the dispatcher adds some overhead, experience suggests that the net effect on the application (both synthetic benchmarks and more real-world applications) may well be positive. This is primarily due to clustering (see programming guide) reducing cache misses. Benchmarking indicates that the overhead is ~10 cc/event (on a large core), with a handful of often-used handlers. The dispatcher does not support run-time reconfiguration. The use of the dispatcher library is optional, and an eventdev-based application may still opt to access the event device using direct eventdev API calls, or by some other means. Mattias Rönnblom (3): lib: introduce dispatcher library test: add dispatcher test suite doc: add dispatcher programming guide MAINTAINERS |5 + app/test/meson.build |1 + app/test/test_dispatcher.c | 1054 ++ doc/api/doxy-api-index.md|1 + doc/api/doxy-api.conf.in |1 + doc/guides/prog_guide/dispatcher_lib.rst | 434 + doc/guides/prog_guide/index.rst |1 + lib/dispatcher/meson.build | 17 + lib/dispatcher/rte_dispatcher.c | 798 lib/dispatcher/rte_dispatcher.h | 484 ++ lib/dispatcher/version.map | 20 + lib/meson.build |2 + 12 files changed, 2818 insertions(+) create mode 100644 app/test/test_dispatcher.c create mode 100644 doc/guides/prog_guide/dispatcher_lib.rst create mode 100644 lib/dispatcher/meson.build create mode 100644 lib/dispatcher/rte_dispatcher.c create mode 100644 lib/dispatcher/rte_dispatcher.h create mode 100644 lib/dispatcher/version.map -- 2.34.1
[PATCH v4 1/3] lib: introduce dispatcher library
The purpose of the dispatcher library is to help reduce coupling in an Eventdev-based DPDK application. In addition, the dispatcher also provides a convenient and flexible way for the application to use service cores for application-level processing. Signed-off-by: Mattias Rönnblom Tested-by: Peter Nilsson Reviewed-by: Heng Wang -- PATCH v4: o Fix bugs in handler and finalizer unregistration. (Naga Harish) o Return -EINVAL in cases where NULL pointers were provided in calls requiring non-NULL pointers. (Naga Harish) o Add experimental warning for the whole API. (Jerin Jacob) PATCH v3: o To underline its optional character and since it does not provide hardware abstraction, the event dispatcher is now a separate library. o Change name from rte_event_dispatcher -> rte_dispatcher, to make it shorter and to avoid the rte_event_* namespace. PATCH v2: o Add dequeue batch count statistic. o Add statistics reset function to API. o Clarify MT safety guarantees (or lack thereof) in the API documentation. o Change loop variable type in evd_lcore_get_handler_by_id() to uint16_t, to be consistent with similar loops elsewhere in the dispatcher. o Fix variable names in finalizer unregister function. PATCH: o Change prefix from RED to EVD, to avoid confusion with random early detection. RFC v4: o Move handlers to per-lcore data structures. o Introduce mechanism which rearranges handlers so that often-used handlers tend to be tried first. o Terminate dispatch loop in case all events are delivered. o To avoid the dispatcher's service function hogging the CPU, process only one batch per call. o Have service function return -EAGAIN if no work is performed. o Events delivered in the process function is no longer marked 'const', since modifying them may be useful for the application and cause no difficulties for the dispatcher. o Various minor API documentation improvements. RFC v3: o Add stats_get() function to the version.map file. --- MAINTAINERS | 3 + doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in| 1 + lib/dispatcher/meson.build | 17 + lib/dispatcher/rte_dispatcher.c | 798 lib/dispatcher/rte_dispatcher.h | 484 +++ lib/dispatcher/version.map | 20 + lib/meson.build | 2 + 8 files changed, 1326 insertions(+) create mode 100644 lib/dispatcher/meson.build create mode 100644 lib/dispatcher/rte_dispatcher.c create mode 100644 lib/dispatcher/rte_dispatcher.h create mode 100644 lib/dispatcher/version.map diff --git a/MAINTAINERS b/MAINTAINERS index a926155f26..6704cd5b2c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1726,6 +1726,9 @@ M: Nithin Dabilpuram M: Pavan Nikhilesh F: lib/node/ +Dispatcher - EXPERIMENTAL +M: Mattias Rönnblom +F: lib/dispatcher/ Test Applications - diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index fdeda13932..7d0cad9fed 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -155,6 +155,7 @@ The public API headers are grouped by topics: - **classification** [reorder](@ref rte_reorder.h), + [dispatcher](@ref rte_dispatcher.h), [distributor](@ref rte_distributor.h), [EFD](@ref rte_efd.h), [ACL](@ref rte_acl.h), diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index a88accd907..59c679e621 100644 --- a/doc/api/doxy-api.conf.in +++ b/doc/api/doxy-api.conf.in @@ -34,6 +34,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ @TOPDIR@/lib/cmdline \ @TOPDIR@/lib/compressdev \ @TOPDIR@/lib/cryptodev \ + @TOPDIR@/lib/dispatcher \ @TOPDIR@/lib/distributor \ @TOPDIR@/lib/dmadev \ @TOPDIR@/lib/efd \ diff --git a/lib/dispatcher/meson.build b/lib/dispatcher/meson.build new file mode 100644 index 00..c6054a3a5d --- /dev/null +++ b/lib/dispatcher/meson.build @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2023 Ericsson AB + +if is_windows +build = false +reason = 'not supported on Windows' +subdir_done() +endif + +sources = files( +'rte_dispatcher.c', +) +headers = files( +'rte_dispatcher.h', +) + +deps += ['eventdev'] diff --git a/lib/dispatcher/rte_dispatcher.c b/lib/dispatcher/rte_dispatcher.c new file mode 100644 index 00..3a5a40502f --- /dev/null +++ b/lib/dispatcher/rte_dispatcher.c @@ -0,0 +1,798 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2023 Ericsson AB + */ + +#include +#include + +#include +#include +#include +#include +#include + +#include "eventdev_pmd.h" + +#include + +#define EVD_MAX_PORTS_PER_LCORE 4 +#define EVD_MAX_HANDLERS 32 +#define EVD_MAX_FINALIZERS 16 +#define EVD_AVG_PRIO_INTERVAL 2000 + +struct rte_dispatcher_
[PATCH v4 3/3] doc: add dispatcher programming guide
Provide programming guide for the dispatcher library.
Signed-off-by: Mattias Rönnblom
--
PATCH v3:
o Adapt guide to the dispatcher API name changes.
PATCH:
o Improve grammar and spelling.
RFC v4:
o Extend event matching section of the programming guide.
o Improve grammar and spelling.
---
MAINTAINERS | 1 +
doc/guides/prog_guide/dispatcher_lib.rst | 434 +++
doc/guides/prog_guide/index.rst | 1 +
3 files changed, 436 insertions(+)
create mode 100644 doc/guides/prog_guide/dispatcher_lib.rst
diff --git a/MAINTAINERS b/MAINTAINERS
index 43890cad0e..ab35498204 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1730,6 +1730,7 @@ Dispatcher - EXPERIMENTAL
M: Mattias Rönnblom
F: lib/dispatcher/
F: app/test/test_dispatcher.c
+F: doc/guides/prog_guide/dispatcher_lib.rst
Test Applications
-
diff --git a/doc/guides/prog_guide/dispatcher_lib.rst
b/doc/guides/prog_guide/dispatcher_lib.rst
new file mode 100644
index 00..d4f29ce7ba
--- /dev/null
+++ b/doc/guides/prog_guide/dispatcher_lib.rst
@@ -0,0 +1,434 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2023 Ericsson AB.
+
+Dispatcher
+==
+
+Overview
+
+
+The purpose of the dispatcher is to help reduce coupling in an
+:doc:`Eventdev `-based DPDK application.
+
+In particular, the dispatcher addresses a scenario where an
+application's modules share the same event device and event device
+ports, and performs work on the same lcore threads.
+
+The dispatcher replaces the conditional logic that follows an event
+device dequeue operation, where events are dispatched to different
+parts of the application, typically based on fields in the
+``rte_event``, such as the ``queue_id``, ``sub_event_type``, or
+``sched_type``.
+
+Below is an excerpt from a fictitious application consisting of two
+modules; A and B. In this example, event-to-module routing is based
+purely on queue id, where module A expects all events to a certain
+queue id, and module B two other queue ids. [#Mapping]_
+
+.. code-block:: c
+
+for (;;) {
+struct rte_event events[MAX_BURST];
+unsigned int n;
+
+n = rte_event_dequeue_burst(dev_id, port_id, events,
+ MAX_BURST, 0);
+
+for (i = 0; i < n; i++) {
+const struct rte_event *event = &events[i];
+
+switch (event->queue_id) {
+case MODULE_A_QUEUE_ID:
+module_a_process(event);
+break;
+case MODULE_B_STAGE_0_QUEUE_ID:
+module_b_process_stage_0(event);
+break;
+case MODULE_B_STAGE_1_QUEUE_ID:
+module_b_process_stage_1(event);
+break;
+}
+}
+}
+
+The issue this example attempts to illustrate is that the centralized
+conditional logic has knowledge of things that should be private to
+the modules. In other words, this pattern leads to a violation of
+module encapsulation.
+
+The shared conditional logic contains explicit knowledge about what
+events should go where. In case, for example, the
+``module_a_process()`` is broken into two processing stages — a
+module-internal affair — the shared conditional code must be updated
+to reflect this change.
+
+The centralized event routing code becomes an issue in larger
+applications, where modules are developed by different organizations.
+This pattern also makes module reuse across different application more
+difficult. The part of the conditional logic relevant for a particular
+application may need to be duplicated across many module
+instantiations (e.g., applications and test setups).
+
+The dispatcher separates the mechanism (routing events to their
+receiver) from the policy (which events should go where).
+
+The basic operation of the dispatcher is as follows:
+
+* Dequeue a batch of events from the event device.
+* For each event determine which handler should receive the event, using
+ a set of application-provided, per-handler event matching callback
+ functions.
+* Provide events matching a particular handler, to that handler, using
+ its process callback.
+
+If the above application would have made use of the dispatcher, the
+code relevant for its module A may have looked something like this:
+
+.. code-block:: c
+
+static bool
+module_a_match(const struct rte_event *event, void *cb_data)
+{
+ return event->queue_id == MODULE_A_QUEUE_ID;
+}
+
+static void
+module_a_process_events(uint8_t event_dev_id, uint8_t event_port_id,
+const struct rte_event *events,
+ uint16_t num, void *cb_data)
+{
+uint16_t i;
+
+for (i = 0; i < num; i++)
+module_a
[PATCH v4 2/3] test: add dispatcher test suite
Add unit tests for the dispatcher.
--
PATCH v3:
o Adapt the test suite to dispatcher API name changes.
PATCH v2:
o Test finalize callback functionality.
o Test handler and finalizer count upper limits.
o Add statistics reset test.
o Make sure dispatcher supply the proper event dev id and port id back
to the application.
PATCH:
o Extend test to cover often-used handler optimization feature.
RFC v4:
o Adapt to non-const events in process function prototype.
Signed-off-by: Mattias Rönnblom
---
MAINTAINERS|1 +
app/test/meson.build |1 +
app/test/test_dispatcher.c | 1054
3 files changed, 1056 insertions(+)
create mode 100644 app/test/test_dispatcher.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 6704cd5b2c..43890cad0e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1729,6 +1729,7 @@ F: lib/node/
Dispatcher - EXPERIMENTAL
M: Mattias Rönnblom
F: lib/dispatcher/
+F: app/test/test_dispatcher.c
Test Applications
-
diff --git a/app/test/meson.build b/app/test/meson.build
index 05bae9216d..3303c73817 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -55,6 +55,7 @@ source_file_deps = {
'test_cycles.c': [],
'test_debug.c': [],
'test_devargs.c': ['kvargs'],
+'test_dispatcher.c': ['dispatcher'],
'test_distributor.c': ['distributor'],
'test_distributor_perf.c': ['distributor'],
'test_dmadev.c': ['dmadev', 'bus_vdev'],
diff --git a/app/test/test_dispatcher.c b/app/test/test_dispatcher.c
new file mode 100644
index 00..b64103c48e
--- /dev/null
+++ b/app/test/test_dispatcher.c
@@ -0,0 +1,1054 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Ericsson AB
+ */
+
+#include "test.h"
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#define NUM_WORKERS 3
+
+#define NUM_PORTS (NUM_WORKERS + 1)
+#define WORKER_PORT_ID(worker_idx) (worker_idx)
+#define DRIVER_PORT_ID (NUM_PORTS - 1)
+
+#define NUM_SERVICE_CORES NUM_WORKERS
+
+/* Eventdev */
+#define NUM_QUEUES 8
+#define LAST_QUEUE_ID (NUM_QUEUES - 1)
+#define MAX_EVENTS 4096
+#define NEW_EVENT_THRESHOLD (MAX_EVENTS / 2)
+#define DEQUEUE_BURST_SIZE 32
+#define ENQUEUE_BURST_SIZE 32
+
+#define NUM_EVENTS 1000
+#define NUM_FLOWS 16
+
+#define DSW_VDEV "event_dsw0"
+
+struct app_queue {
+ uint8_t queue_id;
+ uint64_t sn[NUM_FLOWS];
+ int dispatcher_reg_id;
+};
+
+struct cb_count {
+ uint8_t expected_event_dev_id;
+ uint8_t expected_event_port_id[RTE_MAX_LCORE];
+ atomic_int count;
+};
+
+struct test_app {
+ uint8_t event_dev_id;
+ uint8_t dispatcher_id;
+ uint32_t dispatcher_service_id;
+
+ unsigned int service_lcores[NUM_SERVICE_CORES];
+
+ int never_match_reg_id;
+ uint64_t never_match_count;
+ struct cb_count never_process_count;
+
+ struct app_queue queues[NUM_QUEUES];
+
+ int finalize_reg_id;
+ struct cb_count finalize_count;
+
+ bool running;
+
+ atomic_int completed_events;
+ atomic_int errors;
+};
+
+#define RETURN_ON_ERROR(rc) \
+ do {\
+ if (rc != TEST_SUCCESS) \
+ return rc; \
+ } while (0)
+
+static struct test_app *
+test_app_create(void)
+{
+ int i;
+ struct test_app *app;
+
+ app = calloc(1, sizeof(struct test_app));
+
+ if (app == NULL)
+ return NULL;
+
+ for (i = 0; i < NUM_QUEUES; i++)
+ app->queues[i].queue_id = i;
+
+ return app;
+}
+
+static void
+test_app_free(struct test_app *app)
+{
+ free(app);
+}
+
+static int
+test_app_create_vdev(struct test_app *app)
+{
+ int rc;
+
+ rc = rte_vdev_init(DSW_VDEV, NULL);
+ if (rc < 0)
+ return TEST_SKIPPED;
+
+ rc = rte_event_dev_get_dev_id(DSW_VDEV);
+
+ app->event_dev_id = (uint8_t)rc;
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_app_destroy_vdev(struct test_app *app)
+{
+ int rc;
+
+ rc = rte_event_dev_close(app->event_dev_id);
+ TEST_ASSERT_SUCCESS(rc, "Error while closing event device");
+
+ rc = rte_vdev_uninit(DSW_VDEV);
+ TEST_ASSERT_SUCCESS(rc, "Error while uninitializing virtual device");
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_app_setup_event_dev(struct test_app *app)
+{
+ int rc;
+ int i;
+
+ rc = test_app_create_vdev(app);
+ if (rc < 0)
+ return rc;
+
+ struct rte_event_dev_config config = {
+ .nb_event_queues = NUM_QUEUES,
+ .nb_event_ports = NUM_PORTS,
+ .nb_events_limit = MAX_EVENTS,
+ .nb_event_queue_flows = 64,
+ .nb_event_port_dequeue_depth = DEQUEUE_BURST_SIZE,
+ .nb_event_port_enqueue_depth = ENQUEUE_BURST_SIZE
+ };
+
+ rc = rte_event_dev_configure(app->event_dev_id, &config);
+
+
[PATCH] eal/unix: enhance error reporting for firmware
Put more details if a libarchive context initialisation fails.
Signed-off-by: David Marchand
---
lib/eal/unix/eal_firmware.c | 37 ++---
1 file changed, 30 insertions(+), 7 deletions(-)
diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
index d1616b0bd9..80aaadacf1 100644
--- a/lib/eal/unix/eal_firmware.c
+++ b/lib/eal/unix/eal_firmware.c
@@ -25,19 +25,42 @@ static int
firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t
blocksize)
{
struct archive_entry *e;
+ int err;
ctx->a = archive_read_new();
if (ctx->a == NULL)
return -1;
- if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
- archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||
- archive_read_open_filename(ctx->a, name, blocksize) !=
ARCHIVE_OK ||
- archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
- archive_read_free(ctx->a);
- ctx->a = NULL;
- return -1;
+ err = archive_read_support_format_raw(ctx->a);
+ if (err != ARCHIVE_OK) {
+ RTE_LOG(ERR, EAL, "archive_read_support_format_raw() failed
with %d: %s\n",
+ err, archive_error_string(ctx->a));
+ goto err;
+ }
+ err = archive_read_support_filter_xz(ctx->a);
+ if (err != ARCHIVE_OK) {
+ RTE_LOG(ERR, EAL, "archive_read_support_filter_xz() failed with
%d: %s\n",
+ err, archive_error_string(ctx->a));
+ goto err;
+ }
+ err = archive_read_open_filename(ctx->a, name, blocksize);
+ if (err != ARCHIVE_OK) {
+ RTE_LOG(ERR, EAL, "archive_read_open_filename() failed with %d:
%s\n",
+ err, archive_error_string(ctx->a));
+ goto err;
+ }
+ err = archive_read_next_header(ctx->a, &e);
+ if (err != ARCHIVE_OK) {
+ RTE_LOG(ERR, EAL, "archive_read_next_header() failed with %d:
%s\n",
+ err, archive_error_string(ctx->a));
+ goto err;
}
+
return 0;
+
+err:
+ archive_read_free(ctx->a);
+ ctx->a = NULL;
+ return -1;
}
static ssize_t
--
2.41.0
Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read
Hello,
On Fri, Sep 22, 2023 at 5:59 AM Srikanth Yalavarthi
wrote:
> > From: David Marchand
> > On Thu, Sep 21, 2023 at 3:06 PM Srikanth Yalavarthi
> > wrote:
> > > > > > archive. This causes the ML firmware binary to be parsed
> > > > > > incorrectly.
> > > > >
> > > > > + @David Marchand rte_firmware_read() author for his opinions
> > > >
> > > > /lib/firmware/mlip-fw.bin does not seem to be something packaged in
> > > > Fedora, and I found no trace in linux-firmware repo, so I can't
> > > > reproduce your issue.
> > > >
> > > > Please add some debug and give more details about the issue you are
> > facing.
> > >
> > > The "/lib/firmware/mlip-fw.bin" is Marvell's ML firmware binary. This
> > > file is
> > in un-compressed form.
> > >
> > > When DPDK is built without libarchive support, No issues are observed with
> > using rte_firmware_read to load the firmware file as open and read system
> > calls are used.
> > >
> > > When libarchive support is enabled, rte_firmware_read tries to parse the
> > firmware binary as an xz archive. Since the file is not an archive, this
> > step is
> > failing.
> >
> > Please debug this part and point at the exact place where it fails.
>
> When compiled with libarchive support, the code fails in firmware_open
> (lib/eal/unix/eal_firmware.c:24) function
>
> if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
"""
archive_read_support_format_raw()
The “raw” format handler allows libarchive to be used to
read arbitrary data. It treats any data stream as an archive with a
single entry. The pathname of this entry is “data”; all other entry
fields are unset. This
is not enabled by archive_read_support_format_all() in
order to avoid erroneous handling of damaged archives.
"""
Which means that this instance of libarchive accepts "raw" archive.
> archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK
> ||
"""
archive_read_support_filter_bzip2(),
archive_read_support_filter_compress(),
archive_read_support_filter_grzip(),
archive_read_support_filter_gzip(),
archive_read_support_filter_lrzip(),
archive_read_support_filter_lz4(),
archive_read_support_filter_lzma(),
archive_read_support_filter_lzop(),
archive_read_support_filter_none(), archive_read_support_filter_rpm(),
archive_read_support_filter_uu(), archive_read_support_filter_xz(),
archive_read_support_filter_zstd(),
Enables auto-detection code and decompression support for
the specified compression. These functions may fall back on external
programs if an appropriate library was not available at build time.
Decompression using an
external program is usually slower than decompression
through built-in libraries. Note that “none” is always enabled by
default.
"""
Which means that this instance of libarchive accepts xz compressed
files, and uncompressed files too because the "none" filter is enabled
by default.
> archive_read_open_filename(ctx->a, name, blocksize)
> != ARCHIVE_OK ||
> archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
> archive_read_free(ctx->a);
> ctx->a = NULL;
> return -1;
> }
>
> I understand that all of the 4 checks in the if condition assume that the
> file is a compressed archive. i.e, they look for relevant metadata of a
> compressed archive.
I had double checked before replying last time, it works as I
described with my fedora libarchive.
> All 4 checks were failing when the file being read is a single uncompressed
> file (as in our case).
o_O
Did you check that all 4 checks are failing individually or are you
saying this 4 tests fail as a whole?
I have one suspicion on archive_read_support_filter_xz, which may
return ARCHIVE_WARN.
But that's my only serious hint so far.
I have put up some debug patch, please have a try with it.
https://patchwork.dpdk.org/project/dpdk/patch/20230922080606.905222-1-david.march...@redhat.com/
--
David Marchand
Re: [PATCH] eal: fix modify data area after memset
ping
Fengnan Chang 于2023年9月12日周二 17:05写道：
>
> Let's look at this path:
> malloc_elem_free
>->malloc_elem_join_adjacent_free
> ->join_elem(elem, elem->next)
>
> 0. cur elem's pad > 0
> 1. data area memset in malloc_elem_free first.
> 2. next elem is free, try to join cur elem and next.
> 3. in join_elem, try to modify inner->size, this address had
> memset in step 1, it casue the content of addrees become non-zero.
>
> If user call rte_zmalloc, and pick this elem, it can't get all
> zero'd memory.
>
> Fixes: 2808a12cc053 (malloc: fix memory element size in case of padding)
> Signed-off-by: Fengnan Chang
> ---
> lib/eal/common/malloc_elem.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c
> index 619c040aa3..93a23fa8d4 100644
> --- a/lib/eal/common/malloc_elem.c
> +++ b/lib/eal/common/malloc_elem.c
> @@ -492,7 +492,7 @@ malloc_elem_alloc(struct malloc_elem *elem, size_t size,
> unsigned align,
> * be contiguous in memory.
> */
> static inline void
> -join_elem(struct malloc_elem *elem1, struct malloc_elem *elem2)
> +join_elem(struct malloc_elem *elem1, struct malloc_elem *elem2, bool
> update_inner)
> {
> struct malloc_elem *next = elem2->next;
> elem1->size += elem2->size;
> @@ -502,7 +502,7 @@ join_elem(struct malloc_elem *elem1, struct malloc_elem
> *elem2)
> elem1->heap->last = elem1;
> elem1->next = next;
> elem1->dirty |= elem2->dirty;
> - if (elem1->pad) {
> + if (elem1->pad && update_inner) {
> struct malloc_elem *inner = RTE_PTR_ADD(elem1, elem1->pad);
> inner->size = elem1->size - elem1->pad;
> }
> @@ -526,7 +526,7 @@ malloc_elem_join_adjacent_free(struct malloc_elem *elem)
>
> /* remove from free list, join to this one */
> malloc_elem_free_list_remove(elem->next);
> - join_elem(elem, elem->next);
> + join_elem(elem, elem->next, false);
>
> /* erase header, trailer and pad */
> memset(erase, MALLOC_POISON, erase_len);
> @@ -550,7 +550,7 @@ malloc_elem_join_adjacent_free(struct malloc_elem *elem)
> malloc_elem_free_list_remove(elem->prev);
>
> new_elem = elem->prev;
> - join_elem(new_elem, elem);
> + join_elem(new_elem, elem, false);
>
> /* erase header, trailer and pad */
> memset(erase, MALLOC_POISON, erase_len);
> @@ -683,7 +683,7 @@ malloc_elem_resize(struct malloc_elem *elem, size_t size)
> * join the two
> */
> malloc_elem_free_list_remove(elem->next);
> - join_elem(elem, elem->next);
> + join_elem(elem, elem->next, true);
>
> if (elem->size - new_size >= MIN_DATA_SIZE + MALLOC_ELEM_OVERHEAD) {
> /* now we have a big block together. Lets cut it down a bit,
> by splitting */
> --
> 2.20.1
>
Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info
Hi Nicolas,
On 9/19/23 22:51, Chautru, Nicolas wrote:
Hi Maxime,
This is neither part of 3GPP per se, nor specific to VRB device. Let me provide
more context.
The SRS processing chain
(https://doc.dpdk.org/guides/prog_guide/bbdev.html#bbdev-fft-operation)
includes a pointwise multiplication by time window.
The generic API include some control of these windowing function but still the
actual shape need to be programmed onto any device (ie. rectangular, taped,
sinc, different width or offset, any abritraty shape defined as an array of
scalars). These degrees of liberties cannot be exposed through a generic API
(information is multi-kB, ie the data itself) and can be user specific
(external to the HW IP itself or outside of Intel control).
Thanks for the explanations. I also did my homework as my FFT knowledge
was buried quite deep in my memory. :)
So this is a vendor-specific way to express generic paramaters.
Regarding VRB device, is this table per device or per VF?
Could it be configured by the application directly, or has it to be done
through the PF?
As an illustration for VRB device pf_bb_config provides to user an option to include such
windowing data as an input ("FFT LUT bin file"), but more generally at platform
level for any bb device this big Look-Up Table or big array can be configured on the host
during platform initialization for a given deployment or vendor.
What is required here is for the user application to have knowledge of what
version of such array is being used on the given platform, as this information
would be relevant to processing done outside of bbdev (notably for noise
estimate). Through that mechanism, the user can now map through that API which
possible file was being used, and act accordingly.
The content itself is not specified, for VRB we just use the md5sum of that
binary file (which is just a big array of int16 for point wise multiplication)
so that this can be used to share knowledge between initialized platform
configuration and at run-time user application assumption.
It is also important to under that the user/vendor may use any array or shape
(based on their algorithm) regardless of Intel or IP, and still be able to
share information mapping between what is configured on the platform (multiple
versions possible) and what the application enumerates.
I can add more details in the documentation indeed but above should arguably
make sense. The name FFT_version naming may be quite vague, this is more
related to the FFT pointwise windowing array variant assumed on the platform. I
did not want to impose for it to be an md5sum necessarily, hence the vagueness,
as it could be any hash shared between the device programming and the user
application related to the semi-static FFT processing programming.
Let me know if unclear or if any other thought,
I think this is clear now to me.
In my opinion, this is not good to have this part of the BBDEV API, as
every vendor will have their own way to represent this.
Other alternative is to have a vendor specific API. This is far from
ideal and should be avoided as much as possible, but in this case the
application has to know anyways which device it is driving. It would be
at least clear the field has to be interpreted in a vendor-specific way.
@Hemant, I would be interested in your opinion. (I don't know if NXP has
or plans to have FFT accelerator IP)
Regards,
Maxime
Thanks
Nic
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, September 19, 2023 2:56 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info
On 9/19/23 03:21, Nicolas Chautru wrote:
This can be used to distinguish different version of the flexible
pointwise windowing applied to the FFT and expose this to the
application.
Does this version relates to a standard, or is this specific to the
implementation of your VRB devices?
Signed-off-by: Nicolas Chautru
---
lib/bbdev/rte_bbdev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index
a5bcc09f10..d6e54ee9a4 100644
--- a/lib/bbdev/rte_bbdev.h
+++ b/lib/bbdev/rte_bbdev.h
@@ -349,6 +349,8 @@ struct rte_bbdev_driver_info {
const struct rte_bbdev_op_cap *capabilities;
/** Device cpu_flag requirements */
const enum rte_cpu_flag_t *cpu_flag_reqs;
+ /** Versioning number for the FFT operation type. */
+ uint16_t fft_version;
};
/** Macro used at end of bbdev PMD list */
[RFC PATCH 0/5] Using shared mempools for zero-copy IO proxying
Following my talk at the recent DPDK Summit [1], here is an RFC patchset containing the prototypes I created which led to the talk. This patchset is simply to demonstrate: * what is currently possible with DPDK in terms of zero-copy IPC * where the big gaps, and general problem areas are * what the performance is like doing zero-copy between processes * how we may look to have new deployment models for DPDK apps. This cover letter is quite long, as it covers how to run the demo app and use the drivers included in this set. I felt it more accessible this way than putting it in rst files in the patches. This patchset depends upon patchsets [2] and [3] [1] https://dpdksummit2023.sched.com/event/1P9wU [2] http://patches.dpdk.org/project/dpdk/list/?series=29536 [3] http://patches.dpdk.org/project/dpdk/list/?series=29538 Overview The patchset contains at a high level the following parts: a proxy application which performs packet IO and steers traffic on a per-queue basis to other applications which connect to it via unix sockets, and a set of drivers to be used by those applications so that they can (hopefully) receive packets from the proxy app without any changes to their own code. This all helps to demonstrate the feasibility of zero- copy packet transfer between independent DPDK apps. The drivers are: * a bus driver, which makes the connection to the proxy app via the unix socket. Thereafter it accepts the shared memory from the proxy and maps it into the running process for use for buffers and rings etc. It also handled communication with the proxy app on behalf of the other two drivers * a mempool driver, which simply manages a set of buffers on the basis of offsets within the shared memory area rather than using pointers. The big downside of its use is that it assumes all the objects stored in the mempool are mbufs. (As described in my talk, this is a big issue where I'm not sure we have a good solution available right now to resolve it) * an ethernet driver, which creates an rx and tx ring in shared memory for use in communicating with the proxy app. All buffers sent/received are converted to offsets within the shared memory area. The proxy app itself implements all the other logic - mostly inside datapath.c - to allow the connecting app to run. When an app connects to the unix socket, the proxy app uses memfd to create a hugepage block to be passed through to the "guest" app, and then sends/receives the messages from the drivers until the app connection is up and running to handle traffic. [Ideally, this IPC over unix socket mechanism should probably be generalized into a library used by the app, but for now it's just built-in]. As stated above, the steering of traffic is done per-queue, that is, each app connects to a specific socket corresponding to a NIC queue. For demo purposes, the traffic to the queues is just distributed using RSS, but obviously it would be possible to use e.g. rte_flow to do more interesting distribution in future. Running the Apps To get things all working just do a DPDK build as normal. Then run the io-proxy app. It only takes a single parameter of the core number to use. For example, on my system I run it on lcore 25: ./build/app/dpdk-io-proxy 25 The sockets to be created and how they map to ports/queues is controlled via commandline, but a startup script can be provided, which just needs to be in the current directory and name "dpdk-io-proxy.cmds". Patch 5 of this set contains an example setup that I use. Therefore it's recommended that you run the proxy app from a directory containing that file. If so, the proxy app will use two ports and create two queues on each, mapping them to 4 unix socket files in /tmp. (Each socket is created in its own directory to simplify use with docker containers as described below in next section). No traffic is handled by the app until other end-user apps connect to it. Testpmd works as that second "guest" app without any changes to it. To run multiple testpmd instances, each taking traffic from a unique RX queue and forwarding it back, the following sequence of commands can be used [in this case, doing forwarding on cores 26 through 29, and using the 4 unix sockets configured using the startup file referenced above]. ./build/app/dpdk-testpmd -l 24,26 --no-huge -m1 --no-shconf \ -a sock:/tmp/socket_0_0/sock -- --forward-mode=macswap ./build/app/dpdk-testpmd -l 24,27 --no-huge -m1 --no-shconf \ -a sock:/tmp/socket_0_1/sock -- --forward-mode=macswap ./build/app/dpdk-testpmd -l 24,28 --no-huge -m1 --no-shconf \ -a sock:/tmp/socket_1_0/sock -- --forward-mode=macswap ./build/app/dpdk-testpmd -l 24,29 --no-huge -m1 --no-shconf \ -a sock:/tmp/socket_1_1/sock -- --forward-mode=macswap NOTE: * the "--no-huge -m1" is present to guarantee that no regular DPDK hugepage memory is being
[RFC PATCH 1/5] bus: new driver to accept shared memory over unix socket
Add a new driver to DPDK which supports taking in memory e.g. hugepage
memory via a unix socket connection and maps it into the DPDK process
replacing the current socket memory as the default memory for use by
future requests.
Signed-off-by: Bruce Richardson
---
drivers/bus/meson.build | 1 +
drivers/bus/shared_mem/meson.build | 11 +
drivers/bus/shared_mem/shared_mem_bus.c | 323
drivers/bus/shared_mem/shared_mem_bus.h | 75 ++
drivers/bus/shared_mem/version.map | 11 +
5 files changed, 421 insertions(+)
create mode 100644 drivers/bus/shared_mem/meson.build
create mode 100644 drivers/bus/shared_mem/shared_mem_bus.c
create mode 100644 drivers/bus/shared_mem/shared_mem_bus.h
create mode 100644 drivers/bus/shared_mem/version.map
diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
index a78b4283bf..0e64959d1a 100644
--- a/drivers/bus/meson.build
+++ b/drivers/bus/meson.build
@@ -9,6 +9,7 @@ drivers = [
'ifpga',
'pci',
'platform',
+'shared_mem',
'vdev',
'vmbus',
]
diff --git a/drivers/bus/shared_mem/meson.build
b/drivers/bus/shared_mem/meson.build
new file mode 100644
index 00..1fa21f3a09
--- /dev/null
+++ b/drivers/bus/shared_mem/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2023 Intel Corporation
+
+if is_windows
+build = false
+reason = 'not supported on Windows'
+endif
+
+sources = files('shared_mem_bus.c')
+require_iova_in_mbuf = false
+deps += ['mbuf', 'net']
diff --git a/drivers/bus/shared_mem/shared_mem_bus.c
b/drivers/bus/shared_mem/shared_mem_bus.c
new file mode 100644
index 00..e0369ed416
--- /dev/null
+++ b/drivers/bus/shared_mem/shared_mem_bus.c
@@ -0,0 +1,323 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include "shared_mem_bus.h"
+
+RTE_LOG_REGISTER_DEFAULT(shared_mem_bus_logtype, DEBUG);
+#define BUS_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \
+ shared_mem_bus_logtype, "## SHARED MEM BUS: %s(): " fmt "\n",
__func__, ##args)
+#define BUS_ERR(fmt, args...) BUS_LOG(ERR, fmt, ## args)
+#define BUS_INFO(fmt, args...) BUS_LOG(INFO, fmt, ## args)
+#define BUS_DEBUG(fmt, args...) BUS_LOG(DEBUG, fmt, ## args)
+
+static int dev_scan(void);
+static int dev_probe(void);
+static struct rte_device *find_device(const struct rte_device *start,
rte_dev_cmp_t cmp,
+const void *data);
+static enum rte_iova_mode get_iommu_class(void);
+static int addr_parse(const char *, void *);
+
+struct socket_device {
+ struct rte_device rte_device;
+ TAILQ_ENTRY(socket_device) next;
+ int fd;
+ uintptr_t membase;
+ uintptr_t memlen;
+};
+
+/** List of devices */
+TAILQ_HEAD(socket_list, socket_device);
+TAILQ_HEAD(device_list, rte_device);
+
+struct shared_mem_bus {
+ struct rte_bus bus;
+ struct socket_list socket_list;
+ struct shared_mem_drv *ethdrv;
+ struct device_list device_list;
+};
+
+static struct shared_mem_bus shared_mem_bus = {
+ .bus = {
+ .scan = dev_scan,
+ .probe = dev_probe,
+ .find_device = find_device,
+ .get_iommu_class = get_iommu_class,
+ .parse = addr_parse,
+ },
+
+ .socket_list = TAILQ_HEAD_INITIALIZER(shared_mem_bus.socket_list),
+ .device_list = TAILQ_HEAD_INITIALIZER(shared_mem_bus.device_list),
+};
+
+RTE_REGISTER_BUS(shared_mem, shared_mem_bus.bus);
+
+int
+rte_shm_bus_send_message(void *msg, size_t msglen)
+{
+ return send(shared_mem_bus.socket_list.tqh_first->fd, msg, msglen, 0);
+}
+
+int
+rte_shm_bus_recv_message(void *msg, size_t msglen)
+{
+ return recv(shared_mem_bus.socket_list.tqh_first->fd, msg, msglen, 0);
+}
+
+uintptr_t
+rte_shm_bus_get_mem_offset(void *ptr)
+{
+ struct socket_device *dev;
+ uintptr_t pval = (uintptr_t)ptr;
+
+ TAILQ_FOREACH(dev, &shared_mem_bus.socket_list, next) {
+ if (dev->membase < pval && dev->membase + dev->memlen > pval)
+ return pval - dev->membase;
+ }
+ return (uintptr_t)-1;
+}
+
+void *
+rte_shm_bus_get_mem_ptr(uintptr_t offset)
+{
+ struct socket_device *dev;
+
+ TAILQ_FOREACH(dev, &shared_mem_bus.socket_list, next) {
+ if (offset < dev->memlen)
+ return RTE_PTR_ADD(dev->membase, offset);
+ }
+ return (void *)-1;
+}
+
+static int
+dev_scan(void)
+{
+ if (shared_mem_bus.bus.conf.scan_mode != RTE_BUS_SCAN_ALLOWLIST)
+ return 0;
+
+ struct rte_devargs *devargs;
+ RTE_EAL_DEVARGS_FOREACH(shared_mem_bus.bus.name, devargs) {
+
+ int fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
+
[RFC PATCH 2/5] mempool: driver for mempools of mbufs on shared memory
This mempool driver can be used with the shared_mem bus driver to create
a pool of shared mbufs on a shared memory segment.
Signed-off-by: Bruce Richardson
---
drivers/mempool/meson.build| 1 +
drivers/mempool/shared_mem/meson.build | 10 +++
drivers/mempool/shared_mem/shared_mem_mp.c | 94 ++
3 files changed, 105 insertions(+)
create mode 100644 drivers/mempool/shared_mem/meson.build
create mode 100644 drivers/mempool/shared_mem/shared_mem_mp.c
diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build
index dc88812585..4326bd0ea3 100644
--- a/drivers/mempool/meson.build
+++ b/drivers/mempool/meson.build
@@ -8,6 +8,7 @@ drivers = [
'dpaa2',
'octeontx',
'ring',
+'shared_mem',
'stack',
]
diff --git a/drivers/mempool/shared_mem/meson.build
b/drivers/mempool/shared_mem/meson.build
new file mode 100644
index 00..ee740ccdc9
--- /dev/null
+++ b/drivers/mempool/shared_mem/meson.build
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2023 Intel Corporation
+
+if is_windows
+build = false
+reason = 'not supported on Windows'
+endif
+sources = files('shared_mem_mp.c')
+require_iova_in_mbuf = false
+deps += ['stack', 'bus_shared_mem']
diff --git a/drivers/mempool/shared_mem/shared_mem_mp.c
b/drivers/mempool/shared_mem/shared_mem_mp.c
new file mode 100644
index 00..7dae8aba92
--- /dev/null
+++ b/drivers/mempool/shared_mem/shared_mem_mp.c
@@ -0,0 +1,94 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+#include
+#include
+#include
+#include
+#include
+
+RTE_LOG_REGISTER_DEFAULT(shared_mem_mp_log, DEBUG);
+#define MP_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \
+ shared_mem_mp_log, "## SHARED MP: %s(): " fmt "\n", __func__,
##args)
+#define MP_ERR(fmt, args...) MP_LOG(ERR, fmt, ## args)
+#define MP_INFO(fmt, args...) MP_LOG(INFO, fmt, ## args)
+#define MP_DEBUG(fmt, args...) MP_LOG(DEBUG, fmt, ## args)
+
+static int
+shm_mp_alloc(struct rte_mempool *mp)
+{
+ char name[RTE_STACK_NAMESIZE];
+ struct rte_stack *s;
+ int ret;
+
+ ret = snprintf(name, sizeof(name), RTE_MEMPOOL_MZ_FORMAT, mp->name);
+ if (ret < 0 || ret >= (int)sizeof(name)) {
+ rte_errno = ENAMETOOLONG;
+ return -rte_errno;
+ }
+
+ s = rte_stack_create(name, mp->size, mp->socket_id, 0);
+ if (s == NULL)
+ return -rte_errno;
+ MP_DEBUG("Stack created at address: %p", s);
+
+ mp->pool_data = s;
+
+ return 0;
+}
+
+static int
+shm_mp_enqueue(struct rte_mempool *mp, void * const *obj_table,
+ unsigned int n)
+{
+ struct rte_stack *s = mp->pool_data;
+
+ void *offset_table[n];
+ uintptr_t mempool_base = (uintptr_t)rte_shm_bus_get_mem_ptr(0); /*
offset 0 == base addr */
+ for (uint i = 0; i < n; i++)
+ offset_table[i] = RTE_PTR_SUB(obj_table[i], mempool_base);
+
+ return rte_stack_push(s, offset_table, n) == 0 ? -ENOBUFS : 0;
+}
+
+static int
+shm_mp_dequeue(struct rte_mempool *mp, void **obj_table,
+ unsigned int n)
+{
+ struct rte_stack *s = mp->pool_data;
+ uintptr_t mempool_base = (uintptr_t)rte_shm_bus_get_mem_ptr(0); /*
offset 0 == base addr */
+ uint16_t priv_size = rte_pktmbuf_priv_size(mp);
+
+ if (rte_stack_pop(s, obj_table, n) == 0)
+ return -ENOBUFS;
+ for (uint i = 0; i < n; i++) {
+ obj_table[i] = RTE_PTR_ADD(obj_table[i], mempool_base);
+ struct rte_mbuf *mb = obj_table[i];
+ mb->buf_addr = RTE_PTR_ADD(mb, sizeof(struct rte_mbuf) +
priv_size);
+ mb->pool = mp;
+ }
+ return 0;
+}
+
+static unsigned
+shm_mp_get_count(const struct rte_mempool *mp)
+{
+ return rte_stack_count(mp->pool_data);
+}
+
+static void
+shm_mp_free(struct rte_mempool *mp)
+{
+ rte_stack_free(mp->pool_data);
+}
+
+static struct rte_mempool_ops ops_shared_mem_mp = {
+ .name = "shared_mem",
+ .alloc = shm_mp_alloc,
+ .free = shm_mp_free,
+ .enqueue = shm_mp_enqueue,
+ .dequeue = shm_mp_dequeue,
+ .get_count = shm_mp_get_count,
+};
+
+RTE_MEMPOOL_REGISTER_OPS(ops_shared_mem_mp);
--
2.39.2
[RFC PATCH 3/5] net: new ethdev driver to communicate using shared mem
This ethdev builds on the previous shared_mem bus driver and shared_mem
mempool driver to provide an ethdev interface which can allow zero-copy
I/O from one process to another.
Signed-off-by: Bruce Richardson
---
drivers/net/meson.build | 1 +
drivers/net/shared_mem/meson.build | 11 +
drivers/net/shared_mem/shared_mem_eth.c | 295
3 files changed, 307 insertions(+)
create mode 100644 drivers/net/shared_mem/meson.build
create mode 100644 drivers/net/shared_mem/shared_mem_eth.c
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index bd38b533c5..505d208497 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -53,6 +53,7 @@ drivers = [
'qede',
'ring',
'sfc',
+'shared_mem',
'softnic',
'tap',
'thunderx',
diff --git a/drivers/net/shared_mem/meson.build
b/drivers/net/shared_mem/meson.build
new file mode 100644
index 00..17d1b84454
--- /dev/null
+++ b/drivers/net/shared_mem/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2023 Intel Corporation
+
+if is_windows
+build = false
+reason = 'not supported on Windows'
+endif
+
+sources = files('shared_mem_eth.c')
+deps += 'bus_shared_mem'
+require_iova_in_mbuf = false
diff --git a/drivers/net/shared_mem/shared_mem_eth.c
b/drivers/net/shared_mem/shared_mem_eth.c
new file mode 100644
index 00..564bfdb907
--- /dev/null
+++ b/drivers/net/shared_mem/shared_mem_eth.c
@@ -0,0 +1,295 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+#include
+#include
+#include
+
+RTE_LOG_REGISTER_DEFAULT(shared_mem_eth_logtype, DEBUG);
+#define SHM_ETH_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \
+ shared_mem_eth_logtype, "## SHARED MEM ETH: %s(): " fmt "\n",
__func__, ##args)
+#define SHM_ETH_ERR(fmt, args...) SHM_ETH_LOG(ERR, fmt, ## args)
+#define SHM_ETH_INFO(fmt, args...) SHM_ETH_LOG(INFO, fmt, ## args)
+#define SHM_ETH_DEBUG(fmt, args...) SHM_ETH_LOG(DEBUG, fmt, ## args)
+
+struct shm_eth_stats {
+ uint64_t rx_pkts;
+ uint64_t tx_pkts;
+ uint64_t rx_bytes;
+ uint64_t tx_bytes;
+};
+
+struct shm_eth_private {
+ struct rte_ether_addr addr;
+ struct rte_ring *rx;
+ struct rte_ring *tx;
+ struct shm_eth_stats stats;
+};
+
+static struct rte_mempool *rx_mp; /* TODO: use one per queue */
+
+static int
+shm_eth_configure(struct rte_eth_dev *dev __rte_unused)
+{
+ return 0;
+}
+
+static int
+shm_eth_start(struct rte_eth_dev *dev)
+{
+ struct shm_eth_private *priv = dev->data->dev_private;
+
+ struct eth_shared_mem_msg msg = (struct eth_shared_mem_msg){
+ .type = MSG_TYPE_START,
+ };
+ rte_shm_bus_send_message(&msg, sizeof(msg));
+
+ rte_shm_bus_recv_message(&msg, sizeof(msg));
+ if (msg.type != MSG_TYPE_ACK) {
+ SHM_ETH_ERR("Didn't get ack from host\n");
+ return -1;
+ }
+
+ memset(&priv->stats, 0, sizeof(priv->stats));
+ return 0;
+}
+
+static int
+shm_eth_stop(struct rte_eth_dev *dev __rte_unused)
+{
+ return 0;
+}
+
+static int
+shm_eth_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
+{
+ *info = (struct rte_eth_dev_info){
+ .driver_name = dev->device->driver->name,
+ .max_rx_queues = 1,
+ .max_tx_queues = 1,
+ .max_mac_addrs = 1,
+ .min_mtu = 64,
+ .max_mtu = UINT16_MAX,
+ .max_rx_pktlen = UINT16_MAX,
+ .nb_rx_queues = 1,
+ .nb_tx_queues = 1,
+ .tx_desc_lim = { .nb_max = 8192, .nb_min = 128, .nb_align = 64
},
+ .rx_desc_lim = { .nb_max = 8192, .nb_min = 128, .nb_align = 64
},
+ };
+ return 0;
+}
+
+static int
+shm_eth_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
+{
+ dev->data->mtu = mtu;
+ return 0;
+}
+
+static int
+shm_eth_link_update(struct rte_eth_dev *dev, int wait __rte_unused)
+{
+ dev->data->dev_link = (struct rte_eth_link){
+ .link_speed = RTE_ETH_SPEED_NUM_100G,
+ .link_duplex = 1,
+ .link_autoneg = 1,
+ .link_status = 1,
+ };
+ return 0;
+}
+
+static int
+shm_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,
+ uint16_t nb_rx_desc,
+ unsigned int socket_id,
+ const struct rte_eth_rxconf *rx_conf,
+ struct rte_mempool *mb_pool)
+{
+ RTE_SET_USED(rx_conf);
+
+ struct shm_eth_private *priv = dev->data->dev_private;
+ char ring_name[32];
+
+ if (rte_shm_bus_get_mem_offset(mb_pool) == (uintptr_t)-1) {
+ SHM_ETH_ERR("Mempool not in shared memory");
+ return -1;
+ }
+ snprintf(ring_name, sizeof(ring_name), "shm_eth_rxr%u", rx_queue_id)
[RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces
This app uses the shared memory poll, and shared ethdev infrastructure
to act as a zero-copy IO proxy to other applications. It has been tested
and verified to work successfully proxying data to testpmd instances on
the system, with those testpmd instances each being passed a unix socket
to work with via the shared memory bus "-a sock:/path/to/sock..."
parameter.
Signed-off-by: Bruce Richardson
---
app/io-proxy/command_fns.c | 160 ++
app/io-proxy/commands.list | 6 +
app/io-proxy/datapath.c| 595 +
app/io-proxy/datapath.h| 37 +++
app/io-proxy/datapath_mp.c | 78 +
app/io-proxy/main.c| 71 +
app/io-proxy/meson.build | 12 +
app/meson.build| 1 +
8 files changed, 960 insertions(+)
create mode 100644 app/io-proxy/command_fns.c
create mode 100644 app/io-proxy/commands.list
create mode 100644 app/io-proxy/datapath.c
create mode 100644 app/io-proxy/datapath.h
create mode 100644 app/io-proxy/datapath_mp.c
create mode 100644 app/io-proxy/main.c
create mode 100644 app/io-proxy/meson.build
diff --git a/app/io-proxy/command_fns.c b/app/io-proxy/command_fns.c
new file mode 100644
index 00..f48921e005
--- /dev/null
+++ b/app/io-proxy/command_fns.c
@@ -0,0 +1,160 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Intel Corporation
+ */
+
+#include
+#include
+#include
+
+#include
+
+#include "datapath.h"
+#include "commands.h"
+
+extern volatile bool quit;
+extern volatile bool running_startup_script;
+
+void
+cmd_add_socket_parsed(void *parsed_result, struct cmdline *cl __rte_unused,
+ void *data __rte_unused)
+{
+ struct cmd_add_socket_result *res = parsed_result;
+ uint64_t maxmem = 0;
+ char *endchar;
+
+ maxmem = strtoull(res->memsize, &endchar, 0);
+ switch (*endchar) {
+ case 'G': case 'g':
+ maxmem *= 1024;
+ /* fall-through */
+ case 'M': case 'm':
+ maxmem *= 1024;
+ /* fall-through */
+ case 'K': case 'k':
+ maxmem *= 1024;
+ break;
+ }
+ if (res->port >= MAX_PORTS_SUPPORTED) {
+ fprintf(stderr, "Port id out of range. Must be <%u\n",
MAX_PORTS_SUPPORTED);
+ goto err;
+ }
+ if (res->queue >= MAX_QUEUES_SUPPORTED) {
+ fprintf(stderr, "Queue id out of range. Must be <%u\n",
MAX_QUEUES_SUPPORTED);
+ goto err;
+ }
+ if (listen_unix_socket(res->path, maxmem, res->port, res->queue) != 0) {
+ fprintf(stderr, "error initializing socket: %s\n", res->path);
+ goto err;
+ }
+
+ printf("Created socket = %s with memsize = %s using port = %u, queue =
%u\n",
+ res->path, res->memsize, res->port, res->queue);
+ return;
+
+err:
+ if (running_startup_script) {
+ quit = true;
+ /* wait for main thread to quit. Just spin here for condition
which
+* will never actually come true, as main thread should just
exit
+*/
+ while (quit)
+ usleep(100);
+ }
+ /* if running interactively, do nothing on error except report it above
*/
+}
+
+void
+cmd_list_sockets_parsed(__rte_unused void *parsed_result,
+ __rte_unused struct cmdline *cl,
+ __rte_unused void *data)
+{
+ const char *path;
+ int sock;
+ uint64_t maxmem;
+ uint16_t port, queue;
+ bool connected;
+
+ for (int i = get_next_socket(0, &path, &sock, &maxmem, &port, &queue,
&connected);
+ i < MAX_SOCKETS;
+ i = get_next_socket(i + 1, &path, &sock, &maxmem, &port,
+ &queue, &connected)) {
+ char memstr[32];
+ if (maxmem % (1UL << 30) == 0)
+ snprintf(memstr, sizeof(memstr), "%" PRIu64 "G", maxmem
>> 30);
+ else if (maxmem % (1UL << 20) == 0)
+ snprintf(memstr, sizeof(memstr), "%" PRIu64 "M", maxmem
>> 20);
+ else if (maxmem % (1UL << 10) == 0)
+ snprintf(memstr, sizeof(memstr), "%" PRIu64 "K", maxmem
>> 10);
+ else
+ snprintf(memstr, sizeof(memstr), "%" PRIu64, maxmem);
+
+ printf("Socket %s [%s]: mem=%s, port=%u, queue=%u\n",
+ path, connected ? "connected" : "idle", memstr,
port, queue);
+ }
+}
+
+void
+cmd_list_ports_parsed(__rte_unused void *parsed_result,
+ __rte_unused struct cmdline *cl,
+ __rte_unused void *data)
+{
+ for (int i = 0; i < rte_eth_dev_count_avail(); i++) {
+ struct rte_ether_addr addr;
+ int retval = rte_eth_macaddr_get(i, &addr);
+ if (retval != 0) {
+ printf("Port %d
[RFC PATCH 5/5] app/io-proxy: add startup commands
To make it easier to run the io-proxy, add a startup command line example to configure by default 4 sockets on two ports. Signed-off-by: Bruce Richardson --- app/io-proxy/dpdk-io-proxy.cmds | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 app/io-proxy/dpdk-io-proxy.cmds diff --git a/app/io-proxy/dpdk-io-proxy.cmds b/app/io-proxy/dpdk-io-proxy.cmds new file mode 100644 index 00..515d598079 --- /dev/null +++ b/app/io-proxy/dpdk-io-proxy.cmds @@ -0,0 +1,6 @@ +add socket /tmp/socket_0_0/sock 2G 0 0 +add socket /tmp/socket_0_1/sock 2G 0 1 +add socket /tmp/socket_1_0/sock 2G 1 0 +add socket /tmp/socket_1_1/sock 2G 1 1 +list ports +list sockets -- 2.39.2
RE: [PATCH] common/idpf: fix Tx checksum offload
> -Original Message-
> From: beilei.x...@intel.com
> Sent: Friday, September 22, 2023 11:30 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org
> Subject: [PATCH] common/idpf: fix Tx checksum offload
>
> From: Beilei Xing
>
> For multi-segment packets, the Tx checksum offload doesn't work except the
> last segment, because other segments don't enable HW checksum offload
> successfully.
>
> Fixes: ef47d95e9031 ("net/idpf: fix TSO")
> Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Beilei Xing
> ---
Verified scalar path + single queue and split queue, tested pass for TX
checksum on TSO offload.
Tested-by: Zhimin Huang
[PATCH v2] net/af_xdp: fix cflags to appropriate UMEM feature
Fix missing RTE_NET_AF_XDP_SHARED_UMEM flag in
xsk_socket__create_shared().
rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0
init_internals(): Shared UMEM feature not available. Check kernel and
libbpf version
rte_pmd_af_xdp_probe(): Failed to init internals
vdev_probe(): failed to initialize net_af_xdp0 device
EAL: Bus (vdev) probe failed.
Fixes: e024c7e838fc ("net/af_xdp: avoid version-based check for shared UMEM")
Fixes: 33d66940e9ba ("build: use C11 standard")
Fix is for the commit e024c7e838fc ("net/af_xdp: avoid
version-based check for shared UMEM") fixline would imply
a possible backport though, but no issue has been seen on
version of DPDK not using C11, so I will be skipping
backporting this for now.
Commit 33d66940e9ba ("build: use C11 standard") enforces
the C11 standard so some changes need to be made to the
af_xdp driver meson build to ensure that the appropriate
cflags are passed when checking if certain functions are
available in the libbpf/libxdp libraries.
Signed-off-by: Shibin Koikkara Reeny
---
drivers/net/af_xdp/meson.build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 9a8dbb4d49..3319acca65 100644
--- a/drivers/net/af_xdp/meson.build
+++ b/drivers/net/af_xdp/meson.build
@@ -56,17 +56,17 @@ if build
'''
if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix,
- dependencies : ext_deps)
+ dependencies : ext_deps, args: cflags)
cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM']
endif
if cc.has_function('bpf_object__next_program',
prefix : '#include ',
- dependencies : bpf_dep)
+ dependencies : bpf_dep, args: cflags)
cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN']
endif
if cc.has_function('bpf_xdp_attach',
prefix : '#include ',
- dependencies : bpf_dep)
+ dependencies : bpf_dep, args: cflags)
cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH']
endif
endif
--
2.25.1
Re: [PATCH 1/2] net/sfc: offer indirect VXLAN encap action in transfer flows
On 9/22/2023 7:32 AM, Andrew Rybchenko wrote: > On 8/10/23 21:06, Ivan Malov wrote: >> Parsing inline action VXLAN_ENCAP repeating in many flows is >> expensive, so offer support for its indirect version. Query >> operation is not supported for this action. The next patch >> will add a means to update the encapsulation header data. >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andy Moreton > > Acked-by: Andrew Rybchenko > > Series applied to dpdk-next-net/main, thanks.
Re: [PATCH 1/2] net/mana: enable 32 bit build for mana driver
On 9/21/2023 9:53 PM, Long Li wrote: >> Subject: [PATCH 1/2] net/mana: enable 32 bit build for mana driver >> >> Enable 32 bit build on x86 Linux. Fixed build warnings and errors when >> building in >> 32 bit. >> >> With this patch, mana will be able to build into 32 bit. However, another >> patch for >> mana short doorbell support is needed to make mana fully functional for 32 >> bit >> applicatons. >> >> Cc: sta...@dpdk.org >> >> Signed-off-by: Wei Hu > > Acked-by: Long Li > Series applied to dpdk-next-net/main, thanks.
[PATCH 1/2] eal: introduce x86 processor identification
In some really specific cases, it may be needed to get a detailed
information on the processor running a DPDK application for drivers to
achieve better performance, or for matters that concern only them.
Those information are highly arch-specific and require a specific API.
Introduce a set of functions to get brand, family and model of a x86
processor.
Those functions do not make sense on other arches and a
driver must first check rte_cpu_is_x86() before anything else.
Signed-off-by: David Marchand
---
MAINTAINERS | 1 +
app/test/meson.build| 1 +
app/test/test_cpu.c | 37 +
lib/eal/common/eal_common_cpu.c | 141
lib/eal/common/eal_cpu.h| 77 +
lib/eal/common/meson.build | 1 +
lib/eal/version.map | 6 ++
7 files changed, 264 insertions(+)
create mode 100644 app/test/test_cpu.c
create mode 100644 lib/eal/common/eal_common_cpu.c
create mode 100644 lib/eal/common/eal_cpu.h
diff --git a/MAINTAINERS b/MAINTAINERS
index 698608cdb2..b87d47a1e4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -158,6 +158,7 @@ F: app/test/test_barrier.c
F: app/test/test_bitcount.c
F: app/test/test_byteorder.c
F: app/test/test_common.c
+F: app/test/test_cpu.c
F: app/test/test_cpuflags.c
F: app/test/test_cycles.c
F: app/test/test_debug.c
diff --git a/app/test/meson.build b/app/test/meson.build
index 05bae9216d..4b37ad02fa 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -44,6 +44,7 @@ source_file_deps = {
'test_cmdline_string.c': [],
'test_common.c': [],
'test_compressdev.c': ['compressdev'],
+'test_cpu.c': [],
'test_cpuflags.c': [],
'test_crc.c': ['net'],
'test_cryptodev.c': test_cryptodev_deps,
diff --git a/app/test/test_cpu.c b/app/test/test_cpu.c
new file mode 100644
index 00..40d8bd94eb
--- /dev/null
+++ b/app/test/test_cpu.c
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Red Hat, Inc.
+ */
+
+#include
+#include
+
+#include "eal_cpu.h"
+
+#include "test.h"
+
+static int
+test_cpu(void)
+{
+#ifndef RTE_ARCH_X86
+ RTE_TEST_ASSERT(!rte_cpu_is_x86(), "rte_cpu_is_x86() returned true on "
RTE_STR(RTE_ARCH));
+#else
+ const char *vendor;
+
+ RTE_TEST_ASSERT(rte_cpu_is_x86(), "rte_cpu_is_x86() returned false");
+
+ if (rte_cpu_x86_is_amd())
+ vendor = "AMD";
+ else if (rte_cpu_x86_is_intel())
+ vendor = "Intel";
+ else
+ vendor = "unknown";
+
+ printf("The processor running this program is a x86 %s processor,
brand=0x%"
+ PRIx8", family=0x%"PRIx8", model=0x%"PRIx8"\n", vendor,
rte_cpu_x86_brand(),
+ rte_cpu_x86_family(), rte_cpu_x86_model());
+#endif
+
+ return TEST_SUCCESS;
+}
+
+REGISTER_FAST_TEST(cpu_autotest, true, true, test_cpu);
diff --git a/lib/eal/common/eal_common_cpu.c b/lib/eal/common/eal_common_cpu.c
new file mode 100644
index 00..18cdb27f75
--- /dev/null
+++ b/lib/eal/common/eal_common_cpu.c
@@ -0,0 +1,141 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2023 Red Hat, Inc.
+ */
+
+#include
+
+#include "eal_cpu.h"
+
+#ifdef RTE_ARCH_X86
+#ifndef RTE_TOOLCHAIN_MSVC
+#include
+#endif
+
+static void
+x86_cpuid(uint32_t leaf, uint32_t subleaf, uint32_t *eax, uint32_t *ebx,
+ uint32_t *ecx, uint32_t *edx)
+{
+ uint32_t regs[4] = { 0 };
+
+#ifdef RTE_TOOLCHAIN_MSVC
+ __cpuidex(regs, leaf, subleaf);
+#else
+ __cpuid_count(leaf, subleaf, regs[0], regs[1], regs[2], regs[3]);
+#endif
+
+ *eax = regs[0];
+ *ebx = regs[1];
+ *ecx = regs[2];
+ *edx = regs[3];
+}
+#endif /* RTE_ARCH_X86 */
+
+bool
+rte_cpu_is_x86(void)
+{
+#ifndef RTE_ARCH_X86
+ return false;
+#else
+ return true;
+#endif
+}
+
+bool
+rte_cpu_x86_is_amd(void)
+{
+#ifndef RTE_ARCH_X86
+ rte_panic("Calling %s does not make sense on %s architecture.\n",
+ __func__, RTE_STR(RTE_ARCH));
+#else
+ uint32_t eax, ebx, ecx, edx;
+
+ x86_cpuid(0x0, 0x0, &eax, &ebx, &ecx, &edx);
+ /* ascii_to_little_endian("Auth enti cAMD") */
+ return ebx == 0x68747541 && ecx == 0x444d4163 && edx == 0x69746e65;
+#endif
+}
+
+bool
+rte_cpu_x86_is_intel(void)
+{
+#ifndef RTE_ARCH_X86
+ rte_panic("Calling %s does not make sense on %s architecture.\n",
+ __func__, RTE_STR(RTE_ARCH));
+#else
+ uint32_t eax, ebx, ecx, edx;
+
+ x86_cpuid(0x0, 0x0, &eax, &ebx, &ecx, &edx);
+ /* ascii_to_little_endian("Genu ineI ntel") */
+ return ebx == 0x756e6547 && ecx == 0x6c65746e && edx == 0x49656e69;
+#endif
+}
+
+uint8_t
+rte_cpu_x86_brand(void)
+{
+#ifndef RTE_ARCH_X86
+ rte_panic("Calling %s does not make sense on %s architecture.\n",
+ __func__, RTE_STR(RTE_ARCH));
+#else
+ uint32_t eax, ebx, ecx, edx;
+ uint8_t brand = 0;
+
+ x86_cpuid(0x0, 0x0, &eax,
[PATCH 0/2] Introduce x86 specific identification API
Rather than have every driver implement their own set of cpuid() ugly stuff, provide an abstracted (gcc/clang vs MSVC) API for querying about x86 processor details. Note: - coming up with a cross arch API seems a difficult task, hence a arch specific API has been preferred. If other arches have ideas how to abstract I am open to suggestions though I won't have the time to implement it for this release, - usage of this arch specific API must not become the common practice and maintainers will have to be wary that drivers are still working fine with generic/common processor/arch features, -- David Marchand David Marchand (2): eal: introduce x86 processor identification common/mlx5: use EAL x86 processor identification MAINTAINERS | 1 + app/test/meson.build | 1 + app/test/test_cpu.c | 37 drivers/common/mlx5/mlx5_common.c | 81 + lib/eal/common/eal_common_cpu.c | 141 ++ lib/eal/common/eal_cpu.h | 77 lib/eal/common/meson.build| 1 + lib/eal/version.map | 6 ++ 8 files changed, 285 insertions(+), 60 deletions(-) create mode 100644 app/test/test_cpu.c create mode 100644 lib/eal/common/eal_common_cpu.c create mode 100644 lib/eal/common/eal_cpu.h -- 2.41.0
[PATCH 2/2] common/mlx5: use EAL x86 processor identification
Rather than use an ugly asm thing, use newly introduced EAL x86 API.
Signed-off-by: David Marchand
---
drivers/common/mlx5/mlx5_common.c | 81 ---
1 file changed, 21 insertions(+), 60 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_common.c
b/drivers/common/mlx5/mlx5_common.c
index 0ad14a48c7..99adcd960e 100644
--- a/drivers/common/mlx5/mlx5_common.c
+++ b/drivers/common/mlx5/mlx5_common.c
@@ -6,6 +6,7 @@
#include
#include
+#include
#include
#include
#include
@@ -52,29 +53,6 @@ uint8_t haswell_broadwell_cpu;
*/
#define MLX5_SQ_DB_NC "sq_db_nc"
-/* In case this is an x86_64 intel processor to check if
- * we should use relaxed ordering.
- */
-#ifdef RTE_ARCH_X86_64
-/**
- * This function returns processor identification and feature information
- * into the registers.
- *
- * @param eax, ebx, ecx, edx
- * Pointers to the registers that will hold cpu information.
- * @param level
- * The main category of information returned.
- */
-static inline void mlx5_cpu_id(unsigned int level,
- unsigned int *eax, unsigned int *ebx,
- unsigned int *ecx, unsigned int *edx)
-{
- __asm__("cpuid\n\t"
- : "=a" (*eax), "=b" (*ebx), "=c" (*ecx), "=d" (*edx)
- : "0" (level));
-}
-#endif
-
RTE_LOG_REGISTER_DEFAULT(mlx5_common_logtype, NOTICE)
/* Head of list of drivers. */
@@ -1246,46 +1224,29 @@ mlx5_common_init(void)
RTE_INIT_PRIO(mlx5_is_haswell_broadwell_cpu, LOG)
{
#ifdef RTE_ARCH_X86_64
- unsigned int broadwell_models[4] = {0x3d, 0x47, 0x4F, 0x56};
- unsigned int haswell_models[4] = {0x3c, 0x3f, 0x45, 0x46};
- unsigned int i, model, family, brand_id, vendor;
- unsigned int signature_intel_ebx = 0x756e6547;
- unsigned int extended_model;
- unsigned int eax = 0;
- unsigned int ebx = 0;
- unsigned int ecx = 0;
- unsigned int edx = 0;
- int max_level;
-
- mlx5_cpu_id(0, &eax, &ebx, &ecx, &edx);
- vendor = ebx;
- max_level = eax;
- if (max_level < 1) {
- haswell_broadwell_cpu = 0;
+ uint8_t broadwell_models[] = {0x3d, 0x47, 0x4f, 0x56};
+ uint8_t haswell_models[] = {0x3c, 0x3f, 0x45, 0x46};
+ unsigned int i;
+ uint8_t model;
+
+ if (!rte_cpu_is_x86() || !rte_cpu_x86_is_intel() || rte_cpu_x86_brand()
!= 0x0 ||
+ rte_cpu_x86_family() != 0x6)
+ goto out;
+
+ model = rte_cpu_x86_model();
+ for (i = 0; i < RTE_DIM(broadwell_models); i++) {
+ if (model != broadwell_models[i])
+ continue;
+ haswell_broadwell_cpu = 1;
return;
}
- mlx5_cpu_id(1, &eax, &ebx, &ecx, &edx);
- model = (eax >> 4) & 0x0f;
- family = (eax >> 8) & 0x0f;
- brand_id = ebx & 0xff;
- extended_model = (eax >> 12) & 0xf0;
- /* Check if the processor is Haswell or Broadwell */
- if (vendor == signature_intel_ebx) {
- if (family == 0x06)
- model += extended_model;
- if (brand_id == 0 && family == 0x6) {
- for (i = 0; i < RTE_DIM(broadwell_models); i++)
- if (model == broadwell_models[i]) {
- haswell_broadwell_cpu = 1;
- return;
- }
- for (i = 0; i < RTE_DIM(haswell_models); i++)
- if (model == haswell_models[i]) {
- haswell_broadwell_cpu = 1;
- return;
- }
- }
+ for (i = 0; i < RTE_DIM(haswell_models); i++) {
+ if (model != haswell_models[i])
+ continue;
+ haswell_broadwell_cpu = 1;
+ return;
}
+out:
#endif
haswell_broadwell_cpu = 0;
}
--
2.41.0
Re: [PATCH v1] net/axgbe: use CPUID to identify cpu
On Fri, Sep 15, 2023 at 4:35 PM Ferruh Yigit wrote:
>
> On 9/15/2023 2:02 PM, David Marchand wrote:
> > On Fri, Sep 15, 2023 at 12:54 PM Ferruh Yigit wrote:
> >>
> >> On 8/31/2023 1:31 PM, Selwin Sebastian wrote:
> >>> Using root complex to identify cpu will not work for vm passthrough.
> >>> CPUID is used to get family and modelid to identify cpu
> >>>
> >>> Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to
> >>> distinguish device")
> >>> Cc: sta...@dpdk.org
> >>>
> >>> Signed-off-by: Selwin Sebastian
> >>> ---
> >>> drivers/net/axgbe/axgbe_ethdev.c | 102 ++-
> >>> 1 file changed, 59 insertions(+), 43 deletions(-)
> >>>
> >>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c
> >>> b/drivers/net/axgbe/axgbe_ethdev.c
> >>> index 48714eebe6..59f5d713d0 100644
> >>> --- a/drivers/net/axgbe/axgbe_ethdev.c
> >>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
> >>> @@ -12,6 +12,8 @@
> >>>
> >>> #include "eal_filesystem.h"
> >>>
> >>> +#include
> >>> +
> >>>
> >>
> >> This patch cause build errors for some non x86 architecture, because of
> >> 'cpuid.h'.
> >>
> >> There is already a 'rte_cpuid.h' file that includes 'cpuid.h' and it is
> >> x86 only file.
> >>
> >> @Selwin, does it makes sense to implement the feature you are trying to
> >> get in eal/x86 level and use that API in the driver?
> >
> > This driver was expected to compile on all arches.
> > The meson.build seems to show an intention of compiling/working on non
> > x86 arch...
> >
> > On the other hand (and if I understand correctly the runtime check),
> > it was never expected to work with anything but a AMD PCI root
> > complex.
> >
> >
> >>
> >>
> >> For those eal/x86 APIs, they will be missing in other architectures,
> >>
> >> @David which one is better, to implement APIs for other architectures
> >> but those just return error, or restrict driver build to x86?
> >
> > We gain compilation coverage, but if the vendor itself refuses runtime
> > on anything but its platform... I don't think we should bother with
> > this.
> > Did I miss something?
> >
>
> It is embedded device, so it will only run on x86.
>
> Current meson config doesn't restrict it to x86 (existing x86 check is
> only for vectorization code), but we can restrict if we want to.
>
>
> One option is to restrict driver to x86 arch, and have the local
> '__cpuid()',
>
> other option is move __cpuid() support to eal x86 specific area, so that
> other components also can benefit from it as well as the driver, similar
> to the getting CPU flags code, cpuid() is to get some information from
> CPU, so it is a generic thing, not specific to driver.
>
>
> I think second option is better, but that requires managing this for
> other archs, my question was related to it.
Ok, this patch wants to make sure the CPU vendor is AMD and adjust its
internal configuration based on this AMD processor family.
And as you mentionned, there is a (ugly asm) piece of code too in mlx5
that required identifying a Intel processor family.
I am unclear whether defining a cross arch API for identifying cpu
model details is doable but I suppose it won't be a quick thing to
define.
I came up with a rather simple API, posted it and Cc'd other arch maintainers.
https://patchwork.dpdk.org/project/dpdk/list/?series=29605&state=%2A&archive=both
Comments welcome (but not too many, please ;-)).
--
David Marchand
Re: [PATCH 1/2] eal: introduce x86 processor identification
On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote:
> In some really specific cases, it may be needed to get a detailed
> information on the processor running a DPDK application for drivers to
> achieve better performance, or for matters that concern only them.
>
> Those information are highly arch-specific and require a specific API.
>
> Introduce a set of functions to get brand, family and model of a x86
> processor.
> Those functions do not make sense on other arches and a
> driver must first check rte_cpu_is_x86() before anything else.
>
> Signed-off-by: David Marchand
> ---
> MAINTAINERS | 1 +
> app/test/meson.build| 1 +
> app/test/test_cpu.c | 37 +
> lib/eal/common/eal_common_cpu.c | 141
> lib/eal/common/eal_cpu.h| 77 +
> lib/eal/common/meson.build | 1 +
> lib/eal/version.map | 6 ++
> 7 files changed, 264 insertions(+)
> create mode 100644 app/test/test_cpu.c
> create mode 100644 lib/eal/common/eal_common_cpu.c
> create mode 100644 lib/eal/common/eal_cpu.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 698608cdb2..b87d47a1e4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -158,6 +158,7 @@ F: app/test/test_barrier.c
> F: app/test/test_bitcount.c
> F: app/test/test_byteorder.c
> F: app/test/test_common.c
> +F: app/test/test_cpu.c
> F: app/test/test_cpuflags.c
> F: app/test/test_cycles.c
> F: app/test/test_debug.c
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 05bae9216d..4b37ad02fa 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -44,6 +44,7 @@ source_file_deps = {
> 'test_cmdline_string.c': [],
> 'test_common.c': [],
> 'test_compressdev.c': ['compressdev'],
> +'test_cpu.c': [],
> 'test_cpuflags.c': [],
> 'test_crc.c': ['net'],
> 'test_cryptodev.c': test_cryptodev_deps,
> diff --git a/app/test/test_cpu.c b/app/test/test_cpu.c
> new file mode 100644
> index 00..40d8bd94eb
> --- /dev/null
> +++ b/app/test/test_cpu.c
> @@ -0,0 +1,37 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2023 Red Hat, Inc.
> + */
> +
> +#include
> +#include
> +
> +#include "eal_cpu.h"
> +
> +#include "test.h"
> +
> +static int
> +test_cpu(void)
> +{
> +#ifndef RTE_ARCH_X86
> + RTE_TEST_ASSERT(!rte_cpu_is_x86(), "rte_cpu_is_x86() returned true on "
> RTE_STR(RTE_ARCH));
> +#else
> + const char *vendor;
> +
> + RTE_TEST_ASSERT(rte_cpu_is_x86(), "rte_cpu_is_x86() returned false");
> +
> + if (rte_cpu_x86_is_amd())
> + vendor = "AMD";
> + else if (rte_cpu_x86_is_intel())
> + vendor = "Intel";
> + else
> + vendor = "unknown";
> +
> + printf("The processor running this program is a x86 %s processor,
> brand=0x%"
> + PRIx8", family=0x%"PRIx8", model=0x%"PRIx8"\n", vendor,
> rte_cpu_x86_brand(),
> + rte_cpu_x86_family(), rte_cpu_x86_model());
> +#endif
> +
> + return TEST_SUCCESS;
> +}
> +
> +REGISTER_FAST_TEST(cpu_autotest, true, true, test_cpu);
> diff --git a/lib/eal/common/eal_common_cpu.c b/lib/eal/common/eal_common_cpu.c
> new file mode 100644
> index 00..18cdb27f75
> --- /dev/null
> +++ b/lib/eal/common/eal_common_cpu.c
> @@ -0,0 +1,141 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2023 Red Hat, Inc.
> + */
> +
> +#include
> +
> +#include "eal_cpu.h"
> +
> +#ifdef RTE_ARCH_X86
> +#ifndef RTE_TOOLCHAIN_MSVC
> +#include
> +#endif
> +
> +static void
> +x86_cpuid(uint32_t leaf, uint32_t subleaf, uint32_t *eax, uint32_t *ebx,
> + uint32_t *ecx, uint32_t *edx)
> +{
> + uint32_t regs[4] = { 0 };
> +
> +#ifdef RTE_TOOLCHAIN_MSVC
> + __cpuidex(regs, leaf, subleaf);
> +#else
> + __cpuid_count(leaf, subleaf, regs[0], regs[1], regs[2], regs[3]);
> +#endif
> +
> + *eax = regs[0];
> + *ebx = regs[1];
> + *ecx = regs[2];
> + *edx = regs[3];
> +}
> +#endif /* RTE_ARCH_X86 */
>From a readability perspective, I think it would be better to expand the
scope of this ifdef and have two copies of each function in the file,
rather than a single copy of each with #ifdefs. WDYT?
/Bruce
Re: [PATCH 1/2] eal: introduce x86 processor identification
On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > In some really specific cases, it may be needed to get a detailed > information on the processor running a DPDK application for drivers to > achieve better performance, or for matters that concern only them. > > Those information are highly arch-specific and require a specific API. > > Introduce a set of functions to get brand, family and model of a x86 > processor. > Those functions do not make sense on other arches and a > driver must first check rte_cpu_is_x86() before anything else. > > Signed-off-by: David Marchand > --- Couple of thoughts, having had a few minutes to process this. * Rather than rte_cpu_is_x86() API, we could go a general API called rte_cpu_arch() which returns either a string, or an enum value. Within that, rather than #ifdefs, the actual return value could just be a define placed by meson in the rte_build_config.h file. The list of families according to meson are [1] - we'd just need to merge the 32 and 64-bit variants into one in the meson file. * Similarly rather than having is_intel or is_amd functions, we could generalize to a "manufacturer" API, which could be applicable for other architectures too. /Bruce [1] https://mesonbuild.com/Reference-tables.html#cpu-families
Re: [PATCH 1/2] eal: introduce x86 processor identification
On Fri, Sep 22, 2023 at 11:38:38AM +0100, Bruce Richardson wrote:
> On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote:
> > In some really specific cases, it may be needed to get a detailed
> > information on the processor running a DPDK application for drivers to
> > achieve better performance, or for matters that concern only them.
> >
> > Those information are highly arch-specific and require a specific API.
> >
> > Introduce a set of functions to get brand, family and model of a x86
> > processor.
> > Those functions do not make sense on other arches and a
> > driver must first check rte_cpu_is_x86() before anything else.
> >
> > Signed-off-by: David Marchand
> > ---
>
> Couple of thoughts, having had a few minutes to process this.
>
> * Rather than rte_cpu_is_x86() API, we could go a general API called
> rte_cpu_arch() which returns either a string, or an enum value. Within
> that, rather than #ifdefs, the actual return value could just be a define
> placed by meson in the rte_build_config.h file. The list of families
> according to meson are [1] - we'd just need to merge the 32 and 64-bit
> variants into one in the meson file.
>
We already have the architecture family in meson computed as the
"arch_subdir". Exposing that to the C code and wrapping as EAL function
might look like below (adding to eal.h for convenience).
Thoughts?
/Bruce
diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h
index 53c4a5519e..39f65d0e0c 100644
--- a/lib/eal/include/rte_eal.h
+++ b/lib/eal/include/rte_eal.h
@@ -517,6 +517,24 @@ __rte_internal
int
rte_eal_parse_coremask(const char *coremask, int *cores);
+enum rte_arch_family {
+ rte_cpu_arch_arm,
+ rte_cpu_arch_loongarch,
+ rte_cpu_arch_ppc,
+ rte_cpu_arch_riscv,
+ rte_cpu_arch_x86,
+};
+
+/**
+ * Return the architecture family of the current CPU
+ */
+static inline enum rte_arch_family
+rte_eal_get_arch_family(void)
+{
+ /* take value from build config set by meson */
+ return RTE_ARCH_FAMILY;
+}
+
#ifdef __cplusplus
}
#endif
diff --git a/meson.build b/meson.build
index 2e6e546d20..45e22daeb1 100644
--- a/meson.build
+++ b/meson.build
@@ -63,6 +63,7 @@ elif host_machine.cpu_family().startswith('ppc')
elif host_machine.cpu_family().startswith('riscv')
arch_subdir = 'riscv'
endif
+dpdk_conf.set('RTE_ARCH_FAMILY', 'rte_cpu_arch_' + arch_subdir)
# configure the build, and make sure configs here and in config folder are
# able to be included in any file. We also store a global array of include dirs
Re: [PATCH 00/13] improve the modularization of NFP PMD
On 9/20/2023 12:34 PM, Chaoyong He wrote: > This patch series aims to improve the modularization of NFP PMD through: > * Make the header files self-containing by adding the correct include > statement. > * Try to keep the interface of modules as small as possible. > * Remove the unneeded include statements to make sure a clean dependent > relations among modules. > > Chaoyong He (13): > net/nfp: make sure header file is self-containing > net/nfp: improve modularazation of rxtx module > net/nfp: improve modularazation of nfd3 module > net/nfp: improve modularazation of nfdk module > net/nfp: improve modularazation of common module > net/nfp: improve modularazation of flower module > net/nfp: improve modularazation of flower representor module > net/nfp: improve modularazation of flower ctrl module > net/nfp: improve modularazation of flower cmsg module > net/nfp: improve modularazation of flow module > net/nfp: improve modularazation of meter module > net/nfp: improve modularazation of CPP bridge module > net/nfp: cleanup the include statement of PMD > Series applied to dpdk-next-net/main, thanks. Are these cleanups preparation for a planned work?
Re: [PATCH 0/1] make file prefix unit test more resilient
20/09/2023 12:09, Bruce Richardson: > On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > > wrote: > > > > > > When examining the IOL testing failures for patch series [1], I observed > > > that the failures reported were in the eal_flags_file_prefix unit test. > > > I was able to reproduce this on my system by passing an additional > > > "--on-pci" flag to the test run, since the log to the test has errors > > > about device availability. Adding the "no-pci" flag to the individual > > > > Something is not clear to me. > > > > While I understand that passing "no-pci" helps avoiding the issue (as > > described below), I have some trouble understanding this passage > > (above) with "--on-pci". > > That's a typo for no-pci. When I ran the test on my system with the main > process using no-pci, I was able to reproduce the issue seen in the IOL > lab. Otherwise I couldn't reproduce it. > > > How did you reproduce the issue? > > > > > > > test commands used by the unit tests fixed the issue thereafter, > > > allowing the test to pass in all cases for me. Therefore, I am > > > submitting this patch in the hopes of making the test more robust, since > > > the observed failures seem unrelated to the original patchset [1] I > > > submitted. > > > > > > [1] http://patches.dpdk.org/project/dpdk/list/?series=29406 > > > > > > Bruce Richardson (1): > > > app/test: skip PCI bus scan when testing prefix flags > > > > > > app/test/test_eal_flags.c | 20 ++-- > > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > Iiuc, the problem is that the file_prefix unit test can fail if any > > DPDK subsystem forgets to release some memory and some hugepages are > > left behind at the cleanup step. > > Passing --no-pci as you suggest hides issues coming from PCI drivers. > > > > This is something I tried to fix too, with > > https://patchwork.dpdk.org/project/dpdk/list/?series=29288 though my > > fix only handles a part of the issue (here, the ethdev drivers). > > > > Another way to make the file prefix more robust would be to remove the > > check on released memory, or move it to another test. > > > I actually think the test is a good one to have. Also, taking in your patch > to help with the issue is a good idea also. > > I'd still suggest that this patch be considered anyway, as there is no need > to do PCI bus scanning as part of this test. Therefore I'd view it as a > harmless addition that may help things. I'm hesitating. This test is checking if some memory is left, and I think it is sane. If we add --no-pci, we reduce the coverage of this check. Now that the root cause is fixed by David in ethdev (https://patches.dpdk.org/project/dpdk/patch/20230821085806.3062613-4-david.march...@redhat.com/) we could continue checking memory freeing with PCI drivers. So I tend to reject this patch. Other opinions?
Re: [PATCH 0/1] make file prefix unit test more resilient
On Fri, Sep 22, 2023 at 02:57:32PM +0200, Thomas Monjalon wrote: > 20/09/2023 12:09, Bruce Richardson: > > On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > > > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > > > wrote: > > > > > > > > When examining the IOL testing failures for patch series [1], I observed > > > > that the failures reported were in the eal_flags_file_prefix unit test. > > > > I was able to reproduce this on my system by passing an additional > > > > "--on-pci" flag to the test run, since the log to the test has errors > > > > about device availability. Adding the "no-pci" flag to the individual > > > > > > Something is not clear to me. > > > > > > While I understand that passing "no-pci" helps avoiding the issue (as > > > described below), I have some trouble understanding this passage > > > (above) with "--on-pci". > > > > That's a typo for no-pci. When I ran the test on my system with the main > > process using no-pci, I was able to reproduce the issue seen in the IOL > > lab. Otherwise I couldn't reproduce it. > > > > > How did you reproduce the issue? > > > > > > > > > > test commands used by the unit tests fixed the issue thereafter, > > > > allowing the test to pass in all cases for me. Therefore, I am > > > > submitting this patch in the hopes of making the test more robust, since > > > > the observed failures seem unrelated to the original patchset [1] I > > > > submitted. > > > > > > > > [1] http://patches.dpdk.org/project/dpdk/list/?series=29406 > > > > > > > > Bruce Richardson (1): > > > > app/test: skip PCI bus scan when testing prefix flags > > > > > > > > app/test/test_eal_flags.c | 20 ++-- > > > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > > > Iiuc, the problem is that the file_prefix unit test can fail if any > > > DPDK subsystem forgets to release some memory and some hugepages are > > > left behind at the cleanup step. > > > Passing --no-pci as you suggest hides issues coming from PCI drivers. > > > > > > This is something I tried to fix too, with > > > https://patchwork.dpdk.org/project/dpdk/list/?series=29288 though my > > > fix only handles a part of the issue (here, the ethdev drivers). > > > > > > Another way to make the file prefix more robust would be to remove the > > > check on released memory, or move it to another test. > > > > > I actually think the test is a good one to have. Also, taking in your patch > > to help with the issue is a good idea also. > > > > I'd still suggest that this patch be considered anyway, as there is no need > > to do PCI bus scanning as part of this test. Therefore I'd view it as a > > harmless addition that may help things. > > I'm hesitating. > This test is checking if some memory is left, and I think it is sane. > If we add --no-pci, we reduce the coverage of this check. > > Now that the root cause is fixed by David in ethdev > (https://patches.dpdk.org/project/dpdk/patch/20230821085806.3062613-4-david.march...@redhat.com/) > we could continue checking memory freeing with PCI drivers. > So I tend to reject this patch. > > Other opinions? > No objection to this patch being rejected if not necessary. However, I'd question if the normal case is actually checking for freeing memory in PCI drivers. I suspect that in EAL cleanup we delete all files we use, irrespective of whether the mappings are still in use. Then when the process exits the hugepages will be completely freed back - even if some components leaked memory. I believe this case is checking for correct EAL cleanup of hugepage files, not for any memory leaks, and in that regard omitting some components should make no difference. /Bruce
Re: [PATCH v3 00/11] rework thread management
On Wed, Sep 13, 2023 at 1:45 PM Thomas Monjalon wrote: > > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take thread attributes > settings anymore as it looks a useless complication of the API. > Then the rte_thread API is made stable, > so we can remove the old deprecated functions > rte_thread_setname() and rte_ctrl_thread_create(). > > Some new internal functions are added in rte_thread to make sure > all internal thread names are prefixed with "dpdk-". > > Few other cleanups are done. > > Future work about pthread portability are about: > - cancel > - mutex > > --- > > v2 changes: > - replace (|_) with _? in checkpatch > - simplify thread name size doc > - build time check of internal thread name size > - clean control thread params struct > v3 change: > - fix build (wrong placement of RTE_BUILD_BUG_ON) > note for later: never send a patch during a summit! Series applied, thanks. -- David Marchand
Re: [PATCH] eal: fix location of per lcore macro documentation
On Thu, Sep 21, 2023 at 8:14 PM Tyler Retzlaff
wrote:
>
> doxygen document generation does traverse RTE_TOOLCHAIN_MSVC conditional
> compilation paths so move the documentation for per lcore macros out of
> the RTE_TOOLCHAIN_MSVC block.
>
> Fixes: b2f967dcae69 ("eal: implement per lcore variables for MSVC")
>
> Signed-off-by: Tyler Retzlaff
Reviewed-by: David Marchand
Applied, thanks Tyler.
--
David Marchand
Re: [PATCH 0/6] docs: Unify Getting Started Guides
Hello David, On Wed, Sep 20, 2023 at 5:49 PM David Young wrote: > > The separate Getting Started Guides for Linux, FreeBSD, and Windows have been > consolidated into a single, streamlined guide to simplify the user experience > and facilitate easier maintenance. > > David Young (6): > Section 1: Introduction > Section 2: Install and Build DPDK > Section 3: Setting up a System to Run DPDK Applications > Section 4: Running Applications > Section 5: Appendix > Section 6: Glossary >From my understanding, existing copyright banners should be preserved by this reorganisation work. Yet I noticed a few Copyright banners dated 2025, please double check and fix them. Bruce, Thomas, An open question, if new docs are created, who should this work be attributed to? the dpdk contributors? Thanks. -- David Marchand
RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
Hi, Konstantin
> -Original Message-
> From: Feifei Wang
> Sent: Tuesday, September 5, 2023 11:11 AM
> To: Konstantin Ananyev ; Konstantin
> Ananyev
> Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Yuying Zhang ; Beilei
> Xing ; nd ; nd ; nd
> ; nd ; nd
> Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
>
>
>
> > -Original Message-
> > From: Konstantin Ananyev
> > Sent: Monday, September 4, 2023 6:22 PM
> > To: Feifei Wang ; Konstantin Ananyev
> >
> > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > ; Ruifeng Wang
> ;
> > Yuying Zhang ; Beilei Xing
> > ; nd ; nd ; nd
> > ; nd
> > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> >
> >
> >
> > > > > > > > > > Define specific function implementation for i40e driver.
> > > > > > > > > > Currently, mbufs recycle mode can support 128bit
> > > > > > > > > > vector path and
> > > > > > > > > > avx2
> > > > > > > > path.
> > > > > > > > > > And can be enabled both in fast free and no fast free mode.
> > > > > > > > > >
> > > > > > > > > > Suggested-by: Honnappa Nagarahalli
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Feifei Wang
> > > > > > > > > > Reviewed-by: Ruifeng Wang
> > > > > > > > > > Reviewed-by: Honnappa Nagarahalli
> > > > > >
> > > > > > > > > > ---
> > > > > > > > > > drivers/net/i40e/i40e_ethdev.c| 1 +
> > > > > > > > > > drivers/net/i40e/i40e_ethdev.h| 2 +
> > > > > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c | 147
> > > > > > > > > > ++
> > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 32
> > > > > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 +
> > > > > > > > > > drivers/net/i40e/meson.build | 1 +
> > > > > > > > > > 6 files changed, 187 insertions(+) create mode
> > > > > > > > > > 100644
> > > > > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > >
> > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > > > > 8271bbb394..50ba9aac94
> > > > > > > > > > 100644
> > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > @@ -496,6 +496,7 @@ static const struct eth_dev_ops
> > > > > > > > > > i40e_eth_dev_ops
> > > > > > > > = {
> > > > > > > > > > .flow_ops_get = i40e_dev_flow_ops_get,
> > > > > > > > > > .rxq_info_get = i40e_rxq_info_get,
> > > > > > > > > > .txq_info_get = i40e_txq_info_get,
> > > > > > > > > > + .recycle_rxq_info_get =
> i40e_recycle_rxq_info_get,
> > > > > > > > > > .rx_burst_mode_get=
> i40e_rx_burst_mode_get,
> > > > > > > > > > .tx_burst_mode_get=
> i40e_tx_burst_mode_get,
> > > > > > > > > > .timesync_enable = i40e_timesync_enable,
> > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.h index
> > > > > > > > > > 6f65d5e0ac..af758798e1
> > > > > > > > > > 100644
> > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > @@ -1355,6 +1355,8 @@ void i40e_rxq_info_get(struct
> > > > > > > > > > rte_eth_dev *dev, uint16_t queue_id,
> > > > > > > > > > struct rte_eth_rxq_info *qinfo); void
> > > > > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t
> > > > > > > > > > queue_id,
> > > > > > > > > > struct rte_eth_txq_info *qinfo);
> > > > > > > > > > +void i40e_recycle_rxq_info_get(struct rte_eth_dev
> > > > > > > > > > +*dev, uint16_t
> > > > > > > > queue_id,
> > > > > > > > > > + struct rte_eth_recycle_rxq_info *recycle_rxq_info);
> > > > > > > > > > int i40e_rx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > uint16_t
> > > > > > queue_id,
> > > > > > > > > >struct rte_eth_burst_mode *mode);
> int
> > > > > > > > > > i40e_tx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > uint16_t queue_id, diff -- git
> > > > > > > > > > a/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > new file mode 100644
> > > > > > > > > > index 00..5663ecccde
> > > > > > > > > > --- /dev/null
> > > > > > > > > > +++ b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > @@ -0,0 +1,147 @@
> > > > > > > > > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > > > > > > > > + * Copyright (c) 2023 Arm Limited.
> > > > > > > > > > + */
> > > > > > > > > > +
> > > > > > > > > > +#include
> > > > > > > > > > +#include
> > > > > > > > > > +
> > > > > > > > > > +#include "base/i40e_prototype.h"
> > > > > > > > > > +#include "base/i40e_type.h"
> > > > > > > > > > +#include "i40e_ethdev.h"
> > > > > > > > > > +#include "i40e_rxtx.
Re: [PATCH] ethdev: validate reserved fields
On 9/21/2023 5:33 PM, Ferruh Yigit wrote:
> On 9/21/2023 4:12 PM, Ferruh Yigit wrote:
>> On 5/26/2023 9:15 AM, Bruce Richardson wrote:
>>> On Thu, May 25, 2023 at 01:39:42PM -0700, Stephen Hemminger wrote:
The various reserved fields added to ethdev could not be
safely used for future extensions because they were never
checked on input. Therefore ABI would be broken if these
fields were added in a future DPDK release.
Fixes: 436b3a6b6e62 ("ethdev: reserve space in main structs for extension")
Cc: tho...@monjalon.net
Signed-off-by: Stephen Hemminger
---
lib/ethdev/rte_ethdev.c | 41 +
1 file changed, 41 insertions(+)
>>> Acked-by: Bruce Richardson
>>>
>>
>> Acked-by: Ferruh Yigit
>>
>> Applied to dpdk-next-net/main, thanks.
>>
>
> some unit tests are failing with this patch, both iol and github actions
> reports it, need to investigate the root cause.
>
> Based on findings, we may need to drop the patch from next-net, fyi.
>
Unit test failures caused by segfault, because in
'rte_eth_rx_queue_setup()' & 'rte_eth_tx_queue_setup()' accepts
'rx_conf' & 'tx_conf' to be NULL, but checks doesn't take this into account.
Adding "rx_conf != NULL && (..)" check for Rx, and similar for Tx.
I will update in next-net, and force push.
Re: [PATCH v12 0/4] Recycle mbufs from Tx queue into Rx queue
On 9/20/2023 2:12 PM, Ferruh Yigit wrote: > On 8/24/2023 8:36 AM, Feifei Wang wrote: >> Currently, the transmit side frees the buffers into the lcore cache and >> the receive side allocates buffers from the lcore cache. The transmit >> side typically frees 32 buffers resulting in 32*8=256B of stores to >> lcore cache. The receive side allocates 32 buffers and stores them in >> the receive side software ring, resulting in 32*8=256B of stores and >> 256B of load from the lcore cache. >> >> This patch proposes a mechanism to avoid freeing to/allocating from >> the lcore cache. i.e. the receive side will free the buffers from >> transmit side directly into its software ring. This will avoid the 256B >> of loads and stores introduced by the lcore cache. It also frees up the >> cache lines used by the lcore cache. And we can call this mode as mbufs >> recycle mode. >> >> In the latest version, mbufs recycle mode is packaged as a separate API. >> This allows for the users to change rxq/txq pairing in real time in data >> plane, >> according to the analysis of the packet flow by the application, for example: >> --- >> Step 1: upper application analyse the flow direction >> Step 2: recycle_rxq_info = rte_eth_recycle_rx_queue_info_get(rx_portid, >> rx_queueid) >> Step 3: rte_eth_recycle_mbufs(rx_portid, rx_queueid, tx_portid, tx_queueid, >> recycle_rxq_info); >> Step 4: rte_eth_rx_burst(rx_portid,rx_queueid); >> Step 5: rte_eth_tx_burst(tx_portid,tx_queueid); >> --- >> Above can support user to change rxq/txq pairing at run-time and user does >> not need to >> know the direction of flow in advance. This can effectively expand mbufs >> recycle mode's >> use scenarios. >> >> Furthermore, mbufs recycle mode is no longer limited to the same pmd, >> it can support moving mbufs between different vendor pmds, even can put the >> mbufs >> anywhere into your Rx mbuf ring as long as the address of the mbuf ring can >> be provided. >> In the latest version, we enable mbufs recycle mode in i40e pmd and ixgbe >> pmd, and also try to >> use i40e driver in Rx, ixgbe driver in Tx, and then achieve 7-9% performance >> improvement >> by mbufs recycle mode. >> >> Difference between mbuf recycle, ZC API used in mempool and general path >> For general path: >> Rx: 32 pkts memcpy from mempool cache to rx_sw_ring >> Tx: 32 pkts memcpy from tx_sw_ring to temporary variable + >> 32 pkts memcpy from temporary variable to mempool cache >> For ZC API used in mempool: >> Rx: 32 pkts memcpy from mempool cache to rx_sw_ring >> Tx: 32 pkts memcpy from tx_sw_ring to zero-copy mempool cache >> Refer link: >> http://patches.dpdk.org/project/dpdk/patch/20230221055205.22984-2-kamalakshitha.alig...@arm.com/ >> For mbufs recycle: >> Rx/Tx: 32 pkts memcpy from tx_sw_ring to rx_sw_ring >> Thus we can see in the one loop, compared to general path, mbufs recycle >> mode reduces 32+32=64 pkts memcpy; >> Compared to ZC API used in mempool, we can see mbufs recycle mode reduce 32 >> pkts memcpy in each loop. >> So, mbufs recycle has its own benefits. >> >> Testing status: >> (1) dpdk l3fwd test with multiple drivers: >> port 0: 82599 NIC port 1: XL710 NIC >> - >> Without fast free With fast free >> Thunderx2: +7.53% +13.54% >> - >> >> (2) dpdk l3fwd test with same driver: >> port 0 && 1: XL710 NIC >> - >> Without fast free With fast free >> Ampere altra: +12.61% +11.42% >> n1sdp: +8.30% +3.85% >> x86-sse: +8.43% +3.72% >> - >> >> (3) Performance comparison with ZC_mempool used >> port 0 && 1: XL710 NIC >> with fast free >> - >> With recycle buffer With zc_mempool >> Ampere altra:11.42% 3.54% >> - >> >> Furthermore, we add recycle_mbuf engine in testpmd. Due to XL710 NIC has >> I/O bottleneck in testpmd in ampere altra, we can not see throughput change >> compared with I/O fwd engine. However, using record cmd in testpmd: >> '$set record-burst-stats on' >> we can see the ratio of 'Rx/Tx burst size of 32' is reduced. This >> indicate mbufs recycle can save CPU cycles. >> >> V2: >> 1. Use data-plane API to enable direct-rearm (Konstantin, Honnappa) >> 2. Add 'txq_data_get' API to get txq info for Rx (Konstantin) >> 3. Use input parameter to enable direct rearm in l3fwd (K
RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> -Original Message-
> From: Feifei Wang
> Sent: Friday, September 22, 2023 10:59 PM
> To: Konstantin Ananyev ; Konstantin
> Ananyev
> Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Yuying Zhang ; Beilei
> Xing ; nd ; nd ; nd
> ; nd ; nd ; nd
> Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
>
>
> Hi, Konstantin
>
> > -Original Message-
> > From: Feifei Wang
> > Sent: Tuesday, September 5, 2023 11:11 AM
> > To: Konstantin Ananyev ; Konstantin
> > Ananyev
> > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > ; Ruifeng Wang
> ;
> > Yuying Zhang ; Beilei Xing
> > ; nd ; nd ; nd
> > ; nd ; nd
> > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> >
> >
> >
> > > -Original Message-
> > > From: Konstantin Ananyev
> > > Sent: Monday, September 4, 2023 6:22 PM
> > > To: Feifei Wang ; Konstantin Ananyev
> > >
> > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > > ; Ruifeng Wang
> > ;
> > > Yuying Zhang ; Beilei Xing
> > > ; nd ; nd ; nd
> > > ; nd
> > > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> > >
> > >
> > >
> > > > > > > > > > > Define specific function implementation for i40e driver.
> > > > > > > > > > > Currently, mbufs recycle mode can support 128bit
> > > > > > > > > > > vector path and
> > > > > > > > > > > avx2
> > > > > > > > > path.
> > > > > > > > > > > And can be enabled both in fast free and no fast free
> > > > > > > > > > > mode.
> > > > > > > > > > >
> > > > > > > > > > > Suggested-by: Honnappa Nagarahalli
> > > > > > > > > > >
> > > > > > > > > > > Signed-off-by: Feifei Wang
> > > > > > > > > > > Reviewed-by: Ruifeng Wang
> > > > > > > > > > > Reviewed-by: Honnappa Nagarahalli
> > > > > > >
> > > > > > > > > > > ---
> > > > > > > > > > > drivers/net/i40e/i40e_ethdev.c| 1 +
> > > > > > > > > > > drivers/net/i40e/i40e_ethdev.h| 2 +
> > > > > > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c | 147
> > > > > > > > > > > ++
> > > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 32
> > > > > > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 +
> > > > > > > > > > > drivers/net/i40e/meson.build | 1 +
> > > > > > > > > > > 6 files changed, 187 insertions(+) create mode
> > > > > > > > > > > 100644
> > > > > > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > > > > > 8271bbb394..50ba9aac94
> > > > > > > > > > > 100644
> > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > @@ -496,6 +496,7 @@ static const struct eth_dev_ops
> > > > > > > > > > > i40e_eth_dev_ops
> > > > > > > > > = {
> > > > > > > > > > > .flow_ops_get = i40e_dev_flow_ops_get,
> > > > > > > > > > > .rxq_info_get = i40e_rxq_info_get,
> > > > > > > > > > > .txq_info_get = i40e_txq_info_get,
> > > > > > > > > > > + .recycle_rxq_info_get =
> > i40e_recycle_rxq_info_get,
> > > > > > > > > > > .rx_burst_mode_get=
> > i40e_rx_burst_mode_get,
> > > > > > > > > > > .tx_burst_mode_get=
> > i40e_tx_burst_mode_get,
> > > > > > > > > > > .timesync_enable = i40e_timesync_enable,
> > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.h index
> > > > > > > > > > > 6f65d5e0ac..af758798e1
> > > > > > > > > > > 100644
> > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > @@ -1355,6 +1355,8 @@ void i40e_rxq_info_get(struct
> > > > > > > > > > > rte_eth_dev *dev, uint16_t queue_id,
> > > > > > > > > > > struct rte_eth_rxq_info *qinfo); void
> > > > > > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t
> queue_id,
> > > > > > > > > > > struct rte_eth_txq_info *qinfo);
> > > > > > > > > > > +void i40e_recycle_rxq_info_get(struct rte_eth_dev
> > > > > > > > > > > +*dev, uint16_t
> > > > > > > > > queue_id,
> > > > > > > > > > > + struct rte_eth_recycle_rxq_info
> > > > > > > > > > > +*recycle_rxq_info);
> > > > > > > > > > > int i40e_rx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > > uint16_t
> > > > > > > queue_id,
> > > > > > > > > > > struct rte_eth_burst_mode *mode);
> > int
> > > > > > > > > > > i40e_tx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > > uint16_t queue_id, diff -- git
> > > > > > > > > > > a/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > new file mode 100644 index 00..5663ecccde
> > > > > > > > > > > --- /dev/null
> > > > > > > > >
Re: [PATCH 0/6] docs: Unify Getting Started Guides
On Fri, Sep 22, 2023 at 04:47:55PM +0200, David Marchand wrote: > Hello David, > > On Wed, Sep 20, 2023 at 5:49 PM David Young wrote: > > > > The separate Getting Started Guides for Linux, FreeBSD, and Windows have > > been > > consolidated into a single, streamlined guide to simplify the user > > experience > > and facilitate easier maintenance. > > > > David Young (6): > > Section 1: Introduction > > Section 2: Install and Build DPDK > > Section 3: Setting up a System to Run DPDK Applications > > Section 4: Running Applications > > Section 5: Appendix > > Section 6: Glossary > > From my understanding, existing copyright banners should be preserved > by this reorganisation work. > Yet I noticed a few Copyright banners dated 2025, please double check > and fix them. > > > Bruce, Thomas, > An open question, if new docs are created, who should this work be > attributed to? the dpdk contributors? > For this re-organisation, I expect the copyrights from the existing content be preserved - merging if so necessary, e.g. a page merged from two separate ones with differen copyright owners. For brand new content, the way things look now, it's just likely to come from existing DPDK experts, so they will apply their usual attributions AFAIK. /Bruce
RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
Hi Feifei,
> > > -Original Message-
> > > From: Feifei Wang
> > > Sent: Tuesday, September 5, 2023 11:11 AM
> > > To: Konstantin Ananyev ; Konstantin
> > > Ananyev
> > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > > ; Ruifeng Wang
> > ;
> > > Yuying Zhang ; Beilei Xing
> > > ; nd ; nd ; nd
> > > ; nd ; nd
> > > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> > >
> > >
> > >
> > > > -Original Message-
> > > > From: Konstantin Ananyev
> > > > Sent: Monday, September 4, 2023 6:22 PM
> > > > To: Feifei Wang ; Konstantin Ananyev
> > > >
> > > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > > > ; Ruifeng Wang
> > > ;
> > > > Yuying Zhang ; Beilei Xing
> > > > ; nd ; nd ; nd
> > > > ; nd
> > > > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> > > >
> > > >
> > > >
> > > > > > > > > > > > Define specific function implementation for i40e driver.
> > > > > > > > > > > > Currently, mbufs recycle mode can support 128bit
> > > > > > > > > > > > vector path and
> > > > > > > > > > > > avx2
> > > > > > > > > > path.
> > > > > > > > > > > > And can be enabled both in fast free and no fast free
> > > > > > > > > > > > mode.
> > > > > > > > > > > >
> > > > > > > > > > > > Suggested-by: Honnappa Nagarahalli
> > > > > > > > > > > >
> > > > > > > > > > > > Signed-off-by: Feifei Wang
> > > > > > > > > > > > Reviewed-by: Ruifeng Wang
> > > > > > > > > > > > Reviewed-by: Honnappa Nagarahalli
> > > > > > > >
> > > > > > > > > > > > ---
> > > > > > > > > > > > drivers/net/i40e/i40e_ethdev.c| 1 +
> > > > > > > > > > > > drivers/net/i40e/i40e_ethdev.h| 2 +
> > > > > > > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c | 147
> > > > > > > > > > > > ++
> > > > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 32
> > > > > > > > > > > >
> > > > > > > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 +
> > > > > > > > > > > > drivers/net/i40e/meson.build | 1 +
> > > > > > > > > > > > 6 files changed, 187 insertions(+) create mode
> > > > > > > > > > > > 100644
> > > > > > > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > >
> > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > > > > > > 8271bbb394..50ba9aac94
> > > > > > > > > > > > 100644
> > > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > @@ -496,6 +496,7 @@ static const struct eth_dev_ops
> > > > > > > > > > > > i40e_eth_dev_ops
> > > > > > > > > > = {
> > > > > > > > > > > > .flow_ops_get =
> > > > > > > > > > > > i40e_dev_flow_ops_get,
> > > > > > > > > > > > .rxq_info_get =
> > > > > > > > > > > > i40e_rxq_info_get,
> > > > > > > > > > > > .txq_info_get =
> > > > > > > > > > > > i40e_txq_info_get,
> > > > > > > > > > > > + .recycle_rxq_info_get =
> > > i40e_recycle_rxq_info_get,
> > > > > > > > > > > > .rx_burst_mode_get=
> > > i40e_rx_burst_mode_get,
> > > > > > > > > > > > .tx_burst_mode_get=
> > > i40e_tx_burst_mode_get,
> > > > > > > > > > > > .timesync_enable =
> > > > > > > > > > > > i40e_timesync_enable,
> > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.h index
> > > > > > > > > > > > 6f65d5e0ac..af758798e1
> > > > > > > > > > > > 100644
> > > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > @@ -1355,6 +1355,8 @@ void i40e_rxq_info_get(struct
> > > > > > > > > > > > rte_eth_dev *dev, uint16_t queue_id,
> > > > > > > > > > > > struct rte_eth_rxq_info *qinfo); void
> > > > > > > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t
> > queue_id,
> > > > > > > > > > > > struct rte_eth_txq_info *qinfo);
> > > > > > > > > > > > +void i40e_recycle_rxq_info_get(struct rte_eth_dev
> > > > > > > > > > > > +*dev, uint16_t
> > > > > > > > > > queue_id,
> > > > > > > > > > > > + struct rte_eth_recycle_rxq_info
> > > > > > > > > > > > +*recycle_rxq_info);
> > > > > > > > > > > > int i40e_rx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > > > uint16_t
> > > > > > > > queue_id,
> > > > > > > > > > > >struct rte_eth_burst_mode
> > > > > > > > > > > > *mode);
> > > int
> > > > > > > > > > > > i40e_tx_burst_mode_get(struct rte_eth_dev *dev,
> > > > > > > > > > > > uint16_t queue_id, diff -- git
> > > > > > > > > > > > a/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > > b/drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > > new file mode 100644 index 00..5
RE: [PATCH v1 1/7] bbdev: add FFT version member in driver info
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, September 22, 2023 1:15 AM
> To: Chautru, Nicolas ;
> hemant.agra...@nxp.com; dev@dpdk.org
> Cc: david.march...@redhat.com; Vargas, Hernan
>
> Subject: Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info
>
> Hi Nicolas,
>
> On 9/19/23 22:51, Chautru, Nicolas wrote:
> > Hi Maxime,
> >
> > This is neither part of 3GPP per se, nor specific to VRB device. Let me
> > provide
> more context.
> > The SRS processing chain
> (https://doc.dpdk.org/guides/prog_guide/bbdev.html#bbdev-fft-operation)
> includes a pointwise multiplication by time window.
> > The generic API include some control of these windowing function but still
> the actual shape need to be programmed onto any device (ie. rectangular,
> taped, sinc, different width or offset, any abritraty shape defined as an
> array
> of scalars). These degrees of liberties cannot be exposed through a generic
> API
> (information is multi-kB, ie the data itself) and can be user specific
> (external to
> the HW IP itself or outside of Intel control).
>
> Thanks for the explanations. I also did my homework as my FFT knowledge
> was buried quite deep in my memory. :)
>
> So this is a vendor-specific way to express generic paramaters.
Unsure this is that vendor specific. At least the interface allows to know a
hash of the table being loaded (which is just pointwise data really,
non-proprietary format). I did not state the content is a simple md5sum of the
bin file being loaded from linux.
> Regarding VRB device, is this table per device or per VF?
> Could it be configured by the application directly, or has it to be done
> through
> the PF?
This is configured for the device at platform level, ie. through operator.
Common to all application/devices. This captures the windows shape assumptions.
>
> > As an illustration for VRB device pf_bb_config provides to user an option to
> include such windowing data as an input ("FFT LUT bin file"), but more
> generally at platform level for any bb device this big Look-Up Table or big
> array can be configured on the host during platform initialization for a given
> deployment or vendor.
> > What is required here is for the user application to have knowledge of what
> version of such array is being used on the given platform, as this information
> would be relevant to processing done outside of bbdev (notably for noise
> estimate). Through that mechanism, the user can now map through that API
> which possible file was being used, and act accordingly.
> > The content itself is not specified, for VRB we just use the md5sum of that
> binary file (which is just a big array of int16 for point wise
> multiplication) so
> that this can be used to share knowledge between initialized platform
> configuration and at run-time user application assumption.
> > It is also important to under that the user/vendor may use any array or
> shape (based on their algorithm) regardless of Intel or IP, and still be able
> to
> share information mapping between what is configured on the platform
> (multiple versions possible) and what the application enumerates.
> >
> > I can add more details in the documentation indeed but above should
> arguably make sense. The name FFT_version naming may be quite vague, this
> is more related to the FFT pointwise windowing array variant assumed on the
> platform. I did not want to impose for it to be an md5sum necessarily, hence
> the vagueness, as it could be any hash shared between the device
> programming and the user application related to the semi-static FFT
> processing programming.
> >
> > Let me know if unclear or if any other thought,
>
> I think this is clear now to me.
>
> In my opinion, this is not good to have this part of the BBDEV API, as every
> vendor will have their own way to represent this.
>
> Other alternative is to have a vendor specific API. This is far from ideal and
> should be avoided as much as possible, but in this case the application has to
> know anyways which device it is driving. It would be at least clear the field
> has
> to be interpreted in a vendor-specific way.
>
> @Hemant, I would be interested in your opinion. (I don't know if NXP has or
> plans to have FFT accelerator IP)
Yes looking forward to it.
>
> Regards,
> Maxime
>
> > Thanks
> > Nic
> >
> >> -Original Message-
> >> From: Maxime Coquelin
> >> Sent: Tuesday, September 19, 2023 2:56 AM
> >> To: Chautru, Nicolas ; dev@dpdk.org
> >> Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas,
> Hernan
> >>
> >> Subject: Re: [PATCH v1 1/7] bbdev: add FFT version member in driver
> >> info
> >>
> >>
> >>
> >> On 9/19/23 03:21, Nicolas Chautru wrote:
> >>> This can be used to distinguish different version of the flexible
> >>> pointwise windowing applied to the FFT and expose this to the
> >>> application.
> >>
> >> Does this version relates to a standard, or is this specific to the
> >> im
[PATCH 1/1] eal: enable xz read support and ignore warning
archive_read_support_filter_xz returns a warning when
compression is not fully supported and is supported
through external program. This warning can be ignored
when reading the files through firmware open as only
decompression is required.
Fixes: 40edb9c0d36b ("eal: handle compressed firmware")
Cc: sta...@dpdk.org
Signed-off-by: Srikanth Yalavarthi
---
lib/eal/unix/eal_firmware.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c
index d1616b0bd9..05c06c222a 100644
--- a/lib/eal/unix/eal_firmware.c
+++ b/lib/eal/unix/eal_firmware.c
@@ -25,12 +25,19 @@ static int
firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t
blocksize)
{
struct archive_entry *e;
+ int err;
ctx->a = archive_read_new();
if (ctx->a == NULL)
return -1;
+
+ err = archive_read_support_filter_xz(ctx->a);
+ if (err != ARCHIVE_OK && err != ARCHIVE_WARN) {
+ ctx->a = NULL;
+ return -1;
+ }
+
if (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||
- archive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||
archive_read_open_filename(ctx->a, name, blocksize) !=
ARCHIVE_OK ||
archive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {
archive_read_free(ctx->a);
--
2.41.0
RE: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read
> -Original Message- > From: David Marchand > Sent: 22 September 2023 13:38 > To: Srikanth Yalavarthi > Cc: Jerin Jacob ; Prince Takkar > ; dev@dpdk.org; Shivah Shankar Shankar Narayan > Rao ; Anup Prabhu > Subject: Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for > firmware read > > Hello, > > On Fri, Sep 22, 2023 at 5:59 AM Srikanth Yalavarthi > wrote: > > > From: David Marchand On Thu, Sep 21, > > > 2023 at 3:06 PM Srikanth Yalavarthi wrote: > > > > > > > archive. This causes the ML firmware binary to be parsed > > > > > > > incorrectly. > > > > > > > > > > > > + @David Marchand rte_firmware_read() author for his opinions > > > > > > Did you check that all 4 checks are failing individually or are you saying > this 4 > tests fail as a whole? > > I have one suspicion on archive_read_support_filter_xz, which may return > ARCHIVE_WARN. Yes, archive_read_support_xz is returning ARCHIVE_WARN (-20). This is causing the firmware_open function to fail. I guess we can ignore the ARCHIVE_WARN, since this means about compression support, not decompression. ""These functions return ARCHIVE_OK if the compression is fully supported, ARCHIVE_WARN if the compression is supported only through an external program."" I have submitted a patch, which I have tested with compressed (xz) and uncompressed files. Please share your comments. http://patches.dpdk.org/project/dpdk/patch/20230922165356.31567-1-syalavar...@marvell.com/ > But that's my only serious hint so far. > > I have put up some debug patch, please have a try with it. > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__patchwork.dpdk.org_project_dpdk_patch_20230922080606.905222- > 2D1-2Ddavid.marchand- > 40redhat.com_&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=SNPqUkGl0n_ > Ms1iJa_6wD6LBwX8efL_NOyXvAX- > iCMI&m=gXmofsgJJekf5Jw2JIv1eESMDt3J_NyXqmHn9Gpk80XXWBsn7DBPjYsb > eghxAWQr&s=iwNgfFNxL60sMbI-OP-k78p45eUPFaWTN1kUsO4nguQ&e= Thanks for the debug patch and support. > > > -- > David Marchand
SIGILL in rte_cpu_get_flag_enabled / RTE_CPUFLAG_RTM
Hello, I'm trying to compile our tools on an older lab system and get Program received signal SIGILL, Illegal instruction. 0x7434c766 in rte_cpu_get_flag_enabled (feature=feature@entry=RTE_CPUFLAG_RTM) at ../lib/eal/x86/rte_cpuflags.c:173 173 return (regs[feat->reg] >> feat->bit) & 1; (gdb) bt #0 0x7434c766 in rte_cpu_get_flag_enabled (feature=feature@entry=RTE_CPUFLAG_RTM) at ../lib/eal/x86/rte_cpuflags.c:173 #1 0x73ffb572 in rte_rtm_init () at ../lib/eal/x86/rte_spinlock.c:14 ##2 0x77fc947e in call_init (l=, argc=argc@entry=1, argv=argv@entry=0x7fffe088, env=env@entry=0x7fffe098) at ./elf/dl-init.c:70 #3 0x77fc9568 in call_init (env=0x7fffe098, argv=0x7fffe088, argc=1, l=) at ./elf/dl-init.c:33 #4 _dl_init (main_map=0x77ffe2e0, argc=1, argv=0x7fffe088, env=0x7fffe098) at ./elf/dl-init.c:117 #5 0x77fe32ea in _dl_start_user () from /lib64/ld-linux-x86-64.so.2 This already has been reported here https://inbox.dpdk.org/users/c7ff2508-d633-404e-95af-5f604d8e8...@intel.com/t/ but I don't see a solution there. It just ends up asking for the line numbers. Well, the line is __cpuid_count(feat->leaf, feat->subleaf, regs[RTE_REG_EAX], regs[RTE_REG_EBX], regs[RTE_REG_ECX], regs[RTE_REG_EDX]); /* check if the feature is enabled */ return (regs[feat->reg] >> feat->bit) & 1; > line 173 Maybe this should catch SIGILL? Thanks, Bernd
Re: SIGILL in rte_cpu_get_flag_enabled / RTE_CPUFLAG_RTM
This already has been reported here https://inbox.dpdk.org/users/c7ff2508-d633-404e-95af-5f604d8e8...@intel.com/t/ but I don't see a solution there. It just ends up asking for the line numbers. Well, the line is __cpuid_count(feat->leaf, feat->subleaf, regs[RTE_REG_EAX], regs[RTE_REG_EBX], regs[RTE_REG_ECX], regs[RTE_REG_EDX]); /* check if the feature is enabled */ return (regs[feat->reg] >> feat->bit) & 1; > line 173 Maybe this should catch SIGILL? Hmm, after disabling 2 flags in that function (fast workaround) it continues with reflect_32bits (val=) at ../lib/net/rte_net_crc.c:96 96 if ((val & (1U << i)) != 0) (gdb) bt #0 reflect_32bits (val=) at ../lib/net/rte_net_crc.c:96 #1 crc32_eth_init_lut (poly=poly@entry=79764919, lut=lut@entry=0x770b9d40 ) at ../lib/net/rte_net_crc.c:109 #2 0x73ffcc99 in rte_net_crc_scalar_init () at ../lib/net/rte_net_crc.c:137 #3 rte_net_crc_init () at ../lib/net/rte_net_crc.c:337 #4 0x77fc947e in call_init (l=, argc=argc@entry=1, argv=argv@entry=0x7fffe078, env=env@entry=0x7fffe088) at ./elf/dl-init.c:70 #5 0x77fc9568 in call_init (env=0x7fffe088, argv=0x7fffe078, argc=1, l=) at ./elf/dl-init.c:33 #6 _dl_init (main_map=0x77ffe2e0, argc=1, argv=0x7fffe078, env=0x7fffe088) at ./elf/dl-init.c:117 #7 0x77fe32ea in _dl_start_user () from /lib64/ld-linux-x86-64.so.2 #8 0x0001 in ?? () #9 0x7fffe356 in ?? () #10 0x in ?? ()
[PATCH v2 00/12] event DMA adapter library support
This series adds support for event DMA adapter library. API's defined as part of this library can be used by the application for DMA transfer of data using event based mechanism. v2: - Resolved review comments. - Patch split into multiple patches. Amit Prakash Shukla (12): eventdev: introduce event DMA adapter library eventdev: api to get DMA adapter capabilities eventdev: add DMA adapter API to create and free eventdev: api support for vchan add and delete eventdev: add support for service function eventdev: api support for DMA adapter start stop eventdev: api support to get DMA adapter service ID eventdev: add DMA adapter support for runtime params eventdev: add support for DMA adapter stats eventdev: add support for DMA adapter enqueue eventdev: add DMA adapter port get app/test: add event DMA adapter auto-test MAINTAINERS |5 + app/test/meson.build |1 + app/test/test_event_dma_adapter.c | 808 ++ config/rte_config.h |1 + doc/api/doxy-api-index.md |1 + doc/guides/eventdevs/features/default.ini |8 + doc/guides/prog_guide/event_dma_adapter.rst | 264 +++ doc/guides/prog_guide/eventdev.rst|8 +- .../img/event_dma_adapter_op_forward.svg | 1086 + .../img/event_dma_adapter_op_new.svg | 1079 + doc/guides/prog_guide/index.rst |1 + doc/guides/rel_notes/release_23_11.rst|4 +- lib/eventdev/eventdev_pmd.h | 175 +- lib/eventdev/eventdev_private.c | 10 + lib/eventdev/meson.build |4 +- lib/eventdev/rte_event_dma_adapter.c | 1431 + lib/eventdev/rte_event_dma_adapter.h | 582 +++ lib/eventdev/rte_eventdev.c | 23 + lib/eventdev/rte_eventdev.h | 43 + lib/eventdev/rte_eventdev_core.h |8 +- lib/eventdev/version.map | 15 + lib/meson.build |2 +- 22 files changed, 5551 insertions(+), 8 deletions(-) create mode 100644 app/test/test_event_dma_adapter.c create mode 100644 doc/guides/prog_guide/event_dma_adapter.rst create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_forward.svg create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_new.svg create mode 100644 lib/eventdev/rte_event_dma_adapter.c create mode 100644 lib/eventdev/rte_event_dma_adapter.h -- 2.25.1
[PATCH v2 01/12] eventdev: introduce event DMA adapter library
Introduce event DMA adapter APIs. The change provides information on adapter modes and usage. Application can use this event adapter interface to transfer packets between DMA device and event device. Signed-off-by: Amit Prakash Shukla --- MAINTAINERS |5 + doc/api/doxy-api-index.md |1 + doc/guides/eventdevs/features/default.ini |8 + doc/guides/prog_guide/event_dma_adapter.rst | 264 doc/guides/prog_guide/eventdev.rst|8 +- .../img/event_dma_adapter_op_forward.svg | 1086 + .../img/event_dma_adapter_op_new.svg | 1079 doc/guides/prog_guide/index.rst |1 + doc/guides/rel_notes/release_23_11.rst|4 +- lib/eventdev/eventdev_pmd.h | 175 ++- lib/eventdev/eventdev_private.c | 10 + lib/eventdev/meson.build |1 + lib/eventdev/rte_event_dma_adapter.h | 582 + lib/eventdev/rte_eventdev.h | 43 + lib/eventdev/rte_eventdev_core.h |8 +- lib/eventdev/version.map | 15 + 16 files changed, 3284 insertions(+), 6 deletions(-) create mode 100644 doc/guides/prog_guide/event_dma_adapter.rst create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_forward.svg create mode 100644 doc/guides/prog_guide/img/event_dma_adapter_op_new.svg create mode 100644 lib/eventdev/rte_event_dma_adapter.h diff --git a/MAINTAINERS b/MAINTAINERS index a926155f26..a6b8fc88d0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,11 @@ F: drivers/raw/skeleton/ F: app/test/test_rawdev.c F: doc/guides/prog_guide/rawdev.rst +Eventdev DMA Adapter API +M: Amit Prakash Shukla +T: git://dpdk.org/next/dpdk-next-eventdev +F: lib/eventdev/*dma_adapter* +F: doc/guides/prog_guide/event_dma_adapter.rst Memory Pool Drivers --- diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index fdeda13932..b7df7be4d9 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -29,6 +29,7 @@ The public API headers are grouped by topics: [event_eth_tx_adapter](@ref rte_event_eth_tx_adapter.h), [event_timer_adapter](@ref rte_event_timer_adapter.h), [event_crypto_adapter](@ref rte_event_crypto_adapter.h), + [event_dma_adapter](@ref rte_event_dma_adapter.h), [rawdev](@ref rte_rawdev.h), [metrics](@ref rte_metrics.h), [bitrate](@ref rte_bitrate.h), diff --git a/doc/guides/eventdevs/features/default.ini b/doc/guides/eventdevs/features/default.ini index 00360f60c6..73a52d915b 100644 --- a/doc/guides/eventdevs/features/default.ini +++ b/doc/guides/eventdevs/features/default.ini @@ -44,6 +44,14 @@ internal_port_op_fwd = internal_port_qp_ev_bind = session_private_data = +; +; Features of a default DMA adapter. +; +[DMA adapter Features] +internal_port_op_new = +internal_port_op_fwd = +internal_port_vchan_ev_bind = + ; ; Features of a default Timer adapter. ; diff --git a/doc/guides/prog_guide/event_dma_adapter.rst b/doc/guides/prog_guide/event_dma_adapter.rst new file mode 100644 index 00..eeb9ce6dfd --- /dev/null +++ b/doc/guides/prog_guide/event_dma_adapter.rst @@ -0,0 +1,264 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright (c) 2023 Marvell. + +Event DMA Adapter Library += + +DPDK :doc:`Eventdev library ` provides event driven programming model with features +to schedule events. :doc:`DMA Device library ` provides an interface to DMA poll mode +drivers that support DMA operations. Event DMA Adapter is intended to bridge between the event +device and the DMA device. + +Packet flow from DMA device to the event device can be accomplished using software and hardware +based transfer mechanisms. The adapter queries an eventdev PMD to determine which mechanism to +be used. The adapter uses an EAL service core function for software based packet transfer and +uses the eventdev PMD functions to configure hardware based packet transfer between DMA device +and the event device. DMA adapter uses a new event type called ``RTE_EVENT_TYPE_DMADEV`` to +indicate the source of event. + +Application can choose to submit an DMA operation directly to an DMA device or send it to an DMA +adapter via eventdev based on RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD capability. The +first mode is known as the event new (RTE_EVENT_DMA_ADAPTER_OP_NEW) mode and the second as the +event forward (RTE_EVENT_DMA_ADAPTER_OP_FORWARD) mode. Choice of mode can be specified while +creating the adapter. In the former mode, it is the application's responsibility to enable +ingress packet ordering. In the latter mode, it is the adapter's responsibility to enable +ingress packet ordering. + + +Adapter Modes +- + +RTE_EVENT_DMA_ADAPTER_OP_NEW mode +~ + +In the RTE_EVENT_DMA_ADAPTER_OP_NEW mode,
[PATCH v2 02/12] eventdev: api to get DMA adapter capabilities
Added a new eventdev API rte_event_dma_adapter_caps_get(), to get
DMA adapter capabilities supported by the driver.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/meson.build| 2 +-
lib/eventdev/rte_eventdev.c | 23 +++
lib/eventdev/rte_eventdev.h | 2 +-
lib/meson.build | 2 +-
4 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
index 21347f7c4c..b46bbbc9aa 100644
--- a/lib/eventdev/meson.build
+++ b/lib/eventdev/meson.build
@@ -43,5 +43,5 @@ driver_sdk_headers += files(
'event_timer_adapter_pmd.h',
)
-deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev']
+deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev',
'dmadev']
deps += ['telemetry']
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 6ab4524332..60509c6efb 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
@@ -224,6 +225,28 @@ rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t
eth_port_id,
: 0;
}
+int
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dma_dev_id, uint32_t
*caps)
+{
+ struct rte_eventdev *dev;
+
+ RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
+ if (!rte_dma_is_valid(dma_dev_id))
+ return -EINVAL;
+
+ dev = &rte_eventdevs[dev_id];
+
+ if (caps == NULL)
+ return -EINVAL;
+
+ *caps = 0;
+
+ if (dev->dev_ops->dma_adapter_caps_get)
+ return (*dev->dev_ops->dma_adapter_caps_get)(dev, dma_dev_id,
caps);
+
+ return 0;
+}
+
static inline int
event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
{
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index 026f7c367d..cef90aebf6 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1503,7 +1503,7 @@ rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t
cdev_id,
*
*/
int
-rte_event_dma_adapter_caps_get(uint8_t dev_id, int16_t dmadev_id, uint32_t
*caps);
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dmadev_id, uint32_t
*caps);
/* Ethdev Tx adapter capability bitmap flags */
#define RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT 0x1
diff --git a/lib/meson.build b/lib/meson.build
index 53155be8e9..f3191f10b6 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -33,6 +33,7 @@ libraries = [
'compressdev',
'cryptodev',
'distributor',
+'dmadev',
'efd',
'eventdev',
'gpudev',
@@ -48,7 +49,6 @@ libraries = [
'rawdev',
'regexdev',
'mldev',
-'dmadev',
'rib',
'reorder',
'sched',
--
2.25.1
[PATCH v2 03/12] eventdev: add DMA adapter API to create and free
This patch adds API support to create and free DMA adapter.
Signed-off-by: Amit Prakash Shukla
---
config/rte_config.h | 1 +
lib/eventdev/meson.build | 1 +
lib/eventdev/rte_event_dma_adapter.c | 335 +++
3 files changed, 337 insertions(+)
create mode 100644 lib/eventdev/rte_event_dma_adapter.c
diff --git a/config/rte_config.h b/config/rte_config.h
index 400e44e3cf..401727703f 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -77,6 +77,7 @@
#define RTE_EVENT_ETH_INTR_RING_SIZE 1024
#define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
#define RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE 32
+#define RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE 32
/* rawdev defines */
#define RTE_RAWDEV_MAX_DEVS 64
diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
index b46bbbc9aa..250abcb154 100644
--- a/lib/eventdev/meson.build
+++ b/lib/eventdev/meson.build
@@ -17,6 +17,7 @@ sources = files(
'eventdev_private.c',
'eventdev_trace_points.c',
'rte_event_crypto_adapter.c',
+'rte_event_dma_adapter.c',
'rte_event_eth_rx_adapter.c',
'rte_event_eth_tx_adapter.c',
'rte_event_ring.c',
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
new file mode 100644
index 00..c7ffba1b47
--- /dev/null
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -0,0 +1,335 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Marvell.
+ */
+
+#include "rte_eventdev.h"
+#include "eventdev_pmd.h"
+#include "rte_event_dma_adapter.h"
+
+#define DMA_BATCH_SIZE 32
+#define DMA_DEFAULT_MAX_NB 128
+#define DMA_ADAPTER_NAME_LEN 32
+#define DMA_ADAPTER_BUFFER_SIZE 1024
+
+#define DMA_ADAPTER_OPS_BUFFER_SIZE (DMA_BATCH_SIZE + DMA_BATCH_SIZE)
+
+#define DMA_ADAPTER_ARRAY "event_dma_adapter_array"
+
+/* Macros to check for valid adapter */
+#define EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) \
+ do { \
+ if (!edma_adapter_valid_id(id)) { \
+ RTE_EDEV_LOG_ERR("Invalid DMA adapter id = %d\n", id); \
+ return retval; \
+ } \
+ } while (0)
+
+/* DMA ops circular buffer */
+struct dma_ops_circular_buffer {
+ /* Index of head element */
+ uint16_t head;
+
+ /* Index of tail element */
+ uint16_t tail;
+
+ /* Number of elements in buffer */
+ uint16_t count;
+
+ /* Size of circular buffer */
+ uint16_t size;
+
+ /* Pointer to hold rte_event_dma_adapter_op for processing */
+ struct rte_event_dma_adapter_op **op_buffer;
+} __rte_cache_aligned;
+
+/* DMA device information */
+struct dma_device_info {
+ /* Number of vchans configured for a DMA device. */
+ uint16_t num_dma_dev_vchan;
+} __rte_cache_aligned;
+
+struct event_dma_adapter {
+ /* Event device identifier */
+ uint8_t eventdev_id;
+
+ /* Event port identifier */
+ uint8_t event_port_id;
+
+ /* Adapter mode */
+ enum rte_event_dma_adapter_mode mode;
+
+ /* Memory allocation name */
+ char mem_name[DMA_ADAPTER_NAME_LEN];
+
+ /* Socket identifier cached from eventdev */
+ int socket_id;
+
+ /* Lock to serialize config updates with service function */
+ rte_spinlock_t lock;
+
+ /* DMA device structure array */
+ struct dma_device_info *dma_devs;
+
+ /* Circular buffer for processing DMA ops to eventdev */
+ struct dma_ops_circular_buffer ebuf;
+
+ /* Configuration callback for rte_service configuration */
+ rte_event_dma_adapter_conf_cb conf_cb;
+
+ /* Configuration callback argument */
+ void *conf_arg;
+
+ /* Set if default_cb is being used */
+ int default_cb_arg;
+} __rte_cache_aligned;
+
+static struct event_dma_adapter **event_dma_adapter;
+
+static inline int
+edma_adapter_valid_id(uint8_t id)
+{
+ return id < RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE;
+}
+
+static inline struct event_dma_adapter *
+edma_id_to_adapter(uint8_t id)
+{
+ return event_dma_adapter ? event_dma_adapter[id] : NULL;
+}
+
+static int
+edma_array_init(void)
+{
+ const struct rte_memzone *mz;
+ uint32_t sz;
+
+ mz = rte_memzone_lookup(DMA_ADAPTER_ARRAY);
+ if (mz == NULL) {
+ sz = sizeof(struct event_dma_adapter *) *
RTE_EVENT_DMA_ADAPTER_MAX_INSTANCE;
+ sz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);
+
+ mz = rte_memzone_reserve_aligned(DMA_ADAPTER_ARRAY, sz,
rte_socket_id(), 0,
+RTE_CACHE_LINE_SIZE);
+ if (mz == NULL) {
+ RTE_EDEV_LOG_ERR("Failed to reserve memzone : %s, err =
%d",
+DMA_ADAPTER_ARRAY, rte_errno);
+ return -rte_errno;
+ }
+ }
+
+ event_dma_adapter = mz->addr;
+
+ return 0;
+}
+
+static inline int
+edma_c
[PATCH v2 04/12] eventdev: api support for vchan add and delete
Added API support to add and delete vchan's for a DMA device.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 204 +++
1 file changed, 204 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index c7ffba1b47..dd58188bf3 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -42,8 +42,31 @@ struct dma_ops_circular_buffer {
struct rte_event_dma_adapter_op **op_buffer;
} __rte_cache_aligned;
+/* Vchan information */
+struct dma_vchan_info {
+ /* Set to indicate vchan queue is enabled */
+ bool vq_enabled;
+
+ /* Circular buffer for batching DMA ops to dma_dev */
+ struct dma_ops_circular_buffer dma_buf;
+} __rte_cache_aligned;
+
/* DMA device information */
struct dma_device_info {
+ /* Pointer to vchan queue info */
+ struct dma_vchan_info *vchanq;
+
+ /* Pointer to vchan queue info.
+* This holds ops passed by application till the
+* dma completion is done.
+*/
+ struct dma_vchan_info *tqmap;
+
+ /* If num_vchanq > 0, the start callback will
+* be invoked if not already invoked
+*/
+ uint16_t num_vchanq;
+
/* Number of vchans configured for a DMA device. */
uint16_t num_dma_dev_vchan;
} __rte_cache_aligned;
@@ -81,6 +104,9 @@ struct event_dma_adapter {
/* Set if default_cb is being used */
int default_cb_arg;
+
+ /* No. of vchan queue configured */
+ uint16_t nb_vchanq;
} __rte_cache_aligned;
static struct event_dma_adapter **event_dma_adapter;
@@ -333,3 +359,181 @@ rte_event_dma_adapter_free(uint8_t id)
return 0;
}
+
+static void
+edma_update_vchanq_info(struct event_dma_adapter *adapter, struct
dma_device_info *dev_info,
+ uint16_t vchan, uint8_t add)
+{
+ struct dma_vchan_info *vchan_info;
+ struct dma_vchan_info *tqmap_info;
+ int enabled;
+ uint16_t i;
+
+ if (dev_info->vchanq == NULL)
+ return;
+
+ if (vchan == RTE_DMA_ALL_VCHAN) {
+ for (i = 0; i < dev_info->num_dma_dev_vchan; i++)
+ edma_update_vchanq_info(adapter, dev_info, i, add);
+ } else {
+ tqmap_info = &dev_info->tqmap[vchan];
+ vchan_info = &dev_info->vchanq[vchan];
+ enabled = vchan_info->vq_enabled;
+ if (add) {
+ adapter->nb_vchanq += !enabled;
+ dev_info->num_vchanq += !enabled;
+ } else {
+ adapter->nb_vchanq -= enabled;
+ dev_info->num_vchanq -= enabled;
+ }
+ vchan_info->vq_enabled = !!add;
+ tqmap_info->vq_enabled = !!add;
+ }
+}
+
+int
+rte_event_dma_adapter_vchan_add(uint8_t id, int16_t dma_dev_id, uint16_t vchan,
+ const struct rte_event *event)
+{
+ struct event_dma_adapter *adapter;
+ struct dma_device_info *dev_info;
+ struct rte_eventdev *dev;
+ uint32_t cap;
+ int ret;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ if (!rte_dma_is_valid(dma_dev_id)) {
+ RTE_EDEV_LOG_ERR("Invalid dma_dev_id = %" PRIu8, dma_dev_id);
+ return -EINVAL;
+ }
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL)
+ return -EINVAL;
+
+ dev = &rte_eventdevs[adapter->eventdev_id];
+ ret = rte_event_dma_adapter_caps_get(adapter->eventdev_id, dma_dev_id,
&cap);
+ if (ret) {
+ RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %u dma_dev
%u", id, dma_dev_id);
+ return ret;
+ }
+
+ if ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) &&
(event == NULL)) {
+ RTE_EDEV_LOG_ERR("Event can not be NULL for dma_dev_id = %u",
dma_dev_id);
+ return -EINVAL;
+ }
+
+ dev_info = &adapter->dma_devs[dma_dev_id];
+ if (vchan != RTE_DMA_ALL_VCHAN && vchan >= dev_info->num_dma_dev_vchan)
{
+ RTE_EDEV_LOG_ERR("Invalid vhcan %u", vchan);
+ return -EINVAL;
+ }
+
+ /* In case HW cap is RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, no
+* need of service core as HW supports event forward capability.
+*/
+ if ((cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+ (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND &&
+adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW) ||
+ (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW &&
+adapter->mode == RTE_EVENT_DMA_ADAPTER_OP_NEW)) {
+ if (*dev->dev_ops->dma_adapter_vchan_add == NULL)
+ return -ENOTSUP;
+ if (dev_info->vchanq == NULL) {
+ dev_inf
[PATCH v2 05/12] eventdev: add support for service function
Added support for DMA adapter service function for event devices.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 589 +++
1 file changed, 589 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index dd58188bf3..a9b9452aa0 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -2,6 +2,8 @@
* Copyright (c) 2023 Marvell.
*/
+#include
+
#include "rte_eventdev.h"
#include "eventdev_pmd.h"
#include "rte_event_dma_adapter.h"
@@ -69,6 +71,10 @@ struct dma_device_info {
/* Number of vchans configured for a DMA device. */
uint16_t num_dma_dev_vchan;
+
+ /* Next queue pair to be processed */
+ uint16_t next_vchan_id;
+
} __rte_cache_aligned;
struct event_dma_adapter {
@@ -90,6 +96,9 @@ struct event_dma_adapter {
/* Lock to serialize config updates with service function */
rte_spinlock_t lock;
+ /* Next dma device to be processed */
+ uint16_t next_dmadev_id;
+
/* DMA device structure array */
struct dma_device_info *dma_devs;
@@ -107,6 +116,26 @@ struct event_dma_adapter {
/* No. of vchan queue configured */
uint16_t nb_vchanq;
+
+ /* Per adapter EAL service ID */
+ uint32_t service_id;
+
+ /* Service initialization state */
+ uint8_t service_initialized;
+
+ /* Max DMA ops processed in any service function invocation */
+ uint32_t max_nb;
+
+ /* Store event port's implicit release capability */
+ uint8_t implicit_release_disabled;
+
+ /* Flag to indicate backpressure at dma_dev
+* Stop further dequeuing events from eventdev
+*/
+ bool stop_enq_to_dma_dev;
+
+ /* Loop counter to flush dma ops */
+ uint16_t transmit_loop_count;
} __rte_cache_aligned;
static struct event_dma_adapter **event_dma_adapter;
@@ -148,6 +177,18 @@ edma_array_init(void)
return 0;
}
+static inline bool
+edma_circular_buffer_batch_ready(struct dma_ops_circular_buffer *bufp)
+{
+ return bufp->count >= DMA_BATCH_SIZE;
+}
+
+static inline bool
+edma_circular_buffer_space_for_batch(struct dma_ops_circular_buffer *bufp)
+{
+ return (bufp->size - bufp->count) >= DMA_BATCH_SIZE;
+}
+
static inline int
edma_circular_buffer_init(const char *name, struct dma_ops_circular_buffer
*buf, uint16_t sz)
{
@@ -166,6 +207,67 @@ edma_circular_buffer_free(struct dma_ops_circular_buffer
*buf)
rte_free(buf->op_buffer);
}
+static inline int
+edma_circular_buffer_add(struct dma_ops_circular_buffer *bufp, struct
rte_event_dma_adapter_op *op)
+{
+ uint16_t *tail = &bufp->tail;
+
+ bufp->op_buffer[*tail] = op;
+
+ /* circular buffer, go round */
+ *tail = (*tail + 1) % bufp->size;
+ bufp->count++;
+
+ return 0;
+}
+
+static inline int
+edma_circular_buffer_flush_to_dma_dev(struct event_dma_adapter *adapter,
+ struct dma_ops_circular_buffer *bufp,
uint8_t dma_dev_id,
+ uint16_t vchan, uint16_t *nb_ops_flushed)
+{
+ struct rte_event_dma_adapter_op *op;
+ struct dma_vchan_info *tq;
+ uint16_t *head = &bufp->head;
+ uint16_t *tail = &bufp->tail;
+ uint16_t n;
+ uint16_t i;
+ int ret;
+
+ if (*tail > *head)
+ n = *tail - *head;
+ else if (*tail < *head)
+ n = bufp->size - *head;
+ else {
+ *nb_ops_flushed = 0;
+ return 0; /* buffer empty */
+ }
+
+ tq = &adapter->dma_devs[dma_dev_id].tqmap[vchan];
+
+ for (i = 0; i < n; i++) {
+ op = bufp->op_buffer[*head];
+ ret = rte_dma_copy_sg(dma_dev_id, vchan, op->src_seg,
op->dst_seg,
+ op->nb_src, op->nb_dst, op->flags);
+ if (ret < 0)
+ break;
+
+ /* Enqueue in transaction queue. */
+ edma_circular_buffer_add(&tq->dma_buf, op);
+
+ *head = (*head + 1) % bufp->size;
+ }
+
+ *nb_ops_flushed = i;
+ bufp->count -= *nb_ops_flushed;
+ if (!bufp->count) {
+ *head = 0;
+ *tail = 0;
+ }
+
+ return *nb_ops_flushed == n ? 0 : -1;
+}
+
static int
edma_default_config_cb(uint8_t id, uint8_t evdev_id, struct
rte_event_dma_adapter_conf *conf,
void *arg)
@@ -360,6 +462,406 @@ rte_event_dma_adapter_free(uint8_t id)
return 0;
}
+static inline unsigned int
+edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev,
unsigned int cnt)
+{
+ struct dma_vchan_info *vchan_qinfo = NULL;
+ struct rte_event_dma_adapter_op *dma_op;
+ uint16_t vchan, nb_enqueued = 0;
+ int16_t dma_dev_id;
+ unsigned int i, n;
+ int ret;
+
+ ret = 0;
+
[PATCH v2 06/12] eventdev: api support for DMA adapter start stop
Added API support to start and stop DMA adapter.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 69
1 file changed, 69 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index a9b9452aa0..2f574cb7ea 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -75,6 +75,13 @@ struct dma_device_info {
/* Next queue pair to be processed */
uint16_t next_vchan_id;
+ /* Set to indicate processing has been started */
+ uint8_t dev_started;
+
+ /* Set to indicate dmadev->eventdev packet
+* transfer uses a hardware mechanism
+*/
+ uint8_t internal_event_port;
} __rte_cache_aligned;
struct event_dma_adapter {
@@ -1126,3 +1133,65 @@ rte_event_dma_adapter_vchan_del(uint8_t id, int16_t
dma_dev_id, uint16_t vchan)
return ret;
}
+
+static int
+edma_adapter_ctrl(uint8_t id, int start)
+{
+ struct event_dma_adapter *adapter;
+ struct dma_device_info *dev_info;
+ struct rte_eventdev *dev;
+ uint16_t num_dma_dev;
+ int stop = !start;
+ int use_service;
+ uint32_t i;
+
+ use_service = 0;
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL)
+ return -EINVAL;
+
+ num_dma_dev = rte_dma_count_avail();
+ dev = &rte_eventdevs[adapter->eventdev_id];
+
+ for (i = 0; i < num_dma_dev; i++) {
+ dev_info = &adapter->dma_devs[i];
+ /* start check for num queue pairs */
+ if (start && !dev_info->num_vchanq)
+ continue;
+ /* stop check if dev has been started */
+ if (stop && !dev_info->dev_started)
+ continue;
+ use_service |= !dev_info->internal_event_port;
+ dev_info->dev_started = start;
+ if (dev_info->internal_event_port == 0)
+ continue;
+ start ? (*dev->dev_ops->dma_adapter_start)(dev, i) :
+ (*dev->dev_ops->dma_adapter_stop)(dev, i);
+ }
+
+ if (use_service)
+ rte_service_runstate_set(adapter->service_id, start);
+
+ return 0;
+}
+
+int
+rte_event_dma_adapter_start(uint8_t id)
+{
+ struct event_dma_adapter *adapter;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL)
+ return -EINVAL;
+
+ return edma_adapter_ctrl(id, 1);
+}
+
+int
+rte_event_dma_adapter_stop(uint8_t id)
+{
+ return edma_adapter_ctrl(id, 0);
+}
--
2.25.1
[PATCH v2 08/12] eventdev: add DMA adapter support for runtime params
Added support to set and get runtime params for DMA adapter.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 93
1 file changed, 93 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index e66e0307b9..20817768fc 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1212,3 +1212,96 @@ rte_event_dma_adapter_stop(uint8_t id)
{
return edma_adapter_ctrl(id, 0);
}
+
+#define DEFAULT_MAX_NB 128
+
+int
+rte_event_dma_adapter_runtime_params_init(struct
rte_event_dma_adapter_runtime_params *params)
+{
+ if (params == NULL)
+ return -EINVAL;
+
+ memset(params, 0, sizeof(*params));
+ params->max_nb = DEFAULT_MAX_NB;
+
+ return 0;
+}
+
+static int
+dma_adapter_cap_check(struct event_dma_adapter *adapter)
+{
+ uint32_t caps;
+ int ret;
+
+ if (!adapter->nb_vchanq)
+ return -EINVAL;
+
+ ret = rte_event_dma_adapter_caps_get(adapter->eventdev_id,
adapter->next_dmadev_id, &caps);
+ if (ret) {
+ RTE_EDEV_LOG_ERR("Failed to get adapter caps dev %" PRIu8 "
cdev %" PRIu8,
+adapter->eventdev_id, adapter->next_dmadev_id);
+ return ret;
+ }
+
+ if ((caps & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) ||
+ (caps & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
+ return -ENOTSUP;
+
+ return 0;
+}
+
+int
+rte_event_dma_adapter_runtime_params_set(uint8_t id,
+struct
rte_event_dma_adapter_runtime_params *params)
+{
+ struct event_dma_adapter *adapter;
+ int ret;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ if (params == NULL) {
+ RTE_EDEV_LOG_ERR("params pointer is NULL\n");
+ return -EINVAL;
+ }
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL)
+ return -EINVAL;
+
+ ret = dma_adapter_cap_check(adapter);
+ if (ret)
+ return ret;
+
+ rte_spinlock_lock(&adapter->lock);
+ adapter->max_nb = params->max_nb;
+ rte_spinlock_unlock(&adapter->lock);
+
+ return 0;
+}
+
+int
+rte_event_dma_adapter_runtime_params_get(uint8_t id,
+struct
rte_event_dma_adapter_runtime_params *params)
+{
+ struct event_dma_adapter *adapter;
+ int ret;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ if (params == NULL) {
+ RTE_EDEV_LOG_ERR("params pointer is NULL\n");
+ return -EINVAL;
+ }
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL)
+ return -EINVAL;
+
+ ret = dma_adapter_cap_check(adapter);
+ if (ret)
+ return ret;
+
+ params->max_nb = adapter->max_nb;
+
+ return 0;
+}
--
2.25.1
[PATCH v2 07/12] eventdev: api support to get DMA adapter service ID
Added API support to get DMA adapter service ID.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index 2f574cb7ea..e66e0307b9 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1134,6 +1134,23 @@ rte_event_dma_adapter_vchan_del(uint8_t id, int16_t
dma_dev_id, uint16_t vchan)
return ret;
}
+int
+rte_event_dma_adapter_service_id_get(uint8_t id, uint32_t *service_id)
+{
+ struct event_dma_adapter *adapter;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL || service_id == NULL)
+ return -EINVAL;
+
+ if (adapter->service_initialized)
+ *service_id = adapter->service_id;
+
+ return adapter->service_initialized ? 0 : -ESRCH;
+}
+
static int
edma_adapter_ctrl(uint8_t id, int start)
{
--
2.25.1
[PATCH v2 09/12] eventdev: add support for DMA adapter stats
Added DMA adapter stats support for get and reset functions.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 95
1 file changed, 95 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index 20817768fc..06a09371d2 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -143,6 +143,9 @@ struct event_dma_adapter {
/* Loop counter to flush dma ops */
uint16_t transmit_loop_count;
+
+ /* Per instance stats structure */
+ struct rte_event_dma_adapter_stats dma_stats;
} __rte_cache_aligned;
static struct event_dma_adapter **event_dma_adapter;
@@ -472,6 +475,7 @@ rte_event_dma_adapter_free(uint8_t id)
static inline unsigned int
edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev,
unsigned int cnt)
{
+ struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
struct dma_vchan_info *vchan_qinfo = NULL;
struct rte_event_dma_adapter_op *dma_op;
uint16_t vchan, nb_enqueued = 0;
@@ -481,6 +485,7 @@ edma_enq_to_dma_dev(struct event_dma_adapter *adapter,
struct rte_event *ev, uns
ret = 0;
n = 0;
+ stats->event_deq_count += cnt;
for (i = 0; i < cnt; i++) {
dma_op = ev[i].event_ptr;
@@ -503,6 +508,7 @@ edma_enq_to_dma_dev(struct event_dma_adapter *adapter,
struct rte_event *ev, uns
ret = edma_circular_buffer_flush_to_dma_dev(adapter,
&vchan_qinfo->dma_buf,
dma_dev_id,
vchan,
&nb_enqueued);
+ stats->dma_enq_count += nb_enqueued;
n += nb_enqueued;
/**
@@ -549,6 +555,7 @@ edma_adapter_dev_flush(struct event_dma_adapter *adapter,
int16_t dma_dev_id,
static unsigned int
edma_adapter_enq_flush(struct event_dma_adapter *adapter)
{
+ struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
int16_t dma_dev_id;
uint16_t nb_enqueued = 0;
uint16_t nb_ops_flushed = 0;
@@ -563,6 +570,8 @@ edma_adapter_enq_flush(struct event_dma_adapter *adapter)
if (!nb_ops_flushed)
adapter->stop_enq_to_dma_dev = false;
+ stats->dma_enq_count += nb_enqueued;
+
return nb_enqueued;
}
@@ -574,6 +583,7 @@ edma_adapter_enq_flush(struct event_dma_adapter *adapter)
static int
edma_adapter_enq_run(struct event_dma_adapter *adapter, unsigned int max_enq)
{
+ struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
uint8_t event_port_id = adapter->event_port_id;
uint8_t event_dev_id = adapter->eventdev_id;
struct rte_event ev[DMA_BATCH_SIZE];
@@ -593,6 +603,7 @@ edma_adapter_enq_run(struct event_dma_adapter *adapter,
unsigned int max_enq)
break;
}
+ stats->event_poll_count++;
n = rte_event_dequeue_burst(event_dev_id, event_port_id, ev,
DMA_BATCH_SIZE, 0);
if (!n)
@@ -613,6 +624,7 @@ static inline uint16_t
edma_ops_enqueue_burst(struct event_dma_adapter *adapter, struct
rte_event_dma_adapter_op **ops,
uint16_t num)
{
+ struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
uint8_t event_port_id = adapter->event_port_id;
uint8_t event_dev_id = adapter->eventdev_id;
struct rte_event events[DMA_BATCH_SIZE];
@@ -652,6 +664,10 @@ edma_ops_enqueue_burst(struct event_dma_adapter *adapter,
struct rte_event_dma_a
} while (retry++ < DMA_ADAPTER_MAX_EV_ENQ_RETRIES && nb_enqueued <
nb_ev);
+ stats->event_enq_fail_count += nb_ev - nb_enqueued;
+ stats->event_enq_count += nb_enqueued;
+ stats->event_enq_retry_count += retry - 1;
+
return nb_enqueued;
}
@@ -706,6 +722,7 @@ edma_ops_buffer_flush(struct event_dma_adapter *adapter)
static inline unsigned int
edma_adapter_deq_run(struct event_dma_adapter *adapter, unsigned int max_deq)
{
+ struct rte_event_dma_adapter_stats *stats = &adapter->dma_stats;
struct dma_vchan_info *vchan_info;
struct dma_ops_circular_buffer *tq_buf;
struct rte_event_dma_adapter_op *ops;
@@ -743,6 +760,7 @@ edma_adapter_deq_run(struct event_dma_adapter *adapter,
unsigned int max_deq)
continue;
done = false;
+ stats->dma_deq_count += n;
tq_buf = &dev_info->tqmap[vchan].dma_buf;
@@ -1305,3 +1323,80 @@ rte_event_dma_adapter_runtime_params_get(uint8_t id,
return 0;
}
+
+int
+rte_event_dma_adapter_stats_get(uint8_t id, struct rte_event_dma_adapter_stats
*stats)
+{
+ struct rte_event_dma_adapter_stats dev_stats_sum
[PATCH v2 10/12] eventdev: add support for DMA adapter enqueue
Added support for DMA adapter enqueue.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index 06a09371d2..b55b40cd46 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -1400,3 +1400,16 @@ rte_event_dma_adapter_stats_reset(uint8_t id)
return 0;
}
+
+uint16_t
+rte_event_dma_adapter_enqueue(uint8_t dev_id, uint8_t port_id, struct
rte_event ev[],
+ uint16_t nb_events)
+{
+ const struct rte_event_fp_ops *fp_ops;
+ void *port;
+
+ fp_ops = &rte_event_fp_ops[dev_id];
+ port = fp_ops->data[port_id];
+
+ return fp_ops->dma_enqueue(port, ev, nb_events);
+}
--
2.25.1
[PATCH v2 11/12] eventdev: add DMA adapter port get
Added support for DMA adapter port get.
Signed-off-by: Amit Prakash Shukla
---
lib/eventdev/rte_event_dma_adapter.c | 16
1 file changed, 16 insertions(+)
diff --git a/lib/eventdev/rte_event_dma_adapter.c
b/lib/eventdev/rte_event_dma_adapter.c
index b55b40cd46..5f52977543 100644
--- a/lib/eventdev/rte_event_dma_adapter.c
+++ b/lib/eventdev/rte_event_dma_adapter.c
@@ -472,6 +472,22 @@ rte_event_dma_adapter_free(uint8_t id)
return 0;
}
+int
+rte_event_dma_adapter_event_port_get(uint8_t id, uint8_t *event_port_id)
+{
+ struct event_dma_adapter *adapter;
+
+ EVENT_DMA_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL);
+
+ adapter = edma_id_to_adapter(id);
+ if (adapter == NULL || event_port_id == NULL)
+ return -EINVAL;
+
+ *event_port_id = adapter->event_port_id;
+
+ return 0;
+}
+
static inline unsigned int
edma_enq_to_dma_dev(struct event_dma_adapter *adapter, struct rte_event *ev,
unsigned int cnt)
{
--
2.25.1
[PATCH v2 12/12] app/test: add event DMA adapter auto-test
Added testsuite to test the dma adapter functionality.
The testsuite detects event and DMA device capability
and accordingly dma adapter is configured and modes are
tested.
Signed-off-by: Amit Prakash Shukla
---
app/test/meson.build | 1 +
app/test/test_event_dma_adapter.c | 808 ++
2 files changed, 809 insertions(+)
create mode 100644 app/test/test_event_dma_adapter.c
diff --git a/app/test/meson.build b/app/test/meson.build
index 05bae9216d..eccd3b72d8 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -66,6 +66,7 @@ source_file_deps = {
'test_errno.c': [],
'test_ethdev_link.c': ['ethdev'],
'test_event_crypto_adapter.c': ['cryptodev', 'eventdev', 'bus_vdev'],
+'test_event_dma_adapter.c': ['dmadev', 'eventdev'],
'test_event_eth_rx_adapter.c': ['ethdev', 'eventdev', 'bus_vdev'],
'test_event_eth_tx_adapter.c': ['bus_vdev', 'ethdev', 'net_ring',
'eventdev'],
'test_event_ring.c': ['eventdev'],
diff --git a/app/test/test_event_dma_adapter.c
b/app/test/test_event_dma_adapter.c
new file mode 100644
index 00..801294c118
--- /dev/null
+++ b/app/test/test_event_dma_adapter.c
@@ -0,0 +1,808 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2023 Marvell.
+ */
+
+#include "test.h"
+#include
+#include
+#include
+#include
+#include
+#include
+
+#ifdef RTE_EXEC_ENV_WINDOWS
+static int
+test_event_dma_adapter(void)
+{
+ printf("event_dma_adapter not supported on Windows, skipping test\n");
+ return TEST_SKIPPED;
+}
+
+#else
+
+#include
+#include
+#include
+#include
+#include
+
+#define NUM_MBUFS (8191)
+#define MBUF_CACHE_SIZE (256)
+#define TEST_APP_PORT_ID 0
+#define TEST_APP_EV_QUEUE_ID 0
+#define TEST_APP_EV_PRIORITY 0
+#define TEST_APP_EV_FLOWID 0xAABB
+#define TEST_DMA_EV_QUEUE_ID 1
+#define TEST_ADAPTER_ID0
+#define TEST_DMA_DEV_ID0
+#define TEST_DMA_VCHAN_ID 0
+#define PACKET_LENGTH 1024
+#define NB_TEST_PORTS 1
+#define NB_TEST_QUEUES 2
+#define NUM_CORES 2
+#define DMA_OP_POOL_SIZE 128
+#define TEST_MAX_OP128
+#define TEST_RINGSIZE 512
+
+#define MBUF_SIZE (RTE_PKTMBUF_HEADROOM + PACKET_LENGTH)
+
+/* Handle log statements in same manner as test macros */
+#define LOG_DBG(...)RTE_LOG(DEBUG, EAL, __VA_ARGS__)
+
+struct event_dma_adapter_test_params {
+ struct rte_mempool *src_mbuf_pool;
+ struct rte_mempool *dst_mbuf_pool;
+ struct rte_mempool *op_mpool;
+ uint8_t dma_event_port_id;
+ uint8_t internal_port_op_fwd;
+};
+
+struct rte_event dma_response_info = {
+ .queue_id = TEST_APP_EV_QUEUE_ID,
+ .sched_type = RTE_SCHED_TYPE_ATOMIC,
+ .flow_id = TEST_APP_EV_FLOWID,
+ .priority = TEST_APP_EV_PRIORITY
+};
+
+static struct event_dma_adapter_test_params params;
+static uint8_t dma_adapter_setup_done;
+static uint32_t slcore_id;
+static int evdev;
+
+static int
+send_recv_ev(struct rte_event *ev)
+{
+ struct rte_event recv_ev[TEST_MAX_OP] = {0};
+ struct rte_event_dma_adapter_op *op;
+ uint16_t nb_enqueued = 0;
+ int ret, i = 0;
+
+ if (params.internal_port_op_fwd) {
+ nb_enqueued = rte_event_dma_adapter_enqueue(evdev,
TEST_APP_PORT_ID, ev,
+ TEST_MAX_OP);
+ } else {
+ while (nb_enqueued < TEST_MAX_OP) {
+ nb_enqueued += rte_event_enqueue_burst(evdev,
TEST_APP_PORT_ID,
+
&ev[nb_enqueued], TEST_MAX_OP -
+ nb_enqueued);
+ }
+ }
+
+ TEST_ASSERT_EQUAL(nb_enqueued, TEST_MAX_OP, "Failed to send event to
dma adapter\n");
+
+ while (i < TEST_MAX_OP) {
+ if (rte_event_dequeue_burst(evdev, TEST_APP_PORT_ID,
&recv_ev[i], 1, 0) != 1)
+ continue;
+
+ op = recv_ev[i].event_ptr;
+ ret = memcmp((uint8_t *)op->src_seg->addr, (uint8_t
*)op->dst_seg->addr,
+op->src_seg->length);
+ TEST_ASSERT_EQUAL(ret, 0, "Data mismatch for dma adapter\n");
+ i++;
+ }
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_dma_adapter_stats(void)
+{
+ struct rte_event_dma_adapter_stats stats;
+
+ rte_event_dma_adapter_stats_get(TEST_ADAPTER_ID, &stats);
+ printf(" +--+\n");
+ printf(" + DMA adapter stats for instance %u:\n", TEST_ADAPTER_ID);
+ printf(" + Event port poll count 0x%" PRIx64 "\n",
+ stats.event_poll_count);
+ printf(" + Event dequeue count 0x%" PRIx64 "\n",
+ stats.event_deq_count);
+ p
RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
> -Original Message-
> From: Konstantin Ananyev
> Sent: Saturday, September 23, 2023 12:41 AM
> To: Feifei Wang ; Konstantin Ananyev
>
> Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> ; Ruifeng Wang
> ; Yuying Zhang ; Beilei
> Xing ; nd ; nd ; nd
> ; nd ; nd ; nd ;
> nd
> Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode
>
>
> Hi Feifei,
>
> > > > -Original Message-
> > > > From: Feifei Wang
> > > > Sent: Tuesday, September 5, 2023 11:11 AM
> > > > To: Konstantin Ananyev ; Konstantin
> > > > Ananyev
> > > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > > > ; Ruifeng Wang
> > > ;
> > > > Yuying Zhang ; Beilei Xing
> > > > ; nd ; nd ; nd
> > > > ; nd ; nd
> > > > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle
> > > > mode
> > > >
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: Konstantin Ananyev
> > > > > Sent: Monday, September 4, 2023 6:22 PM
> > > > > To: Feifei Wang ; Konstantin Ananyev
> > > > >
> > > > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli
> > > > > ; Ruifeng Wang
> > > > ;
> > > > > Yuying Zhang ; Beilei Xing
> > > > > ; nd ; nd ; nd
> > > > > ; nd
> > > > > Subject: RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle
> > > > > mode
> > > > >
> > > > >
> > > > >
> > > > > > > > > > > > > Define specific function implementation for i40e
> > > > > > > > > > > > > driver.
> > > > > > > > > > > > > Currently, mbufs recycle mode can support 128bit
> > > > > > > > > > > > > vector path and
> > > > > > > > > > > > > avx2
> > > > > > > > > > > path.
> > > > > > > > > > > > > And can be enabled both in fast free and no fast free
> mode.
> > > > > > > > > > > > >
> > > > > > > > > > > > > Suggested-by: Honnappa Nagarahalli
> > > > > > > > > > > > >
> > > > > > > > > > > > > Signed-off-by: Feifei Wang
> > > > > > > > > > > > >
> > > > > > > > > > > > > Reviewed-by: Ruifeng Wang
> > > > > > > > > > > > > Reviewed-by: Honnappa Nagarahalli
> > > > > > > > >
> > > > > > > > > > > > > ---
> > > > > > > > > > > > > drivers/net/i40e/i40e_ethdev.c| 1 +
> > > > > > > > > > > > > drivers/net/i40e/i40e_ethdev.h| 2 +
> > > > > > > > > > > > > .../net/i40e/i40e_recycle_mbufs_vec_common.c |
> > > > > > > > > > > > > 147
> > > > > > > > > > > > > ++
> > > > > > > > > > > > > drivers/net/i40e/i40e_rxtx.c | 32
> > > > > > > > > > > > >
> > > > > > > > > > > > > drivers/net/i40e/i40e_rxtx.h | 4 +
> > > > > > > > > > > > > drivers/net/i40e/meson.build | 1 +
> > > > > > > > > > > > > 6 files changed, 187 insertions(+) create mode
> > > > > > > > > > > > > 100644
> > > > > > > > > > > > > drivers/net/i40e/i40e_recycle_mbufs_vec_common.c
> > > > > > > > > > > > >
> > > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.c index
> > > > > > > > > > > > > 8271bbb394..50ba9aac94
> > > > > > > > > > > > > 100644
> > > > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > > > > > > > > > > > @@ -496,6 +496,7 @@ static const struct
> > > > > > > > > > > > > eth_dev_ops i40e_eth_dev_ops
> > > > > > > > > > > = {
> > > > > > > > > > > > > .flow_ops_get =
> > > > > > > > > > > > > i40e_dev_flow_ops_get,
> > > > > > > > > > > > > .rxq_info_get =
> > > > > > > > > > > > > i40e_rxq_info_get,
> > > > > > > > > > > > > .txq_info_get =
> > > > > > > > > > > > > i40e_txq_info_get,
> > > > > > > > > > > > > + .recycle_rxq_info_get =
> > > > i40e_recycle_rxq_info_get,
> > > > > > > > > > > > > .rx_burst_mode_get=
> > > > i40e_rx_burst_mode_get,
> > > > > > > > > > > > > .tx_burst_mode_get=
> > > > i40e_tx_burst_mode_get,
> > > > > > > > > > > > > .timesync_enable =
> > > > > > > > > > > > > i40e_timesync_enable,
> > > > > > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > > b/drivers/net/i40e/i40e_ethdev.h index
> > > > > > > > > > > > > 6f65d5e0ac..af758798e1
> > > > > > > > > > > > > 100644
> > > > > > > > > > > > > --- a/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > > +++ b/drivers/net/i40e/i40e_ethdev.h
> > > > > > > > > > > > > @@ -1355,6 +1355,8 @@ void
> > > > > > > > > > > > > i40e_rxq_info_get(struct rte_eth_dev *dev, uint16_t
> queue_id,
> > > > > > > > > > > > > struct rte_eth_rxq_info *qinfo); void
> > > > > > > > > > > > > i40e_txq_info_get(struct rte_eth_dev *dev,
> > > > > > > > > > > > > uint16_t
> > > queue_id,
> > > > > > > > > > > > > struct rte_eth_txq_info *qinfo);
> > > > > > > > > > > > > +void i40e_recycle_rxq_info_get(struct
> > > > > > > > > > > > > +rte_eth_dev *dev, uint16_t
> > > > > > > > > > > queue_id,
> > > > > > > > > > > > > + struct rte_eth_recycle_rxq_info
> > > >
