Re: [PATCH v4] doc: add iavf live migration guide
On 7/12/2023 3:54 AM, Thomas Monjalon wrote: Hello, I don't pull this patch in -rc3 because I feel some improvements should be done. Hi Thomas, thanks for your review. I am sorry for the late response. On 7/7/2023 2:08 PM, Lingyu Liu wrote: +echo 2 > /sys/bus/pci/devices/:ca:00.1/sriov_numvfs +echo "8086 1889" > /sys/bus/pci/drivers/ice-vfio-pci/new_id +echo :ca:11.0 > /sys/bus/pci/devices/:ca:11.0/driver/unbind +echo :ca:11.0 > /sys/bus/pci/drivers/ice-vfio-pci/bind +echo :ca:11.1 > /sys/bus/pci/devices/:ca:11.1/driver/unbind +echo :ca:11.1 > /sys/bus/pci/drivers/ice-vfio-pci/bind Why not using dpdk-devbind.py? dpdk-devbind.py doesn't support ice-vfio-pci driver yet. + +.. note:: + +The command above creates two vfs for device :ca:00.1: vfs should be VFs Thanks. Will change in next version. + +.. code-block:: console + +:ca:11.0 'Ethernet Adaptive Virtual Function 1889' if= drv=ice-vfio-pci unused=iavf +:ca:11.1 'Ethernet Adaptive Virtual Function 1889' if= drv=ice-vfio-pci unused=iavf + +#. Now, start the migration source Virtual Machine by running the following command: + +.. code-block:: console + +qemu/build/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -cpu host -m 4G -smp 1 -device vfio-pci,host=:ca:11.0,x-enable-migration=true,x-pre-copy-dirty-page-tracking=off -drive file=ubuntu-2004.qcow2 -nic user,hostfwd=tcp::-:22 -monitor stdio No need the full qemu command with your local details here. Thanks. Will change. --- a/doc/guides/rel_notes/release_23_07.rst +++ b/doc/guides/rel_notes/release_23_07.rst @@ -200,6 +200,9 @@ New Features Enhanced the GRO library to support TCP packets over IPv6 network. +* **Updated Intel iavf driver.** + + Added the document for iavf driver live migration based on KVM vfio migration. Not sure about the importance of this note. It shows that AVF PMD live migration feature has been supported and lists the steps for users.
Re: [PATCH v2] doc: announce changes to event device structures
On Wed, Jul 26, 2023 at 9:25 PM wrote: > > From: Pavan Nikhilesh > > The structures ``rte_event_dev_info``, ``rte_event_fp_ops`` will be > modified to add new elements to support link profiles. > A new field ``max_profiles_per_port`` will be added to > ``rte_event_dev_info`` and ``switch_profile`` will be added to > ``rte_event_fp_ops``. > > A profile is a unique identifier for a set of event queues linked to > an event port. The unique identifier spans from 0 to the value > advertised in ``rte_event_dev_info.max_profiles_per_port`` - 1. > > Two new experimental APIs will be added, one to associate a set of > event queues with a profile which can be linked to an event port and > another to switch the profile which would affect the next dequeue call. > > Signed-off-by: Pavan Nikhilesh > + > +* eventdev: The structures ``rte_event_dev_info``, ``rte_event_fp_ops`` will > be > + modified to add new elements to support link profiles.A new field > + ``max_profiles_per_port`` will be added to ``rte_event_dev_info`` and > + ``switch_profile`` will be added to ``rte_event_fp_ops``. There are other deprecation notices to update rte_event_fp_ops. Exact fields in rte_event_dev_info be decided later along with patch. With that Acked-by: Jerin Jacob > -- > 2.25.1 >
RE: [PATCH v2] doc: announce changes to event device structures
> > From: Pavan Nikhilesh > > > > The structures ``rte_event_dev_info``, ``rte_event_fp_ops`` will be > > modified to add new elements to support link profiles. > > A new field ``max_profiles_per_port`` will be added to > > ``rte_event_dev_info`` and ``switch_profile`` will be added to > > ``rte_event_fp_ops``. > > > > A profile is a unique identifier for a set of event queues linked to > > an event port. The unique identifier spans from 0 to the value > > advertised in ``rte_event_dev_info.max_profiles_per_port`` - 1. > > > > Two new experimental APIs will be added, one to associate a set of > > event queues with a profile which can be linked to an event port and > > another to switch the profile which would affect the next dequeue call. > > > > Signed-off-by: Pavan Nikhilesh > > > + > > +* eventdev: The structures ``rte_event_dev_info``, > > +``rte_event_fp_ops`` will be > > + modified to add new elements to support link profiles.A new field > > + ``max_profiles_per_port`` will be added to ``rte_event_dev_info`` > > +and > > + ``switch_profile`` will be added to ``rte_event_fp_ops``. > > There are other deprecation notices to update rte_event_fp_ops. > Exact fields in rte_event_dev_info be decided later along with patch. > With that > > Acked-by: Jerin Jacob Acked-by: Hemant Agrawal > > > > -- > > 2.25.1 > >
[PATCH 0/2] simplify building x86 code with AVX2 support
Inside our optimized vector drivers (and libs), there were always build time checks for various levels of instruction set support, most notably AVX2 and AVX-512 on x86 systems. One of the checks done in each case was verifying that the compiler used was able to generate AVX code appropriately. However, since this was originally done, our minimum compiler support has been updated and so we no longer need to check this - all supported compilers can generate AVX2. This allows us to simplify the build logic for the x86 vector code. In future, we can do similarly for AVX-512. Bruce Richardson (2): build/x86: remove conditional checks for AVX2 support build: remove unnecessary AVX2 compiler flag drivers/net/bnxt/bnxt_ethdev.c | 8 drivers/net/bnxt/bnxt_rxr.h | 2 +- drivers/net/bnxt/bnxt_txr.h | 2 +- drivers/net/bnxt/meson.build| 26 + drivers/net/enic/meson.build| 10 +++--- drivers/net/i40e/i40e_rxtx.c| 14 - drivers/net/i40e/meson.build| 22 ++--- drivers/net/iavf/iavf_rxtx_vec_common.h | 2 +- drivers/net/iavf/meson.build| 22 ++--- drivers/net/ice/meson.build | 21 ++-- lib/acl/meson.build | 23 +- lib/acl/rte_acl.c | 10 +++--- 12 files changed, 49 insertions(+), 113 deletions(-) -- 2.39.2
[PATCH 1/2] build/x86: remove conditional checks for AVX2 support
In a number of libraries and drivers we have multiple levels of checks
for enabling AVX2 support. In these cases:
* we first check for AVX2 support in the build-time ISA, i.e. through
the instruction-set/-march flag. If present, we add source file to the
list of sources.
* if not enabled at the minimum instruction-set level, i.e. a
default/generic build, we then check for compiler support for AVX2
and, if available, did a separate build of the AVX2 file using an
additional flag to enable the instruction set.
While this works, and was necessary in older releases, we no longer need
this level of complexity, as all supported DPDK compilers have support
for AVX2. This makes the second check unnecessary.
However, when we look at the effect of the second option above vs the
first, the only real difference is that in the second case, we add an
additional "-mavx2" to the build flags. This flag simply makes the
instruction set available for use, so should be harmless in the case
where the "march" flag already has that instruction set available.
Therefore, we can remove the check for the first case also, and always
use the fallback case with the extra flag.
Signed-off-by: Bruce Richardson
---
drivers/net/bnxt/meson.build | 27 ++-
drivers/net/enic/meson.build | 10 +++---
drivers/net/i40e/meson.build | 23 +++
drivers/net/iavf/meson.build | 23 +++
drivers/net/ice/meson.build | 22 +++---
lib/acl/meson.build | 24 ++--
6 files changed, 40 insertions(+), 89 deletions(-)
diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
index c7a0d5f6c9..c223a21002 100644
--- a/drivers/net/bnxt/meson.build
+++ b/drivers/net/bnxt/meson.build
@@ -53,23 +53,16 @@ subdir('hcapi/cfa')
if arch_subdir == 'x86'
sources += files('bnxt_rxtx_vec_sse.c')
-# compile AVX2 version if either:
-# a. we have AVX supported in minimum instruction set baseline
-# b. it's not minimum instruction set, but supported by compiler
-if cc.get_define('__AVX2__', args: machine_args) != ''
-cflags += ['-DCC_AVX2_SUPPORT']
-sources += files('bnxt_rxtx_vec_avx2.c')
-elif cc.has_argument('-mavx2')
-cflags += ['-DCC_AVX2_SUPPORT']
-bnxt_avx2_lib = static_library('bnxt_avx2_lib',
-'bnxt_rxtx_vec_avx2.c',
-dependencies: [static_rte_ethdev,
-static_rte_bus_pci,
-static_rte_kvargs, static_rte_hash],
-include_directories: includes,
-c_args: [cflags, '-mavx2'])
-objs += bnxt_avx2_lib.extract_objects('bnxt_rxtx_vec_avx2.c')
- endif
+cflags += ['-DCC_AVX2_SUPPORT']
+# build AVX2 code with instruction set explicitly enabled for runtime
selection
+bnxt_avx2_lib = static_library('bnxt_avx2_lib',
+'bnxt_rxtx_vec_avx2.c',
+dependencies: [static_rte_ethdev,
+static_rte_bus_pci,
+static_rte_kvargs, static_rte_hash],
+include_directories: includes,
+c_args: [cflags, '-mavx2'])
+ objs += bnxt_avx2_lib.extract_objects('bnxt_rxtx_vec_avx2.c')
elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
sources += files('bnxt_rxtx_vec_neon.c')
endif
diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build
index 77dcd9e7ec..8700ae27f2 100644
--- a/drivers/net/enic/meson.build
+++ b/drivers/net/enic/meson.build
@@ -28,14 +28,10 @@ sources = files(
deps += ['hash']
includes += include_directories('base')
-# The current implementation assumes 64-bit pointers
-if cc.get_define('__AVX2__', args: machine_args) != '' and
dpdk_conf.get('RTE_ARCH_64')
-sources += files('enic_rxtx_vec_avx2.c')
-# Build the avx2 handler if the compiler supports it, even though 'machine'
-# does not. This is to support users who build for the min supported machine
+# Build the avx2 handler for 64-bit X86 targets, even though 'machine'
+# may not. This is to support users who build for the min supported machine
# and need to run the binary on newer CPUs too.
-# This part is from i40e meson.build
-elif cc.has_argument('-mavx2') and dpdk_conf.get('RTE_ARCH_64')
+if dpdk_conf.has('RTE_ARCH_X86_64')
enic_avx2_lib = static_library('enic_avx2_lib',
'enic_rxtx_vec_avx2.c',
dependencies: [static_rte_ethdev, static_rte_bus_pci],
diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
index 8e53b87a65..46600520e1 100644
--- a/drivers/net/i40e/meson.build
+++ b/drivers/net/i40e/meson.build
@@ -49,22 +49,13 @@ if arch_subdir == 'x86'
cflags += ['-fno-asynchronous-unwind-tables']
endif
-# compile AVX2 version if either:
-# a. we have AVX supported in minimum instruction set baseline
-# b. it's not minimum inst
[PATCH 2/2] build: remove unnecessary AVX2 compiler flag
Since AVX2 is always available at build time, the CC_AVX2_SUPPORT cflag
became equivalent to the RTE_ARCH_X86 one. Therefore, we can just remove
all use of the flag, replacing it will the RTE_ARCH_X86 one, and also
simplifying the code in a few places where we can merge with other
X86/non-X86 blocks e.g. for providing SSE fallbacks.
Signed-off-by: Bruce Richardson
---
drivers/net/bnxt/bnxt_ethdev.c | 8
drivers/net/bnxt/bnxt_rxr.h | 2 +-
drivers/net/bnxt/bnxt_txr.h | 2 +-
drivers/net/bnxt/meson.build| 1 -
drivers/net/i40e/i40e_rxtx.c| 14 --
drivers/net/i40e/meson.build| 1 -
drivers/net/iavf/iavf_rxtx_vec_common.h | 2 +-
drivers/net/iavf/meson.build| 1 -
drivers/net/ice/meson.build | 1 -
lib/acl/meson.build | 1 -
lib/acl/rte_acl.c | 10 +++---
11 files changed, 14 insertions(+), 29 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ee1552452a..e8c178241f 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1280,7 +1280,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
if (bp->ieee_1588)
goto use_scalar_rx;
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1) {
PMD_DRV_LOG(INFO,
@@ -1332,7 +1332,7 @@ bnxt_transmit_function(struct rte_eth_dev *eth_dev)
BNXT_TRUFLOW_EN(bp) || bp->ieee_1588)
goto use_scalar_tx;
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256 &&
rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1) {
PMD_DRV_LOG(INFO,
@@ -3019,7 +3019,7 @@ static const struct {
#if defined(RTE_ARCH_X86)
{bnxt_recv_pkts_vec,"Vector SSE"},
#endif
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
{bnxt_recv_pkts_vec_avx2, "Vector AVX2"},
#endif
#if defined(RTE_ARCH_ARM64)
@@ -3053,7 +3053,7 @@ static const struct {
#if defined(RTE_ARCH_X86)
{bnxt_xmit_pkts_vec,"Vector SSE"},
#endif
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
{bnxt_xmit_pkts_vec_avx2, "Vector AVX2"},
#endif
#if defined(RTE_ARCH_ARM64)
diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
index 8e722b7bf0..af53bc0c25 100644
--- a/drivers/net/bnxt/bnxt_rxr.h
+++ b/drivers/net/bnxt/bnxt_rxr.h
@@ -112,7 +112,7 @@ uint16_t bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf
**rx_pkts,
int bnxt_rxq_vec_setup(struct bnxt_rx_queue *rxq);
#endif
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
uint16_t bnxt_recv_pkts_vec_avx2(void *rx_queue, struct rte_mbuf **rx_pkts,
uint16_t nb_pkts);
#endif
diff --git a/drivers/net/bnxt/bnxt_txr.h b/drivers/net/bnxt/bnxt_txr.h
index 8e391ee58a..e64ea2c7d1 100644
--- a/drivers/net/bnxt/bnxt_txr.h
+++ b/drivers/net/bnxt/bnxt_txr.h
@@ -52,7 +52,7 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf
**tx_pkts,
uint16_t bnxt_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);
#endif
-#if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT)
+#if defined(RTE_ARCH_X86)
uint16_t bnxt_xmit_pkts_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);
#endif
diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
index c223a21002..1f9ce51f43 100644
--- a/drivers/net/bnxt/meson.build
+++ b/drivers/net/bnxt/meson.build
@@ -53,7 +53,6 @@ subdir('hcapi/cfa')
if arch_subdir == 'x86'
sources += files('bnxt_rxtx_vec_sse.c')
-cflags += ['-DCC_AVX2_SUPPORT']
# build AVX2 code with instruction set explicitly enabled for runtime
selection
bnxt_avx2_lib = static_library('bnxt_avx2_lib',
'bnxt_rxtx_vec_avx2.c',
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index b4f65b58fa..63fef1a5ea 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -3216,15 +3216,9 @@ get_avx_supported(bool request_avx512)
#endif
} else {
if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256 &&
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 &&
- rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1)
-#ifdef CC_AVX2_SUPPORT
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1
&&
+ rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)
== 1)
return true;
-#else
- PMD_DRV_LOG(NOTICE,
-
Re: [PATCH v4] doc: add iavf live migration guide
27/07/2023 10:34, Liu, Lingyu: > > On 7/12/2023 3:54 AM, Thomas Monjalon wrote: > > Hello, > > > > I don't pull this patch in -rc3 because I feel some improvements should be > > done. > > > Hi Thomas, thanks for your review. I am sorry for the late response. > > >> On 7/7/2023 2:08 PM, Lingyu Liu wrote: > >>> +echo 2 > /sys/bus/pci/devices/:ca:00.1/sriov_numvfs > >>> +echo "8086 1889" > /sys/bus/pci/drivers/ice-vfio-pci/new_id > >>> +echo :ca:11.0 > > >>> /sys/bus/pci/devices/:ca:11.0/driver/unbind > >>> +echo :ca:11.0 > /sys/bus/pci/drivers/ice-vfio-pci/bind > >>> +echo :ca:11.1 > > >>> /sys/bus/pci/devices/:ca:11.1/driver/unbind > >>> +echo :ca:11.1 > /sys/bus/pci/drivers/ice-vfio-pci/bind > > Why not using dpdk-devbind.py? > > dpdk-devbind.py doesn't support ice-vfio-pci driver yet. So it should be a requirement. Please work on dpdk-devbind.py
Re: [PATCH v6 0/2] net/mlx5: introduce Tx datapath tracing
> Viacheslav Ovsiienko (2): > net/mlx5: add Tx datapath trace analyzing script > doc: add mlx5 datapath tracing feature description That's only a Python script and its doc, so it's OK to add just before the release. Applied, thanks.
[PATCH v1 0/2] add support for flow aging in CNXK driver
Adds support for flow aging in CNXK driver. This patch series is for DPDK 23.11. Ankur Dwivedi (2): common/cnxk: add support to get aged flows net/cnxk: add get flow aged ops doc/guides/nics/cnxk.rst | 12 + doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1 + drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_mbox.h | 27 +++ drivers/common/cnxk/roc_npc.c | 22 ++ drivers/common/cnxk/roc_npc.h | 28 +++ drivers/common/cnxk/roc_npc_aging.c| 315 + drivers/common/cnxk/roc_npc_priv.h | 17 ++ drivers/common/cnxk/roc_platform.h | 8 + drivers/common/cnxk/version.map| 1 + drivers/net/cnxk/cnxk_ethdev_devargs.c | 21 +- drivers/net/cnxk/cnxk_flow.c | 45 13 files changed, 498 insertions(+), 1 deletion(-) create mode 100644 drivers/common/cnxk/roc_npc_aging.c -- 2.25.1
[PATCH v1 1/2] common/cnxk: add support to get aged flows
Adds support to get aged flows in CNXK driver.
The control thread polls the status of flows having age action, every 10
seconds and updates a bitmap array with the aged flows. The poll frequency
of control thread can be set by devargs.
Signed-off-by: Ankur Dwivedi
---
drivers/common/cnxk/meson.build | 1 +
drivers/common/cnxk/roc_mbox.h | 27 +++
drivers/common/cnxk/roc_npc.c | 22 ++
drivers/common/cnxk/roc_npc.h | 28 +++
drivers/common/cnxk/roc_npc_aging.c | 315
drivers/common/cnxk/roc_npc_priv.h | 17 ++
drivers/common/cnxk/roc_platform.h | 8 +
drivers/common/cnxk/version.map | 1 +
8 files changed, 419 insertions(+)
create mode 100644 drivers/common/cnxk/roc_npc_aging.c
diff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build
index 79e10bac74..d5dfd93e31 100644
--- a/drivers/common/cnxk/meson.build
+++ b/drivers/common/cnxk/meson.build
@@ -57,6 +57,7 @@ sources = files(
'roc_npa_irq.c',
'roc_npa_type.c',
'roc_npc.c',
+'roc_npc_aging.c',
'roc_npc_mcam.c',
'roc_npc_mcam_dump.c',
'roc_npc_parse.c',
diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
index 2f85b2f755..6db46a86f4 100644
--- a/drivers/common/cnxk/roc_mbox.h
+++ b/drivers/common/cnxk/roc_mbox.h
@@ -227,6 +227,8 @@ struct mbox_msghdr {
npc_mcam_get_stats_req, npc_mcam_get_stats_rsp) \
M(NPC_GET_FIELD_HASH_INFO, 0x6013, npc_get_field_hash_info,\
npc_get_field_hash_info_req, npc_get_field_hash_info_rsp)\
+ M(NPC_MCAM_GET_HIT_STATUS, 0x6015, npc_mcam_get_hit_status,\
+ npc_mcam_get_hit_status_req, npc_mcam_get_hit_status_rsp)\
/* NIX mbox IDs (range 0x8000 - 0x) */ \
M(NIX_LF_ALLOC, 0x8000, nix_lf_alloc, nix_lf_alloc_req,\
nix_lf_alloc_rsp)\
@@ -2466,6 +2468,31 @@ struct npc_mcam_get_stats_rsp {
uint8_t __io stat_ena; /* enabled */
};
+#define MCAM_ARR_SIZE256
+#define MCAM_ARR_ELEM_SZ 64
+
+struct npc_mcam_get_hit_status_req {
+ struct mbox_msghdr hdr;
+ /* If clear == true, then if the hit status bit for mcam id is set,
+* then needs to cleared by writing 1 back.
+* If clear == false, then leave the hit status bit as is.
+*/
+ bool __io clear;
+ uint8_t __io reserved[3];
+ /* Start range of mcam id */
+ uint32_t __io range_valid_mcam_ids_start;
+ /* End range of mcam id */
+ uint32_t __io range_valid_mcam_ids_end;
+ /* Bitmap of mcam ids for which the hit status needs to checked */
+ uint64_t __io mcam_ids[MCAM_ARR_SIZE];
+};
+
+struct npc_mcam_get_hit_status_rsp {
+ struct mbox_msghdr hdr;
+ /* Bitmap of mcam hit status, prior to clearing */
+ uint64_t __io mcam_hit_status[MCAM_ARR_SIZE];
+};
+
/* TIM mailbox error codes
* Range 801 - 900.
*/
diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c
index 848086c8de..f0bb0aa931 100644
--- a/drivers/common/cnxk/roc_npc.c
+++ b/drivers/common/cnxk/roc_npc.c
@@ -302,6 +302,7 @@ roc_npc_init(struct roc_npc *roc_npc)
npc_mem = mem;
TAILQ_INIT(&npc->ipsec_list);
+ TAILQ_INIT(&npc->age_flow_list);
for (idx = 0; idx < npc->flow_max_priority; idx++) {
TAILQ_INIT(&npc->flow_list[idx]);
TAILQ_INIT(&npc->prio_flow_list[idx]);
@@ -330,6 +331,9 @@ roc_npc_init(struct roc_npc *roc_npc)
*/
plt_bitmap_set(npc->rss_grp_entries, 0);
+ rc = npc_aged_flows_bitmap_alloc(roc_npc);
+ if (rc != 0)
+ goto done;
return rc;
done:
@@ -610,6 +614,17 @@ npc_parse_actions(struct roc_npc *roc_npc, const struct
roc_npc_attr *attr,
flow->mtr_id = act_mtr->mtr_id;
req_act |= ROC_NPC_ACTION_TYPE_METER;
break;
+ case ROC_NPC_ACTION_TYPE_AGE:
+ if (flow->is_validate == true)
+ break;
+ plt_seqcount_init(&roc_npc->flow_age.seq_cnt);
+ errcode = npc_aging_ctrl_thread_create(roc_npc,
+ actions->conf,
+ flow);
+ if (errcode != 0)
+ goto err_exit;
+ req_act |= ROC_NPC_ACTION_TYPE_AGE;
+ break;
default:
errcode = NPC_ERR_ACTION_NOTSUP;
goto err_exit;
@@ -1485,6 +1500,9 @@ roc_npc_flow_create(struct roc_npc *roc_npc, const struct
roc_npc_attr *attr,
}
}
TAILQ_INSERT_TAIL(list, flow, n
[PATCH v1 2/2] net/cnxk: add get flow aged ops
Adds get flow aged ops in CNXK driver. Also adds the devargs to get the
poll frequency of control thread.
Signed-off-by: Ankur Dwivedi
---
doc/guides/nics/cnxk.rst | 12 +++
doc/guides/nics/features/cnxk.ini | 1 +
doc/guides/nics/features/cnxk_vf.ini | 1 +
drivers/net/cnxk/cnxk_ethdev_devargs.c | 21 +++-
drivers/net/cnxk/cnxk_flow.c | 45 ++
5 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst
index 9229056f6f..dc71ab7fc3 100644
--- a/doc/guides/nics/cnxk.rst
+++ b/doc/guides/nics/cnxk.rst
@@ -581,6 +581,18 @@ Runtime Config Options for inline device
With the above configuration, driver would poll for soft expiry events every
1000 usec.
+- ``NPC MCAM Aging poll frequency in seconds`` (default ``10``)
+
+ Poll frequency for aging control thread can be specified by
+ ``aging_poll_freq`` ``devargs`` parameter.
+
+ For example::
+
+ -a 0002:01:00.2,aging_poll_freq=50
+
+ With the above configuration, driver would poll for aging flows every 50
+ seconds.
+
Debugging Options
-
diff --git a/doc/guides/nics/features/cnxk.ini
b/doc/guides/nics/features/cnxk.ini
index 838e781d6d..ebedbd0588 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -80,6 +80,7 @@ vxlan= Y
vxlan_gpe= Y
[rte_flow actions]
+age = Y
count= Y
drop = Y
flag = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini
b/doc/guides/nics/features/cnxk_vf.ini
index 470c45ce59..0e9ad94382 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -71,6 +71,7 @@ vxlan= Y
vxlan_gpe= Y
[rte_flow actions]
+age = Y
count= Y
drop = Y
flag = Y
diff --git a/drivers/net/cnxk/cnxk_ethdev_devargs.c
b/drivers/net/cnxk/cnxk_ethdev_devargs.c
index e1a0845ece..8e862be933 100644
--- a/drivers/net/cnxk/cnxk_ethdev_devargs.c
+++ b/drivers/net/cnxk/cnxk_ethdev_devargs.c
@@ -245,6 +245,19 @@ parse_sdp_channel_mask(const char *key, const char *value,
void *extra_args)
return 0;
}
+static int
+parse_val_u16(const char *key, const char *value, void *extra_args)
+{
+ RTE_SET_USED(key);
+ uint16_t val;
+
+ val = atoi(value);
+
+ *(uint16_t *)extra_args = val;
+
+ return 0;
+}
+
#define CNXK_RSS_RETA_SIZE "reta_size"
#define CNXK_SCL_ENABLE"scalar_enable"
#define CNXK_TX_COMPL_ENA "tx_compl_ena"
@@ -265,10 +278,12 @@ parse_sdp_channel_mask(const char *key, const char
*value, void *extra_args)
#define CNXK_CUSTOM_SA_ACT "custom_sa_act"
#define CNXK_SQB_SLACK "sqb_slack"
#define CNXK_NIX_META_BUF_SZ "meta_buf_sz"
+#define CNXK_FLOW_AGING_POLL_FREQ "aging_poll_freq"
int
cnxk_ethdev_parse_devargs(struct rte_devargs *devargs, struct cnxk_eth_dev
*dev)
{
+ uint16_t aging_thread_poll_freq = ROC_NPC_AGE_POLL_FREQ_MIN;
uint16_t reta_sz = ROC_NIX_RSS_RETA_SZ_64;
uint16_t sqb_count = CNXK_NIX_TX_MAX_SQB;
struct flow_pre_l2_size_info pre_l2_info;
@@ -338,6 +353,8 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs,
struct cnxk_eth_dev *dev)
rte_kvargs_process(kvlist, CNXK_SQB_SLACK, &parse_sqb_count,
&sqb_slack);
rte_kvargs_process(kvlist, CNXK_NIX_META_BUF_SZ, &parse_meta_bufsize,
&meta_buf_sz);
+ rte_kvargs_process(kvlist, CNXK_FLOW_AGING_POLL_FREQ, &parse_val_u16,
+ &aging_thread_poll_freq);
rte_kvargs_free(kvlist);
null_devargs:
@@ -369,6 +386,7 @@ cnxk_ethdev_parse_devargs(struct rte_devargs *devargs,
struct cnxk_eth_dev *dev)
dev->npc.pre_l2_size_offset = pre_l2_info.pre_l2_size_off;
dev->npc.pre_l2_size_offset_mask = pre_l2_info.pre_l2_size_off_mask;
dev->npc.pre_l2_size_shift_dir = pre_l2_info.pre_l2_size_shift_dir;
+ dev->npc.flow_age.aging_poll_freq = aging_thread_poll_freq;
return 0;
exit:
return -EINVAL;
@@ -390,4 +408,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_cnxk,
CNXK_NO_INL_DEV "=0"
CNXK_SDP_CHANNEL_MASK "=<1-4095>/<1-4095>"
CNXK_CUSTOM_SA_ACT "=1"
- CNXK_SQB_SLACK "=<12-512>");
+ CNXK_SQB_SLACK "=<12-512>"
+ CNXK_FLOW_AGING_POLL_FREQ "=<10-65535>");
diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 3b8348ae9c..9d69dd90e3 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -230,6 +230,10 @@ cnxk_map_actions(struct rte_eth_dev *eth_dev, const struct
rte_flow_attr *attr,
in_actions[i].type = ROC_NPC_ACTION_TYPE_METER
[PATCH] examples/l2fwd-macsec: add MACsec forwarding application
Added a new application based on l2fwd to demonstrate inline protocol offload MACsec performance using rte_security APIs. Example command: ./dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 -c 0x6 -- -p 0x3 \ --mcs-tx-portmask 0x1 --mcs-rx-portmask 0x2 --mcs-port-config \ '(0,02:03:04:05:06:07,01:02:03:04:05:06),(1,02:03:04:05:06:17,01:02:03:04:05:16)' Signed-off-by: Akhil Goyal --- .../sample_app_ug/l2_forward_macsec.rst | 106 ++ examples/l2fwd-macsec/Makefile| 52 + examples/l2fwd-macsec/main.c | 1570 + examples/l2fwd-macsec/meson.build | 13 + examples/meson.build |1 + 5 files changed, 1742 insertions(+) create mode 100644 doc/guides/sample_app_ug/l2_forward_macsec.rst create mode 100644 examples/l2fwd-macsec/Makefile create mode 100644 examples/l2fwd-macsec/main.c create mode 100644 examples/l2fwd-macsec/meson.build diff --git a/doc/guides/sample_app_ug/l2_forward_macsec.rst b/doc/guides/sample_app_ug/l2_forward_macsec.rst new file mode 100644 index 00..9fd4ba116f --- /dev/null +++ b/doc/guides/sample_app_ug/l2_forward_macsec.rst @@ -0,0 +1,106 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright(C) 2023 Marvell. + +.. _l2_fwd_macsec_app: + +L2 Forwarding MACsec Sample Application +=== + +The L2 Forwarding MACsec application is a simple example of packet processing using +the Data Plane Development Kit (DPDK) which encrypt/decrypt packets based on +rte_security MACsec sessions. + +Overview + + +The L2 Forwarding MACsec application performs L2 forwarding for each packet that is +received on an RX_PORT after encrypting/decrypting the packets based on rte_security +sessions using inline protocol mode. +The destination port is the adjacent port from the enabled portmask, that is, +if the first four ports are enabled (portmask 0xf), +ports 1 and 2 forward into each other, and ports 3 and 4 forward into each other. + +This application can be used to benchmark performance using a traffic-generator, +as shown in the :numref:`figure_l2_fwd_benchmark_setup`. + +.. _figure_l2_fwd_benchmark_setup: + +.. figure:: img/l2_fwd_benchmark_setup.* + + Performance Benchmark Setup (Basic Environment) + +.. _l2_fwd_vf_setup: + +Compiling the Application +- + +To compile the sample application see :doc:`compiling`. + +The application is located in the ``l2fwd-macsec`` sub-directory. + +Running the Application +--- + +The application requires a number of command line options: + +.. code-block:: console + +.//examples/dpdk-l2fwd-macsec [EAL options] -- -p PORTMASK + [-q NQ] + --mcs-tx-portmask OUTBOUND_PORTMASK + --mcs-rx-portmask INBOUND_PORTMASK + --mcs-port-config '(port,src_mac,dst_mac)[,(port,src_mac,dst_mac)]' + [--portmap="(port, port)[,(port, port)]"] + [-T STAT_INTERVAL] + +where, + +* ``p PORTMASK``: A hexadecimal bitmask of the ports to configure + +* ``q NQ``: A number of queues (=ports) per lcore (default is 1) + +* ``T STAT_INTERVAL``: Time interval in seconds for refreshing the stats(default is 1 sec). +Value 0 disables stats display. + +* ``--mcs-tx-portmask OUTBOUND_PORTMASK``: A hexadecimal bitmask of the ports +to configure encryption flows. + +* ``--mcs-rx-portmask INBOUND_PORTMASK``: A hexadecimal bitmask of the ports +to configure decryption flows. + +* ``--mcs-port-config '(port,src_mac,dst_mac)[,(port,src_mac,dst_mac)]'``: +Configures the source and destination MAC addresses of incoming packets +on a port for which MACsec processing is to be done. + +* ``--portmap="(port,port)[,(port,port)]"``: Determines forwarding ports mapping. + +To run the application in linux environment with 4 lcores, 4 ports with +2 ports for outbound and 2 ports for outbound, issue the command: + +.. code-block:: console + +$ .//examples/dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 \ +-a 0002:06:00.0 -a 0002:07:00.0 -c 0x1E -- -p 0xf \ +--mcs-tx-portmask 0x5 --mcs-rx-portmask 0xA \ +--mcs-port-config '(0,02:03:04:05:06:07,01:02:03:04:05:06), \ +(1,02:03:04:05:06:17,01:02:03:04:05:16), \ +(2,02:03:04:05:06:27,01:02:03:04:05:26), \ +(3,02:03:04:05:06:37,01:02:03:04:05:36)' -T 10 + +To run the application in linux environment with 4 lcores, 4 ports, +to forward RX traffic of ports 0 & 1 on ports 2 & 3 respectively and +vice versa, issue the command: + +.. code-block:: console + +$ .//examples/dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 \ +
[Bug 1269] test-dma-perf running in iova-mode as PA for rte_memcpy results in seg-fault.
https://bugs.dpdk.org/show_bug.cgi?id=1269 Bug ID: 1269 Summary: test-dma-perf running in iova-mode as PA for rte_memcpy results in seg-fault. Product: DPDK Version: 23.07 Hardware: All OS: Linux Status: UNCONFIRMED Severity: major Priority: Normal Component: examples Assignee: dev@dpdk.org Reporter: vipin.vargh...@amd.com Target Milestone: --- Platform: CPU: AMD EPYC 9374F 32-Core Processor OS: RHEL 8.5 Kernel: 4.18.0-372.26.1.el8_6.x86_64 DPDK Application: dpdk-test-dma-perf Configuration: ``` [case1] type=CPU_MEM_COPY mem_size=10 buf_size=64,8192,2,MUL src_numa_node=0 dst_numa_node=0 cache_flush=0 test_seconds=2 lcore = 7 eal_args=--in-memory --no-pci ``` Logs: ``` EAL: Virtual area found at 0x118000 (size = 0x61000) EAL: Memseg list allocated at socket 0, page size 0x800kB EAL: Ask a virtual area of 0x4 bytes EAL: Virtual area found at 0x118020 (size = 0x4) EAL: VA reserved for memseg list at 0x118020, size 4 EAL: Ask a virtual area of 0x61000 bytes EAL: Virtual area found at 0x158020 (size = 0x61000) EAL: Memseg list allocated at socket 0, page size 0x800kB EAL: Ask a virtual area of 0x4 bytes EAL: Virtual area found at 0x158040 (size = 0x4) EAL: VA reserved for memseg list at 0x158040, size 4 EAL: Ask a virtual area of 0x61000 bytes EAL: Virtual area found at 0x198040 (size = 0x61000) EAL: Memseg list allocated at socket 0, page size 0x800kB EAL: Ask a virtual area of 0x4 bytes EAL: Virtual area found at 0x198060 (size = 0x4) EAL: VA reserved for memseg list at 0x198060, size 4 EAL: Ask a virtual area of 0x61000 bytes EAL: Virtual area found at 0x1d8060 (size = 0x61000) EAL: Memseg list allocated at socket 0, page size 0x800kB EAL: Ask a virtual area of 0x4 bytes EAL: Virtual area found at 0x1d8080 (size = 0x4) EAL: VA reserved for memseg list at 0x1d8080, size 4 EAL: Using memfd for anonymous memory EAL: No shared files mode enabled, IPC is disabled EAL: No shared files mode enabled, IPC is disabled EAL: TSC frequency is ~384 KHz EAL: Main lcore 1 is ready (tid=7ff91da0cc00;cpuset=[1]) EAL: lcore 2 is ready (tid=7ff91be46400;cpuset=[2]) EAL: lcore 3 is ready (tid=7ff91b645400;cpuset=[3]) EAL: lcore 4 is ready (tid=7ff91ae44400;cpuset=[4]) EAL: lcore 7 is ready (tid=7ff919641400;cpuset=[7]) EAL: lcore 6 is ready (tid=7ff919e42400;cpuset=[6]) EAL: lcore 5 is ready (tid=7ff91a643400;cpuset=[5]) EAL: Trying to obtain current memory policy. EAL: Setting policy MPOL_PREFERRED for socket 0 EAL: alloc_seg(): mmap() failed: Cannot allocate memory EAL: Ask a virtual area of 0x20 bytes EAL: Virtual area found at 0x118020 (size = 0x20) EAL: attempted to allocate 1 segments, but only 0 were allocated EAL: Restoring previous memory policy: 0 EAL: Trying to obtain current memory policy. EAL: Setting policy MPOL_PREFERRED for socket 0 EAL: Restoring previous memory policy: 0 EAL: request: mp_malloc_sync EAL: No shared files mode enabled, IPC is disabled EAL: Heap on socket 0 was expanded by 1024MB EAL: Module /sys/module/vfio not found! error 2 (No such file or directory) EAL: lib.telemetry log level changed from disabled to warning TELEMETRY: No legacy callbacks, legacy socket not created Number of used lcores: 7. Running scenario 1 Start testing Case process killed by signal 11 Bye... ``` -- You are receiving this mail because: You are the assignee for the bug.
[PATCH v4] node: add IPv4 reassembly node
From: Pavan Nikhilesh
Add IPv4 reassembly node.
Signed-off-by: Pavan Nikhilesh
---
v4 Changes:
- Add packet drop node as the 0th edge.
- Free deathrow packets to packet drop node.
v3 Changes:
- Actually include the changes that fix compilation.
v2 Changes:
- Fix compilation.
doc/guides/prog_guide/graph_lib.rst | 8 ++
lib/node/ethdev_rx.c| 1 +
lib/node/ethdev_rx_priv.h | 1 +
lib/node/ip4_reassembly.c | 186
lib/node/ip4_reassembly_priv.h | 28 +
lib/node/meson.build| 3 +-
lib/node/rte_node_ip4_api.h | 37 ++
lib/node/version.map| 1 +
8 files changed, 264 insertions(+), 1 deletion(-)
create mode 100644 lib/node/ip4_reassembly.c
create mode 100644 lib/node/ip4_reassembly_priv.h
diff --git a/doc/guides/prog_guide/graph_lib.rst
b/doc/guides/prog_guide/graph_lib.rst
index e7b6e12004..10d146e2f6 100644
--- a/doc/guides/prog_guide/graph_lib.rst
+++ b/doc/guides/prog_guide/graph_lib.rst
@@ -453,6 +453,14 @@ to determine the L2 header to be written to the packet
before sending
the packet out to a particular ethdev_tx node.
``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.
+ip4_reassembly
+~~
+This node is an intermediate node that reassembles ipv4 fragmented packets,
+non-fragmented packets pass through the node un-effected. The node rewrites
+it's stream and moves it to the next node.
+The fragment table and death row table should be setup via the
+``rte_node_ip4_reassembly_configure`` API.
+
ip6_lookup
~~
This node is an intermediate node that does LPM lookup for the received
diff --git a/lib/node/ethdev_rx.c b/lib/node/ethdev_rx.c
index d131034991..3e8fac1df4 100644
--- a/lib/node/ethdev_rx.c
+++ b/lib/node/ethdev_rx.c
@@ -215,6 +215,7 @@ static struct rte_node_register ethdev_rx_node_base = {
.next_nodes = {
[ETHDEV_RX_NEXT_PKT_CLS] = "pkt_cls",
[ETHDEV_RX_NEXT_IP4_LOOKUP] = "ip4_lookup",
+ [ETHDEV_RX_NEXT_IP4_REASSEMBLY] = "ip4_reassembly",
},
};
diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethdev_rx_priv.h
index 7f24cf962e..574a76c2a6 100644
--- a/lib/node/ethdev_rx_priv.h
+++ b/lib/node/ethdev_rx_priv.h
@@ -39,6 +39,7 @@ struct ethdev_rx_node_elem {
enum ethdev_rx_next_nodes {
ETHDEV_RX_NEXT_IP4_LOOKUP,
ETHDEV_RX_NEXT_PKT_CLS,
+ ETHDEV_RX_NEXT_IP4_REASSEMBLY,
ETHDEV_RX_NEXT_MAX,
};
diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c
new file mode 100644
index 00..04823cc596
--- /dev/null
+++ b/lib/node/ip4_reassembly.c
@@ -0,0 +1,186 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Marvell.
+ */
+
+#include
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "rte_node_ip4_api.h"
+
+#include "ip4_reassembly_priv.h"
+#include "node_private.h"
+
+struct ip4_reassembly_elem {
+ struct ip4_reassembly_elem *next;
+ struct ip4_reassembly_ctx ctx;
+ rte_node_t node_id;
+};
+
+/* IP4 reassembly global data struct */
+struct ip4_reassembly_node_main {
+ struct ip4_reassembly_elem *head;
+};
+
+typedef struct ip4_reassembly_ctx ip4_reassembly_ctx_t;
+typedef struct ip4_reassembly_elem ip4_reassembly_elem_t;
+
+static struct ip4_reassembly_node_main ip4_reassembly_main;
+
+static uint16_t
+ip4_reassembly_node_process(struct rte_graph *graph, struct rte_node *node,
void **objs,
+ uint16_t nb_objs)
+{
+#define PREFETCH_OFFSET 4
+ struct rte_mbuf *mbuf, *mbuf_out;
+ struct rte_ip_frag_death_row *dr;
+ struct ip4_reassembly_ctx *ctx;
+ struct rte_ipv4_hdr *ipv4_hdr;
+ struct rte_ip_frag_tbl *tbl;
+ void **to_next, **to_free;
+ uint16_t idx = 0;
+ int i;
+
+ ctx = (struct ip4_reassembly_ctx *)node->ctx;
+
+ /* Get core specific reassembly tbl */
+ tbl = ctx->tbl;
+ dr = ctx->dr;
+
+ for (i = 0; i < PREFETCH_OFFSET && i < nb_objs; i++) {
+ rte_prefetch0(rte_pktmbuf_mtod_offset((struct rte_mbuf
*)objs[i], void *,
+ sizeof(struct
rte_ether_hdr)));
+ }
+
+ to_next = node->objs;
+ for (i = 0; i < nb_objs - PREFETCH_OFFSET; i++) {
+#if RTE_GRAPH_BURST_SIZE > 64
+ /* Prefetch next-next mbufs */
+ if (likely(i + 8 < nb_objs))
+ rte_prefetch0(objs[i + 8]);
+#endif
+ rte_prefetch0(rte_pktmbuf_mtod_offset((struct rte_mbuf *)objs[i
+ PREFETCH_OFFSET],
+ void *, sizeof(struct
rte_ether_hdr)));
+ mbuf = (struct rte_mbuf *)objs[i];
+
+ ipv4_hdr = rte_pktmbuf_mtod_offset(mbuf, struct rte_ipv4_hdr *,
+
Re: [PATCH] doc: fix missing release note for I225 support
> > Add missing release note for I225-LMVP support.
> >
> > Fixes: 431d5e6dc3de ("net/igc: support I225-LMVP device")
> >
> > Signed-off-by: Qiming Yang
>
> Acked-by: Qi Zhang
Applied
Re: [PATCH v2] doc: fix missing release note for I219 support
> > Add missing release note for I219 support
> >
> > Fixes: a33e1a5bcd3f ("net/e1000: support more I219 devices")
> >
> > Signed-off-by: Qiming Yang
>
> Acked-by: Qi Zhang
Applied
Re: [PATCH] doc: fix missing release note for link support
28/06/2023 07:39, Kaiwen Deng:
> fix missing release note for link speed change support.
>
> Fixes: 36afbc269081 ("net/ice: support link speed change")
>
> Signed-off-by: Kaiwen Deng
Applied
Re: [PATCH] doc: fix missing release note for double vlan on ice
28/06/2023 08:00, Mingjin Ye:
> Add missing release note for double vlan on ice driver.
>
> Fixes: de5da9d16430 ("net/ice: support double VLAN")
>
> Signed-off-by: Mingjin Ye
Applied (and simplified).
Re: [PATCH] doc: update release note for iavf AVX2 feature
> > Add the missed release note for iavf AVX2 feature in 23.07.
> >
> > Fixes: 5712bf9d6e14 ("net/iavf: add Tx AVX2 offload path")
> >
> > Signed-off-by: Wenzhuo Lu
>
> Acked-by: Beilei Xing
Simplified and applied.
Re: [PATCH] doc: fix missing release note for timestamp offload on iavf
28/06/2023 07:37, Zhichao Zeng:
> Add missing release note for Rx timestamp offload on vector path.
>
> Fixes: 61b6874b9224 ("net/iavf: support Rx timestamp offload on AVX512")
> Signed-off-by: Zhichao Zeng
Added other fix lines for AVX2 and SSE, and applied.
Re: [PATCH] doc: fix missing release note for UFO on iavf and ice
> > Add missing release note for UDP fragmentation offload on iavf and ice.
> >
> > Fixes: 0f24dc14654e ("net/iavf: enable UDP fragmentation offload")
> > Fixes: 623ca7a15db4 ("net/ice: enable UDP fragmentation offload")
> >
> > Signed-off-by: Zhichao Zeng
>
> Acked-by: Qi Zhang
Applied
Re: [PATCH v2] doc: update release notes for Intel IPU
21/07/2023 16:58, beilei.x...@intel.com:
> From: Beilei Xing
>
> Update release notes for Intel IPU new features:
> - Support VF whose device id is 0x145c.
> - Support hairpin queue.
>
> Fixes: 32bcd47e16fe ("net/idpf: support VF")
> Fixes: 1ec8064832db ("net/cpfl: add haipin queue group during vport init")
>
> Signed-off-by: Beilei Xing
> Acked-by: Jingjing Wu
Applied
Re: [PATCH v2] doc: update doc for idpf and cpfl
25/07/2023 17:25, beilei.x...@intel.com: > From: Beilei Xing > > Add recommended matching list for idpf pmd and cpfl pmd. > > Signed-off-by: Beilei Xing Applied
Re: [PATCH] doc: announce QAT support on aarch64
27/06/2023 00:37, Dharmik Thakkar: > Update release notes with added support for QAT on Ampere Altra. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > +* **Intel QuickAssist Technology (QAT) supports on Ampere Altra platform.** > + > + Tested with ipsec-secgw sample application and cryptodev_qat_autotest. I don't think there was any code change to allow this feature. If it is a test report, you should better fill the last section of this page: "Tested Platforms"
Re: [PATCH] doc/dmadevs: add note clarifying naming of idxd devices
> > > Since the test-dma-perf application identifies devices by name, > > > include in the idxd driver documentation a note on device naming when > > vfio-pci. > > > See also discussion in bugzilla[1]. > > > > > > [1] https://bugs.dpdk.org/show_bug.cgi?id=1268 Bugzilla ID: 1268 > > > > > > Signed-off-by: Bruce Richardson > > > --- > > Note, although I reference bugzilla here, I don't consider this a bugfix, > > so I've > > not included a fixes tag and official bugzilla id etc. It's instead a note > > clarifying > > the expected behaviour. > > App/dma-perf got integrated into DPDK via > `https://patches.dpdk.org/project/dpdk/patch/20230629131455.52732-1-cheng1.ji...@intel.com/`. > The expectation is that, it is tried and tested for hardware dma, sw > skeleton dma and cpu memcpy. > Happy to acknowledge the change as it helps the DPDK community. > > Acked-by: Vipin Varghese Replaced PCI id with PCI address, and applied, thanks.
[PATCH] app/testpmd: fix UDP cksum error for UFO enable
The command "tso set " is used to enable UFO, please
see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine")
The above patch configures the RTE_MBUF_F_TX_UDP_SEG to enable UFO only if
tso_segsz is set. Then tx_prepare() may call rte_net_intel_cksum_prepare()
to compute pseudo header checksum (because some PMDs may supports TSO).
As a result, if the peer sends UDP packets, all packets with UDP checksum
error are received for the PMDs only supported TSO.
So enabling UFO also depends on if driver has RTE_ETH_TX_OFFLOAD_UDP_TSO
capability. Similarly, TSO also need to do like this.
In addition, this patch also fixes cmd_tso_set_parsed() for UFO to make
it better to support TSO and UFO.
Fixes: ce8e6e742807 ("app/testpmd: support UFO in checksum engine")
Signed-off-by: Huisong Li
---
app/test-pmd/cmdline.c | 47 +
app/test-pmd/csumonly.c | 4 ++--
2 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0d0723f659..8be593d405 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4906,6 +4906,7 @@ cmd_tso_set_parsed(void *parsed_result,
{
struct cmd_tso_set_result *res = parsed_result;
struct rte_eth_dev_info dev_info;
+ uint64_t offloads;
int ret;
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
@@ -4922,37 +4923,37 @@ cmd_tso_set_parsed(void *parsed_result,
if (ret != 0)
return;
- if ((ports[res->port_id].tso_segsz != 0) &&
- (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
- fprintf(stderr, "Error: TSO is not supported by port %d\n",
- res->port_id);
- return;
+ if (ports[res->port_id].tso_segsz != 0) {
+ if ((dev_info.tx_offload_capa & (RTE_ETH_TX_OFFLOAD_TCP_TSO |
+ RTE_ETH_TX_OFFLOAD_UDP_TSO)) == 0) {
+ fprintf(stderr, "Error: both TSO and UFO are not
supported by port %d\n",
+ res->port_id);
+ return;
+ }
+ /* display warnings if configuration is not supported by the
NIC */
+ if ((dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) ==
0)
+ fprintf(stderr, "Warning: port %d doesn't support
TSO\n",
+ res->port_id);
+ if ((dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_UDP_TSO) ==
0)
+ fprintf(stderr, "Warning: port %d doesn't support
UFO\n",
+ res->port_id);
}
if (ports[res->port_id].tso_segsz == 0) {
ports[res->port_id].dev_conf.txmode.offloads &=
- ~RTE_ETH_TX_OFFLOAD_TCP_TSO;
- printf("TSO for non-tunneled packets is disabled\n");
+ ~(RTE_ETH_TX_OFFLOAD_TCP_TSO |
RTE_ETH_TX_OFFLOAD_UDP_TSO);
+ printf("TSO and UFO for non-tunneled packets is disabled\n");
} else {
- ports[res->port_id].dev_conf.txmode.offloads |=
- RTE_ETH_TX_OFFLOAD_TCP_TSO;
- printf("TSO segment size for non-tunneled packets is %d\n",
+ offloads = (dev_info.tx_offload_capa &
RTE_ETH_TX_OFFLOAD_TCP_TSO) ?
+ RTE_ETH_TX_OFFLOAD_TCP_TSO : 0;
+ offloads |= (dev_info.tx_offload_capa &
RTE_ETH_TX_OFFLOAD_UDP_TSO) ?
+ RTE_ETH_TX_OFFLOAD_UDP_TSO : 0;
+ ports[res->port_id].dev_conf.txmode.offloads |= offloads;
+ printf("segment size for non-tunneled packets is %d\n",
ports[res->port_id].tso_segsz);
}
- cmd_config_queue_tx_offloads(&ports[res->port_id]);
-
- /* display warnings if configuration is not supported by the NIC */
- ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
- if (ret != 0)
- return;
-
- if ((ports[res->port_id].tso_segsz != 0) &&
- (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
- fprintf(stderr,
- "Warning: TSO enabled but not supported by port %d\n",
- res->port_id);
- }
+ cmd_config_queue_tx_offloads(&ports[res->port_id]);
cmd_reconfig_device_queue(res->port_id, 1, 1);
}
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index c103e54111..0c007bd178 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -505,7 +505,7 @@ process_inner_cksums(void *l3_hdr, const struct
testpmd_offload_info *info,
udp_hdr = (struct rte_udp_hdr *)((char *)l3_hdr + info->l3_len);
/* do not recalculate udp cksum if it was 0 */
if (udp_hdr->dgram_cksum !=
