Re: [PATCH V6 0/5] app/testpmd: support multiple process attach and detach port
Hi Ferruh, Can you take a look at this series? I added the call stack info for segment fault. /Huisong 在 2023/5/27 10:11, Huisong Li 写道: This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v6: adjust rte_eth_dev_is_used position based on alphabetical order in version.map -v5: move 'ALLOCATED' state to the back of 'REMOVED' to avoid abi break. -v4: fix a misspelling. -v3: #1 merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for other bus type. #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers/bus: restore driver assignment at front of probing ethdev: fix skip valid port in probing callback app/testpmd: check the validity of the port app/testpmd: add attach and detach port for multiple process app/testpmd: stop forwarding in new or destroy event app/test-pmd/testpmd.c | 47 +++- app/test-pmd/testpmd.h | 1 - drivers/bus/auxiliary/auxiliary_common.c | 9 - drivers/bus/dpaa/dpaa_bus.c | 9 - drivers/bus/fslmc/fslmc_bus.c| 8 +++- drivers/bus/ifpga/ifpga_bus.c| 12 -- drivers/bus/pci/pci_common.c | 9 - drivers/bus/vdev/vdev.c | 10 - drivers/bus/vmbus/vmbus_common.c | 9 - drivers/net/bnxt/bnxt_ethdev.c | 3 +- drivers/net/bonding/bonding_testpmd.c| 1 - drivers/net/mlx5/mlx5.c | 2 +- lib/ethdev/ethdev_driver.c | 13 +-- lib/ethdev/ethdev_driver.h | 12 ++ lib/ethdev/ethdev_pci.h | 2 +- lib/ethdev/rte_class_eth.c | 2 +- lib/ethdev/rte_ethdev.c | 4 +- lib/ethdev/rte_ethdev.h | 4 +- lib/ethdev/version.map | 1 + 19 files changed, 114 insertions(+), 44 deletions(-)
Re: [PATCH v7 1/1] dts: add smoke tests
On Thu, Jul 13, 2023 at 6:54 PM wrote: > > From: Jeremy Spewock > > Adds a new test suite for running smoke tests that verify general > configuration aspects of the system under test. If any of these tests > fail, the DTS execution terminates as part of a "fail-fast" model. > > Signed-off-by: Jeremy Spewock > --- > dts/conf.yaml | 17 +- > dts/framework/config/__init__.py | 107 +-- > dts/framework/config/conf_yaml_schema.json| 142 +- > dts/framework/dts.py | 87 ++--- > dts/framework/exception.py| 12 ++ > dts/framework/remote_session/__init__.py | 11 +- > dts/framework/remote_session/os_session.py| 53 +- > dts/framework/remote_session/posix_session.py | 29 ++- > .../remote_session/remote/__init__.py | 10 + > .../remote/interactive_remote_session.py | 82 > .../remote/interactive_shell.py | 78 > .../remote_session/remote/testpmd_shell.py| 74 > dts/framework/test_result.py | 37 +++- > dts/framework/test_suite.py | 10 +- > dts/framework/testbed_model/node.py | 2 + > dts/framework/testbed_model/sut_node.py | 176 +- > dts/framework/utils.py| 3 + > dts/tests/TestSuite_smoke_tests.py| 113 +++ > 18 files changed, 945 insertions(+), 98 deletions(-) > create mode 100644 > dts/framework/remote_session/remote/interactive_remote_session.py > create mode 100644 dts/framework/remote_session/remote/interactive_shell.py > create mode 100644 dts/framework/remote_session/remote/testpmd_shell.py > create mode 100644 dts/tests/TestSuite_smoke_tests.py Reviewed-by: Juraj Linkeš Thanks for the patch.
Re: [PATCH] app/test-pipeline: relax RSS hash requirement
在 2023/6/26 15:45, Feifei Wang 写道:
For some drivers which can not support the configured RSS hash functions,
the thread reports 'invalid rss_hf' when doing device configure.
For example, i40e driver can not support 'RTE_ETH_RSS_IPV4',
'RTE_ETH_RSS_IPV6' and 'RTE_ETH_RSS_NONFRAG_IPV6_OTHER', thus it can not
run successfully in test-pipeline with XL710 NIC and reports the issue:
-
Ethdev port_id=0 invalid rss_hf: 0xa38c, valid value: 0x7ef8
PANIC in app_init_ports():
Cannot init NIC port 0 (-22)
-
To fix this, referring to l3fwd operation, adjust the 'rss_hf' based on
device capability and just report a warning.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
Reviewed-by: Trevor Tao
---
app/test-pipeline/init.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c
index d146c44be0..84a1734519 100644
--- a/app/test-pipeline/init.c
+++ b/app/test-pipeline/init.c
@@ -188,21 +188,41 @@ static void
app_init_ports(void)
{
uint32_t i;
+ struct rte_eth_dev_info dev_info;
+
please delete this blank line.
/* Init NIC ports, then start the ports */
for (i = 0; i < app.n_ports; i++) {
uint16_t port;
int ret;
+ struct rte_eth_conf local_port_conf = port_conf;
port = app.ports[i];
RTE_LOG(INFO, USER1, "Initializing NIC port %u ...\n", port);
+ ret = rte_eth_dev_info_get(port, &dev_info);
+ if (ret != 0)
+ rte_panic("Error during getting device (port %u) info:
%s\n",
+ port, rte_strerror(-ret));
+
/* Init port */
+ local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
+ dev_info.flow_type_rss_offloads;
+ if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=
+ port_conf.rx_adv_conf.rss_conf.rss_hf) {
+ printf("Warning:"
+ "Port %u modified RSS hash function based on
hardware support,"
+ "requested:%#"PRIx64" configured:%#"PRIx64"\n",
+ port,
+ port_conf.rx_adv_conf.rss_conf.rss_hf,
+ local_port_conf.rx_adv_conf.rss_conf.rss_hf);
+ }
+
ret = rte_eth_dev_configure(
port,
1,
1,
- &port_conf);
+ &local_port_conf);
if (ret < 0)
rte_panic("Cannot init NIC port %u (%d)\n", port, ret);
This treatment is very common.
Acked-by: Huisong Li
RE: [PATCH] app/test-pipeline: relax RSS hash requirement
> -Original Message-
> From: lihuisong (C)
> Sent: Friday, July 14, 2023 3:50 PM
> To: Feifei Wang ; Cristian Dumitrescu
>
> Cc: dev@dpdk.org; nd ; Ruifeng Wang
> ; Trevor Tao
> Subject: Re: [PATCH] app/test-pipeline: relax RSS hash requirement
>
>
> 在 2023/6/26 15:45, Feifei Wang 写道:
> > For some drivers which can not support the configured RSS hash
> > functions, the thread reports 'invalid rss_hf' when doing device configure.
> >
> > For example, i40e driver can not support 'RTE_ETH_RSS_IPV4',
> > 'RTE_ETH_RSS_IPV6' and 'RTE_ETH_RSS_NONFRAG_IPV6_OTHER', thus it
> can
> > not run successfully in test-pipeline with XL710 NIC and reports the issue:
> > -
> > Ethdev port_id=0 invalid rss_hf: 0xa38c, valid value: 0x7ef8 PANIC in
> > app_init_ports():
> > Cannot init NIC port 0 (-22)
> > -
> >
> > To fix this, referring to l3fwd operation, adjust the 'rss_hf' based
> > on device capability and just report a warning.
> >
> > Signed-off-by: Feifei Wang
> > Reviewed-by: Ruifeng Wang
> > Reviewed-by: Trevor Tao
> > ---
> > app/test-pipeline/init.c | 22 +-
> > 1 file changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index
> > d146c44be0..84a1734519 100644
> > --- a/app/test-pipeline/init.c
> > +++ b/app/test-pipeline/init.c
> > @@ -188,21 +188,41 @@ static void
> > app_init_ports(void)
> > {
> > uint32_t i;
> > + struct rte_eth_dev_info dev_info;
> > +
> please delete this blank line.
Thanks for the reviewing. I will change this and update a new version.
> >
> > /* Init NIC ports, then start the ports */
> > for (i = 0; i < app.n_ports; i++) {
> > uint16_t port;
> > int ret;
> > + struct rte_eth_conf local_port_conf = port_conf;
> >
> > port = app.ports[i];
> > RTE_LOG(INFO, USER1, "Initializing NIC port %u ...\n", port);
> >
> > + ret = rte_eth_dev_info_get(port, &dev_info);
> > + if (ret != 0)
> > + rte_panic("Error during getting device (port %u)
> info: %s\n",
> > + port, rte_strerror(-ret));
> > +
> > /* Init port */
> > + local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
> > + dev_info.flow_type_rss_offloads;
> > + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=
> > + port_conf.rx_adv_conf.rss_conf.rss_hf) {
> > + printf("Warning:"
> > + "Port %u modified RSS hash function based
> on hardware support,"
> > + "requested:%#"PRIx64"
> configured:%#"PRIx64"\n",
> > + port,
> > + port_conf.rx_adv_conf.rss_conf.rss_hf,
> > + local_port_conf.rx_adv_conf.rss_conf.rss_hf);
> > + }
> > +
> > ret = rte_eth_dev_configure(
> > port,
> > 1,
> > 1,
> > - &port_conf);
> > + &local_port_conf);
> > if (ret < 0)
> > rte_panic("Cannot init NIC port %u (%d)\n", port,
> ret);
> >
> This treatment is very common.
> Acked-by: Huisong Li
[PATCH 1/3] doc: announce bonding macro change
From: Long Wu
In order to support inclusive naming, some of the macro in DPDK will
need to be renamed. Do this through deprecation process now for 23.07.
Signed-off-by: Long Wu
Reviewed-by: Chaoyong He
---
app/test-pmd/testpmd.c | 2 +-
doc/guides/rel_notes/deprecation.rst | 4
drivers/net/bonding/rte_eth_bond_api.c | 6 +++---
lib/ethdev/rte_ethdev.h| 5 +++--
4 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index c6ad9b18bf..938ca035d4 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -4248,7 +4248,7 @@ uint8_t port_is_bonding_slave(portid_t slave_pid)
slave_pid);
return 0;
}
- if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) ||
(port->slave_flag == 1))
+ if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDING_MEMBER) ||
(port->slave_flag == 1))
return 1;
return 0;
}
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index fb771a0305..c9477dd0da 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -161,3 +161,7 @@ Deprecation Notices
The new port library API (functions rte_swx_port_*)
will gradually transition from experimental to stable status
starting with DPDK 23.07 release.
+
+* bonding: The macro ``RTE_ETH_DEV_BONDED_SLAVE`` will be deprecated in
+ DPDK 23.07, and removed in DPDK 23.11. The relevant code can be updated using
+ ``RTE_ETH_DEV_BONDING_MEMBER``.
diff --git a/drivers/net/bonding/rte_eth_bond_api.c
b/drivers/net/bonding/rte_eth_bond_api.c
index 85d0528b7c..8b6cdce34a 100644
--- a/drivers/net/bonding/rte_eth_bond_api.c
+++ b/drivers/net/bonding/rte_eth_bond_api.c
@@ -472,7 +472,7 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id,
uint16_t slave_port_id)
return -1;
slave_eth_dev = &rte_eth_devices[slave_port_id];
- if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_BONDED_SLAVE) {
+ if (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_BONDING_MEMBER) {
RTE_BOND_LOG(ERR, "Slave device is already a slave of a bonded
device");
return -1;
}
@@ -615,7 +615,7 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id,
uint16_t slave_port_id)
}
/* Add slave details to bonded device */
- slave_eth_dev->data->dev_flags |= RTE_ETH_DEV_BONDED_SLAVE;
+ slave_eth_dev->data->dev_flags |= RTE_ETH_DEV_BONDING_MEMBER;
slave_vlan_filter_set(bonded_port_id, slave_port_id);
@@ -724,7 +724,7 @@ __eth_bond_slave_remove_lock_free(uint16_t bonded_port_id,
slave_eth_dev = &rte_eth_devices[slave_port_id];
slave_remove(internals, slave_eth_dev);
- slave_eth_dev->data->dev_flags &= (~RTE_ETH_DEV_BONDED_SLAVE);
+ slave_eth_dev->data->dev_flags &= (~RTE_ETH_DEV_BONDING_MEMBER);
/* first slave in the active list will be the primary by default,
* otherwise use first device in list */
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 3d44979b44..04a2564f22 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -2036,8 +2036,9 @@ struct rte_eth_dev_owner {
#define RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE RTE_BIT32(0)
/** Device supports link state interrupt */
#define RTE_ETH_DEV_INTR_LSC RTE_BIT32(1)
-/** Device is a bonded slave */
-#define RTE_ETH_DEV_BONDED_SLAVE RTE_BIT32(2)
+/** Device is a bonding member */
+#define RTE_ETH_DEV_BONDING_MEMBERRTE_BIT32(2)
+#define RTE_ETH_DEV_BONDED_SLAVE RTE_DEPRECATED(RTE_ETH_DEV_BONDED_SLAVE)
RTE_ETH_DEV_BONDING_MEMBER
/** Device supports device removal interrupt */
#define RTE_ETH_DEV_INTR_RMV RTE_BIT32(3)
/** Device is port representor */
--
2.39.1
[PATCH 0/3] announce bonding macro and function change
In order to support inclusive naming, some of the macro and function in DPDK will need to be renamed. Do this through deprecation process now for 23.07. Chaoyong He (2): doc: announce bonding data change doc: announce bonding function change Long Wu (1): doc: announce bonding macro change app/test-pmd/testpmd.c| 6 +- app/test/test_link_bonding.c | 100 +++--- app/test/test_link_bonding_mode4.c| 8 +- app/test/test_link_bonding_rssconf.c | 8 +- doc/guides/rel_notes/deprecation.rst | 19 drivers/net/bonding/bonding_testpmd.c | 4 +- drivers/net/bonding/rte_eth_bond.h| 42 - drivers/net/bonding/rte_eth_bond_8023ad.c | 4 +- drivers/net/bonding/rte_eth_bond_8023ad.h | 13 ++- drivers/net/bonding/rte_eth_bond_api.c| 14 +-- drivers/net/bonding/rte_eth_bond_pmd.c| 12 +-- drivers/net/bonding/version.map | 10 +++ examples/bond/main.c | 6 +- lib/ethdev/rte_ethdev.h | 5 +- 14 files changed, 162 insertions(+), 89 deletions(-) -- 2.39.1
[PATCH 2/3] doc: announce bonding data change
In order to support inclusive naming, the data structure of bonding 8023
info need to be renamed. Do this through deprecation process now for
23.07.
Signed-off-by: Chaoyong He
---
doc/guides/rel_notes/deprecation.rst | 3 +++
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
drivers/net/bonding/rte_eth_bond_8023ad.h | 4 ++--
drivers/net/bonding/rte_eth_bond_pmd.c| 4 ++--
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index c9477dd0da..5b16b66267 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -165,3 +165,6 @@ Deprecation Notices
* bonding: The macro ``RTE_ETH_DEV_BONDED_SLAVE`` will be deprecated in
DPDK 23.07, and removed in DPDK 23.11. The relevant code can be updated using
``RTE_ETH_DEV_BONDING_MEMBER``.
+ The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be
+ deprecated in DPDK 23.07, and removed in DPDK 23.11. The relevant code can be
+ updated using ``struct rte_eth_bond_8023ad_member_info``.
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 4a266bb2ca..49f22ffab1 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -1518,7 +1518,7 @@ rte_eth_bond_8023ad_setup(uint16_t port_id,
int
rte_eth_bond_8023ad_slave_info(uint16_t port_id, uint16_t slave_id,
- struct rte_eth_bond_8023ad_slave_info *info)
+ struct rte_eth_bond_8023ad_member_info *info)
{
struct rte_eth_dev *bond_dev;
struct bond_dev_private *internals;
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h
b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 7ad8d6d00b..ab6d0182a9 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -141,7 +141,7 @@ struct rte_eth_bond_8023ad_conf {
enum rte_bond_8023ad_agg_selection agg_selection;
};
-struct rte_eth_bond_8023ad_slave_info {
+struct rte_eth_bond_8023ad_member_info {
enum rte_bond_8023ad_selection selected;
uint8_t actor_state;
struct port_params actor;
@@ -195,7 +195,7 @@ rte_eth_bond_8023ad_setup(uint16_t port_id,
*/
int
rte_eth_bond_8023ad_slave_info(uint16_t port_id, uint16_t slave_id,
- struct rte_eth_bond_8023ad_slave_info *conf);
+ struct rte_eth_bond_8023ad_member_info *conf);
#ifdef __cplusplus
}
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
b/drivers/net/bonding/rte_eth_bond_pmd.c
index 73205f78f4..0a595d427c 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3471,7 +3471,7 @@ dump_lacp_port_param(const struct port_params *params,
FILE *f)
}
static void
-dump_lacp_slave(const struct rte_eth_bond_8023ad_slave_info *info, FILE *f)
+dump_lacp_slave(const struct rte_eth_bond_8023ad_member_info *info, FILE *f)
{
char a_state[256] = { 0 };
char p_state[256] = { 0 };
@@ -3520,7 +3520,7 @@ dump_lacp_slave(const struct
rte_eth_bond_8023ad_slave_info *info, FILE *f)
static void
dump_lacp(uint16_t port_id, FILE *f)
{
- struct rte_eth_bond_8023ad_slave_info slave_info;
+ struct rte_eth_bond_8023ad_member_info slave_info;
struct rte_eth_bond_8023ad_conf port_conf;
uint16_t slaves[RTE_MAX_ETHPORTS];
int num_active_slaves;
--
2.39.1
[PATCH 3/3] doc: announce bonding function change
In order to support inclusive naming, some of the function in DPDK will
need to be renamed. Do this through deprecation process now for 23.07.
Signed-off-by: Long Wu
Signed-off-by: Chaoyong He
---
app/test-pmd/testpmd.c| 4 +-
app/test/test_link_bonding.c | 100 +++---
app/test/test_link_bonding_mode4.c| 8 +-
app/test/test_link_bonding_rssconf.c | 8 +-
doc/guides/rel_notes/deprecation.rst | 12 +++
drivers/net/bonding/bonding_testpmd.c | 4 +-
drivers/net/bonding/rte_eth_bond.h| 42 -
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
drivers/net/bonding/rte_eth_bond_8023ad.h | 11 ++-
drivers/net/bonding/rte_eth_bond_api.c| 8 +-
drivers/net/bonding/rte_eth_bond_pmd.c| 8 +-
drivers/net/bonding/version.map | 10 +++
examples/bond/main.c | 6 +-
13 files changed, 144 insertions(+), 79 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 938ca035d4..2dd4180bf9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -612,7 +612,7 @@ change_bonding_slave_port_status(portid_t bond_pid, bool
is_stop)
portid_t slave_pid;
int i;
- num_slaves = rte_eth_bond_slaves_get(bond_pid, slave_pids,
+ num_slaves = rte_eth_bond_members_get(bond_pid, slave_pids,
RTE_MAX_ETHPORTS);
if (num_slaves < 0) {
fprintf(stderr, "Failed to get slave list for port = %u\n",
@@ -3519,7 +3519,7 @@ close_port(portid_t pid)
flush_port_owned_resources(pi);
#ifdef RTE_NET_BOND
if (port->bond_flag == 1)
- num_slaves = rte_eth_bond_slaves_get(pi,
+ num_slaves = rte_eth_bond_members_get(pi,
slave_pids, RTE_MAX_ETHPORTS);
#endif
rte_eth_dev_close(pi);
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 5c496352c2..a94644a831 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -281,14 +281,14 @@ test_create_bonded_device(void)
test_params->bonding_mode), "Failed to set ethdev %d to
mode %d",
test_params->bonded_port_id, test_params->bonding_mode);
- current_slave_count =
rte_eth_bond_slaves_get(test_params->bonded_port_id,
+ current_slave_count =
rte_eth_bond_members_get(test_params->bonded_port_id,
slaves, RTE_MAX_ETHPORTS);
TEST_ASSERT_EQUAL(current_slave_count, 0,
"Number of slaves %d is great than expected %d.",
current_slave_count, 0);
- current_slave_count = rte_eth_bond_active_slaves_get(
+ current_slave_count = rte_eth_bond_active_members_get(
test_params->bonded_port_id, slaves, RTE_MAX_ETHPORTS);
TEST_ASSERT_EQUAL(current_slave_count, 0,
@@ -335,19 +335,19 @@ test_add_slave_to_bonded_device(void)
uint16_t slaves[RTE_MAX_ETHPORTS];
- TEST_ASSERT_SUCCESS(rte_eth_bond_slave_add(test_params->bonded_port_id,
+ TEST_ASSERT_SUCCESS(rte_eth_bond_member_add(test_params->bonded_port_id,
test_params->slave_port_ids[test_params->bonded_slave_count]),
"Failed to add slave (%d) to bonded port (%d).",
test_params->slave_port_ids[test_params->bonded_slave_count],
test_params->bonded_port_id);
- current_slave_count =
rte_eth_bond_slaves_get(test_params->bonded_port_id,
+ current_slave_count =
rte_eth_bond_members_get(test_params->bonded_port_id,
slaves, RTE_MAX_ETHPORTS);
TEST_ASSERT_EQUAL(current_slave_count, test_params->bonded_slave_count
+ 1,
"Number of slaves (%d) is greater than expected (%d).",
current_slave_count, test_params->bonded_slave_count +
1);
- current_slave_count = rte_eth_bond_active_slaves_get(
+ current_slave_count = rte_eth_bond_active_members_get(
test_params->bonded_port_id, slaves, RTE_MAX_ETHPORTS);
TEST_ASSERT_EQUAL(current_slave_count, 0,
"Number of active slaves (%d) is not as
expected (%d).\n",
@@ -362,12 +362,12 @@ static int
test_add_slave_to_invalid_bonded_device(void)
{
/* Invalid port ID */
- TEST_ASSERT_FAIL(rte_eth_bond_slave_add(test_params->bonded_port_id + 5,
+ TEST_ASSERT_FAIL(rte_eth_bond_member_add(test_params->bonded_port_id +
5,
test_params->slave_port_ids[test_params->bonded_slave_count]),
"Expected call to failed as invalid port specified.");
/* Non bonded device */
- TEST_ASSERT_FAIL(rte_eth_bond_slave_add(tes
[PATCH v2] app/test-pipeline: relax RSS hash requirement
For some drivers which can not support the configured RSS hash functions,
the thread reports 'invalid rss_hf' when doing device configure.
For example, i40e driver can not support 'RTE_ETH_RSS_IPV4',
'RTE_ETH_RSS_IPV6' and 'RTE_ETH_RSS_NONFRAG_IPV6_OTHER', thus it can not
run successfully in test-pipeline with XL710 NIC and reports the issue:
-
Ethdev port_id=0 invalid rss_hf: 0xa38c, valid value: 0x7ef8
PANIC in app_init_ports():
Cannot init NIC port 0 (-22)
-
To fix this, referring to l3fwd operation, adjust the 'rss_hf' based on
device capability and just report a warning.
Signed-off-by: Feifei Wang
Reviewed-by: Ruifeng Wang
Reviewed-by: Trevor Tao
Acked-by: Huisong Li
---
app/test-pipeline/init.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c
index d146c44be0..558f0e428d 100644
--- a/app/test-pipeline/init.c
+++ b/app/test-pipeline/init.c
@@ -188,21 +188,40 @@ static void
app_init_ports(void)
{
uint32_t i;
+ struct rte_eth_dev_info dev_info;
/* Init NIC ports, then start the ports */
for (i = 0; i < app.n_ports; i++) {
uint16_t port;
int ret;
+ struct rte_eth_conf local_port_conf = port_conf;
port = app.ports[i];
RTE_LOG(INFO, USER1, "Initializing NIC port %u ...\n", port);
+ ret = rte_eth_dev_info_get(port, &dev_info);
+ if (ret != 0)
+ rte_panic("Error during getting device (port %u) info:
%s\n",
+ port, rte_strerror(-ret));
+
/* Init port */
+ local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
+ dev_info.flow_type_rss_offloads;
+ if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=
+ port_conf.rx_adv_conf.rss_conf.rss_hf) {
+ printf("Warning:"
+ "Port %u modified RSS hash function based on
hardware support,"
+ "requested:%#"PRIx64" configured:%#"PRIx64"\n",
+ port,
+ port_conf.rx_adv_conf.rss_conf.rss_hf,
+ local_port_conf.rx_adv_conf.rss_conf.rss_hf);
+ }
+
ret = rte_eth_dev_configure(
port,
1,
1,
- &port_conf);
+ &local_port_conf);
if (ret < 0)
rte_panic("Cannot init NIC port %u (%d)\n", port, ret);
--
2.25.1
RE: [PATCH v2] net/mlx5: fix lro update tcp header cksum error
Hi,
rte_raw_cksum() is doing __rte_raw_cksum_reduce(), so the returned result is
always below 0x1, upper half is zero.
We add 3 16-bit values in range 0...0x, what is possible result? Let's
consider the ranges:
upper/lower halves
0 0..0x, no carry
1 0..0x, one carry - once we add upper half - we'll get carry
again, should be added
2 0..0xFFFD, two carries
So, yes, we need this patch, sorry I've missed adjusted v2.
Acked-by: Viacheslav Ovsiienko
With best regards,
Slava
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, July 13, 2023 3:16 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Raslan Darawsheh
> Cc: dev@dpdk.org; jiangheng (G)
> Subject: Re: [PATCH v2] net/mlx5: fix lro update tcp header cksum error
>
> Any comment on this patch?
>
> 13/04/2023 02:57, jiangheng (G):
> > The variable csum is the sum of three 16 bits integers, the max value
> > is 0x2FFFD. The corner case of sum of 3 is 0x1 gives the wrong
> > result: 0x1 + 0x = 0x1, the upper 16 bits are not 0.
> > It must be folded again to ensure that the upper 16 bits are 0.
> >
> > Fixes: e4c2a16eb1de ("net/mlx5: handle LRO packets in Rx queue")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: jiangheng
> > ---
> > drivers/net/mlx5/mlx5_rx.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c
> > index a2be523e9e..ae537dfffa 100644
> > --- a/drivers/net/mlx5/mlx5_rx.c
> > +++ b/drivers/net/mlx5/mlx5_rx.c
> > @@ -1090,6 +1090,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr
> *__rte_restrict tcp,
> > tcp->cksum = 0;
> > csum += rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4);
> > csum = ((csum & 0x) >> 16) + (csum & 0x);
> > + csum = ((csum & 0x) >> 16) + (csum & 0x);
> > csum = (~csum) & 0x;
> > if (csum == 0)
> > csum = 0x;
> > > Hi, Jiangheng
> > >
> > > You are right, the corner case of sum of 3 is 0x1 gives the wrong
> result.
> > > Could you, please, format the patch according to the rules and send v2 ?
> > > - add Fixes: tag with reference to appropriate commit
> > > - add Cc: sta...@dpdk.org
> > > - fix typos in commit message - capitalize sentences, add trailing points,
> etc.
> > >
> > > With best regards,
> > > Slava
> > >
> > > > From: jiangheng (G)
> > > > Sent: среда, 12 апреля 2023 г. 14:39
> > > > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko
> > > >
> > > > Subject: [PATCH] net/mlx5: fix lro update tcp header cksum error
> > > >
> > > > csum is the sum of three 16 bits value it must be folded twice to
> > > > ensure that the upper 16 bits are 0
> > > > ---
> > > > drivers/net/mlx5/mlx5_rx.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/net/mlx5/mlx5_rx.c
> > > > b/drivers/net/mlx5/mlx5_rx.c index a2be523e9e..ae537dfffa 100644
> > > > --- a/drivers/net/mlx5/mlx5_rx.c
> > > > +++ b/drivers/net/mlx5/mlx5_rx.c
> > > > @@ -1090,6 +1090,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr
> > > > *__rte_restrict tcp,
> > > > tcp->cksum = 0;
> > > > csum += rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4);
> > > > csum = ((csum & 0x) >> 16) + (csum & 0x);
> > > > + csum = ((csum & 0x) >> 16) + (csum & 0x);
> > > > csum = (~csum) & 0x;
> > > > if (csum == 0)
> > > > csum = 0x;
> > > > --
> > > > 2.27.0
>
RE: [PATCH] usertools: enhance logic to display NUMA
[AMD Official Use Only - General]
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, July 11, 2023 9:56 PM
> To: Varghese, Vipin ; Stephen Hemminger
>
> Cc: david.march...@redhat.com; Tummala, Sivaprasad
> ; dev@dpdk.org
> Subject: Re: [PATCH] usertools: enhance logic to display NUMA
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> 11/07/2023 17:42, Stephen Hemminger:
> > On Sat, 26 Mar 2022 00:32:07 -0700
> > Vipin Varghese wrote:
> >
> > > +
> > > + output = " Socket " + str(socket).ljust(3, ' ') + " Numa " +
> str(numa).zfill(1) + " "
> > > + #output = " Socket " + str(socket).zfill(1) + " Numa " +
> > > str(numa).zfill(1) +
> " "
> > > + print(output)
> > > + print(format("-" * len(output)))
> > > +
> > > + for index,coreSibling in enumerate(numa_map[keys]):
> > > + print ("Core " + str(index).ljust(3, ' ') + "" +
> > > str(coreSibling))
> > > + #print ("Core " + str(index).zfill(3) + "" + str(coreSibling))
> > > +print("")
> > > +
> >
> > Git complains because you added new blank line at end of file.
> >
> > One wording suggestion would be to use the term "Node" instead of
> "Numa" in the table.
> > And fix heading alignment. The new headings don't look right.
> >
> > For the case with only single socket, single node, some of the
> > headings could be dropped as well.
>
> I don't understand why we continue working on this script.
> I thought we agreed it should be removed in favor of lstopo.
>
Sorry Thomas, I did not follow your ` I don't understand why we continue
working on this script. I thought we agreed it should be removed in favor of
lstopo.`
>From last email from my end `we should promote and document the changes
>provided the existing tool is phased out and use lstopo`.
Note:
1. This is with assumption that both Linux and Windows `lstopo` is modified and
handles `ACPI L3 SRAT NUMA` and `Node per Socket NUMA`.
2. I have not seen a depreciation notice for cpu_layout.py too.
RE: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
[AMD Official Use Only - General] > -Original Message- > From: Jerin Jacob > Sent: Thursday, July 13, 2023 4:11 PM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; Yigit, Ferruh ; > bruce.richard...@intel.com; david.march...@redhat.com; tho...@monjalon.net > Subject: Re: [PATCH] doc: deprecation notice to add callback data to > rte_event_fp_ops > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad > wrote: > > > > [AMD Official Use Only - General] > > > > Hi Jerin, > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Thursday, July 13, 2023 2:22 PM > > > To: Tummala, Sivaprasad > > > Cc: dev@dpdk.org; Yigit, Ferruh ; > > > bruce.richard...@intel.com; david.march...@redhat.com; > > > tho...@monjalon.net > > > Subject: Re: [PATCH] doc: deprecation notice to add callback data to > > > rte_event_fp_ops > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala > > > wrote: > > > > > > > > Deprecation notice to add "rte_eventdev_port_data" field to > > > > > > Could you share the rational for why rte_eventdev_port_data needs to be > added? > > > > "rte_eventdev_port_data" is used to hold callbacks registered optionally per > event device port and associated callback data. > > By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch > > this > data for fastpath eventdev inline functions in advance. > > Please add above info in the release notes for next version. Sure, will do the same. > > > > > > > > > > > > > ``rte_event_fp_ops`` for callback support. > > > > > > > > Signed-off-by: Sivaprasad Tummala > > > > --- > > > > doc/guides/rel_notes/deprecation.rst | 4 > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > > > b/doc/guides/rel_notes/deprecation.rst > > > > index 8e1cdd677a..2c69338818 100644 > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > @@ -133,6 +133,10 @@ Deprecation Notices > > > >``rte_cryptodev_get_auth_algo_string``, > > > ``rte_cryptodev_get_aead_algo_string`` and > > > >``rte_cryptodev_asym_get_xform_string`` respectively. > > > > > > > > +* eventdev: The struct rte_event_fp_ops will be updated with a > > > > +new element > > > > + rte_eventdev_port_data to support optional callbacks in DPDK 23.11. > > > > +This changes > > > > + the size of rte_event_fp_ops and result in ABI change. > > > > + > > > > * flow_classify: The flow_classify library and example have no > > > > maintainer. > > > >The library is experimental and, as such, it could be removed from > > > > DPDK. > > > >Its removal has been postponed to let potential users report > > > > interest > > > > -- > > > > 2.34.1 > > > >
[PATCH 1/1] net/sfc: add explicit fail path for unknown tunnel flow type
The driver supports flow tunnel offload. When the parsed rule
type is unknown, which must not happen, the driver does not
properly indicate the failure in non-debug builds. That
presumably makes Coverity report possible NULL pointer
dereference in regard with uninitialised HW match
specification (which gets properly initialised
when the rule type check is successful).
In order to fix this, replace the debug
assert with a proper runtime fail path.
Coverity issue: 393675
Fixes: 73e01736868b ("net/sfc: turn MAE flow action rules into shareable
resources")
Cc: sta...@dpdk.org
Signed-off-by: Ivan Malov
---
drivers/net/sfc/sfc_mae.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c
index 60a54fd425..f5fe55b46f 100644
--- a/drivers/net/sfc/sfc_mae.c
+++ b/drivers/net/sfc/sfc_mae.c
@@ -3460,8 +3460,10 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,
}
break;
default:
- SFC_ASSERT(B_FALSE);
- break;
+ rc = rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+ "FT: unexpected rule type");
+ goto fail_unexpected_ft_rule_type;
}
/*
@@ -3531,6 +3533,7 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,
if (ctx_mae.match_spec_action != NULL)
efx_mae_match_spec_fini(sa->nic, ctx_mae.match_spec_action);
+fail_unexpected_ft_rule_type:
fail_init_match_spec_action:
fail_priority_check:
return rc;
--
2.17.1
Re: [PATCH v7 1/1] dts: add smoke tests
Tested-by: Patrick Robb
Re: [PATCH v7 1/1] dts: add smoke tests
On Fri, Jul 14, 2023 at 4:47 PM Patrick Robb wrote: > > > Tested-by: Patrick Robb Have you tested with a non-root user? The unit tests are failing for me.
Re: [PATCH v2] eal: avoid issues in macro expansion of alignment
On Wed, 5 Jul 2023 00:16:50 +0200
Morten Brørup wrote:
> > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > Sent: Tuesday, 4 July 2023 18.01
> >
> > On Tue, 4 Jul 2023 10:43:40 +0200
> > Morten Brørup wrote:
> >
> > > > From: Stephen Hemminger [mailto:step...@networkplumber.org]
> > > > Sent: Tuesday, 4 July 2023 01.24
> > > >
> > > > RTE_ALIGN_MUL_NEAR is a macro so the cycle argument could
> > > > get evaluated twice causing some potential skew. Fix by
> > > > computing value once.
> > > >
> > > > Suggested by patch to fix side effects.
> > > >
> > > > Fixes: 5cbd14b3e5f9 ("eal: roundup TSC frequency when estimating")
> > > > Cc: pbhagavat...@marvell.com
> > > > Signed-off-by: Stephen Hemminger
> > > > ---
> > > > v2 - fix spelling error in commit message
> > > >
> > > > lib/eal/common/eal_common_timer.c | 8 ++--
> > > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/lib/eal/common/eal_common_timer.c
> > > > b/lib/eal/common/eal_common_timer.c
> > > > index 5686a5102b66..05614b0503cf 100644
> > > > --- a/lib/eal/common/eal_common_timer.c
> > > > +++ b/lib/eal/common/eal_common_timer.c
> > > > @@ -42,10 +42,14 @@ estimate_tsc_freq(void)
> > > > RTE_LOG(WARNING, EAL, "WARNING: TSC frequency estimated roughly"
> > > > " - clock timings may be less accurate.\n");
> > > > /* assume that the rte_delay_us_sleep() will sleep for 1 second
> > > > */
> > > > - uint64_t start = rte_rdtsc();
> > > > + uint64_t start, elapsed;
> > > > +
> > > > + start = rte_rdtsc();
> > > > rte_delay_us_sleep(US_PER_S);
> > > > + elapsed = rte_rdtsc() - start;
> > > > +
> > > > /* Round up to 10Mhz. 1E7 ~ 10Mhz */
> > > > - return RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);
> > > > + return RTE_ALIGN_MUL_NEAR(elapsed, CYC_PER_10MHZ);
> > > > }
> > > >
> > > > void
> > > > --
> > > > 2.39.2
> > >
> > > Please fix the RTE_ALIGN_MUL_NEAR() macro instead. It already uses
> > temporary variables with typeof() anyway.
> > >
> > > Other macros might have similar behavior of using their parameters
> > more than once, and could be improved too.
> > >
> >
> > It is already fixed, so this patch can be dropped.
>
> The macro is not fixed in 23.07-rc2 [1], but evaluates the "v" parameter four
> times; first two times to calculate respectively "ceil" and "floor", and then
> two times in the trigraph to determine which way to round. The "mul"
> parameter is evaluated twice by the macro.
>
> #define RTE_ALIGN_MUL_NEAR(v, mul)\
> ({ \
> typeof(v) ceil = RTE_ALIGN_MUL_CEIL(v, mul);\
> typeof(v) floor = RTE_ALIGN_MUL_FLOOR(v, mul); \
> (ceil - (v)) > ((v) - floor) ? floor : ceil;\
> })
>
> [1]:
> https://elixir.bootlin.com/dpdk/v23.07-rc2/source/lib/eal/include/rte_common.h#L388
>
Still working on sorting this out. Discovered this new issue.
If I fix RTE_ALIGN_CEIL to only evaluate arguments once.
-#define RTE_ALIGN_CEIL(val, align) \
- RTE_ALIGN_FLOOR(((val) + ((typeof(val)) (align) - 1)), align)
+#define RTE_ALIGN_CEIL(val, align) \
+ __extension__ ({\
+ uintptr_t _align = align; \
+ RTE_ALIGN_FLOOR(((val) + ((typeof(val)) (_align) - 1)),
_align); \
+ })
Then compiler won't allow it to be used in initialization of globals like this.
In file included from ../lib/telemetry/rte_telemetry.h:14,
from ../lib/ethdev/rte_ethdev_telemetry.c:9:
../lib/eal/include/rte_common.h:350:23: error: braced-group within expression
allowed only inside a function
350 | __extension__ ({\
| ^
../lib/eal/include/rte_common.h:371:31: note: in expansion of macro
‘RTE_ALIGN_CEIL’
371 | #define RTE_ALIGN(val, align) RTE_ALIGN_CEIL(val, align)
| ^~
../lib/ethdev/rte_eth_ctrl.h:435:10: note: in expansion of macro ‘RTE_ALIGN’
435 | (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT64_BIT)/UINT64_BIT)
| ^
../lib/ethdev/rte_eth_ctrl.h:452:34: note: in expansion of macro
‘RTE_FLOW_MASK_ARRAY_SIZE’
452 | uint64_t flow_types_mask[RTE_FLOW_MASK_ARRAY_SIZE];
RE: [PATCH v2] eal: avoid issues in macro expansion of alignment
Stephen, perhaps you can solve it using __builtin_constant_p() in the
macro.-MortenSent from smartphone. Please excuse brevity and spelling.
Oprindelig besked Fra: Stephen Hemminger
Dato: 14.07.2023 18.37 (GMT+01:00) Til: Morten
Brørup Cc: dev@dpdk.org, pbhagavat...@marvell.com
Emne: Re: [PATCH v2] eal: avoid issues in macro expansion of alignment On Wed,
5 Jul 2023 00:16:50 +0200Morten Brørup wrote:> >
From: Stephen Hemminger [mailto:step...@networkplumber.org]> > Sent: Tuesday, 4
July 2023 18.01> > > > On Tue, 4 Jul 2023 10:43:40 +0200> > Morten Brørup
wrote:> > > > > > From: Stephen Hemminger
[mailto:step...@networkplumber.org]> > > > Sent: Tuesday, 4 July 2023 01.24> >
> >> > > > RTE_ALIGN_MUL_NEAR is a macro so the cycle argument could> > > > get
evaluated twice causing some potential skew. Fix by> > > > computing value
once.> > > >> > > > Suggested by patch to fix side effects.> > > >> > > >
Fixes: 5cbd14b3e5f9 ("eal: roundup TSC frequency when estimating")> > > > Cc:
pbhagavat...@marvell.com> > > > Signed-off-by: Stephen Hemminger
> > > > ---> > > > v2 - fix spelling error in
commit message> > > >> > > > lib/eal/common/eal_common_timer.c | 8 ++--> >
> > 1 file changed, 6 insertions(+), 2 deletions(-)> > > >> > > > diff --git
a/lib/eal/common/eal_common_timer.c> > > > b/lib/eal/common/eal_common_timer.c>
> > > index 5686a5102b66..05614b0503cf 100644> > > > ---
a/lib/eal/common/eal_common_timer.c> > > > +++
b/lib/eal/common/eal_common_timer.c> > > > @@ -42,10 +42,14 @@
estimate_tsc_freq(void)> > > > RTE_LOG(WARNING, EAL, "WARNING: TSC
frequency estimated roughly"> > > > " - clock timings may be
less accurate.\n");> > > > /* assume that the rte_delay_us_sleep() will
sleep for 1 second */> > > > - uint64_t start = rte_rdtsc();> > > > +
uint64_t start, elapsed;> > > > +> > > > + start = rte_rdtsc();> > > >
rte_delay_us_sleep(US_PER_S);> > > > + elapsed = rte_rdtsc() - start;> > > >
+> > > > /* Round up to 10Mhz. 1E7 ~ 10Mhz */> > > > - return
RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);> > > > + return
RTE_ALIGN_MUL_NEAR(elapsed, CYC_PER_10MHZ);> > > > }> > > >> > > > void> > >
> --> > > > 2.39.2 > > >> > > Please fix the RTE_ALIGN_MUL_NEAR() macro
instead. It already uses > > temporary variables with typeof() anyway. > > >>
> > Other macros might have similar behavior of using their parameters > >
more than once, and could be improved too. > > > > > > > It is already fixed,
so this patch can be dropped. > > The macro is not fixed in 23.07-rc2 [1], but
evaluates the "v" parameter four times; first two times to calculate
respectively "ceil" and "floor", and then two times in the trigraph to
determine which way to round. The "mul" parameter is evaluated twice by the
macro.> > #define RTE_ALIGN_MUL_NEAR(v, mul) \> ({
\> typeof(v)
ceil = RTE_ALIGN_MUL_CEIL(v, mul);\> typeof(v) floor =
RTE_ALIGN_MUL_FLOOR(v, mul); \> (ceil - (v)) > ((v) - floor) ?
floor : ceil;\> })> > [1]:
https://elixir.bootlin.com/dpdk/v23.07-rc2/source/lib/eal/include/rte_common.h#L388>
Still working on sorting this out. Discovered this new issue.If I fix
RTE_ALIGN_CEIL to only evaluate arguments once.-#define RTE_ALIGN_CEIL(val,
align) \-RTE_ALIGN_FLOOR(((val) + ((typeof(val)) (align) - 1)),
align)+#define RTE_ALIGN_CEIL(val, align)\+
__extension__ ({\+ uintptr_t
_align = align; \+ RTE_ALIGN_FLOOR(((val) +
((typeof(val)) (_align) - 1)), _align); \+ }) Then compiler won't allow it
to be used in initialization of globals like this.In file included from
../lib/telemetry/rte_telemetry.h:14, from
../lib/ethdev/rte_ethdev_telemetry.c:9:../lib/eal/include/rte_common.h:350:23:
error: braced-group within expression allowed only inside a function 350 |
__extension__ ({ \ |
^../lib/eal/include/rte_common.h:371:31: note: in expansion of macro
‘RTE_ALIGN_CEIL’ 371 | #define RTE_ALIGN(val, align) RTE_ALIGN_CEIL(val,
align) |
^~../lib/ethdev/rte_eth_ctrl.h:435:10: note: in expansion of macro
‘RTE_ALIGN’ 435 | (RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT64_BIT)/UINT64_BIT)
| ^../lib/ethdev/rte_eth_ctrl.h:452:34: note: in
expansion of macro ‘RTE_FLOW_MASK_ARRAY_SIZE’ 452 | uint64_t
flow_types_mask[RTE_FLOW_MASK_ARRAY_SIZE];
Re: [PATCH v7 1/1] dts: add smoke tests
On Fri, Jul 14, 2023 at 11:30 AM Juraj Linkeš wrote: > On Fri, Jul 14, 2023 at 4:47 PM Patrick Robb wrote: > > > > > > Tested-by: Patrick Robb > > Have you tested with a non-root user? The unit tests are failing for me. > We have been running this as root in testing and there is an issue with running this as non-root users because the unit tests don't escalate privileges. This is a trivial fix of course, but in further testing I think it also makes sense to extend the timeouts for these unit tests (as we do in regular CI testing) and I will wrap this into an updated patch on Monday morning.
