RE: [PATCH v17] app/procinfo: display eventdev xstats
>+Has new coverity issue.
>+The reason is the boolean is set every time because it gets every time.
>+Looks like code goes over eventdev_var[] even if no eventdevs are present.
>+Should only look for the number of eventdevs
Thanks Stephen, I will add a condition at the top of the function like:
evdevs = rte_event_dev_count();
if (!evdevs)
return 0;
This will ensure if there is no eventdev device function returns.
I will also change the for loop to iterate only with the count of evdevs like:
for (i = 0; i < evdevs; i++) {... instead of for (i = 0; i <
RTE_EVENT_MAX_DEVS; i++) {.
I still need that flag to be set when a user sets a value from command line for
a queue or port.
The flag is needed to display and exit from the program.
if (process_eventdev_xstats())
return 0;
Re: [PATCH v17] app/procinfo: display eventdev xstats
On Sat, 8 Jul 2023 15:11:45 +
"Sevincer, Abdullah" wrote:
> >+Has new coverity issue.
> >+The reason is the boolean is set every time because it gets every time.
>
> >+Looks like code goes over eventdev_var[] even if no eventdevs are present.
> >+Should only look for the number of eventdevs
>
> Thanks Stephen, I will add a condition at the top of the function like:
>
> evdevs = rte_event_dev_count();
> if (!evdevs)
> return 0;
>
> This will ensure if there is no eventdev device function returns.
>
> I will also change the for loop to iterate only with the count of evdevs like:
> for (i = 0; i < evdevs; i++) {... instead of for (i = 0; i <
> RTE_EVENT_MAX_DEVS; i++) {.
>
> I still need that flag to be set when a user sets a value from command line
> for a queue or port.
> The flag is needed to display and exit from the program.
>
> if (process_eventdev_xstats())
> return 0;
>
Maybe something like this:
PS: also shortened variable names for clarity
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index be63eace6909..e3d2578c39dc 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -2045,18 +2045,13 @@ xstats_reset(uint8_t dev_id,
}
-static int
-process_eventdev_xstats(void)
+static unsigned int
+eventdev_xstats(void)
{
- int i;
- int j;
- int processing_eventdev_xstats = 0;
-
- for (i = 0; i < RTE_EVENT_MAX_DEVS; i++) {
-
- if (!processing_eventdev_xstats)
- processing_eventdev_xstats = 1;
+ unsigned int count = 0;
+ int i, j;
+ for (i = 0; i < rte_event_dev_count(); i++) {
if (eventdev_var[i].dump_xstats) {
int ret = rte_event_dev_dump(i, stdout);
@@ -2106,12 +2101,10 @@ process_eventdev_xstats(void)
eventdev_var[i].queues[j]);
}
}
+ ++count;
}
- if (processing_eventdev_xstats)
- return 1;
-
- return 0;
+ return count;
}
int
@@ -2164,7 +2157,7 @@ main(int argc, char **argv)
return 0;
}
- if (process_eventdev_xstats())
+ if (eventdev_xstats() > 0)
return 0;
nb_ports = rte_eth_dev_count_avail();
[PATCH v1] app/procinfo: revise display eventdev xstats
process_eventdev_xstats() function was iterating over
eventdev_var[] structure even if there is no eventdev present.
Revised the code to check to iterate and only look for the number
of eventdevs present in the system. Also, shortened function name to
eventdev_xstats().
Coverity issue: 395458
Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats")
Cc: sta...@dpdk.org
Signed-off-by: Abdullah Sevincer
---
app/proc-info/main.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index be63eace69..88cee0ca48 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -2045,19 +2045,16 @@ xstats_reset(uint8_t dev_id,
}
-static int
-process_eventdev_xstats(void)
+static unsigned int
+eventdev_xstats(void)
{
- int i;
- int j;
- int processing_eventdev_xstats = 0;
-
- for (i = 0; i < RTE_EVENT_MAX_DEVS; i++) {
+ unsigned int count = 0;
+ int i, j;
- if (!processing_eventdev_xstats)
- processing_eventdev_xstats = 1;
+ for (i = 0; i < rte_event_dev_count(); i++) {
if (eventdev_var[i].dump_xstats) {
+ ++count;
int ret = rte_event_dev_dump(i, stdout);
if (ret)
@@ -2065,6 +2062,7 @@ process_eventdev_xstats(void)
}
if (eventdev_var[i].shw_device_xstats == 1) {
+ ++count;
xstats_display(i, RTE_EVENT_DEV_XSTATS_DEVICE, 0);
if (eventdev_var[i].reset_xstats == 1)
@@ -2072,6 +2070,7 @@ process_eventdev_xstats(void)
}
if (eventdev_var[i].shw_all_ports == 1) {
+ ++count;
for (j = 0; j < MAX_PORTS_QUEUES; j++) {
xstats_display(i, RTE_EVENT_DEV_XSTATS_PORT, j);
@@ -2079,6 +2078,8 @@ process_eventdev_xstats(void)
xstats_reset(i,
RTE_EVENT_DEV_XSTATS_PORT, j);
}
} else {
+ if (eventdev_var[i].num_ports > 0)
+ ++count;
for (j = 0; j < eventdev_var[i].num_ports; j++) {
xstats_display(i, RTE_EVENT_DEV_XSTATS_PORT,
eventdev_var[i].ports[j]);
@@ -2090,6 +2091,7 @@ process_eventdev_xstats(void)
}
if (eventdev_var[i].shw_all_queues == 1) {
+ ++count;
for (j = 0; j < MAX_PORTS_QUEUES; j++) {
xstats_display(i, RTE_EVENT_DEV_XSTATS_QUEUE,
j);
@@ -2097,6 +2099,8 @@ process_eventdev_xstats(void)
xstats_reset(i,
RTE_EVENT_DEV_XSTATS_QUEUE, j);
}
} else {
+ if (eventdev_var[i].num_queues > 0)
+ ++count;
for (j = 0; j < eventdev_var[i].num_queues; j++) {
xstats_display(i, RTE_EVENT_DEV_XSTATS_QUEUE,
eventdev_var[i].queues[j]);
@@ -2108,10 +2112,7 @@ process_eventdev_xstats(void)
}
}
- if (processing_eventdev_xstats)
- return 1;
-
- return 0;
+ return count;
}
int
@@ -2164,7 +2165,7 @@ main(int argc, char **argv)
return 0;
}
- if (process_eventdev_xstats())
+ if (eventdev_xstats() > 0)
return 0;
nb_ports = rte_eth_dev_count_avail();
--
2.25.1
Re: [PATCH v3] dts: replace pexpect with fabric
Tested-by: Patrick Robb
On Fri, Jun 9, 2023 at 5:46 AM Juraj Linkeš
wrote:
> Pexpect is not a dedicated SSH connection library while Fabric is. With
> Fabric, all SSH-related logic is provided and we can just focus on
> what's DTS specific.
>
> Signed-off-by: Juraj Linkeš
> ---
>
> Notes:
> v3: updated passwordless sudo setup on Linux
>
> doc/guides/tools/dts.rst | 29 +-
> dts/conf.yaml | 2 +-
> dts/framework/exception.py| 10 +-
> dts/framework/remote_session/linux_session.py | 31 +-
> dts/framework/remote_session/os_session.py| 51 +++-
> dts/framework/remote_session/posix_session.py | 48 +--
> .../remote_session/remote/remote_session.py | 35 ++-
> .../remote_session/remote/ssh_session.py | 287 ++
> dts/framework/testbed_model/sut_node.py | 12 +-
> dts/framework/utils.py| 9 -
> dts/poetry.lock | 161 --
> dts/pyproject.toml| 2 +-
> 12 files changed, 376 insertions(+), 301 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
> index ebd6dceb6a..c7b31623e4 100644
> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -95,9 +95,14 @@ Setting up DTS environment
>
> #. **SSH Connection**
>
> - DTS uses Python pexpect for SSH connections between DTS environment
> and the other hosts.
> - The pexpect implementation is a wrapper around the ssh command in the
> DTS environment.
> - This means it'll use the SSH agent providing the ssh command and its
> keys.
> + DTS uses the Fabric Python library for SSH connections between DTS
> environment
> + and the other hosts.
> + The authentication method used is pubkey authentication.
> + Fabric tries to use a passed key/certificate,
> + then any key it can with through an SSH agent,
> + then any "id_rsa", "id_dsa" or "id_ecdsa" key discoverable in
> ``~/.ssh/``
> + (with any matching OpenSSH-style certificates).
> + DTS doesn't pass any keys, so Fabric tries to use the other two
> methods.
>
>
> Setting up System Under Test
> @@ -132,6 +137,21 @@ There are two areas that need to be set up on a
> System Under Test:
> It's possible to use the hugepage configuration already present on
> the SUT.
> If you wish to do so, don't specify the hugepage configuration in
> the DTS config file.
>
> +#. **User with administrator privileges**
> +
> +.. _sut_admin_user:
> +
> + DTS needs administrator privileges to run DPDK applications (such as
> testpmd) on the SUT.
> + The SUT user must be able run commands in privileged mode without
> asking for password.
> + On most Linux distributions, it's a matter of setting up passwordless
> sudo:
> +
> + #. Run ``sudo visudo`` and check that it contains ``%sudo
> ALL=(ALL:ALL) NOPASSWD:ALL``.
> +
> + #. Add the SUT user to the sudo group with:
> +
> + .. code-block:: console
> +
> + sudo usermod -aG sudo
>
> Running DTS
> ---
> @@ -151,7 +171,8 @@ which is a template that illustrates what can be
> configured in DTS:
> :start-at: executions:
>
>
> -The user must be root or any other user with prompt starting with ``#``.
> +The user must have :ref:`administrator privileges `
> +which don't require password authentication.
> The other fields are mostly self-explanatory
> and documented in more detail in
> ``dts/framework/config/conf_yaml_schema.json``.
>
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index a9bd8a3ecf..129801d87c 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -16,7 +16,7 @@ executions:
> nodes:
>- name: "SUT 1"
> hostname: sut1.change.me.localhost
> -user: root
> +user: dtsuser
> arch: x86_64
> os: linux
> lcores: ""
> diff --git a/dts/framework/exception.py b/dts/framework/exception.py
> index ca353d98fc..44ff4e979a 100644
> --- a/dts/framework/exception.py
> +++ b/dts/framework/exception.py
> @@ -62,13 +62,19 @@ class SSHConnectionError(DTSError):
> """
>
> host: str
> +errors: list[str]
> severity: ClassVar[ErrorSeverity] = ErrorSeverity.SSH_ERR
>
> -def __init__(self, host: str):
> +def __init__(self, host: str, errors: list[str] | None = None):
> self.host = host
> +self.errors = [] if errors is None else errors
>
> def __str__(self) -> str:
> -return f"Error trying to connect with {self.host}"
> +message = f"Error trying to connect with {self.host}."
> +if self.errors:
> +message += f" Errors encountered while retrying: {',
> '.join(self.errors)}"
> +
> +return message
>
>
> class SSHSessionDeadError(DTSError):
> diff --git a/dts/framework/remote_session/linux_session.py
> b/dts/framework/remote_session/linux_session.py
> index a1e3bc3a92..f13f399121 100644
> --- a/dts/framework/remote_session/linux_session.py
> +++ b/dts/framework/remote_session/linux_
Re: [PATCH v4] dmadev: add tracepoints
Hi Thomas,
On 2023/7/7 18:40, Thomas Monjalon wrote:
> 26/05/2023 10:42, Chengwen Feng:
>> Add tracepoints at important APIs for tracing support.
>>
>> Signed-off-by: Chengwen Feng
>> Acked-by: Morten Brørup
>>
>> ---
>> v4: Fix asan smoke fail.
>> v3: Address Morten's comment:
>> Move stats_get and vchan_status and to trace_fp.h.
>> v2: Address Morten's comment:
>> Make stats_get as fast-path trace-points.
>> Place fast-path trace-point functions behind in version.map.
>
> There are more things to fix.
> First you must export rte_dmadev_trace_fp.h as it is included by rte_dmadev.h.
It was already included by rte_dmadev.h:
diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h
index e61d71959e..e792b90ef8 100644
--- a/lib/dmadev/rte_dmadev.h
+++ b/lib/dmadev/rte_dmadev.h
@@ -796,6 +796,7 @@ struct rte_dma_sge {
};
#include "rte_dmadev_core.h"
+#include "rte_dmadev_trace_fp.h"
> Note: you could have caught this if testing the example app for DMA.
> Second, you must avoid structs and enum in this header file,
Let me explain the #if #endif logic:
For the function:
uint16_t
rte_dma_completed(int16_t dev_id, uint16_t vchan, const uint16_t nb_cpls,
uint16_t *last_idx, bool *has_error)
The common trace implementation:
RTE_TRACE_POINT_FP(
rte_dma_trace_completed,
RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
const uint16_t nb_cpls, uint16_t *last_idx,
bool *has_error, uint16_t ret),
rte_trace_point_emit_i16(dev_id);
rte_trace_point_emit_u16(vchan);
rte_trace_point_emit_u16(nb_cpls);
rte_trace_point_emit_ptr(idx_val);
rte_trace_point_emit_ptr(has_error);
rte_trace_point_emit_u16(ret);
)
But it has a problem: for pointer parameter (e.g. last_idx and has_error), only
record
the pointer value (i.e. address value).
I think the pointer value has no mean (in particular, many of there pointers
are stack
variables), the value of the pointer point to is meaningful.
So I add the pointer reference like below (as V3 did):
RTE_TRACE_POINT_FP(
rte_dma_trace_completed,
RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
const uint16_t nb_cpls, uint16_t *last_idx,
bool *has_error, uint16_t ret),
int has_error_val = *has_error;// pointer reference
int last_idx_val = *last_idx; // pointer reference
rte_trace_point_emit_i16(dev_id);
rte_trace_point_emit_u16(vchan);
rte_trace_point_emit_u16(nb_cpls);
rte_trace_point_emit_int(last_idx_val);// record the value of
pointer
rte_trace_point_emit_int(has_error_val); // record the value of
pointer
rte_trace_point_emit_u16(ret);
)
Unfortunately, the above lead to asan failed. because in:
RTE_TRACE_POINT_REGISTER(rte_dma_trace_completed,
lib.dmadev.completed)
it will invoke rte_dma_trace_completed() with the parameter is undefined.
To solve this problem, consider the rte_dmadev_trace_points.c will include
rte_trace_point_register.h,
and the rte_trace_point_register.h will defined macro:
_RTE_TRACE_POINT_REGISTER_H_.
so we update trace points as (as V4 did):
RTE_TRACE_POINT_FP(
rte_dma_trace_completed,
RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
const uint16_t nb_cpls, uint16_t *last_idx,
bool *has_error, uint16_t ret),
#ifdef _RTE_TRACE_POINT_REGISTER_H_
uint16_t __last_idx = 0;
bool __has_error = false;
last_idx = &__last_idx; // make sure the pointer has
meaningful value.
has_error = &__has_error;// so that the next pointer
reference will work well.
#endif /* _RTE_TRACE_POINT_REGISTER_H_ */
int has_error_val = *has_error;
int last_idx_val = *last_idx;
rte_trace_point_emit_i16(dev_id);
rte_trace_point_emit_u16(vchan);
rte_trace_point_emit_u16(nb_cpls);
rte_trace_point_emit_int(last_idx_val);
rte_trace_point_emit_int(has_error_val);
rte_trace_point_emit_u16(ret);
)
> otherwise it cannot be included alone.
> Look at what is done in other *_trace_fp.h files.
>
>
Whether enable_trace_fp is true or false, the v4 work well.
Below is that run examples with enable_trace_fp=true.
./dpdk-test --file-prefix=feng123 --trace=lib.dmadev.* -l 10-11
EAL: Detected CPU lcores: 96
EAL: Detected NUMA nodes: 4
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/feng123/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: VFIO support initialized
TELEMETRY: No legacy callbacks, legacy socket not created
APP: HPET is not enabled, using TSC as default timer
RTE>>dmadev_autotest
skeldma_probe(): Create dma_skeleton dmadev with lcore-id -1
### Test dmadev infrastructure using skeleton driver
test_dma_get_dev_id_by_name Pas
Re: [PATCH v5 00/11] use rte_pktmbuf_mto_offset
Series-acked-by: Chengwen Feng On 2023/7/8 9:57, Stephen Hemminger wrote: > v5 - fix checkpatch warnings about long lines > split up complex expression in test/crypto_dev > > Stephen Hemminger (11): > gro: use rte_pktmbuf_mtod_offset > gso: use rte_pktmbuf_mtod_offset > test/crypto_dev: use rte_pktmbuf_mtod_offset > drivers/crypto: use rte_pktmbuf_mtod_offset > net/nfp: use rte_pktmbuf_mtod_offset > net/tap: use rte_pktmbuf_motd_offset > baseband/fpga: use rte_pktmbuf_offset > cpt: use rte_pktmbuf_mtod_offset > testpmd: use rte_pktmbuf_mtod_offset > examples/ptpclient: use rte_pktmbuf_mtod_offset > examples/l2fwd-crypto: use rte_pktmbuf_mtod_offset > > app/test-pmd/ieee1588fwd.c| 4 +- > app/test/test_cryptodev.c | 83 --- > .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 7 +- > drivers/common/cpt/cpt_ucode.h| 10 +-- > drivers/crypto/caam_jr/caam_jr.c | 8 +- > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 2 +- > drivers/crypto/cnxk/cnxk_se.h | 5 +- > drivers/crypto/ipsec_mb/pmd_kasumi.c | 19 +++-- > drivers/crypto/ipsec_mb/pmd_snow3g.c | 4 +- > drivers/crypto/ipsec_mb/pmd_zuc.c | 18 ++-- > drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 9 +- > drivers/crypto/qat/qat_sym.h | 9 +- > drivers/net/nfp/flower/nfp_flower_cmsg.h | 3 +- > drivers/net/nfp/flower/nfp_flower_ctrl.c | 4 +- > drivers/net/tap/rte_eth_tap.c | 4 +- > examples/l2fwd-crypto/main.c | 14 ++-- > examples/ptpclient/ptpclient.c| 18 ++-- > lib/gro/gro_tcp.h | 4 +- > lib/gro/gro_tcp4.c| 4 +- > lib/gro/gro_tcp6.c| 4 +- > lib/gro/gro_udp4.c| 4 +- > lib/gro/gro_vxlan_tcp4.c | 4 +- > lib/gro/gro_vxlan_udp4.c | 4 +- > lib/gso/gso_common.h | 12 +-- > lib/gso/gso_tcp4.c| 8 +- > lib/gso/gso_tunnel_tcp4.c | 12 +-- > lib/gso/gso_tunnel_udp4.c | 18 ++-- > 27 files changed, 161 insertions(+), 134 deletions(-) >
