Photon OS + MLX not coming up

[chetan bhasin]

Hi,



We are using DPDK version “*21.02*” and facing issue while doing port start
of MLX (ConnectX-4 Lx Virtual Function)



*:0b:00.0 'MT27710 Family [ConnectX-4 Lx Virtual Function]* 1016'
if=eth2 drv=mlx5_core unused=



*Photon kernel version* - 4.19.277-3.ph3



*Firmware version – *

]# ethtool -i eth2

driver: mlx5_core

version: 5.0-0

firmware-version: 14.26.1040 (HP_2690110034)

expansion-rom-version:

bus-info: :0b:00.0

supports-statistics: yes

supports-test: yes

supports-eeprom-access: no

supports-register-dump: no

supports-priv-flags: yes



*modinfo mlx5_core *

filename:
/lib/modules/4.19.277-3.ph3/kernel/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko.xz

version:5.0-0

license:Dual BSD/GPL

description:Mellanox 5th generation network adapters (ConnectX series)
core driver

author: Eli Cohen e...@mellanox.com

srcversion: 981FA6D58D2B017B197F177



We are seeing following errors in dpdk when we start the port



2023/05/12 06:00:57:497 notice dpdk   EAL: Couldn't map new
region for DMA

2023/05/12 06:01:29:966 error  dpdk   Interface
TwentyFiveGigabitEthernetb/0/0 error -12: Unknown error -12

2023/05/12 06:01:29:966 error  interface  sw_set_flags_helper:
dpdk_interface_admin_up_down: Interface start failed

2023/05/12 06:01:29:966 notice dpdk   common_mlx5: Unable to
find virtually contiguous chunk for address (0x10).
rte_memseg_contig_walk() failed.

2023/05/12 06:01:29:966 notice dpdk   mlx5_pci: Failed to init
cache list NIC_ingress_0_matcher_cache entry (nil).

2023/05/12 06:01:29:966 notice dpdk   mlx5_pci: port 0 failed
to set defaults flows

Re: [PATCH v4 0/4] Support AMD CDX bus, for FPGA based CDX devices. The CDX

[Ferruh Yigit]

On 5/8/2023 12:18 PM, Nipun Gupta wrote:
> It uses sysfs interface and the vfio-cdx driver to discover
> and initialize the CDX devices.
> 
> The CDX bus and VFIO support is available at Xilinx open source tree:
> https://github.com/Xilinx/linux-xlnx (drivers/cdx/ and drivers/vfio/cdx)
> 
> Linux CDX bus patches has been added into linux next:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cdx
> 
> VFIO patches are also submitted in upstream:
> https://www.spinics.net/lists/kvm/msg310623.html
> 
> CDX is a Hardware Architecture designed for AMD FPGA devices. It
> consists of mechanism for interaction between FPGA, Firmware and 
> the APUs (Application CPUs).
> Firmware resides on RPU (Realtime CPUs) which interacts with
> the FPGA program manager and the APUs. The RPU provides memory-mapped
> interface (RPU if) which is used to communicate with APUs.
> 
> VFIO CDX driver provides the CDX device resources like MMIO and interrupts
> to map to user-space. DPDK CDX bus uses sysfs interface and the vfio-cdx
> driver to discover and initialize the CDX devices for user-space
> applications.
> 
> Changes v3->v4:
> - removed platform specific patch (adding config for ARM CDX)
>   from this series
> 
> Changes v2->v3:
> - merged cdx bus compilation enablement in the first patch
> - fixed issue reported by check-git-log.sh
> - updated release notes
> - updated offset to uint64_t instead of off_t in cdx_map_resource
> 
> Changes v1->v2:
> - Moved file rte_cdx_bus.h to internal bus_cdx_driver.h
>   and added this file to deivce_cdx_headers
> - Moved cdx.h to private.h
> - Removed rte_ prefix from the static symbols in .c files.
> 
> Changes RFC->v1:
> - Marked few API's as internal which were not required
>   to be provided to user.
> 
> Nipun Gupta (4):
>   bus/cdx: introduce cdx bus
>   bus/cdx: add DMA map and unmap support
>   bus/cdx: add support for MSI
>   bus/cdx: support plug unplug and dev iterator

For series,
Acked-by: Ferruh Yigit 

RE: [PATCH v2 4/4] app: add testgraph application

[Yan, Zhirun]

> -Original Message-
> From: Vamsi Attunuru 
> Sent: Tuesday, April 25, 2023 9:15 PM
> To: dev@dpdk.org; tho...@monjalon.net; jer...@marvell.com
> Cc: vattun...@marvell.com; ndabilpu...@marvell.com
> Subject: [PATCH v2 4/4] app: add testgraph application
> 
> Patch adds test-graph application to validate graph
> and node libraries.
> 
> Signed-off-by: Vamsi Attunuru 
> ---
>  app/meson.build|1 +
>  app/test-graph/cmdline.c   |  211 +
>  app/test-graph/cmdline_graph.c |  294 +++
>  app/test-graph/cmdline_graph.h |   19 +
>  app/test-graph/meson.build |   14 +
>  app/test-graph/parameters.c|  157 
>  app/test-graph/testgraph.c | 1426 
>  app/test-graph/testgraph.h |   91 ++
>  doc/guides/tools/index.rst |1 +
>  doc/guides/tools/testgraph.rst |  131 +++
>  10 files changed, 2345 insertions(+)
> 
> diff --git a/app/meson.build b/app/meson.build
> index 74d2420f67..6c7b24e604 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -22,6 +22,7 @@ apps = [
>  'test-eventdev',
>  'test-fib',
>  'test-flow-perf',
> +'test-graph',
>  'test-gpudev',
>  'test-mldev',
>  'test-pipeline',
> diff --git a/app/test-graph/cmdline.c b/app/test-graph/cmdline.c
> new file mode 100644
> index 00..d9474d827a
> --- /dev/null
> +++ b/app/test-graph/cmdline.c
> @@ -0,0 +1,211 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Marvell International Ltd.
> + */
> +
> +#include 
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include "cmdline_graph.h"
> +#include "testgraph.h"
> +
> +static struct cmdline *testgraph_cl;
> +static cmdline_parse_ctx_t *main_ctx;
> +
> +/* *** Help command with introduction. *** */
> +struct cmd_help_brief_result {
> + cmdline_fixed_string_t help;
> +};
> +
> +static void
> +cmd_help_brief_parsed(__rte_unused void *parsed_result, struct cmdline *cl,
> __rte_unused void *data)
> +{
> + cmdline_printf(cl,
> +"\n"
> +"Help is available for the following sections:\n\n"
> +"help control: Start and stop 
> graph walk.\n"
> +"help display: Displaying port, 
> stats and config
> "
> +"information.\n"
> +"help config : Configuration 
> information.\n"
> +"help all: All of the above 
> sections.\n\n");
> +}
> +
> +static cmdline_parse_token_string_t cmd_help_brief_help =
> + TOKEN_STRING_INITIALIZER(struct cmd_help_brief_result, help, "help");
> +
> +static cmdline_parse_inst_t cmd_help_brief = {
> + .f = cmd_help_brief_parsed,
> + .data = NULL,
> + .help_str = "help: Show help",
> + .tokens = {
> + (void *)&cmd_help_brief_help,
> + NULL,
> + },
> +};
> +
> +/* *** Help command with help sections. *** */
> +struct cmd_help_long_result {
> + cmdline_fixed_string_t help;
> + cmdline_fixed_string_t section;
> +};
> +
> +static void
> +cmd_help_long_parsed(void *parsed_result, struct cmdline *cl, __rte_unused
> void *data)
> +{
> + int show_all = 0;
> + struct cmd_help_long_result *res = parsed_result;
> +
> + if (!strcmp(res->section, "all"))
> + show_all = 1;
> +
> + if (show_all || !strcmp(res->section, "control")) {
> +
> + cmdline_printf(cl, "\n"
> +"Control forwarding:\n"
> +"---\n\n"
> +
> +"start graph_walk\n"
> +" Start graph_walk on worker threads.\n\n"
> +
> +"stop graph_walk\n"
> +" Stop worker threads from running
> graph_walk.\n\n"
> +
> +"quit\n"
> +"Quit to prompt.\n\n");
> + }
> +
> + if (show_all || !strcmp(res->section, "display")) {
> +
> + cmdline_printf(cl,
> +"\n"
> +"Display:\n"
> +"\n\n"
> +
> +"show node_list\n"
> +" Display the list of supported nodes.\n\n"
> +
> +"show graph_stats\n"
> +" Display the node statistics of graph 
> cluster.\n\n");
> + }
> +
> + if (show_all || !strcmp(res->section, "config")) {
> + cmdline_printf(cl, "\n"
> +"Configuration:\n"
> +"--\n"
> +"set lcore_config
> (port_id0,rxq0,lcore_idX),..."
> +".

Re: [dpdk-dev][PATCH] ethdev: add send queue flow matching item

[Jan Viktorin]

Hi all,

I'd like to test this feature somehow but this patch just implements the API... 
Will there
be some PMD support soon? I could see that mlx5 implements some internal hidden 
RTE Flow
item SC already that matches this behaviour... It would be great to make it 
available
via this TX_QUEUE feature. Any plans for this (Ori)?

Jan

On Thu, 20 Apr 2023 10:59:01 +0530
 wrote:

> From: Kiran Kumar K 
> 
> Adding support for send queue flow matching item.
> This item is valid only for egress rules.
> An example use case would be that application can
> set different vlan insert rules with different PCP values
> based on tx queue number.
> 
> Signed-off-by: Kiran Kumar K 
> ---
>  app/test-pmd/cmdline_flow.c | 28 +++
>  doc/guides/prog_guide/rte_flow.rst  |  7 +
>  doc/guides/rel_notes/release_23_07.rst  | 31 ++---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  4 +++
>  lib/ethdev/rte_flow.c   |  1 +
>  lib/ethdev/rte_flow.h   | 26 +
>  6 files changed, 68 insertions(+), 29 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 58939ec321..a68a6080a8 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -496,6 +496,8 @@ enum index {
>   ITEM_QUOTA_STATE_NAME,
>   ITEM_AGGR_AFFINITY,
>   ITEM_AGGR_AFFINITY_VALUE,
> + ITEM_TX_QUEUE,
> + ITEM_TX_QUEUE_VALUE,
>  
>   /* Validate/create actions. */
>   ACTIONS,
> @@ -1452,6 +1454,7 @@ static const enum index next_item[] = {
>   ITEM_METER,
>   ITEM_QUOTA,
>   ITEM_AGGR_AFFINITY,
> + ITEM_TX_QUEUE,
>   END_SET,
>   ZERO,
>  };
> @@ -1953,6 +1956,12 @@ static const enum index item_aggr_affinity[] = {
>   ZERO,
>  };
>  
> +static const enum index item_tx_queue[] = {
> + ITEM_TX_QUEUE_VALUE,
> + ITEM_NEXT,
> + ZERO,
> +};
> +
>  static const enum index next_action[] = {
>   ACTION_END,
>   ACTION_VOID,
> @@ -6945,6 +6954,22 @@ static const struct token token_list[] = {
>   .args = ARGS(ARGS_ENTRY(struct rte_flow_item_aggr_affinity,
>   affinity)),
>   },
> + [ITEM_TX_QUEUE] = {
> + .name = "tx_queue",
> + .help = "match on the tx queue of send packet",
> + .priv = PRIV_ITEM(TX_QUEUE,
> +   sizeof(struct rte_flow_item_tx_queue)),
> + .next = NEXT(item_tx_queue),
> + .call = parse_vc,
> + },
> + [ITEM_TX_QUEUE_VALUE] = {
> + .name = "tx_queue_value",
> + .help = "tx queue value",
> + .next = NEXT(item_tx_queue, NEXT_ENTRY(COMMON_UNSIGNED),
> +  item_param),
> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_tx_queue,
> + tx_queue)),
> + },
>  };
>  
>  /** Remove and return last entry from argument stack. */
> @@ -11849,6 +11874,9 @@ flow_item_default_mask(const struct rte_flow_item 
> *item)
>   case RTE_FLOW_ITEM_TYPE_AGGR_AFFINITY:
>   mask = &rte_flow_item_aggr_affinity_mask;
>   break;
> + case RTE_FLOW_ITEM_TYPE_TX_QUEUE:
> + mask = &rte_flow_item_tx_queue_mask;
> + break;
>   default:
>   break;
>   }
> diff --git a/doc/guides/prog_guide/rte_flow.rst 
> b/doc/guides/prog_guide/rte_flow.rst
> index 32fc45516a..7154b56330 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -1486,6 +1486,13 @@ This item is meant to use the same structure as `Item: 
> PORT_REPRESENTOR`_.
>  
>  See also `Action: REPRESENTED_PORT`_.
>  
> +Item: ``TX_QUEUE``
> +^^^
> +
> +Matches on the tx queue of send packet .
> +
> +- ``tx_queue``: Tx queue.
> +
>  Item: ``AGGR_AFFINITY``
>  ^^^
>  
> diff --git a/doc/guides/rel_notes/release_23_07.rst 
> b/doc/guides/rel_notes/release_23_07.rst
> index a9b1293689..631cbd2b58 100644
> --- a/doc/guides/rel_notes/release_23_07.rst
> +++ b/doc/guides/rel_notes/release_23_07.rst
> @@ -24,36 +24,9 @@ DPDK Release 23.07
>  New Features
>  
>  
> -.. This section should contain new features added in this release.
> -   Sample format:
> +* **Added flow matching of tx queue.**
>  
> -   * **Add a title in the past tense with a full stop.**
> -
> - Add a short 1-2 sentence description in the past tense.
> - The description should be enough to allow someone scanning
> - the release notes to understand the new feature.
> -
> - If the feature adds a lot of sub-features you can use a bullet list
> - like this:
> -
> - * Added feature foo to do something.
> - * Enhanced feature bar to do something else.
> -
> - Refer to the previous release notes for examples.
> -
> - Suggested order in release notes items:
> - * Core libs (EAL, 

Re: [PATCH] net/dpaa2: set check sum good flags

[Ferruh Yigit]

On 5/10/2023 6:50 AM, Sachin Saxena (OSS) wrote:
> On 5/8/2023 4:27 PM, Tianli Lai wrote:
>> Caution: This is an external email. Please take care when clicking
>> links or opening attachments. When in doubt, report the message using
>> the 'Report this email' button
>>
>>
>> set check sum good flags when dpaa2 hardware set check result.
>>
>> Signed-off-by: Tianli Lai 
> 
> Acked-by: Sachin Saxena 
> 


Fixes: d2ef05d5c13e ("net/dpaa2: optimize Rx/Tx path")
Fixes: 94d31549c380 ("net/dpaa2: support Rx checksum offload in slow
parsing")
Cc: sta...@dpdk.org


Applied to dpdk-next-net/main, thanks.

Re: [RFC PATCH v2 0/3] improve FEC API usage

[Ferruh Yigit]

On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote:
> The documentation for the FEC API is currently incomplete and contains
> inaccuracies in its descriptions of function parameters. 
> Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set()
> is not well-defined. It does not provide information on what should
> be done if only AUTO bit is set or one of the specified FEC modes is 
> not supported. Additionally, the fec_capa parameter in rte_eth_fec_get()
> implies that more than one FEC mode can be obtained, but it is 
> wrong. Furthermore, the behaviour is undefined in 
> rte_eth_fec_set() when the fec_capa parameter is zero.
> 
> To address these issues, a patch series has been created that updates
> the FEC API documentation, renames one of the parameters to improve 
> its clarity and adds a check for zero fec_capability.
> 
> v2:
> * Update documentation for rte_eth_fec_set() to fix review comments.
> * Don't rename the fec_capa parameter of rte_eth_fec_get() but
>   add a proper description instead.
> 
> Denis Pryazhennikov (3):
>   ethdev: update documentation for API to set FEC
>   ethdev: check that at least one FEC mode is specified
>   ethdev: update documentation for API to get FEC
> 

For series,
Acked-by: Ferruh Yigit 


+cc Author and reviewer of original patch, if there is no objection I
can proceed with the set.


@Denis, can you please provide Fixes tags too? If you prefer you can
send a new version with ack and fixes tags.

Re: [PATCH v3] eventdev: avoid non-burst shortcut for variable-size bursts

[Jerin Jacob]

On Thu, May 11, 2023 at 2:00 PM Mattias Rönnblom
 wrote:
>
> Use non-burst event enqueue and dequeue calls from burst enqueue and
> dequeue only when the burst size is compile-time constant (and equal
> to one).
>
> Signed-off-by: Mattias Rönnblom 
>
> ---
>
> v3: Actually include the change v2 claimed to contain.
> v2: Wrap builtin call in __extension__, to avoid compiler warnings if
> application is compiled with -pedantic. (Morten Brørup)
> ---
>  lib/eventdev/rte_eventdev.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index a90e23ac8b..a471caeb6d 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t 
> port_id,
>  * Allow zero cost non burst mode routine invocation if application
>  * requests nb_events as const one
>  */
> -   if (nb_events == 1)
> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)

"Why" part is not clear from the commit message. Is this to avoid
nb_events read if it is built-in const.
If so, check should be following. Right?

if (__extension__((__builtin_constant_p(nb_events)) && nb_events == 1)
|| nb_events  == 1)

At least, It was my original intention in the code.



> return (fp_ops->enqueue)(port, ev);
> else
> return fn(port, ev, nb_events);
> @@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t 
> port_id, struct rte_event ev[],
>  * Allow zero cost non burst mode routine invocation if application
>  * requests nb_events as const one
>  */
> -   if (nb_events == 1)
> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)
> return (fp_ops->dequeue)(port, ev, timeout_ticks);
> else
> return (fp_ops->dequeue_burst)(port, ev, nb_events,
> --
> 2.34.1
>

Re: [PATCH] examples/l3fwd: add hard code to collect empty poll and NIC counters

[Jerin Jacob]

On Thu, May 11, 2023 at 7:02 PM Honnappa Nagarahalli
 wrote:
>
> 
>
> >
> > On Thu, May 11, 2023 at 1:55 PM Feifei Wang 
> > wrote:
> > >
> > > This patch is to collect empty poll of 'rte_eth_rx_burst' functions in
> > > dpdk l3fwd application. Empty poll means Rx burst function receives no
> > > pkts in one loop.
> > >
> > > Furthermore, we also add 'nic_xstats_display' API to show NIC counters.
> > >
> > > Usage:
> > > With this patch, no special settings, just run l3fwd, and when you
> > > stoping l3fwd, thread will print the info above.
> > >
> > > Note:
> > > This patch has just a slight impact on performance and can be ignored.
> How much is the regression?
>
> >
> > IMO, We should not introduce regression as l3fwd kind of uses as reference
> > application.
> > I think, l3fwd should limit to stats exposed by ethdev(i.e directly from 
> > NIC,
> > without performance regression).
> Agree L3fwd is the reference app. Unfortunately, it is not in a state to 
> debug any problems. May be many are just believing the numbers without 
> understanding that there are problems.
> Can we place these stats under a run time flag and reduce the impact further?

I think, example applications, we can have compile time option for new
feature addtions in fastpath or add new forwarding mode in testpmd.

>
> >
> >
> >
> > >
> > > dpdk version:23.03
> > >
> > > Suggested-by: Lijian Zhang 
> > > Signed-off-by: Feifei Wang 
> > > Reviewed-by: Ruifeng Wang 
> > > Reviewed-by: Honnappa Nagarahalli 
> > > ---
> > >  examples/l3fwd/l3fwd.h | 68
> > ++
> > >  examples/l3fwd/l3fwd_lpm.c | 26 +--
> > >  examples/l3fwd/main.c  | 22 
> > >  3 files changed, 114 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index
> > > b55855c932..2b3fca62f3 100644
> > > --- a/examples/l3fwd/l3fwd.h
> > > +++ b/examples/l3fwd/l3fwd.h
> > > @@ -56,6 +56,17 @@
> > >  #define L3FWD_HASH_ENTRIES (1024*1024*1)
> > >  #endif
> > >
> > > +struct lcore_stats {
> > > +uint32_t nb_rx_pkts[16];
> > > +uint32_t num_loop[16];
> > > +uint32_t none_loop[16];
> > > +uint32_t no_full_loop[16];
> > > +float  none_loop_per[16];
> > > +float no_full_loop_per[16];
> > > +} __rte_cache_aligned;
> > > +
> > > +extern struct lcore_stats stats[RTE_MAX_LCORE];
> > > +
> > >  struct parm_cfg {
> > > const char *rule_ipv4_name;
> > > const char *rule_ipv6_name;
> > > @@ -115,6 +126,63 @@ extern struct acl_algorithms acl_alg[];
> > >
> > >  extern uint32_t max_pkt_len;
> > >
> > > +static inline void
> > > +nic_xstats_display(uint32_t port_id)
> > > +{
> > > +struct rte_eth_xstat *xstats;
> > > +int cnt_xstats, idx_xstat;
> > > +struct rte_eth_xstat_name *xstats_names;
> > > +
> > > +printf("## NIC extended statistics for port %-2d\n", 
> > > port_id);
> > > +if (!rte_eth_dev_is_valid_port(port_id)) {
> > > +fprintf(stderr, "Error: Invalid port number %i\n", 
> > > port_id);
> > > +return;
> > > +}
> > > +
> > > +/* Get count */
> > > +cnt_xstats = rte_eth_xstats_get_names(port_id, NULL, 0);
> > > +if (cnt_xstats  < 0) {
> > > +fprintf(stderr, "Error: Cannot get count of xstats\n");
> > > +return;
> > > +}
> > > +
> > > +/* Get id-name lookup table */
> > > +xstats_names = malloc(sizeof(struct rte_eth_xstat_name) * 
> > > cnt_xstats);
> > > +if (xstats_names == NULL) {
> > > +fprintf(stderr, "Cannot allocate memory for xstats 
> > > lookup\n");
> > > +return;
> > > +}
> > > +if (cnt_xstats != rte_eth_xstats_get_names(
> > > +port_id, xstats_names, cnt_xstats)) {
> > > +fprintf(stderr, "Error: Cannot get xstats lookup\n");
> > > +free(xstats_names);
> > > +return;
> > > +}
> > > +
> > > +/* Get stats themselves */
> > > +xstats = malloc(sizeof(struct rte_eth_xstat) * cnt_xstats);
> > > +if (xstats == NULL) {
> > > +fprintf(stderr, "Cannot allocate memory for xstats\n");
> > > +free(xstats_names);
> > > +return;
> > > +}
> > > +if (cnt_xstats != rte_eth_xstats_get(port_id, xstats, 
> > > cnt_xstats)) {
> > > +fprintf(stderr, "Error: Unable to get xstats\n");
> > > +free(xstats_names);
> > > +free(xstats);
> > > +return;
> > > +}
> > > +
> > > +/* Display xstats */
> > > +for (idx_xstat = 0; idx_xstat < cnt_xstats; idx_xstat++) {
> > > +printf("%s: %"PRIu64"\n",
> > > +xstats_names[idx_xstat].name,
> > > +xstats[idx_xstat].value);
> > > +}
> > > +free(xstats_names

Re: [PATCH v4] net/i40e: support enable/disable source pruning

[Matthew Smith]

> On Apr 19, 2023, at 12:24 AM, Ye, MingjinX  wrote:
> 
> VRRP advertisement packets are dropped on i40e PF device because
> when a MAC address is added to a device, packets originating from
> that MAC address are dropped.
> This patch fixes the bug by disabling source pruning by default,
> and adds a PMD specific API to enable/disable source pruning.
> 
> Bugzilla ID: 648
> 
> Signed-off-by: Mingjin Ye 
> ---
> v3: The i40e specific commands are moved to
> drivers/net/i40e/i40e_testpmd.c.
> --
> v4: Modify the commit log.
> ---
> drivers/net/i40e/i40e_ethdev.c  | 43 
> drivers/net/i40e/i40e_ethdev.h  |  1 +
> drivers/net/i40e/i40e_testpmd.c | 88 +
> drivers/net/i40e/rte_pmd_i40e.c | 20 
> drivers/net/i40e/rte_pmd_i40e.h | 17 +++
> drivers/net/i40e/version.map|  1 +
> 6 files changed, 170 insertions(+)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index cb0070f94b..90d8e5a8bc 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -5647,6 +5647,46 @@ i40e_enable_pf_lb(struct i40e_pf *pf)
>hw->aq.asq_last_status);
> }
> 
> +/* i40e_pf_set_source_prune
> + * @pf: pointer to the pf structure
> + * @on: Enable/disable source prune
> + *
> + * set source prune on pf
> + */
> +int
> +i40e_pf_set_source_prune(struct i40e_pf *pf, int on)
> +{
> +   struct i40e_hw *hw = I40E_PF_TO_HW(pf);
> +   struct i40e_vsi_context ctxt;
> +   int ret;
> +
> +   memset(&ctxt, 0, sizeof(ctxt));
> +   ctxt.seid = pf->main_vsi_seid;
> +   ctxt.pf_num = hw->pf_id;
> +   ret = i40e_aq_get_vsi_params(hw, &ctxt, NULL);
> +   if (ret) {
> +   PMD_DRV_LOG(ERR, "cannot get pf vsi config, err %d, aq_err 
> %d",
> +   ret, hw->aq.asq_last_status);
> +   return ret;
> +   }
> +   ctxt.flags = I40E_AQ_VSI_TYPE_PF;
> +   ctxt.info.valid_sections =
> +   rte_cpu_to_le_16(I40E_AQ_VSI_PROP_SWITCH_VALID);
> +   if (on)
> +   ctxt.info.switch_id &=
> +   ~rte_cpu_to_le_16(I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB);
> +   else
> +   ctxt.info.switch_id |=
> +   rte_cpu_to_le_16(I40E_AQ_VSI_SW_ID_FLAG_LOCAL_LB);
> +
> +   ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL);
> +   if (ret)
> +   PMD_DRV_LOG(ERR, "update vsi switch failed, aq_err=%d",
> +   hw->aq.asq_last_status);
> +
> +   return ret;
> +}
> +
> /* Setup a VSI */
> struct i40e_vsi *
> i40e_vsi_setup(struct i40e_pf *pf,
> @@ -5704,6 +5744,9 @@ i40e_vsi_setup(struct i40e_pf *pf,
>}
>}
> 
> +   /* source prune is disabled to support VRRP in default*/
> +   i40e_pf_set_source_prune(pf, 0);
> +
>vsi = rte_zmalloc("i40e_vsi", sizeof(struct i40e_vsi), 0);
>if (!vsi) {
>PMD_DRV_LOG(ERR, "Failed to allocate memory for vsi");
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index 9b806d130e..6f65d5e0ac 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -1430,6 +1430,7 @@ int i40e_pf_calc_configured_queues_num(struct i40e_pf 
> *pf);
> int i40e_pf_reset_rss_reta(struct i40e_pf *pf);
> int i40e_pf_reset_rss_key(struct i40e_pf *pf);
> int i40e_pf_config_rss(struct i40e_pf *pf);
> +int i40e_pf_set_source_prune(struct i40e_pf *pf, int on);
> int i40e_set_rss_key(struct i40e_vsi *vsi, uint8_t *key, uint8_t key_len);
> int i40e_set_rss_lut(struct i40e_vsi *vsi, uint8_t *lut, uint16_t lut_size);
> int i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params);
> diff --git a/drivers/net/i40e/i40e_testpmd.c b/drivers/net/i40e/i40e_testpmd.c
> index 7be9fea5b0..b6ef5d6e42 100644
> --- a/drivers/net/i40e/i40e_testpmd.c
> +++ b/drivers/net/i40e/i40e_testpmd.c
> @@ -2446,6 +2446,84 @@ static cmdline_parse_inst_t cmd_ptype_mapping_update = 
> {
>},
> };
> 
> +/* *** configure source prune for port *** */
> +struct cmd_config_src_prune_result {
> +   cmdline_fixed_string_t port;
> +   cmdline_fixed_string_t keyword;
> +   cmdline_fixed_string_t port_all; /* valid if "allports" argument == 1 
> */
> +   uint16_t port_id;/* valid if "allports" argument == 0 
> */
> +   cmdline_fixed_string_t item;
> +   cmdline_fixed_string_t enable;
> +};
> +
> +static void cmd_config_pf_src_prune_parsed(void *parsed_result,
> +   __rte_unused struct cmdline *cl,
> +   void *allports)
> +{
> +   struct cmd_config_src_prune_result *res = parsed_result;
> +   uint8_t enable;
> +   uint16_t i;
> +
> +   if (!strcmp(res->enable, "on"))
> +   enable = 1;
> +   else
> +   enable = 0;
> +
> +   /* all ports */
> +   if (allports) {
> +   

Re: Hardware timestamps

[Игорь К]

Thank you for the answer.

ср, 12 апр. 2023 г. в 10:05, David Marchand :

> Hello,
>
> On Wed, Apr 12, 2023 at 8:57 AM Игорь К  wrote:
> >
> > I have tried to get hw timestamps of packets on Intel X550T(10G) and
> AQC107(10G).
> > But RTE_ETH_RX_OFFLOAD_TIMESTAMP = 0 in dev_info.rx_offload_capa.
> > Tell me is it possible to get hw timestamps on these NICs with DPDK?
>
> Looking at the doc, and the code, none of those drivers (net/ixgbe,
> net/atlantic) seem to support this feature.
> I'll let the maintainers reply on the feasibility.
>
>
> > Which 10G NICs support this option?
>
> The documentation from the main repository provides a list of per
> driver features:
> https://doc.dpdk.org/guides/nics/overview.html
>
> For an already released DPDK, the link becomes
> https://doc.dpdk.org/guides-/nics/overview.html.
> Like, for example: https://doc.dpdk.org/guides-22.11/nics/overview.html
>
>
> --
> David Marchand
>
>

RE: [PATCH v2] net/ice: fix dcf init rss blocked

[Liao, TingtingX]

> -Original Message-

> From: Kaiwen Deng mailto:kaiwenx.d...@intel.com>>

> Sent: Tuesday, May 9, 2023 9:22 AM

> To: dev@dpdk.org

> Cc: sta...@dpdk.org; Yang, Qiming 
> mailto:qiming.y...@intel.com>>; Zhou, YidingX 
> mailto:yidingx.z...@intel.com>>; Deng, KaiwenX 
> mailto:kaiwenx.d...@intel.com>>; Zhang, Qi Z 
> mailto:qi.z.zh...@intel.com>>

> Subject: [PATCH v2] net/ice: fix dcf init rss blocked

>

> The i variable type is uint8_t which causes a dead loop, changing it to 
> size_t will solve this issue.

>

> Signed-off-by: Kaiwen Deng 
> mailto:kaiwenx.d...@intel.com>>


Tested-by: Tingting Liao 
mailto:tingtingx.l...@intel.com>>

[PATCH 0/2] AES CCM support in CNXK crypto PMD

[Tejasree Kondoj]

This series adds AES CCM support to CNXK crypto PMD
and fixes capabilities in lookaside IPsec mode.

Tejasree Kondoj (2):
  crypto/cnxk: add AES CCM support
  crypto/cnxk: fix IPsec CCM capabilities

 doc/guides/cryptodevs/cnxk.rst|  1 +
 doc/guides/cryptodevs/features/cn10k.ini  |  3 ++
 doc/guides/cryptodevs/features/cn9k.ini   |  3 ++
 drivers/common/cnxk/roc_se.c  |  4 +-
 drivers/common/cnxk/roc_se.h  |  1 +
 .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 34 -
 drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  2 +-
 drivers/crypto/cnxk/cnxk_se.h | 49 ++-
 8 files changed, 80 insertions(+), 17 deletions(-)

-- 
2.25.1

[PATCH 1/2] crypto/cnxk: add AES CCM support

[Tejasree Kondoj]

Adding AES CCM support to lookaside crypto PMD.

Signed-off-by: Tejasree Kondoj 
---
 doc/guides/cryptodevs/cnxk.rst|  1 +
 doc/guides/cryptodevs/features/cn10k.ini  |  3 ++
 doc/guides/cryptodevs/features/cn9k.ini   |  3 ++
 drivers/common/cnxk/roc_se.c  |  4 +-
 drivers/common/cnxk/roc_se.h  |  1 +
 .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 30 
 drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  2 +-
 drivers/crypto/cnxk/cnxk_se.h | 49 ++-
 8 files changed, 78 insertions(+), 15 deletions(-)

diff --git a/doc/guides/cryptodevs/cnxk.rst b/doc/guides/cryptodevs/cnxk.rst
index 3c2e38fefd..2d3ceebcaa 100644
--- a/doc/guides/cryptodevs/cnxk.rst
+++ b/doc/guides/cryptodevs/cnxk.rst
@@ -76,6 +76,7 @@ Hash algorithms:
 AEAD algorithms:
 
 * ``RTE_CRYPTO_AEAD_AES_GCM``
+* ``RTE_CRYPTO_AEAD_AES_CCM``
 * ``RTE_CRYPTO_AEAD_CHACHA20_POLY1305``
 
 Asymmetric Crypto Algorithms
diff --git a/doc/guides/cryptodevs/features/cn10k.ini 
b/doc/guides/cryptodevs/features/cn10k.ini
index 162d1a25ca..bb5827eb82 100644
--- a/doc/guides/cryptodevs/features/cn10k.ini
+++ b/doc/guides/cryptodevs/features/cn10k.ini
@@ -81,6 +81,9 @@ SHAKE_256   = Y
 AES GCM (128) = Y
 AES GCM (192) = Y
 AES GCM (256) = Y
+AES CCM (128) = Y
+AES CCM (192) = Y
+AES CCM (256) = Y
 CHACHA20-POLY1305 = Y
 
 ;
diff --git a/doc/guides/cryptodevs/features/cn9k.ini 
b/doc/guides/cryptodevs/features/cn9k.ini
index bbed4b2e23..bf0e1a98b2 100644
--- a/doc/guides/cryptodevs/features/cn9k.ini
+++ b/doc/guides/cryptodevs/features/cn9k.ini
@@ -82,6 +82,9 @@ SHAKE_256   = Y
 AES GCM (128) = Y
 AES GCM (192) = Y
 AES GCM (256) = Y
+AES CCM (128) = Y
+AES CCM (192) = Y
+AES CCM (256) = Y
 CHACHA20-POLY1305 = Y
 
 ;
diff --git a/drivers/common/cnxk/roc_se.c b/drivers/common/cnxk/roc_se.c
index 5a894013a6..0c0ddaf6c3 100644
--- a/drivers/common/cnxk/roc_se.c
+++ b/drivers/common/cnxk/roc_se.c
@@ -71,6 +71,7 @@ cpt_ciph_type_set(roc_se_cipher_type type, struct roc_se_ctx 
*ctx,
case ROC_SE_AES_CFB:
case ROC_SE_AES_CTR:
case ROC_SE_AES_GCM:
+   case ROC_SE_AES_CCM:
case ROC_SE_AES_DOCSISBPI:
if (unlikely(cpt_ciph_aes_key_validate(key_len) != 0))
return -1;
@@ -520,7 +521,7 @@ roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, 
roc_se_cipher_type type, const ui
zuc_const = zs_ctx->zuc.otk_ctx.zuc_const;
}
 
-   if (type == ROC_SE_AES_GCM)
+   if ((type == ROC_SE_AES_GCM) || (type == ROC_SE_AES_CCM))
se_ctx->template_w4.s.opcode_minor = BIT(5);
 
ret = cpt_ciph_type_set(type, se_ctx, key_len);
@@ -569,6 +570,7 @@ roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, 
roc_se_cipher_type type, const ui
cpt_ciph_aes_key_type_set(fctx, key_len);
break;
case ROC_SE_AES_GCM:
+   case ROC_SE_AES_CCM:
cpt_ciph_aes_key_type_set(fctx, key_len);
break;
case ROC_SE_AES_XTS:
diff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h
index a0c97b26c5..56f510f7a0 100644
--- a/drivers/common/cnxk/roc_se.h
+++ b/drivers/common/cnxk/roc_se.h
@@ -112,6 +112,7 @@ typedef enum {
ROC_SE_AES_GCM = 0x7,
ROC_SE_AES_XTS = 0x8,
ROC_SE_CHACHA20 = 0x9,
+   ROC_SE_AES_CCM = 0xA,
 
/* These are only for software use */
ROC_SE_ZUC_EEA3 = 0x90,
diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c 
b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
index 19956ffa07..91483ab693 100644
--- a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
+++ b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
@@ -782,6 +782,36 @@ static const struct rte_cryptodev_capabilities caps_aes[] 
= {
}, }
}, }
},
+   {   /* AES CCM */
+   .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+   {.sym = {
+   .xform_type = RTE_CRYPTO_SYM_XFORM_AEAD,
+   {.aead = {
+   .algo = RTE_CRYPTO_AEAD_AES_CCM,
+   .block_size = 16,
+   .key_size = {
+   .min = 16,
+   .max = 32,
+   .increment = 8
+   },
+   .digest_size = {
+   .min = 4,
+   .max = 16,
+   .increment = 1
+   },
+   .aad_size = {
+   .min = 0,
+   .max = 1024,
+   .increment = 1
+   },
+   

[PATCH 2/2] crypto/cnxk: fix IPsec CCM capabilities

[Tejasree Kondoj]

Fixing lookaside IPsec AES-CCM capabilities.

Fixes: 246dea7e6efb ("crypto/cnxk: support AES-CCM")
Cc: sta...@dpdk.org

Signed-off-by: Tejasree Kondoj 
---
 drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c 
b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
index 91483ab693..c35e5f341d 100644
--- a/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
+++ b/drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c
@@ -1084,8 +1084,8 @@ static const struct rte_cryptodev_capabilities 
sec_caps_aes[] = {
.increment = 4
},
.iv_size = {
-   .min = 12,
-   .max = 12,
+   .min = 11,
+   .max = 11,
.increment = 0
}
}, }
-- 
2.25.1

[PATCH] test/crypto: fix IPsec AES CCM test vector

[Tejasree Kondoj]

Fixing IPsec AES-CCM test vector IV length.

Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
Cc: sta...@dpdk.org

Signed-off-by: Tejasree Kondoj 
---
 app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h 
b/app/test/test_cryptodev_security_ipsec_test_vectors.h
index 2686bbeb62..462cef6785 100644
--- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
+++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
@@ -417,7 +417,7 @@ struct ipsec_test_data pkt_aes_256_ccm = {
.op = RTE_CRYPTO_AEAD_OP_ENCRYPT,
.algo = RTE_CRYPTO_AEAD_AES_CCM,
.key.length = 32,
-   .iv.length = 12,
+   .iv.length = 11,
.iv.offset = IV_OFFSET,
.digest_length = 16,
.aad_length = 12,
-- 
2.25.1

Re: [PATCH v3] eventdev: avoid non-burst shortcut for variable-size bursts

[Mattias Rönnblom]

On 2023-05-12 13:59, Jerin Jacob wrote:
> On Thu, May 11, 2023 at 2:00 PM Mattias Rönnblom
>  wrote:
>>
>> Use non-burst event enqueue and dequeue calls from burst enqueue and
>> dequeue only when the burst size is compile-time constant (and equal
>> to one).
>>
>> Signed-off-by: Mattias Rönnblom 
>>
>> ---
>>
>> v3: Actually include the change v2 claimed to contain.
>> v2: Wrap builtin call in __extension__, to avoid compiler warnings if
>>  application is compiled with -pedantic. (Morten Brørup)
>> ---
>>   lib/eventdev/rte_eventdev.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
>> index a90e23ac8b..a471caeb6d 100644
>> --- a/lib/eventdev/rte_eventdev.h
>> +++ b/lib/eventdev/rte_eventdev.h
>> @@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t 
>> port_id,
>>   * Allow zero cost non burst mode routine invocation if application
>>   * requests nb_events as const one
>>   */
>> -   if (nb_events == 1)
>> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)
> 
> "Why" part is not clear from the commit message. Is this to avoid
> nb_events read if it is built-in const.

The __builtin_constant_p() is introduced to avoid having the compiler 
generate a conditional branch and two different code paths in case 
nb_elem is a run-time variable.

In particular, this matters if nb_elems is run-time variable and varies 
between 1 and some larger value.

I should have mention this in the commit message.

A very slight performance improvement. It also makes the code better 
match the comment, imo. Zero cost for const one enqueues, but no impact 
non-compile-time-constant-length enqueues.

Feel free to ignore.

> If so, check should be following. Right?
> 
> if (__extension__((__builtin_constant_p(nb_events)) && nb_events == 1)
> || nb_events  == 1)
> 
> At least, It was my original intention in the code.
> 
> 
> 
>>  return (fp_ops->enqueue)(port, ev);
>>  else
>>  return fn(port, ev, nb_events);
>> @@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t 
>> port_id, struct rte_event ev[],
>>   * Allow zero cost non burst mode routine invocation if application
>>   * requests nb_events as const one
>>   */
>> -   if (nb_events == 1)
>> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events == 1)
>>  return (fp_ops->dequeue)(port, ev, timeout_ticks);
>>  else
>>  return (fp_ops->dequeue_burst)(port, ev, nb_events,
>> --
>> 2.34.1
>>

RE: [PATCH v3] eventdev: avoid non-burst shortcut for variable-size bursts

[Morten Brørup]

> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Friday, 12 May 2023 15.15
> 
> On 2023-05-12 13:59, Jerin Jacob wrote:
> > On Thu, May 11, 2023 at 2:00 PM Mattias Rönnblom
> >  wrote:
> >>
> >> Use non-burst event enqueue and dequeue calls from burst enqueue and
> >> dequeue only when the burst size is compile-time constant (and equal
> >> to one).
> >>
> >> Signed-off-by: Mattias Rönnblom 
> >>
> >> ---
> >>
> >> v3: Actually include the change v2 claimed to contain.
> >> v2: Wrap builtin call in __extension__, to avoid compiler warnings if
> >>  application is compiled with -pedantic. (Morten Brørup)
> >> ---
> >>   lib/eventdev/rte_eventdev.h | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> >> index a90e23ac8b..a471caeb6d 100644
> >> --- a/lib/eventdev/rte_eventdev.h
> >> +++ b/lib/eventdev/rte_eventdev.h
> >> @@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t
> port_id,
> >>   * Allow zero cost non burst mode routine invocation if
> application
> >>   * requests nb_events as const one
> >>   */
> >> -   if (nb_events == 1)
> >> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events ==
> 1)
> >
> > "Why" part is not clear from the commit message. Is this to avoid
> > nb_events read if it is built-in const.
> 
> The __builtin_constant_p() is introduced to avoid having the compiler
> generate a conditional branch and two different code paths in case
> nb_elem is a run-time variable.
> 
> In particular, this matters if nb_elems is run-time variable and varies
> between 1 and some larger value.
> 
> I should have mention this in the commit message.
> 
> A very slight performance improvement. It also makes the code better
> match the comment, imo. Zero cost for const one enqueues, but no impact
> non-compile-time-constant-length enqueues.
> 
> Feel free to ignore.
> 
> > If so, check should be following. Right?
> >
> > if (__extension__((__builtin_constant_p(nb_events)) && nb_events == 1)
> > || nb_events  == 1)

@Mattias: You missed the second part of this comparison, also catching 
nb_events == 1 with non-constant nb_events.

@Jerin: Such a change has no effect, compared to the original code.

> >
> > At least, It was my original intention in the code.

@Jerin: Mattias implemented exactly what the comment says.

Perhaps only the comment should be updated, not the code.

Is nb_events likely to be non-constant 1, and are there benefits to calling 
either of the non-burst functions in those cases, vs. the branch cost of this 
comparison (which Mattias' patch gets rid of)?

> >
> >
> >
> >>  return (fp_ops->enqueue)(port, ev);
> >>  else
> >>  return fn(port, ev, nb_events);
> >> @@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t
> port_id, struct rte_event ev[],
> >>   * Allow zero cost non burst mode routine invocation if
> application
> >>   * requests nb_events as const one
> >>   */
> >> -   if (nb_events == 1)
> >> +   if (__extension__(__builtin_constant_p(nb_events)) && nb_events ==
> 1)
> >>  return (fp_ops->dequeue)(port, ev, timeout_ticks);
> >>  else
> >>  return (fp_ops->dequeue_burst)(port, ev, nb_events,
> >> --
> >> 2.34.1
> >>

RE: [PATCH] test/crypto: fix IPsec AES CCM test vector

[Anoob Joseph]

> 
> Fixing IPsec AES-CCM test vector IV length.
> 
> Fixes: d314299950de ("test/crypto: add AES-CCM vectors")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Tejasree Kondoj 
> ---
>  app/test/test_cryptodev_security_ipsec_test_vectors.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Anoob Joseph 

[PATCH 2/2] test/crypto: handle return code

[Anoob Joseph]

The sub test case, test_snow3g_decryption, may fail for non-critical
reasons such as lack of support. Handle the return value gracefully to
allow TEST_SKIPPED return value to be propagated correctly.

Signed-off-by: Anoob Joseph 
---
 app/test/test_cryptodev.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 86e63a33fc..d212e71ba6 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -6947,6 +6947,7 @@ test_snow3g_decryption_with_digest_test_case_1(void)
struct snow3g_hash_test_data snow3g_hash_data;
struct rte_cryptodev_info dev_info;
struct crypto_testsuite_params *ts_params = &testsuite_params;
+   int ret;
 
rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
uint64_t feat_flags = dev_info.feature_flags;
@@ -6962,8 +6963,9 @@ test_snow3g_decryption_with_digest_test_case_1(void)
 */
snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data);
 
-   if (test_snow3g_decryption(&snow3g_test_case_7))
-   return TEST_FAILED;
+   ret = test_snow3g_decryption(&snow3g_test_case_7);
+   if (ret != TEST_SUCCESS)
+   return ret;
 
return test_snow3g_authentication_verify(&snow3g_hash_data);
 }
-- 
2.25.1

[PATCH 1/2] test/crypto: free memory in error and skip paths

[Anoob Joseph]

In multi session tests, multiple sessions get created. So the handling
in ut_teardown won't guard against any memory that is not freed by the
test case. Test case should free sessions as well as local memory that
was used to save session pointers both in case of unsupported cases as
well as operation failures.

Signed-off-by: Anoob Joseph 
---
 app/test/test_cryptodev.c | 55 +++
 1 file changed, 39 insertions(+), 16 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index fb4fc4e805..86e63a33fc 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -12751,8 +12751,8 @@ test_multi_session(void)
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct crypto_unittest_params *ut_params = &unittest_params;
struct rte_cryptodev_info dev_info;
+   int i, nb_sess, ret = TEST_SUCCESS;
void **sessions;
-   uint16_t i;
 
/* Verify the capabilities */
struct rte_cryptodev_sym_capability_idx cap_idx;
@@ -12782,21 +12782,25 @@ test_multi_session(void)
sessions[i] = rte_cryptodev_sym_session_create(
ts_params->valid_devs[0], &ut_params->auth_xform,
ts_params->session_mpool);
-   if (sessions[i] == NULL && rte_errno == ENOTSUP)
-   return TEST_SKIPPED;
+   if (sessions[i] == NULL && rte_errno == ENOTSUP) {
+   nb_sess = i;
+   ret = TEST_SKIPPED;
+   break;
+   }
 
TEST_ASSERT_NOT_NULL(sessions[i],
"Session creation failed at session number %u",
i);
+
/* Attempt to send a request on each session */
-   TEST_ASSERT_SUCCESS( test_AES_CBC_HMAC_SHA512_decrypt_perform(
+   ret = test_AES_CBC_HMAC_SHA512_decrypt_perform(
sessions[i],
ut_params,
ts_params,
catch_22_quote_2_512_bytes_AES_CBC_ciphertext,
catch_22_quote_2_512_bytes_AES_CBC_HMAC_SHA512_digest,
-   aes_cbc_iv),
-   "Failed to perform decrypt on request number %u.", i);
+   aes_cbc_iv);
+
/* free crypto operation structure */
rte_crypto_op_free(ut_params->op);
 
@@ -12815,16 +12819,25 @@ test_multi_session(void)
rte_pktmbuf_free(ut_params->ibuf);
ut_params->ibuf = 0;
}
+
+   if (ret == TEST_SKIPPED) {
+   i++;
+   break;
+   }
+
+   TEST_ASSERT_SUCCESS(ret, "Failed to perform decrypt on request 
number %u.", i);
}
 
-   for (i = 0; i < MAX_NB_SESSIONS; i++) {
+   nb_sess = i;
+
+   for (i = 0; i < nb_sess; i++) {
rte_cryptodev_sym_session_free(ts_params->valid_devs[0],
sessions[i]);
}
 
rte_free(sessions);
 
-   return TEST_SUCCESS;
+   return ret;
 }
 
 struct multi_session_params {
@@ -12843,8 +12856,9 @@ test_multi_session_random_usage(void)
 {
struct crypto_testsuite_params *ts_params = &testsuite_params;
struct rte_cryptodev_info dev_info;
+   uint32_t nb_sess, i, j;
+   int ret = TEST_SUCCESS;
void **sessions;
-   uint32_t i, j;
struct multi_session_params ut_paramz[] = {
 
{
@@ -12903,27 +12917,30 @@ test_multi_session_random_usage(void)
ts_params->valid_devs[0],
&ut_paramz[i].ut_params.auth_xform,
ts_params->session_mpool);
-   if (sessions[i] == NULL && rte_errno == ENOTSUP)
-   return TEST_SKIPPED;
+   if (sessions[i] == NULL && rte_errno == ENOTSUP) {
+   nb_sess = i;
+   ret = TEST_SKIPPED;
+   goto session_clear;
+   }
 
TEST_ASSERT_NOT_NULL(sessions[i],
"Session creation failed at session number %u",
i);
}
 
+   nb_sess = i;
+
srand(time(NULL));
for (i = 0; i < 4; i++) {
 
j = rand() % MB_SESSION_NUMBER;
 
-   TEST_ASSERT_SUCCESS(
-   test_AES_CBC_HMAC_SHA512_decrypt_perform(
+   ret = test_AES_CBC_HMAC_SHA512_decrypt_perform(
sessions[j],
&ut_paramz[j].ut_params,
ts_params, ut_paramz[j].cipher,
ut_paramz[j].digest,
-   ut_paramz[j].iv),

[PATCH] test/crypto: remove redundant code

[Anoob Joseph]

Code for registering raw API tests for various PMDs are repeated.
Add common routine to avoid duplication of code.

Signed-off-by: Anoob Joseph 
---
 app/test/test_cryptodev.c | 40 ++-
 1 file changed, 10 insertions(+), 30 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d212e71ba6..f44e8b3101 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -17462,13 +17462,11 @@ test_cryptodev_bcmfs(void)
 }
 
 static int
-test_cryptodev_qat_raw_api(void)
+run_cryptodev_raw_testsuite(const char *pmd_name)
 {
-   static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD);
int ret;
 
-   ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP,
-   "RAW API");
+   ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP, "RAW 
API");
if (ret)
return ret;
 
@@ -17479,6 +17477,12 @@ test_cryptodev_qat_raw_api(void)
return ret;
 }
 
+static int
+test_cryptodev_qat_raw_api(void)
+{
+   return run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD));
+}
+
 static int
 test_cryptodev_cn9k(void)
 {
@@ -17494,37 +17498,13 @@ test_cryptodev_cn10k(void)
 static int
 test_cryptodev_dpaa2_sec_raw_api(void)
 {
-   static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD);
-   int ret;
-
-   ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP,
-   "RAW API");
-   if (ret)
-   return ret;
-
-   global_api_test_type = CRYPTODEV_RAW_API_TEST;
-   ret = run_cryptodev_testsuite(pmd_name);
-   global_api_test_type = CRYPTODEV_API_TEST;
-
-   return ret;
+   return 
run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA2_SEC_PMD));
 }
 
 static int
 test_cryptodev_dpaa_sec_raw_api(void)
 {
-   static const char *pmd_name = RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD);
-   int ret;
-
-   ret = require_feature_flag(pmd_name, RTE_CRYPTODEV_FF_SYM_RAW_DP,
-   "RAW API");
-   if (ret)
-   return ret;
-
-   global_api_test_type = CRYPTODEV_RAW_API_TEST;
-   ret = run_cryptodev_testsuite(pmd_name);
-   global_api_test_type = CRYPTODEV_API_TEST;
-
-   return ret;
+   return 
run_cryptodev_raw_testsuite(RTE_STR(CRYPTODEV_NAME_DPAA_SEC_PMD));
 }
 
 REGISTER_TEST_COMMAND(cryptodev_dpaa2_sec_raw_api_autotest,
-- 
2.25.1

[PATCH v3] eal: add tracepoints to track lcores and services

[Arnaud Fiorini]

The tracepoints added are used to track lcore role and status,
as well as service mapping and service runstates. These
tracepoints are then used in analyses in Trace Compass.

Signed-off-by: Arnaud Fiorini 
---
 .mailmap |  1 +
 doc/guides/prog_guide/service_cores.rst  | 14 ++
 lib/eal/common/eal_common_thread.c   |  4 ++
 lib/eal/common/eal_common_trace_points.c | 21 +
 lib/eal/common/rte_service.c | 17 ++-
 lib/eal/include/eal_trace_internal.h | 60 
 6 files changed, 116 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 0859104404..6453cb2aa5 100644
--- a/.mailmap
+++ b/.mailmap
@@ -120,6 +120,7 @@ Archana Muniganti  

 Archit Pandey 
 Arkadiusz Kubalewski 
 Arkadiusz Kusztal 
+Arnaud Fiorini 
 Arnon Warshavsky 
 Arshdeep Kaur 
 Artem V. Andreev 
diff --git a/doc/guides/prog_guide/service_cores.rst 
b/doc/guides/prog_guide/service_cores.rst
index 270b875783..3b9a947e4c 100644
--- a/doc/guides/prog_guide/service_cores.rst
+++ b/doc/guides/prog_guide/service_cores.rst
@@ -52,3 +52,17 @@ The service core library is capable of collecting runtime 
statistics like number
 of calls to a specific service, and number of cycles used by the service. The
 cycle count collection is dynamically configurable, allowing any application to
 profile the services running on the system at any time.
+
+Service Core Tracing
+
+
+The service core library is instrumented with tracepoints using the DPDK Trace
+Library. These tracepoints allow you to track the service and logical cores
+state. To activate tracing when launching a DPDK program it is necessary to 
use the
+``--trace`` option to specify a regular expression to select which tracepoints
+to enable. Here is an example if you want to only specify service core 
tracing::
+
+./dpdk/examples/service_cores/build/service_cores 
--trace="lib.eal.thread*" --trace="lib.eal.service*"
+
+See the `DPDK Trace Library 
`_
+for details.
diff --git a/lib/eal/common/eal_common_thread.c 
b/lib/eal/common/eal_common_thread.c
index 079a385630..25dbdd68e3 100644
--- a/lib/eal/common/eal_common_thread.c
+++ b/lib/eal/common/eal_common_thread.c
@@ -205,6 +205,8 @@ eal_thread_loop(void *arg)
__ATOMIC_ACQUIRE)) == NULL)
rte_pause();
 
+   rte_eal_trace_thread_lcore_running(lcore_id, f);
+
/* call the function and store the return value */
fct_arg = lcore_config[lcore_id].arg;
ret = f(fct_arg);
@@ -219,6 +221,8 @@ eal_thread_loop(void *arg)
 */
__atomic_store_n(&lcore_config[lcore_id].state, WAIT,
__ATOMIC_RELEASE);
+
+   rte_eal_trace_thread_lcore_stopped(lcore_id);
}
 
/* never reached */
diff --git a/lib/eal/common/eal_common_trace_points.c 
b/lib/eal/common/eal_common_trace_points.c
index 3f5bf5c55c..0f1240ea3a 100644
--- a/lib/eal/common/eal_common_trace_points.c
+++ b/lib/eal/common/eal_common_trace_points.c
@@ -70,6 +70,27 @@ RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_remote_launch,
lib.eal.thread.remote.launch)
 RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_ready,
lib.eal.thread.lcore.ready)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_running,
+   lib.eal.thread.lcore.running)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_thread_lcore_stopped,
+   lib.eal.thread.lcore.stopped)
+
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_map_lcore,
+   lib.eal.service.map.lcore)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_state_change,
+   lib.eal.service.lcore.state.change)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_start,
+   lib.eal.service.lcore.start)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_lcore_stop,
+   lib.eal.service.lcore.stop)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_run_begin,
+   lib.eal.service.run.begin)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_runstate_set,
+   lib.eal.service.run.state.set)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_run_end,
+   lib.eal.service.run.end)
+RTE_TRACE_POINT_REGISTER(rte_eal_trace_service_component_register,
+   lib.eal.service.component.register)
 
 RTE_TRACE_POINT_REGISTER(rte_eal_trace_intr_callback_register,
lib.eal.intr.register)
diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c
index 7ab48f2be8..94e872a08a 100644
--- a/lib/eal/common/rte_service.c
+++ b/lib/eal/common/rte_service.c
@@ -9,6 +9,7 @@
 #include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
@@ -16,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "eal_private.h"
 
@@ -276,6 +278,8 @@ rte_service_component_register(const struct 
rte_service_spec *spec,
if (id_ptr)
*id_ptr = free_slot;
 
+   rte_eal_trace

Re: [PATCH 00/13] Sync the kernel driver logic

[Ferruh Yigit]

On 4/10/2023 12:00 PM, Chaoyong He wrote:
> The DPDK NFP PMD share the same underlying data structure and API with
> the NFP kernel driver, because they use the same firmware.
> 
> The DPDK NFP PMD only has a very initial version and not changed for a
> long time, but the NFP kernel driver keeps evolve at the same time, so
> the differece between them are keeping expand.
> 
> This patch series try to sync the needed logics to narrow the gap.
> 
> Chaoyong He (13):
>   net/nfp: define correct size for configuration BAR
>   net/nfp: move shared target logic to own source file
>   net/nfp: remove the redundant macro about CPP target
>   net/nfp: drop usage of return error helpers
>   net/nfp: use generic macros for array size and to set bits
>   net/nfp: remove dead code related to CPP
>   net/nfp: remove duplicated nffw defines
>   net/nfp: move NFD3 logic to own source file
>   net/nfp: adjust the coding style for NFD3
>   net/nfp: rename macro name of NFD3 Tx descriptor
>   net/nfp: move NFDk logic to own source file
>   net/nfp: adjust the coding style for NFDk
>   net/nfp: modify the logic of some NFDk function


Series applied to dpdk-next-net/main, thanks.

Re: [PATCH v3] eventdev: avoid non-burst shortcut for variable-size bursts

[Mattias Rönnblom]

On 2023-05-12 15:56, Morten Brørup wrote:

From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
Sent: Friday, 12 May 2023 15.15

On 2023-05-12 13:59, Jerin Jacob wrote:

On Thu, May 11, 2023 at 2:00 PM Mattias Rönnblom
 wrote:


Use non-burst event enqueue and dequeue calls from burst enqueue and
dequeue only when the burst size is compile-time constant (and equal
to one).

Signed-off-by: Mattias Rönnblom 

---

v3: Actually include the change v2 claimed to contain.
v2: Wrap builtin call in __extension__, to avoid compiler warnings if
  application is compiled with -pedantic. (Morten Brørup)
---
   lib/eventdev/rte_eventdev.h | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index a90e23ac8b..a471caeb6d 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t

port_id,

   * Allow zero cost non burst mode routine invocation if

application

   * requests nb_events as const one
   */
-   if (nb_events == 1)
+   if (__extension__(__builtin_constant_p(nb_events)) && nb_events ==

1)


"Why" part is not clear from the commit message. Is this to avoid
nb_events read if it is built-in const.


The __builtin_constant_p() is introduced to avoid having the compiler
generate a conditional branch and two different code paths in case
nb_elem is a run-time variable.

In particular, this matters if nb_elems is run-time variable and varies
between 1 and some larger value.

I should have mention this in the commit message.

A very slight performance improvement. It also makes the code better
match the comment, imo. Zero cost for const one enqueues, but no impact
non-compile-time-constant-length enqueues.

Feel free to ignore.


If so, check should be following. Right?

if (__extension__((__builtin_constant_p(nb_events)) && nb_events == 1)
|| nb_events  == 1)


@Mattias: You missed the second part of this comparison, also catching 
nb_events == 1 with non-constant nb_events.



I didn't comment on that code snippet since it was based on a 
misconception of the intention of my patch.



@Jerin: Such a change has no effect, compared to the original code.



At least, It was my original intention in the code.


@Jerin: Mattias implemented exactly what the comment says.

Perhaps only the comment should be updated, not the code.

Is nb_events likely to be non-constant 1, and are there benefits to calling 
either of the non-burst functions in those cases, vs. the branch cost of this 
comparison (which Mattias' patch gets rid of)?



I think the main worry would be the cost of branch mispredictions in
case of alternating enqueue sizes (between 1 and some other size).

If there is a performance upside to calling single-event enqueue in a 
scenario where all enqueues are *run-time variable* and 1 (which I find 
unlikely, but well inside the realms of the possibility), the next 
question would be: OK, but how about for two events? Three? Four. Etc.







  return (fp_ops->enqueue)(port, ev);
  else
  return fn(port, ev, nb_events);
@@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t

port_id, struct rte_event ev[],

   * Allow zero cost non burst mode routine invocation if

application

   * requests nb_events as const one
   */
-   if (nb_events == 1)
+   if (__extension__(__builtin_constant_p(nb_events)) && nb_events ==

1)

  return (fp_ops->dequeue)(port, ev, timeout_ticks);
  else
  return (fp_ops->dequeue_burst)(port, ev, nb_events,
--
2.34.1

[RFC v2 0/2] add DTS smoke tests

[jspewock]

From: Jeremy Spewock 

This update to the RFC adds a few more things such as physical devices
and virtual devices to the config, driver checks in the smoke tests, and 
interactive shell
handling.

Interactive shells are handled by creating two SSH connections upon
connecting to the SUT, one which is for normal non-interactive
opertaions and another (using paramiko) that is reserved for interactive 
shells. This
interactive session is stored in the main session of the SUT and can be
piloted using the interactive handler. This handler creates a new
channel off the session and provides methods for sending commands both
blindly and by expecting output. Then, classes are made for individual
DPDK applications that use one of these interactive handlers and know
how to handle that applications specific behaviors and outputs.

Old RFC:
* 
http://patches.dpdk.org/project/dpdk/patch/20230413175415.7683-3-jspew...@iol.unh.edu/

Jeremy Spewock (1):
  dts: added paramiko to dependencies

Jeremy Spewock (1):
  dts: add smoke tests

 dts/conf.yaml |   9 +
 dts/framework/config/__init__.py  |  21 +++
 dts/framework/config/conf_yaml_schema.json|  32 +++-
 dts/framework/dts.py  |  19 ++-
 dts/framework/exception.py|  11 ++
 dts/framework/remote_session/os_session.py|   6 +-
 .../remote_session/remote/__init__.py |  28 +++
 dts/framework/test_result.py  |  13 +-
 dts/framework/test_suite.py   |  24 ++-
 dts/framework/testbed_model/__init__.py   |   5 +
 .../interactive_apps/__init__.py  |   6 +
 .../interactive_apps/interactive_command.py   |  57 +++
 .../interactive_apps/testpmd_driver.py|  24 +++
 dts/framework/testbed_model/node.py   |   2 +
 dts/framework/testbed_model/sut_node.py   |   6 +
 dts/poetry.lock   | 160 ++
 dts/pyproject.toml|   1 +
 dts/tests/TestSuite_smoke_tests.py|  94 ++
 18 files changed, 472 insertions(+), 46 deletions(-)
 create mode 100644 dts/framework/testbed_model/interactive_apps/__init__.py
 create mode 100644 
dts/framework/testbed_model/interactive_apps/interactive_command.py
 create mode 100644 
dts/framework/testbed_model/interactive_apps/testpmd_driver.py
 create mode 100644 dts/tests/TestSuite_smoke_tests.py

-- 
2.40.1

[RFC v2 1/2] dts: add smoke tests

[jspewock]

From: Jeremy Spewock 

Adds a new test suite for running smoke tests that verify general
configuration aspects of the system under test. If any of these tests
fail, the DTS execution terminates as part of a "fail-fast" model.

Signed-off-by: Jeremy Spewock 
---
 dts/conf.yaml |  9 ++
 dts/framework/config/__init__.py  | 21 +
 dts/framework/config/conf_yaml_schema.json| 32 ++-
 dts/framework/dts.py  | 19 +++-
 dts/framework/exception.py| 11 +++
 dts/framework/remote_session/os_session.py|  6 +-
 .../remote_session/remote/__init__.py | 28 ++
 dts/framework/test_result.py  | 13 ++-
 dts/framework/test_suite.py   | 24 -
 dts/framework/testbed_model/__init__.py   |  5 +
 .../interactive_apps/__init__.py  |  6 ++
 .../interactive_apps/interactive_command.py   | 57 +++
 .../interactive_apps/testpmd_driver.py| 24 +
 dts/framework/testbed_model/node.py   |  2 +
 dts/framework/testbed_model/sut_node.py   |  6 ++
 dts/tests/TestSuite_smoke_tests.py| 94 +++
 16 files changed, 348 insertions(+), 9 deletions(-)
 create mode 100644 dts/framework/testbed_model/interactive_apps/__init__.py
 create mode 100644 
dts/framework/testbed_model/interactive_apps/interactive_command.py
 create mode 100644 
dts/framework/testbed_model/interactive_apps/testpmd_driver.py
 create mode 100644 dts/tests/TestSuite_smoke_tests.py

diff --git a/dts/conf.yaml b/dts/conf.yaml
index a9bd8a3e..042ef954 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -10,13 +10,22 @@ executions:
 compiler_wrapper: ccache
 perf: false
 func: true
+nics: #physical devices to be used for testing
+  - addresses:
+  - ":11:00.0"
+  - ":11:00.1"
+driver: "i40e"
+vdevs: #names of virtual devices to be used for testing
+  - "crypto_openssl"
 test_suites:
+  - smoke_tests
   - hello_world
 system_under_test: "SUT 1"
 nodes:
   - name: "SUT 1"
 hostname: sut1.change.me.localhost
 user: root
+password: ""
 arch: x86_64
 os: linux
 lcores: ""
diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py
index ebb0823f..f3b8b6e3 100644
--- a/dts/framework/config/__init__.py
+++ b/dts/framework/config/__init__.py
@@ -106,6 +106,21 @@ def from_dict(d: dict) -> "NodeConfiguration":
 hugepages=hugepage_config,
 )
 
+@dataclass(slots=True, frozen=True)
+class NICConfiguration:
+addresses: list[str]
+driver: str
+
+@staticmethod
+def from_dict(d:dict) -> "NICConfiguration":
+return NICConfiguration(
+addresses=[addr for addr in d.get("addresses", [])],
+driver=d.get("driver")
+)
+@staticmethod
+def from_list(l:list[dict]) -> list["NICConfiguration"]:
+return [] + [NICConfiguration.from_dict(x) for x in l]
+
 
 @dataclass(slots=True, frozen=True)
 class BuildTargetConfiguration:
@@ -157,6 +172,8 @@ class ExecutionConfiguration:
 func: bool
 test_suites: list[TestSuiteConfig]
 system_under_test: NodeConfiguration
+nics: list[NICConfiguration]
+vdevs: list[str]
 
 @staticmethod
 def from_dict(d: dict, node_map: dict) -> "ExecutionConfiguration":
@@ -166,7 +183,9 @@ def from_dict(d: dict, node_map: dict) -> 
"ExecutionConfiguration":
 test_suites: list[TestSuiteConfig] = list(
 map(TestSuiteConfig.from_dict, d["test_suites"])
 )
+nic_conf: NICConfiguration = NICConfiguration.from_list(d['nics'])
 sut_name = d["system_under_test"]
+list_of_vdevs = d["vdevs"]
 assert sut_name in node_map, f"Unknown SUT {sut_name} in execution {d}"
 
 return ExecutionConfiguration(
@@ -174,7 +193,9 @@ def from_dict(d: dict, node_map: dict) -> 
"ExecutionConfiguration":
 perf=d["perf"],
 func=d["func"],
 test_suites=test_suites,
+nics=nic_conf,
 system_under_test=node_map[sut_name],
+vdevs=list_of_vdevs
 )
 
 
diff --git a/dts/framework/config/conf_yaml_schema.json 
b/dts/framework/config/conf_yaml_schema.json
index ca2d4a1e..603859de 100644
--- a/dts/framework/config/conf_yaml_schema.json
+++ b/dts/framework/config/conf_yaml_schema.json
@@ -40,6 +40,18 @@
 "mscv"
   ]
 },
+"single_nic" : {
+  "type":"object",
+  "description": "an object that holds nic information",
+  "properties": {
+"addresses": {
+  "type":"array",
+  "items": {
+"type":"string"
+  }
+}
+  }
+},
 "build_target": {
   "type": "object",
   "description": "Targets supported by DTS",
@@ -97,7 +109,8 @@
 "test_suite": {
   "type": "string",
   "enum": [
-"hello_world"
+"hello_world",
+"smoke_

[RFC v2 2/2] dts: added paramiko to dependencies

[jspewock]

From: Jeremy Spewock 

added paramiko to the dependency files

Signed-off-by: Jeremy Spewock 
---
 dts/poetry.lock| 160 ++---
 dts/pyproject.toml |   1 +
 2 files changed, 124 insertions(+), 37 deletions(-)

diff --git a/dts/poetry.lock b/dts/poetry.lock
index 0b2a007d..d5b41550 100644
--- a/dts/poetry.lock
+++ b/dts/poetry.lock
@@ -1,20 +1,33 @@
 [[package]]
 name = "attrs"
-version = "22.1.0"
+version = "23.1.0"
 description = "Classes Without Boilerplate"
 category = "main"
 optional = false
-python-versions = ">=3.5"
+python-versions = ">=3.7"
 
 [package.extras]
-dev = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "zope.interface", 
"furo", "sphinx", "sphinx-notfound-page", "pre-commit", "cloudpickle"]
-docs = ["furo", "sphinx", "zope.interface", "sphinx-notfound-page"]
-tests = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "zope.interface", 
"cloudpickle"]
-tests_no_zope = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "cloudpickle"]
+cov = ["attrs", "coverage[toml] (>=5.3)"]
+dev = ["attrs", "pre-commit"]
+docs = ["furo", "myst-parser", "sphinx", "sphinx-notfound-page", 
"sphinxcontrib-towncrier", "towncrier", "zope-interface"]
+tests = ["attrs", "zope-interface"]
+tests-no-zope = ["cloudpickle", "hypothesis", "mypy (>=1.1.1)", "pympler", 
"pytest-mypy-plugins", "pytest-xdist", "pytest (>=4.3.0)"]
+
+[[package]]
+name = "bcrypt"
+version = "4.0.1"
+description = "Modern password hashing for your software and your servers"
+category = "main"
+optional = false
+python-versions = ">=3.6"
+
+[package.extras]
+tests = ["pytest (>=3.2.1,!=3.3.0)"]
+typecheck = ["mypy"]
 
 [[package]]
 name = "black"
-version = "22.10.0"
+version = "22.12.0"
 description = "The uncompromising code formatter."
 category = "dev"
 optional = false
@@ -33,6 +46,17 @@ d = ["aiohttp (>=3.7.4)"]
 jupyter = ["ipython (>=7.8.0)", "tokenize-rt (>=3.2.0)"]
 uvloop = ["uvloop (>=0.15.2)"]
 
+[[package]]
+name = "cffi"
+version = "1.15.1"
+description = "Foreign Function Interface for Python calling C code."
+category = "main"
+optional = false
+python-versions = "*"
+
+[package.dependencies]
+pycparser = "*"
+
 [[package]]
 name = "click"
 version = "8.1.3"
@@ -52,18 +76,39 @@ category = "dev"
 optional = false
 python-versions = 
"!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,!=3.5.*,!=3.6.*,>=2.7"
 
+[[package]]
+name = "cryptography"
+version = "40.0.2"
+description = "cryptography is a package which provides cryptographic recipes 
and primitives to Python developers."
+category = "main"
+optional = false
+python-versions = ">=3.6"
+
+[package.dependencies]
+cffi = ">=1.12"
+
+[package.extras]
+docs = ["sphinx (>=5.3.0)", "sphinx-rtd-theme (>=1.1.1)"]
+docstest = ["pyenchant (>=1.6.11)", "twine (>=1.12.0)", 
"sphinxcontrib-spelling (>=4.0.1)"]
+pep8test = ["black", "ruff", "mypy", "check-manifest"]
+sdist = ["setuptools-rust (>=0.11.4)"]
+ssh = ["bcrypt (>=3.1.5)"]
+test = ["pytest (>=6.2.0)", "pytest-shard (>=0.1.2)", "pytest-benchmark", 
"pytest-cov", "pytest-subtests", "pytest-xdist", "pretend", "iso8601"]
+test-randomorder = ["pytest-randomly"]
+tox = ["tox"]
+
 [[package]]
 name = "isort"
-version = "5.10.1"
+version = "5.12.0"
 description = "A Python utility / library to sort Python imports."
 category = "dev"
 optional = false
-python-versions = ">=3.6.1,<4.0"
+python-versions = ">=3.8.0"
 
 [package.extras]
-pipfile_deprecated_finder = ["pipreqs", "requirementslib"]
-requirements_deprecated_finder = ["pipreqs", "pip-api"]
-colors = ["colorama (>=0.4.3,<0.5.0)"]
+colors = ["colorama (>=0.4.3)"]
+requirements-deprecated-finder = ["pip-api", "pipreqs"]
+pipfile-deprecated-finder = ["pip-shims (>=0.5.2)", "pipreqs", 
"requirementslib"]
 plugins = ["setuptools"]
 
 [[package]]
@@ -87,7 +132,7 @@ python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
 
 [[package]]
 name = "jsonschema"
-version = "4.17.0"
+version = "4.17.3"
 description = "An implementation of JSON Schema validation for Python"
 category = "main"
 optional = false
@@ -129,15 +174,33 @@ reports = ["lxml"]
 
 [[package]]
 name = "mypy-extensions"
-version = "0.4.3"
-description = "Experimental type system extensions for programs checked with 
the mypy typechecker."
+version = "1.0.0"
+description = "Type system extensions for programs checked with the mypy type 
checker."
 category = "dev"
 optional = false
-python-versions = "*"
+python-versions = ">=3.5"
+
+[[package]]
+name = "paramiko"
+version = "3.1.0"
+description = "SSH2 protocol library"
+category = "main"
+optional = false
+python-versions = ">=3.6"
+
+[package.dependencies]
+bcrypt = ">=3.2"
+cryptography = ">=3.3"
+pynacl = ">=1.5"
+
+[package.extras]
+all = ["pyasn1 (>=0.1.7)", "invoke (>=2.0)", "gssapi (>=1.4.1)", "pywin32 
(>