date:20230510

RE: DPDK 22.11 Troubleshooting

2023-05-10 Thread Gilbert Carrillo




-Original Message-
From: Bruce Richardson  
Sent: Tuesday, May 9, 2023 3:43 AM
To: Gilbert Carrillo 
Cc: dev@dpdk.org
Subject: Re: DPDK 22.11 Troubleshooting

On Mon, May 08, 2023 at 11:26:59PM +, Gilbert Carrillo wrote:
> 
> 
> -Original Message-
> From: Bruce Richardson 
> Sent: Wednesday, May 3, 2023 11:18 AM
> To: Gilbert Carrillo 
> Cc: dev@dpdk.org
> Subject: Re: DPDK 22.11 Troubleshooting
> 
> On Wed, May 03, 2023 at 04:53:20PM +, Gilbert Carrillo wrote:
> > Make static returns an error (see attached).
> > 
> > v/R,
> > Gilbert
> >
> 
> To help investigate this issue, can you perhaps include the text of the full 
> build output when you run "make static". On my system I see libelf listed on 
> the linker flags when I run "make static", and things link properly. I'm 
> wondering how my setup may differ from yours.
> 
> /Bruce
>  
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Wednesday, May 3, 2023 10:35 AM
> > To: Gilbert Carrillo 
> > Cc: dev@dpdk.org
> > Subject: Re: DPDK 22.11 Troubleshooting
> > 
> > On Wed, May 03, 2023 at 04:22:05PM +, Gilbert Carrillo wrote:
> > > Hi Bruce,
> > > 
> > > Thank you for the response.
> > > 
> > > There is no errors when I run the makefile, however I do see a difference 
> > > in the programs. I don't believe the makefile is linking all the 
> > > libraries together as intended.
> > > 
> > > For example, when I run the ethtool sample program and compile it using 
> > > meson, it works fine and rte_eth_dev_count_avail() returns the correct 
> > > amount. However, when I compile ethtool with the makefile and run it 
> > > rte_eth_dev_count_avail() returns 0.
> > > 
> > 
> > Note that by default the meson build will statically link the examples, 
> > while the makefile will dynamically load the drivers at runtime. That may 
> > explain the difference. Can you try building and running using "make 
> > static" rather than just "make".
> > 
> > /Bruce
> 
> Bruce,
> 
> I had multiple versions of DPDK installed and I was linking the wrong one. I 
> was able to compile my application with CMAKE successfully.
> 
> I had one last quick question. I am trying to achieve zero copy DMA from my 
> FPGA to my external buffer. Is this possible? I saw methods such as attaching 
> an mbuf to the external buffer? But I wasn't sure if this was truly zero copy.
> 
Attaching an mbuf to an external buffer would not involve any copy of the data 
itself, so should be zero-copy. Each mbuf header contains a buffer pointer, 
which normally points just to the end of the header structure, but which can 
point to any other location in memory.

/Bruce


Thank you, Bruce. Is attaching an mbuf to my external buffer the only way to 
achieve this zero copy DMA? I also read that there is a function 
rte_pktmbuf_read() that can read the data from my FPGA directly to my external 
buffer, but I don't think this method is zero copy since it requires the CPU to 
copy the data. 

/Gilbert

RE: [PATCH v7] net/ice: fix ice dcf control thread crash

2023-05-10 Thread Liao, TingtingX

> -Original Message-

> From: Mingjin Ye mailto:mingjinx...@intel.com>>

> Sent: Tuesday, April 11, 2023 10:09 AM

> To: dev@dpdk.org

> Cc: Yang, Qiming mailto:qiming.y...@intel.com>>; 
> sta...@dpdk.org; Zhou, YidingX 
> mailto:yidingx.z...@intel.com>>; Ye, MingjinX 
> mailto:mingjinx...@intel.com>>; Zhang, Ke1X 
> mailto:ke1x.zh...@intel.com>>; Zhang, Qi Z 
> mailto:qi.z.zh...@intel.com>>

> Subject: [PATCH v7] net/ice: fix ice dcf control thread crash

>

> The control thread accesses the hardware resources after the resources were 
> released, which results in a segment error.

>

> The 'ice-reset' threads are detached, so thread resources cannot be reclaimed 
> by `pthread_join` calls.

>

> This commit synchronizes the number of "ice-reset" threads by adding a 
> variable ("vsi_update_thread_num") to the "struct ice_dcf_hw" and performing 
> an atomic operation on this variable. When releasing HW resources, we wait 
> for the number of "ice-reset" threads to be reduced to 0 before releasing the 
> resources.

>

> Fixes: c7e1a1a3bfeb ("net/ice: refactor DCF VLAN handling")

> Fixes: 3b3757bda3c3 ("net/ice: get VF hardware index in DCF")

> Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")

> Fixes: 0b02c9519432 ("net/ice: handle PF initialization by DCF")

> Cc: sta...@dpdk.org

>

> Signed-off-by: Ke Zhang mailto:ke1x.zh...@intel.com>>

> Signed-off-by: Mingjin Ye 
> mailto:mingjinx...@intel.com>>



Tested-by: Tingting Liao 
mailto:tingtingx.l...@intel.com>>

Re: [PATCH v2 3/3] vhost: add device op to offload the interrupt kick

2023-05-10 Thread David Marchand

On Wed, Apr 5, 2023 at 2:42 PM Eelco Chaudron  wrote:
>
> This patch adds an operation callback which gets called every time the
> library wants to call eventfd_write(). This eventfd_write() call could
> result in a system call, which could potentially block the PMD thread.
>
> The callback function can decide whether it's ok to handle the
> eventfd_write() now or have the newly introduced function,
> rte_vhost_notify_guest(), called at a later time.
>
> This can be used by 3rd party applications, like OVS, to avoid system
> calls being called as part of the PMD threads.
>
> Signed-off-by: Eelco Chaudron 
> ---
>  lib/vhost/meson.build |2 +
>  lib/vhost/rte_vhost.h |   23 +++-
>  lib/vhost/socket.c|   72 
> ++---
>  lib/vhost/version.map |9 ++
>  lib/vhost/vhost.c |   38 ++
>  lib/vhost/vhost.h |   65 +++-
>  6 files changed, 184 insertions(+), 25 deletions(-)
>
> diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
> index 197a51d936..e93ba6b078 100644
> --- a/lib/vhost/meson.build
> +++ b/lib/vhost/meson.build
> @@ -39,3 +39,5 @@ driver_sdk_headers = files(
>  'vdpa_driver.h',
>  )
>  deps += ['ethdev', 'cryptodev', 'hash', 'pci', 'dmadev']
> +
> +use_function_versioning = true
> diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
> index 58a5d4be92..7a10bc36cf 100644
> --- a/lib/vhost/rte_vhost.h
> +++ b/lib/vhost/rte_vhost.h
> @@ -298,7 +298,13 @@ struct rte_vhost_device_ops {
>  */
> void (*guest_notified)(int vid);
>
> -   void *reserved[1]; /**< Reserved for future extension */
> +   /**
> +* If this callback is registered, notification to the guest can
> +* be handled by the front-end calling rte_vhost_notify_guest().
> +* If it's not handled, 'false' should be returned. This can be used
> +* to remove the "slow" eventfd_write() syscall from the datapath.
> +*/
> +   bool (*guest_notify)(int vid, uint16_t queue_id);
>  };
>
>  /**
> @@ -433,6 +439,21 @@ void rte_vhost_log_used_vring(int vid, uint16_t 
> vring_idx,
>
>  int rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int 
> enable);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
> + *
> + * Inject the offloaded interrupt into the vhost device's queue. For more
> + * details see the 'guest_notify' vhost device operation.
> + *
> + * @param vid
> + *  vhost device ID
> + * @param queue_id
> + *  virtio queue index
> + */
> +__rte_experimental
> +void rte_vhost_notify_guest(int vid, uint16_t queue_id);
> +
>  /**
>   * Register vhost driver. path could be different for multiple
>   * instance support.
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index 669c322e12..787d6bacf8 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -15,6 +15,7 @@
>  #include 
>  #include 
>
> +#include 
>  #include 
>
>  #include "fd_man.h"
> @@ -43,6 +44,7 @@ struct vhost_user_socket {
> bool async_copy;
> bool net_compliant_ol_flags;
> bool stats_enabled;
> +   bool alloc_notify_ops;
>
> /*
>  * The "supported_features" indicates the feature bits the
> @@ -846,6 +848,14 @@ vhost_user_socket_mem_free(struct vhost_user_socket 
> *vsocket)
> vsocket->path = NULL;
> }
>
> +   if (vsocket && vsocket->alloc_notify_ops) {
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wcast-qual"
> +   free((struct rte_vhost_device_ops *)vsocket->notify_ops);
> +#pragma GCC diagnostic pop
> +   vsocket->notify_ops = NULL;
> +   }

Rather than select the behavior based on a boolean (and here force the
compiler to close its eyes), I would instead add a non const pointer
to ops (let's say alloc_notify_ops) in vhost_user_socket.
The code can then unconditionnally call free(vsocket->alloc_notify_ops);


> +
> if (vsocket) {
> free(vsocket);
> vsocket = NULL;
> @@ -1099,21 +1109,75 @@ rte_vhost_driver_unregister(const char *path)
>  /*
>   * Register ops so that we can add/remove device to data core.
>   */
> -int
> -rte_vhost_driver_callback_register(const char *path,
> -   struct rte_vhost_device_ops const * const ops)
> +static int
> +rte_vhost_driver_callback_register__(const char *path,

No need for a rte_ prefix on static symbol.
And we can simply call this internal helper vhost_driver_callback_register().


> +   struct rte_vhost_device_ops const * const ops, bool ops_allocated)
>  {
> struct vhost_user_socket *vsocket;
>
> pthread_mutex_lock(&vhost_user.mutex);
> vsocket = find_vhost_user_socket(path);
> -   if (vsocket)
> +   if (vsocket) {
> +   if (vsocket->alloc_notify_ops) {
> +   vsocket->alloc_notify_ops = false;
> +#pragma GCC di

Re: [RFC PATCH v2 3/4] dts: add doc generation

2023-05-10 Thread Juraj Linkeš

On Tue, May 9, 2023 at 11:40 AM Bruce Richardson
 wrote:
>
> On Tue, May 09, 2023 at 11:23:50AM +0200, Juraj Linkeš wrote:
> > On Fri, May 5, 2023 at 3:29 PM Bruce Richardson
> >  wrote:
> > >
> > > On Fri, May 05, 2023 at 01:13:34PM +0200, Juraj Linkeš wrote:
> > > > On Fri, May 5, 2023 at 12:57 PM Bruce Richardson
> > > >  wrote:
> > > > >
> > > > > On Thu, May 04, 2023 at 02:37:48PM +0200, Juraj Linkeš wrote:
> > > > > > The tool used to generate developer docs is sphinx, which is already
> > > > > > used in DPDK. The configuration is kept the same to preserve the 
> > > > > > style.
> > > > > >
> > > > > > Sphinx generates the documentation from Python docstrings. The 
> > > > > > docstring
> > > > > > format most suitable for DTS seems to be the Google format [0] which
> > > > > > requires the sphinx.ext.napoleon extension.
> > > > > >
> > > > > > There are two requirements for building DTS docs:
> > > > > > * The same Python version as DTS or higher, because Sphinx import 
> > > > > > the
> > > > > >   code.
> > > > > > * Also the same Python packages as DTS, for the same reason.
> > > > > >
> > > > > > [0] 
> > > > > > https://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings
> > > > > >
> > > > > > Signed-off-by: Juraj Linkeš 
> > > > > > ---
> > > > > >  doc/api/meson.build  |  1 +
> > > > > >  doc/guides/conf.py   | 22 ++
> > > > > >  doc/guides/meson.build   |  1 +
> > > > > >  doc/guides/tools/dts.rst | 29 +++
> > > > > >  dts/doc/doc-index.rst| 20 
> > > > > >  dts/doc/meson.build  | 50 
> > > > > > 
> > > > > >  dts/meson.build  | 16 +
> > > > > >  meson.build  |  1 +
> > > > > >  meson_options.txt|  2 ++
> > > > > >  9 files changed, 137 insertions(+), 5 deletions(-)
> > > > > >  create mode 100644 dts/doc/doc-index.rst
> > > > > >  create mode 100644 dts/doc/meson.build
> > > > > >  create mode 100644 dts/meson.build
> > > > > >
> > > > > 
> > > > >
> > > > > > diff --git a/dts/doc/meson.build b/dts/doc/meson.build
> > > > > > new file mode 100644
> > > > > > index 00..db2bb0bed9
> > > > > > --- /dev/null
> > > > > > +++ b/dts/doc/meson.build
> > > > > > @@ -0,0 +1,50 @@
> > > > > > +# SPDX-License-Identifier: BSD-3-Clause
> > > > > > +# Copyright(c) 2023 PANTHEON.tech s.r.o.
> > > > > > +
> > > > > > +sphinx = find_program('sphinx-build', required: 
> > > > > > get_option('enable_dts_docs'))
> > > > > > +sphinx_apidoc = find_program('sphinx-apidoc', required: 
> > > > > > get_option('enable_dts_docs'))
> > > > > > +
> > > > > > +if sphinx.found() and sphinx_apidoc.found()
> > > > > > +endif
> > > > > > +
> > > > > > +dts_api_framework_dir = join_paths(dts_dir, 'framework')
> > > > > > +dts_api_build_dir = join_paths(doc_api_build_dir, 'dts')
> > > > > > +dts_api_src = custom_target('dts_api_src',
> > > > > > +output: 'modules.rst',
> > > > > > +command: ['SPHINX_APIDOC_OPTIONS=members,show-inheritance',
> > > > >
> > > > > This gives errors when I try to configure a build, even without docs
> > > > > enabled.
> > > > >
> > > > > ~/dpdk.org$ meson setup build-test
> > > > > The Meson build system
> > > > > Version: 1.0.1
> > > > > Source dir: /home/bruce/dpdk.org
> > > > > ...
> > > > > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > > > > Program sphinx-build found: YES (/usr/bin/sphinx-build)
> > > > > Program sphinx-apidoc found: YES (/usr/bin/sphinx-apidoc)
> > > > >
> > > > > dts/doc/meson.build:12:0: ERROR: Program 
> > > > > 'SPHINX_APIDOC_OPTIONS=members,show-inheritance' not found or not 
> > > > > executable
> > > > >
> > > > > A full log can be found at 
> > > > > /home/bruce/dpdk.org/build-test/meson-logs/meson-log.txt
> > > > >
> > > > > Assuming these need to be set in the environment, I think you can use 
> > > > > the
> > > > > "env" parameter to custom target instead.
> > > > >
> > > >
> > > > I used meson 0.53.2 as that seemed to be the version I should target
> > > > (it's used in .ci/linux-setup.sh) which doesn't support the argument
> > > > (I originally wanted to use it, but they added it in 0.57.0). I didn't
> > > > see the error with 0.53.2.
> > > >
> > > > Which version should I target? 1.0.1?
> > > >
> > > > > > +sphinx_apidoc, '--append-syspath', '--force',
> > > > > > +'--module-first', '--separate',
> > > > > > +'--doc-project', 'DTS', '-V', meson.project_version(),
> > > > > > +'-o', dts_api_build_dir,
> > > > > > +dts_api_framework_dir],
> > > > > > +build_by_default: get_option('enable_dts_docs'))
> > > > > > +doc_targets += dts_api_src
> > > > > > +doc_target_names += 'DTS_API_sphinx_sources'
> > > > > > +
> > >
> > > I didn't try with 0.53.2 - let me test that, see if the error goes away. 
> > > We
> > > may need

Re: [PATCH v2] vfio: do not coalesce DMA mappings

2023-05-10 Thread Nipun Gupta

On 4/24/2023 8:52 PM, David Marchand wrote:

Hello Anatoly,

On Wed, Apr 5, 2023 at 4:17 PM Burakov, Anatoly
wrote:

Could you please provide some steps to reproduce the hotplug issue
you're having? It would be great to have a test case for this patchset
to put it in context.

I am working on CDX bus
(http://patchwork.dpdk.org/project/dpdk/patch/20230124140746.594066-2-nipun.gu...@amd.com/)
and trying out some cases for plug/unplug.

The test is as follows:
# Run testpmd application
./dpdk-testpmd -c 0x3 -- -i --nb-cores=1

# Bind to VFIO
echo "vfio-cdx" > /sys/bus/cdx/devices/cdx-00\:00/driver_override
echo "cdx-00:00" > /sys/bus/cdx/drivers_probe

# Plug a device
testpmd> port attach cdx:cdx-00:00

#quit testpmd
testpmd> quit

This gave error at testpmd exit that memory cannot be freed. On
debugging I updated this code and seems it should be seen with any of
the device.

I see similar test case (without quit) mentioned
https://doc.dpdk.org/dts/test_plans/hotplug_test_plan.html, but the
difference is that it is with igb_uio and issue is being observed with
VFIO.

Please note the device/bus mentioned in the commands is not yet
upstreamed in DPDK, but patches would be sent out soon.

Thanks,
Nipun

Thanks, I can reproduce this issue with regular devices too (run testpmd
with no devices, bind a NIC to VFIO, attach it, then quit). You're
correct in that since the initial mapping was done with mapping large
contiguous zones (such as when mempools are created before attach), any
subsequent freeing of memory will cause these errors to happen.

I don't think this can be fixed by anything other than not doing the
contiguous mapping thing, so provisionally, I think this patch should be
accepted. I'll play around with it some more and get back to you :)

Can we conclude on this topic?
It is best we merge this kind of change the sooner possible for a release.

Hi Anatoly,
Can you kindly update on this?

Thanks,
Nipun

Thanks.

--
David Marchand

Re: [PATCH v3 00/11] sync Truflow support with latest release

2023-05-10 Thread Ajit Khaparde

On Thu, May 4, 2023 at 10:36 AM Ajit Khaparde
 wrote:
>
> Update Truflow support to latest release, deprecating code, updating
> the copyright date and hsi structure, syncing the truflow core,
> adding ULP shared session support, RSS action support, Queue
> action support, rte meter support, and more.
>
> Please apply.
>
> v2->v3:
> - update some commit messages
> - removed some empty lines in the patches
> - removed some dead and unnecessary code
> - fixed some checkpatch errors
>
> Version 2 fixes:
> - misspellings
> - whitespace issues
> - signed off issues

Patchset applied to dpdk-next-net-brcm for-next-net branch.

Thanks.

>
>
> Kishore Padmanabha (1):
>   net/bnxt: fix multi-root card support
>
> Randy Schacher (8):
>   net/bnxt: remove deprecated features
>   net/bnxt: update bnxt hsi structure
>   net/bnxt: update copyright date and cleanup whitespace
>   net/bnxt: update Truflow core
>   net/bnxt: update ULP shared session support
>   net/bnxt: add RSS and Queue action in TruFLow
>   net/bnxt: add support for rte meter
>   net/bnxt: add support for eCPRI packet parsing
>
> Shuanglin Wang (1):
>   net/bnxt: set RSS config based on RSS mode
>
> Somnath Kotur (1):
>   net/bnxt: update PTP support on Thor
>
>  .mailmap  | 1 +
>  doc/guides/nics/features/bnxt.ini | 3 +
>  drivers/net/bnxt/bnxt.h   |66 +-
>  drivers/net/bnxt/bnxt_cpr.c   | 2 +-
>  drivers/net/bnxt/bnxt_cpr.h   | 2 +-
>  drivers/net/bnxt/bnxt_ethdev.c|   209 +-
>  drivers/net/bnxt/bnxt_filter.c| 2 +-
>  drivers/net/bnxt/bnxt_filter.h| 6 +-
>  drivers/net/bnxt/bnxt_flow.c  |75 +-
>  drivers/net/bnxt/bnxt_hwrm.c  |   272 +-
>  drivers/net/bnxt/bnxt_hwrm.h  |40 +-
>  drivers/net/bnxt/bnxt_irq.c   | 2 +-
>  drivers/net/bnxt/bnxt_irq.h   | 3 +-
>  drivers/net/bnxt/bnxt_nvm_defs.h  | 3 +-
>  drivers/net/bnxt/bnxt_reps.c  | 4 +-
>  drivers/net/bnxt/bnxt_reps.h  | 2 +-
>  drivers/net/bnxt/bnxt_ring.c  | 7 +-
>  drivers/net/bnxt/bnxt_ring.h  | 3 +-
>  drivers/net/bnxt/bnxt_rxq.c   |   159 +-
>  drivers/net/bnxt/bnxt_rxq.h   | 2 +-
>  drivers/net/bnxt/bnxt_rxr.c   |15 +-
>  drivers/net/bnxt/bnxt_rxr.h   | 3 +-
>  drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 2 +-
>  drivers/net/bnxt/bnxt_rxtx_vec_common.h   | 2 +-
>  drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 2 +-
>  drivers/net/bnxt/bnxt_rxtx_vec_sse.c  | 2 +-
>  drivers/net/bnxt/bnxt_stats.c | 2 +-
>  drivers/net/bnxt/bnxt_stats.h | 2 +-
>  drivers/net/bnxt/bnxt_txq.c   | 3 +-
>  drivers/net/bnxt/bnxt_txq.h   | 2 +-
>  drivers/net/bnxt/bnxt_txr.c   |55 +-
>  drivers/net/bnxt/bnxt_txr.h   | 4 +-
>  drivers/net/bnxt/bnxt_util.c  | 2 +-
>  drivers/net/bnxt/bnxt_util.h  | 3 +-
>  drivers/net/bnxt/bnxt_vnic.c  |   974 +-
>  drivers/net/bnxt/bnxt_vnic.h  |80 +-
>  drivers/net/bnxt/hsi_struct_def_dpdk.h|  5723 ++-
>  drivers/net/bnxt/meson.build  | 5 +-
>  drivers/net/bnxt/rte_pmd_bnxt.c   | 2 +-
>  drivers/net/bnxt/rte_pmd_bnxt.h   | 2 +-
>  drivers/net/bnxt/tf_core/bitalloc.c   | 3 +-
>  drivers/net/bnxt/tf_core/bitalloc.h   | 3 +-
>  drivers/net/bnxt/tf_core/cfa_resource_types.h | 5 +-
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr.c   |  2116 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr.h   |   523 +
>  .../net/bnxt/tf_core/cfa_tcam_mgr_device.h|   101 +
>  .../net/bnxt/tf_core/cfa_tcam_mgr_hwop_msg.c  |   201 +
>  .../net/bnxt/tf_core/cfa_tcam_mgr_hwop_msg.h  |28 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr_p4.c|   921 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr_p4.h|20 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr_p58.c   |   926 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr_p58.h   |20 +
>  drivers/net/bnxt/tf_core/cfa_tcam_mgr_sbmp.h  |   126 +
>  .../net/bnxt/tf_core/cfa_tcam_mgr_session.c   |   377 +
>  .../net/bnxt/tf_core/cfa_tcam_mgr_session.h   |54 +
>  drivers/net/bnxt/tf_core/dpool.c  | 3 +-
>  drivers/net/bnxt/tf_core/dpool.h  | 3 +-
>  drivers/net/bnxt/tf_core/ll.c | 2 +-
>  drivers/net/bnxt/tf_core/ll.h | 2 +-
>  drivers/net/bnxt/tf_core/lookup3.h| 1 -
>  drivers/net/bnxt/tf_core/meson.build  |38 +-
>  drivers/net/bnxt/tf_core/rand.c   | 2 +-
>  drivers/net/bnxt/tf_core/rand.h   | 3 +-

[PATCH] net/ice: fix statistics

2023-05-10 Thread Mingjin Ye

When the stats_get api is called for the first time in pmd, the offset
of the stats register is not recorded. That results in all the obtained
count values being 0.

This patch adds reset statistics before dev_init returning. That avoids
some noise being counted.

Fixes: 12443386a0b0 ("net/ice: support flex Rx descriptor RxDID22")
Cc: sta...@dpdk.org

Signed-off-by: Mingjin Ye 
---
 drivers/net/ice/ice_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 9a88cf9796..1116880485 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2440,6 +2440,9 @@ ice_dev_init(struct rte_eth_dev *dev)
 
pf->supported_rxdid = ice_get_supported_rxdid(hw);
 
+   /* reset all stats of the device, including pf and main vsi */
+   ice_stats_reset(dev);
+
return 0;
 
 err_flow_init:
-- 
2.25.1

Reminder - DPDK Ci Community Testing Meeting - Tomorrow 5/11/23 @ 6am PDT/9am EDT

2023-05-10 Thread Nathan Southern

Good evening,

The DPDK Community CI Testing Group meets tomorrow, May 11, 2023, at 6am
PDT/9am EDT/1300h UTC.

Zoom information to follow. We look forward to seeing you there

Thanks,

Nathan

Nathan C. Southern, Project Coordinator

Data Plane Development Kit

The Linux Foundation

248.835.4812 (mobile)

nsouth...@linuxfoundation.org

Join Zoom Meeting
*https://zoom.us/j/95952696590?pwd=b0JjVnJaWDZ3TW1XYjZKQkxmZUZuQT09*


Meeting ID: 959 5269 6590
Password: 815823
One tap mobile
+16465588656,,95952696590#,,#,815823# US (New York)
+13126266799,,95952696590#,,#,815823# US (Chicago)

Dial by your location
+1 646 558 8656 US (New York)
+1 312 626 6799 US (Chicago)
+1 346 248 7799 US (Houston)
+1 669 900 6833 US (San Jose)
+1 253 215 8782 US
+1 301 715 8592 US
855 880 1246 US Toll-free
877 369 0926 US Toll-free
+1 438 809 7799 Canada
+1 587 328 1099 Canada
+1 647 374 4685 Canada
+1 647 558 0588 Canada
+1 778 907 2071 Canada
855 703 8985 Canada Toll-free
Meeting ID: 959 5269 6590
Password: 815823
Find your local number: *https://zoom.us/u/aluff6iKE*

DPDK (Data Plane Development Kit)
Created by: Nathan Southern

[PATCH] event/dsw: free rings on close

2023-05-10 Thread Mattias Rönnblom

The per-port data and control rings were not freed when the event
device was closed.

Fixes: 1c8e3caa3bfb ("event/dsw: add event scheduling and device start/stop")
Cc: sta...@dpdk.org

Signed-off-by: Mattias Rönnblom 
---
 drivers/event/dsw/dsw_evdev.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index ffabf0d23d..6c5cde2468 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -363,6 +363,10 @@ static int
 dsw_close(struct rte_eventdev *dev)
 {
struct dsw_evdev *dsw = dsw_pmd_priv(dev);
+   uint16_t port_id;
+
+   for (port_id = 0; port_id < dsw->num_ports; port_id++)
+   dsw_port_release(&dsw->ports[port_id]);
 
dsw->num_ports = 0;
dsw->num_queues = 0;
-- 
2.34.1

[PATCH] eventdev: avoid non-burst shortcut for variable-size bursts

2023-05-10 Thread Mattias Rönnblom

Use non-burst event enqueue and dequeue calls from burst enqueue and
dequeue only when the burst size is compile-time constant (and equal
to one).

Signed-off-by: Mattias Rönnblom 
---
 lib/eventdev/rte_eventdev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index a90e23ac8b..8af15816db 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1944,7 +1944,7 @@ __rte_event_enqueue_burst(uint8_t dev_id, uint8_t port_id,
 * Allow zero cost non burst mode routine invocation if application
 * requests nb_events as const one
 */
-   if (nb_events == 1)
+   if (__builtin_constant_p(nb_events) && nb_events == 1)
return (fp_ops->enqueue)(port, ev);
else
return fn(port, ev, nb_events);
@@ -2200,7 +2200,7 @@ rte_event_dequeue_burst(uint8_t dev_id, uint8_t port_id, 
struct rte_event ev[],
 * Allow zero cost non burst mode routine invocation if application
 * requests nb_events as const one
 */
-   if (nb_events == 1)
+   if (__builtin_constant_p(nb_events) && nb_events == 1)
return (fp_ops->dequeue)(port, ev, timeout_ticks);
else
return (fp_ops->dequeue_burst)(port, ev, nb_events,
-- 
2.34.1

RE: [dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 13

2023-05-10 Thread Gao, DaxueX




> -Original Message-
> From: jer...@marvell.com 
> Sent: 2023年5月2日 21:51
> To: dev@dpdk.org; Dumitrescu, Cristian ;
> Singh, Jasvinder 
> Cc: tho...@monjalon.net; david.march...@redhat.com;
> ferruh.yi...@xilinx.com; step...@networkplumber.org; Jerin Jacob
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] examples/ip_pipeline: fix build issue with GCC 
> 13
> 
> From: Jerin Jacob 
> 
> Fix the following build issue by initializing req to NULL for the local 
> variable.
> 
> In function 'thread_msg_handle', inlined from 'thread_main' at
> ../examples/ip_pipeline/thread.c:3130:6:
> ../examples/ip_pipeline/thread.c:535:20: warning: 'req' may be used
> uninitialized [-Wmaybe-uninitialized]
>   535 | if (req == NULL)
>   |^
> ../examples/ip_pipeline/thread.c: In function 'thread_main':
> ../examples/ip_pipeline/thread.c:433:32: note: 'req' was declared here
>   433 | struct thread_msg_req *req;
> 
> Bugzilla ID: 1220
> Fixes: a8bd581de397 ("examples/ip_pipeline: add thread runtime")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Jerin Jacob 
Tested-by: Daxue Gao

RE: [dpdk-dev] [PATCH v2] examples/ntb: fix build issue with GCC 13