Re: [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100
On 3/12/23 13:54, Ivan Malov wrote:
The driver supports representor functionality. In it,
packets coming from VFs to the dedicated back-end Rx
queue get demultiplexed into front-end Rx queues of
representor ethdevs as per the per-packet metadata
indicating logical HW ingress ports. On transmit,
packets are provided with symmetrical metadata
by front-end Tx queues, and the back-end queue
transforms the data into so-called Tx override
descriptors. These let the packets bypass flow
lookup and go directly to the represented VFs.
However, in the Rx part, the driver extracts
the said metadata on every HW Rx queue, that
is, not just on the one used by representors.
Doing so leads to a buggy behaviour. It is
revealed by operating testpmd as follows:
dpdk-testpmd -a :c6:00.0 -a :c6:00.1 -- -i
testpmd> flow create 0 transfer pattern port_representor \
port_id is 0 / end actions port_representor port_id 1 / end
Flow rule #0 created
testpmd> set fwd io
testpmd> start tx_first
testpmd> flow destroy 0 rule 0
Flow rule #0 destroyed
testpmd> stop
-- Forward statistics for port 0 -
RX-packets: 19196498 RX-dropped: 0 RX-total: 19196498
TX-packets: 19196535 TX-dropped: 0 TX-total: 19196535
---
-- Forward statistics for port 1 -
RX-packets: 19196503 RX-dropped: 0 RX-total: 19196503
TX-packets: 19196530 TX-dropped: 0 TX-total: 19196530
---
In this scenario, two physical functions of the adapter
do not have any corresponding "back-to-back" forwarder
on peer host. Packets transmitted from port 0 can only
be forwarded to port 1 by means of a special flow rule.
The flow rule indeed works, but destroying it does not
stop forwarding. Port statistics carry on incrementing.
Also, it is apparent that forwarding in the opposite
direction must not have worked in this case as the
flow is meant to target only one of the directions.
Because of the bug, the first 32 mbufs received
as a result of the flow rule operation have the
said metadata present. In io mode, testpmd does
not tamper with mbufs and passes them directly
to transmit path, so this data remains in them
instructing the PMD to override destinations
of the packets via Tx option descriptors.
Expected behaviour is as follows:
-- Forward statistics for port 0 -
RX-packets: 0 RX-dropped: 0 RX-total: 0
TX-packets: 15787496 TX-dropped: 0 TX-total: 15787496
---
-- Forward statistics for port 1 -
RX-packets: 15787464 RX-dropped: 0 RX-total: 15787464
TX-packets: 32 TX-dropped: 0 TX-total: 32
---
These figures show the rule work only for one direction.
Also, removing the flow shall cause forwarding to cease.
Provided patch fixes the bug accordingly.
Fixes: d0f981a3efd8 ("net/sfc: handle ingress mport in EF100 Rx prefix")
Cc: sta...@dpdk.org
Signed-off-by: Ivan Malov
Reviewed-by: Andy Moreton
Acked-by: Andrew Rybchenko
Re: [PATCH v2 06/44] net/sfc: fix segment fault when parse devargs
On 3/20/23 12:20, Chengwen Feng wrote:
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: 9e7fc8b8f3be ("net/sfc: add device parameter to choose FW variant")
Fixes: c22d3c508e0c ("net/sfc: support parameter to choose performance profile")
Fixes: 63d588ff2692 ("net/sfc: libefx-based driver stub")
Fixes: df1bfde4ff0d ("net/sfc: factor out libefx-based Rx datapath")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Acked-by: Andrew Rybchenko
Re: [PATCH v2 02/44] ethdev: fix segment fault when parse args
On 3/20/23 12:20, Chengwen Feng wrote:
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse args with 'only keys'
(e.g. 'mac,representor').
Fixes: c10cdce180a6 ("ethdev: support MAC address as iterator filter")
Fixes: a7d3c6271d55 ("ethdev: support representor id as iterator filter")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Acked-by: Andrew Rybchenko
Re: [PATCH] dma/dpaa2: set the vfa bit for rbp with vf
Hi, Any comments on the patch? Thanks
RE: [PATCH] app/crypto-perf: change buffer size based on optype
> Adding digest size to buffer size in auth-then-cipher mode with auth_op set to > generate as cipher length includes digest size also. > > Signed-off-by: Tejasree Kondoj > --- > app/test-crypto-perf/cperf_options_parsing.c | 8 > 1 file changed, 8 insertions(+) > Acked-by: Anoob Joseph
[PATCH] power: amd power monitor support
mwaitx allows epyc processors to enter a implementation dependent
power/performance optimized state (C1 state) for a specific period
or until a store to the monitored address range.
Signed-off-by: Sivaprasad Tummala
---
lib/eal/include/generic/rte_cpuflags.h | 2 +
lib/eal/x86/include/rte_cpuflags.h | 1 +
lib/eal/x86/rte_cpuflags.c | 3 +
lib/eal/x86/rte_power_intrinsics.c | 80 +-
lib/power/rte_power_pmd_mgmt.c | 3 +-
5 files changed, 86 insertions(+), 3 deletions(-)
diff --git a/lib/eal/include/generic/rte_cpuflags.h
b/lib/eal/include/generic/rte_cpuflags.h
index d35551e931..db653a8dd7 100644
--- a/lib/eal/include/generic/rte_cpuflags.h
+++ b/lib/eal/include/generic/rte_cpuflags.h
@@ -26,6 +26,8 @@ struct rte_cpu_intrinsics {
/**< indicates support for rte_power_pause function */
uint32_t power_monitor_multi : 1;
/**< indicates support for rte_power_monitor_multi function */
+ uint32_t amd_power_monitorx : 1;
+ /**< indicates amd support for rte_power_monitor function */
};
/**
diff --git a/lib/eal/x86/include/rte_cpuflags.h
b/lib/eal/x86/include/rte_cpuflags.h
index 92e90fb6e0..5ccf4e7d98 100644
--- a/lib/eal/x86/include/rte_cpuflags.h
+++ b/lib/eal/x86/include/rte_cpuflags.h
@@ -102,6 +102,7 @@ enum rte_cpu_flag_t {
/* (EAX 8001h) ECX features */
RTE_CPUFLAG_LAHF_SAHF, /**< LAHF_SAHF */
RTE_CPUFLAG_LZCNT, /**< LZCNT */
+ RTE_CPUFLAG_MONITORX, /**< MONITORX */
/* (EAX 8001h) EDX features */
RTE_CPUFLAG_SYSCALL,/**< SYSCALL */
diff --git a/lib/eal/x86/rte_cpuflags.c b/lib/eal/x86/rte_cpuflags.c
index d6b518251b..ae2e0a8470 100644
--- a/lib/eal/x86/rte_cpuflags.c
+++ b/lib/eal/x86/rte_cpuflags.c
@@ -133,6 +133,7 @@ const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(LAHF_SAHF, 0x8001, 0, RTE_REG_ECX, 0)
FEAT_DEF(LZCNT, 0x8001, 0, RTE_REG_ECX, 4)
+ FEAT_DEF(MONITORX, 0x8001, 0, RTE_REG_ECX, 29)
FEAT_DEF(SYSCALL, 0x8001, 0, RTE_REG_EDX, 11)
FEAT_DEF(XD, 0x8001, 0, RTE_REG_EDX, 20)
@@ -191,5 +192,7 @@ rte_cpu_get_intrinsics_support(struct rte_cpu_intrinsics
*intrinsics)
intrinsics->power_pause = 1;
if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_RTM))
intrinsics->power_monitor_multi = 1;
+ } else if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_MONITORX)) {
+ intrinsics->amd_power_monitorx = 1;
}
}
diff --git a/lib/eal/x86/rte_power_intrinsics.c
b/lib/eal/x86/rte_power_intrinsics.c
index f749da9b85..4e81870387 100644
--- a/lib/eal/x86/rte_power_intrinsics.c
+++ b/lib/eal/x86/rte_power_intrinsics.c
@@ -30,6 +30,7 @@ __umwait_wakeup(volatile void *addr)
static bool wait_supported;
static bool wait_multi_supported;
+static bool amd_mwaitx_supported;
static inline uint64_t
__get_umwait_val(const volatile void *p, const uint8_t sz)
@@ -65,6 +66,76 @@ __check_val_size(const uint8_t sz)
}
}
+/**
+ * This function uses MONITORX/MWAITX instructions and will enter C1 state.
+ * For more information about usage of these instructions, please refer to
+ * AMD64 Architecture Programmer’s Manual.
+ */
+static inline int
+amd_power_monitorx(const struct rte_power_monitor_cond *pmc,
+ const uint64_t tsc_timestamp)
+{
+ const unsigned int lcore_id = rte_lcore_id();
+ struct power_wait_status *s;
+ uint64_t cur_value;
+
+ RTE_SET_USED(tsc_timestamp);
+
+ /* prevent non-EAL thread from using this API */
+ if (lcore_id >= RTE_MAX_LCORE)
+ return -EINVAL;
+
+ if (pmc == NULL)
+ return -EINVAL;
+
+ if (__check_val_size(pmc->size) < 0)
+ return -EINVAL;
+
+ if (pmc->fn == NULL)
+ return -EINVAL;
+
+ s = &wait_status[lcore_id];
+
+ /* update sleep address */
+ rte_spinlock_lock(&s->lock);
+ s->monitor_addr = pmc->addr;
+
+ /*
+* we're using raw byte codes for now as only the newest compiler
+* versions support this instruction natively.
+*/
+ /* set address for MONITORX */
+ asm volatile(".byte 0x0f, 0x01, 0xfa;"
+ :
+ : "a"(pmc->addr),
+ "c"(0), /* no extensions */
+ "d"(0)); /* no hints */
+
+ /* now that we've put this address into monitor, we can unlock */
+ rte_spinlock_unlock(&s->lock);
+
+ cur_value = __get_umwait_val(pmc->addr, pmc->size);
+
+ /* check if callback indicates we should abort */
+ if (pmc->fn(cur_value, pmc->opaque) != 0)
+ goto end;
+
+ /* execute MWAITX */
+ asm volatile(".byte 0x0f, 0x01, 0xfb;"
+ : /* ignore rflags */
+ : "a"(0), /* enter C1 */
+
[PATCH] net/gve: add struct members and typedefs for DQO
Add struct members for gve_tx_queue and gve_rx_queue.
Add typedefs for little endians.
Signed-off-by: Junfeng Guo
Signed-off-by: Rushil Gupta
Signed-off-by: Joshua Washington
Signed-off-by: Jeroen de Borst
---
.mailmap | 1 +
drivers/net/gve/base/gve_osdep.h | 4
drivers/net/gve/gve_ethdev.h | 9 +
3 files changed, 14 insertions(+)
diff --git a/.mailmap b/.mailmap
index 0859104404..10e1392cd8 100644
--- a/.mailmap
+++ b/.mailmap
@@ -590,6 +590,7 @@ Jens Freimann
Jeremy Plsek
Jeremy Spewock
Jerin Jacob
+Jeroen de Borst
Jerome Jutteau
Jerry Hao OS
Jerry Lilijun
diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/gve_osdep.h
index 7cb73002f4..abf3d379ae 100644
--- a/drivers/net/gve/base/gve_osdep.h
+++ b/drivers/net/gve/base/gve_osdep.h
@@ -35,6 +35,10 @@ typedef rte_be16_t __be16;
typedef rte_be32_t __be32;
typedef rte_be64_t __be64;
+typedef rte_le16_t __le16;
+typedef rte_le32_t __le32;
+typedef rte_le64_t __le64;
+
typedef rte_iova_t dma_addr_t;
#define ETH_MIN_MTURTE_ETHER_MIN_MTU
diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h
index 42a02cf5d4..0b825113f6 100644
--- a/drivers/net/gve/gve_ethdev.h
+++ b/drivers/net/gve/gve_ethdev.h
@@ -11,6 +11,9 @@
#include "base/gve.h"
+/* TODO: this is a workaround to ensure that Tx complq is enough */
+#define DQO_TX_MULTIPLIER 4
+
/*
* Following macros are derived from linux/pci_regs.h, however,
* we can't simply include that header here, as there is no such
@@ -124,6 +127,9 @@ struct gve_tx_queue {
const struct rte_memzone *qres_mz;
struct gve_queue_resources *qres;
+ /* newly added for DQO */
+ uint64_t compl_ring_phys_addr;
+
/* Only valid for DQO_RDA queue format */
struct gve_tx_queue *complq;
@@ -164,6 +170,9 @@ struct gve_rx_queue {
uint16_t ntfy_id;
uint16_t rx_buf_len;
+ /* newly added for DQO */
+ uint64_t compl_ring_phys_addr;
+
/* Only valid for DQO_RDA queue format */
struct gve_rx_queue *bufq;
--
2.34.1
