Re: [PATCH v3] devtools: ensure proper tag sequence
19/07/2022 14:01, jpali...@marvell.com: > From: Jakub Palider > > This change to log checking procedure ensures that certain > tags are in proper order. > The order of tags is as follows: > * Coverity issue > * Bugzilla ID > * Fixes > * Cc > * > * Suggested-by > * Reported-by > + Signed-off-by > * Acked-by > * Reviewed-by > * Tested-by > where: > * => 0 or more than one instance possible > + => more than once instance possible > In order to satisfy the above requirements an extra check > is performed for obligatory tags. > > v3: > * restored some tags under check > * defined chronological order after Signed-off > > v2: > * narrowed down the tags under check > > Signed-off-by: Jakub Palider I've moved "Reported-by" before "Suggested-by" and made the output more consistent with other checks. Applied, thanks.
Re: [PATCH 0/2] update ethdev deprecation notices
> > > The deprecation plan was not followed for rte_flow actions and items. > > > It needs to be reflected before the release 22.11. > > > > > > Thomas Monjalon (2): > > >doc: update deprecation notice of legacy flow actions > > >doc: update deprecation notice of flow items > > > > Series-acked-by: Andrew Rybchenko > > Series-acked-by: Ori Kam Applied
Re: [PATCH v1] doc: update release notes for 22.11
24/11/2022 18:12, Mcnamara, John: > > Fix grammar, spelling and formatting of DPDK 22.11 release notes. > > P.S., I didn't remove the instructions or empty sections. Removed comments and applied, thanks.
[PATCH v6] mailmap: add file to DPDK
From: Bruce Richardson Since a number of contributors to DPDK have submitted patches to DPDK under more than one email address, we should maintain a mailmap file to properly track their commits using "shortlog". It also helps fix up any mangled names, for example, with surname/firstname reversed, or with incorrect capitalization. By keeping this file in the DPDK repository, rather than committers maintaining their own copies, it allows individual contributors to edit it to update their own email address preferences if so desired. While at it, update our checkpatches.sh script and add some documentation to help new contributors. Signed-off-by: Bruce Richardson Signed-off-by: David Marchand --- Changes since v5: - reworded the note asking for filling .mailmap in the contributing guide, Changes since v4: - removed duplicates, - sorted file with LC_COLLATE=en_US.utf8, - checked all git history: added missing people, added more mangled names, removed people with no trace in git history, Changes since v3: - fixed some issues with non iso characters in names, - added .mailmap to MAINTAINERS, - populated .mailmap with the contributors file Thomas and I maintain, - added a check so that people will stop mangling their own names, - added a note in the contributing guide, --- .mailmap| 1571 +++ MAINTAINERS |1 + devtools/checkpatches.sh| 30 + doc/guides/contributing/patches.rst |6 + 4 files changed, 1608 insertions(+) create mode 100644 .mailmap diff --git a/.mailmap b/.mailmap new file mode 100644 index 00..b94c8c2608 --- /dev/null +++ b/.mailmap @@ -0,0 +1,1571 @@ +Aakash Sasidharan +Aaro Koskinen +Aaron Campbell +Aaron Conole +Abdullah Ömer Yamaç +Abdullah Sevincer +Abed Kamaluddin +Abhijit Sinha +Abhimanyu Saini +Abhinandan Gujjar +Abhishek Maheshwari +Abhishek Marathe +Abhishek Sachan +Abraham Tovar +Adam Bynes +Adam Dybkowski +Adam Ludkiewicz +Adham Masarwah +Adrian Moreno +Adrian Podlawski +Adrien Mazarguil +Ady Agbarih +Agalya Babu RadhaKrishnan +Aidan Goddard +Aideen McLoughlin +Ajit Khaparde +Akash Saxena +Akeem G Abodunrin +Akhil Goyal +Alain Leon +Alan Carew +Alan Dewar +Alan Liu +Alan Winkowski +Alejandro Lucero +Aleksander Gajewski +Aleksandr Loktionov +Aleksandr Miloshenko +Aleksey Baulin +Aleksey Katargin +Alexander Bechikov +Alexander Belyakov +Alexander Chernavin +Alexander Guy +Alexander Kozyrev +Alexander Matushevsky +Alexander Solganik +Alexander V Gutkin +Alexandre Ferrieux +Alexey Kardashevskiy +Alex Kiselev +Alex Marginean +Alex Markuze +Alex Porosanu +Alex Rosenbaum +Alex Vesker +Alex Wang +Alex Zelezniak +Alfredo Cardigliano +Ali Alnubani +Alice Michael +Alin Rauta +Ali Volkan Atli +Allain Legacy +Allen Hubbe +Alok Makhariya +Alvin Zhang +Aman Singh +Amaranath Somalapuram +Amine Kherbouche +Amin Tootoonchian +Ami Sabo +Amit Bernstein +Amit Gupta +Amit Prakash Shukla +Amr Mokhtar +Amruta Zende +Amrutha Sampath +Ananda Sathyanarayana +Anand B Jyoti +Anand Rawat +Anand Sunkad +Anatolii Gerasymenko +Anatoly Burakov +Anbarasan Murugesan +Anders Roxell +Andrea Arcangeli +Andrea Grandi +Andre Richter +Andrew Boyer +Andrew Harvey +Andrew Jackson +Andrew Lee +Andrew Pinski +Andrew Rybchenko +Andrey Chilikin +Andrey Nikolaev +Andrey Vesnovaty +Andrii Pypchenko +Andrius Sirvys +Andriy Berestovskyy +Andrzej Ostruszka +Andy Gospodarek +Andy Green +Andy Moreton +Andy Pei +Anirudh Venkataramanan +Ankur Dwivedi +Anna Lukin +Anoob Joseph +Antara Ganesh Kolar +Anthony Fee +Antonio Fischetti +Anupam Kapoor +Apeksha Gupta +Archana Muniganti +Archit Pandey +Arkadiusz Kubalewski +Arkadiusz Kusztal +Arnon Warshavsky +Arshdeep Kaur +Artem V. Andreev +Artur Rojek +Artur Trybula +Artur Tyminski +Asaf Penso +Asaf Ravid +Ashijeet Acharya +Ashish Gupta +Ashish Jain +Ashish Paul +Ashish Sadanandan +Ashish Shah +Ashwin Sekhar T K +Asim Jamshed +Aviad Yehezkel +Avi Kivity +Aws Ismail +Ayuj Verma +Balakrishna Bhamidipati +Balasubramanian Manoharan +Balazs Nemeth +Bao-Long Tran +Barak Enat +Barry Cao +Baruch Siach +Bassam Zaid AlKilani +Beilei Xing +Bei Sun +Benjamin Le Berre +Ben Magistro +Benoît Canet +Benoît Ganne +Ben Pfaff +Ben Shelton +Ben Walker +Bernard Iremonger +Bert van Leeuwen +Bhagyada Modali +Bharat Mota +Bill Hong +Billy McFall +Billy O'Mahony +Bing Zhao +Bin Huang +Bin Zheng +Björn Töpel +Bo Chen +Boon Ang +Boris Pismenny +Brandon Lo +Brendan Ryan +Brett Creeley +Brian Archbold +Brian Brooks +Brian Dooley +Brian Johnson +Brian Poole +Brian Russell +Brick Yang +Bruce Allan +Bruce Liu <2103458...@qq.com> +Bruce Merry +Bruce Richardson +Bryan Benson +Byron Marohn +Carolyn Wyborny +Chaeyong Chong +Chaitanya Babu Talluri +Chandubabu Namburu +Changchun Ouyang +Changpeng
RE: release candidate 22.11-rc4
Hi All, Update the test status for Intel part. Till now dpdk22.11-rc4 test is almost finished. No critical & new issue are found. # Basic Intel(R) NIC testing * Build or compile: *Build: cover the build test combination with latest GCC/Clang version and the popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.1, Ubuntu22.10, Fedora36&37, RHEL8.6 etc. - All test passed. *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu22.04.1 and RHEL8.6. - All test passed. * PF/VF(i40e, ixgbe): test scenarios including PF/VF- RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. - All test done. No new issue is found. - Known Bug "vf_interrupt_pmd/nic_interrupt_VF_vfio_pci: l3fwd-power Wake up failed" on X722 37d0. Verify patch passed. * PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc. - All test done. No new issue is found. * Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, RFC2544 Zero packet loss performance test, etc. - All test done. No new issue is found. * Power and IPsec: * Power: test scenarios including bi-direction/Telemetry/Empty Poll Lib/Priority Base Frequency, etc. - All test done. No new issue is found. * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc. - All test done. No new issue is found. # Basic cryptodev and virtio testing * Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing, etc. - All test done. No new issue is found. * Cryptodev: *Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc. - All test done. No new issue is found. *Performance test: test scenarios including Throughput Performance /Cryptodev Latency, etc. - All test done. No new issue is found. BRs Yu Jiang > -Original Message- > From: Jiang, YuX > Sent: Thursday, November 24, 2022 5:16 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Richardson, Bruce > ; Peng, Yuan > Subject: RE: release candidate 22.11-rc4 > > Hi All, > > Update the test status for Intel part. Till now dpdk22.11-rc4 test execution > rate > is 85%. > No new issue is found. > > # Basic Intel(R) NIC testing > * Build or compile: > *Build: cover the build test combination with latest GCC/Clang version and > the popular OS revision such as Ubuntu20.04.5, Ubuntu22.04.1, Ubuntu22.10, > Fedora36，Fedora37, RHEL8.6 etc. > - All test passed. > *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as > Ubuntu22.04.1 and RHEL8.6. > - All test passed. > * PF/VF(i40e, ixgbe): test scenarios including PF/VF- > RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. > - Execution rate is 90%. No new issue is found. > - Known Bug "vf_interrupt_pmd/nic_interrupt_VF_vfio_pci: l3fwd-power > Wake up failed" on X722 37d0. Verify patch passed. > * PF/VF(ice): test scenarios including Switch features/Package > Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible > Descriptor, etc. > - Execution rate is 90%. No new issue is found. > * Intel NIC single core/NIC performance: test scenarios including PF/VF single > core performance test, RFC2544 Zero packet loss performance test, etc. > - Execution rate is 80%. No new issue is found. > * Power and IPsec: > * Power: test scenarios including bi-direction/Telemetry/Empty Poll > Lib/Priority Base Frequency, etc. > - Execution rate is 80%. No new issue is found. > * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - > QAT&SW/FIB library, etc. > - Execution rate is 30%. No new issue is found. > # Basic cryptodev and virtio testing > * Virtio: both function and performance test are covered. Such as > PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing, etc. > - Execution rate is 90%. No new issue is found. > * Cryptodev: > *Function test: test scenarios including Cryptodev API testing/CompressDev > ISA-L/QAT/ZLIB PMD Testing/FIPS, etc. > - Under testing. No new issue is found. > *Performance test: test scenarios including Throughput Performance > /Cryptodev Latency, etc. > - Under testing. No new issue is found. > > Best regards, > Yu Jiang > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 22, 2022 11:50 PM > > To: annou...@dpdk.org > > Subject: release candidate 22.11-rc4 > > > > A new DPDK release candidate is ready for testing: > > https://git.dpdk.org/dpdk/tag/?id=v22.11-rc4 > > > > There are 56 new patches in this snapshot. > > > > Release notes: > > https://doc.dpdk.org/guides/rel_notes/release_22_11.html > > > > This is the last release candidate. >
RE: [PATCH v6] mailmap: add file to DPDK
> -Original Message- > From: David Marchand > Sent: Friday, November 25, 2022 2:54 PM > To: dev@dpdk.org > Cc: ferruh.yi...@amd.com; Richardson, Bruce > ; Thomas Monjalon > Subject: [PATCH v6] mailmap: add file to DPDK > > From: Bruce Richardson > > Since a number of contributors to DPDK have submitted patches to DPDK > under more than one email address, we should maintain a mailmap file to > properly track their commits using "shortlog". > > It also helps fix up any mangled names, for example, with > surname/firstname reversed, or with incorrect capitalization. > By keeping this file in the DPDK repository, rather than committers > maintaining their own copies, it allows individual contributors to edit > it to update their own email address preferences if so desired. > > While at it, update our checkpatches.sh script and add some > documentation to help new contributors. > > Signed-off-by: Bruce Richardson > Signed-off-by: David Marchand > --- > Changes since v5: > - reworded the note asking for filling .mailmap in the contributing > guide, > > +Cristian Dumitrescu The above yahoo.com address under my name was a mistake and it is not valid, therefore it should probably be removed from here. The only valid one is: > +Cristian Dumitrescu
Re: [PATCH] net/gve: add support for basic stats
Makes sense.
On Thu, Nov 24, 2022 at 9:26 AM Ferruh Yigit wrote:
>
> On 11/24/2022 4:59 PM, Stephen Hemminger wrote:
> > On Thu, 24 Nov 2022 15:33:35 +0800
> > Junfeng Guo wrote:
> >
> >> +static int
> >> +gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> >> +{
> >> +uint16_t i;
> >> +
> >> +for (i = 0; i < dev->data->nb_tx_queues; i++) {
> >> +struct gve_tx_queue *txq = dev->data->tx_queues[i];
> >> +if (txq == NULL)
> >> +continue;
> >> +
> >> +stats->opackets += txq->packets;
> >> +stats->obytes += txq->bytes;
> >> +stats->oerrors += txq->errors;
> >> +}
> >> +
> >> +for (i = 0; i < dev->data->nb_rx_queues; i++) {
> >> +struct gve_rx_queue *rxq = dev->data->rx_queues[i];
> >> +if (rxq == NULL)
> >> +continue;
> >> +
> >> +stats->ipackets += rxq->packets;
> >> +stats->ibytes += rxq->bytes;
> >> +stats->ierrors += rxq->errors;
> >> +stats->rx_nombuf += rxq->no_mbufs;
> >> +}
> >> +
> >> +return 0;
> >> +}
> >> +
> >
> > The driver should be filling in the per-queue stats as well.
> > q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors
>
>
> Hi Stephen,
>
> Queue stats moved to xstats, and there is a long term goal to move all
> queue stats from basic stats to xstats for all PMDs, and remove interim
> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
>
> That is why request to new PMDs is to not introduce queue stats in basic
> stats, but in xstats.
