[PATCH v4] doc: support IPsec Multi-buffer lib v1.3

2022-11-12 Thread Pablo de Lara 
Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G
and CHACHA20_POLY1305 PMD documentation guides
with information about the latest Intel IPSec Multi-buffer
library supported.

Signed-off-by: Pablo de Lara 
Acked-by: Ciara Power 
Acked-by: Brian Dooley 

---
-v4: Added information on CHACHA20_POLY1305 PMD guide
-v3: Fixed library version from 1.2 to 1.3 in one line
-v2: Removed repeated word 'the'
---
 doc/guides/cryptodevs/aesni_gcm.rst |  8 +++---
 doc/guides/cryptodevs/aesni_mb.rst  | 29 -
 doc/guides/cryptodevs/chacha20_poly1305.rst | 12 ++---
 doc/guides/cryptodevs/kasumi.rst| 15 ---
 doc/guides/cryptodevs/snow3g.rst| 15 ---
 doc/guides/cryptodevs/zuc.rst   | 14 +++---
 6 files changed, 67 insertions(+), 26 deletions(-)

diff --git a/doc/guides/cryptodevs/aesni_gcm.rst 
b/doc/guides/cryptodevs/aesni_gcm.rst
index 6229392f58..5192287ed8 100644
--- a/doc/guides/cryptodevs/aesni_gcm.rst
+++ b/doc/guides/cryptodevs/aesni_gcm.rst
@@ -40,8 +40,8 @@ Installation
 To build DPDK with the AESNI_GCM_PMD the user is required to download the 
multi-buffer
 library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.2, which
-can be downloaded in 
``_.
+The latest version of the library supported by this PMD is v1.3, which
+can be downloaded in 
``_.
 
 .. code-block:: console
 
@@ -84,8 +84,8 @@ and the external crypto libraries supported by them:
17.08 - 18.02  Multi-buffer library 0.46 - 0.48
18.05 - 19.02  Multi-buffer library 0.49 - 0.52
19.05 - 20.08  Multi-buffer library 0.52 - 0.55
-   20.11 - 21.08  Multi-buffer library 0.53 - 1.2*
-   21.11+ Multi-buffer library 1.0  - 1.2*
+   20.11 - 21.08  Multi-buffer library 0.53 - 1.3*
+   21.11+ Multi-buffer library 1.0  - 1.3*
=  
 
 \* Multi-buffer library 1.0 or newer only works for Meson but not Make build 
system.
diff --git a/doc/guides/cryptodevs/aesni_mb.rst 
b/doc/guides/cryptodevs/aesni_mb.rst
index 599ed5698f..b9bf03655d 100644
--- a/doc/guides/cryptodevs/aesni_mb.rst
+++ b/doc/guides/cryptodevs/aesni_mb.rst
@@ -1,7 +1,7 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
 Copyright(c) 2015-2018 Intel Corporation.
 
-AESN-NI Multi Buffer Crypto Poll Mode Driver
+AES-NI Multi Buffer Crypto Poll Mode Driver
 
 
 
@@ -10,8 +10,6 @@ support for utilizing Intel multi buffer library, see the 
white paper
 `Fast Multi-buffer IPsec Implementations on Intel® Architecture Processors
 
`_.
 
-The AES-NI MB PMD has current only been tested on Fedora 21 64-bit with gcc.
-
 The AES-NI MB PMD supports synchronous mode of operation with
 ``rte_cryptodev_sym_cpu_crypto_process`` function call.
 
@@ -77,6 +75,23 @@ Limitations
 * RTE_CRYPTO_CIPHER_DES_DOCSISBPI is not supported for combined Crypto-CRC
   DOCSIS security protocol.
 
+AESNI MB PMD selection over SNOW3G/ZUC/KASUMI PMDs
+--
+
+This PMD supports wireless cipher suite (SNOW3G, ZUC and KASUMI).
+On Intel processors, it is recommended to use this PMD instead of SNOW3G, ZUC 
and KASUMI PMDs,
+as it enables algorithm mixing (e.g. cipher algorithm SNOW3G-UEA2 with
+authentication algorithm AES-CMAC-128) and performance over IMIX (packet size 
mix) traffic
+is significantly higher.
+
+AESNI MB PMD selection over CHACHA20-POLY1305 PMD
+-
+
+This PMD supports Chacha20-Poly1305 algorithm.
+On Intel processors, it is recommended to use this PMD instead of 
CHACHA20-POLY1305 PMD,
+as it delivers better performance on single segment buffers.
+For multi-segment buffers, it is still recommended to use CHACHA20-POLY1305 
PMD,
+until the new SGL API is introduced in the AESNI MB PMD.
 
 Installation
 
@@ -84,8 +99,8 @@ Installation
 To build DPDK with the AESNI_MB_PMD the user is required to download the 
multi-buffer
 library from `here `_
 and compile it on their user system before building DPDK.
-The latest version of the library supported by this PMD is v1.2, which
-can be downloaded from 
``_.
+The latest version of the library supported by this PMD is v1.3, which
+can be downloaded from 
``_.
 
 .. code-block:: console
 
@@ -130,8 +145,8 @@ and the Multi-Buffer library version supported by them:
18.05 - 19.02   0.49 - 0.52
19.05 - 19.08   0.52
19.11 - 20.08   0.52 -

[Bug 1125] i40e: Tx offload for outer UDP checksum is advertised but in fact unsupported

2022-11-12 Thread bugzilla 
https://bugs.dpdk.org/show_bug.cgi?id=1125

Bug ID: 1125
   Summary: i40e: Tx offload for outer UDP checksum is advertised
but in fact unsupported
   Product: DPDK
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: ethdev
  Assignee: dev@dpdk.org
  Reporter: ivan.ma...@oktetlabs.ru
  Target Milestone: ---

In the opensource ethdev verification suite [1], there is a test,
xmit/one_packet, which is tailored specifically for Tx offload checks. In the
case of i40e, the test finds a bug in encap. TSO support.

As shown in [2], a VXLAN packet with TSO request is transmitted, and resulting
packets mismatch because of the wrong checksum in the outer UDP header (it is
the same as the one in the original superframe). However, since the test sees
capability bit TX_OFFLOAD_OUTER_UDP_CKSUM in device info, the checksum is
expected to be offloaded.

According to Intel(R) Ethernet Controller X710/ XXV710/XL710 Datasheet, section
8.4.4.2, "Tunneling UDP headers and GRE header are not offloaded while the
X710/XXV710/XL710 leaves their checksum field as is". That means the i40e PMD
shall not advertise TX_OFFLOAD_OUTER_UDP_CKSUM capability via device info API.

[1] https://mails.dpdk.org/archives/dev/2022-October/251663.html
[2] https://ts-factory.io/bublik/v2/log/163204?focusId=165783&mode=treeAndlog

-- 
You are receiving this mail because:
You are the assignee for the bug.

[PATCH v8] testpmd: cleanup cleanly from signal

2022-11-12 Thread Stephen Hemminger 
Do a clean shutdown of testpmd when a signal is received;
instead of having testpmd kill itself.
This fixes the problem where a signal could be received
in the middle of a PMD and then the signal handler would call
PMD's close routine leading to locking problems.

An added benefit is it gets rid of some Windows specific code.

Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container")
Signed-off-by: Stephen Hemminger 
---
v8 - fix build on Windows (again)
 Windows doesn't have FILENO_STDIN

 app/test-pmd/testpmd.c | 67 +++---
 1 file changed, 31 insertions(+), 36 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index aa7ea29f15ba..b4fb6a2bcbcf 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -11,6 +11,7 @@
 #include 
 #ifndef RTE_EXEC_ENV_WINDOWS
 #include 
+#include 
 #endif
 #include 
 #include 
@@ -4224,13 +4225,6 @@ init_port(void)
memset(txring_numa, NUMA_NO_CONFIG, RTE_MAX_ETHPORTS);
 }
 
-static void
-force_quit(void)
-{
-   pmd_test_exit();
-   prompt_exit();
-}
-
 static void
 print_stats(void)
 {
@@ -4249,28 +4243,9 @@ print_stats(void)
 }
 
 static void
-signal_handler(int signum)
+signal_handler(int signum __rte_unused)
 {
-   if (signum == SIGINT || signum == SIGTERM) {
-   fprintf(stderr, "\nSignal %d received, preparing to exit...\n",
-   signum);
-#ifdef RTE_LIB_PDUMP
-   /* uninitialize packet capture framework */
-   rte_pdump_uninit();
-#endif
-#ifdef RTE_LIB_LATENCYSTATS
-   if (latencystats_enabled != 0)
-   rte_latencystats_uninit();
-#endif
-   force_quit();
-   /* Set flag to indicate the force termination. */
-   f_quit = 1;
-   /* exit with the expected status */
-#ifndef RTE_EXEC_ENV_WINDOWS
-   signal(signum, SIG_DFL);
-   kill(getpid(), signum);
-#endif
-   }
+   f_quit = 1;
 }
 
 int
@@ -4449,9 +4424,6 @@ main(int argc, char** argv)
} else
 #endif
{
-   char c;
-   int rc;
-
f_quit = 0;
 
printf("No commandline core given, start packet forwarding\n");
@@ -4476,15 +4448,38 @@ main(int argc, char** argv)
prev_time = cur_time;
rte_delay_us_sleep(US_PER_S);
}
-   }
+   } else {
+   char c;
+   fd_set fds;
+
+   printf("Press enter to exit\n");
+
+   FD_ZERO(&fds);
+   FD_SET(0, &fds);
 
-   printf("Press enter to exit\n");
-   rc = read(0, &c, 1);
+   ret = select(1, &fds, NULL, NULL, NULL);
+   if (ret < 0 && errno != EINTR)
+   rte_exit(EXIT_FAILURE,
+"Select failed: %s\n",
+strerror(errno));
+
+   if (ret == 1 && read(0, &c, 1) < 0)
+   rte_exit(EXIT_FAILURE,
+"Read failed: %s\n",
+strerror(errno));
+   }
pmd_test_exit();
-   if (rc < 0)
-   return 1;
}
 
+#ifdef RTE_LIB_PDUMP
+   /* uninitialize packet capture framework */
+   rte_pdump_uninit();
+#endif
+#ifdef RTE_LIB_LATENCYSTATS
+   if (latencystats_enabled != 0)
+   rte_latencystats_uninit();
+#endif
+
ret = rte_eal_cleanup();
if (ret != 0)
rte_exit(EXIT_FAILURE,
-- 
2.35.1