date:20221029

DPDK main build is broken for me in net/mlx5 if I disable common/mlx5

2022-10-29 Thread Andrew Rybchenko


Hi,

DPDK main build is broken for me in net/mlx5 if I disable common/mlx5

../src/drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable 
"mlx5_config".


It worked for me before and net/mlx5 is not built since common driver is 
missing.


Andrew.

Re: [PATCH v6 1/1] baseband/acc100: add workaround for deRM corner cases

2022-10-29 Thread Tom Rix




On 10/25/22 8:01 AM, Chautru, Nicolas wrote:

Hi Maxime,


-Original Message-
From: Maxime Coquelin 
Sent: Tuesday, October 25, 2022 1:26 AM
To: Vargas, Hernan ; dev@dpdk.org;
gak...@marvell.com; t...@redhat.com
Cc: Chautru, Nicolas ; Zhang, Qi Z
; David Marchand ;
Thomas Monjalon 
Subject: Re: [PATCH v6 1/1] baseband/acc100: add workaround for deRM
corner cases

Hi Hernan,

On 10/25/22 04:38, Hernan Vargas wrote:

Add function to support de-ratematch pre-processing for SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure
and in some cases a potential stability issue on the ACC100.
To be able to avoid completely such potential issue, the PMD can
preempt such code block configuration so that to process the first
level deRM in SW using the SDK libraries prior to running the rest of
the FEC decoding in HW using an amended code block configuration.
In case meson build system doesn't find such SDK libraries, the fall
method is to run in HW with a warning.

Signed-off-by: Hernan Vargas 
---
   drivers/baseband/acc/acc_common.h |   8 ++
   drivers/baseband/acc/meson.build  |  21 +
   drivers/baseband/acc/rte_acc100_pmd.c | 108

+-

   3 files changed, 134 insertions(+), 3 deletions(-)

diff --git a/drivers/baseband/acc/acc_common.h
b/drivers/baseband/acc/acc_common.h
index eae7eab4e9..5e8972b40a 100644
--- a/drivers/baseband/acc/acc_common.h
+++ b/drivers/baseband/acc/acc_common.h
@@ -123,6 +123,14 @@
   #define ACC_HARQ_ALIGN_64B  64
   #define ACC_MAX_ZC  384

+/* De-ratematch code rate limitation when padding is required */
+#define ACC_LIM_03 2  /* 0.03 */ #define ACC_LIM_09 6  /* 0.09 */
+#define ACC_LIM_14 9  /* 0.14 */ #define ACC_LIM_21 14 /* 0.21 */
+#define ACC_LIM_31 20 /* 0.31 */ #define ACC_MAX_E (128 * 1024 - 2)
+
   /* Helper macro for logging */
   #define rte_acc_log(level, fmt, ...) \
rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ diff --git
a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build
index 77c393b533..a5fc4fed01 100644
--- a/drivers/baseband/acc/meson.build
+++ b/drivers/baseband/acc/meson.build
@@ -1,6 +1,27 @@
   # SPDX-License-Identifier: BSD-3-Clause
   # Copyright(c) 2020 Intel Corporation

+# Check for FlexRAN SDK libraries
+dep_dec5g = dependency('flexran_sdk_ldpc_decoder_5gnr', required:
+false)
+
+if dep_dec5g.found()
+ext_deps += cc.find_library('libstdc++', required: true)
+ext_deps += cc.find_library('libirc', required: true)
+ext_deps += cc.find_library('libimf', required: true)
+ext_deps += cc.find_library('libipps', required: true)
+ext_deps += cc.find_library('libsvml', required: true)
+ext_deps += dep_dec5g
+ext_deps += dependency('flexran_sdk_ldpc_encoder_5gnr', required:

true)

+ext_deps += dependency('flexran_sdk_LDPC_ratematch_5gnr', required:

true)

+ext_deps += dependency('flexran_sdk_rate_dematching_5gnr', required:

true)

+ext_deps += dependency('flexran_sdk_turbo', required: true)
+ext_deps += dependency('flexran_sdk_crc', required: true)
+ext_deps += dependency('flexran_sdk_rate_matching', required: true)
+ext_deps += dependency('flexran_sdk_common', required: true)
+cflags += ['-DRTE_BBDEV_SDK_AVX2']
+cflags += ['-DRTE_BBDEV_SDK_AVX512'] endif
+
   deps += ['bbdev', 'bus_pci']

   sources = files('rte_acc100_pmd.c', 'rte_acc200_pmd.c') diff --git
a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index 23bc5d25bb..e8b230e563 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -25,6 +25,10 @@
   #include "acc101_pmd.h"
   #include "acc200_cfg.h"

+#ifdef RTE_BBDEV_SDK_AVX512
+#include  #endif
+
   #ifdef RTE_LIBRTE_BBDEV_DEBUG
   RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
   #else
@@ -756,6 +760,14 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

ret = -ENOMEM;
goto free_lb_out;
}
+   q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
+   RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
+   RTE_CACHE_LINE_SIZE, conf->socket);
+   if (q->derm_buffer == NULL) {
+   rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
+   ret = -ENOMEM;
+   goto free_companion_ring_addr;
+   }

/*
 * Software queue ring wraps synchronously with the HW when it
reaches @@ -776,7 +788,7 @@ acc100_queue_setup(struct rte_bbdev *dev,

uint16_t queue_id,

q_idx = acc100_find_free_queue_idx(dev, conf);
if (q_idx == -1) {
ret = -EINVAL;
-   goto free_companion_ring_addr;
+   goto free_derm_buffer;
}

q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF; @@ -804,6

+816,9

@@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id,
dev->data->queues[queue_id].queue_pri

Re: [PATCH v15 00/18] add support for idpf PMD in DPDK

2022-10-29 Thread Andrew Rybchenko


On 10/29/22 06:27, beilei.x...@intel.com wrote:

From: Beilei Xing 

This patchset introduced the idpf (Infrastructure Data Path Function) PMD in 
DPDK for Intel® IPU E2000 (Device ID: 0x1452).
The Intel® IPU E2000 targets to deliver high performance under real workloads 
with security and isolation.
Please refer to
https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html
for more information.

Linux upstream is still ongoing, previous work refers to 
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220128001009.721392-20-alan.br...@intel.com/.

v2-v4:
fixed some coding style issues and did some refactors.

v5:
fixed typo.

v6-v9:
fixed build errors and coding style issues.

v11:
  - move shared code to common/idpf/base
  - Create one vport if there's no vport devargs
  - Refactor if conditions according to coding style
  - Refactor virtual channel return values
  - Refine dev_stop function
  - Refine RSS lut/key
  - Fix build error

v12:
  - Refine dev_configure
  - Fix coding style according to the comments
  - Re-order patch
  - Romove dev_supported_ptypes_get

v13:
  - refine dev_start/stop and queue_start/stop
  - fix timestamp offload

v14:
  - fix wrong position for rte_validate_tx_offload

v15:
  - refine the return value for ethdev ops.
  - removce forward static declarations.
  - refine get caps.
  - fix lock/unlock handling.


Applied to dpdk-next-net/main, thanks.

I've a number of concerns:
 * conditional compilation IDPF_RX_PTYPE_OFFLOAD in [PATCH v15 17/18] 
net/idpf: add AVX512 data path for single queue model
 * the same prefix used for functions in common/idpf/base and net/idpf 
drivers
 * common/idpf/base uses own defines for negative errno (defined as a 
number with corresponding errno in a comment). Strictly speaking it is 
not the same, but work fine in a majority of cases


So, final decision will be done by Thomas on pulling to main tree.

[PATCH 0/2] fix build disabling common/mlx5

2022-10-29 Thread Thomas Monjalon

Andrew reported a build failure when disabling mlx5 common driver.
It is a blocker for -rc2 release.

While fixing the use of a variable across mlx5 drivers in first patch,
the consistency of its use is improved in a second patch.

Thomas Monjalon (2):
  net/mlx5: fix disabling common/mlx5 dependency
  common/mlx5: move Meson config initialization and check

 drivers/common/mlx5/linux/meson.build   | 2 --
 drivers/common/mlx5/meson.build | 2 ++
 drivers/common/mlx5/windows/meson.build | 4 
 drivers/net/mlx5/hws/meson.build| 4 
 drivers/net/mlx5/meson.build| 8 +---
 5 files changed, 11 insertions(+), 9 deletions(-)

-- 
2.36.1

[PATCH 1/2] net/mlx5: fix disabling common/mlx5 dependency

2022-10-29 Thread Thomas Monjalon

If the dependency common/mlx5 is explicitly disabled,
but net/mlx5 is not explictly disabled,
Meson will read the full recipe of net/mlx5
and will fail when accessing a variable from common/mlx5:
drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config".

The solution is to stop parsing net/mlx5 if common/mlx5 is disabled.
The deps array must be defined before stopping, in order to automatically
disable the build of net/mlx5 and print the reason.

Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering")

Reported-by: Andrew Rybchenko 
Signed-off-by: Thomas Monjalon 
---
 drivers/net/mlx5/meson.build | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index ff84448186..9a8eb0bc19 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -9,6 +9,10 @@ if not (is_linux or is_windows)
 endif
 
 deps += ['hash', 'common_mlx5']
+if not ('mlx5' in common_drivers)
+# avoid referencing undefined variables from common/mlx5
+subdir_done()
+endif
 headers = files('rte_pmd_mlx5.h')
 sources = files(
 'mlx5.c',
-- 
2.36.1

[PATCH 2/2] common/mlx5: move Meson config initialization and check

2022-10-29 Thread Thomas Monjalon

The variable mlx5_config may be used by other mlx5 drivers
and should be always initialized.
By moving its initialization (with configuration file generation),
it is made consistent for Linux and Windows builds.

And the check of mlx5_config in net/mlx5 is moved at the top of
net/mlx5/hws/meson.build so HWS requirements are in the right context.

Signed-off-by: Thomas Monjalon 
---
 drivers/common/mlx5/linux/meson.build   | 2 --
 drivers/common/mlx5/meson.build | 2 ++
 drivers/common/mlx5/windows/meson.build | 4 
 drivers/net/mlx5/hws/meson.build| 4 
 drivers/net/mlx5/meson.build| 4 +---
 5 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/common/mlx5/linux/meson.build 
b/drivers/common/mlx5/linux/meson.build
index 84e2a1ad8c..2b57b299bd 100644
--- a/drivers/common/mlx5/linux/meson.build
+++ b/drivers/common/mlx5/linux/meson.build
@@ -8,7 +8,6 @@ dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
 LIB_GLUE_BASE = 'librte_common_mlx5_glue.so'
 LIB_GLUE_VERSION = abi_version
 LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
-mlx5_config = configuration_data()
 if dlopen_ibverbs
 dpdk_conf.set('RTE_IBVERBS_LINK_DLOPEN', 1)
 cflags += [
@@ -232,7 +231,6 @@ foreach arg:has_member_args
 file_prefix = '#include <' + arg[1] + '>'
 mlx5_config.set(arg[0], cc.has_member(arg[2], arg[3], prefix : 
file_prefix, dependencies: libs))
 endforeach
-configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config)
 
 # Build Glue Library
 if dlopen_ibverbs
diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build
index 6ddbde7e8f..d7ca21d2cf 100644
--- a/drivers/common/mlx5/meson.build
+++ b/drivers/common/mlx5/meson.build
@@ -37,4 +37,6 @@ else
 cflags += [ '-UPEDANTIC' ]
 endif
 
+mlx5_config = configuration_data()
 subdir(exec_env)
+configure_file(output : 'mlx5_autoconf.h', configuration : mlx5_config)
diff --git a/drivers/common/mlx5/windows/meson.build 
b/drivers/common/mlx5/windows/meson.build
index edbbaa9ae1..cc486014a8 100644
--- a/drivers/common/mlx5/windows/meson.build
+++ b/drivers/common/mlx5/windows/meson.build
@@ -39,7 +39,3 @@ if get_option('buildtype').contains('debug')
 else
 cflags += [ '-UPEDANTIC' ]
 endif
-
-# Generate an empty mlx5_autoconf.h file for compatibility with Linux
-config = configuration_data()
-configure_file(output : 'mlx5_autoconf.h', configuration : config)
diff --git a/drivers/net/mlx5/hws/meson.build b/drivers/net/mlx5/hws/meson.build
index d2bb864fd2..38776d5163 100644
--- a/drivers/net/mlx5/hws/meson.build
+++ b/drivers/net/mlx5/hws/meson.build
@@ -1,6 +1,10 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright (c) 2022 NVIDIA Corporation & Affiliates
 
+if not (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false))
+subdir_done()
+endif
+
 includes += include_directories('.')
 sources += files(
 'mlx5dr_context.c',
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 9a8eb0bc19..66b23f5584 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -77,6 +77,4 @@ testpmd_sources += files('mlx5_testpmd.c')
 
 subdir(exec_env)
 
-if (is_linux and mlx5_config.get('HAVE_IBV_FLOW_DV_SUPPORT', false))
-subdir('hws')
-endif
+subdir('hws')
-- 
2.36.1

DPDK main build is broken for me in net/mlx5 if I disable common/mlx5

Re: [PATCH v6 1/1] baseband/acc100: add workaround for deRM corner cases

Re: [PATCH v15 00/18] add support for idpf PMD in DPDK

[PATCH 0/2] fix build disabling common/mlx5

[PATCH 1/2] net/mlx5: fix disabling common/mlx5 dependency

[PATCH 2/2] common/mlx5: move Meson config initialization and check

6 matches

Site Navigation

Mail list logo

Footer information