Re: [PATCH] gro: fix gro with tcp push flag

[kumaraparameshwaran rathinavel]

We should do it for the rte_gro_reassemble as well, with timer mode it
could lead to more duplicate ACKs. I had a proposal for the enhancement
which would handle both  rte_gro_reassemble and rte_gro_reassemble_burst
but have not got any response yet.

I have a custom patch which is working fine for timer mode where there is
no packet reordering, earlier without the patch there were DUP-ACKs and
this could potentially affect the window scaling.

On Tue, Jul 26, 2022 at 12:27 PM Jun Qiu  wrote:

> May be in rte_gro_reassemble_burst, where no delay is introduced, PUSH
> packets can be merged
>
>
>
> *发件人:* kumaraparameshwaran rathinavel 
> *发送时间:* 2022年7月26日 14:41
> *收件人:* Jun Qiu 
> *抄送:* dev@dpdk.org; jiayu...@intel.com; sta...@dpdk.org
> *主题:* Re: [PATCH] gro: fix gro with tcp push flag
>
>
>
>
>
>
>
> On Tue, Jul 26, 2022 at 11:48 AM Jun Qiu  wrote:
>
> TCP data packets sometimes carry a PUSH flag. Currently,
> only the packets that do not have PUSH flag can be GROed.
> The packets that have a PUSH flag cannot be GROed, the packets
> that cannot be processed by GRO are placed last.
> In this case, the received packets may be out of order.
> For example, there are two packets mbuf1 and mbuf2. mbuf1
> contains PUSH flag, mbuf2 does not contain PUSH flag.
> After GRO processing, mbuf2 is sent for processing before mbuf1.
> This out-of-order will affect TCP processing performance and
> lead to unnecessary dup-ACK.
>
> Referring to the Linux kernel implementation, packets with PUSH
> flag can also perform GRO. And if one of the packets containing
> PUSH flag, the packets after GRO will carry PUSH flag.
>
>
>
> In case of smaller transfers in which the TCP segment size is not more
> than one MTU, it is a single TCP packet with PSH flag set, so in those
> cases  we are introducing unwanted delay.  I think the better approach
> would be if there are previous packets in the flow and the current packet
> received has PSH flag then coalesce with the previous packet, if lookup is
> failure and the current packet has PSH flag set then deliver it
> immediately.
>
>
>
> Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jun Qiu 
> ---
>  lib/gro/gro_tcp4.c   |  4 ++--
>  lib/gro/gro_tcp4.h   | 16 +---
>  lib/gro/gro_vxlan_tcp4.c |  4 ++--
>  3 files changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c
> index 7498c66141..7849a2bd1d 100644
> --- a/lib/gro/gro_tcp4.c
> +++ b/lib/gro/gro_tcp4.c
> @@ -220,10 +220,10 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
> hdr_len = pkt->l2_len + pkt->l3_len + pkt->l4_len;
>
> /*
> -* Don't process the packet which has FIN, SYN, RST, PSH, URG, ECE
> +* Don't process the packet which has FIN, SYN, RST, URG, ECE
>  * or CWR set.
>  */
> -   if (tcp_hdr->tcp_flags != RTE_TCP_ACK_FLAG)
> +   if (tcp_hdr->tcp_flags & (~(RTE_TCP_ACK_FLAG | RTE_TCP_PSH_FLAG)))
> return -1;
> /*
>  * Don't process the packet whose payload length is less than or
> diff --git a/lib/gro/gro_tcp4.h b/lib/gro/gro_tcp4.h
> index 212f97a042..2974faf228 100644
> --- a/lib/gro/gro_tcp4.h
> +++ b/lib/gro/gro_tcp4.h
> @@ -210,7 +210,8 @@ merge_two_tcp4_packets(struct gro_tcp4_item *item,
> uint16_t l2_offset)
>  {
> struct rte_mbuf *pkt_head, *pkt_tail, *lastseg;
> -   uint16_t hdr_len, l2_len;
> +   struct rte_tcp_hdr *head_tcp_hdr, *tail_tcp_hdr;
> +   uint16_t hdr_len, l2_len, l3_offset;
>
> if (cmp > 0) {
> pkt_head = item->firstseg;
> @@ -221,13 +222,22 @@ merge_two_tcp4_packets(struct gro_tcp4_item *item,
> }
>
> /* check if the IPv4 packet length is greater than the max value */
> -   hdr_len = l2_offset + pkt_head->l2_len + pkt_head->l3_len +
> -   pkt_head->l4_len;
> +   l3_offset = l2_offset + pkt_head->l2_len + pkt_head->l3_len;
> +   hdr_len = l3_offset + pkt_head->l4_len;
> l2_len = l2_offset > 0 ? pkt_head->outer_l2_len : pkt_head->l2_len;
> if (unlikely(pkt_head->pkt_len - l2_len + pkt_tail->pkt_len -
> hdr_len > MAX_IPV4_PKT_LENGTH))
> return 0;
>
> +   /* merge push flag to pkt_head */
> +   tail_tcp_hdr = rte_pktmbuf_mtod_offset(pkt_tail,
> +   struct rte_tcp_hdr *, l3_offset);
> +   if (tail_tcp_hdr->tcp_flags & RTE_TCP_PSH_FLAG) {
> +   head_tcp_hdr = rte_pktmbuf_mtod_offset(pkt_head,
> +   struct rte_tcp_hdr *, l3_offset);
> +   head_tcp_hdr->tcp_flags |= RTE_TCP_PSH_FLAG;
> +   }
> +
> /* remove the packet header for the tail packet */
> rte_pktmbuf_adj(pkt_tail, hdr_len);
>
> diff --git a/lib/gro/gro_vxlan_tcp4.c b/lib/gro/gro_vxlan_tcp4.c
> index 3be4deb7c7..884802af0b 100644
> --- a/lib/gro/gro_vxlan_tcp4.c
> +++ b/lib/gro/gro

Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation

[Maxime Coquelin]

On 7/25/22 22:32, David Marchand wrote:

translate_ring_addresses (via numa_realloc) may change a virtio device and
virtio queue.
The virtqueue object must be refreshed before accessing the lock.

Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications")
Cc: sta...@dpdk.org

Signed-off-by: David Marchand 
---
  lib/vhost/vhost_user.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 4ad28bac45..91d40e32fc 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2596,6 +2596,7 @@ vhost_user_iotlb_msg(struct virtio_net **pdev,
if (is_vring_iotlb(dev, vq, imsg)) {
rte_spinlock_lock(&vq->access_lock);
*pdev = dev = translate_ring_addresses(dev, i);
+   vq = dev->virtqueue[i];
rte_spinlock_unlock(&vq->access_lock);
}
}


Reviewed-by: Maxime Coquelin 

Thanks,
Maxime

Re: [PATCH v3 2/4] vhost: make NUMA reallocation code more robust

[Maxime Coquelin]

On 7/25/22 22:32, David Marchand wrote:

translate_ring_addresses and numa_realloc may change a virtio device and
virtio queue. Callers of those helpers must be extra careful and refresh
any reference to old data.

Change those functions prototype as a way to hint about this issue and
always ask for an indirect pointer.

Besides, when reallocating the device and queue, the code already made
sure it will return a pointer to a valid device. The checks on such
returned pointer can be removed.

Signed-off-by: David Marchand 
---
  lib/vhost/vhost_user.c | 144 +++--
  1 file changed, 66 insertions(+), 78 deletions(-)



Reviewed-by: Maxime Coquelin 

Thanks,
Maxime

Re: [PATCH v2] examples/dma: support DMA dequeue when no packet received

[Kevin Laatz]

On 25/07/2022 13:22, Chengwen Feng wrote:

Currently the example using DMA in asynchronous mode, which are:
nb_rx = rte_eth_rx_burst();
if (nb_rx == 0)
continue;
...
dma_enqueue(); // enqueue the received packets copy request
nb_cpl = dma_dequeue(); // get copy completed packets
...

There are no waiting inside dma_dequeue(), and this is why it's called
asynchronus. If there are no packet received, it won't call
dma_dequeue(), but some packets may still in the DMA queue which
enqueued in last cycle. As a result, when the traffic is stopped, the
sent packets and received packets are unbalanced from the perspective
of the traffic generator.

The patch supports DMA dequeue when no packet received, it helps to
judge the test result by comparing the sent packets with the received
packets on traffic generator sides.

Signed-off-by: Chengwen Feng 
---
  examples/dma/dmafwd.c | 8 +++-
  1 file changed, 7 insertions(+), 1 deletion(-)


Acked-by: Kevin Laatz 

Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index

[Maxime Coquelin]

On 7/25/22 22:32, David Marchand wrote:

Having a back reference to the index of the vq in the dev->virtqueue[]
array makes it possible to unify the internal API, with only passing dev
and vq.
It also allows displaying the vq index in log messages.

Remove virtqueue index checks where unneeded (like in static helpers
called from a loop on all available virtqueue).
Move virtqueue index validity checks the sooner possible.

Signed-off-by: David Marchand 
---
Changes since v2:
- rebased on top of cleanup that avoids some use-after-free issues in
   case of allocation failures or numa realloactions,

Changes since v1:
- fix vq init (that's what happens when only recompiling the vhost
   library and not relinking testpmd...),

---
  lib/vhost/iotlb.c  |  5 +--
  lib/vhost/iotlb.h  |  2 +-
  lib/vhost/vhost.c  | 72 +--
  lib/vhost/vhost.h  |  3 ++
  lib/vhost/vhost_user.c | 46 +++---
  lib/vhost/virtio_net.c | 86 +++---
  6 files changed, 91 insertions(+), 123 deletions(-)



...


diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 35fa4670fd..467dfb203f 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c


...


@@ -2275,12 +2267,11 @@ rte_vhost_clear_queue(int vid, uint16_t queue_id, 
struct rte_mbuf **pkts,
}
  
  	if ((queue_id & 1) == 0)

-   n_pkts_cpl = vhost_poll_enqueue_completed(dev, queue_id,
-   pkts, count, dma_id, vchan_id);
-   else {
+   n_pkts_cpl = vhost_poll_enqueue_completed(dev, vq, pkts, count,
+   dma_id, vchan_id);
+   else
n_pkts_cpl = async_poll_dequeue_completed(dev, vq, pkts, count,
-   dma_id, vchan_id, dev->flags & 
VIRTIO_DEV_LEGACY_OL_FLAGS);
-   }
+   dma_id, vchan_id, dev->flags & 
VIRTIO_DEV_LEGACY_OL_FLAGS);


One of the two functions should be renamed for consistency, but that's
not the point of this series.

For this patch:

Reviewed-by: Maxime Coquelin 

Thanks,
Maxime

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

[Devendra Singh Rawat]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Rasesh Mody
> ; Devendra Singh Rawat 
> Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be'
> 
> External Email
> 
> --
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  drivers/net/qede/qede_filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
> index ca3165d97210..24035b64e7a1 100644
> --- a/drivers/net/qede/qede_filter.c
> +++ b/drivers/net/qede/qede_filter.c
> @@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
> 
>   qdev->vxlan.udp_port = udp_port;
>   /* If the request is to delete UDP port and if the number of
> -  * VXLAN filters have reached 0 then VxLAN offload can be be
> +  * VXLAN filters have reached 0 then VxLAN offload can be
>* disabled.
>*/
>   if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
> @@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
> 
>   qdev->vxlan.udp_port = udp_port;
>   /* If the request is to delete UDP port and if the number of
> -  * GENEVE filters have reached 0 then GENEVE offload can be
> be
> +  * GENEVE filters have reached 0 then GENEVE offload can be
>* disabled.
>*/
>   if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
> --
> 2.35.1

Acked-by: Devendra Singh Rawat 

Thanks

Re: [PATCH v3 4/4] vhost: stop using mempool for IOTLB cache

[Maxime Coquelin]

On 7/25/22 22:32, David Marchand wrote:

A mempool consumes 3 memzones (with the default ring mempool driver).
The default DPDK configuration allows RTE_MAX_MEMZONE (2560) memzones.

Assuming there is no other memzones that means that we can have a
maximum of 853 mempools.

In the vhost library, the IOTLB cache code so far was requesting a
mempool per vq, which means that at the maximum, the vhost library
could request mempools for 426 qps.

This limit was recently reached on big systems with a lot of virtio
ports (and multiqueue in use).

While the limit on mempool count could be something we fix at the DPDK
project level, there is no reason to use mempools for the IOTLB cache:
- the IOTLB cache entries do not need to be DMA-able and are only used
   by the current process (in multiprocess context),
- getting/putting objects from/in the mempool is always associated with
   some other locks, so some level of lock contention is already present,

We can convert to a malloc'd pool with objects put in a free list
protected by a spinlock.

Signed-off-by: David Marchand 
---
  lib/vhost/iotlb.c | 102 --
  lib/vhost/iotlb.h |   1 +
  lib/vhost/vhost.c |   2 +-
  lib/vhost/vhost.h |   4 +-
  4 files changed, 67 insertions(+), 42 deletions(-)



Thanks for working on this, this is definitely not needed to use mempool
for this.

Reviewed-by: Maxime Coquelin 

Maxime

[dpdk-dev v1] crypto/qat: add in libcrypto version check

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji 
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
 # version comes with quotes, so we split based on " and take the middle
 imb_ver = cc.get_define('IMB_VERSION_STR',
 prefix : '#include').split('"')[1]
-- 
2.17.1

Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index

[David Marchand]

On Tue, Jul 26, 2022 at 10:52 AM Maxime Coquelin
 wrote:
> > @@ -2275,12 +2267,11 @@ rte_vhost_clear_queue(int vid, uint16_t queue_id, 
> > struct rte_mbuf **pkts,
> >   }
> >
> >   if ((queue_id & 1) == 0)
> > - n_pkts_cpl = vhost_poll_enqueue_completed(dev, queue_id,
> > - pkts, count, dma_id, vchan_id);
> > - else {
> > + n_pkts_cpl = vhost_poll_enqueue_completed(dev, vq, pkts, 
> > count,
> > + dma_id, vchan_id);
> > + else
> >   n_pkts_cpl = async_poll_dequeue_completed(dev, vq, pkts, 
> > count,
> > - dma_id, vchan_id, dev->flags & 
> > VIRTIO_DEV_LEGACY_OL_FLAGS);
> > - }
> > + dma_id, vchan_id, dev->flags & 
> > VIRTIO_DEV_LEGACY_OL_FLAGS);
>
> One of the two functions should be renamed for consistency, but that's
> not the point of this series.

The async prefix makes sense, so renaming vhost_poll_enqueue_completed
as async_poll_enqueue_completed seems the way to go.
I don't mind sending a separate patch for this.


-- 
David Marchand

[dpdk-dev v2] crypto/qat: add in libcrypto version check

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES calculation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji 
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
 # version comes with quotes, so we split based on " and take the middle
 imb_ver = cc.get_define('IMB_VERSION_STR',
 prefix : '#include').split('"')[1]
-- 
2.17.1

RE: [EXT] [PATCH v2 09/20] remove repeated word 'only'

[Rasesh Mody]

> From: Stephen Hemminger 
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Rasesh Mody
> ; Shahed Shaikh 
> Subject: [EXT] [PATCH v2 09/20] remove repeated word 'only'
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger 

Acked-by: Rasesh Mody 

Thanks!
-Rasesh
> ---
>  drivers/net/bnx2x/bnx2x.c  | 2 +-
>  drivers/net/pcap/pcap_ethdev.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index
> 74e3018eab6f..29c16bb207c7 100644
> --- a/drivers/net/bnx2x/bnx2x.c
> +++ b/drivers/net/bnx2x/bnx2x.c
> @@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct
> bnx2x_softc *sc, uint32_t resource)
> 
>  /*
>   * Get the recovery leader resource id according to the engine this function
> - * belongs to. Currently only only 2 engines is supported.
> + * belongs to. Currently only 2 engines are supported.
>   */
>  static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)  { diff --
> git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
> index ec29fd6bc53c..bcb02ca0638e 100644
> --- a/drivers/net/pcap/pcap_ethdev.c
> +++ b/drivers/net/pcap/pcap_ethdev.c
> @@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
>   internals->if_index =
>   osdep_iface_index_get(rx_queues-
> >queue[0].name);
> 
> - /* phy_mac arg is applied only only if "iface" devarg is
> provided */
> + /* phy_mac arg is applied only if "iface" devarg is provided */
>   if (rx_queues->phy_mac) {
>   if (eth_pcap_update_mac(rx_queues-
> >queue[0].name,
>   eth_dev, vdev->device.numa_node)
> == 0)
> --
> 2.35.1

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

[Rasesh Mody]

> From: Stephen Hemminger 
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Rasesh Mody
> ; Devendra Singh Rawat 
> Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be'
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger 

Acked-by: Rasesh Mody 

Thanks!
-Rasesh
> ---
>  drivers/net/qede/qede_filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
> index ca3165d97210..24035b64e7a1 100644
> --- a/drivers/net/qede/qede_filter.c
> +++ b/drivers/net/qede/qede_filter.c
> @@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev
> *eth_dev,
> 
>   qdev->vxlan.udp_port = udp_port;
>   /* If the request is to delete UDP port and if the number of
> -  * VXLAN filters have reached 0 then VxLAN offload can be
> be
> +  * VXLAN filters have reached 0 then VxLAN offload can be
>* disabled.
>*/
>   if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
> @@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev
> *eth_dev,
> 
>   qdev->vxlan.udp_port = udp_port;
>   /* If the request is to delete UDP port and if the number of
> -  * GENEVE filters have reached 0 then GENEVE offload can be
> be
> +  * GENEVE filters have reached 0 then GENEVE offload can be
>* disabled.
>*/
>   if (qdev->geneve.enable && qdev->geneve.num_filters ==
> 0)
> --
> 2.35.1

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

[Akhil Goyal]

Hi Kai,

This is a fix for compilation when openssl 1.1 is used to build QAT.
Can you update the title to
Crypto/qat: fix build with OpenSSL 1.1

> This patch add in libcrypto version check before enable libipsec-mb for
> QAT. The inter-ipsec-mb lib for partial hash and AES cacluation should
> only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
> on the system.

Spell check on description.

> 
> Signed-off-by: Kai Ji 
> ---
>  drivers/common/qat/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/common/qat/meson.build
> b/drivers/common/qat/meson.build
> index 245c0fbe61..8247bdd017 100644
> --- a/drivers/common/qat/meson.build
> +++ b/drivers/common/qat/meson.build
> @@ -37,7 +37,9 @@ endif
> 
>  IMB_required_ver = '1.2.0'
>  libipsecmb = cc.find_library('IPSec_MB', required: false)
> -if libipsecmb.found()
> +libcrypto_3 = dependency('libcrypto', required: false,
> +method: 'pkg-config', version : '>=3.0.0')
> +if libipsecmb.found() and libcrypto_3.found()
>  # version comes with quotes, so we split based on " and take the middle
>  imb_ver = cc.get_define('IMB_VERSION_STR',
>  prefix : '#include').split('"')[1]
> --
> 2.17.1

[PATCH] test/crypto: add AES-CCM test vectors

[Anoob Joseph]

From: Archana Muniganti 

Added ESP tunnel mode known vectors for AES-CCM along with
combined mode support.

Signed-off-by: Archana Muniganti 
---
 app/test/test_cryptodev.c |   8 ++
 app/test/test_cryptodev_security_ipsec.c  |   3 +
 app/test/test_cryptodev_security_ipsec.h  |   5 +
 ...st_cryptodev_security_ipsec_test_vectors.h | 101 ++
 4 files changed, 117 insertions(+)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 69a0301de0..ee566a4ee3 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -15292,6 +15292,10 @@ static struct unit_test_suite ipsec_proto_testsuite  = 
{
"Outbound known vector (ESP tunnel mode IPv4 AES-GCM 
256)",
ut_setup_security, ut_teardown,
test_ipsec_proto_known_vec, &pkt_aes_256_gcm),
+   TEST_CASE_NAMED_WITH_DATA(
+   "Outbound known vector (ESP tunnel mode IPv4 AES-CCM 
256)",
+   ut_setup_security, ut_teardown,
+   test_ipsec_proto_known_vec, &pkt_aes_256_ccm),
TEST_CASE_NAMED_WITH_DATA(
"Outbound known vector (ESP tunnel mode IPv4 AES-CBC 
128 HMAC-SHA256 [16B ICV])",
ut_setup_security, ut_teardown,
@@ -15353,6 +15357,10 @@ static struct unit_test_suite ipsec_proto_testsuite  = 
{
"Inbound known vector (ESP tunnel mode IPv4 AES-GCM 
256)",
ut_setup_security, ut_teardown,
test_ipsec_proto_known_vec_inb, &pkt_aes_256_gcm),
+   TEST_CASE_NAMED_WITH_DATA(
+   "Inbound known vector (ESP tunnel mode IPv4 AES-CCM 
256)",
+   ut_setup_security, ut_teardown,
+   test_ipsec_proto_known_vec_inb, &pkt_aes_256_ccm),
TEST_CASE_NAMED_WITH_DATA(
"Inbound known vector (ESP tunnel mode IPv4 AES-CBC 
128)",
ut_setup_security, ut_teardown,
diff --git a/app/test/test_cryptodev_security_ipsec.c 
b/app/test/test_cryptodev_security_ipsec.c
index 6086055af1..3f691f0f56 100644
--- a/app/test/test_cryptodev_security_ipsec.c
+++ b/app/test/test_cryptodev_security_ipsec.c
@@ -392,6 +392,9 @@ test_ipsec_td_prepare(const struct crypto_param *param1,
else
memcpy(td, &pkt_aes_256_gcm, sizeof(*td));
 
+   if (param1->alg.aead == RTE_CRYPTO_AEAD_AES_CCM)
+   td->salt.len = 3;
+
td->aead = true;
td->xform.aead.aead.algo = param1->alg.aead;
td->xform.aead.aead.key.length = param1->key_length;
diff --git a/app/test/test_cryptodev_security_ipsec.h 
b/app/test/test_cryptodev_security_ipsec.h
index 744dd64a9e..02b08f9f95 100644
--- a/app/test/test_cryptodev_security_ipsec.h
+++ b/app/test/test_cryptodev_security_ipsec.h
@@ -132,6 +132,11 @@ static const struct crypto_param aead_list[] = {
{
.type = RTE_CRYPTO_SYM_XFORM_AEAD,
.alg.aead = RTE_CRYPTO_AEAD_AES_GCM,
+   .key_length = 32,
+   },
+   {
+   .type = RTE_CRYPTO_SYM_XFORM_AEAD,
+   .alg.aead = RTE_CRYPTO_AEAD_AES_CCM,
.key_length = 32
},
 };
diff --git a/app/test/test_cryptodev_security_ipsec_test_vectors.h 
b/app/test/test_cryptodev_security_ipsec_test_vectors.h
index 5c5b0445ee..5f775a241a 100644
--- a/app/test/test_cryptodev_security_ipsec_test_vectors.h
+++ b/app/test/test_cryptodev_security_ipsec_test_vectors.h
@@ -325,6 +325,107 @@ struct ipsec_test_data pkt_aes_256_gcm = {
},
 };
 
+struct ipsec_test_data pkt_aes_256_ccm = {
+   .key = {
+   .data = {
+   0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x68,
+   0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e, 0x6f, 0x70,
+   0x61, 0x62, 0x63, 0x64, 0x61, 0x62, 0x63, 0x64,
+   0x65, 0x66, 0x67, 0x68, 0x69, 0x6a, 0x6b, 0x6c,
+   },
+   },
+   .input_text = {
+   .data = {
+   /* IP */
+   0x45, 0x00, 0x00, 0x2E, 0x00, 0x01, 0x00, 0x00,
+   0x40, 0x11, 0x5F, 0xBC, 0x0D, 0x00, 0x00, 0x02,
+   0x0E, 0x00, 0x00, 0x01,
+
+   /* UDP */
+   0x04, 0x01, 0x04, 0x01, 0x00, 0x1A, 0xA0, 0x79,
+   0x78, 0x78, 0x78, 0x78, 0x78, 0x78, 0x78, 0x78,
+   0x78, 0x78, 0x78, 0x78, 0x78, 0x78, 0x78, 0x78,
+   0x78, 0x78,
+   },
+   .len = 46,
+   },
+   .output_text = {
+   .data = {
+   /* IP - outer header */
+   0x45, 0x00, 0x00, 0x64, 0x00, 0x01, 0x00, 0x00,
+  

[PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues

[huzaifa.rahman]

Bugzilla ID: 734

there's a bug in memif_stats_get() function due to confusion
between C2S (client->server) and S2C (server->client) rings,
causing a crash if there's a different number of RX and TX queues.

this is fixed by selectiing the correct rings for RX and TX i.e
for RX, S2C rings are selected and for TX, C2S rings are selected.

Signed-off-by: huzaifa.rahman 
---
 drivers/net/memif/rte_eth_memif.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/memif/rte_eth_memif.c 
b/drivers/net/memif/rte_eth_memif.c
index dd951b8296..e56df84e10 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1444,8 +1444,8 @@ memif_stats_get(struct rte_eth_dev *dev, struct 
rte_eth_stats *stats)
stats->opackets = 0;
stats->obytes = 0;
 
-   tmp = (pmd->role == MEMIF_ROLE_CLIENT) ? pmd->run.num_c2s_rings :
-   pmd->run.num_s2c_rings;
+   tmp = (pmd->role == MEMIF_ROLE_CLIENT) ? pmd->run.num_s2c_rings :
+   pmd->run.num_c2s_rings;
nq = (tmp < RTE_ETHDEV_QUEUE_STAT_CNTRS) ? tmp :
RTE_ETHDEV_QUEUE_STAT_CNTRS;
 
@@ -1458,8 +1458,8 @@ memif_stats_get(struct rte_eth_dev *dev, struct 
rte_eth_stats *stats)
stats->ibytes += mq->n_bytes;
}
 
-   tmp = (pmd->role == MEMIF_ROLE_CLIENT) ? pmd->run.num_s2c_rings :
-   pmd->run.num_c2s_rings;
+   tmp = (pmd->role == MEMIF_ROLE_CLIENT) ? pmd->run.num_c2s_rings :
+   pmd->run.num_s2c_rings;
nq = (tmp < RTE_ETHDEV_QUEUE_STAT_CNTRS) ? tmp :
RTE_ETHDEV_QUEUE_STAT_CNTRS;
 
-- 
2.25.1

[RFC] regexdev: add maximum number of mbuf segments field

[Gerry Gribbon]

Allows application to query maximum number of mbuf segments that can
be chained together.

Signed-off-by: Gerry Gribbon 
---
 drivers/regex/mlx5/mlx5_regex.h  |  1 +
 drivers/regex/mlx5/mlx5_regex_fastpath.c | 43 
 drivers/regex/mlx5/mlx5_rxp.c|  1 +
 lib/regexdev/rte_regexdev.h  |  2 ++
 4 files changed, 47 insertions(+)

diff --git a/drivers/regex/mlx5/mlx5_regex.h b/drivers/regex/mlx5/mlx5_regex.h
index 89495301ac..98fe95b781 100644
--- a/drivers/regex/mlx5/mlx5_regex.h
+++ b/drivers/regex/mlx5/mlx5_regex.h
@@ -94,4 +94,5 @@ uint16_t mlx5_regexdev_dequeue(struct rte_regexdev *dev, 
uint16_t qp_id,
   struct rte_regex_ops **ops, uint16_t nb_ops);
 uint16_t mlx5_regexdev_enqueue_gga(struct rte_regexdev *dev, uint16_t qp_id,
   struct rte_regex_ops **ops, uint16_t nb_ops);
+uint16_t mlx5_regexdev_max_segs_get(void);
 #endif /* MLX5_REGEX_H */
diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c 
b/drivers/regex/mlx5/mlx5_regex_fastpath.c
index 9a2db7e43f..16f48627e5 100644
--- a/drivers/regex/mlx5/mlx5_regex_fastpath.c
+++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c
@@ -41,6 +41,39 @@
 /* In WQE set mode, the pi should be quarter of the MLX5_REGEX_MAX_WQE_INDEX. 
*/
 #define MLX5_REGEX_UMR_QP_PI_IDX(pi, ops) \
(((pi) + (ops)) & (MLX5_REGEX_MAX_WQE_INDEX >> 2))
+#ifdef RTE_LIBRTE_MLX5_DEBUG
+#define MLX5_REGEX_DEBUG 0
+#endif
+#ifdef HAVE_MLX5_UMR_IMKEY
+static uint16_t max_nb_segs = MLX5_REGEX_MAX_KLM_NUM;
+#else
+static uint16_t max_nb_segs = 1;
+#endif
+
+uint16_t
+mlx5_regexdev_max_segs_get(void)
+{
+   return max_nb_segs;
+}
+
+#ifdef MLX5_REGEX_DEBUG
+static inline uint16_t
+validate_ops(struct rte_regex_ops **ops, uint16_t nb_ops)
+{
+   uint16_t nb_left = nb_ops;
+   struct rte_mbuf *mbuf;
+
+   while (nb_left--) {
+   mbuf = ops[nb_left]->mbuf;
+   if ((mbuf->pkt_len > MLX5_RXP_MAX_JOB_LENGTH) ||
+   (mbuf->nb_segs > max_nb_segs)) {
+   DRV_LOG(ERR, "Failed to validate regex ops");
+   return 1;
+   }
+   }
+   return 0;
+}
+#endif
 
 static inline uint32_t
 qp_size_get(struct mlx5_regex_hw_qp *qp)
@@ -375,6 +408,11 @@ mlx5_regexdev_enqueue_gga(struct rte_regexdev *dev, 
uint16_t qp_id,
struct mlx5_regex_hw_qp *qp_obj;
size_t hw_qpid, nb_left = nb_ops, nb_desc;
 
+#ifdef MLX5_REGEX_DEBUG
+   if (validate_ops(ops, nb_ops))
+   return 0;
+#endif
+
while ((hw_qpid = ffs(queue->free_qps))) {
hw_qpid--; /* ffs returns 1 for bit 0 */
qp_obj = &queue->qps[hw_qpid];
@@ -409,6 +447,11 @@ mlx5_regexdev_enqueue(struct rte_regexdev *dev, uint16_t 
qp_id,
struct mlx5_regex_hw_qp *qp_obj;
size_t hw_qpid, job_id, i = 0;
 
+#ifdef MLX5_REGEX_DEBUG
+   if (validate_ops(ops, nb_ops))
+   return 0;
+#endif
+
while ((hw_qpid = ffs(queue->free_qps))) {
hw_qpid--; /* ffs returns 1 for bit 0 */
qp_obj = &queue->qps[hw_qpid];
diff --git a/drivers/regex/mlx5/mlx5_rxp.c b/drivers/regex/mlx5/mlx5_rxp.c
index ed3af15e40..35a4cfb7ac 100644
--- a/drivers/regex/mlx5/mlx5_rxp.c
+++ b/drivers/regex/mlx5/mlx5_rxp.c
@@ -45,6 +45,7 @@ mlx5_regex_info_get(struct rte_regexdev *dev __rte_unused,
  RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F;
info->rule_flags = 0;
info->max_queue_pairs = UINT16_MAX;
+   info->max_num_mbuf_segs = mlx5_regexdev_max_segs_get();
return 0;
 }
 
diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
index 3bce8090f6..7d2e1ee1d0 100644
--- a/lib/regexdev/rte_regexdev.h
+++ b/lib/regexdev/rte_regexdev.h
@@ -622,6 +622,8 @@ struct rte_regexdev_info {
/**< Supported compiler rule flags.
 * @see RTE_REGEX_PCRE_RULE_*, struct rte_regexdev_rule::rule_flags
 */
+   uint16_t max_num_mbuf_segs;
+   /**< Maximum number of mbuf segments that can be chained together. */
 };
 
 /**
-- 
2.25.1

Re: [PATCH v2] ethtool: added help command to list all available

[Huzaifa Rahman]

Hi,

Is there any other work/changes required for this patch to be submitted?


Thanks


On Mon, May 30, 2022 at 3:42 PM Ferruh Yigit 
wrote:

> On 5/27/2022 6:14 AM, Huzaifa Rahman wrote:
> > [CAUTION: External Email]
> > Hi,
> >
> > The following tests are failing but my patch is not related to anything
> > related to these. Please re-run the tests.
> >
> > Failed Tests:
> >   - mtu_update
> >   - scatter
> >
>
> Hi Huzaifa,
>
> Agree, it looks unrelated, I will trigger the test again, can please
> check in ~10 mins.
>
> >
> > Thanks,
> >
> > Huzaifa
> >
> >
> >
> > On Tue, Mar 22, 2022 at 2:36 PM huzaifa.rahman
> > mailto:huzaifa.rah...@emumba.com>> wrote:
> >
> > Help command is not available for ethtool example. It is needed so
> user
> > can see all the available commands directly from the command line
> along
> > with the formats.
> >
> > Signed-off-by: huzaifa.rahman  > >
> > ---
> >   doc/guides/sample_app_ug/ethtool.rst  |  1 +
> >   examples/ethtool/ethtool-app/ethapp.c | 38
> +++
> >   examples/ethtool/ethtool-app/ethapp.h |  1 +
> >   3 files changed, 40 insertions(+)
> >
>
> <...>
>

[dpdk-dev v2] Crypto/qat: fix build with OpenSSL 1.1

[Kai Ji]

This patch add in libcrypto version check before enable libipsec-mb for
QAT. The inter-ipsec-mb lib for partial hash and AES calculation should
only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are installed
on the system.

Signed-off-by: Kai Ji 
---
 drivers/common/qat/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 245c0fbe61..8247bdd017 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -37,7 +37,9 @@ endif
 
 IMB_required_ver = '1.2.0'
 libipsecmb = cc.find_library('IPSec_MB', required: false)
-if libipsecmb.found()
+libcrypto_3 = dependency('libcrypto', required: false,
+method: 'pkg-config', version : '>=3.0.0')
+if libipsecmb.found() and libcrypto_3.found()
 # version comes with quotes, so we split based on " and take the middle
 imb_ver = cc.get_define('IMB_VERSION_STR',
 prefix : '#include').split('"')[1]
-- 
2.17.1

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

[Ji, Kai]

Thanks akhil,

V2 here: 
http://patchwork.dpdk.org/project/dpdk/patch/20220726115608.84140-1-kai...@intel.com/

Regards

Kai 

> -Original Message-
> From: Akhil Goyal 
> Sent: Tuesday, July 26, 2022 11:14 AM
> To: Ji, Kai ; dev@dpdk.org
> Cc: Ashwin Sekhar Thalakalath Kottilveetil ; Anoob
> Joseph 
> Subject: RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check
> 
> Hi Kai,
> 
> This is a fix for compilation when openssl 1.1 is used to build QAT.
> Can you update the title to
> Crypto/qat: fix build with OpenSSL 1.1
> 
> > This patch add in libcrypto version check before enable libipsec-mb
> > for QAT. The inter-ipsec-mb lib for partial hash and AES cacluation
> > should only be enabled when both OpensSSL 3.0 and IPSec_MB 1.2.0 are
> > installed on the system.
> 
> Spell check on description.
> 
> >
> > Signed-off-by: Kai Ji 
> > ---
> >  drivers/common/qat/meson.build | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/common/qat/meson.build
> > b/drivers/common/qat/meson.build index 245c0fbe61..8247bdd017 100644
> > --- a/drivers/common/qat/meson.build
> > +++ b/drivers/common/qat/meson.build
> > @@ -37,7 +37,9 @@ endif
> >
> >  IMB_required_ver = '1.2.0'
> >  libipsecmb = cc.find_library('IPSec_MB', required: false) -if
> > libipsecmb.found()
> > +libcrypto_3 = dependency('libcrypto', required: false,
> > +method: 'pkg-config', version : '>=3.0.0') if libipsecmb.found()
> > +and libcrypto_3.found()
> >  # version comes with quotes, so we split based on " and take the middle
> >  imb_ver = cc.get_define('IMB_VERSION_STR',
> >  prefix : '#include').split('"')[1]
> > --
> > 2.17.1

[PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

[Sunil Pai G]

The DPDK commit [1] improves the socket layer logs in the vhost library
to ease log filtering and debugging.
Update the system-dpdk vhost tests to reflect this change.

[1] c85c35b1d447 ("vhost: improve socket layer logs")

Signed-off-by: Sunil Pai G 

---
v1->v2: updated more tests that were added since v1 was sent.
Did not carry acks forward from Cian and Maxime because of new
changes added.
---
 tests/system-dpdk.at | 78 ++--
 1 file changed, 39 insertions(+), 39 deletions(-)

diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at
index 15f97097a..346400731 100644
--- a/tests/system-dpdk.at
+++ b/tests/system-dpdk.at
@@ -78,14 +78,14 @@ AT_CHECK([ovs-vsctl show], [], [stdout])
 sleep 2
 
 dnl Parse log file
-AT_CHECK([grep "VHOST_CONFIG: vhost-user client: socket created" 
ovs-vswitchd.log], [], [stdout])
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) vhost-user 
client: socket created" ovs-vswitchd.log], [], [stdout])
 AT_CHECK([grep "vHost User device 'dpdkvhostuserclient0' created in 'client' 
mode, using client socket" ovs-vswitchd.log], [], [stdout])
-AT_CHECK([grep "VHOST_CONFIG: $OVS_RUNDIR/dpdkvhostclient0: reconnecting..." 
ovs-vswitchd.log], [], [stdout])
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) reconnecting..." 
ovs-vswitchd.log], [], [stdout])
 
 dnl Clean up
 AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], 
[stderr])
 OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
-\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostclient0: No such 
file or directory@d
+\@VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) failed to connect: No such file 
or directory@d
 ])")
 AT_CLEANUP
 dnl --
@@ -112,11 +112,11 @@ AT_CHECK([ovs-vsctl add-port br10 dpdkvhostuser0 -- set 
Interface dpdkvhostuser0
 AT_CHECK([ovs-vsctl show], [], [stdout])
 
 dnl Parse log file
-AT_CHECK([grep "VHOST_CONFIG: vhost-user server: socket created" \
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostuser0) vhost-user server: 
socket created" \
   ovs-vswitchd.log], [], [stdout])
 AT_CHECK([grep "Socket $OVS_RUNDIR/dpdkvhostuser0 created for vhost-user port 
dpdkvhostuser0" \
   ovs-vswitchd.log], [], [stdout])
-AT_CHECK([grep "VHOST_CONFIG: bind to $OVS_RUNDIR/dpdkvhostuser0" 
ovs-vswitchd.log], [],
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostuser0) binding succeeded" 
ovs-vswitchd.log], [],
  [stdout])
 
 dnl Set up namespaces
@@ -157,8 +157,8 @@ pkill -f -x -9 'tail -f /dev/null'
 dnl Clean up
 AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuser0], [], [stdout], [stderr])
 OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
-\@VHOST_CONFIG: recvmsg failed@d
-\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostuser0: No such file 
or directory@d
+\@VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostuser0) recvmsg failed@d
+\@VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostuser0) failed to connect: No such file 
or directory@d
 \@dpdkvhostuser ports are considered deprecated;  please migrate to 
dpdkvhostuserclient ports.@d
 \@failed to enumerate system datapaths: No such file or directory@d
 ])")
@@ -187,9 +187,9 @@ AT_CHECK([ovs-vsctl add-port br10 dpdkvhostuserclient0 -- 
set Interface \
 AT_CHECK([ovs-vsctl show], [], [stdout])
 
 dnl Parse log file
-AT_CHECK([grep "VHOST_CONFIG: vhost-user client: socket created" 
ovs-vswitchd.log], [], [stdout])
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) vhost-user 
client: socket created" ovs-vswitchd.log], [], [stdout])
 AT_CHECK([grep "vHost User device 'dpdkvhostuserclient0' created in 'client' 
mode, using client socket" ovs-vswitchd.log], [], [stdout])
-AT_CHECK([grep "VHOST_CONFIG: $OVS_RUNDIR/dpdkvhostclient0: reconnecting..." 
ovs-vswitchd.log], [], [stdout])
+AT_CHECK([grep "VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) reconnecting..." 
ovs-vswitchd.log], [], [stdout])
 
 dnl Set up namespaces
 ADD_NAMESPACES(ns1, ns2)
@@ -229,8 +229,8 @@ pkill -f -x -9 'tail -f /dev/null'
 dnl Clean up
 AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], 
[stderr])
 OVS_VSWITCHD_STOP("m4_join([], [SYSTEM_DPDK_ALLOWED_LOGS], [
-\@VHOST_CONFIG: recvmsg failed@d
-\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostclient0: No such 
file or directory@d
+\@VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) recvmsg failed@d
+\@VHOST_CONFIG: ($OVS_RUNDIR/dpdkvhostclient0) failed to connect: No such file 
or directory@d
 \@dpdkvhostuser ports are considered deprecated;  please migrate to 
dpdkvhostuserclient ports.@d
 \@failed to enumerate system datapaths: No such file or directory@d
 ])")
@@ -304,14 +304,14 @@ AT_CHECK([ovs-vsctl list interface dpdkvhostuserclient0], 
[], [stdout])
 AT_CHECK([egrep 'ingress_policing_rate: 0' stdout], [], [stdout])
 
 dnl Parse log file
-AT_CHECK([grep "VHOST_CONFIG: vhost-user client: socket created" 
ovs-vswitchd

RE: [PATCH dpdk-latest v2] system-dpdk: Update vhost tests to be compatible with DPDK 22.07.

[Pai G, Sunil]

Copy paste error of wrong mailing list , please ignore this patch, was intended 
for OVS ML

[PATCH] net: rename octeon ep PMD

[Sathesh Edara]

This patch renames octeon end point driver from octeontx_ep to
octeon_ep to enable single unified driver to support current
OcteonTx and future Octeon PCI endpoint NICs to reflect common
driver for all Octeon based PCI endpoint NICs.

Signed-off-by: Sathesh Edara 
---
 MAINTAINERS   | 6 +++---
 .../nics/features/{octeontx_ep.ini => octeon_ep.ini}  | 2 +-
 doc/guides/nics/index.rst | 2 +-
 doc/guides/nics/{octeontx_ep.rst => octeon_ep.rst}| 8 
 drivers/net/meson.build   | 2 +-
 drivers/net/{octeontx_ep => octeon_ep}/meson.build| 0
 drivers/net/{octeontx_ep => octeon_ep}/otx2_ep_vf.c   | 0
 drivers/net/{octeontx_ep => octeon_ep}/otx2_ep_vf.h   | 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_common.h| 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_ethdev.c| 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_rxtx.c  | 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_rxtx.h  | 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_vf.c| 0
 drivers/net/{octeontx_ep => octeon_ep}/otx_ep_vf.h| 0
 drivers/net/{octeontx_ep => octeon_ep}/version.map| 0
 15 files changed, 10 insertions(+), 10 deletions(-)
 rename doc/guides/nics/features/{octeontx_ep.ini => octeon_ep.ini} (75%)
 rename doc/guides/nics/{octeontx_ep.rst => octeon_ep.rst} (81%)
 rename drivers/net/{octeontx_ep => octeon_ep}/meson.build (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx2_ep_vf.c (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx2_ep_vf.h (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_common.h (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_ethdev.c (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_rxtx.c (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_rxtx.h (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_vf.c (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/otx_ep_vf.h (100%)
 rename drivers/net/{octeontx_ep => octeon_ep}/version.map (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 32ffdd1a61..d7c7fa4cdf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -812,9 +812,9 @@ M: Radha Mohan Chintakuntla 
 M: Veerasenareddy Burru 
 M: Sathesh Edara 
 T: git://dpdk.org/next/dpdk-next-net-mrvl
-F: drivers/net/octeontx_ep/
-F: doc/guides/nics/features/octeontx_ep.ini
-F: doc/guides/nics/octeontx_ep.rst
+F: drivers/net/octeon_ep/
+F: doc/guides/nics/features/octeon_ep.ini
+F: doc/guides/nics/octeon_ep.rst
 
 Mellanox mlx4
 M: Matan Azrad 
diff --git a/doc/guides/nics/features/octeontx_ep.ini 
b/doc/guides/nics/features/octeon_ep.ini
similarity index 75%
rename from doc/guides/nics/features/octeontx_ep.ini
rename to doc/guides/nics/features/octeon_ep.ini
index d1453f5bee..141d918466 100644
--- a/doc/guides/nics/features/octeontx_ep.ini
+++ b/doc/guides/nics/features/octeon_ep.ini
@@ -1,5 +1,5 @@
 ;
-; Supported features of the 'octeontx_ep' network poll mode driver.
+; Supported features of the 'octeon_ep' network poll mode driver.
 ;
 ; Refer to default.ini for the full list of available PMD features.
 ;
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index f48e9f815c..f80906a97d 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -52,7 +52,7 @@ Network Interface Controller Drivers
 ngbe
 null
 octeontx
-octeontx_ep
+octeon_ep
 pfe
 qede
 sfc_efx
diff --git a/doc/guides/nics/octeontx_ep.rst b/doc/guides/nics/octeon_ep.rst
similarity index 81%
rename from doc/guides/nics/octeontx_ep.rst
rename to doc/guides/nics/octeon_ep.rst
index 2ec8a034b5..2a4f0f8152 100644
--- a/doc/guides/nics/octeontx_ep.rst
+++ b/doc/guides/nics/octeon_ep.rst
@@ -1,12 +1,12 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
 Copyright(C) 2021 Marvell.
 
-OCTEON TX EP Poll Mode driver
-=
+OCTEON EP Poll Mode driver
+==
 
-The OCTEON TX EP ETHDEV PMD (**librte_pmd_octeontx_ep**) provides poll mode
+The OCTEON EP ETHDEV PMD (**librte_pmd_octeon_ep**) provides poll mode
 ethdev driver support for the virtual functions (VF) of **Marvell OCTEON 9**
-and **Cavium OCTEON TX** families of adapters in SR-IOV context.
+and **Cavium OCTEON** families of adapters in SR-IOV context.
 
 More information can be found at `Marvell Official Website
 
`_.
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index e35652fe63..37919eaf8b 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -45,7 +45,7 @@ drivers = [
 'ngbe',
 'null',
 'octeontx',
-'octeontx_ep',
+'octeon_ep',
 'pcap',
 'pfe',
 'qede',
diff --git a/drivers/net/octeontx_ep/meson.build 
b/drivers/net/octeon_ep/meson.build
similarity index

RE: [PATCH v11] sched: enable CMAN at runtime

[Singh, Jasvinder]

> -Original Message-
> From: Danilewicz, MarcinX 
> Sent: Friday, July 15, 2022 3:51 PM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian 
> Cc: Ajmera, Megha 
> Subject: [PATCH v11] sched: enable CMAN at runtime
> 
> Added changes to enable CMAN (RED or PIE) at init from profile configuration
> file.
> 
> By default CMAN code is enable but not in use, when there is no RED or PIE
> profile configured.
> 
> Signed-off-by: Marcin Danilewicz 
> ---
> Log: v2 change in rte_sched.h to avoid ABI breakage.
>  v3 changes from comments
>  v4 rebase to 22.07-rc1
>  v5 rebase to main latest
>  v6 commit message fixed
>  v7 changes from comments
>  v8 with changes from comments
>  v9 changes from comments
> tmgr.c
> cman_params set to null
> qos_sched/cfg_file.c
> removed redundant cman_params to NULL assignement
> subport_params[].cman_params assigned
> only when CMAN enabled
>  v10 removed ip_pipeline app build error from change
> in tmgr.c
>  v11 added cman_enabled flag instead
> of testing cman_params.cman_mode variable
> ---

Acked-by: Jasvinder Singh 

RE: [PATCH v2 00/13] telemetry JSON escaping and other enhancements

[Morten Brørup]

> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Monday, 25 July 2022 18.35
> 
> This patchset contains fixes for the problem of handling characters
> returned by telemetry callbacks which require escaping when encoded in
> JSON format. It also includes unit tests to validate the correct
> encoding in such scenarios and a number of smaller enhancements to
> telemetry and telemetry testing.
> 
> RFC->V2:
> * limited characters allowed in dictionary element names and command
>   names to side-step the encoding problems there.
> * added support for proper escaping of dictionary string values
> * added more testing and test cases
> * added other misc telemetry cleanups and refactoring
> 

Good job, Bruce!

Series-Acked-by: Morten Brørup 

Re: [RFC] regexdev: add maximum number of mbuf segments field

[Stephen Hemminger]

On Tue, 26 Jul 2022 10:47:07 +
Gerry Gribbon  wrote:

> diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
> index 3bce8090f6..7d2e1ee1d0 100644
> --- a/lib/regexdev/rte_regexdev.h
> +++ b/lib/regexdev/rte_regexdev.h
> @@ -622,6 +622,8 @@ struct rte_regexdev_info {
>   /**< Supported compiler rule flags.
>* @see RTE_REGEX_PCRE_RULE_*, struct rte_regexdev_rule::rule_flags
>*/
> + uint16_t max_num_mbuf_segs;
> + /**< Maximum number of mbuf segments that can be chained together. */
>  };
>  
>  /**

Did you notice that that struct is sparse and there is already
an existing hole that could be reused.  This is going to be an API/ABI
breakage already so reusing the hole will be ok.

Also, please update the release notes for this.

RE: [PATCH v2 1/3] power: add uncore API to power library

[Kearney, Tadhg]

> -Original Message-
> From: Richardson, Bruce 
*snip*
> > > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1)
> > > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32)
> >
> > Check if these flags should be added to other platforms.
> >
> 
> I think we need some explanation as to what these values are for, and how
> they should be set for various platforms.

Kernel does support sysfs uncore interface, as in below: 
"To control uncore frequency, a sysfs interface is provided in the directory: 
/sys/devices/system/cpu/intel_uncore_frequency/.
There is one directory for each package and die combination as the scope of 
uncore scaling control is per die in multiple die/package SoCs or per package 
for single die per package SoCs. The name represents the scope of control. For 
example: 'package_00_die_00' is for package id 0 and die 0." 

The macros 'RTE_MAX_NUMA_DIE' and 'RTE_MAX_UNCORE_FREQS' were first introduced 
as we needed to impose limits on cpu die number and how many uncore frequencies 
would be allowed for a system.

> Are they always these values, or

No, they differ from system to system.

> should they be determined programmatically at build time?

Retrieving information about die and number of uncore frequencies is not 
possible as we do not have a direct interface in Linux which would give this 
information.

With all this, better to remove these macros altogether from config path and 
instead figure out number of dies during run time, by iterating through package 
and die files from the sysfs file  'package_*_die_*',
  for systems that support sysfs uncore path. We would then give error with 
systems that do not contain sysfs uncore path.

Regards, Tadhg
 

[PATCH v3 00/20] Remove repeated words in comments and messages

[Stephen Hemminger]

This is a cleanup of comments and messages. Done by an ugly
pcregrep across sources and skipping lots of false positives

The idea is based of what some maintainers have been doing in netdev.

Series-acked-by: Bruce Richardson  

v3
  - fix some small checkpatch complaints

v2
  - reword ethdev comment rather than just fix typo
  - catch more repeated words
  - make messages consistent


Stephen Hemminger (20):
  ethdev: reword dev_info_get description.
  remove repeated word 'to'
  remove repeated word 'is'
  remove repeated word 'same'
  remove repeated word 'on'
  remove repeated word 'in'
  remove repeated word 'this'
  remove repeated word 'then'
  remove repeated word 'only'
  remove repeated word 'worker'
  remove repeated word 'or'
  remove repeated word 'table'
  remove repeated word 'that'
  remove repeated word 'override'
  remove repeated word 'groups'
  remove repeated word 'page'
  remove repeated word 'individual'
  remove repeated word 'expected'
  remove repeated word 'be'
  remove repeated word 'all'

 app/test/test_ipsec.c   |  2 +-
 app/test/test_resource.c|  2 +-
 drivers/common/sfc_efx/base/efx_regs_mcdi.h |  2 +-
 drivers/common/sfc_efx/base/efx_types.h |  2 +-
 drivers/common/sfc_efx/base/siena_nvram.c   |  2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  4 +--
 drivers/event/sw/sw_evdev.c |  2 +-
 drivers/net/bnx2x/bnx2x.c   |  2 +-
 drivers/net/bnx2x/ecore_fw_defs.h   |  2 +-
 drivers/net/bnx2x/ecore_sp.h|  2 +-
 drivers/net/bonding/rte_eth_bond_8023ad.h   |  2 +-
 drivers/net/cxgbe/cxgbe_filter.h|  2 +-
 drivers/net/cxgbe/sge.c |  2 +-
 drivers/net/hns3/hns3_ethdev.c  |  2 +-
 drivers/net/i40e/i40e_fdir.c|  2 +-
 drivers/net/igc/base/igc_mac.c  |  2 +-
 drivers/net/ixgbe/ixgbe_ipsec.c |  2 +-
 drivers/net/mlx5/mlx5_flow.c|  2 +-
 drivers/net/mvneta/mvneta_ethdev.c  |  2 +-
 drivers/net/mvpp2/mrvl_ethdev.c |  2 +-
 drivers/net/nfp/nfp_ctrl.h  |  2 +-
 drivers/net/pcap/pcap_ethdev.c  |  2 +-
 drivers/net/qede/qede_filter.c  |  4 +--
 drivers/net/sfc/sfc_ef10_tx.c   |  2 +-
 drivers/net/sfc/sfc_tso.c   |  2 +-
 examples/vm_power_manager/channel_monitor.h |  2 +-
 examples/vm_power_manager/oob_monitor.h |  2 +-
 lib/bpf/rte_bpf_ethdev.h|  2 +-
 lib/distributor/rte_distributor.c   |  2 +-
 lib/ethdev/rte_ethdev.h | 33 -
 lib/mbuf/rte_mbuf_core.h|  2 +-
 lib/net/rte_ether.h |  2 +-
 lib/pipeline/rte_swx_ctl.c  |  2 +-
 lib/power/guest_channel.c   |  2 +-
 lib/ring/rte_ring.c |  3 +-
 35 files changed, 42 insertions(+), 64 deletions(-)

-- 
2.35.1

[PATCH v3 01/20] ethdev: reword dev_info_get description.

[Stephen Hemminger]

The original comment was redundant and had duplicate word 'of'.

Signed-off-by: Stephen Hemminger 
---
 lib/ethdev/rte_ethdev.h | 33 +
 1 file changed, 5 insertions(+), 28 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index de9e970d4d11..d2eff20b8917 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3356,34 +3356,11 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct 
rte_ether_addr *ma,
 /**
  * Retrieve the contextual information of an Ethernet device.
  *
- * As part of this function, a number of of fields in dev_info will be
- * initialized as follows:
- *
- * rx_desc_lim = lim
- * tx_desc_lim = lim
- *
- * Where lim is defined within the rte_eth_dev_info_get as
- *
- *  const struct rte_eth_desc_lim lim = {
- *  .nb_max = UINT16_MAX,
- *  .nb_min = 0,
- *  .nb_align = 1,
- * .nb_seg_max = UINT16_MAX,
- * .nb_mtu_seg_max = UINT16_MAX,
- *  };
- *
- * device = dev->device
- * min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN
- * max_mtu = UINT16_MAX
- *
- * The following fields will be populated if support for dev_infos_get()
- * exists for the device and the rte_eth_dev 'dev' has been populated
- * successfully with a call to it:
- *
- * driver_name = dev->device->driver->name
- * nb_rx_queues = dev->data->nb_rx_queues
- * nb_tx_queues = dev->data->nb_tx_queues
- * dev_flags = &dev->data->dev_flags
+ * The device information about driver, descriptors limits,
+ * capabilities, flags,  and queues is returned.
+ *
+ * The fields are populated with generic values that then are
+ * overridden by the device driver specific values.
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
-- 
2.35.1

[PATCH v3 02/20] remove repeated word 'to'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_resource.c  | 2 +-
 drivers/common/sfc_efx/base/siena_nvram.c | 2 +-
 lib/pipeline/rte_swx_ctl.c| 2 +-
 lib/power/guest_channel.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_resource.c b/app/test/test_resource.c
index 8f41e3babdc5..05c27db203cc 100644
--- a/app/test/test_resource.c
+++ b/app/test/test_resource.c
@@ -45,7 +45,7 @@ static int test_resource_c(void)
r->name);
 
TEST_ASSERT_SUCCESS(resource_fwrite_file(r, "test_resource.c"),
-   "Failed to to write file %s", r->name);
+   "Failed to write file %s", r->name);
 
f = fopen("test_resource.c", "r");
TEST_ASSERT_NOT_NULL(f,
diff --git a/drivers/common/sfc_efx/base/siena_nvram.c 
b/drivers/common/sfc_efx/base/siena_nvram.c
index 05ca4bd83dc9..ebcd3487b631 100644
--- a/drivers/common/sfc_efx/base/siena_nvram.c
+++ b/drivers/common/sfc_efx/base/siena_nvram.c
@@ -532,7 +532,7 @@ siena_nvram_partn_get_version(
: MC_CMD_NVRAM_TYPE_DYNAMIC_CFG_PORT1;
/*
 * Ingore missing partitions on port 2, assuming they're due
-* to to running on a single port part.
+* to running on a single port part.
 */
if ((1 << dcfg_partn) &  ~enp->en_u.siena.enu_partn_mask) {
if (entry->port == 2)
diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c
index 710e89a46a26..9b7bf5e0fb01 100644
--- a/lib/pipeline/rte_swx_ctl.c
+++ b/lib/pipeline/rte_swx_ctl.c
@@ -1582,7 +1582,7 @@ rte_swx_ctl_pipeline_table_entry_delete(struct 
rte_swx_ctl_pipeline *ctl,
CHECK(!table_entry_check(ctl, table_id, entry, 1, 0), EINVAL);
 
/* The entry is found in the table->entries list:
-* - Move the existing entry from the table->entries list to to the
+* - Move the existing entry from the table->entries list to the
 *   table->pending_delete list.
 */
existing_entry = table_entries_find(table, entry);
diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index 969a9e5aaa06..7b2ae0b6506f 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -74,7 +74,7 @@ guest_channel_host_connect(const char *path, unsigned int 
lcore_id)
fd_path, lcore_id);
fd = open(fd_path, O_RDWR);
if (fd < 0) {
-   RTE_LOG(ERR, GUEST_CHANNEL, "Unable to to connect to '%s' with 
error "
+   RTE_LOG(ERR, GUEST_CHANNEL, "Unable to connect to '%s' with 
error "
"%s\n", fd_path, strerror(errno));
return -1;
}
-- 
2.35.1

[PATCH v3 03/20] remove repeated word 'is'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +-
 lib/net/rte_ether.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h 
b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
index 2daf825a366e..f3ec456864f6 100644
--- a/drivers/common/sfc_efx/base/efx_regs_mcdi.h
+++ b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
@@ -7992,7 +7992,7 @@
 #defineMC_CMD_SENSOR_SET_LIMS_IN_SENSOR_LEN 4
 /*Enum values, see field(s): */
 /*   MC_CMD_SENSOR_INFO/MC_CMD_SENSOR_INFO_OUT/MASK */
-/* interpretation is is sensor-specific. */
+/* interpretation is sensor-specific. */
 #defineMC_CMD_SENSOR_SET_LIMS_IN_LOW0_OFST 4
 #defineMC_CMD_SENSOR_SET_LIMS_IN_LOW0_LEN 4
 /* interpretation is is sensor-specific. */
diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h
index bf8a55ba06ca..b35c72c7b0e0 100644
--- a/lib/net/rte_ether.h
+++ b/lib/net/rte_ether.h
@@ -350,7 +350,7 @@ static inline int rte_vlan_strip(struct rte_mbuf *m)
  *   The packet mbuf.
  * @return
  *   - 0: On success
- *   -EPERM: mbuf is is shared overwriting would be unsafe
+ *   -EPERM: mbuf is shared overwriting would be unsafe
  *   -ENOSPC: not enough headroom in mbuf
  */
 static inline int rte_vlan_insert(struct rte_mbuf **m)
-- 
2.35.1

[PATCH v3 04/20] remove repeated word 'same'

[Stephen Hemminger]

The word 'same' is duplicated in comment.

Signed-off-by: Stephen Hemminger 
Acked-by: Liron Himi 
---
 drivers/net/mvneta/mvneta_ethdev.c | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c 
b/drivers/net/mvneta/mvneta_ethdev.c
index eef016aa0b65..fc13b2547f31 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -350,7 +350,7 @@ mvneta_dev_start(struct rte_eth_dev *dev)
mvneta_stats_reset(dev);
 
/*
-* In case there are some some stale uc/mc mac addresses flush them
+* In case there are some stale uc/mc mac addresses flush them
 * here. It cannot be done during mvneta_dev_close() as port information
 * is already gone at that point (due to neta_ppio_deinit() in
 * mvneta_dev_stop()).
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 735efb6cfc06..19a4e3b8c329 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -858,7 +858,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
}
 
/*
-* In case there are some some stale uc/mc mac addresses flush them
+* In case there are some stale uc/mc mac addresses flush them
 * here. It cannot be done during mrvl_dev_close() as port information
 * is already gone at that point (due to pp2_ppio_deinit() in
 * mrvl_dev_stop()).
-- 
2.35.1

[PATCH v3 05/20] remove repeated word 'on'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/bonding/rte_eth_bond_8023ad.h   | 2 +-
 examples/vm_power_manager/channel_monitor.h | 2 +-
 examples/vm_power_manager/oob_monitor.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h 
b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 7eb392f8c8a1..7ad8d6d00bd5 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -271,7 +271,7 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t 
slave_id,
struct rte_mbuf *lacp_pkt);
 
 /**
- * Enable dedicated hw queues for 802.3ad control plane traffic on on slaves
+ * Enable dedicated hw queues for 802.3ad control plane traffic on slaves
  *
  * This function creates an additional tx and rx queue on each slave for
  * dedicated 802.3ad control plane traffic . A flow filtering rule is
diff --git a/examples/vm_power_manager/channel_monitor.h 
b/examples/vm_power_manager/channel_monitor.h
index 2b38c554b5cd..ab69524af52c 100644
--- a/examples/vm_power_manager/channel_monitor.h
+++ b/examples/vm_power_manager/channel_monitor.h
@@ -41,7 +41,7 @@ extern "C" {
 int channel_monitor_init(void);
 
 /**
- * Run the channel monitor, loops forever on on epoll_wait.
+ * Run the channel monitor, loops forever on epoll_wait.
  *
  *
  * @return
diff --git a/examples/vm_power_manager/oob_monitor.h 
b/examples/vm_power_manager/oob_monitor.h
index b96e08df782c..2389c1151956 100644
--- a/examples/vm_power_manager/oob_monitor.h
+++ b/examples/vm_power_manager/oob_monitor.h
@@ -20,7 +20,7 @@ extern "C" {
 int branch_monitor_init(void);
 
 /**
- * Run the OOB branch monitor, loops forever on on epoll_wait.
+ * Run the OOB branch monitor, loops forever on epoll_wait.
  *
  *
  * @return
-- 
2.35.1

[PATCH v3 06/20] remove repeated word 'in'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/common/sfc_efx/base/efx_types.h | 2 +-
 drivers/event/sw/sw_evdev.c | 2 +-
 drivers/net/hns3/hns3_ethdev.c  | 2 +-
 drivers/net/mlx5/mlx5_flow.c| 2 +-
 drivers/net/sfc/sfc_ef10_tx.c   | 2 +-
 drivers/net/sfc/sfc_tso.c   | 2 +-
 lib/mbuf/rte_mbuf_core.h| 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_types.h 
b/drivers/common/sfc_efx/base/efx_types.h
index 12ae1084d83a..a6123962f976 100644
--- a/drivers/common/sfc_efx/base/efx_types.h
+++ b/drivers/common/sfc_efx/base/efx_types.h
@@ -399,7 +399,7 @@ extern int fix_lint;
  *
  *   (_element) << 4
  *
- * The result will contain the relevant bits filled in in the range
+ * The result will contain the relevant bits filled in the range
  * [0,high-low), with garbage in bits [high-low+1,...).
  */
 #defineEFX_EXTRACT_NATIVE(_element, _min, _max, _low, _high)   
\
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b5c..7be9ac320963 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -244,7 +244,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,
if (qid->type == RTE_SCHED_TYPE_ORDERED) {
uint32_t window_size;
 
-   /* rte_ring and window_size_mask require require window_size to
+   /* rte_ring and window_size_mask require window_size to
 * be a power-of-2.
 */
window_size = rte_align32pow2(
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 6b1d1a5fb191..29cff1946932 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3904,7 +3904,7 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 
/*
 * When promiscuous mode was enabled, disable the vlan filter to let
-* all packets coming in in the receiving direction.
+* all packets coming in the receiving direction.
 */
offloads = dev->data->dev_conf.rxmode.offloads;
if (offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) {
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8c93a3f2e5ac..674dc31cadd0 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -4816,7 +4816,7 @@ flow_mreg_del_default_copy_action(struct rte_eth_dev *dev)
 }
 
 /**
- * Add the default copy action in in RX_CP_TBL.
+ * Add the default copy action in RX_CP_TBL.
  *
  * This functions is called in the mlx5_dev_start(). No thread safe
  * is guaranteed.
diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c
index 5403a60707d1..116229382b68 100644
--- a/drivers/net/sfc/sfc_ef10_tx.c
+++ b/drivers/net/sfc/sfc_ef10_tx.c
@@ -503,7 +503,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, 
struct rte_mbuf *m_seg,
 
/*
 * Tx prepare has debug-only checks that offload flags are correctly
-* filled in in TSO mbuf. Use zero IPID if there is no IPv4 flag.
+* filled in TSO mbuf. Use zero IPID if there is no IPv4 flag.
 * If the packet is still IPv4, HW will simply start from zero IPID.
 */
if (first_m_seg->ol_flags & RTE_MBUF_F_TX_IPV4)
diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c
index 927e351a6ed4..a0827d1c0dd6 100644
--- a/drivers/net/sfc/sfc_tso.c
+++ b/drivers/net/sfc/sfc_tso.c
@@ -149,7 +149,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx,
 
/*
 * Handle IP header. Tx prepare has debug-only checks that offload flags
-* are correctly filled in in TSO mbuf. Use zero IPID if there is no
+* are correctly filled in TSO mbuf. Use zero IPID if there is no
 * IPv4 flag. If the packet is still IPv4, HW will simply start from
 * zero IPID.
 */
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 3d6ddd6773d2..b1c10252 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -42,7 +42,7 @@ extern "C" {
 
 /**
  * The RX packet is a 802.1q VLAN packet, and the tci has been
- * saved in in mbuf->vlan_tci.
+ * saved in mbuf->vlan_tci.
  * If the flag RTE_MBUF_F_RX_VLAN_STRIPPED is also present, the VLAN
  * header has been stripped from mbuf data, else it is still
  * present.
-- 
2.35.1

[PATCH v3 07/20] remove repeated word 'this'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 lib/ring/rte_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index cddaf6b2876f..8ed455043dee 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -280,7 +280,8 @@ rte_ring_create_elem(const char *name, unsigned int esize, 
unsigned int count,
 
/* reserve a memory zone for this ring. If we can't get rte_config or
 * we are secondary process, the memzone_reserve function will set
-* rte_errno for us appropriately - hence no check in this this 
function */
+* rte_errno for us appropriately - hence no check in this function
+*/
mz = rte_memzone_reserve_aligned(mz_name, ring_size, socket_id,
 mz_flags, __alignof__(*r));
if (mz != NULL) {
-- 
2.35.1

[PATCH v3 08/20] remove repeated word 'then'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/i40e/i40e_fdir.c   | 2 +-
 drivers/net/igc/base/igc_mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 8caedea14eaa..3b7714217405 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -377,7 +377,7 @@ i40e_init_flx_pld(struct i40e_pf *pf)
if ((flex_pit2).src_offset < \
(flex_pit1).src_offset + (flex_pit1).size) { \
PMD_DRV_LOG(ERR, "src_offset should be not" \
-   " less than than previous offset" \
+   " less than previous offset" \
" + previous FSIZE."); \
return -EINVAL; \
} \
diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c
index 3cd6506e5e60..0822ffe7c37c 100644
--- a/drivers/net/igc/base/igc_mac.c
+++ b/drivers/net/igc/base/igc_mac.c
@@ -587,7 +587,7 @@ void igc_update_mc_addr_list_generic(struct igc_hw *hw,
  *  @hw: pointer to the HW structure
  *
  *  In certain situations, a system BIOS may report that the PCIx maximum
- *  memory read byte count (MMRBC) value is higher than than the actual
+ *  memory read byte count (MMRBC) value is higher than the actual
  *  value. We check the PCIx command register with the current PCIx status
  *  register.
  **/
-- 
2.35.1

[PATCH v3 09/20] remove repeated word 'only'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
Acked-by: Rasesh Mody 
---
 drivers/net/bnx2x/bnx2x.c  | 2 +-
 drivers/net/pcap/pcap_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 74e3018eab6f..29c16bb207c7 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct bnx2x_softc 
*sc, uint32_t resource)
 
 /*
  * Get the recovery leader resource id according to the engine this function
- * belongs to. Currently only only 2 engines is supported.
+ * belongs to. Currently only 2 engines are supported.
  */
 static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)
 {
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc53c..bcb02ca0638e 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
internals->if_index =
osdep_iface_index_get(rx_queues->queue[0].name);
 
-   /* phy_mac arg is applied only only if "iface" devarg is 
provided */
+   /* phy_mac arg is applied only if "iface" devarg is provided */
if (rx_queues->phy_mac) {
if (eth_pcap_update_mac(rx_queues->queue[0].name,
eth_dev, vdev->device.numa_node) == 0)
-- 
2.35.1

[PATCH v3 10/20] remove repeated word 'worker'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 lib/distributor/rte_distributor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/distributor/rte_distributor.c 
b/lib/distributor/rte_distributor.c
index 3035b7a99925..967e27d35a49 100644
--- a/lib/distributor/rte_distributor.c
+++ b/lib/distributor/rte_distributor.c
@@ -575,7 +575,7 @@ rte_distributor_process(struct rte_distributor *d,
}
}
 
-   /* Add to current worker worker */
+   /* Add to current worker */
unsigned int idx = bl->count++;
 
bl->tags[idx] = new_tag;
-- 
2.35.1

[PATCH v3 11/20] remove repeated word 'or'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/cxgbe/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 5d91355c9ab1..1a767dabf59c 100644
--- a/drivers/net/cxgbe/sge.c
+++ b/drivers/net/cxgbe/sge.c
@@ -65,7 +65,7 @@ static inline void ship_tx_pkt_coalesce_wr(struct adapter 
*adap,
  * for DMA, but this is of course never sent to the hardware and is only used
  * to prevent double unmappings.  All of the above requires that the Free List
  * Buffers which we allocate have the bottom 5 bits free (0) -- i.e. are
- * 32-byte or or a power of 2 greater in alignment.  Since the SGE's minimal
+ * 32-byte or a power of 2 greater in alignment.  Since the SGE's minimal
  * Free List Buffer alignment is 32 bytes, this works out for us ...
  */
 enum {
-- 
2.35.1

[PATCH v3 12/20] remove repeated word 'table'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/ixgbe/ixgbe_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index c353ae33b4f8..3d479011bea1 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -310,7 +310,7 @@ ixgbe_crypto_remove_sa(struct rte_eth_dev *dev,
return -1;
}
 
-   /* Disable and clear Rx SPI and key table table entries*/
+   /* Disable and clear Rx SPI and key table entries*/
reg_val = IPSRXIDX_WRITE | IPSRXIDX_TABLE_SPI | (sa_index << 3);
IXGBE_WRITE_REG(hw, IXGBE_IPSRXSPI, 0);
IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPIDX, 0);
-- 
2.35.1

[PATCH v3 13/20] remove repeated word 'that'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
Reviewed-by: Niklas Söderlund 
---
 drivers/net/nfp/nfp_ctrl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h
index 372d53746243..2327d4eb7646 100644
--- a/drivers/net/nfp/nfp_ctrl.h
+++ b/drivers/net/nfp/nfp_ctrl.h
@@ -182,7 +182,7 @@
  * Reuse spare address to contain the offset from the start of
  * the host buffer where the first byte of the received frame
  * will land.  Any metadata will come prior to that offset.  If the
- * value in this field is 0, it means that that the metadata will
+ * value in this field is 0, it means that the metadata will
  * always land starting at the first byte of the host buffer and
  * packet data will immediately follow the metadata.  As always,
  * the RX descriptor indicates the presence or absence of metadata
-- 
2.35.1

[PATCH v3 14/20] remove repeated word 'override'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c 
b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 8444f1a7950d..0721fdd3f0d7 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -191,7 +191,7 @@ build_proto_compound_sg_fd(dpaa2_sec_session *sess,
if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
sess->pdcp.hfn_ovd_offset);
-   /*enable HFN override override */
+   /* enable HFN override */
DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
@@ -267,7 +267,7 @@ build_proto_compound_fd(dpaa2_sec_session *sess,
if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
sess->pdcp.hfn_ovd_offset);
-   /*enable HFN override override */
+   /* enable HFN override */
DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
-- 
2.35.1

[PATCH v3 15/20] remove repeated word 'groups'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 app/test/test_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index 7047e1796091..8d208c526a49 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -968,7 +968,7 @@ crypto_ipsec_4grp(uint32_t pkt_num)
 {
uint32_t sa_ind;
 
-   /* group packets in 4 different size groups groups, 2 per SA */
+   /* group packets in 4 different size groups, 2 per SA */
if (pkt_num < PKT_4)
sa_ind = 0;
else if (pkt_num < PKT_12)
-- 
2.35.1

[PATCH v3 16/20] remove repeated word 'page'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/bnx2x/ecore_fw_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_fw_defs.h 
b/drivers/net/bnx2x/ecore_fw_defs.h
index 6fc1fce7e29c..ab1abf6b34b3 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -341,7 +341,7 @@
 #define TOE_STATE (TOE_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 #define RDMA_STATE (RDMA_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 
-/* microcode fixed page page size 4K (chains and ring segments) */
+/* microcode fixed page size 4K (chains and ring segments) */
 #define MC_PAGE_SIZE 4096
 
 /* Number of indices per slow-path SB */
-- 
2.35.1

[PATCH v3 17/20] remove repeated word 'individual'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/cxgbe/cxgbe_filter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h
index 46ebf833381e..6e099a5c1cfc 100644
--- a/drivers/net/cxgbe/cxgbe_filter.h
+++ b/drivers/net/cxgbe/cxgbe_filter.h
@@ -28,7 +28,7 @@
  * (value, mask) tuples.  The associated ingress packet field matches the
  * tuple when ((field & mask) == value).  (Thus a wildcard "don't care" field
  * rule can be constructed by specifying a tuple of (0, 0).)  A filter rule
- * matches an ingress packet when all of the individual individual field
+ * matches an ingress packet when all of the individual field
  * matching rules are true.
  *
  * Partial field masks are always valid, however, while it may be easy to
-- 
2.35.1

[PATCH v3 18/20] remove repeated word 'expected'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 lib/bpf/rte_bpf_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h
index 135062c9e13c..1cca2e6c95a2 100644
--- a/lib/bpf/rte_bpf_ethdev.h
+++ b/lib/bpf/rte_bpf_ethdev.h
@@ -99,7 +99,7 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,
  * @param prm
  *  Parameters used to create and initialise the BPF execution context.
  * @param flags
- *  Flags that define expected expected behavior of the loaded filter
+ *  Flags that define expected behavior of the loaded filter
  *  (i.e. jited/non-jited version to use).
  * @return
  *   Zero on successful completion or negative error code otherwise.
-- 
2.35.1

[PATCH v3 19/20] remove repeated word 'be'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
Acked-by: Devendra Singh Rawat 
Acked-by: Rasesh Mody 
---
 drivers/net/qede/qede_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
index ca3165d97210..24035b64e7a1 100644
--- a/drivers/net/qede/qede_filter.c
+++ b/drivers/net/qede/qede_filter.c
@@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
qdev->vxlan.udp_port = udp_port;
/* If the request is to delete UDP port and if the number of
-* VXLAN filters have reached 0 then VxLAN offload can be be
+* VXLAN filters have reached 0 then VxLAN offload can be
 * disabled.
 */
if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
@@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
qdev->vxlan.udp_port = udp_port;
/* If the request is to delete UDP port and if the number of
-* GENEVE filters have reached 0 then GENEVE offload can be be
+* GENEVE filters have reached 0 then GENEVE offload can be
 * disabled.
 */
if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
-- 
2.35.1

[PATCH v3 20/20] remove repeated word 'all'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger 
---
 drivers/net/bnx2x/ecore_sp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 1f4d5a3ebe29..c0b4d431c879 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -787,7 +787,7 @@ struct ecore_vlan_mac_obj {
/**
*  Delete all configured elements having the given
*  vlan_mac_flags specification. Assumes no pending for
-   *  execution commands. Will schedule all all currently
+   *  execution commands. Will schedule all currently
*  configured MACs/VLANs/VLAN-MACs matching the vlan_mac_flags
*  specification for deletion and will use the given
*  ramrod_flags for the last DEL operation.
-- 
2.35.1

RE: [PATCH v3 14/20] remove repeated word 'override'

[Hemant Agrawal]

> -Original Message-
> From: Stephen Hemminger 
> Sent: Tuesday, July 26, 2022 10:00 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Gagandeep Singh
> ; Hemant Agrawal 
> Subject: [PATCH v3 14/20] remove repeated word 'override'
> Importance: High
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger 
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Acked-by: Hemant Agrawal 

RFC: EAL legacy memory fixed address translations

[Don Wallwork]

This proposal describes a method for translating any huge page
address from virtual to physical or vice versa using simple
addition or subtraction of a single fixed value. This allows
devices to efficiently access arbitrary huge page memory, even
stack data when worker stacks are in huge pages.

When legacy memory mode is used, it is possible to map a single
virtual memory region large enough to cover all huge pages. During
legacy hugepage init, each hugepage is mapped into that region.
Once all pages have been mapped, any unused holes in that memory
region are unmapped.

This feature is applicable when rte_eal_iova_mode() == RTE_IOVA_PA
and could be enabled either by default when the legacy memory EAL
option is given, or a new EAL option could be added to specifically
enable this feature.

It may be desirable to set a capability bit when this feature is
enabled to allow drivers to behave differently depending on the
state of that flag.

We have been working for some time with an internal patch that
implements this functionality. While this patch works for us, it
is not ready to be submitted upstream and we are open to suggested
improvements. We would like to know whether this feature may be of
interest to the wider DPDK community.

RE: [PATCH v2 02/13] telemetry: fix escaping of invalid json characters

[Morten Brørup]

> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Monday, 25 July 2022 18.36
> To: dev@dpdk.org
> Cc: Bruce Richardson; Ciara Power; Keith Wiles
> Subject: [PATCH v2 02/13] telemetry: fix escaping of invalid json
> characters
> 
> For string values returned from telemetry, escape any values that
> cannot
> normally appear in a json string. According to the json spec[1], the
> characters than need to be handled are control chars (char value <
> 0x20)
> and '"' and '\' characters.
> 
> To handle this, we replace the snprintf call with a separate string
> copying and encapsulation routine which checks each character as it
> copies it to the final array.
> 
> [1] https://www.rfc-editor.org/rfc/rfc8259.txt
> 
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
> Bugzilla ID: 1037
> 
> Signed-off-by: Bruce Richardson 
> ---

Patchwork didn't pick up my reply to the 00/13 of the series, so I'll try again 
here...

Series-Acked-by: Morten Brørup 

[RFC] EAL: legacy memory fixed address translations

[Don Wallwork]

This proposal describes a method for translating any huge page
address from virtual to physical or vice versa using simple
addition or subtraction of a single fixed value. This allows
devices to efficiently access arbitrary huge page memory, even
stack data when worker stacks are in huge pages.

When legacy memory mode is used, it is possible to map a single
virtual memory region large enough to cover all huge pages. During
legacy hugepage init, each hugepage is mapped into that region.
Once all pages have been mapped, any unused holes in that memory
region are unmapped.

This feature is applicable when rte_eal_iova_mode() == RTE_IOVA_PA
and could be enabled either by default when the legacy memory EAL
option is given, or a new EAL option could be added to specifically
enable this feature.

It may be desirable to set a capability bit when this feature is
enabled to allow drivers to behave differently depending on the
state of that flag.

We have been working for some time with an internal patch that
implements this functionality. While this patch works for us, it
is not ready to be submitted upstream and we are open to suggested
improvements. We would like to know whether this feature may be of
interest to the wider DPDK community.

Re: [RFC] EAL: legacy memory fixed address translations

[Dmitry Kozlyuk]

Hi Don,

2022-07-26 14:33 (UTC-0400), Don Wallwork:
> This proposal describes a method for translating any huge page
> address from virtual to physical or vice versa using simple
> addition or subtraction of a single fixed value. This allows
> devices to efficiently access arbitrary huge page memory, even
> stack data when worker stacks are in huge pages.

What is the use case and how much is the benefit?

When drivers need to process a large number of memory blocks,
these are typically packets in the form of mbufs,
which already have IOVA attached, so there is no translation.
Does translation of mbuf VA to PA with the proposed method
show significant improvement over reading mbuf->iova?

When drivers need to process a few IOVA-contiguous memory blocks,
they can calculate VA-to-PA offsets in advance,
amortizing translation cost.
Hugepage stack falls within this category.

> When legacy memory mode is used, it is possible to map a single
> virtual memory region large enough to cover all huge pages. During
> legacy hugepage init, each hugepage is mapped into that region.

Legacy mode is called "legacy" with an intent to be deprecated :)
There is initial allocation (-m) and --socket-limit in dynamic mode.
When initial allocation is equal to the socket limit,
it should be the same behavior as in legacy mode:
the number of hugepages mapped is constant and cannot grow,
so the feature seems applicable as well.

> Once all pages have been mapped, any unused holes in that memory
> region are unmapped.

Who tracks these holes and prevents translation from their VA?
Why the holes appear?

> This feature is applicable when rte_eal_iova_mode() == RTE_IOVA_PA

One can say it always works for RTE_IOVA_VA with VA-to-PA offset of 0.

> and could be enabled either by default when the legacy memory EAL
> option is given, or a new EAL option could be added to specifically
> enable this feature.
> 
> It may be desirable to set a capability bit when this feature is
> enabled to allow drivers to behave differently depending on the
> state of that flag.

The feature requires, in IOVA-as-PA mode:
1) that hugepage mapping is static (legacy mode or "-m" == "--socket-limit");
2) that EAL has succeeded to map all hugepages in one PA-continuous block.
As userspace code, DPDK cannot guarantee 2).
Because this mode breaks nothing and just makes translation more efficient,
DPDK can always try to implement it and then report whether it has succeeded.
Applications and drivers can decide what to do by querying this API.

[RFC] pcapng: record received RSS hash in pcap file

[Stephen Hemminger]

There is an option for recording RSS hash with packets in the
pcapng standard. This implements this for all received packets.

There is a corner case that can not be addressed with current
DPDK API's. If using rte_flow() and some hardware it is possible
to write a flow rule that uses another hash function like XOR.
But there is no API that records this, or provides the algorithm
info on a per-packet basis.

The current version of wireshark does not display the recorded
hash option. But if we build it they will come.

Signed-off-by: Stephen Hemminger 
---
 lib/pcapng/rte_pcapng.c | 27 ++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c
index 06ad712bd1eb..f7df3ddd64e8 100644
--- a/lib/pcapng/rte_pcapng.c
+++ b/lib/pcapng/rte_pcapng.c
@@ -4,6 +4,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -453,9 +454,10 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue,
struct pcapng_enhance_packet_block *epb;
uint32_t orig_len, data_len, padding, flags;
struct pcapng_option *opt;
-   const uint16_t optlen = pcapng_optlen(sizeof(flags)) + 
pcapng_optlen(sizeof(queue));
+   uint16_t optlen;
struct rte_mbuf *mc;
uint64_t ns;
+   bool rss_hash;
 
 #ifdef RTE_LIBRTE_ETHDEV_DEBUG
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL);
@@ -488,6 +490,10 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue,
goto fail;
}
 
+   /* record HASH on incoming packets */
+   rss_hash = (direction == RTE_PCAPNG_DIRECTION_IN &&
+   (md->ol_flags & RTE_MBUF_F_RX_RSS_HASH));
+
/* pad the packet to 32 bit boundary */
data_len = rte_pktmbuf_data_len(mc);
padding = RTE_ALIGN(data_len, sizeof(uint32_t)) - data_len;
@@ -499,6 +505,11 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue,
memset(tail, 0, padding);
}
 
+   optlen = pcapng_optlen(sizeof(flags));
+   optlen += pcapng_optlen(sizeof(queue));
+   if (rss_hash)
+   optlen += pcapng_optlen(sizeof(uint8_t) + sizeof(uint32_t));
+
/* reserve trailing options and block length */
opt = (struct pcapng_option *)
rte_pktmbuf_append(mc, optlen + sizeof(uint32_t));
@@ -522,6 +533,20 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue,
opt = pcapng_add_option(opt, PCAPNG_EPB_QUEUE,
&queue, sizeof(queue));
 
+   if (rss_hash) {
+   uint8_t hash_opt[5];
+
+   /* The algorithm could be something else if
+* using rte_flow_action_rss; but the current API does not
+* have a way for ethdev to report  this on a per-packet basis.
+*/
+   hash_opt[0] = PCAPNG_HASH_TOEPLITZ;
+
+   memcpy(&hash_opt[1], &md->hash.rss, sizeof(uint32_t));
+   opt = pcapng_add_option(opt, PCAPNG_EPB_HASH,
+   &hash_opt, sizeof(hash_opt));
+   }
+
/* Note: END_OPT necessary here. Wireshark doesn't do it. */
 
/* Add PCAPNG packet header */
-- 
2.35.1

[dpdk-dev v1] lib/cryptodev: multi-process IPC request handler

[Kai Ji]

This patch add in multi-process IPC request handler function in rte
cryptodev. This function intend to support a queue-pair configuration
request to allow the secondary process to reconfigure the queue-pair
setup'ed by the primary process.

Signed-off-by: Kai Ji 
---
 lib/cryptodev/rte_cryptodev.c | 45 +++
 lib/cryptodev/rte_cryptodev.h | 14 +++
 2 files changed, 59 insertions(+)

diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 42f3221052..18fdbf6db6 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -1202,6 +1202,51 @@ rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t 
queue_pair_id)
return 0;
 }
 
+/* crypto queue pair config */
+#define CRYPTODEV_MP_REQ "cryptodev_mp_request"
+
+static int
+rte_cryptodev_mp_request(const struct rte_mp_msg *mp_msg, const void *peer)
+{
+   struct rte_mp_msg mp_res;
+   struct rte_cryptodev_mp_param *res =
+   (struct rte_cryptodev_mp_param *)mp_res.param;
+   const struct rte_cryptodev_mp_param *param =
+   (const struct rte_cryptodev_mp_param *)mp_msg->param;
+
+   int ret;
+   int dev_id = 0;
+   int port_id = 0, socket_id = 1;
+   struct rte_cryptodev_qp_conf queue_conf;
+   queue_conf.nb_descriptors = 2;
+
+   RTE_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
+   switch (param->type) {
+   case RTE_CRYPTODEV_MP_REQ_QP:
+   ret = rte_cryptodev_queue_pair_setup(dev_id, port_id,
+   &queue_conf, socket_id);
+   res->result = ret;
+
+   ret = rte_mp_reply(&mp_res, peer);
+   break;
+   default:
+   CDEV_LOG_ERR("invalid mp request type\n");
+   return -EINVAL;
+   }
+   return ret;
+
+}
+
+int rte_cryptodev_mp_request_register(void)
+{
+   int ret;
+
+   RTE_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
+   ret = rte_mp_action_register(CRYPTODEV_MP_REQ,
+   rte_cryptodev_mp_request);
+   return ret;
+}
+
 int
 rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
const struct rte_cryptodev_qp_conf *qp_conf, int socket_id)
diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
index 56f459c6a0..901465ca65 100644
--- a/lib/cryptodev/rte_cryptodev.h
+++ b/lib/cryptodev/rte_cryptodev.h
@@ -539,6 +539,18 @@ enum rte_cryptodev_event_type {
RTE_CRYPTODEV_EVENT_MAX /**< max value of this enum */
 };
 
+/* Request types for IPC. */
+enum rte_cryptodev_mp_req_type {
+   RTE_CRYPTODEV_MP_REQ_NONE,
+   RTE_CRYPTODEV_MP_REQ_QP
+};
+
+/* Parameters for IPC. */
+struct rte_cryptodev_mp_param {
+   enum rte_cryptodev_mp_req_type type;
+   int result;
+};
+
 /** Crypto device queue pair configuration structure. */
 struct rte_cryptodev_qp_conf {
uint32_t nb_descriptors; /**< Number of descriptors per queue pair */
@@ -744,6 +756,8 @@ rte_cryptodev_stop(uint8_t dev_id);
 extern int
 rte_cryptodev_close(uint8_t dev_id);
 
+extern int rte_cryptodev_mp_request_register(void);
+
 /**
  * Allocate and set up a receive queue pair for a device.
  *
-- 
2.17.1

[PATCH v1] graph: fix out of bounds access when re-allocate node objs

[Zhirun Yan]

For __rte_node_enqueue_prologue(), If the number of objs is more than
the node->size * 2, the extra objs will write out of bounds memory.
It should use __rte_node_stream_alloc_size() to request enough memory.

And for rte_node_next_stream_put(), it will re-allocate a small size,
when the node free space is small and new objs is less than the current
node->size. Some objs pointers behind new size may be lost. And it will
cause memory leak. It should request enough size of memory, containing
the original objs and new objs at least.

Fixes: 40d4f51403ec ("graph: implement fastpath routines")

Signed-off-by: Zhirun Yan 
Signed-off-by: Liang, Cunming 
---
 lib/graph/rte_graph_worker.h | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/graph/rte_graph_worker.h b/lib/graph/rte_graph_worker.h
index 0c0b9c095a..b7d145c3cb 100644
--- a/lib/graph/rte_graph_worker.h
+++ b/lib/graph/rte_graph_worker.h
@@ -218,13 +218,16 @@ static __rte_always_inline void
 __rte_node_enqueue_prologue(struct rte_graph *graph, struct rte_node *node,
const uint16_t idx, const uint16_t space)
 {
+   uint32_t req_size;
 
/* Add to the pending stream list if the node is new */
if (idx == 0)
__rte_node_enqueue_tail_update(graph, node);
 
-   if (unlikely(node->size < (idx + space)))
-   __rte_node_stream_alloc(graph, node);
+   if (unlikely(node->size < (idx + space))) {
+   req_size = rte_align32pow2(node->size + space);
+   __rte_node_stream_alloc_size(graph, node, req_size);
+   }
 }
 
 /**
@@ -430,9 +433,12 @@ rte_node_next_stream_get(struct rte_graph *graph, struct 
rte_node *node,
node = __rte_node_next_node_get(node, next);
const uint16_t idx = node->idx;
uint16_t free_space = node->size - idx;
+   uint32_t req_size;
 
-   if (unlikely(free_space < nb_objs))
-   __rte_node_stream_alloc_size(graph, node, nb_objs);
+   if (unlikely(free_space < nb_objs)) {
+   req_size = rte_align32pow2(node->size + nb_objs);
+   __rte_node_stream_alloc_size(graph, node, req_size);
+   }
 
return &node->objs[idx];
 }
-- 
2.25.1

RE: [EXT] [dpdk-dev v1] lib/cryptodev: multi-process IPC request handler

[Akhil Goyal]

This is a library change you should cc all PMD owners while sending patch.

> This patch add in multi-process IPC request handler function in rte
> cryptodev. This function intend to support a queue-pair configuration
> request to allow the secondary process to reconfigure the queue-pair
> setup'ed by the primary process.

Who will release the queue pair already setup by primary in the first place?
Currently, all queues are setup by primary and secondary uses them.
So if a queue is re-initialized by secondary, and if it is being used in 
primary process,
Wont that drop packets abruptly if the queue is re-initialized?

Also, I see register API but not deregister.
> 
> Signed-off-by: Kai Ji 
> ---
>  lib/cryptodev/rte_cryptodev.c | 45 +++
>  lib/cryptodev/rte_cryptodev.h | 14 +++
>  2 files changed, 59 insertions(+)
> 
> diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
> index 42f3221052..18fdbf6db6 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -1202,6 +1202,51 @@ rte_cryptodev_get_qp_status(uint8_t dev_id,
> uint16_t queue_pair_id)
>   return 0;
>  }
> 
> +/* crypto queue pair config */
> +#define CRYPTODEV_MP_REQ "cryptodev_mp_request"
> +
> +static int
> +rte_cryptodev_mp_request(const struct rte_mp_msg *mp_msg, const void
> *peer)
> +{
> + struct rte_mp_msg mp_res;
> + struct rte_cryptodev_mp_param *res =
> + (struct rte_cryptodev_mp_param *)mp_res.param;
> + const struct rte_cryptodev_mp_param *param =
> + (const struct rte_cryptodev_mp_param *)mp_msg->param;
> +
> + int ret;
> + int dev_id = 0;
> + int port_id = 0, socket_id = 1;
> + struct rte_cryptodev_qp_conf queue_conf;
> + queue_conf.nb_descriptors = 2;
> +
> + RTE_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
> + switch (param->type) {
> + case RTE_CRYPTODEV_MP_REQ_QP:
> + ret = rte_cryptodev_queue_pair_setup(dev_id, port_id,
> + &queue_conf, socket_id);
> + res->result = ret;
> +
> + ret = rte_mp_reply(&mp_res, peer);
> + break;
> + default:
> + CDEV_LOG_ERR("invalid mp request type\n");
> + return -EINVAL;
> + }
> + return ret;
> +
> +}
> +
> +int rte_cryptodev_mp_request_register(void)
> +{
> + int ret;
> +
> + RTE_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);
> + ret = rte_mp_action_register(CRYPTODEV_MP_REQ,
> + rte_cryptodev_mp_request);
> + return ret;
> +}
> +
>  int
>  rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
>   const struct rte_cryptodev_qp_conf *qp_conf, int socket_id)
> diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
> index 56f459c6a0..901465ca65 100644
> --- a/lib/cryptodev/rte_cryptodev.h
> +++ b/lib/cryptodev/rte_cryptodev.h
> @@ -539,6 +539,18 @@ enum rte_cryptodev_event_type {
>   RTE_CRYPTODEV_EVENT_MAX /**< max value of this enum */
>  };
> 
> +/* Request types for IPC. */
> +enum rte_cryptodev_mp_req_type {
> + RTE_CRYPTODEV_MP_REQ_NONE,
> + RTE_CRYPTODEV_MP_REQ_QP
> +};
> +
> +/* Parameters for IPC. */
> +struct rte_cryptodev_mp_param {
> + enum rte_cryptodev_mp_req_type type;
> + int result;
> +};
> +
>  /** Crypto device queue pair configuration structure. */
>  struct rte_cryptodev_qp_conf {
>   uint32_t nb_descriptors; /**< Number of descriptors per queue pair */
> @@ -744,6 +756,8 @@ rte_cryptodev_stop(uint8_t dev_id);
>  extern int
>  rte_cryptodev_close(uint8_t dev_id);
> 
> +extern int rte_cryptodev_mp_request_register(void);
> +
>  /**
>   * Allocate and set up a receive queue pair for a device.
>   *
> --
> 2.17.1

[PATCH] config/arm: add Graviton3

[Ruifeng Wang]

Add meson build configuration for Graviton3 platform
with 64-bit Arm Neoverse N2 cores.

It adds crypto feature to generic Neoverse N2 config.

Signed-off-by: Ruifeng Wang 
---
 config/arm/arm64_graviton3_linux_gcc | 16 
 config/arm/meson.build   | 10 ++
 2 files changed, 26 insertions(+)
 create mode 100644 config/arm/arm64_graviton3_linux_gcc

diff --git a/config/arm/arm64_graviton3_linux_gcc 
b/config/arm/arm64_graviton3_linux_gcc
new file mode 100644
index 00..19b422075d
--- /dev/null
+++ b/config/arm/arm64_graviton3_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = ['ccache', 'aarch64-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-linux-gnu-g++']
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+platform = 'graviton3'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index aa12eb76f4..272330ed44 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -311,6 +311,14 @@ soc_graviton2 = {
 'numa': false
 }
 
+soc_graviton3 = {
+'description': 'AWS Graviton3',
+'implementer': '0x41',
+'part_number': '0xd49',
+'extra_march_features': ['crypto'],
+'numa': false
+}
+
 soc_kunpeng920 = {
 'description': 'HiSilicon Kunpeng 920',
 'implementer': '0x48',
@@ -390,6 +398,7 @@ cn10k:   Marvell OCTEON 10
 dpaa:NXP DPAA
 emag:Ampere eMAG
 graviton2:   AWS Graviton2
+graviton3:   AWS Graviton3
 kunpeng920:  HiSilicon Kunpeng 920
 kunpeng930:  HiSilicon Kunpeng 930
 n1sdp:   Arm Neoverse N1SDP
@@ -413,6 +422,7 @@ socs = {
 'dpaa': soc_dpaa,
 'emag': soc_emag,
 'graviton2': soc_graviton2,
+'graviton3': soc_graviton3,
 'kunpeng920': soc_kunpeng920,
 'kunpeng930': soc_kunpeng930,
 'n1sdp': soc_n1sdp,
-- 
2.25.1

[PATCH v2] config/arm: add Graviton3

[Ruifeng Wang]

Add meson build configuration for Graviton3 platform
with 64-bit Arm Neoverse N2 cores.

It adds crypto feature to generic Neoverse N2 config.

Signed-off-by: Ruifeng Wang 
---
v2:
Rebased to top of tree.

 config/arm/arm64_graviton3_linux_gcc | 16 
 config/arm/meson.build   | 10 ++
 2 files changed, 26 insertions(+)
 create mode 100644 config/arm/arm64_graviton3_linux_gcc

diff --git a/config/arm/arm64_graviton3_linux_gcc 
b/config/arm/arm64_graviton3_linux_gcc
new file mode 100644
index 00..19b422075d
--- /dev/null
+++ b/config/arm/arm64_graviton3_linux_gcc
@@ -0,0 +1,16 @@
+[binaries]
+c = ['ccache', 'aarch64-linux-gnu-gcc']
+cpp = ['ccache', 'aarch64-linux-gnu-g++']
+ar = 'aarch64-linux-gnu-gcc-ar'
+strip = 'aarch64-linux-gnu-strip'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+pcap-config = ''
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+platform = 'graviton3'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 9f1636e0d5..9ece795b0b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -335,6 +335,14 @@ soc_graviton2 = {
 'numa': false
 }
 
+soc_graviton3 = {
+'description': 'AWS Graviton3',
+'implementer': '0x41',
+'part_number': '0xd49',
+'extra_march_features': ['crypto'],
+'numa': false
+}
+
 soc_kunpeng920 = {
 'description': 'HiSilicon Kunpeng 920',
 'implementer': '0x48',
@@ -415,6 +423,7 @@ dpaa:NXP DPAA
 emag:Ampere eMAG
 ft2000plus:  Phytium FT-2000+
 graviton2:   AWS Graviton2
+graviton3:   AWS Graviton3
 kunpeng920:  HiSilicon Kunpeng 920
 kunpeng930:  HiSilicon Kunpeng 930
 n1sdp:   Arm Neoverse N1SDP
@@ -439,6 +448,7 @@ socs = {
 'emag': soc_emag,
 'ft2000plus': soc_ft2000plus,
 'graviton2': soc_graviton2,
+'graviton3': soc_graviton3,
 'kunpeng920': soc_kunpeng920,
 'kunpeng930': soc_kunpeng930,
 'n1sdp': soc_n1sdp,
-- 
2.25.1