RE: [PATCH v7] ip_frag: add IPv4 options fragment and test data
> According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting process.Add some test data for the IPv4 header optional > field fragmenting. > > Signed-off-by: Huichao Cai > --- Acked-by: Konstantin Ananyev > 1.8.3.1
DPDK Release Status Meeting 2022-04-14
Release status meeting minutes 2022-04-14 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the proposed current dates for 22.07: * Proposal deadline (RFC/v1 patches): 10 April 2022 * API freeze (-rc1): 30 May 2022 * PMD features freeze (-rc2): 20 June 2022 * Built-in applications features freeze (-rc3): 27 June 2022 * Release: 13 July 2022 Updated dates are posted shortly after they are changed at: http://core.dpdk.org/roadmap/#dates Here are some provisional dates for 22.11: * Proposal deadline (RFC/v1 patches): 14 August 2022 * API freeze (-rc1): 3 October 2022 * PMD features freeze (-rc2): 24 October 2022 * Built-in applications features freeze (-rc3): 31 October 2022 * Release: 16 November 2022 Subtrees * next-net * Processing patches * Shared between Andrew/Ferruh/Thomas * next-net-intel * Some patches to pull * next-net-mlx * Some patches to pull * next-net-brcm * No update * next-net-mrvl * Around 15 patches in queue * next-eventdev * Around 15 patches in queue * next-virtio * Currently reviewing async vhost patches - discussion ongoing * VirtIO block device Intel vdpa * Waiting for new revisions * next-crypto * 60 patches in backlog * Some patches from last release * Series on ipsec-qw under review * Patchset for new BBDEV Rejected * Flexran SDK - needs to be removed from Meson and use ipconfig * main * EAL patches under review * Thread series for Windows * Making progress * Enabling of ASAN in the CI * Requires existing ASAN defects to be closed * https://bugs.dpdk.org/buglist.cgi?quicksearch=%5Basan%5D * Lock annotations series: * https://patchwork.dpdk.org/project/dpdk/list/?series=22292 * FreeBSD support for vmbus * Cleanup series for memory leaks and NULL pointers need reviews: * https://patchwork.dpdk.org/bundle/dmarchand/need_reviews/ * Sample apps being updated LTS --- * 21.11.1 * RC1 for 21.11.1 * Looking for testing before April 13th * Release targeted for April 26th * 20.11.5 * Released April 4th * 19.11.12 * Released April 7th * Distros * v20.11 in Debian 11 * 22.04 will contain 21.11 Defects --- * Bugzilla links, 'Bugs', added for hosted projects * https://www.dpdk.org/hosted-projects/ Opens - * None DPDK Release Status Meetings The DPDK Release Status Meeting is intended for DPDK Committers to discuss the status of the master tree and sub-trees, and for project managers to track progress or milestone dates. The meeting occurs on every Thursday at 9:30 UTC. on https://meet.jit.si/DPDK If you wish to attend just send an email to "John McNamara john.mcnam...@intel.com" for the invite.
Re: [PATCH] kni: update kernel API to receive packets
On 4/15/2022 5:07 AM, Gagandeep Singh wrote:
Hi
-Original Message-
From: Harold Huang
Sent: Friday, April 15, 2022 8:54 AM
To: Gagandeep Singh
Cc: dev@dpdk.org
Subject: Re: [PATCH] kni: update kernel API to receive packets
On Thu, Apr 14, 2022 at 8:23 PM Gagandeep Singh wrote:
API 'netif_rx_ni()' has been removed in kernel with commit:
baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any
context.")
The API netif_rx() can be used for any context to receive packets from
device drivers.
This patch replaces the API netif_rx_ni() with netif_rx().
But this change would cause KNI kernel module does not work in the old kernel
without this patch. I suggested using netif_rx_ni to keep compatibility.
netif_rx() API exists from very older versions of kernel before v2.6. There
will be
no compilation issues. Only difference was, netif_rx_ni() can be used in
noninterrupt contexts
to improve performance.
May not be compilation issue, but with old kernels won't the behavior be
different when 'netif_rx_ni()' switched to 'netif_rx()'?
Now, in latest kernel, netif_rx_ni() is removed and netif_rx can handle all the
contexts.
So we have to replace this API otherwise compilation will break on latest
kernel.
Signed-off-by: Gagandeep Singh
---
kernel/linux/kni/kni_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
index 29e5b9e21f..e66b35314a 100644
--- a/kernel/linux/kni/kni_net.c
+++ b/kernel/linux/kni/kni_net.c
@@ -441,7 +441,7 @@ kni_net_rx_normal(struct kni_dev *kni)
skb->ip_summed = CHECKSUM_UNNECESSARY;
/* Call netif interface */
- netif_rx_ni(skb);
+ netif_rx(skb);
/* Update statistics */
dev->stats.rx_bytes += len;
--
2.25.1
--
Thanks, Harold.
Re: [DPDK v3] net/ixgbe: promote MDIO API
zhichaox.z...@intel.com writes:
> From: zhichao zeng
>
> Promote the MDIO APIs to be stable.
>
> Signed-off-by: zhichao zeng
> ---
> drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 -
> drivers/net/ixgbe/version.map | 10 +-
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..426fe5845b 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
> * - (-ENODEV) if *port* invalid.
> * - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> */
> -__rte_experimental
> int
> rte_pmd_ixgbe_mdio_lock(uint16_t port);
>
> @@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
> * - (-ENOTSUP) if hardware doesn't support.
> * - (-ENODEV) if *port* invalid.
> */
> -__rte_experimental
> int
> rte_pmd_ixgbe_mdio_unlock(uint16_t port);
>
> @@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
> * - (-ENODEV) if *port* invalid.
> * - (IXGBE_ERR_PHY) If PHY read command failed
> */
> -__rte_experimental
> int
> rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
>uint32_t dev_type, uint16_t *phy_data);
> @@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t
> reg_addr,
> * - (-ENODEV) if *port* invalid.
> * - (IXGBE_ERR_PHY) If PHY read command failed
> */
> -__rte_experimental
> int
> rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
> uint32_t dev_type, uint16_t phy_data);
> @@ -725,7 +721,6 @@ enum {
> * - (-ENODEV) if *port* invalid.
> * - (-ENOTSUP) if hardware doesn't support this feature.
> */
> -__rte_experimental
> int
> rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
>
> diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
> index bca5cc5826..f0f29d8749 100644
> --- a/drivers/net/ixgbe/version.map
> +++ b/drivers/net/ixgbe/version.map
> @@ -16,6 +16,10 @@ DPDK_22 {
> rte_pmd_ixgbe_macsec_enable;
> rte_pmd_ixgbe_macsec_select_rxsa;
> rte_pmd_ixgbe_macsec_select_txsa;
Promoted APIs should be part of the DPDK_23 ABI, not DPDK_22.
David - I just did some checking and noted that we have been promoting
directly from experimental to DPDK 22, and that we did the same for DPDK
21. However in the DPDK_20 we (rightly) promoted to DPDK_21, new APIs
are promoted to being stable in the next ABI release.
Was that I conscious decision? I don't thinking there is impact by the
error / change, beyond house keeping.
> + rte_pmd_ixgbe_mdio_lock;
> + rte_pmd_ixgbe_mdio_unlock;
> + rte_pmd_ixgbe_mdio_unlocked_read;
> + rte_pmd_ixgbe_mdio_unlocked_write;
> rte_pmd_ixgbe_ping_vf;
> rte_pmd_ixgbe_set_all_queues_drop_en;
> rte_pmd_ixgbe_set_tc_bw_alloc;
> @@ -31,6 +35,7 @@ DPDK_22 {
> rte_pmd_ixgbe_set_vf_vlan_filter;
> rte_pmd_ixgbe_set_vf_vlan_insert;
> rte_pmd_ixgbe_set_vf_vlan_stripq;
> + rte_pmd_ixgbe_upd_fctrl_sbp;
>
> local: *;
> };
> @@ -40,9 +45,4 @@ EXPERIMENTAL {
>
> rte_pmd_ixgbe_get_fdir_info;
> rte_pmd_ixgbe_get_fdir_stats;
> - rte_pmd_ixgbe_mdio_lock;
> - rte_pmd_ixgbe_mdio_unlock;
> - rte_pmd_ixgbe_mdio_unlocked_read;
> - rte_pmd_ixgbe_mdio_unlocked_write;
> - rte_pmd_ixgbe_upd_fctrl_sbp;
> };
--
Regards, Ray K
Re: [PATCH 1/4] lib/power: add get and set API for emptypoll max
Kevin Laatz writes:
> Add new get/set APIs to configure emptypoll max which is used to
> determine when a queue can go into sleep state.
>
> Signed-off-by: Kevin Laatz
> ---
> lib/power/rte_power_pmd_mgmt.c | 21 ++---
> lib/power/rte_power_pmd_mgmt.h | 27 +++
> lib/power/version.map | 4
> 3 files changed, 49 insertions(+), 3 deletions(-)
>
> diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c
> index 39a2b4cd23..dfb7ca9187 100644
> --- a/lib/power/rte_power_pmd_mgmt.c
> +++ b/lib/power/rte_power_pmd_mgmt.c
> @@ -11,7 +11,7 @@
>
> #include "rte_power_pmd_mgmt.h"
>
> -#define EMPTYPOLL_MAX 512
> +unsigned int emptypoll_max;
>
> /* store some internal state */
> static struct pmd_conf_data {
> @@ -206,7 +206,7 @@ queue_can_sleep(struct pmd_core_cfg *cfg, struct
> queue_list_entry *qcfg)
> qcfg->n_empty_polls++;
>
> /* if we haven't reached threshold for empty polls, we can't sleep */
> - if (qcfg->n_empty_polls <= EMPTYPOLL_MAX)
> + if (qcfg->n_empty_polls <= emptypoll_max)
> return false;
>
> /*
> @@ -290,7 +290,7 @@ clb_umwait(uint16_t port_id, uint16_t qidx, struct
> rte_mbuf **pkts __rte_unused,
> /* this callback can't do more than one queue, omit multiqueue logic */
> if (unlikely(nb_rx == 0)) {
> queue_conf->n_empty_polls++;
> - if (unlikely(queue_conf->n_empty_polls > EMPTYPOLL_MAX)) {
> + if (unlikely(queue_conf->n_empty_polls > emptypoll_max)) {
> struct rte_power_monitor_cond pmc;
> int ret;
>
> @@ -661,6 +661,18 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int
> lcore_id,
> return 0;
> }
>
> +void
> +rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max)
> +{
> + emptypoll_max = max;
> +}
> +
> +unsigned int
> +rte_power_pmd_mgmt_get_emptypoll_max(void)
> +{
> + return emptypoll_max;
> +}
> +
> RTE_INIT(rte_power_ethdev_pmgmt_init) {
> size_t i;
>
> @@ -669,4 +681,7 @@ RTE_INIT(rte_power_ethdev_pmgmt_init) {
> struct pmd_core_cfg *cfg = &lcore_cfgs[i];
> TAILQ_INIT(&cfg->head);
> }
> +
> + /* initialize config defaults */
> + emptypoll_max = 512;
> }
> diff --git a/lib/power/rte_power_pmd_mgmt.h b/lib/power/rte_power_pmd_mgmt.h
> index 444e7b8a66..d5a94f8187 100644
> --- a/lib/power/rte_power_pmd_mgmt.h
> +++ b/lib/power/rte_power_pmd_mgmt.h
> @@ -90,6 +90,33 @@ int
> rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,
> uint16_t port_id, uint16_t queue_id);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
> + *
> + * Set a emptypoll_max to specified value. Used to specify the number of
> empty
> + * polls to wait before entering sleep state.
> + *
> + * @param max
> + * The value to set emptypoll_max to.
> + */
> +__rte_experimental
> +void
> +rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max);
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
> + *
> + * Get the current value of emptypoll_max.
> + *
> + * @return
> + * The current emptypoll_max value
> + */
> +__rte_experimental
> +unsigned int
> +rte_power_pmd_mgmt_get_emptypoll_max(void);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/power/version.map b/lib/power/version.map
> index 6ec6d5d96d..8bcd497e06 100644
> --- a/lib/power/version.map
> +++ b/lib/power/version.map
> @@ -38,4 +38,8 @@ EXPERIMENTAL {
> # added in 21.02
> rte_power_ethdev_pmgmt_queue_disable;
> rte_power_ethdev_pmgmt_queue_enable;
> +
> + # added in 22.07
> + rte_power_pmd_mgmt_set_emptypoll_max;
> + rte_power_pmd_mgmt_get_emptypoll_max;
minor niggle, get then set.
> };
--
Regards, Ray K
Re: [PATCH v2 2/2] build: hide local symbols in shared libraries
Thomas Monjalon writes:
> The symbols which are not listed in the version script
> are exported by default.
> Adding a local section with a wildcard make non-listed functions
> and variables as hidden, as it should be in all version.map files.
>
> These are the changes done in the shared libraries:
> - DF .text Base auxiliary_add_device
> - DF .text Base auxiliary_dev_exists
> - DF .text Base auxiliary_dev_iterate
> - DF .text Base auxiliary_insert_device
> - DF .text Base auxiliary_is_ignored_device
> - DF .text Base auxiliary_match
> - DF .text Base auxiliary_on_scan
> - DF .text Base auxiliary_scan
> - DO .bss Base auxiliary_bus_logtype
> - DO .data Base auxiliary_bus
> - DO .bss Base gpu_logtype
>
> There is no impact on regexdev library.
>
> Because these local symbols were exported as non-internal
> in DPDK 21.11, any change in these functions would break the ABI.
> Exception rules are added for these experimental libraries,
> so the ABI check will skip them until the next ABI version.
>
> A check is added to avoid such miss in future.
>
> Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus")
> Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library")
> Cc: sta...@dpdk.org
Good catch, I see you fixed a few of these recently.
>
> Signed-off-by: Thomas Monjalon
> ---
> devtools/check-symbol-maps.sh | 7 +++
> devtools/libabigail.abignore | 8
> drivers/bus/auxiliary/version.map | 2 ++
> lib/gpudev/version.map| 2 ++
> lib/regexdev/version.map | 2 ++
> 5 files changed, 21 insertions(+)
>
> diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
> index 5bd290ac97..8266fdf9ea 100755
> --- a/devtools/check-symbol-maps.sh
> +++ b/devtools/check-symbol-maps.sh
> @@ -53,4 +53,11 @@ if [ -n "$duplicate_symbols" ] ; then
> ret=1
> fi
>
> +local_miss_maps=$(grep -L 'local: \*;' $@)
> +if [ -n "$local_miss_maps" ] ; then
> +echo "Found maps without local catch-all:"
> +echo "$local_miss_maps"
> +ret=1
> +fi
> +
> exit $ret
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 18c11c80c6..c618f20032 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -32,3 +32,11 @@
> ; Ignore changes in common mlx5 driver, should be all internal
> [suppress_file]
> soname_regexp = ^librte_common_mlx5\.
> +
> +; Ignore visibility fix of local functions in experimental auxiliary driver
> +[suppress_file]
> +soname_regexp = ^librte_bus_auxiliary\.
> +
> +; Ignore visibility fix of local functions in experimental gpudev library
> +[suppress_file]
> +soname_regexp = ^librte_gpudev\.
> diff --git a/drivers/bus/auxiliary/version.map
> b/drivers/bus/auxiliary/version.map
> index a52260657c..dc993e84ff 100644
> --- a/drivers/bus/auxiliary/version.map
> +++ b/drivers/bus/auxiliary/version.map
> @@ -4,4 +4,6 @@ EXPERIMENTAL {
> # added in 21.08
> rte_auxiliary_register;
> rte_auxiliary_unregister;
> +
> + local: *;
> };
> diff --git a/lib/gpudev/version.map b/lib/gpudev/version.map
> index b23e3fd6eb..a2c8ce5759 100644
> --- a/lib/gpudev/version.map
> +++ b/lib/gpudev/version.map
> @@ -39,4 +39,6 @@ INTERNAL {
> rte_gpu_get_by_name;
> rte_gpu_notify;
> rte_gpu_release;
> +
> + local: *;
> };
> diff --git a/lib/regexdev/version.map b/lib/regexdev/version.map
> index 988b909638..3c6e9fffa1 100644
> --- a/lib/regexdev/version.map
> +++ b/lib/regexdev/version.map
> @@ -26,6 +26,8 @@ EXPERIMENTAL {
> rte_regexdev_xstats_get;
> rte_regexdev_xstats_names_get;
> rte_regexdev_xstats_reset;
> +
> + local: *;
> };
>
> INTERNAL {
--
Regards, Ray K
Re: [PATCH] kni: update kernel API to receive packets
On Fri, 15 Apr 2022 13:30:33 +0100 Ferruh Yigit wrote: > >> But this change would cause KNI kernel module does not work in the old > >> kernel > >> without this patch. I suggested using netif_rx_ni to keep compatibility. > > > > netif_rx() API exists from very older versions of kernel before v2.6. There > > will be > > no compilation issues. Only difference was, netif_rx_ni() can be used in > > noninterrupt contexts > > to improve performance. > > May not be compilation issue, but with old kernels won't the behavior be > different when 'netif_rx_ni()' switched to 'netif_rx() Probably best handled by #ifdef on kernel version but will be a mess for backports to distro kernels. Looks like: Older -> New netif_rx_ni netif_rx neitf_rx __netif_rx
[PATCH 0/3] Enable ASan in GHA
This series fixes two issues that were revealed while running unit tests with ASan in GHA. There are still some outstanding issues for which bz have been created. The last patch enables ASan in GHA, skipping tests which have issues. -- David Marchand David Marchand (3): test/mem: disable ASan when accessing unallocated mem mem: fix ASan shadow for remapped memory segments ci: build some job with ASan .ci/linux-build.sh | 8 ++ .github/workflows/build.yml | 3 +- app/test/meson.build | 208 ++- app/test/test_memory.c | 5 + lib/eal/common/malloc_elem.h | 12 +- lib/eal/common/malloc_heap.c | 12 +- lib/eal/include/rte_common.h | 13 +++ 7 files changed, 152 insertions(+), 109 deletions(-) -- 2.23.0
[PATCH 1/3] test/mem: disable ASan when accessing unallocated mem
As described in bugzilla, ASan reports accesses to all memory segment as
invalid, since those parts have not been allocated.
Move __rte_no_asan to rte_common.h and disable ASan on a part of the test.
Bugzilla ID: 880
Fixes: 6cc51b1293ce ("mem: instrument allocator for ASan")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
app/test/test_memory.c | 5 +
lib/eal/common/malloc_elem.h | 10 ++
lib/eal/include/rte_common.h | 13 +
3 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/app/test/test_memory.c b/app/test/test_memory.c
index 140ac3f3cf..440e5ef838 100644
--- a/app/test/test_memory.c
+++ b/app/test/test_memory.c
@@ -25,6 +25,11 @@
* - Try to read all memory; it should not segfault.
*/
+/*
+ * ASan complains about accessing unallocated memory.
+ * See: https://bugs.dpdk.org/show_bug.cgi?id=880
+ */
+__rte_no_asan
static int
check_mem(const struct rte_memseg_list *msl __rte_unused,
const struct rte_memseg *ms, void *arg __rte_unused)
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index f2aa98821b..228f178418 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -7,6 +7,8 @@
#include
+#include
+
#define MIN_DATA_SIZE (RTE_CACHE_LINE_SIZE)
/* dummy definition of struct so we can use pointers to it in malloc_elem
struct */
@@ -131,12 +133,6 @@ malloc_elem_cookies_ok(const struct malloc_elem *elem)
#define ASAN_MEM_TO_SHADOW(mem) \
RTE_PTR_ADD(ASAN_MEM_SHIFT(mem), ASAN_SHADOW_OFFSET)
-#if defined(__clang__)
-#define __rte_no_asan __attribute__((no_sanitize("address", "hwaddress")))
-#else
-#define __rte_no_asan __attribute__((no_sanitize_address))
-#endif
-
__rte_no_asan
static inline void
asan_set_shadow(void *addr, char val)
@@ -276,8 +272,6 @@ old_malloc_size(struct malloc_elem *elem)
#else /* !RTE_MALLOC_ASAN */
-#define __rte_no_asan
-
static inline void
asan_set_freezone(void *ptr __rte_unused, size_t size __rte_unused) { }
diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 67587025ab..d56a7570c0 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -267,6 +267,19 @@ static void __attribute__((destructor(RTE_PRIO(prio)),
used)) func(void)
*/
#define __rte_cold __attribute__((cold))
+/**
+ * Disable AddressSanitizer on some code
+ */
+#ifdef RTE_MALLOC_ASAN
+#ifdef RTE_CC_CLANG
+#define __rte_no_asan __attribute__((no_sanitize("address", "hwaddress")))
+#else
+#define __rte_no_asan __attribute__((no_sanitize_address))
+#endif
+#else /* ! RTE_MALLOC_ASAN */
+#define __rte_no_asan
+#endif
+
/*** Macros for pointer arithmetic /
/**
--
2.23.0
[PATCH 2/3] mem: fix ASan shadow for remapped memory segments
When releasing some memory, the allocator can choose to return some
pages to the OS. At the same time, this memory was poisoned in ASAn
shadow. Doing the latter made it impossible to remap this same page
later.
On the other hand, without this poison, the OS would pagefault in any
case for this page.
Remove the poisoning for unmapped pages.
Bugzilla ID: 994
Fixes: 6cc51b1293ce ("mem: instrument allocator for ASan")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
lib/eal/common/malloc_elem.h | 4
lib/eal/common/malloc_heap.c | 12 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common/malloc_elem.h b/lib/eal/common/malloc_elem.h
index 228f178418..b859003722 100644
--- a/lib/eal/common/malloc_elem.h
+++ b/lib/eal/common/malloc_elem.h
@@ -272,6 +272,10 @@ old_malloc_size(struct malloc_elem *elem)
#else /* !RTE_MALLOC_ASAN */
+static inline void
+asan_set_zone(void *ptr __rte_unused, size_t len __rte_unused,
+ uint32_t val __rte_unused) { }
+
static inline void
asan_set_freezone(void *ptr __rte_unused, size_t size __rte_unused) { }
diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c
index 6c572b6f2c..5913d9f862 100644
--- a/lib/eal/common/malloc_heap.c
+++ b/lib/eal/common/malloc_heap.c
@@ -860,6 +860,7 @@ malloc_heap_free(struct malloc_elem *elem)
size_t len, aligned_len, page_sz;
struct rte_memseg_list *msl;
unsigned int i, n_segs, before_space, after_space;
+ bool unmapped_pages = false;
int ret;
const struct internal_config *internal_conf =
eal_get_internal_configuration();
@@ -999,6 +1000,13 @@ malloc_heap_free(struct malloc_elem *elem)
/* don't care if any of this fails */
malloc_heap_free_pages(aligned_start, aligned_len);
+ /*
+* Clear any poisoning in ASan for the associated pages so that
+* next time EAL maps those pages, the allocator can access
+* them.
+*/
+ asan_set_zone(aligned_start, aligned_len, 0x00);
+ unmapped_pages = true;
request_sync();
} else {
@@ -1032,7 +1040,9 @@ malloc_heap_free(struct malloc_elem *elem)
rte_mcfg_mem_write_unlock();
free_unlock:
- asan_set_freezone(asan_ptr, asan_data_len);
+ /* Poison memory range if belonging to some still mapped pages. */
+ if (!unmapped_pages)
+ asan_set_freezone(asan_ptr, asan_data_len);
rte_spinlock_unlock(&(heap->lock));
return ret;
--
2.23.0
[PATCH 3/3] ci: build some job with ASan
Enable ASan, this can greatly help identify leaks and buffer overflows.
Running all unit tests is not possible at the moment: skip unit tests
who have known issues with ASan.
Signed-off-by: David Marchand
---
.ci/linux-build.sh | 8 ++
.github/workflows/build.yml | 3 +-
app/test/meson.build| 208 +++-
3 files changed, 118 insertions(+), 101 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 774a1441bf..93706c0131 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -95,6 +95,14 @@ if [ "$MINI" = "true" ]; then
OPTS="$OPTS -Denable_drivers=net/null"
OPTS="$OPTS -Ddisable_libs=*"
fi
+
+if [ "$ASAN" = "true" ]; then
+OPTS="$OPTS -Db_sanitize=address"
+if [ "${CC%%clang}" != "$CC" ]; then
+OPTS="$OPTS -Db_lundef=false"
+fi
+fi
+
meson build --werror $OPTS
ninja -C build
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 22daaabb91..45871e76ed 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -16,6 +16,7 @@ jobs:
env:
AARCH64: ${{ matrix.config.cross == 'aarch64' }}
ABI_CHECKS: ${{ contains(matrix.config.checks, 'abi') }}
+ ASAN: ${{ contains(matrix.config.checks, 'asan') }}
BUILD_32BIT: ${{ matrix.config.cross == 'i386' }}
BUILD_DOCS: ${{ contains(matrix.config.checks, 'doc') }}
CC: ccache ${{ matrix.config.compiler }}
@@ -47,7 +48,7 @@ jobs:
- os: ubuntu-18.04
compiler: clang
library: shared
-checks: doc+tests
+checks: asan+doc+tests
- os: ubuntu-18.04
compiler: gcc
library: static
diff --git a/app/test/meson.build b/app/test/meson.build
index 5fc1dd1b7b..4622b5c010 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -149,96 +149,97 @@ test_deps = enabled_libs
# as well as libs, the pci and vdev bus drivers are needed for a lot of tests
test_deps += ['bus_pci', 'bus_vdev']
-# Each test is marked with flag true/false
-# to indicate whether it can run in no-huge mode.
+# Each test is marked with flags:
+# - the first flag indicates whether the test can run in no-huge mode,
+# - the second flag indicates whether the test can run with ASan enabled,
fast_tests = [
-['acl_autotest', true],
-['atomic_autotest', false],
-['bitmap_autotest', true],
-['bpf_autotest', true],
-['bpf_convert_autotest', true],
-['bitops_autotest', true],
-['byteorder_autotest', true],
-['cksum_autotest', true],
-['cmdline_autotest', true],
-['common_autotest', true],
-['cpuflags_autotest', true],
-['debug_autotest', true],
-['devargs_autotest', true],
-['eal_flags_c_opt_autotest', false],
-['eal_flags_main_opt_autotest', false],
-['eal_flags_n_opt_autotest', false],
-['eal_flags_hpet_autotest', false],
-['eal_flags_no_huge_autotest', false],
-['eal_flags_a_opt_autotest', false],
-['eal_flags_b_opt_autotest', false],
-['eal_flags_vdev_opt_autotest', false],
-['eal_flags_r_opt_autotest', false],
-['eal_flags_mem_autotest', false],
-['eal_flags_file_prefix_autotest', false],
-['eal_flags_misc_autotest', false],
-['eal_fs_autotest', true],
-['errno_autotest', true],
-['ethdev_link_status', true],
-['event_ring_autotest', true],
-['fib_autotest', true],
-['fib6_autotest', true],
-['func_reentrancy_autotest', false],
-['hash_autotest', true],
-['interrupt_autotest', true],
-['ipfrag_autotest', false],
-['lcores_autotest', true],
-['logs_autotest', true],
-['lpm_autotest', true],
-['lpm6_autotest', true],
-['malloc_autotest', false],
-['mbuf_autotest', false],
-['mcslock_autotest', false],
-['memcpy_autotest', true],
-['memory_autotest', false],
-['mempool_autotest', false],
-['memzone_autotest', false],
-['meter_autotest', true],
-['multiprocess_autotest', false],
-['per_lcore_autotest', true],
-['pflock_autotest', true],
-['prefetch_autotest', true],
-['rcu_qsbr_autotest', true],
-['pie_autotest', true],
-['rib_autotest', true],
-['rib6_autotest', true],
-['ring_autotest', true],
-['rwlock_test1_autotest', true],
-['rwlock_rda_autotest', true],
-['rwlock_rds_wrm_autotest', true],
-['rwlock_rde_wro_autotest', true],
-['sched_autotest', true],
-['security_autotest', false],
-['spinlock_autotest', true],
-['stack_autotest', false],
-['stack_lf_autotest', false],
-['string_autotest', true],
-['tailq_autotest', true],
-['ticketlock_autotest', true],
-['timer_autotest', false],
-
Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs
On Sat, 16 Apr 2022 09:07:45 +0800 Chengwen Feng wrote: > Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve > the number of elements. But the value to be returned when the parameter > 'xstats' is NULL is not specified, some PMDs (eg. hns3/ipn3ke/mvpp2/ > axgbe) return zero while others return the required number of elements. Lets fix the PMD's this impacts other code as well.
