Re: [dpdk-dev] [PATCH] app/testpmd: add PF and VF targets to flow action type sample
Hi,
> -Original Message-
> From: psathe...@marvell.com
> Sent: Monday, December 21, 2020 7:47 AM
>
> From: Satheesh Paul
>
> Add support to specify PF or VF as targets in "set sample_actions"
> command.
>
> Signed-off-by: Satheesh Paul
> ---
>
> The changes add support for below usecases.
>
> 1. Sample mirror to PF
> testpmd>set sample_actions 0 / pf / end
> #pkts to VF id 2 will be mirrored to the PF
> testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
> index 0 / vf id 2 / end
>
> 2. Sample mirror to VF
> testpmd>set sample_actions 1 / vf id 1 / end
> #pkts to VF id 2 will be mirrored to VF id 1
> testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
> index 1 / vf id 2 / end
>
> app/test-pmd/cmdline_flow.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 585cab98b..12f2b1664 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -560,6 +560,7 @@ struct rte_flow_action_queue
> sample_queue[RAW_SAMPLE_CONFS_MAX_NUM];
> struct rte_flow_action_count
> sample_count[RAW_SAMPLE_CONFS_MAX_NUM];
> struct rte_flow_action_port_id
> sample_port_id[RAW_SAMPLE_CONFS_MAX_NUM];
> struct rte_flow_action_raw_encap
> sample_encap[RAW_SAMPLE_CONFS_MAX_NUM];
> +struct rte_flow_action_vf sample_vf[RAW_SAMPLE_CONFS_MAX_NUM];
>
> /** Maximum number of subsequent tokens and arguments on the stack. */
> #define CTX_STACK_SIZE 16
> @@ -7558,6 +7559,14 @@ cmd_set_raw_parsed_sample(const struct buffer
> *in)
> (const void *)action->conf, size);
> action->conf = &sample_port_id[idx];
> break;
> + case RTE_FLOW_ACTION_TYPE_PF:
> + break;
> + case RTE_FLOW_ACTION_TYPE_VF:
> + size = sizeof(struct rte_flow_action_vf);
> + rte_memcpy(&sample_vf[idx],
> + (const void *)action->conf, size);
> + action->conf = &sample_vf[idx];
> + break;
> default:
> printf("Error - Not supported action\n");
> return;
> --
> 2.25.4
Acked-by: Ori Kam
Best,
Ori
[dpdk-dev] [Bug 630] [DPDK 21.02] hotplug_mp/attach_detach_virtio_user: The host display is abnormal after dpdk-hotplug_mp exits
https://bugs.dpdk.org/show_bug.cgi?id=630 Bug ID: 630 Summary: [DPDK 21.02] hotplug_mp/attach_detach_virtio_user: The host display is abnormal after dpdk-hotplug_mp exits Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: normal Priority: Normal Component: vhost/virtio Assignee: dev@dpdk.org Reporter: junx.w.z...@intel.com Target Milestone: --- Environment DPDK version: Use make showversion or for a non-released version: git remote -v && git show-ref --heads 21.02.0-rc2: 3021257a8111d204dc7741bd67a2502efffb6842 Other software versions: name/version for QEMU, OVS, etc. Repeat as required. OS: Fedora release 33 (Thirty Three)(5.9.10-200.fc33.x86_64) Compiler: gcc (GCC) 10.2.1 20201016 (Red Hat 10.2.1-6) Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz NIC hardware: FVL_eagle(Ethernet Controller X710 for 10GbE SFP+ 1572) NIC firmware: driver: i40e version: 2.14.13 firmware-version: 8.00 0x80008b82 1.2766.0 Test Setup Steps to reproduce List the steps to reproduce the issue. 1.compile hotplug_mp meson configure -Dexamples=multi_process/hotplug_mp x86_64-native-linuxapp-gcc ninja -C x86_64-native-linuxapp-gcc 2.bind port on vfio-pci usertools/dpdk-devbind.py --force --bind=i40e :84:00.0 :84:00.1 3.launch testpmd x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 --file-prefix=vhost_9552_20210131070840 --no-pci --vdev eth_vhost0,iface=/home/vhost-net -- -i 4.launch dpdk-hotplug_mp in another session x86_64-native-linuxapp-gcc/examples/dpdk-hotplug_mp --proc-type=auto 5.execute cmd in dpdk-hotplug_mp 1)attach net_virtio_user0,mac=00:01:02:03:04:05,path=/home/vhost-net,packed_vq=1,mrg_rxbuf=1,in_order=0 2)detach net_virtio_user0 Show the output from the previous commands. dpdk-hotplug_mp exits but the host display is abnormal Expected Result Explain what is the expected result in text or as an example output: dpdk-hotplug_mp not exits or dpdk-hotplug_mp exits and the host display is normal Regression Is this issue a regression: (Y) Version the regression was introduced: commit 949735312f5ecb0e4eec2ece1a20fef99295 Author: Maxime Coquelin Date: Tue Jan 26 11:16:35 2021 +0100 net/virtio: move vhost-user specifics to its backend This patch moves all the Vhost-user backend specific logic like Vhost FD, listen FD and interrupt handling to the vhost-user backend implementation. In order to achieve that, new ops are created to update the link status, disconnect and reconnect the server, and fetch the link state interrupt FD. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia -- You are receiving this mail because: You are the assignee for the bug.
[dpdk-dev] [Bug 624] Port close results in "invalid port_id" log message
https://bugs.dpdk.org/show_bug.cgi?id=624 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Resolution|--- |FIXED --- Comment #3 from Thomas Monjalon (tho...@monjalon.net) --- Resolved in http://git.dpdk.org/dpdk/commit/?id=a6f34f9100 -- You are receiving this mail because: You are the assignee for the bug.
[dpdk-dev] [PATCH] maintainers: update for nfp
Release-on-close has been implemented for the NFP PMD. Remove the UNMAINTAINED flag. Signed-off-by: Heinrich Kuhn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77a2273c1..68c5ce6e5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -815,7 +815,7 @@ F: drivers/net/nfb/ F: doc/guides/nics/nfb.rst F: doc/guides/nics/features/nfb.ini -Netronome nfp - UNMAINTAINED +Netronome nfp M: Heinrich Kuhn F: drivers/net/nfp/ F: doc/guides/nics/nfp.rst -- 2.30.0
[dpdk-dev] [PATCH] net/iavf: fix default RSS configuration
Add advanced RSS offloads check due to some legacy driver(kernel/DPDK PF)
does not support virtual channel command VIRTCHNL_OP_RSS_HENA with
hena = 0 and VIRTCHNL_OP_ADD_RSS_CFG.
Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS")
Signed-off-by: Xuan Ding
---
drivers/net/iavf/iavf_ethdev.c | 67 +-
1 file changed, 41 insertions(+), 26 deletions(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 58a20b443f..d8735401d9 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -291,11 +291,13 @@ iavf_init_rss(struct iavf_adapter *adapter)
if (ret)
return ret;
- /* Set RSS hash configuration based on rss_conf->rss_hf. */
- ret = iavf_rss_hash_set(adapter, rss_conf->rss_hf, true);
- if (ret) {
- PMD_DRV_LOG(ERR, "fail to set default RSS");
- return ret;
+ if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
+ /* Set RSS hash configuration based on rss_conf->rss_hf. */
+ ret = iavf_rss_hash_set(adapter, rss_conf->rss_hf, true);
+ if (ret) {
+ PMD_DRV_LOG(ERR, "fail to set default RSS");
+ return ret;
+ }
}
return 0;
@@ -1251,21 +1253,23 @@ iavf_dev_rss_hash_update(struct rte_eth_dev *dev,
if (rss_conf->rss_hf == 0)
return 0;
- /* Clear existing RSS. */
- ret = iavf_set_hena(adapter, 0);
+ if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
+ /* Clear existing RSS. */
+ ret = iavf_set_hena(adapter, 0);
- /* It is a workaround, temporarily allow error to be returned
-* due to possible lack of PF handling for hena = 0.
-*/
- if (ret)
- PMD_DRV_LOG(WARNING, "fail to clean existing RSS,"
- "lack PF support");
+ /* It is a workaround, temporarily allow error to be returned
+* due to possible lack of PF handling for hena = 0.
+*/
+ if (ret)
+ PMD_DRV_LOG(WARNING, "fail to clean existing RSS,"
+ "lack PF support");
- /* Set new RSS configuration. */
- ret = iavf_rss_hash_set(adapter, rss_conf->rss_hf, true);
- if (ret) {
- PMD_DRV_LOG(ERR, "fail to set new RSS");
- return ret;
+ /* Set new RSS configuration. */
+ ret = iavf_rss_hash_set(adapter, rss_conf->rss_hf, true);
+ if (ret) {
+ PMD_DRV_LOG(ERR, "fail to set new RSS");
+ return ret;
+ }
}
return 0;
@@ -2092,6 +2096,24 @@ iavf_dev_filter_ctrl(struct rte_eth_dev *dev,
return ret;
}
+static void
+iavf_default_rss_disable(struct iavf_adapter *adapter)
+{
+ struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);
+ int ret = 0;
+
+ if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
+ /* Set hena = 0 to ask PF to cleanup all existing RSS. */
+ ret = iavf_set_hena(adapter, 0);
+ if (ret)
+ /* It is a workaround, temporarily allow error to be
+* returned due to possible lack of PF handling for
+* hena = 0.
+*/
+ PMD_INIT_LOG(WARNING, "fail to disable default RSS,"
+ "lack PF support");
+ }
+}
static int
iavf_dev_init(struct rte_eth_dev *eth_dev)
@@ -2180,14 +2202,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
return ret;
}
- /* Set hena = 0 to ask PF to cleanup all existing RSS. */
- ret = iavf_set_hena(adapter, 0);
- if (ret)
- /* It is a workaround, temporarily allow error to be returned
-* due to possible lack of PF handling for hena = 0.
-*/
- PMD_DRV_LOG(WARNING, "fail to disable default RSS,"
- "lack PF support");
+ iavf_default_rss_disable(adapter);
return 0;
}
--
2.17.1
Re: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum errors
Hi,
> -Original Message-
> From: dev On Behalf Of Lance Richardson
> Sent: Saturday, January 30, 2021 12:36 AM
> To: Wenzhuo Lu ; Xiaoyun Li
> ; Bernard Iremonger
>
> Cc: dev@dpdk.org; Ajit Kumar Khaparde ;
> Kalesh Anakkur Purayil
> Subject: [dpdk-dev] [PATCH 21.05] app/testpmd: count outer IP checksum
> errors
>
> Count and display outer IP checksum errors in the checksum forwarder.
>
> Example forwarder stats output:
> RX-packets: 158RX-dropped: 0 RX-total: 158
> Bad-ipcsum: 48 Bad-l4csum: 48Bad-outer-l4csum: 6
> Bad-outer-ipcsum: 40
> TX-packets: 0 TX-dropped: 0 TX-total: 0
>
> Signed-off-by: Lance Richardson
> Reviewed-by: Ajit Kumar Khaparde
> Reviewed-by: Kalesh Anakkur Purayil anakkur.pura...@broadcom.com>
> ---
> app/test-pmd/csumonly.c | 5 +
> app/test-pmd/testpmd.c | 11 ++- app/test-pmd/testpmd.h | 2
> ++
> 3 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index
> d813d4fae0..37ed415cee 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -814,6 +814,7 @@ pkt_burst_checksum_forward(struct fwd_stream
> *fs)
> uint32_t rx_bad_ip_csum;
> uint32_t rx_bad_l4_csum;
> uint32_t rx_bad_outer_l4_csum;
> + uint32_t rx_bad_outer_ip_csum;
> struct testpmd_offload_info info;
> uint16_t nb_segments = 0;
> int ret;
> @@ -833,6 +834,7 @@ pkt_burst_checksum_forward(struct fwd_stream
> *fs)
> rx_bad_ip_csum = 0;
> rx_bad_l4_csum = 0;
> rx_bad_outer_l4_csum = 0;
> + rx_bad_outer_ip_csum = 0;
> gro_enable = gro_ports[fs->rx_port].enable;
>
> txp = &ports[fs->tx_port];
> @@ -862,6 +864,8 @@ pkt_burst_checksum_forward(struct fwd_stream
> *fs)
> rx_bad_l4_csum += 1;
> if (rx_ol_flags & PKT_RX_OUTER_L4_CKSUM_BAD)
> rx_bad_outer_l4_csum += 1;
> + if (rx_ol_flags & PKT_RX_EIP_CKSUM_BAD)
> + rx_bad_outer_ip_csum += 1;
>
> /* step 1: dissect packet, parsing optional vlan, ip4/ip6, vxlan
>* and inner headers */
> @@ -1124,6 +1128,7 @@ pkt_burst_checksum_forward(struct fwd_stream
> *fs)
> fs->rx_bad_ip_csum += rx_bad_ip_csum;
> fs->rx_bad_l4_csum += rx_bad_l4_csum;
> fs->rx_bad_outer_l4_csum += rx_bad_outer_l4_csum;
> + fs->rx_bad_outer_ip_csum += rx_bad_outer_ip_csum;
>
> inc_tx_burst_stats(fs, nb_tx);
> if (unlikely(nb_tx < nb_rx)) {
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> c256e719ae..67f60745a0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1805,6 +1805,8 @@ fwd_stream_stats_display(streamid_t stream_id)
> " Rx- bad outer L4 checksum: %-14"PRIu64"\n",
> fs->rx_bad_ip_csum, fs->rx_bad_l4_csum,
> fs->rx_bad_outer_l4_csum);
> + printf(" RX- bad outer IP checksum: %-14"PRIu64"\n",
> + fs->rx_bad_outer_ip_csum);
> } else {
> printf("\n");
> }
> @@ -1827,6 +1829,7 @@ fwd_stats_display(void)
> uint64_t rx_bad_ip_csum;
> uint64_t rx_bad_l4_csum;
> uint64_t rx_bad_outer_l4_csum;
> + uint64_t rx_bad_outer_ip_csum;
> } ports_stats[RTE_MAX_ETHPORTS];
> uint64_t total_rx_dropped = 0;
> uint64_t total_tx_dropped = 0;
> @@ -1859,6 +1862,8 @@ fwd_stats_display(void)
> ports_stats[fs->rx_port].rx_bad_l4_csum += fs-
> >rx_bad_l4_csum;
> ports_stats[fs->rx_port].rx_bad_outer_l4_csum +=
> fs->rx_bad_outer_l4_csum;
> + ports_stats[fs->rx_port].rx_bad_outer_ip_csum +=
> + fs->rx_bad_outer_ip_csum;
>
> if (record_core_cycles)
> fwd_cycles += fs->core_cycles;
> @@ -1890,13 +1895,16 @@ fwd_stats_display(void)
> "RX-total: %-"PRIu64"\n", stats.ipackets, stats.imissed,
> stats.ipackets + stats.imissed);
>
> - if (cur_fwd_eng == &csum_fwd_engine)
> + if (cur_fwd_eng == &csum_fwd_engine) {
> printf(" Bad-ipcsum: %-14"PRIu64
> " Bad-l4csum: %-14"PRIu64
> "Bad-outer-l4csum: %-14"PRIu64"\n",
> ports_stats[pt_id].rx_bad_ip_csum,
> ports_stats[pt_id].rx_bad_l4_csum,
> ports_stats[pt_id].rx_bad_outer_l4_csum);
> + printf(" Bad-outer-ipcsum: %-14"PRIu64"\n",
> +ports_stats[pt_id].rx_bad_outer_ip_csum);
> + }
> if (stats.ierrors + stats.rx_nombuf > 0) {
> printf(" RX-error: %-"PRIu64"\n", stats.ierrors);
>
[dpdk-dev] [PATCH] examples/vhost: add error propagation in ioat ops
It makes more sense to add error propagation for rte_ioat_completed_ops.
Signed-off-by: Cheng Jiang
---
examples/vhost/ioat.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c
index dbad28d43..60b73be93 100644
--- a/examples/vhost/ioat.c
+++ b/examples/vhost/ioat.c
@@ -22,7 +22,6 @@ struct packet_tracker {
struct packet_tracker cb_tracker[MAX_VHOST_DEVICE];
-
int
open_ioat(const char *value)
{
@@ -129,7 +128,7 @@ ioat_transfer_data_cb(int vid, uint16_t queue_id,
struct rte_vhost_async_status *opaque_data, uint16_t count)
{
uint32_t i_desc;
- int dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;
+ uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2 + VIRTIO_RXQ].dev_id;
struct rte_vhost_iov_iter *src = NULL;
struct rte_vhost_iov_iter *dst = NULL;
unsigned long i_seg;
@@ -182,10 +181,17 @@ ioat_check_completed_copies_cb(int vid, uint16_t queue_id,
unsigned short mask = MAX_ENQUEUED_SIZE - 1;
unsigned short i;
- int dev_id = dma_bind[vid].dmas[queue_id * 2
+ uint16_t dev_id = dma_bind[vid].dmas[queue_id * 2
+ VIRTIO_RXQ].dev_id;
n_seg = rte_ioat_completed_ops(dev_id, 255, dump, dump);
- if (n_seg <= 0)
+ if (n_seg < 0) {
+ RTE_LOG(ERR,
+ VHOST_DATA,
+ "fail to poll completed buf on IOAT device %u",
+ dev_id);
+ return 0;
+ }
+ if (n_seg == 0)
return 0;
cb_tracker[dev_id].ioat_space += n_seg;
--
2.29.2
[dpdk-dev] [PATCH] examples/vhost: remove async inflight packet counter
Remove async inflight packet counter since there is no need to keep
traking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number
traking ring from being exhausted.
Fixes: 63dabdeda690 ("examples/vhost: refactor vhost data path")
Signed-off-by: Cheng Jiang
---
examples/vhost/ioat.h | 2 +-
examples/vhost/main.c | 10 +-
examples/vhost/main.h | 1 -
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/examples/vhost/ioat.h b/examples/vhost/ioat.h
index 0a1dbb811..1aa28ed6a 100644
--- a/examples/vhost/ioat.h
+++ b/examples/vhost/ioat.h
@@ -11,7 +11,7 @@
#define MAX_VHOST_DEVICE 1024
#define IOAT_RING_SIZE 4096
-#define MAX_ENQUEUED_SIZE 512
+#define MAX_ENQUEUED_SIZE 4096
struct dma_info {
struct rte_pci_addr addr;
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 233a2dc6e..99e8d9c69 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -831,11 +831,8 @@ complete_async_pkts(struct vhost_dev *vdev)
complete_count = rte_vhost_poll_enqueue_completed(vdev->vid,
VIRTIO_RXQ, p_cpl, MAX_PKT_BURST);
- if (complete_count) {
- __atomic_sub_fetch(&vdev->nr_async_pkts, complete_count,
- __ATOMIC_SEQ_CST);
+ if (complete_count)
free_pkts(p_cpl, complete_count);
- }
}
static __rte_always_inline void
@@ -878,8 +875,6 @@ drain_vhost(struct vhost_dev *vdev)
complete_async_pkts(vdev);
ret = rte_vhost_submit_enqueue_burst(vdev->vid, VIRTIO_RXQ,
m, nr_xmit, m_cpu_cpl, &cpu_cpl_nr);
- __atomic_add_fetch(&vdev->nr_async_pkts, ret - cpu_cpl_nr,
- __ATOMIC_SEQ_CST);
if (cpu_cpl_nr)
free_pkts(m_cpu_cpl, cpu_cpl_nr);
@@ -1210,9 +1205,6 @@ drain_eth_rx(struct vhost_dev *vdev)
enqueue_count = rte_vhost_submit_enqueue_burst(vdev->vid,
VIRTIO_RXQ, pkts, rx_count,
m_cpu_cpl, &cpu_cpl_nr);
- __atomic_add_fetch(&vdev->nr_async_pkts,
- enqueue_count - cpu_cpl_nr,
- __ATOMIC_SEQ_CST);
if (cpu_cpl_nr)
free_pkts(m_cpu_cpl, cpu_cpl_nr);
diff --git a/examples/vhost/main.h b/examples/vhost/main.h
index 2d6c05fd7..0ccdce4b4 100644
--- a/examples/vhost/main.h
+++ b/examples/vhost/main.h
@@ -51,7 +51,6 @@ struct vhost_dev {
uint64_t features;
size_t hdr_len;
uint16_t nr_vrings;
- uint64_t nr_async_pkts;
struct rte_vhost_memory *mem;
struct device_statistics stats;
TAILQ_ENTRY(vhost_dev) global_vdev_entry;
--
2.29.2
[dpdk-dev] [PATCH v2] examples/vhost: remove async inflight packet counter
Remove async inflight packet counter since there is no need to keep
tracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number
tracking ring from being exhausted.
Fixes: 63dabdeda690 ("examples/vhost: refactor vhost data path")
Signed-off-by: Cheng Jiang
---
v2: fixed a typo
examples/vhost/ioat.h | 2 +-
examples/vhost/main.c | 10 +-
examples/vhost/main.h | 1 -
3 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/examples/vhost/ioat.h b/examples/vhost/ioat.h
index 0a1dbb811..1aa28ed6a 100644
--- a/examples/vhost/ioat.h
+++ b/examples/vhost/ioat.h
@@ -11,7 +11,7 @@
#define MAX_VHOST_DEVICE 1024
#define IOAT_RING_SIZE 4096
-#define MAX_ENQUEUED_SIZE 512
+#define MAX_ENQUEUED_SIZE 4096
struct dma_info {
struct rte_pci_addr addr;
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 233a2dc6e..99e8d9c69 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -831,11 +831,8 @@ complete_async_pkts(struct vhost_dev *vdev)
complete_count = rte_vhost_poll_enqueue_completed(vdev->vid,
VIRTIO_RXQ, p_cpl, MAX_PKT_BURST);
- if (complete_count) {
- __atomic_sub_fetch(&vdev->nr_async_pkts, complete_count,
- __ATOMIC_SEQ_CST);
+ if (complete_count)
free_pkts(p_cpl, complete_count);
- }
}
static __rte_always_inline void
@@ -878,8 +875,6 @@ drain_vhost(struct vhost_dev *vdev)
complete_async_pkts(vdev);
ret = rte_vhost_submit_enqueue_burst(vdev->vid, VIRTIO_RXQ,
m, nr_xmit, m_cpu_cpl, &cpu_cpl_nr);
- __atomic_add_fetch(&vdev->nr_async_pkts, ret - cpu_cpl_nr,
- __ATOMIC_SEQ_CST);
if (cpu_cpl_nr)
free_pkts(m_cpu_cpl, cpu_cpl_nr);
@@ -1210,9 +1205,6 @@ drain_eth_rx(struct vhost_dev *vdev)
enqueue_count = rte_vhost_submit_enqueue_burst(vdev->vid,
VIRTIO_RXQ, pkts, rx_count,
m_cpu_cpl, &cpu_cpl_nr);
- __atomic_add_fetch(&vdev->nr_async_pkts,
- enqueue_count - cpu_cpl_nr,
- __ATOMIC_SEQ_CST);
if (cpu_cpl_nr)
free_pkts(m_cpu_cpl, cpu_cpl_nr);
diff --git a/examples/vhost/main.h b/examples/vhost/main.h
index 2d6c05fd7..0ccdce4b4 100644
--- a/examples/vhost/main.h
+++ b/examples/vhost/main.h
@@ -51,7 +51,6 @@ struct vhost_dev {
uint64_t features;
size_t hdr_len;
uint16_t nr_vrings;
- uint64_t nr_async_pkts;
struct rte_vhost_memory *mem;
struct device_statistics stats;
TAILQ_ENTRY(vhost_dev) global_vdev_entry;
--
2.29.2
[dpdk-dev] [PATCH] net/mlx5: update flow meter capability flags names
Existing names of the flags denoting flow meter capability are unclear
and may be misleading.
This patch updates the names to align with the updated documentation.
Comments were edited, describing the names clearly.
Signed-off-by: Dekel Peled
Acked-by: Matan Azrad
---
drivers/common/mlx5/mlx5_devx_cmds.c | 8
drivers/common/mlx5/mlx5_devx_cmds.h | 12 +---
drivers/common/mlx5/mlx5_prm.h | 4 ++--
drivers/net/mlx5/linux/mlx5_os.c | 4 ++--
drivers/net/mlx5/mlx5_flow_meter.c | 4 ++--
5 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c
b/drivers/common/mlx5/mlx5_devx_cmds.c
index adeeb811f7..b075af9f6d 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -758,14 +758,14 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,
return -1;
}
hcattr = MLX5_ADDR_OF(query_hca_cap_out, out, capability);
- attr->qos.srtcm_sup =
- MLX5_GET(qos_cap, hcattr, flow_meter_srtcm);
+ attr->qos.flow_meter_old =
+ MLX5_GET(qos_cap, hcattr, flow_meter_old);
attr->qos.log_max_flow_meter =
MLX5_GET(qos_cap, hcattr, log_max_flow_meter);
attr->qos.flow_meter_reg_c_ids =
MLX5_GET(qos_cap, hcattr, flow_meter_reg_id);
- attr->qos.flow_meter_reg_share =
- MLX5_GET(qos_cap, hcattr, flow_meter_reg_share);
+ attr->qos.flow_meter =
+ MLX5_GET(qos_cap, hcattr, flow_meter);
attr->qos.packet_pacing =
MLX5_GET(qos_cap, hcattr, packet_pacing);
attr->qos.wqe_rate_pp =
diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h
b/drivers/common/mlx5/mlx5_devx_cmds.h
index dbcbee16bc..3e2a0a24f9 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.h
+++ b/drivers/common/mlx5/mlx5_devx_cmds.h
@@ -38,11 +38,17 @@ struct mlx5_devx_mkey_attr {
/* HCA qos attributes. */
struct mlx5_hca_qos_attr {
uint32_t sup:1; /* Whether QOS is supported. */
- uint32_t srtcm_sup:1; /* Whether srTCM mode is supported. */
+ uint32_t flow_meter_old:1; /* Flow meter is supported, old version. */
uint32_t packet_pacing:1; /* Packet pacing is supported. */
uint32_t wqe_rate_pp:1; /* Packet pacing WQE rate mode. */
- uint32_t flow_meter_reg_share:1;
- /* Whether reg_c share is supported. */
+ uint32_t flow_meter:1;
+ /*
+* Flow meter is supported, updated version.
+* When flow_meter is 1, it indicates that REG_C sharing is supported.
+* If flow_meter is 1, flow_meter_old is also 1.
+* Using older driver versions, flow_meter_old can be 1
+* while flow_meter is 0.
+*/
uint8_t log_max_flow_meter;
/* Power of the maximum supported meters. */
uint8_t flow_meter_reg_c_ids;
diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index 4c764d09cf..751dda2537 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -1474,13 +1474,13 @@ struct mlx5_ifc_qos_cap_bits {
u8 reserved_at_4[0x1];
u8 packet_pacing_burst_bound[0x1];
u8 packet_pacing_typical_size[0x1];
- u8 flow_meter_srtcm[0x1];
+ u8 flow_meter_old[0x1];
u8 reserved_at_8[0x8];
u8 log_max_flow_meter[0x8];
u8 flow_meter_reg_id[0x8];
u8 wqe_rate_pp[0x1];
u8 reserved_at_25[0x7];
- u8 flow_meter_reg_share[0x1];
+ u8 flow_meter[0x1];
u8 reserved_at_2e[0x17];
u8 packet_pacing_max_rate[0x20];
u8 packet_pacing_min_rate[0x20];
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index a8cc5f3116..9b95b9fe31 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -1145,7 +1145,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
}
#if defined(HAVE_MLX5DV_DR) && defined(HAVE_MLX5_DR_CREATE_ACTION_FLOW_METER)
if (config->hca_attr.qos.sup &&
- config->hca_attr.qos.srtcm_sup &&
+ config->hca_attr.qos.flow_meter_old &&
config->dv_flow_en) {
uint8_t reg_c_mask =
config->hca_attr.qos.flow_meter_reg_c_ids;
@@ -1173,7 +1173,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
- 1 + REG_C_0;
priv->mtr_en = 1;
priv->mtr_reg_share =
- config->hca_attr.qos.flow_meter_reg_share;
+ config->hca_attr.qos.flow_meter;
DRV_LOG(DEBUG, "The REG_C meter uses is %d"
Re: [dpdk-dev] [PATCH v3] bus/pci: nvme on Windows requires class id and bus
> Subject: [PATCH v3] bus/pci: nvme on Windows requires class id and bus
>
> External email: Use caution opening links or attachments
>
>
> Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID
> and device.bus fields. Decode the class ID from the PCI device info strings
> if it
> is present and set device.bus.
>
> Signed-off-by: Nick Connolly
> ---
> v3:
> * Put version history at top - v2 mistakenly had it after the diffs
>
> v2:
> * If only a 4-digit class ID is available, convert it to 6-digit format
>
> drivers/bus/pci/windows/pci.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index f66258452..d380fc1ae 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -280,17 +280,29 @@ parse_pci_hardware_id(const char *buf, struct
> rte_pci_id *pci_id) {
> int ids = 0;
> uint16_t vendor_id, device_id;
> - uint32_t subvendor_id = 0;
> + uint32_t subvendor_id = 0, class_id = 0;
> + const char *cp;
>
> ids = sscanf_s(buf, "PCI\\VEN_%" PRIx16 "&DEV_%" PRIx16
> "&SUBSYS_%"
> PRIx32, &vendor_id, &device_id, &subvendor_id);
> if (ids != 3)
> return -1;
>
> + /* Try and find PCI class ID */
> + for (cp = buf; !(cp[0] == 0 && cp[1] == 0); cp++)
> + if (*cp == '&' && sscanf_s(cp,
> + "&CC_%" PRIx32, &class_id) == 1) {
> + /* Convert 4-digit class IDs to 6-digit format */
> + if (strspn(cp + 4, "0123456789abcdefABCDEF") == 4)
Maybe we can move this format string to a define in the header, something like
RTE_PCI_DRV_CLASSID_FMT?
> + class_id <<= 8;
> + break;
> + }
> +
> pci_id->vendor_id = vendor_id;
> pci_id->device_id = device_id;
> pci_id->subsystem_device_id = subvendor_id >> 16;
> pci_id->subsystem_vendor_id = subvendor_id & 0x;
> + pci_id->class_id = class_id;
> return 0;
> }
>
> @@ -339,6 +351,7 @@ pci_scan_one(HDEVINFO dev_info,
> PSP_DEVINFO_DATA device_info_data)
> if (ret != 0)
> goto end;
>
> + dev->device.bus = &rte_pci_bus.bus;
> dev->addr = addr;
> dev->id = pci_id;
> dev->max_vfs = 0; /* TODO: get max_vfs */
> --
> 2.25.1
Re: [dpdk-dev] [PATCH] net/iavf: fix default RSS configuration
> -Original Message-
> From: Ding, Xuan
> Sent: Sunday, January 31, 2021 6:47 PM
> To: Zhang, Qi Z ; Wu, Jingjing ;
> Xing, Beilei
> Cc: dev@dpdk.org; Ding, Xuan
> Subject: [PATCH] net/iavf: fix default RSS configuration
>
> Add advanced RSS offloads check due to some legacy driver(kernel/DPDK PF)
> does not support virtual channel command VIRTCHNL_OP_RSS_HENA with
> hena = 0 and VIRTCHNL_OP_ADD_RSS_CFG.
>
> Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS")
Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS")
>
> Signed-off-by: Xuan Ding
Acked-by: Qi Zhang
Applied to dpdk-next-net-intel.
Thanks
Qi
[dpdk-dev] [Bug 530] Lack of Support for Inner RSS Header Hashing (Feature 2.21)
https://bugs.dpdk.org/show_bug.cgi?id=530 Zhang, RobinX (robinx.zh...@intel.com) changed: What|Removed |Added Resolution|--- |FIXED Status|IN_PROGRESS |RESOLVED --- Comment #4 from Zhang, RobinX (robinx.zh...@intel.com) --- set to RESOLVED FIXED -- You are receiving this mail because: You are the assignee for the bug.
[dpdk-dev] [Bug 613] [dpdk-21.02] rule lost after port stopped
https://bugs.dpdk.org/show_bug.cgi?id=613 Zhang, RobinX (robinx.zh...@intel.com) changed: What|Removed |Added Resolution|--- |WONTFIX CC||robinx.zh...@intel.com Status|UNCONFIRMED |RESOLVED --- Comment #2 from Zhang, RobinX (robinx.zh...@intel.com) --- Expected behavior, set to RESOLVED WONTFIX -- You are receiving this mail because: You are the assignee for the bug.
[dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask
From: Alvin Zhang
The absolute field offsets of IPv4 or IPv6 header are related to
hardware configuration. The X710 and X722 have different hardware
configurations, and users can even modify the hardware configuration.
Therefore, The default values cannot be used when calculating mask
offset.
The following flows can be created on X722 NIC, but the packet will
not enter the queue 3:
flow create 0 ingress pattern eth / ipv4 proto is 255 / end
actions queue index 3 / end
pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
actions queue index 3 / end
pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
actions queue index 3 / end
pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
queue index 3 / end
pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
This patch read the field offsets from the NIC and return the mask
register value.
Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director")
Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields")
Cc: sta...@dpdk.org
Signed-off-by: Alvin Zhang
---
v2: Update commit log
---
drivers/net/i40e/i40e_ethdev.c | 158 +++--
drivers/net/i40e/i40e_ethdev.h | 4 +-
drivers/net/i40e/i40e_flow.c | 2 +-
3 files changed, 125 insertions(+), 39 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 946994b..f167b5f 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -202,12 +202,12 @@
#define I40E_TRANSLATE_INSET 0
#define I40E_TRANSLATE_REG 1
-#define I40E_INSET_IPV4_TOS_MASK0x0009FF00UL
-#define I40E_INSET_IPv4_TTL_MASK0x000D00FFUL
-#define I40E_INSET_IPV4_PROTO_MASK 0x000DFF00UL
-#define I40E_INSET_IPV6_TC_MASK 0x0009F00FUL
-#define I40E_INSET_IPV6_HOP_LIMIT_MASK 0x000CFF00UL
-#define I40E_INSET_IPV6_NEXT_HDR_MASK 0x000C00FFUL
+#define I40E_INSET_IPV4_TOS_MASK0xFF00UL
+#define I40E_INSET_IPV4_TTL_MASK0x00FFUL
+#define I40E_INSET_IPV4_PROTO_MASK 0xFF00UL
+#define I40E_INSET_IPV6_TC_MASK 0xF00FUL
+#define I40E_INSET_IPV6_HOP_LIMIT_MASK 0xFF00UL
+#define I40E_INSET_IPV6_NEXT_HDR_MASK 0x00FFUL
/* PCI offset for querying capability */
#define PCI_DEV_CAP_REG0xA4
@@ -220,6 +220,25 @@
/* Bit mask of Extended Tag enable/disable */
#define PCI_DEV_CTRL_EXT_TAG_MASK (1 << PCI_DEV_CTRL_EXT_TAG_SHIFT)
+#define I40E_GLQF_PIT_IPV4_START 2
+#define I40E_GLQF_PIT_IPV4_COUNT 2
+#define I40E_GLQF_PIT_IPV6_START 4
+#define I40E_GLQF_PIT_IPV6_COUNT 2
+
+#define I40E_GLQF_PIT_SOURCE_OFF_GET(a)\
+ (((a) & I40E_GLQF_PIT_SOURCE_OFF_MASK) >> \
+I40E_GLQF_PIT_SOURCE_OFF_SHIFT)
+
+#define I40E_GLQF_PIT_DEST_OFF_GET(a) \
+ (((a) & I40E_GLQF_PIT_DEST_OFF_MASK) >> \
+I40E_GLQF_PIT_DEST_OFF_SHIFT)
+
+#define I40E_GLQF_PIT_FSIZE_GET(a) (((a) & I40E_GLQF_PIT_FSIZE_MASK) >> \
+I40E_GLQF_PIT_FSIZE_SHIFT)
+
+#define I40E_GLQF_PIT_BUILD(off, mask) (((off) << 16) | (mask))
+#define I40E_FDIR_FIELD_OFFSET(a) ((a) >> 1)
+
static int eth_i40e_dev_init(struct rte_eth_dev *eth_dev, void *init_params);
static int eth_i40e_dev_uninit(struct rte_eth_dev *eth_dev);
static int i40e_dev_configure(struct rte_eth_dev *dev);
@@ -9417,49 +9436,116 @@ i40e_status_code i40e_replace_gtp_cloud_filter(struct
i40e_pf *pf)
return val;
}
+static int
+i40e_fd_get_field_offset(struct i40e_hw *hw, uint32_t pit_reg_start,
+uint32_t pit_reg_count, uint32_t hdr_off)
+{
+ const uint32_t pit_reg_end = pit_reg_start + pit_reg_count;
+ uint32_t field_off = I40E_FDIR_FIELD_OFFSET(hdr_off);
+ uint32_t i, reg_val, src_off, count;
+
+ for (i = pit_reg_start; i < pit_reg_end; i++) {
+ reg_val = i40e_read_rx_ctl(hw, I40E_GLQF_PIT(i));
+
+ src_off = I40E_GLQF_PIT_SOURCE_OFF_GET(reg_val);
+ count = I40E_GLQF_PIT_FSIZE_GET(reg_val);
+
+ if (src_off <= field_off && (src_off + count) > field_off)
+ break;
+ }
+
+ if (i >= pit_reg_end) {
+ PMD_DRV_LOG(ERR,
+ "Hardware GLQF_PIT configuration does not support
this field mask");
+ return -1;
+ }
+
+ return I40E_GLQF_PIT_DEST_OFF_GET(reg_val) + field_off - src_off;
+}
+
int
-i40e_generate_inset_mask_reg(uint64_t inset, uint32_t *mask, uint8_t nb_elem)
+i40e_generate_inset_mask_reg(struct i40e_hw *hw, uint64_t inset,
+uint32_t *mask, uint8_t nb_elem)
{
- uint8_t i, idx = 0;
[dpdk-dev] [Bug 631] [dpdk-21.02] vdev_primary_secondary/Virtio_primary_and_secondary_process: start dpdk-symmetric_mp occur core dumped in vm.
https://bugs.dpdk.org/show_bug.cgi?id=631
Bug ID: 631
Summary: [dpdk-21.02]
vdev_primary_secondary/Virtio_primary_and_secondary_pr
ocess: start dpdk-symmetric_mp occur core dumped in
vm.
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: vhost/virtio
Assignee: dev@dpdk.org
Reporter: weix.l...@intel.com
Target Milestone: ---
DPDK version: Use make showversion or for a non-released version: git remote -v
&& git show-ref --heads
21.02.0-rc2:3021257a8111d204dc7741bd67a2502efffb6842
Other software versions: QEMU-3.0.0
OS: Ubuntu 20.04.1 LTS/5.10.0-051000-generic
Compiler: gcc version 9.3.0 (Ubuntu 9.3.0-10ubuntu2)
Hardware platform: Intel(R) Xeon(R) Platinum 8280M CPU @ 2.70GHz
NIC hardware: fortville_spirit.
NIC driver: 5.10.0-051000-generic
NIC firmware: 8.00 0x80008b8a 1.2766.0
Test Setup
Steps to reproduce
List the steps to reproduce the issue.
1.Bind port to vfio-pci
dpdk-devbind.py --force --bind=vfio-pci :af:00.0 :af:00.1
2.Start testpmd on vhost
x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2,3,4,5,6,7,8,9,10,11,12 -n 4
-a :af:00.0 --file-prefix=vhost_86314_20210131132233 --vdev
'net_vhost0,iface=/root/dpdk/vhost-net0,queues=2,client=1' --vdev
'net_vhost1,iface=/root/dpdk/vhost-net1,queues=2,client=1' -- -i --nb-cores=4
--rxq=2 --txq=2 --txd=1024 --rxd=1024
set fwd txonly
start
3.Start vm
taskset -c 46,47,48,49,50,51,52,53 /home/QEMU/qemu-4.2.1/bin/qemu-system-x86_64
-name vm0 -enable-kvm -pidfile /tmp/.vm0.pid -daemonize -monitor
unix:/tmp/vm0_monitor.sock,server,nowait -netdev
user,id=nttsip1,hostfwd=tcp:10.240.183.220:6000-:22 -device
e1000,netdev=nttsip1 -chardev
socket,id=char0,path=/root/dpdk/vhost-net0,server -netdev
type=vhost-user,id=netdev0,chardev=char0,vhostforce,queues=2 -device
virtio-net-pci,netdev=netdev0,mac=52:54:00:00:00:02,mrg_rxbuf=on,mq=on,vectors=6
-chardev socket,id=char1,path=/root/dpdk/vhost-net1,server -netdev
type=vhost-user,id=netdev1,chardev=char1,vhostforce,queues=2 -device
virtio-net-pci,netdev=netdev1,mac=52:54:00:00:00:03,mrg_rxbuf=on,mq=on,vectors=6
-cpu host -smp 8 -m 8192 -object
memory-backend-file,id=mem,size=8192M,mem-path=/mnt/huge,share=on -numa
node,memdev=mem -mem-prealloc -chardev
socket,path=/tmp/vm0_qga0.sock,server,nowait,id=vm0_qga0 -device virtio-serial
-device virtserialport,chardev=vm0_qga0,name=org.qemu.guest_agent.0 -vnc :4
-drive file=/home/image/ubuntu2004.img
4.Config vm and build dpdk in vm
echo 0 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
echo 1024 >
/sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages
umount `awk '/hugetlbfs/ { print $2 }' /proc/mounts`
awk '/hugetlbfs/ { print $2 }' /proc/mounts
mkdir -p /mnt/huge
mount -t hugetlbfs nodev /mnt/huge
cat /proc/mounts |grep hugetlbfs
rmmod vfio_pci
rmmod vfio_iommu_type1
rmmod vfio
modprobe vfio
modprobe vfio-pci
echo 1 > /sys/module/vfio/parameters/enable_unsafe_noiommu_mode
usertools/dpdk-devbind.py --force --bind=vfio-pci :00:04.0 :00:05.0
rm -rf x86_64-native-linuxapp-gcc
CC=gcc meson -Denable_kmods=True -Dlibdir=lib --default-library=static
x86_64-native-linuxapp-gcc
ninja -C x86_64-native-linuxapp-gcc -j 8
cp ./examples/multi_process/symmetric_mp/main.c .
sed -i '/.offloads = DEV_RX_OFFLOAD_CHECKSUM,/d'
./examples/multi_process/symmetric_mp/main.c
sed -i 's/ETH_MQ_RX_RSS,/ETH_MQ_RX_NONE,/g'
./examples/multi_process/symmetric_mp/main.c
meson configure -Dexamples=multi_process/symmetric_mp
x86_64-native-linuxapp-gcc
ninja -C x86_64-native-linuxapp-gcc
5.Start dpdk-symmetric_mp in vm
x86_64-native-linuxapp-gcc/examples/dpdk-symmetric_mp -l 0 -n 4
--proc-type=auto -- -p 3 --num-procs=2 --proc-id=0
Show the output from the previous commands.
root@vmubuntu2004:~/dpdk# x86_64-native-linuxapp-gcc/examples/dpdk-symmetric_mp
-l 0 -n 4 --proc-type=auto -- -p 3 --num-procs=2 --proc-id=0
EAL: Detected 8 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Auto-detected process type: PRIMARY
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: No available 1048576 kB hugepages reported
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: Invalid NUMA socket, default to 0
EAL: Invalid NUMA socket, default to 0
EAL: Probe PCI driver: net_virtio (1af4:1000) device: :00:04.0 (socket 0)
EAL: using IOMMU type 8 (No-IOMMU)
EAL: Ignore mapping IO port bar(0)
EAL: Invalid NUMA socket, default to 0
EAL: Probe PCI driver: net_virtio (1af4:1000) device: :00:05.0 (socket 0)
EAL: Ignore mapping IO port bar(0)
Segmentation fault (core dumped)
Expected Result
Explain what is the expected result in text or as an example output:
# Start dpdk-symmetric_mp in vm normally.
Regression
Is this issue a regression: (Y)
Version the regr
[dpdk-dev] [PATCH V1] doc: add known issue of X722 firmware restriction
Currently, X722 firmware doesn't support to add more than one mirror rule in one vsi. Signed-off-by: Liulingyu --- doc/guides/nics/i40e.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 20c998398c..c9de2e19aa 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -723,6 +723,11 @@ When programming cloud filters for IPv4/6_UDP/TCP/SCTP with SRC port only or DST it will make any cloud filter using inner_vlan or tunnel key invalid. Default configuration will be recovered only by NIC core reset. +Mirror rule limitation for X722 +~~~ + +Due to firmware restriction of X722, the same VSI cannot have more than one mirror rule. + High Performance of Small Packets on 40GbE NIC -- -- 2.25.1
Re: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask
> -Original Message-
> From: dev On Behalf Of Zhang,Alvin
> Sent: Monday, February 1, 2021 10:41 AM
> To: Guo, Jia ; Xing, Beilei ; Zhang,
> Qi Z
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix inputset field mask
>
> From: Alvin Zhang
>
> The absolute field offsets of IPv4 or IPv6 header are related to hardware
> configuration. The X710 and X722 have different hardware configurations,
> and users can even modify the hardware configuration.
> Therefore, The default values cannot be used when calculating mask offset.
>
> The following flows can be created on X722 NIC, but the packet will not enter
> the queue 3:
> flow create 0 ingress pattern eth / ipv4 proto is 255 / end
> actions queue index 3 / end
> pkt = Ether()/IP(ttl=63, proto=255)/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv4 tos is 50 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IP(tos=50)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 tc is 12 / udp / end
> actions queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/UDP()/Raw('X'*40)
>
> flow create 0 ingress pattern eth / ipv6 hop is 34 / end actions
> queue index 3 / end
> pkt = Ether()/IPv6(tc=12,hlim=34,fl=0x98765)/Raw('X'*40)
>
> This patch read the field offsets from the NIC and return the mask register
> value.
>
> Fixes: 98f055707685 ("i40e: configure input fields for RSS or flow director")
> Fixes: 92cf7f8ec082 ("i40e: allow filtering on more IP header fields")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Alvin Zhang
> ---
>
> v2: Update commit log
> ---
>
> +static int
> +i40e_fd_get_field_offset(struct i40e_hw *hw, uint32_t pit_reg_start,
It's not only for fdir, but also for RSS, so better to remove '_fd' in the
function name.
> + uint32_t pit_reg_count, uint32_t hdr_off) {
Besides, since this patch is too HW specific and large, I suggest we need:
1) regression test first.
2) verify RSS with private API.
But RC3 is coming, we may have no much time for all tests, so can you submit
the patch after 21.02 release?
BR,
Beilei
[dpdk-dev] [PATCH] net/ice: fix eth rss type checking
For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask
to fix rss rule cannot be created when set eth as rss type.
Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing")
Signed-off-by: Xuan Ding
---
drivers/net/ice/ice_hash.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index aee4761625..ff0c55b4da 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -424,24 +424,24 @@ struct ice_rss_hash_cfg empty_tmplt = {
#define ICE_RSS_TYPE_GTPU_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
ETH_RSS_GTPU)
+/* PPPOE*/
+#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+
/* PPPOE IPv4 */
#define ICE_RSS_TYPE_PPPOE_IPV4(ICE_RSS_TYPE_INNER_IPV4 | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_UDP(ICE_RSS_TYPE_INNER_IPV4_UDP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_TCP(ICE_RSS_TYPE_INNER_IPV4_TCP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
/* PPPOE IPv6 */
#define ICE_RSS_TYPE_PPPOE_IPV6(ICE_RSS_TYPE_INNER_IPV6 | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_UDP(ICE_RSS_TYPE_INNER_IPV6_UDP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_TCP(ICE_RSS_TYPE_INNER_IPV6_TCP | \
-ETH_RSS_PPPOE)
-
-/* PPPOE*/
-#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
/* ESP, AH, L2TPV3 and PFCP */
#define ICE_RSS_TYPE_IPV4_ESP (ETH_RSS_ESP | ETH_RSS_IPV4)
--
2.17.1
[dpdk-dev] [PATCH v2] net/ice: fix rss type checking
For pattern MAC_PPPOE_IPV4/6, add ETH_RSS_ETH into insput_set_mask
to fix rss rule cannot be created when set eth as rss type.
Fixes: 0d84f86c3022("net/ice: fix GTPU header parsing")
Signed-off-by: Xuan Ding
---
v2:
* Refine the commit title.
* Adjust the indentation by adding a space.
---
drivers/net/ice/ice_hash.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index aee4761625..be63f09cab 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -424,24 +424,24 @@ struct ice_rss_hash_cfg empty_tmplt = {
#define ICE_RSS_TYPE_GTPU_IPV6_TCP (ICE_RSS_TYPE_INNER_IPV6_TCP | \
ETH_RSS_GTPU)
+/* PPPOE */
+#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+
/* PPPOE IPv4 */
#define ICE_RSS_TYPE_PPPOE_IPV4(ICE_RSS_TYPE_INNER_IPV4 | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_UDP(ICE_RSS_TYPE_INNER_IPV4_UDP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV4_TCP(ICE_RSS_TYPE_INNER_IPV4_TCP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
/* PPPOE IPv6 */
#define ICE_RSS_TYPE_PPPOE_IPV6(ICE_RSS_TYPE_INNER_IPV6 | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_UDP(ICE_RSS_TYPE_INNER_IPV6_UDP | \
-ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
#define ICE_RSS_TYPE_PPPOE_IPV6_TCP(ICE_RSS_TYPE_INNER_IPV6_TCP | \
-ETH_RSS_PPPOE)
-
-/* PPPOE*/
-#define ICE_RSS_TYPE_PPPOE (ETH_RSS_ETH | ETH_RSS_PPPOE)
+ICE_RSS_TYPE_PPPOE)
/* ESP, AH, L2TPV3 and PFCP */
#define ICE_RSS_TYPE_IPV4_ESP (ETH_RSS_ESP | ETH_RSS_IPV4)
--
2.17.1
Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix vid allocation race
Hi Peng & Fei,
> -Original Message-
> From: dev On Behalf Of Peng He
> Sent: Friday, January 29, 2021 3:36 PM
> To: dev@dpdk.org
> Cc: maxime.coque...@redhat.com
> Subject: [dpdk-dev] [PATCH] lib/librte_vhost: fix vid allocation race
Fix the title to 'vhost: X'
>
> From: "chenwei.0515"
This should not be here.. you could just delete it as the author is already
in commit message.
>
> vhost_new_devcie might be called in different threads at the same time.
s/devcie/device
> thread 1(config thread)
> rte_vhost_driver_start
>->vhost_user_start_client
>->vhost_user_add_connection
> -> vhost_new_device
>
> thread 2(vhost-events)
> vhost_user_read_cb
>->vhost_user_msg_handler (return value < 0)
> -> vhost_user_start_client
> -> vhost_new_device
>
> So there could be a case that a same vid has been allocated twice, or
> some vid might be lost in DPDK lib however still held by the upper
> applications.
Good catch! I checked the code and find there exists cases that different
threads
may allocate vhost slot.
And I also find that other functions which use the global vhost_devices[] may
also
meet the same problem. For example, vhost_destroy_device() could be called by
different
thread. So I suggest to fix the problem completely in all related functions like
vhost_destroy_device() and get_device(). What do you think?
If you agree with above, note that the title should also be changed.
Besides, please also add 'Fixes:$COMMID_ID' and cc to sta...@dpdk.org so it
could be
fixed in LTS. You can check other commit for reference.
>
> Reported-by: Peng He
> Signed-off-by: Fei Chen
> Reviewed-by: Zhihong Wang
> ---
> lib/librte_vhost/vhost.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index efb136edd1..db11d293d2 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -26,6 +26,7 @@
> #include "vhost_user.h"
>
> struct virtio_net *vhost_devices[MAX_VHOST_DEVICE];
> +pthread_mutex_t vhost_dev_lock = PTHREAD_MUTEX_INITIALIZER;
There's a duplicate space between 'pthread_mutex_t' and 'vhost_dev_lock',
Let's just leave one 😊
Thanks,
Chenbo
>
> /* Called with iotlb_lock read-locked */
> uint64_t
> @@ -645,6 +646,7 @@ vhost_new_device(void)
> struct virtio_net *dev;
> int i;
>
> + pthread_mutex_lock(&vhost_dev_lock);
> for (i = 0; i < MAX_VHOST_DEVICE; i++) {
> if (vhost_devices[i] == NULL)
> break;
> @@ -653,6 +655,7 @@ vhost_new_device(void)
> if (i == MAX_VHOST_DEVICE) {
> VHOST_LOG_CONFIG(ERR,
> "Failed to find a free slot for new device.\n");
> + pthread_mutex_unlock(&vhost_dev_lock);
> return -1;
> }
>
> @@ -660,10 +663,13 @@ vhost_new_device(void)
> if (dev == NULL) {
> VHOST_LOG_CONFIG(ERR,
> "Failed to allocate memory for new dev.\n");
> + pthread_mutex_unlock(&vhost_dev_lock);
> return -1;
> }
>
> vhost_devices[i] = dev;
> + pthread_mutex_unlock(&vhost_dev_lock);
> +
> dev->vid = i;
> dev->flags = VIRTIO_DEV_BUILTIN_VIRTIO_NET;
> dev->slave_req_fd = -1;
> --
> 2.23.0
Re: [dpdk-dev] [PATCH] vhost: avoid iotlb mempool allocation while IOMMU disabled
Hi Junjie, > -Original Message- > From: Wan Junjie > Sent: Saturday, January 30, 2021 12:39 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Wan Junjie ; Peng He > ; Zhihong Wang > Subject: [PATCH] vhost: avoid iotlb mempool allocation while IOMMU disabled > > If vhost device's IOMMU feature is disabled, iotlb mempool allocation > is unnecessary. > > Reported-by: Peng He > Signed-off-by: Wan Junjie > Reviewed-by: Zhihong Wang > --- > lib/librte_vhost/vhost.c | 6 -- > lib/librte_vhost/vhost_user.c | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index efb136edd..00c5040e2 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -352,7 +352,8 @@ free_vq(struct virtio_net *dev, struct vhost_virtqueue > *vq) > vhost_free_async_mem(vq); > } > rte_free(vq->batch_copy_elems); > - rte_mempool_free(vq->iotlb_pool); > + if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > + rte_mempool_free(vq->iotlb_pool); We could make it simpler, check vq->iotlb_pool is not NULL and then free the mempool, which ignores the problem that features may not be set yet (See below comment). Although we could also keep the original because rte_mempool_free will do the check, let's do it outside to avoid useless func call. > rte_free(vq); > } > > @@ -556,7 +557,8 @@ init_vring_queue(struct virtio_net *dev, uint32_t > vring_idx) > vq->callfd = VIRTIO_UNINITIALIZED_EVENTFD; > vq->notif_enable = VIRTIO_UNINITIALIZED_NOTIF; > > - vhost_user_iotlb_init(dev, vring_idx); > + if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM)) > + vhost_user_iotlb_init(dev, vring_idx); Note that when this func is called, dev->features are not set. So it's meaningless to do this. So, we should do it after the features are set. Thanks, Chenbo > /* Backends are set to -1 indicating an inactive device. */ > vq->backend = -1; > } > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index a60bb945a..d415607d7 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -575,7 +575,7 @@ numa_realloc(struct virtio_net *dev, int index) > dev->virtqueue[index] = vq; > vhost_devices[dev->vid] = dev; > > - if (old_vq != vq) > + if (old_vq != vq && (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) > vhost_user_iotlb_init(dev, index); > > return dev; > -- > 2.29.2
Re: [dpdk-dev] [PATCH v6 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD
On 2021/1/29 11:25, chris wrote: Hi ferruh and maxime: v6 changes: send v6. Let us discuss if merge in this or early next release. Ping. Sorry that forget to reply to previous message id. - change to DEBUG level for IO bar detection in pci_uio_ioport_map - rework the code in iobar branch - fixes commit message format issue - temporarily remove the 3rd patch for vfio path, leave it for future discusssion - rework against virtio_pmd_rework_v2 huawei.xhw (2): bus/pci: use PCI standard sysfs entry to get PIO address bus/pci: support MMIO in PCI ioport accessors drivers/bus/pci/linux/pci.c | 81 --- drivers/bus/pci/linux/pci_uio.c | 170 2 files changed, 118 insertions(+), 133 deletions(-)
Re: [dpdk-dev] [RFC PATCH v1] build: kni gcc cross-compilation support
> -Original Message- > From: Bruce Richardson > Sent: Friday, January 29, 2021 4:40 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; jerinjac...@gmail.com; > hemant.agra...@nxp.com; ferruh.yi...@intel.com; abo...@pensando.io; > dev@dpdk.org > Subject: Re: [RFC PATCH v1] build: kni gcc cross-compilation support > > On Fri, Jan 29, 2021 at 03:17:02PM +, Juraj Linkeš wrote: > > > > > > > -Original Message- > > > From: Bruce Richardson > > > Sent: Friday, January 29, 2021 4:01 PM > > > To: Juraj Linkeš > > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > > jerinjac...@gmail.com; hemant.agra...@nxp.com; > > > ferruh.yi...@intel.com; abo...@pensando.io; dev@dpdk.org > > > Subject: Re: [RFC PATCH v1] build: kni gcc cross-compilation support > > > > > > On Fri, Jan 29, 2021 at 02:47:57PM +, Juraj Linkeš wrote: > > > > > > > > > > > > > -Original Message- > > > > > From: Bruce Richardson > > > > > Sent: Friday, January 29, 2021 3:42 PM > > > > > To: Juraj Linkeš > > > > > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > > > > > jerinjac...@gmail.com; hemant.agra...@nxp.com; > > > > > ferruh.yi...@intel.com; abo...@pensando.io; dev@dpdk.org > > > > > Subject: Re: [RFC PATCH v1] build: kni gcc cross-compilation > > > > > support > > > > > > > > > > > > > > > Can we find some way of getting it working for both cases. > > > > > > > For native builds we want: > > > > > > > > > > > > > > * build kernel-dir = /lib/modules//build > > > > > > > * install dir = /lib/modules//extra/dpdk > > > > > > > > > > > > > > What are the expected equivalent paths for cross building? > > > > > > > > > > > > > > > > > > > The ubuntu1804 packages are installing aarch64 cross files to > > > > > > /usr/aarch64- > > > > > linux-gnu, so we could install it to /usr/aarch64-linux- > > > > > gnu/lib/modules//extra/dpdk, or > > > > > /usr//lib/modules//extra/dpdk in general. I > > > > > think we can get from 'make kernelversion', so that would > > > > > work, although I'm not sure this is the right place. > > > > > > > > > > > So what do you specify as the "kernel_dir" for the cross compile? > > > > > > > > > > > > > The place where I cloned (and cross-compiled) linux sources: > > > > $HOME/linux. > > > > > > > So I think the key problem is that for cross-compilation you need > > > two completely independent paths, while for native builds the two can be > linked. Is that correct? > > > > Assuming that we want to install cross modules, then yes, although > > it's incomplete. There's also the scenario when a user would use > > different kernel_dir than the default for native builds. I don't know > > why anyone would do that, but it is a theoretical possibility :-) > > In the cross-compile install case, is the prefix /usr/aarch64-linux-gnu/ > coming > from a DESTDIR environment variable? If it is, then we could just use the > kernel_dir option for the build path, and always install to > /lib/modules//... > allowing any cross-compiler relocation to take care of the rest. It's not coming from anywhere. What I meant is that an ubuntu package such as 'libatomic1-arm64-cross' installs its headers/libs under /usr/aarch64-linux-gnu/.
Re: [dpdk-dev] [PATCH] mbuf: remove unneeded EAL header include
> -Original Message-
> From: David Marchand
> Sent: Saturday, January 30, 2021 4:33 AM
> To: dev@dpdk.org
> Cc: konstantin.anan...@intel.com; bruce.richard...@intel.com;
> sta...@dpdk.org; Olivier Matz ; Ruifeng Wang
> ; Phil Yang ; Andrew
> Rybchenko ; tho...@monjalon.net
> Subject: [PATCH] mbuf: remove unneeded EAL header include
>
> There is no need for the direct inclusion of the generic/ header [1] now that
> we don't use the rte_atomic API anymore.
>
> 1: https://git.dpdk.org/dpdk/commit/?id=3eb860b08eb7
>
> Fixes: e41d27a68df6 ("mbuf: remove atomic reference counters")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
> ---
> lib/librte_mbuf/rte_mbuf_core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf_core.h
> b/lib/librte_mbuf/rte_mbuf_core.h index a85cabdd18..9d1609336a 100644
> --- a/lib/librte_mbuf/rte_mbuf_core.h
> +++ b/lib/librte_mbuf/rte_mbuf_core.h
> @@ -20,7 +20,6 @@
>
> #include
> #include
> -#include
>
> #ifdef __cplusplus
> extern "C" {
> --
> 2.23.0
Reviewed-by: Ruifeng Wang
