[dpdk-dev] No telemetry legacy support print

[Jerin Kollanukkaran]

"No telemetry legacy support " prints pops up on all the default dpdk 
applications now.
Is it worth to print? Since it using direct 'printf', we cannot even disable 
through dynamic logging.
Is possible to remove that print at least, if non legacy telemetry init is 
successful. 
Thoughts?

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] vfio: fix check for vfio_group_fd

[David Marchand]

On Thu, May 21, 2020 at 2:54 PM Burakov, Anatoly
 wrote:
>
> On 19-May-20 8:43 AM, David Marchand wrote:
> > On Tue, May 19, 2020 at 5:42 AM wangyunjian  wrote:
> >>
> >> From: Yunjian Wang 
> >>
> >> The issue is that a file descriptor at 0 is a valid one. Currently
> >> the file not found, the return value will be set to 0. As a result,
> >> it is impossible to distinguish between a correct descriptor and a
> >> failed return value. Fix it to return -ENOENT instead of 0.
> >>
> >> Fixes: b758423bc4fe ("vfio: fix race condition with sysfs")
> >> Fixes: ff0b67d1c868 ("vfio: DMA mappinge")
> >> Cc: sta...@dpdk.org
> >
> > This patch reverts the (marked for stable) fix b758423bc4fe ("vfio:
> > fix race condition with sysfs") and comes with a different fix.
> >
> > - Kevin, Luca, I would put this b758423bc4fe backport on hold.
> >
> > - Anatoly, I don't want to put 20.05 at risk.
> > My simple question for 20.05 is, should we revert b758423bc4fe?
>
> No, let's not revert anything.
>
> As far as i can tell, this patch is a more complete fix, but it
> essentially does the same thing, just in a different (and better) way.
> Still, i haven't reviewed it in detail.
>
> >
> > - This patchset will go to 20.08 as I don't feel confident in taking it now.
> >
>
> Yes, let's leave it for 20.08.

Thanks for the analysis Anatoly.


-- 
David Marchand

Re: [dpdk-dev] net/iavf: fix invalid flow access

[Zhang, Qi Z]

> -Original Message-
> From: Peng, Yuan 
> Sent: Friday, May 22, 2020 11:44 AM
> To: Guo, Jia ; Xing, Beilei ; Zhang,
> Qi Z ; Wu, Jingjing ; Yang,
> Qiming 
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
> 
> Subject: RE: [dpdk-dev] net/iavf: fix invalid flow access
> 
> Test-by Peng, Yuan 
> 
> -Original Message-
> From: dev  On Behalf Of Jeff Guo
> Sent: Friday, May 22, 2020 10:12 AM
> To: Xing, Beilei ; Zhang, Qi Z ;
> Wu, Jingjing ; Yang, Qiming
> 
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
> 
> Subject: [dpdk-dev] net/iavf: fix invalid flow access
> 
> When hash init, the default rss rules would be added, while hash uninit, the
> default rss rules should be deleted. Add the missing part in the hash uninit
> process. Also add invalid flow checking func in iavf generic flow to avoid the
> error of "Cannot access memory at address 0xXX" occur.
> 
> Fixes: 5ea614254332 ("net/iavf: fix VF reset for RSS")
> Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
> 
> Signed-off-by: Jeff Guo 

Acked-by: Qi Zhang 

Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter

[Yang, Qiming]

Hi, Guinan
I don't make sense for this commit log. Don't write like a test case. Please 
use technical expression.

Qiming
> -Original Message-
> From: dev  On Behalf Of Guinan Sun
> Sent: Friday, May 22, 2020 14:12
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in
> struct adapter
> 
> If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port
> reset process of
> 
> testpmd> start
> testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port
> testpmd> start 0 start
> 
> Then after this process, the mac_ctrl_frame_fwd has been change to "off",
> so we should delete "adapter->mac_ctrl_frame_fwd = 0;" from dev-stop.
> 
> In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get ()
> function.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: SunGuinan 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..dd4023f01 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> 
>   adapter->rss_reta_updated = 0;
> 
> - adapter->mac_ctrl_frame_fwd = 0;
> -
>   hw->adapter_stopped = true;
>  }
> 
> @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev,
> struct rte_eth_fc_conf *fc_conf)
>* MFLCN register.
>*/
>   mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
> + fc_conf->mac_ctrl_frame_fwd = mflcn_reg;
> +
>   if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
>   rx_pause = 1;
>   else
> --
> 2.17.1

Re: [dpdk-dev] No telemetry legacy support print

[David Marchand]

On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran  wrote:
>
> "No telemetry legacy support " prints pops up on all the default dpdk 
> applications now.
> Is it worth to print? Since it using direct 'printf', we cannot even disable 
> through dynamic logging.
> Is possible to remove that print at least, if non legacy telemetry init is 
> successful.
> Thoughts?

This init function is odd as it calls printf in error and warning
cases and sets an error string when it succeeds.
Let's remove the two printf in this init function.

If we really care about the warning message, we have to initialise
*err_str to NULL (+ this must be described in the function prototype).
In EAL init, we can then add a rte_eal_init_alert with the error
string when telemetry init fails and maybe a warning message if
err_str != NULL.


-- 
David Marchand

Re: [dpdk-dev] [PATCH] net/ixgbe: fix MAC security private API

[Yang, Qiming]

Hi, 
Do you copy the commit log of the other patch? I think this patch don't touch 
any private API.

Qiming

> -Original Message-
> From: dev  On Behalf Of Guinan Sun
> Sent: Friday, May 22, 2020 12:40
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix MAC security private API
> 
> The driver type need to be checked in private API.
> The patch fixes the issue.
> 
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Guinan Sun 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c  | 14 --
> drivers/net/ixgbe/ixgbe_ethdev.h  |  4 ++--
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 10 ++
>  3 files changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..3e9c0f895 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -8988,7 +8988,7 @@ ixgbe_dev_macsec_setting_reset(struct
> rte_eth_dev *dev)
>   macsec->replayprotect_en = 0;
>  }
> 
> -void
> +int
>  ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
>   struct ixgbe_macsec_setting
> *macsec_setting)  { @@ -8997,6 +8997,9 @@
> ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
>   uint8_t en = macsec_setting->encrypt_en;
>   uint8_t rp = macsec_setting->replayprotect_en;
> 
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
>   /**
>* Workaround:
>* As no ixgbe_disable_sec_rx_path equivalent is @@ -9057,14
> +9060,19 @@ ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
>* just call the hand-written one directly for now.
>*/
>   ixgbe_enable_sec_tx_path_generic(hw);
> +
> + return 0;
>  }
> 
> -void
> +int
>  ixgbe_dev_macsec_register_disable(struct rte_eth_dev *dev)  {
>   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
>   uint32_t ctrl;
> 
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
>   /**
>* Workaround:
>* As no ixgbe_disable_sec_rx_path equivalent is @@ -9106,6
> +9114,8 @@ ixgbe_dev_macsec_register_disable(struct rte_eth_dev *dev)
>* just call the hand-written one directly for now.
>*/
>   ixgbe_enable_sec_tx_path_generic(hw);
> +
> + return 0;
>  }
> 
>  RTE_PMD_REGISTER_PCI(net_ixgbe, rte_ixgbe_pmd); diff --git
> a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
> index 3d78b2ee2..c14cadab4 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> @@ -755,10 +755,10 @@ int ixgbe_action_rss_same(const struct
> rte_flow_action_rss *comp,  int ixgbe_config_rss_filter(struct rte_eth_dev
> *dev,
>   struct ixgbe_rte_flow_rss_conf *conf, bool add);
> 
> -void ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
> +int ixgbe_dev_macsec_register_enable(struct rte_eth_dev *dev,
>   struct ixgbe_macsec_setting *macsec_setting);
> 
> -void ixgbe_dev_macsec_register_disable(struct rte_eth_dev *dev);
> +int ixgbe_dev_macsec_register_disable(struct rte_eth_dev *dev);
> 
>  void ixgbe_dev_macsec_setting_save(struct rte_eth_dev *dev,
>   struct ixgbe_macsec_setting *macsec_setting); diff --git
> a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> index 8bcaded6e..40cc7058f 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> @@ -517,6 +517,7 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port,
> uint8_t en, uint8_t rp)  {
>   struct rte_eth_dev *dev;
>   struct ixgbe_macsec_setting macsec_setting;
> + int ret = 0;
> 
>   RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> 
> @@ -528,15 +529,16 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port,
> uint8_t en, uint8_t rp)
> 
>   ixgbe_dev_macsec_setting_save(dev, &macsec_setting);
> 
> - ixgbe_dev_macsec_register_enable(dev, &macsec_setting);
> + ret = ixgbe_dev_macsec_register_enable(dev, &macsec_setting);
> 
> - return 0;
> + return ret;
>  }
> 
>  int
>  rte_pmd_ixgbe_macsec_disable(uint16_t port)  {
>   struct rte_eth_dev *dev;
> + int ret = 0;
> 
>   RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> 
> @@ -544,9 +546,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
> 
>   ixgbe_dev_macsec_setting_reset(dev);
> 
> - ixgbe_dev_macsec_register_disable(dev);
> + ret = ixgbe_dev_macsec_register_disable(dev);
> 
> - return 0;
> + return ret;
>  }
> 
>  int
> --
> 2.17.1

Re: [dpdk-dev] No telemetry legacy support print

[Thomas Monjalon]

22/05/2020 09:47, David Marchand:
> On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran  
> wrote:
> >
> > "No telemetry legacy support " prints pops up on all the default dpdk 
> > applications now.
> > Is it worth to print? Since it using direct 'printf', we cannot even 
> > disable through dynamic logging.
> > Is possible to remove that print at least, if non legacy telemetry init is 
> > successful.
> > Thoughts?
> 
> This init function is odd as it calls printf in error and warning
> cases and sets an error string when it succeeds.
> Let's remove the two printf in this init function.
> 
> If we really care about the warning message, we have to initialise
> *err_str to NULL (+ this must be described in the function prototype).
> In EAL init, we can then add a rte_eal_init_alert with the error
> string when telemetry init fails and maybe a warning message if
> err_str != NULL.

There are 5 printf in telemetry.
The definitive fix should be to split EAL:
- 1 low-level layer offering arch and OS support, including early logs.
- 1 high-level layer including configuration parsing and rte_eal_init().

Re: [dpdk-dev] 【BUG REPORT】l3fwd-power can not exit by ctrl+c

[oulijun]

在 2020/5/20 15:22, David Marchand 写道:

Hello,

On Wed, May 20, 2020 at 5:18 AM oulijun  wrote:

 I am using 20.05-rc2 version to test based on HNS3 NIC hardware, and
found that after starting l3fwd-power,

using ctrl+c cannot force quit. But I revert the patch(33666b4 service:
fix crash on exit) and it is ok.


We had a fix in rc1 that is supposed to fix this.
https://git.dpdk.org/dpdk/commit?id=613ce6691c0d5ac0f99d7995f1e8e4ac86643882

Copying Anatoly and David H. too.


Hi, David Marchand
   I am only merged the patch(examples/l3fwd-power: implement proper 
shutdown) based on 20.05-rc0 and test. the bug is not resolved.
Can you provide me with complete solution?  I want to understand the 
cause of the whole problem


The gdb print as follows:
[root@centos-C3 build]# ./l3fwd-power -w :7d:00.1  -c 0xc00 -n 4 
-- -P -p 0x01 --config '(0,0,27)' --parse-ptype

EAL: Detected 128 lcore(s)
EAL: Detected 4 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: No available hugepages reported in hugepages-32768kB
EAL: No available hugepages reported in hugepages-64kB
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: PCI device :7d:00.1 on NUMA socket 0
EAL:   probe driver: 19e5:a221 net_hns3
Promiscuous mode selected
soft parse-ptype is enabled
POWER: Env isn't set yet!
POWER: Attempting to initialise ACPI cpufreq power management...
POWER: Power management governor of lcore 26 has been set to user space 
successfully

POWER: Initialized successfully for lcore 26 power management
POWER: Initialized successfully for lcore 27 power management
port 0 is not present on the board
EAL: Error - exiting with code: 1
  Cause: check_port_config failed
[root@centos-C3 build]# ./l3fwd-power -w :7d:00.1  -c 0xc00 -n 4 
-- -P -p 0x01 --config '(0,0,27)' --parse-ptype

EAL: Detected 128 lcore(s)
EAL: Detected 4 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'PA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: No available hugepages reported in hugepages-32768kB
EAL: No available hugepages reported in hugepages-64kB
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: PCI device :7d:00.1 on NUMA socket 0
EAL:   probe driver: 19e5:a221 net_hns3
EAL:   using IOMMU type 1 (Type 1)
EAL: Ignore mapping IO port bar(1)
EAL: Ignore mapping IO port bar(3)
Promiscuous mode selected
soft parse-ptype is enabled
POWER: Env isn't set yet!
POWER: Attempting to initialise ACPI cpufreq power management...
POWER: Initialized successfully for lcore 26 power management
POWER: Initialized successfully for lcore 27 power management
Initializing port 0 ... Creating queues: nb_rxq=1 nb_txq=2... Port 0 
modified RSS hash function based on hardware support,requested:0x20820 
configured:0x820

 Address:00:18:2D:01:00:9E, Allocated mbuf pool on socket 0
LPM: Adding route 0x01010100 / 24 (0)
LPM: Adding route 0x02010100 / 24 (1)
LPM: Adding route 0x03010100 / 24 (2)
LPM: Adding route 0x04010100 / 24 (3)
LPM: Adding route 0x05010100 / 24 (4)
LPM: Adding route 0x06010100 / 24 (5)
LPM: Adding route 0x07010100 / 24 (6)
LPM: Adding route 0x08010100 / 24 (7)
txq=26,0,0 txq=27,1,0

Initializing rx queues on lcore 26 ...
Initializing rx queues on lcore 27 ... rxq=0,0,0 Port 0: softly parse 
packet type info



Checking link status...:7d:00.1 
hns3_update_link_status(): Link status change to up!

done
Port 0 Link Up - speed 25000 Mbps - full-duplex
L3FWD_POWER: entering main loop on lcore 27
L3FWD_POWER:  -- lcoreid=27 portid=0 rxqueueid=0
L3FWD_POWER: lcore 26 has nothing to do
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
L3FWD_POWER: lcore 27 is waked up from rx interrupt on port 0 queue 0
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
L3FWD_POWER: lcore 27 is waked up from rx interrupt on port 0 queue 0
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
L3FWD_POWER: lcore 27 is waked up from rx interrupt on port 0 queue 0
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
L3FWD_POWER: lcore 27 is waked up from rx interrupt on port 0 queue 0
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
^C^C^C^C^C


Killed
[root@centos-C3 build]#
[root@centos-C3 build]#
[root@centos-C3 build]#
[root@centos-C3 build]# gdb
GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-114.el7
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 


This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "aarch64-redhat-linux-gnu".
For bug reporting instructions, please see:
.
(gdb) set args
(gdb)
(gdb)
(gdb) ./l3fwd-power -w :7d:00.1  -c 0xc00 -n 4 -- -P -p 0x01 
--config '(0,0,27)' --

Re: [dpdk-dev] [PATCH v2] doc: announce adoption of C11 atomic operations semantics

[Ananyev, Konstantin]

> 
> As agreed in the DPDK tech board [1], after 20.05 release, patches must
> use C11 atomic operations semantics with the help of wrappers.
> 
> [1] http://mails.dpdk.org/archives/dev/2020-April/165143.html
> 
> Signed-off-by: Honnappa Nagarahalli 
> Reviewed-by: Phil Yang 
> Reviewed-by: Ruifeng Wang 
> Acked-by: Hemant Agrawal 
> Acked-by: Jerin Jacob 
> ---
>  doc/guides/rel_notes/deprecation.rst | 13 +
>  1 file changed, 13 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 20aa745b7..01f99a0d6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -113,3 +113,16 @@ Deprecation Notices
>Python 2 support will be completely removed in 20.11.
>In 20.08, explicit deprecation warnings will be displayed when running
>scripts with Python 2.
> +
> +* rte_atomicNN_xxx: These APIs do not take memory order parameter. This does
> +  not allow for writing optimized code for all the CPU architectures 
> supported
> +  in DPDK. DPDK will adopt C11 atomic operations semantics and provide 
> wrappers
> +  using C11 atomic built-ins. These wrappers must be used for patches that
> +  need to be merged in 20.08 onwards. This change will not introduce any
> +  performance degradation.
> +
> +* rte_smp_*mb: These APIs provide full barrier functionality. However, many
> +  use cases do not require full barriers. To support such use cases, DPDK 
> will
> +  adopt C11 barrier semantics and provide wrappers using C11 atomic 
> built-ins.
> +  These wrappers must be used for patches that need to be merged in 20.08
> +  onwards. This change will not introduce any performance degradation.
> --

Acked-by: Konstantin Ananyev 

> 2.17.1

Re: [dpdk-dev] 【BUG REPORT】l3fwd-power can not exit by ctrl+c

[Burakov, Anatoly]

On 22-May-20 9:17 AM, oulijun wrote:



在 2020/5/20 15:22, David Marchand 写道:

Hello,

On Wed, May 20, 2020 at 5:18 AM oulijun  wrote:
 I am using 20.05-rc2 version to test based on HNS3 NIC hardware, 
and

found that after starting l3fwd-power,

using ctrl+c cannot force quit. But I revert the patch(33666b4 service:
fix crash on exit) and it is ok.


We had a fix in rc1 that is supposed to fix this.
https://git.dpdk.org/dpdk/commit?id=613ce6691c0d5ac0f99d7995f1e8e4ac86643882 



Copying Anatoly and David H. too.


Hi, David Marchand
    I am only merged the patch(examples/l3fwd-power: implement proper 
shutdown) based on 20.05-rc0 and test.


Why are you testing 20.05-rc0 when there is a later version that already 
has all of this fixed? What's the point of creating additional 
difficulties for yourself, and, more importantly, reporting bugs to the 
community that are already fixed while also not testing the version that 
has those fixes? What are you trying to do that requires you to use rc0 
instead of rc2 or later?


We know rc0 was buggy. We had one patch (linked to by David above) in 
rc1 that fixed it. We had another one in rc2 (linked by myself in 
another email: 
https://git.dpdk.org/dpdk/commit/?id=f4d1e19c293dc95073614f630ea729cf0bfb57b7) 
which completed the fix. Both of these patches are present in rc2 and 
later. So why not try and test rc2 or laster, instead of cherry-picking 
patches on top of rc0?


 the bug is not resolved.
Can you provide me with complete solution?  I want to understand the 
cause of the whole problem




The cause of the problem is described in the commit messages for the 
patches. The one David linked to was because l3fwd was exiting 
incorrectly and was relying on particulars of implementation of 
rte_exit() which exited the application straight away, without waiting 
for threads to finish. The one i linked to fixed an additional issue 
related to waiting for interrupts - there was no timeout, so the thread 
never woke up if there was no traffic, and thus rte_exit() couldn't 
finish as well.


All of the above was fixed by rc2, and later versions have these fixes 
as well. So, why are you insisting on using an outdated version for testing?


--
Thanks,
Anatoly

Re: [dpdk-dev] 【BUG REPORT】l3fwd-power can not exit by ctrl+c

[Hunt, David]

On 22/5/2020 9:17 AM, oulijun wrote:



在 2020/5/20 15:22, David Marchand 写道:

Hello,

On Wed, May 20, 2020 at 5:18 AM oulijun  wrote:
 I am using 20.05-rc2 version to test based on HNS3 NIC 
hardware, and

found that after starting l3fwd-power,

using ctrl+c cannot force quit. But I revert the patch(33666b4 service:
fix crash on exit) and it is ok.


We had a fix in rc1 that is supposed to fix this.
https://git.dpdk.org/dpdk/commit?id=613ce6691c0d5ac0f99d7995f1e8e4ac86643882 



Copying Anatoly and David H. too.


Hi, David Marchand
   I am only merged the patch(examples/l3fwd-power: implement proper 
shutdown) based on 20.05-rc0 and test. the bug is not resolved.
Can you provide me with complete solution?  I want to understand the 
cause of the whole problem




Hi Lijun,

    The complete solution is to use a version with all of the fixes, as 
Anatoly suggested previously. I have just checked out the latest tip of 
the master branch, and l3fwd-power exits gracefully with a single CTRL-C:



...
Checking link statusdone
Port 0 Link Up - speed 10 Mbps - full-duplex
L3FWD_POWER: entering main loop on lcore 27
L3FWD_POWER:  -- lcoreid=27 portid=0 rxqueueid=0
L3FWD_POWER: lcore 26 has nothing to do
L3FWD_POWER: lcore 27 sleeps until interrupt triggers
*^C*POWER: Power management governor of lcore 26 has been set back to  
successfully
POWER: Power management of lcore 26 has exited from 'performance' mode 
and been set back to the original
POWER: Power management governor of lcore 27 has been set back to 
successfully
POWER: Power management of lcore 27 has exited from 'performance' mode 
and been set back to the original

#


Rgds,
Dave.

Re: [dpdk-dev] [PATCH] net/ixgbe: fix MACsec private API

[Kevin Traynor]

On 22/05/2020 06:59, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
> 
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Guinan Sun 
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c 
> b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> index 8bcaded6e..9bff557f9 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> @@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, 
> uint8_t rp)
>  
>   dev = &rte_eth_devices[port];
>  
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
>   macsec_setting.offload_en = 1;
>   macsec_setting.encrypt_en = en;
>   macsec_setting.replayprotect_en = rp;
> @@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
>  
>   dev = &rte_eth_devices[port];
>  
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
>   ixgbe_dev_macsec_setting_reset(dev);
>  
>   ixgbe_dev_macsec_register_disable(dev);
> 

Acked-by: Kevin Traynor 

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API

[Ye Xiaolong]

On 05/22, Guinan Sun wrote:
>The driver type need to be checked in private API.
>The patch fixes the issue.
>
>Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Guinan Sun 
>---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c 
>b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>index 8bcaded6e..9bff557f9 100644
>--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
>+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>@@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, 
>uint8_t rp)
> 
>   dev = &rte_eth_devices[port];
> 
>+  if (!is_ixgbe_supported(dev))
>+  return -ENOTSUP;
>+
>   macsec_setting.offload_en = 1;
>   macsec_setting.encrypt_en = en;
>   macsec_setting.replayprotect_en = rp;
>@@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
> 
>   dev = &rte_eth_devices[port];
> 
>+  if (!is_ixgbe_supported(dev))
>+  return -ENOTSUP;
>+
>   ixgbe_dev_macsec_setting_reset(dev);
> 
>   ixgbe_dev_macsec_register_disable(dev);
>-- 
>2.17.1
>

Applied to dpdk-next-net-intel, Thanks.

Re: [dpdk-dev] net/iavf: fix invalid flow access

[Ye Xiaolong]

On 05/21, Jeff Guo wrote:
>When hash init, the default rss rules would be added, while hash uninit,
>the default rss rules should be deleted. Add the missing part in the hash
>uninit process. Also add invalid flow checking func in iavf generic flow
>to avoid the error of "Cannot access memory at address 0xXX" occur.
>
>Fixes: 5ea614254332 ("net/iavf: fix VF reset for RSS")
>Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
>
>Signed-off-by: Jeff Guo 
>---
> drivers/net/iavf/iavf_generic_flow.c | 24 
> drivers/net/iavf/iavf_hash.c | 12 
> 2 files changed, 28 insertions(+), 8 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_generic_flow.c 
>b/drivers/net/iavf/iavf_generic_flow.c
>index c0c67d0c7..b6c26c4fd 100644
>--- a/drivers/net/iavf/iavf_generic_flow.c
>+++ b/drivers/net/iavf/iavf_generic_flow.c
>@@ -935,6 +935,22 @@ iavf_flow_create(struct rte_eth_dev *dev,
>   return flow;
> }
> 
>+static bool
>+iavf_flow_is_valid(struct rte_flow *flow)
>+{
>+  struct iavf_flow_engine *engine;
>+  void *temp;
>+
>+  if (flow && flow->engine) {
>+  TAILQ_FOREACH_SAFE(engine, &engine_list, node, temp) {
>+  if (engine == flow->engine)
>+  return true;
>+  }
>+  }
>+
>+  return false;
>+}
>+
> static int
> iavf_flow_destroy(struct rte_eth_dev *dev,
> struct rte_flow *flow,
>@@ -945,10 +961,10 @@ iavf_flow_destroy(struct rte_eth_dev *dev,
>   struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(ad);
>   int ret = 0;
> 
>-  if (!flow || !flow->engine || !flow->engine->destroy) {
>+  if (!iavf_flow_is_valid(flow) || !flow->engine->destroy) {
>   rte_flow_error_set(error, EINVAL,
>  RTE_FLOW_ERROR_TYPE_HANDLE,
>- NULL, "Invalid flow");
>+ NULL, "Invalid flow destroy");
>   return -rte_errno;
>   }
> 
>@@ -1002,10 +1018,10 @@ iavf_flow_query(struct rte_eth_dev *dev,
>   IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
>   struct rte_flow_query_count *count = data;
> 
>-  if (!flow || !flow->engine || !flow->engine->query_count) {
>+  if (!iavf_flow_is_valid(flow) || !flow->engine->query_count) {
>   rte_flow_error_set(error, EINVAL,
>  RTE_FLOW_ERROR_TYPE_HANDLE,
>- NULL, "Invalid flow");
>+ NULL, "Invalid flow query");
>   return -rte_errno;
>   }
> 
>diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
>index 56ab170d8..af528863b 100644
>--- a/drivers/net/iavf/iavf_hash.c
>+++ b/drivers/net/iavf/iavf_hash.c
>@@ -887,7 +887,7 @@ static struct iavf_flow_parser iavf_hash_parser = {
> };
> 
> static int
>-iavf_hash_default_set(struct iavf_adapter *ad)
>+iavf_hash_default_set(struct iavf_adapter *ad, bool add)
> {
>   struct virtchnl_rss_cfg *rss_cfg;
>   uint16_t i;
>@@ -902,9 +902,10 @@ iavf_hash_default_set(struct iavf_adapter *ad)
>   rss_cfg->proto_hdrs = *iavf_hash_default_hdrs[i];
>   rss_cfg->rss_algorithm = VIRTCHNL_RSS_ALG_TOEPLITZ_ASYMMETRIC;
> 
>-  ret = iavf_add_del_rss_cfg(ad, rss_cfg, true);
>+  ret = iavf_add_del_rss_cfg(ad, rss_cfg, add);
>   if (ret) {
>-  PMD_DRV_LOG(ERR, "fail to add RSS configure");
>+  PMD_DRV_LOG(ERR, "fail to %s RSS configure",
>+  add ? "add" : "delete");
>   rte_free(rss_cfg);
>   return ret;
>   }
>@@ -941,7 +942,7 @@ iavf_hash_init(struct iavf_adapter *ad)
>   return ret;
>   }
> 
>-  ret = iavf_hash_default_set(ad);
>+  ret = iavf_hash_default_set(ad, true);
>   if (ret) {
>   PMD_DRV_LOG(ERR, "fail to set default RSS");
>   iavf_unregister_parser(parser, ad);
>@@ -1222,6 +1223,9 @@ iavf_hash_destroy(__rte_unused struct iavf_adapter *ad,
> static void
> iavf_hash_uninit(struct iavf_adapter *ad)
> {
>+  if (iavf_hash_default_set(ad, false))
>+  PMD_DRV_LOG(ERR, "fail to delete default RSS");
>+
>   iavf_unregister_parser(&iavf_hash_parser, ad);
> }
> 
>-- 
>2.20.1
>

Applied to dpdk-next-net-intel, Thanks.

[dpdk-dev] [PATCH 5/5] net/hns3: fix key length when configuring RSS

[Wei Hu (Xavier)]

From: Lijun Ou 

When users set the length of rss hash key greater than the supported
length by hardware, the pmd driver should intercept and can not
configure the wrong key into the hardware.

Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: sta...@dpdk.org

Signed-off-by: Lijun Ou 
Signed-off-by: Wei Hu (Xavier) 
---
 drivers/net/hns3/hns3_flow.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c
index aef301a..e3c2392 100644
--- a/drivers/net/hns3/hns3_flow.c
+++ b/drivers/net/hns3/hns3_flow.c
@@ -1475,6 +1475,14 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,
return -EINVAL;
}
 
+   if (rss_flow_conf.key_len &&
+   rss_flow_conf.key_len > RTE_DIM(rss_info->key)) {
+   hns3_err(hw,
+   "input hash key(%u) greater than supported len(%lu)",
+   rss_flow_conf.key_len, RTE_DIM(rss_info->key));
+   return -EINVAL;
+   }
+
/* Filter the unsupported flow types */
flow_types = rss_flow_conf.types & HNS3_ETH_RSS_SUPPORT;
if (flow_types != rss_flow_conf.types)
-- 
2.7.4

[dpdk-dev] [PATCH 2/5] net/hns3: fix promiscuous config not clear for PF on uninit

[Wei Hu (Xavier)]

From: Chengchang Tang 

Currently, promiscuous mode configuration are not cleared during
unintialziation based on hns3 PF device. The residual entries may cause
unnecessary bandwidth usage.

So, we need clear the PF's promisc mode status during the uninit.

Fixes: a45fd0aa0ea1 ("net/hns3: fix Rx queue search with broadcast packet")
Fixes: d51867db65c1 ("net/hns3: add initialization")
Cc: sta...@dpdk.org

Signed-off-by: Chengchang Tang 
Signed-off-by: Wei Hu (Xavier) 
---
 drivers/net/hns3/hns3_ethdev.c | 53 ++
 1 file changed, 43 insertions(+), 10 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 06c4886..1c06b8f 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3826,7 +3826,7 @@ hns3_set_promisc_mode(struct hns3_hw *hw, bool en_uc_pmc, 
bool en_mc_pmc)
 }
 
 static int
-hns3_clear_all_vfs_promisc_mode(struct hns3_hw *hw)
+hns3_promisc_init(struct hns3_hw *hw)
 {
struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
struct hns3_pf *pf = &hns->pf;
@@ -3834,16 +3834,54 @@ hns3_clear_all_vfs_promisc_mode(struct hns3_hw *hw)
uint16_t func_id;
int ret;
 
+   ret = hns3_set_promisc_mode(hw, false, false);
+   if (ret) {
+   PMD_INIT_LOG(ERR, "failed to set promisc mode, ret = %d", ret);
+   return ret;
+   }
+
+   /*
+* In current version VFs are not supported when PF is driven by DPDK
+* driver. After PF has been taken over by DPDK, the original VF will
+* be invalid. So, there is a possibility of entry residues. It should
+* clear VFs's promisc mode to avoid unnecessary bandwidth usage
+* during init.
+*/
for (func_id = HNS3_1ST_VF_FUNC_ID; func_id < pf->func_num; func_id++) {
hns3_promisc_param_init(¶m, false, false, false, func_id);
ret = hns3_cmd_set_promisc_mode(hw, ¶m);
-   if (ret)
+   if (ret) {
+   PMD_INIT_LOG(ERR, "failed to clear vf:%d promisc mode,"
+   " ret = %d", func_id, ret);
return ret;
+   }
}
 
return 0;
 }
 
+static void
+hns3_promisc_uninit(struct hns3_hw *hw)
+{
+   struct hns3_promisc_param param;
+   uint16_t func_id;
+   int ret;
+
+   func_id = HNS3_PF_FUNC_ID;
+
+   /*
+* In current version VFs are not supported when PF is driven by
+* DPDK driver, and VFs' promisc mode status has been cleared during
+* init and their status will not change. So just clear PF's promisc
+* mode status during uninit.
+*/
+   hns3_promisc_param_init(¶m, false, false, false, func_id);
+   ret = hns3_cmd_set_promisc_mode(hw, ¶m);
+   if (ret)
+   PMD_INIT_LOG(ERR, "failed to clear promisc status during"
+   " uninit, ret = %d", ret);
+}
+
 static int
 hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 {
@@ -4186,15 +4224,9 @@ hns3_init_hardware(struct hns3_adapter *hns)
goto err_mac_init;
}
 
-   ret = hns3_set_promisc_mode(hw, false, false);
-   if (ret) {
-   PMD_INIT_LOG(ERR, "Failed to set promisc mode: %d", ret);
-   goto err_mac_init;
-   }
-
-   ret = hns3_clear_all_vfs_promisc_mode(hw);
+   ret = hns3_promisc_init(hw);
if (ret) {
-   PMD_INIT_LOG(ERR, "Failed to clear all vfs promisc mode: %d",
+   PMD_INIT_LOG(ERR, "Failed to init promisc: %d",
 ret);
goto err_mac_init;
}
@@ -4353,6 +4385,7 @@ hns3_uninit_pf(struct rte_eth_dev *eth_dev)
 
hns3_enable_hw_error_intr(hns, false);
hns3_rss_uninit(hns);
+   hns3_promisc_uninit(hw);
hns3_fdir_filter_uninit(hns);
hns3_uninit_umv_space(hw);
hns3_pf_disable_irq0(hw);
-- 
2.7.4

[dpdk-dev] [PATCH 4/5] net/hns3: add RSS hash offload to port Rx configuration

[Wei Hu (Xavier)]

From: Lijun Ou 

Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`. The hns3 PMD driver
already can notify the validity of `rte_mbuf::hash:rss` to the application
by enabling `PKT_RX_RSS_HASH` flag in `rte_mbuf::ol_flags`.

Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations")
Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: sta...@dpdk.org

Signed-off-by: Lijun Ou 
Signed-off-by: Wei Hu (Xavier) 
---
 drivers/net/hns3/hns3_ethdev.c| 1 +
 drivers/net/hns3/hns3_ethdev_vf.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 1c06b8f..33d7c5c 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2312,6 +2312,7 @@ hns3_dev_configure(struct rte_eth_dev *dev)
 
/* When RSS is not configured, redirect the packet queue 0 */
if ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {
+   conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
rss_conf = conf->rx_adv_conf.rss_conf;
if (rss_conf.rss_key == NULL) {
rss_conf.rss_key = rss_cfg->key;
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c 
b/drivers/net/hns3/hns3_ethdev_vf.c
index 904562e..16d6012 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -784,6 +784,7 @@ hns3vf_dev_configure(struct rte_eth_dev *dev)
 
/* When RSS is not configured, redirect the packet queue 0 */
if ((uint32_t)mq_mode & ETH_MQ_RX_RSS_FLAG) {
+   conf->rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;
rss_conf = conf->rx_adv_conf.rss_conf;
if (rss_conf.rss_key == NULL) {
rss_conf.rss_key = rss_cfg->key;
-- 
2.7.4

[dpdk-dev] [PATCH 1/5] net/hns3: replace PF vport id zero with private macro

[Wei Hu (Xavier)]

From: Chengchang Tang 

In hns3 PMD driver, the vport id 0 denote PF, and the vport id 1 denote
the first VF device of the port.

This patch adds two macros named HNS3_PF_FUNC_ID and HNS3_1ST_VF_FUNC_ID,
and replaces this two numbers to improve code readability.

Signed-off-by: Chengchang Tang 
Signed-off-by: Wei Hu (Xavier) 
---
 drivers/net/hns3/hns3_ethdev.c | 48 +++---
 drivers/net/hns3/hns3_ethdev.h |  3 +++
 2 files changed, 25 insertions(+), 26 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index a09ac08..06c4886 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -474,10 +474,9 @@ hns3_set_vlan_rx_offload_cfg(struct hns3_adapter *hns,
 
/*
 * In current version VF is not supported when PF is driven by DPDK
-* driver, the PF-related vf_id is 0, just need to configure parameters
-* for vport_id 0.
+* driver, just need to configure parameters for PF vport.
 */
-   vport_id = 0;
+   vport_id = HNS3_PF_FUNC_ID;
req->vf_offset = vport_id / HNS3_VF_NUM_PER_CMD;
bitmap = 1 << (vport_id % HNS3_VF_NUM_PER_BYTE);
req->vf_bitmap[req->vf_offset] = bitmap;
@@ -564,14 +563,16 @@ hns3_vlan_filter_init(struct hns3_adapter *hns)
int ret;
 
ret = hns3_set_vlan_filter_ctrl(hw, HNS3_FILTER_TYPE_VF,
-   HNS3_FILTER_FE_EGRESS, false, 0);
+   HNS3_FILTER_FE_EGRESS, false,
+   HNS3_PF_FUNC_ID);
if (ret) {
hns3_err(hw, "failed to init vf vlan filter, ret = %d", ret);
return ret;
}
 
ret = hns3_set_vlan_filter_ctrl(hw, HNS3_FILTER_TYPE_PORT,
-   HNS3_FILTER_FE_INGRESS, false, 0);
+   HNS3_FILTER_FE_INGRESS, false,
+   HNS3_PF_FUNC_ID);
if (ret)
hns3_err(hw, "failed to init port vlan filter, ret = %d", ret);
 
@@ -585,7 +586,8 @@ hns3_enable_vlan_filter(struct hns3_adapter *hns, bool 
enable)
int ret;
 
ret = hns3_set_vlan_filter_ctrl(hw, HNS3_FILTER_TYPE_PORT,
-   HNS3_FILTER_FE_INGRESS, enable, 0);
+   HNS3_FILTER_FE_INGRESS, enable,
+   HNS3_PF_FUNC_ID);
if (ret)
hns3_err(hw, "failed to %s port vlan filter, ret = %d",
 enable ? "enable" : "disable", ret);
@@ -674,10 +676,9 @@ hns3_set_vlan_tx_offload_cfg(struct hns3_adapter *hns,
 
/*
 * In current version VF is not supported when PF is driven by DPDK
-* driver, the PF-related vf_id is 0, just need to configure parameters
-* for vport_id 0.
+* driver, just need to configure parameters for PF vport.
 */
-   vport_id = 0;
+   vport_id = HNS3_PF_FUNC_ID;
req->vf_offset = vport_id / HNS3_VF_NUM_PER_CMD;
bitmap = 1 << (vport_id % HNS3_VF_NUM_PER_BYTE);
req->vf_bitmap[req->vf_offset] = bitmap;
@@ -1425,10 +1426,9 @@ hns3_add_uc_addr_common(struct hns3_hw *hw, struct 
rte_ether_addr *mac_addr)
 
/*
 * In current version VF is not supported when PF is driven by DPDK
-* driver, the PF-related vf_id is 0, just need to configure parameters
-* for vf_id 0.
+* driver, just need to configure parameters for PF vport.
 */
-   vf_id = 0;
+   vf_id = HNS3_PF_FUNC_ID;
hns3_set_field(egress_port, HNS3_MAC_EPORT_VFID_M,
   HNS3_MAC_EPORT_VFID_S, vf_id);
 
@@ -1781,10 +1781,9 @@ hns3_add_mc_addr(struct hns3_hw *hw, struct 
rte_ether_addr *mac_addr)
 
/*
 * In current version VF is not supported when PF is driven by DPDK
-* driver, the PF-related vf_id is 0, just need to configure parameters
-* for vf_id 0.
+* driver, just need to configure parameters for PF vport.
 */
-   vf_id = 0;
+   vf_id = HNS3_PF_FUNC_ID;
hns3_update_desc_vfid(desc, vf_id, false);
ret = hns3_add_mac_vlan_tbl(hw, &req, desc);
if (ret) {
@@ -1824,10 +1823,9 @@ hns3_remove_mc_addr(struct hns3_hw *hw, struct 
rte_ether_addr *mac_addr)
/*
 * This mac addr exist, remove this handle's VFID for it.
 * In current version VF is not supported when PF is driven by
-* DPDK driver, the PF-related vf_id is 0, just need to
-* configure parameters for vf_id 0.
+* DPDK driver, just need to configure parameters for PF vport.
 */
-   vf_id = 0;
+   vf_id = HNS3_PF_FUNC_ID;
hns3_update_desc_vfid(desc, vf_id, true);
 
/* All the vfid is zero, so need to delete this entry */
@@

[dpdk-dev] [PATCH 3/5] net/hns3: fix preparing sending packets less than 60 bytes

[Wei Hu (Xavier)]

Currently, when running testpmd application based on hns3 network engine
with csum fwd mode by "set fwd csum" command in the prompt line, sending
42 consecutive bytes of arp packets to network port with packets generator,
But in fact hardware can't send the arp packets and the related logs as
below:
"Preparing packet burst to failed: Invalid argument"

The hardware doesn't support transmit packets less than 60 bytes, and in
the '.tx_pkt_burst' ops implementation function named hns3_xmit_pkts
appending operation has been added for less than 60 bytes packets. So the
interception needs to be removed in the '.tx_pkt_prepare' ops
implementation function named hns3_prep_pkts.

Fixes: de620754a109 ("net/hns3: fix sending packets less than 60 bytes")
Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
Cc: sta...@dpdk.org

Signed-off-by: Wei Hu (Xavier) 
Signed-off-by: Hao Chen 
Signed-off-by: Chengchang Tang 
---
 drivers/net/hns3/hns3_rxtx.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index 8b3ced1..25ba3b8 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -2313,12 +2313,6 @@ hns3_prep_pkts(__rte_unused void *tx_queue, struct 
rte_mbuf **tx_pkts,
for (i = 0; i < nb_pkts; i++) {
m = tx_pkts[i];
 
-   /* check the size of packet */
-   if (m->pkt_len < RTE_ETHER_MIN_LEN) {
-   rte_errno = EINVAL;
-   return i;
-   }
-
if (hns3_pkt_is_tso(m) &&
(hns3_pkt_need_linearized(m, m->nb_segs) ||
 hns3_check_tso_pkt_valid(m))) {
-- 
2.7.4

[dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

[Wei Hu (Xavier)]

This series are improvement and bugfixes for hns3 PMD driver.

Chengchang Tang (2):
  net/hns3: replace PF vport id zero with private macro
  net/hns3: fix promiscuous config not clear for PF on uninit

Lijun Ou (2):
  net/hns3: add RSS hash offload to port Rx configuration
  net/hns3: fix key length when configuring RSS

Wei Hu (Xavier) (1):
  net/hns3: fix preparing sending packets less than 60 bytes

 drivers/net/hns3/hns3_ethdev.c| 102 --
 drivers/net/hns3/hns3_ethdev.h|   3 ++
 drivers/net/hns3/hns3_ethdev_vf.c |   1 +
 drivers/net/hns3/hns3_flow.c  |   8 +++
 drivers/net/hns3/hns3_rxtx.c  |   6 ---
 5 files changed, 78 insertions(+), 42 deletions(-)

-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow FDIR enable issue

[Ye Xiaolong]

On 05/21, Wei Zhao wrote:
>When we flush flow FDIR, all queues are disabled for FDIR.
>If FDIR rule is created again, then the flow list is empty,
>as it is the first time to create rule after flush fdir filter,
>so we need to enable FDIR for all queues. And also, disable FDIR
>for queues should be done in function i40e_flow_flush_fdir_filter().
>
>Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter")
>Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in Rx queue")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Wei Zhao 
>
>---
>
>v2:
>update log info
>---
> drivers/net/i40e/i40e_flow.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
>index 25c77e7aa..8f8df6fae 100644
>--- a/drivers/net/i40e/i40e_flow.c
>+++ b/drivers/net/i40e/i40e_flow.c
>@@ -3462,6 +3462,10 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
>   }
>   }
> 
>+  /* If create the first fdir rule, enable fdir check for rx queues */
>+  if (TAILQ_EMPTY(&pf->fdir.fdir_list))
>+  i40e_fdir_rx_proc_enable(dev, 1);
>+
>   return 0;
> err:
>   i40e_fdir_teardown(pf);
>@@ -5330,9 +5334,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct 
>rte_flow_error *error)
>   return -rte_errno;
>   }
> 
>-  /* Disable FDIR processing as all FDIR rules are now flushed */
>-  i40e_fdir_rx_proc_enable(dev, 0);
>-
>   return ret;
> }
> 
>@@ -5368,6 +5369,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
>   for (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP;
>pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++)
>   pf->fdir.inset_flag[pctype] = 0;
>+
>+  /* Disable FDIR processing as all FDIR rules are now flushed */
>+  i40e_fdir_rx_proc_enable(dev, 0);
>   }
> 
>   return ret;
>-- 
>2.19.1
>

Applied to dpdk-next-net-intel, Thanks.

[dpdk-dev] winget: Windows package manager

[Thomas Monjalon]

Hi,

Now there is an official package manager in Windows:
https://devblogs.microsoft.com/commandline/windows-package-manager-preview/

Who wants to build a DPDK package?

Where the manifest should be hosted? We used to have a directory pkg/...

Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter

[Zhao1, Wei]

Hi, Guinan
 
> -Original Message-
> From: Sun, GuinanX 
> Sent: Friday, May 22, 2020 2:12 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
> 
> If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port reset
> process of
> 
> testpmd> start
> testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port
> testpmd> start 0 start

This test step seems confused.

> 
> Then after this process, the mac_ctrl_frame_fwd has been change to "off", so
> we should delete "adapter->mac_ctrl_frame_fwd = 0;" from dev-stop.
> 
> In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get ()
> function.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: SunGuinan 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..dd4023f01 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> 
>   adapter->rss_reta_updated = 0;
> 
> - adapter->mac_ctrl_frame_fwd = 0;
> -
>   hw->adapter_stopped = true;
>  }
> 
> @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct
> rte_eth_fc_conf *fc_conf)
>* MFLCN register.
>*/
>   mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
> + fc_conf->mac_ctrl_frame_fwd = mflcn_reg;
> +
>   if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
>   rx_pause = 1;
>   else
> --
> 2.17.1

Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter

[Zhao1, Wei]

Hi,

> -Original Message-
> From: Sun, GuinanX 
> Sent: Friday, May 22, 2020 2:12 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
> 
> If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a port reset
> process of
> 
> testpmd> start
> testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port
> testpmd> start 0 start
> 
> Then after this process, the mac_ctrl_frame_fwd has been change to "off", so
> we should delete "adapter->mac_ctrl_frame_fwd = 0;" from dev-stop.
> 
> In addition, add a value to mac_ctrl_frame_fwd in the ixgbe_flow_ctrl_get ()
> function.
> 
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: SunGuinan 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..dd4023f01 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> 
>   adapter->rss_reta_updated = 0;
> 
> - adapter->mac_ctrl_frame_fwd = 0;
> -
>   hw->adapter_stopped = true;
>  }
> 
> @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct
> rte_eth_fc_conf *fc_conf)
>* MFLCN register.
>*/
>   mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
> + fc_conf->mac_ctrl_frame_fwd = mflcn_reg;
> +


Error, that is not right!!

>   if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
>   rx_pause = 1;
>   else
> --
> 2.17.1

Re: [dpdk-dev] No telemetry legacy support print

[Power, Ciara]

>-Original Message-
>From: David Marchand 
>Sent: Friday 22 May 2020 08:47
>To: Jerin Kollanukkaran ; Richardson, Bruce
>; Power, Ciara 
>Cc: Wiles, Keith ; Thomas Monjalon
>; dpdk-dev 
>Subject: Re: No telemetry legacy support print
>
>On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran 
>wrote:
>>
>> "No telemetry legacy support " prints pops up on all the default dpdk
>applications now.
>> Is it worth to print? Since it using direct 'printf', we cannot even disable
>through dynamic logging.
>> Is possible to remove that print at least, if non legacy telemetry init is
>successful.
>> Thoughts?
>
>This init function is odd as it calls printf in error and warning cases and 
>sets an
>error string when it succeeds.
>Let's remove the two printf in this init function.
>
>If we really care about the warning message, we have to initialise *err_str to
>NULL (+ this must be described in the function prototype).
>In EAL init, we can then add a rte_eal_init_alert with the error string when
>telemetry init fails and maybe a warning message if err_str != NULL.
>
>
>--
>David Marchand


I agree with this solution, I can work on getting a patch done to fix this.
Thanks!

- Ciara

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

[Ferruh Yigit]

On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
> This series are improvement and bugfixes for hns3 PMD driver.

Hi Xavier,

We are planning to have the -rc4 this weekend and the release on Tuesday. So we
are literally a few days away from the release.

It is definitely not good idea to change the code this close to the release,
that is why we are saying -rc4 for the critical defects only.

I will postpone this series to the next release, fyi.

> 
> Chengchang Tang (2):
>   net/hns3: replace PF vport id zero with private macro
>   net/hns3: fix promiscuous config not clear for PF on uninit
> 
> Lijun Ou (2):
>   net/hns3: add RSS hash offload to port Rx configuration
>   net/hns3: fix key length when configuring RSS
> 
> Wei Hu (Xavier) (1):
>   net/hns3: fix preparing sending packets less than 60 bytes
> 
>  drivers/net/hns3/hns3_ethdev.c| 102 
> --
>  drivers/net/hns3/hns3_ethdev.h|   3 ++
>  drivers/net/hns3/hns3_ethdev_vf.c |   1 +
>  drivers/net/hns3/hns3_flow.c  |   8 +++
>  drivers/net/hns3/hns3_rxtx.c  |   6 ---
>  5 files changed, 78 insertions(+), 42 deletions(-)
> 

[dpdk-dev] [PATCH 20.08] crypto/scheduler: use ring peek API

[Konstantin Ananyev]

scheduler PMD uses its own hand-made peek functions
that directly access rte_ring internals.
As now rte_ring has an API for that type of functionality -
change scheduler PMD to use API provided by rte_ring.

Signed-off-by: Konstantin Ananyev 
---
 .../crypto/scheduler/scheduler_multicore.c| 28 ---
 .../crypto/scheduler/scheduler_pmd_private.h  | 28 +++
 2 files changed, 21 insertions(+), 35 deletions(-)

diff --git a/drivers/crypto/scheduler/scheduler_multicore.c 
b/drivers/crypto/scheduler/scheduler_multicore.c
index 7808e9a34..2d6790bb3 100644
--- a/drivers/crypto/scheduler/scheduler_multicore.c
+++ b/drivers/crypto/scheduler/scheduler_multicore.c
@@ -110,31 +110,25 @@ static uint16_t
 schedule_dequeue_ordering(void *qp, struct rte_crypto_op **ops,
uint16_t nb_ops)
 {
-   struct rte_ring *order_ring = ((struct scheduler_qp_ctx 
*)qp)->order_ring;
+   struct rte_ring *order_ring =
+   ((struct scheduler_qp_ctx *)qp)->order_ring;
struct rte_crypto_op *op;
-   uint32_t nb_objs = rte_ring_count(order_ring);
-   uint32_t nb_ops_to_deq = 0;
-   uint32_t nb_ops_deqd = 0;
-
-   if (nb_objs > nb_ops)
-   nb_objs = nb_ops;
+   uint32_t nb_objs, nb_ops_to_deq;
 
-   while (nb_ops_to_deq < nb_objs) {
-   SCHEDULER_GET_RING_OBJ(order_ring, nb_ops_to_deq, op);
+   nb_objs = rte_ring_dequeue_burst_start(order_ring, (void **)ops,
+   nb_ops, NULL);
+   if (nb_objs == 0)
+   return 0;
 
+   for (nb_ops_to_deq = 0; nb_ops_to_deq != nb_objs; nb_ops_to_deq++) {
+   op = ops[nb_ops_to_deq];
if (!(op->status & CRYPTO_OP_STATUS_BIT_COMPLETE))
break;
-
op->status &= ~CRYPTO_OP_STATUS_BIT_COMPLETE;
-   nb_ops_to_deq++;
-   }
-
-   if (nb_ops_to_deq) {
-   nb_ops_deqd = rte_ring_sc_dequeue_bulk(order_ring,
-   (void **)ops, nb_ops_to_deq, NULL);
}
 
-   return nb_ops_deqd;
+   rte_ring_dequeue_finish(order_ring, nb_ops_to_deq);
+   return nb_ops_to_deq;
 }
 
 static int
diff --git a/drivers/crypto/scheduler/scheduler_pmd_private.h 
b/drivers/crypto/scheduler/scheduler_pmd_private.h
index 3ed480c18..e1531d1da 100644
--- a/drivers/crypto/scheduler/scheduler_pmd_private.h
+++ b/drivers/crypto/scheduler/scheduler_pmd_private.h
@@ -80,36 +80,28 @@ scheduler_order_insert(struct rte_ring *order_ring,
rte_ring_sp_enqueue_burst(order_ring, (void **)ops, nb_ops, NULL);
 }
 
-#define SCHEDULER_GET_RING_OBJ(order_ring, pos, op) do {\
-   struct rte_crypto_op **ring = (void *)&order_ring[1]; \
-   op = ring[(order_ring->cons.head + pos) & order_ring->mask]; \
-} while (0)
-
 static __rte_always_inline uint16_t
 scheduler_order_drain(struct rte_ring *order_ring,
struct rte_crypto_op **ops, uint16_t nb_ops)
 {
struct rte_crypto_op *op;
-   uint32_t nb_objs = rte_ring_count(order_ring);
-   uint32_t nb_ops_to_deq = 0;
-   uint32_t nb_ops_deqd = 0;
+   uint32_t nb_objs, nb_ops_to_deq;
 
-   if (nb_objs > nb_ops)
-   nb_objs = nb_ops;
+   nb_objs = rte_ring_dequeue_burst_start(order_ring, (void **)ops,
+   nb_ops, NULL);
+   if (nb_objs == 0)
+   return 0;
 
-   while (nb_ops_to_deq < nb_objs) {
-   SCHEDULER_GET_RING_OBJ(order_ring, nb_ops_to_deq, op);
+   for (nb_ops_to_deq = 0; nb_ops_to_deq != nb_objs; nb_ops_to_deq++) {
+   op = ops[nb_ops_to_deq];
if (op->status == RTE_CRYPTO_OP_STATUS_NOT_PROCESSED)
break;
-   nb_ops_to_deq++;
}
 
-   if (nb_ops_to_deq)
-   nb_ops_deqd = rte_ring_sc_dequeue_bulk(order_ring,
-   (void **)ops, nb_ops_to_deq, NULL);
-
-   return nb_ops_deqd;
+   rte_ring_dequeue_finish(order_ring, nb_ops_to_deq);
+   return nb_ops_to_deq;
 }
+
 /** device specific operations function pointer structure */
 extern struct rte_cryptodev_ops *rte_crypto_scheduler_pmd_ops;
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH 2/2] ring: empty optimization

[Ananyev, Konstantin]

> 
> Testing if the ring is empty is as simple as comparing the producer and
> consumer pointers.
> 
> In theory, this optimization reduces the number of potential cache misses
> from 3 to 2 by not having to read r->mask in rte_ring_count().
> 
> The modification of this function were also discussed in the RFC here:
> https://mails.dpdk.org/archives/dev/2020-April/165752.html
> 
> Signed-off-by: Morten Brørup 
> ---
>  lib/librte_ring/rte_ring.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
> index 9078e7c24..f67141482 100644
> --- a/lib/librte_ring/rte_ring.h
> +++ b/lib/librte_ring/rte_ring.h
> @@ -733,7 +733,9 @@ rte_ring_full(const struct rte_ring *r)
>  static inline int
>  rte_ring_empty(const struct rte_ring *r)
>  {
> - return rte_ring_count(r) == 0;
> + uint32_t prod_tail = r->prod.tail;
> + uint32_t cons_tail = r->cons.tail;
> + return cons_tail == prod_tail;
>  }
> 
>  /**
> --

Acked-by: Konstantin Ananyev 

> 2.17.1

Re: [dpdk-dev] [PATCH 1/2] ring: coding style cleanup

[Ananyev, Konstantin]

> 
> Fix coding style violations that checkpatch will complain about.
> 
> Add missing "int" after "unsigned".
> Add missing spaces around "+=" and "+".
> Remove superfluous type cast of numerical constant.
> 
> Suggested-by: Konstantin Ananyev 
> Signed-off-by: Morten Brørup 
> ---

Acked-by: Konstantin Ananyev 

> 2.17.1

[dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only.

[Louise Kilheeney]

This patch set converts all python scripts in the project to use
python3 only. This is due to python2 being EOL in January 2020.

One script not tested: ./config/arm/armv8_machine.py

Louise Kilheeney (9):
  app/test-bbdev: support python3 only
  usertools/dpdk-devbind: support python3 only
  usertools/dpdk-telemetry-client: support python3 only
  usertools/dpdk-pmdinfo: support python3 only
  usertools/cpu_layout: support python3 only
  app/test-cmdline: support python3 only
  app/test: support python3 only
  devtools: support python3 only
  config/arm: support python3 only

 app/test-bbdev/test-bbdev.py  |  7 +++
 app/test-cmdline/cmdline_test.py  |  3 +--
 app/test-cmdline/cmdline_test_data.py |  1 +
 app/test/autotest.py  |  3 +--
 app/test/autotest_data.py |  1 +
 app/test/autotest_runner.py   | 14 +++---
 app/test/autotest_test_funcs.py   |  1 +
 config/arm/armv8_machine.py   |  2 +-
 devtools/update_version_map_abi.py|  3 +--
 mk/rte.sdktest.mk |  6 +++---
 usertools/cpu_layout.py   |  9 ++---
 usertools/dpdk-devbind.py |  3 +--
 usertools/dpdk-pmdinfo.py |  4 +---
 usertools/dpdk-telemetry-client.py| 16 
 14 files changed, 28 insertions(+), 45 deletions(-)

-- 
2.17.1

[dpdk-dev] [PATCH 20.08 1/9] app/test-bbdev: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Nicolas Chautru 

Signed-off-by: Louise Kilheeney 
---
 app/test-bbdev/test-bbdev.py | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
index 0194be046..50add4580 100755
--- a/app/test-bbdev/test-bbdev.py
+++ b/app/test-bbdev/test-bbdev.py
@@ -1,5 +1,4 @@
-#!/usr/bin/env python
-
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
@@ -12,7 +11,7 @@
 from threading import Timer
 
 def kill(process):
-print "ERROR: Test app timed out"
+print ("ERROR: Test app timed out")
 process.kill()
 
 if "RTE_SDK" in os.environ:
@@ -66,7 +65,7 @@ def kill(process):
 args = parser.parse_args()
 
 if not os.path.exists(args.testapp_path):
-print "No such file: " + args.testapp_path
+print ("No such file: " + args.testapp_path)
 sys.exit(1)
 
 params = [args.testapp_path]
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 3/9] usertools/dpdk-telemetry-client: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Kevin Laatz 

Signed-off-by: Louise Kilheeney 
---
 usertools/dpdk-telemetry-client.py | 16 
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py 
b/usertools/dpdk-telemetry-client.py
index 35edb7cd2..fa599046a 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -1,10 +1,7 @@
-#! /usr/bin/env python
+#! /usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Intel Corporation
 
-from __future__ import print_function
-from __future__ import unicode_literals
-
 import socket
 import os
 import sys
@@ -18,11 +15,6 @@
 GLOBAL_METRICS_REQ = 
"{\"action\":0,\"command\":\"global_stat_values\",\"data\":null}"
 DEFAULT_FP = "/var/run/dpdk/default_client"
 
-try:
-raw_input  # Python 2
-except NameError:
-raw_input = input  # Python 3
-
 class Socket:
 
 def __init__(self):
@@ -49,7 +41,7 @@ def __init__(self): # Creates a client instance
 def __del__(self):
 try:
 if self.unregistered == 0:
-self.unregister();
+self.unregister()
 except:
 print("Error - Client could not be destroyed")
 
@@ -82,7 +74,7 @@ def requestMetrics(self): # Requests metrics for given client
 
 def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests 
metrics for given client
 print("\nPlease enter the number of times you'd like to continuously 
request Metrics:")
-n_requests = int(raw_input("\n:"))
+n_requests = int(input("\n:"))
 print("\033[F") #Removes the user input from screen, cleans it up
 print("\033[K")
 for i in range(n_requests):
@@ -103,7 +95,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive 
menu within the scr
 print("[4] Unregister client")
 
 try:
-self.choice = int(raw_input("\n:"))
+self.choice = int(input("\n:"))
 print("\033[F") #Removes the user input for screen, cleans it 
up
 print("\033[K")
 if self.choice == 1:
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 6/9] app/test-cmdline: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Olivier Matz 

Signed-off-by: Louise Kilheeney 
---
 app/test-cmdline/cmdline_test.py  | 3 +--
 app/test-cmdline/cmdline_test_data.py | 1 +
 mk/rte.sdktest.mk | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/test-cmdline/cmdline_test.py b/app/test-cmdline/cmdline_test.py
index 3a8fac426..0e7c72459 100755
--- a/app/test-cmdline/cmdline_test.py
+++ b/app/test-cmdline/cmdline_test.py
@@ -1,9 +1,8 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
 # Script that runs cmdline_test app and feeds keystrokes into it.
-from __future__ import print_function
 import cmdline_test_data
 import os
 import pexpect
diff --git a/app/test-cmdline/cmdline_test_data.py 
b/app/test-cmdline/cmdline_test_data.py
index 114d2cb6a..2d9b3262a 100644
--- a/app/test-cmdline/cmdline_test_data.py
+++ b/app/test-cmdline/cmdline_test_data.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
index 803018ba3..ad7ef138f 100644
--- a/mk/rte.sdktest.mk
+++ b/mk/rte.sdktest.mk
@@ -63,7 +63,7 @@ coverage:
@mkdir -p $(AUTOTEST_DIR) ; \
cd $(AUTOTEST_DIR) ; \
if [ -f $(RTE_OUTPUT)/app/test ]; then \
-   python $(RTE_SDK)/test/cmdline_test/cmdline_test.py \
+   python3 $(RTE_SDK)/test/cmdline_test/cmdline_test.py \
$(RTE_OUTPUT)/app/cmdline_test; \
ulimit -S -n 100 ; \
python $(RTE_SDK)/app/test/autotest.py \
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Signed-off-by: Louise Kilheeney 
---
 usertools/dpdk-devbind.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 40b4beea4..441301f2d 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -1,9 +1,8 @@
-#! /usr/bin/env python
+#! /usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 #
 
-from __future__ import print_function
 import sys
 import os
 import getopt
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 7/9] app/test: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Signed-off-by: Louise Kilheeney 
---
 app/test/autotest.py|  3 +--
 app/test/autotest_data.py   |  1 +
 app/test/autotest_runner.py | 14 +++---
 app/test/autotest_test_funcs.py |  1 +
 mk/rte.sdktest.mk   |  4 ++--
 5 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/app/test/autotest.py b/app/test/autotest.py
index b42f48879..9eef1efbe 100644
--- a/app/test/autotest.py
+++ b/app/test/autotest.py
@@ -1,9 +1,8 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
 # Script that uses either test app or qemu controlled by python-pexpect
-from __future__ import print_function
 import autotest_data
 import autotest_runner
 import sys
diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py
index 7b1d01389..e33258026 100644
--- a/app/test/autotest_data.py
+++ b/app/test/autotest_data.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
diff --git a/app/test/autotest_runner.py b/app/test/autotest_runner.py
index 95e74c760..8c15cbdc2 100644
--- a/app/test/autotest_runner.py
+++ b/app/test/autotest_runner.py
@@ -1,10 +1,10 @@
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
 # The main logic behind running autotests in parallel
 
-from __future__ import print_function
-import StringIO
+import io
 import csv
 from multiprocessing import Pool, Queue
 import pexpect
@@ -78,7 +78,7 @@ def pool_init(queue, result_queue):
 cmdline = "%s %s" % (cmdline, prefix_cmdline)
 
 # prepare logging of init
-startuplog = StringIO.StringIO()
+startuplog = io.StringIO()
 
 # run test app
 try:
@@ -86,7 +86,7 @@ def pool_init(queue, result_queue):
 print("\n%s %s\n" % ("=" * 20, prefix), file=startuplog)
 print("\ncmdline=%s" % cmdline, file=startuplog)
 
-pool_child = pexpect.spawn(cmdline, logfile=startuplog)
+pool_child = pexpect.spawn(cmdline, logfile=startuplog, 
encoding='utf-8')
 
 # wait for target to boot
 if not wait_prompt(pool_child):
@@ -138,7 +138,7 @@ def run_test(target, test):
 # create log buffer for each test
 # in multiprocessing environment, the logging would be
 # interleaved and will create a mess, hence the buffering
-logfile = StringIO.StringIO()
+logfile = io.StringIO()
 pool_child.logfile = logfile
 
 # make a note when the test started
@@ -210,9 +210,9 @@ def __init__(self, cmdline, target, blacklist, whitelist, 
n_processes):
 # parse the binary for available test commands
 binary = cmdline.split()[0]
 stripped = 'not stripped' not in \
-   subprocess.check_output(['file', binary])
+   subprocess.check_output(['file', binary]).decode()
 if not stripped:
-symbols = subprocess.check_output(['nm', binary]).decode('utf-8')
+symbols = subprocess.check_output(['nm', binary]).decode()
 self.avail_cmds = re.findall('test_register_(\w+)', symbols)
 else:
 self.avail_cmds = None
diff --git a/app/test/autotest_test_funcs.py b/app/test/autotest_test_funcs.py
index 26688b713..775dfd1dc 100644
--- a/app/test/autotest_test_funcs.py
+++ b/app/test/autotest_test_funcs.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
index ad7ef138f..81eff0c08 100644
--- a/mk/rte.sdktest.mk
+++ b/mk/rte.sdktest.mk
@@ -49,7 +49,7 @@ test test-fast test-perf test-drivers test-dump:
@mkdir -p $(AUTOTEST_DIR) ; \
cd $(AUTOTEST_DIR) ; \
if [ -f $(RTE_OUTPUT)/app/test ]; then \
-   python $(RTE_SDK)/app/test/autotest.py \
+   python3 $(RTE_SDK)/app/test/autotest.py \
$(RTE_OUTPUT)/app/test \
$(RTE_TARGET) \
$(BLACKLIST) $(WHITELIST); \
@@ -66,7 +66,7 @@ coverage:
python3 $(RTE_SDK)/test/cmdline_test/cmdline_test.py \
$(RTE_OUTPUT)/app/cmdline_test; \
ulimit -S -n 100 ; \
-   python $(RTE_SDK)/app/test/autotest.py \
+   python3 $(RTE_SDK)/app/test/autotest.py \
$(RTE_OUTPUT)/app/test \
$(RTE_TARGET) \
$(BLACKLIST) $(WHITELIST) ; \
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 5/9] usertools/cpu_layout: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Signed-off-by: Louise Kilheeney 
---
 usertools/cpu_layout.py | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
index 6f129b1db..89a48cec4 100755
--- a/usertools/cpu_layout.py
+++ b/usertools/cpu_layout.py
@@ -1,14 +1,9 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 # Copyright(c) 2017 Cavium, Inc. All rights reserved.
 
-from __future__ import print_function
 import sys
-try:
-xrange # Python 2
-except NameError:
-xrange = range # Python 3
 
 sockets = []
 cores = []
@@ -17,7 +12,7 @@
 fd = open("{}/kernel_max".format(base_path))
 max_cpus = int(fd.read())
 fd.close()
-for cpu in xrange(max_cpus + 1):
+for cpu in range(max_cpus + 1):
 try:
 fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
 except IOError:
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 4/9] usertools/dpdk-pmdinfo: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Neil Horman 

Signed-off-by: Louise Kilheeney 
---
 usertools/dpdk-pmdinfo.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index 12f20735e..f5cd077f5 100755
--- a/usertools/dpdk-pmdinfo.py
+++ b/usertools/dpdk-pmdinfo.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2016  Neil Horman 
 
@@ -7,8 +7,6 @@
 # Utility to dump PMD_INFO_STRING support from an object file
 #
 # -
-from __future__ import print_function
-from __future__ import unicode_literals
 import json
 import io
 import os
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 9/9] config/arm: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Thomas Monjalon 

Signed-off-by: Louise Kilheeney 
---
 config/arm/armv8_machine.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/arm/armv8_machine.py b/config/arm/armv8_machine.py
index 404866d2f..a0e6a8769 100755
--- a/config/arm/armv8_machine.py
+++ b/config/arm/armv8_machine.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Cavium, Inc
 
-- 
2.17.1

[dpdk-dev] [PATCH 20.08 8/9] devtools: support python3 only

[Louise Kilheeney]

Changed script to explicitly use python3 only.

Cc: Neil Horman 
Cc: Ray Kinsella 

Signed-off-by: Louise Kilheeney 
---
 devtools/update_version_map_abi.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/devtools/update_version_map_abi.py 
b/devtools/update_version_map_abi.py
index 616412a1c..58aa368f9 100755
--- a/devtools/update_version_map_abi.py
+++ b/devtools/update_version_map_abi.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
@@ -9,7 +9,6 @@
 from the devtools/update-abi.sh utility.
 """
 
-from __future__ import print_function
 import argparse
 import sys
 import re
-- 
2.17.1

[dpdk-dev] [Bug 484] rte_sched_subport_free function does not free subport memory

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=484

Bug ID: 484
   Summary: rte_sched_subport_free function does not free subport
memory
   Product: DPDK
   Version: 19.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: major
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: hrvoje.habja...@zg.ht.hr
  Target Milestone: ---

Created attachment 105
  --> https://bugs.dpdk.org/attachment.cgi?id=105&action=edit
Patch to fix rte_sched_subport_free leak

Hi.

It would seem that rte_sched_subport_free does not properly free allocated
subport memory.

In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865),
there is code to free all allocated stuff related to scheduler subport. First
there are some checks, and in the end, rte_bitmap_free is called.

Now, rte_bitmap_free is a dummy function, and it just checks if provided
pointer to bitmap is valid or not. So, actual memory for subport is not freed,
and this is shown as memory leak.

Fix is quite simple, rte_bitmap_free should be replaced with rte_free, and
argument should be changed to subport pointer.

Regards,

H.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [PATCH 20.08 9/9] config/arm: support python3 only

[Thomas Monjalon]

22/05/2020 15:23, Louise Kilheeney:
> Changed script to explicitly use python3 only.

What is the reason of this change?


> Cc: Thomas Monjalon 
> 
> Signed-off-by: Louise Kilheeney 
> ---
>  config/arm/armv8_machine.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/arm/armv8_machine.py b/config/arm/armv8_machine.py
> index 404866d2f..a0e6a8769 100755
> --- a/config/arm/armv8_machine.py
> +++ b/config/arm/armv8_machine.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/python3
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Cavium, Inc

[dpdk-dev] [PATCH] telemetry: fix error and warning printfs

[Ciara Power]

Initially, printf was used to indicate and error/warning resulting from
telemetry initialisation. This is now fixed to use EAL logs for
warnings, and the unnecessary printf for an error is removed.

Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
Fixes: dd6275a424ac ("telemetry: fix error log output")
Cc: david.march...@redhat.com

Signed-off-by: Ciara Power 
---
 lib/librte_eal/freebsd/eal.c | 4 +++-
 lib/librte_eal/linux/eal.c   | 4 +++-
 lib/librte_telemetry/rte_telemetry.h | 9 +
 lib/librte_telemetry/telemetry.c | 2 --
 4 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
index 14b52168e..07456059e 100644
--- a/lib/librte_eal/freebsd/eal.c
+++ b/lib/librte_eal/freebsd/eal.c
@@ -956,13 +956,15 @@ rte_eal_init(int argc, char **argv)
return -1;
}
if (!internal_config.no_telemetry) {
-   const char *error_str;
+   const char *error_str = NULL;
if (rte_telemetry_init(rte_eal_get_runtime_dir(),
&internal_config.ctrl_cpuset, &error_str)
!= 0) {
rte_eal_init_alert(error_str);
return -1;
}
+   if (error_str != NULL)
+   RTE_LOG(WARNING, EAL, "%s\n", error_str);
}
 
eal_mcfg_complete();
diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
index 9620d2544..10317a660 100644
--- a/lib/librte_eal/linux/eal.c
+++ b/lib/librte_eal/linux/eal.c
@@ -1294,13 +1294,15 @@ rte_eal_init(int argc, char **argv)
return -1;
}
if (!internal_config.no_telemetry) {
-   const char *error_str;
+   const char *error_str = NULL;
if (rte_telemetry_init(rte_eal_get_runtime_dir(),
&internal_config.ctrl_cpuset, &error_str)
!= 0) {
rte_eal_init_alert(error_str);
return -1;
}
+   if (error_str != NULL)
+   RTE_LOG(WARNING, EAL, "%s\n", error_str);
}
 
eal_mcfg_complete();
diff --git a/lib/librte_telemetry/rte_telemetry.h 
b/lib/librte_telemetry/rte_telemetry.h
index 2c3c96cf7..eb7f2c917 100644
--- a/lib/librte_telemetry/rte_telemetry.h
+++ b/lib/librte_telemetry/rte_telemetry.h
@@ -241,8 +241,17 @@ int
 rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char *help);
 
 /**
+ * @internal
  * Initialize Telemetry.
  *
+ * @param runtime_dir
+ * The runtime directory of DPDK.
+ * @param cpuset
+ * The CPU set to be used for setting the thread affinity.
+ * @param err_str
+ * This err_str pointer should point to NULL on entry. In the case of an error
+ * or warning, it will be non-NULL on exit.
+ *
  * @return
  *  0 on success.
  * @return
diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/telemetry.c
index 7b6f8a79e..e7e3d861d 100644
--- a/lib/librte_telemetry/telemetry.c
+++ b/lib/librte_telemetry/telemetry.c
@@ -403,12 +403,10 @@ rte_telemetry_init(const char *runtime_dir, rte_cpuset_t 
*cpuset,
 {
if (telemetry_v2_init(runtime_dir, cpuset) != 0) {
*err_str = telemetry_log_error;
-   printf("Error initialising telemetry - %s\n", *err_str);
return -1;
}
if (telemetry_legacy_init(runtime_dir, cpuset) != 0) {
*err_str = telemetry_log_error;
-   printf("No telemetry legacy support - %s\n", *err_str);
}
return 0;
 }
-- 
2.17.1

[dpdk-dev] [PATCH v1] doc: update release notes for 20.05

[John McNamara]

Fix grammar, spelling and formatting of DPDK 20.05 release notes.

Signed-off-by: John McNamara 
---
 doc/guides/rel_notes/release_20_05.rst | 264 +++--
 1 file changed, 116 insertions(+), 148 deletions(-)

diff --git a/doc/guides/rel_notes/release_20_05.rst 
b/doc/guides/rel_notes/release_20_05.rst
index 8470690..d10a1f4 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -56,38 +56,38 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
-* **Added Trace Library and Tracepoints**
+* **Added Trace Library and Tracepoints.**
 
-  A native implementation of ``common trace format(CTF)`` based trace library
-  has been added to provide the ability to add tracepoints in
-  application/library to get runtime trace/debug information for control and
+  A native implementation of "common trace format" (CTF) based trace library
+  has been added to provide the ability to add tracepoints in an
+  application/library to get runtime trace/debug information for control, and
   fast APIs with minimum impact on fast path performance.
   Typical trace overhead is ~20 cycles and instrumentation overhead is 1 cycle.
   Added tracepoints in ``EAL``, ``ethdev``, ``cryptodev``, ``eventdev`` and
   ``mempool`` libraries for important functions.
 
-* **Added APIs for RCU defer queue.**
+* **Added APIs for RCU defer queues.**
 
-  Added APIs to create and delete defer queue. Additional APIs are provided
+  Added APIs to create and delete defer queues. Additional APIs are provided
   to enqueue a deleted resource and reclaim the resource in the future.
-  These APIs help the application use lock-free data structures with
+  These APIs help an application use lock-free data structures with
   less effort.
 
 * **Added new API for rte_ring.**
 
-  * New synchronization modes for rte_ring.
+  * Introduced new synchronization modes for rte_ring.
 
-  Introduced new optional MT synchronization modes for rte_ring:
-  Relaxed Tail Sync (RTS) mode and Head/Tail Sync (HTS) mode.
-  With these mode selected, rte_ring shows significant improvements for
-  average enqueue/dequeue times on overcommitted systems.
+Introduced new optional MT synchronization modes for ``rte_ring``:
+Relaxed Tail Sync (RTS) mode and Head/Tail Sync (HTS) mode.
+With these modes selected, ``rte_ring`` shows significant improvements for
+average enqueue/dequeue times on overcommitted systems.
 
-  * Added peek style API for rte_ring.
+  * Added peek style API for ``rte_ring``.
 
-  For rings with producer/consumer in RTE_RING_SYNC_ST, RTE_RING_SYNC_MT_HTS
-  mode, provide an ability to split enqueue/dequeue operation into two phases
-  (enqueue/dequeue start; enqueue/dequeue finish). That allows user to inspect
-  objects in the ring without removing them from it (aka MT safe peek).
+For rings with producer/consumer in ``RTE_RING_SYNC_ST``, 
``RTE_RING_SYNC_MT_HTS``
+mode, provide the ability to split enqueue/dequeue operation into two 
phases
+(enqueue/dequeue start and enqueue/dequeue finish). This allows the user 
to inspect
+objects in the ring without removing them (aka MT safe peek).
 
 * **Added flow aging support.**
 
@@ -100,14 +100,16 @@ New Features
   * Added new query: ``rte_flow_get_aged_flows`` to get the aged-out flows
 contexts from the port.
 
-* **ethdev: Added a new value to link speed for 200Gbps**
+* **ethdev: Added a new value to link speed for 200Gbps.**
 
-* **Updated Amazon ena driver.**
+  Added a new ethdev value to for link speeds of 200Gbps.
 
-  Updated ena PMD with new features and improvements, including:
+* **Updated the Amazon ena driver.**
+
+  Updated the ena PMD with new features and improvements, including:
 
   * Added support for large LLQ (Low-latency queue) headers.
-  * Added Tx drops as new extended driver statistic.
+  * Added Tx drops as a new extended driver statistic.
   * Added support for accelerated LLQ mode.
   * Handling of the 0 length descriptors on the Rx path.
 
@@ -115,14 +117,14 @@ New Features
 
   Updated Hisilicon hns3 driver with new features and improvements, including:
 
-  * Added support for TSO
-  * Added support for configuring promiscuous and allmulticast mode for VF
+  * Added support for TSO.
+  * Added support for configuring promiscuous and allmulticast mode for VF.
 
 * **Updated Intel i40e driver.**
 
   Updated i40e PMD with new features and improvements, including:
 
-  * Enable MAC address as FDIR input set for ipv4-other, ipv4-udp and ipv4-tcp.
+  * Enabled MAC address as FDIR input set for ipv4-other, ipv4-udp and 
ipv4-tcp.
   * Added support for RSS using L3/L4 source/destination only.
   * Added support for setting hash function in rte flow.
 
@@ -139,14 +141,14 @@ New Features
   Updated the Intel ice driver with new features and improvements, including:
 
   * Added support for DCF (

Re: [dpdk-dev] [PATCH 20.08 9/9] config/arm: support python3 only

[Kilheeney, Louise]

since python 2 is EOL, Making these scripts to use python3-only, 
it's part of a general update to have everything use python3. 
This is already using python 3 and this makes it explicit.

Best Regards 
Louise Kilheeney
-Original Message-
From: Thomas Monjalon  
Sent: Friday 22 May 2020 14:46
To: Kilheeney, Louise 
Cc: dev@dpdk.org
Subject: Re: [PATCH 20.08 9/9] config/arm: support python3 only

22/05/2020 15:23, Louise Kilheeney:
> Changed script to explicitly use python3 only.

What is the reason of this change?


> Cc: Thomas Monjalon 
> 
> Signed-off-by: Louise Kilheeney 
> ---
>  config/arm/armv8_machine.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/arm/armv8_machine.py b/config/arm/armv8_machine.py 
> index 404866d2f..a0e6a8769 100755
> --- a/config/arm/armv8_machine.py
> +++ b/config/arm/armv8_machine.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/python3
>  # SPDX-License-Identifier: BSD-3-Clause  # Copyright(c) 2017 Cavium, 
> Inc

Re: [dpdk-dev] [PATCH 3/3] lib: remind experimental status in library headers

[Honnappa Nagarahalli]

> Subject: [PATCH 3/3] lib: remind experimental status in library headers
> 
> The following libraries are experimental, all of their functions can change or
> disappear:
> 
> - librte_bbdev
> - librte_bpf
> - librte_compressdev
> - librte_fib
> - librte_flow_classify
> - librte_ipsec
> - librte_rcu
> - librte_rib
> - librte_stack
> - librte_telemetry
> 
> Their status is properly announced in MAINTAINERS.
> Remind this status in their headers in a common fashion.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand 
> ---
>  lib/librte_bbdev/rte_bbdev.h |  3 ++-
>  lib/librte_bpf/rte_bpf.h |  6 +-
>  lib/librte_compressdev/rte_compressdev.h |  6 +-
>  lib/librte_fib/rte_fib.h |  7 +++
>  lib/librte_fib/rte_fib6.h|  7 +++
>  lib/librte_flow_classify/rte_flow_classify.h |  6 --
>  lib/librte_ipsec/rte_ipsec.h |  6 +-
>  lib/librte_rcu/rte_rcu_qsbr.h|  7 ++-
>  lib/librte_rib/rte_rib.h |  7 +++
>  lib/librte_rib/rte_rib6.h|  7 +++
>  lib/librte_stack/rte_stack.h |  7 +--
>  lib/librte_telemetry/rte_telemetry.h | 10 ++
>  12 files changed, 66 insertions(+), 13 deletions(-)
> 
> diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h index
> ecd95a823d..ab4e1bd6f4 100644
> --- a/lib/librte_bbdev/rte_bbdev.h
> +++ b/lib/librte_bbdev/rte_bbdev.h
> @@ -11,7 +11,8 @@
>   * Wireless base band device abstraction APIs.
>   *
>   * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
nit, is 'removed' a better choice instead of 'disappear'? May be something like:
All functions in this file may be changed or removed without prior notice.

>   *
>   * This API allows an application to discover, configure and use a device to
>   * process operations. An asynchronous API (enqueue, followed by later
> dequeue) diff --git a/lib/librte_bpf/rte_bpf.h b/lib/librte_bpf/rte_bpf.h 
> index
> cbf1cddaca..ceb3e26b03 100644
> --- a/lib/librte_bpf/rte_bpf.h
> +++ b/lib/librte_bpf/rte_bpf.h
> @@ -7,9 +7,13 @@
> 
>  /**
>   * @file rte_bpf.h
> - * @b EXPERIMENTAL: this API may change without prior notice
>   *
>   * RTE BPF support.
> + *
> + * @warning
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
> + *
>   * librte_bpf provides a framework to load and execute eBPF bytecode
>   * inside user-space dpdk based applications.
>   * It supports basic set of features from eBPF spec diff --git
> a/lib/librte_compressdev/rte_compressdev.h
> b/lib/librte_compressdev/rte_compressdev.h
> index 8052efe675..9c873b347d 100644
> --- a/lib/librte_compressdev/rte_compressdev.h
> +++ b/lib/librte_compressdev/rte_compressdev.h
> @@ -8,7 +8,11 @@
>  /**
>   * @file rte_compressdev.h
>   *
> - * RTE Compression Device APIs
> + * RTE Compression Device APIs.
> + *
> + * @warning
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
>   *
>   * Defines comp device APIs for the provisioning of compression operations.
>   */
> diff --git a/lib/librte_fib/rte_fib.h b/lib/librte_fib/rte_fib.h index
> af3bbf07ee..b52d058406 100644
> --- a/lib/librte_fib/rte_fib.h
> +++ b/lib/librte_fib/rte_fib.h
> @@ -8,6 +8,13 @@
> 
>  /**
>   * @file
> + *
> + * RTE FIB library.
> + *
> + * @warning
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
> + *
>   * FIB (Forwarding information base) implementation
>   * for IPv4 Longest Prefix Match
>   */
> diff --git a/lib/librte_fib/rte_fib6.h b/lib/librte_fib/rte_fib6.h index
> 66c71c84c9..e6e8892ecb 100644
> --- a/lib/librte_fib/rte_fib6.h
> +++ b/lib/librte_fib/rte_fib6.h
> @@ -8,6 +8,13 @@
> 
>  /**
>   * @file
> + *
> + * RTE FIB6 library.
> + *
> + * @warning
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
> + *
>   * FIB (Forwarding information base) implementation
>   * for IPv6 Longest Prefix Match
>   */
> diff --git a/lib/librte_flow_classify/rte_flow_classify.h
> b/lib/librte_flow_classify/rte_flow_classify.h
> index 74d1ecaf50..ac5b08aa6d 100644
> --- a/lib/librte_flow_classify/rte_flow_classify.h
> +++ b/lib/librte_flow_classify/rte_flow_classify.h
> @@ -8,9 +8,11 @@
>  /**
>   * @file
>   *
> - * RTE Flow Classify Library
> + * RTE Flow Classify Library.
>   *
> - * @b EXPERIMENTAL: this API may change without prior notice
> + * @warning
> + * @b EXPERIMENTAL:
> + * All functions in this file may change or disappear without prior notice.
>   *
>   * This library provides flow record information with some measured
> properties.
>   *
> diff --git a/lib/librte_ipsec/rte_ipsec.h b/lib/librte_ipsec/rte_ipsec.h index
> cf7619..50f109553c 100644

Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs

[Bruce Richardson]

On Fri, May 22, 2020 at 02:48:39PM +0100, Ciara Power wrote:
> Initially, printf was used to indicate and error/warning resulting from
> telemetry initialisation. This is now fixed to use EAL logs for
> warnings, and the unnecessary printf for an error is removed.
> 
> Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> Fixes: dd6275a424ac ("telemetry: fix error log output")
> Cc: david.march...@redhat.com
> 
> Signed-off-by: Ciara Power 
Reviewed-by: Bruce Richardson 

Re: [dpdk-dev] [PATCH] net/ixgbe: fix MACsec private API

[Ferruh Yigit]

On 5/22/2020 6:59 AM, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
> 
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Guinan Sun 

Reviewed-by: Ferruh Yigit 

[dpdk-dev] [PATCH] doc: add gcc 10 support to release notes

[Kevin Traynor]

Note support for gcc 10 in the DPDK 20.05 release notes.

Signed-off-by: Kevin Traynor 
---
Note: Reduced context so can apply before/after John's cleanup patch
---
 doc/guides/rel_notes/release_20_05.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst 
b/doc/guides/rel_notes/release_20_05.rst
index 84706904e..2b8038a17 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -326,2 +326,5 @@ New Features
 
+* **Added support for GCC 10.**
+
+  Added support for building with GCC 10.1.
 
-- 
2.21.3

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 20.05

[Kevin Traynor]

On 22/05/2020 15:06, John McNamara wrote:
> Fix grammar, spelling and formatting of DPDK 20.05 release notes.
> 
> Signed-off-by: John McNamara 
> ---
>  doc/guides/rel_notes/release_20_05.rst | 264 
> +++--
>  1 file changed, 116 insertions(+), 148 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_20_05.rst 
> b/doc/guides/rel_notes/release_20_05.rst
> index 8470690..d10a1f4 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -56,38 +56,38 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   =
>  
> -* **Added Trace Library and Tracepoints**
> +* **Added Trace Library and Tracepoints.**
>  
> -  A native implementation of ``common trace format(CTF)`` based trace library
> -  has been added to provide the ability to add tracepoints in
> -  application/library to get runtime trace/debug information for control and
> +  A native implementation of "common trace format" (CTF) based trace library

Not sure if the "" are intentional?

> +  has been added to provide the ability to add tracepoints in an
> +  application/library to get runtime trace/debug information for control, and
>fast APIs with minimum impact on fast path performance.
>Typical trace overhead is ~20 cycles and instrumentation overhead is 1 
> cycle.
>Added tracepoints in ``EAL``, ``ethdev``, ``cryptodev``, ``eventdev`` and
>``mempool`` libraries for important functions.
>  
> -* **Added APIs for RCU defer queue.**
> +* **Added APIs for RCU defer queues.**
>  
> -  Added APIs to create and delete defer queue. Additional APIs are provided
> +  Added APIs to create and delete defer queues. Additional APIs are provided
>to enqueue a deleted resource and reclaim the resource in the future.
> -  These APIs help the application use lock-free data structures with
> +  These APIs help an application use lock-free data structures with
>less effort.
>  
>  * **Added new API for rte_ring.**
>  
> -  * New synchronization modes for rte_ring.
> +  * Introduced new synchronization modes for rte_ring.
>  
> -  Introduced new optional MT synchronization modes for rte_ring:
> -  Relaxed Tail Sync (RTS) mode and Head/Tail Sync (HTS) mode.
> -  With these mode selected, rte_ring shows significant improvements for
> -  average enqueue/dequeue times on overcommitted systems.
> +Introduced new optional MT synchronization modes for ``rte_ring``:
> +Relaxed Tail Sync (RTS) mode and Head/Tail Sync (HTS) mode.
> +With these modes selected, ``rte_ring`` shows significant improvements 
> for
> +average enqueue/dequeue times on overcommitted systems.
>  
> -  * Added peek style API for rte_ring.
> +  * Added peek style API for ``rte_ring``.
>  
> -  For rings with producer/consumer in RTE_RING_SYNC_ST, RTE_RING_SYNC_MT_HTS
> -  mode, provide an ability to split enqueue/dequeue operation into two phases
> -  (enqueue/dequeue start; enqueue/dequeue finish). That allows user to 
> inspect
> -  objects in the ring without removing them from it (aka MT safe peek).
> +For rings with producer/consumer in ``RTE_RING_SYNC_ST``, 
> ``RTE_RING_SYNC_MT_HTS``
> +mode, provide the ability to split enqueue/dequeue operation into two 
> phases
> +(enqueue/dequeue start and enqueue/dequeue finish). This allows the user 
> to inspect
> +objects in the ring without removing them (aka MT safe peek).
>  
>  * **Added flow aging support.**
>  
> @@ -100,14 +100,16 @@ New Features
>* Added new query: ``rte_flow_get_aged_flows`` to get the aged-out flows
>  contexts from the port.
>  
> -* **ethdev: Added a new value to link speed for 200Gbps**
> +* **ethdev: Added a new value to link speed for 200Gbps.**
>  
> -* **Updated Amazon ena driver.**
> +  Added a new ethdev value to for link speeds of 200Gbps.
>  
> -  Updated ena PMD with new features and improvements, including:
> +* **Updated the Amazon ena driver.**
> +
> +  Updated the ena PMD with new features and improvements, including:
>  
>* Added support for large LLQ (Low-latency queue) headers.
> -  * Added Tx drops as new extended driver statistic.
> +  * Added Tx drops as a new extended driver statistic.
>* Added support for accelerated LLQ mode.
>* Handling of the 0 length descriptors on the Rx path.
>  
> @@ -115,14 +117,14 @@ New Features
>  
>Updated Hisilicon hns3 driver with new features and improvements, 
> including:
>  
> -  * Added support for TSO
> -  * Added support for configuring promiscuous and allmulticast mode for VF
> +  * Added support for TSO.
> +  * Added support for configuring promiscuous and allmulticast mode for VF.
>  
>  * **Updated Intel i40e driver.**
>  
>Updated i40e PMD with new features and improvements, including:
>  
> -  * Enable MAC address as FDIR input set for ipv4-other, ipv4-udp and 
> ipv4-tcp.
> +  * Enabled MAC address as FDIR input 

Re: [dpdk-dev] [PATCH v1]doc:Update i40e PMD firmware/driver mapping table.

[Ferruh Yigit]

On 5/22/2020 3:20 AM, Xing, Beilei wrote:
> 
> 
>> -Original Message-
>> From: dev  On Behalf Of Chen, Zhaoyan
>> Sent: Thursday, May 21, 2020 3:45 PM
>> To: dev@dpdk.org
>> Cc: Chen, Zhaoyan 
>> Subject: [dpdk-dev] [PATCH v1]doc:Update i40e PMD firmware/driver
>> mapping table.
> 
> Minor comments: 
> 1. Space is needed after colon
> 2. Update -> update
> 3. no need . in the tile
> So it should be like "doc: update firmware/driver mapping table for i40e"

Hi Beilei,

If the content is correct and only issue is above ones, I can fix them while
merging.

> 
>>
>> Update i40e PMD firmware/driver mapping table.
>>
>> Signed-off-by: Zhaoyan Chen 
>>
>> ---
>>  doc/guides/nics/i40e.rst | 4 
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index
>> 2f846091cf..00c3042d5d 100644
>> --- a/doc/guides/nics/i40e.rst
>> +++ b/doc/guides/nics/i40e.rst
>> @@ -88,6 +88,8 @@ For X710/XL710/XXV710,
>> +--+---+--+
>> | DPDK version | Kernel driver version | Firmware version |
>> +==+===+==+
>> +   |20.05 | 2.11.27   |   7.30   |
>> +   +--+---+--+
>> |20.02 | 2.10.19   |   7.20   |
>> +--+---+--+
>> |19.11 | 2.9.21|   7.00   |
>> @@ -127,6 +129,8 @@ For X722,
>> +--+---+--+
>> | DPDK version | Kernel driver version | Firmware version |
>> +==+===+==+
>> +   |20.05 | 2.11.27   |   4.11   |
>> +   +--+---+--+
>> |20.02 | 2.10.19   |   4.11   |
>> +--+---+--+
>> |19.11 | 2.9.21|   4.10   |
>> --
>> 2.22.0
> 

Re: [dpdk-dev] [PATCH v1] doc: update release notes for 20.05

[Power, Ciara]

Hi John,


>-Original Message-
>From: dev  On Behalf Of John McNamara
>Sent: Friday 22 May 2020 15:06
>To: dev@dpdk.org
>Cc: tho...@monjalon.net; Mcnamara, John 
>Subject: [dpdk-dev] [PATCH v1] doc: update release notes for 20.05
>
>Fix grammar, spelling and formatting of DPDK 20.05 release notes.
>
>Signed-off-by: John McNamara 
>---
> doc/guides/rel_notes/release_20_05.rst | 264 +++--
>
> 1 file changed, 116 insertions(+), 148 deletions(-)
>
>diff --git a/doc/guides/rel_notes/release_20_05.rst
>b/doc/guides/rel_notes/release_20_05.rst
>index 8470690..d10a1f4 100644
>--- a/doc/guides/rel_notes/release_20_05.rst
>+++ b/doc/guides/rel_notes/release_20_05.rst



>
> * **Updated Telemetry Library.**
>
>-  The updated Telemetry library has many improvements on the original
>version
>-  to make it more accessible and scalable:
>+  The updated Telemetry library has been significantly in relation to
>+ the  original version to make it more accessible and scalable:

I think there may be a word missing - "significantly improved in" might
have been intended here.




- Ciara

[dpdk-dev] [PATCH] doc/guides: fix telemetry register command example

[Ciara Power]

The example shown for registering telemetry commands was previously
missing the help text parameter.

Fixes: 24cd1b529f35 ("doc: update telemetry guides")

Signed-off-by: Ciara Power 
---
 doc/guides/prog_guide/telemetry_lib.rst | 14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/doc/guides/prog_guide/telemetry_lib.rst 
b/doc/guides/prog_guide/telemetry_lib.rst
index d8f5856ee..8563a7200 100644
--- a/doc/guides/prog_guide/telemetry_lib.rst
+++ b/doc/guides/prog_guide/telemetry_lib.rst
@@ -21,14 +21,18 @@ Registering Commands
 
 Libraries and applications must register commands to make their information
 available via the Telemetry library. This involves providing a string command
-in the required format ("/library/command"), and the callback function that
-will handle formatting the information when required. An example showing ethdev
-commands being registered is shown below:
+in the required format ("/library/command"), the callback function that
+will handle formatting the information when required, and help text for the
+command. An example showing ethdev commands being registered is shown below:
 
 .. code-block:: c
 
-rte_telemetry_register_cmd("/ethdev/list", handle_port_list);
-rte_telemetry_register_cmd("/ethdev/xstats", handle_port_xstats);
+rte_telemetry_register_cmd("/ethdev/list", handle_port_list,
+"Returns list of available ethdev ports. Takes no parameters");
+rte_telemetry_register_cmd("/ethdev/xstats", handle_port_xstats,
+"Returns the extended stats for a port. Parameters: int port_id");
+rte_telemetry_register_cmd("/ethdev/link_status", handle_port_link_status,
+"Returns the link status for a port. Parameters: int port_id");
 
 
 Formatting JSON response
-- 
2.17.1

Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs

[Jerin Jacob]

On Fri, May 22, 2020 at 7:21 PM Ciara Power  wrote:
>
> Initially, printf was used to indicate and error/warning resulting from
> telemetry initialisation. This is now fixed to use EAL logs for
> warnings, and the unnecessary printf for an error is removed.
>
> Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> Fixes: dd6275a424ac ("telemetry: fix error log output")
> Cc: david.march...@redhat.com
>
> Signed-off-by: Ciara Power 
> ---
>  lib/librte_eal/freebsd/eal.c | 4 +++-
>  lib/librte_eal/linux/eal.c   | 4 +++-
>  lib/librte_telemetry/rte_telemetry.h | 9 +
>  lib/librte_telemetry/telemetry.c | 2 --
>  4 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
> index 14b52168e..07456059e 100644
> --- a/lib/librte_eal/freebsd/eal.c
> +++ b/lib/librte_eal/freebsd/eal.c
> @@ -956,13 +956,15 @@ rte_eal_init(int argc, char **argv)
> return -1;
> }
> if (!internal_config.no_telemetry) {
> -   const char *error_str;
> +   const char *error_str = NULL;
> if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> &internal_config.ctrl_cpuset, &error_str)
> != 0) {
> rte_eal_init_alert(error_str);
> return -1;
> }
> +   if (error_str != NULL)
> +   RTE_LOG(WARNING, EAL, "%s\n", error_str);
> }
>
> eal_mcfg_complete();
> diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> index 9620d2544..10317a660 100644
> --- a/lib/librte_eal/linux/eal.c
> +++ b/lib/librte_eal/linux/eal.c
> @@ -1294,13 +1294,15 @@ rte_eal_init(int argc, char **argv)
> return -1;
> }
> if (!internal_config.no_telemetry) {
> -   const char *error_str;
> +   const char *error_str = NULL;
> if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> &internal_config.ctrl_cpuset, &error_str)
> != 0) {
> rte_eal_init_alert(error_str);
> return -1;
> }
> +   if (error_str != NULL)
> +   RTE_LOG(WARNING, EAL, "%s\n", error_str);

"EAL: No legacy callbacks, legacy socket not created" comes all the times now.
Should we treat this as a warning? as it comes for with for the
built-in applications?
If it is important why not have a default handler in the EAL library?


> }
>
> eal_mcfg_complete();
> diff --git a/lib/librte_telemetry/rte_telemetry.h 
> b/lib/librte_telemetry/rte_telemetry.h
> index 2c3c96cf7..eb7f2c917 100644
> --- a/lib/librte_telemetry/rte_telemetry.h
> +++ b/lib/librte_telemetry/rte_telemetry.h
> @@ -241,8 +241,17 @@ int
>  rte_telemetry_register_cmd(const char *cmd, telemetry_cb fn, const char 
> *help);
>
>  /**
> + * @internal
>   * Initialize Telemetry.
>   *
> + * @param runtime_dir
> + * The runtime directory of DPDK.
> + * @param cpuset
> + * The CPU set to be used for setting the thread affinity.
> + * @param err_str
> + * This err_str pointer should point to NULL on entry. In the case of an 
> error
> + * or warning, it will be non-NULL on exit.
> + *
>   * @return
>   *  0 on success.
>   * @return
> diff --git a/lib/librte_telemetry/telemetry.c 
> b/lib/librte_telemetry/telemetry.c
> index 7b6f8a79e..e7e3d861d 100644
> --- a/lib/librte_telemetry/telemetry.c
> +++ b/lib/librte_telemetry/telemetry.c
> @@ -403,12 +403,10 @@ rte_telemetry_init(const char *runtime_dir, 
> rte_cpuset_t *cpuset,
>  {
> if (telemetry_v2_init(runtime_dir, cpuset) != 0) {
> *err_str = telemetry_log_error;
> -   printf("Error initialising telemetry - %s\n", *err_str);
> return -1;
> }
> if (telemetry_legacy_init(runtime_dir, cpuset) != 0) {
> *err_str = telemetry_log_error;
> -   printf("No telemetry legacy support - %s\n", *err_str);
> }
> return 0;
>  }
> --
> 2.17.1
>

Re: [dpdk-dev] [PATCH] doc/guides: fix telemetry register command example

[Laatz, Kevin]

On 22/05/2020 17:27, Ciara Power wrote:

The example shown for registering telemetry commands was previously
missing the help text parameter.

Fixes: 24cd1b529f35 ("doc: update telemetry guides")

Signed-off-by: Ciara Power 
---
  doc/guides/prog_guide/telemetry_lib.rst | 14 +-
  1 file changed, 9 insertions(+), 5 deletions(-)


Reviewed-by: Kevin Laatz 

Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs

[Bruce Richardson]

On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> On Fri, May 22, 2020 at 7:21 PM Ciara Power  wrote:
> >
> > Initially, printf was used to indicate and error/warning resulting from
> > telemetry initialisation. This is now fixed to use EAL logs for
> > warnings, and the unnecessary printf for an error is removed.
> >
> > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> > Fixes: dd6275a424ac ("telemetry: fix error log output")
> > Cc: david.march...@redhat.com
> >
> > Signed-off-by: Ciara Power 
> > ---
> >  lib/librte_eal/freebsd/eal.c | 4 +++-
> >  lib/librte_eal/linux/eal.c   | 4 +++-
> >  lib/librte_telemetry/rte_telemetry.h | 9 +
> >  lib/librte_telemetry/telemetry.c | 2 --
> >  4 files changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
> > index 14b52168e..07456059e 100644
> > --- a/lib/librte_eal/freebsd/eal.c
> > +++ b/lib/librte_eal/freebsd/eal.c
> > @@ -956,13 +956,15 @@ rte_eal_init(int argc, char **argv)
> > return -1;
> > }
> > if (!internal_config.no_telemetry) {
> > -   const char *error_str;
> > +   const char *error_str = NULL;
> > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > &internal_config.ctrl_cpuset, &error_str)
> > != 0) {
> > rte_eal_init_alert(error_str);
> > return -1;
> > }
> > +   if (error_str != NULL)
> > +   RTE_LOG(WARNING, EAL, "%s\n", error_str);
> > }
> >
> > eal_mcfg_complete();
> > diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> > index 9620d2544..10317a660 100644
> > --- a/lib/librte_eal/linux/eal.c
> > +++ b/lib/librte_eal/linux/eal.c
> > @@ -1294,13 +1294,15 @@ rte_eal_init(int argc, char **argv)
> > return -1;
> > }
> > if (!internal_config.no_telemetry) {
> > -   const char *error_str;
> > +   const char *error_str = NULL;
> > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > &internal_config.ctrl_cpuset, &error_str)
> > != 0) {
> > rte_eal_init_alert(error_str);
> > return -1;
> > }
> > +   if (error_str != NULL)
> > +   RTE_LOG(WARNING, EAL, "%s\n", error_str);
> 
> "EAL: No legacy callbacks, legacy socket not created" comes all the times now.
> Should we treat this as a warning? as it comes for with for the
> built-in applications?
> If it is important why not have a default handler in the EAL library?
> 
Perhaps the warning level could be changed to INFO.
BTW: if you compile with jansson library available, the legacy callbacks
will be available and this will be silenced.

/Bruce

Re: [dpdk-dev] [PATCH] telemetry: fix error and warning printfs

[Jerin Jacob]

On Fri, May 22, 2020 at 10:18 PM Bruce Richardson
 wrote:
>
> On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> > On Fri, May 22, 2020 at 7:21 PM Ciara Power  wrote:
> > >
> > > Initially, printf was used to indicate and error/warning resulting from
> > > telemetry initialisation. This is now fixed to use EAL logs for
> > > warnings, and the unnecessary printf for an error is removed.
> > >
> > > Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
> > > Fixes: dd6275a424ac ("telemetry: fix error log output")
> > > Cc: david.march...@redhat.com
> > >
> > > Signed-off-by: Ciara Power 
> > > ---
> > >  lib/librte_eal/freebsd/eal.c | 4 +++-
> > >  lib/librte_eal/linux/eal.c   | 4 +++-
> > >  lib/librte_telemetry/rte_telemetry.h | 9 +
> > >  lib/librte_telemetry/telemetry.c | 2 --
> > >  4 files changed, 15 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c
> > > index 14b52168e..07456059e 100644
> > > --- a/lib/librte_eal/freebsd/eal.c
> > > +++ b/lib/librte_eal/freebsd/eal.c
> > > @@ -956,13 +956,15 @@ rte_eal_init(int argc, char **argv)
> > > return -1;
> > > }
> > > if (!internal_config.no_telemetry) {
> > > -   const char *error_str;
> > > +   const char *error_str = NULL;
> > > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > > &internal_config.ctrl_cpuset, &error_str)
> > > != 0) {
> > > rte_eal_init_alert(error_str);
> > > return -1;
> > > }
> > > +   if (error_str != NULL)
> > > +   RTE_LOG(WARNING, EAL, "%s\n", error_str);
> > > }
> > >
> > > eal_mcfg_complete();
> > > diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
> > > index 9620d2544..10317a660 100644
> > > --- a/lib/librte_eal/linux/eal.c
> > > +++ b/lib/librte_eal/linux/eal.c
> > > @@ -1294,13 +1294,15 @@ rte_eal_init(int argc, char **argv)
> > > return -1;
> > > }
> > > if (!internal_config.no_telemetry) {
> > > -   const char *error_str;
> > > +   const char *error_str = NULL;
> > > if (rte_telemetry_init(rte_eal_get_runtime_dir(),
> > > &internal_config.ctrl_cpuset, &error_str)
> > > != 0) {
> > > rte_eal_init_alert(error_str);
> > > return -1;
> > > }
> > > +   if (error_str != NULL)
> > > +   RTE_LOG(WARNING, EAL, "%s\n", error_str);
> >
> > "EAL: No legacy callbacks, legacy socket not created" comes all the times 
> > now.
> > Should we treat this as a warning? as it comes for with for the
> > built-in applications?
> > If it is important why not have a default handler in the EAL library?
> >
> Perhaps the warning level could be changed to INFO.

OK.

> BTW: if you compile with jansson library available, the legacy callbacks
> will be available and this will be silenced.

I see.

>
> /Bruce

[dpdk-dev] [PATCH 0/2] bnxt bug fixes

[Kalesh A P]

From: Kalesh AP 

These are two bug fixes observed during regression testing
with DPDK 20.05-rc3.

Please apply.

Kalesh AP (1):
  net/bnxt: fix the check for validating??link speed

Rahul Gupta (1):
  net/bnxt: performance fix for Arm

 drivers/net/bnxt/bnxt.h|  1 +
 drivers/net/bnxt/bnxt_cpr.h|  6 +++---
 drivers/net/bnxt/bnxt_ethdev.c |  2 +-
 drivers/net/bnxt/bnxt_hwrm.c   | 14 +-
 drivers/net/bnxt/bnxt_ring.h   | 24 +---
 5 files changed, 27 insertions(+), 20 deletions(-)

-- 
2.10.1

[dpdk-dev] [PATCH 2/2] net/bnxt: performance fix for ARM

[Kalesh A P]

From: Rahul Gupta 

Eliminate unnecessary rte_smp_wmb() before writing to request/completion
doorbells. Use rte_cio_wmb() memory barrier instead of rte_io_wmb() before
writing to tx/rx request queue doorbells and use rte_compiler_barrier()
before writing to tx/rx completion queue doorbells.

Fixes: 4af9d0c72941 ("net/bnxt: cleanup NQ doorbell")
Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
Cc: sta...@dpdk.org

Signed-off-by: Rahul Gupta 
Signed-off-by: Kalesh AP 
---
 drivers/net/bnxt/bnxt_cpr.h  |  6 +++---
 drivers/net/bnxt/bnxt_ring.h | 24 +---
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h
index c288078..cccd6cd 100644
--- a/drivers/net/bnxt/bnxt_cpr.h
+++ b/drivers/net/bnxt/bnxt_cpr.h
@@ -64,9 +64,9 @@ struct bnxt_db_info;
(cons));\
 } while (0)
 #define B_CP_DIS_DB(cpr, raw_cons) \
-   rte_write32((DB_CP_FLAGS |  \
-   RING_CMP(((cpr)->cp_ring_struct), raw_cons)),   \
-   ((cpr)->cp_db.doorbell))
+   rte_write32_relaxed((DB_CP_FLAGS |  \
+   RING_CMP(((cpr)->cp_ring_struct), raw_cons)), \
+   ((cpr)->cp_db.doorbell))
 
 #define B_CP_DB(cpr, raw_cons, ring_mask)  \
rte_write32((DB_CP_FLAGS |  \
diff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h
index 48a39d7..9913aed 100644
--- a/drivers/net/bnxt/bnxt_ring.h
+++ b/drivers/net/bnxt/bnxt_ring.h
@@ -82,10 +82,12 @@ void bnxt_free_rxtx_nq_ring(struct bnxt *bp);
 
 static inline void bnxt_db_write(struct bnxt_db_info *db, uint32_t idx)
 {
+   rte_cio_wmb();
+
if (db->db_64)
rte_write64_relaxed(db->db_key64 | idx, db->doorbell);
else
-   rte_write32(db->db_key32 | idx, db->doorbell);
+   rte_write32_relaxed(db->db_key32 | idx, db->doorbell);
 }
 
 /* Ring an NQ doorbell and disable interrupts for the ring. */
@@ -94,10 +96,10 @@ static inline void bnxt_db_nq(struct bnxt_cp_ring_info *cpr)
if (unlikely(!cpr->cp_db.db_64))
return;
 
-   rte_smp_wmb();
-   rte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ |
-   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
-   cpr->cp_db.doorbell);
+   rte_cio_wmb();
+   rte_write64_relaxed(cpr->cp_db.db_key64 | DBR_TYPE_NQ |
+   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
+   cpr->cp_db.doorbell);
 }
 
 /* Ring an NQ doorbell and enable interrupts for the ring. */
@@ -106,10 +108,10 @@ static inline void bnxt_db_nq_arm(struct 
bnxt_cp_ring_info *cpr)
if (unlikely(!cpr->cp_db.db_64))
return;
 
-   rte_smp_wmb();
-   rte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ_ARM |
-   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
-   cpr->cp_db.doorbell);
+   rte_cio_wmb();
+   rte_write64_relaxed(cpr->cp_db.db_key64 | DBR_TYPE_NQ_ARM |
+   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
+   cpr->cp_db.doorbell);
 }
 
 static inline void bnxt_db_cq(struct bnxt_cp_ring_info *cpr)
@@ -117,9 +119,9 @@ static inline void bnxt_db_cq(struct bnxt_cp_ring_info *cpr)
struct bnxt_db_info *db = &cpr->cp_db;
uint32_t idx = RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons);
 
-   rte_smp_wmb();
+   rte_compiler_barrier();
if (db->db_64)
-   rte_write64(db->db_key64 | idx, db->doorbell);
+   rte_write64_relaxed(db->db_key64 | idx, db->doorbell);
else
B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
 }
-- 
2.10.1

Re: [dpdk-dev] [PATCH dpdk-dev] net/mlx5: check the reg available for metadata action

[Slava Ovsiienko]

Hi, Tonghao

Thank you for the patch.
I suppose, the patch should be extended to encompass the routines:
- flow_dv_convert_action_mark
- flow_dv_convert_action_set_meta (done in the patch)
- flow_dv_validate_item_mark
- flow_dv_validate_item_mark
- flow_dv_validate_action_flag
- flow_dv_validate_action_mark

In action converting routines we should add MLX5_ASSERT()
(returning REG_NONE must not happen there - the wrong
conditions must be filtered out on validation stage)

One more point - it would be good to add cc:sta...@dpdk.org

Would you like to extend the patch or let us do it?

With  best regards,
Slava

> -Original Message-
> From: xiangxia.m@gmail.com 
> Sent: Wednesday, May 20, 2020 4:33
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: Tonghao Zhang 
> Subject: [PATCH dpdk-dev] net/mlx5: check the reg available for metadata
> action
> 
> From: Tonghao Zhang 
> 
> If user don't set the dv_xmeta_en to 1 or 2, in the
> flow_dv_convert_action_set_meta function:
> * flow_dv_get_metadata_reg may return the REG_NONE,
>   when MLX5_METADATA_FDB enabled for metadata set
>   action.
> * reg_to_field(REG_NONE) return MLX5_MODI_OUT_NONE
>   which is invalid.
> 
> The rdma-core calltrace:
> dr_action_create_modify_action
> dr_actions_convert_modify_header
> dr_action_modify_sw_to_hw
> dr_action_modify_sw_to_hw_set
> dr_ste_get_modify_hdr_hw_field
> 
> sw_field [MLX5_MODI_OUT_NONE 4095]
> should not > ste_ctx->modify_hdr_field_arr_sz [92]
> 
> As doc[1] says:
> | dv_xmeta_en 0, this is default value, defines the legacy mode, the
> | MARK and META related actions and items operate only within NIC Tx and
> | NIC Rx steering domains, no MARK and META information crosses the
> | domain boundaries.
> 
> This patch add check for that case to warn that not supported.
> 
> [1] -
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.dp
> dk.org%2Fguides-
> 20.02%2Fnics%2Fmlx5.html&data=02%7C01%7Cviacheslavo%40mellan
> ox.com%7C49a86a92f7884fb4d45808d7fc5de31a%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C637255352498582078&sdata=cDfb%2F
> oJAPNvGhMjUrjmjAE3R%2FH4wUpOI7WcZ5miTLvA%3D&reserved=0
> 
> Signed-off-by: Tonghao Zhang 
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index e4818319507c..dfcaf90eda11
> 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1251,6 +1251,12 @@ flow_dv_convert_action_set_meta
> 
>   if (reg < 0)
>   return reg;
> +
> + if (reg == REG_NONE)
> + return rte_flow_error_set(error, ENOTSUP,
> +   RTE_FLOW_ERROR_TYPE_ITEM,
> +   NULL, "unavailable "
> +   "metadata register");
>   /*
>* In datapath code there is no endianness
>* coversions for perfromance reasons, all
> --
> 2.26.1

[dpdk-dev] [PATCH v2 0/2] bnxt fixes

[Kalesh A P]

From: Kalesh AP 

These are two bug fixes observed during regression testing
with DPDK 20.05-rc3.

Please apply.

V2: fixed commit message and added Reviewed-by tag.

Kalesh AP (1):
  net/bnxt: fix the check for validating??link speed

Rahul Gupta (1):
  net/bnxt: performance fix for Arm

 drivers/net/bnxt/bnxt.h|  1 +
 drivers/net/bnxt/bnxt_cpr.h|  6 +++---
 drivers/net/bnxt/bnxt_ethdev.c |  2 +-
 drivers/net/bnxt/bnxt_hwrm.c   | 14 +-
 drivers/net/bnxt/bnxt_ring.h   | 24 +---
 5 files changed, 27 insertions(+), 20 deletions(-)

-- 
2.10.1

[dpdk-dev] [PATCH v2 2/2] net/bnxt: performance fix for Arm

[Kalesh A P]

From: Rahul Gupta 

Eliminate unnecessary rte_smp_wmb() before writing to request/completion
doorbells. Use rte_cio_wmb() memory barrier instead of rte_io_wmb() before
writing to tx/rx request queue doorbells and use rte_compiler_barrier()
before writing to tx/rx completion queue doorbells.

Fixes: 4af9d0c72941 ("net/bnxt: cleanup NQ doorbell")
Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
Cc: sta...@dpdk.org

Signed-off-by: Rahul Gupta 
Signed-off-by: Kalesh AP 
Reviewed-by: Ajit Kumar Khaparde 
Reviewed-by: Lance Richardson 
---
 drivers/net/bnxt/bnxt_cpr.h  |  6 +++---
 drivers/net/bnxt/bnxt_ring.h | 24 +---
 2 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.h b/drivers/net/bnxt/bnxt_cpr.h
index c288078..cccd6cd 100644
--- a/drivers/net/bnxt/bnxt_cpr.h
+++ b/drivers/net/bnxt/bnxt_cpr.h
@@ -64,9 +64,9 @@ struct bnxt_db_info;
(cons));\
 } while (0)
 #define B_CP_DIS_DB(cpr, raw_cons) \
-   rte_write32((DB_CP_FLAGS |  \
-   RING_CMP(((cpr)->cp_ring_struct), raw_cons)),   \
-   ((cpr)->cp_db.doorbell))
+   rte_write32_relaxed((DB_CP_FLAGS |  \
+   RING_CMP(((cpr)->cp_ring_struct), raw_cons)), \
+   ((cpr)->cp_db.doorbell))
 
 #define B_CP_DB(cpr, raw_cons, ring_mask)  \
rte_write32((DB_CP_FLAGS |  \
diff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h
index 48a39d7..9913aed 100644
--- a/drivers/net/bnxt/bnxt_ring.h
+++ b/drivers/net/bnxt/bnxt_ring.h
@@ -82,10 +82,12 @@ void bnxt_free_rxtx_nq_ring(struct bnxt *bp);
 
 static inline void bnxt_db_write(struct bnxt_db_info *db, uint32_t idx)
 {
+   rte_cio_wmb();
+
if (db->db_64)
rte_write64_relaxed(db->db_key64 | idx, db->doorbell);
else
-   rte_write32(db->db_key32 | idx, db->doorbell);
+   rte_write32_relaxed(db->db_key32 | idx, db->doorbell);
 }
 
 /* Ring an NQ doorbell and disable interrupts for the ring. */
@@ -94,10 +96,10 @@ static inline void bnxt_db_nq(struct bnxt_cp_ring_info *cpr)
if (unlikely(!cpr->cp_db.db_64))
return;
 
-   rte_smp_wmb();
-   rte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ |
-   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
-   cpr->cp_db.doorbell);
+   rte_cio_wmb();
+   rte_write64_relaxed(cpr->cp_db.db_key64 | DBR_TYPE_NQ |
+   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
+   cpr->cp_db.doorbell);
 }
 
 /* Ring an NQ doorbell and enable interrupts for the ring. */
@@ -106,10 +108,10 @@ static inline void bnxt_db_nq_arm(struct 
bnxt_cp_ring_info *cpr)
if (unlikely(!cpr->cp_db.db_64))
return;
 
-   rte_smp_wmb();
-   rte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ_ARM |
-   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
-   cpr->cp_db.doorbell);
+   rte_cio_wmb();
+   rte_write64_relaxed(cpr->cp_db.db_key64 | DBR_TYPE_NQ_ARM |
+   RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),
+   cpr->cp_db.doorbell);
 }
 
 static inline void bnxt_db_cq(struct bnxt_cp_ring_info *cpr)
@@ -117,9 +119,9 @@ static inline void bnxt_db_cq(struct bnxt_cp_ring_info *cpr)
struct bnxt_db_info *db = &cpr->cp_db;
uint32_t idx = RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons);
 
-   rte_smp_wmb();
+   rte_compiler_barrier();
if (db->db_64)
-   rte_write64(db->db_key64 | idx, db->doorbell);
+   rte_write64_relaxed(db->db_key64 | idx, db->doorbell);
else
B_CP_DIS_DB(cpr, cpr->cp_raw_cons);
 }
-- 
2.10.1

Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to nanoseconds

[PATRICK KEROULAS]

> > > > mlx5 part of libibverbs includes a ts-to-ns converter which takes the
> > > > instantaneous clock info. It's unused in dpdk so far. I've tested it in 
> > > > the
> > > > device/port init routine and the result looks reliable. Since this 
> > > > approach
> > > > looks very simple, compared to the time sync mechanism, I'm trying to
> > > > integrate.
> > > >
> > > > The conversion should occur in the primary process (testpmd) I suppose.
> > > > 1) The needed clock info derives from ethernet device. Is it possible to
> > > >access that struct from a rx callback?
> > > > 2) how to attach the nanosecond to mbuf so that `pdump` catches it?
> > > >(workaround: copy `mbuf->udata64` in forwarded packets.)
> > > > 3) any other idea?
> > >
> > > The timestamp is carried in mbuf.
> > > Then the conversion must be done by the ethdev caller (application or
> > > any other upper layer).
> >
> > What if the converter function needs a clock_info?
> > https://github.com/linux-rdma/rdma-core/blob/7af01c79e00555207dee6132d72e7bfc1bb5485e/providers/mlx5/mlx5dv.h#L1201
> > I'm affraid this info may change by the time the converter is called
> > by upper layer.
>
> Indeed, the clock in the device is not an atomic one :)
> We need to adjust the time conversion continuously.
> I am not an expert of time synchronization, so I add more people Cc
> who could help for having a precise timestamp.

Thanks Thomas.
Not sure this is a synchronization issue. We have dedicated processes
(linuxptp) to keep both NIC and sys clocks in sync with an external clock.
It is "just" a matter of unit conversion.

If it has to be performed in dpdk-pdump, I would need some help to
retrieve mlx5_clock_info from inside a secondary process. Looking at
mlx5_read_clock(), this info is extracted from ibv_context which looks
reachable in a primary process only (segfault, if I try in pdump).

[dpdk-dev] [PATCH] doc: add tested Marvell integrated NIC platforms

[jerinj]

From: Jerin Jacob 

Add tested Marvell integrated NIC platforms to v20.05 release notes.

Signed-off-by: Jerin Jacob 
---
 doc/guides/rel_notes/release_20_05.rst | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_05.rst 
b/doc/guides/rel_notes/release_20_05.rst
index 84706904e..8701e851e 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -409,3 +409,18 @@ Tested Platforms
This section is a comment. Do not overwrite or remove it.
Also, make sure to start the actual text at the margin.
=
+
+* ARMv8 SoC combinations from Marvell (with integrated NICs)
+
+  * SoC:
+
+* CN83xx, CN96xx, CN93xx
+
+  * OS (Based on Marvell OCTEON TX SDK-10.3.2.0-PR12):
+
+* Arch Linux
+* Buildroot 2018.11
+* Ubuntu 16.04.1 LTS
+* Ubuntu 16.10
+* Ubuntu 18.04.1
+* Ubuntu 19.04
-- 
2.26.2

[dpdk-dev] [Bug 485] pipe_profile_check function have wrong argument size

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=485

Bug ID: 485
   Summary: pipe_profile_check function have wrong argument size
   Product: DPDK
   Version: 19.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: major
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: hrvoje.habja...@zg.ht.hr
  Target Milestone: ---

Created attachment 106
  --> https://bugs.dpdk.org/attachment.cgi?id=106&action=edit
Correct rate argument of pipe_profile_check function

Hi.

Function pipe_profile_check (in lib/librte_sched/rte_sched.c, line 306) is used
to check for correct parameters in pipe profile. One of checks is to ensure
that pipe profile rate is equal or below subport rate. Subport rate is provided
as function argument.

In case that port and subport rate is set to 40G, pipe_profile_check fails
because 40G converted to bytes is bigger that uint32 which is used for check.

Fix is simple, and just requires that rate argument of pipe_profile_check
should be changed to uint64_t.

Regards,

H.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[dpdk-dev] [PATCH 1/2] net/bnxt: fix the check for validating link speed

[Kalesh A P]

From: Kalesh AP 

bnxt PMD uses the macro BNXT_SUPPORTED_SPEEDS to validate
the user requested speed. But this has all the speed values
supported by the PMD and is not chip specific.

The check against this macro returns success when the user
tries set the speed to 100G on a port even if the chip does
not support 100G speed.

Fixed it to use bnxt_get_speed_capabilities() to check the
supported speeds by the chip.

Fixes: 1d0704f4d793 ("net/bnxt: add device configure operation")
Cc: sta...@dpdk.org

Signed-off-by: Kalesh AP 
Reviewed-by: Somnath Kotur 
Reviewed-by: Ajit Kumar Khaparde 
---
 drivers/net/bnxt/bnxt.h|  1 +
 drivers/net/bnxt/bnxt_ethdev.c |  2 +-
 drivers/net/bnxt/bnxt_hwrm.c   | 14 +-
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 446764c..2c3aef6 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -780,4 +780,5 @@ void bnxt_cancel_fc_thread(struct bnxt *bp);
 void bnxt_flow_cnt_alarm_cb(void *arg);
 int bnxt_flow_stats_req(struct bnxt *bp);
 int bnxt_flow_stats_cnt(struct bnxt *bp);
+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp);
 #endif
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ae495da..e635781 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -778,7 +778,7 @@ static int bnxt_shutdown_nic(struct bnxt *bp)
  * Device configuration and status function
  */
 
-static uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
 {
uint32_t link_speed = bp->link_info->support_speeds;
uint32_t speed_capa = 0;
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index c1798b5..945bc90 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2788,13 +2788,18 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t 
conf_link_speed)
ETH_LINK_SPEED_40G | ETH_LINK_SPEED_50G | \
ETH_LINK_SPEED_100G | ETH_LINK_SPEED_200G)
 
-static int bnxt_valid_link_speed(uint32_t link_speed, uint16_t port_id)
+static int bnxt_validate_link_speed(struct bnxt *bp)
 {
+   uint32_t link_speed = bp->eth_dev->data->dev_conf.link_speeds;
+   uint16_t port_id = bp->eth_dev->data->port_id;
+   uint32_t link_speed_capa;
uint32_t one_speed;
 
if (link_speed == ETH_LINK_SPEED_AUTONEG)
return 0;
 
+   link_speed_capa = bnxt_get_speed_capabilities(bp);
+
if (link_speed & ETH_LINK_SPEED_FIXED) {
one_speed = link_speed & ~ETH_LINK_SPEED_FIXED;
 
@@ -2804,14 +2809,14 @@ static int bnxt_valid_link_speed(uint32_t link_speed, 
uint16_t port_id)
link_speed, port_id);
return -EINVAL;
}
-   if ((one_speed & BNXT_SUPPORTED_SPEEDS) != one_speed) {
+   if ((one_speed & link_speed_capa) != one_speed) {
PMD_DRV_LOG(ERR,
"Unsupported advertised speed (%u) for port 
%u\n",
link_speed, port_id);
return -EINVAL;
}
} else {
-   if (!(link_speed & BNXT_SUPPORTED_SPEEDS)) {
+   if (!(link_speed & link_speed_capa)) {
PMD_DRV_LOG(ERR,
"Unsupported advertised speeds (%u) for port 
%u\n",
link_speed, port_id);
@@ -2957,8 +2962,7 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool 
link_up)
if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp))
return 0;
 
-   rc = bnxt_valid_link_speed(dev_conf->link_speeds,
-   bp->eth_dev->data->port_id);
+   rc = bnxt_validate_link_speed(bp);
if (rc)
goto error;
 
-- 
2.10.1

[dpdk-dev] [PATCH v2 1/2] net/bnxt: fix the check for validating link speed

[Kalesh A P]

From: Kalesh AP 

bnxt PMD uses the macro BNXT_SUPPORTED_SPEEDS to validate
the user requested speed. But this has all the speed values
supported by the PMD and is not chip specific.

The check against this macro returns success when the user
tries set the speed to 100G on a port even if the chip does
not support 100G speed.

Fixed it to use bnxt_get_speed_capabilities() to check the
supported speeds by the chip.

Fixes: 1d0704f4d793 ("net/bnxt: add device configure operation")
Cc: sta...@dpdk.org

Signed-off-by: Kalesh AP 
Reviewed-by: Somnath Kotur 
Reviewed-by: Ajit Kumar Khaparde 
---
 drivers/net/bnxt/bnxt.h|  1 +
 drivers/net/bnxt/bnxt_ethdev.c |  2 +-
 drivers/net/bnxt/bnxt_hwrm.c   | 14 +-
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 446764c..2c3aef6 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -780,4 +780,5 @@ void bnxt_cancel_fc_thread(struct bnxt *bp);
 void bnxt_flow_cnt_alarm_cb(void *arg);
 int bnxt_flow_stats_req(struct bnxt *bp);
 int bnxt_flow_stats_cnt(struct bnxt *bp);
+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp);
 #endif
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ae495da..e635781 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -778,7 +778,7 @@ static int bnxt_shutdown_nic(struct bnxt *bp)
  * Device configuration and status function
  */
 
-static uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
+uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
 {
uint32_t link_speed = bp->link_info->support_speeds;
uint32_t speed_capa = 0;
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index c1798b5..945bc90 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2788,13 +2788,18 @@ static uint16_t bnxt_parse_eth_link_speed(uint32_t 
conf_link_speed)
ETH_LINK_SPEED_40G | ETH_LINK_SPEED_50G | \
ETH_LINK_SPEED_100G | ETH_LINK_SPEED_200G)
 
-static int bnxt_valid_link_speed(uint32_t link_speed, uint16_t port_id)
+static int bnxt_validate_link_speed(struct bnxt *bp)
 {
+   uint32_t link_speed = bp->eth_dev->data->dev_conf.link_speeds;
+   uint16_t port_id = bp->eth_dev->data->port_id;
+   uint32_t link_speed_capa;
uint32_t one_speed;
 
if (link_speed == ETH_LINK_SPEED_AUTONEG)
return 0;
 
+   link_speed_capa = bnxt_get_speed_capabilities(bp);
+
if (link_speed & ETH_LINK_SPEED_FIXED) {
one_speed = link_speed & ~ETH_LINK_SPEED_FIXED;
 
@@ -2804,14 +2809,14 @@ static int bnxt_valid_link_speed(uint32_t link_speed, 
uint16_t port_id)
link_speed, port_id);
return -EINVAL;
}
-   if ((one_speed & BNXT_SUPPORTED_SPEEDS) != one_speed) {
+   if ((one_speed & link_speed_capa) != one_speed) {
PMD_DRV_LOG(ERR,
"Unsupported advertised speed (%u) for port 
%u\n",
link_speed, port_id);
return -EINVAL;
}
} else {
-   if (!(link_speed & BNXT_SUPPORTED_SPEEDS)) {
+   if (!(link_speed & link_speed_capa)) {
PMD_DRV_LOG(ERR,
"Unsupported advertised speeds (%u) for port 
%u\n",
link_speed, port_id);
@@ -2957,8 +2962,7 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool 
link_up)
if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp))
return 0;
 
-   rc = bnxt_valid_link_speed(dev_conf->link_speeds,
-   bp->eth_dev->data->port_id);
+   rc = bnxt_validate_link_speed(bp);
if (rc)
goto error;
 
-- 
2.10.1

[dpdk-dev] net/iavf: fix protocol field selector configure

[Jeff Guo]

When VFs configure the rss rule by virtchnl, it need to set bit mask into
the field selector for the protocol, then PF got the configure massage and
parse the field selector to the corresponding protocol field.

Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

Signed-off-by: Jeff Guo 
---
 drivers/net/iavf/iavf_hash.c | 474 +--
 1 file changed, 280 insertions(+), 194 deletions(-)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index af528863b..1e0ffad4c 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -43,6 +43,7 @@ struct iavf_hash_match_type {
enum iavf_pattern_hint_type phint_type;
uint64_t hash_type;
struct virtchnl_proto_hdrs *proto_hdrs;
+   uint32_t link_type;
 };
 
 struct iavf_rss_meta {
@@ -147,8 +148,11 @@ static struct iavf_pattern_match_item 
iavf_hash_pattern_list[] = {
{iavf_pattern_empty, IAVF_INSET_NONE, &phint_empty},
 };
 
-#defineGTP_EH_PDU_LINK_UP  1
-#defineGTP_EH_PDU_LINK_DWN 0
+enum iavf_pattern_link_type {
+   IAVF_PATTERN_LINK_DOWN,
+   IAVF_PATTERN_LINK_UP,
+   IAVF_PATTERN_LINK_NONE,
+};
 
 #define TUNNEL_LEVEL_OUTER 0
 #define TUNNEL_LEVEL_FIRST_INNER   1
@@ -160,103 +164,112 @@ static struct iavf_pattern_match_item 
iavf_hash_pattern_list[] = {
 #define BUFF_NOUSED0
 #define FIELD_FOR_PROTO_ONLY   0
 
+#define FIELD_SELECTOR(proto_hdr_field)(1UL << ((proto_hdr_field) % \
+(1UL << PROTO_HDR_SHIFT)))
+
 #define proto_hint_eth_src { \
-   VIRTCHNL_PROTO_HDR_ETH, VIRTCHNL_PROTO_HDR_ETH_SRC, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_eth_dst { \
-   VIRTCHNL_PROTO_HDR_ETH, VIRTCHNL_PROTO_HDR_ETH_DST, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_eth_only { \
VIRTCHNL_PROTO_HDR_ETH, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_eth { \
VIRTCHNL_PROTO_HDR_ETH, \
-   VIRTCHNL_PROTO_HDR_ETH_SRC | VIRTCHNL_PROTO_HDR_ETH_DST, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST), {BUFF_NOUSED } }
 
 #define proto_hint_svlan { \
-   VIRTCHNL_PROTO_HDR_S_VLAN, VIRTCHNL_PROTO_HDR_S_VLAN_ID, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_S_VLAN, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_S_VLAN_ID), {BUFF_NOUSED } }
 
 #define proto_hint_cvlan { \
-   VIRTCHNL_PROTO_HDR_C_VLAN, VIRTCHNL_PROTO_HDR_C_VLAN_ID, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_C_VLAN, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_C_VLAN_ID), {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_src { \
-   VIRTCHNL_PROTO_HDR_IPV4, VIRTCHNL_PROTO_HDR_IPV4_SRC, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_dst { \
-   VIRTCHNL_PROTO_HDR_IPV4, VIRTCHNL_PROTO_HDR_IPV4_DST, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_only { \
VIRTCHNL_PROTO_HDR_IPV4, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_ipv4 { \
VIRTCHNL_PROTO_HDR_IPV4, \
-   VIRTCHNL_PROTO_HDR_IPV4_SRC | VIRTCHNL_PROTO_HDR_IPV4_DST, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), {BUFF_NOUSED } }
 
 #define proto_hint_udp_src_port { \
-   VIRTCHNL_PROTO_HDR_UDP, VIRTCHNL_PROTO_HDR_UDP_SRC_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_UDP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_udp_dst_port { \
-   VIRTCHNL_PROTO_HDR_UDP, VIRTCHNL_PROTO_HDR_UDP_DST_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_UDP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_udp_only { \
VIRTCHNL_PROTO_HDR_UDP, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_udp { \
VIRTCHNL_PROTO_HDR_UDP, \
-   VIRTCHNL_PROTO_HDR_UDP_SRC_PORT | VIRTCHNL_PROTO_HDR_UDP_DST_PORT, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_tcp_src_port { \
-   VIRTCHNL_PROTO_HDR_TCP, VIRTCHNL_PROTO_HDR_TCP_SRC_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_TCP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_tcp_dst_port { \
-   VIRTCHNL_PROTO_HDR_TCP, VIRTCHNL_PROTO_HDR_TCP_DST_PORT, \
-   {BUFF_NOUSED } }
+

[dpdk-dev] net/iavf: fix protocol field selector configure

[Jeff Guo]

When VFs configure the rss rule by virtchnl, it need to set bit mask into
the field selector for the protocol, then PF got the configure massage and
parse the field selector to the corresponding protocol field.

Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

Signed-off-by: Jeff Guo 
---
 drivers/net/iavf/iavf_hash.c | 474 +--
 1 file changed, 280 insertions(+), 194 deletions(-)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index af528863b..1e0ffad4c 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -43,6 +43,7 @@ struct iavf_hash_match_type {
enum iavf_pattern_hint_type phint_type;
uint64_t hash_type;
struct virtchnl_proto_hdrs *proto_hdrs;
+   uint32_t link_type;
 };
 
 struct iavf_rss_meta {
@@ -147,8 +148,11 @@ static struct iavf_pattern_match_item 
iavf_hash_pattern_list[] = {
{iavf_pattern_empty, IAVF_INSET_NONE, &phint_empty},
 };
 
-#defineGTP_EH_PDU_LINK_UP  1
-#defineGTP_EH_PDU_LINK_DWN 0
+enum iavf_pattern_link_type {
+   IAVF_PATTERN_LINK_DOWN,
+   IAVF_PATTERN_LINK_UP,
+   IAVF_PATTERN_LINK_NONE,
+};
 
 #define TUNNEL_LEVEL_OUTER 0
 #define TUNNEL_LEVEL_FIRST_INNER   1
@@ -160,103 +164,112 @@ static struct iavf_pattern_match_item 
iavf_hash_pattern_list[] = {
 #define BUFF_NOUSED0
 #define FIELD_FOR_PROTO_ONLY   0
 
+#define FIELD_SELECTOR(proto_hdr_field)(1UL << ((proto_hdr_field) % \
+(1UL << PROTO_HDR_SHIFT)))
+
 #define proto_hint_eth_src { \
-   VIRTCHNL_PROTO_HDR_ETH, VIRTCHNL_PROTO_HDR_ETH_SRC, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_eth_dst { \
-   VIRTCHNL_PROTO_HDR_ETH, VIRTCHNL_PROTO_HDR_ETH_DST, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_ETH, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_eth_only { \
VIRTCHNL_PROTO_HDR_ETH, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_eth { \
VIRTCHNL_PROTO_HDR_ETH, \
-   VIRTCHNL_PROTO_HDR_ETH_SRC | VIRTCHNL_PROTO_HDR_ETH_DST, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_SRC) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_ETH_DST), {BUFF_NOUSED } }
 
 #define proto_hint_svlan { \
-   VIRTCHNL_PROTO_HDR_S_VLAN, VIRTCHNL_PROTO_HDR_S_VLAN_ID, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_S_VLAN, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_S_VLAN_ID), {BUFF_NOUSED } }
 
 #define proto_hint_cvlan { \
-   VIRTCHNL_PROTO_HDR_C_VLAN, VIRTCHNL_PROTO_HDR_C_VLAN_ID, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_C_VLAN, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_C_VLAN_ID), {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_src { \
-   VIRTCHNL_PROTO_HDR_IPV4, VIRTCHNL_PROTO_HDR_IPV4_SRC, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_dst { \
-   VIRTCHNL_PROTO_HDR_IPV4, VIRTCHNL_PROTO_HDR_IPV4_DST, {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_IPV4, FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), \
+   {BUFF_NOUSED } }
 
 #define proto_hint_ipv4_only { \
VIRTCHNL_PROTO_HDR_IPV4, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_ipv4 { \
VIRTCHNL_PROTO_HDR_IPV4, \
-   VIRTCHNL_PROTO_HDR_IPV4_SRC | VIRTCHNL_PROTO_HDR_IPV4_DST, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), {BUFF_NOUSED } }
 
 #define proto_hint_udp_src_port { \
-   VIRTCHNL_PROTO_HDR_UDP, VIRTCHNL_PROTO_HDR_UDP_SRC_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_UDP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_udp_dst_port { \
-   VIRTCHNL_PROTO_HDR_UDP, VIRTCHNL_PROTO_HDR_UDP_DST_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_UDP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_udp_only { \
VIRTCHNL_PROTO_HDR_UDP, FIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }
 
 #define proto_hint_udp { \
VIRTCHNL_PROTO_HDR_UDP, \
-   VIRTCHNL_PROTO_HDR_UDP_SRC_PORT | VIRTCHNL_PROTO_HDR_UDP_DST_PORT, \
-   {BUFF_NOUSED } }
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_SRC_PORT) | \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_UDP_DST_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_tcp_src_port { \
-   VIRTCHNL_PROTO_HDR_TCP, VIRTCHNL_PROTO_HDR_TCP_SRC_PORT, \
-   {BUFF_NOUSED } }
+   VIRTCHNL_PROTO_HDR_TCP, \
+   FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_TCP_SRC_PORT), {BUFF_NOUSED } }
 
 #define proto_hint_tcp_dst_port { \
-   VIRTCHNL_PROTO_HDR_TCP, VIRTCHNL_PROTO_HDR_TCP_DST_PORT, \
-   {BUFF_NOUSED } }
+

Re: [dpdk-dev] winget: Windows package manager

[Dmitry Kozlyuk]

On Fri, 22 May 2020 11:32:05 +0200
Thomas Monjalon  wrote:

> Hi,
> 
> Now there is an official package manager in Windows:
> https://devblogs.microsoft.com/commandline/windows-package-manager-preview/
> 
> Who wants to build a DPDK package?
> 
> Where the manifest should be hosted? We used to have a directory pkg/...

AFAICT from docs and GitHub, winget is not a package manager, but more like a
console client for downloading and running readily-available installers.
It does not provide a package format or package build infrastructure like RPM,
DEB, etc do. It doesn't even have a concept of dependency or an installation
script, it cannot even download an archive and extract it. What it has is a
repository with MS-approved manifests and lots of open questions (how are
these packages verified? who maintains them? what is update procedure?).

Winget repository contains no build tools for DPDK on Windows (Ninja, Clang,
MinGW-w64; it has Python for Meson, though). These are the ones we may want
manifested first.

IMO, Chocolatey is a way to go for Windows GSG, for it is mature and its
package database contains everything needed.

-- 
Dmitry Kozlyuk

Re: [dpdk-dev] [PATCH v2 0/2] bnxt fixes

[Ajit Khaparde]

On Fri, May 22, 2020 at 10:26 AM Kalesh A P <
kalesh-anakkur.pura...@broadcom.com> wrote:

> From: Kalesh AP 
>
> These are two bug fixes observed during regression testing
> with DPDK 20.05-rc3.
>
> Please apply.
>
Patches applied to dpdk-next-net-brcm. Thanks


>
> V2: fixed commit message and added Reviewed-by tag.
>
> Kalesh AP (1):
>   net/bnxt: fix the check for validating link speed
>
> Rahul Gupta (1):
>   net/bnxt: performance fix for Arm
>
>  drivers/net/bnxt/bnxt.h|  1 +
>  drivers/net/bnxt/bnxt_cpr.h|  6 +++---
>  drivers/net/bnxt/bnxt_ethdev.c |  2 +-
>  drivers/net/bnxt/bnxt_hwrm.c   | 14 +-
>  drivers/net/bnxt/bnxt_ring.h   | 24 +---
>  5 files changed, 27 insertions(+), 20 deletions(-)
>
> --
> 2.10.1
>
>

[dpdk-dev] [PATCH] net/bnxt: fix a segfault during close

[Ajit Khaparde]

We are freeing flow_stats a little early. This results in a
segfault when the driver accesses the members during cleanup.
Move the call to bnxt_free_flow_stats_info() to prevent this.

Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
Signed-off-by: Ajit Khaparde 
---
 drivers/net/bnxt/bnxt_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e63578109..e8b4c058a 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp)
 
 static void bnxt_free_mem(struct bnxt *bp, bool reconfig)
 {
-   bnxt_free_flow_stats_info(bp);
-
bnxt_free_filter_mem(bp);
bnxt_free_vnic_attributes(bp);
bnxt_free_vnic_mem(bp);
@@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)
bnxt_uninit_ctx_mem(bp);
 
bnxt_uninit_locks(bp);
+   bnxt_free_flow_stats_info(bp);
rte_free(bp->ptp_cfg);
bp->ptp_cfg = NULL;
return rc;
-- 
2.21.1 (Apple Git-122.3)

Re: [dpdk-dev] [PATCH 0/5] misc updates for hns3 PMD driver

[Wei Hu (Xavier)]

On 2020/5/22 19:20, Ferruh Yigit wrote:

On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:

This series are improvement and bugfixes for hns3 PMD driver.

Hi Xavier,

We are planning to have the -rc4 this weekend and the release on Tuesday. So we
are literally a few days away from the release.

It is definitely not good idea to change the code this close to the release,
that is why we are saying -rc4 for the critical defects only.

I will postpone this series to the next release, fyi.

Hi, Ferruh Yigit
  I got it.  I will adjust the frequency of sending patches to the 
community in future.

  Thank you.

  Regards
Xavier

Chengchang Tang (2):
   net/hns3: replace PF vport id zero with private macro
   net/hns3: fix promiscuous config not clear for PF on uninit

Lijun Ou (2):
   net/hns3: add RSS hash offload to port Rx configuration
   net/hns3: fix key length when configuring RSS

Wei Hu (Xavier) (1):
   net/hns3: fix preparing sending packets less than 60 bytes

  drivers/net/hns3/hns3_ethdev.c| 102 --
  drivers/net/hns3/hns3_ethdev.h|   3 ++
  drivers/net/hns3/hns3_ethdev_vf.c |   1 +
  drivers/net/hns3/hns3_flow.c  |   8 +++
  drivers/net/hns3/hns3_rxtx.c  |   6 ---
  5 files changed, 78 insertions(+), 42 deletions(-)

Re: [dpdk-dev] net/iavf: fix protocol field selector configure

[Zhang, Qi Z]

> -Original Message-
> From: Guo, Jia 
> Sent: Saturday, May 23, 2020 7:18 AM
> To: Xing, Beilei ; Zhang, Qi Z ;
> Wu, Jingjing 
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
> 
> Subject: [dpdk-dev] net/iavf: fix protocol field selector configure
> 
> When VFs configure the rss rule by virtchnl, it need to set bit mask into the
> field selector for the protocol, then PF got the configure massage and parse
> the field selector to the corresponding protocol field.
> 
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
> 
> Signed-off-by: Jeff Guo 
> ---
>  drivers/net/iavf/iavf_hash.c | 474 +--
>  1 file changed, 280 insertions(+), 194 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index
> af528863b..1e0ffad4c 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -43,6 +43,7 @@ struct iavf_hash_match_type {
>   enum iavf_pattern_hint_type phint_type;
>   uint64_t hash_type;
>   struct virtchnl_proto_hdrs *proto_hdrs;
> + uint32_t link_type;

If this is just a hint for gtpu link type.
Better to rename to "gtpu_hint"
And use the already defined enum but not uint32_t.
 
>  };
> 
>  struct iavf_rss_meta {
> @@ -147,8 +148,11 @@ static struct iavf_pattern_match_item
> iavf_hash_pattern_list[] = {
>   {iavf_pattern_empty, IAVF_INSET_NONE, &phint_empty},  };
> 
> -#define  GTP_EH_PDU_LINK_UP  1
> -#define  GTP_EH_PDU_LINK_DWN 0
> +enum iavf_pattern_link_type {

Rename to iavf_gtpu_hint.

> + IAVF_PATTERN_LINK_DOWN,
> + IAVF_PATTERN_LINK_UP,
> + IAVF_PATTERN_LINK_NONE,
> +};

The configure is for GTP down/up link, 
The name "xxx_LINK_DOWN", and "xxx_LINK_UP" is a little bit misleading.
Could be 
IAVF_GTPU_HINT_UPLINK.
IAVF_GTPU_HINT_DOWNLINK.
IAVF_GTPU_HINT_N/A

> 
>  #define TUNNEL_LEVEL_OUTER   0
>  #define TUNNEL_LEVEL_FIRST_INNER 1
> @@ -160,103 +164,112 @@ static struct iavf_pattern_match_item
> iavf_hash_pattern_list[] = {
>  #define BUFF_NOUSED  0
>  #define FIELD_FOR_PROTO_ONLY 0
> 
> +#define FIELD_SELECTOR(proto_hdr_field)  (1UL << ((proto_hdr_field) % \
> +  (1UL << PROTO_HDR_SHIFT)))

Could be simplified to.
#define FIELD_SELECTOR(proto_hdr_field) \
(1UL << (proto_hdr_field & PROTO_HDR_FIELD_MASK))

..

Regards
Qi

Re: [dpdk-dev] [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter

[Sun, GuinanX]

Hi

> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, May 22, 2020 5:47 PM
> To: Sun, GuinanX ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming ; Ye, Xiaolong
> 
> Subject: RE: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
> 
> Hi,
> 
> > -Original Message-
> > From: Sun, GuinanX 
> > Sent: Friday, May 22, 2020 2:12 PM
> > To: dev@dpdk.org
> > Cc: Zhao1, Wei ; Sun, GuinanX
> > ; sta...@dpdk.org
> > Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct
> > adapter
> >
> > If some user set mac_ctrl_frame_fwd to 1 from fc ops, then he do a
> > port reset process of
> >
> > testpmd> start
> > testpmd> set flow_ctrl mac_ctrl_frame_fwd on 0 stop port stop 0 port
> > testpmd> start 0 start
> >
> > Then after this process, the mac_ctrl_frame_fwd has been change to
> > "off", so we should delete "adapter->mac_ctrl_frame_fwd = 0;" from dev-stop.
> >
> > In addition, add a value to mac_ctrl_frame_fwd in the
> > ixgbe_flow_ctrl_get () function.
> >
> > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: SunGuinan 
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index f8a84c565..dd4023f01 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
> >
> >  adapter->rss_reta_updated = 0;
> >
> > -adapter->mac_ctrl_frame_fwd = 0;
> > -
> >  hw->adapter_stopped = true;
> >  }
> >
> > @@ -4754,6 +4752,8 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev,
> > struct rte_eth_fc_conf *fc_conf)
> >   * MFLCN register.
> >   */
> >  mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
> > +fc_conf->mac_ctrl_frame_fwd = mflcn_reg;
> > +
> 
> 
> Error, that is not right!!

You are right, I will make corrections later.
In addition, the problem of ixgbe_flow_ctrl_get () and the timing of 
mac_ctrl_frame_fwd are two problems. 
I will make a patch set and release it later.

> 
> >  if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))  rx_pause =
> > 1;  else
> > --
> > 2.17.1
> 

[dpdk-dev] [PATCH] net/bnxt: allow the mark to use a cfa code of zero

[Mike Baucom]

The mark code was too restrictive by disallowing a cfa_code of zero.
This code loosens the requirement and allows zero.

Fixes: b87abb2e55cb ("net/bnxt: support marking packet")

Signed-off-by: Mike Baucom 
Reviewed-by: Kishore Padmanabha 
---
 drivers/net/bnxt/bnxt_rxr.c | 20 +---
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index ee1acb1..91ff729 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -465,17 +465,15 @@ static inline struct rte_mbuf *bnxt_tpa_end(
break;
}
 
-   if (cfa_code) {
-   rc = ulp_mark_db_mark_get(bp->ulp_ctx, gfid,
- cfa_code, &mark_id);
-   if (!rc) {
-   /* Got the mark, write it to the mbuf and return */
-   mbuf->hash.fdir.hi = mark_id;
-   mbuf->udata64 = (cfa_code & 0xull) << 32;
-   mbuf->hash.fdir.id = rxcmp1->cfa_code;
-   mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
-   return;
-   }
+   rc = ulp_mark_db_mark_get(bp->ulp_ctx, gfid,
+ cfa_code, &mark_id);
+   if (!rc) {
+   /* Got the mark, write it to the mbuf and return */
+   mbuf->hash.fdir.hi = mark_id;
+   mbuf->udata64 = (cfa_code & 0xull) << 32;
+   mbuf->hash.fdir.id = rxcmp1->cfa_code;
+   mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID;
+   return;
}
 
 skip_mark:
-- 
1.9.1

Re: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during close

[Ajit Khaparde]

On Fri, May 22, 2020 at 2:27 PM Ajit Khaparde 
wrote:

> We are freeing flow_stats a little early. This results in a
> segfault when the driver accesses the members during cleanup.
> Move the call to bnxt_free_flow_stats_info() to prevent this.
>
> Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
> Signed-off-by: Ajit Khaparde 
>
Patch applied to dpdk-next-net-brcm.


> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index e63578109..e8b4c058a 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp)
>
>  static void bnxt_free_mem(struct bnxt *bp, bool reconfig)
>  {
> -   bnxt_free_flow_stats_info(bp);
> -
> bnxt_free_filter_mem(bp);
> bnxt_free_vnic_attributes(bp);
> bnxt_free_vnic_mem(bp);
> @@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool
> reconfig_dev)
> bnxt_uninit_ctx_mem(bp);
>
> bnxt_uninit_locks(bp);
> +   bnxt_free_flow_stats_info(bp);
> rte_free(bp->ptp_cfg);
> bp->ptp_cfg = NULL;
> return rc;
> --
> 2.21.1 (Apple Git-122.3)
>
>

[dpdk-dev] [PATCH v2 0/2] fix MAC ctrl frame fwd get

[Guinan Sun]

Fix incorrect MAC control frame forward.
Fix flow control status get.
---
v2 changes:
* Rebase.
* Split into two patches.
* Set fc mac_ctrl_frame_fwd by bit operation.
* Modify commit messge.

Guinan Sun (2):
  net/ixgbe: fix incorrect MAC control frame forward
  net/ixgbe: fix flow control status get

 drivers/net/ixgbe/ixgbe_ethdev.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
2.17.1

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix incorrect MAC control frame forward

[Guinan Sun]

mac_ctrl_frame_fwd shouldn't be cleared when port stop,
otherwise it will be inconsistent with the actual status.
This patch fixes the issue.

Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: sta...@dpdk.org

Signed-off-by: Guinan Sun 
---
v2 changes:
* Modified commit messge.
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f8a84c565..42947ba40 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2939,8 +2939,6 @@ ixgbe_dev_stop(struct rte_eth_dev *dev)
 
adapter->rss_reta_updated = 0;
 
-   adapter->mac_ctrl_frame_fwd = 0;
-
hw->adapter_stopped = true;
 }
 
-- 
2.17.1

[dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix flow control status get

[Guinan Sun]

mac_ctrl_frame_fwd assignment is missing, so
setting mac_ctrl_frame_fwd should be added in
ixgbe_flow_ctrl_get().
The patch fixes the issue.

Fixes: 56ea46a997b7 ("ethdev: retrieve flow control configuration")
Cc: sta...@dpdk.org

Signed-off-by: Guinan Sun 
---
v2 changes:
* Set fc mac_ctrl_frame_fwd by bit operation.
* Modified commit messge.
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 42947ba40..890d756e4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4752,6 +4752,11 @@ ixgbe_flow_ctrl_get(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
 * MFLCN register.
 */
mflcn_reg = IXGBE_READ_REG(hw, IXGBE_MFLCN);
+   if (mflcn_reg & IXGBE_MFLCN_PMCF)
+   fc_conf->mac_ctrl_frame_fwd = 1;
+   else
+   fc_conf->mac_ctrl_frame_fwd = 0;
+
if (mflcn_reg & (IXGBE_MFLCN_RPFCE | IXGBE_MFLCN_RFCE))
rx_pause = 1;
else
-- 
2.17.1

[dpdk-dev] [Bug 477] Typing error in index.rst of doc/guides/eventdevs at line 8

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=477

Ajit Khaparde (ajit.khapa...@broadcom.com) changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ajit.khapa...@broadcom.com
 Resolution|--- |FIXED

--- Comment #3 from Ajit Khaparde (ajit.khapa...@broadcom.com) ---
Fixed with commit 5a448a55b4bb39720a42d9a186ed35dd6515e980

-- 
You are receiving this mail because:
You are the assignee for the bug.