Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix unitialized data warning
On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger
wrote:
>
> Valgrind reports that eal interrupt thread is calling epoll_ctl
> with uninitialized data. Trivial to fix by initializing it.
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta...@dpdk.org
> Signed-off-by: Stephen Hemminger
> ---
> lib/librte_eal/linux/eal/eal_interrupts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c
> b/lib/librte_eal/linux/eal/eal_interrupts.c
> index 1955324d3045..2cd537ba4492 100644
> --- a/lib/librte_eal/linux/eal/eal_interrupts.c
> +++ b/lib/librte_eal/linux/eal/eal_interrupts.c
> @@ -1045,7 +1045,7 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
> static __attribute__((noreturn)) void *
> eal_intr_thread_main(__rte_unused void *arg)
> {
> - struct epoll_event ev;
> + struct epoll_event ev = { };
>
> /* host thread, never break out */
> for (;;) {
typedef union epoll_data
{
void *ptr;
int fd;
uint32_t u32;
uint64_t u64;
} epoll_data_t;
struct epoll_event
{
uint32_t events; /* Epoll events */
epoll_data_t data;/* User data variable */
} __EPOLL_PACKED;
static __attribute__((noreturn)) void *
eal_intr_thread_main(__rte_unused void *arg)
{
struct epoll_event ev;
[...]
ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP;
ev.data.fd = src->intr_handle.fd;
[...]
if (epoll_ctl(pfd, EPOLL_CTL_ADD,
src->intr_handle.fd, &ev) < 0){
So the uninitialised part is because we only set an int in the union.
False positive from valgrind, but the fix is quite simple.
Acked-by: David Marchand
--
David Marchand
[dpdk-dev] [PATCH] doc: introduce openwrt how-to guide
This doc describes how to enable DPDK on openwrt in both virtual and physical x86 environment. Signed-off-by: Xiaolong Ye --- doc/guides/howto/index.rst | 1 + doc/guides/howto/openwrt.rst | 180 +++ 2 files changed, 181 insertions(+) create mode 100644 doc/guides/howto/openwrt.rst diff --git a/doc/guides/howto/index.rst b/doc/guides/howto/index.rst index a4c131652..5a97ea508 100644 --- a/doc/guides/howto/index.rst +++ b/doc/guides/howto/index.rst @@ -19,3 +19,4 @@ HowTo Guides packet_capture_framework telemetry debug_troubleshoot +openwrt diff --git a/doc/guides/howto/openwrt.rst b/doc/guides/howto/openwrt.rst new file mode 100644 index 0..62be3a031 --- /dev/null +++ b/doc/guides/howto/openwrt.rst @@ -0,0 +1,180 @@ +.. SPDX-License-Identifier: BSD-3-Clause +Copyright(c) 2019 Intel Corporation. + +Enable DPDK on openwrt +== + +This document describes how to enable Data Plane Development Kit(DPDK) on +Openwrt in both virtual and physical x86 environment. + +Introduction + + +The OpenWrt project is a Linux operating system targeting embedded devices. +Instead of trying to create a single, static firmware, OpenWrt provides a fully +writable filesystem with package management. This frees user from the +application selection and configuration provided by the vendor and allows user +to customize the device through the use of packages to suit any application. For +developers, OpenWrt is the framework to build and application without having to +build a complete firmware around it, for users this means the ability for full +customization, to use the device in ways never envisioned. + +Pre-requisites +~~ + +You need gcc, binutils, bzip2, flex, python3.5+, perl, make, find, grep, diff, +unzip, gawk, getopt, subversion, libz-dev and libc headers installed. + +Build OpenWrt +- + +You can obtain OpenWrt image through https://downloads.openwrt.org/releases. To +fully customize your own OpenWrt, it is highly recommended to build it through +the source code, you can clone the OpenWrt source code by: + +.. code-block:: console + + git clone https://git.openwrt.org/openwrt/openwrt.git + +OpenWrt configuration +~ + +* Select ``x86`` in ``Target System`` +* Select ``x86_64`` in ``Subtarget`` +* Select ``Build the OpenWrt SDK`` for cross-compilation environment +* Select ``Use glibc`` in ``Advanced configuration options (for developers)`` + -> ``ToolChain Options`` + -> ``C Library implementation`` + +Kernel configuration + + +Below configurations need to be enabled: + +* CONFIG_UIO=y +* CONFIG_HUGETLBFS=y +* CONFIG_HUGETLB_PAGE=y +* CONFIG_PAGE_MONITOR=y + +Build steps +~~~ + +1. Run ``./scripts/feeds update -a`` to obtain all the latest package definitions +defined in feeds.conf / feeds.conf.default + +2. Run ``./scripts/feeds install -a`` to install symlinks for all obtained +packages into package/feeds/ + +3. Run ``make menuconfig`` to select preferred configuration mentioned above for +the toolchain, target system & firmware packages. + +3. Run ``make kernel_menuconfig`` to select preferred kernel configurations. + +4. Run ``make`` to build your firmware. This will download all sources, build +the cross-compile toolchain and then cross-compile the Linux kernel & all +chosen applications for your target system. + +After build is done, you can find the images and sdk in ``/bin/targets/x86/64-glibc/``. + +DPDK Cross Compilation for OpenWrt +-- + +Pre-requisites +~~ + +NUMA is required to run dpdk in x86. + +.. note:: + + For compiling the NUMA lib, run libtool --version to ensure the libtool version >= 2.2, + otherwise the compilation will fail with errors. + +.. code-block:: console + + git clone https://github.com/numactl/numactl.git + cd numactl + git checkout v2.0.13 -b v2.0.13 + ./autogen.sh + autoconf -i + export PATH=/glibc/openwrt-sdk-x86-64_gcc-8.3.0_glibc.Linux-x86_64/staging_dir/toolchain-x86_64_gcc-8.3.0_glibc/bin/:$PATH + ./configure CC=x86_64-openwrt-linux-gnu-gcc --prefix= + make install + +The numa header files and lib file is generated in the include and lib folder respectively under . + +Build DPDK +~~ + +.. code-block:: console + + export STAGING_DIR=/glibc/openwrt-sdk-x86-64_gcc-8.3.0_glibc.Linux-x86_64/staging_dir + export RTE_SDK=`pwd` + export RTE_KERNELDIR=/build_dir/target-x86_64_glibc/linux-x86_64/linux-4.19.81/ + make config T=x86_64-native-linuxapp-gcc + make -j 100 CROSS=x86_64-openwrt-linux-gnu- + +Running DPDK application on OpenWrt +--- + +Virtual machine +~~~ + +* Extract boot image + +.. code-block:: console + + gzip -d openwrt-x86-64-combined-ext4.img.gz + +* Launch Qemu + +..
Re: [dpdk-dev] [PATCH] doc: introduce openwrt how-to guide
On Fri, Nov 29, 2019 at 04:19:11PM +0800, Xiaolong Ye wrote: > This doc describes how to enable DPDK on openwrt in both virtual and > physical x86 environment. > > Signed-off-by: Xiaolong Ye > --- At this point, I don't think it's a good idea to be adding more instructions for building DPDK using make - it will only make the future switchover to using meson harder. Can you update the doc to describe the process using meson for the DPDK build. /Bruce
Re: [dpdk-dev] [PATCH] cryptodev: add chacha20-poly1305 aead algorithm
Hi Akhil,
doc question below
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Friday, November 29, 2019 6:58 AM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal,
> ArkadiuszX
>
> Subject: [PATCH] cryptodev: add chacha20-poly1305 aead algorithm
>
> This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev.
>
> Signed-off-by: Arek Kusztal
> ---
> doc/guides/cryptodevs/features/default.ini | 13 +++--
> doc/guides/rel_notes/release_19_11.rst | 4
> lib/librte_cryptodev/rte_crypto_sym.h | 9 +
> 3 files changed, 20 insertions(+), 6 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/features/default.ini
> b/doc/guides/cryptodevs/features/default.ini
> index b7f9a0a..2a3ff48 100644
> --- a/doc/guides/cryptodevs/features/default.ini
> +++ b/doc/guides/cryptodevs/features/default.ini
> @@ -93,12 +93,13 @@ SHA3_512 HMAC =
> ; Supported AEAD algorithms of a default crypto driver.
> ;
> [AEAD]
> -AES GCM (128) =
> -AES GCM (192) =
> -AES GCM (256) =
> -AES CCM (128) =
> -AES CCM (192) =
> -AES CCM (256) =
> +AES GCM (128) =
> +AES GCM (192) =
> +AES GCM (256) =
> +AES CCM (128) =
> +AES CCM (192) =
> +AES CCM (256) =
> +CHACHA20-POLY1305 =
> ;
> ; Supported Asymmetric algorithms of a default crypto driver.
> ;
> diff --git a/doc/guides/rel_notes/release_19_11.rst
> b/doc/guides/rel_notes/release_19_11.rst
> index 48c80e5..d07a396 100644
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -315,6 +315,10 @@ New Features
> "--iova-mode=pa" option can be used, IOVA_DC bus iommu scheme can also
> result in IOVA as PA.
>
> +* **Added Chacha20-Poly1305 algorithm to Cryptodev API.**
> +
> + Chacha20-Poly1305 AEAD algorithm can now be supported in Cryptodev.
> +
[Fiona] This is targeting 20.02 but there's no release note file available yet,
so temporarily putting in the 19.11 file.
In future can we get the release note file created earlier in the cycle? Maybe
after the rc2 of previous release?
This would enable earlier pushing of patches and avoid respins
>
> Removed Items
> -
> diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
> b/lib/librte_cryptodev/rte_crypto_sym.h
> index ffa038d..bc356f6 100644
> --- a/lib/librte_cryptodev/rte_crypto_sym.h
> +++ b/lib/librte_cryptodev/rte_crypto_sym.h
> @@ -348,6 +348,8 @@ enum rte_crypto_aead_algorithm {
> /**< AES algorithm in CCM mode. */
> RTE_CRYPTO_AEAD_AES_GCM,
> /**< AES algorithm in GCM mode. */
> + RTE_CRYPTO_AEAD_CHACHA20_POLY1305,
> + /**< Chacha20 cipher with poly1305 authenticator */
> RTE_CRYPTO_AEAD_LIST_END
> };
>
> @@ -391,6 +393,11 @@ struct rte_crypto_aead_xform {
>* be allocated, even though the length field will
>* have a value less than this.
>*
> + * - For Chacha20-Poly1305 it is 96-bit nonce.
> + * PMD sets initial counter for Poly1305 key generation
> + * part to 0 and for Chacha20 encryption to 1 as per
> + * rfc8439 2.8. AEAD construction.
> + *
>* For optimum performance, the data pointed to SHOULD
>* be 8-byte aligned.
>*/
> @@ -407,6 +414,8 @@ struct rte_crypto_aead_xform {
>*
>* - For CCM mode, this is the length of the nonce,
>* which can be in the range 7 to 13 inclusive.
> + *
> + * - For Chacha20-Poly1305 this field is always 12.
>*/
> } iv; /**< Initialisation vector parameters */
>
> --
> 2.1.0
[Fiona] Apart from doc comment above
Acked-by:
Re: [dpdk-dev] [RFC PATCH] mark experimental variables
On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote:
> On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote:
> > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote:
> > > So far, we did not pay attention to direct access to variables but they
> > > are part of the API/ABI too and should be clearly identified.
> > >
> > > Introduce a __rte_experimental_var tag and mark existing variables.
> > >
> > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API
> > > exports")
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: David Marchand
> > > ---
> > > Quick patch to try to catch experimental variables.
> > > Not sure if we could use a single section, so please advise if there is
> > > better to do about this.
> > >
> > I don't see any definition of __rte_experimental_var here, won't the
> > preprocessor choke on this when you try to compile without that?
>
> Sorry, not getting your point.
> If there is an issue, then it is the same as __rte_experimental.
>
No, there is no issue, I'm just blind. For some reason cscope wasn't finding
the definition of __rte_experimental_var when I applied your patch for me. Its
clear you have it below.
Acked-by: Neil Horman
> [snip]
>
> > > diff --git a/lib/librte_eal/common/include/rte_compat.h
> > > b/lib/librte_eal/common/include/rte_compat.h
> > > index 3eb33784b..3fd05179f 100644
> > > --- a/lib/librte_eal/common/include/rte_compat.h
> > > +++ b/lib/librte_eal/common/include/rte_compat.h
> > > @@ -11,11 +11,16 @@
> > > #define __rte_experimental \
> > > __attribute__((deprecated("Symbol is not yet part of stable ABI"), \
> > > section(".text.experimental")))
> > > +#define __rte_experimental_var \
> > > +__attribute__((deprecated("Symbol is not yet part of stable ABI"), \
> > > +section(".data.experimental")))
> > >
> > > #else
> > >
> > > #define __rte_experimental \
> > > __attribute__((section(".text.experimental")))
> > > +#define __rte_experimental_var \
> > > +__attribute__((section(".data.experimental")))
> > >
> > > #endif
> > >
>
>
> --
> David Marchand
>
>
Re: [dpdk-dev] Admin Queue ENA
Hi Michał,
Thanks for getting back on this.
In our design we are using multiple cores requesting for rte_eth_stats_get,
it is not from one process and hence not serialized. Since in our design
this is not serialized, and hence in get_comp_ctxt() checking for occupied
flag and comp_ctxt_release() are not done atomically which is causing this
issue. Please let me know if my understanding is correct, so that I will
fix the application in such a way that it is done from one process and not
multiple.
Thanks,
Param.
On Thu, Nov 28, 2019 at 6:44 PM Michał Krawczyk wrote:
> Hi Param,
>
> first of all - you are using very old ena_com. This code comes from
> the DPDK version before v18.08. If you have any doubts, please check
> the newer version of the driver and DPDK as the potential bug could be
> already fixed there.
>
> Anyway, if you will look at the function get_comp_ctxt() which is
> called by __ena_com_submit_admin_cmd() to get the completion context,
> there is a check for the context if it's not occupied - in case it is
> (which will be true until comp_ctxt_release() will clear it), the new
> command using the same context cannot be used. So there shouldn't be
> two consumers using the same completion contexts.
>
> In addition, drivers that are using ena_com are sending admin commands
> one at a time during the init, so there shouldn't be even 2 commands
> at a time. The only exception is ena_com_get_dev_basic_stats(), which
> is called from rte_eth_stats_get() context - but if you consider DPDK
> application, it should use it on the management lcore after init, so
> it'll also be serialized.
>
> Thanks,
> Michal
>
>
>
> pt., 8 lis 2019 o 07:02 kumaraparameshwaran rathinavel
> napisał(a):
> >
> > Hi Michał,
> >
> > Please look at the below function,
> >
> > static int
> > ena_com_wait_and_process_admin_cq_polling(
> > struct ena_comp_ctx *comp_ctx,
> > struct ena_com_admin_queue *admin_queue)
> > {
> > unsigned long flags = 0;
> > u64 start_time;
> > int ret;
> >
> > start_time = ENA_GET_SYSTEM_USECS();
> >
> > while (comp_ctx->status == ENA_CMD_SUBMITTED) {
> > if ((ENA_GET_SYSTEM_USECS() - start_time) >
> > ADMIN_CMD_TIMEOUT_US) {
> > ena_trc_err("Wait for completion (polling) timeout\n");
> > /* ENA didn't have any completion */
> > ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);
> > admin_queue->stats.no_completion++;
> > admin_queue->running_state = false;
> > ENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);
> >
> > ret = ENA_COM_TIMER_EXPIRED;
> > goto err;
> > }
> >
> > ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);
> > ena_com_handle_admin_completion(admin_queue);
> > ENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);
> > }
> >
> > if (unlikely(comp_ctx->status == ENA_CMD_ABORTED)) {
> > ena_trc_err("Command was aborted\n");
> > ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);
> > admin_queue->stats.aborted_cmd++;
> > ENA_SPINLOCK_UNLOCK(admin_queue->q_lock, flags);
> > ret = ENA_COM_NO_DEVICE;
> > goto err;
> > }
> >
> > ENA_ASSERT(comp_ctx->status == ENA_CMD_COMPLETED,
> >"Invalid comp status %d\n", comp_ctx->status);
> >
> > ret = ena_com_comp_status_to_errno(comp_ctx->comp_status);
> > err:
> > comp_ctxt_release(admin_queue, comp_ctx);
> > return ret;
> > }
> >
> > This is a case where there are two threads executing admin commands.
> >
> > The occupied flag is set to false in the function comp_ctxt_release.
> Let us say there are two consumers of completion context and C1 has a
> completion context and the same completion context can be used by another
> consumer C2 even before the C1 is resetting the occupied flag.
> >
> > This is because the ena_com_handle_admin_completion is done under spin
> lock and comp_ctxt_release is not under this spin lock.
> >
> > Thanks,
> > Param
> >
> > On Thu, Oct 24, 2019 at 2:09 PM Michał Krawczyk wrote:
> >>
> >> sob., 19 paź 2019 o 20:26 kumaraparameshwaran rathinavel
> >> napisał(a):
> >> >
> >> > Hi All,
> >> >
> >> > In the ENA poll mode driver I see that every request in the admin
> queue is
> >> > associated with a completion context and this is preallocated during
> the
> >> > device initialisation. When the completion context is used we check
> for
> >> > occupied to be true in the 16.X version if the occupied flag is set
> to true
> >> > we assert and in the latest version I see that this is an error log.
> But
> >> > there is a time window where if the completion context would be
> available
> >> > to the other consumer but still the old consumer did not set the
> occupied
> >> > to false. The new consumer holds the admin queue lock to get the
> completion
> >> > context but the update by the old consumer to set the the occupied
> flag is
> >> > not done under lock. So should we
Re: [dpdk-dev] [RFC PATCH] mark experimental variables
On Fri, Nov 29, 2019 at 12:43 PM Neil Horman wrote:
>
> On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote:
> > On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote:
> > > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote:
> > > > So far, we did not pay attention to direct access to variables but they
> > > > are part of the API/ABI too and should be clearly identified.
> > > >
> > > > Introduce a __rte_experimental_var tag and mark existing variables.
> > > >
> > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API
> > > > exports")
> > > > Cc: sta...@dpdk.org
> > > >
> > > > Signed-off-by: David Marchand
> > > > ---
> > > > Quick patch to try to catch experimental variables.
> > > > Not sure if we could use a single section, so please advise if there is
> > > > better to do about this.
> > > >
> > > I don't see any definition of __rte_experimental_var here, won't the
> > > preprocessor choke on this when you try to compile without that?
> >
> > Sorry, not getting your point.
> > If there is an issue, then it is the same as __rte_experimental.
> >
> No, there is no issue, I'm just blind. For some reason cscope wasn't finding
> the definition of __rte_experimental_var when I applied your patch for me.
> Its
> clear you have it below.
Ok, thanks for confirming.
> Acked-by: Neil Horman
I will do an extra pass and submit a non RFC patch with your ack if I
have no change.
Thanks Neil.
--
David Marchand
Re: [dpdk-dev] [RFC 0/6] Add ABI compatibility checks to the meson build
Hello Kevin, On Wed, Oct 23, 2019 at 11:26 AM Kevin Laatz wrote: > > With the recent changes made to stabilize ABI versioning in DPDK, it will > become increasingly important to check patches for ABI compatibility. We > propose adding the ABI compatibility checking to be done as part of the > build. > > The advantages to adding the ABI compatibility checking to the build are > two-fold. Firstly, developers can easily check their patches to make sure > they don’t break the ABI without adding any extra steps. Secondly, it > makes the integration into existing CI seamless since there are no extra > scripts to make the CI run. The build will run as usual and if an > incompatibility is detected in the ABI, the build will fail and show the > incompatibility. As an added bonus, enabling the ABI compatibility checks > does not impact the build speed. > > The proposed solution works as follows: > 1. Generate the ABI dump of the baseline. This can be done with the new >script added in this RFC. This step will only need to be done when the >ABI version changes (so once a year) and can be added to master so it >exists by default. This step can be skipped if the dump files for the >baseline already exist. > 2. Build with meson. If there is an ABI incompatibility, the build will >fail and print the incompatibility information. > > The patches accompanying this RFC add the ABI dump file generating script, > the meson option required to enable/disable the checks, and the required > meson changes to run the compatibility checks during the build. Could you rebase this series on master? Thanks. -- David Marchand
Re: [dpdk-dev] [PATCH] config: update Marvell ARMADA
On Fri, Nov 29, 2019 at 3:55 PM wrote: > > From: Liron Himi > > disable more NXP modules that conflict with MUSDK # Please share more details on the conflict. # What about meson build? "make" will be deprecated soon. # This scheme won't work for distro build, Please spend the effort to analyze the conflict and fix the conflict. IMO, That would be the correct solution. > > Signed-off-by: Liron Himi > --- > config/defconfig_arm64-armada-linuxapp-gcc | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/config/defconfig_arm64-armada-linuxapp-gcc > b/config/defconfig_arm64-armada-linuxapp-gcc > index 059180284..c09751cf0 100644 > --- a/config/defconfig_arm64-armada-linuxapp-gcc > +++ b/config/defconfig_arm64-armada-linuxapp-gcc > @@ -19,6 +19,23 @@ CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y > > # Disable NXP as it is conflict with MUSDK > CONFIG_RTE_LIBRTE_DPAA_BUS=n > +CONFIG_RTE_LIBRTE_COMMON_DPAAX=n > +CONFIG_RTE_LIBRTE_FSLMC_BUS=n > +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n > +CONFIG_RTE_LIBRTE_DPAA2_PMD=n > +CONFIG_RTE_LIBRTE_DPAA_BUS=n > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n > +CONFIG_RTE_LIBRTE_DPAA_PMD=n > +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=n > +CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n > +CONFIG_RTE_LIBRTE_PFE_PMD=n > +CONFIG_RTE_LIBRTE_ENETC_PMD=n > + > > # Doesn't support NUMA > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n > -- > 2.23.0 >
[dpdk-dev] [PATCH v4] add drop statistic for af_packet
Signed-off-by: Vadim Podovinnikov
---
drivers/net/af_packet/rte_eth_af_packet.c | 33 +--
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c
b/drivers/net/af_packet/rte_eth_af_packet.c
index eee0fbce2..2aa7c0fcc 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -52,6 +52,7 @@ struct pkt_rx_queue {
volatile unsigned long rx_pkts;
volatile unsigned long rx_bytes;
+ volatile unsigned long rx_drop;
};
struct pkt_tx_queue {
@@ -322,6 +323,25 @@ eth_dev_info(struct rte_eth_dev *dev, struct
rte_eth_dev_info *dev_info)
return 0;
}
+static void
+fill_eth_drop_stats(struct rte_eth_dev *dev)
+{
+ unsigned int i, imax;
+ struct pmd_internals *internal = dev->data->dev_private;
+ socklen_t sock_len = sizeof(struct tpacket_stats);
+ struct tpacket_stats st;
+
+ imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
+ internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
+ for (i = 0; i < imax; i++) {
+ memset(&st, 0, sock_len);
+ int rc = getsockopt(internal->rx_queue[i].sockfd, SOL_PACKET,
+ PACKET_STATISTICS, &st, &sock_len);
+ if (rc == 0)
+ internal->rx_queue[i].rx_drop += st.tp_drops;
+ }
+}
+
static int
eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
{
@@ -329,22 +349,18 @@ eth_stats_get(struct rte_eth_dev *dev, struct
rte_eth_stats *igb_stats)
unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
unsigned long rx_bytes_total = 0, tx_bytes_total = 0, rx_drop = 0;
const struct pmd_internals *internal = dev->data->dev_private;
- socklen_t sock_len = sizeof(struct tpacket_stats);
- struct tpacket_stats st;
+
+ fill_eth_drop_stats(dev);
imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
for (i = 0; i < imax; i++) {
igb_stats->q_ipackets[i] = internal->rx_queue[i].rx_pkts;
igb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;
+ igb_stats->q_errors[i] = internal->rx_queue[i].rx_drop;
rx_total += igb_stats->q_ipackets[i];
rx_bytes_total += igb_stats->q_ibytes[i];
-
- memset(&st, 0, sock_len);
- int rc = getsockopt(internal->rx_queue[i].sockfd, SOL_PACKET,
- PACKET_STATISTICS, &st, &sock_len);
- if (rc == 0)
- rx_drop += st.tp_drops;
+ rx_drop += igb_stats->q_errors[i];
}
imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
@@ -375,6 +391,7 @@ eth_stats_reset(struct rte_eth_dev *dev)
for (i = 0; i < internal->nb_queues; i++) {
internal->rx_queue[i].rx_pkts = 0;
internal->rx_queue[i].rx_bytes = 0;
+ internal->rx_queue[i].rx_drop = 0;
}
for (i = 0; i < internal->nb_queues; i++) {
--
2.24.0
Re: [dpdk-dev] [PATCH] doc: introduce openwrt how-to guide
On 11/29, Bruce Richardson wrote: >On Fri, Nov 29, 2019 at 04:19:11PM +0800, Xiaolong Ye wrote: >> This doc describes how to enable DPDK on openwrt in both virtual and >> physical x86 environment. >> >> Signed-off-by: Xiaolong Ye >> --- > >At this point, I don't think it's a good idea to be adding more >instructions for building DPDK using make - it will only make the future >switchover to using meson harder. Can you update the doc to describe the >process using meson for the DPDK build. Good point, I'll try the meson build and update the doc accordingly. Thanks, Xiaolong > >/Bruce
Re: [dpdk-dev] [PATCH] doc: introduce openwrt how-to guide
On Fri, 29 Nov 2019 16:19:11 +0800 Xiaolong Ye wrote: > This doc describes how to enable DPDK on openwrt in both virtual and > physical x86 environment. > > Signed-off-by: Xiaolong Ye > --- > doc/guides/howto/index.rst | 1 + > doc/guides/howto/openwrt.rst | 180 +++ > 2 files changed, 181 insertions(+) > create mode 100644 doc/guides/howto/openwrt.rst > > diff --git a/doc/guides/howto/index.rst b/doc/guides/howto/index.rst > index a4c131652..5a97ea508 100644 > --- a/doc/guides/howto/index.rst > +++ b/doc/guides/howto/index.rst > @@ -19,3 +19,4 @@ HowTo Guides > packet_capture_framework > telemetry > debug_troubleshoot > +openwrt > diff --git a/doc/guides/howto/openwrt.rst b/doc/guides/howto/openwrt.rst > new file mode 100644 > index 0..62be3a031 > --- /dev/null > +++ b/doc/guides/howto/openwrt.rst > @@ -0,0 +1,180 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > +Copyright(c) 2019 Intel Corporation. > + > +Enable DPDK on openwrt > +== > + > +This document describes how to enable Data Plane Development Kit(DPDK) on > +Openwrt in both virtual and physical x86 environment. > + > +Introduction > + > + > +The OpenWrt project is a Linux operating system targeting embedded devices. > +Instead of trying to create a single, static firmware, OpenWrt provides a > fully > +writable filesystem with package management. This frees user from the > +application selection and configuration provided by the vendor and allows > user > +to customize the device through the use of packages to suit any application. > For > +developers, OpenWrt is the framework to build and application without having > to > +build a complete firmware around it, for users this means the ability for > full > +customization, to use the device in ways never envisioned. > + > +Pre-requisites > +~~ > + > +You need gcc, binutils, bzip2, flex, python3.5+, perl, make, find, grep, > diff, > +unzip, gawk, getopt, subversion, libz-dev and libc headers installed. > + > +Build OpenWrt > +- > + > +You can obtain OpenWrt image through https://downloads.openwrt.org/releases. > To > +fully customize your own OpenWrt, it is highly recommended to build it > through > +the source code, you can clone the OpenWrt source code by: > + > +.. code-block:: console > + > + git clone https://git.openwrt.org/openwrt/openwrt.git > + > +OpenWrt configuration > +~ > + > +* Select ``x86`` in ``Target System`` > +* Select ``x86_64`` in ``Subtarget`` > +* Select ``Build the OpenWrt SDK`` for cross-compilation environment > +* Select ``Use glibc`` in ``Advanced configuration options (for developers)`` > +-> ``ToolChain Options`` > +-> ``C Library implementation`` > + > +Kernel configuration > + > + > +Below configurations need to be enabled: > + > +* CONFIG_UIO=y > +* CONFIG_HUGETLBFS=y > +* CONFIG_HUGETLB_PAGE=y > +* CONFIG_PAGE_MONITOR=y > + > +Build steps > +~~~ > + > +1. Run ``./scripts/feeds update -a`` to obtain all the latest package > definitions > +defined in feeds.conf / feeds.conf.default > + > +2. Run ``./scripts/feeds install -a`` to install symlinks for all obtained > +packages into package/feeds/ > + > +3. Run ``make menuconfig`` to select preferred configuration mentioned above > for > +the toolchain, target system & firmware packages. > + > +3. Run ``make kernel_menuconfig`` to select preferred kernel configurations. > + > +4. Run ``make`` to build your firmware. This will download all sources, build > +the cross-compile toolchain and then cross-compile the Linux kernel & all > +chosen applications for your target system. > + > +After build is done, you can find the images and sdk in `` Root>/bin/targets/x86/64-glibc/``. > + > +DPDK Cross Compilation for OpenWrt > +-- > + > +Pre-requisites > +~~ > + > +NUMA is required to run dpdk in x86. > + > +.. note:: > + > + For compiling the NUMA lib, run libtool --version to ensure the libtool > version >= 2.2, > + otherwise the compilation will fail with errors. > + > +.. code-block:: console > + > + git clone https://github.com/numactl/numactl.git > + cd numactl > + git checkout v2.0.13 -b v2.0.13 > + ./autogen.sh > + autoconf -i > + export PATH= sdk>/glibc/openwrt-sdk-x86-64_gcc-8.3.0_glibc.Linux-x86_64/staging_dir/toolchain-x86_64_gcc-8.3.0_glibc/bin/:$PATH > + ./configure CC=x86_64-openwrt-linux-gnu-gcc --prefix= toolchain dir> > + make install > + > +The numa header files and lib file is generated in the include and lib > folder respectively under . > + > +Build DPDK > +~~ > + > +.. code-block:: console > + > + export STAGING_DIR= sdk>/glibc/openwrt-sdk-x86-64_gcc-8.3.0_glibc.Linux-x86_64/staging_dir > + export RTE_SDK=`pwd` > + export RTE_KERNELDIR= Root>/build_dir/target-x86_64_glibc
Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix unitialized data warning
On Fri, 29 Nov 2019 09:25:15 +0100
David Marchand wrote:
> On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger
> wrote:
> >
> > Valgrind reports that eal interrupt thread is calling epoll_ctl
> > with uninitialized data. Trivial to fix by initializing it.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: sta...@dpdk.org
> > Signed-off-by: Stephen Hemminger
> > ---
> > lib/librte_eal/linux/eal/eal_interrupts.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c
> > b/lib/librte_eal/linux/eal/eal_interrupts.c
> > index 1955324d3045..2cd537ba4492 100644
> > --- a/lib/librte_eal/linux/eal/eal_interrupts.c
> > +++ b/lib/librte_eal/linux/eal/eal_interrupts.c
> > @@ -1045,7 +1045,7 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds)
> > static __attribute__((noreturn)) void *
> > eal_intr_thread_main(__rte_unused void *arg)
> > {
> > - struct epoll_event ev;
> > + struct epoll_event ev = { };
> >
> > /* host thread, never break out */
> > for (;;) {
>
> typedef union epoll_data
> {
> void *ptr;
> int fd;
> uint32_t u32;
> uint64_t u64;
> } epoll_data_t;
>
> struct epoll_event
> {
> uint32_t events; /* Epoll events */
> epoll_data_t data;/* User data variable */
> } __EPOLL_PACKED;
>
>
> static __attribute__((noreturn)) void *
> eal_intr_thread_main(__rte_unused void *arg)
> {
> struct epoll_event ev;
> [...]
> ev.events = EPOLLIN | EPOLLPRI | EPOLLRDHUP |
> EPOLLHUP;
> ev.data.fd = src->intr_handle.fd;
> [...]
> if (epoll_ctl(pfd, EPOLL_CTL_ADD,
> src->intr_handle.fd, &ev) < 0){
>
> So the uninitialised part is because we only set an int in the union.
> False positive from valgrind, but the fix is quite simple.
>
> Acked-by: David Marchand
Agreed it is a false positive because the kernel is not going to care about
the unused bits in the union. But I wanted to make the application
run clean under valgrind. Otherwise, it is hard to find the real warnings
in surrounding noise.
[dpdk-dev] [PATCH v2 0/7] Add ABI compatibility checks to the meson build
With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly important to check patches for ABI compatibility. We propose adding the ABI compatibility checking to be done as part of the build. The advantages to adding the ABI compatibility checking to the build are two-fold. Firstly, developers can easily check their patches to make sure they don’t break the ABI without adding any extra steps. Secondly, it makes the integration into existing CI seamless since there are no extra scripts to make the CI run. The build will run as usual and if an incompatibility is detected in the ABI, the build will fail and show the incompatibility. As an added bonus, enabling the ABI compatibility checks does not impact the build speed. The proposed solution works as follows: 1. Generate the ABI dump of the baseline. This can be done with the new script added in this RFC. This step will only need to be done when the ABI version changes (so once a year) and can be added to master so it exists by default. This step can be skipped if the dump files for the baseline already exist. 2. Build with meson. If there is an ABI incompatibility, the build will fail and print the incompatibility information. The patches accompanying this RFC add the ABI dump file generating script, the meson option required to enable/disable the checks, and the required meson changes to run the compatibility checks during the build. --- v2: - Rebased on master for 19.11. - Moved the experimental syms checks next to the abi checks. This also removed the dependency on the experimental checks from the shared build. - General cleanup. Bruce Richardson (2): build: enable debug info by default in meson builds build: use meson warning levels Kevin Laatz (5): devtools: add abi dump generation script build: add meson option for abi related checks build: add lib abi checks to meson build: add drivers abi checks to meson build: clean up experimental syms check buildtools/meson.build | 4 config/meson.build | 40 +--- devtools/gen-abi-dump.sh | 24 drivers/meson.build | 34 -- lib/meson.build | 34 -- meson.build | 9 - meson_options.txt| 2 ++ 7 files changed, 107 insertions(+), 40 deletions(-) create mode 100755 devtools/gen-abi-dump.sh -- 2.17.1
[dpdk-dev] [PATCH v2 1/7] build: enable debug info by default in meson builds
From: Bruce Richardson
We can turn on debug info by default in meson builds, since it has no
performance penalty. This is done by changing the default build type from
"release" to "debugoptimized". Since the latter using O2, we can using
extra cflags to override that back to O3, which will make little real
difference for actual debugging.
For real debug builds, the user can still do "meson --buildtype=debug ..."
and to remove the debug info "meson --buildtype=release ..." can be used.
These are all standard meson options.
The advantage of having debug builds by default using meson settings is
that we can then add checks for ABI compatibility into each build, and
disable them if we detect that the user has turned off the debug info.
Signed-off-by: Bruce Richardson
---
meson.build | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index b7ae9c8d9..3b7a2e7de 100644
--- a/meson.build
+++ b/meson.build
@@ -7,10 +7,16 @@ project('DPDK', 'C',
version: run_command(find_program('cat', 'more'),
files('VERSION')).stdout().strip(),
license: 'BSD',
- default_options: ['buildtype=release', 'default_library=static'],
+ default_options: ['buildtype=debugoptimized',
+ 'default_library=static'],
meson_version: '>= 0.47.1'
)
+# for default "debugoptimized" builds override optimization level 2 with 3
+if get_option('buildtype') == 'debugoptimized'
+ add_project_arguments('-O3', language: 'c')
+endif
+
# set up some global vars for compiler, platform, configuration, etc.
cc = meson.get_compiler('c')
dpdk_conf = configuration_data()
--
2.17.1
[dpdk-dev] [PATCH v2 5/7] build: add lib abi checks to meson
This patch adds the ABI compatibility check for the lib directory to the
meson build. If enabled, the ABI compatibility checks will run for all
.so's in the lib directory (provided a matching dump file exists). The
build will fail if an ABI incompatibility is detected.
Signed-off-by: Kevin Laatz
Signed-off-by: Bruce Richardson
---
v2:
- fixed conditional around abi check custom target
---
buildtools/meson.build | 4
lib/meson.build| 13 +
2 files changed, 17 insertions(+)
diff --git a/buildtools/meson.build b/buildtools/meson.build
index 6ef2c5721..56a1e3dee 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -7,6 +7,10 @@ pmdinfo = find_program('gen-pmdinfo-cfile.sh')
check_experimental_syms = find_program('check-experimental-syms.sh')
+if get_option('abi_compat_checks')
+ abidiff = find_program('abidiff')
+endif
+
# set up map-to-def script using python, either built-in or external
python3 = import('python').find_installation(required: false)
if python3.found()
diff --git a/lib/meson.build b/lib/meson.build
index 6ceb5e756..69ea3a2b0 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -180,6 +180,19 @@ foreach l:libraries
include_directories: includes,
dependencies: shared_deps)
+ if not is_windows and get_option('compat_checks')
+ custom_target(dir_name + '.abi_chk',
+ command: [abidiff,
+ meson.source_root() +
'/lib/abi/'
+ + dir_name + '.dump',
+ '@INPUT@'],
+ input: shared_lib,
+ output: dir_name + '.abi_chk',
+ capture: true,
+ install: false,
+ build_by_default: is_experimental == 0)
+ endif
+
dpdk_libraries = [shared_lib] + dpdk_libraries
dpdk_static_libraries = [static_lib] +
dpdk_static_libraries
endif # sources.length() > 0
--
2.17.1
[dpdk-dev] [PATCH v2 3/7] devtools: add abi dump generation script
This patch adds a script to generate ABI dump files. These files will be
required to perform ABI compatibility checks during the build later in the
patchset. This script should be run on a DPDK version with a stable ABI.
Since this is a tool designed for human use, we simplify it to just work
off a whole build directory, taking the parameter of the builddir and
generating the lib|drivers/abi dir. This is hardcoded into the script since
the meson build expects the .dump files in these directories.
Signed-off-by: Kevin Laatz
Signed-off-by: Bruce Richardson
---
devtools/gen-abi-dump.sh | 24
1 file changed, 24 insertions(+)
create mode 100755 devtools/gen-abi-dump.sh
diff --git a/devtools/gen-abi-dump.sh b/devtools/gen-abi-dump.sh
new file mode 100755
index 0..ffedef10c
--- /dev/null
+++ b/devtools/gen-abi-dump.sh
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+builddir=$1
+
+if [ -z "$builddir" ] ; then
+ echo "Usage: $(basename $0) build_dir"
+ exit 1
+fi
+
+if [ ! -d "$builddir" ] ; then
+ echo "Error: build directory, '$builddir', doesn't exist"
+ exit 1
+fi
+
+for d in lib drivers ; do
+ mkdir -p $d/abi
+
+ for f in $builddir/$d/*.so* ; do
+ test -L "$f" && continue
+
+ libname=$(basename $f)
+ abidw --out-file $d/abi/${libname%.so*}.dump $f || exit 1
+ done
+done
--
2.17.1
[dpdk-dev] [PATCH v2 7/7] build: clean up experimental syms check
This patch cleans up the meson build files in lib and drivers by moving the
custom target for checking the experimental syms next to the abi compat
checks. This also removes the dependency on the check for the shared build,
which was not required by anything, but was only added to force the
experimental syms check run.
Signed-off-by: Kevin Laatz
---
drivers/meson.build | 21 +++--
lib/meson.build | 21 +++--
2 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index e19eed419..9b0955722 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -163,15 +163,6 @@ foreach class:dpdk_driver_classes
'-Wl,/implib:lib\\' + implib]
else
lk_args = ['-Wl,--version-script=' +
version_map]
- # on unix systems check the output of the
- # experimental syms script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.exp_chk',
- command: [check_experimental_syms,
- version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.exp_chk')
endif
shared_lib = shared_library(lib_name,
@@ -181,7 +172,6 @@ foreach class:dpdk_driver_classes
dependencies: shared_deps,
c_args: cflags,
link_args: lk_args,
- link_depends: lk_deps,
version: lib_version,
soversion: so_version,
install: true,
@@ -197,6 +187,17 @@ foreach class:dpdk_driver_classes
dependencies: static_deps)
if not is_windows and get_option('compat_checks')
+ # on unix systems check the output of the
+ # experimental syms script
+ custom_target(lib_name + '.exp_chk',
+ command: [check_experimental_syms,
+ version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.exp_chk',
+ install: false,
+ build_by_default: true)
+
custom_target('lib' + lib_name + '.abi_chk',
command: [abidiff,
meson.source_root() +
'/drivers/abi/lib'
diff --git a/lib/meson.build b/lib/meson.build
index 69ea3a2b0..c448d9dff 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -154,15 +154,6 @@ foreach l:libraries
'-Wl,/implib:lib\\' + implib]
else
lk_args = ['-Wl,--version-script=' +
version_map]
- # on unix systems check the output of the
- # experimental syms script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(name + '.exp_chk',
- command: [check_experimental_syms,
- version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: name + '.exp_chk')
endif
shared_lib = shared_library(libname,
@@ -172,7 +163,6 @@ foreach l:libraries
dependencies: shared_deps,
include_directories: includes,
link_args: lk_args,
- link_depends: lk_deps,
version: lib_version,
soversion: so_version,
install: true)
@@ -181,6 +171,17 @@ foreach l:libraries
dependencies: shared_deps)
if not is_windows and get_option('compat_checks')
+ # on unix systems check the output of the
+ # experimental syms script
+ custom_tar
[dpdk-dev] [PATCH v2 2/7] build: use meson warning levels
From: Bruce Richardson
Rather than trying to manage all the cflags ourselves, we can use meson
warning levels to give the user more control. We remove the Wextra flag and
rely on meson to add it, by bumping up our default warning level.
Signed-off-by: Bruce Richardson
---
config/meson.build | 40 +---
meson.build| 3 ++-
2 files changed, 23 insertions(+), 20 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 364a8d739..36a594970 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -158,31 +158,33 @@ endif
# add -include rte_config to cflags
add_project_arguments('-include', 'rte_config.h', language: 'c')
-# enable extra warnings and disable any unwanted warnings
+# enable extra warnings and disable any unwanted warnings. "-Wall" is added
+# by meson at warning level 1, and "-Wextra" at level 2, so we can omit
+# those. Add extra warnings at level 2 or above. (2 is default level).
warning_flags = [
- # -Wall is added by meson by default, so add -Wextra only
- '-Wextra',
-
- # additional warnings in alphabetical order
- '-Wcast-qual',
- '-Wdeprecated',
- '-Wformat-nonliteral',
- '-Wformat-security',
- '-Wmissing-declarations',
- '-Wmissing-prototypes',
- '-Wnested-externs',
- '-Wold-style-definition',
- '-Wpointer-arith',
- '-Wsign-compare',
- '-Wstrict-prototypes',
- '-Wundef',
- '-Wwrite-strings',
-
# globally disabled warnings
'-Wno-address-of-packed-member',
'-Wno-packed-not-aligned',
'-Wno-missing-field-initializers'
]
+if get_option('warning_level').to_int() >= 2
+ warning_flags += [
+ # additional warnings in alphabetical order
+ '-Wcast-qual',
+ '-Wdeprecated',
+ '-Wformat-nonliteral',
+ '-Wformat-security',
+ '-Wmissing-declarations',
+ '-Wmissing-prototypes',
+ '-Wnested-externs',
+ '-Wold-style-definition',
+ '-Wpointer-arith',
+ '-Wsign-compare',
+ '-Wstrict-prototypes',
+ '-Wundef',
+ '-Wwrite-strings',
+ ]
+endif
if not dpdk_conf.get('RTE_ARCH_64')
# for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's
fine!!
warning_flags += '-Wno-pointer-to-int-cast'
diff --git a/meson.build b/meson.build
index 3b7a2e7de..7a8f97ad6 100644
--- a/meson.build
+++ b/meson.build
@@ -8,7 +8,8 @@ project('DPDK', 'C',
files('VERSION')).stdout().strip(),
license: 'BSD',
default_options: ['buildtype=debugoptimized',
- 'default_library=static'],
+ 'default_library=static',
+ 'warning_level=2'],
meson_version: '>= 0.47.1'
)
--
2.17.1
[dpdk-dev] [PATCH v2 6/7] build: add drivers abi checks to meson
This patch adds the ABI compatibility check for the drivers directory to
the meson build. If enabled, the ABI compatibility checks will run for all
.so's in the lib directory (provided a matching dump file exists). The
build will fail if an ABI incompatibility is detected.
Signed-off-by: Kevin Laatz
---
v2:
- fixed conditional around abi check custom target
---
drivers/meson.build | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/meson.build b/drivers/meson.build
index 72eec4608..e19eed419 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -196,6 +196,19 @@ foreach class:dpdk_driver_classes
include_directories: includes,
dependencies: static_deps)
+ if not is_windows and get_option('compat_checks')
+ custom_target('lib' + lib_name + '.abi_chk',
+ command: [abidiff,
+ meson.source_root() +
'/drivers/abi/lib'
+ + lib_name + '.dump',
+ '@INPUT@'],
+ input: shared_lib,
+ output: 'lib' + lib_name + '.abi_chk',
+ capture: true,
+ install: false,
+ build_by_default: is_experimental == 0)
+ endif
+
dpdk_drivers += static_lib
set_variable('shared_@0@'.format(lib_name), shared_dep)
--
2.17.1
[dpdk-dev] [PATCH v2 4/7] build: add meson option for abi related checks
This patch adds a new meson option for running ABI compatibility checks
during the build. If enabled, the lib and drivers .so files will be
compared against any existing ABI dump files in lib|drivers/abi of the
source directory. If there are any incompatibilities, the build will fail
and display the incompatibility.
Signed-off-by: Kevin Laatz
---
meson_options.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meson_options.txt b/meson_options.txt
index bc369d06c..5f42def1d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,7 @@
# Please keep these options sorted alphabetically.
+option('compat_checks', type: 'boolean', value: true,
+ description: 'enable abi compatibility checks and experimental syms
checks to run during the build')
option('disable_drivers', type: 'string', value: '',
description: 'Comma-separated list of drivers to explicitly disable.')
option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-',
--
2.17.1
[dpdk-dev] SPDX license tag nag
This is the current status of DPDK 19.11 about files with missing or incorrect SPDX tags. This is a polite nag, please either ack the patches, or merge them. If there is no patch please submit one if you are the author. Several patches are outstanding to fix some of these. But others have not been addressed. Pending: https://patchwork.dpdk.org/patch/59769/ lib/librte_ethdev/rte_ethdev_pci.h lib/librte_ethdev/rte_ethdev_vdev.h https://patchwork.dpdk.org/patch/59770/ app/test-pmd/flowgen.c app/test-pmd/macswap.c https://patchwork.dpdk.org/patch/59771/ app/test/test_compressdev_test_buffer.h https://patchwork.dpdk.org/patch/62802/ examples/performance-thread/l3fwd-thread/test.sh Patches needed: app/test/test_timer_racecond.c devtools/cocci.sh devtools/load-devel-config examples/ipsec-secgw/test/trs_aesgcm_inline_crypto_fallback_defs.sh examples/ipsec-secgw/test/tun_aesgcm_inline_crypto_fallback_defs.sh The nagging will continue until all files are fixed.
Re: [dpdk-dev] [EXT] Re: [PATCH] config: update Marvell ARMADA
Regards, Liron -Original Message- From: Jerin Jacob Sent: Friday, 29 November 2019 16:05 To: Liron Himi Cc: Jerin Jacob Kollanukkaran ; dpdk-dev ; dpdk stable Subject: [EXT] Re: [dpdk-dev] [PATCH] config: update Marvell ARMADA External Email -- On Fri, Nov 29, 2019 at 3:55 PM wrote: > > From: Liron Himi > > disable more NXP modules that conflict with MUSDK # Please share more details on the conflict. [L.H.] both components calls of_ APIs so when MUSDK is compiled statically it conflicts with NXP's code. Note that the original armada config already had some NXP flags disabled, but in recent version NXP moved the of_ code to be depends on 'CONFIG_RTE_LIBRTE_COMMON_DPAAX' so needed to update it. # What about meson build? "make" will be deprecated soon. [L.H.] only when compiling the MUSDK as static LIBs, we face this issue. In meson we need to compile MUSDK as shared LIBS. # This scheme won't work for distro build, Please spend the effort to analyze the conflict and fix the conflict. IMO, That would be the correct solution. > > Signed-off-by: Liron Himi > --- > config/defconfig_arm64-armada-linuxapp-gcc | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/config/defconfig_arm64-armada-linuxapp-gcc > b/config/defconfig_arm64-armada-linuxapp-gcc > index 059180284..c09751cf0 100644 > --- a/config/defconfig_arm64-armada-linuxapp-gcc > +++ b/config/defconfig_arm64-armada-linuxapp-gcc > @@ -19,6 +19,23 @@ CONFIG_RTE_LIBRTE_PMD_MVSAM_CRYPTO=y > > # Disable NXP as it is conflict with MUSDK > CONFIG_RTE_LIBRTE_DPAA_BUS=n > +CONFIG_RTE_LIBRTE_COMMON_DPAAX=n > +CONFIG_RTE_LIBRTE_FSLMC_BUS=n > +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n > +CONFIG_RTE_LIBRTE_DPAA2_PMD=n > +CONFIG_RTE_LIBRTE_DPAA_BUS=n > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n > +CONFIG_RTE_LIBRTE_DPAA_PMD=n > +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=n > +CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n > +CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n > +CONFIG_RTE_LIBRTE_PFE_PMD=n > +CONFIG_RTE_LIBRTE_ENETC_PMD=n > + > > # Doesn't support NUMA > CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n > -- > 2.23.0 >
[dpdk-dev] [PATCH v3 1/7] build: enable debug info by default in meson builds
From: Bruce Richardson
We can turn on debug info by default in meson builds, since it has no
performance penalty. This is done by changing the default build type from
"release" to "debugoptimized". Since the latter using O2, we can using
extra cflags to override that back to O3, which will make little real
difference for actual debugging.
For real debug builds, the user can still do "meson --buildtype=debug ..."
and to remove the debug info "meson --buildtype=release ..." can be used.
These are all standard meson options.
The advantage of having debug builds by default using meson settings is
that we can then add checks for ABI compatibility into each build, and
disable them if we detect that the user has turned off the debug info.
Signed-off-by: Bruce Richardson
---
meson.build | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index b7ae9c8d9..3b7a2e7de 100644
--- a/meson.build
+++ b/meson.build
@@ -7,10 +7,16 @@ project('DPDK', 'C',
version: run_command(find_program('cat', 'more'),
files('VERSION')).stdout().strip(),
license: 'BSD',
- default_options: ['buildtype=release', 'default_library=static'],
+ default_options: ['buildtype=debugoptimized',
+ 'default_library=static'],
meson_version: '>= 0.47.1'
)
+# for default "debugoptimized" builds override optimization level 2 with 3
+if get_option('buildtype') == 'debugoptimized'
+ add_project_arguments('-O3', language: 'c')
+endif
+
# set up some global vars for compiler, platform, configuration, etc.
cc = meson.get_compiler('c')
dpdk_conf = configuration_data()
--
2.17.1
[dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson build
With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly important to check patches for ABI compatibility. We propose adding the ABI compatibility checking to be done as part of the build. The advantages to adding the ABI compatibility checking to the build are two-fold. Firstly, developers can easily check their patches to make sure they don’t break the ABI without adding any extra steps. Secondly, it makes the integration into existing CI seamless since there are no extra scripts to make the CI run. The build will run as usual and if an incompatibility is detected in the ABI, the build will fail and show the incompatibility. As an added bonus, enabling the ABI compatibility checks does not impact the build speed. The proposed solution works as follows: 1. Generate the ABI dump of the baseline. This can be done with the new script added in this RFC. This step will only need to be done when the ABI version changes (so once a year) and can be added to master so it exists by default. This step can be skipped if the dump files for the baseline already exist. 2. Build with meson. If there is an ABI incompatibility, the build will fail and print the incompatibility information. The patches accompanying this RFC add the ABI dump file generating script, the meson option required to enable/disable the checks, and the required meson changes to run the compatibility checks during the build. --- v2: - Rebased on master for 19.11. - Moved the experimental syms checks next to the abi checks. This also removed the dependency on the experimental checks from the shared build. - General cleanup. v3: - Fixed typo in meson option name in buildtools/meson.build. Bruce Richardson (2): build: enable debug info by default in meson builds build: use meson warning levels Kevin Laatz (5): devtools: add abi dump generation script build: add meson option for abi related checks build: add lib abi checks to meson build: add drivers abi checks to meson build: clean up experimental syms check buildtools/meson.build | 4 config/meson.build | 40 +--- devtools/gen-abi-dump.sh | 24 drivers/meson.build | 34 -- lib/meson.build | 34 -- meson.build | 9 - meson_options.txt| 2 ++ 7 files changed, 107 insertions(+), 40 deletions(-) create mode 100755 devtools/gen-abi-dump.sh -- 2.17.1
[dpdk-dev] [PATCH v3 2/7] build: use meson warning levels
From: Bruce Richardson
Rather than trying to manage all the cflags ourselves, we can use meson
warning levels to give the user more control. We remove the Wextra flag and
rely on meson to add it, by bumping up our default warning level.
Signed-off-by: Bruce Richardson
---
config/meson.build | 40 +---
meson.build| 3 ++-
2 files changed, 23 insertions(+), 20 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 364a8d739..36a594970 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -158,31 +158,33 @@ endif
# add -include rte_config to cflags
add_project_arguments('-include', 'rte_config.h', language: 'c')
-# enable extra warnings and disable any unwanted warnings
+# enable extra warnings and disable any unwanted warnings. "-Wall" is added
+# by meson at warning level 1, and "-Wextra" at level 2, so we can omit
+# those. Add extra warnings at level 2 or above. (2 is default level).
warning_flags = [
- # -Wall is added by meson by default, so add -Wextra only
- '-Wextra',
-
- # additional warnings in alphabetical order
- '-Wcast-qual',
- '-Wdeprecated',
- '-Wformat-nonliteral',
- '-Wformat-security',
- '-Wmissing-declarations',
- '-Wmissing-prototypes',
- '-Wnested-externs',
- '-Wold-style-definition',
- '-Wpointer-arith',
- '-Wsign-compare',
- '-Wstrict-prototypes',
- '-Wundef',
- '-Wwrite-strings',
-
# globally disabled warnings
'-Wno-address-of-packed-member',
'-Wno-packed-not-aligned',
'-Wno-missing-field-initializers'
]
+if get_option('warning_level').to_int() >= 2
+ warning_flags += [
+ # additional warnings in alphabetical order
+ '-Wcast-qual',
+ '-Wdeprecated',
+ '-Wformat-nonliteral',
+ '-Wformat-security',
+ '-Wmissing-declarations',
+ '-Wmissing-prototypes',
+ '-Wnested-externs',
+ '-Wold-style-definition',
+ '-Wpointer-arith',
+ '-Wsign-compare',
+ '-Wstrict-prototypes',
+ '-Wundef',
+ '-Wwrite-strings',
+ ]
+endif
if not dpdk_conf.get('RTE_ARCH_64')
# for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's
fine!!
warning_flags += '-Wno-pointer-to-int-cast'
diff --git a/meson.build b/meson.build
index 3b7a2e7de..7a8f97ad6 100644
--- a/meson.build
+++ b/meson.build
@@ -8,7 +8,8 @@ project('DPDK', 'C',
files('VERSION')).stdout().strip(),
license: 'BSD',
default_options: ['buildtype=debugoptimized',
- 'default_library=static'],
+ 'default_library=static',
+ 'warning_level=2'],
meson_version: '>= 0.47.1'
)
--
2.17.1
[dpdk-dev] [PATCH v3 3/7] devtools: add abi dump generation script
This patch adds a script to generate ABI dump files. These files will be
required to perform ABI compatibility checks during the build later in the
patchset. This script should be run on a DPDK version with a stable ABI.
Since this is a tool designed for human use, we simplify it to just work
off a whole build directory, taking the parameter of the builddir and
generating the lib|drivers/abi dir. This is hardcoded into the script since
the meson build expects the .dump files in these directories.
Signed-off-by: Kevin Laatz
Signed-off-by: Bruce Richardson
---
devtools/gen-abi-dump.sh | 24
1 file changed, 24 insertions(+)
create mode 100755 devtools/gen-abi-dump.sh
diff --git a/devtools/gen-abi-dump.sh b/devtools/gen-abi-dump.sh
new file mode 100755
index 0..ffedef10c
--- /dev/null
+++ b/devtools/gen-abi-dump.sh
@@ -0,0 +1,24 @@
+#!/bin/sh
+
+builddir=$1
+
+if [ -z "$builddir" ] ; then
+ echo "Usage: $(basename $0) build_dir"
+ exit 1
+fi
+
+if [ ! -d "$builddir" ] ; then
+ echo "Error: build directory, '$builddir', doesn't exist"
+ exit 1
+fi
+
+for d in lib drivers ; do
+ mkdir -p $d/abi
+
+ for f in $builddir/$d/*.so* ; do
+ test -L "$f" && continue
+
+ libname=$(basename $f)
+ abidw --out-file $d/abi/${libname%.so*}.dump $f || exit 1
+ done
+done
--
2.17.1
[dpdk-dev] [PATCH v3 7/7] build: clean up experimental syms check
This patch cleans up the meson build files in lib and drivers by moving the
custom target for checking the experimental syms next to the abi compat
checks. This also removes the dependency on the check for the shared build,
which was not required by anything, but was only added to force the
experimental syms check run.
Signed-off-by: Kevin Laatz
---
drivers/meson.build | 21 +++--
lib/meson.build | 21 +++--
2 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index e19eed419..9b0955722 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -163,15 +163,6 @@ foreach class:dpdk_driver_classes
'-Wl,/implib:lib\\' + implib]
else
lk_args = ['-Wl,--version-script=' +
version_map]
- # on unix systems check the output of the
- # experimental syms script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(lib_name + '.exp_chk',
- command: [check_experimental_syms,
- version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: lib_name + '.exp_chk')
endif
shared_lib = shared_library(lib_name,
@@ -181,7 +172,6 @@ foreach class:dpdk_driver_classes
dependencies: shared_deps,
c_args: cflags,
link_args: lk_args,
- link_depends: lk_deps,
version: lib_version,
soversion: so_version,
install: true,
@@ -197,6 +187,17 @@ foreach class:dpdk_driver_classes
dependencies: static_deps)
if not is_windows and get_option('compat_checks')
+ # on unix systems check the output of the
+ # experimental syms script
+ custom_target(lib_name + '.exp_chk',
+ command: [check_experimental_syms,
+ version_map, '@INPUT@'],
+ capture: true,
+ input: static_lib,
+ output: lib_name + '.exp_chk',
+ install: false,
+ build_by_default: true)
+
custom_target('lib' + lib_name + '.abi_chk',
command: [abidiff,
meson.source_root() +
'/drivers/abi/lib'
diff --git a/lib/meson.build b/lib/meson.build
index 69ea3a2b0..c448d9dff 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -154,15 +154,6 @@ foreach l:libraries
'-Wl,/implib:lib\\' + implib]
else
lk_args = ['-Wl,--version-script=' +
version_map]
- # on unix systems check the output of the
- # experimental syms script, using it as a
- # dependency of the .so build
- lk_deps += custom_target(name + '.exp_chk',
- command: [check_experimental_syms,
- version_map, '@INPUT@'],
- capture: true,
- input: static_lib,
- output: name + '.exp_chk')
endif
shared_lib = shared_library(libname,
@@ -172,7 +163,6 @@ foreach l:libraries
dependencies: shared_deps,
include_directories: includes,
link_args: lk_args,
- link_depends: lk_deps,
version: lib_version,
soversion: so_version,
install: true)
@@ -181,6 +171,17 @@ foreach l:libraries
dependencies: shared_deps)
if not is_windows and get_option('compat_checks')
+ # on unix systems check the output of the
+ # experimental syms script
+ custom_tar
[dpdk-dev] [PATCH v3 4/7] build: add meson option for abi related checks
This patch adds a new meson option for running ABI compatibility checks
during the build. If enabled, the lib and drivers .so files will be
compared against any existing ABI dump files in lib|drivers/abi of the
source directory. If there are any incompatibilities, the build will fail
and display the incompatibility.
Signed-off-by: Kevin Laatz
---
meson_options.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meson_options.txt b/meson_options.txt
index bc369d06c..5f42def1d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,5 +1,7 @@
# Please keep these options sorted alphabetically.
+option('compat_checks', type: 'boolean', value: true,
+ description: 'enable abi compatibility checks and experimental syms
checks to run during the build')
option('disable_drivers', type: 'string', value: '',
description: 'Comma-separated list of drivers to explicitly disable.')
option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-',
--
2.17.1
[dpdk-dev] [PATCH v3 6/7] build: add drivers abi checks to meson
This patch adds the ABI compatibility check for the drivers directory to
the meson build. If enabled, the ABI compatibility checks will run for all
.so's in the lib directory (provided a matching dump file exists). The
build will fail if an ABI incompatibility is detected.
Signed-off-by: Kevin Laatz
---
v2:
- fixed conditional around abi check custom target
---
drivers/meson.build | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/meson.build b/drivers/meson.build
index 72eec4608..e19eed419 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -196,6 +196,19 @@ foreach class:dpdk_driver_classes
include_directories: includes,
dependencies: static_deps)
+ if not is_windows and get_option('compat_checks')
+ custom_target('lib' + lib_name + '.abi_chk',
+ command: [abidiff,
+ meson.source_root() +
'/drivers/abi/lib'
+ + lib_name + '.dump',
+ '@INPUT@'],
+ input: shared_lib,
+ output: 'lib' + lib_name + '.abi_chk',
+ capture: true,
+ install: false,
+ build_by_default: is_experimental == 0)
+ endif
+
dpdk_drivers += static_lib
set_variable('shared_@0@'.format(lib_name), shared_dep)
--
2.17.1
[dpdk-dev] [PATCH v3 5/7] build: add lib abi checks to meson
This patch adds the ABI compatibility check for the lib directory to the
meson build. If enabled, the ABI compatibility checks will run for all
.so's in the lib directory (provided a matching dump file exists). The
build will fail if an ABI incompatibility is detected.
Signed-off-by: Kevin Laatz
Signed-off-by: Bruce Richardson
---
v2:
- fixed conditional around abi check custom target
v3:
- fix typo in meson option name
---
buildtools/meson.build | 4
lib/meson.build| 13 +
2 files changed, 17 insertions(+)
diff --git a/buildtools/meson.build b/buildtools/meson.build
index 6ef2c5721..1d6915708 100644
--- a/buildtools/meson.build
+++ b/buildtools/meson.build
@@ -7,6 +7,10 @@ pmdinfo = find_program('gen-pmdinfo-cfile.sh')
check_experimental_syms = find_program('check-experimental-syms.sh')
+if get_option('compat_checks')
+ abidiff = find_program('abidiff')
+endif
+
# set up map-to-def script using python, either built-in or external
python3 = import('python').find_installation(required: false)
if python3.found()
diff --git a/lib/meson.build b/lib/meson.build
index 6ceb5e756..69ea3a2b0 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -180,6 +180,19 @@ foreach l:libraries
include_directories: includes,
dependencies: shared_deps)
+ if not is_windows and get_option('compat_checks')
+ custom_target(dir_name + '.abi_chk',
+ command: [abidiff,
+ meson.source_root() +
'/lib/abi/'
+ + dir_name + '.dump',
+ '@INPUT@'],
+ input: shared_lib,
+ output: dir_name + '.abi_chk',
+ capture: true,
+ install: false,
+ build_by_default: is_experimental == 0)
+ endif
+
dpdk_libraries = [shared_lib] + dpdk_libraries
dpdk_static_libraries = [static_lib] +
dpdk_static_libraries
endif # sources.length() > 0
--
2.17.1
Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen
> On Nov 19, 2019, at 11:42 AM, Roberts, Lee A. wrote: > > Nirmal, > > Here are the changes that I've been using to allow jumbo frames with > dpdk-19.08 and > pktgen-19.10.0: > > diff -r default/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h > jumbo/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h > 462c462 > < #define RTE_MBUF_DEFAULT_DATAROOM 2048 > --- >> #define RTE_MBUF_DEFAULT_DATAROOM 9600 > diff -r default/dpdk-19.08/lib/librte_net/rte_ether.h > jumbo/dpdk-19.08/lib/librte_net/rte_ether.h > 33c33 > < #define RTE_ETHER_MAX_LEN 1518 /**< Maximum frame len, including CRC. */ > --- >> #define RTE_ETHER_MAX_LEN 9600 /**< Maximum frame len, including CRC. */ > diff -r default/pktgen-19.10.0/app/pktgen.c jumbo/pktgen-19.10.0/app/pktgen.c > 749c749 > < else if ( (plen >= 1024) && (plen <= PG_ETHER_MAX_LEN)) > --- >> else if ( (plen >= 1024) && (plen <= 1518)) > 753c753 > < else if (plen > PG_ETHER_MAX_LEN) > --- >> else if (plen > 1518) > diff -r default/pktgen-19.10.0/lib/common/pg_inet.h > jumbo/pktgen-19.10.0/lib/common/pg_inet.h > 379,380c379,380 > < #define ETH_MTU 1500/* Max MTU for Ethernet */ > < #define ETH_MAX_PKT 1518/* Max Ethernet frame size */ > --- >> #define ETH_MTU 9600 /* Max MTU for Ethernet */ >> #define ETH_MAX_PKT 9600 /* Max Ethernet frame size */ > > - Lee Roberts I have a updated pktgen with jumbo support. You need to pass the -j option to get jumbo frame support in pktgen. I have not done a lot of testing on this version. If you have time please pull the pktgen repo and switch over to the ‘dev’ branch and see if this work for you. I did not use your changes here and did it my way :-) I did not change DPDK, as it seemed like it did not matter if RTE_MBUF_DEFAULT_DATAROOM changed. I am sure someplace may care if they used that define. > > > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nirmal Sarkar > Sent: Monday, November 18, 2019 10:26 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen > > Hello, > > I'm trying to explore pktgen and dpdk-pktgen with Jumbo frame. > > I'm using ubuntu-18.04 system where pktgen is a kernel module and I don't > have any provision to set it for Jumbo frame. > Can you please suggest how to configure Jumbo frame in pktgen ? > > In dpdk source code, I've modified RTE_MBUF_DEFAULT_DATAROOM [ > *lib/librte_mbuf/rte_mbuf.h*] value with 9K and built. > During testing, I could not send packet size more than 1500 byte. > What is the suggestion to overcome this problem ? > > Regards, > N. Sarkar Regards, Keith
Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing
> On Nov 19, 2019, at 6:47 PM, Frank Li wrote: > > Current IPv6 functionality in pktgen is broken. This fix makes it so that > IPv6 addresses are properly set when using the set, sequence, and save > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses > are properly set. > > To preserve the runtime commands, the `_atoip` function no longer takes > in flags to specify converting IPv4/6 addresses, and will try both, > returning, 4, 6, or -1 for a valid IPv4/6, invalid address, respectively. > > Also print IPv6 addresses in UI properly. > > Co-authored-by Valentin Andrei > > Signed-off-by: Frank Li > --- I applied this patch and if you have time do a pull on the pktgen repo and switch over to the ‘dev’ branch and see if this version works for you. Regards, Keith
