Re: [dpdk-dev] [PATCH 14/14] test: skip tests when missing requirements

2019-06-08 Thread David Marchand 
(pruning a little bit of the CC: list...)

On Fri, Jun 7, 2019 at 10:55 PM Honnappa Nagarahalli <
honnappa.nagaraha...@arm.com> wrote:

> >
> > Let's mark as skipped the tests when they are missing some requirements
> like a
> > number of used cores or specific hardware availability, like compress,
> crypto or
> > eventdev devices.
> >
> > Signed-off-by: David Marchand 
> > ---
> >  app/test/test.c | 24 
> >  app/test/test_compressdev.c |  4 ++--
> >  app/test/test_cryptodev.c   |  4 ++--
> >  app/test/test_distributor.c |  4 ++--
> >  app/test/test_distributor_perf.c|  4 ++--
> >  app/test/test_event_timer_adapter.c |  5 +++--
> >  app/test/test_eventdev.c|  2 ++
> >  app/test/test_func_reentrancy.c |  6 +++---
> >  app/test/test_hash_multiwriter.c|  7 +++
> >  app/test/test_hash_readwrite.c  |  7 +++
> >  app/test/test_hash_readwrite_lf.c   |  8 
> >  app/test/test_ipsec.c   |  4 ++--
> >  app/test/test_mbuf.c| 13 ++---
> >  app/test/test_rcu_qsbr.c| 10 +-
> >  app/test/test_rcu_qsbr_perf.c   |  9 +
> >  app/test/test_service_cores.c   | 14 ++
> >  app/test/test_stack.c   |  8 +---
> >  app/test/test_timer.c   | 10 +-
> >  app/test/test_timer_secondary.c | 10 ++
> >  19 files changed, 90 insertions(+), 63 deletions(-)
> >
>
> 
>
> >
> >   RTE_LCORE_FOREACH_SLAVE(core_id) {
> > diff --git a/app/test/test_hash_readwrite_lf.c
> > b/app/test/test_hash_readwrite_lf.c
> > index 5644361..2664f51 100644
> > --- a/app/test/test_hash_readwrite_lf.c
> > +++ b/app/test/test_hash_readwrite_lf.c
> > @@ -1254,10 +1254,10 @@ struct {
> >   int htm;
> >   int use_jhash = 0;
> >   int ext_bkt = 0;
> > - if (rte_lcore_count() == 1) {
> > - printf("More than one lcore is required "
> > - "to do read write lock-free concurrency test\n");
> > - return -1;
> > +
> > + if (rte_lcore_count() < 2) {
> > + printf("Not enough cores for hash_readwrite_lf_autotest,
> > expecting at least 2\n");
> > + return TEST_SKIPPED;
> >   }
> Looks good
>
> > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index
> > 92ab0c2..725d27d 100644
> > --- a/app/test/test_rcu_qsbr.c
> > +++ b/app/test/test_rcu_qsbr.c
> > @@ -949,14 +949,14 @@
> >  static int
> >  test_rcu_qsbr_main(void)
> >  {
> > + if (rte_lcore_count() < 5) {
> Should be '4'. 4 cores are enough for the test.
>

Well, if we make it 4, then there was an issue before.
num_cores < 4 means 'at least 4 slave cores', so with the master core, we
are at 5.

See:
static inline int
get_enabled_cores_mask(void)
{
uint16_t core_id;
uint32_t max_cores = rte_lcore_count();

if (max_cores > TEST_RCU_MAX_LCORE) {
printf("Number of cores exceed %d\n", TEST_RCU_MAX_LCORE);
return -1;
}

core_id = 0;
num_cores = 0;
RTE_LCORE_FOREACH_SLAVE(core_id) {
enabled_core_ids[num_cores] = core_id;
num_cores++;
}

return 0;
}



> > + printf("Not enough cores for rcu_qsbr_autotest, expecting
> at
> > least 5\n");
> > + return TEST_SKIPPED;
> > + }
> > +
> >   if (get_enabled_cores_mask() != 0)
> >   return -1;
> >
> > - if (num_cores < 4) {
> > - printf("Test failed! Need 4 or more cores\n");
> > - goto test_fail;
> > - }
> There is another check in 'get_enabled_cores_mask' function. We should
> convert that as well. Suggest pulling the check in 'get_enabled_cores_mask'
> to 'test_rcu_qsbr_main'
>

Already said it before, can't we just shoot this enabled_core_ids[] array?
Is there a real need to enumerate per core rank?



> > -
> >   /* Error-checking test cases */
> >   if (test_rcu_qsbr_get_memsize() < 0)
> >   goto test_fail;
> > diff --git a/app/test/test_rcu_qsbr_perf.c
> b/app/test/test_rcu_qsbr_perf.c
> > index 6b1912c..dcdd9da 100644
> > --- a/app/test/test_rcu_qsbr_perf.c
> > +++ b/app/test/test_rcu_qsbr_perf.c
> > @@ -623,6 +623,11 @@
> >  static int
> >  test_rcu_qsbr_main(void)
> >  {
> > + if (rte_lcore_count() < 3) {
> Should be 2. Minimum 2 cores are required.
>

Idem num_cores < 2.
Was the check incorrect before?



> > + printf("Not enough cores for rcu_qsbr_perf_autotest,
> > expecting at least 3\n");
> > + return TEST_SKIPPED;
> > + }
> > +
> >   rte_atomic64_init(&updates);
> >   rte_atomic64_init(&update_cycles);
> >   rte_atomic64_init(&checks);
> > @@ -632,10 +637,6 @@
> >   return -1;
> >
> >   printf("Number of cores provided = %d\n", num_cores);
> > - if (num_cores < 2) {
> > - printf("Test failed! Need 2 or more cores\n");
> > -

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-08 Thread Jerin Jacob Kollanukkaran 
> -Original Message-
> From: dev  On Behalf Of Honnappa Nagarahalli
> Sent: Friday, June 7, 2019 7:24 PM
> To: Aaron Conole 
> Cc: msant...@redhat.com; tho...@monjalon.net; Ruifeng Wang (Arm
> Technology China) ; Gavin Hu (Arm Technology
> China) ; Dharmik Thakkar ;
> jerin.ja...@caviumnetworks.com; ys...@mellanox.com; dev@dpdk.org;
> bruce.richard...@intel.com; Honnappa Nagarahalli
> ; nd ; nd 
> Subject: Re: [dpdk-dev] DPDK compilation on arm is failing in Travis
> 
> > >> >
> > >> >  Thomas Monjalon  writes:
> > >> >
> > >> >
> > >> >
> > >> >  The compilation of the master branch is failing for aarch64:
> > >> >
> > >> >  https://travis-ci.com/DPDK/dpdk
> > >> >
> > >> > The log is so much verbose that I am not able to understand what
> > >> >
> > >> > is really wrong.
> > >> >
> > >> > Please help to diagnose and fix, thanks.
> > >> >
> > >> >
> > >> >
> > >> > A discussion about this:
> > >> >
> > >> >
> > >> >
> > >> > http://mails.dpdk.org/archives/dev/2019-June/134012.html
> > >> >
> > >> >
> > >> >
> > >> > I see the error now.
> > >> >
> > >> > It is printing the full log after the error, so I missed the
> > >> > error
> > >> >
> > >> > at the top.
> > >> >
> > >> >
> > >> >
> > >> > I've read your comment about a possible error with the patch
> > >> >
> > >> > removing weak functions but neither me nor Bruce were able to
> > >> > reproduce
> > >> >
> > >> > it.
> > >> >
> > >> >  What is the condition to see this compiler warning?
> > >> >
> > >> >
> > >> >
> > >> > It is only on ARM, and only when the neon intrinsics are in use.
> > >> >
> > >> > I am not able to reproduce it from the tip of master.
> > >> >
> > >> >
> > >> >
> > >> > I am using:
> > >> >
> > >> > gcc (Ubuntu 8.3.0-6ubuntu1~18.04) 8.3.0
> > >> >
> > >> >
> > >> >
> > >> > From the log on Travis, looks like the compiler is:
> > >> >
> > >> > gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
> > >> >
> > >> >
> > >> >
> > >> > Is this the issue?
> > >> >
> > >> >
> > >> >
> > >> > Why are we seeing the error now?
> > >> >
> > >> > I tested with gcc-5 (Ubuntu/Linaro 5.5.0-12ubuntu1) 5.5.0
> > >> > 20171010, it
> > >> works fine. I cannot get hold of 5.4.0. Not sure if needs to be 
> > >> supported.
> > >> >
> > >> > Are there any issues in upgrading to 7 or 8?
> > >> >
> > >> > I have tested it on my ubuntu 16.04 vm on commit
> > >> > 8cb511bb94ad92a76990f175cac76bb13d51daba
> > >> > (head of master seems to be failing for other reasons on my vm).
> > >> > I tested the following gcc versions:
> > >> >
> > >> > gcc 5.5.0 "cc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010"
> > >> > gcc 7.4.0 "cc (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0"
> > >> > gcc 8.1.0 "cc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0"
> > >> >
> > >> > All tested versions failed on the exact same error shown in travis.
> > >> > I don't know if the compiler is at fault here. Maybe Aaron's
> > >> > patch is a viable
> > >> option?
> > >> >
> > >> >  The issue is the vector lane setting code looks like:
> > >> >
> > >> >
> > >> >
> > >> >lval = lane_set(scalar, rval, lane id)
> > >> >
> > >> >
> > >> >
> > >> > In this case, 'rval' is being used before it is ever set, but it
> > >> >
> > >> > really could be just 0 for the first lane setting code.
> > >> > Thereafter,
> > >> >
> > >> > we use the old value of input as the rval, but each time a
> > >> > different lane is
> > >> set.
> > >> >
> > >> >
> > >> >
> > >> > It would be nice if there were an intrinsic that formatted
> > >> > correctly
> > >> >
> > >> > from the start (something we could call like lval =
> > >> >
> > >> > lane_set_from_array(scalar_array)).
> > >> >
> > >> > [Honnappa] This exists already. ‘vdupq_n_s32’ can be used. Can
> > >> > you try the
> > >> following?
> > >>
> > >> Well, it isn't exactly that.  You are setting all lanes from a scalar.
> > > Yes, you are correct, it sets all the lanes. I am not sure on how
> > > this will affect the performance.
> > >
> > >> I'd rather be able to say:
> > >>
> > >>input0 = vdupq_nn_s32(&parms[0]);
> > >>input1 = vdupq_nn_s32(&parms[4]);
> > >>
> > >> Something like that, which lets us delete all the rest of the
> > >> lane-set code.  But it seems it doesn't exist.
> > >>
> > >> Regardless, I think either patch should work (either using the 'all 
> > >> lanes'
> > >> setting you have or the static variable).  I have no preference on
> > >> it
> > >> - it's up to you (or someone else) to say which is preferred.  I
> > >> guess your version could be preferable since there's no static to
> > >> need to "explain" :)
> > > I think we can go ahead with your patch with using a temporary
> > > vector for the first set, as it does not introduce any change to the
> > > code and hence performance should not get affected.
> > >
> > > But, I do not understand why you have added 'static'. Also, changing
> > > 'ZEROVAL' to 'tmp' or something similar will be better.
> >
> > The static is there to guarantee '0' value.  Otherwise we create a
> > temp variabl

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-08 Thread Jerin Jacob Kollanukkaran 
> -Original Message-
> From: Jerin Jacob Kollanukkaran 
> Sent: Saturday, June 8, 2019 2:08 PM
> To: Honnappa Nagarahalli ; Aaron Conole
> 
> Cc: msant...@redhat.com; tho...@monjalon.net; Ruifeng Wang (Arm
> Technology China) ; Gavin Hu (Arm Technology
> China) ; Dharmik Thakkar ;
> jerin.ja...@caviumnetworks.com; ys...@mellanox.com; dev@dpdk.org;
> bruce.richard...@intel.com; nd ; nd 
> Subject: RE: DPDK compilation on arm is failing in Travis
> 
> > -Original Message-
> > From: dev  On Behalf Of Honnappa Nagarahalli
> > Sent: Friday, June 7, 2019 7:24 PM
> > To: Aaron Conole 
> > Cc: msant...@redhat.com; tho...@monjalon.net; Ruifeng Wang (Arm
> > Technology China) ; Gavin Hu (Arm Technology
> > China) ; Dharmik Thakkar
> ;
> > jerin.ja...@caviumnetworks.com; ys...@mellanox.com; dev@dpdk.org;
> > bruce.richard...@intel.com; Honnappa Nagarahalli
> > ; nd ; nd 
> > Subject: Re: [dpdk-dev] DPDK compilation on arm is failing in Travis
> >
> > > >> >
> > > >> >  Thomas Monjalon  writes:
> > > >> >
> > > >> >
> > > >> >
> > > >> >  The compilation of the master branch is failing for aarch64:
> > > >> >
> > > >> >  https://travis-ci.com/DPDK/dpdk
> > > >> >
> > > >> > The log is so much verbose that I am not able to understand
> > > >> > what
> > > >> >
> > > >> > is really wrong.
> > > >> >
> > > >> > Please help to diagnose and fix, thanks.
> > > >> >
> > > >> >
> > > >> >
> > > >> > A discussion about this:
> > > >> >
> > > >> >
> > > >> >
> > > >> > http://mails.dpdk.org/archives/dev/2019-June/134012.html
> > > >> >
> > > >> >
> > > >> >
> > > >> > I see the error now.
> > > >> >
> > > >> > It is printing the full log after the error, so I missed the
> > > >> > error
> > > >> >
> > > >> > at the top.
> > > >> >
> > > >> >
> > > >> >
> > > >> > I've read your comment about a possible error with the patch
> > > >> >
> > > >> > removing weak functions but neither me nor Bruce were able to
> > > >> > reproduce
> > > >> >
> > > >> > it.
> > > >> >
> > > >> >  What is the condition to see this compiler warning?
> > > >> >
> > > >> >
> > > >> >
> > > >> > It is only on ARM, and only when the neon intrinsics are in use.
> > > >> >
> > > >> > I am not able to reproduce it from the tip of master.
> > > >> >
> > > >> >
> > > >> >
> > > >> > I am using:
> > > >> >
> > > >> > gcc (Ubuntu 8.3.0-6ubuntu1~18.04) 8.3.0
> > > >> >
> > > >> >
> > > >> >
> > > >> > From the log on Travis, looks like the compiler is:
> > > >> >
> > > >> > gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609
> > > >> >
> > > >> >
> > > >> >
> > > >> > Is this the issue?
> > > >> >
> > > >> >
> > > >> >
> > > >> > Why are we seeing the error now?
> > > >> >
> > > >> > I tested with gcc-5 (Ubuntu/Linaro 5.5.0-12ubuntu1) 5.5.0
> > > >> > 20171010, it
> > > >> works fine. I cannot get hold of 5.4.0. Not sure if needs to be 
> > > >> supported.
> > > >> >
> > > >> > Are there any issues in upgrading to 7 or 8?
> > > >> >
> > > >> > I have tested it on my ubuntu 16.04 vm on commit
> > > >> > 8cb511bb94ad92a76990f175cac76bb13d51daba
> > > >> > (head of master seems to be failing for other reasons on my vm).
> > > >> > I tested the following gcc versions:
> > > >> >
> > > >> > gcc 5.5.0 "cc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010"
> > > >> > gcc 7.4.0 "cc (Ubuntu 7.4.0-1ubuntu1~16.04~ppa1) 7.4.0"
> > > >> > gcc 8.1.0 "cc (Ubuntu 8.1.0-5ubuntu1~16.04) 8.1.0"
> > > >> >
> > > >> > All tested versions failed on the exact same error shown in travis.
> > > >> > I don't know if the compiler is at fault here. Maybe Aaron's
> > > >> > patch is a viable
> > > >> option?
> > > >> >
> > > >> >  The issue is the vector lane setting code looks like:
> > > >> >
> > > >> >
> > > >> >
> > > >> >lval = lane_set(scalar, rval, lane id)
> > > >> >
> > > >> >
> > > >> >
> > > >> > In this case, 'rval' is being used before it is ever set, but
> > > >> > it
> > > >> >
> > > >> > really could be just 0 for the first lane setting code.
> > > >> > Thereafter,
> > > >> >
> > > >> > we use the old value of input as the rval, but each time a
> > > >> > different lane is
> > > >> set.
> > > >> >
> > > >> >
> > > >> >
> > > >> > It would be nice if there were an intrinsic that formatted
> > > >> > correctly
> > > >> >
> > > >> > from the start (something we could call like lval =
> > > >> >
> > > >> > lane_set_from_array(scalar_array)).
> > > >> >
> > > >> > [Honnappa] This exists already. ‘vdupq_n_s32’ can be used. Can
> > > >> > you try the
> > > >> following?
> > > >>
> > > >> Well, it isn't exactly that.  You are setting all lanes from a scalar.
> > > > Yes, you are correct, it sets all the lanes. I am not sure on how
> > > > this will affect the performance.
> > > >
> > > >> I'd rather be able to say:
> > > >>
> > > >>input0 = vdupq_nn_s32(&parms[0]);
> > > >>input1 = vdupq_nn_s32(&parms[4]);
> > > >>
> > > >> Something like that, which lets us delete all the rest of the
> > > >> lane-set code.  But it seems it doesn't exist.
> > > >>
> > > >> Reg

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-08 Thread Ananyev, Konstantin 

> > >
> > > When including the rte_ether.h header in applications with warnings
> > > enabled, a warning was given because of the assumption of 2-byte alignment
> > > of ethernet addresses when processing them.
> > >
> > > .../include/rte_ether.h:149:2: warning: converting a packed ‘const
> > >   struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’
> > >   {aka ‘const short unsigned int’} pointer (alignment 2) may result in
> > >   an unaligned pointer value [-Waddress-of-packed-member]
> > > 149 |  const unaligned_uint16_t *ea_words = (const unaligned_uint16_t 
> > > *)ea;
> > > |  ^
> > >
> > > Since ethernet addresses should always be aligned on a two-byte boundary,
> > > we can just inform the compiler of this assumption to remove the warnings
> > > and allow us to always access the addresses using 16-bit operations.
> > >
> > > Signed-off-by: Bruce Richardson 
> > > Signed-off-by: Stephen Hemminger 
> > > Reviewed-by: Andrew Rybchenko 
> > > ---
> > >  lib/librte_net/rte_ether.h | 11 ++-
> > >  1 file changed, 6 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> > > index feb35a33c94b..d7b76ddf63eb 100644
> > > --- a/lib/librte_net/rte_ether.h
> > > +++ b/lib/librte_net/rte_ether.h
> > > @@ -58,7 +58,8 @@ extern "C" {
> > >   * See http://standards.ieee.org/regauth/groupmac/tutorial.html
> > >   */
> > >  struct rte_ether_addr {
> > > - uint8_t addr_bytes[RTE_ETHER_ADDR_LEN]; /**< Addr bytes in tx order */
> > > + uint8_t addr_bytes[RTE_ETHER_ADDR_LEN] __rte_aligned(2);
> > > + /**< Addr bytes in tx order */
> > >  } __attribute__((__packed__));
> >
> > Hmm, that would change layout of any struct/union that has struct 
> > rte_ether_addr inside.
> > So seems like implicit ABI breakage to me.
> > Konstantin
> 
> There was no rte_ether_addr in previous releases.

I suppose you refer to the fact that struct ether_addr was renamed to 
rte_ether_addr by:
https://git.dpdk.org/dpdk/commit/?id=6d13ea8e8e49ab957deae2bba5ecf4a4bfe747d1 
As I understand, Olivier patches in that rework introduce API change only,  
keeping ABI unchanged.
While your patch makes ABI breakage possible.
Konstantin

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-08 Thread Ananyev, Konstantin 

> > > -Original Message-
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> > > Sent: Wednesday, June 5, 2019 7:10 PM
> > > To: dev@dpdk.org
> > > Cc: Richardson, Bruce ; Stephen Hemminger
> > > ; Andrew Rybchenko
> > > 
> > > Subject: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses
> > > as being 2-byte aligned
> > >
> > > From: Bruce Richardson 
> > >
> > > When including the rte_ether.h header in applications with warnings
> > > enabled, a warning was given because of the assumption of 2-byte
> > > alignment of ethernet addresses when processing them.
> > >
> > > .../include/rte_ether.h:149:2: warning: converting a packed ‘const
> > >   struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’
> > >   {aka ‘const short unsigned int’} pointer (alignment 2) may result in
> > >   an unaligned pointer value [-Waddress-of-packed-member]
> > > 149 |  const unaligned_uint16_t *ea_words = (const unaligned_uint16_t
> > *)ea;
> > > |  ^
> > >
> > > Since ethernet addresses should always be aligned on a two-byte
> > > boundary, we can just inform the compiler of this assumption to remove
> > > the warnings and allow us to always access the addresses using 16-bit
> > operations.
> > >
> > > Signed-off-by: Bruce Richardson 
> > > Signed-off-by: Stephen Hemminger 
> > > Reviewed-by: Andrew Rybchenko 
> > > ---
> > >  lib/librte_net/rte_ether.h | 11 ++-
> > >  1 file changed, 6 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
> > > index feb35a33c94b..d7b76ddf63eb 100644
> > > --- a/lib/librte_net/rte_ether.h
> > > +++ b/lib/librte_net/rte_ether.h
> > > @@ -58,7 +58,8 @@ extern "C" {
> > >   * See http://standards.ieee.org/regauth/groupmac/tutorial.html
> > >   */
> > >  struct rte_ether_addr {
> > > - uint8_t addr_bytes[RTE_ETHER_ADDR_LEN]; /**< Addr bytes in tx order
> > */
> > > + uint8_t addr_bytes[RTE_ETHER_ADDR_LEN] __rte_aligned(2);
> > > + /**< Addr bytes in tx order */
> > >  } __attribute__((__packed__));
> >
> > Hmm, that would change layout of any struct/union that has struct
> > rte_ether_addr inside.
> > So seems like implicit ABI breakage to me.
> > Konstantin
> >
> 
> I suppose it could, though only if you had the structure starting at an odd 
> byte
> inside the larger structure.

Yes.

>  Personally, I'd think it should be ok in just about
> all cases, as I'd find it hard to imagine when you wouldn't have this, but
> technically I suppose it's a break.

I also don't expect it to be a common case, but it is not totally impossible.
So I still think it qualifies as ABI change and we need to follow our own ABI
breakage policy here. 

> For real packet heads the fields will always be
> two-byte aligned so there is no issue.
>

[dpdk-dev] [PATCH 0/6] bnxt patch series

2019-06-08 Thread Ajit Khaparde 
This is a patchset against dpdk-next-net tree on top of
commit d800226ab9ede99ab9bc56a69168e6e587f1.
Please apply.


Kalesh AP (1):
  net/bnxt: fix output of port xstats

Naresh Kumar PBS (2):
  net/bnxt: fix interrupt vector array initialization
  net/bnxt: address build errors reported by intel compiler

Somnath Kotur (3):
  net/bnxt: add code to redirect tunnel packets
  net/bnxt: fix to check for NULL completion ring doorbell in
int_handler
  net/bnxt: driver to use configured MTU value during load

 drivers/net/bnxt/bnxt.h|   1 +
 drivers/net/bnxt/bnxt_cpr.c|   2 +-
 drivers/net/bnxt/bnxt_ethdev.c |  28 ++--
 drivers/net/bnxt/bnxt_filter.h |   5 +-
 drivers/net/bnxt/bnxt_flow.c   | 236 -
 drivers/net/bnxt/bnxt_hwrm.c   |  88 +++-
 drivers/net/bnxt/bnxt_hwrm.h   |   7 +-
 drivers/net/bnxt/bnxt_irq.c|   2 +-
 drivers/net/bnxt/bnxt_stats.c  |   2 +
 9 files changed, 321 insertions(+), 50 deletions(-)

-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH 3/6] net/bnxt: driver to use configured MTU value during load

2019-06-08 Thread Ajit Khaparde 
From: Somnath Kotur 

The MTU value of a port can be (re)configured out-of-band.
FW will be returning this configured MTU as part of func_qcfg cmd.
Driver to use this value during load time.

Signed-off-by: Somnath Kotur 
Signed-off-by: Kalesh AP 
Reviewed-by: Lance Richardson 
Signed-off-by: Ajit Khaparde 
---
 drivers/net/bnxt/bnxt_cpr.c| 2 +-
 drivers/net/bnxt/bnxt_ethdev.c | 7 ++-
 drivers/net/bnxt/bnxt_hwrm.c   | 5 -
 drivers/net/bnxt/bnxt_hwrm.h   | 2 +-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index 0fd6e51e5..655bcf1a8 100644
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/drivers/net/bnxt/bnxt_cpr.c
@@ -35,7 +35,7 @@ void bnxt_handle_async_event(struct bnxt *bp,
break;
case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_VF_CFG_CHANGE:
PMD_DRV_LOG(INFO, "Async event: VF config changed\n");
-   bnxt_hwrm_func_qcfg(bp);
+   bnxt_hwrm_func_qcfg(bp, NULL);
break;
case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PORT_CONN_NOT_ALLOWED:
PMD_DRV_LOG(INFO, "Port conn async event\n");
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ee775b125..e527df1bf 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3654,6 +3654,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
uint32_t total_alloc_len;
rte_iova_t mz_phys_addr;
struct bnxt *bp;
+   uint16_t mtu;
int rc;
 
if (version_printed++ == 0)
@@ -3906,12 +3907,16 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
pci_dev->mem_resource[0].phys_addr,
pci_dev->mem_resource[0].addr);
 
-   rc = bnxt_hwrm_func_qcfg(bp);
+   rc = bnxt_hwrm_func_qcfg(bp, &mtu);
if (rc) {
PMD_DRV_LOG(ERR, "hwrm func qcfg failed\n");
goto error_free;
}
 
+   if (mtu >= ETHER_MIN_MTU && mtu <= BNXT_MAX_MTU &&
+   mtu != eth_dev->data->mtu)
+   eth_dev->data->mtu = mtu;
+
if (BNXT_PF(bp)) {
//if (bp->pf.active_vfs) {
// TODO: Deallocate VF resources?
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 09fee3d39..696974c83 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -2638,7 +2638,7 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool 
link_up)
 }
 
 /* JIRA 22088 */
-int bnxt_hwrm_func_qcfg(struct bnxt *bp)
+int bnxt_hwrm_func_qcfg(struct bnxt *bp, uint16_t *mtu)
 {
struct hwrm_func_qcfg_input req = {0};
struct hwrm_func_qcfg_output *resp = bp->hwrm_cmd_resp_addr;
@@ -2663,6 +2663,9 @@ int bnxt_hwrm_func_qcfg(struct bnxt *bp)
PMD_DRV_LOG(INFO, "Trusted VF cap enabled\n");
}
 
+   if (mtu)
+   *mtu = resp->mtu;
+
switch (resp->port_partition_type) {
case HWRM_FUNC_QCFG_OUTPUT_PORT_PARTITION_TYPE_NPAR1_0:
case HWRM_FUNC_QCFG_OUTPUT_PORT_PARTITION_TYPE_NPAR1_5:
diff --git a/drivers/net/bnxt/bnxt_hwrm.h b/drivers/net/bnxt/bnxt_hwrm.h
index cd8bb79f9..e35462cb4 100644
--- a/drivers/net/bnxt/bnxt_hwrm.h
+++ b/drivers/net/bnxt/bnxt_hwrm.h
@@ -127,7 +127,7 @@ void bnxt_free_hwrm_rx_ring(struct bnxt *bp, int 
queue_index);
 int bnxt_alloc_hwrm_resources(struct bnxt *bp);
 int bnxt_get_hwrm_link_config(struct bnxt *bp, struct rte_eth_link *link);
 int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up);
-int bnxt_hwrm_func_qcfg(struct bnxt *bp);
+int bnxt_hwrm_func_qcfg(struct bnxt *bp, uint16_t *mtu);
 int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp);
 int bnxt_hwrm_func_reserve_vf_resc(struct bnxt *bp, bool test);
 int bnxt_hwrm_allocate_pf_only(struct bnxt *bp);
-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH 1/6] net/bnxt: add code to redirect tunnel packets

2019-06-08 Thread Ajit Khaparde 
From: Somnath Kotur 

Add code to redirect GRE, NVGRE and VXLAN tunnel packets
to the specified VF.

Signed-off-by: Somnath Kotur 
Signed-off-by: Kalesh AP 
Reviewed-by: Lance Richardson 
Signed-off-by: Ajit Khaparde 
---
 drivers/net/bnxt/bnxt.h|   1 +
 drivers/net/bnxt/bnxt_filter.h |   5 +-
 drivers/net/bnxt/bnxt_flow.c   | 236 -
 drivers/net/bnxt/bnxt_hwrm.c   |  83 
 drivers/net/bnxt/bnxt_hwrm.h   |   5 +
 5 files changed, 295 insertions(+), 35 deletions(-)

diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h
index 641790fef..942da7ff0 100644
--- a/drivers/net/bnxt/bnxt.h
+++ b/drivers/net/bnxt/bnxt.h
@@ -430,6 +430,7 @@ struct bnxt {
uint16_tmax_l2_ctx;
uint16_tmax_vnics;
uint16_tmax_stat_ctx;
+   uint16_tfirst_vf_id;
uint16_tvlan;
struct bnxt_pf_info pf;
uint8_t port_partition_type;
diff --git a/drivers/net/bnxt/bnxt_filter.h b/drivers/net/bnxt/bnxt_filter.h
index f8bad29de..4fda3f03a 100644
--- a/drivers/net/bnxt/bnxt_filter.h
+++ b/drivers/net/bnxt/bnxt_filter.h
@@ -19,7 +19,8 @@ struct bnxt_filter_info {
 #define HWRM_CFA_L2_FILTER 0
 #define HWRM_CFA_EM_FILTER 1
 #define HWRM_CFA_NTUPLE_FILTER 2
-   uint8_t filter_type;//L2 or EM or NTUPLE filter
+#define HWRM_CFA_TUNNEL_REDIRECT_FILTER3
+   uint8_t filter_type;
uint32_tdst_id;
 
/* Filter Characteristics */
@@ -120,6 +121,8 @@ struct bnxt_filter_info *bnxt_get_l2_filter(struct bnxt *bp,
HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_TUNNEL_TYPE_VXLAN
 #define CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_NVGRE  \
HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_TUNNEL_TYPE_NVGRE
+#define CFA_NTUPLE_FILTER_ALLOC_REQ_TUNNEL_TYPE_IPGRE  \
+   HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_TUNNEL_TYPE_IPGRE
 #define L2_FILTER_ALLOC_INPUT_EN_L2_ADDR_MASK  \
HWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR_MASK
 #define NTUPLE_FLTR_ALLOC_INPUT_IP_PROTOCOL_UDP\
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index 6f92e3de5..deb9733e9 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -109,9 +109,12 @@ bnxt_filter_type_check(const struct rte_flow_item 
pattern[],
}
use_ntuple |= 1;
break;
+   case RTE_FLOW_ITEM_TYPE_ANY:
+   use_ntuple = 0;
+   break;
default:
-   PMD_DRV_LOG(ERR, "Unknown Flow type\n");
-   use_ntuple |= 1;
+   PMD_DRV_LOG(DEBUG, "Unknown Flow type\n");
+   use_ntuple |= 0;
}
item++;
}
@@ -134,6 +137,8 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
const struct rte_flow_item_eth *eth_spec, *eth_mask;
const struct rte_flow_item_nvgre *nvgre_spec;
const struct rte_flow_item_nvgre *nvgre_mask;
+   const struct rte_flow_item_gre *gre_spec;
+   const struct rte_flow_item_gre *gre_mask;
const struct rte_flow_item_vxlan *vxlan_spec;
const struct rte_flow_item_vxlan *vxlan_mask;
uint8_t vni_mask[] = {0xFF, 0xFF, 0xFF};
@@ -146,13 +151,23 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
int use_ntuple;
uint32_t en = 0;
uint32_t en_ethertype;
-   int dflt_vnic;
+   int dflt_vnic, rc = 0;
 
use_ntuple = bnxt_filter_type_check(pattern, error);
PMD_DRV_LOG(DEBUG, "Use NTUPLE %d\n", use_ntuple);
if (use_ntuple < 0)
return use_ntuple;
 
+   if (use_ntuple && (bp->eth_dev->data->dev_conf.rxmode.mq_mode &
+   ETH_MQ_RX_RSS)) {
+   PMD_DRV_LOG(ERR, "Cannot create ntuple flow on RSS queues\n");
+   rte_flow_error_set(error, EINVAL,
+  RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+  "Cannot create flow on RSS queues");
+   rc = -rte_errno;
+   return rc;
+   }
+
filter->filter_type = use_ntuple ?
HWRM_CFA_NTUPLE_FILTER : HWRM_CFA_EM_FILTER;
en_ethertype = use_ntuple ?
@@ -169,16 +184,11 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
return -rte_errno;
}
 
-   if (!item->spec || !item->mask) {
-   rte_flow_error_set(error, EINVAL,
-  RTE_FLOW_ERROR_TYPE_ITEM,
-  item,
-  "spec/mask is NULL");
-   return -rte_errno;
-   }
-
switch (item->type) {
case RTE_FLOW_ITEM_TYPE_ETH:
+   if (!item->s

[dpdk-dev] [PATCH 5/6] net/bnxt: fix interrupt vector array initialization

2019-06-08 Thread Ajit Khaparde 
From: Naresh Kumar PBS 

Initialize the vector array when it is valid, thereby
preventing a case were it may be accessed when
the array is unallocated

Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")

Signed-off-by: Naresh Kumar PBS 
Signed-off-by: Ajit Khaparde 
Reviewed-by: Lance Richardson 
---
 drivers/net/bnxt/bnxt_ethdev.c | 13 ++---
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 4133d0bef..4dd845992 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -412,13 +412,12 @@ static int bnxt_init_chip(struct bnxt *bp)
"intr_handle->nb_efd = %d intr_handle->max_intr = %d\n",
 intr_handle->intr_vec, intr_handle->nb_efd,
intr_handle->max_intr);
-   }
-
-   for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues;
-queue_id++) {
-   intr_handle->intr_vec[queue_id] = vec;
-   if (vec < base + intr_handle->nb_efd - 1)
-   vec++;
+   for (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues;
+queue_id++) {
+   intr_handle->intr_vec[queue_id] = vec;
+   if (vec < base + intr_handle->nb_efd - 1)
+   vec++;
+   }
}
 
/* enable uio/vfio intr/eventfd mapping */
-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH 4/6] net/bnxt: fix output of port xstats

2019-06-08 Thread Ajit Khaparde 
From: Kalesh AP 

If the HWRM_PORT_QSTATS_EXT fails to initialize
fw_rx_port_stats_ext_size or fw_tx_port_stats_ext_size,
the driver can end up passing junk statistics to the application.

Instead of relying on the application to initialize the xstats
buffer before calling the xstats_get dev_op, memset xstats
with zeros to avoid returning or displaying incorrect statistics.

Also fixed the buffer starting offset.

Fixes: f55e12f33416 ("net/bnxt: support extended port counters")

Signed-off-by: Kalesh AP 
Signed-off-by: Ajit Khaparde 
Reviewed-by: Lance Richardson 
---
 drivers/net/bnxt/bnxt_ethdev.c | 6 --
 drivers/net/bnxt/bnxt_stats.c  | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e527df1bf..4133d0bef 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3775,7 +3775,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
goto skip_ext_stats;
 
bp->hw_rx_port_stats_ext = (void *)
-   (bp->hw_rx_port_stats + sizeof(struct rx_port_stats));
+   ((uint8_t *)bp->hw_rx_port_stats +
+sizeof(struct rx_port_stats));
bp->hw_rx_port_stats_ext_map = bp->hw_rx_port_stats_map +
sizeof(struct rx_port_stats);
bp->flags |= BNXT_FLAG_EXT_RX_PORT_STATS;
@@ -3783,7 +3784,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)
 
if (bp->hwrm_spec_code < HWRM_SPEC_CODE_1_9_2) {
bp->hw_tx_port_stats_ext = (void *)
-   (bp->hw_tx_port_stats + sizeof(struct tx_port_stats));
+   ((uint8_t *)bp->hw_tx_port_stats +
+sizeof(struct tx_port_stats));
bp->hw_tx_port_stats_ext_map =
bp->hw_tx_port_stats_map +
sizeof(struct tx_port_stats);
diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
index ad2888774..3cd5144ec 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -415,6 +415,8 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
unsigned int stat_size = sizeof(uint64_t);
unsigned int stat_count;
 
+   memset(xstats, 0, sizeof(*xstats));
+
bnxt_hwrm_port_qstats(bp);
bnxt_hwrm_func_qstats_tx_drop(bp, 0x, &tx_drop_pkts);
bnxt_hwrm_ext_port_qstats(bp);
-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH 2/6] net/bnxt: fix to check for NULL completion ring doorbell in int_handler

2019-06-08 Thread Ajit Khaparde 
From: Somnath Kotur 

It is observed that sometimes during init, the bnxt_int_handler() gets
invoked while the cpr->cp_db.doorbell is not yet initialized. Check for
the same and return.

Signed-off-by: Somnath Kotur 
Signed-off-by: Kalesh AP 
Signed-off-by: Ajit Khaparde 
---
 drivers/net/bnxt/bnxt_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
index 918f3dcf4..e1b9a2b04 100644
--- a/drivers/net/bnxt/bnxt_irq.c
+++ b/drivers/net/bnxt/bnxt_irq.c
@@ -31,7 +31,7 @@ static void bnxt_int_handler(void *param)
 
raw_cons = cpr->cp_raw_cons;
while (1) {
-   if (!cpr || !cpr->cp_ring_struct)
+   if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.cp_doorbell)
return;
 
cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH 6/6] net/bnxt: address build errors reported by intel compiler

2019-06-08 Thread Ajit Khaparde 
From: Naresh Kumar PBS 

Address build errors reported by intel compiler while compiling
on Windows. Instead of typeof() using the actual type in ALLOW_FUNC

Signed-off-by: Naresh Kumar PBS 
Signed-off-by: Ajit Khaparde 
Reviewed-by: Lance Richardson 
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 4dd845992..c76f7d5db 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3639,7 +3639,7 @@ int bnxt_alloc_ctx_mem(struct bnxt *bp)
 
 #define ALLOW_FUNC(x)  \
{ \
-   typeof(x) arg = (x); \
+   uint32_t arg = (x); \
bp->pf.vf_req_fwd[((arg) >> 5)] &= \
~rte_cpu_to_le_32(1 << ((arg) & 0x1f)); \
}
-- 
2.20.1 (Apple Git-117)

[dpdk-dev] [PATCH v2 0/7] add multiple cores feature to test-compress-perf

2019-06-08 Thread Tomasz Jozwiak 
This patchset adds multiple cores feature to compression perf tool.
All structures have been aligned and are consistent
with crypto perf tool. All test cases have constructor, runner
and destructor and can use more cores and compression devices at
the same time. 

v2 changes:

  - fixed checkpatch warning
  - fixed max_nb_queue_pairs detection. Based on compression API
if max_nb_queue_pairs = 0 that means there is no limit in 
maximum number of queue pairs 
  - fixed qp setup on the last device


Tomasz Jozwiak (7):
  app/test-compress-perf: add weak functions for multi-cores test
  app/test-compress-perf: add ptest command line option
  app/test-compress-perf: add verification test case
  app/test-compress-perf: add benchmark test case
  doc: update dpdk-test-compress-perf description
  app/test-compress-perf: add force process termination
  doc: update release notes for 19.08

 app/test-compress-perf/Makefile   |   1 +
 app/test-compress-perf/comp_perf.h|  61 +++
 app/test-compress-perf/comp_perf_options.h|  46 +-
 app/test-compress-perf/comp_perf_options_parse.c  |  58 +-
 app/test-compress-perf/comp_perf_test_benchmark.c | 152 --
 app/test-compress-perf/comp_perf_test_benchmark.h |  25 +-
 app/test-compress-perf/comp_perf_test_common.c| 285 ++
 app/test-compress-perf/comp_perf_test_common.h|  41 ++
 app/test-compress-perf/comp_perf_test_verify.c| 136 +++--
 app/test-compress-perf/comp_perf_test_verify.h|  24 +-
 app/test-compress-perf/main.c | 633 ++
 app/test-compress-perf/meson.build|   3 +-
 doc/guides/rel_notes/release_19_08.rst|   3 +
 doc/guides/tools/comp_perf.rst|  34 +-
 14 files changed, 1036 insertions(+), 466 deletions(-)
 create mode 100644 app/test-compress-perf/comp_perf.h
 create mode 100644 app/test-compress-perf/comp_perf_test_common.c
 create mode 100644 app/test-compress-perf/comp_perf_test_common.h

-- 
2.7.4

[dpdk-dev] [PATCH v2 2/7] app/test-compress-perf: add ptest command line option

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch adds --ptest option to make possible a choose
of test case from command line.

Signed-off-by: Tomasz Jozwiak 
---
 app/test-compress-perf/comp_perf_options_parse.c | 36 
 1 file changed, 36 insertions(+)

diff --git a/app/test-compress-perf/comp_perf_options_parse.c 
b/app/test-compress-perf/comp_perf_options_parse.c
index bc4b98a..07672b2 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -15,6 +15,7 @@
 
 #include "comp_perf_options.h"
 
+#define CPERF_PTEST_TYPE   ("ptest")
 #define CPERF_DRIVER_NAME  ("driver-name")
 #define CPERF_TEST_FILE("input-file")
 #define CPERF_SEG_SIZE ("seg-sz")
@@ -37,6 +38,7 @@ static void
 usage(char *progname)
 {
printf("%s [EAL options] --\n"
+   " --ptest benchmark / verify :"
" --driver-name NAME: compress driver to use\n"
" --input-file NAME: file to compress and decompress\n"
" --extended-input-sz N: extend file data up to this size 
(default: no extension)\n"
@@ -76,6 +78,37 @@ get_str_key_id_mapping(struct name_id_map *map, unsigned int 
map_len,
 }
 
 static int
+parse_cperf_test_type(struct comp_test_data *test_data, const char *arg)
+{
+   struct name_id_map cperftest_namemap[] = {
+   {
+   cperf_test_type_strs[CPERF_TEST_TYPE_BENCHMARK],
+   CPERF_TEST_TYPE_BENCHMARK
+   },
+   {
+   cperf_test_type_strs[CPERF_TEST_TYPE_VERIFY],
+   CPERF_TEST_TYPE_VERIFY
+   },
+   {
+   cperf_test_type_strs[CPERF_TEST_TYPE_PMDCC],
+   CPERF_TEST_TYPE_PMDCC
+   }
+   };
+
+   int id = get_str_key_id_mapping(
+   (struct name_id_map *)cperftest_namemap,
+   RTE_DIM(cperftest_namemap), arg);
+   if (id < 0) {
+   RTE_LOG(ERR, USER1, "failed to parse test type");
+   return -1;
+   }
+
+   test_data->test = (enum cperf_perf_test_type)id;
+
+   return 0;
+}
+
+static int
 parse_uint32_t(uint32_t *value, const char *arg)
 {
char *end = NULL;
@@ -499,6 +532,8 @@ struct long_opt_parser {
 };
 
 static struct option lgopts[] = {
+
+   { CPERF_PTEST_TYPE, required_argument, 0, 0 },
{ CPERF_DRIVER_NAME, required_argument, 0, 0 },
{ CPERF_TEST_FILE, required_argument, 0, 0 },
{ CPERF_SEG_SIZE, required_argument, 0, 0 },
@@ -517,6 +552,7 @@ static int
 comp_perf_opts_parse_long(int opt_idx, struct comp_test_data *test_data)
 {
struct long_opt_parser parsermap[] = {
+   { CPERF_PTEST_TYPE, parse_cperf_test_type },
{ CPERF_DRIVER_NAME,parse_driver_name },
{ CPERF_TEST_FILE,  parse_test_file },
{ CPERF_SEG_SIZE,   parse_seg_sz },
-- 
2.7.4

[dpdk-dev] [PATCH v2 3/7] app/test-compress-perf: add verification test case

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch adds a verification part to
compression-perf-tool as a separate test case, which can be
executed multi-threaded.

Signed-off-by: Tomasz Jozwiak 
---
 app/test-compress-perf/Makefile|   1 +
 app/test-compress-perf/comp_perf_test_verify.c | 122 ++---
 app/test-compress-perf/comp_perf_test_verify.h |  24 -
 app/test-compress-perf/main.c  |   1 +
 app/test-compress-perf/meson.build |   1 +
 5 files changed, 112 insertions(+), 37 deletions(-)

diff --git a/app/test-compress-perf/Makefile b/app/test-compress-perf/Makefile
index de74129..f54d9a4 100644
--- a/app/test-compress-perf/Makefile
+++ b/app/test-compress-perf/Makefile
@@ -12,6 +12,7 @@ CFLAGS += -O3
 # all source are stored in SRCS-y
 SRCS-y := main.c
 SRCS-y += comp_perf_options_parse.c
+SRCS-y += comp_perf_test_verify.c
 SRCS-y += comp_perf_test_common.c
 
 include $(RTE_SDK)/mk/rte.app.mk
diff --git a/app/test-compress-perf/comp_perf_test_verify.c 
b/app/test-compress-perf/comp_perf_test_verify.c
index 28a0fe8..c2aab70 100644
--- a/app/test-compress-perf/comp_perf_test_verify.c
+++ b/app/test-compress-perf/comp_perf_test_verify.c
@@ -8,14 +8,48 @@
 #include 
 
 #include "comp_perf_test_verify.h"
+#include "comp_perf_test_common.h"
+
+void
+cperf_verify_test_destructor(void *arg)
+{
+   if (arg) {
+   comp_perf_free_memory(&((struct cperf_verify_ctx *)arg)->mem);
+   rte_free(arg);
+   }
+}
+
+void *
+cperf_verify_test_constructor(uint8_t dev_id, uint16_t qp_id,
+   struct comp_test_data *options)
+{
+   struct cperf_verify_ctx *ctx = NULL;
+
+   ctx = rte_malloc(NULL, sizeof(struct cperf_verify_ctx), 0);
+
+   if (ctx != NULL) {
+   ctx->mem.dev_id = dev_id;
+   ctx->mem.qp_id = qp_id;
+   ctx->options = options;
+
+   if (!comp_perf_allocate_memory(ctx->options, &ctx->mem) &&
+   !prepare_bufs(ctx->options, &ctx->mem))
+   return ctx;
+   }
+
+   cperf_verify_test_destructor(ctx);
+   return NULL;
+}
 
 static int
-main_loop(struct comp_test_data *test_data, uint8_t level,
-   enum rte_comp_xform_type type,
-   uint8_t *output_data_ptr,
-   size_t *output_data_sz)
+main_loop(struct cperf_verify_ctx *ctx, enum rte_comp_xform_type type)
 {
-   uint8_t dev_id = test_data->cdev_id;
+   struct comp_test_data *test_data = ctx->options;
+   uint8_t *output_data_ptr;
+   size_t *output_data_sz;
+   struct cperf_mem_resources *mem = &ctx->mem;
+
+   uint8_t dev_id = mem->dev_id;
uint32_t i, iter, num_iter;
struct rte_comp_op **ops, **deq_ops;
void *priv_xform = NULL;
@@ -33,7 +67,7 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
}
 
ops = rte_zmalloc_socket(NULL,
-   2 * test_data->total_bufs * sizeof(struct rte_comp_op *),
+   2 * mem->total_bufs * sizeof(struct rte_comp_op *),
0, rte_socket_id());
 
if (ops == NULL) {
@@ -42,7 +76,7 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
return -1;
}
 
-   deq_ops = &ops[test_data->total_bufs];
+   deq_ops = &ops[mem->total_bufs];
 
if (type == RTE_COMP_COMPRESS) {
xform = (struct rte_comp_xform) {
@@ -50,14 +84,16 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
.compress = {
.algo = RTE_COMP_ALGO_DEFLATE,
.deflate.huffman = test_data->huffman_enc,
-   .level = level,
+   .level = test_data->level,
.window_size = test_data->window_sz,
.chksum = RTE_COMP_CHECKSUM_NONE,
.hash_algo = RTE_COMP_HASH_ALGO_NONE
}
};
-   input_bufs = test_data->decomp_bufs;
-   output_bufs = test_data->comp_bufs;
+   output_data_ptr = ctx->mem.compressed_data;
+   output_data_sz = &ctx->comp_data_sz;
+   input_bufs = mem->decomp_bufs;
+   output_bufs = mem->comp_bufs;
out_seg_sz = test_data->out_seg_sz;
} else {
xform = (struct rte_comp_xform) {
@@ -69,8 +105,10 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
.hash_algo = RTE_COMP_HASH_ALGO_NONE
}
};
-   input_bufs = test_data->comp_bufs;
-   output_bufs = test_data->decomp_bufs;
+   output_data_ptr = ctx->mem.decompressed_data;
+   output_data_sz = &ctx->decomp_data_sz;
+   input_bufs = mem->comp_bufs;
+   output_bufs = mem->decomp_buf

[dpdk-dev] [PATCH v2 6/7] app/test-compress-perf: add force process termination

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch adds a possibility to force controlled process termination
as a result of two signals: SIGTERM and SIGINT

Signed-off-by: Tomasz Jozwiak 
---
 app/test-compress-perf/comp_perf_options.h|  1 +
 app/test-compress-perf/comp_perf_test_benchmark.c | 13 
 app/test-compress-perf/comp_perf_test_verify.c| 14 
 app/test-compress-perf/main.c | 26 +--
 4 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/app/test-compress-perf/comp_perf_options.h 
b/app/test-compress-perf/comp_perf_options.h
index 79e63d5..534212d 100644
--- a/app/test-compress-perf/comp_perf_options.h
+++ b/app/test-compress-perf/comp_perf_options.h
@@ -68,6 +68,7 @@ struct comp_test_data {
 
double ratio;
enum cleanup_st cleanup;
+   int perf_comp_force_stop;
 };
 
 int
diff --git a/app/test-compress-perf/comp_perf_test_benchmark.c 
b/app/test-compress-perf/comp_perf_test_benchmark.c
index 9b0b146..b38b33c 100644
--- a/app/test-compress-perf/comp_perf_test_benchmark.c
+++ b/app/test-compress-perf/comp_perf_test_benchmark.c
@@ -183,6 +183,9 @@ main_loop(struct cperf_benchmark_ctx *ctx, enum 
rte_comp_xform_type type)
ops[op_id]->private_xform = priv_xform;
}
 
+   if (unlikely(test_data->perf_comp_force_stop))
+   goto end;
+
num_enq = rte_compressdev_enqueue_burst(dev_id,
mem->qp_id, ops,
num_ops);
@@ -241,6 +244,9 @@ main_loop(struct cperf_benchmark_ctx *ctx, enum 
rte_comp_xform_type type)
 
/* Dequeue the last operations */
while (total_deq_ops < total_ops) {
+   if (unlikely(test_data->perf_comp_force_stop))
+   goto end;
+
num_deq = rte_compressdev_dequeue_burst(dev_id,
   mem->qp_id,
   deq_ops,
@@ -305,6 +311,13 @@ main_loop(struct cperf_benchmark_ctx *ctx, enum 
rte_comp_xform_type type)
rte_mempool_put_bulk(mem->op_pool, (void **)ops, allocated);
rte_compressdev_private_xform_free(dev_id, priv_xform);
rte_free(ops);
+
+   if (test_data->perf_comp_force_stop) {
+   RTE_LOG(ERR, USER1,
+ "lcore: %d Perf. test has been aborted by user\n",
+   mem->lcore_id);
+   res = -1;
+   }
return res;
 }
 
diff --git a/app/test-compress-perf/comp_perf_test_verify.c 
b/app/test-compress-perf/comp_perf_test_verify.c
index c2aab70..b2cd7a0 100644
--- a/app/test-compress-perf/comp_perf_test_verify.c
+++ b/app/test-compress-perf/comp_perf_test_verify.c
@@ -187,6 +187,9 @@ main_loop(struct cperf_verify_ctx *ctx, enum 
rte_comp_xform_type type)
ops[op_id]->private_xform = priv_xform;
}
 
+   if (unlikely(test_data->perf_comp_force_stop))
+   goto end;
+
num_enq = rte_compressdev_enqueue_burst(dev_id,
mem->qp_id, ops,
num_ops);
@@ -267,6 +270,9 @@ main_loop(struct cperf_verify_ctx *ctx, enum 
rte_comp_xform_type type)
 
/* Dequeue the last operations */
while (total_deq_ops < total_ops) {
+   if (unlikely(test_data->perf_comp_force_stop))
+   goto end;
+
num_deq = rte_compressdev_dequeue_burst(dev_id,
mem->qp_id,
deq_ops,
@@ -345,6 +351,14 @@ main_loop(struct cperf_verify_ctx *ctx, enum 
rte_comp_xform_type type)
rte_mempool_put_bulk(mem->op_pool, (void **)ops, allocated);
rte_compressdev_private_xform_free(dev_id, priv_xform);
rte_free(ops);
+
+   if (test_data->perf_comp_force_stop) {
+   RTE_LOG(ERR, USER1,
+ "lcore: %d Perf. test has been aborted by user\n",
+   mem->lcore_id);
+   res = -1;
+   }
+
return res;
 }
 
diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index f8e5f15..a9022f6 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -2,6 +2,10 @@
  * Copyright(c) 2018 Intel Corporation
  */
 
+#include 
+#include 
+#include 
+
 #include 
 #include 
 #include 
@@ -42,6 +46,8 @@ static const struct cperf_test cperf_testmap[] = {
}
 };
 
+static struct comp_test_data *test_data;
+
 static int
 comp_perf_check_capabilities(stru

[dpdk-dev] [PATCH v2 4/7] app/test-compress-perf: add benchmark test case

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch adds a benchmark part to
compression-perf-tool as a separate test case, which can be
executed multi-threaded.

Signed-off-by: Tomasz Jozwiak 
---
 app/test-compress-perf/Makefile   |   1 +
 app/test-compress-perf/comp_perf_test_benchmark.c | 139 --
 app/test-compress-perf/comp_perf_test_benchmark.h |  25 +++-
 app/test-compress-perf/main.c |   1 +
 app/test-compress-perf/meson.build|   1 +
 5 files changed, 129 insertions(+), 38 deletions(-)

diff --git a/app/test-compress-perf/Makefile b/app/test-compress-perf/Makefile
index f54d9a4..d1a6820 100644
--- a/app/test-compress-perf/Makefile
+++ b/app/test-compress-perf/Makefile
@@ -13,6 +13,7 @@ CFLAGS += -O3
 SRCS-y := main.c
 SRCS-y += comp_perf_options_parse.c
 SRCS-y += comp_perf_test_verify.c
+SRCS-y += comp_perf_test_benchmark.c
 SRCS-y += comp_perf_test_common.c
 
 include $(RTE_SDK)/mk/rte.app.mk
diff --git a/app/test-compress-perf/comp_perf_test_benchmark.c 
b/app/test-compress-perf/comp_perf_test_benchmark.c
index 5752906..9b0b146 100644
--- a/app/test-compress-perf/comp_perf_test_benchmark.c
+++ b/app/test-compress-perf/comp_perf_test_benchmark.c
@@ -10,11 +10,45 @@
 
 #include "comp_perf_test_benchmark.h"
 
+void
+cperf_benchmark_test_destructor(void *arg)
+{
+   if (arg) {
+   comp_perf_free_memory(
+   &((struct cperf_benchmark_ctx *)arg)->ver.mem);
+   rte_free(arg);
+   }
+}
+
+void *
+cperf_benchmark_test_constructor(uint8_t dev_id, uint16_t qp_id,
+   struct comp_test_data *options)
+{
+   struct cperf_benchmark_ctx *ctx = NULL;
+
+   ctx = rte_malloc(NULL, sizeof(struct cperf_benchmark_ctx), 0);
+
+   if (ctx != NULL) {
+   ctx->ver.mem.dev_id = dev_id;
+   ctx->ver.mem.qp_id = qp_id;
+   ctx->ver.options = options;
+   ctx->ver.silent = 1; /* ver. part will be silent */
+
+   if (!comp_perf_allocate_memory(ctx->ver.options, &ctx->ver.mem)
+ && !prepare_bufs(ctx->ver.options, &ctx->ver.mem))
+   return ctx;
+   }
+
+   cperf_benchmark_test_destructor(ctx);
+   return NULL;
+}
+
 static int
-main_loop(struct comp_test_data *test_data, uint8_t level,
-   enum rte_comp_xform_type type)
+main_loop(struct cperf_benchmark_ctx *ctx, enum rte_comp_xform_type type)
 {
-   uint8_t dev_id = test_data->cdev_id;
+   struct comp_test_data *test_data = ctx->ver.options;
+   struct cperf_mem_resources *mem = &ctx->ver.mem;
+   uint8_t dev_id = mem->dev_id;
uint32_t i, iter, num_iter;
struct rte_comp_op **ops, **deq_ops;
void *priv_xform = NULL;
@@ -31,7 +65,7 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
}
 
ops = rte_zmalloc_socket(NULL,
-   2 * test_data->total_bufs * sizeof(struct rte_comp_op *),
+   2 * mem->total_bufs * sizeof(struct rte_comp_op *),
0, rte_socket_id());
 
if (ops == NULL) {
@@ -40,7 +74,7 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
return -1;
}
 
-   deq_ops = &ops[test_data->total_bufs];
+   deq_ops = &ops[mem->total_bufs];
 
if (type == RTE_COMP_COMPRESS) {
xform = (struct rte_comp_xform) {
@@ -48,14 +82,14 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
.compress = {
.algo = RTE_COMP_ALGO_DEFLATE,
.deflate.huffman = test_data->huffman_enc,
-   .level = level,
+   .level = test_data->level,
.window_size = test_data->window_sz,
.chksum = RTE_COMP_CHECKSUM_NONE,
.hash_algo = RTE_COMP_HASH_ALGO_NONE
}
};
-   input_bufs = test_data->decomp_bufs;
-   output_bufs = test_data->comp_bufs;
+   input_bufs = mem->decomp_bufs;
+   output_bufs = mem->comp_bufs;
out_seg_sz = test_data->out_seg_sz;
} else {
xform = (struct rte_comp_xform) {
@@ -67,8 +101,8 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
.hash_algo = RTE_COMP_HASH_ALGO_NONE
}
};
-   input_bufs = test_data->comp_bufs;
-   output_bufs = test_data->decomp_bufs;
+   input_bufs = mem->comp_bufs;
+   output_bufs = mem->decomp_bufs;
out_seg_sz = test_data->seg_sz;
}
 
@@ -82,13 +116,13 @@ main_loop(struct comp_test_data *test_data, uint8_t level,
 
uint64_t tsc_start, tsc_end, tsc_duration;
 
-   tsc_start = tsc_end = tsc_duration = 0

[dpdk-dev] [PATCH v2 1/7] app/test-compress-perf: add weak functions for multi-cores test

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch adds a template functions for multi-cores performance
version of compress-perf-tool.

Signed-off-by: Tomasz Jozwiak 
Signed-off-by: Tomasz Jozwiak 
---
 app/test-compress-perf/Makefile  |   3 +-
 app/test-compress-perf/comp_perf.h   |  61 +++
 app/test-compress-perf/comp_perf_options.h   |  45 +-
 app/test-compress-perf/comp_perf_options_parse.c |  24 +-
 app/test-compress-perf/comp_perf_test_common.c   | 285 +++
 app/test-compress-perf/comp_perf_test_common.h   |  41 ++
 app/test-compress-perf/main.c| 627 ++-
 app/test-compress-perf/meson.build   |   3 +-
 8 files changed, 688 insertions(+), 401 deletions(-)
 create mode 100644 app/test-compress-perf/comp_perf.h
 create mode 100644 app/test-compress-perf/comp_perf_test_common.c
 create mode 100644 app/test-compress-perf/comp_perf_test_common.h

diff --git a/app/test-compress-perf/Makefile b/app/test-compress-perf/Makefile
index d20e17e..de74129 100644
--- a/app/test-compress-perf/Makefile
+++ b/app/test-compress-perf/Makefile
@@ -12,7 +12,6 @@ CFLAGS += -O3
 # all source are stored in SRCS-y
 SRCS-y := main.c
 SRCS-y += comp_perf_options_parse.c
-SRCS-y += comp_perf_test_verify.c
-SRCS-y += comp_perf_test_benchmark.c
+SRCS-y += comp_perf_test_common.c
 
 include $(RTE_SDK)/mk/rte.app.mk
diff --git a/app/test-compress-perf/comp_perf.h 
b/app/test-compress-perf/comp_perf.h
new file mode 100644
index 000..144ad8a
--- /dev/null
+++ b/app/test-compress-perf/comp_perf.h
@@ -0,0 +1,61 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2019 Intel Corporation
+ */
+
+#ifndef _COMP_PERF_
+#define _COMP_PERF_
+
+#include 
+
+struct comp_test_data;
+
+typedef void  *(*cperf_constructor_t)(
+   uint8_t dev_id,
+   uint16_t qp_id,
+   struct comp_test_data *options);
+
+typedef int (*cperf_runner_t)(void *test_ctx);
+typedef void (*cperf_destructor_t)(void *test_ctx);
+
+struct cperf_test {
+   cperf_constructor_t constructor;
+   cperf_runner_t runner;
+   cperf_destructor_t destructor;
+};
+
+/* Needed for weak functions*/
+
+void *
+cperf_benchmark_test_constructor(uint8_t dev_id __rte_unused,
+uint16_t qp_id __rte_unused,
+struct comp_test_data *options __rte_unused);
+
+void
+cperf_benchmark_test_destructor(void *arg __rte_unused);
+
+int
+cperf_benchmark_test_runner(void *test_ctx __rte_unused);
+
+void *
+cperf_verify_test_constructor(uint8_t dev_id __rte_unused,
+uint16_t qp_id __rte_unused,
+struct comp_test_data *options __rte_unused);
+
+void
+cperf_verify_test_destructor(void *arg __rte_unused);
+
+int
+cperf_verify_test_runner(void *test_ctx __rte_unused);
+
+void *
+cperf_pmd_cyclecount_test_constructor(uint8_t dev_id __rte_unused,
+uint16_t qp_id __rte_unused,
+struct comp_test_data *options __rte_unused);
+
+void
+cperf_pmd_cyclecount_test_destructor(void *arg __rte_unused);
+
+int
+cperf_pmd_cyclecount_test_runner(void *test_ctx __rte_unused);
+
+#endif /* _COMP_PERF_ */
diff --git a/app/test-compress-perf/comp_perf_options.h 
b/app/test-compress-perf/comp_perf_options.h
index f87751d..79e63d5 100644
--- a/app/test-compress-perf/comp_perf_options.h
+++ b/app/test-compress-perf/comp_perf_options.h
@@ -13,6 +13,24 @@
 #define MAX_MBUF_DATA_SIZE (UINT16_MAX - RTE_PKTMBUF_HEADROOM)
 #define MAX_SEG_SIZE ((int)(MAX_MBUF_DATA_SIZE / EXPANSE_RATIO))
 
+extern const char *cperf_test_type_strs[];
+
+/* Cleanup state machine */
+enum cleanup_st {
+   ST_CLEAR = 0,
+   ST_TEST_DATA,
+   ST_COMPDEV,
+   ST_INPUT_DATA,
+   ST_MEMORY_ALLOC,
+   ST_DURING_TEST
+};
+
+enum cperf_perf_test_type {
+   CPERF_TEST_TYPE_BENCHMARK,
+   CPERF_TEST_TYPE_VERIFY,
+   CPERF_TEST_TYPE_PMDCC
+};
+
 enum comp_operation {
COMPRESS_ONLY,
DECOMPRESS_ONLY,
@@ -30,37 +48,26 @@ struct range_list {
 struct comp_test_data {
char driver_name[64];
char input_file[64];
-   struct rte_mbuf **comp_bufs;
-   struct rte_mbuf **decomp_bufs;
-   uint32_t total_bufs;
+   enum cperf_perf_test_type test;
+
uint8_t *input_data;
size_t input_data_sz;
-   uint8_t *compressed_data;
-   uint8_t *decompressed_data;
-   struct rte_mempool *comp_buf_pool;
-   struct rte_mempool *decomp_buf_pool;
-   struct rte_mempool *op_pool;
-   int8_t cdev_id;
+   uint16_t nb_qps;
uint16_t seg_sz;
uint16_t out_seg_sz;
uint16_t burst_sz;
uint32_t pool_sz;
uint32_t num_iter;
uint16_t max_sgl_segs;
+
enum rte_comp_huffman huffman_enc;
enum comp_operation test_op;
int window_sz;
-   struct range_list level;
-   /* Store TSC duration for all levels

[dpdk-dev] [PATCH v2 7/7] doc: update release notes for 19.08

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

Added release note entry for test-compress-perf application

Signed-off-by: Tomasz Jozwiak 
---
 doc/guides/rel_notes/release_19_08.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_08.rst 
b/doc/guides/rel_notes/release_19_08.rst
index b9510f9..543e7d3 100644
--- a/doc/guides/rel_notes/release_19_08.rst
+++ b/doc/guides/rel_notes/release_19_08.rst
@@ -54,6 +54,9 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
+* **Updated test-compress-perf tool application.**
+
+  Added multiple cores feature to compression perf tool application.
 
 Removed Items
 -
-- 
2.7.4

[dpdk-dev] [PATCH v2 5/7] doc: update dpdk-test-compress-perf description

2019-06-08 Thread Tomasz Jozwiak 
From: Tomasz Jozwiak 

This patch updates a dpdk-test-compress-perf documentation.

Signed-off-by: Tomasz Jozwiak 
---
 doc/guides/tools/comp_perf.rst | 34 +++---
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/tools/comp_perf.rst
index 52869c1..71eef18 100644
--- a/doc/guides/tools/comp_perf.rst
+++ b/doc/guides/tools/comp_perf.rst
@@ -6,7 +6,9 @@ dpdk-test-compress-perf Tool
 
 The ``dpdk-test-compress-perf`` tool is a Data Plane Development Kit (DPDK)
 utility that allows measuring performance parameters of PMDs available in the
-compress tree. The tool reads the data from a file (--input-file),
+compress tree. User can use multiple cores to run tests on but only
+one type of compression PMD can be measured during single application
+execution. The tool reads the data from a file (--input-file),
 dumps all the file into a buffer and fills out the data of input mbufs,
 which are passed to compress device with compression operations.
 Then, the output buffers are fed into the decompression stage, and the 
resulting
@@ -26,9 +28,35 @@ Limitations
 
 * Stateful operation is not supported in this version.
 
+EAL Options
+~~~
+
+The following are the EAL command-line options that can be used in conjunction
+with the ``dpdk-test-compress-perf`` application.
+See the DPDK Getting Started Guides for more information on these options.
+
+*   ``-c `` or ``-l ``
+
+   Set the hexadecimal bitmask of the cores to run on. The corelist is a
+   list cores to use.
+
+.. Note::
+
+   One lcore is needed for process admin, tests are run on all other cores.
+   To run tests on two lcores, three lcores must be passed to the tool.
+
+*   ``-w ``
+
+   Add a PCI device in white list.
+
+*   ``--vdev ``
+
+   Add a virtual device.
+
+Appication Options
+~~
 
-Command line options
-
+ ``--ptest [benchmark/verify]``: set test type (default: benchmark)
 
  ``--driver-name NAME``: compress driver to use
 
-- 
2.7.4

Re: [dpdk-dev] [EXT] [PATCH v2 0/7] add multiple cores feature to test-compress-perf

2019-06-08 Thread Shally Verma 



> -Original Message-
> From: Tomasz Jozwiak 
> Sent: Sunday, June 9, 2019 3:29 AM
> To: dev@dpdk.org; fiona.tr...@intel.com; tjozwia...@gmail.com; Shally
> Verma 
> Subject: [EXT] [PATCH v2 0/7] add multiple cores feature to test-compress-
> perf
> 
> External Email
> 
> --
> This patchset adds multiple cores feature to compression perf tool.
> All structures have been aligned and are consistent with crypto perf tool. All
> test cases have constructor, runner and destructor and can use more cores
> and compression devices at the same time.
> 
> v2 changes:
> 
>   - fixed checkpatch warning
>   - fixed max_nb_queue_pairs detection. Based on compression API
> if max_nb_queue_pairs = 0 that means there is no limit in
> maximum number of queue pairs
It should mean implementation defined/specific

>   - fixed qp setup on the last device
> 
> 
> Tomasz Jozwiak (7):
>   app/test-compress-perf: add weak functions for multi-cores test
>   app/test-compress-perf: add ptest command line option
>   app/test-compress-perf: add verification test case
>   app/test-compress-perf: add benchmark test case
>   doc: update dpdk-test-compress-perf description
>   app/test-compress-perf: add force process termination
>   doc: update release notes for 19.08
> 
>  app/test-compress-perf/Makefile   |   1 +
>  app/test-compress-perf/comp_perf.h|  61 +++
>  app/test-compress-perf/comp_perf_options.h|  46 +-
>  app/test-compress-perf/comp_perf_options_parse.c  |  58 +-
>  app/test-compress-perf/comp_perf_test_benchmark.c | 152 --
>  app/test-compress-perf/comp_perf_test_benchmark.h |  25 +-
>  app/test-compress-perf/comp_perf_test_common.c| 285 ++
>  app/test-compress-perf/comp_perf_test_common.h|  41 ++
>  app/test-compress-perf/comp_perf_test_verify.c| 136 +++--
>  app/test-compress-perf/comp_perf_test_verify.h|  24 +-
>  app/test-compress-perf/main.c | 633 
> ++
>  app/test-compress-perf/meson.build|   3 +-
>  doc/guides/rel_notes/release_19_08.rst|   3 +
>  doc/guides/tools/comp_perf.rst|  34 +-
>  14 files changed, 1036 insertions(+), 466 deletions(-)
>  create mode 100644 app/test-compress-perf/comp_perf.h
>  create mode 100644 app/test-compress-perf/comp_perf_test_common.c
>  create mode 100644 app/test-compress-perf/comp_perf_test_common.h
> 
> --
> 2.7.4