[dpdk-dev] [PATCH 1/3] net/i40e: fix invalid Tx threshold setup

[Qi Zhang]

Tx desc's DD status is not cleaned by NIC automatically after packets
have been transmitted until software refill a new packet during next
loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible
that an outdated DD status be checked as tx_next_dd, then segment fault
happen due to free a NULL mbuf pointer.

Then patch fixes this issue by
1. try to adapt tx_rs_thresh to an aggresive tx_free_thresh.
2. queue setup fail when tx_free_thresh + tx_rs_thresh > nb_desc

Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: sta...@dpdk.org

Signed-off-by: Qi Zhang 
---
 drivers/net/i40e/i40e_rxtx.c | 19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 1489552da..4640a9c66 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2169,15 +2169,30 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 *  - tx_rs_thresh must be a divisor of the ring size.
 *  - tx_free_thresh must be greater than 0.
 *  - tx_free_thresh must be less than the size of the ring minus 3.
+*  - tx_free_thresh + tx_rs_thresh must not exceed nb_desc.
 *
 * One descriptor in the TX ring is used as a sentinel to avoid a H/W
 * race condition, hence the maximum threshold constraints. When set
 * to zero use default values.
 */
-   tx_rs_thresh = (uint16_t)((tx_conf->tx_rs_thresh) ?
-   tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH);
tx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ?
tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH);
+   /* force tx_rs_thresh to adapt an aggresive tx_free_thresh */
+   tx_rs_thresh = (DEFAULT_TX_RS_THRESH + tx_free_thresh > nb_desc) ?
+   nb_desc - tx_free_thresh : DEFAULT_TX_RS_THRESH;
+   if (tx_conf->tx_rs_thresh > 0)
+   tx_rs_thresh = tx_conf->tx_rs_thresh;
+   if (tx_rs_thresh + tx_free_thresh > nb_desc) {
+   PMD_INIT_LOG(ERR, "tx_rs_thresh + tx_free_thresh must not "
+   "exceed nb_desc. (tx_rs_thresh=%u "
+   "tx_free_thresh=%u nb_desc=%u port=%d 
queue=%d)",
+   (unsigned int)tx_rs_thresh,
+   (unsigned int)tx_free_thresh,
+   (unsigned int)nb_desc,
+   (int)dev->data->port_id,
+   (int)queue_idx);
+   return I40E_ERR_PARAM;
+   }
if (tx_rs_thresh >= (nb_desc - 2)) {
PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than the "
 "number of TX descriptors minus 2. "
-- 
2.13.6

[dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup

[Qi Zhang]

When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible
that an outdated DD status be checked as tx_next_dd, then segment fault
happen due to free a NULL mbuf pointer.

The issue usually happens with an aggresive tx_free_thresh, for example:

./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 
--txfreet=1020

The patchset fix this issue on i40e, ixgbe and ice.

Qi Zhang (3):
  net/i40e: fix invalid Tx threshold setup
  net/ice: fix invalid Tx threshold setup
  net/ixgbe: fix invalid Tx threshold setup

 drivers/net/i40e/i40e_rxtx.c   | 19 +--
 drivers/net/ice/ice_rxtx.c | 21 ++---
 drivers/net/ixgbe/ixgbe_rxtx.c | 19 +--
 3 files changed, 52 insertions(+), 7 deletions(-)

-- 
2.13.6

[dpdk-dev] [PATCH 3/3] net/ixgbe: fix invalid Tx threshold setup

[Qi Zhang]

Tx desc's DD status is not cleaned by NIC automatically after packets
have been transmitted until software refill a new packet during next
loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible
that an outdated DD status be checked as tx_next_dd, then segment fault
happen due to free a NULL mbuf pointer.

Then patch fixes this issue by
1. try to adapt tx_rs_thresh to an aggresive tx_free_thresh.
2. queue setup fail when tx_free_thresh + tx_rs_thresh > nb_desc

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Qi Zhang 
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 19 +--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 1fbc754ae..3072bc1b5 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2496,14 +2496,29 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
 *  tx_rs_thresh must be a divisor of the ring size.
 *  tx_free_thresh must be greater than 0.
 *  tx_free_thresh must be less than the size of the ring minus 3.
+*  tx_free_thresh + tx_rs_thresh must not exceed nb_desc.
 * One descriptor in the TX ring is used as a sentinel to avoid a
 * H/W race condition, hence the maximum threshold constraints.
 * When set to zero use default values.
 */
-   tx_rs_thresh = (uint16_t)((tx_conf->tx_rs_thresh) ?
-   tx_conf->tx_rs_thresh : DEFAULT_TX_RS_THRESH);
tx_free_thresh = (uint16_t)((tx_conf->tx_free_thresh) ?
tx_conf->tx_free_thresh : DEFAULT_TX_FREE_THRESH);
+   /* force tx_rs_thresh to adapt an aggresive tx_free_thresh */
+   tx_rs_thresh = (DEFAULT_TX_RS_THRESH + tx_free_thresh > nb_desc) ?
+   nb_desc - tx_free_thresh : DEFAULT_TX_RS_THRESH;
+   if (tx_conf->tx_rs_thresh > 0)
+   tx_rs_thresh = tx_conf->tx_rs_thresh;
+   if (tx_rs_thresh + tx_free_thresh > nb_desc) {
+   PMD_INIT_LOG(ERR, "tx_rs_thresh + tx_free_thresh must not "
+"exceed nb_desc. (tx_rs_thresh=%u "
+"tx_free_thresh=%u nb_desc=%u port = %d queue=%d)",
+(unsigned int)tx_rs_thresh,
+(unsigned int)tx_free_thresh,
+(unsigned int)nb_desc,
+(int)dev->data->port_id,
+(int)queue_idx);
+   return -(EINVAL);
+   }
if (tx_rs_thresh >= (nb_desc - 2)) {
PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than the number "
"of TX descriptors minus 2. (tx_rs_thresh=%u "
-- 
2.13.6

[dpdk-dev] [PATCH 2/3] net/ice: fix invalid Tx threshold setup

[Qi Zhang]

Tx desc's DD status is not cleaned by NIC automatically after packets
have been transmitted until software refill a new packet during next
loop. So when tx_free_thresh + tx_rs_thresh > nb_desc, it is possible
that an outdated DD status be checked as tx_next_dd, then segment fault
happen due to free a NULL mbuf pointer.

Then patch fixes this issue by
1. try to adapt tx_rs_thresh to an aggresive tx_free_thresh.
2. queue setup fail when tx_free_thresh + tx_rs_thresh > nb_desc

Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: sta...@dpdk.org

Signed-off-by: Qi Zhang 
---
 drivers/net/ice/ice_rxtx.c | 21 ++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ace766b1d..620a5ea2b 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -764,17 +764,32 @@ ice_tx_queue_setup(struct rte_eth_dev *dev,
 *  - tx_rs_thresh must be a divisor of the ring size.
 *  - tx_free_thresh must be greater than 0.
 *  - tx_free_thresh must be less than the size of the ring minus 3.
+*  - tx_free_thresh + tx_rs_thresh must not exceed nb_desc.
 *
 * One descriptor in the TX ring is used as a sentinel to avoid a H/W
 * race condition, hence the maximum threshold constraints. When set
 * to zero use default values.
 */
-   tx_rs_thresh = (uint16_t)(tx_conf->tx_rs_thresh ?
- tx_conf->tx_rs_thresh :
- ICE_DEFAULT_TX_RSBIT_THRESH);
tx_free_thresh = (uint16_t)(tx_conf->tx_free_thresh ?
tx_conf->tx_free_thresh :
ICE_DEFAULT_TX_FREE_THRESH);
+   /* force tx_rs_thresh to adapt an aggresive tx_free_thresh */
+   tx_rs_thresh =
+   (ICE_DEFAULT_TX_RSBIT_THRESH + tx_free_thresh > nb_desc) ?
+   nb_desc - tx_free_thresh : ICE_DEFAULT_TX_RSBIT_THRESH;
+   if (tx_conf->tx_rs_thresh)
+   tx_rs_thresh = tx_conf->tx_rs_thresh;
+   if (tx_rs_thresh + tx_free_thresh > nb_desc) {
+   PMD_INIT_LOG(ERR, "tx_rs_thresh + tx_free_thresh must not "
+   "exceed nb_desc. (tx_rs_thresh=%u "
+   "tx_free_thresh=%u nb_desc=%u port = %d 
queue=%d)",
+   (unsigned int)tx_rs_thresh,
+   (unsigned int)tx_free_thresh,
+   (unsigned int)nb_desc,
+   (int)dev->data->port_id,
+   (int)queue_idx);
+   return -EINVAL;
+   }
if (tx_rs_thresh >= (nb_desc - 2)) {
PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than the "
 "number of TX descriptors minus 2. "
-- 
2.13.6

[dpdk-dev] [PATCH] net/ice: set min and max MTU

[Qi Zhang]

This commit sets the min and max supported MTU values for ice devices
via the i40e_dev_info_get() function. Min MTU supported is set to
ETHER_MIN_MTU and max mtu is calculated as the max packet length
supported minus the transport overhead.

Signed-off-by: Qi Zhang 
---
 drivers/net/ice/ice_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..9f5f919f4 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1994,6 +1994,8 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
dev_info->max_tx_queues = vsi->nb_qps;
dev_info->max_mac_addrs = vsi->max_macaddrs;
dev_info->max_vfs = pci_dev->max_vfs;
+   dev_info->max_mtu = dev_info->max_rx_pktlen - ICE_ETH_OVERHEAD;
+   dev_info->min_mtu = ETHER_MIN_MTU;
 
dev_info->rx_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
-- 
2.13.6

[dpdk-dev] [PATCH] net/iavf: enable more link speed

[Qi Zhang]

Enable advanced link speed mode (VIRTCHNL_VF_CAP_ADV_LINK_SPEED) so iavf
PMD can identify more link speed that reported by pf.

Cc: sta...@dpdk.org

Signed-off-by: Qi Zhang 
---
 drivers/net/iavf/base/virtchnl.h | 17 -
 drivers/net/iavf/iavf.h  |  2 +-
 drivers/net/iavf/iavf_ethdev.c   | 21 +++--
 drivers/net/iavf/iavf_vchnl.c|  4 ++--
 4 files changed, 34 insertions(+), 10 deletions(-)

diff --git a/drivers/net/iavf/base/virtchnl.h b/drivers/net/iavf/base/virtchnl.h
index 13bfdb86b..10b65380c 100644
--- a/drivers/net/iavf/base/virtchnl.h
+++ b/drivers/net/iavf/base/virtchnl.h
@@ -258,6 +258,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);
 #define VIRTCHNL_VF_OFFLOAD_ENCAP  0X0010
 #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X0020
 #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM  0X0040
+/* Define below the capability flags that are not offloads */
+#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED  0x0080
 
 #define VF_BASE_MODE_OFFLOADS (VIRTCHNL_VF_OFFLOAD_L2 | \
   VIRTCHNL_VF_OFFLOAD_VLAN | \
@@ -562,10 +564,23 @@ enum virtchnl_event_codes {
 struct virtchnl_pf_event {
enum virtchnl_event_codes event;
union {
+   /* If the PF driver does not support the new speed reporting
+* capabilities then use link_event else use link_event_adv to
+* get the speed and link information. The ability to understand
+* new speeds is indicated by setting the capability flag
+* VIRTCHNL_VF_CAP_ADV_LINK_SPEED in vf_cap_flags parameter
+* in virtchnl_vf_resource struct and can be used to determine
+* which link event struct to use below.
+*/
struct {
enum virtchnl_link_speed link_speed;
-   bool link_status;
+   u8 link_status;
} link_event;
+   struct {
+   /* link_speed provided in Mbps */
+   u32 link_speed;
+   u8 link_status;
+   } link_event_adv;
} event_data;
 
int severity;
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index e6e3e8d30..9a334e41c 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -95,7 +95,7 @@ struct iavf_info {
/* Event from pf */
bool dev_closed;
bool link_up;
-   enum virtchnl_link_speed link_speed;
+   uint32_t link_speed;
 
struct iavf_vsi vsi;
bool vf_reset;
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 7a0696ed7..bd9c5ecdf 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -584,24 +584,33 @@ iavf_dev_link_update(struct rte_eth_dev *dev,
 *  when receive LINK_CHANGE evnet from PF by Virtchnnl.
 */
switch (vf->link_speed) {
-   case VIRTCHNL_LINK_SPEED_100MB:
+   case 10:
+   new_link.link_speed = ETH_SPEED_NUM_10M;
+   break;
+   case 100:
new_link.link_speed = ETH_SPEED_NUM_100M;
break;
-   case VIRTCHNL_LINK_SPEED_1GB:
+   case 1000:
new_link.link_speed = ETH_SPEED_NUM_1G;
break;
-   case VIRTCHNL_LINK_SPEED_10GB:
+   case 1:
new_link.link_speed = ETH_SPEED_NUM_10G;
break;
-   case VIRTCHNL_LINK_SPEED_20GB:
+   case 2:
new_link.link_speed = ETH_SPEED_NUM_20G;
break;
-   case VIRTCHNL_LINK_SPEED_25GB:
+   case 25000:
new_link.link_speed = ETH_SPEED_NUM_25G;
break;
-   case VIRTCHNL_LINK_SPEED_40GB:
+   case 4:
new_link.link_speed = ETH_SPEED_NUM_40G;
break;
+   case 5:
+   new_link.link_speed = ETH_SPEED_NUM_50G;
+   break;
+   case 10:
+   new_link.link_speed = ETH_SPEED_NUM_100G;
+   break;
default:
new_link.link_speed = ETH_SPEED_NUM_NONE;
break;
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 6381fb63c..da6401d35 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -153,7 +153,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev, uint8_t 
*msg,
case VIRTCHNL_EVENT_LINK_CHANGE:
PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE event");
vf->link_up = pf_msg->event_data.link_event.link_status;
-   vf->link_speed = pf_msg->event_data.link_event.link_speed;
+   vf->link_speed = pf_msg->event_data.link_event_adv.link_speed;
iavf_dev_link_update(dev, 0);
_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC,
 

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

[Liron Himi]

+1

Regards,
Liron

-Original Message-
From: Trahe, Fiona  
Sent: Friday, May 3, 2019 9:10 PM
To: Doherty, Declan ; ravi1.ku...@amd.com; 
t...@semihalf.com; Liron Himi ; Alan Winkowski 

Cc: De Lara Guarch, Pablo ; dev@dpdk.org; 
Kusztal, ArkadiuszX ; Anoob Joseph 
; Shally Verma ; akhil.go...@nxp.com; 
Trahe, Fiona 
Subject: [EXT] RE: [PATCH] doc: add cryptodev gcm iv deprecation notice

External Email

--
Forwarding to maintainers of the following crypto PMDs which may be affected by 
this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack 
please - 3 acks are needed

This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/


> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph ; shal...@marvell.com
> Cc: Trahe, Fiona ; De Lara Guarch, Pablo 
> ; dev@dpdk.org; Kusztal, ArkadiuszX 
> 
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
> 
> Hi Anoob/Shally,
> 
> Could you please review this patch and provide Ack.
> 
> Thanks,
> Akhil
> 
> 
> >
> >
> > This patch adds deprecation notice of changing iv behaviour when 
> > using Galois Counter Mode of operation. Right now IV of all 
> > supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal 
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 6 ++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> >  * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the 
> > xforms
> >structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> >``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still 
> > +can
> > +  be used but only when IV length in following structs 
> > +``rte_crypto_auth_xform``,
> > +  ``rte_crypto_aead_xform`` is set to zero. When IV length is 
> > +greater or equal
> > +  to one it means it represents IV, when is set to zero it means J0 
> > +is used
> > +  directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0

Re: [dpdk-dev] [PATCH v2] cryptodev: add an option to support both iv and J0 for GCM

[Anoob Joseph]

> -Original Message-
> From: dev  On Behalf Of Arek Kusztal
> Sent: Wednesday, April 17, 2019 9:28 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com;
> pablo.de.lara.gua...@intel.com; Arek Kusztal 
> Subject: [dpdk-dev] [PATCH v2] cryptodev: add an option to support both iv and
> J0 for GCM
> 
> This patch adds an option to support both IV (of all supported sizes) and J0 
> when
> using Galois Counter Mode of crypto operation.
> 
> Signed-off-by: Arek Kusztal 
Acked-by: Anoob Joseph 

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

[Thomas Monjalon]

02/05/2019 22:27, Thomas Monjalon:
> 02/05/2019 20:31, Ferruh Yigit:
> > On 4/29/2019 10:52 AM, Thomas Monjalon wrote:
> > > 25/04/2019 17:27, Ferruh Yigit:
> > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote:
> > >>> 25/04/2019 13:47, Ferruh Yigit:
> >  On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
> > > 25/04/2019 00:03, Ferruh Yigit:
> > >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
> > >>
> > >> Not all PMDs support the fixed link speed set, and link speed can be 
> > >> set
> > >> even with auto negotiation enabled. Reverting the patch to not break
> > >> existing usage.
> > >
> > > Which PMDs do not support this flag?
> > > Why not fixing the PMDs?
> > >
> > 
> >  At least ixgbe and i40e is not supporting setting a fixed speed.
> >  But I am not sure if this is something to fix, the command in testpmd 
> >  is to set
> >  the link speed, what is the problem with setting the link speed without
> >  disabling the auto-negotiation?
> > >>>
> > >>> It means it will negotiate with only one speed proposed.
> > >>
> > >> Yes.
> > >>
> > >>> The real issue is to not support the fixed flag.
> > >>
> > >> I don't know if this is a real issue but
> > >> even it is, is it an issue in the scope of this testpmd command?
> > >>
> > >> right now we are first updating the command to set fixed speed flag, and
> > >> requesting PMDs to fix for it, I am suggesting not to update the command 
> > >> at all.
> > > 
> > > I understand. But this change shows a broken behaviour.
> > > This is the intent of testpmd to show what works or not in PMDs.
> > > How hard is it to fix the PMDs in your opinion?
> > > 
> > 
> > As far as I can see the the fixed link speed set is not supported in the 
> > PMD.
> > 
> > It may be easy to add perhaps, I don't know, but is it really a "broken
> > behavior" to not have this support?
> > What defines that setting speed has to be "fixed speed", if this demand is 
> > not
> > there, should testpmd enforce it?
> 
> I think a PMD should support both: fixed or not.
> 
> > In mail thread we have talked that this testpmd command can get an extra
> > argument to define the speed fixed or not, this can be used to test fixed 
> > speed
> > by who wants to test/use fixed speed.
> > 
> > I am for reverting this for the release, and adding a new version next 
> > release
> > with fixed speed argument, otherwise testpmd won't be used to set the speed 
> > for
> > some PMDs.
> 
> OK

We could have an option in testpmd to test ETH_LINK_SPEED_FIXED.

Revert applied.

Re: [dpdk-dev] [PATCH v3] app/test: replace TEST_SKIPPED with -ENOTSUP

[Thomas Monjalon]

24/04/2019 21:28, Ayuj Verma:
> - Return -ENOTSUP for unsupported tests

Sorry if you already explained it before,
please could you add the reason for this change
in the commit log?

Re: [dpdk-dev] [dpdk-stable] [PATCH] test: clean remaining trace of removed devargs ut

[Thomas Monjalon]

30/04/2019 12:15, Gaëtan Rivet:
> Hello David,
> 
> On Mon, Apr 29, 2019 at 04:32:45PM +0200, David Marchand wrote:
> > This test has been removed by the commit 83945fbd7c49 ("test: remove
> > devargs unit tests") which left some trace in meson and reintroduced in
> > autotest by the second commit 9eabcb682493 ("test: update autotest
> > list").
> > 
> > Fixes: 83945fbd7c49 ("test: remove devargs unit tests")
> > Fixes: 9eabcb682493 ("test: update autotest list")
> > Cc: sta...@dpdk.org
> > 
> > Signed-off-by: David Marchand 
> 
> AFAICS, those are the only remaining references to the devargs autotest,
> 
> Acked-by: Gaetan Rivet 

Applied, thanks

Re: [dpdk-dev] [PATCH] test: load tests symbols from binary at init

[Thomas Monjalon]

29/04/2019 16:41, Burakov, Anatoly:
> On 29-Apr-19 3:28 PM, David Marchand wrote:
> > Rather than call nm on the test application binary for each test to
> > consider, call it once at the object init.
> > 
> > Signed-off-by: David Marchand 
> 
> LGTM
> 
> Acked-by: Anatoly Burakov 

Applied, thanks

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

[Thomas Monjalon]

Hi,

03/05/2019 07:48, Suanming. Mou:
> When primary app exits, the residual running pdump will stop the
> primary app to restart. Add pdump exits with primary support.

Sorry I fail to parse this sentence.
Maybe it should be longer to be more explicit about
what it the current issue and how it is solved.
Some comments in the code may also be improved.

> Signed-off-by: Suanming.Mou 

I think you should remove the dot in your name.

> Reviewed-by: Anatoly Burakov 
> Reviewed-by: Vipin Varghese 
> ---
> V8:
> * reword the print info in monitor_primary.
> * add release_19_05.rst update.

As it is not a fix, it will slip in 19.08.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] doc: update references to removed function

[Thomas Monjalon]

> > Remove references to the (deleted) rte_event_port_enqueue_depth() function
> > in the Doxygen comments for rte_event_enqueue_burst() and friends, and
> > replace with references to rte_event_port_attr_get().
> > 
> > Fixes: 78ffab961155 ("eventdev: add port attribute function")
> > Fixes: c9bf83947e2e ("eventdev: add eth Tx adapter APIs")
> > Cc: sta...@dpdk.org
> > 
> > Signed-off-by: Erik Gabriel Carrillo 
> > Acked-by: Jerin Jacob 
> 
> 
> Please mark the previous version as superseded in patchwork.
> 
> Acked-by: John McNamara 

Applied, thanks

Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity

[Thomas Monjalon]

> > rte_hash_hash is multi-thread safe but not multi-process safe because of
> > the use of function pointers. Previous document and comment says the other
> > way around. This commit fixes the issue.
> 
> Acked-by: John McNamara 

Applied, thanks

Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references

[Thomas Monjalon]

01/05/2019 16:12, Mcnamara, John:
> From: Lipiec, Herakliusz
> > 
> > Bugzilla ID: 235
> 
> The fix is good and should be applied.
> 
> However, if viewed strictly, that `Link text `_ syntax is only 
> required if the link text and the url are different.
> 
> So in this case you could (or the original author) just use a simple url 
> without any additional syntax.
> 
> However, better still would be if we did something like this to put the links 
> inline in the text:

Yes, that would be good to do this kind of cleanup in the guides.

[...]
> However, the fix is better than a broken link so:
> 
> Acked-by: John McNamara 

Applied, thanks

Re: [dpdk-dev] [PATCH] doc: update release notes for new armv8 targets

[Thomas Monjalon]

> > From: Jerin Jacob 
> > 
> > Added documentation for the new armv8 targets supported in 19.05 release.
> 
> Acked-by: John McNamara 

Changed the formatting and applied, thanks.

Re: [dpdk-dev] [PATCH v2] doc: update release notes for windows support

[Thomas Monjalon]

23/04/2019 20:12, Pallavi Kadam:
> Added documentation for Windows support on 19.05 release.
> 
> Signed-off-by: Pallavi Kadam 
> Reviewed-by: Anand Rawat 
> Reviewed-by: Ranjit Menon 
> ---
> +* **Added Windows Support.**
> +
> +  Added Windows support to compile and build Hello World Sample Application.

Applied with following changes:

* **Introduced Windows Support.**

  Added Windows support to build Hello World sample application.

Re: [dpdk-dev] [PATCH v8 0/2] guide to debug and troubleshoot.

[Thomas Monjalon]

09/04/2019 08:33, Vipin Varghese:
> The patch series adds a how-to guide for debugging and
> troubleshooting tips.
> 
> Motivation
> ==
> 
> DPDK proc-info tool is been enhanced to accommodate the debug information
> for the port, traffic manager crypto, ring and mempool contents. With these
> additional information, it becomes easy to analyze issues and performance
> variance.
> 
> But applications are designed based on the target platform, workload, poll
> mode drivers, and multi-process. This raises variance in debugging and
> collecting data. Hence attempt of patch series is identified such symptoms
> and share step by step guide to cover the cases.
> 
> Not all possible cases could be covered in a single attempt. But with
> feedback and support from the community, this can be expanded.

I removed _guide at the end of the filename,
and applied, thanks.

[dpdk-dev] [dpdk-announce] release candidate 19.05-rc3

[Thomas Monjalon]

A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v19.05-rc3

The release notes are almost complete:
http://doc.dpdk.org/guides/rel_notes/release_19_05.html

Please hurry up to do the last checks and bug fixes this week,
in order to have DPDK 19.05 out at the end of the week.
You may share some release validation results
by replying to this message (at dev@dpdk.org).

In order to prepare the next cycle, the deprecation notices
must be reviewed, and the roadmap topics proposed on the mailing list.

May the fourth be with DPDK 19.05 :-)

Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

[Suanming . Mou]

On 2019/5/5 5:17, Thomas Monjalon wrote:

Hi,

03/05/2019 07:48, Suanming. Mou:

When primary app exits, the residual running pdump will stop the
primary app to restart. Add pdump exits with primary support.

Sorry I fail to parse this sentence.
Maybe it should be longer to be more explicit about
what it the current issue and how it is solved.

Thanks for the suggestion. It's fine to add more contents.

Some comments in the code may also be improved.


Could you please help to show the detail? Or it will be hard to do the 
improvement.


` There are a thousand Hamlets in a thousand people's eyes.`




Signed-off-by: Suanming.Mou 

I think you should remove the dot in your name.


Sorry for that, maybe I missed some important instructions which notes 
the dot.


I will remove it later.




Reviewed-by: Anatoly Burakov 
Reviewed-by: Vipin Varghese 
---
V8:
* reword the print info in monitor_primary.
* add release_19_05.rst update.

As it is not a fix, it will slip in 19.08.


It seems 19.08 is still not started yet.

Does that mean the patch should be hung till 19.08 be started?

Re: [dpdk-dev] [PATCH] net/iavf: enable more link speed

[Zhao1, Wei]

Acked-by: Wei Zhao 


> -Original Message-
> From: Zhang, Qi Z
> Sent: Saturday, May 4, 2019 10:09 PM
> To: Lu, Wenzhuo ; Zhao1, Wei 
> Cc: Stillwell Jr, Paul M ; dev@dpdk.org; Zhang,
> Qi Z ; sta...@dpdk.org
> Subject: [PATCH] net/iavf: enable more link speed
> 
> Enable advanced link speed mode (VIRTCHNL_VF_CAP_ADV_LINK_SPEED) so
> iavf PMD can identify more link speed that reported by pf.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Qi Zhang 
> ---
>  drivers/net/iavf/base/virtchnl.h | 17 -
>  drivers/net/iavf/iavf.h  |  2 +-
>  drivers/net/iavf/iavf_ethdev.c   | 21 +++--
>  drivers/net/iavf/iavf_vchnl.c|  4 ++--
>  4 files changed, 34 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/iavf/base/virtchnl.h 
> b/drivers/net/iavf/base/virtchnl.h
> index 13bfdb86b..10b65380c 100644
> --- a/drivers/net/iavf/base/virtchnl.h
> +++ b/drivers/net/iavf/base/virtchnl.h
> @@ -258,6 +258,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16,
> virtchnl_vsi_resource);
>  #define VIRTCHNL_VF_OFFLOAD_ENCAP0X0010
>  #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM   0X0020
>  #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM0X0040
> +/* Define below the capability flags that are not offloads */
> +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED  0x0080
> 
>  #define VF_BASE_MODE_OFFLOADS (VIRTCHNL_VF_OFFLOAD_L2 | \
>  VIRTCHNL_VF_OFFLOAD_VLAN | \
> @@ -562,10 +564,23 @@ enum virtchnl_event_codes {  struct
> virtchnl_pf_event {
>   enum virtchnl_event_codes event;
>   union {
> + /* If the PF driver does not support the new speed reporting
> +  * capabilities then use link_event else use link_event_adv to
> +  * get the speed and link information. The ability to understand
> +  * new speeds is indicated by setting the capability flag
> +  * VIRTCHNL_VF_CAP_ADV_LINK_SPEED in vf_cap_flags
> parameter
> +  * in virtchnl_vf_resource struct and can be used to determine
> +  * which link event struct to use below.
> +  */
>   struct {
>   enum virtchnl_link_speed link_speed;
> - bool link_status;
> + u8 link_status;
>   } link_event;
> + struct {
> + /* link_speed provided in Mbps */
> + u32 link_speed;
> + u8 link_status;
> + } link_event_adv;
>   } event_data;
> 
>   int severity;
> diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index
> e6e3e8d30..9a334e41c 100644
> --- a/drivers/net/iavf/iavf.h
> +++ b/drivers/net/iavf/iavf.h
> @@ -95,7 +95,7 @@ struct iavf_info {
>   /* Event from pf */
>   bool dev_closed;
>   bool link_up;
> - enum virtchnl_link_speed link_speed;
> + uint32_t link_speed;
> 
>   struct iavf_vsi vsi;
>   bool vf_reset;
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c 
> index
> 7a0696ed7..bd9c5ecdf 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -584,24 +584,33 @@ iavf_dev_link_update(struct rte_eth_dev *dev,
>*  when receive LINK_CHANGE evnet from PF by Virtchnnl.
>*/
>   switch (vf->link_speed) {
> - case VIRTCHNL_LINK_SPEED_100MB:
> + case 10:
> + new_link.link_speed = ETH_SPEED_NUM_10M;
> + break;
> + case 100:
>   new_link.link_speed = ETH_SPEED_NUM_100M;
>   break;
> - case VIRTCHNL_LINK_SPEED_1GB:
> + case 1000:
>   new_link.link_speed = ETH_SPEED_NUM_1G;
>   break;
> - case VIRTCHNL_LINK_SPEED_10GB:
> + case 1:
>   new_link.link_speed = ETH_SPEED_NUM_10G;
>   break;
> - case VIRTCHNL_LINK_SPEED_20GB:
> + case 2:
>   new_link.link_speed = ETH_SPEED_NUM_20G;
>   break;
> - case VIRTCHNL_LINK_SPEED_25GB:
> + case 25000:
>   new_link.link_speed = ETH_SPEED_NUM_25G;
>   break;
> - case VIRTCHNL_LINK_SPEED_40GB:
> + case 4:
>   new_link.link_speed = ETH_SPEED_NUM_40G;
>   break;
> + case 5:
> + new_link.link_speed = ETH_SPEED_NUM_50G;
> + break;
> + case 10:
> + new_link.link_speed = ETH_SPEED_NUM_100G;
> + break;
>   default:
>   new_link.link_speed = ETH_SPEED_NUM_NONE;
>   break;
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c 
> index
> 6381fb63c..da6401d35 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -153,7 +153,7 @@ iavf_handle_pf_event_msg(struct rte_eth_dev *dev,
> uint8_t *msg,
>   case VIRTCHNL_EVENT_LINK_CHANGE:
>   PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE
> event");
> 

[dpdk-dev] [PATCH] net/i40e: add new device id for X710/XXV710 of IPN3KE

[Rosen Xu]

New pci device ids are created to support X710/XXV710 of Intel FPGA
Programmable Acceleration card N3000, also called ipn3ke.

Signed-off-by: Rosen Xu 
---
 drivers/net/i40e/base/i40e_common.c | 2 ++
 drivers/net/i40e/base/i40e_devids.h | 2 ++
 drivers/net/i40e/i40e_ethdev.c  | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/drivers/net/i40e/base/i40e_common.c 
b/drivers/net/i40e/base/i40e_common.c
index 8a98aff..fc1ac66 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -42,6 +42,8 @@ STATIC enum i40e_status_code i40e_set_mac_type(struct i40e_hw 
*hw)
case I40E_DEV_ID_20G_KR2_A:
case I40E_DEV_ID_25G_B:
case I40E_DEV_ID_25G_SFP28:
+   case I40E_DEV_ID_X710_N3000:
+   case I40E_DEV_ID_XXV710_N3000:
hw->mac.type = I40E_MAC_XL710;
break;
 #ifdef X722_A0_SUPPORT
diff --git a/drivers/net/i40e/base/i40e_devids.h 
b/drivers/net/i40e/base/i40e_devids.h
index 8b667c2..ab3f33b 100644
--- a/drivers/net/i40e/base/i40e_devids.h
+++ b/drivers/net/i40e/base/i40e_devids.h
@@ -22,6 +22,8 @@
 #define I40E_DEV_ID_10G_BASE_T40x1589
 #define I40E_DEV_ID_25G_B  0x158A
 #define I40E_DEV_ID_25G_SFP28  0x158B
+#define I40E_DEV_ID_X710_N3000  0x0CF8
+#define I40E_DEV_ID_XXV710_N3000   0x0D58
 #ifdef CARLSVILLE_HW
 #define I40E_DEV_ID_10G_BASE_T_BC  0x15FF
 #endif
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 2eea523..cab440f 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -433,6 +433,8 @@ static int i40e_sw_tunnel_filter_insert(struct i40e_pf *pf,
{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_1G_BASE_T_X722) },
{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_10G_BASE_T_X722) },
{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_I_X722) },
+   { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_X710_N3000) },
+   { RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_XXV710_N3000) },
{ .vendor_id = 0, /* sentinel */ },
 };
 
-- 
1.8.3.1

[dpdk-dev] [PATCH] net/ice: minor code cleanups

[Xiao Wang]

This patch is a cleanup on comment, variable modifier, coding style.

Signed-off-by: Xiao Wang 
---
 drivers/net/ice/ice_ethdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1f06a2c80..706632424 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1587,7 +1587,7 @@ ice_dev_uninit(struct rte_eth_dev *dev)
/* disable uio intr before callback unregister */
rte_intr_disable(intr_handle);
 
-   /* register callback func to eal lib */
+   /* unregister callback func from eal lib */
rte_intr_callback_unregister(intr_handle,
 ice_interrupt_handler, dev);
 
@@ -2125,7 +2125,7 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
 }
 
 static int
-ice_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 {
 #define CHECK_INTERVAL 100  /* 100ms */
 #define MAX_REPEAT_TIME 10  /* 1s (10 * 100ms) in total */
@@ -2502,7 +2502,7 @@ ice_vlan_tpid_set(struct rte_eth_dev *dev,
reg_id = 3;
else
reg_id = 5;
-   break;
+   break;
case ETH_VLAN_TYPE_INNER:
if (qinq) {
reg_id = 5;
-- 
2.15.1

[dpdk-dev] [PATCH] net/ice: fix EEPROM range check

[Xiao Wang]

The last word should not cross shadow RAM boundary.

Fixes: 68a1ab82ad74 ("net/ice: speed up to retrieve EEPROM")
Cc: sta...@dpdk.org

Signed-off-by: Xiao Wang 
---
 drivers/net/ice/ice_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 706632424..3d2f35bb0 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3002,8 +3002,8 @@ ice_get_eeprom(struct rte_eth_dev *dev,
last_word = (eeprom->offset + eeprom->length - 1) >> 1;
nwords = last_word - first_word + 1;
 
-   if (first_word > hw->nvm.sr_words ||
-   last_word > hw->nvm.sr_words) {
+   if (first_word >= hw->nvm.sr_words ||
+   last_word >= hw->nvm.sr_words) {
PMD_DRV_LOG(ERR, "Requested EEPROM bytes out of range.");
return -EINVAL;
}
-- 
2.15.1