Re: [dpdk-dev] [PATCH v4 2/5] meson: add infra to support machine specific flags

[Phil Yang (Arm Technology China)]

Hi Pavan,

> -Original Message-
> From: dev  On Behalf Of Pavan Nikhilesh Bhagavatula
> Sent: Wednesday, January 9, 2019 6:40 PM
> To: jer...@marvell.com; Gavin Hu (Arm Technology China)
> ; bruce.richard...@intel.com; tho...@monjalon.net
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula 
> Subject: [dpdk-dev] [PATCH v4 2/5] meson: add infra to support machine 
> specific
> flags
> 
> From: Pavan Nikhilesh 
> 
> Currently, RTE_* flags are set based on the implementer ID but there might be
> some micro arch specific differences from the same vendor eg. CACHE_LINESIZE.
> Add support to set micro arch specific flags.
> 
> Signed-off-by: Jerin Jacob 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  config/arm/meson.build | 53 +-
>  1 file changed, 32 insertions(+), 21 deletions(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> dae55d6b2..576363fc0 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -7,23 +7,6 @@ march_opt = '-march=@0@'.format(machine)
> 
>  arm_force_native_march = false
> 
> -machine_args_generic = [
> - ['default', ['-march=armv8-a+crc+crypto']],
> - ['native', ['-march=native']],
> - ['0xd03', ['-mcpu=cortex-a53']],
> - ['0xd04', ['-mcpu=cortex-a35']],
> - ['0xd07', ['-mcpu=cortex-a57']],
> - ['0xd08', ['-mcpu=cortex-a72']],
> - ['0xd09', ['-mcpu=cortex-a73']],
> - ['0xd0a', ['-mcpu=cortex-a75']],
> -]
> -machine_args_cavium = [
> - ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
> - ['native', ['-march=native']],
> - ['0xa1', ['-mcpu=thunderxt88']],
> - ['0xa2', ['-mcpu=thunderxt81']],
> - ['0xa3', ['-mcpu=thunderxt83']]]
> -
>  flags_common_default = [
>   # Accelarate rte_memcpy. Be sure to run unit test
> (memcpy_perf_autotest)
>   # to determine the best threshold in code. Refer to notes in source file
> @@ -50,12 +33,10 @@ flags_generic = [
>   ['RTE_USE_C11_MEM_MODEL', true],
>   ['RTE_CACHE_LINE_SIZE', 128]]
>  flags_cavium = [
> - ['RTE_MACHINE', '"thunderx"'],
>   ['RTE_CACHE_LINE_SIZE', 128],
>   ['RTE_MAX_NUMA_NODES', 2],
>   ['RTE_MAX_LCORE', 96],
> - ['RTE_MAX_VFIO_GROUPS', 128],
> - ['RTE_USE_C11_MEM_MODEL', false]]
> + ['RTE_MAX_VFIO_GROUPS', 128]]
>  flags_dpaa = [
>   ['RTE_MACHINE', '"dpaa"'],
>   ['RTE_USE_C11_MEM_MODEL', true],
> @@ -69,6 +50,27 @@ flags_dpaa2 = [
>   ['RTE_MAX_NUMA_NODES', 1],
>   ['RTE_MAX_LCORE', 16],
>   ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
> +flags_default_extra = []
> +flags_thunderx_extra = [
> + ['RTE_MACHINE', '"thunderx"'],
> + ['RTE_USE_C11_MEM_MODEL', false]]
> +
> +machine_args_generic = [
> + ['default', ['-march=armv8-a+crc+crypto']],
> + ['native', ['-march=native']],
> + ['0xd03', ['-mcpu=cortex-a53']],
> + ['0xd04', ['-mcpu=cortex-a35']],
> + ['0xd07', ['-mcpu=cortex-a57']],
> + ['0xd08', ['-mcpu=cortex-a72']],
> + ['0xd09', ['-mcpu=cortex-a73']],
> + ['0xd0a', ['-mcpu=cortex-a75']]]
> +
> +machine_args_cavium = [
> + ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
> + ['native', ['-march=native']],
> + ['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],
> + ['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],
> + ['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra]]
> 
>  ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)
> impl_generic = ['Generic armv8', flags_generic, machine_args_generic] @@ -
> 157,10 +159,19 @@ else
>   foreach marg: machine[2]
>   if marg[0] == impl_pn
>   foreach f: marg[1]
> - machine_args += f
> + if cc.has_argument(f)
> + machine_args += f
> + endif
>   endforeach
>   endif
>   endforeach
> +
> + # Apply any extra machine specific flags.
> + foreach flag: marg.get(2, flags_default_extra)
> + if flag.length() > 0
> + dpdk_conf.set(flag[0], flag[1])
> + endif
> + endforeach

I think this loop should put inside the 'if marg[0] == impl_pn' condition.
The right logic should be:
If marg[0] == impl_pn
# update machine_args
# Apply any extra machine specific flags
endif

I tested this patch on thunderx2, but it set the octeontx2 extra flags into the 
rte_build_config.h. Because octeontx2 is the last item of 'machine_args_cavium' 
table.

>  endif
>  message(machine_args)
> 
> --
> 2.20.1

Thanks,
Phil Yang.

Re: [dpdk-dev] [EXT] RE: [PATCH v4 2/5] meson: add infra to support machine specific flags

[Pavan Nikhilesh Bhagavatula]

Hi Phil,

On Tue, 2019-02-12 at 08:06 +, Phil Yang (Arm Technology China)
wrote:
> External Email
> 
> ---
> ---
> Hi Pavan,
> 
> > -Original Message-
> > From: dev  On Behalf Of Pavan Nikhilesh
> > Bhagavatula
> > Sent: Wednesday, January 9, 2019 6:40 PM
> > To: jer...@marvell.com; Gavin Hu (Arm Technology China)
> > ; bruce.richard...@intel.com; tho...@monjalon.net
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <
> > pbhagavat...@marvell.com>
> > Subject: [dpdk-dev] [PATCH v4 2/5] meson: add infra to support
> > machine specific
> > flags
> > 
> > From: Pavan Nikhilesh 
> > 
> > Currently, RTE_* flags are set based on the implementer ID but
> > there might be
> > some micro arch specific differences from the same vendor eg.
> > CACHE_LINESIZE.
> > Add support to set micro arch specific flags.
> > 
> > Signed-off-by: Jerin Jacob 
> > Signed-off-by: Pavan Nikhilesh 
> > ---
> >  config/arm/meson.build | 53 +-
> > 
> >  1 file changed, 32 insertions(+), 21 deletions(-)
> > 
> > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > dae55d6b2..576363fc0 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -7,23 +7,6 @@ march_opt = '-march=@0@'.format(machine)
> > 
> >  arm_force_native_march = false
> > 
> > -machine_args_generic = [
> > -   ['default', ['-march=armv8-a+crc+crypto']],
> > -   ['native', ['-march=native']],
> > -   ['0xd03', ['-mcpu=cortex-a53']],
> > -   ['0xd04', ['-mcpu=cortex-a35']],
> > -   ['0xd07', ['-mcpu=cortex-a57']],
> > -   ['0xd08', ['-mcpu=cortex-a72']],
> > -   ['0xd09', ['-mcpu=cortex-a73']],
> > -   ['0xd0a', ['-mcpu=cortex-a75']],
> > -]
> > -machine_args_cavium = [
> > -   ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
> > -   ['native', ['-march=native']],
> > -   ['0xa1', ['-mcpu=thunderxt88']],
> > -   ['0xa2', ['-mcpu=thunderxt81']],
> > -   ['0xa3', ['-mcpu=thunderxt83']]]
> > -
> >  flags_common_default = [
> > # Accelarate rte_memcpy. Be sure to run unit test
> > (memcpy_perf_autotest)
> > # to determine the best threshold in code. Refer to notes in
> > source file
> > @@ -50,12 +33,10 @@ flags_generic = [
> > ['RTE_USE_C11_MEM_MODEL', true],
> > ['RTE_CACHE_LINE_SIZE', 128]]
> >  flags_cavium = [
> > -   ['RTE_MACHINE', '"thunderx"'],
> > ['RTE_CACHE_LINE_SIZE', 128],
> > ['RTE_MAX_NUMA_NODES', 2],
> > ['RTE_MAX_LCORE', 96],
> > -   ['RTE_MAX_VFIO_GROUPS', 128],
> > -   ['RTE_USE_C11_MEM_MODEL', false]]
> > +   ['RTE_MAX_VFIO_GROUPS', 128]]
> >  flags_dpaa = [
> > ['RTE_MACHINE', '"dpaa"'],
> > ['RTE_USE_C11_MEM_MODEL', true],
> > @@ -69,6 +50,27 @@ flags_dpaa2 = [
> > ['RTE_MAX_NUMA_NODES', 1],
> > ['RTE_MAX_LCORE', 16],
> > ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]
> > +flags_default_extra = []
> > +flags_thunderx_extra = [
> > +   ['RTE_MACHINE', '"thunderx"'],
> > +   ['RTE_USE_C11_MEM_MODEL', false]]
> > +
> > +machine_args_generic = [
> > +   ['default', ['-march=armv8-a+crc+crypto']],
> > +   ['native', ['-march=native']],
> > +   ['0xd03', ['-mcpu=cortex-a53']],
> > +   ['0xd04', ['-mcpu=cortex-a35']],
> > +   ['0xd07', ['-mcpu=cortex-a57']],
> > +   ['0xd08', ['-mcpu=cortex-a72']],
> > +   ['0xd09', ['-mcpu=cortex-a73']],
> > +   ['0xd0a', ['-mcpu=cortex-a75']]]
> > +
> > +machine_args_cavium = [
> > +   ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
> > +   ['native', ['-march=native']],
> > +   ['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],
> > +   ['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],
> > +   ['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra]]
> > 
> >  ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-
> > 5321)
> > impl_generic = ['Generic armv8', flags_generic,
> > machine_args_generic] @@ -
> > 157,10 +159,19 @@ else
> > foreach marg: machine[2]
> > if marg[0] == impl_pn
> > foreach f: marg[1]
> > -   machine_args += f
> > +   if cc.has_argument(f)
> > +   machine_args += f
> > +   endif
> > endforeach
> > endif
> > endforeach
> > +
> > +   # Apply any extra machine specific flags.
> > +   foreach flag: marg.get(2, flags_default_extra)
> > +   if flag.length() > 0
> > +   dpdk_conf.set(flag[0], flag[1])
> > +   endif
> > +   endforeach
> 
> I think this loop should put inside the 'if marg[0] == impl_pn'
> condition.
> The right logic should be:
> If marg[0] == impl_pn
>   # update machine_args
>   # Apply any extra machine specific flags
> endif

Yes, you are correct I will modify this in the next version.

Thanks,
Pavan.
> 
> I tested this patch on thunderx2, but it set the octeontx2 extra
> flags into the rte_build_config.h. Because octeontx2 is the last item

Re: [dpdk-dev] [PATCH v4 4/5] config: add octeontx2 machine config

[Phil Yang (Arm Technology China)]

Hi Jerin/Pavan,

> -Original Message-
> From: dev  On Behalf Of Pavan Nikhilesh Bhagavatula
> Sent: Wednesday, January 9, 2019 6:40 PM
> To: jer...@marvell.com; Gavin Hu (Arm Technology China)
> ; bruce.richard...@intel.com; tho...@monjalon.net
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula 
> Subject: [dpdk-dev] [PATCH v4 4/5] config: add octeontx2 machine config
> 
> From: Jerin Jacob 
> 
> Optimized configuration for Marvell octeontx2 SoC. Update meson build to
> support Marvell octeontx2 SoC.
> 
> Signed-off-by: Jerin Jacob 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  config/arm/meson.build| 10 +-
>  config/defconfig_arm64-octeontx2-linuxapp-gcc | 18 ++
>  mk/machine/octeontx2/rte.vars.mk  | 34 +++
>  3 files changed, 61 insertions(+), 1 deletion(-)  create mode 100644
> config/defconfig_arm64-octeontx2-linuxapp-gcc
>  create mode 100644 mk/machine/octeontx2/rte.vars.mk
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> aca285b6a..8086357a1 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -60,6 +60,13 @@ flags_thunderx2_extra = [
>   ['RTE_MAX_NUMA_NODES', 2],
>   ['RTE_MAX_LCORE', 256],
>   ['RTE_USE_C11_MEM_MODEL', true]]
> +flags_octeontx2_extra = [
> + ['RTE_MACHINE', '"octeontx2"'],
> + ['RTE_MAX_NUMA_NODES', 1],
> + ['RTE_MAX_LCORE', 24],
> + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false],
> + ['RTE_LIBRTE_VHOST_NUMA', false],
> + ['RTE_EAL_IGB_UIO', false]]
> 
>  machine_args_generic = [
>   ['default', ['-march=armv8-a+crc+crypto']], @@ -77,7 +84,8 @@
> machine_args_cavium = [
>   ['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],
>   ['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],
>   ['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra],
> - ['0xaf', ['-mcpu=thunderx2t99'], flags_thunderx2_extra]]
> + ['0xaf', ['-mcpu=thunderx2t99'], flags_thunderx2_extra],
> + ['0xb2', ['-mcpu=octeontx2'], flags_octeontx2_extra]]
> 
>  ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)
> impl_generic = ['Generic armv8', flags_generic, machine_args_generic] diff 
> --git
> a/config/defconfig_arm64-octeontx2-linuxapp-gcc b/config/defconfig_arm64-
> octeontx2-linuxapp-gcc
> new file mode 100644
> index 0..9a99eada1
> --- /dev/null
> +++ b/config/defconfig_arm64-octeontx2-linuxapp-gcc
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#include "defconfig_arm64-armv8a-linuxapp-gcc"
> +
> +CONFIG_RTE_MACHINE="octeontx2"
> +
> +CONFIG_RTE_CACHE_LINE_SIZE=128
> +CONFIG_RTE_MAX_NUMA_NODES=1
> +CONFIG_RTE_MAX_LCORE=24
> +
> +# Doesn't support NUMA
> +CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
> +CONFIG_RTE_LIBRTE_VHOST_NUMA=n
> +
> +# Recommend to use VFIO as co-processors needs SMMU/IOMMU
> +CONFIG_RTE_EAL_IGB_UIO=n
> diff --git a/mk/machine/octeontx2/rte.vars.mk
> b/mk/machine/octeontx2/rte.vars.mk
> new file mode 100644
> index 0..e209cf492
> --- /dev/null
> +++ b/mk/machine/octeontx2/rte.vars.mk
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Marvell
> +International Ltd #
> +
> +#
> +# machine:
> +#
> +#   - can define ARCH variable (overridden by cmdline value)
> +#   - can define CROSS variable (overridden by cmdline value)
> +#   - define MACHINE_CFLAGS variable (overridden by cmdline value)
> +#   - define MACHINE_LDFLAGS variable (overridden by cmdline value)
> +#   - define MACHINE_ASFLAGS variable (overridden by cmdline value)
> +#   - can define CPU_CFLAGS variable (overridden by cmdline value) that
> +# overrides the one defined in arch.
> +#   - can define CPU_LDFLAGS variable (overridden by cmdline value) that
> +# overrides the one defined in arch.
> +#   - can define CPU_ASFLAGS variable (overridden by cmdline value) that
> +# overrides the one defined in arch.
> +#   - may override any previously defined variable
> +#
> +
> +# ARCH =
> +# CROSS =
> +# MACHINE_CFLAGS =
> +# MACHINE_LDFLAGS =
> +# MACHINE_ASFLAGS =
> +# CPU_CFLAGS =
> +# CPU_LDFLAGS =
> +# CPU_ASFLAGS =
> +
> +include $(RTE_SDK)/mk/rte.helper.mk
> +
> +MACHINE_CFLAGS += $(call rte_cc_has_argument,
> +-march=armv8.2-a+crc+crypto+lse) MACHINE_CFLAGS += $(call
> +rte_cc_has_argument, -mcpu=octeontx2)

Why do you choose to expose armv8.2-a flag other than using armv8a combine with 
the extension flags here?
The value 'armv8.2-a' implies 'armv8.1-a' and enables compiler support for the 
ARMv8.2-A architecture extensions. And the 'lse' extension is the default 
feature for 'armv8.1-a'. So it seems there is no need to specify 'armv8.2-a' 
with 'lse'.

According to the meson build code, the default -march config for Cavium is 
'armv8-a'. So I think it seems better to keep 'armv8-a' here and add flags for 
the specific extensions.
The same for thunderx2 configuration.

> --
> 2.20.1

Thanks,
Phil Yang

Re: [dpdk-dev] [PATCH v3] eal: support strlcat function

[Thomas Monjalon]

17/01/2019 18:30, Bruce Richardson:
> Add the strlcat function to DPDK to exist alongside the strlcpy one.
> While strncat is generally safe for use for concatenation, the API for the
> strlcat function is perhaps a little nicer to use, and supports truncation
> detection.
> 
> See commit 5364de644a4b ("eal: support strlcpy function") for more
> details on the function selection logic, since we only should be using the
> DPDK-provided version when no system-provided version is present.
> 
> Signed-off-by: Bruce Richardson 
> Reviewed-by: Ferruh Yigit 

Applied, thanks

[dpdk-dev] [PATCH v1 1/3] librte_pipeline: add support for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

Signed-off-by: Georgina Sheehan 
---
 lib/librte_pipeline/rte_table_action.c | 133 +
 lib/librte_pipeline/rte_table_action.h |  20 
 2 files changed, 153 insertions(+)

diff --git a/lib/librte_pipeline/rte_table_action.c 
b/lib/librte_pipeline/rte_table_action.c
index 8a2bb13dc..8f11a17e6 100644
--- a/lib/librte_pipeline/rte_table_action.c
+++ b/lib/librte_pipeline/rte_table_action.c
@@ -2119,6 +2119,87 @@ pkt4_work_decap(struct rte_mbuf *mbuf0,
mbuf3->pkt_len = pkt_len3 - n3;
 }
 
+/**
+ * RTE_TABLE_ACTION_DSCP
+ */
+
+struct dscp_data {
+   uint8_t dscp_val;
+} __attribute__((__packed__));
+
+static int
+dscp_apply(void *data,
+   struct rte_table_action_dscp_params *p)
+{
+   struct dscp_data *d = data;
+
+   d->dscp_val = (p->dscp_val & 0x3f) << 2;
+
+   return 0;
+}
+
+static __rte_always_inline uint16_t
+dscp_ipv4_checksum_update(uint16_t cksum0,
+   uint8_t dscp_old,
+   uint8_t dscp_new)
+{
+   int32_t cksum1;
+   cksum1 = cksum0;
+   cksum1 = ~cksum1 & 0x;
+
+   /* Subtract ip0 (one's complement logic) */
+   cksum1 -= ((uint16_t)dscp_old & 0x);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+
+   /* Add ip1 (one's complement logic) */
+   cksum1 += ((uint16_t)dscp_new & 0x);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+
+   return (uint16_t)(~cksum1);
+}
+
+static __rte_always_inline void
+pkt_ipv4_work_dscp(struct ipv4_hdr *ip, struct dscp_data *data)
+{
+   uint16_t ip_cksum;
+   uint8_t dscp;
+
+   ip->hdr_checksum = ntohs(ip->hdr_checksum);
+
+   dscp = ip->type_of_service & 0x3;
+   dscp = ip->type_of_service | data->dscp_val;
+
+   ip_cksum = dscp_ipv4_checksum_update(ip->hdr_checksum,
+   ip->type_of_service, dscp);
+
+   ip->type_of_service = dscp;
+
+   ip_cksum = ntohs(ip_cksum);
+
+   ip->hdr_checksum = ip_cksum;
+}
+
+static __rte_always_inline void
+pkt_ipv6_work_dscp(struct ipv6_hdr *ip, struct dscp_data *data)
+{
+   ip->vtc_flow = rte_ntohl(ip->vtc_flow);
+
+   uint32_t dscp = data->dscp_val;
+
+   dscp = dscp << 20;
+
+   uint32_t vtc_flow;
+
+   vtc_flow = ip->vtc_flow & 0xF03F;
+   vtc_flow = ip->vtc_flow | dscp;
+
+   vtc_flow = rte_htonl(vtc_flow);
+
+   ip->vtc_flow = vtc_flow;
+}
+
 /**
  * Action profile
  */
@@ -2138,6 +2219,7 @@ action_valid(enum rte_table_action_type action)
case RTE_TABLE_ACTION_SYM_CRYPTO:
case RTE_TABLE_ACTION_TAG:
case RTE_TABLE_ACTION_DECAP:
+   case RTE_TABLE_ACTION_DSCP:
return 1;
default:
return 0;
@@ -2158,6 +2240,7 @@ struct ap_config {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 static size_t
@@ -2180,6 +2263,8 @@ action_cfg_size(enum rte_table_action_type action)
return sizeof(struct rte_table_action_stats_config);
case RTE_TABLE_ACTION_SYM_CRYPTO:
return sizeof(struct rte_table_action_sym_crypto_config);
+   case RTE_TABLE_ACTION_DSCP:
+   return sizeof(struct rte_table_action_dscp_config);
default:
return 0;
}
@@ -2213,6 +2298,9 @@ action_cfg_get(struct ap_config *ap_config,
 
case RTE_TABLE_ACTION_SYM_CRYPTO:
return &ap_config->sym_crypto;
+
+   case RTE_TABLE_ACTION_DSCP:
+   return &ap_config->dscp;
default:
return NULL;
}
@@ -2278,6 +2366,9 @@ action_data_size(enum rte_table_action_type action,
case RTE_TABLE_ACTION_DECAP:
return sizeof(struct decap_data);
 
+   case RTE_TABLE_ACTION_DSCP:
+   return sizeof(struct dscp_data);
+
default:
return 0;
}
@@ -2543,6 +2634,10 @@ rte_table_action_apply(struct rte_table_action *action,
return decap_apply(action_data,
action_params);
 
+   case RTE_TABLE_ACTION_DSCP:
+   return dscp_apply(action_data,
+   action_params);
+
default:
return -EINVAL;
}
@@ -2939,6 +3034,17 @@ pkt_work(struct rte_mbuf *mbuf,
pkt_work_tag(mbuf, data);
}
 
+   if (cfg->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   void *data =
+   action_data_get(table_entry, action,
+   RTE_TABLE_ACTION_DSCP);
+
+   if (cfg->common.ip_version)
+   pkt_ipv4_work_dscp(ip, data);
+   else
+   pkt_ipv6_work_

[dpdk-dev] [PATCH v1 3/3] net/softnic: add support for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

Signed-off-by: Georgina Sheehan 
---
 drivers/net/softnic/rte_eth_softnic_action.c  | 14 
 drivers/net/softnic/rte_eth_softnic_cli.c | 34 +++
 .../net/softnic/rte_eth_softnic_internals.h   |  2 ++
 drivers/net/softnic/rte_eth_softnic_thread.c  | 10 ++
 4 files changed, 60 insertions(+)

diff --git a/drivers/net/softnic/rte_eth_softnic_action.c 
b/drivers/net/softnic/rte_eth_softnic_action.c
index 92c744dc9..98d03d5ef 100644
--- a/drivers/net/softnic/rte_eth_softnic_action.c
+++ b/drivers/net/softnic/rte_eth_softnic_action.c
@@ -397,12 +397,26 @@ softnic_table_action_profile_create(struct pmd_internals 
*p,
}
}
 
+   if (params->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   status = rte_table_action_profile_action_register(ap,
+   RTE_TABLE_ACTION_DSCP,
+   ¶ms->dscp);
+
+   if (status) {
+   rte_table_action_profile_free(ap);
+   return NULL;
+   }
+   }
+
+
status = rte_table_action_profile_freeze(ap);
if (status) {
rte_table_action_profile_free(ap);
return NULL;
}
 
+
+
/* Node allocation */
profile = calloc(1, sizeof(struct softnic_table_action_profile));
if (profile == NULL) {
diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c 
b/drivers/net/softnic/rte_eth_softnic_cli.c
index 76136c2e2..d576cdbfb 100644
--- a/drivers/net/softnic/rte_eth_softnic_cli.c
+++ b/drivers/net/softnic/rte_eth_softnic_cli.c
@@ -1358,6 +1358,7 @@ cmd_port_in_action_profile(struct pmd_internals *softnic,
  *  [time]
  *  [tag]
  *  [decap]
+ *  [dscp]
  *
  */
 static void
@@ -1787,6 +1788,17 @@ cmd_table_action_profile(struct pmd_internals *softnic,
t0 += 5;
} /* sym_crypto */
 
+   if (t0 < n_tokens && (strcmp(tokens[t0], "dscp") == 0)) {
+   if (n_tokens < t0 + 1) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH,
+   "table action profile dscp");
+   return;
+   }
+
+   p.action_mask |= 1LLU << RTE_TABLE_ACTION_DSCP;
+   t0 += 1;
+   } /** DSCP **/
+
if (t0 < n_tokens) {
snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
return;
@@ -3432,6 +3444,7 @@ parse_match(char **tokens,
  *  aead_algo  aead_key  aead_iv  aead_aad 
  *  digest_size 
  *   data_offset ]
+ *[dscp ]
  *
  * where:
  * ::= g | y | r | drop
@@ -4431,6 +,27 @@ parse_table_action_decap(char **tokens,
return 2;
 }
 
+static uint32_t
+parse_table_action_dscp(char **tokens,
+   uint32_t n_tokens,
+   struct softnic_table_rule_action *a)
+{
+   if (n_tokens < 2 ||
+   strcmp(tokens[0], "dscp"))
+   return 0;
+
+   uint8_t dscp_val;
+
+   if (softnic_parser_read_uint8(&dscp_val, tokens[1]))
+   return 0;
+
+   a->dscp.dscp_val = dscp_val;
+
+   a->action_mask |= 1 << RTE_TABLE_ACTION_DSCP;
+
+   return 2;
+}
+
 static uint32_t
 parse_table_action(char **tokens,
uint32_t n_tokens,
diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h 
b/drivers/net/softnic/rte_eth_softnic_internals.h
index 415434d0d..67ba3ecf3 100644
--- a/drivers/net/softnic/rte_eth_softnic_internals.h
+++ b/drivers/net/softnic/rte_eth_softnic_internals.h
@@ -333,6 +333,7 @@ struct softnic_table_action_profile_params {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 struct softnic_table_action_profile {
@@ -962,6 +963,7 @@ struct softnic_table_rule_action {
struct rte_table_action_tag_params tag;
struct rte_table_action_decap_params decap;
struct rte_table_action_sym_crypto_params sym_crypto;
+   struct rte_table_action_dscp_params dscp;
 };
 
 struct rte_flow {
diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c 
b/drivers/net/softnic/rte_eth_softnic_thread.c
index 57989a5aa..e73d4a704 100644
--- a/drivers/net/softnic/rte_eth_softnic_thread.c
+++ b/drivers/net/softnic/rte_eth_softnic_thread.c
@@ -2598,6 +2598,16 @@ action_convert(struct rte_table_action *a,
return status;
}
 
+   if (action->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   status = rte_table_action_apply(a,
+   data,
+   RTE_TABLE_ACTION_DSCP,
+   &action->dscp);
+
+   if (status)
+   return status;
+   }
+
return 0;
 }
 
-- 
2.17.1

[dpdk-dev] [PATCH v1 2/3] pipeline: add implementation for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

Signed-off-by: Georgina Sheehan 
---
 examples/ip_pipeline/action.c   | 11 +++
 examples/ip_pipeline/action.h   |  1 +
 examples/ip_pipeline/cli.c  | 52 -
 examples/ip_pipeline/pipeline.h |  1 +
 examples/ip_pipeline/thread.c   | 10 +++
 5 files changed, 74 insertions(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index d2104aad6..625c870a2 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -366,6 +366,17 @@ table_action_profile_create(const char *name,
}
}
 
+   if (params->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   status = rte_table_action_profile_action_register(ap,
+   RTE_TABLE_ACTION_DSCP,
+   ¶ms->dscp);
+
+   if (status) {
+   rte_table_action_profile_free(ap);
+   return NULL;
+   }
+   }
+
status = rte_table_action_profile_freeze(ap);
if (status) {
rte_table_action_profile_free(ap);
diff --git a/examples/ip_pipeline/action.h b/examples/ip_pipeline/action.h
index cde17e69a..ea8f81c56 100644
--- a/examples/ip_pipeline/action.h
+++ b/examples/ip_pipeline/action.h
@@ -54,6 +54,7 @@ struct table_action_profile_params {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 struct table_action_profile {
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index a92467e63..ca3083a48 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -1045,7 +1045,8 @@ static const char cmd_table_action_profile_help[] =
 "   [time]\n"
 "   [sym_crypto dev  offset ]\n"
 "   [tag]\n"
-"   [decap]\n";
+"   [decap]\n"
+"   [dscp]\n";
 
 static void
 cmd_table_action_profile(char **tokens,
@@ -1458,6 +1459,17 @@ cmd_table_action_profile(char **tokens,
t0 += 1;
} /* decap */
 
+   if ((t0 < n_tokens) && (strcmp(tokens[t0], "dscp") == 0)) {
+   if (n_tokens < t0 + 1) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH,
+   "table action profile dscp");
+   return;
+   }
+
+   p.action_mask |= 1LLU << RTE_TABLE_ACTION_DSCP;
+   t0 += 1;
+   } /** DSCP **/
+
if (t0 < n_tokens) {
snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
return;
@@ -3116,6 +3128,7 @@ parse_match(char **tokens,
  *   data_offset ]
  *[tag ]
  *[decap ]
+ *[dscp ]
  *
  * where:
  * ::= g | y | r | drop
@@ -4108,6 +4121,26 @@ parse_table_action_decap(char **tokens,
return 2;
 }
 
+static uint32_t
+parse_table_action_dscp(char **tokens,
+   uint32_t n_tokens,
+   struct table_rule_action *a)
+{
+   if ((n_tokens < 2) ||
+   strcmp(tokens[0], "dscp"))
+   return 0;
+
+   uint8_t dscp_val;
+
+   if (parser_read_uint8(&dscp_val, tokens[1]))
+   return 0;
+
+   a->dscp.dscp_val = dscp_val;
+
+   a->action_mask |= 1 << RTE_TABLE_ACTION_DSCP;
+   return 2;
+}
+
 static uint32_t
 parse_table_action(char **tokens,
uint32_t n_tokens,
@@ -4293,6 +4326,20 @@ parse_table_action(char **tokens,
n_tokens -= n;
}
 
+   if (n_tokens && (strcmp(tokens[0], "dscp") == 0)) {
+   uint32_t n;
+
+   n = parse_table_action_dscp(tokens, n_tokens, a);
+   if (n == 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "action dscp");
+   return 0;
+   }
+
+   tokens += n;
+   n_tokens -= n;
+   }
+
if (n_tokens0 - n_tokens == 1) {
snprintf(out, out_size, MSG_ARG_INVALID, "action");
return 0;
@@ -5056,6 +5103,9 @@ table_rule_show(const char *pipeline_name,
if (a->action_mask & (1LLU << RTE_TABLE_ACTION_DECAP))
fprintf(f, "decap %u ", a->decap.n);
 
+   if (a->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP))
+   fprintf(f, "dscp ");
+
/* end */
fprintf(f, "\n");
}
diff --git a/examples/ip_pipeline/pipeline.h b/examples/ip_pipeline/pipeline.h
index 278775c2d..670174ed4 100644
--- a/examples/ip_pipeline/pipeline.h
+++ b/examples/ip_pipeline/pipeline.h
@@ -290,6 +290,7 @@ struct table_rule_action {
struct rte_table_action_sym_crypto_params sym_crypto;
struct rte_table_action_tag_params tag;
struct rte_table_action_decap_params dec

Re: [dpdk-dev] [PATCH v5] doc/patches: add meson build to contributing guide

[Thomas Monjalon]

29/01/2019 11:10, Vipin Varghese:
> +Meson system
> +

What do you think about adding "Makefile system" title for previous section?
We could also add an introduction explaining that both systems must be tested.

> +
> +Compilation of patches is to be tested with 
> ``devtools/test-meson-builds.sh`` script in ``devtools``

A dot is missing. You may remove "in ``devtools``" as it is already in the path.

> +
> +The script internally checks for dependencies, then builds for several
> +combinations of compilation configuration.
> +

Re: [dpdk-dev] [PATCH] test: fix broken "make test"

[Ferruh Yigit]

On 2/11/2019 6:38 PM, Rami Rosen wrote:
> This patch fixes a broken build; when running
> make test
> we get the following error:
> ...
> Traceback (most recent call last):
>   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in 
> num_fails = runner.run_all_tests()
>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
> run_all_tests
> self.parallel_tests)
>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
> __filter_test
> test_cmd = test["Command"]
> KeyError: 'Command'
> ...
> The reason is that the pdump autotest entry uses "Comamnd"
> instead of "Command"; this patch fixes it.
> 
> Bugzilla ID: 205
> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> Signed-off-by: Rami Rosen 

Reviewed-by: Ferruh Yigit 

Good catch! But it seems 19.02 released autotest broken, so this needs to be
backported to 19.02:

Cc: sta...@dpdk.org


Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring
the the suggestion in next meeting.

Re: [dpdk-dev] [PATCH] test: fix broken "make test"

[David Marchand]

On Tue, Feb 12, 2019 at 10:36 AM Ferruh Yigit 
wrote:

> Good catch! But it seems 19.02 released autotest broken, so this needs to
> be
> backported to 19.02:
>
> Cc: sta...@dpdk.org
>
>
> Thomas,
> What do you think adding autotest into DPDK community lab testing? I will
> bring
> the the suggestion in next meeting.
>

+1.

-- 
David Marchand

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse operations

[Shally Verma]

>-Original Message-
>From: Arek Kusztal 
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; 
>shally.ve...@caviumnetworks.com; Arek Kusztal 
>Subject: [PATCH v2 1/3] cryptodev: add result field to mod exp and inverse 
>operations
>
>External Email
>
>This commit adds result field to be used when modular exponentiation or
>modular multiplicative inverse operation is used
>
>Signed-off-by: Arek Kusztal 
>---
Acked-by: Shally Verma 

> lib/librte_cryptodev/rte_crypto_asym.h | 10 ++
> 1 file changed, 10 insertions(+)
>
>diff --git a/lib/librte_cryptodev/rte_crypto_asym.h 
>b/lib/librte_cryptodev/rte_crypto_asym.h
>index 0a50cd5..991263f 100644
>--- a/lib/librte_cryptodev/rte_crypto_asym.h
>+++ b/lib/librte_cryptodev/rte_crypto_asym.h
>@@ -339,6 +339,16 @@ struct rte_crypto_mod_op_param {
> * be relatively prime to modulus in corresponding Modular
> * Multiplicative Inverse rte_crypto_modinv_xform
> */
>+
>+   rte_crypto_param result;
>+   /**<
>+* Pointer to the result of modular exponentiation/multiplicative 
>inverse
>+* data in octet-string network byte order format.
>+*
>+* This field shall be big enough to hold the result of Modular
>+* Exponentiation or Modular Multplicative Inverse
>+* (bigger or equal to length of modulus)
>+*/
> };
>
> /**
>--
>2.1.0

Re: [dpdk-dev] [PATCH v2 3/3] test: add result field to mod exp and mod inv

[Shally Verma]

>-Original Message-
>From: Arek Kusztal 
>Sent: 08 February 2019 16:44
>To: dev@dpdk.org
>Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; 
>shally.ve...@caviumnetworks.com; Arek Kusztal 
>Subject: [PATCH v2 3/3] test: add result field to mod exp and mod inv
>
>External Email
>
>This patch adds result field to modular exponentiation and
>modular multiplicative inverse tests
>
>Signed-off-by: Arek Kusztal 
>---
Acked-by: Shally Verma 

Thanks
Shally

Re: [dpdk-dev] [PATCH] openssl: fix not clearing big numbers after computations

[Shally Verma]

>-Original Message-
>From: dev  On Behalf Of Arek Kusztal
>Sent: 07 February 2019 16:25
>To: dev@dpdk.org
>Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; 
>shally.ve...@caviumnetworks.com; sunila.s...@caviumnetworks.com;
>ashish.gu...@caviumnetworks.com; Arek Kusztal 
>Subject: [dpdk-dev] [PATCH] openssl: fix not clearing big numbers after 
>computations
>
>After performing mod exp and mod inv big numbers (BIGNUM) should
>be cleared as data already is copied into op fields and this BNs would
>very likely contain private information for unspecified amount of time
>(duration of the session).
>
>Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
>
>Signed-off-by: Arek Kusztal 
>---
Acked-by: Shally Verma 

> drivers/crypto/openssl/rte_openssl_pmd.c | 6 ++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c 
>b/drivers/crypto/openssl/rte_openssl_pmd.c
>index ea5aac6..4ecc3c4 100644
>--- a/drivers/crypto/openssl/rte_openssl_pmd.c
>+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
>@@ -1795,6 +1795,9 @@ process_openssl_modinv_op(struct rte_crypto_op *cop,
>   cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
>   }
>
>+  BN_clear(res);
>+  BN_clear(base);
>+
>   return 0;
> }
>
>@@ -1825,6 +1828,9 @@ process_openssl_modexp_op(struct rte_crypto_op *cop,
>   cop->status = RTE_CRYPTO_OP_STATUS_ERROR;
>   }
>
>+  BN_clear(res);
>+  BN_clear(base);
>+
>   return 0;
> }
>
>--
>2.1.0

Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt

[Kusztal, ArkadiuszX]

Hi Shally, Ayuj

Answers with [AK]

> -Original Message-
> From: Shally Verma [mailto:shal...@marvell.com]
> Sent: Tuesday, February 12, 2019 6:27 AM
> To: Kusztal, ArkadiuszX ; Ayuj Verma
> ; Trahe, Fiona 
> Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy
> ; Sunila Sahu ;
> dev@dpdk.org
> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
> 
> HI Arek,
> 
> From: Kusztal, ArkadiuszX 
> Sent: 11 February 2019 17:11
> To: Ayuj Verma ; Trahe, Fiona
> ; Shally Verma 
> Cc: akhil.go...@nxp.com
> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt
> 
> External Email
> 
> Hi Ayuj,
> 
> Few comments from me.
> 
> Some PMDs can only support RSA private key operations using CRT keys
> (quintuple) only. Thus it is required to add in PMD RSA xform capability
> which key type is supported to perform sign and decrypt ops.
> 
> 
> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and
> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an
> private key op using CRT keys (quintuple) only.
> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type
> key_type in RSA XFORM then?
> 
> [Shally] PMDs, like openssl, can support private key ops with both key type
> i.e. one can invoke RSA_Sign() with quintuple keys or exponent keys.
> Openssl in its capability would reflect it support ops with both key types.
> that's why key_type is still required in xform.

[AK] But still I wonder if we could not just use this enum to distinguish 
between crt and mod exp rsa?
I am not very keen on adding SIGN_CRT op type as it is RSA only. Another option 
would be to add flags to rsa op like uint64_t flags;
> 
> PMD would reflect its capability to support these operations using its
> op_type mask. App should query RSA xform capability API to check if specific
> op_type is supported, thus call operation with relevant key type.
> 
> Another proposal is, it is not known if non-crt keys is used at all to perform
> otherwise naturally slow RSA private keys operations.
> So, it is also possible to deprecate RSA_KEY_TYPE_EXPONENT altogether and
> just use quintuple key type for private key operations.
> In that case, there is no need to add another SIGN/DECRYPT_CRT variant,
> current SIGN and DECRYPT operation default to using quintuple RSA keys.
> [AK] - even if I generally agree that all drivers will be using CRT by default
> (when quintuple keys provided) I think that if some PMD cannot support
> mod exp, it should fail on session init or should receive unsupported error on
> dequeue.
> 
> [Shally] Sorry this isn't clear to me when you say "if some PMD cannot
> support mod exp, it should fail on session init" . modexp is exported as
> separate xform on lib, if PMD doesn't support this xform, it will not be in 
> its
> capability.
> Or do you mean to say, we can leave exponent key type support , if PMD
> doesn't support operations using this type, it can will fail during
> session_init()?
[AK] Yes
> modexp is base for all RSA operation, so any PMD has to support it internally
> in any case.
> 
> Ayuj Verma (3):
>   lib/cryptodev: add crt sign and decrypt ops
>   crypto/openssl: update op-type mask with crt ops
>   test/crypto: check for rsa capa for op-type
> 
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c |  4 +-
>  lib/librte_cryptodev/rte_crypto_asym.h   |  8 
>  test/test/test_cryptodev_asym.c  | 47 
>  3 files changed, 58 insertions(+), 1 deletion(-)
> 
> --
> 2.20.0
> 
> Regards,
> Arek

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Thomas Monjalon]

06/02/2019 18:08, Luca Boccassi:
> Whenever possible (if the library ships a pkg-config file) use meson's
> dependency() function to look for it, as it will automatically add it
> to the Requires.private list if needed, to allow for static builds to
> succeed for reverse dependencies of DPDK. Otherwise the recursive
> dependencies are not parsed, and users doing static builds have to
> resolve them manually by themselves.
> When using this API avoid additional checks that are superfluous and
> take extra time, and avoid adding the linker flag manually which causes
> it to be duplicated.
> 
> Signed-off-by: Luca Boccassi 
> Acked-by: Bruce Richardson 

This patch breaks compilation on my machine with a lot of strange errors:

from drivers/net/pcap/rte_eth_pcap.c

/usr/include/stdint.h:109: error: "__INT64_C" redefined
/usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' 
qualifier from pointer target type
/usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored
etc

Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt

[Shally Verma]

Hi Arek

>-Original Message-
>From: Kusztal, ArkadiuszX 
>Sent: 12 February 2019 16:42
>To: Shally Verma ; Ayuj Verma ; 
>Trahe, Fiona 
>Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy ; 
>Sunila Sahu ;
>dev@dpdk.org
>Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
>
>Hi Shally, Ayuj
>
>Answers with [AK]
>
>> -Original Message-
>> From: Shally Verma [mailto:shal...@marvell.com]
>> Sent: Tuesday, February 12, 2019 6:27 AM
>> To: Kusztal, ArkadiuszX ; Ayuj Verma
>> ; Trahe, Fiona 
>> Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy
>> ; Sunila Sahu ;
>> dev@dpdk.org
>> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
>>
>> HI Arek,
>>
>> From: Kusztal, ArkadiuszX 
>> Sent: 11 February 2019 17:11
>> To: Ayuj Verma ; Trahe, Fiona
>> ; Shally Verma 
>> Cc: akhil.go...@nxp.com
>> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt
>>
>> External Email
>> 
>> Hi Ayuj,
>>
>> Few comments from me.
>>
>> Some PMDs can only support RSA private key operations using CRT keys
>> (quintuple) only. Thus it is required to add in PMD RSA xform capability
>> which key type is supported to perform sign and decrypt ops.
>>
>>
>> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and
>> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an
>> private key op using CRT keys (quintuple) only.
>> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type
>> key_type in RSA XFORM then?
>>
>> [Shally] PMDs, like openssl, can support private key ops with both key type
>> i.e. one can invoke RSA_Sign() with quintuple keys or exponent keys.
>> Openssl in its capability would reflect it support ops with both key types.
>> that's why key_type is still required in xform.
>
>[AK] But still I wonder if we could not just use this enum to distinguish 
>between crt and mod exp rsa?
>I am not very keen on adding SIGN_CRT op type as it is RSA only. Another 
>option would be to add flags to rsa op like uint64_t flags;
[Shally] Ok .. you mean as feature flag? Example, 
RTE_CRYPTODEV_ASYM_FF_RSA_PRIV_KEY_OP_CRT?

Thanks
Shally
...
>> Regards,
>> Arek

Re: [dpdk-dev] [PATCH] test: fix broken "make test"

[Thomas Monjalon]

12/02/2019 10:36, Ferruh Yigit:
> On 2/11/2019 6:38 PM, Rami Rosen wrote:
> > This patch fixes a broken build; when running
> > make test
> > we get the following error:
> > ...
> > Traceback (most recent call last):
> >   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in 
> > num_fails = runner.run_all_tests()
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
> > run_all_tests
> > self.parallel_tests)
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
> > __filter_test
> > test_cmd = test["Command"]
> > KeyError: 'Command'
> > ...
> > The reason is that the pdump autotest entry uses "Comamnd"
> > instead of "Command"; this patch fixes it.
> > 
> > Bugzilla ID: 205
> > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> > Signed-off-by: Rami Rosen 
> 
> Reviewed-by: Ferruh Yigit 
> 
> Good catch! But it seems 19.02 released autotest broken, so this needs to be
> backported to 19.02:
> 
> Cc: sta...@dpdk.org

Applied, thanks


> Thomas,
> What do you think adding autotest into DPDK community lab testing? I will 
> bring
> the the suggestion in next meeting.

Yes, sure.
It has already been discussed but no task was created:
https://bugs.dpdk.org/buglist.cgi?product=lab
Let's follow-up in next meeting.

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Bruce Richardson]

On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> 06/02/2019 18:08, Luca Boccassi:
> > Whenever possible (if the library ships a pkg-config file) use meson's
> > dependency() function to look for it, as it will automatically add it
> > to the Requires.private list if needed, to allow for static builds to
> > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > dependencies are not parsed, and users doing static builds have to
> > resolve them manually by themselves.
> > When using this API avoid additional checks that are superfluous and
> > take extra time, and avoid adding the linker flag manually which causes
> > it to be duplicated.
> > 
> > Signed-off-by: Luca Boccassi 
> > Acked-by: Bruce Richardson 
> 
> This patch breaks compilation on my machine with a lot of strange errors:
> 
> from drivers/net/pcap/rte_eth_pcap.c
> 
> /usr/include/stdint.h:109: error: "__INT64_C" redefined
> /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' 
> qualifier from pointer target type
> /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored
> etc
>
Is this on Arch linux again? I just reverified these first two patches and
they work fine for me on Fedora (I assume Luca probably tested them already on
Debian) 

Anything unusual about your setup?

/Bruce

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Thomas Monjalon]

12/02/2019 12:31, Bruce Richardson:
> On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> > 06/02/2019 18:08, Luca Boccassi:
> > > Whenever possible (if the library ships a pkg-config file) use meson's
> > > dependency() function to look for it, as it will automatically add it
> > > to the Requires.private list if needed, to allow for static builds to
> > > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > > dependencies are not parsed, and users doing static builds have to
> > > resolve them manually by themselves.
> > > When using this API avoid additional checks that are superfluous and
> > > take extra time, and avoid adding the linker flag manually which causes
> > > it to be duplicated.
> > > 
> > > Signed-off-by: Luca Boccassi 
> > > Acked-by: Bruce Richardson 
> > 
> > This patch breaks compilation on my machine with a lot of strange errors:
> > 
> > from drivers/net/pcap/rte_eth_pcap.c
> > 
> > /usr/include/stdint.h:109: error: "__INT64_C" redefined
> > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' 
> > qualifier from pointer target type
> > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored
> > etc
> >
> Is this on Arch linux again? I just reverified these first two patches and
> they work fine for me on Fedora (I assume Luca probably tested them already on
> Debian) 
> 
> Anything unusual about your setup?

Nothing unusual. Just using the best environment ever ;)
I will try to debug it.

Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt

[Kusztal, ArkadiuszX]

> -Original Message-
> From: Shally Verma [mailto:shal...@marvell.com]
> Sent: Tuesday, February 12, 2019 12:19 PM
> To: Kusztal, ArkadiuszX ; Ayuj Verma
> ; Trahe, Fiona 
> Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy
> ; Sunila Sahu ;
> dev@dpdk.org
> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
> 
> Hi Arek
> 
> >-Original Message-
> >From: Kusztal, ArkadiuszX 
> >Sent: 12 February 2019 16:42
> >To: Shally Verma ; Ayuj Verma
> >; Trahe, Fiona 
> >Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy
> >; Sunila Sahu ;
> >dev@dpdk.org
> >Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
> >
> >Hi Shally, Ayuj
> >
> >Answers with [AK]
> >
> >> -Original Message-
> >> From: Shally Verma [mailto:shal...@marvell.com]
> >> Sent: Tuesday, February 12, 2019 6:27 AM
> >> To: Kusztal, ArkadiuszX ; Ayuj Verma
> >> ; Trahe, Fiona 
> >> Cc: akhil.go...@nxp.com; Kanaka Durga Kotamarthy
> >> ; Sunila Sahu ;
> >> dev@dpdk.org
> >> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt
> >>
> >> HI Arek,
> >>
> >> From: Kusztal, ArkadiuszX 
> >> Sent: 11 February 2019 17:11
> >> To: Ayuj Verma ; Trahe, Fiona
> >> ; Shally Verma 
> >> Cc: akhil.go...@nxp.com
> >> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt
> >>
> >> External Email
> >> 
> >> Hi Ayuj,
> >>
> >> Few comments from me.
> >>
> >> Some PMDs can only support RSA private key operations using CRT keys
> >> (quintuple) only. Thus it is required to add in PMD RSA xform
> >> capability which key type is supported to perform sign and decrypt ops.
> >>
> >>
> >> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and
> >> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an
> private
> >> key op using CRT keys (quintuple) only.
> >> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type
> >> key_type in RSA XFORM then?
> >>
> >> [Shally] PMDs, like openssl, can support private key ops with both
> >> key type i.e. one can invoke RSA_Sign() with quintuple keys or exponent
> keys.
> >> Openssl in its capability would reflect it support ops with both key types.
> >> that's why key_type is still required in xform.
> >
> >[AK] But still I wonder if we could not just use this enum to distinguish
> between crt and mod exp rsa?
> >I am not very keen on adding SIGN_CRT op type as it is RSA only.
> >Another option would be to add flags to rsa op like uint64_t flags;
> [Shally] Ok .. you mean as feature flag? Example,
> RTE_CRYPTODEV_ASYM_FF_RSA_PRIV_KEY_OP_CRT?
[AK] Yes.
> 
> Thanks
> Shally
> ...
> >> Regards,
> >> Arek

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Bruce Richardson]

On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote:
> 12/02/2019 12:31, Bruce Richardson:
> > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> > > 06/02/2019 18:08, Luca Boccassi:
> > > > Whenever possible (if the library ships a pkg-config file) use meson's
> > > > dependency() function to look for it, as it will automatically add it
> > > > to the Requires.private list if needed, to allow for static builds to
> > > > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > > > dependencies are not parsed, and users doing static builds have to
> > > > resolve them manually by themselves.
> > > > When using this API avoid additional checks that are superfluous and
> > > > take extra time, and avoid adding the linker flag manually which causes
> > > > it to be duplicated.
> > > > 
> > > > Signed-off-by: Luca Boccassi 
> > > > Acked-by: Bruce Richardson 
> > > 
> > > This patch breaks compilation on my machine with a lot of strange errors:
> > > 
> > > from drivers/net/pcap/rte_eth_pcap.c
> > > 
> > > /usr/include/stdint.h:109: error: "__INT64_C" redefined
> > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' 
> > > qualifier from pointer target type
> > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored
> > > etc
> > >
> > Is this on Arch linux again? I just reverified these first two patches and
> > they work fine for me on Fedora (I assume Luca probably tested them already 
> > on
> > Debian) 
> > 
> > Anything unusual about your setup?
> 
> Nothing unusual. Just using the best environment ever ;)
> I will try to debug it.
> 
It may be something pcap-specific, since pcap has to have it's own special
query mechanims outside the normal pkg-config one. If you remove the
pcap-driver changes, does the rest of the patch work for you?

/Bruce

Re: [dpdk-dev] [dpdk-stable] [PATCH ] mbuf: fix a typo

[Thomas Monjalon]

11/02/2019 19:52, Rami Rosen:
> This trivial patch fixes a typo in rte_mbuf.h.
> 
> Fixes: f20b50b946da ("mbuf: optimize refcnt update")
> Cc: sta...@dpdk.org 
> Signed-off-by: Rami Rosen 

Applied, thanks

[dpdk-dev] [PATCH v2 1/3] librte_pipeline: add support for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

v2: Added in call of function parse_table_action_dscp in softnic cli file

Signed-off-by: Georgina Sheehan 
---
 lib/librte_pipeline/rte_table_action.c | 133 +
 lib/librte_pipeline/rte_table_action.h |  20 
 2 files changed, 153 insertions(+)

diff --git a/lib/librte_pipeline/rte_table_action.c 
b/lib/librte_pipeline/rte_table_action.c
index 8a2bb13dc..8f11a17e6 100644
--- a/lib/librte_pipeline/rte_table_action.c
+++ b/lib/librte_pipeline/rte_table_action.c
@@ -2119,6 +2119,87 @@ pkt4_work_decap(struct rte_mbuf *mbuf0,
mbuf3->pkt_len = pkt_len3 - n3;
 }
 
+/**
+ * RTE_TABLE_ACTION_DSCP
+ */
+
+struct dscp_data {
+   uint8_t dscp_val;
+} __attribute__((__packed__));
+
+static int
+dscp_apply(void *data,
+   struct rte_table_action_dscp_params *p)
+{
+   struct dscp_data *d = data;
+
+   d->dscp_val = (p->dscp_val & 0x3f) << 2;
+
+   return 0;
+}
+
+static __rte_always_inline uint16_t
+dscp_ipv4_checksum_update(uint16_t cksum0,
+   uint8_t dscp_old,
+   uint8_t dscp_new)
+{
+   int32_t cksum1;
+   cksum1 = cksum0;
+   cksum1 = ~cksum1 & 0x;
+
+   /* Subtract ip0 (one's complement logic) */
+   cksum1 -= ((uint16_t)dscp_old & 0x);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+
+   /* Add ip1 (one's complement logic) */
+   cksum1 += ((uint16_t)dscp_new & 0x);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+   cksum1 = (cksum1 & 0x) + (cksum1 >> 16);
+
+   return (uint16_t)(~cksum1);
+}
+
+static __rte_always_inline void
+pkt_ipv4_work_dscp(struct ipv4_hdr *ip, struct dscp_data *data)
+{
+   uint16_t ip_cksum;
+   uint8_t dscp;
+
+   ip->hdr_checksum = ntohs(ip->hdr_checksum);
+
+   dscp = ip->type_of_service & 0x3;
+   dscp = ip->type_of_service | data->dscp_val;
+
+   ip_cksum = dscp_ipv4_checksum_update(ip->hdr_checksum,
+   ip->type_of_service, dscp);
+
+   ip->type_of_service = dscp;
+
+   ip_cksum = ntohs(ip_cksum);
+
+   ip->hdr_checksum = ip_cksum;
+}
+
+static __rte_always_inline void
+pkt_ipv6_work_dscp(struct ipv6_hdr *ip, struct dscp_data *data)
+{
+   ip->vtc_flow = rte_ntohl(ip->vtc_flow);
+
+   uint32_t dscp = data->dscp_val;
+
+   dscp = dscp << 20;
+
+   uint32_t vtc_flow;
+
+   vtc_flow = ip->vtc_flow & 0xF03F;
+   vtc_flow = ip->vtc_flow | dscp;
+
+   vtc_flow = rte_htonl(vtc_flow);
+
+   ip->vtc_flow = vtc_flow;
+}
+
 /**
  * Action profile
  */
@@ -2138,6 +2219,7 @@ action_valid(enum rte_table_action_type action)
case RTE_TABLE_ACTION_SYM_CRYPTO:
case RTE_TABLE_ACTION_TAG:
case RTE_TABLE_ACTION_DECAP:
+   case RTE_TABLE_ACTION_DSCP:
return 1;
default:
return 0;
@@ -2158,6 +2240,7 @@ struct ap_config {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 static size_t
@@ -2180,6 +2263,8 @@ action_cfg_size(enum rte_table_action_type action)
return sizeof(struct rte_table_action_stats_config);
case RTE_TABLE_ACTION_SYM_CRYPTO:
return sizeof(struct rte_table_action_sym_crypto_config);
+   case RTE_TABLE_ACTION_DSCP:
+   return sizeof(struct rte_table_action_dscp_config);
default:
return 0;
}
@@ -2213,6 +2298,9 @@ action_cfg_get(struct ap_config *ap_config,
 
case RTE_TABLE_ACTION_SYM_CRYPTO:
return &ap_config->sym_crypto;
+
+   case RTE_TABLE_ACTION_DSCP:
+   return &ap_config->dscp;
default:
return NULL;
}
@@ -2278,6 +2366,9 @@ action_data_size(enum rte_table_action_type action,
case RTE_TABLE_ACTION_DECAP:
return sizeof(struct decap_data);
 
+   case RTE_TABLE_ACTION_DSCP:
+   return sizeof(struct dscp_data);
+
default:
return 0;
}
@@ -2543,6 +2634,10 @@ rte_table_action_apply(struct rte_table_action *action,
return decap_apply(action_data,
action_params);
 
+   case RTE_TABLE_ACTION_DSCP:
+   return dscp_apply(action_data,
+   action_params);
+
default:
return -EINVAL;
}
@@ -2939,6 +3034,17 @@ pkt_work(struct rte_mbuf *mbuf,
pkt_work_tag(mbuf, data);
}
 
+   if (cfg->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   void *data =
+   action_data_get(table_entry, action,
+   RTE_TABLE_ACTION_DSCP);
+
+   if (cfg->common.ip_version)
+   pkt_ipv4_work_

[dpdk-dev] [PATCH v2 3/3] net/softnic: add support for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

v2: Added in call of function parse_table_action_dscp in softnic cli file

Signed-off-by: Georgina Sheehan 
---
 drivers/net/softnic/rte_eth_softnic_action.c  | 14 ++
 drivers/net/softnic/rte_eth_softnic_cli.c | 48 +++
 .../net/softnic/rte_eth_softnic_internals.h   |  2 +
 drivers/net/softnic/rte_eth_softnic_thread.c  | 10 
 4 files changed, 74 insertions(+)

diff --git a/drivers/net/softnic/rte_eth_softnic_action.c 
b/drivers/net/softnic/rte_eth_softnic_action.c
index 92c744dc9..98d03d5ef 100644
--- a/drivers/net/softnic/rte_eth_softnic_action.c
+++ b/drivers/net/softnic/rte_eth_softnic_action.c
@@ -397,12 +397,26 @@ softnic_table_action_profile_create(struct pmd_internals 
*p,
}
}
 
+   if (params->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   status = rte_table_action_profile_action_register(ap,
+   RTE_TABLE_ACTION_DSCP,
+   ¶ms->dscp);
+
+   if (status) {
+   rte_table_action_profile_free(ap);
+   return NULL;
+   }
+   }
+
+
status = rte_table_action_profile_freeze(ap);
if (status) {
rte_table_action_profile_free(ap);
return NULL;
}
 
+
+
/* Node allocation */
profile = calloc(1, sizeof(struct softnic_table_action_profile));
if (profile == NULL) {
diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c 
b/drivers/net/softnic/rte_eth_softnic_cli.c
index 76136c2e2..0e94cfc55 100644
--- a/drivers/net/softnic/rte_eth_softnic_cli.c
+++ b/drivers/net/softnic/rte_eth_softnic_cli.c
@@ -1358,6 +1358,7 @@ cmd_port_in_action_profile(struct pmd_internals *softnic,
  *  [time]
  *  [tag]
  *  [decap]
+ *  [dscp]
  *
  */
 static void
@@ -1787,6 +1788,17 @@ cmd_table_action_profile(struct pmd_internals *softnic,
t0 += 5;
} /* sym_crypto */
 
+   if (t0 < n_tokens && (strcmp(tokens[t0], "dscp") == 0)) {
+   if (n_tokens < t0 + 1) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH,
+   "table action profile dscp");
+   return;
+   }
+
+   p.action_mask |= 1LLU << RTE_TABLE_ACTION_DSCP;
+   t0 += 1;
+   } /** DSCP **/
+
if (t0 < n_tokens) {
snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
return;
@@ -3432,6 +3444,7 @@ parse_match(char **tokens,
  *  aead_algo  aead_key  aead_iv  aead_aad 
  *  digest_size 
  *   data_offset ]
+ *[dscp ]
  *
  * where:
  * ::= g | y | r | drop
@@ -4431,6 +,27 @@ parse_table_action_decap(char **tokens,
return 2;
 }
 
+static uint32_t
+parse_table_action_dscp(char **tokens,
+   uint32_t n_tokens,
+   struct softnic_table_rule_action *a)
+{
+   if (n_tokens < 2 ||
+   strcmp(tokens[0], "dscp"))
+   return 0;
+
+   uint8_t dscp_val;
+
+   if (softnic_parser_read_uint8(&dscp_val, tokens[1]))
+   return 0;
+
+   a->dscp.dscp_val = dscp_val;
+
+   a->action_mask |= 1 << RTE_TABLE_ACTION_DSCP;
+
+   return 2;
+}
+
 static uint32_t
 parse_table_action(char **tokens,
uint32_t n_tokens,
@@ -4616,6 +4650,20 @@ parse_table_action(char **tokens,
n_tokens -= n;
}
 
+   if (n_tokens && (strcmp(tokens[0], "dscp") == 0)) {
+   uint32_t n;
+
+   n = parse_table_action_dscp(tokens, n_tokens, a);
+   if (n == 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "action dscp");
+   return 0;
+   }
+
+   tokens += n;
+   n_tokens -= n;
+   }
+
if (n_tokens0 - n_tokens == 1) {
snprintf(out, out_size, MSG_ARG_INVALID, "action");
return 0;
diff --git a/drivers/net/softnic/rte_eth_softnic_internals.h 
b/drivers/net/softnic/rte_eth_softnic_internals.h
index 415434d0d..67ba3ecf3 100644
--- a/drivers/net/softnic/rte_eth_softnic_internals.h
+++ b/drivers/net/softnic/rte_eth_softnic_internals.h
@@ -333,6 +333,7 @@ struct softnic_table_action_profile_params {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 struct softnic_table_action_profile {
@@ -962,6 +963,7 @@ struct softnic_table_rule_action {
struct rte_table_action_tag_params tag;
struct rte_table_action_decap_params decap;
struct rte_table_action_sym_crypto_params sym_crypto;
+   struct rte_table_action_dscp_params dscp;
 };
 
 struct rte_flow {
diff --git a/drivers/net/softnic/rte_eth_s

[dpdk-dev] [PATCH v2 2/3] pipeline: add implementation for DSCP action

[Sheehan,Georgina]

From: Georgina Sheehan 

This allows the application to change the DSCP value of incoming packets

v2: Added in call of function parse_table_action_dscp in softnic cli file

Signed-off-by: Georgina Sheehan 
---
 examples/ip_pipeline/action.c   | 11 +++
 examples/ip_pipeline/action.h   |  1 +
 examples/ip_pipeline/cli.c  | 52 -
 examples/ip_pipeline/pipeline.h |  1 +
 examples/ip_pipeline/thread.c   | 10 +++
 5 files changed, 74 insertions(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index d2104aad6..625c870a2 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -366,6 +366,17 @@ table_action_profile_create(const char *name,
}
}
 
+   if (params->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP)) {
+   status = rte_table_action_profile_action_register(ap,
+   RTE_TABLE_ACTION_DSCP,
+   ¶ms->dscp);
+
+   if (status) {
+   rte_table_action_profile_free(ap);
+   return NULL;
+   }
+   }
+
status = rte_table_action_profile_freeze(ap);
if (status) {
rte_table_action_profile_free(ap);
diff --git a/examples/ip_pipeline/action.h b/examples/ip_pipeline/action.h
index cde17e69a..ea8f81c56 100644
--- a/examples/ip_pipeline/action.h
+++ b/examples/ip_pipeline/action.h
@@ -54,6 +54,7 @@ struct table_action_profile_params {
struct rte_table_action_ttl_config ttl;
struct rte_table_action_stats_config stats;
struct rte_table_action_sym_crypto_config sym_crypto;
+   struct rte_table_action_dscp_config dscp;
 };
 
 struct table_action_profile {
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index a92467e63..ca3083a48 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -1045,7 +1045,8 @@ static const char cmd_table_action_profile_help[] =
 "   [time]\n"
 "   [sym_crypto dev  offset ]\n"
 "   [tag]\n"
-"   [decap]\n";
+"   [decap]\n"
+"   [dscp]\n";
 
 static void
 cmd_table_action_profile(char **tokens,
@@ -1458,6 +1459,17 @@ cmd_table_action_profile(char **tokens,
t0 += 1;
} /* decap */
 
+   if ((t0 < n_tokens) && (strcmp(tokens[t0], "dscp") == 0)) {
+   if (n_tokens < t0 + 1) {
+   snprintf(out, out_size, MSG_ARG_MISMATCH,
+   "table action profile dscp");
+   return;
+   }
+
+   p.action_mask |= 1LLU << RTE_TABLE_ACTION_DSCP;
+   t0 += 1;
+   } /** DSCP **/
+
if (t0 < n_tokens) {
snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);
return;
@@ -3116,6 +3128,7 @@ parse_match(char **tokens,
  *   data_offset ]
  *[tag ]
  *[decap ]
+ *[dscp ]
  *
  * where:
  * ::= g | y | r | drop
@@ -4108,6 +4121,26 @@ parse_table_action_decap(char **tokens,
return 2;
 }
 
+static uint32_t
+parse_table_action_dscp(char **tokens,
+   uint32_t n_tokens,
+   struct table_rule_action *a)
+{
+   if ((n_tokens < 2) ||
+   strcmp(tokens[0], "dscp"))
+   return 0;
+
+   uint8_t dscp_val;
+
+   if (parser_read_uint8(&dscp_val, tokens[1]))
+   return 0;
+
+   a->dscp.dscp_val = dscp_val;
+
+   a->action_mask |= 1 << RTE_TABLE_ACTION_DSCP;
+   return 2;
+}
+
 static uint32_t
 parse_table_action(char **tokens,
uint32_t n_tokens,
@@ -4293,6 +4326,20 @@ parse_table_action(char **tokens,
n_tokens -= n;
}
 
+   if (n_tokens && (strcmp(tokens[0], "dscp") == 0)) {
+   uint32_t n;
+
+   n = parse_table_action_dscp(tokens, n_tokens, a);
+   if (n == 0) {
+   snprintf(out, out_size, MSG_ARG_INVALID,
+   "action dscp");
+   return 0;
+   }
+
+   tokens += n;
+   n_tokens -= n;
+   }
+
if (n_tokens0 - n_tokens == 1) {
snprintf(out, out_size, MSG_ARG_INVALID, "action");
return 0;
@@ -5056,6 +5103,9 @@ table_rule_show(const char *pipeline_name,
if (a->action_mask & (1LLU << RTE_TABLE_ACTION_DECAP))
fprintf(f, "decap %u ", a->decap.n);
 
+   if (a->action_mask & (1LLU << RTE_TABLE_ACTION_DSCP))
+   fprintf(f, "dscp ");
+
/* end */
fprintf(f, "\n");
}
diff --git a/examples/ip_pipeline/pipeline.h b/examples/ip_pipeline/pipeline.h
index 278775c2d..670174ed4 100644
--- a/examples/ip_pipeline/pipeline.h
+++ b/examples/ip_pipeline/pipeline.h
@@ -290,6 +290,7 @@ struct table_rule_action {
struct rte_table_action_sym_crypto_params sym_crypto;
struct rte_ta

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Thomas Monjalon]

12/02/2019 12:43, Bruce Richardson:
> On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote:
> > 12/02/2019 12:31, Bruce Richardson:
> > > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> > > > 06/02/2019 18:08, Luca Boccassi:
> > > > > Whenever possible (if the library ships a pkg-config file) use meson's
> > > > > dependency() function to look for it, as it will automatically add it
> > > > > to the Requires.private list if needed, to allow for static builds to
> > > > > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > > > > dependencies are not parsed, and users doing static builds have to
> > > > > resolve them manually by themselves.
> > > > > When using this API avoid additional checks that are superfluous and
> > > > > take extra time, and avoid adding the linker flag manually which 
> > > > > causes
> > > > > it to be duplicated.
> > > > > 
> > > > > Signed-off-by: Luca Boccassi 
> > > > > Acked-by: Bruce Richardson 
> > > > 
> > > > This patch breaks compilation on my machine with a lot of strange 
> > > > errors:
> > > > 
> > > > from drivers/net/pcap/rte_eth_pcap.c
> > > > 
> > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined
> > > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' 
> > > > qualifier from pointer target type
> > > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive 
> > > > ignored
> > > > etc
> > > >
> > > Is this on Arch linux again? I just reverified these first two patches and
> > > they work fine for me on Fedora (I assume Luca probably tested them 
> > > already on
> > > Debian) 
> > > 
> > > Anything unusual about your setup?
> > 
> > Nothing unusual. Just using the best environment ever ;)
> > I will try to debug it.
> > 
> It may be something pcap-specific, since pcap has to have it's own special
> query mechanims outside the normal pkg-config one. If you remove the
> pcap-driver changes, does the rest of the patch work for you?

Yes, the issue happens only with pcap on Arm.
Reverting the pcap related changes, it builds fine.

More infos about my setup:
meson-0.49.1
aarch64-linux-gnu-gcc-8.2.0
libpcap-1.9.0 (32 and 64-bit) for x86

I think there is a mix between libcap for x86 and Arm compilation.
Probably a meson bug?

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Bruce Richardson]

On Tue, Feb 12, 2019 at 03:47:56PM +0100, Thomas Monjalon wrote:
> 12/02/2019 12:43, Bruce Richardson:
> > On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote:
> > > 12/02/2019 12:31, Bruce Richardson:
> > > > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> > > > > 06/02/2019 18:08, Luca Boccassi:
> > > > > > Whenever possible (if the library ships a pkg-config file) use 
> > > > > > meson's
> > > > > > dependency() function to look for it, as it will automatically add 
> > > > > > it
> > > > > > to the Requires.private list if needed, to allow for static builds 
> > > > > > to
> > > > > > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > > > > > dependencies are not parsed, and users doing static builds have to
> > > > > > resolve them manually by themselves.
> > > > > > When using this API avoid additional checks that are superfluous and
> > > > > > take extra time, and avoid adding the linker flag manually which 
> > > > > > causes
> > > > > > it to be duplicated.
> > > > > > 
> > > > > > Signed-off-by: Luca Boccassi 
> > > > > > Acked-by: Bruce Richardson 
> > > > > 
> > > > > This patch breaks compilation on my machine with a lot of strange 
> > > > > errors:
> > > > > 
> > > > > from drivers/net/pcap/rte_eth_pcap.c
> > > > > 
> > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined
> > > > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 
> > > > > 'const' qualifier from pointer target type
> > > > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive 
> > > > > ignored
> > > > > etc
> > > > >
> > > > Is this on Arch linux again? I just reverified these first two patches 
> > > > and
> > > > they work fine for me on Fedora (I assume Luca probably tested them 
> > > > already on
> > > > Debian) 
> > > > 
> > > > Anything unusual about your setup?
> > > 
> > > Nothing unusual. Just using the best environment ever ;)
> > > I will try to debug it.
> > > 
> > It may be something pcap-specific, since pcap has to have it's own special
> > query mechanims outside the normal pkg-config one. If you remove the
> > pcap-driver changes, does the rest of the patch work for you?
> 
> Yes, the issue happens only with pcap on Arm.
> Reverting the pcap related changes, it builds fine.
> 
> More infos about my setup:
>   meson-0.49.1
>   aarch64-linux-gnu-gcc-8.2.0
>   libpcap-1.9.0 (32 and 64-bit) for x86
> 
> I think there is a mix between libcap for x86 and Arm compilation.
> Probably a meson bug?
> 
Could well be a meson issue. It may be using the local pcap-config rather
than the cross-compilation version [assuming cross-compilation here, though
I don't see the issue with my setup].

Thomas, can you apply this set with the pcap driver change dropped,
or is it better if Luca does a new version of this set?

/Bruce

Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library()

[Thomas Monjalon]

12/02/2019 16:03, Bruce Richardson:
> On Tue, Feb 12, 2019 at 03:47:56PM +0100, Thomas Monjalon wrote:
> > 12/02/2019 12:43, Bruce Richardson:
> > > On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote:
> > > > 12/02/2019 12:31, Bruce Richardson:
> > > > > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote:
> > > > > > 06/02/2019 18:08, Luca Boccassi:
> > > > > > > Whenever possible (if the library ships a pkg-config file) use 
> > > > > > > meson's
> > > > > > > dependency() function to look for it, as it will automatically 
> > > > > > > add it
> > > > > > > to the Requires.private list if needed, to allow for static 
> > > > > > > builds to
> > > > > > > succeed for reverse dependencies of DPDK. Otherwise the recursive
> > > > > > > dependencies are not parsed, and users doing static builds have to
> > > > > > > resolve them manually by themselves.
> > > > > > > When using this API avoid additional checks that are superfluous 
> > > > > > > and
> > > > > > > take extra time, and avoid adding the linker flag manually which 
> > > > > > > causes
> > > > > > > it to be duplicated.
> > > > > > > 
> > > > > > > Signed-off-by: Luca Boccassi 
> > > > > > > Acked-by: Bruce Richardson 
> > > > > > 
> > > > > > This patch breaks compilation on my machine with a lot of strange 
> > > > > > errors:
> > > > > > 
> > > > > > from drivers/net/pcap/rte_eth_pcap.c
> > > > > > 
> > > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined
> > > > > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 
> > > > > > 'const' qualifier from pointer target type
> > > > > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive 
> > > > > > ignored
> > > > > > etc
> > > > > >
> > > > > Is this on Arch linux again? I just reverified these first two 
> > > > > patches and
> > > > > they work fine for me on Fedora (I assume Luca probably tested them 
> > > > > already on
> > > > > Debian) 
> > > > > 
> > > > > Anything unusual about your setup?
> > > > 
> > > > Nothing unusual. Just using the best environment ever ;)
> > > > I will try to debug it.
> > > > 
> > > It may be something pcap-specific, since pcap has to have it's own special
> > > query mechanims outside the normal pkg-config one. If you remove the
> > > pcap-driver changes, does the rest of the patch work for you?
> > 
> > Yes, the issue happens only with pcap on Arm.
> > Reverting the pcap related changes, it builds fine.
> > 
> > More infos about my setup:
> > meson-0.49.1
> > aarch64-linux-gnu-gcc-8.2.0
> > libpcap-1.9.0 (32 and 64-bit) for x86
> > 
> > I think there is a mix between libcap for x86 and Arm compilation.
> > Probably a meson bug?
> > 
> Could well be a meson issue. It may be using the local pcap-config rather
> than the cross-compilation version [assuming cross-compilation here, though
> I don't see the issue with my setup].
> 
> Thomas, can you apply this set with the pcap driver change dropped,
> or is it better if Luca does a new version of this set?

I think we need a comment about the pcap miss.
Probably better to do a new version.

Luca, please could you test cross-compilation?

[dpdk-dev] Arm's roadmap for 19.05 release

[Honnappa Nagarahalli]

Hello,
Following are the features we are working on for 19.05 release:

1) Complete RCU library implementation
2) Enable relaxed memory ordering in spinlock
3) Enable relaxed memory ordering in Reader-Writer lock
4) Enable lock free extended bucket in rte_hash library
5) Introduce ticket-lock

Thank you,
Honnappa

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

[Michael S. Tsirkin]

On Tue, Jan 15, 2019 at 08:55:50AM +, Shahaf Shuler wrote:
> Tuesday, January 15, 2019 10:29 AM, Ilya Maximets:
> > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory
> > ordering feature support
> > 
> > On 15.01.2019 9:33, Shahaf Shuler wrote:
> > > Thursday, January 10, 2019 10:37 PM, Shahaf Shuler:
> > >> Subject: RE: [dpdk-dev] [PATCH v2] net/virtio: add platform memory
> > >> ordering feature support
> > >>
> > >> Wednesday, January 9, 2019 5:50 PM, Michael S. Tsirkin:
> > >>> alejandro.luc...@netronome.com; Daniel Marcovitch
> > >>> 
> > >>> Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory
> > >>> ordering feature support
> > >>>
> > >>> On Wed, Jan 09, 2019 at 05:34:38PM +0300, Ilya Maximets wrote:
> >  virtio_mb() is really heavy. I'd like to avoid it somehow, but I
> >  don't know how to do this yet.
> > >>>
> > >>> Linux driver doesn't avoid it either.
> > >>
> > >> I understand v3 was merged but still would like to continue the
> > >> discuss and make sure all is clear and agreed.
> > >>
> > >> Form patch [1] description it is very clear why we need the
> > >> rte_smp_mb() barrier.
> > >> However I am not sure why this barrier is interoperate into rte_mb in
> > >> case of vDPA.  In vDPA case, both read of the user ring and write of
> > >> the avail index are for local cached memory.
> > >> The only write which is to uncachable memory (device memory) is the
> > >> notify itself.
> > >>
> > >> As I mentioned, there is a need to have a store fence before doing
> > >> the notify, but from different reasons. So vDPA use case and need Is
> > >> a bit different than what presented in [1].
> > >
> > > Any answer?
> > > It is pity if we add redundant barriers which will degrade the driver
> > performance.
> > 
> > Sorry for late responses. Have a lot of work with OVS right now.
> > 
> > Regarding your question.
> > Current code looks like this:
> > 
> >  1. Update ring.
> >  2. virtio_wmb()
> >  3. Update idx.
> >  4. virtio_mb()
> >  5. read flags.
> >  6. notify.
> > 
> > virtio_mb() is here to avoid reordering of steps 3 and 5.
> > i.e. we need a full barrier to ensure the order between store (idx update)
> > and load (reading the flags). Otherwise we could miss the notification.
> > We can't avoid the barrier here, because even x86 does not guarantee the
> > ordering of the local load with earlier local store.
> 
> This is clear. You need the rte_smp_mb() here. My question is why you need 
> the rte_mb() in case of vDPA? 
> As you said, all accesses are local. 

Are you asking why the different barriers? Or as you asking why is a barrier
needed at all?

The barriers themselves are clearly needed.

But in my opinion some dpdk barrier implementations are sub-optimal and too
strong.  For example on intel: the big question is whether anyone does
any non-temporals. In absence of these, and with non-cacheable mappings
on x86 wmb and rmb should be a nop, and mb should be a locked instruction.
It might make sense to add rte_dma_rmb/wmb/mb.




> Pasting you commit code:
> /*
>  * Per virtio_ring.h in Linux.
>  * For virtio_pci on SMP, we don't need to order with respect to MMIO 
>  * accesses through relaxed memory I/O windows, so smp_mb() et al are 
>  * sufficient.
>  *
>  * For using virtio to talk to real devices (eg. vDPA) we do need real
>  * barriers.  
>  */   
> static inline void
> virtio_mb(uint8_t weak_barriers)  
> { 
> if (weak_barriers)
> rte_smp_mb(); 
> else  
> rte_mb(); 
> } 
> 
> > 
> > >
> > >>
> > >> [1]
> > >>
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> > >>
> > tches.dpdk.org%2Fpatch%2F49545%2F&data=02%7C01%7Cshahafs%40
> > mellan
> > >>
> > ox.com%7C01907f1b2e0e4002cb7508d67ac38a98%7Ca652971c7d2e4d9ba6a4
> > d1492
> > >>
> > 56f461b%7C0%7C0%7C636831377591864200&sdata=TSpc%2Fzyq2aq0N3
> > %2Bh4o
> > >> ro4std8ut%2FQU6%2BOeMDeeaQdsM%3D&reserved=0
> > >>
> > >>>
> > >>> --
> > >>> MST
> > >
> > >

Re: [dpdk-dev] [PATCH] test: fix broken "make test"

[Ferruh Yigit]

On 2/12/2019 11:24 AM, Thomas Monjalon wrote:
> 12/02/2019 10:36, Ferruh Yigit:
>> On 2/11/2019 6:38 PM, Rami Rosen wrote:
>>> This patch fixes a broken build; when running
>>> make test
>>> we get the following error:
>>> ...
>>> Traceback (most recent call last):
>>>   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in 
>>> num_fails = runner.run_all_tests()
>>>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
>>> run_all_tests
>>> self.parallel_tests)
>>>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
>>> __filter_test
>>> test_cmd = test["Command"]
>>> KeyError: 'Command'
>>> ...
>>> The reason is that the pdump autotest entry uses "Comamnd"
>>> instead of "Command"; this patch fixes it.
>>>
>>> Bugzilla ID: 205
>>> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
>>> Signed-off-by: Rami Rosen 
>>
>> Reviewed-by: Ferruh Yigit 
>>
>> Good catch! But it seems 19.02 released autotest broken, so this needs to be
>> backported to 19.02:
>>
>> Cc: sta...@dpdk.org
> 
> Applied, thanks
> 
> 
>> Thomas,
>> What do you think adding autotest into DPDK community lab testing? I will 
>> bring
>> the the suggestion in next meeting.
> 
> Yes, sure.
> It has already been discussed but no task was created:
>   https://bugs.dpdk.org/buglist.cgi?product=lab
> Let's follow-up in next meeting.

It has been discussed again, and following task created for lab:
https://bugs.dpdk.org/show_bug.cgi?id=212

[dpdk-dev] [PATCH] net/bnxt: support IOVA VA mode

[Davide Caratti]

Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags: this allows initializing bnxt
PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be
acccessed without CAP_SYS_ADMIN privileges.

Cc: sta...@dpdk.org
Signed-off-by: Davide Caratti 
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 801c6ffad..189527207 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3548,7 +3548,7 @@ static int bnxt_pci_remove(struct rte_pci_device *pci_dev)
 static struct rte_pci_driver bnxt_rte_pmd = {
.id_table = bnxt_pci_id_map,
.drv_flags = RTE_PCI_DRV_NEED_MAPPING |
-   RTE_PCI_DRV_INTR_LSC,
+   RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_IOVA_AS_VA,
.probe = bnxt_pci_probe,
.remove = bnxt_pci_remove,
 };
-- 
2.20.1

Re: [dpdk-dev] [PATCH] net/bnxt: support IOVA VA mode

[Ajit Khaparde]

On Tue, Feb 12, 2019 at 10:30 AM Davide Caratti  wrote:

> Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags: this allows initializing bnxt
> PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be
> acccessed without CAP_SYS_ADMIN privileges.
>
> Cc: sta...@dpdk.org
> Signed-off-by: Davide Caratti 
>
Acked-by: Ajit Khaparde 


> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 801c6ffad..189527207 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3548,7 +3548,7 @@ static int bnxt_pci_remove(struct rte_pci_device
> *pci_dev)
>  static struct rte_pci_driver bnxt_rte_pmd = {
> .id_table = bnxt_pci_id_map,
> .drv_flags = RTE_PCI_DRV_NEED_MAPPING |
> -   RTE_PCI_DRV_INTR_LSC,
> +   RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_IOVA_AS_VA,
> .probe = bnxt_pci_probe,
> .remove = bnxt_pci_remove,
>  };
> --
> 2.20.1
>
>

[dpdk-dev] [PATCH 0/4] fix test of some build options

[Thomas Monjalon]

When using the "make" system which allows a huge number of
build combinations, some options were not tested with
the script test-build.sh.


Thomas Monjalon (4):
  mk: fix build of shared library with libbsd
  devtools: add libelf dependency to build test
  devtools: test build of zlib PMD
  devtools: fix test of some build options

 devtools/test-build.sh   | 12 +---
 mk/exec-env/linuxapp/rte.vars.mk |  6 ++
 mk/rte.app.mk|  3 ---
 mk/rte.lib.mk|  2 ++
 4 files changed, 17 insertions(+), 6 deletions(-)

-- 
2.20.1

[dpdk-dev] [PATCH 2/4] devtools: add libelf dependency to build test

[Thomas Monjalon]

The option CONFIG_RTE_LIBRTE_BPF_ELF was never enabled
with test-build.sh.
It is fixed with the environment variable DPDK_DEP_ELF.

Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF object 
file")
Cc: konstantin.anan...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Thomas Monjalon 
---
 devtools/test-build.sh | 4 
 1 file changed, 4 insertions(+)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 42f4ad003..ace52a776 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -9,6 +9,7 @@ default_path=$PATH
 # - DPDK_BUILD_TEST_CONFIGS (defconfig1+option1+option2 defconfig2)
 # - DPDK_DEP_ARCHIVE
 # - DPDK_DEP_CFLAGS
+# - DPDK_DEP_ELF (y/[n])
 # - DPDK_DEP_ISAL (y/[n])
 # - DPDK_DEP_JSON (y/[n])
 # - DPDK_DEP_LDFLAGS
@@ -96,6 +97,7 @@ reset_env ()
unset CROSS
unset DPDK_DEP_ARCHIVE
unset DPDK_DEP_CFLAGS
+   unset DPDK_DEP_ELF
unset DPDK_DEP_ISAL
unset DPDK_DEP_JSON
unset DPDK_DEP_LDFLAGS
@@ -186,6 +188,8 @@ config () #   
sed -ri  's,(MVPP2_PMD=)n,\1y,' $1/.config
test -z "$LIBMUSDK_PATH" || \
sed -ri 's,(MVNETA_PMD=)n,\1y,' $1/.config
+   test "$DPDK_DEP_ELF" != y || \
+   sed -ri's,(BPF_ELF=)n,\1y,' $1/.config
test -z "$DPDK_DEP_JSON" || \
sed -ri  's,(TELEMETRY=)n,\1y,' $1/.config
build_config_hook $1 $2 $3
-- 
2.20.1

[dpdk-dev] [PATCH 1/4] mk: fix build of shared library with libbsd

[Thomas Monjalon]

When building DPDK with "make" and options
CONFIG_RTE_USE_LIBBSD=y
and
CONFIG_RTE_BUILD_SHARED_LIB=y
libbsd was not linked, resulting in compilation errors:
undefined reference to `strlcpy'

The link option -lbsd is added in a common place for both
Linux apps and libs.
It is used in app linkage via EXECENV_LDLIBS,
and in lib linkage via the added variable EXECENV_LDLIBS-y.

Fixes: 5364de644a4b ("eal: support strlcpy function")
Cc: bruce.richard...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Thomas Monjalon 
---
 mk/exec-env/linuxapp/rte.vars.mk | 6 ++
 mk/rte.app.mk| 3 ---
 mk/rte.lib.mk| 2 ++
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/mk/exec-env/linuxapp/rte.vars.mk b/mk/exec-env/linuxapp/rte.vars.mk
index 3129edc8c..57ee82150 100644
--- a/mk/exec-env/linuxapp/rte.vars.mk
+++ b/mk/exec-env/linuxapp/rte.vars.mk
@@ -24,6 +24,8 @@ ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
 EXECENV_LDLIBS += -lgcc_s
 endif
 
+EXECENV_LDLIBS-$(CONFIG_RTE_USE_LIBBSD) += -lbsd
+
 # force applications to link with gcc/icc instead of using ld
 LINK_USING_CC := 1
 
@@ -32,4 +34,8 @@ EXECENV_LDFLAGS += -export-dynamic
 # Add library to the group to resolve symbols
 EXECENV_LDLIBS  += -ldl
 
+# EXECENV_LDLIBS-y applies to lib.so and app linking
+# while EXECENV_LDLIBS applies only to app linking.
+EXECENV_LDLIBS += $(EXECENV_LDLIBS-y)
+
 export EXECENV_CFLAGS EXECENV_LDFLAGS EXECENV_ASFLAGS EXECENV_LDLIBS
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 8a4f0f4e5..d0ab942d5 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -309,9 +309,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)+= -lrt
 ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP)$(CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES),yy)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)+= -lnuma
 endif
-ifeq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP)$(CONFIG_RTE_USE_LIBBSD),yy)
-_LDLIBS-$(CONFIG_RTE_LIBRTE_EAL)+= -lbsd
-endif
 _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)  += -lm
 _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED)  += -lrt
 _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMBER) += -lm
diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk
index c696a2174..4df8849a0 100644
--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -35,6 +35,8 @@ PREINSTALL = $(SYMLINK-FILES-y)
 _INSTALL = $(INSTALL-FILES-y) $(RTE_OUTPUT)/lib/$(LIB)
 _CLEAN = doclean
 
+LDLIBS += $(EXECENV_LDLIBS-y)
+
 .PHONY: all
 all: install
 
-- 
2.20.1

[dpdk-dev] [PATCH 3/4] devtools: test build of zlib PMD

[Thomas Monjalon]

The PMD zlib was not enabled in devtools/test-build.sh.
It is fixed by using the environment variable DPDK_DEP_ZLIB.

Fixes: 0c4e4c16b004 ("compress/zlib: introduce zlib PMD")
Cc: ashish.gu...@caviumnetworks.com
Cc: sta...@dpdk.org

Signed-off-by: Thomas Monjalon 
---
 devtools/test-build.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index ace52a776..0511ae6d0 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -158,6 +158,8 @@ config () #   
test "$DPDK_DEP_ZLIB" != y || \
sed -ri  's,(BNX2X_PMD=)n,\1y,' $1/.config
test "$DPDK_DEP_ZLIB" != y || \
+   sed -ri   's,(PMD_ZLIB=)n,\1y,' $1/.config
+   test "$DPDK_DEP_ZLIB" != y || \
sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
test "$DPDK_DEP_PCAP" != y || \
sed -ri   's,(PCAP=)n,\1y,' $1/.config
-- 
2.20.1

[dpdk-dev] [PATCH 4/4] devtools: fix test of some build options

[Thomas Monjalon]

CONFIG_RTE_LIBRTE_PMD_ISAL was not tested because of a typo.

CONFIG_RTE_LIBRTE_PMD_QAT_SYM was not tested since it has been
introduced and made CONFIG_RTE_LIBRTE_PMD_QAT enabled by default.

While at it, DPDK_DEP_JSON is now checked for "y",
as other DPDK_DEP_* variables, instead of non-empty.

Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD")
Cc: lee.d...@intel.com
Fixes: 7a34c2155716 ("compress/qat: add empty driver")
Cc: fiona.tr...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Thomas Monjalon 
---
 devtools/test-build.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 0511ae6d0..d37b121ca 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -150,7 +150,7 @@ config () #   
test "$DPDK_DEP_ARCHIVE" != y || \
sed -ri   's,(RESOURCE_TAR=)n,\1y,' $1/.config
test "$DPDK_DEP_ISAL" != y || \
-   sed -ri   's,(ISAL_PMD=)n,\1y,' $1/.config
+   sed -ri   's,(PMD_ISAL=)n,\1y,' $1/.config
test "$DPDK_DEP_MLX" != y || \
sed -ri   's,(MLX._PMD=)n,\1y,' $1/.config
test "$DPDK_DEP_SZE" != y || \
@@ -180,7 +180,7 @@ config () #   
test "$DPDK_DEP_SSL" != y || \
sed -ri's,(PMD_OPENSSL=)n,\1y,' $1/.config
test "$DPDK_DEP_SSL" != y || \
-   sed -ri's,(PMD_QAT=)n,\1y,' $1/.config
+   sed -ri's,(QAT_SYM=)n,\1y,' $1/.config
test -z "$FLEXRAN_SDK" || \
sed -ri 's,(BBDEV_TURBO_SW=)n,\1y,' $1/.config
sed -ri   's,(SCHED_.*=)n,\1y,' $1/.config
@@ -192,7 +192,7 @@ config () #   
sed -ri 's,(MVNETA_PMD=)n,\1y,' $1/.config
test "$DPDK_DEP_ELF" != y || \
sed -ri's,(BPF_ELF=)n,\1y,' $1/.config
-   test -z "$DPDK_DEP_JSON" || \
+   test "$DPDK_DEP_JSON" != y || \
sed -ri  's,(TELEMETRY=)n,\1y,' $1/.config
build_config_hook $1 $2 $3
 
-- 
2.20.1

[dpdk-dev] [PATCH] net/ixgbe: fix crash when on remove

[wangyunjian]

From: Yunjian Wang 

The nic's interrupt source has some active handler, when the
port remove. We should cancel the delay handler before remove
dev to prevent executing the delay handler.

Call Trace:
  #0  ixgbe_disable_intr (hw=0x0, hw=0x0)
  at /usr/src/debug/dpdk-18.11/drivers/net/ixgbe/ixgbe_ethdev.c:852
  #1  ixgbe_dev_interrupt_delayed_handler (param=0xadb9c0
  )
  at /usr/src/debug/dpdk-18.11/drivers/net/ixgbe/ixgbe_ethdev.c:4386
  #2  0x7f05782147af in eal_alarm_callback (arg=)
  at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/
  eal_alarm.c:90
  #3  0x7f057821320a in eal_intr_process_interrupts (nfds=1,
  events=0x7f056cbf3e88) at /usr/src/debug/dpdk-18.11/lib/
  librte_eal/linuxapp/eal/eal_interrupts.c:838
  #4  eal_intr_handle_interrupts (totalfds=, pfd=18)
  at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/
  eal_interrupts.c:885
  #5  eal_intr_thread_main (arg=)
  at /usr/src/debug/dpdk-18.11/lib/librte_eal/linuxapp/eal/
  eal_interrupts.c:965
  #6  0x7f05708a0e45 in start_thread () from /usr/lib64/libpthread.so.0
  #7  0x7f056eb4ab5d in clone () from /usr/lib64/libc.so.6

Fixes: 2866c5f1b87e ("ixgbe: support port hotplug")
Cc: sta...@dpdk.org

Signed-off-by: Yunjian Wang 
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 7493110..e9533e5 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1336,6 +1336,9 @@ struct rte_ixgbe_xstats_name_off {
rte_delay_ms(100);
} while (retries++ < (10 + IXGBE_LINK_UP_TIME));
 
+   /* cancel the delay handler before remove dev */
+   rte_eal_alarm_cancel(ixgbe_dev_interrupt_delayed_handler, eth_dev);
+
/* uninitialize PF if max_vfs not zero */
ixgbe_pf_host_uninit(eth_dev);
 
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH] net/ice: fix segment fault

[Zhang, Qi Z]

> -Original Message-
> From: Lu, Wenzhuo
> Sent: Friday, February 1, 2019 9:36 AM
> To: Zhang, Qi Z ; Yang, Qiming 
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/ice: fix segment fault
> 
> Hi,
> 
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Wednesday, January 30, 2019 4:24 PM
> > To: Lu, Wenzhuo ; Yang, Qiming
> > 
> > Cc: dev@dpdk.org; Zhang, Qi Z 
> > Subject: [PATCH] net/ice: fix segment fault
> >
> > Fix segment fault when detach a device due to some redundant function
> > call in ice_dev_uninit.
> >
> > Fixes: f9cf4f864150 ("net/ice: support device initialization")
> >
> > Signed-off-by: Qi Zhang 
> Acked-by: Wenzhuo Lu 

Applied to dpdk-next-net-intel.

Thanks
Qi

Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF

[Zhao1, Wei]

> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, February 13, 2019 11:35 AM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo 
> Subject: RE: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF
> 
> 
> 
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Wednesday, January 16, 2019 1:02 PM
> > To: dev@dpdk.org
> > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z
> > ; Zhao1, Wei 
> > Subject: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF
> >
> > There is need to enable two ops of promiscuous_enable and
> > promiscuous_disable on VF.
> >
> > Fixes: af75078fece3 ("first public release")
> 
> I think this is not a fix, we just add some feature not be implemented.
> 
> Btw, you need to update doc/guides/nics/features/ixgbe_vf.ini

Ok, I will update in v3

> 
> >
> > Signed-off-by: Wei Zhao 
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 20 
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 91ba620..e8a2c6e 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -260,6 +260,8 @@ static int
> > ixgbevf_dev_rx_queue_intr_disable(struct
> > rte_eth_dev *dev,  static void ixgbevf_set_ivar_map(struct ixgbe_hw
> > *hw, int8_t direction,
> >  uint8_t queue, uint8_t msix_vector);  static
> void
> > ixgbevf_configure_msix(struct rte_eth_dev *dev);
> > +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);
> > +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);
> >  static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev);
> > static void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev);
> >
> > @@ -596,6 +598,8 @@ static const struct eth_dev_ops
> ixgbevf_eth_dev_ops = {
> > .xstats_get_names = ixgbevf_dev_xstats_get_names,
> > .dev_close= ixgbevf_dev_close,
> > .dev_reset= ixgbevf_dev_reset,
> > +   .promiscuous_enable   = ixgbevf_dev_promiscuous_enable,
> > +   .promiscuous_disable  = ixgbevf_dev_promiscuous_disable,
> > .allmulticast_enable  = ixgbevf_dev_allmulticast_enable,
> > .allmulticast_disable = ixgbevf_dev_allmulticast_disable,
> > .dev_infos_get= ixgbevf_dev_info_get,
> > @@ -8290,6 +8294,22 @@ ixgbe_dev_udp_tunnel_port_del(struct
> > rte_eth_dev *dev,  }
> >
> >  static void
> > +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) {
> > +   struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > +
> > +   hw->mac.ops.update_xcast_mode(hw,
> > IXGBEVF_XCAST_MODE_PROMISC); }
> > +
> > +static void
> > +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) {
> > +   struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > +
> > +   hw->mac.ops.update_xcast_mode(hw,
> IXGBEVF_XCAST_MODE_NONE); }
> > +
> > +static void
> >  ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)  {
> > struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > --
> > 2.7.5

Re: [dpdk-dev] [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF

[Zhang, Qi Z]

> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, January 16, 2019 1:02 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z
> ; Zhao1, Wei 
> Subject: [PATCH v2 1/3] net/ixgbe: promiscuous mode enable on VF
> 
> There is need to enable two ops of promiscuous_enable and
> promiscuous_disable on VF.
> 
> Fixes: af75078fece3 ("first public release")

I think this is not a fix, we just add some feature not be implemented.

Btw, you need to update doc/guides/nics/features/ixgbe_vf.ini

> 
> Signed-off-by: Wei Zhao 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 20 
>  1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 91ba620..e8a2c6e 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -260,6 +260,8 @@ static int ixgbevf_dev_rx_queue_intr_disable(struct
> rte_eth_dev *dev,  static void ixgbevf_set_ivar_map(struct ixgbe_hw *hw,
> int8_t direction,
>uint8_t queue, uint8_t msix_vector);  static 
> void
> ixgbevf_configure_msix(struct rte_eth_dev *dev);
> +static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);
> +static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);
>  static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev);  static
> void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev);
> 
> @@ -596,6 +598,8 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
>   .xstats_get_names = ixgbevf_dev_xstats_get_names,
>   .dev_close= ixgbevf_dev_close,
>   .dev_reset= ixgbevf_dev_reset,
> + .promiscuous_enable   = ixgbevf_dev_promiscuous_enable,
> + .promiscuous_disable  = ixgbevf_dev_promiscuous_disable,
>   .allmulticast_enable  = ixgbevf_dev_allmulticast_enable,
>   .allmulticast_disable = ixgbevf_dev_allmulticast_disable,
>   .dev_infos_get= ixgbevf_dev_info_get,
> @@ -8290,6 +8294,22 @@ ixgbe_dev_udp_tunnel_port_del(struct rte_eth_dev
> *dev,  }
> 
>  static void
> +ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev) {
> + struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + hw->mac.ops.update_xcast_mode(hw,
> IXGBEVF_XCAST_MODE_PROMISC); }
> +
> +static void
> +ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev) {
> + struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +
> + hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE); }
> +
> +static void
>  ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)  {
>   struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> --
> 2.7.5

Re: [dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host

[Zhang, Qi Z]

> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, January 16, 2019 1:02 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z
> ; Zhao1, Wei 
> Subject: [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host
> 

The title is misleading, we are going to support VF's promiscuous mode but not 
PF.

How about "Add VF promiscuous mode support when PF as host"

> There is need to PF host promiscuous mode enable. For ixgbe, in order to
> support VF vlan promiscuous or unicast promiscuous, we need to set PF host
> register PFVML2FLT of bit UPE and VPE.
> It also align to ixgbe kernel code version 5.5.3.
> 
> Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mode on VF")

Same to previous patch, not a fix.
> 
> Signed-off-by: Wei Zhao 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
>  drivers/net/ixgbe/ixgbe_pf.c | 78
> 
>  2 files changed, 57 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> b/drivers/net/ixgbe/ixgbe_ethdev.h
> index d0b9396..e81f152 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> @@ -265,6 +265,7 @@ struct ixgbe_vf_info {
>   uint8_t spoofchk_enabled;
>   uint8_t api_version;
>   uint16_t switch_domain_id;
> + uint16_t xcast_mode;
>  };
> 
>  /*
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> 4b833ff..c9d1a1c 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -408,23 +408,6 @@ ixgbe_vf_reset_msg(struct rte_eth_dev *dev, uint16_t
> vf)  }
> 
>  static int
> -ixgbe_enable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf) -{
> - struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> - uint32_t vmolr;
> -
> - vmolr = IXGBE_READ_REG(hw, IXGBE_VMOLR(vf));
> -
> - RTE_LOG(INFO, PMD, "VF %u: enabling multicast promiscuous\n", vf);
> -
> - vmolr |= IXGBE_VMOLR_MPE;
> -
> - IXGBE_WRITE_REG(hw, IXGBE_VMOLR(vf), vmolr);
> -
> - return 0;
> -}
> -
> -static int
>  ixgbe_disable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf)  {
>   struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> @@ -688,19 +671,70 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev,
> uint32_t vf, uint32_t *msgbuf)  {
>   struct ixgbe_vf_info *vfinfo =
>   *(IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private));
> - bool enable = !!msgbuf[1];  /* msgbuf contains the flag to enable */
> + struct ixgbe_hw *hw =
> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> + int xcast_mode = msgbuf[1]; /* msgbuf contains the flag to enable */
> + u32 vmolr, fctrl, disable, enable;
> 
>   switch (vfinfo[vf].api_version) {
>   case ixgbe_mbox_api_12:
> + /* promisc introduced in 1.3 version */
> + if (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)
> + return -EOPNOTSUPP;
> + break;
> + /* Fall threw */
> + case ixgbe_mbox_api_13:
>   break;
>   default:
>   return -1;
>   }
> 
> - if (enable)
> - return ixgbe_enable_vf_mc_promisc(dev, vf);
> - else
> - return ixgbe_disable_vf_mc_promisc(dev, vf);
> + if (vfinfo[vf].xcast_mode == xcast_mode)
> + goto out;
> +
> + switch (xcast_mode) {
> + case IXGBEVF_XCAST_MODE_NONE:
> + disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
> +   IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE |
> IXGBE_VMOLR_VPE;
> + enable = 0;
> + break;
> + case IXGBEVF_XCAST_MODE_MULTI:
> + disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE |
> IXGBE_VMOLR_VPE;
> + enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE;
> + break;
> + case IXGBEVF_XCAST_MODE_ALLMULTI:
> + disable = IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
> + enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
> IXGBE_VMOLR_MPE;
> + break;
> + case IXGBEVF_XCAST_MODE_PROMISC:
> + if (hw->mac.type <= ixgbe_mac_82599EB)
> + return -1;
> +
> + fctrl = IXGBE_READ_REG(hw, IXGBE_FCTRL);
> + if (!(fctrl & IXGBE_FCTRL_UPE)) {
> + /* VF promisc requires PF in promisc */
> + RTE_LOG(ERR, PMD,
> +"Enabling VF promisc requires PF in promisc\n");
> + return -1;
> + }
> +
> + disable = 0;
> + enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
> +  IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE |
> IXGBE_VMOLR_VPE;
> + break;
> + default:
> + return -1;
> + }
> +
> + vmolr = IXGBE_READ_REG(hw, IXGBE_VMOLR(vf));
> + vmolr &= ~disable;
> + vmolr |= enable;
> + IXGBE_WRITE_REG(hw, IXGBE_VMOLR(vf), vmolr);
> + vfinfo[vf].xcast_

Re: [dpdk-dev] [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host

[Zhao1, Wei]

> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, February 13, 2019 11:42 AM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo 
> Subject: RE: [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host
> 
> 
> 
> > -Original Message-
> > From: Zhao1, Wei
> > Sent: Wednesday, January 16, 2019 1:02 PM
> > To: dev@dpdk.org
> > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z
> > ; Zhao1, Wei 
> > Subject: [PATCH v2 2/3] net/ixgbe: enable promiscuous mode on PF host
> >
> 
> The title is misleading, we are going to support VF's promiscuous mode but
> not PF.
> 
> How about "Add VF promiscuous mode support when PF as host"

Get, update in v3

> 
> > There is need to PF host promiscuous mode enable. For ixgbe, in order
> > to support VF vlan promiscuous or unicast promiscuous, we need to set
> > PF host register PFVML2FLT of bit UPE and VPE.
> > It also align to ixgbe kernel code version 5.5.3.
> >
> > Fixes: 72dec9e37a84 ("ixgbe: support multicast promiscuous mode on
> > VF")
> 
> Same to previous patch, not a fix.
> >
> > Signed-off-by: Wei Zhao 
> > ---
> >  drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
> >  drivers/net/ixgbe/ixgbe_pf.c | 78
> > 
> >  2 files changed, 57 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h
> > b/drivers/net/ixgbe/ixgbe_ethdev.h
> > index d0b9396..e81f152 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.h
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h
> > @@ -265,6 +265,7 @@ struct ixgbe_vf_info {
> > uint8_t spoofchk_enabled;
> > uint8_t api_version;
> > uint16_t switch_domain_id;
> > +   uint16_t xcast_mode;
> >  };
> >
> >  /*
> > diff --git a/drivers/net/ixgbe/ixgbe_pf.c
> > b/drivers/net/ixgbe/ixgbe_pf.c index 4b833ff..c9d1a1c 100644
> > --- a/drivers/net/ixgbe/ixgbe_pf.c
> > +++ b/drivers/net/ixgbe/ixgbe_pf.c
> > @@ -408,23 +408,6 @@ ixgbe_vf_reset_msg(struct rte_eth_dev *dev,
> > uint16_t
> > vf)  }
> >
> >  static int
> > -ixgbe_enable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf) -{
> > -   struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > -   uint32_t vmolr;
> > -
> > -   vmolr = IXGBE_READ_REG(hw, IXGBE_VMOLR(vf));
> > -
> > -   RTE_LOG(INFO, PMD, "VF %u: enabling multicast promiscuous\n", vf);
> > -
> > -   vmolr |= IXGBE_VMOLR_MPE;
> > -
> > -   IXGBE_WRITE_REG(hw, IXGBE_VMOLR(vf), vmolr);
> > -
> > -   return 0;
> > -}
> > -
> > -static int
> >  ixgbe_disable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf)  {
> > struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > @@ -688,19 +671,70 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev
> *dev,
> > uint32_t vf, uint32_t *msgbuf)  {
> > struct ixgbe_vf_info *vfinfo =
> > *(IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data-
> >dev_private));
> > -   bool enable = !!msgbuf[1];  /* msgbuf contains the flag to enable
> */
> > +   struct ixgbe_hw *hw =
> > IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > +   int xcast_mode = msgbuf[1]; /* msgbuf contains the flag to enable
> */
> > +   u32 vmolr, fctrl, disable, enable;
> >
> > switch (vfinfo[vf].api_version) {
> > case ixgbe_mbox_api_12:
> > +   /* promisc introduced in 1.3 version */
> > +   if (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)
> > +   return -EOPNOTSUPP;
> > +   break;
> > +   /* Fall threw */
> > +   case ixgbe_mbox_api_13:
> > break;
> > default:
> > return -1;
> > }
> >
> > -   if (enable)
> > -   return ixgbe_enable_vf_mc_promisc(dev, vf);
> > -   else
> > -   return ixgbe_disable_vf_mc_promisc(dev, vf);
> > +   if (vfinfo[vf].xcast_mode == xcast_mode)
> > +   goto out;
> > +
> > +   switch (xcast_mode) {
> > +   case IXGBEVF_XCAST_MODE_NONE:
> > +   disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
> > + IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE |
> > IXGBE_VMOLR_VPE;
> > +   enable = 0;
> > +   break;
> > +   case IXGBEVF_XCAST_MODE_MULTI:
> > +   disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE |
> > IXGBE_VMOLR_VPE;
> > +   enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE;
> > +   break;
> > +   case IXGBEVF_XCAST_MODE_ALLMULTI:
> > +   disable = IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
> > +   enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
> > IXGBE_VMOLR_MPE;
> > +   break;
> > +   case IXGBEVF_XCAST_MODE_PROMISC:
> > +   if (hw->mac.type <= ixgbe_mac_82599EB)
> > +   return -1;
> > +
> > +   fctrl = IXGBE_READ_REG(hw, IXGBE_FCTRL);
> > +   if (!(fctrl & IXGBE_FCTRL_UPE)) {
> > +   /* VF promisc requires PF in promisc */
> > +   RTE_LOG(ERR, PMD,
> > +  "Enabling VF promisc requires PF in promisc\n");
> > +   return -1;
> > +   }
> > +
> > +   disa

Re: [dpdk-dev] [PATCH v2 3/3] net/ixgbe: update API version

[Zhang, Qi Z]

I think this patch should be merged with PATCH 2/3, since "ixgbe_mbox_api_13" 
is already be referenced on that patch.

> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, January 16, 2019 1:02 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo ; Zhang, Qi Z
> ; Zhao1, Wei 
> Subject: [PATCH v2 3/3] net/ixgbe: update API version
> 
> There is need to update to latest API version in order for negotiation 
> between pf
> and vf, then new API message can be supported.
> 
> Fixes: 88fccb7a05c6 ("ixgbevf: fix jumbo frame")
> 
> Signed-off-by: Wei Zhao 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
>  drivers/net/ixgbe/ixgbe_pf.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index e8a2c6e..a25178a 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1512,6 +1512,7 @@ ixgbevf_negotiate_api(struct ixgbe_hw *hw)
> 
>   /* start with highest supported, proceed down */
>   static const enum ixgbe_pfvf_api_rev sup_ver[] = {
> + ixgbe_mbox_api_13,
>   ixgbe_mbox_api_12,
>   ixgbe_mbox_api_11,
>   ixgbe_mbox_api_10,
> diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index
> c9d1a1c..a6d8501 100644
> --- a/drivers/net/ixgbe/ixgbe_pf.c
> +++ b/drivers/net/ixgbe/ixgbe_pf.c
> @@ -569,6 +569,7 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev,
> uint32_t vf, uint32_t *msgbuf)
>   case ixgbe_mbox_api_10:
>   case ixgbe_mbox_api_11:
>   case ixgbe_mbox_api_12:
> + case ixgbe_mbox_api_13:
>   vfinfo[vf].api_version = (uint8_t)api_version;
>   return 0;
>   default:
> --
> 2.7.5

[dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support

[Wei Zhao]

There is need to check whether dev_conf.rxmode.offloads is
set when start ice device, if one of the vlan related bits
is set, for example DEV_RX_OFFLOAD_VLAN_FILTER and so on,
sevice start process to enable this offloads request.

Signed-off-by: Wei Zhao 

---

v2:
-rework patch for compile error.
---
 drivers/net/avf/avf_ethdev.c |  2 +-
 drivers/net/ice/ice_ethdev.c | 10 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 13eec1b..797f505 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -1159,7 +1159,7 @@ avf_enable_irq0(struct avf_hw *hw)
AVF_WRITE_REG(hw, AVFINT_ICR0_ENA1, AVFINT_ICR0_ENA1_ADMINQ_MASK);
 
AVF_WRITE_REG(hw, AVFINT_DYN_CTL01, AVFINT_DYN_CTL01_INTENA_MASK |
-   AVFINT_DYN_CTL01_ITR_INDX_MASK);
+   AVFINT_DYN_CTL01_CLEARPBA_MASK | 
AVFINT_DYN_CTL01_ITR_INDX_MASK);
 
AVF_WRITE_FLUSH(hw);
 }
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 6ab66fa..5753d79 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1720,7 +1720,7 @@ ice_dev_start(struct rte_eth_dev *dev)
struct ice_vsi *vsi = pf->main_vsi;
uint16_t nb_rxq = 0;
uint16_t nb_txq, i;
-   int ret;
+   int mask, ret;
 
/* program Tx queues' context in hardware */
for (nb_txq = 0; nb_txq < data->nb_tx_queues; nb_txq++) {
@@ -1748,6 +1748,14 @@ ice_dev_start(struct rte_eth_dev *dev)
 
ice_set_rx_function(dev);
 
+   mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
+   ETH_VLAN_EXTEND_MASK;
+   ret = ice_vlan_offload_set(dev, mask);
+   if (ret) {
+   PMD_INIT_LOG(ERR, "Unable to set VLAN offload");
+   goto rx_err;
+   }
+
/* enable Rx interrput and mapping Rx queue to interrupt vector */
if (ice_rxq_intr_setup(dev))
return -EIO;
-- 
2.7.5

Re: [dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support

[Zhao1, Wei]

Error patch, please ignore it.

> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, February 13, 2019 11:30 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei
> 
> Subject: [PATCH v2] net/ice: enable VLAN filter offloads support
> 
> There is need to check whether dev_conf.rxmode.offloads is set when start
> ice device, if one of the vlan related bits is set, for example
> DEV_RX_OFFLOAD_VLAN_FILTER and so on, sevice start process to enable
> this offloads request.
> 
> Signed-off-by: Wei Zhao 
> 
> ---
> 
> v2:
> -rework patch for compile error.
> ---
>  drivers/net/avf/avf_ethdev.c |  2 +-
>  drivers/net/ice/ice_ethdev.c | 10 +-
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
> index 13eec1b..797f505 100644
> --- a/drivers/net/avf/avf_ethdev.c
> +++ b/drivers/net/avf/avf_ethdev.c
> @@ -1159,7 +1159,7 @@ avf_enable_irq0(struct avf_hw *hw)
>   AVF_WRITE_REG(hw, AVFINT_ICR0_ENA1,
> AVFINT_ICR0_ENA1_ADMINQ_MASK);
> 
>   AVF_WRITE_REG(hw, AVFINT_DYN_CTL01,
> AVFINT_DYN_CTL01_INTENA_MASK |
> -
> AVFINT_DYN_CTL01_ITR_INDX_MASK);
> + AVFINT_DYN_CTL01_CLEARPBA_MASK |
> AVFINT_DYN_CTL01_ITR_INDX_MASK);
> 
>   AVF_WRITE_FLUSH(hw);
>  }
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 6ab66fa..5753d79 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1720,7 +1720,7 @@ ice_dev_start(struct rte_eth_dev *dev)
>   struct ice_vsi *vsi = pf->main_vsi;
>   uint16_t nb_rxq = 0;
>   uint16_t nb_txq, i;
> - int ret;
> + int mask, ret;
> 
>   /* program Tx queues' context in hardware */
>   for (nb_txq = 0; nb_txq < data->nb_tx_queues; nb_txq++) { @@ -
> 1748,6 +1748,14 @@ ice_dev_start(struct rte_eth_dev *dev)
> 
>   ice_set_rx_function(dev);
> 
> + mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
> + ETH_VLAN_EXTEND_MASK;
> + ret = ice_vlan_offload_set(dev, mask);
> + if (ret) {
> + PMD_INIT_LOG(ERR, "Unable to set VLAN offload");
> + goto rx_err;
> + }
> +
>   /* enable Rx interrput and mapping Rx queue to interrupt vector */
>   if (ice_rxq_intr_setup(dev))
>   return -EIO;
> --
> 2.7.5

[dpdk-dev] [PATCH v2] net/ice: enable VLAN filter offloads support

[Wei Zhao]

There is need to check whether dev_conf.rxmode.offloads is
set when start ice device, if one of the vlan related bits
is set, for example DEV_RX_OFFLOAD_VLAN_FILTER and so on,
sevice start process to enable this offloads request.

Signed-off-by: Wei Zhao 

---

v2:
-rework patch for compile error.
---
 drivers/net/ice/ice_ethdev.c | 10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 6b0113b..a23c63a 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1714,7 +1714,7 @@ ice_dev_start(struct rte_eth_dev *dev)
struct ice_vsi *vsi = pf->main_vsi;
uint16_t nb_rxq = 0;
uint16_t nb_txq, i;
-   int ret;
+   int mask, ret;
 
/* program Tx queues' context in hardware */
for (nb_txq = 0; nb_txq < data->nb_tx_queues; nb_txq++) {
@@ -1742,6 +1742,14 @@ ice_dev_start(struct rte_eth_dev *dev)
 
ice_set_rx_function(dev);
 
+   mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
+   ETH_VLAN_EXTEND_MASK;
+   ret = ice_vlan_offload_set(dev, mask);
+   if (ret) {
+   PMD_INIT_LOG(ERR, "Unable to set VLAN offload");
+   goto rx_err;
+   }
+
/* enable Rx interrput and mapping Rx queue to interrupt vector */
if (ice_rxq_intr_setup(dev))
return -EIO;
-- 
2.7.5

Re: [dpdk-dev] [PATCH v5] doc/patches: add meson build to contributing guide

[Varghese, Vipin]

Sure, I will share v6 with the changes

> -Original Message-
> From: Thomas Monjalon 
> Sent: Tuesday, February 12, 2019 3:06 PM
> To: Varghese, Vipin 
> Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic,
> Marko ; Yigit, Ferruh ;
> Padubidri, Sanjay A ; Patel, Amol
> ; Richardson, Bruce 
> Subject: Re: [dpdk-dev] [PATCH v5] doc/patches: add meson build to 
> contributing
> guide
> 
> 29/01/2019 11:10, Vipin Varghese:
> > +Meson system
> > +
> 
> What do you think about adding "Makefile system" title for previous section?
> We could also add an introduction explaining that both systems must be tested.
> 
> > +
> > +Compilation of patches is to be tested with
> > +``devtools/test-meson-builds.sh`` script in ``devtools``
> 
> A dot is missing. You may remove "in ``devtools``" as it is already in the 
> path.
> 
> > +
> > +The script internally checks for dependencies, then builds for
> > +several combinations of compilation configuration.
> > +
> 
> 

[dpdk-dev] RSS handling using L2_Payload type - Flexible Payload

[Anandaraman Viswanathan]

Hi Team,
This is regarding RSS feature. In RSS configuration with Flexible Payload, 
facing a problem in getting packets distributed across multiple queues (2 per 
port). While debugging, found packets going thru q1 even if million packets are 
sent.
For simulating multiple flows, modifying Inner Payload which has one more 
Ethernet header, Src and Dest MAC of that header are getting changed 
incrementally for each packet.


To further validate if FVL support RSS L2_PAYLOAD , we used the function 
rte_eth_dev_info_get() to check RSS offloads in dev_info struct,  It outputs 
"hash_key_size:52 flow_type_rss_offloads:0x7ef8", which means RSS supports 
L2_PAYLOAD.


The details of configuration and code snippets given below

struct rte_eth_hash_filter_info filter_info;



memset(&filter_info, 0, sizeof(filter_info));



filter_info.info_type = RTE_ETH_HASH_FILTER_INPUT_SET_SELECT;

filter_info.info.input_set_conf.flow_type = RTE_ETH_FLOW_L2_PAYLOAD;

filter_info.info.input_set_conf.inset_size = 8;



filter_info.info.input_set_conf.field[0] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_1ST_WORD;

filter_info.info.input_set_conf.field[1] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_2ND_WORD;

filter_info.info.input_set_conf.field[2] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_3RD_WORD;

filter_info.info.input_set_conf.field[3] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_4TH_WORD;

filter_info.info.input_set_conf.field[4] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_5TH_WORD;

filter_info.info.input_set_conf.field[5] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_6TH_WORD;

filter_info.info.input_set_conf.field[6] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_7TH_WORD;

filter_info.info.input_set_conf.field[7] = 
RTE_ETH_INPUT_SET_FLEX_PAYLOAD_8TH_WORD;



filter_info.info.input_set_conf.op = RTE_ETH_INPUT_SET_ADD;



filter_ret = rte_eth_dev_filter_ctrl(xd->port_id, RTE_ETH_FILTER_HASH, 
RTE_ETH_FILTER_SET, &filter_info);



MACRO  "RTE_ETH_FLOW_L2_PAYLOAD " has been used to set RSS flow type, wish to 
check if this approach is good OR Any prerequisites in config to be done OR Any 
further changes needed in the code.



Hello Helin

Copying you as we see from DPDK forum 
(http://mails.dpdk.org/archives/dev/2015-November/027203.html
 ), you are the author of above feature in DPDK , hence wish to request for 
clarifying our understanding on RSS as mentioned above is correct.


Cheers
Anand

::DISCLAIMER::
--
The contents of this e-mail and any attachment(s) are confidential and intended 
for the named recipient(s) only. E-mail transmission is not guaranteed to be 
secure or error-free as information could be intercepted, corrupted, lost, 
destroyed, arrive late or incomplete, or may contain viruses in transmission. 
The e mail and its contents (with or without referred errors) shall therefore 
not attach any liability on the originator or HCL or its affiliates. Views or 
opinions, if any, presented in this email are solely those of the author and 
may not necessarily reflect the views or opinions of HCL or its affiliates. Any 
form of reproduction, dissemination, copying, disclosure, modification, 
distribution and / or publication of this message without the prior written 
consent of authorized representative of HCL is strictly prohibited. If you have 
received this email in error please delete it and notify the sender 
immediately. Before opening any email and/or attachments, please check them for 
viruses and other defects.
--

[dpdk-dev] [PATCH v6] doc/patches: add meson build to contributing guide

[Vipin Varghese]

Patches has to be validated for meson devtool script for
code and document changes. Updating documentation for meson
build steps in checking Compilation category.

Signed-off-by: Vipin Varghese 
Tested-by: Marko Kovacevic 
Acked-by: Marko Kovacevic 
---

V6:
 added 'Makefile' sub-header - Thomas Monjalon
 reword the content - Thomas Monjalon

V5:
 create sub section to Compilation - Thomas Monjalon
 remove Linux and BSD references - Thomas Monjalon
 reword tool chain to toolchain - Thomas Monjalon

V4:
 spelling correction for Compilation - Thomas Monjalon
 restored double space for new header - Thomas Monjalon
 reword the meson compilation content - Vipin Varghese
 added 'tested' and 'acked' from - Marko Kovacevic

V3:
 removed extra character - Vipin Varghese

V2:
 updated the meson build options - Bruce Richardson
---
 doc/guides/contributing/patches.rst | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/contributing/patches.rst 
b/doc/guides/contributing/patches.rst
index a64bb0368..211a5cdc7 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -431,6 +431,9 @@ Where the range is a ``git log`` option.
 Checking Compilation
 
 
+Makefile System
+~~~
+
 Compilation of patches and changes should be tested using the 
``test-build.sh`` script in the ``devtools``
 directory of the DPDK repo::
 
@@ -473,6 +476,14 @@ The recommended configurations and options to test 
compilation prior to submitti
export DPDK_DEP_PCAP=y
export DPDK_DEP_SSL=y
 
+Meson System
+
+
+Compilation of patches is to be tested with ``devtools/test-meson-builds.sh`` 
script.
+
+The script internally checks for dependencies, then builds for several
+combinations of compilation configuration.
+
 
 Sending Patches
 ---
-- 
2.17.1

[dpdk-dev] [PATCH v3 2/2] net/ixgbe: add VF promiscuous mode support when PF as host

[Wei Zhao]

There is need to PF host promiscuous mode enable. For ixgbe,
in order to support VF vlan promiscuous or unicast promiscuous,
we need to set PF host register PFVML2FLT of bit UPE and VPE.
It also align to ixgbe kernel code version 5.5.3. And also
it need to update to the latest API version in order for
negotiation between pf and vf, then new API message can be
supported.

Signed-off-by: Wei Zhao 
---
 drivers/net/ixgbe/ixgbe_ethdev.c |  1 +
 drivers/net/ixgbe/ixgbe_ethdev.h |  1 +
 drivers/net/ixgbe/ixgbe_pf.c | 79 +---
 3 files changed, 59 insertions(+), 22 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index f36064d..ed784d8 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1512,6 +1512,7 @@ ixgbevf_negotiate_api(struct ixgbe_hw *hw)
 
/* start with highest supported, proceed down */
static const enum ixgbe_pfvf_api_rev sup_ver[] = {
+   ixgbe_mbox_api_13,
ixgbe_mbox_api_12,
ixgbe_mbox_api_11,
ixgbe_mbox_api_10,
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h
index 565c69c..1e4157f 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.h
+++ b/drivers/net/ixgbe/ixgbe_ethdev.h
@@ -265,6 +265,7 @@ struct ixgbe_vf_info {
uint8_t spoofchk_enabled;
uint8_t api_version;
uint16_t switch_domain_id;
+   uint16_t xcast_mode;
 };
 
 /*
diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c
index be0c076..fafff6b 100644
--- a/drivers/net/ixgbe/ixgbe_pf.c
+++ b/drivers/net/ixgbe/ixgbe_pf.c
@@ -408,23 +408,6 @@ ixgbe_vf_reset_msg(struct rte_eth_dev *dev, uint16_t vf)
 }
 
 static int
-ixgbe_enable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf)
-{
-   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   uint32_t vmolr;
-
-   vmolr = IXGBE_READ_REG(hw, IXGBE_VMOLR(vf));
-
-   RTE_LOG(INFO, PMD, "VF %u: enabling multicast promiscuous\n", vf);
-
-   vmolr |= IXGBE_VMOLR_MPE;
-
-   IXGBE_WRITE_REG(hw, IXGBE_VMOLR(vf), vmolr);
-
-   return 0;
-}
-
-static int
 ixgbe_disable_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf)
 {
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -596,6 +579,7 @@ ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t 
vf, uint32_t *msgbuf)
case ixgbe_mbox_api_10:
case ixgbe_mbox_api_11:
case ixgbe_mbox_api_12:
+   case ixgbe_mbox_api_13:
vfinfo[vf].api_version = (uint8_t)api_version;
return 0;
default:
@@ -698,19 +682,70 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t 
vf, uint32_t *msgbuf)
 {
struct ixgbe_vf_info *vfinfo =
*(IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private));
-   bool enable = !!msgbuf[1];  /* msgbuf contains the flag to enable */
+   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   int xcast_mode = msgbuf[1]; /* msgbuf contains the flag to enable */
+   u32 vmolr, fctrl, disable, enable;
 
switch (vfinfo[vf].api_version) {
case ixgbe_mbox_api_12:
+   /* promisc introduced in 1.3 version */
+   if (xcast_mode == IXGBEVF_XCAST_MODE_PROMISC)
+   return -EOPNOTSUPP;
+   break;
+   /* Fall threw */
+   case ixgbe_mbox_api_13:
break;
default:
return -1;
}
 
-   if (enable)
-   return ixgbe_enable_vf_mc_promisc(dev, vf);
-   else
-   return ixgbe_disable_vf_mc_promisc(dev, vf);
+   if (vfinfo[vf].xcast_mode == xcast_mode)
+   goto out;
+
+   switch (xcast_mode) {
+   case IXGBEVF_XCAST_MODE_NONE:
+   disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |
+ IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
+   enable = 0;
+   break;
+   case IXGBEVF_XCAST_MODE_MULTI:
+   disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
+   enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE;
+   break;
+   case IXGBEVF_XCAST_MODE_ALLMULTI:
+   disable = IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;
+   enable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE;
+   break;
+   case IXGBEVF_XCAST_MODE_PROMISC:
+   if (hw->mac.type <= ixgbe_mac_82599EB)
+   return -1;
+
+   fctrl = IXGBE_READ_REG(hw, IXGBE_FCTRL);
+   if (!(fctrl & IXGBE_FCTRL_UPE)) {
+   /* VF promisc requires PF in promisc */
+   RTE_LOG(ERR, PMD,
+  "Enabling VF promisc requires PF in promisc\n");
+   return -1;
+   }
+
+   disable = 

[dpdk-dev] [PATCH v3 0/2] net/ixgbe: promiscuous mode enable on VF

[Wei Zhao]

There is need to enable promiscuous mode enable on VF,
pf host should also enable to support that.

v2:
--fix typo in commit log.

v3:
--delete unnecessary commit log infomation
--merge 2 patch into 1
--change patch headline name
--add promiscuous enable support infomation into doc

Zhao Wei (2):
  net/ixgbe: promiscuous mode enable on VF
  net/ixgbe: add VF promiscuous mode support when PF as host

 doc/guides/nics/features/ixgbe_vf.ini |  1 +
 drivers/net/ixgbe/ixgbe_ethdev.c  | 21 ++
 drivers/net/ixgbe/ixgbe_ethdev.h  |  1 +
 drivers/net/ixgbe/ixgbe_pf.c  | 79 +--
 4 files changed, 80 insertions(+), 22 deletions(-)

-- 
2.7.5

[dpdk-dev] [PATCH v3 1/2] net/ixgbe: promiscuous mode enable on VF

[Wei Zhao]

There is need to enable two ops of promiscuous_enable and
promiscuous_disable on VF.

Signed-off-by: Wei Zhao 
---
 doc/guides/nics/features/ixgbe_vf.ini |  1 +
 drivers/net/ixgbe/ixgbe_ethdev.c  | 20 
 2 files changed, 21 insertions(+)

diff --git a/doc/guides/nics/features/ixgbe_vf.ini 
b/doc/guides/nics/features/ixgbe_vf.ini
index 0a15500..1614190 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -11,6 +11,7 @@ Jumbo frame  = Y
 Scattered Rx = Y
 LRO  = Y
 TSO  = Y
+Promiscuous mode = Y
 Allmulticast mode= Y
 Unicast MAC filter   = Y
 RSS hash = Y
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 7493110..f36064d 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -260,6 +260,8 @@ static int ixgbevf_dev_rx_queue_intr_disable(struct 
rte_eth_dev *dev,
 static void ixgbevf_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
 uint8_t queue, uint8_t msix_vector);
 static void ixgbevf_configure_msix(struct rte_eth_dev *dev);
+static void ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev);
+static void ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev);
 static void ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev);
 static void ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev);
 
@@ -596,6 +598,8 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
.xstats_get_names = ixgbevf_dev_xstats_get_names,
.dev_close= ixgbevf_dev_close,
.dev_reset= ixgbevf_dev_reset,
+   .promiscuous_enable   = ixgbevf_dev_promiscuous_enable,
+   .promiscuous_disable  = ixgbevf_dev_promiscuous_disable,
.allmulticast_enable  = ixgbevf_dev_allmulticast_enable,
.allmulticast_disable = ixgbevf_dev_allmulticast_disable,
.dev_infos_get= ixgbevf_dev_info_get,
@@ -8301,6 +8305,22 @@ ixgbe_dev_udp_tunnel_port_del(struct rte_eth_dev *dev,
 }
 
 static void
+ixgbevf_dev_promiscuous_enable(struct rte_eth_dev *dev)
+{
+   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_PROMISC);
+}
+
+static void
+ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)
+{
+   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE);
+}
+
+static void
 ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)
 {
struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-- 
2.7.5