Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd user guide
-Original Message-
From: Rami Rosen [mailto:ramir...@gmail.com]
Sent: Thursday, December 27, 2018 9:59 PM
To: dev@dpdk.org
Cc: sta...@dpdk.org; Wisam Monther; Rami Rosen
Subject: [PATCH] doc: fix a typo in testpmd user guide
This patch fixes a typo in testpmd user guide.
Fixes: aac6f11f5864 ("app/testpmd: add ethernet peer command")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..ab40b9f5f 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1149,7 +1149,7 @@ set eth-peer
Set the forwarding peer address for certain port::
- testpmd> set eth-peer (port_id) (perr_addr)
+ testpmd> set eth-peer (port_id) (peer_addr)
This is equivalent to the ``--eth-peer`` command-line option.
--
2.19.2
Acked-by: Wisam Jaddo
BRs,
Wisam Jaddo
[dpdk-dev] [PATCH] net/mlx5: add ConnectX6 support
Signed-off-by: Wisam Jaddo
---
drivers/net/mlx5/mlx5.c | 4
drivers/net/mlx5/mlx5.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 9e5cab1..dcabeb1 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1586,6 +1586,10 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF)
},
{
+ RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+ PCI_DEVICE_ID_MELLANOX_CONNECTX6)
+ },
+ {
.vendor_id = 0
}
};
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index b2fe5cb..c7efc3c 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -52,6 +52,7 @@ enum {
PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF = 0x101a,
PCI_DEVICE_ID_MELLANOX_CONNECTX5BF = 0xa2d2,
PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF = 0xa2d3,
+ PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
};
/** Switch information returned by mlx5_nl_switch_info(). */
--
2.7.4
Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter allocation logic
Saturday, December 29, 2018 10:13 PM, Slava Ovsiienko:
> Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter allocation
> logic
>
> Moti, don't you forget to update flow_verbs_counter_release() ?
> Only shared counters should be removed from the list.
+1, thanks slava.
Moti, I have no more comments on this series.
Please fix above and send the next series w/ my Ack.
>
> WBR,
> Slava
>
> > -Original Message-
> > From: dev On Behalf Of Mordechay Haimovsky
> > Sent: Friday, December 28, 2018 0:20
> > To: dev@dpdk.org
> > Cc: Mordechay Haimovsky ; sta...@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix shared counter
> > allocation logic
> >
> > This commit fixes the logic for searching and allocating a shared
> > counter in mlx5_flow_verbs.
> > Now only the shared counters in the counters list are checked for a
> > match and not all the counters as before.
> >
> > Fixes: 84c406e74524 ("net/mlx5: add flow translate function")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Moti Haimovsky
> > ---
> > v2:
> > * Modified commit header
> > ---
> > drivers/net/mlx5/mlx5_flow_verbs.c | 14 +++---
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c
> > b/drivers/net/mlx5/mlx5_flow_verbs.c
> > index 81ec59d..409e1cd 100644
> > --- a/drivers/net/mlx5/mlx5_flow_verbs.c
> > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c
> > @@ -121,13 +121,13 @@
> > struct mlx5_flow_counter *cnt;
> > int ret;
> >
> > - LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > - if (!cnt->shared || cnt->shared != shared)
> > - continue;
> > - if (cnt->id != id)
> > - continue;
> > - cnt->ref_cnt++;
> > - return cnt;
> > + if (shared) {
> > + LIST_FOREACH(cnt, &priv->flow_counters, next) {
> > + if (cnt->shared && cnt->id == id) {
> > + cnt->ref_cnt++;
> > + return cnt;
> > + }
> > + }
> > }
> > cnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);
> > if (!cnt) {
> > --
> > 1.8.3.1
Re: [dpdk-dev] [PATCH] net/mlx5: add ConnectX6 support
Sunday, December 30, 2018 4:17 PM, Wisam Monther:
> Subject: [PATCH] net/mlx5: add ConnectX6 support
Name should be ConnectX-6.
>
> Signed-off-by: Wisam Jaddo
> ---
> drivers/net/mlx5/mlx5.c | 4
> drivers/net/mlx5/mlx5.h | 1 +
> 2 files changed, 5 insertions(+)
Need to update also the rst file. See example in
https://www.mail-archive.com/dev@dpdk.org/msg101529.html
ConnectX-6 is of course 200G.
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index
> 9e5cab1..dcabeb1 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -1586,6 +1586,10 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
> PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF)
> },
> {
> + RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
> + PCI_DEVICE_ID_MELLANOX_CONNECTX6)
> + },
> + {
I assume we want also to add the ConnectX-6 VF, right?
> .vendor_id = 0
> }
> };
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> b2fe5cb..c7efc3c 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -52,6 +52,7 @@ enum {
> PCI_DEVICE_ID_MELLANOX_CONNECTX5EXVF = 0x101a,
> PCI_DEVICE_ID_MELLANOX_CONNECTX5BF = 0xa2d2,
> PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF = 0xa2d3,
> + PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
> };
>
> /** Switch information returned by mlx5_nl_switch_info(). */
> --
> 2.7.4
